Re: [patch 2/8] update ctime and mtime for mmaped write

2007-03-06 Thread Miklos Szeredi
> > > I can understand you wanting to avoid the overhead of the minor faults > > > resulting from using page_mkclean(), but I'm not sure its worth it. > > > > It would be nice if the cost of MS_ASYNC wouldn't be too high. And I > > do have the feeling that minor faults are far more expensive

Re: [RFC][PATCH 2/7] RSS controller core

2007-03-06 Thread Andrew Morton
On Tue, 06 Mar 2007 17:55:29 +0300 Pavel Emelianov <[EMAIL PROTECTED]> wrote: > +struct rss_container { > + struct res_counter res; > + struct list_head page_list; > + struct container_subsys_state css; > +}; > + > +struct page_container { > + struct page *page; > + struct

Re: [ANNOUNCE] RSDL completely fair starvation free interactive cpu scheduler

2007-03-06 Thread Willy Tarreau
Hi Bill, On Tue, Mar 06, 2007 at 04:37:37PM -0500, Bill Davidsen wrote: (...) > The point is that no one CPU scheduler will satisfy the policy needs of > all users, any more than one i/o scheduler does so. We have realtime > scheduling, preempt both voluntary and involuntary, why should we not

Re: [RFC] div64_64 support

2007-03-06 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 10:29:41 -0800 > /* calculate the cubic root of x using Newton-Raphson */ > static uint32_t ncubic(uint64_t a) > { > uint64_t x; > > /* Initial estimate is based on: >* cbrt(x) = exp(log(x) / 3) >*/ >

Re: [PATCH 1/2] ibmebus: dynamic addiiton/removal of adapters, uevent, root device based on struct device

2007-03-06 Thread John Rose
> This adds two sysfs attributes to /sys/bus/ibmebus which can > be used to notify the ebus driver of added / removed ebus > devices in the OF device tree. We are seeing several build errors when attempting to apply this to 2.6.21-rc2: CC arch/powerpc/kernel/ibmebus.o

Re: [RFC] div64_64 support

2007-03-06 Thread Sami Farin
On Tue, Mar 06, 2007 at 10:29:41 -0800, Stephen Hemminger wrote: > Don't count the existing Newton-Raphson out. It turns out that to get enough > precision for 32 bits, only 4 iterations are needed. By unrolling those, it > gets much better timing. > > Slightly gross test program (with original

Re: [patch 2/8] update ctime and mtime for mmaped write

2007-03-06 Thread Peter Zijlstra
On Tue, 2007-03-06 at 22:24 +0100, Miklos Szeredi wrote: > > I'm not liking this, its not a constant operation as the name implies. > > OK, I'll think of something better. > > > And it style is a bit out of line with the rest of rmap. > > > > The thing it actually does is page_mkclean(), all it

Re: [PATCH] x86_64, i386: Add command line length to boot protocol

2007-03-06 Thread Alon Bar-Lev
On 3/6/07, Bernhard Walle <[EMAIL PROTECTED]> wrote: +The kernel command line is a null-terminated string. The maximum +length can be retrieved from the field cmdline_size. Before protocol +version 2.06, the maximum was 255 characters. A string that is too +long will be automatically truncated

Re: [patch 1/1] ppc: Possible bug fix for FCC driver

2007-03-06 Thread Vitaly Bordug
On Tue, 6 Mar 2007 12:03:57 +0100 Cedric Pontois wrote: > Hi Vitaly, > > The problem seems to be similar in recent kernels > (/drivers/net/fs_enet/mac-fcc.c). The transmit clock is inverted (TCI > bit set). The packets are well received, transmitted packets go out > (tx counter is ok),

Re: Xen & VMI?

2007-03-06 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > 1 sane ABI instead of 4 parallel ones? It's the same difference as the > difference between 300 system calls and 1200 system calls. Alot more > focus, alot more integration, alot less pain. Every time i change a > detail in Linux i have to update (and think about) 1

Re: userspace pagecache management tool

2007-03-06 Thread Rik van Riel
Andrew Morton wrote: On Tue, 06 Mar 2007 12:10:49 + P__draig Brady <[EMAIL PROTECTED]> wrote: Andrew Morton wrote: If I'm the target audience for that API then it's broken as I'd mess it up, or would take too long to get it right. Can't we just fix the posix_fadvise() implementation to

Re: [PATCH -mm] Blackfin: blackfin i2c driver

2007-03-06 Thread Alexey Dobriyan
On Tue, Mar 06, 2007 at 02:54:18PM +0800, Wu, Bryan wrote: > [PATCH] Blackfin: blackfin i2c driver > > The i2c linux driver for blackfin architecture which supports both GPIO > i2c operation and blackfin on-chip TWI controller i2c operation. > +config TWICLK_KHZ > + int "TWI clock (kHZ)" > +

Re: userspace pagecache management tool

2007-03-06 Thread Andrew Morton
On Tue, 06 Mar 2007 12:10:49 + P__draig Brady <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > Yes. Let's flesh it out the backup program policy some more: > > > > - Unconditionally invalidate output files > > > > - on entry to read(), probe pagecache, record which pages in the range

Re: [ANNOUNCE] RSDL completely fair starvation free interactive cpu scheduler

2007-03-06 Thread Bill Davidsen
Willy Tarreau wrote: On Tue, Mar 06, 2007 at 11:18:44AM +1100, Con Kolivas wrote: On Tuesday 06 March 2007 10:05, Bill Davidsen wrote: jos poortvliet wrote: Well, imho his current staircase scheduler already does a better job compared to mainline, but it won't make it in (or at

RE: Xen & VMI?

2007-03-06 Thread Nakajima, Jun
Ingo Molnar wrote: > * Nakajima, Jun <[EMAIL PROTECTED]> wrote: > >> I think a KVM Linux would benefit more from paravirt ops, rather than >> VMI. The higher-level interface such as the one in Xen, espeically >> for I/O, interrupt controllers, timer, SMP, etc. actually simplifies >> the

Re: + stupid-hack-to-make-mainline-build.patch added to -mm tree

2007-03-06 Thread Dan Hecht
On 03/06/2007 02:21 PM, Andi Kleen wrote: I believe this was just a quick fix in response to Ingo breaking the VMI build yesterday by disabling NO_IDLE_HZ on us. There is no technical reason why NO_IDLE_HZ=y can't coexist with NO_HZ. Well it's nasty that you force NO_IDLE_HZ on all of

Re: Xen & VMI?

2007-03-06 Thread Chris Wright
* Ingo Molnar ([EMAIL PROTECTED]) wrote: > with the big freaking difference that the 5 parallel implementations of > inode->i_op are: > > _internal to Linux_ Granted. Until it's modprobe xen.ko, vmware.ko, viridian.ko...that's not going to go away, even with the VMI. > Doh. There's only

Re: [lm-sensors] Could the k8temp driver be interfering with ACPI?

2007-03-06 Thread Jean Delvare
Hi Matthew, On Fri, 2 Mar 2007 21:46:43 +, Matthew Garrett wrote: > On Fri, Mar 02, 2007 at 10:41:55PM +0100, Jean Delvare wrote: > > > I like the patch, after adding some casts to the printf args it > > compiles fine. However you print warnings each time a resource has been > > reserved...

Re: [patch 2/8] update ctime and mtime for mmaped write

2007-03-06 Thread Miklos Szeredi
> I'm not liking this, its not a constant operation as the name implies. OK, I'll think of something better. > And it style is a bit out of line with the rest of rmap. > > The thing it actually does is page_mkclean(), all it doesn't do is > setting the pte read-only. > > I can understand you

RE: [lm-sensors] Could the k8temp driver be interfering with ACPI?

2007-03-06 Thread Moore, Robert
In other words, as per my earlier message: Port addresses can be dynamically generated by the AML code and thus, there is no way that the ACPI subsystem can statically predict any addresses that will be accessed by the AML. Bob > -Original Message- > From: [EMAIL PROTECTED]

Re: + stupid-hack-to-make-mainline-build.patch added to -mm tree

2007-03-06 Thread Andi Kleen
> I believe this was just a quick fix in response to Ingo breaking the VMI > build yesterday by disabling NO_IDLE_HZ on us. There is no technical > reason why NO_IDLE_HZ=y can't coexist with NO_HZ. Well it's nasty that you force NO_IDLE_HZ on all of paravirt ops users. I think the right

Re: [lm-sensors] Could the k8temp driver be interfering with ACPI?

2007-03-06 Thread Pavel Machek
Hi! > > > Is there anything preventing us from doing such a walk and pre-allocate > > > all the I/O ranges? I am not familiar with the ACPI code at all, would > > > you possibly propose a patch doing that? > > > > ACPI AML is probably turing-complete: I'm afraid you are trying to > > solve the

Re: Xen & VMI?

2007-03-06 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > so trying to argue as if there was no ABI imposed on Linux by hiding > > the Xen ABI behind paravirt_ops, and whistling into the air as if > > nothing happened is misguided at best. > > How is the situation even slightly different with a

Re: [RFC] ARP notify option

2007-03-06 Thread Chris Friesen
Stephen Hemminger wrote: +arp_notify - BOOLEAN + Define mode for notification of address and device changes. + 0 - (default): do nothing + 1 - Generate gratuitous arp replies when device is brought up + or hardware address changes. Did you consider using gratuitous

Re: Xen & VMI?

2007-03-06 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > so trying to argue as if there was no ABI imposed on Linux by hiding the > Xen ABI behind paravirt_ops, and whistling into the air as if nothing > happened is misguided at best. How is the situation even slightly different with a unified hypervisor ABI? J - To

Re: Xen & VMI?

2007-03-06 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > If you're seriously talking about an ABI, [...] HELLO, this isnt a hypothetical!! The moment there's a xen_paravirt_ops, Linux has DE FACTO committed itself to the Xen ABI: whatever functionality the hypercall_page call table plus the int

Re: [GIT PATCH] ACPI patches for 2.6.21 - part II (resend)

2007-03-06 Thread Pavel Machek
Hi! > > > commit 4465857d5f99079bae00621626adf74ed8256296 > > > Author: Mattia Dongili <[EMAIL PROTECTED]> > > > Date: Sat Jan 13 23:04:39 2007 +0100 > > > > > > sony_acpi: Add lanpower and audiopower controls > > > > > > audiopower works well on my SZ72B so it's not marked has

Re: + stupid-hack-to-make-mainline-build.patch added to -mm tree

2007-03-06 Thread Dan Hecht
On 03/06/2007 02:59 AM, Thomas Gleixner wrote: On Tue, 2007-03-06 at 00:55 -0800, Zachary Amsden wrote: a proper CE device also has the added bonus of making high-res timers guests work automatically. It should be simple: just pass it through to your hypervisor, a hyper-CE-device, like a

Re: kref refcounting breakage in mainline

2007-03-06 Thread Greg KH
On Tue, Mar 06, 2007 at 06:43:22AM +0100, Mike Galbraith wrote: > On Mon, 2007-03-05 at 16:25 -0800, Greg KH wrote: > > > Mike, I've reverted this patch, and I don't see any references leaking. > > And, as your patch released the reference on the driver, and the > > module_add_driver() call would

Re: Xen & VMI?

2007-03-06 Thread Ingo Molnar
* Chris Wright <[EMAIL PROTECTED]> wrote: > > i'm still arguing the same: that doing the same thing via > > overlapping, conflicting, redundant ABIs is crazy and contrary to > > the basic interests of Linux. It's like having 5 different, parallel > > variants of sys_open(), interfaced via a

Re: Xen & VMI?

2007-03-06 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > maybe we are talking past each other because i dont really disagree with > that: i mentioned it right at beginning that higher-level APIs would > have to be added to VMI. What i'd like to avoid is the ABI duplication > for the lowlevel stuff /and/ for the highlevel stuff.

Re: BUG() during suspend to disk (2.6.21-rc2, x86_64)

2007-03-06 Thread Rafael J. Wysocki
Hi, On Tuesday, 6 March 2007 11:32, Vivek Goyal wrote: > Hi, > > I see following BUG() on serial console while hibernating on a x86_64 > machine. I am using 2.6.21-rc2 kernel. I see it too. > BUG: at arch/x86_64/kernel/acpi/sleep.c:70 init_low_mapping() > > Call Trace: > []

Re: Xen & VMI?

2007-03-06 Thread Chris Wright
* Ingo Molnar ([EMAIL PROTECTED]) wrote: > > * Chris Wright <[EMAIL PROTECTED]> wrote: > > > What are you driving at? You seem to be arguing that abstractions are > > bad unless done via ABI's. [...] > > i'm still arguing the same: that doing the same thing via overlapping, > conflicting,

Re: [rtc-linux] Re: 2.6.21-rc2 : Oops in rtc_cmos...

2007-03-06 Thread Alessandro Zummo
On Tue, 6 Mar 2007 11:32:28 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > > on then... My dmesg says, related to rtc : > > > > ... > > rtc_cmos 00:03: rtc core: registered rtc_cmos as rtc0 > > I think the RTC core shouldn't emit this message; I'll send > a patch. It's just confusing on

Re: [lm-sensors] Could the k8temp driver be interfering with ACPI?

2007-03-06 Thread Stefan Monnier
>> > Is there anything preventing us from doing such a walk and pre-allocate >> > all the I/O ranges? I am not familiar with the ACPI code at all, would >> > you possibly propose a patch doing that? >> >> ACPI AML is probably turing-complete: I'm afraid you are trying to >> solve the halting

Re: [PATCH]: CXGB3 infiniband build fix

2007-03-06 Thread Roland Dreier
Applied, thanks. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [lm-sensors] Could the k8temp driver be interfering with ACPI?

2007-03-06 Thread Bodo Eggert
On Tue, 6 Mar 2007, Jean Delvare wrote: > On Mon, 05 Mar 2007 14:56:44 +0100, Bodo Eggert wrote: > > 2) make ACPI take this lock whenever it touches ports not allocated by > > itself > >and release it on function return. > > This is costly. TANSTAAFL. You'll need to take some lock, and if

Re: [PATCH] Kconfig: Update swsusp description

2007-03-06 Thread Rafael J. Wysocki
Hi, On Tuesday, 6 March 2007 10:41, Pavel Machek wrote: > Hi! > > > > > Index: linux-2.6.21-rc2/kernel/power/Kconfig > > > > === > > > > --- linux-2.6.21-rc2.orig/kernel/power/Kconfig 2007-02-28 > > > > 23:54:45.0 +0100 >

Re: should RTS init in serial core be tied to CRTSCTS

2007-03-06 Thread Krzysztof Halasa
"Mike Frysinger" <[EMAIL PROTECTED]> writes: >/* > * Setup the RTS and DTR signals once the > * port is open and ready to respond. > */ >if (info->tty->termios->c_cflag & CBAUD) >uart_set_mctrl(port, TIOCM_RTS |

Re: Xen & VMI?

2007-03-06 Thread Ingo Molnar
* Nakajima, Jun <[EMAIL PROTECTED]> wrote: > I think a KVM Linux would benefit more from paravirt ops, rather than > VMI. The higher-level interface such as the one in Xen, espeically for > I/O, interrupt controllers, timer, SMP, etc. actually simplifies the > implementation of the VMM, and

Re: Wanted: simple, safe x86 stack overflow detection

2007-03-06 Thread Bill Irwin
On Tue, 6 Mar 2007, Chuck Ebbert wrote: >> In the 4k/4k stack i386 kernel, is there any fundamental reason it >> can't be 4k/8k? We seem to be mostly hitting problems in overflowing >> the IRQ stack... I think. Overhead would only be 4k per CPU for that. On Tue, Mar 06, 2007 at 07:43:41PM +,

[KORG] Zeus1 Downtime

2007-03-06 Thread J.H.
Just a heads up to everyone, Zeus1 (one of the frontend machines) will be offline for an extended period starting late on March 6th, 2007 (PST). This is to make some array changes (moving from raid5 to raid6) and to flip the file system on the mirrors to xfs. There is no ETA on when zeus1 will

Re: [patch 2/8] update ctime and mtime for mmaped write

2007-03-06 Thread Peter Zijlstra
On Tue, 2007-03-06 at 19:04 +0100, Miklos Szeredi wrote: > plain text document attachment (mmap_mtime.patch) > Index: linux/mm/rmap.c > === > --- linux.orig/mm/rmap.c 2007-03-06 15:17:46.0 +0100 > +++ linux/mm/rmap.c

Re: Xen & VMI?

2007-03-06 Thread Ingo Molnar
* Chris Wright <[EMAIL PROTECTED]> wrote: > What are you driving at? You seem to be arguing that abstractions are > bad unless done via ABI's. [...] i'm still arguing the same: that doing the same thing via overlapping, conflicting, redundant ABIs is crazy and contrary to the basic interests

Re: Problem with freezable workqueues

2007-03-06 Thread Rafael J. Wysocki
Hi, On Tuesday, 6 March 2007 01:30, Johannes Berg wrote: > On Tue, 2007-02-27 at 22:51 +0100, Rafael J. Wysocki wrote: > > > For 2.6.21-rc1 I've invented the appended workaround (works for me, waiting > > for > > Johannes to confirm it works for him too), but I think we need something > >

[PATCH 2.6.21-rc1] Extend print_symbol capability TRY #3

2007-03-06 Thread Robert Peterson
This is try #3 for this patch, with corrections based on feedback. It is the same as try #2 except: (1) I changed the comment on function __print_symbol. Although my original patch didn't change this comment, Randy Dunlap noted that the comment was wrong, so I changed it. Hopefully it

Re: 2.6.21-rc2-mm2

2007-03-06 Thread Con Kolivas
On Wednesday 07 March 2007 01:47, Thomas Gleixner wrote: > On Wed, 2007-03-07 at 00:24 +1100, Con Kolivas wrote: > > > printk(KERN_INFO "Time: %s clocksource has been installed.\n", > > >clock->name); > > > } > > > > > > So clock seems to be NULL, but was accessed before >

Re: [patch v2] epoll use a single inode ...

2007-03-06 Thread Eric Dumazet
Eric Dumazet a écrit : On Tuesday 06 March 2007 18:28, Eric Dumazet wrote: On Tuesday 06 March 2007 18:19, Linus Torvalds wrote: Using reciprocal divides permits to change each divide by two multiplies, less expensive on current CPUS. Are you sure? I am going to test this, but at least on

Re: [PATCH] Fix buffer overflow in Omnikey CardMan 4040 driver

2007-03-06 Thread Simon Arlott
On 06/03/07 21:12, Marcel Holtmann wrote: Hi Linus, the attached patch fixes a buffer overflow in the Omnikey CardMan 4040 driver that could lead to a potential arbitrary code execution with kernel privileges. Regards Marcel - if (count < 5) { + if ((count < 5) || (count >

Re: kernel BUG at arch/x86_64/mm/../../i386/mm/hugetlbpage.c:140!

2007-03-06 Thread Bill Irwin
On Saturday 03 March 2007, Bill Irwin wrote: >> If you have a known-working kernel version, git-bisect might help you >> track down where it was introduced. Given the messages prior to the >> hugetlbpage.c BUG_ON I'd say that this is something else besides the >> specific code listed by line

Re: 2.6.21-rc suspend regression: sysfs deadlock

2007-03-06 Thread Oliver Neukum
Am Dienstag, 6. März 2007 20:20 schrieb Hugh Dickins: > This comes from Oliver's commit 94bebf4d1b8e7719f0f3944c037a21cfd99a4af7 > Driver core: fix race in sysfs between sysfs_remove_file() and read()/write() > in 2.6.21-rc1.  It looks to me like sysfs_write_file downs buffer->sem > while calling

[PATCH] Fix buffer overflow in Omnikey CardMan 4040 driver

2007-03-06 Thread Marcel Holtmann
Hi Linus, the attached patch fixes a buffer overflow in the Omnikey CardMan 4040 driver that could lead to a potential arbitrary code execution with kernel privileges. Regards Marcel [PATCH] Fix buffer overflow in Omnikey CardMan 4040 driver (CVE-2007-0005) Based on a patch from Don Howard

Re: bugs in kernel 2.6.21 (both two release candidates) and kernel

2007-03-06 Thread Al Boldi
Linus Torvalds wrote: > Finding somebody who is both technically top-notch *and* can work with > people is so rare as to be something you shouldn't even look for. That's > especially true since quite often, maintainership doesn't even come with a > lot of glory - just a lot of work, and the

Re: [RFC] div64_64 support

2007-03-06 Thread Stephen Hemminger
On Tue, 6 Mar 2007 20:48:41 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > On Tue, Mar 06, 2007 at 10:29:41AM -0800, Stephen Hemminger wrote: > > Don't count the existing Newton-Raphson out. It turns out that to get enough > > precision for 32 bits, only 4 iterations are needed. By unrolling

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-06 Thread Greg KH
On Tue, Mar 06, 2007 at 12:10:09AM -0600, Matt Mackall wrote: > On Mon, Mar 05, 2007 at 08:03:50PM -0800, Greg KH wrote: > > On Mon, Mar 05, 2007 at 09:39:47PM -0600, Matt Mackall wrote: > > > On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: > > > > If so, can you disable the option and

[patch 2.6.21-rc2-git] rduc pnp syslog spam

2007-03-06 Thread David Brownell
Make some normal code paths in PNP stop issuing syslog spam. Since PNP issues calls regardless of device capablities, it's no surprise when some of those devices don't support those calls! Signed-off-by: David Brownell <[EMAIL PROTECTED]> Index: linux-2.6/drivers/pnp/manager.c

[PATCH] Use CONFIG_ARCH_HAS_ILOG2_xxx in __get_order() not ARCH_HAS_ILOG2_xxx

2007-03-06 Thread David Howells
From: David Howells <[EMAIL PROTECTED]> Use CONFIG_ARCH_HAS_ILOG2_xxx in __get_order() not ARCH_HAS_ILOG2_xxx as the former is the right thing to use. Signed-Off-By: David Howells <[EMAIL PROTECTED]> --- include/asm-generic/page.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

Re: [ANNOUNCE] RSDL completely fair starvation free interactive cpu scheduler

2007-03-06 Thread Con Kolivas
On Wednesday 07 March 2007 04:50, Bill Davidsen wrote: > Gene Heskett wrote: > > On Monday 05 March 2007, Nicolas Mailhot wrote: > >> This looks like -mm stuff if you want it in 2.6.22 > > > > This needs to get to 2.6.21, it really is that big an improvement. > > As Con pointed out, for some

Re: Wanted: simple, safe x86 stack overflow detection

2007-03-06 Thread Bill Irwin
Bill Irwin wrote: >> Chuck, is any of this of any use to you? On Tue, Mar 06, 2007 at 01:59:39PM -0500, Chuck Ebbert wrote: > I said "simple." :) > In the 4k/4k stack i386 kernel, is there any fundamental reason it > can't be 4k/8k? We seem to be mostly hitting problems in overflowing > the IRQ

Re: [PATCH] Fix get_order() [try #2]

2007-03-06 Thread David Howells
Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > #if BITS_PER_LONG == 32 && defined(ARCH_HAS_ILOG2_U32) > > There is no such thing except on FRV, where it's redundant. Redundant in what way? > CONFIG_ARCH_HAS_ILOG2_U32 >

Re: 2.6.21-rc2 : Oops in rtc_cmos...

2007-03-06 Thread David Brownell
On Monday 05 March 2007 11:29 pm, Paul Rolland wrote: > Hello Adrian, > > > does the patch in http://lkml.org/lkml/2007/2/23/184 fix your problem? > > Yes, it does, so it's a Good One (tm), And points out that $SUBJECT is misleading; the root cause of the oops isn't rtc_cmos. Workaround, don't

[patch 2.6.21-rc2-git] reduce rtc syslog spam

2007-03-06 Thread David Brownell
Make the RTC core less noisy. On fault paths this message is confusing; and on success, a message from the driver itself should be much more informative (displaying chip type, options, etc). Signed-off-by: David Brownell <[EMAIL PROTECTED]> --- It would be nice if this cleanup went into 2.6.21,

Re: [RFC] div64_64 support

2007-03-06 Thread Andi Kleen
On Tue, Mar 06, 2007 at 10:29:41AM -0800, Stephen Hemminger wrote: > Don't count the existing Newton-Raphson out. It turns out that to get enough > precision for 32 bits, only 4 iterations are needed. By unrolling those, it > gets much better timing. But did you fix the >2^43 bug too? SGI has

Re: [ofa-general] [PATCH 2.6.21-rc2] iw_cxgb3: Don't use mm after its freed in iwch_mmap().

2007-03-06 Thread Roland Dreier
Thanks, applied. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [ofa-general] [PATCH 2.6.21-rc2] iw_cxgb3: Start ep timer on a MPA reject.

2007-03-06 Thread Roland Dreier
Thanks, applied. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Wanted: simple, safe x86 stack overflow detection

2007-03-06 Thread Hugh Dickins
On Tue, 6 Mar 2007, Chuck Ebbert wrote: > > In the 4k/4k stack i386 kernel, is there any fundamental reason it > can't be 4k/8k? We seem to be mostly hitting problems in overflowing > the IRQ stack... I think. Overhead would only be 4k per CPU for that. For all of history prior to 2.6.20,

Re: Xen & VMI?

2007-03-06 Thread Chris Wright
* Ingo Molnar ([EMAIL PROTECTED]) wrote: > yes - but de-facto contradicted by the Xen paravirt_ops patches sent to > lkml ;) There's no intrinsic value to the Xen on VMI approach that's superior to Xen on pv_ops (not to mention the complications that it causes). What are you driving at? You

Re: [PATCH] Fix get_order() [try #2]

2007-03-06 Thread Alexey Dobriyan
On Tue, Mar 06, 2007 at 06:34:26PM +, David Howells wrote: > Provide an ilog2_up() that rounds its result up (ilog2() rounds down). > > Fix get_order() to use ilog2_up() not ilog2() to get the correct rounding. > > Adjust the documentation surrounding ilog2() and co. to indicate what rounding

Re: Raid 10 Problems?

2007-03-06 Thread Jan Engelhardt
>> > -b internal -- seems like a good idea to speed up >> > resynchronization. >> >> I'm trying to figure out what the default is. >> > -e 1.0 -- I wonder why the new superblock format >> > is >> > not default in mdadm (0.90 is still used). >> > >> >> Looks interesting for big arrays but not

Re: encrypting jffs2 filesystem with DM-crypt or what else?

2007-03-06 Thread Jari Ruusu
markus reichelt wrote: > * emin ak <[EMAIL PROTECTED]> wrote: > > I need to encrypt a jffs2/mtd formatted flash filesystem for an > > embedded device, Normally using a loopback interface (cryptoloop, > > DM-crypt or loop-aes) solves this problem but they are not well > > known on journalling file

[Patch] fix parsing of statistics type-attribute

2007-03-06 Thread Martin Peschke
Without this fix the the statistics user interface accepted, for example: echo name=my_stats type=utilisa > definition while it should only accept: echo name=my_stats type=utilisation > definition Signed-off-by: Martin Peschke <[EMAIL PROTECTED]> --- statistic.c |3 ++-

[Patch 2/2] add for_each_substring() and match_substring() - exploitation

2007-03-06 Thread Martin Peschke
simplifying statistics code by using for_each_substring() and match_substring() instead of strsep() and match_token() Signed-off-by: Martin Peschke <[EMAIL PROTECTED]> --- statistic.c | 67 +--- 1 file changed, 20 insertions(+), 47

Re: [PATCH] Fix building kernel under Solaris

2007-03-06 Thread Sam Ravnborg
On Tue, Mar 06, 2007 at 10:09:40AM -0800, Deepak Saxena wrote: > > Fix varous build breakages that occur when building on a Solaris system > (SunOS 4.8 to be exact) > > - No asm/types.h > > - lpptest doesn't make sense on a Solaris host (this should really be > cross-built..) > > - Need to

[Patch 1/2] add for_each_substring() and match_substring()

2007-03-06 Thread Martin Peschke
This adds for_each_substring() and match_substring() to lib/parser.c. Using these instead of strsep() and match_token() is more comfortable, less error prone and safer. strsep() is destructive; it changes the string it is working on. match_token() needs strsep() to chop a large string up into

2.6.21-rc suspend regression: sysfs deadlock

2007-03-06 Thread Hugh Dickins
Resume from RAM on a ThinkPad T43p is now happy with Thomas' periodic tick fix - the most unusable aspect of that for me had been how slow repeat keys were to start repeating, but that's all fine now. But suspend to RAM still hanging, unless I "chmod a-x /usr/sbin/docker" on SuSE 10.2: docker

[Patch] small lib/parser.c cleanup

2007-03-06 Thread Martin Peschke
simplifying code by using available string duplication function Signed-off-by: Martin Peschke <[EMAIL PROTECTED]> --- parser.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) Index: linux/lib/parser.c === ---

Re: [uml-devel] [PATCH 4/5] UML - driver formatting fixes

2007-03-06 Thread Blaisorblade
On Tuesday 06 March 2007 19:32, Jeff Dike wrote: > Fix a bunch of formatting violations in the drivers: > return(n) -> return n > whitespace fixes > emacs formatting comment removal > breaking if(foo) return(n) into two lines > > There are also a couple of errno use bugs: >

Re: [RFC] ARP notify option

2007-03-06 Thread Chris Wright
* Stephen Hemminger ([EMAIL PROTECTED]) wrote: > This adds another inet device option to enable gratuitous ARP > when device is brought up or address change. This is handy for > clusters or virtualization. This looks good. I'll test with Xen. What about the source addr selection? thanks,

Re: return negative number for unsigned long function in kernel

2007-03-06 Thread Andreas Schwab
"Chen, Dongliang" <[EMAIL PROTECTED]> writes: > There are lots of functions in the Linux kernel that are declared as > unsigned long, but the return value is negative integer while error > occurred. An example of these functions is do_mmap_pgoff in mm/mmap.c, > which is defined as: > > unsigned

Re: [linux-usb-devel] khubd and ent:sda1 sucking CPU with reiser4 + USB HD

2007-03-06 Thread Eric Buddington
On Tue, Mar 06, 2007 at 01:34:41PM -0500, Alan Stern wrote: > The stack trace didn't include the khubd process at all. Probably that > means it had already died. No, it's still there. I ran 'echo t >/proc/sysrq-trigger' again, and khubd did not show up in dmesg: -bash-2.05b# echo t

Re: [RFC] ARP notify option

2007-03-06 Thread Jeremy Fitzhardinge
Stephen Hemminger wrote: > This adds another inet device option to enable gratuitous ARP > when device is brought up or address change. This is handy for > clusters or virtualization. > Thanks Stephen. Haven't tested this yet, but it definitely cleans up a warty corner of netfront. J -

Re: [ANNOUNCE] RSDL completely fair starvation free interactive cpu scheduler

2007-03-06 Thread jos poortvliet
Op Tuesday 06 March 2007, schreef Willy Tarreau: > In a way, I think they are right. Let me explain. Pluggable schedulers are > useful when you want to switch away from the default one. This is very > useful during development of a new scheduler, as well as when you're not > satisfied with the

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-06 Thread Greg KH
On Tue, Mar 06, 2007 at 12:10:09AM -0600, Matt Mackall wrote: > On Mon, Mar 05, 2007 at 08:03:50PM -0800, Greg KH wrote: > > On Mon, Mar 05, 2007 at 09:39:47PM -0600, Matt Mackall wrote: > > > On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: > > > > If so, can you disable the option and

Re: Wanted: simple, safe x86 stack overflow detection

2007-03-06 Thread Chuck Ebbert
Bill Irwin wrote: > On Wed, Feb 28, 2007 at 09:41:44PM +0100, Andi Kleen wrote: >> I suppose one could have a CONFIG_DEBUG_STACK_OVERFLOW that gets >> the stacks from vmalloc which would catch any overflow with its >> guard pages. This is you would need to change __pa() to handle >> that too

Re: [PATCH] Fix get_order() [try #2]

2007-03-06 Thread H. Peter Anvin
David Howells wrote: H. Peter Anvin <[EMAIL PROTECTED]> wrote: Why not just make it ((n) < 1 ? 0 : ...) and make it well-defined for n == 0? Because log2(0) is -INF or mathematically undefined or something isn't it? Yes, but it's a *rounding up* function. In this case, it makes sense to

Re: [PATCH] ocfs2: fix module_init error handling

2007-03-06 Thread Mark Fasheh
On Wed, Mar 07, 2007 at 01:38:17AM +0900, Akinobu Mita wrote: > OK. There are three problems (these are not likely to happen) > > - There is no error handling when register_filesystem() fails > (several slab caches, debugfs directory, and workqueue will not be cleaned) > > - workqueue will not

Re: [RFC] div64_64 support

2007-03-06 Thread H. Peter Anvin
Andi Kleen wrote: Let me see... You throw code like that and expect someone to actually understand it in one year, and be able to correct a bug ? To be honest I don't expect any bugs in this function. Please add something, an URL or even better a nice explanation, per favor... It's

[RFC] ARP notify option

2007-03-06 Thread Stephen Hemminger
This adds another inet device option to enable gratuitous ARP when device is brought up or address change. This is handy for clusters or virtualization. Tested on a normal device (not Xen). Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- Documentation/networking/ip-sysctl.txt |6

Re: [PATCH] Fix get_order() [try #2]

2007-03-06 Thread David Howells
H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Why not just make it ((n) < 1 ? 0 : ...) and make it well-defined for > n == 0? Because log2(0) is -INF or mathematically undefined or something isn't it? David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH] Fix get_order()

2007-03-06 Thread David Howells
Linus Torvalds <[EMAIL PROTECTED]> wrote: > That seems bogus. "n == 1" should give "0", no? Sigh. No. The comment header says it all: /** * roundup_pow_of_two - round the given value up to nearest power of two * @n - parameter * * round the given

Re: [RFC] div64_64 support II

2007-03-06 Thread H. Peter Anvin
Andi Kleen wrote: The problem with these algorithms that tradoff one or more multiplies in order to avoid a divide is that they don't give anything and often lose when both multiplies and divides are emulated in software. Actually on rereading this: is there really any Linux port that emulates

Re: [S390] Use generic bug.

2007-03-06 Thread David Miller
From: Heiko Carstens <[EMAIL PROTECTED]> Date: Tue, 6 Mar 2007 12:59:17 +0100 > On Mon, Mar 05, 2007 at 02:56:29PM -0800, David Miller wrote: > > From: Martin Schwidefsky <[EMAIL PROTECTED]> > > Date: Mon, 5 Mar 2007 23:43:54 +0100 > > > > > + if (__builtin_constant_p(__ret_warn_on)) { \ >

Re: [patch] paravirt: VDSO page is essential

2007-03-06 Thread Jeremy Fitzhardinge
Zachary Amsden wrote: > Yes, I don't have a problem with your patch, I just wish I had been > cc'd on it. Fixing this is rather tricky, but I believe no strange > build magic is required, it can be done in kernel init code. Still > building my SUSE 9.0 guest to test. SUSE 9.0 is one of those

passing function pointers through platform devices?

2007-03-06 Thread NZG
I'm developing an SPI- bus >MMC/SD block driver translation layer. As part of this layer the write protect and card detect lines need to be read. The method for determining the state of these lines will be board specific. Is it appropriate to pass a function pointer through a platform device

Re: [PATCH (update 4)] timer: Run calc_load halfway through each round_jiffies second

2007-03-06 Thread Simon Arlott
On 05/03/07 22:35, Simon Arlott wrote: On 01/01/02 03:05, Pavel Machek wrote: This changes calc_load so that it updates load half a second after any tasks scheduled using round_jiffies. Hmm, otoh this makes calc_load more expensive, power-wise, because it needs to wake the cpu once more? I

[PATCH 4/5] UML - driver formatting fixes

2007-03-06 Thread Jeff Dike
Fix a bunch of formatting violations in the drivers: return(n) -> return n whitespace fixes emacs formatting comment removal breaking if(foo) return(n) into two lines There are also a couple of errno use bugs: using errno in a printk when the failure put

Re: [PATCH] Fix get_order() [try #2]

2007-03-06 Thread David Howells
H. Peter Anvin <[EMAIL PROTECTED]> wrote: > Eh? roundup_pow_of_two(1) should be 0; 2^0 = 1. Nonono. roundup_pow_of_two(0) => ? roundup_pow_of_two(1) => 1 roundup_pow_of_two(2) => 2 roundup_pow_of_two(3) => 4 roundup_pow_of_two(4) => 4

Re: [PATCH] Fix get_order() [try #2]

2007-03-06 Thread H. Peter Anvin
David Howells wrote: /** + * ilog2_up - rounded up log of base 2 of 32-bit or a 64-bit unsigned value + * @n - parameter + * + * constant-capable log of base 2 calculation + * - this can be used to initialise global variables from constant data, hence + * the massive ternary operator

Re: [PATCH] Fix get_order()

2007-03-06 Thread Linus Torvalds
On Tue, 6 Mar 2007, David Howells wrote: > @@ -159,8 +175,8 @@ unsigned long __roundup_pow_of_two(unsigned long n) > #define roundup_pow_of_two(n)\ > (\ > __builtin_constant_p(n) ? ( \ > - (n ==

[PATCH 3/5] UML - handle block device hotplug errors

2007-03-06 Thread Jeff Dike
If a disk fails to open, i.e. its host file doesn't exist, it won't be removable because the hot-unplug code checks the existence of its gendisk. This won't exist because it is only allocated for successfully opened disks. Thus, a typo on the command line can result in a unusable and unfixable

<    1   2   3   4   5   6   7   8   9   10   >