Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Olaf Kirch
On Thursday 19 July 2007 21:56, Ingo Molnar wrote: > nope - with this patch applied the box still has no network, symptoms > are similar. (should i apply the WARN_ON() patch too?) Yes, that would be nice. If that doesn't help, you can also throw in the one below. Olaf -- Olaf Kirch | --- o

Re: [1/2] 2.6.22-git: known regressions

2007-07-19 Thread Dave Airlie
DRM Subject : wine locks up system References : http://lkml.org/lkml/2007/7/17/128 Last known good : ? Submitter : Charles Gagalac <[EMAIL PROTECTED]> Caused-By : commit d4e2cbe9cb9219fc924191a6baa2369140cb5ea8 Dave Airlie <[EMAIL PROTECTED]>

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-19 Thread Bodo Eggert
On Thu, 19 Jul 2007, Denis Vlasenko wrote: > On Tuesday 17 July 2007 00:42, Bodo Eggert wrote: > > > b) make 4K stacks the default option in vanilla kernel.org kernels as > > > a gentle nudge towards getting people to start fixing the code paths > > > that are not 4K stack safe. > > > > That's

Re: [PATCH 3/3] UIO: Hilscher CIF card driver

2007-07-19 Thread Jan Engelhardt
On Jul 19 2007 21:28, Hans-Jürgen Koch wrote: >Am Donnerstag 19 Juli 2007 18:33 schrieb Jan Engelhardt: >> On Jul 18 2007 16:26, Greg Kroah-Hartman wrote: >> > >> >http://www.tglx.de/private/hjk/cif-orig-2.6.tar.bz2 >> > >> >WARNING: Don't look at the code for too long, you might become sick :-)

Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node

2007-07-19 Thread Andi Kleen
> " > * For initialized data: > * You should insert __initdata between the variable name and equal > * sign followed by value, e.g.: > * > * static int init_variable __initdata = 0; > * static char linux_logo[] __initdata = { 0x32, 0x36, ... }; > " > > or we need to update these lines?

Re: kobject link failure

2007-07-19 Thread Jan Engelhardt
On Jul 19 2007 12:18, Greg KH wrote: >On Thu, Jul 19, 2007 at 08:03:06PM +0200, Jan Engelhardt wrote: >> >> top is 275afcac9953ece0828972edeab9684cfe1a5ef3, error is: >> LD .tmp_vmlinux1 >> drivers/built-in.o: In function `store_uevent': >> core.c:(.text+0x20ebb): undefined reference to

[PATCH] infiniband mlx4: potential leaks in __mlx4_ib_modify_qp

2007-07-19 Thread Florin Malita
Temporarily allocated struct mlx4_qp_context *context is leaked by several error paths. The patch takes advantage of the return value 'err' being preinitialized to -EINVAL. Spotted by Coverity (1768). Signed-off-by: Florin Malita <[EMAIL PROTECTED]> --- drivers/infiniband/hw/mlx4/qp.c | 12

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Ingo Molnar
* Olaf Kirch <[EMAIL PROTECTED]> wrote: > Does the following help? > --- build-2.6.orig/drivers/net/netconsole.c > +++ build-2.6/drivers/net/netconsole.c > @@ -70,7 +70,7 @@ static void write_msg(struct console *co > int frag, left; > unsigned long flags; > > - if (!np.dev) >

Re: Powerpc - Include pagemap.h in asm/powerpc/tlb.h

2007-07-19 Thread Kumar Gala
On Jul 19, 2007, at 12:30 AM, Andrew Morton wrote: On Fri, 13 Jul 2007 21:20:33 -0400 Mathieu Desnoyers <[EMAIL PROTECTED]> wrote: Powerpc - Include pagemap.h in asm/powerpc/tlb.h Fixes this powerpc build error in 2.6.22-rc6-mm1 for powerpc 64 : In file included from

Re: [PATCH for review] [12/48] x86_64: use the global PIT lock

2007-07-19 Thread Andi Kleen
> > I was not talking about sysdevs. I was talking about platform devices > that are already being created for pcspkr by arch code. Now I want > arch code to provide a spinlock for pcspkr driver to use when > accessing PIT. What it does it allows to remove arch specific > knowledge (i.e. #ifdef

Re: [PATCH] Update .gitignore for arch/i386/boot

2007-07-19 Thread Alexey Dobriyan
On Thu, Jul 19, 2007 at 01:09:10PM -0600, Matthew Wilcox wrote: > With the new setup code, we generate a couple more files > --- a/arch/i386/boot/.gitignore > +++ b/arch/i386/boot/.gitignore > @@ -1,3 +1,5 @@ > bootsect > bzImage > setup > +setup.bin > +setup.elf ACK same chunk against

[patch] slub crashes with recent -git

2007-07-19 Thread Ingo Molnar
Linus, Christoph, recent slub commits in -git cause this bootup crash: Freeing unused kernel memory: 324k freed Write protecting the kernel read-only data: 1294k [ cut here ] kernel BUG at mm/slub.c:2401! invalid opcode: [#1] PREEMPT SMP Modules linked in:

Re: [PATCH] virtual sched_clock() for s390

2007-07-19 Thread Ingo Molnar
* Jan Glauber <[EMAIL PROTECTED]> wrote: > > still, CFS needs time measurement across idle periods as well, for > > another purpose: to be able to do precise task statistics for /proc. > > (for top, ps, etc.) So it's still true that sched_clock() should > > include idle periods too. > > I'm

Re: [PATCH] Fix a use after free bug in kernel->userspace relay file support

2007-07-19 Thread Mathieu Desnoyers
* Jesper Juhl ([EMAIL PROTECTED]) wrote: > Hi, > > Coverity spotted what looks like a real possible case of using a > variable after it has been freed. > The problem is in kernel/relay.c::relay_open_buf() > > If the code hits "goto free_buf;" it ends up in this code : > > free_buf: >

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Olaf Kirch
Does the following help? Olaf -- Olaf Kirch | --- o --- Nous sommes du soleil we love when we play [EMAIL PROTECTED] |/ | \ sol.dhoop.naytheet.ah kin.ir.samse.qurax Test patch --- Index: build-2.6/drivers/net/netconsole.c

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-19 Thread Denis Vlasenko
On Tuesday 17 July 2007 00:42, Bodo Eggert wrote: > > Please note that I was not trying to remove the 8K stack option right > > now - heck, I didn't even add anything to feature-removal-schedule.txt > > - all I wanted to accomplish with the patch that started this threas > > was; a) indicate that

Re: kobject link failure

2007-07-19 Thread Greg KH
On Thu, Jul 19, 2007 at 08:03:06PM +0200, Jan Engelhardt wrote: > Hi, > > > top is 275afcac9953ece0828972edeab9684cfe1a5ef3, error is: > LD .tmp_vmlinux1 > drivers/built-in.o: In function `store_uevent': > core.c:(.text+0x20ebb): undefined reference to `kobject_actions' >

Re: kobject link failure

2007-07-19 Thread Greg KH
On Thu, Jul 19, 2007 at 08:11:26PM +0200, Gabriel C wrote: > Jan Engelhardt wrote: > > Hi, > > > > > > top is 275afcac9953ece0828972edeab9684cfe1a5ef3, error is: > > LD .tmp_vmlinux1 > > drivers/built-in.o: In function `store_uevent': > > core.c:(.text+0x20ebb): undefined reference to

[PATCH] Fix DMA on Dreamcast

2007-07-19 Thread Adrian McMenamin
I think my first attempt to post this may have got lost in space somewhere. Signed-off by: Adrian McMenamin <[EMAIL PROTECTED]> diff --git a/arch/sh/drivers/dma/dma-api.c b/arch/sh/drivers/dma/dma-api.c index cf8e119..0c9b3bc 100644 --- a/arch/sh/drivers/dma/dma-api.c +++

Re: Linux, tcpdump and vlan

2007-07-19 Thread Stephen Hemminger
On Thu, 19 Jul 2007 11:20:43 -0700 (PDT) andrei radulescu-banu <[EMAIL PROTECTED]> wrote: > > [Ben] If tcpdump and/or bridging needs to disable the hw-accel, then it can > explicitly do so by some API. That is better than overloading > the promisc flag in my opinion. > > I guess I could be

Re: [PATCH 3/3] UIO: Hilscher CIF card driver

2007-07-19 Thread Hans-Jürgen Koch
Am Donnerstag 19 Juli 2007 18:33 schrieb Jan Engelhardt: > > On Jul 18 2007 16:26, Greg Kroah-Hartman wrote: > > > >http://www.tglx.de/private/hjk/cif-orig-2.6.tar.bz2 > > > >WARNING: Don't look at the code for too long, you might become sick :-) > > Taking precautions for people? I get a 404...

Re: [PATCH] posix-timer: fix deletion race

2007-07-19 Thread Jeremy Katz
On Thu, 19 Jul 2007, Thomas Gleixner wrote: On Wed, 2007-07-18 at 16:43 -0700, Jeremy Katz wrote: On Wed, 18 Jul 2007, Jeremy Katz wrote: On Wed, 18 Jul 2007, Thomas Gleixner wrote: Also can you please enable CONFIG_PROVE_LOCKING, which might catch any locking problem, which might be

Re: [PATCH for review] [12/48] x86_64: use the global PIT lock

2007-07-19 Thread Dmitry Torokhov
On 7/19/07, Andi Kleen <[EMAIL PROTECTED]> wrote: On Thursday 19 July 2007 17:22:38 Dmitry Torokhov wrote: > Hi Andi, > > On 7/19/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > From: Thomas Gleixner <[EMAIL PROTECTED]> > > > > Replace the pcspkr private PIT lock by the global PIT lock to

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Ingo Molnar
* Olaf Kirch <[EMAIL PROTECTED]> wrote: > Here's a somewhat drastic modification that should not change any > timing, but just verifies whether my patch is to blame at all. Can you > give it a try? > @@ -1027,7 +1027,7 @@ static inline void netif_rx_complete(str >* But at least it

Re: [PATCH] Fix a use after free bug in kernel->userspace relay file support

2007-07-19 Thread David J. Wilder
ACK Thanks for catching this. Your patch looks fine. I tested for regression, no problems. I also tested the error path and had the expected results. Thanks Dave Jesper Juhl wrote: Hi, Coverity spotted what looks like a real possible case of using a variable after it has been freed. The

[PATCH] UBI: potential leak in ubi_scan_erase_peb

2007-07-19 Thread Florin Malita
Coverity (1769) found the following problem: if the erase counter overflow check triggers, ec_hdr is leaked. Moving the allocation after the overflow check should take care of it. Signed-off-by: Florin Malita <[EMAIL PROTECTED]> --- drivers/mtd/ubi/scan.c |8 1 file changed, 4

Re: kmalloc zero size changes break i386

2007-07-19 Thread Linus Torvalds
On Thu, 19 Jul 2007, Linus Torvalds wrote: > > Does something like this fix it? > > Christoph, please go over this and see if there are other cases like that. Actually, here's a better version, I think. Andi, does this patch fix your problem? Linus --- mm/slab.c |4 ++--

Re: [PATCH] virtual sched_clock() for s390

2007-07-19 Thread Jan Glauber
On Thu, 2007-07-19 at 18:00 +0200, Ingo Molnar wrote: > * Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > > > /* > > > - * Monotonic_clock - returns # of nanoseconds passed since time_init() > > > + * Scheduler clock - returns current time in nanosec units. > > > + * Now based on virtual cpu

Re: [2/2] 2.6.22-git: known regressions

2007-07-19 Thread Michal Piotrowski
On 19/07/07, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: On Thursday 19 July 2007, Michal Piotrowski wrote: > IDE > > Subject : compile error if CONFIG_BLOCK not enabled related to linux/ide.h include > References : http://lkml.org/lkml/2007/7/18/11 > Last known good : ?

[PATCH]: update coredump path in kernel to not check coredump rlim if core_pattern is a pipe

2007-07-19 Thread Neil Horman
Hey- Patch to update do_coredump such that it ignores RLIMIT_CORE in the event that core_pattern is a pipe. RLIMIT_CORE is meant to prevent dumping cores that are to large for the filesystem they are being written to for a given user id. If the core_pattern points to a pipe, the core

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Olaf Kirch
On Thursday 19 July 2007 18:07, Ingo Molnar wrote: > because i dont seem to be able to trigger Olaf's WARN_ON(), can you see > anything in the ethtool output that i sent in the previous mail(s)? If the WARN_ON doesn't trigger, I cannot see how my patch would affect your system. - IF we

SDHCI: mmc0: Unexpected interrupt 0x00008000.

2007-07-19 Thread Jeremy Fitzhardinge
I'm getting this with current GIT kernels when I plug an SD card into the side of my machine. It appears to see the filesystem OK anyway, but for some reason all the hal/gnome desktop stuff isn't seeing it. Was working last week. The message is: mmc0: Unexpected interrupt 0x8000. sdhci:

Re: [2/2] 2.6.22-git: known regressions

2007-07-19 Thread Bartlomiej Zolnierkiewicz
On Thursday 19 July 2007, Michal Piotrowski wrote: > IDE > > Subject : compile error if CONFIG_BLOCK not enabled related to > linux/ide.h include > References : http://lkml.org/lkml/2007/7/18/11 > Last known good : ? > Submitter : Kumar Gala <[EMAIL PROTECTED]> > Caused-By

Re: 2.6.22-git: known regressions with patches

2007-07-19 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 19 July 2007, Michal Piotrowski wrote: > Unclassified > > Subject : disk error loop (panic?) ide_do_rw_disk-bad > References : http://lkml.org/lkml/2007/7/17/467 > Last known good : ? > Submitter : Giacomo Catenazzi <[EMAIL PROTECTED]> > Caused-By : ? >

[PATCH] Update .gitignore for arch/i386/boot

2007-07-19 Thread Matthew Wilcox
With the new setup code, we generate a couple more files Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> diff --git a/arch/i386/boot/.gitignore b/arch/i386/boot/.gitignore index 495f20c..1846514 100644 --- a/arch/i386/boot/.gitignore +++ b/arch/i386/boot/.gitignore @@ -1,3 +1,5 @@ bootsect

Re: kmalloc zero size changes break i386

2007-07-19 Thread Pekka Enberg
Linus Torvalds wrote: Ok, I think I see it: I think the mm/slab.c conversion of kmalloc(0) is totally broken. The problem? It returns ZERO_SIZE_PTR from __find_general_cachep(), not from __kmalloc(). So anythign that uses __find_general_cachep() will get an invalid cachep pointer, which was

Re: [1/2] 2.6.22-git: known regressions

2007-07-19 Thread Satyam Sharma
On 7/20/07, Gabriel C <[EMAIL PROTECTED]> wrote: Gabriel C wrote: >> >> >>> Subject : Oops while modprobing phy fixed module >>> References : http://lkml.org/lkml/2007/7/14/63 >>> Last known good : ? >>> Submitter : Gabriel C <[EMAIL PROTECTED]> >>> Caused-By : Tejun Heo

Re: [patch] Change softlockup trigger limit using a kernel parameter

2007-07-19 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > just in case someone sees false positives and wants to turn it off. Why not make 0=off? J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] fix modpost warnings for xtensa

2007-07-19 Thread Chris Zankel
[PATCH] fix modpost warnings for xtensa The Xtensa architecture places literal pools in sections separate from the instructions. The corresponsing text sections, therefore, reference the .literal section, and we have to suppress those warnings. The naming

[GIT PATCH] hwmon patches against 2.6.22

2007-07-19 Thread Mark M. Hoffman
Hi Linus: Updates to the hwmon subsystem are ready... Please pull from: git://lm-sensors.org/kernel/mhoffman/hwmon-2.6.git release You'll get several new drivers, conversion of several existing drivers to use the platform device model, and various bugfixes and enhancements. The last

Re: [patch] Change softlockup trigger limit using a kernel parameter

2007-07-19 Thread Ingo Molnar
* Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > also, i think the valid threshold should be between 1 and 60 seconds > > i think. > > 60 seconds! Is that not a pretty high threshold? The reason for > lowering the tolerance threshold from 10s is to catch bugs early in > lab

Re: [1/2] 2.6.22-git: known regressions

2007-07-19 Thread Gabriel C
Gabriel C wrote: >> >> >>> Subject : Oops while modprobing phy fixed module >>> References : http://lkml.org/lkml/2007/7/14/63 >>> Last known good : ? >>> Submitter : Gabriel C <[EMAIL PROTECTED]> >>> Caused-By : Tejun Heo <[EMAIL PROTECTED]> >>>

Re: [2/2] 2.6.22-git: known regressions

2007-07-19 Thread Michal Piotrowski
On 19/07/07, Satyam Sharma <[EMAIL PROTECTED]> wrote: > Subject : ext4 build warnings > References : http://lkml.org/lkml/2007/7/18/420 > Last known good : ? > Submitter : Jeff Garzik <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By : Mingming Cao <[EMAIL

Re: [patch] Change softlockup trigger limit using a kernel parameter

2007-07-19 Thread Ravikiran G Thirumalai
On Thu, Jul 19, 2007 at 11:11:42AM +0200, Ingo Molnar wrote: > >* Andrew Morton <[EMAIL PROTECTED]> wrote: > >> > +softlockup_thresh: >> > + >> > +This value can be used to lower the softlockup tolerance >> > +threshold. The default threshold is 10s. If a cpu is locked up >> > +for 10s, the

Re: Linux, tcpdump and vlan

2007-07-19 Thread andrei radulescu-banu
> [Ben] If tcpdump and/or bridging needs to disable the hw-accel, then it can explicitly do so by some API. That is better than overloading the promisc flag in my opinion. I guess I could be persuaded in the end. But let me still play devil advocate. The semantics of 'promiscuous', in my

Re: [patch] sched: implement cpu_clock(cpu) high-speed time source, take #2

2007-07-19 Thread Jens Axboe
On Thu, Jul 19 2007, Jeremy Fitzhardinge wrote: > Jens Axboe wrote: > > On Thu, Jul 19 2007, Jeremy Fitzhardinge wrote: > > > >>> Index: linux/block/blktrace.c > >>> === > >>> --- linux.orig/block/blktrace.c > >>> +++

Re: [PATCH] Chinese Language Maintainer

2007-07-19 Thread Tsugikazu Shibata
On Wed, 18 Jul 2007 00:24:07 +0800, leo wrote: (snip) > Here is the helper process I propose to help more people to participate. > Suggestions and comments are welcomed. I think this seems mostly good. I will try to comment a bit. > 1) Developer who can't speak English or has a problem going

Re: kobject link failure

2007-07-19 Thread Gabriel C
Jan Engelhardt wrote: > Hi, > > > top is 275afcac9953ece0828972edeab9684cfe1a5ef3, error is: > LD .tmp_vmlinux1 > drivers/built-in.o: In function `store_uevent': > core.c:(.text+0x20ebb): undefined reference to `kobject_actions' > core.c:(.text+0x20edd): undefined reference to

Re: kmalloc zero size changes break i386

2007-07-19 Thread Linus Torvalds
On Thu, 19 Jul 2007, Roland Dreier wrote: > > I think the oops below is related -- Michael reports that avoiding > kmalloc(0) in the mlx4_ib driver makes it go away. Ok, I think I see it: I think the mm/slab.c conversion of kmalloc(0) is totally broken. The problem? It returns ZERO_SIZE_PTR

Re: [patch] sched: implement cpu_clock(cpu) high-speed time source, take #2

2007-07-19 Thread Jeremy Fitzhardinge
Jens Axboe wrote: > On Thu, Jul 19 2007, Jeremy Fitzhardinge wrote: > >>> Index: linux/block/blktrace.c >>> === >>> --- linux.orig/block/blktrace.c >>> +++ linux/block/blktrace.c >>> @@ -41,7 +41,7 @@ static void trace_note(struct

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-19 Thread Serge E. Hallyn
Quoting Arjan van de Ven ([EMAIL PROTECTED]): > > > > > :) > > > > Actually, given that when lsm was being introduced, lsm seemed to > > improve performance overall, have you taken any measurements to show > > that this is actually the case? Of course it makes sense that it would, > > but

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Daniel Walker
On Thu, 2007-07-19 at 20:00 +0200, Andi Kleen wrote: > On Thursday 19 July 2007 19:43:49 Daniel Walker wrote: > > On Thu, 2007-07-19 at 19:38 +0200, Andi Kleen wrote: > > > On Thursday 19 July 2007 19:31:56 Daniel Walker wrote: > > > > > > > >From my perspective a downside to sched_clock is that

Re: [git patches] two warning fixes

2007-07-19 Thread Linus Torvalds
On Thu, 19 Jul 2007, Krzysztof Halasa wrote: > > Jeff Garzik <[EMAIL PROTECTED]> writes: > > > My overall goal is killing useless warnings > > that continually obscure real ones. > > Precisely, the goal should be to make must_check (and similar things) > warn only in real cases. .. the

[PATCH] AFS: Use patched rxrpc_kernel_send_data() correctly

2007-07-19 Thread David Howells
Fix afs_send_simple_reply() to accept a greater-than-zero return value from rxrpc_kernel_send_data() as being a successful return rather than thinking it an error and aborting the call. rxrpc_kernel_send_data() previously returned zero incorrectly when it worked successfully, but has been patched

kobject link failure

2007-07-19 Thread Jan Engelhardt
Hi, top is 275afcac9953ece0828972edeab9684cfe1a5ef3, error is: LD .tmp_vmlinux1 drivers/built-in.o: In function `store_uevent': core.c:(.text+0x20ebb): undefined reference to `kobject_actions' core.c:(.text+0x20edd): undefined reference to `kobject_actions' make[1]: *** [.tmp_vmlinux1]

[PATCH] remove handle_mm_fault export

2007-07-19 Thread Christoph Hellwig
Now that arch/powerpc/platforms/cell/spufs/fault.c is always built in the kernel there is no need to export handle_mm_fault anymore. Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Index: linux-2.6/mm/memory.c === ---

Re: [git patches] two warning fixes

2007-07-19 Thread Linus Torvalds
On Thu, 19 Jul 2007, Krzysztof Halasa wrote: > > > > We absolutely NEVER add things like "must_check" unless not checking > > causes a real and obvious SECURITY ISSUE. > > Oh, come on, almost every kernel bug is a potential security issue. Sure. And adding unnecessary checking that

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-19 Thread Arjan van de Ven
> > :) > > Actually, given that when lsm was being introduced, lsm seemed to > improve performance overall, have you taken any measurements to show > that this is actually the case? Of course it makes sense that it would, > but witjout measurements we do not know. SuSE did a bunch of

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Andi Kleen
On Thursday 19 July 2007 19:43:49 Daniel Walker wrote: > On Thu, 2007-07-19 at 19:38 +0200, Andi Kleen wrote: > > On Thursday 19 July 2007 19:31:56 Daniel Walker wrote: > > > > > >From my perspective a downside to sched_clock is that the math is > > > duplicated per architecture .. I think it

Re: [patch 2/3] ps3: BD/DVD/CD-ROM Storage Driver

2007-07-19 Thread Rene Herman
On 07/19/2007 11:47 AM, Andrew Morton wrote: On Thu, 19 Jul 2007 11:39:32 +0200 (CEST) Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: Oh dear. ps3rom_priv(dev) = host; that's 'orrid. We have an identifier pretending to be a function, only we go and treat it as an lvalue. I mean, C

Re: [PATCH] [scsi] lpfc: potential leak in lpfc_sli_hbqbuf_fill_hbqs

2007-07-19 Thread James Bottomley
On Thu, 2007-07-19 at 13:44 -0400, James Smart wrote: > Florin, > > Thanks for the effort to create this patch. Turns out we have already > fixed this, and have it included in our 8.2.2 patch set, which we will be > posting within the next week. The 2.6.23 merge window is estimated to close on

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Olaf Kirch
On Thursday 19 July 2007 19:36, Olaf Kirch wrote: > Can you confirm this by spraying the laptop with arp packets > or broadcast pings while it's booting? Sorry for the noise - didn't see your other message where you described just that. This sounds more like a hardware issue - Rx interrupt seems

Re: Keyboard programming needs root

2007-07-19 Thread Bodo Eggert
Daniël Mantione <[EMAIL PROTECTED]> wrote: > Op Thu, 19 Jul 2007, schreef Dmitry Torokhov: >> On 7/14/07, Daniel Mantione <[EMAIL PROTECTED]> wrote: > To make this discussion productive, I want to work towards a solution. I > don't mind how I can make the keyboard work as it should, I just want

Re: [PATCH] [scsi] lpfc: potential leak in lpfc_sli_hbqbuf_fill_hbqs

2007-07-19 Thread James Smart
Florin, Thanks for the effort to create this patch. Turns out we have already fixed this, and have it included in our 8.2.2 patch set, which we will be posting within the next week. So James, don't pick this patch up, take the larger patch set instead. Thanks. -- james s Florin Malita

Re: [PATCH] hugetlbfs read() support

2007-07-19 Thread Bill Irwin
On Thu, Jul 19, 2007 at 10:07:59AM -0700, Nishanth Aravamudan wrote: > But I do think a second reason to do this is to make hugetlbfs behave > like a normal fs -- that is read(), write(), etc. work on files in the > mountpoint. But that is simply my opinion. Mine as well. -- wli - To

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Daniel Walker
On Thu, 2007-07-19 at 19:38 +0200, Andi Kleen wrote: > On Thursday 19 July 2007 19:31:56 Daniel Walker wrote: > > > >From my perspective a downside to sched_clock is that the math is > > duplicated per architecture .. I think it would be a win to use the > > generic functions if it's possible.. >

Re: [PATCH 1/5] HOWTO: add Japanese translation of Documentation/HOWTO

2007-07-19 Thread Tsugikazu Shibata
On Thu, 19 Jul 2007 01:43:14 +0200, jesper.juhl wrote: > On 19/07/07, Greg Kroah-Hartman <[EMAIL PROTECTED]> wrote: > > From: Tsugikazu Shibata <[EMAIL PROTECTED]> > > > > Add the japanese translation of the Documentation/HOWTO file. > > > > A few comments below. Jesper, Thank you very much for

Re: Linux, tcpdump and vlan

2007-07-19 Thread andrei radulescu-banu
>> [Andrei] VLAN_TX_SKB_CB() is perfect for that. > [Patrick, Stephen] No its not. Its only legal to use while something has > ownership of the skb. Between VLAN devices and real devices qdiscs are free to use it. All right, using VLAN_TX_SKB_CB() is a bad idea. In that case, we need to amend

Re: new text patching for review

2007-07-19 Thread Mathieu Desnoyers
* Andi Kleen ([EMAIL PROTECTED]) wrote: > > > Ewww you plan to run this in SMP ? So you actually go byte > > by byte changing pieces of instructions non atomically and doing > > non-Intel's errata friendly XMC. You are really looking for trouble > > there :) Two distinct errors can

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Ingo Molnar
* Olaf Kirch <[EMAIL PROTECTED]> wrote: > On Thursday 19 July 2007 18:05, Ingo Molnar wrote: > > that network-intense test also produced periodic broadcast packets that > > got the e1000 out of its weird state before the tx timeout could hit. > > Now that i've stopped the test, the network is

Re: [patch] CFS scheduler, -v19

2007-07-19 Thread Ingo Molnar
* Bill Davidsen <[EMAIL PROTECTED]> wrote: > Bill Davidsen wrote: > >Ingo Molnar wrote: > >>* Bill Davidsen <[EMAIL PROTECTED]> wrote: > >> > Does the patch below help? > > > >Doesn't seem to apply against 2.6.22.1, I'm trying 2.6.22.6 as soon as > >I recreate it. > > Applied to

Re: [linux-pm] Re: Hibernation considerations

2007-07-19 Thread david
On Thu, 19 Jul 2007, Milton Miller wrote: (2) Upon start-up (by which I mean what happens after the user has pressed the power button or something like that): * check if the image is present (and valid) _without_ enabling ACPI (we don't do that now, but I see no reason for not

Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node

2007-07-19 Thread Yinghai Lu
On 7/19/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > do we need to put __initdata just before =? AFAIK gcc __attribute__ syntax allows both. It certainly seems to compile. in include/linux/init.h it said " * For initialized data: * You should insert __initdata between the variable name and

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Andi Kleen
On Thursday 19 July 2007 19:31:56 Daniel Walker wrote: > >From my perspective a downside to sched_clock is that the math is > duplicated per architecture .. I think it would be a win to use the > generic functions if it's possible.. They can't be used because they're not cpu local. The whole

Re: [PATCH] Check for compound pages in set_page_dirty()

2007-07-19 Thread Hugh Dickins
On Thu, 19 Jul 2007, Jens Axboe wrote: > On Wed, Jul 18 2007, Hugh Dickins wrote: > > On Wed, 18 Jul 2007, Jens Axboe wrote: > > > > > > Since I had my hands dirty already... > > > > Great, thanks. (There's also such a test in fs/nfs/direct.c, > > but let's not trouble Trond until we've settled

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Olaf Kirch
On Thursday 19 July 2007 18:05, Ingo Molnar wrote: > that network-intense test also produced periodic broadcast packets that > got the e1000 out of its weird state before the tx timeout could hit. > Now that i've stopped the test, the network is quiescent again and the > e1000 hangs. Can you

Re: [PATCH 2/2] nbd: change a parameter's type to remove a memcpy call

2007-07-19 Thread Paul Clements
Denis Cheng wrote: this memcpy looks so strange, in fact it's merely a pointer dereference, so I change the parameter's type to refer it more directly, this could make the memcpy not needed anymore. in the function nbd_read_stat where nbd_find_request is only once called, the parameter served

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Daniel Walker
On Thu, 2007-07-19 at 19:22 +0200, Andi Kleen wrote: > On Thursday 19 July 2007 19:15:38 Daniel Walker wrote: > > On Thu, 2007-07-19 at 19:13 +0200, Andi Kleen wrote: > > > > What about using the cycles2ns() clocksource helpers, it would eliminate > > > > the duplication of the shift/multiply math

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-19 Thread Chris Wright
* Serge E. Hallyn ([EMAIL PROTECTED]) wrote: > Actually, given that when lsm was being introduced, lsm seemed to > improve performance overall, have you taken any measurements to show > that this is actually the case? Of course it makes sense that it would, > but witjout measurements we do not

Re: [PATCH for review] [12/48] x86_64: use the global PIT lock

2007-07-19 Thread Andi Kleen
On Thursday 19 July 2007 17:22:38 Dmitry Torokhov wrote: > Hi Andi, > > On 7/19/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > > > > From: Thomas Gleixner <[EMAIL PROTECTED]> > > > > Replace the pcspkr private PIT lock by the global PIT lock to serialize the > > PIT access all over the place. > > >

Re: [PATCH] Cleanup elevator_ops->trim function

2007-07-19 Thread Jens Axboe
On Thu, Jul 19 2007, Pavel Emelyanov wrote: > The elevator_ops's member "trim" is declared and called not like > all the other ones. Was this deliberate? It's not a elevator action like the others, it's not called during request handling, only for shutdown. So the different naming is actually ok,

Re: lguest, Re: -mm merge plans for 2.6.23

2007-07-19 Thread Christoph Hellwig
On Thu, Jul 12, 2007 at 02:52:23PM +1000, Rusty Russell wrote: > This is solely for the wakeup: you don't wake an mm 8) > > The mm reference is held as well under the big lguest_mutex (mm gets > destroyed before files get closed, so we definitely do need to hold a > reference). > > I just

[PATCH 4/4] serial: MPSC: Fix coding style and whitespace issues

2007-07-19 Thread Mark A. Greer
Fix up mpsc.c to be aligned with Documentation/CodingStyle. Also fix up some whitespace issues. Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> --- drivers/serial/mpsc.c | 684 1 file changed, 283 insertions(+), 401 deletions(-) diff --git

[PATCH 3/4] serial: MPSC: Remove duplicate SUPPORT_SYSRQ definition

2007-07-19 Thread Mark A. Greer
Remove the duplicate definition of SUPPORT_SYSRQ in mpsc driver. Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]> --- drivers/serial/mpsc.c |4 1 file changed, 4 deletions(-) diff --git a/drivers/serial/mpsc.c b/drivers/serial/mpsc.c index 0d75505..1311433 100644 ---

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-19 Thread Christian Ehrhardt
On Thu, Jul 19, 2007 at 09:54:30AM -0700, Arjan van de Ven wrote: > the next step after this patch is to have an option to get rid of all > the function pointer chasing (which is expensive) for the case where you > know you only want one security module (which you then can turn on or > off)...

[PATCH 2/4] serial: MPSC: Stop rx engine when CREAD cleared

2007-07-19 Thread Mark A. Greer
From: Stephane Chazelas <[EMAIL PROTECTED]> Currently, the MPSC driver doesn't stop recieving characters when the CREAD flag in termios->c_cflag is cleared. It should. Also, only start receiving if its not already started. Signed-off-by: Stephane Chazelas <[EMAIL PROTECTED]> Signed-off-by:

Re: [patch] CFS scheduler, -v19

2007-07-19 Thread Bill Davidsen
Bill Davidsen wrote: Ingo Molnar wrote: * Bill Davidsen <[EMAIL PROTECTED]> wrote: Does the patch below help? Doesn't seem to apply against 2.6.22.1, I'm trying 2.6.22.6 as soon as I recreate it. Applied to 2.6.22-git9, building now. - To unsubscribe from this list: send the line

[PATCH 1/4] serial: MPSC: Remove race between Rx stop & restart

2007-07-19 Thread Mark A. Greer
From: Carlos Sanchez <[EMAIL PROTECTED]> The patch in commit ID f7232056bff5fe2d3bfeab35252a66ebaeb5bbde stops (aborts) the MPSC's receive engine just before restarting it. Unfortunately, it doesn't wait for the abort to complete before restarting it which creates a race between the abort and the

Re: [PATCH 0/3][try 1] init: enable system-on-initramfs

2007-07-19 Thread Bodo Eggert
On Thu, 19 Jul 2007, Stephen Smalley wrote: > Not wanting to get into any flamewars here about selinux, but just FYI: > security_sb_post_mountroot is obsolete and can be removed without harm > to selinux; it is a leftover of selinux before we moved the initial > policy load to userspace. These

Re: [patch] sched: implement cpu_clock(cpu) high-speed time source, take #2

2007-07-19 Thread Jens Axboe
On Thu, Jul 19 2007, Jeremy Fitzhardinge wrote: > > Index: linux/block/blktrace.c > > === > > --- linux.orig/block/blktrace.c > > +++ linux/block/blktrace.c > > @@ -41,7 +41,7 @@ static void trace_note(struct blk_trace > >

Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node

2007-07-19 Thread Andi Kleen
> do we need to put __initdata just before =? AFAIK gcc __attribute__ syntax allows both. It certainly seems to compile. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [2/2] 2.6.22-git: known regressions

2007-07-19 Thread Mingming Caoc
Satyam Sharma wrote: Subject : ext4 build warnings References : http://lkml.org/lkml/2007/7/18/420 Last known good : ? Submitter : Jeff Garzik <[EMAIL PROTECTED]> Caused-By : ? Handled-By : Mingming Cao <[EMAIL PROTECTED]> Status : unknown Mingming Cao

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Andi Kleen
On Thursday 19 July 2007 19:15:38 Daniel Walker wrote: > On Thu, 2007-07-19 at 19:13 +0200, Andi Kleen wrote: > > > What about using the cycles2ns() clocksource helpers, it would eliminate > > > the duplication of the shift/multiply math . > > > > They are completely different from what

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-19 Thread Bodo Eggert
On Tue, 17 Jul 2007, Arjan van de Ven wrote: > > 1) It all can be reduced to 4K + 4K by asuming all IRQ happen on one CPU. > > no it's separate stacks for soft and hard irqs, so it's really 4+4+4 Thanks, I missed that information. Unfortunately this change still does not help if one of these

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Daniel Walker
On Thu, 2007-07-19 at 19:13 +0200, Andi Kleen wrote: > > What about using the cycles2ns() clocksource helpers, it would eliminate > > the duplication of the shift/multiply math . > > They are completely different from what clocksource provides. How so? Daniel - To unsubscribe from this list:

[PATCH] docbook bad file references

2007-07-19 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Fix docbook warnings: Warning(linux-2.6.22-git12//drivers/base/power/main.c): no structured comments found Warning(linux-2.6.22-git12//include/linux/splice.h): no structured comments found Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> ---

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-19 Thread Serge E. Hallyn
Quoting Arjan van de Ven ([EMAIL PROTECTED]): > > > Right, the ability to boot with security.capability=disabpled (or > > whatever) and then load a custom module without having to use a whole > > new kernel is something I'm sure end-users want. > > > > Especially since compiling a kernel which

[PATCH] irq.h fix kernel-doc

2007-07-19 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Add kernel-doc entry in for: Warning(linux-2.6.22-git12//include/linux/irq.h:177): No description found for parameter 'last_unhandled' Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- include/linux/irq.h |1 + 1 file changed, 1 insertion(+) ---

Re: [patch] CFS scheduler, -v19

2007-07-19 Thread Ingo Molnar
* Bill Davidsen <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: > >* Bill Davidsen <[EMAIL PROTECTED]> wrote: > > > >>>Does the patch below help? > > Doesn't seem to apply against 2.6.22.1, I'm trying 2.6.22.6 as soon as > I recreate it. the patch below is merged against 2.6.22.1-cfs-v19 -

Re: [1/2] 2.6.22-git: known regressions

2007-07-19 Thread Gabriel C
Satyam Sharma wrote: > On 7/19/07, Michal Piotrowski <[EMAIL PROTECTED]> wrote: > > >> Subject : Section mismatch: reference to .init.data:cpu_llc_id >> (between 'set_cpu_sibling_map' and 'initialize_secondary') >> References : http://lkml.org/lkml/2007/7/19/202 >> Last known good

<    1   2   3   4   5   6   7   8   9   10   >