[PATCH] ia64: fix build failure on fs/quota.c

2007-07-19 Thread Doug Chapman
Fix ia64 build failure on fs/qutoa.c. A recent patch used the type compat_u64 which on ia64 is only available if CONFIG_COMPAT is defined. From: Tony Luck <[EMAIL PROTECTED]> Signed-off-by: Doug Chapman <[EMAIL PROTECTED]> -- --- a/fs/quota.c +++ b/fs/quota.c @@ -387,7 +387,7 @@ asmlinkage

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Andi Kleen
> What about using the cycles2ns() clocksource helpers, it would eliminate > the duplication of the shift/multiply math . They are completely different from what clocksource provides. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] [7/58] x86_64: various cleanups in NUMA scan node

2007-07-19 Thread Yinghai Lu
On 7/19/07, Andi Kleen <[EMAIL PROTECTED]> wrote: From: David Rientjes <[EMAIL PROTECTED]> In acpi_scan_nodes(), we immediately return -1 if acpi_numa <= 0, meaning we haven't detected any underlying ACPI topology or we have explicitly disabled its use from the command-line with numa=noacpi.

Re: 2.6.22-git: known regressions with patches

2007-07-19 Thread S.Çağlar Onur
Hi Michal; 19 Tem 2007 Per tarihinde, Michal Piotrowski şunları yazmıştı: > Block layer > > Subject : bsg.c:(.init.text+0x43d): undefined reference to > `scsi_register_interface' References : > http://lkml.org/lkml/2007/7/16/343 > Last known good : ? > Submitter : Larry Finger

Re: [kvm-devel] [ANNOUNCE] kvm-30 release

2007-07-19 Thread Luca
On 7/19/07, Avi Kivity <[EMAIL PROTECTED]> wrote: Changes from kvm-29: [...] - revert ide enable changes that caused an I/O regression Not really. Dave is seeing the regression when IDE ports are enabled and KVM BIOS does enable them. Reverting the patch allows running another BIOS (e.g.

Re: [patch] CFS scheduler, -v19

2007-07-19 Thread Ingo Molnar
* Bill Davidsen <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: > >* Bill Davidsen <[EMAIL PROTECTED]> wrote: > > > >>>Does the patch below help? > > Doesn't seem to apply against 2.6.22.1, I'm trying 2.6.22.6 as soon as > I recreate it. hm, it's against recent -git. dont waste your time on

Re: [PATCH] hugetlbfs read() support

2007-07-19 Thread Nishanth Aravamudan
On 19.07.2007 [09:58:50 -0700], Andrew Morton wrote: > On Thu, 19 Jul 2007 08:51:49 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > + } > > > > + > > > > + offset += ret; > > > > + retval += ret; > > > > + len -= ret; > > > > +

Re: [patch] CFS scheduler, -v19

2007-07-19 Thread Bill Davidsen
Ingo Molnar wrote: * Bill Davidsen <[EMAIL PROTECTED]> wrote: Does the patch below help? Doesn't seem to apply against 2.6.22.1, I'm trying 2.6.22.6 as soon as I recreate it. Spectacularly no! With this patch the "glitch1" script with multiple scrolling windows has all xterms and

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-19 Thread Bodo Eggert
On Wed, 18 Jul 2007, Rene Herman wrote: > On 07/18/2007 01:19 AM, Bodo Eggert wrote: > > Please post a list of things you have designed, so I can avoid them. > > - The ability to read > - The ability to understand > > You're doing a hell of a job already. If you designed them like you design

Re: [2/2] 2.6.22-git: known regressions

2007-07-19 Thread Satyam Sharma
Subject : ext4 build warnings References : http://lkml.org/lkml/2007/7/18/420 Last known good : ? Submitter : Jeff Garzik <[EMAIL PROTECTED]> Caused-By : ? Handled-By : Mingming Cao <[EMAIL PROTECTED]> Status : unknown Mingming Cao fixed this:

Re: Determine version of kernel that produced vmcore

2007-07-19 Thread Don Zickus
On Thu, Jul 19, 2007 at 06:49:53PM +0200, Bernhard Walle wrote: > * Don Zickus <[EMAIL PROTECTED]> [2007-07-19 18:39]: > > > > I am not a big fan of this approach as it forces distros to require > > kexec-tools when building a kernel. Even Joe Hacker who wants a custom > > kernel (and not

Re: [PATCH for review] [7/48] i386: divorce CONFIG_X86_PAE from CONFIG_HIGHMEM64G

2007-07-19 Thread Andi Kleen
On Thursday 19 July 2007 16:46:31 Dave Jones wrote: > On Thu, Jul 19, 2007 at 03:48:36PM +0200, Andi Kleen wrote: I didn't. If you guys really want to have a thread to criticize the changelog (which seems quite bogus, after all we're interested in code here, not changelogs) then please at least

Re: [1/2] 2.6.22-git: known regressions

2007-07-19 Thread Satyam Sharma
On 7/19/07, Michal Piotrowski <[EMAIL PROTECTED]> wrote: Subject : Section mismatch: reference to .init.data:cpu_llc_id (between 'set_cpu_sibling_map' and 'initialize_secondary') References : http://lkml.org/lkml/2007/7/19/202 Last known good : ? Submitter : Gabriel C

Re: MMC/SD Root filesystem suspend/resume problems

2007-07-19 Thread Pierre Ossman
On Thu, 19 Jul 2007 16:53:39 +0100 Richard Purdie <[EMAIL PROTECTED]> wrote: > Hi Pierre, > > Lots of Linux handhelds use MMC/SD devices as the root file system. > This has worked quite reliably for many kernel versions. In 2.6.22, > it seems that if you suspend such a system then resume it, the

Re: [PATCH -mm 0/5] Freezer update

2007-07-19 Thread Andrew Morton
On Thu, 19 Jul 2007 11:30:54 -0500 "Josh Boyer" <[EMAIL PROTECTED]> wrote: > On 7/18/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > so please consider them as 2.6.23 material. > > > > The door for new 2.6.23 material shut two weeks ago. Here, at least. > > So do you have a general

Re: [patch] afs: build fix

2007-07-19 Thread David Howells
Ingo Molnar <[EMAIL PROTECTED]> wrote: > - if (posix_test_lock(file, fl) == 0) { > + posix_test_lock(file, fl); > + if (fl->fl_type == F_UNLCK) { Yep. Andrew Morton already has a patch of this form. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: kmalloc zero size changes break i386

2007-07-19 Thread Andi Kleen
On Thursday 19 July 2007 16:08:34 Pekka Enberg wrote: > Hi Andi, > > On 7/19/07, Andi Kleen <[EMAIL PROTECTED]> wrote: > > qemu testing and booting test machines with i386 kernels wasn't very > > successfull > > with recent git kernels. I got either BUGs because of failing sysfs > >

Re: [1/2] 2.6.22-git: known regressions

2007-07-19 Thread Michal Piotrowski
On 19/07/07, Avi Kivity <[EMAIL PROTECTED]> wrote: Michal Piotrowski wrote: > > Unclassified > > Subject : a52b1752c07 broke !SMP: error: implicit declaration of function `WARN_ON' > References : http://lkml.org/lkml/2007/7/17/600 > Last known good : ? > Submitter : Uwe

Re: [PATCH] [8/58] x86_64: Use string instruction memcpy/memset on AMD Fam10

2007-07-19 Thread Yinghai Lu
On 7/19/07, Jan Engelhardt <[EMAIL PROTECTED]> wrote: On Jul 19 2007 11:54, Andi Kleen wrote: >Subject: [PATCH] [8/58] x86_64: Use string instruction memcpy/memset on AMD >Fam10 What processors carry 0x10? Quad core Opteron. YH - To unsubscribe from this list: send the line

Re: [PATCH] hugetlbfs read() support

2007-07-19 Thread Andrew Morton
On Thu, 19 Jul 2007 08:51:49 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > + } > > > + > > > + offset += ret; > > > + retval += ret; > > > + len -= ret; > > > + index += offset >> HPAGE_SHIFT; > > > + offset &= ~HPAGE_MASK; > > > + > > > +

[patch] afs: build fix

2007-07-19 Thread Ingo Molnar
Subject: afs: build fix From: Ingo Molnar <[EMAIL PROTECTED]> this fresh commit: commit e8d6c554126b830217c5e9f549e0e21f865a0a8a Author: David Howells <[EMAIL PROTECTED]> Date: Sun Jul 15 23:40:12 2007 -0700 AFS: implement file locking Implement file locking for AFS. did not

Re: [PATCH] [15/58] i386: Rewrite sched_clock

2007-07-19 Thread Daniel Walker
On Thu, 2007-07-19 at 11:54 +0200, Andi Kleen wrote: > Move it into an own file for easy sharing. > Do everything per CPU. This avoids problems with TSCs that > tick at different frequencies per CPU. > Resync properly on cpufreq changes. CPU frequency is instable > around cpu frequency changing,

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-19 Thread Arjan van de Ven
> Right, the ability to boot with security.capability=disabpled (or > whatever) and then load a custom module without having to use a whole > new kernel is something I'm sure end-users want. > > Especially since compiling a kernel which works with, say, a default > fedora install, with lvm etc,

[git patch] ocfs2 ->fallocate support

2007-07-19 Thread Mark Fasheh
Here's a small patch to plug ocfs2 into the new ->fallocate callback which was just merged. --Mark Please pull from 'upstream-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git upstream-linus to receive the following updates: fs/ocfs2/file.c | 77

[git pull request] scheduler updates

2007-07-19 Thread Ingo Molnar
Linus, please pull the latest scheduler git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git 4 small changes only. It includes an cleanup: Ralf Baechle noticed that sched_cacheflush() is now unused, a new kernel-internal API for future use

Re: [2/2] 2.6.22-git: known regressions

2007-07-19 Thread Michal Piotrowski
On 19/07/07, Greg KH <[EMAIL PROTECTED]> wrote: On Thu, Jul 19, 2007 at 06:34:55PM +0200, Michal Piotrowski wrote: > SYSFS > > Subject : sysfs root link count broken in 2.6.22-git5 > References : http://lkml.org/lkml/2007/7/15/62 > Last known good : ? > Submitter : Jean

Re: Determine version of kernel that produced vmcore

2007-07-19 Thread Bernhard Walle
* Don Zickus <[EMAIL PROTECTED]> [2007-07-19 18:39]: > > I am not a big fan of this approach as it forces distros to require > kexec-tools when building a kernel. Even Joe Hacker who wants a custom > kernel (and not interested in kexec) would have to not only download the > kernel.src.rpm but

Re: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

2007-07-19 Thread rae l
On 7/19/07, rae l <[EMAIL PROTECTED]> wrote: On 7/19/07, Paul Clements <[EMAIL PROTECTED]> wrote: > Could you name "n" as "tmp" (as in the previous code) so that it's clear > that's only a temporary variable. Other than that, this looks good. Sure. I just use the name "n" as in the declaration

Re: [1/2] 2.6.22-git: known regressions

2007-07-19 Thread Avi Kivity
Michal Piotrowski wrote: Unclassified Subject : a52b1752c07 broke !SMP: error: implicit declaration of function `WARN_ON' References : http://lkml.org/lkml/2007/7/17/600 Last known good : ? Submitter : Uwe Kleine-König <[EMAIL PROTECTED]> Caused-By : Avi Kivity

Re: Linux, tcpdump and vlan

2007-07-19 Thread Ben Greear
andrei radulescu-banu wrote: [Ben] I think a better method would be to allow disabling VLAN HW accel for a NIC with ethtool. This requires changes to ethtool and e1000 driver, +other drivers. It is a handy thing to have. I don't view it as a solution to tcpdump - or to the vlan

Re: Determine version of kernel that produced vmcore

2007-07-19 Thread Don Zickus
On Wed, Jul 18, 2007 at 11:07:40PM +0900, Ken'ichi Ohmichi wrote: > The content of mkdfinfo file has been increasing whenever adding > features and correcting bugs. The content is increasing even now. > And, the feature addition is done not only for new kernels but also > for old upstream kernels.

[PATCH] Add kernel/notifier.c

2007-07-19 Thread Alexey Dobriyan
There is separate notifier header, but no separate notifier .c file. Extract notifier code out of kernel/sys.c which will remain for misc syscalls I hope. Merge kernel/die_notifier.c into kernel/notifier.c. Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> --- include/linux/notifier.h |2

Re: MMC/SD Root filesystem suspend/resume problems

2007-07-19 Thread Richard Purdie
On Thu, 2007-07-19 at 16:57 +0100, Richard Purdie wrote: > Lots of Linux handhelds use MMC/SD devices as the root file system. This > has worked quite reliably for many kernel versions. In 2.6.22, it seems > that if you suspend such a system then resume it, the device locks up. > Trying to execute

Re: [2/2] 2.6.22-git: known regressions

2007-07-19 Thread Greg KH
On Thu, Jul 19, 2007 at 06:34:55PM +0200, Michal Piotrowski wrote: > SYSFS > > Subject : sysfs root link count broken in 2.6.22-git5 > References : http://lkml.org/lkml/2007/7/15/62 > Last known good : ? > Submitter : Jean Delvare <[EMAIL PROTECTED]> > Caused-By : ? >

Re: [PATCH] [8/58] x86_64: Use string instruction memcpy/memset on AMD Fam10

2007-07-19 Thread Jan Engelhardt
On Jul 19 2007 11:54, Andi Kleen wrote: >Subject: [PATCH] [8/58] x86_64: Use string instruction memcpy/memset on AMD >Fam10 What processors carry 0x10? Jan -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]

Re: [2/2] 2.6.22-git: known regressions

2007-07-19 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-git. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk3 Andi Kleen

2.6.22-git: known regressions with patches

2007-07-19 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-git with patches available. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk3

Re: 2.4 Q: list of open files per inode?

2007-07-19 Thread Al Viro
On Thu, Jul 19, 2007 at 01:41:03PM +0200, Jan Engelhardt wrote: > > On Jul 19 2007 02:01, Jacob A wrote: > > > > How can a device driver go over the list of all the files that are open on > > a > > specific inode instance? > > pseudo-code: > > task_list_lock; > for each process; do >

[1/2] 2.6.22-git: known regressions

2007-07-19 Thread Michal Piotrowski
Hi all, Here is a list of some known regressions in 2.6.22-git. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions List of Aces NameRegressions fixed since 21-Jun-2007 Adrian Bunk3 Andi Kleen

Re: Linux, tcpdump and vlan

2007-07-19 Thread Patrick McHardy
andrei radulescu-banu wrote: > The consensus seems to be that skb's need to carry vlan accelerated tags in > their cb's, on rx as well as tx. VLAN_TX_SKB_CB() is perfect for that. No its not. Its only legal to use while something has ownership of the skb. Between VLAN devices and real devices

Re: Keyboard programming needs root

2007-07-19 Thread Daniël Mantione
Op Thu, 19 Jul 2007, schreef Dmitry Torokhov: > Hi Daniel, > > On 7/14/07, Daniel Mantione <[EMAIL PROTECTED]> wrote: > > Hello, > > > > A while back a patch was merged to make that only root can program the > > keyboard: > > > >

Re: [PATCH -mm 0/5] Freezer update

2007-07-19 Thread Josh Boyer
On 7/18/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > so please consider them as 2.6.23 material. The door for new 2.6.23 material shut two weeks ago. Here, at least. So do you have a general guideline as to when you'd like patches sent to you for the next merge window? The releases are

Re: [PATCH 3/3] UIO: Hilscher CIF card driver

2007-07-19 Thread Jan Engelhardt
On Jul 18 2007 16:26, Greg Kroah-Hartman wrote: > >http://www.tglx.de/private/hjk/cif-orig-2.6.tar.bz2 > >WARNING: Don't look at the code for too long, you might become sick :-) Taking precautions for people? I get a 404... Jan -- - To unsubscribe from this list: send the line

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-19 Thread Adrian Bunk
On Thu, Jul 19, 2007 at 08:37:27AM -0500, Serge E. Hallyn wrote: > Quoting James Morris ([EMAIL PROTECTED]): > > On Thu, 19 Jul 2007, Serge E. Hallyn wrote: > > > > > > It's already pretty clear. > > > > > > I doubt anyone not on lkml or linux-security-module has heard of this. > > > > > > So

Re: [patch] sched: implement cpu_clock(cpu) high-speed time source, take #2

2007-07-19 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > that's still an important question, but these changes are still needed > nevertheless, to unbreak softlockup.c Well, I'm happy with using jiffies as the backport fix for softlockup (if sched_clock is indeed a problem there), but mainly because it won't affect Xen. I don't

Re: [PATCH] Revert part of 3f1b0e1f287547903f11fa1e6de7d2765597766e

2007-07-19 Thread Jan Engelhardt
On Jul 18 2007 22:52, Alexey Dobriyan wrote: > >On Wed, Jul 18, 2007 at 09:03:13PM +0300, S.Çağlar Onur wrote: >> With 3f1b0e1f287547903f11fa1e6de7d2765597766e Linus's current git tree >> starts >> to ignore any *.orig or *.rej files (for example "git status" cannot show >> what are they) but

Re: does CONFIG_UNUSED_SYMBOLS have any value anymore?

2007-07-19 Thread Robert P. J. Day
On Thu, 19 Jul 2007, Arjan van de Ven wrote: > the removal entry is/was for the symbols *marked*, not for the > infrastructure ah, gotcha. so the infrastructure itself is still useful from time to time, then. ok. rday --

Re: [PATCH for review] [26/48] i386: hpet assumes boot cpu is 0

2007-07-19 Thread Jeremy Fitzhardinge
Andi Kleen wrote: > From: Chris Wright <[EMAIL PROTECTED]> > > I fixed this in x86_64. Looks like the kind of thing that will break voyager > on i386. > All those Voyagers with hpet? J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-19 Thread Lennart Sorensen
On Thu, Jul 19, 2007 at 04:38:09PM +0300, Avi Kivity wrote: > Looking at two random servers here and a desktop, interrupts are > unshared except for usb. A laptop was not so lucky. So "no chance" is > a bit extreme. > > I agree it's far from optimal, but it is less limited than you imply.

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-19 Thread Robert P. J. Day
On Thu, 19 Jul 2007, Randy Dunlap wrote: > On Thu, 19 Jul 2007 05:25:30 -0400 (EDT) Robert P. J. Day wrote: > > > On Thu, 19 Jul 2007, Stefan Richter wrote: > > > > > Robert P. J. Day wrote: > > > > On Thu, 19 Jul 2007, Adrian Bunk wrote: > > > > > > > > ... > > > >> I would consider it more ugly

Re: Linux, tcpdump and vlan

2007-07-19 Thread Stephen Hemminger
On Thu, 19 Jul 2007 08:47:01 -0700 (PDT) andrei radulescu-banu <[EMAIL PROTECTED]> wrote: > The consensus seems to be that skb's need to carry vlan accelerated tags in > their cb's, on rx as well as tx. VLAN_TX_SKB_CB() is perfect for that. > > > [Patrick] On the TX path, it could simply use

Re: [patch] sched: implement cpu_clock(cpu) high-speed time source, take #2

2007-07-19 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > Ingo Molnar wrote: > > yeah, that's the idea. > > Good. But the real question: does it help Andrew? that's still an important question, but these changes are still needed nevertheless, to unbreak softlockup.c ... I havent been watching while

Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-19 Thread Greg KH
On Thu, Jul 19, 2007 at 09:19:56AM -0400, James Morris wrote: > On Thu, 19 Jul 2007, James Morris wrote: > > > On Thu, 19 Jul 2007, Jim Kovaric wrote: > > > > > IBMs TAMOS (Tivoli Access Manager for Operating systems) contains a > > > loadable module, > > > which is an "out of tree module",

Re: [patch] sched: implement cpu_clock(cpu) high-speed time source, take #2

2007-07-19 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > yeah, that's the idea. > Good. But the real question: does it help Andrew? J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

D state

2007-07-19 Thread Manu Abraham
Hi, When a device is in D3 state, is it possible to read from the PCI config space header ? Or does a D3 state imply that the whole PC itself is in standby ? I am trying to relate whether a device that i have, a new device that i am working upon, starts up in D3 state. whether that could be the

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > i'll now check whether removing ignore_on_loglevel (no other > > changes) makes the hang go away. Maybe ignore_on_loglevel is buggy - > > or it produces an immediate printk (going out to the interface) > > during a particularly sensitive period of

Re: [patch] sched: implement cpu_clock(cpu) high-speed time source, take #2

2007-07-19 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > how about the patch below instead? (which, unlike the first one, > > happens to build and boot ;-) > > Yes, that should be fine if its just based on sched_clock. Presumably > that means that any architecture (eg, s390) which chooses to

Re: [PATCH][RFC] Delete export of tty.h to userspace.

2007-07-19 Thread Robert P. J. Day
On Thu, 19 Jul 2007, Jiri Slaby wrote: > Christoph Hellwig napsal(a): > > On Thu, Jul 19, 2007 at 07:17:07AM -0400, Robert P. J. Day wrote: > >> so you're saying you'll drop that include from util-linux, is > >> that it? but it's still a good plan to generate a warning > >> whenever userspace

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Ingo Molnar
* Kok, Auke <[EMAIL PROTECTED]> wrote: > > I don't have a fix ready yet - I hope I'll have something later this > > afternoon. > > interesting, you seem to found the cause allright. I can't confirm the > problem but I know that netpoll and NAPI has historically been an > issue. I look

Re: [patch] sched: implement cpu_clock(cpu) high-speed time source, take #2

2007-07-19 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > >>> Hm, that doesn't look quite right. Doesn't rq_clock measure time >>> spent running? Unstolen time includes idle time too (it just >>> excludes time in which a VCPU is runnable but not actually running). >>> >>

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > i'll now check whether removing ignore_on_loglevel (no other changes) > makes the hang go away. Maybe ignore_on_loglevel is buggy - or it > produces an immediate printk (going out to the interface) during a > particularly sensitive period of network

Re: [PATCH] virtual sched_clock() for s390

2007-07-19 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > /* > > - * Monotonic_clock - returns # of nanoseconds passed since time_init() > > + * Scheduler clock - returns current time in nanosec units. > > + * Now based on virtual cpu time to only account time the guest > > + * was actually running.

Re: Linux, tcpdump and vlan

2007-07-19 Thread andrei radulescu-banu
One additional thought: with the proposed changes in my prev message, the driver can be set to hw vlan accelerated mode, even if no vlan interfaces are configured. We would not have to switch hw vlan accelerated mode anymore, when vlan interfaces are created or destroyed.

Re: sysfs root link count broken in 2.6.22-git5

2007-07-19 Thread Jan Engelhardt
On Jul 19 2007 10:41, Jean Delvare wrote: >> Well, just check if /sys/devices/ exists, that should be cheap enough. :) > >Yes, this is a possibility, and one I had considered at first. But I >wasn't sure which subdirectory to check. sysfs isn't well known for its >stability, and I didn't know

MMC/SD Root filesystem suspend/resume problems

2007-07-19 Thread Richard Purdie
Hi Pierre, Lots of Linux handhelds use MMC/SD devices as the root file system. This has worked quite reliably for many kernel versions. In 2.6.22, it seems that if you suspend such a system then resume it, the device locks up. Trying to execute anything on the filesystem results in a "Permission

Re: kmalloc zero size changes break i386

2007-07-19 Thread Linus Torvalds
On Thu, 19 Jul 2007, Andi Kleen wrote: > > qemu testing and booting test machines with i386 kernels wasn't very > successfull > with recent git kernels. I got either BUGs because of failing sysfs > initialization > or oopses in kmalloc, but no user land. Can you send in the oopses and BUGs?

Re: [PATCH 03/33] powerpc: Refuse to build 64-bit with GCC-4.2.0 and CONFIG_MODULES

2007-07-19 Thread Segher Boessenkool
From: Segher Boessenkool <[EMAIL PROTECTED]> ...since this won't work (compiler bug, see ). The bug report says IA64 is broken, too. Please verify and extend the patch if possible... The GCC bug exists on all architectures. Linux build is only affected on

Re: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

2007-07-19 Thread rae l
On 7/19/07, Paul Clements <[EMAIL PROTECTED]> wrote: Could you name "n" as "tmp" (as in the previous code) so that it's clear that's only a temporary variable. Other than that, this looks good. Sure. I just use the name "n" as in the declaration of list_for_each_entry_safe in the header file

About get_page for compound page

2007-07-19 Thread Fengwei Yin
Hi, In get_page(), the parameter page is changed by page = compound_head(page); if the page is not the first page of compound pages. My question: is this behavior correct? Regards Yin, Fengwei - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > ah! Just found the reason: the bug apparently depends on the precise > kernel command-line contents. I accidentally dropped ignore_loglevel > (found this while comparing with the older logs i sent to you), adding > it back in produces hung networking

Re: Someone ( bsg merge ? ) broke {sd,hd}parm on current git

2007-07-19 Thread Gabriel C
James Bottomley wrote: > On Thu, 2007-07-19 at 16:31 +0200, Gabriel C wrote: > >> No is not an SATA controller. >> >> sda and sdb are SCSI disks connected to an Adaptec AIC-7892P U160/m >> controller using the aic7xxx driver. >> > > OK, this definitely works for me, that's what my root

[PATCH] [scsi] lpfc: potential leak in lpfc_sli_hbqbuf_fill_hbqs

2007-07-19 Thread Florin Malita
If lpfc_hbq_alloc() fails, an hbq_buffer is leaked. Found by Coverity (1775). Signed-off-by: Florin Malita <[EMAIL PROTECTED]> --- drivers/scsi/lpfc/lpfc_sli.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c

Re: [PATCH] hugetlbfs read() support

2007-07-19 Thread Badari Pulavarty
On Wed, 2007-07-18 at 22:19 -0700, Andrew Morton wrote: > On Fri, 13 Jul 2007 18:23:33 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > Hi Andrew, > > > > Here is the patch to support read() for hugetlbfs, needed to get > > oprofile working on executables backed by largepages. > > > >

Re: [PATCH] Fix memory leak in dlm_add_member() when dlm_node_weight() returns less than zero

2007-07-19 Thread Steven Whitehouse
Hi, Now in the GFS2 git tree. Thanks, Steve. On Thu, 2007-07-19 at 00:27 +0200, Jesper Juhl wrote: > Greetings, > > There's a memory leak in fs/dlm/member.c::dlm_add_member(). > > If "dlm_node_weight(ls->ls_name, nodeid)" returns < 0, then > we'll return without freeing the memory allocated

Re: does CONFIG_UNUSED_SYMBOLS have any value anymore?

2007-07-19 Thread Arjan van de Ven
Robert P. J. Day wrote: On Thu, 19 Jul 2007, Arjan van de Ven wrote: Stefan Richter wrote: Robert P. J. Day wrote: ... it's not clear if that means that it was a *one-time* transition aid which is now unnecessary, or whether it's an *ongoing* aid which might be used at any time. currently,

Re: Linux, tcpdump and vlan

2007-07-19 Thread andrei radulescu-banu
The consensus seems to be that skb's need to carry vlan accelerated tags in their cb's, on rx as well as tx. VLAN_TX_SKB_CB() is perfect for that. > [Patrick] On the TX path, it could simply use the CB, but this is actually also wrong (for both macvlan and real devices) since qdiscs have

[patch] sched: implement cpu_clock(cpu) high-speed time source, take #2

2007-07-19 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > Hm, that doesn't look quite right. Doesn't rq_clock measure time > > spent running? Unstolen time includes idle time too (it just > > excludes time in which a VCPU is runnable but not actually running). > > generally rq_clock() also includes idle

Re: Linux, tcpdump and vlan

2007-07-19 Thread Krzysztof Halasa
Stephen Hemminger <[EMAIL PROTECTED]> writes: > Not at runtime, acceleration is always on if you compile kernel with vlan > support. That is a design mistake as far as I can tell. I think so. >> However seeing unknown tags on master device (with tcpdump etc) >> would certainly be useful. > >

[patch] sched: implement cpu_clock(cpu) high-speed time source

2007-07-19 Thread Ingo Molnar
* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote: > > yeah. But then it should not be using sched_clock() but CFS's new > > rq_clock() method - which does try to construct a globally valid > > timesource out of sched_clock(). [that fix is not backportable > > though] > > Hm, that doesn't look

Re: does CONFIG_UNUSED_SYMBOLS have any value anymore?

2007-07-19 Thread Robert P. J. Day
On Thu, 19 Jul 2007, Stefan Richter wrote: > Robert P. J. Day wrote: > ... > > it's not clear if that means that it was a *one-time* transition > > aid which is now unnecessary, or whether it's an *ongoing* aid which > > might be used at any time. currently, there are no invocations of > >

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Kok, Auke
Olaf Kirch wrote: On Thursday 19 July 2007 12:58, Ingo Molnar wrote: i.e. it's the classic 'eth0 got stuck somehow' tx/rx state machine hickup symptoms, with no other bad symptoms such as lockups or crashes. Duh, I found it. The e1000 poll routine does this to leave polling mode.

Re: [PATCH] virtual sched_clock() for s390

2007-07-19 Thread Srivatsa Vaddagiri
On Thu, Jul 19, 2007 at 08:29:06AM -0700, Jeremy Fitzhardinge wrote: > > - * Monotonic_clock - returns # of nanoseconds passed since time_init() > > + * Scheduler clock - returns current time in nanosec units. > > + * Now based on virtual cpu time to only account time the guest > > + * was

Re: does CONFIG_UNUSED_SYMBOLS have any value anymore?

2007-07-19 Thread Robert P. J. Day
On Thu, 19 Jul 2007, Arjan van de Ven wrote: > Stefan Richter wrote: > > Robert P. J. Day wrote: > > ... > > > it's not clear if that means that it was a *one-time* transition > > > aid which is now unnecessary, or whether it's an *ongoing* aid which > > > might be used at any time. currently,

[PATCH] powerpc: Allow smp_call_function_single() to current cpu

2007-07-19 Thread Avi Kivity
This removes the requirement for callers to get_cpu() to check in simple cases. i386 and x86_64 already received a similar treatment. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- arch/powerpc/kernel/smp.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git

Re: [NFS] [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags

2007-07-19 Thread J. Bruce Fields
On Thu, Jul 19, 2007 at 10:16:14AM +1000, Neil Brown wrote: > On Wednesday July 18, [EMAIL PROTECTED] wrote: > > On Fri, Jul 13, 2007 at 12:29:33AM -0700, Andrew Morton wrote: > > > On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown <[EMAIL PROTECTED]> wrote: > > > > > > > +static void exp_flags(struct

[PATCH] ia64: Allow smp_call_function_single() to current cpu

2007-07-19 Thread Avi Kivity
This removes the requirement for callers to get_cpu() to check in simple cases. i386 and x86_64 already received a similar treatment. Signed-off-by: Avi Kivity <[EMAIL PROTECTED]> --- arch/ia64/kernel/smp.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git

Re: [PATCH][RFC] Delete export of tty.h to userspace.

2007-07-19 Thread Jiri Slaby
Christoph Hellwig napsal(a): > On Thu, Jul 19, 2007 at 07:17:07AM -0400, Robert P. J. Day wrote: >> so you're saying you'll drop that include from util-linux, is that it? >> but it's still a good plan to generate a warning whenever userspace >> includes that file, so i'll submit a quick patch to

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > ugh. Something really weird happened with this e1000 problem. > > i crashed the laptop in a weird way and had to power-cycle it in an > unusual fashion. After that i wanted to try your latest BUG_ON() > theory but the network hang went away! > > For

Re: [PATCH][RFC] Delete export of tty.h to userspace.

2007-07-19 Thread Robert P. J. Day
On Thu, 19 Jul 2007, Christoph Hellwig wrote: > On Thu, Jul 19, 2007 at 07:17:07AM -0400, Robert P. J. Day wrote: > > so you're saying you'll drop that include from util-linux, is that > > it? but it's still a good plan to generate a warning whenever > > userspace includes that file, so i'll

Re: [PATCH] virtual sched_clock() for s390

2007-07-19 Thread Jeremy Fitzhardinge
Jan Glauber wrote: > This patch introduces a cpu time clock for s390 (only ticking > if the virtual cpu is running) and bases the s390 implementation > of sched_clock() on it. > > The times lice length on a virtual cpu can be anything > between the calculated time slice and zero. In reality > this

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-19 Thread Olaf Kirch
On Thursday 19 July 2007 17:07, Ingo Molnar wrote: > i crashed the laptop in a weird way and had to power-cycle it in an > unusual fashion. After that i wanted to try your latest BUG_ON() theory > but the network hang went away! Should I rejoice, or regret? :-) > maybe it's not the

Re: [PATCH] net/, drivers/net/ , missing EXPERIMENTAL in menus

2007-07-19 Thread Randy Dunlap
On Thu, 19 Jul 2007 05:25:30 -0400 (EDT) Robert P. J. Day wrote: > On Thu, 19 Jul 2007, Stefan Richter wrote: > > > Robert P. J. Day wrote: > > > On Thu, 19 Jul 2007, Adrian Bunk wrote: > > > > > > ... > > >> I would consider it more ugly to special case this and that in the > > >> kconfig code

Re: New 'Section mismatch:' warning in current git

2007-07-19 Thread Jeremy Fitzhardinge
Gabriel C wrote: > Hello, > > on current git head I see this new warning caused by commit > c70df74376c1e29a04e07e23dd3f4c384d6166dd > > ... > > MODPOST vmlinux > WARNING: arch/i386/kernel/built-in.o(.text+0xc290): Section mismatch: > reference to .init.data:cpu_llc_id (between

Re: [patch] fix the softlockup watchdog to actually work

2007-07-19 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: >> Well, my observation is that both softlockup and the scheduler really >> want to measure unstolen time, so it seemed to me that sched_clock was >> a nice common place to implement that, rather than implementing a >> whole new time interface. At the time that seemed OK,

Re: [PATCH for review] [12/48] x86_64: use the global PIT lock

2007-07-19 Thread Dmitry Torokhov
Hi Andi, On 7/19/07, Andi Kleen <[EMAIL PROTECTED]> wrote: From: Thomas Gleixner <[EMAIL PROTECTED]> Replace the pcspkr private PIT lock by the global PIT lock to serialize the PIT access all over the place. Like I said before I'd be more happy if spinlock was attached to a platform device

Re: Linux, tcpdump and vlan

2007-07-19 Thread Stephen Hemminger
On Thu, 19 Jul 2007 16:23:48 +0200 Krzysztof Halasa <[EMAIL PROTECTED]> wrote: > Stephen Hemminger <[EMAIL PROTECTED]> writes: > > > 1) non-accelerated device > > * all frames show in promiscious mode > > * tag is part of the frame that shows up > >in tcpdump, and then gets

Re: Someone ( bsg merge ? ) broke {sd,hd}parm on current git

2007-07-19 Thread James Bottomley
On Thu, 2007-07-19 at 16:31 +0200, Gabriel C wrote: > No is not an SATA controller. > > sda and sdb are SCSI disks connected to an Adaptec AIC-7892P U160/m > controller using the aic7xxx driver. OK, this definitely works for me, that's what my root disk is on. I think this isn't a kernel

Re: [BUGFIX]{PATCH] flush icache on ia64 take2

2007-07-19 Thread Zoltan Menyhart
KAMEZAWA Hiroyuki wrote: Hmm...but the current code flushes the page. just do it in "lazy" way. much difference ? I agree the current code flushes the I-cache for all kinds of file systems (for PTEs with the exec bit on). The error is that it does it after the PTE is written. In addition, I

Re: kmalloc zero size changes break i386

2007-07-19 Thread Roland Dreier
I think the oops below is related -- Michael reports that avoiding kmalloc(0) in the mlx4_ib driver makes it go away. From: "Michael S. Tsirkin" <[EMAIL PROTECTED]> Subject: oops on mlx4 modprobe To: [EMAIL PROTECTED], Roland Dreier <[EMAIL PROTECTED]> Date: Thu, 19 Jul 2007 11:47:51 +0300

Re: Keyboard programming needs root

2007-07-19 Thread Dmitry Torokhov
Hi Daniel, On 7/14/07, Daniel Mantione <[EMAIL PROTECTED]> wrote: Hello, A while back a patch was merged to make that only root can program the keyboard: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0b360adbdb54d5b98b78d57ba0916bc4b8871968 Is this patch

<    1   2   3   4   5   6   7   8   9   10   >