Re: [-mm Patch] net/bluetooth/hidp/core.c: Make hidp_setup_input() return int

2007-09-25 Thread David Miller
From: Marcel Holtmann <[EMAIL PROTECTED]> Date: Tue, 25 Sep 2007 00:18:07 +0200 > Hi Wang, > > > This patch: > > - makes hidp_setup_input() return int to indicate errors; > > - checks its return value to handle errors. > > > > And this time it is against -rc7-mm1 tree. > > > > Thanks to roel

Re: Chroot bug

2007-09-25 Thread Willy Tarreau
On Wed, Sep 26, 2007 at 01:21:08AM -0400, Kyle Moffett wrote: (...) > Now, like magic, the entire system is once more accessible. > > Alternatively you could: > mount -t proc proc /proc > cat /proc/1/mounts > mount -t $ROOTFS_FROM_PROC $ROOTDEV_FROM_PROC / Since 2.6.20, it was even simpler

Re: Chroot bug

2007-09-25 Thread Kyle Moffett
On Sep 25, 2007, at 20:55:51, Adrian Bunk wrote: On Wed, Sep 26, 2007 at 09:20:54AM +0930, David Newall wrote: Good call. Though I suppose, since it's used 24x7 to aid security on countless production servers, that security dwarfs testing. Still, debugging, yes that's valid. Incompetent

[PATCH] lguest example launcher truncates block device file to 0 length on problems

2007-09-25 Thread Rusty Russell
From: Chris Malley <[EMAIL PROTECTED]> The function should also use ftruncate64() rather than ftruncate() to prevent files over 4GB (not uncommon for a root filesystem) being zeroed. Signed-off-by: Chris Malley <[EMAIL PROTECTED]> Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r

Re: 2.6.23-rc8-mm1: somewhat broken forced HPET on ICH5

2007-09-25 Thread Alexey Dobriyan
On Tue, Sep 25, 2007 at 11:45:17PM +0200, Thomas Gleixner wrote: > On Wed, 2007-09-26 at 00:50 +0400, Alexey Dobriyan wrote: > > ich-force-hpet-ich5-quirk-to-force-detect-enable.patch > > is causing the following on Etch boot: > > > > [initscripts as usual] > > Setting system clock: > >

Re: [PATCH 1/4] dma: add dma_flags_set_dmaflush() to dma interface

2007-09-25 Thread Randy Dunlap
On Tue, 25 Sep 2007 17:00:57 -0700 [EMAIL PROTECTED] wrote: [adding James Bottomley to cc: since I think he's interested in all of these patches] > Introduce the dma_flags_set_dmaflush() interface and give it > a default no-op implementation. > > Signed-off-by: Arthur Kepner <[EMAIL

Re: NMI error and Intel S5000PSL Motherboards

2007-09-25 Thread Randy Dunlap
On Wed, 26 Sep 2007 02:12:34 -0800 AndrewL733 wrote: > We have about 100 servers based on Intel S5000PSL-SATA motherboards. > They have been running for anywhere between 1 and 10 months. For the > past few months, after updating them all to the 2.6.20.15 kernel > (because of a bug in the

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread FUJITA Tomonori
On Tue, 25 Sep 2007 22:45:53 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2007-09-25 at 23:34 -0400, Jeff Garzik wrote: > > Matthew Wilcox wrote: > > > On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote: > > >> Are there any const-ness worries for scsi_host_template, or

[git patches] libata fixes

2007-09-25 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/pata_sis.c |3 ++- drivers/ata/sata_sil24.c | 16 2 files changed, 14 insertions(+), 5

Re: 2.6.23-rc7-mm1 AHCI ATA errors -- won't boot

2007-09-25 Thread Jeff Garzik
Would it also be possible for you to send along 'hdparm --Istdout' output for your config disk thingy, /dev/sdd ? Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: KPROBES: Instrumenting a function's call site

2007-09-25 Thread Ananth N Mavinakayanahalli
On Tue, Sep 25, 2007 at 06:12:38PM -0400, Avishay Traeger wrote: > Hello, > I am trying to use kprobes to measure the latency of a function by > instrumenting its call site. Basically, I find the call instruction, > and insert a kprobe with a pre-handler and post-handler at that point. > The

[PATCH 4/8] gdth: Isolate driver-global variables using helpers

2007-09-25 Thread Jeff Garzik
Sanitizes access to some driver-global variables, in preparation for making them dynamic rather than statically-sized. This equivalent-transform style change blissfully ignores the fact that gdth_ctr_vtab[] is never used (only assigned), and that the driver itself seems to get a bit confused

[PATCH 8/8] gdth: convert to modern SCSI host alloc/scan

2007-09-25 Thread Jeff Garzik
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index f382664..3f3ef4b 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -3960,7 +3960,7 @@ static int __init gdth_register_virt(struct scsi_host_template *shtp, {

[PATCH 7/8] gdth: make some virt ctrlr code common; shuffle SHT members

2007-09-25 Thread Jeff Garzik
* New function gdth_register_virt() replaces the three basically-duplicate copies of virtual controller registration. * shuffle scsi_host_template members such that they appear in the order in which they are defined in the header. this makes is easier to verify when initializers are

[PATCH 6/8] gdth: Move probe-time error handling code to end of each function

2007-09-25 Thread Jeff Garzik
Use standard laddered-goto error handling approach in three probe-time functions. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index d7ef159..89ac155 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -3964,13 +3964,11 @@

[PATCH 5/8] gdth: kill gdth_{read,write}[bwl] wrappers

2007-09-25 Thread Jeff Garzik
They are direct equivalents to {read,write}[bwl]. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index b9d1f69..d7ef159 100644 --- a/drivers/scsi/gdth.c +++ b/drivers/scsi/gdth.c @@ -294,13 +294,6 @@ static struct timer_list gdth_timer;

[PATCH 3/8] gdth: Remove 2.4.x support, in-kernel changelog

2007-09-25 Thread Jeff Garzik
* Remove in-source changelog. It's archived permanently in git and various kernel archives, and changelogs should exist purely in git. * Remove 2.4.x kernel support. It is an active obstacle to modernizing this driver, at this point. This includes killing gdth_kcompat.h which is 100%

[PATCH 2/8] gdth: Split out PCI register into separate function

2007-09-25 Thread Jeff Garzik
An equivalent-transformation change. No functional changes beyond those necessary to call the new function. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index f330d34..840bdf6 100644 --- a/drivers/scsi/gdth.c +++

[PATCH 1/8] gdth: Split out EISA and ISA register into separate functions

2007-09-25 Thread Jeff Garzik
An equivalent-transformation change. No functional changes beyond those necessary to call the new, split-out functions. Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c index b20c188..f330d34 100644 --- a/drivers/scsi/gdth.c +++

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on copyup ops

2007-09-25 Thread Kok, Auke
Erez Zadok wrote: > Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> > --- > fs/unionfs/copyup.c | 102 +- > 1 files changed, 51 insertions(+), 51 deletions(-) > > diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c > index 23ac4c8..e3c5f15 100644

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread FUJITA Tomonori
On Tue, 25 Sep 2007 23:01:53 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-09-26 at 12:55 +0900, FUJITA Tomonori wrote: > > On Tue, 25 Sep 2007 22:45:53 -0500 > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > On Tue, 2007-09-25 at 23:34 -0400, Jeff Garzik wrote: > > > >

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-25 Thread Jeff Garzik
Peer Chen wrote: According to the description of section 5.2.2.1 and 10.1.2 of AHCI specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯ by software when GHC.AE is set to ¡®1¡¯. Signed-off-by: Peer Chen <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc7/drivers/ata/ahci.c.orig

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread James Bottomley
On Wed, 2007-09-26 at 12:55 +0900, FUJITA Tomonori wrote: > On Tue, 25 Sep 2007 22:45:53 -0500 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Tue, 2007-09-25 at 23:34 -0400, Jeff Garzik wrote: > > > Matthew Wilcox wrote: > > > > On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote:

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread FUJITA Tomonori
On Tue, 25 Sep 2007 22:45:53 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2007-09-25 at 23:34 -0400, Jeff Garzik wrote: > > Matthew Wilcox wrote: > > > On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote: > > >> Are there any const-ness worries for scsi_host_template, or

Re: [PATCH] put_user() on struct is not nice

2007-09-25 Thread Al Viro
On Wed, Sep 26, 2007 at 12:05:46PM +1000, Rusty Russell wrote: > On Wed, 2007-09-26 at 01:54 +0100, Al Viro wrote: > > use copy_to_user() instead... > > Thanks Al, Jes sent me the same fix which I have queued for for 2.6.24: OK, decision on urgency is up to you - post .23 is fine by me... - To

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread Jeff Garzik
James Bottomley wrote: This whole mess is generated basically because the zero default of the template should be treated as initiator. How about this, which makes that manifest? James diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index adc9559..7e26440 100644 ---

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread James Bottomley
On Tue, 2007-09-25 at 23:34 -0400, Jeff Garzik wrote: > Matthew Wilcox wrote: > > On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote: > >> Are there any const-ness worries for scsi_host_template, or plans for > >> the future? I do not see any other examples of the host template > >>

signals dropped when proc. run as daemon, but not when in the foreground

2007-09-25 Thread John Z. Bohach
Hello, I'm writing a system app. that becomes a daemon by the usual fork() -> setsid() -> fork() method. It then registers a signal handler for SIGCHLD via sigaction (SA_SIGINFO style). chldAction.sa_sigaction = sigChld; sigemptyset(&(chldAction.sa_mask)); chldAction.sa_flags =

[PATCH 2/2] [VIDEO FRAMEBUFFER] Blackfin BF54x framebuffer device driver for a SHARP LQ043T1DG01 TFT LCD

2007-09-25 Thread Bryan Wu
From: Michael Hennerich <[EMAIL PROTECTED]> Date: Wed, 26 Sep 2007 11:33:01 +0800 Subject: [PATCH 2/2] [VIDEO FRAMEBUFFER] Blackfin BF54x framebuffer device driver for a SHARP LQ043T1DG01 TFT LCD Signed-off-by: Michael Hennerich <[EMAIL PROTECTED]> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> ---

[PATCH 1/2] [INPUT] Blackfin BF54x Input Keypad controller driver

2007-09-25 Thread Bryan Wu
From: Michael Hennerich <[EMAIL PROTECTED]> Date: Sun, 5 Aug 2007 18:45:26 +0800 Subject: [PATCH 1/2] [INPUT] Blackfin BF54x Input Keypad controller driver Signed-off-by: Michael Hennerich <[EMAIL PROTECTED]> Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> --- drivers/input/keyboard/Kconfig

Re: 2.6.23-rc6-mm1: Build failure on ppc64 drivers/ata/pata_scc.c

2007-09-25 Thread Jeff Garzik
Satyam Sharma wrote: Hi, On Thu, 20 Sep 2007, Alan Cox wrote: On Thu, 20 Sep 2007 14:13:15 +0100 [EMAIL PROTECTED] (Mel Gorman) wrote: PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c . It doesn't show up on other arches because this driver is specific to the

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread FUJITA Tomonori
On Tue, 25 Sep 2007 22:37:33 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > FUJITA Tomonori wrote: > > diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c > > index adc9559..694015d 100644 > > --- a/drivers/scsi/hosts.c > > +++ b/drivers/scsi/hosts.c > > @@ -342,6 +342,10 @@ struct Scsi_Host

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread Matthew Wilcox
On Tue, Sep 25, 2007 at 11:34:00PM -0400, Jeff Garzik wrote: > Well, sure, the driver is the owner of that memory. > > We're talking about common code. > > If everybody agrees SHT is R/W in the core, Fujita-san's patch is fine. Oh ... harder to find, but scsi_module.c does that, as does

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread Jeff Garzik
Matthew Wilcox wrote: On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote: Are there any const-ness worries for scsi_host_template, or plans for the future? I do not see any other examples of the host template members getting modified. Goodness, Jeff, you haven't looked too hard.

[PATCH 25/25] Unionfs: use poison.h for safe poison pointers

2007-09-25 Thread Erez Zadok
This also fixes a compile warning on 64-bit systems. Signed-off-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/debug.c | 16 ++-- fs/unionfs/union.h |1 + 2 files changed, 7 insertions(+), 10 deletions(-) diff --git

[PATCH 01/25] Unionfs: Simplify unionfs_get_nlinks

2007-09-25 Thread Erez Zadok
From: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> Since we set the right value for d_type in readdir, there's really no point in having to calculate the number of directory links. Some on-disk filesystems don't even store the number of links for directories. Signed-off-by: Josef 'Jeff' Sipek <[EMAIL

[PATCH 04/25] Unionfs: cache-coherency fixes

2007-09-25 Thread Erez Zadok
From: Olivier Blin <[EMAIL PROTECTED]> Do not update mtime if there is no upper branch for the inode. This prevents from calling unionfs_lower_inode_idx() with a negative index, which triggers a bug. Signed-off-by: Olivier Blin <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]>

[PATCH 02/25] Unionfs: Remove unused #defines

2007-09-25 Thread Erez Zadok
From: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> Signed-off-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/union.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h index

[PATCH 18/25] Unionfs: add un/likely conditionals on super ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/main.c | 98 ++- fs/unionfs/super.c | 90 2 files changed, 95 insertions(+), 93 deletions(-) diff --git a/fs/unionfs/main.c

[PATCH 16/25] Unionfs: add un/likely conditionals on inode ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/inode.c | 160 ++-- 1 files changed, 80 insertions(+), 80 deletions(-) diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c index 7ee4760..7ae4a25 100644 --- a/fs/unionfs/inode.c +++

[PATCH 10/25] Unionfs: add un/likely conditionals on copyup ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/copyup.c | 102 +- 1 files changed, 51 insertions(+), 51 deletions(-) diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c index 23ac4c8..e3c5f15 100644 --- a/fs/unionfs/copyup.c +++

[PATCH 11/25] Unionfs: add un/likely conditionals on debug ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/debug.c | 108 +++ 1 files changed, 57 insertions(+), 51 deletions(-) diff --git a/fs/unionfs/debug.c b/fs/unionfs/debug.c index 9546a41..09b52ce 100644 --- a/fs/unionfs/debug.c +++

[PATCH 09/25] Unionfs: add un/likely conditionals on common fileops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c | 94 +++--- 1 files changed, 47 insertions(+), 47 deletions(-) diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c index e69ccf6..db8f064 100644 ---

[PATCH 20/25] Unionfs: add un/likely conditionals on rename ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/rename.c | 96 +- 1 files changed, 48 insertions(+), 48 deletions(-) diff --git a/fs/unionfs/rename.c b/fs/unionfs/rename.c index 7b8fe39..92c4515 100644 --- a/fs/unionfs/rename.c +++

[PATCH 12/25] Unionfs: add un/likely conditionals on dentry ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c | 68 ++ 1 files changed, 35 insertions(+), 33 deletions(-) diff --git a/fs/unionfs/dentry.c b/fs/unionfs/dentry.c index 52bcb18..3f3a18d 100644 --- a/fs/unionfs/dentry.c +++

[PATCH 13/25] Unionfs: add un/likely conditionals on dir ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/dirfops.c | 22 +++--- fs/unionfs/dirhelper.c | 30 +++--- 2 files changed, 26 insertions(+), 26 deletions(-) diff --git a/fs/unionfs/dirfops.c b/fs/unionfs/dirfops.c index c923e58..fa2df88

[PATCH 17/25] Unionfs: add un/likely conditionals on lookup ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/lookup.c | 44 ++-- 1 files changed, 22 insertions(+), 22 deletions(-) diff --git a/fs/unionfs/lookup.c b/fs/unionfs/lookup.c index 2109714..92b5e0a 100644 --- a/fs/unionfs/lookup.c +++

[PATCH 15/25] Unionfs: add un/likely conditionals on fileops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/file.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c index d8eaaa5..06ca1fa 100644 --- a/fs/unionfs/file.c +++ b/fs/unionfs/file.c

[PATCH 23/25] Unionfs: add un/likely conditionals on unlink ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/unlink.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git a/fs/unionfs/unlink.c b/fs/unionfs/unlink.c index 3924f7f..33d08d9 100644 --- a/fs/unionfs/unlink.c +++

[PATCH 06/25] Unionfs: minor coding style updates

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/debug.c |6 -- fs/unionfs/dentry.c |2 +- fs/unionfs/inode.c | 14 -- fs/unionfs/main.c |4 ++-- fs/unionfs/union.h |2 +- 5 files changed, 16 insertions(+), 12 deletions(-) diff --git

[PATCH 07/25] Unionfs: add lower nameidata debugging support

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/debug.c | 20 fs/unionfs/dentry.c |4 +++- fs/unionfs/inode.c |8 +++- fs/unionfs/union.h |4 4 files changed, 34 insertions(+), 2 deletions(-) diff --git a/fs/unionfs/debug.c

[PATCH 22/25] Unionfs: add un/likely conditionals on common subr

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/sioq.c |4 ++-- fs/unionfs/subr.c | 26 +- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/fs/unionfs/sioq.c b/fs/unionfs/sioq.c index 2a8c88e..35d9fc3 100644 --- a/fs/unionfs/sioq.c +++

[PATCH 08/25] Unionfs: lower nameidata support for nfsv4

2007-09-25 Thread Erez Zadok
Pass nameidata structures as needed to the lower file system, support LOOKUP_ACCESS/OPEN intents. This makes unionfs work on top of nfsv4. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> --- fs/unionfs/dentry.c | 11 +--

[PATCH 19/25] Unionfs: add un/likely conditionals on mmap ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/mmap.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c index 37af979..1cea075 100644 --- a/fs/unionfs/mmap.c +++ b/fs/unionfs/mmap.c @@ -84,7

[PATCH 21/25] Unionfs: add un/likely conditionals on readdir ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/rdstate.c | 15 --- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/rdstate.c b/fs/unionfs/rdstate.c index 0a18d5c..7ec7f95 100644 --- a/fs/unionfs/rdstate.c +++ b/fs/unionfs/rdstate.c @@ -45,7

[PATCH 03/25] Unionfs: display informational messages only if debug is on

2007-09-25 Thread Erez Zadok
This is to avoid filling the console/logs with messages that are primarily of debugging use. Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> --- fs/unionfs/commonfops.c |4 ++-- fs/unionfs/dentry.c |6 +++--- fs/unionfs/union.h |

[PATCH 24/25] Unionfs: add un/likely conditionals on xattr ops

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/xattr.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/unionfs/xattr.c b/fs/unionfs/xattr.c index 7f77d7d..bd2de06 100644 --- a/fs/unionfs/xattr.c +++ b/fs/unionfs/xattr.c @@ -23,14 +23,14 @@ void

[PATCH 14/25] Unionfs: add un/likely conditionals on headers

2007-09-25 Thread Erez Zadok
Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> --- fs/unionfs/fanout.h | 13 - fs/unionfs/union.h |4 ++-- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/fs/unionfs/fanout.h b/fs/unionfs/fanout.h index 51aa0de..6405399 100644 --- a/fs/unionfs/fanout.h +++

[PATCH 05/25] Unionfs: cast page->index loff_t before shifting

2007-09-25 Thread Erez Zadok
Fixes bugs in number promotion/demotion computation, as per Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> Acked-by: Josef 'Jeff' Sipek <[EMAIL PROTECTED]> --- fs/unionfs/mmap.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git

[GIT PULL -mm] 00/25 Unionfs updates/cleanups/fixes

2007-09-25 Thread Erez Zadok
The following is a series of patches related to Unionfs. Aside from a few minor cleanups/fixes, the two main changes are (1) lower nameidata support so we can stack on nfsv4, and (2) un/likely optimizations. These patches were tested (where appropriate) on our 2.6.23-rc8 latest code, as well as

[PATCH] Fix cgroup_create_dir() comments

2007-09-25 Thread Paul Menage
Comment fixed, to match the actual arguments. Signed-off-by: Balaji Rao <[EMAIL PROTECTED]> Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- kernel/cgroup.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: container-2.6.23-rc8-mm1/kernel/cgroup.c

[PATCH] Add cgroup write_uint() helper method

2007-09-25 Thread Paul Menage
Add write_uint() helper method for cgroup subsystems This helper is analagous to the read_uint() helper method for reporting u64 values to userspace. It's designed to reduce the amount of boilerplate requierd for creating new cgroup subsystems. Signed-off-by: Paul Menage <[EMAIL PROTECTED]>

Re: NMI error and Intel S5000PSL Motherboards

2007-09-25 Thread Randy Dunlap
On Wed, 26 Sep 2007 02:12:34 -0800 AndrewL733 wrote: > We have about 100 servers based on Intel S5000PSL-SATA motherboards. product info (for others): http://support.intel.com/support/motherboards/server/s5000psl/index.htm > They have been running for anywhere between 1 and 10 months. For the

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread Matthew Wilcox
On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote: > Are there any const-ness worries for scsi_host_template, or plans for > the future? I do not see any other examples of the host template > members getting modified. Goodness, Jeff, you haven't looked too hard. There's dozens of

Re: subsystem_unregister() breakage in -mm

2007-09-25 Thread Greg KH
On Wed, Sep 26, 2007 at 01:02:37AM +0200, Miklos Szeredi wrote: > > On Wed, Sep 26, 2007 at 12:27:14AM +0200, Miklos Szeredi wrote: > > > I get "BUG: failure at mm/slab.c:591/page_get_cache()!" in latest -mm > > > when removing the fuse module. > > > > > > This patch titled "kobject: remove the

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-25 Thread Jeff Garzik
Alan Cox wrote: It converts several macros to inline functions (encouraged), and also illustrates a nice, clean way of testing an ID word's validity. [obviously the final implementation varies, depending on that ID word's history] Its in -mm and I thought you put a copy in your tree after I

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread Jeff Garzik
FUJITA Tomonori wrote: diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index adc9559..694015d 100644 --- a/drivers/scsi/hosts.c +++ b/drivers/scsi/hosts.c @@ -342,6 +342,10 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)

Re: 2.6.23-rc7-mm1 AHCI ATA errors -- won't boot

2007-09-25 Thread Jeff Garzik
Berck E. Nash wrote: Jeff Garzik wrote: Does the attached patch change behavior at all? You should be able to apply it on top of libata-dev.git#upstream or -mm. Still broken, dmesg with ATA_DEBUG defined, attached. Great, this will be useful output. It will probably be a couple days

NMI error and Intel S5000PSL Motherboards

2007-09-25 Thread AndrewL733
We have about 100 servers based on Intel S5000PSL-SATA motherboards. They have been running for anywhere between 1 and 10 months. For the past few months, after updating them all to the 2.6.20.15 kernel (because of a bug in the 2.6.18 kernel), we are seeing some strange NMI errors. For

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread FUJITA Tomonori
On Tue, 25 Sep 2007 20:42:35 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-09-26 at 10:28 +0900, FUJITA Tomonori wrote: > > On Tue, 25 Sep 2007 20:00:02 -0500 > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > Andrew asked that I provide a status report of pending

Re: [PATCH 1/3] Fix coding style

2007-09-25 Thread Dhaval Giani
On Tue, Sep 25, 2007 at 09:16:20PM +0200, Ingo Oeser wrote: > On Tuesday 25 September 2007, Srivatsa Vaddagiri wrote: > > Index: current/kernel/sched_debug.c > > === > > --- current.orig/kernel/sched_debug.c > > +++

Re: [PATCH] put_user() on struct is not nice

2007-09-25 Thread Rusty Russell
On Wed, 2007-09-26 at 01:54 +0100, Al Viro wrote: > use copy_to_user() instead... Thanks Al, Jes sent me the same fix which I have queued for for 2.6.24: From: Jes Sorensen <[EMAIL PROTECTED]> Use copy_to_user() when copying a struct timespec to the guest - put_user() cannot handle two long's

Re: [GIT PATCH] SCSI bug fix for 2.6.23-rc8

2007-09-25 Thread James Bottomley
On Tue, 2007-09-25 at 12:55 -0500, James Bottomley wrote: > This is, unfortunately, not a recent regression but it's only been > recently diagnosed. Apparently the SCSI Parallel transport class domain > validation cable width detection wasn't working, leading to cases where > controllers with

Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure

2007-09-25 Thread KAMEZAWA Hiroyuki
On Wed, 26 Sep 2007 10:32:05 +0900 KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote: > Maybe my patch is the problem. could you give me your .config ? > Ah, memory hot remove is selectable even if the arch doesn't support itsorry. ok, this is fix. Thanks, -Kame == MEMORY_HOTREMOVE config option

Re: ACPI power off regression in 2.6.23-rc8 (NOT in rc7)

2007-09-25 Thread Mike Houston
On Tue, 25 Sep 2007 17:05:00 +0200 Damien Wyart <[EMAIL PROTECTED]> wrote: > > Will test this evening the patch you pointed in your next message. > > Ok, with both patches (including the very latest one from Alexey --- > tried the "stylistically correct" one), machine halts fine again. > Thanks

Re: CFS: new java yield graphs

2007-09-25 Thread Antoine Martin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 These are pure cpu scheduling tests, not doing any I/O this time. All these tests are still "pathological" in the sense that they are only meant to show differences between schedulers rather than try to simulate real usage scenarios. all the graphs

[PATCH] - drivers/hid/hid-debug.c - trivial - add KERN_DEBUG prefix, fix typo, constify

2007-09-25 Thread Joe Perches
Added KERN_DEBUG to output lines Fixed preffered -> preferred typo Added const to char *'s Also, exported symbol hid_resolv_event is unused by the current kernel tree and perhaps should be removed. Signed-off-by: Joe Perches <[EMAIL PROTECTED]> diff --git a/drivers/hid/hid-debug.c

Re: [PATCH 1/4] module: implement module_inhibit_unload()

2007-09-25 Thread Tejun Heo
Rusty Russell wrote: > On Wed, 2007-09-26 at 08:15 +0900, Tejun Heo wrote: >> I have no problem with changing the condition check to loop but it would >> be great if someone can point me to a code where this unexpected wake up >> is used. > > This is one of those areas where we're conservative.

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread James Bottomley
On Wed, 2007-09-26 at 10:28 +0900, FUJITA Tomonori wrote: > On Tue, 25 Sep 2007 20:00:02 -0500 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > Andrew asked that I provide a status report of pending updates. The > > list is attached below. It's pretty much driver updates and minor bug > >

[RFC] detect missed mnt_want_write() calls

2007-09-25 Thread Dave Hansen
On Fri, 2007-09-21 at 01:17 -0700, Andrew Morton wrote: > On Thu, 20 Sep 2007 12:52:57 -0700 Dave Hansen <[EMAIL PROTECTED]> wrote: > > + ret = mnt_want_write(filp->f_vfsmnt); > > It still creeps me out that we have this sprinkled *all over* the tree and > people will forget to do it

Re: kswapd high CPU usage with no swap

2007-09-25 Thread Rik van Riel
On Tue, 25 Sep 2007 12:13:41 +0200 Jan Kundrát <[EMAIL PROTECTED]> wrote: > Rik van Riel wrote: > > How much memory did you have in "cached" when you looked > > with top (and no swap enabled) ? > > Hi Rik, > it was pretty low number (several thousands, or maybe tens of > thousands). > > In the

Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure

2007-09-25 Thread KAMEZAWA Hiroyuki
On Wed, 26 Sep 2007 01:30:02 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > Hi Andrew, > > The 2.6.23-rc8-mm1 kernel linking fails on the powerpc (P5+) box > > CC init/version.o > LD init/built-in.o > LD .tmp_vmlinux1 > drivers/built-in.o: In function

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread FUJITA Tomonori
On Tue, 25 Sep 2007 20:00:02 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > Andrew asked that I provide a status report of pending updates. The > list is attached below. It's pretty much driver updates and minor bug > fixes. The main functionality changes are Kay's sysfs updates and the >

Re: 2.6.23-rc7-mm1 AHCI ATA errors -- won't boot

2007-09-25 Thread Jeff Garzik
Berck E. Nash wrote: Jeff Garzik wrote: Once the blame has been squared fixed upon me :) you can use git-bisect to locate the precise change that broke your setup. Okay, here's the problem: 268fe6f9f15551be9abedd44a237392675d529d5 is first bad commit commit

Re: missing mnt_drop_write() on open error

2007-09-25 Thread Dave Hansen
On Wed, 2007-09-26 at 01:14 +0200, Miklos Szeredi wrote: > I get this at umount, if there was a failed open(): > > WARNING: at fs/namespace.c:586 __mntput() > > I think the problem is that may_open() calls mnt_want_write(), but if > open doesn't succeed, mnt_drop_write() will not be called.

Re: 2.6.23-rc7-mm1 AHCI ATA errors -- won't boot

2007-09-25 Thread Jeff Garzik
Robert Hancock wrote: ATA spec says "The device shall return command aborted if the device does not support the Power Management feature set." Whereas TEST UNIT READY is required for SCSI. It seems the SAT authors didn't consider this case. Dumb me -- I misread that as mandatory.

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread David Miller
From: James Bottomley <[EMAIL PROTECTED]> Date: Tue, 25 Sep 2007 20:00:02 -0500 > David Miller (1): > esp: fix instance numbering. I'd like to request that this one goes into 2.6.23 as it is a bug fix and the bug confuses users. Thanks. - To unsubscribe from this list: send the line

Re: [PATCH 1/1] Unionfs: move poison #define into poison.h

2007-09-25 Thread Josef 'Jeff' Sipek
On Tue, Sep 25, 2007 at 01:45:19PM -0400, Josef 'Jeff' Sipek wrote: > This also fixes a compile warning on 64-bit systems. Ok, I had a brain-fart...ignore this patch. Jeff. -- We have joy, we have fun, we have Linux on a Sun... - To unsubscribe from this list: send the line "unsubscribe

queued patches for SCSI for 2.6.24

2007-09-25 Thread James Bottomley
Andrew asked that I provide a status report of pending updates. The list is attached below. It's pretty much driver updates and minor bug fixes. The main functionality changes are Kay's sysfs updates and the shift of the ULD attachement towards the block prep function. James --- Adrian Bunk

Re: Chroot bug

2007-09-25 Thread Adrian Bunk
On Wed, Sep 26, 2007 at 09:20:54AM +0930, David Newall wrote: > Alan Cox wrote: >> On Wed, 26 Sep 2007 01:05:07 +0930 >> David Newall <[EMAIL PROTECTED]> wrote: >>> Alan Cox wrote: >>> > Marek's loading dynamic libraries, it seems clear that the prime > purpose of chroot is to aid

[PATCH] fix sctp_del_bind_addr() last argument type

2007-09-25 Thread Al Viro
It gets pointer to fastcall function, expects a pointer to normal one and calls the sucker. Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- include/net/sctp/structs.h |2 +- net/sctp/bind_addr.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] cdrom_open() forgets to unlock on -EROFS failure exits

2007-09-25 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/cdrom/cdrom.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c index 67ee3d4..7924571 100644 --- a/drivers/cdrom/cdrom.c +++ b/drivers/cdrom/cdrom.c @@ -1032,6 +1032,10

[PATCH] put_user() on struct is not nice

2007-09-25 Thread Al Viro
use copy_to_user() instead... Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/lguest/hypercalls.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/lguest/hypercalls.c b/drivers/lguest/hypercalls.c index db6caac..5ecd60b 100644 ---

[PATCH] hibernation doesn't even build on frv - tons of helpers are missing

2007-09-25 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- kernel/power/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig index c8580a1..14b0e10 100644 --- a/kernel/power/Kconfig +++ b/kernel/power/Kconfig @@ -110,7 +110,7 @@ config

[PATCH] mv643xx_eth: duplicate methods in initializer

2007-09-25 Thread Al Viro
Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/net/mv643xx_eth.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c index 6a117e9..456d1e1 100644 --- a/drivers/net/mv643xx_eth.c +++ b/drivers/net/mv643xx_eth.c

[PATCH] usbvision-video: buggered method tables

2007-09-25 Thread Al Viro
duplicated .mmap in one, .vidioc_s_audio misspelled as .vidioc_g_audio in other Signed-off-by: Al Viro <[EMAIL PROTECTED]> --- drivers/media/video/usbvision/usbvision-video.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git

Re: subsystem_unregister() breakage in -mm

2007-09-25 Thread Greg KH
On Wed, Sep 26, 2007 at 01:02:37AM +0200, Miklos Szeredi wrote: > > On Wed, Sep 26, 2007 at 12:27:14AM +0200, Miklos Szeredi wrote: > > > I get "BUG: failure at mm/slab.c:591/page_get_cache()!" in latest -mm > > > when removing the fuse module. > > > > > > This patch titled "kobject: remove the

Re: sys_chroot+sys_fchdir Fix

2007-09-25 Thread Al Viro
On Tue, Sep 25, 2007 at 04:53:00PM -0400, Phillip Susi wrote: > Alan Cox wrote: > >On Fri, 21 Sep 2007 13:39:34 -0400 > >Phillip Susi <[EMAIL PROTECTED]> wrote: > > > >>David Newall wrote: > >>>* In particular, the superuser can escape from a =91chroot jail=92 by d= > >>>oing=20 > >>>=91mkdir foo;

Re: Chroot bug

2007-09-25 Thread Alan Cox
> Good call. Though I suppose, since it's used 24x7 to aid security on > countless production servers, that security dwarfs testing. Still, > debugging, yes that's valid. > > I don't suppose it makes and difference; whatever the purpose, a chroot > that doesn't change the root is buggy. It

[PATCH 4/4] mthca: allow setting "dmaflush" attribute on user-allocated memory

2007-09-25 Thread akepner
Use the dma_flags_set_dmaflush() interface to allow a "dmaflush" attribute to be associated with user-allocated memory. (For now, it's only implemented for mthca.) Signed-off-by: Arthur Kepner <[EMAIL PROTECTED]> -- drivers/infiniband/core/umem.c |7 +--

  1   2   3   4   5   6   7   8   9   10   >