Re: 2.6.23-rc8-mm2

2007-09-29 Thread thunder7
From: Greg KH <[EMAIL PROTECTED]> Date: Sat, Sep 29, 2007 at 08:19:42AM -0700 > On Sat, Sep 29, 2007 at 05:37:29PM +0800, Dave Young wrote: > > Hi, > > The kernel report warnings about sysfs filename duplicate under > > rc8-mm1 and rc8-mm2. > > 1. > > cut > > sysfs: duplicate filename

Re: 2.6.23-rc8-mm2 - PowerPC link failure at arch/powerpc/kernel/head_64.o

2007-09-29 Thread Kamalesh Babulal
Hi Andrew, The compilation with the cross compiler for the PowerPC-405 on the powerbox fails at linking LD init/built-in.o LD .tmp_vmlinux1 ld: arch/powerpc/kernel/head_64.o(.text+0x80c8): sibling call optimization to `.text.init.refok' does not allow automatic multiple TOCs;

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Linus Torvalds writes: > > > On Sat, 29 Sep 2007, Erez Zadok wrote: > > > > Would you prefer if CodingStyle was reorganized or even split into (1) > > general principles and (2) details? Perhaps we need a CodingStylePrinciples > > and a CodingStyleDetails? > >

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sun, 30 Sep 2007 04:27:24 BST, Al Viro said: > ... and no matter how many rules you put down, it's still possible to > write a code that will be awful stylistically while adhering to all of > them. Religiously. I've run into those sort of programmers. Unfortunately, there's no real cure for

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, [EMAIL PROTECTED] wrote: > > I kind of meant the *maintainers* couldn't whine about things not in > CodingStyle ;) No, I understood you. I'm personally of the opinion that the automated style checking, and having detailed rules is always a mistake. It's *much* better

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 20:00:01 PDT, Linus Torvalds said: > On Sat, 29 Sep 2007, [EMAIL PROTECTED] wrote: > > I think there needs to be a "sense of fairness" attached here - CodingStyle > > should cover all the stuff maintainers/reviewers are allowed to whinge > > about. > > No. > > People whine

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Theodore Tso writes: > On Sat, Sep 29, 2007 at 03:56:38PM -0400, J. Bruce Fields wrote: > > It'd be a start just to revert CodingStyle to its original content and > > move the rest to CodingStyleReference. But someone would want to skim > > through the CodingStyle

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Al Viro
On Sat, Sep 29, 2007 at 10:24:01PM -0400, [EMAIL PROTECTED] wrote: > On Sat, 29 Sep 2007 11:18:05 PDT, Linus Torvalds said: > > > "CodingStyle" should be about the big issues, not about details. Yes, > > we've messed that up over the years, but let's not continue that. > > > > In other words,

[PATCH] Add Documentation/{w1,w1/masters}/00-INDEX

2007-09-29 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Two 00-INDEX files under Documentation/w1 Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- Documentation/w1/00-INDEX |8 Documentation/w1/masters/00-INDEX |6 ++ 2 files changed, 14 insertions(+) --- /dev/null 2007-04-23

[PATCH] Add missing entries to top level Documentation/00-INDEX

2007-09-29 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> Add missing entries to Documentation/00-INDEX Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- Documentation/00-INDEX | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff -r dc28e4e17791 Documentation/00-INDEX ---

Re: [rfc][patch] i386: remove comment about barriers

2007-09-29 Thread Paul E. McKenney
On Sat, Sep 29, 2007 at 03:28:48PM +0200, Nick Piggin wrote: > Hi, > > OK this was going to be a quick patch, but after sleeping on it, I think > it deserves a better analysis... I can prove the comment is incorrect with a > test program, but I'm not as sure about my thinking that leads me to

[PATCH] Tweak Documentation/SM501.txt

2007-09-29 Thread Rob Landley
From: Rob Landley <[EMAIL PROTECTED]> The existing Documentation/SM501.txt gives no clue what the chip is or does, so copy the description from Kconfig help text. cc: Ben Dooks <[EMAIL PROTECTED]> Signed-off-by: Rob Landley <[EMAIL PROTECTED]> --- Documentation/SM501.txt |5 + 1 file

Re: [PATCH RFC 6/9] RCU priority boosting for preemptible RCU

2007-09-29 Thread Paul E. McKenney
On Fri, Sep 28, 2007 at 07:05:14PM -0400, Steven Rostedt wrote: > > > -- > On Fri, 28 Sep 2007, Gautham R Shenoy wrote: > > > > > > > +#ifdef CONFIG_PREEMPT_RCU_BOOST > > > +/* > > > + * Task state with respect to being RCU-boosted. This state is changed > > > + * by the task itself in

Re: [RFC] Extending kbuild syntax

2007-09-29 Thread Adrian Bunk
On Sat, Sep 29, 2007 at 10:11:45PM +0200, Sam Ravnborg wrote: >... > The second is the more controversial suggestion. > In several Makefile we have simple if expression of the variants: > if ($(CONFIG_FOO),y) > obj-$(CONFIG_BAR) += fubar.o > endif > > The pattern varies over this theme. > The

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, [EMAIL PROTECTED] wrote: > > I think there needs to be a "sense of fairness" attached here - CodingStyle > should cover all the stuff maintainers/reviewers are allowed to whinge about. No. People whine too much as is. Don't give them *license* to do so.

Re: 2.6.23-rc8-mm2

2007-09-29 Thread Valdis . Kletnieks
On Thu, 27 Sep 2007 02:22:20 PDT, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc8/2.6.23-rc8-mm2/ Locks up hard at very early boot on my Dell Latitude - grub says loading kernel, the screen clears, and we lock up before we get penguins. -rc8-mm1 was

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 11:18:05 PDT, Linus Torvalds said: > "CodingStyle" should be about the big issues, not about details. Yes, > we've messed that up over the years, but let's not continue that. > > In other words, I'd suggest *removing* lines from CodingStyle, not adding > them. The file has

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Valdis . Kletnieks
On Sat, 29 Sep 2007 03:51:56 PDT, Andrew Morton said: > Printing something like > > bytes remaining: 0x12 (18) > > is a quite logical thing to do, although pretty darm pointless. On the other hand, printing this: magic number: 0x2710 probably doesn't ring any bells, but if you

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Theodore Tso
On Sat, Sep 29, 2007 at 03:56:38PM -0400, J. Bruce Fields wrote: > It'd be a start just to revert CodingStyle to its original content and > move the rest to CodingStyleReference. But someone would want to skim > through the CodingStyle history for any legimate corrections that we > want to keep.

bluetooth: hci_sysfs work queue problem

2007-09-29 Thread Dave Young
Hi, The hci_sysfs uses work queue to finish the sysfs add/del fuction. But when the same device connection failed, if another connection of same device come in before the delete work finish, sysfs will warn about duplicate filename creating. Sep 19 12:30:27 darkstar kernel: sysfs: duplicate

Re: [patch] x86: improved memory barrier implementation

2007-09-29 Thread Dave Jones
On Fri, Sep 28, 2007 at 05:07:19PM +0100, Alan Cox wrote: > > Winchip: can any of these CPUs with ooostores do SMP? If not, then smp_wmb > > can also be a simple barrier on i386 too. > > The IDT Winchip can do SMP apparently. >From the Winchip3 (which was the final winchip) specs.. "The

Re: [patch 2/5] Linux Kernel Markers

2007-09-29 Thread Rusty Russell
On Fri, 2007-09-28 at 10:28 -0400, Mathieu Desnoyers wrote: > +struct __mark_marker; Hi Mathieu, How about, "struct marker". You've taken the "marker*" namespace, so all these underscores are __gratuitious__ :) > +/* > + * module_mutex nests inside markers_mutex. Markers mutex protects

Re: 2.6.23-rc8-mm2

2007-09-29 Thread Dave Young
>On 9/29/07, Greg KH <[EMAIL PROTECTED]> wrote: > On Sat, Sep 29, 2007 at 05:37:29PM +0800, Dave Young wrote: > > Hi, > > The kernel report warnings about sysfs filename duplicate under > > rc8-mm1 and rc8-mm2. > > 1. > > cut > > NET: Registered protocol family 16 > > ACPI: bus type pci

[ANNOUNCE] GIT 1.5.3.3

2007-09-29 Thread Junio C Hamano
The latest maintenance release GIT 1.5.3.3 is available at the usual places: http://www.kernel.org/pub/software/scm/git/ git-1.5.3.3.tar.{gz,bz2} (tarball) git-htmldocs-1.5.3.3.tar.{gz,bz2} (preformatted docs) git-manpages-1.5.3.3.tar.{gz,bz2}

Re: getting FUSD compiled with current kernels

2007-09-29 Thread Lee Revell
On 9/29/07, Florian Schmidt <[EMAIL PROTECTED]> wrote: > My goal is to hack up oss2jack [3] to use ALSA pcm devices.. And a later goal > is to create a virtual ALSA soundcard [which would multiplex access to a real > non hw-mixing capable soundcard] to finally end the dmix software mixing woes >

Re: [PATCH] make unicode default

2007-09-29 Thread Antonino A. Daplas
On Sat, 2007-09-29 at 10:36 +0200, Jan Engelhardt wrote: > Make the vt return to the system default when it is reset. > Also make UTF-8 the system default. It's about time we do, so this is fine with me. Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, Erez Zadok wrote: > > Would you prefer if CodingStyle was reorganized or even split into (1) > general principles and (2) details? Perhaps we need a CodingStylePrinciples > and a CodingStyleDetails? I'm certainly ok with the split into two files. What I'm not ok with is

Re: F_DUPFD_CLOEXEC implementation

2007-09-29 Thread Denys Vlasenko
Hi Ulrich, On Friday 28 September 2007 18:34, Ulrich Drepper wrote: > One more small change to extend the availability of creation of > file descriptors with FD_CLOEXEC set. Adding a new command to > fcntl() requires no new system call and the overall impact on > code size if minimal.

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Linus Torvalds writes: > > > On Fri, 28 Sep 2007, Erez Zadok wrote: > > > > Documentation/CodingStyle | 88 > > +- > > I'm not very happy with this. > > "CodingStyle" should be about the big issues, not about

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Måns Rullgård
David Brownell <[EMAIL PROTECTED]> writes: >> > > Let's kill it, please. (i.e., ACK) >> > >> > But ... why? What value could needless parens provide? >> >> Who says that needless parens could provide value? > > Jean, which is why he submitted the patch. > You, implicitly, by acking a patch

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 15:30:15 -0700 David Brownell wrote: > > > > Let's kill it, please. (i.e., ACK) > > > > > > But ... why? What value could needless parens provide? > > > > Who says that needless parens could provide value? > > Jean, which is why he submitted the patch. > You, implicitly,

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread H. Peter Anvin
Wolfgang Erig wrote: > Hi Peter, > > On Sat, Sep 29, 2007 at 11:35:53AM +0200, Wolfgang Erig wrote: >> I start again with a fresh tree and better controlled experiments. > > now the result of bisection seems to be consistent. > > The last good commit is >

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
> > > Let's kill it, please. (i.e., ACK) > > > > But ... why? What value could needless parens provide? > > Who says that needless parens could provide value? Jean, which is why he submitted the patch. You, implicitly, by acking a patch saying those parens are bad. But not me ... I don't think

Re: [patch] Combine path_put and path_put_conditional

2007-09-29 Thread Ingo Oeser
Hi Andreas, On Friday 28 September 2007, Andreas Gruenbacher wrote: > The name path_put_conditional (formerly, dput_path) is a little unclear. > Replace (path_put_conditional + path_put) with path_walk_put_both, > "put a pair of paths after a path_walk" (see the kerneldoc). ^

Re: [2.6.23-rc8-mm2] kernel BUG at mm/slab.c:591! | invalid opcode: 0000 [#1] SMP

2007-09-29 Thread Frans Pop
On Friday 28 September 2007, you wrote: > My Toshiba Satellite A40 (i386, P4 Mobile) hangs during boot after: With 'hpet-force-enable-on-ich34' reverted the system boots OK again. We're not yet done though. It now fails to resume from suspend and there's also the BUG (see subject) during power

Re: [PATCHSET 3/4] sysfs: divorce sysfs from kobject and driver model

2007-09-29 Thread Tejun Heo
Hello, Eric. Eric W. Biederman wrote: > Mostly I am thinking that any non-object model users should have > their own dedicated wrapper layer. To help keep things consistent > and to make it hard enough to abuse the system that people will > find that it is usually easier to do it the

Re: FW: [patch 01/02] vfs: variant symlinks

2007-09-29 Thread Trond Myklebust
On Sat, 2007-09-29 at 12:40 -0700, Schmidt, Kenneth P wrote: > The best example of how this can be useful is to allow a heterogeneous > environment which uses a common filesystem. For example, both x86_64 and > power systems could mount a root nfs share and execute with a common set of >

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Robert P. J. Day
On Sat, 29 Sep 2007, Linus Torvalds wrote: > > > On Fri, 28 Sep 2007, Erez Zadok wrote: > > > > Documentation/CodingStyle | 88 > > +- > > I'm not very happy with this. > > "CodingStyle" should be about the big issues, not about details. > Yes, we've

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Rafael J. Wysocki
On Saturday, 29 September 2007 22:47, Bill Davidsen wrote: > Alexey Starikovskiy wrote: > > > -static void > > -acpi_power_off (void) > > -{ > > - printk("%s called\n",__FUNCTION__); > > - /* Some SMP machines only can poweroff in boot CPU */ > > - set_cpus_allowed(current,

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-09-29 Thread Ilpo Järvinen
On Sat, 29 Sep 2007, Cedric Le Goater wrote: > Ilpo Järvinen wrote: > > On Fri, 28 Sep 2007, Ilpo Järvinen wrote: > >> On Fri, 28 Sep 2007, Cedric Le Goater wrote: > >> > >>> I just found that warning in my logs. It seems that it's been > >>> happening since rc7-mm1 at least. > >>> > >>>

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Bill Davidsen
Alexey Starikovskiy wrote: -static void -acpi_power_off (void) -{ - printk("%s called\n",__FUNCTION__); - /* Some SMP machines only can poweroff in boot CPU */ - set_cpus_allowed(current, cpumask_of_cpu(0)); ACPI in kernel 2.6.12 did disable non-boot cpus too in powe_off.

Re: [spi-devel-general] IT8716F SPI driver submission?

2007-09-29 Thread David Brownell
> The IT8716F accepts commands byte-wise and does all of the lifting on > the SPI bus as well. There are limitations, though: > - It can send 1,2,4,5 bytes (including command byte) to the slave and > read 0,1,2,3 bytes back. Other values are not possible. > - Bus clock rate is either 33 MHz or

Re: FW: [patch 01/02] vfs: variant symlinks

2007-09-29 Thread Al Viro
On Sat, Sep 29, 2007 at 12:40:23PM -0700, Schmidt, Kenneth P wrote: > The best example of how this can be useful is to allow a heterogeneous > environment which uses a common filesystem. For example, both x86_64 and > power systems could mount a root nfs share and execute with a common set of >

Re: [OT] kbuild syntax extension for ccflags and asflags (was: [PATCH 1/3] CodingStyle updates)

2007-09-29 Thread Sam Ravnborg
> > Lately I have considered extending the kbuild syntax a bit. > > > > Introducing > > ccflags-y > > asflags-y > > > > [with same functionality as the EXTRA_CFLAGS, EXTRA_AFLAGS] > > would allow us to do: > > > > ccflags-$(CONFIG_WHATEVER_DEBUG) := -DDEBUG > > Please do! > > That is very

[OT] kbuild syntax extension for ccflags and asflags (was: [PATCH 1/3] CodingStyle updates)

2007-09-29 Thread Ingo Oeser
Hi Sam, On Saturday 29 September 2007, Sam Ravnborg wrote: > Lately I have considered extending the kbuild syntax a bit. > > Introducing > ccflags-y > asflags-y > > [with same functionality as the EXTRA_CFLAGS, EXTRA_AFLAGS] > would allow us to do: > > ccflags-$(CONFIG_WHATEVER_DEBUG) :=

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 11:53:06 -0700 David Brownell wrote: > > From [EMAIL PROTECTED] Sat Sep 29 11:40:17 2007 > > > > Let's kill it, please. (i.e., ACK) > > But ... why? What value could needless parens provide? Who says that needless parens could provide value? > "Yet Another Subtle And

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 15:56:38 -0400 J. Bruce Fields wrote: > On Sat, Sep 29, 2007 at 11:18:05AM -0700, Linus Torvalds wrote: > > I'm not very happy with this. > > > > "CodingStyle" should be about the big issues, not about details. Yes, > > we've messed that up over the years, but let's not

[RFC] Extending kbuild syntax

2007-09-29 Thread Sam Ravnborg
Over the last few weeks I have pondered with the idea to extend the current kbuild syntax. The idea have existed for long but only recently I started to think how to do this in a truely flexible manner. Two areas are in need for a bit of attention to improve current kbuild files in the kernel.

[PATCH 4/4] hpt366: MWDMA filter for SATA cards (take 2)

2007-09-29 Thread Sergei Shtylyov
The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in their so-called drivers :-), so the driver needs to account for this -- to achieve this: - add mdma_filter() method from the original patch by Bartlomiej Zolnierkewicz

Re: [2.6.23-rc8-mm2] System hangs (loops?) during boot

2007-09-29 Thread Andrew Morton
On Sat, 29 Sep 2007 21:40:22 +0200 Frans Pop <[EMAIL PROTECTED]> wrote: > On Saturday 29 September 2007, you wrote: > > On Sat, 29 Sep 2007 02:32:44 +0200 Frans Pop <[EMAIL PROTECTED]> wrote: > > > On Friday 28 September 2007, Frans Pop wrote: > > > > My Toshiba Satellite A40 (i386, P4 Mobile)

Re: Write-back from inside FS - need suggestions

2007-09-29 Thread Andrew Morton
On Sat, 29 Sep 2007 22:10:42 +0300 Artem Bityutskiy <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > I'd have thought that a suitable wrapper around a suitably-modified > > sync_sb_inodes() would be appropriate for both filesystems? > > Ok, I've modified sync_inodes_sb() so that I can pass

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread J. Bruce Fields
On Sat, Sep 29, 2007 at 11:18:05AM -0700, Linus Torvalds wrote: > I'm not very happy with this. > > "CodingStyle" should be about the big issues, not about details. Yes, > we've messed that up over the years, but let's not continue that. > > In other words, I'd suggest *removing* lines from

Re: Write-back from inside FS - need suggestions

2007-09-29 Thread Artem Bityutskiy
Andrew Morton wrote: I'd have thought that a suitable wrapper around a suitably-modified sync_sb_inodes() would be appropriate for both filesystems? Ok, I've modified sync_inodes_sb() so that I can pass it my own wbc, where I set wcb->nr_to_write = 20. It gives me _exactly_ what I want. It

Re: Out of memory management in embedded systems

2007-09-29 Thread Abhishek Sagar
On 9/29/07, Daniel Spång <[EMAIL PROTECTED]> wrote: > > An embedded system is NOT an ordinary system that happens to > > boot from flash. An embedded system requires intelligent design. > > We might be talking about slightly different systems. I agree that > systems that are really embedded, in

[FYI] 2.6.23-rc8-git3 misc observations

2007-09-29 Thread Bill Davidsen
Running FC6 (updated this am) the temp sensors GNOME applet works with the kernel.org kernel, not the FC6 kernel. This has been true for a while, and I've stopped chasing it, I don't really care right now, since the sensors command works fine and that's what my daemon checks. Using 2.6.23-rc8

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Wolfgang Erig
Hi Peter, On Sat, Sep 29, 2007 at 08:07:21PM +0200, Wolfgang Erig wrote: > > Now I try the things written in > http://marc.info/[EMAIL PROTECTED] I have dumped a memory region which is my understanding what you want to see. The difference between the good and the bad case is only the patch

FW: [patch 01/02] vfs: variant symlinks

2007-09-29 Thread Schmidt, Kenneth P
On 9/28/07 11:22 AM, "Jan Dittmer" <[EMAIL PROTECTED]> wrote: > Ken Schmidt wrote: >> Variant symlinks add the ability to embed variables in to the >> contents of symbolic links so their targets can change based on >> outside sources (user environment, uts, filesystems, etc.) > > Could you

Re: [15/17] SLUB: Support virtual fallback via SLAB_VFALLBACK

2007-09-29 Thread Andrew Morton
On Sat, 29 Sep 2007 06:19:33 +1000 Nick Piggin <[EMAIL PROTECTED]> wrote: > On Saturday 29 September 2007 19:27, Andrew Morton wrote: > > On Sat, 29 Sep 2007 11:14:02 +0200 Peter Zijlstra <[EMAIL PROTECTED]> > wrote: > > > > oom-killings, or page allocation failures? The latter, one hopes. > >

Re: [rfc][patch] i386: remove comment about barriers

2007-09-29 Thread Davide Libenzi
On Sat, 29 Sep 2007, Nick Piggin wrote: > [ This is true for x86's sfence/lfence, but raises a question about Linux's > memory barriers. Does anybody expect that a sequence of smp_wmb and smp_rmb > would ever provide a full smp_mb barrier? I've always assumed no, but I > don't know if it is

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
> From [EMAIL PROTECTED] Sat Sep 29 11:40:17 2007 > > Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? "Yet Another Subtle And Hard To Fix Source Of Bloat" is not a plus. I'd kind of think a change like this should have some positive motivation. - To

Re: Versioning file system

2007-09-29 Thread Sorin Faibish
Interesting that you mention the multitude of file systems because I was very surprised to see NILFS being promoted in the latest Linux Magazine but no mention of the other more important file systems currently in work like UnionFS ChunkFS or ext4 so publisized. I can say I was disapointed of the

2.6.22/realtek bug in hardware, any kernel work-around?

2007-09-29 Thread Justin Piszcz
Package: samba Version: 3.0.26a-1 Kernel: 2.6.22 samba 3.0.26a-1 performance < 900 KiB/s, but FTP = 30-90 MiB/s Let me start out by saing this is an oddball problem: SAMBA: LINUX -> WINDOWS = < 900 KiB/s (varies between 100 - 900 KiB/s) WINDOWS -> LINUX = 30-90 MiB/s (always) FTP: Either

Re: Bonnie++ with 1024k stripe SW/RAID5 causes kernel to goto D-state

2007-09-29 Thread Chris Snook
Justin Piszcz wrote: Kernel: 2.6.23-rc8 (older kernels do this as well) When running the following command: /usr/bin/time /usr/sbin/bonnie++ -d /x/test -s 16384 -m p34 -n 16:10:16:64 It hangs unless I increase various parameters md/raid such as the stripe_cache_size etc.. # ps auxww |

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 03:51:56 -0700 Andrew Morton wrote: > On Sat, 29 Sep 2007 12:25:30 +0200 Jean Delvare <[EMAIL PROTECTED]> wrote: > > > Remove a not particularly relevant rule from CodingStyle. > > Sometimes, printing numbers in parentheses doesn't add value, but in > > some (most?) cases it

Re: [PATCH 1/3] CodingStyle updates

2007-09-29 Thread Sam Ravnborg
On Sat, Sep 29, 2007 at 11:01:29AM -0700, Randy Dunlap wrote: > On Fri, 28 Sep 2007 17:32:00 -0400 Erez Zadok wrote: > > > 1. Updates chapter 13 (printing kernel messages) to expand on the use of > >pr_debug()/pr_info(), what to avoid, and how to hook your debug code with > >kernel.h. > >

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Fri, 28 Sep 2007, Erez Zadok wrote: > > Documentation/CodingStyle | 88 > +- I'm not very happy with this. "CodingStyle" should be about the big issues, not about details. Yes, we've messed that up over the years, but let's not continue that.

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Wolfgang Erig
Hi Peter, On Sat, Sep 29, 2007 at 11:35:53AM +0200, Wolfgang Erig wrote: > > I start again with a fresh tree and better controlled experiments. now the result of bisection seems to be consistent. The last good commit is f2d98ae63dc64dedb00499289e13a50677f771f9 Linker script for the new x86

Re: [PATCH 1/1] Kernel compile bug in 2.6.22.6/7 {maybe more} ARM/StrongARM

2007-09-29 Thread Russell King
On Wed, Sep 26, 2007 at 04:53:14PM -0400, Dave Jones wrote: > Following up on this from yesterday, Linus please revert the above cset. > It doesn't seem to be necessary (it was added to fix a miscompile in > 'make allnoconfig' which doesn't seem to be repeatable with it reverted) > and actively

Re: [PATCH 1/3] CodingStyle updates

2007-09-29 Thread Randy Dunlap
On Fri, 28 Sep 2007 17:32:00 -0400 Erez Zadok wrote: > 1. Updates chapter 13 (printing kernel messages) to expand on the use of >pr_debug()/pr_info(), what to avoid, and how to hook your debug code with >kernel.h. > > Signed-off-by: Erez Zadok <[EMAIL PROTECTED]> > --- >

2.6.23-rc8 - Hangcheck on resume from x2mem

2007-09-29 Thread Bill Davidsen
I find this in dmesg after resume from s2mem: Hangcheck: hangcheck value past margin! System: ASUS P5LD2-VM board, Intel 6600 CPU at 2.40 GHz (no o/c) 2GB RAM, 3x320GB SATA sw RAID-5. FC6 distribution, fully updated, suspend via "system" menu pulldown. Just in case this is of interest,

[PATCH] fix console change race exposed by CFS

2007-09-29 Thread Jan Luebbe
From: Jan Lübbe <[EMAIL PROTECTED]> The new behaviour of CFS exposes a race which occurs if a switch is requested when vt_mode.mode is VT_PROCESS. The process with vc->vt_pid is signaled before vc->vt_newvt is set. This causes the switch to fail when triggered by the monitoing process because

Re: [PATCH] module: return error when mod_sysfs_init() failed

2007-09-29 Thread Greg KH
On Sun, Sep 30, 2007 at 12:37:10AM +0900, Akinobu Mita wrote: > 2007/9/29, Greg KH <[EMAIL PROTECTED]>: > > > Index: 2.6-git/kernel/module.c > > > === > > > --- 2.6-git.orig/kernel/module.c > > > +++ 2.6-git/kernel/module.c > > > @@

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
> > -Printing numbers in parentheses (%d) adds no value and should be avoided. > > I wonder how that got there. Well, the only place that numbers "naturally" appear wrapped in parenthesis is tables of credits and debits... as a debit, sort of a literal "add no value" situation. ;) Oh, and for

Re: getting FUSD compiled with current kernels

2007-09-29 Thread Sam Ravnborg
On Sat, Sep 29, 2007 at 06:37:51PM +0200, Florian Schmidt wrote: > On Saturday 29 September 2007, Florian Schmidt wrote: > > On Saturday 29 September 2007, Florian Schmidt wrote: > > > Hi, > > > > > > I'm trying to build FUSD [1] against current kernels [2.6.22]. I get > > > errors [2]: > > > > Oh

Bonnie++ with 1024k stripe SW/RAID5 causes kernel to goto D-state

2007-09-29 Thread Justin Piszcz
Kernel: 2.6.23-rc8 (older kernels do this as well) When running the following command: /usr/bin/time /usr/sbin/bonnie++ -d /x/test -s 16384 -m p34 -n 16:10:16:64 It hangs unless I increase various parameters md/raid such as the stripe_cache_size etc.. # ps auxww | grep D USER PID

Re: [patch 0/2] suspend/resume regression fixes

2007-09-29 Thread Bill Davidsen
Mark Lord wrote: Linus Torvalds wrote: On Sat, 22 Sep 2007, Thomas Gleixner wrote: My final enlightment was, when I removed the ACPI processor module, which controls the lower idle C-states, right before resume; this worked fine all the time even without all the workaround hacks. I really

Re: 2.6.22.6 + oprofile oops

2007-09-29 Thread Sami Farin
On Sat, Sep 22, 2007 at 14:23:35 +0300, Sami Farin wrote: > x86_64 SMP kernel v2.6.22.6 (not using callgraph). > sometimes oprofile works for a longer time... but not this time. > > 2007-09-22 13:53:32.52723 <1>[ 3372.390188] Unable to handle kernel NULL > pointer dereference at

Re: [PATCH RFC] paravirt_ops: refactor struct paravirt_ops into smaller pv_*_ops

2007-09-29 Thread Jeremy Fitzhardinge
Nakajima, Jun wrote: > To me such atomicity is provided by the "sti" instruction (i.e. the > processor begins responding to external, maskable interrupts _after_ the > next instruction is executed), and there is nothing special with that > combination "sti; hlt" (you can also have like "sti; ret",

RE: [PATCH RFC] paravirt_ops: refactor struct paravirt_ops into smaller pv_*_ops

2007-09-29 Thread Nakajima, Jun
Jeremy Fitzhardinge wrote: > Nakajima, Jun wrote: > > Yes. For the native, "safe_halt" is "sti; hlt". The "native_halt" is > > just "hlt". So the para_virt part of "hlt" could be moved to pv_cpu_ops, > > and the "sti" part stays in pv_irq_ops. > > > > By "sti part", you mean the full "sti; hlt"

Re: [patch/backport] CFS scheduler, -v22, for v2.6.23-rc8, v2.6.22.8, v2.6.21.7, v2.6.20.20

2007-09-29 Thread Alejandro Riveira Fernández
El Fri, 28 Sep 2007 23:20:13 -0300 Henrique de Moraes Holschuh <[EMAIL PROTECTED]> escribió: > On Fri, 28 Sep 2007, Alejandro Riveira Fernández wrote: > > I feel it better than 20.5 but the later is more stable. Let me explain. > > > > I patched a 2.6.22.9 kernel with both versions 22 and

Re: getting FUSD compiled with current kernels

2007-09-29 Thread Florian Schmidt
On Saturday 29 September 2007, Florian Schmidt wrote: > On Saturday 29 September 2007, Florian Schmidt wrote: > > Hi, > > > > I'm trying to build FUSD [1] against current kernels [2.6.22]. I get > > errors [2]: > > Oh i forgot to show the code snippets in question. I put them to the Oh and i also

Re: getting FUSD compiled with current kernels

2007-09-29 Thread Florian Schmidt
On Saturday 29 September 2007, Florian Schmidt wrote: > Hi, > > I'm trying to build FUSD [1] against current kernels [2.6.22]. I get errors > [2]: Oh i forgot to show the code snippets in question. I put them to the crresponding error below [matching line number is marked with [*]]: > > [2]

getting FUSD compiled with current kernels

2007-09-29 Thread Florian Schmidt
Hi, I'm trying to build FUSD [1] against current kernels [2.6.22]. I get errors [2]: I tried looking into it but not being a kernel hacker i must admit i didn't even find out where sysfs_dentry is defined (so i can make the type complete). Or whether this would even be the correct way to fix

Re: [rfc][patch] i386: remove comment about barriers

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, Nick Piggin wrote: > > OK this was going to be a quick patch, but after sleeping on it, I think > it deserves a better analysis... I can prove the comment is incorrect with a > test program, but I'm not as sure about my thinking that leads me to call it > also misleading.

Re: [patch] x86: improved memory barrier implementation

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, Nick Piggin wrote: > > > > The non-temporal stores should be basically considered to be "IO", not any > > normal memory operation. > > Maybe you're thinking of uncached / WC? Non-temporal stores to cacheable > RAM apparently can go out of order too, and they are being

Re: [PATCH 1/3] CodingStyle updates

2007-09-29 Thread Scott Preece
A couple of comments interspersed... On 9/28/07, Erez Zadok <[EMAIL PROTECTED]> wrote: ... > There are a number of driver model diagnostic macros in > which you should use to make sure messages are matched to the right device --- I think this "which" is non-restrictive, so it should have a

Re: Strange system hangs

2007-09-29 Thread Krzysztof Oledzki
On Sat, 29 Sep 2007, Nick Piggin wrote: On Friday 28 September 2007 18:42, Krzysztof Oledzki wrote: Hello, I am experiencing weird system hangs. Once about 2-5 weeks system freezes and stops accepting remote connections, so it is no longer possible to connect to most important services:

Re: [PATCH] module: return error when mod_sysfs_init() failed

2007-09-29 Thread Akinobu Mita
2007/9/29, Greg KH <[EMAIL PROTECTED]>: > > Index: 2.6-git/kernel/module.c > > === > > --- 2.6-git.orig/kernel/module.c > > +++ 2.6-git/kernel/module.c > > @@ -1782,7 +1782,8 @@ static struct module *load_module(void _ > >

Re: 2.6.23-rc8-mm2

2007-09-29 Thread Greg KH
On Sat, Sep 29, 2007 at 05:37:29PM +0800, Dave Young wrote: > Hi, > The kernel report warnings about sysfs filename duplicate under > rc8-mm1 and rc8-mm2. > 1. > cut > NET: Registered protocol family 16 > ACPI: bus type pci registered > PCI: PCI BIOS revision 2.10 entry at 0xfb93e, last

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Alexey Starikovskiy
Mark Lord wrote: Wolfgang Erig wrote: On Sat, Sep 29, 2007 at 01:30:33AM -0700, H. Peter Anvin wrote: Wolfgang Erig wrote: Both are bad. Two different systems and two different bisections. I sent the last step of each. $ git bisect good Bisecting: 0 revisions left to test after this

Chroot bug take 3

2007-09-29 Thread David Newall
/. I hope I haven't crossed the line between determined and annoying. I thought we were done, but now I find meat still on this bone. Posit a normal process having some filesystem root, and a current working directory (pwd) lying within that root subtree. When chroot is performed, pwd is

Re: [PATCH 05/12] mm: trylock_page

2007-09-29 Thread Peter Zijlstra
On Fri, 2007-09-28 at 13:11 +1000, Nick Piggin wrote: > On Friday 28 September 2007 17:42, Peter Zijlstra wrote: > > Replace raw TestSetPageLocked() usage with trylock_page() > > I have such a thing queued too, for the lock bitops patches for when 2.6.24 > opens, Andrew promises me :). > > I

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-09-29 Thread Cedric Le Goater
Ilpo Järvinen wrote: > On Fri, 28 Sep 2007, Ilpo Järvinen wrote: >> On Fri, 28 Sep 2007, Cedric Le Goater wrote: >> >>> I just found that warning in my logs. It seems that it's been >>> happening since rc7-mm1 at least. >>> >>> WARNING: at

Re: [PATCH] module: return error when mod_sysfs_init() failed

2007-09-29 Thread Greg KH
On Sat, Sep 29, 2007 at 07:06:53PM +0900, Akinobu Mita wrote: > load_module() returns zero when mod_sysfs_init() fails, > then the module loading will succeed accidentally. > > This patch makes load_module() return error correctly in that case. > > Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]> >

Re: A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?)

2007-09-29 Thread Peter Zijlstra
On Sat, 2007-09-29 at 20:28 +0800, Fengguang Wu wrote: > On Sat, Sep 29, 2007 at 01:48:01PM +0200, Peter Zijlstra wrote: > > On the patch itself, not sure if it would have been enough. As soon as > > there is a single dirty inode on the list one would get caught in the > > same problem as

Re: [PATCH 1/3] CodingStyle updates

2007-09-29 Thread Shawn Bohrer
On Fri, Sep 28, 2007 at 05:32:00PM -0400, Erez Zadok wrote: > 1. Updates chapter 13 (printing kernel messages) to expand on the use of >pr_debug()/pr_info(), what to avoid, and how to hook your debug code with >kernel.h. > > 2. New chapter 19, branch prediction optimizations, discusses

Re: x86-64 sporadic hang in 2.6.23rc7 and 2.6.22

2007-09-29 Thread Helge Hafting
Thomas Gleixner wrote: On Mon, 2007-09-24 at 23:08 +0200, Helge Hafting wrote: The two kernels mentioned hangs occationally. Typically when I compile something and pass the time by surfing the web. A few minutes and then I notice that the mouse (and everything else in X) stops. kbd LEDs

Re: [PATCH] module: return error when mod_sysfs_init() failed

2007-09-29 Thread Rusty Russell
On Sat, 2007-09-29 at 19:06 +0900, Akinobu Mita wrote: > load_module() returns zero when mod_sysfs_init() fails, > then the module loading will succeed accidentally. > > This patch makes load_module() return error correctly in that case. Thanks, applied. Cheers, Rusty. - To unsubscribe from

IT8716F SPI driver submission?

2007-09-29 Thread Carl-Daniel Hailfinger
Hi! I have written a rough code skeleton to be able to use the ITE IT8716F Super I/O chip as SPI host/master. The code works fine in userspace, but the Linux kernel SPI framework looks like it could save me from implementing full support for SPI flash clients/slaves. That's why I'd like to

[rfc][patch] i386: remove comment about barriers

2007-09-29 Thread Nick Piggin
Hi, OK this was going to be a quick patch, but after sleeping on it, I think it deserves a better analysis... I can prove the comment is incorrect with a test program, but I'm not as sure about my thinking that leads me to call it also misleading. The comment being removed by this patch is

  1   2   3   4   >