Re: [RFC] Per-thread getrusage

2008-01-27 Thread Pavel Emelyanov
Andrew Morton wrote: > On Thu, 17 Jan 2008 13:57:05 +0530 Vinay Sridhar <[EMAIL PROTECTED]> > wrote: > >> Hi All, >> >> Last year, there was discussion about per-thread getrusage by adding >> RUSAGE_THREAD flag to getrusage(). Please refer to the thread >>

Re: [PATCH v2 8/9] bfs: remove multiple assignments

2008-01-27 Thread Joel Schopp
-inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; +inode->i_mtime = CURRENT_TIME_SEC; +inode->i_atime = CURRENT_TIME_SEC; +inode->i_ctime = CURRENT_TIME_SEC; multiple assignments like "x = y = z = value;" can potentially (depending on the compiler and arch) be

Re: [PATCH] remove duplicating priority setting in try_to_free_p

2008-01-27 Thread minchan kim
On Jan 28, 2008 2:33 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > > On Sat, 26 Jan 2008 02:29:23 -0500 "minchan kim" <[EMAIL PROTECTED]> wrote: > > > shrink_zones in try_to_free_pages already set zone through > > note_zone_scanning_priority. > > So, setting prev_priority in try_to_free_pages is

Re: [PATCH] Only print kernel debug information for OOMs caused by kernel allocations

2008-01-27 Thread Andi Kleen
On Monday 28 January 2008 06:52, Andrew Morton wrote: > On Wed, 16 Jan 2008 23:24:21 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > > I recently suffered an 20+ minutes oom thrash disk to death and computer > > completely unresponsive situation on my desktop when some user program > > decided to

Re: [patch 24/26] mount options: fix tmpfs

2008-01-27 Thread Hugh Dickins
On Thu, 24 Jan 2008, Miklos Szeredi wrote: > Thanks Miklos, that's a welcome enhancement, nicely done. I've only noticed one thing wrong (MPOL_PREFERRED shown as "default"); but thought shmem_config didn't add much value - I'd rather avoid those syntactic changes to unchanged code; and several

Re: [PATCH] [3/18] BKL-removal: Convert ext3 to use unlocked_ioctl

2008-01-27 Thread Andi Kleen
On Monday 28 January 2008 06:33, Andrew Morton wrote: > On Sun, 27 Jan 2008 03:17:09 +0100 (CET) Andi Kleen <[EMAIL PROTECTED]> wrote: > > I checked ext3_ioctl and it looked largely safe to not be used > > without BKL. So convert it over to unlocked_ioctl. > > > > The only case where I wasn't

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-27 Thread Paul Mundt
On Sun, Jan 27, 2008 at 09:33:23PM -0800, Andrew Morton wrote: > On Fri, 18 Jan 2008 09:56:33 +0900 Paul Mundt <[EMAIL PROTECTED]> wrote: > > > On Thu, Jan 17, 2008 at 10:30:06PM +, Adrian McMenamin wrote: > > > From: Adrian McMenamin <[EMAIL PROTECTED]> > > > > > > This patch adds support

Re: [RFC] Per-thread getrusage

2008-01-27 Thread Andrew Morton
On Thu, 17 Jan 2008 13:57:05 +0530 Vinay Sridhar <[EMAIL PROTECTED]> wrote: > Hi All, > > Last year, there was discussion about per-thread getrusage by adding > RUSAGE_THREAD flag to getrusage(). Please refer to the thread > http://lkml.org/lkml/2007/4/4/308. Ulrich had suggested that

Re: [PATCH] Convert reiserfs_ioctl() to an unlocked_ioctl

2008-01-27 Thread Andrew Morton
I get a massive reject when applying this. As usual. I'm afraid that the days when one could prepare 2.6.x patches against the 2.6.x-1 tree are long past us. Please resend after 2.6.25-rc1 or, better, redo against the most-recently-released -mm kernel or, better, redo against

Re: [PATCH] Only print kernel debug information for OOMs caused by kernel allocations

2008-01-27 Thread Andrew Morton
On Wed, 16 Jan 2008 23:24:21 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > > I recently suffered an 20+ minutes oom thrash disk to death and computer > completely unresponsive situation on my desktop when some user program > decided to grab all memory. It eventually recovered, but left lots > of

(Try#3) [Patch] Shut up warnings from files under drivers/

2008-01-27 Thread WANG Cong
On Sun, Jan 27, 2008 at 10:21:00AM +0100, Sam Ravnborg wrote: >Hi WANG. > >Thanks for chasing these annoying warnings - it is >good to keep the warning level low so we keep >attention when new warnings happens! > >> index d775eb6..eec1624 100644 >> --- a/drivers/video/aty/atyfb_base.c >> +++

Re: [patch] drop linux/ufs_fs.h from userspace export

2008-01-27 Thread Andrew Morton
On Sat, 26 Jan 2008 04:09:52 -0500 Mike Frysinger <[EMAIL PROTECTED]> wrote: > Per previous discussions about cleaning up ufs_fs.h, people just want this > straight up dropped from userspace export. The only remaining consumer (silo) > has been fixed a while ago to not rely on this header. >

Re: [PATCH] [3/18] BKL-removal: Convert ext3 to use unlocked_ioctl

2008-01-27 Thread Andrew Morton
On Sun, 27 Jan 2008 03:17:09 +0100 (CET) Andi Kleen <[EMAIL PROTECTED]> wrote: > > I checked ext3_ioctl and it looked largely safe to not be used > without BKL. So convert it over to unlocked_ioctl. > > The only case where I wasn't quite sure was for the > dynamic fs grow ioctls versus

Re: [PATCH] SH/Dreamcast - add support for GD-Rom CDROM drive on SEGA Dreamcast

2008-01-27 Thread Andrew Morton
On Fri, 18 Jan 2008 09:56:33 +0900 Paul Mundt <[EMAIL PROTECTED]> wrote: > On Thu, Jan 17, 2008 at 10:30:06PM +, Adrian McMenamin wrote: > > From: Adrian McMenamin <[EMAIL PROTECTED]> > > > > This patch adds support for the GD-Rom drive, SEGA's proprietary > > implementation of an IDE CD Rom

Re: [PATCH 1/1] Net: e100, fix iomap mem accesses

2008-01-27 Thread Andrew Morton
On Fri, 18 Jan 2008 14:38:51 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Jiri Slaby wrote: > > readX functions are not permitted on iomap-ped space change to ioreadX, > > also pci_unmap pci_map-ped space on exit (instead of iounmap). > > > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> > >

Re: [PATCH] linux/types.h: always export 64bit aligned defines

2008-01-27 Thread Andrew Morton
On Sat, 26 Jan 2008 04:23:21 -0500 Mike Frysinger <[EMAIL PROTECTED]> wrote: > Some kernel headers exported to userspace rely on these 64bit aligned defines. > However, they are hidden behind __KERNEL_STRICT_NAMES at the moment which > means most of the time, they're never actually available.

Re: [PATCH -mm 2/2] PWM LED driver

2008-01-27 Thread Andrew Morton
On Thu, 24 Jan 2008 15:33:45 +0100 Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > + if (i > 0) { > + for (i = i - 1; i >= 0; i--) { > + led_classdev_unregister([i].cdev); > + pwm_channel_free([i].pwmc); > + } > + } Could

Re: [PATCH] remove duplicating priority setting in try_to_free_p

2008-01-27 Thread Andrew Morton
On Sat, 26 Jan 2008 02:29:23 -0500 "minchan kim" <[EMAIL PROTECTED]> wrote: > shrink_zones in try_to_free_pages already set zone through > note_zone_scanning_priority. > So, setting prev_priority in try_to_free_pages is needless. > > This patch is made by 2.6.24-rc8. > > Signed-off-by: barrios

Re: [PATCH -mm] kprobes: kretprobe user entry-handler (updated)

2008-01-27 Thread Andrew Morton
On Sat, 26 Jan 2008 23:52:48 +0530 Abhishek Sagar <[EMAIL PROTECTED]> wrote: > This is a repost of a patch which was reviewed earlier at: > http://lkml.org/lkml/2007/11/13/58 (thanks to Jim Keniston and Srinivasa for > their review comments). This provides support to add an optional user defined

Re: [patch 00/14] M68k patches for 2.6.25

2008-01-27 Thread Andrew Morton
On Sun, 27 Jan 2008 13:32:16 +0100 Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > Hi Linus, Andrew, > > Here are the m68k patches I had queued up for 2.6.25: > [1] m68k: Use cc-cross-prefix > [2] m68k: ARRAY_SIZE() cleanup > [3] dio: ARRAY_SIZE() cleanup > [4] m68k: Balance

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-27 Thread Matthew Garrett
On Sun, Jan 27, 2008 at 09:10:13PM -0800, Andrew Morton wrote: > You cannot seriously tell me that if we are to change this range from 0-8 > up to 0-100 then this is not a backwards-incompatible change in > semantics. We're talking about changing 0-100 to 0-something sane, because the current

Re: (Updated) [Patch] Shut up warnings from files under drivers/

2008-01-27 Thread WANG Cong
On Sun, Jan 27, 2008 at 10:21:12AM +0100, Jiri Slaby wrote: >On 01/27/2008 10:08 AM, Jiri Slaby wrote: >>On 01/27/2008 05:15 AM, WANG Cong wrote: >>>Fix defined-but-not-used warnings from files under drivers/, >>>such as: >>> >>>drivers/char/applicom.c:68: warning: ‘applicom_pci_tbl’ defined but

Re: [Patch] drivers/base/core.c: fix a compile error

2008-01-27 Thread WANG Cong
> >No, that will fix the build error, but die when linking :( > >I'll work on a real fix for this now... > Sorry. I just compiled it since the building process was stopped by another error. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek

2008-01-27 Thread Andrew Morton
On Mon, 28 Jan 2008 05:38:25 +0100 Andi Kleen <[EMAIL PROTECTED]> wrote: > On Monday 28 January 2008 05:13:09 Trond Myklebust wrote: > > > > On Mon, 2008-01-28 at 03:58 +0100, Andi Kleen wrote: > > > The problem is that it's not a race in who gets to do its thing first, > > > but a > > >

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-27 Thread Andrew Morton
On Mon, 28 Jan 2008 01:25:50 + Matthew Garrett <[EMAIL PROTECTED]> wrote: > On Sat, Jan 26, 2008 at 10:00:45PM -0800, Andrew Morton wrote: > > - Create a new /sys node with a new name which has the new semantics. > > The semantics are the same as they always have been - values between 0 >

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek

2008-01-27 Thread Trond Myklebust
On Mon, 2008-01-28 at 05:38 +0100, Andi Kleen wrote: > On Monday 28 January 2008 05:13:09 Trond Myklebust wrote: > > > > On Mon, 2008-01-28 at 03:58 +0100, Andi Kleen wrote: > > > The problem is that it's not a race in who gets to do its thing first, > > > but a > > > parallel reader can

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek

2008-01-27 Thread Andi Kleen
On Monday 28 January 2008 05:13:09 Trond Myklebust wrote: > > On Mon, 2008-01-28 at 03:58 +0100, Andi Kleen wrote: > > The problem is that it's not a race in who gets to do its thing first, but > > a > > parallel reader can actually see a corrupted value from the two independent > > words on

[PATCH] [CPUISOL] Support for workqueue isolation

2008-01-27 Thread maxk
From: Max Krasnyansky <[EMAIL PROTECTED]> I'm sure this one is going to be controversial for a lot of folks here. So let me explain :). What this patch is trying to address is the case when a high priority realtime (FIFO, RR) user-space thread is using 100% CPU for extended periods of time. In

[PATCH] [CPUISOL] Export CPU isolation bits

2008-01-27 Thread maxk
From: Max Krasnyansky <[EMAIL PROTECTED]> Here we're just exporting CPU isolation bitmap so that it can be used outside the scheduler code. Helper functions like cpu_isolated() are provided for easy access. This is very similar to cpu_online() and friends. The patch also exports 'isolated' bit

[CPUISOL] CPU isolation extensions

2008-01-27 Thread maxk
Following patch series extends CPU isolation support. Yes, most people want to virtuallize CPUs these days and I want to isolate them :). The primary idea here is to be able to use some CPU cores as dedicated engines for running user-space code with minimal kernel overhead/intervention, think

[PATCH] [CPUISOL] Add config options for CPU isolation

2008-01-27 Thread maxk
From: Max Krasnyansky <[EMAIL PROTECTED]> This simply adds a couple of new kconfig options for configuring CPU isolation features. Signed-off-by: Max Krasnyansky <[EMAIL PROTECTED]> --- arch/x86/Kconfig |1 + kernel/Kconfig.cpuisol | 24 2 files changed, 25

[PATCH] [CPUISOL] Isolated CPUs should be ignored by the "stop machine"

2008-01-27 Thread maxk
From: Max Krasnyansky <[EMAIL PROTECTED]> This patch is trying to address the same use case I explained in the previous workqueue isolation patch. Which is when a high priority realtime (FIFO, RR) user-space thread is using 100% CPU for extended periods of time. In which case stopmachine

[PATCH] [CPUISOL] Do not route IRQs to the CPUs isolated at boot

2008-01-27 Thread maxk
From: Max Krasnyansky <[EMAIL PROTECTED]> Most people would expect isolated CPUs to not get any IRQs by default. This happens naturally if CPU is brought off-line, marked isolated and then brought back online. Signed-off-by: Max Krasnyansky <[EMAIL PROTECTED]> ---

Re: [PATCH] Moving spinlock to struct usb_hcd

2008-01-27 Thread Greg KH
On Mon, Jan 28, 2008 at 09:50:36AM +0530, Romit Dasgupta wrote: > Hi, > Should I go ahead and submit the patch with the usual > "signed-off" thingie? Or is it totally useless patch that is going to > be ignored? Let's see some proof that it actually helps, and then we can

Re: [PATCH] Moving spinlock to struct usb_hcd

2008-01-27 Thread Romit Dasgupta
Hi, Should I go ahead and submit the patch with the usual "signed-off" thingie? Or is it totally useless patch that is going to be ignored? Thanks, -Romit On Jan 26, 2008 9:06 PM, Romit Dasgupta <[EMAIL PROTECTED]> wrote: > > > > > > Looking at how this lock is used, contention

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek

2008-01-27 Thread Trond Myklebust
On Mon, 2008-01-28 at 03:58 +0100, Andi Kleen wrote: > The problem is that it's not a race in who gets to do its thing first, but a > parallel reader can actually see a corrupted value from the two independent > words on 32bit (e.g. during a 4GB). And this could actually completely > corrupt

[PATCH] writeback: speed up writeback of big dirty files

2008-01-27 Thread Fengguang Wu
Andrew, I'd suggest it for 2.6.25. It's a safer version of the reverted patch in .24-rc8. It was tested on ext2/ext3/jfs/xfs/reiserfs and won't 100% iowait even without the other bug fixing patches. Fengguang --- writeback: speed up writeback of big dirty files After making dirty a 100M file,

Re: [kvm-devel] [PATCH][RFC] SVM: Add Support for Nested Paging in AMD Fam16 CPUs

2008-01-27 Thread Jeremy Fitzhardinge
Avi Kivity wrote: I find it non-descriptive, and it reminds me of another hypervisor. I suggest 'tlp' for two-level paging. That has its own ambiguity; without other context it reads like "two-level pagetable". Anyway, using the same term for the same thing is not a bad idea. J -- To

Re: Problem with ata layer in 2.6.24

2008-01-27 Thread Kasper Sandberg
On Sun, 2008-01-27 at 21:22 -0500, Gene Heskett wrote: > Greeting; > > None were logged during the time I was running an -rc7 or -rc8. > > The previous hits on this resulted in the udma speed being downgraded > till it was actually running in pio just before the freeze that > required the

Re: [PATCH] [0/18] Implement some low hanging BKL removal fruit in fs/*

2008-01-27 Thread Andi Kleen
> BTW. here is a patch I did a while back for minix. I know it isn't > a big deal, but the work is done so I guess I should send it along. Looks safe, although I'm surprised it actually gets around with such little locking in general. -Andi -- To unsubscribe from this list: send the line

Re: Many processes stuck in blk_congestion_wait

2008-01-27 Thread Fengguang Wu
On Wed, Jan 23, 2008 at 05:19:14PM -0500, Sev Binello wrote: > We are experiencing numerous hangs/slow downs on our WS4 U5 nfs client > machines (not seen on WS3). > Many processes end up in a D state for long periods of time > and are in blk_congestion_wait(). > > Time in this state can vary,

Re: nfs server patches for 2.6.25

2008-01-27 Thread J. Bruce Fields
On Sun, Jan 27, 2008 at 05:10:17PM -0500, bfields wrote: > OK. I've got a machine running > > for c in $(git rev-list origin..linux-nfs/nfs-server-stable^); do > git checkout $c > make -s -j4 > done > > now just to make sure Thanks again! Pfft, that

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek

2008-01-27 Thread Andi Kleen
On Monday 28 January 2008 00:08:56 Trond Myklebust wrote: > > On Sun, 2008-01-27 at 16:18 -0600, Steve French wrote: > > If two seeks overlap, can't you end up with an f_pos value that is > > different than what either thread seeked to? or if you have a seek and > > a read overlap can't you end

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek

2008-01-27 Thread Andi Kleen
On Sunday 27 January 2008 23:18:26 Steve French wrote: > If two seeks overlap, can't you end up with an f_pos value that is > different than what either thread seeked to? Yes you can on 32bit. Especially during the 4GB wrap -Andi -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek

2008-01-27 Thread Andi Kleen
On Sunday 27 January 2008 17:57:14 Steve French wrote: > Don't you need to a spinlock/spinunlock(i_lock) or something similar > (there isn't a spinlock in the file struct unfortunately) around the > reads and writes from f_pos in fs/read_write.c in remote_llseek with > your patch since the

Re: Troubles waking up from suspend (S3) - how to debug?

2008-01-27 Thread R. J. Wysocki
On Sunday, 27 of January 2008, Bruno Prémont wrote: > I'm currently trying out suspend (S3) on a few machines but none of them > wakes > up completely/properly (I have a few more hosts I'm planning to try suspend > on once I can get useful information out of those not waking up properly). > >

Re: 2.6.24-rc7-rt2

2008-01-27 Thread Stefan Monnier
> For me, on the other hand, it is against the spirit of free software to > actively make a block for people to do what ever they want with the code > when they are only doing it to themselves. That includes loading non-GPL > software into the kernel. The only thing they are not allowed to do is

[PATCH] x86_64: not set boot cpu in cpu_online_map at smp_prepare_boot_cpu

2008-01-27 Thread Yinghai Lu
[PATCH] x86_64: not set boot cpu in cpu_online_map at smp_prepare_boot_cpu in init/main.c boot_cpu_init() does that before Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> Index: linux-2.6/arch/x86/kernel/smpboot_64.c === ---

Problem with ata layer in 2.6.24

2008-01-27 Thread Gene Heskett
Greeting; I had to reboot early this morning due to a freezeup, and I had a bunch of these in the messages log: == Jan 27 19:42:11 coyote kernel: [42461.915961] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen Jan 27 19:42:11 coyote kernel: [42461.915973] ata1.00:

[PATCH] x86_64: not set boot cpu in cpu_present_map again

2008-01-27 Thread Yinghai Lu
[PATCH] x86_64: not set boot cpu in cpu_present_map again in init/main.c boot_cpu_init() already does that before setup_arch Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> Index: linux-2.6/arch/x86/kernel/setup_64.c === ---

Re: High wake up latencies with FAIR_USER_SCHED

2008-01-27 Thread Srivatsa Vaddagiri
On Sun, Jan 27, 2008 at 09:01:15PM +0100, Guillaume Chazarain wrote: > I noticed some strangely high wake up latencies with FAIR_USER_SCHED > using this script: > We have two busy loops with UID=1. > And UID=2 maintains the running median of its wake up latency. > I get these latencies: > > #

Re: [PATCH] [0/18] Implement some low hanging BKL removal fruit in fs/*

2008-01-27 Thread Nick Piggin
On Sunday 27 January 2008 13:17, Andi Kleen wrote: > [Andrew: I believe this is -mm material for .25] > > - Convert some more file systems (generally those who don't use the BKL > for anything except mount) to use unlocked_bkl. > - Implement BKL less fasync (see patch for the rationale) > This is

NFS EINVAL with O_TRUNC

2008-01-27 Thread Martin Waitz
hoi :) I bisected the kernel to find out why cfs stopped working. (open with O_TRUNC returning EINVAL when file already exists on an cfs file system.) First I tried to debug cfs itself, and after reading Gianlucas thread on lkml I then looked at the kernel itself.

Re: [PATCH 3/9] x86_64: Switch to .data.compressed in arch/x86/boot/compressed/vmlinux_64.scr

2008-01-27 Thread H. Peter Anvin
Yinghai Lu wrote: payload.compressed ? We can call it .payload, or just .rodata.compressed. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: 2.6.24 regression: pan hanging unkilleable and un-straceable

2008-01-27 Thread Nick Piggin
On Sunday 27 January 2008 01:27, Pascal Terjan wrote: > Nick Piggin yahoo.com.au> writes: > > On Sunday 27 January 2008 00:29, Frederik Himpe wrote: > > > I just succeeded to reproduce the problem with this patch. Does this > > > smell like an XFS problem? > > I got the same issue using ext3 > >

Re: [PATCH 3/9] x86_64: Switch to .data.compressed in arch/x86/boot/compressed/vmlinux_64.scr

2008-01-27 Thread Yinghai Lu
On Jan 27, 2008 4:33 PM, H. Peter Anvin <[EMAIL PROTECTED]> wrote: > > Yinghai Lu wrote: > > On Jan 27, 2008 2:04 PM, Ian Campbell <[EMAIL PROTECTED]> wrote: > >> On Sat, 2008-01-26 at 16:59 -0800, Yinghai Lu wrote: > >> > >>> can you make 32 bit use .text.compressed instead ? > >> Any reason to

Re: [RFC] some page can't be migrated

2008-01-27 Thread Shaohua Li
On Mon, 2008-01-28 at 12:43 +1100, Nick Piggin wrote: > On Sunday 27 January 2008 17:03, Andrew Morton wrote: > > > On Fri, 25 Jan 2008 14:03:25 +0800 Shaohua Li <[EMAIL PROTECTED]> > > > wrote: > > > > > > - if (!page->mapping) > > > + if (!page->mapping) { > > > + if (!PageAnon(page) &&

Re: 2.6.24 regression: pan hanging unkilleable and un-straceable

2008-01-27 Thread Nick Piggin
On Sunday 27 January 2008 00:29, Frederik Himpe wrote: > On di, 2008-01-22 at 16:25 +1100, Nick Piggin wrote: > > > > On Tuesday 22 January 2008 07:58, Frederik Himpe wrote: > > > > > With Linux 2.6.24-rc8 I often have the problem that the pan usenet > > > > > reader starts using 100% of CPU time

Re: [RFC] some page can't be migrated

2008-01-27 Thread Nick Piggin
On Sunday 27 January 2008 17:03, Andrew Morton wrote: > > On Fri, 25 Jan 2008 14:03:25 +0800 Shaohua Li <[EMAIL PROTECTED]> > > wrote: > > > > - if (!page->mapping) > > + if (!page->mapping) { > > + if (!PageAnon(page) && PagePrivate(page)) > > +

Re: [Regression] 2.6.24-git3: Major annoyance during suspend/hibernation on x86-64 (bisected)

2008-01-27 Thread Steven Rostedt
Rafael J. Wysocki wrote: No, this isn't the WARN_ON(). this does have the feel of being scheduling related, but are you absolutely sure about the precise identity of the patch? Actually, not quite. That's why I have verified it and found that another patch is really responsible for the

Re: [Regression] 2.6.24-git3: Major annoyance during suspend/hibernation on x86-64 (bisected)

2008-01-27 Thread Rafael J. Wysocki
On Sunday, 27 of January 2008, Ingo Molnar wrote: > > * Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > 2.6.24-git3 adds a 5 - 10 sec delay to the suspend and hibernation > > code paths (probably related to the disabling of nonboot CPUs), which > > is [EMAIL PROTECTED]&*()

Re: [PATCH] Rationalise ACPI backlight implementation

2008-01-27 Thread Matthew Garrett
On Sat, Jan 26, 2008 at 10:00:45PM -0800, Andrew Morton wrote: > - Create a new /sys node with a new name which has the new semantics. The semantics are the same as they always have been - values between 0 and max_brightness are valid values. If you've made assumptions about what max_brightness

Re: a7839e96 (PNP: increase max resources) breaks my ALSA intel8x0 sound card

2008-01-27 Thread Shaohua Li
On Mon, 2008-01-28 at 08:50 +1100, Linus Torvalds wrote: > > On Sun, 27 Jan 2008, Avuton Olrich wrote: > > > > With v2.6.24 my second ALSA sound device stopped working. > > Hmm. Why is PnP ACPI called before PCI probing? That seems to be the > problem here - we should *never* have any firmware

[PATCH 2/2] aio: -EINVAL on negative read/write offset

2008-01-27 Thread Rusty Russell
An AIO read or write should return -EINVAL if the offset is negative. This check matches the one in pread and pwrite. This was found by the libaio test suite. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> --- fs/aio.c |4 1 file changed, 4 insertions(+) diff -r 18802689361a

[PATCH 1/2] aio: partial write return

2008-01-27 Thread Rusty Russell
When an AIO write gets a non-retry error after writing some data (eg. ENOSPC), it should return the amount written already, not the error. Just like write() is supposed to. This was found by the libaio test suite. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> Acked-By: Zach Brown <[EMAIL

Re: [PATCH] CRAMFS: Uncompressed files support

2008-01-27 Thread Kyungmin Park
> > This patch enables the uncompressed files support in cramfs. > > > > The word 'uncompressed file' is from linear cramfs (aka Application XIP). > > In linear cramfs, it is used to suport XIP on NOR. However it is also > > helpful on OneNAND. It makes a filesystem faster by removing compression

Re: Troubles waking up from suspend (S3) - how to debug?

2008-01-27 Thread Tino Keitel
On Sun, Jan 27, 2008 at 18:42:37 +0100, Bruno Prémont wrote: > I'm currently trying out suspend (S3) on a few machines but none of them > wakes > up completely/properly (I have a few more hosts I'm planning to try suspend > on once I can get useful information out of those not waking up

Re: 2.6.25 regression: VIDEO_DEV=y/m, I2C=n compile error

2008-01-27 Thread Mauro Carvalho Chehab
Hi Adrian and Marcin, On Sun, 27 Jan 2008 20:52:16 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > Commit 8ffbc6559493c64d6194c92d856196fdaeb8a5fb causes the following > compile error with CONFIG_VIDEO_DEV=y/m, CONFIG_I2C=n: > > <-- snip --> > > ... > MODPOST 26 modules > ERROR:

Re: [PATCH 3/9] x86_64: Switch to .data.compressed in arch/x86/boot/compressed/vmlinux_64.scr

2008-01-27 Thread H. Peter Anvin
Yinghai Lu wrote: On Jan 27, 2008 2:04 PM, Ian Campbell <[EMAIL PROTECTED]> wrote: On Sat, 2008-01-26 at 16:59 -0800, Yinghai Lu wrote: can you make 32 bit use .text.compressed instead ? Any reason to prefer .text? It is data at this stage after all. it is comressed text insead of

2.6.24 regression: Wake On Lan in sky2 broken on Mac mini

2008-01-27 Thread Tino Keitel
Hi folks, with 2.6.24-rc8, Wake On LAN doesn't work anymore as it used to with 2.6.23 on my Mac mini Core Duo. I saw that this was reported in http://bugzilla.kernel.org/show_bug.cgi?id=9721 and on netdev a patch for the sky2 driver was sent by Stephen Hemminger. This patch fixed WOL for me after

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Dmitri Vorobiev
Paolo Ciarrocchi пишет: > On Jan 27, 2008 11:48 PM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote: >> On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: ... > > How should I compare the .o file? > Simply doing a md5sum or should I do a objdump -d before? > Or a strip? > Comparing the

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Paolo Ciarrocchi
On Jan 27, 2008 11:48 PM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote: > > On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > * Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: > > > > > Looks like it would be better to proceed in the following manner: > > > > > > 1) remove dead

Re: preemptible RCU bug (was Re: [git pull] scheduler changes for v2.6.25)

2008-01-27 Thread Paul E. McKenney
On Sun, Jan 27, 2008 at 01:26:02PM +0100, Ingo Molnar wrote: > > * Paul E. McKenney <[EMAIL PROTECTED]> wrote: > > > > Sorry, no help available for this option yet. > > > > Good catch!!! > > > > This patch supplies help text for the "RCU implementation type" kernel > > configuration choice. >

[PATCH 5/5] PPC: Fix powerpc vio_find_name to not use devices_subsys

2008-01-27 Thread Greg Kroah-Hartman
From: Paul Mackerras <[EMAIL PROTECTED]> This fixes vio_find_name() in arch/powerpc/kernel/vio.c, which is currently broken because it tries to use devices_subsys. That is bad for two reasons: (1) it's doing (or trying to do) a scan of all devices when it should only be scanning those on the vio

[PATCH 3/5] Module: check to see if we have a built in module with the same name

2008-01-27 Thread Greg Kroah-Hartman
When trying to load a module with the same name as a built-in one, a scary kobject backtrace comes up. Prevent that from checking for this condition and warning the user as to what exactly is going on. Cc: Rusty Russell <[EMAIL PROTECTED]> Cc: Linus Torvalds <[EMAIL PROTECTED]> Cc: Andrew Morton

[PATCH 4/5] Driver core: add bus_find_device_by_name function

2008-01-27 Thread Greg Kroah-Hartman
The driver core, and some other parts of the kernel just want to find a device based on a name for a specific bus. Give them a simple wrapper to prevent them from having to always roll their own. This will be used in the PPC patch later in this series. Cc: Paul Mackerras <[EMAIL PROTECTED]>

[PATCH 2/5] x86: fix runtime error in arch/x86/kernel/cpu/mcheck/mce_amd_64.c

2008-01-27 Thread Greg Kroah-Hartman
This problem is due to the kobject rework recently done in this file. The mce_amd_64.c code uses some wierd forward calls to back out of the recursive way the code creates kobjects. Because of this, we need to verify that we have really created a kobject before calling kobject_uevent(). Many

[GIT PATCH] driver core fixes against 2.6.24

2008-01-27 Thread Greg KH
Here's 5 patches against your current git tree that fix all of the reported breakages due to the driver core patch merge. They fix the following issues: - build breakage with CONFIG_BLOCK=n - strange traceback messages when loading a module that is already built into the kernel. - ppc

[PATCH 1/5] Driver core: Fix up build when CONFIG_BLOCK=N

2008-01-27 Thread Greg Kroah-Hartman
This fixes up the driver core build errors when CONFIG_BLOCK=N Thanks to Alexander van Heukelum <[EMAIL PROTECTED]> for the basis of this patch, and to Jeremy Fitzhardinge <[EMAIL PROTECTED]> for reporting the problem. Cc: Alexander van Heukelum <[EMAIL PROTECTED]> Cc: Jeremy Fitzhardinge

Re: [PATCH 3/9] x86_64: Switch to .data.compressed in arch/x86/boot/compressed/vmlinux_64.scr

2008-01-27 Thread Yinghai Lu
On Jan 27, 2008 2:04 PM, Ian Campbell <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-01-26 at 16:59 -0800, Yinghai Lu wrote: > > > can you make 32 bit use .text.compressed instead ? > > Any reason to prefer .text? It is data at this stage after all. > it is comressed text insead of compressed data.

Re: X fails to start with latest Linus git

2008-01-27 Thread Kevin Winchester
On Sun, 27 Jan 2008 13:42:44 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > hm, perhaps it's due to the xtime lock dependency: > > > > do { > > seq = read_seqbegin(_lock); > > getnstimeofday(ts); > >

cups slow on linux-2.6.24

2008-01-27 Thread Jeff Chua
I'm sending printing jobs to a network printer (it's actually printing to the localhost simply creating a file), and running this on Linux-2.6.24 will cause the printing to slow down to 1 print every 3 seconds after printing 500 times. No such symptoms on 2.6.23.12, or 2.6.20.21. It's

Re: X fails to start with latest Linus git

2008-01-27 Thread Kevin Winchester
On Sun, 27 Jan 2008 13:42:44 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > hm, perhaps it's due to the xtime lock dependency: > > > > do { > > seq = read_seqbegin(_lock); > > getnstimeofday(ts); > >

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek

2008-01-27 Thread Trond Myklebust
On Sun, 2008-01-27 at 16:18 -0600, Steve French wrote: > If two seeks overlap, can't you end up with an f_pos value that is > different than what either thread seeked to? or if you have a seek and > a read overlap can't you end up with the read occurring in the midst > of an update of f_pos

Re: X fails to start with latest Linus git

2008-01-27 Thread Kevin Winchester
On Sun, 27 Jan 2008 13:37:02 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Kevin Winchester <[EMAIL PROTECTED]> wrote: > > > Sure, the result of the script is at > > > > http://personal.nbnet.nb.ca/kwin/cfs-debug-info-2008.01.27-08.13.28 > > it seems you've got hpet active by default: >

Re: X fails to start with latest Linus git

2008-01-27 Thread Kevin Winchester
On Sun, 27 Jan 2008 13:35:14 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Kevin Winchester <[EMAIL PROTECTED]> wrote: > > > although it is not complete. For some reason (xubuntu, probably) dash > > is my default shell and it does not like the for loop at line 69 of > > that script: > >

Re: [PATCH] [10/18] BKL-removal: Implement a compat_ioctl handler for JFS

2008-01-27 Thread Dave Kleikamp
On Sun, 2008-01-27 at 03:17 +0100, Andi Kleen wrote: > The ioctls were already compatible except for the actual values so this > was fairly easy to do. > > Cc: [EMAIL PROTECTED] > > Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> Added to the jfs git tree. Thanks, Shaggy -- David Kleikamp IBM

Re: [PATCH] [9/18] BKL-removal: Use unlocked_ioctl for jfs

2008-01-27 Thread Dave Kleikamp
On Sun, 2008-01-27 at 03:17 +0100, Andi Kleen wrote: > Convert jfs_ioctl over to not use the BKL. The only potential race > I could see was with two ioctls in parallel changing the flags > and losing the updates. Use the i_mutex to protect against this. > > Cc: [EMAIL PROTECTED] > >

Re: [PATCH 3/9] x86_64: Switch to .data.compressed in arch/x86/boot/compressed/vmlinux_64.scr

2008-01-27 Thread H. Peter Anvin
Ian Campbell wrote: On Sat, 2008-01-26 at 16:59 -0800, Yinghai Lu wrote: can you make 32 bit use .text.compressed instead ? Any reason to prefer .text? It is data at this stage after all. Technically, it's .rodata... -hpa -- To unsubscribe from this list: send the line

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Paolo Ciarrocchi
On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > > * Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: > > > Looks like it would be better to proceed in the following manner: > > > > 1) remove dead code (no md5 change); > > 2) reformat the lines to use tabs, not spaces (no md5 change);

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Ingo Molnar
* Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: > Looks like it would be better to proceed in the following manner: > > 1) remove dead code (no md5 change); > 2) reformat the lines to use tabs, not spaces (no md5 change); > 3) address the "else-braces" and "single statement block" errors >(no

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Paolo Ciarrocchi
On Jan 27, 2008 11:32 PM, Dmitri Vorobiev <[EMAIL PROTECTED]> wrote: [..] > > Is there any point in changing code inside the #if 0/#endif block? Just to avoid checkpatch complaints :-) > > @@ -76,10 +74,10 @@ void Un_impl(void) > > /* > > Called for opcodes which are illegal and which are

Re: Question about DMA

2008-01-27 Thread Jiri Slaby
On 01/27/2008 09:51 PM, Francis Moreau wrote: Hello, I have 2 questions regarding set_dma_addr(unsigned int channel, unsigned int addr) helper. 1/ Why does the function take only one address ? I would expect it to take both a source and a destination address for the dma controller to transfer

Re: [PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Dmitri Vorobiev
Paolo Ciarrocchi пишет: > This file has not been modified since October so should be > easy to integrate the following patch. > > Before: > total: 214 errors, 28 warnings, 739 lines checked > > After: > total: 4 errors, 28 warnings, 708 lines checked > > Compile tested: > > [EMAIL

Re: (ondemand) CPU governor regression between 2.6.23 and 2.6.24

2008-01-27 Thread Ingo Molnar
* Peter Zijlstra <[EMAIL PROTECTED]> wrote: > On Sun, 2008-01-27 at 17:57 +0100, Toralf Förster wrote: > > > It would be nice to run a grid application at lowest priority > > without impact to power / fan / temperature but OTOH have full > > performance for desktop applications, isn't it ? >

Re: CONFIG_ROMFS_FS

2008-01-27 Thread Jan Engelhardt
On Jan 27 2008 23:23, Thanasis wrote: > >Q: Do I need CONFIG_ROMFS_FS=y in order to use an initrd image to boot? > A: Only if your initrd is romfs. Which is usually not the case in this decade, much less this year. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: "sched: add vslice" causes horrible interactivity under load

2008-01-27 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > while such delays are happening? Please enable CONFIG_SCHED_DEBUG=y > > and CONFIG_SCHEDSTATS=y as well before doing the dump. Also please > > send your .config. > > another thing that might make a difference is to disable (or enable) > the

Re: [PATCH] [8/18] BKL-removal: Remove BKL from remote_llseek

2008-01-27 Thread Steve French
If two seeks overlap, can't you end up with an f_pos value that is different than what either thread seeked to? or if you have a seek and a read overlap can't you end up with the read occurring in the midst of an update of f_pos (which takes more than one instruction on various architectures),

Re: "sched: add vslice" causes horrible interactivity under load

2008-01-27 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > while such delays are happening? Please enable CONFIG_SCHED_DEBUG=y > and CONFIG_SCHEDSTATS=y as well before doing the dump. Also please > send your .config. another thing that might make a difference is to disable (or enable) the

[PATCH] X86: coding style fixes to arch/x86/math-errors.c - take 2

2008-01-27 Thread Paolo Ciarrocchi
This file has not been modified since October so should be easy to integrate the following patch. Before: total: 214 errors, 28 warnings, 739 lines checked After: total: 4 errors, 28 warnings, 708 lines checked Compile tested: [EMAIL PROTECTED]:/tmp$ size error.o.* textdata bss

  1   2   3   4   5   6   >