Re: [PATCH] cpuset: sparse warnings in cpuset.c

2008-02-02 Thread Paul Jackson
Harvey wrote: > Don't redeclare p, use a new variable q. You dah man! Thanks. Acked-by: Paul Jackson <[EMAIL PROTECTED]> -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <[EMAIL PROTECTED]> 1.940.382.4214

Re: [PATCH] Fix ext4 bitops

2008-02-02 Thread Benjamin Herrenschmidt
On Fri, 2008-02-01 at 21:02 +0100, Bastian Blank wrote: > Fix ext4 bitops. Please provide a better description, as it's not obvious at first sight. > Signed-off-by: Bastian Blank <[EMAIL PROTECTED]> > > diff --git a/include/asm-powerpc/bitops.h b/include/asm-powerpc/bitops.h > index

Re: Integrating cpusets and cpu isolation [was Re: [CPUISOL] CPU isolation extensions]

2008-02-02 Thread Paul Jackson
Max wrote: > Paul, I actually mentioned at the beginning of my email that I did read that > thread > started by Peter. I did learn quite a bit from it :) Ah - sorry - I missed that part. However, I'm still getting the feeling that there were some key points in that thread that we have not

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread Sam Ravnborg
> --- g26.orig/drivers/char/Kconfig > +++ g26/drivers/char/Kconfig > @@ -715,9 +715,12 @@ config NVRAM > To compile this driver as a module, choose M here: the > module will be called nvram. > > +comment "You are using the RTC framework, not the legacy CMOS RTC driver" > +

Re: [PATCH] cpuset: sparse warnings in cpuset.c

2008-02-02 Thread Harvey Harrison
Don't redeclare p, use a new variable q. kernel/cpuset.c:824:23: warning: symbol 'p' shadows an earlier one kernel/cpuset.c:746:21: originally declared here kernel/cpuset.c:1272:52: warning: Using plain integer as NULL pointer Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Paul, used a

[PATCH] x86: fix compile warning building without CONFIG_SYSCTL

2008-02-02 Thread Li Zefan
building without CONFIG_SYSCTL: arch/x86/kernel/nmi_64.c:50: warning: 'unknown_nmi_panic_callback' declared 'static' but never defined This patch also fixes nmi_32.c Signed-off-by: Li Zefan <[EMAIL PROTECTED]> --- arch/x86/kernel/nmi_32.c | 21 +

Re: [patch] scsi: fix spurious build failures in aic7xxx

2008-02-02 Thread Sam Ravnborg
On Sun, Feb 03, 2008 at 05:54:41AM +0100, Ingo Molnar wrote: > > * Ingo Molnar <[EMAIL PROTECTED]> wrote: > > > > I could not reproduce the bug myself but I think I spotted it. We > > > had a missing dependency to the _reg.h file. Try following patch and > > > let me now if it continue to

Re: [PATCH] x86: fix compile waring building without CONFIG_SYSCTL

2008-02-02 Thread Li Zefan
Ingo Molnar wrote: > * Li Zefan <[EMAIL PROTECTED]> wrote: > >> +#ifdef CONFIG_SYSCTL >> static int unknown_nmi_panic_callback(struct pt_regs *regs, int cpu); >> +#endif > > instead of adding another #ifdef, a much cleaner solution would be to > just reorder do_nmi_callback() with

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread David Brownell
On Saturday 02 February 2008, Ingo Molnar wrote: > randconfig testing found the following build failure: > > kernel/built-in.o: In function `be_sleepy': > sleepy.c:(.init.text+0x1952): undefined reference to `rtc_class' > sleepy.c:(.init.text+0x1963): undefined reference to `rtc_class_open'

Re: [PATCH] Change pci_raw_ops to pci_raw_read/write

2008-02-02 Thread Yinghai Lu
On Jan 28, 2008 7:03 PM, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > We want to allow different implementations of pci_raw_ops for standard > and extended config space on x86. Rather than clutter generic code with > knowledge of this, we make pci_raw_ops private to x86 and use it to > implement

Re: [PATCH] cpuset: sparse warnings in cpuset.c

2008-02-02 Thread Paul Jackson
Harvey wrote: > No need to redeclare p, we have finished with it at this point, > so reuse it in the for loop. Good catch, however I disagree with the fix. It makes the code more brittle. It's not a good idea to reuse a variable for some other purpose just because you "know" the original use is

Re: [RFC PATCH v2] x86: mmiotrace - trace memory mapped IO

2008-02-02 Thread Pekka Paalanen
On Thu, 31 Jan 2008 08:29:06 -0800 Arjan van de Ven <[EMAIL PROTECTED]> wrote: > On Thu, 31 Jan 2008 18:16:30 +0200 > Pekka Paalanen <[EMAIL PROTECTED]> wrote: > > > And here's mmiotrace. This works for me (amd64), but not for a test > > user who has 32-bit x86. We have not had the chance to

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread David Brownell
On Saturday 02 February 2008, Ingo Molnar wrote: > > [   23.509562] Calling initcall 0xc0c49e00: be_sleepy+0x0/0x170() > > [   23.515837] PM: no wakelarm-capable RTC > > [   23.517562] initcall 0xc0c49e00: be_sleepy+0x0/0x170() returned 0. Because CONFIG_RTC_DRV_CMOS was not configured, though

Re: [PATCH] x86: fix compile waring building without CONFIG_SYSCTL

2008-02-02 Thread Ingo Molnar
* Li Zefan <[EMAIL PROTECTED]> wrote: > +#ifdef CONFIG_SYSCTL > static int unknown_nmi_panic_callback(struct pt_regs *regs, int cpu); > +#endif instead of adding another #ifdef, a much cleaner solution would be to just reorder do_nmi_callback() with unknown_nmi_panic_callback(), and

Re: [PATCH v2] x86: Add a list for custom page fault handlers.

2008-02-02 Thread Ingo Molnar
* Pekka Paalanen <[EMAIL PROTECTED]> wrote: > I have two reasons why I'd like to let it be a module: > - it's "broken", the relay buffers are cleared on module unload > - it's a lot easier to push updated version for testing to people > > Ok, the first one is just a silly excuse, but the second

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread Ingo Molnar
randconfig testing found the following build failure: kernel/built-in.o: In function `be_sleepy': sleepy.c:(.init.text+0x1952): undefined reference to `rtc_class' sleepy.c:(.init.text+0x1963): undefined reference to `rtc_class_open' config attached. Ingo # # Automatically generated

Re: [PATCH v2] x86: Add a list for custom page fault handlers.

2008-02-02 Thread Pekka Paalanen
On Thu, 31 Jan 2008 08:15:07 -0800 Arjan van de Ven <[EMAIL PROTECTED]> wrote: > On Thu, 31 Jan 2008 18:02:53 +0200 > Pekka Paalanen <[EMAIL PROTECTED]> wrote: > > > > Very well, first the revised custom page fault handler patch. > > Changes since the previous submit: > > - use spin_lock_irqsave

Re: [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables.

2008-02-02 Thread Ingo Molnar
* Andrew Morton <[EMAIL PROTECTED]> wrote: > > It's a sane patch and a helps going further, and a total pain to > > re-do later on. Besides, I may have some use for it on powerpc at > > some point too... > > OK, I'll try to reestablish it. > > Look: I can't fix *everyone's* stuff. This was

[PATCH try#2] [MTD/MAPS] Blackfin BF5xx Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank

2008-02-02 Thread Bryan Wu
>From 974192a0bf168e84370377b835a2858948789088 Mon Sep 17 00:00:00 2001 From: Bryan Wu <[EMAIL PROTECTED]> Date: Sun, 3 Feb 2008 14:27:09 +0800 Subject: [PATCH] [MTD/MAPS] Blackfin BF5xx Maps: Handle the case where flash memory and ethernet mac/phy are mapped onto the same async bank [try #1]

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Gene Heskett
On Sunday 03 February 2008, Ingo Molnar wrote: >* Gene Heskett <[EMAIL PROTECTED]> wrote: >> I believe its the same, but lemme paste it for sure, yes: >> [ 26.339926] ENABLING IO-APIC IRQs >> [ 26.340119] ..TIMER: vector=0x31 apic1=0 pin1=0 apic2=-1 pin2=-1 >> [ 26.350129] ..MP-BIOS bug:

Re: [PATCH] per-process securebits

2008-02-02 Thread Ismail Dönmez
At Sunday 03 February 2008 around 08:18:12 Andrew Morton wrote: > So how do we ever get to the stage where we can recommend that distributors > turn these things on, and have them agree with us? FWIW with my distributor hat on I think File system capabilities are very nice and enables one to

Re: [PATCH] mxser: fix compile warning building without CONFIG_PCI

2008-02-02 Thread Li Zefan
Jiri Slaby wrote: > On 02/03/2008 03:59 AM, Li Zefan wrote: >> When build without CONFIG_PIC, got the following warnings: >> >> drivers/char/mxser.c: In function 'mxser_init': >> drivers/char/mxser.c:698: warning: unused variable 'devnum' >> drivers/char/mxser.c:698: warning: unused variable

[PATCH] x86: fix compile waring building without CONFIG_SYSCTL

2008-02-02 Thread Li Zefan
building without CONFIG_SYSCTL: arch/x86/kernel/nmi_64.c:50: warning: 'unknown_nmi_panic_callback' declared 'static' but never defined This patch also fixes nmi_32.c Signed-off-by: Li Zefan <[EMAIL PROTECTED]> --- arch/x86/kernel/nmi_32.c |3 ++- arch/x86/kernel/nmi_64.c |3 ++- 2

[PATCH] cpuset: sparse warnings in cpuset.c

2008-02-02 Thread Harvey Harrison
No need to redeclare p, we have finished with it at this point, so reuse it in the for loop. kernel/cpuset.c:824:23: warning: symbol 'p' shadows an earlier one kernel/cpuset.c:746:21: originally declared here kernel/cpuset.c:1272:52: warning: Using plain integer as NULL pointer Signed-off-by:

Re: [PATCH] per-process securebits

2008-02-02 Thread Andrew Morton
On Sat, 02 Feb 2008 22:01:51 -0800 "Andrew G. Morgan" <[EMAIL PROTECTED]> wrote: > Here is the very very long version (which took some time to write, and I > thought was a bit much to spam these lists with): > > http://userweb.kernel.org/~morgan/sendmail-capabilities-war-story.html Thanks.

Re: [PATCH] mxser: fix compile warning building without CONFIG_PCI

2008-02-02 Thread Jiri Slaby
On 02/03/2008 03:59 AM, Li Zefan wrote: When build without CONFIG_PIC, got the following warnings: drivers/char/mxser.c: In function 'mxser_init': drivers/char/mxser.c:698: warning: unused variable 'devnum' drivers/char/mxser.c:698: warning: unused variable 'busnum' drivers/char/mxser.c:697:

[PATCH] pcie AER: don't check _OSC when acpi is disabled

2008-02-02 Thread Yinghai Lu
[PATCH] pcie AER: don't check _OSC when acpi is disabled when acpi=off or pci=noacpi, get warning AER service couldn't init device :00:0a.0:pcie01 - no _OSC support AER service couldn't init device :00:0e.0:pcie01 - no _OSC support AER service couldn't init device :00:0f.0:pcie01 -

Re: [PATCH] request_irq() always returns -EINVAL with a NULL handler.

2008-02-02 Thread Andrew Morton
On Thu, 17 Jan 2008 17:57:58 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote: > I assume that these ancient network drivers were trying to find out if > an irq is available. eepro.c expecting +EBUSY was doubly wrong. > > I'm not sure that can_request_irq() is the right thing, but these drivers >

[PATCH try#2 ] kbuild: add svn revision information to setlocalversion

2008-02-02 Thread Bryan Wu
>From 0a7a2c6f19d32a85ca1a7887382325170ef19a66 Mon Sep 17 00:00:00 2001 From: Bryan Wu <[EMAIL PROTECTED]> Date: Sun, 3 Feb 2008 14:05:00 +0800 Subject: [PATCH] [Scripts] add svn revision information to setlocalversion follow git and mercurial style, include uncommitted changes detect Cc: Frans

Re: [PATCH] per-process securebits

2008-02-02 Thread Andrew G. Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [EMAIL PROTECTED] wrote: | Quoting Andrew G. Morgan ([EMAIL PROTECTED]): |> -BEGIN PGP SIGNED MESSAGE- |> Hash: SHA1 |> |> Here is the patch to add per-process securebits. |> |> Its all code that lives inside the capability LSM and the new

Re: [PATCH] Allow NBD to be used locally

2008-02-02 Thread Kyle Moffett
Whoops, only hit "Reply" on the first email, sorry Jan. On Feb 2, 2008 7:54 PM, Jan Engelhardt <[EMAIL PROTECTED]> wrote: > On Feb 2 2008 18:31, [EMAIL PROTECTED] wrote: > > > >> How will that work? Fuse makes up a filesystem - not helpful > >> if you have a raw disk without a known fs to mount.

Re: [PATCH] per-process securebits

2008-02-02 Thread Andrew G. Morgan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Andrew Morton wrote: | On Fri, 01 Feb 2008 00:11:37 -0800 "Andrew G. Morgan" <[EMAIL PROTECTED]> wrote: | |> [This patch represents a no-op unless CONFIG_SECURITY_FILE_CAPABILITIES |> is enabled at configure time.] | | Patches like this scare the

[PATCH] IPV4: fix compile error building without CONFIG_FS_PROC

2008-02-02 Thread Li Zefan
compile error building without CONFIG_FS_PROC. net/ipv4/fib_frontend.c: In function 'fib_net_init': net/ipv4/fib_frontend.c:1032: error: implicit declaration of function 'fib_proc_ init' net/ipv4/fib_frontend.c: In function 'fib_net_exit': net/ipv4/fib_frontend.c:1047: error: implicit

Re: Integrating cpusets and cpu isolation [was Re: [CPUISOL] CPU isolation extensions]

2008-02-02 Thread Max Krasnyansky
Paul Jackson wrote: > Max wrote: >> Here is the list of things of issues with sched_load_balance flag from CPU >> isolation >> perspective: > > A separate thread happened to start up on lkml.org, shortly after > yours, that went into this in considerable detail. > > For example, the

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Ingo Molnar
* Gene Heskett <[EMAIL PROTECTED]> wrote: > I believe its the same, but lemme paste it for sure, yes: > [ 26.339926] ENABLING IO-APIC IRQs > [ 26.340119] ..TIMER: vector=0x31 apic1=0 pin1=0 apic2=-1 pin2=-1 > [ 26.350129] ..MP-BIOS bug: 8254 timer not connected to IO-APIC > [ 26.350182]

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > [ 23.893598] Calling initcall 0xc0c518b0: be_sleepy+0x0/0x170() > [ 23.901601] PM: no wakelarm-capable RTC > [ 23.905599] initcall 0xc0c518b0: be_sleepy+0x0/0x170() returned 0. > [ 23.910879] initcall 0xc0c518b0 ran for 3 msecs:

Re: [PATCH] Improve Documentation/stable_api_nonsense.txt v2

2008-02-02 Thread Daniel Hazelton
On Sunday 03 February 2008 00:03:10 Greg KH wrote: > On Sat, Feb 02, 2008 at 07:52:37PM -0500, Daniel Hazelton wrote: > > On Saturday 02 February 2008 19:22:49 Greg KH wrote: > > > On Sat, Feb 02, 2008 at 04:44:57PM +0200, Heikki Orsila wrote: > > > > > > > > > > @@ -145,6 +145,10 @@ as small as

Re: [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables.

2008-02-02 Thread Andrew Morton
On Sun, 03 Feb 2008 16:37:00 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > Why dropping add-mm-argument-to-pte-pmd-pud-pgd_free.patch though ? I dropped the whole series. > It's a sane patch and a helps going further, and a total pain to re-do > later on. Besides, I may have some

Re: [patch 2/3] CONFIG_HIGHPTE vs. sub-page page tables.

2008-02-02 Thread Benjamin Herrenschmidt
Why dropping add-mm-argument-to-pte-pmd-pud-pgd_free.patch though ? It's a sane patch and a helps going further, and a total pain to re-do later on. Besides, I may have some use for it on powerpc at some point too... Ben. -- To unsubscribe from this list: send the line "unsubscribe

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > i didnt have all RTC drivers enabled (it was a randconfig .config i > started out with) - but this did not appear to cure the problem. New > bootlog and new config attached. i disabled all hpet items in the .config on the theory that they might

Re: PCI: Remove users of pci_enable_device_bars()

2008-02-02 Thread Benjamin Herrenschmidt
> > Since Alan has commented on it: > > > > http://lkml.org/lkml/2007/12/17/422 > > > > "5520 in fact is always enabled as it is the host bridge. > > pci_enable_device_io will do just fine. The 5520 fun is if you disable it > > the system hangs." > > > > I moved on assuming that either

latest git compile error in sound/drivers/opl3/opl3_synth.c

2008-02-02 Thread Li Zefan
sound/drivers/opl3/opl3_synth.c: In function 'snd_opl3_find_patch': sound/drivers/opl3/opl3_synth.c:308: error: 'OPL3_PATCH_HASH_SIZE' undeclared (first use in this function) sound/drivers/opl3/opl3_synth.c:308: error: (Each undeclared identifier is reported only once

[NET/IPv6] Race condition with flow_cache_genid?

2008-02-02 Thread Kyle Moffett
Hi, I was poking around trying to figure out how to install the Mobile IPv6 daemons this evening and noticed they required a kernel patch, although upon further inspection the kernel patch seemed to already be applied in 2.6.24. Unfortunately the flow cache appears to be horribly racy. Attached

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Gene Heskett
On Saturday 02 February 2008, Ingo Molnar wrote: >* Gene Heskett <[EMAIL PROTECTED]> wrote: >> I think that one came from me, but it also gets over 14,000 hits on >> google. >> >> Now Jeff, here is the strange part. That error was killing me, many >> times an hour and eventually crashing

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread Ingo Molnar
* David Brownell <[EMAIL PROTECTED]> wrote: > On Saturday 02 February 2008, Ingo Molnar wrote: > > > > * Pavel Machek <[EMAIL PROTECTED]> wrote: > > > > > > It would have been easier to just use the public interface and > > > > hard-wire "rtc0". But going directly to the hardware was

Re: [PATCH] Improve Documentation/stable_api_nonsense.txt v2

2008-02-02 Thread Greg KH
On Sat, Feb 02, 2008 at 07:52:37PM -0500, Daniel Hazelton wrote: > On Saturday 02 February 2008 19:22:49 Greg KH wrote: > > On Sat, Feb 02, 2008 at 04:44:57PM +0200, Heikki Orsila wrote: > > > > @@ -145,6 +145,10 @@ as small as possible, and that all potential > > > interfaces are tested as well

[patch] scsi: fix spurious build failures in aic7xxx

2008-02-02 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > I could not reproduce the bug myself but I think I spotted it. We > > had a missing dependency to the _reg.h file. Try following patch and > > let me now if it continue to break. > > thanks! I threw this into the test setup and will know by

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Ingo Molnar
* Ingo Molnar <[EMAIL PROTECTED]> wrote: > > [ 27.097095] ENABLING IO-APIC IRQs > > [ 27.097287] ..TIMER: vector=0x31 apic1=0 pin1=2 apic2=-1 pin2=-1 > > [ 27.107291] ..MP-BIOS bug: 8254 timer not connected to IO-APIC > > [ 27.107343] ...trying to set up timer (IRQ0) through the 8259A

[PATCH] module: remove module taint on ndiswrapper

2008-02-02 Thread Pavel Roskin
Revert 0aa5bd52d0c49ca56d24584c646e6544ccbb3dc9, which disallowed ndiswrapper to use GPL-only symbols. Add comments why ndiswrapper and driverloader are tainted to avoid similar mistakes in the future. Signed-off-by: Pavel Roskin <[EMAIL PROTECTED]> --- kernel/module.c |7 ++- 1 files

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Ingo Molnar
* Gene Heskett <[EMAIL PROTECTED]> wrote: > I think that one came from me, but it also gets over 14,000 hits on > google. > > Now Jeff, here is the strange part. That error was killing me, many > times an hour and eventually crashing completely, repeatedly. > > I applied that kernel

[PATCH] jbd/jbd2: sparse warnings in revoke.c, journal.c

2008-02-02 Thread Harvey Harrison
fs/jbd/revoke.c:176:29: warning: Using plain integer as NULL pointer fs/jbd/revoke.c:182:28: warning: Using plain integer as NULL pointer fs/jbd/journal.c:1622:2: warning: Using plain integer as NULL pointer fs/jbd/journal.c:1629:28: warning: Using plain integer as NULL pointer

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Gene Heskett
On Saturday 02 February 2008, Jeff Garzik wrote: >Chris Rankin wrote: >> ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen >> ata1.00: cmd c8/00:08:00:00:00/00:00:00:00:00/e0 tag 0 dma 4096 in >> res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout) >> ata1.00: status: { DRDY

Re: [PATCH] mmu notifiers #v5

2008-02-02 Thread Andrea Arcangeli
On Sat, Feb 02, 2008 at 09:14:57PM -0600, Jack Steiner wrote: > Also, most (but not all) applications that use the GRU do not usually do > anything that requires frequent flushing (fortunately). The GRU is intended > for HPC-like applications. These don't usually do frequent map/unmap > operations

Re: [REVIEW for merge] kbuild updates including silence of section mismatch check

2008-02-02 Thread Bryan Wu
On Sat, 2008-02-02 at 22:30 +0100, Sam Ravnborg wrote: > Bryan this was from you - please comment/fix. > > Sam > > On Sat, Feb 02, 2008 at 10:25:51PM +0100, Frans Pop wrote: > > Sam Ravnborg wrote: > > > --- a/scripts/setlocalversion > > > +++ b/scripts/setlocalversion > > > @@ -45,3

Re: [PATCH] mmu notifiers #v5

2008-02-02 Thread Jack Steiner
On Sun, Feb 03, 2008 at 03:17:04AM +0100, Andrea Arcangeli wrote: > On Fri, Feb 01, 2008 at 11:23:57AM -0800, Christoph Lameter wrote: > > Yes so your invalidate_range is still some sort of dysfunctional > > optimization? Gazillions of invalidate_page's will have to be executed > > when tearing

[PATCH] drivers/block/: add __devinitdata to all pci_device_id table of block drivers

2008-02-02 Thread Denis Cheng
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- drivers/block/DAC960.c |2 +- drivers/block/cciss.c|2 +- drivers/block/cpqarray.c |2 +- drivers/block/sx8.c |2 +- drivers/block/umem.c |2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH] Remove unneeded code in sys_getpriority

2008-02-02 Thread Rabin Vincent
This check is not required because the condition is always true. Signed-off-by: Rabin Vincent <[EMAIL PROTECTED]> --- kernel/sys.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/kernel/sys.c b/kernel/sys.c index d1fe71e..a001974 100644 --- a/kernel/sys.c +++

[PATCH] mxser: fix compile warning building without CONFIG_PCI

2008-02-02 Thread Li Zefan
When build without CONFIG_PIC, got the following warnings: drivers/char/mxser.c: In function 'mxser_init': drivers/char/mxser.c:698: warning: unused variable 'devnum' drivers/char/mxser.c:698: warning: unused variable 'busnum' drivers/char/mxser.c:697: warning: unused variable 'index'

[PATCH 2/2] kprobe: remove preempt_enable/disable from kprobe_handle_fault()

2008-02-02 Thread Harvey Harrison
This patch removes the preempt_disable/enable pair around kprobe_running which was originally added to avoid the assertion from smp_processor_id which would be hit an asertion if preemption was enabled. Kprobes can not be running if we are preemptible, so test explicitly for preemption and bail

[PATCH 1/2] kprobes: Introduce kprobe_handle_fault()

2008-02-02 Thread Harvey Harrison
Use a central kprobe_handle_fault() inline in kprobes.h to remove all of the arch-dependant, practically identical implementations in avr32, ia64, powerpc, s390, sparc64, and x86. avr32 was the only arch without the preempt_disable/enable pair in its notify_page_fault implementation. This

Re: [linux-pm] sleepy linux self-test

2008-02-02 Thread David Brownell
On Saturday 02 February 2008, Ingo Molnar wrote: > > * Pavel Machek <[EMAIL PROTECTED]> wrote: > > > > It would have been easier to just use the public interface and > > > hard-wire "rtc0". But going directly to the hardware was dirtier, > > > and more in the spirit of "hack that obviously

Re: [patch 2/4] mmu_notifier: Callbacks to invalidate address ranges

2008-02-02 Thread Andrea Arcangeli
On Fri, Feb 01, 2008 at 05:35:28PM -0600, Robin Holt wrote: > No, we need a callout when we are becoming more restrictive, but not > when becoming more permissive. I would have to guess that is the case > for any of these callouts. It is for both GRU and XPMEM. I would > expect the same is true

Re: [PATCH] mmu notifiers #v5

2008-02-02 Thread Andrea Arcangeli
On Fri, Feb 01, 2008 at 11:23:57AM -0800, Christoph Lameter wrote: > Yes so your invalidate_range is still some sort of dysfunctional > optimization? Gazillions of invalidate_page's will have to be executed > when tearing down large memory areas. I don't know if gru can flush the external TLB

[PATCH] MTD/NAND: fix a compile warning in plat_nand_remove

2008-02-02 Thread Li Zefan
With CONFIG_MTD_PARTITIONS not set, got this: drivers/mtd/nand/plat_nand.c:113: warning: unused variable 'pdata' Signed-off-by: Li Zefan <[EMAIL PROTECTED]> --- drivers/mtd/nand/plat_nand.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/mtd/nand/plat_nand.c

[PATCH] writeback: __sync_single_inode() trivial cleanup

2008-02-02 Thread Fengguang Wu
Make the if-else straight in __sync_single_inode(). No behavior change. Cc: Michael Rubin <[EMAIL PROTECTED]> Cc: Peter Zijlstra <[EMAIL PROTECTED]> Signed-off-by: Fengguang Wu <[EMAIL PROTECTED]> --- fs/fs-writeback.c | 15 +++ 1 files changed, 7 insertions(+), 8 deletions(-) ---

Re: linux-2.6.24 compile error in drivers/net/b44.c

2008-02-02 Thread Li Zefan
Li Zefan wrote: > Miguel Botón 写道: >> Li Zefan wrote: >>> Add CCs: >>> >>> CC: [EMAIL PROTECTED] >>> CC: [EMAIL PROTECTED] >>> CC: [EMAIL PROTECTED] >>> >>> Li Zefan wrote: drivers/net/b44.c: In function 'b44_remove_one': drivers/net/b44.c:2231: error: implicit declaration of function

Re: linux-2.6.24 compile error in drivers/net/b44.c

2008-02-02 Thread Li Zefan
Miguel Botón 写道: > Li Zefan wrote: >> Add CCs: >> >> CC: [EMAIL PROTECTED] >> CC: [EMAIL PROTECTED] >> CC: [EMAIL PROTECTED] >> >> Li Zefan wrote: >>> drivers/net/b44.c: In function 'b44_remove_one': >>> drivers/net/b44.c:2231: error: implicit declaration of function >>>

[PATCH 00/10] atl1: move to atlx and update for 2.6.25

2008-02-02 Thread Jay Cliburn
In preparation for a future atl2 driver for the Atheros L2 10/100 chip, we propose to move the existing atl1 driver to a new directory (drivers/net/atlx), then split out functions and definitions that both atl1 and atl2 can share. The final structure will look like this: drivers/net/atl1

[PATCH 09/10] atl1: make functions static

2008-02-02 Thread Jay Cliburn
Make needlessly global functions static. In a couple of cases this requires removing forward declarations and reordering functions. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Acked-by: Chris Snook <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 101

[PATCH 10/10] atl1: reduce forward declarations

2008-02-02 Thread Jay Cliburn
Rearrange functions to allow removal of some forward declarations. Make certain global functions static along the way. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Acked-by: Chris Snook <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 1406 +++---

[PATCH 06/10] atl1: use csum_start

2008-02-02 Thread Jay Cliburn
Use skb->csum_start for tx checksum offload preparation. Also swap the variables css and cso so they hold the intended values of csum start and offset, respectively. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Acked-by: Chris Snook <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 11

[PATCH 05/10] atl1: simplify tx packet descriptor

2008-02-02 Thread Jay Cliburn
The transmit packet descriptor consists of four 32-bit words, with word 3 upper bits overloaded depending upon the condition of its bits 3 and 4. The driver currently duplicates all word 2 and some word 3 register bit definitions unnecessarily and also uses a set of nested structures in its

[PATCH 08/10] atl1: print debug info if rrd error

2008-02-02 Thread Jay Cliburn
Add some debug printks if we encounter a potentially bad receive return descriptor. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Acked-by: Chris Snook <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 26 ++ 1 files changed, 22 insertions(+), 4 deletions(-) diff

[PATCH 01/10] atl1: relocate atl1 driver to /drivers/net/atlx

2008-02-02 Thread Jay Cliburn
In preparation for a future Atheros L2 NIC driver (called atl2), relocate the atl1 driver into a new /drivers/net/atlx directory that will ultimately be shared with the future atl2 driver. Signed-off-by: Chris Snook <[EMAIL PROTECTED]> Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> ---

[PATCH 04/10] atl1: add ethtool register dump

2008-02-02 Thread Jay Cliburn
Add the ethtool register dump option to the atl1 driver. Signed-off-by: Jay Cliburn <[EMAIL PROTECTED]> Acked-by: Chris Snook <[EMAIL PROTECTED]> --- drivers/net/atlx/atl1.c | 53 +++ drivers/net/atlx/atl1.h |1 + 2 files changed, 54

[PATCH 03/10] atl1: fix broken TSO

2008-02-02 Thread Jay Cliburn
The L1 tx packet descriptor expects TCP Header Length to be expressed as a number of 32-bit dwords. The atl1 driver uses tcp_hdrlen() to populate the field, but tcp_hdrlen() returns the header length in bytes, not in dwords. Add a shift to convert tcp_hdrlen() to dwords when we write it to the

latest git compile error in net/sched/cls_flow.c

2008-02-02 Thread Li Zefan
I made a randconfig, and got the following error: net/sched/cls_flow.c: In function 'flow_dump': net/sched/cls_flow.c:598: error: 'struct tcf_ematch_tree' has no member named 'hdr' make[2]: *** [net/sched/cls_flow.o] Error 1 make[1]: *** [net/sched] Error 2 make: *** [net] Error 2 seems it's

Re: [patch 0/4] [RFC] EMMU Notifiers V5

2008-02-02 Thread Andrea Arcangeli
On Thu, Jan 31, 2008 at 09:04:39PM -0800, Christoph Lameter wrote: > - Has page tables to track pages whose refcount was elevated(?) but > no reverse maps. Just a correction, rmaps exists or swap couldn't be sane, it's just that it's not built on the page_t because the guest memory is really

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Jeff Garzik
Chris Rankin wrote: ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen ata1.00: cmd c8/00:08:00:00:00/00:00:00:00:00/e0 tag 0 dma 4096 in res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout) ata1.00: status: { DRDY } ata1: soft resetting link ata1.00: configured for UDMA/66

Re: [patch 1/3] mmu_notifier: Core code

2008-02-02 Thread Andrea Arcangeli
On Thu, Jan 31, 2008 at 07:58:40PM -0800, Christoph Lameter wrote: > Ok. Andrea wanted the same because then he can void the begin callouts. Exactly. I hope the page-pin will avoid me having to serialize the KVM page fault against the start/end critical section. BTW, I wonder if the start/end

Re: [PATCH] Unbreak sky2 on 88E8039 with current git

2008-02-02 Thread Petr Vandrovec
Stephen Hemminger wrote: On Sat, 2 Feb 2008 11:52:43 +0100 Petr Vandrovec <[EMAIL PROTECTED]> wrote: Hello, since I synced my tree to Linus's one two days ago, sky2's packet receiption dies almost instantly. Device still transmits packets, but no receive. Fortunately fix is simple,

Re: [PATCH] x86: Remove pt_regs arg from smp_thermal_interrupt

2008-02-02 Thread Harvey Harrison
The pt_regs arg is never used, make it agree with the other definitions of smp_thermal_interrupt. It doesn't look like smp_thermal_interrupt is even called on 32-bit... Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- How about I actually send the patch that worked this time? Sorry about

Desparately wanted: intelfb modesetting in mainline

2008-02-02 Thread Hubert Tonneau
As a probable result of Intel opening specifications, it is now fairly easy to buy a business computer that will run Linux without loosing weeks hacking to get it up and running: just go with an intel graphic board since Intel X11 driver now works just fine. Well, this apply only if you run

Re: [PATCH] Allow NBD to be used locally

2008-02-02 Thread Jan Engelhardt
On Feb 2 2008 18:31, [EMAIL PROTECTED] wrote: > >> How will that work? Fuse makes up a filesystem - not helpful >> if you have a raw disk without a known fs to mount. > >take zfs-fuse or ntfs-3g for example. >you have a blockdevice or backing-file containing data structures and fuse >makes

Re: [PATCH] Improve Documentation/stable_api_nonsense.txt v2

2008-02-02 Thread Daniel Hazelton
On Saturday 02 February 2008 19:22:49 Greg KH wrote: > On Sat, Feb 02, 2008 at 04:44:57PM +0200, Heikki Orsila wrote: > > @@ -145,6 +145,10 @@ as small as possible, and that all potential > > interfaces are tested as well as they can be (unused interfaces are > > pretty much impossible to test

[PATCH] x86: Remove pt_regs arg from smp_thermal_interrupt

2008-02-02 Thread Harvey Harrison
The pt_regs arg is never used, make it agree with the other definitions of smp_thermal_interrupt. It doesn't look like smp_thermal_interrupt is even called on 32-bit... Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> --- Andrew, this is a fairly dumb patch, but works-for-me(tm)

[PATCH] Remove needless PCI_DEVICE_ID definition from uio_cif.c

2008-02-02 Thread Hans-Jürgen Koch
From: Hans J. Koch <[EMAIL PROTECTED]> CC: Greg Kroah-Hartman <[EMAIL PROTECTED]> CC: Benedikt Spranger <[EMAIL PROTECTED]> Subject: Remove needless PCI_DEVICE_ID definition from uio_cif.c Date: Sun, 03 Feb 2008 01:37:58 +0100 Meanwhile, PCI_DEVICE_ID_PLX_9030 is defined in pci_ids.h, no need to

Automated Kernel Testing

2008-02-02 Thread Kevin Winchester
Hi Ingo & Andrew, Since you both seem to be quite interested in the number of kernel testers and the reporting of bugs, I figured I would bounce this idea off of you... As a part-time kernel tester, I find it interesting to see that Ingo has tools that are able to automatically

Re: [PATCH] AMD Thermal Interrupt Support

2008-02-02 Thread Andrew Morton
On Sat, 02 Feb 2008 16:27:40 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote: > On Sat, 2008-02-02 at 16:10 -0800, Andrew Morton wrote: > > On Thu, 17 Jan 2008 17:06:33 -0800 "Russell Leidich" <[EMAIL PROTECTED]> > > wrote: > > > > > > Here's the hopefully-final version of the patch, which I

Re: [BUG] 2.6.24 refuses to boot - ATA problem?

2008-02-02 Thread Daniel Hazelton
On Saturday 02 February 2008 18:40:55 Chris Rankin wrote: > Hi, > > I have tried to boot a 2.6.24 kernel on my 1 GHz Coppermine / 512 MB RAM > PC. (This is without the nmi_watchdog=1 option.) However, the ATA layer is > failing to initialise: > > Driver 'sd' needs updating - please use bus_type

Re: [PATCH] Improve Documentation/stable_api_nonsense.txt v2

2008-02-02 Thread Greg KH
On Sat, Feb 02, 2008 at 04:44:57PM +0200, Heikki Orsila wrote: > This is version 2 of the patch. Address Gregs, Matts and Andis comments. > Retain the word "exact" due to request of Greg. Use "the exact > same" as per "Matt Mackall". > > * Change wording > * Make a remark about necessary changes

Re: [PATCH 2/3] uio: mark pci_device_id hilscher_pci_ids[] __devinitdata

2008-02-02 Thread Hans-Jürgen Koch
Am Sat, 2 Feb 2008 17:51:36 +0800 schrieb Denis Cheng <[EMAIL PROTECTED]>: Makes sense. > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Signed-off-by: Hans J. Koch <[EMAIL PROTECTED]> > --- > drivers/uio/uio_cif.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git

Re: [PATCH] AMD Thermal Interrupt Support

2008-02-02 Thread Harvey Harrison
On Sat, 2008-02-02 at 16:10 -0800, Andrew Morton wrote: > On Thu, 17 Jan 2008 17:06:33 -0800 "Russell Leidich" <[EMAIL PROTECTED]> > wrote: > > > > Here's the hopefully-final version of the patch, which I have just > > > tested on Intel and AMD. > > Curious. This just broke. > > i386

Re: [PATCH] [MEMSTICK] Updates for the memstick driver

2008-02-02 Thread Andrew Morton
Changes to the block core in mainline have destroyed this driver. This was hitherto not known because I was unable to carry git-block in -mm because it blithely tromped all over other people's code. I'll disable the memstick driver in config for now. Please send fixes? -- To unsubscribe from

Re: latencytop: optimize LT_BACKTRACEDEPTH loops a bit

2008-02-02 Thread Arjan van de Ven
Dmitry Adamushko wrote: Subject: latencytop: optimize LT_BACKTRACEDEPTH loops a bit. It looks like there is no need to loop any longer when 'same == 0'. thanks for the contribution! while I like your patch, I wonder if we should go even a little further in cleaning this up @@ -73,12 +73,12

Re: [PATCH 1/3] uio: Kconfig improvements

2008-02-02 Thread Hans-Jürgen Koch
Am Sat, 2 Feb 2008 17:51:35 +0800 schrieb Denis Cheng <[EMAIL PROTECTED]>: Agreed. > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Signed-off-by: Hans J. Koch <[EMAIL PROTECTED]> > --- > drivers/uio/Kconfig | 10 +- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff

Re: [PATCH] AMD Thermal Interrupt Support

2008-02-02 Thread Andrew Morton
On Thu, 17 Jan 2008 17:06:33 -0800 "Russell Leidich" <[EMAIL PROTECTED]> wrote: > > Here's the hopefully-final version of the patch, which I have just > > tested on Intel and AMD. Curious. This just broke. i386 allmodconfig: arch/x86/kernel/cpu/mcheck/p4.o: In function

Re: [PATCH 27/32] ide-tape: remove idetape_increase_max_pipeline_stages()

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Borislav Petkov wrote: > From: Borislav Petkov <[EMAIL PROTECTED]> > > This function was being used only at one place so fold it in there. > > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> This change is fine but depends on previous patches so I can't apply it.

Re: [PATCH 28/32] ide-tape: shorten some function names

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Borislav Petkov wrote: > From: Borislav Petkov <[EMAIL PROTECTED]> > > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> > --- > drivers/ide/ide-tape.c | 29 +++-- > 1 files changed, 15 insertions(+), 14 deletions(-) > > diff --git

Re: [RFC PATCH 26/32] ide-tape: remove packet command and struct request memory buffers

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Borislav Petkov wrote: > From: Borislav Petkov <[EMAIL PROTECTED]> > > Bart, > this one is rather intrusive so please doublecheck it wrt to kzalloc/kfree > balancing on all the codepaths so that we don't leak memory all over the > place. > I free all the alloc'd pc's

  1   2   3   4   5   6   7   8   >