[PATCH v3] perf bench: fix assert when NDEBUG is defined

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea When NDEBUG is defined, the assert macro will be expanded to nothing. Some assert calls used in perf are also including some functionality (e.g. system calls), not only validity checks. Therefore, if NDEBUG is defined, this functionality will be removed along with the assert.

Re: [PATCH v6] pstore/ram: Add ramoops support for the Flattened Device Tree.

2012-09-07 Thread Anton Vorontsov
On Fri, Sep 07, 2012 at 11:29:36AM -0700, Bryan Freed wrote: > When called with a non-zero of_node, fill out a new ramoops_platform_data > with data from the specified Flattened Device Tree node. > Update ramoops documentation with the new FDT interface. > Update devicetree/binding documentation

Re: [PATCH] virtio-balloon spec: provide a version of the "silent deflate" feature that works

2012-09-07 Thread Rusty Russell
"Michael S. Tsirkin" writes: > On Fri, Sep 07, 2012 at 04:09:50PM +0930, Rusty Russell wrote: >> > So it looks like a bug: we should teach driver to tell host first on leak? >> > Yan, Vadim, can you comment please? >> > >> > Also if true, looks like this bit will be useful to detect a fixed

Re: [PATCH 0/7] Fixes for hybrid graphics Apple machines

2012-09-07 Thread Seth Forshee
On Fri, Sep 07, 2012 at 10:35:04PM +0100, Dave Airlie wrote: > On Fri, Sep 7, 2012 at 4:22 PM, Seth Forshee > wrote: > > Many hybrid graphics Apple laptops fail to set up LVDS on the secondary > > GPU due to missing or incorrect mode information for the panel at init > > time. The only way to

Re: [PATCH 1/7] mm: interval tree updates

2012-09-07 Thread Hillf Danton
Hello Michel Lets first see snippet in another work. https://lkml.org/lkml/2012/9/4/75 [PATCH 5/7] mm rmap: remove vma_address check for address inside vma On Tue, Sep 4, 2012 at 5:20 PM, Michel Lespinasse wrote: > diff --git a/mm/rmap.c b/mm/rmap.c > index

RE: [PATCH RESEND] USB/host: Cleanup unneccessary irq disable code

2012-09-07 Thread Liu, Chuansheng
> -Original Message- > From: Liu, Chuansheng > Sent: Friday, September 07, 2012 5:20 PM > To: gre...@linuxfoundation.org > Cc: linux-kernel@vger.kernel.org > Subject: [PATCH RESEND] USB/host: Cleanup unneccessary irq disable code > > Because the IRQF_DISABLED as the flag is now a NOOP

Re: [PATCHv2 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-09-07 Thread Mark Brown
On Wed, Sep 05, 2012 at 05:06:04PM +0530, Sourav Poddar wrote: > +static struct regmap_config smsc_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > + .max_register = SMSC_MAX_REGISTER - 1; That max_register setup looks very odd... > +

Re: [PATCH v1 00/10] vfs: getname/putname overhaul

2012-09-07 Thread Andi Kleen
On Fri, Sep 07, 2012 at 08:54:18PM -0400, Jeff Layton wrote: > On Fri, 07 Sep 2012 14:26:56 -0700 > Andi Kleen wrote: > > > Jeff Layton writes: > > > > > This patchset is a first pass at overhauling the getname/putname > > > interface to use a struct. The idea here is to add a new getname_info

Re: [Resend][PATCH] pciehp: always implement resume

2012-09-07 Thread Bjorn Helgaas
[fix Kristen's email addr] On Fri, Sep 7, 2012 at 5:33 PM, Bjorn Helgaas wrote: > +cc Mark & Kristen > > Commit cd2fe83a815 by Mark added the code we're changing here, so this > is your chance to speak up if we're not doing the right thing :) > > On Fri, Sep 7, 2012 at 4:28 PM, Bjorn Helgaas

[PATCH 02/13] tools lib traceevent: Get rid of die() from pretty_print()

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim There are three cases that call die() in the pretty_print. 1. insufficient number of argument: cannot proceed anymore. 2. too long format conversion specifier: truncate and proceed. 3. bad size specifier in format string: skip and proceed. For all cases, convert die to

[PATCH 01/13] perf tools: Ignore compiled python binaries

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim It prevents mindless git add from adding those files. Signed-off-by: Namhyung Kim Cc: Ingo Molnar Cc: Paul Mackerras Cc: Peter Zijlstra Link: http://lkml.kernel.org/r/1346982953-30824-1-git-send-email-namhy...@kernel.org Signed-off-by: Arnaldo Carvalho de Melo ---

[PATCH 12/13] perf tools: add NO_BACKTRACE for application self-debugging

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Irina Tirdea perf has support for self-debugging by defining dump_stack function. This function uses backtrace and backtrace_symbols functions defined as GNU extensions. In Android, bionic does not offer support for these functions and compilation will fail with the following error:

[PATCH 08/13] perf tools: fix missing winsize definition

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Irina Tirdea In Android, struct winsize is not defined in the headers already included in help.c. This leads to a compile error. Including termios.h fixes the compilation error since it defines struct winsize. Signed-off-by: Irina Tirdea Cc: David Ahern Cc: Ingo Molnar Cc: Namhyung

[PATCH 09/13] perf tools: include missing pthread.h header

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Irina Tirdea pthread variables are used in some files without explicitely including pthread.h. This leads to compile errors on Android. e.g.: in annotate.h, error: unknown type name 'pthread_mutex_t' Including pthread.h explicitely in files that use it to have all definitions included.

[PATCH 10/13] perf tools: replace mkostemp with mkstemp

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Irina Tirdea The mkostemp function is only available in glibc. This leads to compile error in Android, since bionic is derived from BSD. Replacing mkostemp with mkstemp. mkstemp is available on both glibc and bionic. Signed-off-by: Irina Tirdea Cc: David Ahern Cc: Ingo Molnar Cc:

[PATCH 13/13] perf tools: Fix build for another rbtree.c change

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Fixes: ../../lib/rbtree.c: In function 'rb_insert_color': ../../lib/rbtree.c:95:9: error: 'true' undeclared (first use in this function) ../../lib/rbtree.c:95:9: note: each undeclared identifier is reported only once for each function it appears in ../../lib/rbtree.c: In

[PATCH 11/13] tools lib traceevent: replace mempcpy with memcpy

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Irina Tirdea The mempcpy function is not supported by bionic in Android and will lead to compilation errors. Replacing mempcpy with memcpy so it will work in Android. Signed-off-by: Irina Tirdea Cc: David Ahern Cc: Ingo Molnar Cc: Namhyung Kim Cc: Paul Mackerras Cc: Peter Zijlstra

[PATCH 06/13] perf tools: Replace sort's standalone field_sep with symbol_conf.field_sep

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa The repsep_snprintf function was still using standalone field_sep, which not even set anymore. Replacing it with 'symbol_conf.field_sep'. Signed-off-by: Jiri Olsa Cc: Andi Kleen Cc: Corey Ashford Cc: David Ahern Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Namhyung Kim

Re: [PATCH] mm: fix mmap overflow checking

2012-09-07 Thread Wanlong Gao
On 09/08/2012 09:58 AM, KOSAKI Motohiro wrote: >>> I've seen the exactly same patch from another fujitsu guys several >>> month ago. and as I pointed >>> out at that time, this line don't work when 32bit kernel + mmap2 syscall >>> case. >>> >>> Please don't think do_mmap_pgoff() is for mmap(2)

[PATCH 04/13] tools lib traceevent: Get rid of die() from pevent_register_print_function

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim If memory allocation for handler fails or argument type is not match, return gracefully instead of calling die(). Also add an new error code for the later case. Signed-off-by: Namhyung Kim Acked-by: Steven Rostedt Cc: Frederic Weisbecker Cc: Ingo Molnar Cc: Peter

[PATCH 03/13] tools lib traceevent: Get rid of die() from pevent_register_event_handler

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Namhyung Kim If memory allocation for handler fails, return gracefully instead of calling die(). Note that casts to void * are needed because gcc complained about discarding 'const' qualifier during implicit argument cast. Signed-off-by: Namhyung Kim Acked-by: Steven Rostedt Cc:

[GIT PULL 00/13] perf/core improvements and fixes

2012-09-07 Thread Arnaldo Carvalho de Melo
Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 479d875835a49e849683743ec50c30b6a429696b: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core (2012-09-07 07:36:59 +0200) are available in the git

[PATCH 05/13] perf diff: Make diff command work with evsel hists

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Putting 'perf diff' command back on track with the 'latest' evsel hists changes. Each evsel has its own 'hists' object gathering stats for the particular event. While currently counts are accumulated for the whole session regardless of the events diversification within compared

[PATCH 07/13] perf tools: include basename for non-glibc systems

2012-09-07 Thread Arnaldo Carvalho de Melo
From: Irina Tirdea perf uses the glibc version of basename(), by defining _GNU_SOURCE, including string.h and not including libgen.h. The glibc version of basename is better than the POSIX version since it does not modify its argument. Android has only one version of basename which is defined

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-07 Thread Greg Kroah-Hartman
On Fri, Sep 07, 2012 at 06:32:48PM -0700, Yinghai Lu wrote: > Greg, > > Any reason for using kmalloc instead of local variable during your > rewriting pci search code? > > commit 95247b57ed844511a212265b45cf9a919753aea1 > Author: Greg Kroah-Hartman > Date: Wed Feb 13 11:03:58 2008 -0800

Re: [PATCH] mm: fix mmap overflow checking

2012-09-07 Thread KOSAKI Motohiro
>> I've seen the exactly same patch from another fujitsu guys several >> month ago. and as I pointed >> out at that time, this line don't work when 32bit kernel + mmap2 syscall >> case. >> >> Please don't think do_mmap_pgoff() is for mmap(2) specific and read a >> past thread before resend >> a

Re: [PATCH 0/5] dev_ and dynamic_debug cleanups

2012-09-07 Thread Joe Perches
On Fri, 2012-09-07 at 11:35 -0400, Jason Baron wrote: > If nobody else thinks this patch is better, let's at least add a comment in > __dev_printk() and __netdev_printk() to fix dynamic debug, if these are > changed. Or maybe make dynamic_emit_prefix a public function and move the

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-07 Thread Yinghai Lu
On Fri, Sep 7, 2012 at 6:00 PM, Yinghai Lu wrote: > On Thu, Aug 23, 2012 at 12:45 AM, Feng Tang wrote: >> From 57a28ee5e7662ca28ba4c793aa037d64bd082dee Mon Sep 17 00:00:00 2001 >> From: Feng Tang >> Date: Wed, 22 Aug 2012 15:41:51 +0800 >> Subject: [PATCH 1/2] PCI: Use local parameter

[PATCH] rtc_sysfs_show_hctosys(): display 0 if resume failed

2012-09-07 Thread David Fries
Without this patch /sys/class/rtc/$CONFIG_RTC_HCTOSYS_DEVICE/hctosys contains a 1 (meaning "This rtc was used to initialize the system clock") even if setting the time by do_settimeofday() at bootup failed. The RTC can also be used to set the clock on resume, if it did 1, otherwise 0. Previously

Re: [PATCH v2 07/12] rbtree: adjust root color in rb_insert_color() only when necessary

2012-09-07 Thread Arnaldo Carvalho de Melo
Em Fri, Aug 31, 2012 at 11:35:40AM +0300, Adrian Hunter escreveu: > AFAICS tools/perf/util/include/linux is for fixing up the > differences between kernel headers and exported kernel headers. > Hence my change: > > diff --git a/tools/perf/util/include/linux/rbtree.h >

Re: [PATCH] perf bench: fix assert when NDEBUG is defined

2012-09-07 Thread Irina Tirdea
> Its valid (although admittedly dubious) to have BUG_ON with > side-effects. > > The 'right' fix would be something like: > > --- > #ifndef BUG_ON > +#ifdef NDEBUG > +#define BUG_ON(cond) do { if (cond) ; } while (0) > +#else > #define BUG_ON(cond) assert(!(cond)) > #endif > +#endif > This is

Re: [PATCH 4/6] unicore32: Add common clock support

2012-09-07 Thread Mike Turquette
Quoting Thierry Reding (2012-09-02 03:21:11) > diff --git a/arch/unicore32/kernel/clock.c b/arch/unicore32/kernel/clock.c > +struct clk_uc { > + struct clk_hw hw; > }; This looks ugly. Normally register addresses, masks and the like would go here. Instead you duplicate some functions

Re: [PATCH v2 00/12] Porting perf to Android

2012-09-07 Thread Arnaldo Carvalho de Melo
Em Sat, Sep 08, 2012 at 03:43:12AM +0300, Irina Tirdea escreveu: > This is version 2 for the patches to port perf to Android. > With these patches perf compiles on latest Android tree (JellyBean). > > The patches are on top of current perf/core branch of the tip tree. Thanks, I applied 6 out of

[PATCH] tracing: add an option for disabling markers

2012-09-07 Thread Mandeep Singh Baines
In our application, we have trace markers spread through user-space. We have markers in GL, X, etc. These are super handy for Chrome's about:tracing feature (Chrome + system + kernel trace view), but can be very distracting when you're trying to debug a kernel issue. I normally, use "grep -v

[PATCH] mfd: arizona: Remove unused variable

2012-09-07 Thread Mark Brown
Left over as bitrot from previous changes. Signed-off-by: Mark Brown --- drivers/mfd/arizona-irq.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/arizona-irq.c b/drivers/mfd/arizona-irq.c index a062153..f7886c8 100644 --- a/drivers/mfd/arizona-irq.c +++

Re: [PATCH 1/2] PCI: Use local parameter pci_device_id for pci_get_subsys/class()

2012-09-07 Thread Yinghai Lu
On Thu, Aug 23, 2012 at 12:45 AM, Feng Tang wrote: > From 57a28ee5e7662ca28ba4c793aa037d64bd082dee Mon Sep 17 00:00:00 2001 > From: Feng Tang > Date: Wed, 22 Aug 2012 15:41:51 +0800 > Subject: [PATCH 1/2] PCI: Use local parameter pci_device_id for > pci_get_subsys/class() > > This fixes a

Re: [PATCH] regulator: core: fix rdev->regmap NULL pointer

2012-09-07 Thread Mark Brown
On Fri, Sep 07, 2012 at 08:45:05PM +0530, AnilKumar Ch wrote: > Fixes rdev->regmap NULL pointer if regmap for regulator device > is NULL. If it is NULL then get regmap for regulator device > from its parent (MFD). > > Signed-off-by: AnilKumar Ch Applied with a rewritten commit message - this is

Re: [PATCH 04/12] perf diff: Refactor diff displacement possition info

2012-09-07 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 06, 2012 at 05:46:58PM +0200, Jiri Olsa escreveu: > @@ -150,6 +154,24 @@ static struct perf_evsel *evsel_match(struct perf_evsel > *evsel, > return NULL; > } > > +static void resort_evlist(struct perf_evlist *evlist, bool name) For consistency, please use: +static void

Re: [PATCH v1 00/10] vfs: getname/putname overhaul

2012-09-07 Thread Jeff Layton
On Fri, 07 Sep 2012 14:26:56 -0700 Andi Kleen wrote: > Jeff Layton writes: > > > This patchset is a first pass at overhauling the getname/putname > > interface to use a struct. The idea here is to add a new getname_info > > struct that allow us to pass around some auxillary info along with > >

Re: [PATCH 4/5] perf ui/browser: Use perf_hpp__format functions

2012-09-07 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 03, 2012 at 11:53:09AM +0900, Namhyung Kim escreveu: > From: Namhyung Kim > > Override hpp->color functions for TUI. Because line coloring is done > outside of the function, it just sets the percent value and pass it. > > Signed-off-by: Namhyung Kim > --- >

Re: mmotm 2012-09-06-16-46 uploaded (drivers/misc/lis3lv02d/lis3lv02d_spi.c)

2012-09-07 Thread Randy Dunlap
On 09/06/2012 04:47 PM, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2012-09-06-16-46 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > on x86_64: CONFIG_OF and CONFIG_DTC are not enabled. drivers/misc/lis3lv02d/lis3lv02d_spi.c:137:3: error: implicit

Re: [PATCH 8/9] ARM: msm: Add DT support for 8960

2012-09-07 Thread Stephen Boyd
On 09/07/12 15:58, David Brown wrote: > On Wed, Sep 05, 2012 at 12:28:58PM -0700, Stephen Boyd wrote: > >> +DT_MACHINE_START(MSM8960_DT, "Qualcomm MSM (Flattened Device Tree)") > The description string should specify the general name of what this is > suspporting. Right now, with these patches,

Re: [PATCHSET RESEND 0/5] perf tools: Cleanup hist printing code (v4)

2012-09-07 Thread Arnaldo Carvalho de Melo
Em Mon, Sep 03, 2012 at 11:53:05AM +0900, Namhyung Kim escreveu: > This is a cleanup and refactoring patchset for the hist printing code > by adding perf_hpp__format functions and perf_hpp. I believe it makes > the code easy to maintain and to add new features like upcoming group > viewing and

[PATCH v2 04/12] perf tools: fix ALIGN redefinition in system headers

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea On some systems (e.g. Android), ALIGN is defined in system headers as ALIGN(p). The definition of ALIGN used in perf takes 2 parameters: ALIGN(x,a). This leads to redefinition conflicts. Redefinition error on Android: In file included from util/include/linux/list.h:1:0, from

[PATCH v2 06/12] perf tools: fix missing winsize definition

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea In Android, struct winsize is not defined in the headers already included in help.c. This leads to a compile error. Including termios.h fixes the compilation error since it defines struct winsize. Signed-off-by: Irina Tirdea --- tools/perf/util/help.c |1 +

[PATCH v2 09/12] perf tools: replace mkostemp with mkstemp

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea mkostemp is only available in glibc. This leads to compile error in Android, since bionic is derived from BSD. Replacing mkostemp with mkstemp. mkstemp is available on both glibc and bionic. Signed-off-by: Irina Tirdea --- tools/perf/util/dso-test-data.c |2 +- 1 file

[PATCH v2 11/12] perf tools: add NO_BACKTRACE for application self-debugging

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea perf has support for self-debugging by defining dump_stack function. This function uses backtrace and backtrace_symbols functions defined as GNU extensions. In Android, bionic does not offer support for these functions and compilation will fail with the following error:

[PATCH v2 10/12] tools lib traceevent: replace mempcpy with memcpy

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea mempcpy is not supported by bionic in Android and will lead to compilation errors. Replacing mempcpy with memcpy so it will work in Android. Signed-off-by: Irina Tirdea --- tools/lib/traceevent/event-parse.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH v2 08/12] perf tools: fix no return in non-void function

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea thread_func in builtin-sched.c has an internal loop and never returns. The only return from this thread are BUG_ON calls in case return values are not 0. The compiler on Android complains that the function needs to return a non-void value. Adding the noreturn function

[PATCH v2 07/12] perf tools: include missing pthread.h header

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea pthread variables are used in some files without explicitely including pthread.h. This leads to compile errors on Android. e.g.: in annotate.h, error: unknown type name 'pthread_mutex_t' Including pthread.h explicitely in files that use it to have all definitions included.

[PATCH v2 05/12] perf tools: include basename for non-glibc systems

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea perf uses the glibc version of basename(), by defining _GNU_SOURCE, including string.h and not including libgen.h. The glibc version of basename is better than the POSIX version since it does not modify its argument. Android has only one version of basename which is defined

[PATCH v2 03/12] perf tools: include __WORDSIZE definition

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea __WORDSIZE is GLibC-specific and is not defined on all systems or glibc versions (e.g. Android's bionic does not define it). In file included from util/include/linux/bitmap.h:5:0, from util/header.h:10, from util/session.h:6,

[PATCH v2 02/12] perf tools: update types definitions for Android

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea Some type definitions are missing from Android or are already defined in bionic and lead to redefinition errors. Android defines in types.h __le32. Since perf is wrapping with a local version, we need to define this constant in the local version too. Error in Android: In

[PATCH v2 01/12] perf tools: include wrapper for magic.h

2012-09-07 Thread Irina Tirdea
From: Irina Tirdea perf is currently including magic.h directly from the kernel. If the glibc magic.h is also included, this leads to warnings that the constants are redefined. This happens on some systems (e.g. Android). Redefinition errors on Android: In file included from util/util.h:79:0,

[PATCH v2 00/12] Porting perf to Android

2012-09-07 Thread Irina Tirdea
This is version 2 for the patches to port perf to Android. With these patches perf compiles on latest Android tree (JellyBean). The patches are on top of current perf/core branch of the tip tree. Changes for v2: () dropped the patch that replaced on_exit with at_exit. A better solution is the

Re: [PATCH] mtd:nand:clk: preparation for switch to common clock framework

2012-09-07 Thread Brian Norris
On Fri, Sep 7, 2012 at 2:56 PM, Karicheri, Muralidharan wrote: > How do these patch get to upstream? Does this get merged through davinci > maintainer or through individual subsystem maintainers? I think this driver would be taken by David Woodhouse in his linux-mtd repo. Usually Artem

Re: [PATCH 11/13] perf tools: replace mempcpy with memcpy

2012-09-07 Thread Irina Tirdea
> > Can you resubmit this in txt form? I applied some other patches from you > but you need to try to do it yourself, i.e. send just to you, then try > to save the patch and apply it... Sorry about this... I will check this myself from now on. I've seen you already merged this one, but I'll

Re: [PATCH 2/2] mm: support MIGRATE_DISCARD

2012-09-07 Thread Minchan Kim
On Fri, Sep 07, 2012 at 10:32:03AM +0100, Mel Gorman wrote: > On Fri, Sep 07, 2012 at 09:21:45AM +0100, Mel Gorman wrote: > > > > So other than the mix up of order parameters I think this should work. > > > > But I'd be wrong, isolated page accounting is not fixed up so it will > eventually

Re: [PATCH] rtc_sysfs_show_hctosys 0 if resume failed

2012-09-07 Thread Andrew Morton
On Sat, 25 Aug 2012 21:19:31 -0500 David Fries wrote: > Subject: [PATCH] rtc_sysfs_show_hctosys 0 if resume failed This doesn't make much sense. Did you mean "rtc_sysfs_show_hctosys(): display 0 if resume failed"? > The original rtc_sysfs_show_hctosys returnd 1 if this device was the >

Re: mtd: kernel BUG at arch/x86/mm/pat.c:279!

2012-09-07 Thread Suresh Siddha
On Fri, 2012-09-07 at 16:09 -0700, Linus Torvalds wrote: > The "u32 len" -> "unsigned long len" thing *might* make a difference, though. This I believe doesn't fix the reported BUG. I was trying to address your previous comment about broken types. > > I also think your patch is incomplete even

Re: mmotm 2012-09-06-16-46 uploaded (fs/binfmt_aout)

2012-09-07 Thread Randy Dunlap
On 09/06/2012 04:47 PM, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2012-09-06-16-46 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > when CONFIG_COREDUMP is not enabled: ERROR: "dump_seek" [fs/binfmt_aout.ko] undefined! ERROR: "dump_write"

Re: [PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h

2012-09-07 Thread Randy Dunlap
On 09/07/2012 02:30 PM, Timur Tabi wrote: > mdio-mux-mmioreg.c uses function of_address_to_resource(), which is defined > in linux/of_address.h. This fixes a compilation error: > > drivers/net/phy/mdio-mux-mmioreg.c: In function 'mdio_mux_mmioreg_probe': >

Re: [PATCH wq/for-3.6-fixes 3/3] workqueue: fix possible idle worker depletion during CPU_ONLINE

2012-09-07 Thread Tejun Heo
I think this should do it. Can you spot any hole with the following patch? Thanks. Index: work/kernel/workqueue.c === --- work.orig/kernel/workqueue.c +++ work/kernel/workqueue.c @@ -66,6 +66,7 @@ enum { /* pool flags */

Re: [Resend][PATCH] pciehp: always implement resume

2012-09-07 Thread Bjorn Helgaas
+cc Mark & Kristen Commit cd2fe83a815 by Mark added the code we're changing here, so this is your chance to speak up if we're not doing the right thing :) On Fri, Sep 7, 2012 at 4:28 PM, Bjorn Helgaas wrote: > On Fri, Sep 7, 2012 at 2:28 PM, Rafael J. Wysocki wrote: >> From: Oliver Neukum >>

Re: [Resend][PATCH] pciehp: always implement resume

2012-09-07 Thread Bjorn Helgaas
On Fri, Sep 7, 2012 at 2:28 PM, Rafael J. Wysocki wrote: > From: Oliver Neukum > Subject: pciehp: always implement resume > > The driver by default ignores resume. On some laptops > that means that interrupts are not delivered after S3. > So card removals and insertions will not be handled.

Re: [PATCH 1/7] mm: interval tree updates

2012-09-07 Thread Michel Lespinasse
On Fri, Sep 07, 2012 at 03:55:14PM -0700, Andrew Morton wrote: > On Fri, 7 Sep 2012 15:29:36 -0700 > Michel Lespinasse wrote: > > > > Ho hum. I don't think I can be bothered untangling all this. > > > > I don't think you should have to do it yourself either. > > Patch wrangling is what I do

Re: [PATCH 1/7] mm: interval tree updates

2012-09-07 Thread Michel Lespinasse
On Fri, Sep 07, 2012 at 03:55:14PM -0700, Andrew Morton wrote: > On Fri, 7 Sep 2012 15:29:36 -0700 > Michel Lespinasse wrote: > > > > Ho hum. I don't think I can be bothered untangling all this. > > > > I don't think you should have to do it yourself either. > > Patch wrangling is what I do

Re: [dm-devel] [PATCH v10 4/8] block: Add bio_reset()

2012-09-07 Thread Kent Overstreet
On Sat, Sep 08, 2012 at 12:14:33AM +0100, Alasdair G Kergon wrote: > As I indicated already in this discussion, dm started to use > merge_bvec_fn as a cheap way of avoiding splitting and this improved > overall efficiency. Often it's better to pay the small price of calling > that function to

Re: [PATCH v3 00/31] AArch64 Linux kernel port

2012-09-07 Thread Olof Johansson
On Fri, Sep 07, 2012 at 05:26:35PM +0100, Catalin Marinas wrote: > This is the 3rd version of patches implementing Linux kernel support for > the 64-bit ARM architecture. Most of the review comments for the > previous release have been implemented. There are a few left (like > generic timer dts

Re: RE: [PATCH] mtd:nand:clk: preparation for switch to common clock framework

2012-09-07 Thread Mike Turquette
Quoting Karicheri, Muralidharan (2012-09-07 14:56:22) > Mike, > > How do these patch get to upstream? Does this get merged through davinci > maintainer or through individual subsystem maintainers? > What does scripts/get_maintainer.pl tell you? Also feel free to make my Acked-by into a

Re: [dm-devel] [PATCH v10 4/8] block: Add bio_reset()

2012-09-07 Thread Alasdair G Kergon
As I indicated already in this discussion, dm started to use merge_bvec_fn as a cheap way of avoiding splitting and this improved overall efficiency. Often it's better to pay the small price of calling that function to ensure the bio is created the right size in the first place so it won't have

Re: mtd: kernel BUG at arch/x86/mm/pat.c:279!

2012-09-07 Thread Linus Torvalds
On Fri, Sep 7, 2012 at 3:42 PM, Suresh Siddha wrote: > - unsigned long start; > - unsigned long off; > - u32 len; > + resource_size_t start, off; > + unsigned long len; So since the oops is on x86-64, I don't think it's the "unsigned long" -> "resource_size_t" part

Re: [PATCH wq/for-3.6-fixes 3/3] workqueue: fix possible idle worker depletion during CPU_ONLINE

2012-09-07 Thread Tejun Heo
On Fri, Sep 07, 2012 at 04:05:56PM -0700, Tejun Heo wrote: > I got it down to the following but it creates a problem where CPU > hotplug queues a work item on worker->scheduled before the execution > loops starts. :( Oops, wrong patch. This is the right one. Index: work/kernel/workqueue.c

Re: [PATCH 5/5] mempolicy: fix a memory corruption by refcount imbalance in alloc_pages_vma()

2012-09-07 Thread KOSAKI Motohiro
> mempolicy: fix a memory corruption by refcount imbalance in alloc_pages_vma() > > [cc9a6c87: cpuset: mm: reduce large amounts of memory barrier related damage > v3] introduced a potential memory corruption. shmem_alloc_page() uses a > pseudo vma and it has one significant unique combination,

Re: [PATCH wq/for-3.6-fixes 3/3] workqueue: fix possible idle worker depletion during CPU_ONLINE

2012-09-07 Thread Tejun Heo
I got it down to the following but it creates a problem where CPU hotplug queues a work item on worker->scheduled before the execution loops starts. :( Need to think more about it. kernel/workqueue.c | 63 - 1 file changed, 29

[PATCH 1/9] block: Convert integrity to bvec_alloc_bs(), and a bugfix

2012-09-07 Thread Kent Overstreet
This adds a pointer to the bvec array to struct bio_integrity_payload, instead of the bvecs always being inline; then the bvecs are allocated with bvec_alloc_bs(). This is needed eventually for immutable bio vecs - immutable bvecs aren't useful if we still have to copy them, hence the need for

[PATCH 2/9] block: Add bio_advance()

2012-09-07 Thread Kent Overstreet
This is prep work for immutable bio vecs; we first want to centralize where bvecs are modified. Next two patches convert some existing code to use this function. Signed-off-by: Kent Overstreet CC: Jens Axboe --- fs/bio.c| 41 +

[PATCH 3/9] block: Refactor blk_update_request()

2012-09-07 Thread Kent Overstreet
Converts it to use bio_advance(), simplifying it quite a bit in the process. Signed-off-by: Kent Overstreet CC: Jens Axboe --- block/blk-core.c | 84 +++- 1 file changed, 16 insertions(+), 68 deletions(-) diff --git a/block/blk-core.c

[PATCH 5/9] block: Add bio_end()

2012-09-07 Thread Kent Overstreet
Just a little convenience macro - main reason to add it now is preparing for immutable bio vecs, it'll reduce the size of the patch that puts bi_sector/bi_size/bi_idx into a struct bvec_iter. Signed-off-by: Kent Overstreet CC: Jens Axboe --- block/blk-core.c | 2 +-

[PATCH 6/9] block: Use bio_sectors() more consistently

2012-09-07 Thread Kent Overstreet
Bunch of places in the code weren't using it where they could be - this'll reduce the size of the patch that puts bi_sector/bi_size/bi_idx into a struct bvec_iter. Signed-off-by: Kent Overstreet CC: Jens Axboe --- drivers/block/aoe/aoeblk.c | 2 +- drivers/block/aoe/aoecmd.c | 2 +-

[PATCH 7/9] block: Don't use bi_idx in bio_split() or require it to be 0

2012-09-07 Thread Kent Overstreet
Prep work for immutable bio_vecs/efficient bio splitting: they require auditing and removing most uses of bi_idx. So here we convert bio_split() to respect the current value of bi_idx and use the bio_iovec() macro, instead of assuming bi_idx will be 0. Signed-off-by: Kent Overstreet CC: Jens

[PATCH 8/9] block: Remove bi_idx references

2012-09-07 Thread Kent Overstreet
These were harmless but uneccessary,andt getting rid of them makes the code easier to audit since most of them need to be removed. Signed-off-by: Kent Overstreet CC: Jens Axboe --- drivers/block/floppy.c | 1 - drivers/md/dm-verity.c | 2 +- drivers/md/raid10.c| 1 - fs/buffer.c

[PATCH 9/9] block: Remove some unnecessary bi_vcnt usage

2012-09-07 Thread Kent Overstreet
More prep work for immutable bvecs/effecient bio splitting - usage of bi_vcnt has to be auditing, so getting rid of all the unnecessary usage makes that easier. Plus, bio_segments() is really what this code wanted, as it respects the current value of bi_idx. Signed-off-by: Kent Overstreet CC:

[PATCH 4/9] md: Convert md_trim_bio() to use bio_advance()

2012-09-07 Thread Kent Overstreet
Signed-off-by: Kent Overstreet CC: Jens Axboe CC: NeilBrown --- drivers/md/md.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 7a2b079..51ce48c 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -190,25

Re: [PATCH 3/5] mempolicy: fix a race in shared_policy_replace()

2012-09-07 Thread KOSAKI Motohiro
First off, thank you very much for reworking this for me. I haven't got a chance to get a test machine for this. > shared_policy_replace() use of sp_alloc() is unsafe. 1) sp_node cannot > be dereferenced if sp->lock is not held and 2) another thread can modify > sp_node between spin_unlock for

[PATCH 0/9] Prep work for immutable bio vecs

2012-09-07 Thread Kent Overstreet
Random assortment of refactoring and trivial cleanups. Immutable bio vecs and efficient bio splitting require auditing and removing pretty much all bi_idx uses, among other things. The reason is that with immutable bio vecs we can't use the bvec array directly; if we have a partially completed

Re: [PATCH RESEND]mm/ia64: fix a node distance bug

2012-09-07 Thread David Rientjes
On Thu, 6 Sep 2012, wujianguo wrote: > From: Jianguo Wu > > In arch ia64, has following definition: > extern u8 numa_slit[MAX_NUMNODES * MAX_NUMNODES]; > #define node_distance(from,to) (numa_slit[(from) * num_online_nodes() + (to)]) > > num_online_nodes() is a variable value, it can be changed

Re: [PATCH 8/9] ARM: msm: Add DT support for 8960

2012-09-07 Thread David Brown
On Wed, Sep 05, 2012 at 12:28:58PM -0700, Stephen Boyd wrote: > +DT_MACHINE_START(MSM8960_DT, "Qualcomm MSM (Flattened Device Tree)") The description string should specify the general name of what this is suspporting. Right now, with these patches, it would list Qualcomm MSM (Flattened

Re: [PATCH 1/7] mm: interval tree updates

2012-09-07 Thread Andrew Morton
On Fri, 7 Sep 2012 15:29:36 -0700 Michel Lespinasse wrote: > > Ho hum. I don't think I can be bothered untangling all this. > > I don't think you should have to do it yourself either. Patch wrangling is what I do ;) > But, if you're willing to take it, I can send you replacement patches for

Re: Question about failure in PCI power-state change

2012-09-07 Thread Bjorn Helgaas
+cc Rafael, Huang, linux-pm On Fri, Sep 7, 2012 at 3:44 PM, Larry Finger wrote: > Hi, > > On occasion when I unload and reload driver rtl8192ce, I get the message > > "Refused to change power state, currently in D3" > > I added additional info to the printk and discovered that it was trying to >

Question about failure in PCI power-state change

2012-09-07 Thread Larry Finger
Hi, On occasion when I unload and reload driver rtl8192ce, I get the message "Refused to change power state, currently in D3" I added additional info to the printk and discovered that it was trying to change to state D0. The problem seems to occur when I have made a connection, unloaded the

Re: [PATCH v10 4/8] block: Add bio_reset()

2012-09-07 Thread Jens Axboe
On 2012-09-07 16:25, Kent Overstreet wrote: > On Fri, Sep 07, 2012 at 04:06:45PM -0600, Jens Axboe wrote: >> On 2012-09-07 15:55, Jens Axboe wrote: >>> On 2012-09-07 14:58, Kent Overstreet wrote: On Thu, Sep 06, 2012 at 07:34:18PM -0600, Jens Axboe wrote: > On 2012-09-06 16:34, Kent

Re: mtd: kernel BUG at arch/x86/mm/pat.c:279!

2012-09-07 Thread Suresh Siddha
On Fri, 2012-09-07 at 11:14 -0700, Linus Torvalds wrote: > Guys, this looks like a MTD and/or io_remap_pfn_range() bug, and it's > not getting any traction. > > What the f*ck is mtd_mmap() doing, and why? The problem seems to be an > overflow condition, because reserve_pfn_range() does > >

Re: [PATCH 0/4] PCI error handler const

2012-09-07 Thread Bjorn Helgaas
On Fri, Sep 7, 2012 at 9:33 AM, Stephen Hemminger wrote: > This is a trivial patch to make PCI error handler function > tables const. Split into pieces so that core changes are first. I put all four of these on this branch:

[stable][PATCH] pch_uart: Add eg20t_port lock field, avoid recursive spinlocks

2012-09-07 Thread Darren Hart
commit 2588aba002d14e938c2f56d299ecf3e7ce1302a5 upstream. pch_uart_interrupt() takes priv->port.lock which leads to two recursive spinlock calls if low_latency==1 or CONFIG_PREEMPT_RT_FULL=y (one otherwise): pch_uart_interrupt spin_lock_irqsave(priv->port.lock, flags) case

Re: [PATCH] mm: fix mmap overflow checking

2012-09-07 Thread KOSAKI Motohiro
On Tue, Sep 4, 2012 at 5:23 AM, Wanlong Gao wrote: > POSIX said that if the file is a regular file and the value of "off" > plus "len" exceeds the offset maximum established in the open file > description associated with fildes, mmap should return EOVERFLOW. > > The following test from LTP can

Re: [PATCH v2] SUNRPC: check current nsproxy before set of node name on client creation

2012-09-07 Thread Myklebust, Trond
On Mon, 2012-08-13 at 08:10 -0400, Jeff Layton wrote: > On Mon, 13 Aug 2012 15:37:31 +0400 > Stanislav Kinsbursky wrote: > > > v2: > > 1) rpc_clnt_set_nodename() prototype updated. > > 2) fixed errors in comment. > > > > When child reaper exits, it can destroy mount namespace it belongs to, and

Re: [PATCH 1/7] mm: interval tree updates

2012-09-07 Thread Michel Lespinasse
On Fri, Sep 7, 2012 at 3:13 PM, Andrew Morton wrote: > On Tue, 4 Sep 2012 02:20:51 -0700 > Michel Lespinasse wrote: > >> This commit updates the generic interval tree code that was >> introduced in "mm: replace vma prio_tree with an interval tree". >> >> Changes: >> >> - fixed 'endpoing' typo

Re: [PATCH v10 4/8] block: Add bio_reset()

2012-09-07 Thread Kent Overstreet
On Fri, Sep 07, 2012 at 04:06:45PM -0600, Jens Axboe wrote: > On 2012-09-07 15:55, Jens Axboe wrote: > > On 2012-09-07 14:58, Kent Overstreet wrote: > >> On Thu, Sep 06, 2012 at 07:34:18PM -0600, Jens Axboe wrote: > >>> On 2012-09-06 16:34, Kent Overstreet wrote: > Reusing bios is something

Endianess bug fix for sierra_net

2012-09-07 Thread Lennart Sorensen
I discovered I couldn't get sierra_net to work on a powerpc. Turns out the firmware attribute check assumes the system is little endian and hence fails because the attributes is a 16 bit value. Signed-off-by: Len Sorensen diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c

  1   2   3   4   5   6   7   8   9   10   >