3.7-stable review patch. If anyone has any objections, please let me know.
--
From: Or Gerlitz
[ Upstream commit ca4c7b35f75492de7fbf5ee95be07481c348caee ]
The lines
if (mlx4_is_mfunc(dev)) {
nreq = 2;
} else {
which hard code the number of
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Cong Wang
[ Upstream commit c9be4a5c49cf51cc70a993f004c5bb30067a65ce ]
A regression is introduced by the following commit:
commit 4d52cfbef6266092d535237ba5a4b981458ab171
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Tilman Schmidt
[ Upstream commit d721a1752ba544df8d7d36959038b26bc92bdf80 ]
If subtracting 12 from l leaves zero we'd do a zero size allocation,
leading to an oops later when we try to set
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Stephen Hemminger
[ Upstream commit adbbf69d1a54abf424e91875746a610dcc80017d ]
I changed my email because the vyatta.com mail server is now
redirected to brocade.com; and the Brocade mail
On Tuesday, February 12, 2013 12:50:38 PM Tejun Heo wrote:
> Hey, Rafael.
>
> On Tue, Feb 12, 2013 at 09:53:08PM +0100, Rafael J. Wysocki wrote:
> > This looks fishy, but I wonder if Tejun has any ideas.
> >
> > Tejun, can you please have a look at the call trace below? It looks like
> > the
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: T Makphaibulchoke
commit 4965f5667f36a95b41cda6638875bc992bd7d18b upstream.
Using a recursive call add a non-conflicting region in
__reserve_region_with_split() could result in a stack
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Larry Finger
commit a5ffbe0a1993a27072742ef7db6cf9839956fce9 upstream.
Kernel commits 41affd5 and 6539306 changed the locking in rtl_lps_leave()
from a spinlock to a mutex by doing the calls
On Sun, Jan 20, 2013 at 05:51:12PM -0500, Mark Lord wrote:
> Got it again, this time on a different system
> running mostly the same software.
Mark, Paweł, Tom, could any of you confirm whether this helps?
--b.
diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c
index dbf12ac..2d34b6b 100644
---
On 02/12/2013 10:32 AM, Arnd Bergmann wrote:
> On Tuesday 12 February 2013, Stephen Warren wrote:
>>> I don't think that's going to help any link issues, so I'd drop it and
>>> keep this function simple.
>>
>> As explained in the above, a complier will drop unnecessary functions
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Sjur Brændeland
commit aded024a12b32fc1ed9a80639681daae2d07ec25 upstream.
Don't access uninitialized work-queue when removing device.
The work queue is initialized only if the device
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Johan Hedberg
commit 8cf9fa1240229cbdd888236c0c43fcbad680cf00 upstream.
The conn->smp_chan pointer can be NULL if SMP PDUs arrive at unexpected
moments. To avoid NULL pointer dereferences the
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Matt Fleming
commit 83e68189745ad931c2afd45d8ee3303929233e7f upstream.
Originally 'efi_enabled' indicated whether a kernel was booted from
EFI firmware. Over time its semantics have changed,
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: T Makphaibulchoke
commit 4965f5667f36a95b41cda6638875bc992bd7d18b upstream.
Using a recursive call add a non-conflicting region in
__reserve_region_with_split() could result in a stack
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Stephen Hemminger
[ Upstream commit adbbf69d1a54abf424e91875746a610dcc80017d ]
I changed my email because the vyatta.com mail server is now
redirected to brocade.com; and the Brocade mail
Hey, Rafael.
On Tue, Feb 12, 2013 at 09:53:08PM +0100, Rafael J. Wysocki wrote:
> This looks fishy, but I wonder if Tejun has any ideas.
>
> Tejun, can you please have a look at the call trace below? It looks like
> the workqueues code is involved heavily.
> >
> > kworker/0:0/4 is trying to
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Romain KUNTZ
[ Upstream commit 7efdba5bd9a2f3e2059beeb45c9fa55eefe1bced ]
Commit 299b0767 (ipv6: Fix IPsec slowpath fragmentation problem)
has introduced a error in the header length
On Mon, Feb 11, 2013 at 08:36:17PM +0100, Rafael J. Wysocki wrote:
> On Monday, February 11, 2013 05:13:30 PM Nathan Zimmer wrote:
> > There are some spots that I need to give a much deeper review,
> > cpufreq_register_driver for example.
> >
> > But I believe
> > > @@ -196,7 +195,7 @@ static
On Tue, Feb 12, 2013 at 09:08:27PM +0100, Paolo Bonzini wrote:
> Il 12/02/2013 19:23, Michael S. Tsirkin ha scritto:
> > On Tue, Feb 12, 2013 at 07:04:27PM +0100, Paolo Bonzini wrote:
> Perhaps, but 3 or 4 arguments (in/out/nsg or in/out/nsg_in/nsg_out) just
> for this are definitely too
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Rob Herring
[ Upstream commit d6fb3be544b46a7611a3373fcaa62b5b0be01888 ]
The xgmac driver assumes 1 frame per descriptor. If a frame larger than
the descriptor's buffer size is received, the
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: =?UTF-8?q?Timo=20Ter=C3=A4s?=
[ Upstream commit 5d0feaff230c0abfe4a112e6f09f096ed99e0b2d ]
This was introduced in commit 6dccd16 "r8169: merge with version
6.001.00 of Realtek's r8169
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Eric Dumazet
[ Upstream commit 794ed393b707f01858f5ebe2ae5eabaf89d00022 ]
Ben Greear reported crashes in ip_rcv_finish() on a stress
test involving many macvlans.
We tracked the bug to a dst
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Cong Wang
[ Upstream commit 604dfd6efc9b79bce432f2394791708d8e8f6efc ]
The return value of pktgen_add_device() is not checked, so
even if we fail to add some device, for example, non-exist
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Tilman Schmidt
[ Upstream commit d721a1752ba544df8d7d36959038b26bc92bdf80 ]
If subtracting 12 from l leaves zero we'd do a zero size allocation,
leading to an oops later when we try to set
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Romain Kuntz
[ Upstream commit 85da53bf1c336bb07ac038fb951403ab0478d2c5 ]
The tests on the flags in addrconf_get_prefix_route() does no make
much sense: the 'noflags' parameter contains the
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Cong Wang
[ Upstream commit c9be4a5c49cf51cc70a993f004c5bb30067a65ce ]
A regression is introduced by the following commit:
commit 4d52cfbef6266092d535237ba5a4b981458ab171
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Matt Fleming
commit e0094244e41c4d0c7ad69920681972fc45d8ce34 upstream.
It has been reported that running this driver on some Samsung laptops
with EFI can cause those machines to become bricked
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Larry Finger
commit 0a06ad8e3a1cb5311b7dbafde45410aa1bce9d40 upstream.
In routine _rtl_rx_pre_process(), skb_dequeue() is called to get an skb;
however, the wrong variable name is used in
This is the start of the stable review cycle for the 3.4.31 release.
There are 36 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Thu Feb 14 20:38:17 UTC 2013.
Anything
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Larry Finger
commit 0a06ad8e3a1cb5311b7dbafde45410aa1bce9d40 upstream.
In routine _rtl_rx_pre_process(), skb_dequeue() is called to get an skb;
however, the wrong variable name is used in
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Sjur Brændeland
commit aded024a12b32fc1ed9a80639681daae2d07ec25 upstream.
Don't access uninitialized work-queue when removing device.
The work queue is initialized only if the device
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Yan Burman
[ Upstream commit 213815a1e6ae70b9648483b110bc5081795f99e8 ]
Commit 5b4c4d36860e "mlx4_en: Allow communication between functions on
same host" introduced a regression under which a
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Marcelo Ricardo Leitner
[ Upstream commit bd30e947207e2ea0ff2c08f5b4a03025ddce48d3 ]
They will be created at output, if ever needed. This avoids creating
empty neighbor entries when
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Phil Sutter
[ Upstream commit 9665d5d62487e8e7b1f546c00e11107155384b9a ]
When releasing a packet socket, the routine packet_set_ring() is reused
to free rings instead of allocating them. But
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: "David S. Miller"
[ Upstream commit 559bcac35facfed49ab4f408e162971612dcfdf3 ]
1) rhine_tx() should use dev_kfree_skb() not dev_kfree_skb_irq()
2) rhine_slow_event_task's NAPI triggering
On Tuesday, February 12, 2013 10:18:57 AM Daniel J Blueman wrote:
> On 12 February 2013 03:49, Rafael J. Wysocki wrote:
> > On Monday, February 11, 2013 08:27:49 PM Rafael J. Wysocki wrote:
> >> On Monday, February 11, 2013 12:01:37 PM Bjorn Helgaas wrote:
> >> > [+cc Rafael]
> >> >
> >> > On
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Daniel Borkmann
[ Upstream commit b5c37fe6e24eec194bb29d22fdd55d73bcc709bf ]
On sctp_endpoint_destroy, previously used sensitive keying material
should be zeroed out before the memory is
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Ian Campbell
[ Upstream commit 48856286b64e4b66ec62b94e504d0b29c1ade664 ]
A buggy or malicious frontend should not be able to confuse netback.
If we spot anything which is not as it should be
On Tue, Feb 12, 2013 at 01:52:32PM +0400, Stanislav Kinsbursky wrote:
> 12.02.2013 00:58, J. Bruce Fields пишет:
>
> > void svc_close_net(struct svc_serv *serv, struct net *net)
> > {
> >-svc_close_list(serv, >sv_tempsocks, net);
> >-svc_close_list(serv, >sv_permsocks, net);
> >-
> >-
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Matthew Daley
[ Upstream commit 7d5145d8eb2b9791533ffe4dc003b129b9696c48 ]
Signed-off-by: Matthew Daley
Reviewed-by: Konrad Rzeszutek Wilk
Acked-by: Ian Campbell
Acked-by: Jan Beulich
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Ian Campbell
[ Upstream commit b9149729ebdcfce63f853aa54a404c6a8f6ebbf3 ]
Signed-off-by: Ian Campbell
Acked-by: Jan Beulich
Signed-off-by: David S. Miller
Signed-off-by: Greg Kroah-Hartman
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Eric Dumazet
[ Upstream commit 2e5f421211ff76c17130b4597bc06df4eeead24f ]
Commit 9dc274151a548 (tcp: fix ABC in tcp_slow_start())
uncovered a bug in FRTO code :
tcp_process_frto() is setting
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?=
[ Upstream commit 6731d2095bd4aef18027c72ef845ab1087c3ba63 ]
There are transients during normal FRTO procedure during which
the packets_in_flight can go to
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Sarveshwar Bandi
[ Upstream commit 6caab7b0544e83e6c160b5e80f5a4a7dd69545c7 ]
If lower layer driver leaves the ip header in the skb fragment, it needs to
be first pulled into skb->data before
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Neil Horman
[ Upstream commit 2f94aabd9f6c925d77aecb3ff020f1cc12ed8f86 ]
Jamie Parsons reported a problem recently, in which the re-initalization of an
association (The duplicate init case),
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Heiko Carstens
[ Upstream commit ab54ee80aa7585f9666ff4dd665441d7ce41f1e8 ]
We have conflicting type qualifiers for "freg_t" in s390's ptrace.h and the
iphase atm device driver, which causes
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Daniel Borkmann
[ Upstream commit 6ba542a291a5e558603ac51cda9bded347ce7627 ]
In sctp_setsockopt_auth_key, we create a temporary copy of the user
passed shared auth key for the endpoint or
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Or Gerlitz
[ Upstream commit ca4c7b35f75492de7fbf5ee95be07481c348caee ]
The lines
if (mlx4_is_mfunc(dev)) {
nreq = 2;
} else {
which hard code the number of
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Eric Dumazet
[ Upstream commit a05948f296ce103989b28a2606e47d2e287c3c89 ]
Christoph Paasch found netxen could trigger a BUG in its dismantle
phase, in netxen_release_tx_buffer(), using full
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Nithin Nayak Sujir
[ Upstream commit daf3ec688e057f6060fb9bb0819feac7a8bbf45c ]
TG3_PHY_AUXCTL_SMDSP_ENABLE/DISABLE macros do a blind write to the phy
auxiliary control register and overwrite
On Tue, Feb 12, 2013 at 11:35:29AM +0100, Holger Hoffstätte wrote:
> On 02/12/13 01:40, Sarah Sharp wrote:
> > Can you turn on CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING,
> > recompile the 3.7.5 kernel, and send me dmesg starting from the point
> > you unmount the device and then power it
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Nithin Nayak Sujir
[ Upstream commit 9c13cb8bb477a83b9a3c9e5a5478a4e21294a760 ]
When netconsole is enabled, logging messages generated during tg3_open
can result in a null pointer dereference
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Somnath Kotur
commit 93040ae5cc8dcc893eca4a4366dc8415af278edf upstream.
Fixed spelling error in a comment as pointed out by DaveM.
Also refactored existing code a bit to provide placeholders
3.4-stable review patch. If anyone has any objections, please let me know.
--
From: Ian Campbell
[ Upstream commit 4cc7c1cb7b11b6f3515bd9075527576a1eecc4aa ]
Signed-off-by: Ian Campbell
Signed-off-by: David S. Miller
Signed-off-by: Greg Kroah-Hartman
---
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Daniel Borkmann
[ Upstream commit 6ba542a291a5e558603ac51cda9bded347ce7627 ]
In sctp_setsockopt_auth_key, we create a temporary copy of the user
passed shared auth key for the endpoint or
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Phil Sutter
[ Upstream commit 9665d5d62487e8e7b1f546c00e11107155384b9a ]
When releasing a packet socket, the routine packet_set_ring() is reused
to free rings instead of allocating them. But
This is the start of the stable review cycle for the 3.0.64 release.
There are 22 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Thu Feb 14 20:31:38 UTC 2013.
Anything
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Daniel Borkmann
[ Upstream commit b5c37fe6e24eec194bb29d22fdd55d73bcc709bf ]
On sctp_endpoint_destroy, previously used sensitive keying material
should be zeroed out before the memory is
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Eric Dumazet
[ Upstream commit 2e5f421211ff76c17130b4597bc06df4eeead24f ]
Commit 9dc274151a548 (tcp: fix ABC in tcp_slow_start())
uncovered a bug in FRTO code :
tcp_process_frto() is setting
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?=
[ Upstream commit 6731d2095bd4aef18027c72ef845ab1087c3ba63 ]
There are transients during normal FRTO procedure during which
the packets_in_flight can go to
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Eric Dumazet
[ Upstream commit ae62ca7b03217be5e74759dc6d7698c95df498b3 ]
commit 35f9c09fe9c72e (tcp: tcp_sendpages() should call tcp_push() once)
added an internal flag :
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Sarveshwar Bandi
[ Upstream commit 6caab7b0544e83e6c160b5e80f5a4a7dd69545c7 ]
If lower layer driver leaves the ip header in the skb fragment, it needs to
be first pulled into skb->data before
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Nithin Nayak Sujir
[ Upstream commit 9c13cb8bb477a83b9a3c9e5a5478a4e21294a760 ]
When netconsole is enabled, logging messages generated during tg3_open
can result in a null pointer dereference
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Cong Wang
[ Upstream commit 604dfd6efc9b79bce432f2394791708d8e8f6efc ]
The return value of pktgen_add_device() is not checked, so
even if we fail to add some device, for example, non-exist
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Marcelo Ricardo Leitner
[ Upstream commit bd30e947207e2ea0ff2c08f5b4a03025ddce48d3 ]
They will be created at output, if ever needed. This avoids creating
empty neighbor entries when
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Heiko Carstens
[ Upstream commit ab54ee80aa7585f9666ff4dd665441d7ce41f1e8 ]
We have conflicting type qualifiers for "freg_t" in s390's ptrace.h and the
iphase atm device driver, which causes
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Nithin Nayak Sujir
[ Upstream commit daf3ec688e057f6060fb9bb0819feac7a8bbf45c ]
TG3_PHY_AUXCTL_SMDSP_ENABLE/DISABLE macros do a blind write to the phy
auxiliary control register and overwrite
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Neil Horman
[ Upstream commit 2f94aabd9f6c925d77aecb3ff020f1cc12ed8f86 ]
Jamie Parsons reported a problem recently, in which the re-initalization of an
association (The duplicate init case),
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: Eric Dumazet
[ Upstream commit 794ed393b707f01858f5ebe2ae5eabaf89d00022 ]
Ben Greear reported crashes in ip_rcv_finish() on a stress
test involving many macvlans.
We tracked the bug to a dst
3.7-stable review patch. If anyone has any objections, please let me know.
--
From: Eric Dumazet
[ Upstream commit f26845b43c75d3f32f98d194c1327b5b1e6b3fb0 ]
Under unusual circumstances, TCP collapse can split a big GRO TCP packet
while its being used in a
3.0-stable review patch. If anyone has any objections, please let me know.
--
From: =?UTF-8?q?Timo=20Ter=C3=A4s?=
[ Upstream commit 5d0feaff230c0abfe4a112e6f09f096ed99e0b2d ]
This was introduced in commit 6dccd16 "r8169: merge with version
6.001.00 of Realtek's r8169
3.7-stable review patch. If anyone has any objections, please let me know.
--
From: Eric Dumazet
[ Upstream commit 82bda6195615891181115f579a480aa5001ce7e9 ]
splice() can handle pages of any order, but network code tries hard to
split them in PAGE_SIZE units. Not quite
3.7-stable review patch. If anyone has any objections, please let me know.
--
From: Eric Dumazet
[ Upstream commit bc9540c637c3d8712ccbf9dcf28621f380ed5e64 ]
commit 9ca1b22d6d2 (net: splice: avoid high order page splitting)
forgot that skb->head could need a copy into
3.7-stable review patch. If anyone has any objections, please let me know.
--
From: Steffen Klassert
[ Upstream commit b44108dbdbaa07c609bb5755e8dd6c2035236251 ]
git commit 9cb3a50c (ipv4: Invalidate the socket cached route on
pmtu events if possible) introduced a refcount
3.7-stable review patch. If anyone has any objections, please let me know.
--
From: Eric Dumazet
[ Upstream commit cce894bb824429fd312706c7012acae43e725865 ]
spin_is_locked() on a non !SMP build is kind of useless.
BUG_ON(!spin_is_locked(xx)) is guaranteed to crash.
Just
This is the start of the stable review cycle for the 3.7.8 release.
There are 61 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Thu Feb 14 20:31:32 UTC 2013.
Anything
On Monday, February 11, 2013 05:43:50 PM Bjorn Helgaas wrote:
> On Mon, Feb 11, 2013 at 5:34 PM, Bjorn Helgaas wrote:
> > On Mon, Feb 4, 2013 at 1:23 PM, Rafael J. Wysocki wrote:
> >> On Monday, February 04, 2013 03:55:47 PM Konstantin Khlebnikov wrote:
> >>> This patchset contains some fixes
On Tuesday, February 12, 2013 11:11:23 AM Yinghai Lu wrote:
> Peter Hurley found "irq 18 nobody cared" with pci-next, and dmesg has
>
> [8.983246] pci :00:1e.0: can't derive routing for PCI INT A
> [8.983600] snd_ctxfi :09:02.0: PCI INT A: no GSI - using ISA IRQ 5
>
> bisect to
>
On Tue, 12 Feb 2013, Linus Torvalds wrote:
> On Tue, Feb 12, 2013 at 1:50 AM, Steven Whitehouse
> wrote:
> >
> > That doesn't seem right to me... DLM has not been experimental for a
> > long time now. Why not just select CRC32 in addition to IP_SCTP ?
>
> Hmm. IP_SCTP already does a "select
Feb 13, 2013 01:32:53 AM, Linus Torvalds wrote:
On Tue, Feb 12, 2013 at 10:29 AM, Artem S. Tashkinov wrote:
>> Feb 12, 2013 11:30:20 PM, Linus Torvalds wrote:
>>>
>>>A few things to try to pinpoint:
>>>
>>> (a) Is it *only* write performance that suffers, or is it other
>>>performance too?
On Tue, Feb 12, 2013 at 11:39 AM, Dave Jones wrote:
> My Thinkpad T430s suspend/resumes fine most of the time. But every so often
> (like one in ten times or so), as soon as I suspend, I get a black screen,
> and a blinking power button.
>
> (Note: Not the capslock lights like when we panic, this
Il 12/02/2013 19:23, Michael S. Tsirkin ha scritto:
> On Tue, Feb 12, 2013 at 07:04:27PM +0100, Paolo Bonzini wrote:
Perhaps, but 3 or 4 arguments (in/out/nsg or in/out/nsg_in/nsg_out) just
for this are definitely too many and make the API harder to use.
You have to find a
smatch analysis:
fs/nfs/getroot.c:130 nfs_get_root() info: redundant null
check on name calling kfree()
fs/nfs/unlink.c:272 nfs_async_unlink() info: redundant null
check on devname_garbage calling kfree()
Cc: Trond Myklebust
Cc: linux-...@vger.kernel.org
Signed-off-by: Tim Gardner
---
On Dec 3, 2012, at 7:36 AM, Wei Yongjun wrote:
> From: Wei Yongjun
>
> Use for_each_compatible_node() macro instead of open coding it.
>
> Signed-off-by: Wei Yongjun
> ---
> arch/powerpc/platforms/85xx/mpc85xx_mds.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
applied to next
Hi Mark,
Thanks for your comments.
On 02/12/2013 11:39 AM, Mark Rutland wrote:
> Hello,
>
> I have a few comments on the devicetree binding and the way it's parsed.
>
>> +static const struct of_device_id dbx500_mailbox_match[] = {
>> + { .compatible = "stericsson,db8500-mailbox",
>> +
On Tue, Feb 12, 2013 at 10:31:48AM -0800, Paul E. McKenney wrote:
> On Tue, Feb 12, 2013 at 12:25:26PM -0500, Johannes Weiner wrote:
> > On Tue, Feb 12, 2013 at 08:10:51AM -0800, Paul E. McKenney wrote:
> > > On Tue, Feb 12, 2013 at 04:43:30PM +0100, Michal Hocko wrote:
> > > > On Tue 12-02-13
On 02/12/2013 11:39 AM, H. Peter Anvin wrote:
> On 02/12/2013 10:42 AM, Steven Rostedt wrote:
>>
>> And currently the output is just plain broken. This isn't a hack. You
>> should have seen my first attempt. Now THAT was a hack! My first attempt
>> was extremely intrusive, and required a lot of
Dynamically allocate the NLM host structure in order to avoid stack overflow.
nlmsvc_mark_resources() is several call levels deep in a stack
that has a number of large variables. 512 bytes seems like a lot
on the stack at this point.
smatch analysis:
fs/lockd/svcsubs.c:366
Acked-by: Nadia Yvette Chambers
On February 12, 2013 at 1:17 PM Tim Gardner wrote:
> smatch analysis:
>
> fs/hugetlbfs/inode.c:883 hugetlbfs_fill_super() info: redundant null check on
> sbinfo->spool calling kfree()
>
> Cc: Nadia Yvette Chambers
> Signed-off-by: Tim Gardner
> ---
>
>
> > Do you btw. have any hints how I can convert to the cpu_idle thing you
> > hinted?
>
> If you have exactly 1 idle state, then cpuidle isn't that interesting,
> except, perhaps the standard residency counters. If you have multiple
> states to choose from, cpuidle becomes more valuable.
>
On Mon, Feb 11, 2013 at 01:43:58PM -0800, Dan Magenheimer wrote:
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
>
> > So, how about this, please draw up a specific plan for how you are going
> > to get this code out of drivers/staging/ I want to see the steps
> > involved, who is going to
On Tue, Feb 12, 2013 at 12:25:26PM -0500, Johannes Weiner wrote:
> On Tue, Feb 12, 2013 at 08:10:51AM -0800, Paul E. McKenney wrote:
> > On Tue, Feb 12, 2013 at 04:43:30PM +0100, Michal Hocko wrote:
> > > On Tue 12-02-13 10:10:02, Johannes Weiner wrote:
> > > > On Tue, Feb 12, 2013 at 10:54:19AM
The return code from the registration of the thermal class is used to
unallocate resources, but this failure isn't passed back to the caller of
thermal_init. Return this failure back to the caller.
This bug was introduced in changeset 4cb18728 which overwrote the return code
when the variable
From: Stephen Warren
Allow K: entries in MAINTAINERS to match directly against filenames;
either those extracted from patch +++ or --- lines, or those specified
on the command-line using the -f option.
This potentially allows fewer lines in a MAINTAINERS entry, if all the
relevant files are
On 02/12/2013 10:42 AM, Steven Rostedt wrote:
>
> And currently the output is just plain broken. This isn't a hack. You
> should have seen my first attempt. Now THAT was a hack! My first attempt
> was extremely intrusive, and required a lot of arch changes. But then I
> realized it was too much,
My Thinkpad T430s suspend/resumes fine most of the time. But every so often
(like one in ten times or so), as soon as I suspend, I get a black screen,
and a blinking power button.
(Note: Not the capslock lights like when we panic, this laptop 'conveniently
doesn't have those. This is the light
On Tue, Feb 12, 2013 at 01:03:04PM -0500, Len Brown wrote:
>
> >> Can you please move the definition of sparc_idle to processor_32.h
> >> It is sparc32 specific - and then we do not need the __ASSEMBLY__ guards
> >> as the sparc32 variant are not used from assembler.
> >
> > sure, let me know if
Quoting Stephen Warren (2013-02-12 09:46:25)
> On 02/12/2013 08:17 AM, Laxman Dewangan wrote:
> > Initialise the parent of UARTs to PLLP and disabling clock by
> > default.
>
> This patch wasn't tested, was it? Without the patch I just sent titled
> "ARM: tegra: remove clock-frequency properties
Even though nlmclnt_reclaim() is only one call into the stack frame,
928 bytes on the stack seems like a lot. Recode to dynamically
allocate the request structure once from within the reclaimer task,
then pass this pointer into nlmclnt_reclaim() for reuse on
subsequent calls.
smatch analysis:
Hi,
There seems to be an issue with gcov on kernel modules if you have an
arm-eabi gcc on Linux 3.8-rc6 and previous versions.
./arm-linux-gnueabi-gcc --version
arm-linux-gnueabi-gcc (GCC) 4.7.2
I followed these instructions [1], but without much success.
In case I compile an out of tree
On Tue, Feb 12, 2013 at 10:29 AM, Artem S. Tashkinov wrote:
> Feb 12, 2013 11:30:20 PM, Linus Torvalds wrote:
>>
>>A few things to try to pinpoint:
>>
>> (a) Is it *only* write performance that suffers, or is it other
>>performance too? Networking (DMA? Perhaps only writing *to* the
>>network?)?
301 - 400 of 1429 matches
Mail list logo