Frederic,
I noticed that an allnoconfig x86 build builds perf events.
I think it comes from this commit of yours:
commit 99e8c5a3b875a34d894a711c9a3669858d6adf45
Author: Frederic Weisbecker
Date: Thu Dec 17 01:33:54 2009 +0100
hw-breakpoints: Fix hardware breakpoints -> perf events
On 09/25/2013 03:37 PM, richard -rw- weinberger wrote:
> On Wed, Sep 25, 2013 at 4:28 PM, Thomas Meyer wrote:
>> Am Mittwoch, den 25.09.2013, 08:59 -0500 schrieb Rob Landley:
>>> On 09/24/2013 01:36:56 PM, Thomas Meyer wrote:
Hi,
Is there such a thing?
>>>
>>> In the kernel's vfs
On 09/28/2013 01:10 PM, Borislav Petkov wrote:
> On Sat, Sep 28, 2013 at 09:58:04PM +0200, Ingo Molnar wrote:
>> It's also probably the first time that code entered on an ordinary
>> cell phone has gets into the Linux kernel, so it's probably a new
>> Linux milestone, in a twisted, sick way. ;-)
>
2013/9/28 Sebastian Hesselbarth :
> On 09/22/2013 12:37 PM, Barry Song wrote:
>>
>> 2013/9/22 Sebastian Hesselbarth :
>>>
>>> On 09/19/2013 10:48 AM, Sebastian Hesselbarth wrote:
On 09/19/13 10:45, Barry Song wrote:
>>
>>
>> @@ -1124,3 +1106,4 @@ void __init
Hi Maxime,
El 26/09/13 10:13, Maxime Ripard escribió:
On Wed, Sep 25, 2013 at 08:23:14PM -0300, Emilio López wrote:
El 25/09/13 11:03, Maxime Ripard escribió:
Most of the Allwinner SoCs (at this time, all but the A10) also have a
High Speed timers that are not using the 24MHz oscillator as a
On 09/27/2013 10:29 AM, Chen Gang wrote:
> On 09/27/2013 02:33 AM, Paul E. McKenney wrote:
>> On Thu, Sep 26, 2013 at 10:57:39AM +0800, Chen Gang wrote:
>>> On 09/26/2013 04:16 AM, Paul E. McKenney wrote:
On Wed, Sep 25, 2013 at 10:55:30AM +0800, Chen Gang wrote:
>
> Thank you for
On Sat, Sep 28, 2013 at 1:28 AM, tip-bot for Borislav Petkov
wrote:
> Commit-ID: 646e29a1789a3a936871008c15199c50367bf291
> Gitweb: http://git.kernel.org/tip/646e29a1789a3a936871008c15199c50367bf291
> Author: Borislav Petkov
> AuthorDate: Fri, 27 Sep 2013 16:35:54 +0200
> Committer:
Hi Ingo,
I found problems about irq affinity in my machine, I don't know whether it's
my machine problem
or linux can not support irq affinity setting in my machine. Do you have time
to help point out that?
Thank you very much!
According to your Documentation/IRQ-Affiniy.txt
I try to test
On 09/27/2013 10:35 PM, Michael S. Tsirkin wrote:
> On Fri, Sep 27, 2013 at 01:57:24PM +0800, Jason Wang wrote:
>> We used to use a percpu structure vq_index to record the cpu to queue
>> mapping, this is suboptimal since it duplicates the work of XPS and
>> loses all other XPS functionality such
Hi Linus,
nothing too major, radeon still has some dpm changes for off by default.
radeon, intel, msm:
radeon a few more dpm fixes (still off by default), uvd fixes,
i915 runtime warn backtrace and regression fix
msm: iommu changes fallout,
Dave.
The following changes since commit
On Sat, 28 Sep 2013, Tomasz Figa wrote:
> A series of commit starting at
>
> 50a97e059b USB: OHCI: make ohci-exynos a separate driver
>
> and ending at
>
> b8ad5c3706 USB: OHCI: make ohci-pxa27x a separate driver
>
> introduced the concept of separate OHCI drivers for particular
>
On Sat, 2013-09-28 at 10:25 +0200, Ingo Molnar wrote:
> > [0.072367] x86: Booting node #0, CPUs: #1 #2 #3 #4 #5 #6 #7 <--
> > [0.686329] x86: Booted up 1 node, 8 CPUs
^
> - Added nodes count to the 'Booted up' line. Since we count nodes and
On 09/27/2013 08:19 PM, Chen Gang wrote:
> On 09/27/2013 07:53 PM, Tejun Heo wrote:
>> Hello,
>>
>> On Fri, Sep 27, 2013 at 03:16:59PM +0800, Chen Gang wrote:
>>> Hmm... do you mean: "can not evaluate an interface before implement(or
>>> read details) them all"?
>>
>> No, I'm saying there are a
On Friday 27 of September 2013 18:37:56 Yadwinder Singh Brar wrote:
> Hi Tomasz,
>
> On Thu, Sep 26, 2013 at 7:30 PM, Tomasz Figa wrote:
> > Hi Yadwinder,
> >
> > I haven't reviewed this series yet, but let me clarify some things
> > from
> > your comments.
> >
> > On Thursday 26 of September
On Saturday, September 28, 2013 08:18:18 PM Ronald wrote:
> [ resend, forgot to disable HTML (sorry!) ]
>
> Dear kernel developers,
>
> Commit 8fd37a4c9 (PM / hibernate: Create memory bitmaps after freezing
> user space) causes resume to fail.
>
> Only, when using the s2disk utility (through
Instead of calculating sizes of arrays manually, kcalloc() can be used
to allocate arrays of elements with defined size. This is just a cleanup
patch without any functional changes.
Signed-off-by: Tomasz Figa
---
drivers/clk/clk.c | 14 +++---
1 file changed, 7 insertions(+), 7
This function is supposed to iterate over all parents of given child
clock to find the index of given parent clock in its parent list,
using parent cache if possible and falling back to string compare
otherwise. However currently the logic falls back to string compare in
every iteration in which
There are at least two different error cases that can happen in
clk_fetch_parent_index() function:
- allocation failure,
- parent clock lookup failure,
however it returns only an u8, which is supposed to contain parent clock
index.
This patch modified the function to return full int instead
On Friday, September 27, 2013 04:44:20 PM Yinghai Lu wrote:
> [+ Rafael]
>
> On Fri, Sep 27, 2013 at 4:19 PM, Benjamin Herrenschmidt
> wrote:
> > On Fri, 2013-09-27 at 15:56 -0700, Yinghai Lu wrote:
> >
> >> ok, please if you are ok attached one instead. It will print some warning
> >> about
>
Hi Christoph,
On Tue, Sep 24, 2013 at 08:35:03AM +0200, Christoph Fritz wrote:
> On Mon, 2013-09-23 at 09:49 +0530, Vinod Koul wrote:
> > On Tue, Sep 17, 2013 at 03:56:05PM +0200, Michael Grzeschik wrote:
> > > Hello,
> > >
> > > this series is solving some lockdep issues in the imx-dma code.
>
Please, disconsider this e-mail.
Geyslan Gregório Bem
hackingbits.com
2013/9/28 Geyslan G. Bem :
> The *t variable in the fill_note_info function is only used if
> siginfo->si_signo isn't 0. Moving "t" pointer to that inner scope.
>
> Tested.
>
> Signed-off-by: Geyslan G. Bem
> ---
>
Please, disconsider this e-mail.
Geyslan Gregório Bem
hackingbits.com
2013/9/28 Geyslan G. Bem :
> Adjustment based on the checkpatch.pl.
>
> Tested.
>
> Signed-off-by: Geyslan G. Bem
> ---
> fs/exec.c | 92
> ++-
> 1 file changed,
Please, disconsider this e-mail.
Geyslan Gregório Bem
hackingbits.com
2013/9/28 Geyslan G. Bem :
> ia32_aout had no safe checks concerning the mmap and f_op in this module.
> It's not necessary to verify f_op in the load_aout_library, since the
> prior kernel_read/vfs_read function already
Please, disconsider this e-mail.
Geyslan Gregório Bem
hackingbits.com
2013/9/28 Geyslan G. Bem :
> file size used only once, so removed due its useless prior allocation.
> It's not necessary to verify f_op in the load_aout_library, since the
> prior kernel_read/vfs_read function already does.
>
There is no use of pointer 'fid' before the next assignment.
Signed-off-by: Geyslan G. Bem
---
fs/9p/vfs_inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index 94de6d1..7566477 100644
--- a/fs/9p/vfs_inode.c
+++
Get rid of the useless '*sb' variable.
Signed-off-by: Geyslan G. Bem
---
fs/9p/vfs_inode.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
index 7566477..b352457 100644
--- a/fs/9p/vfs_inode.c
+++ b/fs/9p/vfs_inode.c
@@ -783,7 +783,6 @@ struct dentry
Get rid of the useless 'err' variable, since the return is treated
farther down without the use of it.
Signed-off-by: Geyslan G. Bem
---
fs/9p/vfs_inode_dotl.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c
index a7c4814..a892c2f 100644
---
The *t variable in the fill_note_info function is only used if
siginfo->si_signo isn't 0. Moving "t" pointer to that inner scope.
Tested.
Signed-off-by: Geyslan G. Bem
---
fs/binfmt_elf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
file size used only once, so removed due its useless prior allocation.
It's not necessary to verify f_op in the load_aout_library, since the
prior kernel_read/vfs_read function already does.
Made coding style fixes and printk replacements.
Tested using qemu, a handcrafted a.out binary and an
ia32_aout had no safe checks concerning the mmap and f_op in this module.
It's not necessary to verify f_op in the load_aout_library, since the
prior kernel_read/vfs_read function already does.
Made coding style fixes and printks replacements.
Tested using qemu, a handcrafted a.out binary and an
In case of error in the p9_client_write, the function v9fs_fid_xattr_set
should return its negative value, what was never being done.
Signed-off-by: Geyslan G. Bem
---
fs/9p/xattr.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/fs/9p/xattr.c b/fs/9p/xattr.c
index
The 'name' variable was assigned but never used. Hence puts its
assignment to the top and makes proper use of its value.
Signed-off-by: Geyslan G. Bem
---
fs/9p/vfs_inode_dotl.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/fs/9p/vfs_inode_dotl.c
There is no use of pointer 'v9ses'. Get rid of useless 'retval'
assignment.
Signed-off-by: Geyslan G. Bem
---
fs/9p/vfs_inode_dotl.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c
index a892c2f..6803758 100644
--- a/fs/9p/vfs_inode_dotl.c
Adjustment based on the checkpatch.pl.
Tested.
Signed-off-by: Geyslan G. Bem
---
fs/exec.c | 92 ++-
1 file changed, 49 insertions(+), 43 deletions(-)
diff --git a/fs/exec.c b/fs/exec.c
index 8875dd1..b5c6086 100644
--- a/fs/exec.c
Get rid of the useless '*fid' variable.
Signed-off-by: Geyslan G. Bem
---
fs/9p/cache.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/9p/cache.c b/fs/9p/cache.c
index a9ea73d..50f9d9c 100644
--- a/fs/9p/cache.c
+++ b/fs/9p/cache.c
@@ -239,13 +239,12 @@ void
Get rid of the useless '*clnt' variable.
Signed-off-by: Geyslan G. Bem
---
fs/9p/vfs_file.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index aa5ecf4..42b7286 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -463,14 +463,12 @@
For negative numbers presumably we need to d++ for the minus sign, no?
Borislav Petkov wrote:
>On Sat, Sep 28, 2013 at 09:58:33PM +0200, Ingo Molnar wrote:
>>
>> * Borislav Petkov wrote:
>>
>> > On Sat, Sep 28, 2013 at 09:49:27PM +0200, Borislav Petkov wrote:
>> > > And yes, that one works
On Sat, Sep 28, 2013 at 04:53:08PM +0100, Charles Keepax wrote:
> > I don't see why this would only be an issue for ASoC - it happens to
> > I would suggest that rather than unconditionally doing this on lookup
> > it'd be easier to do it the other way round and explicitly add mappings
> > from
On Sat, Sep 28, 2013 at 08:21:36PM +0200, Tomasz Figa wrote:
> Since CONFIG_PLAT_S3C64XX is going to be removed, this patch modifies
> the s3c-i2s-v2 driver to use the proper way of checking for S3C64xx
> support - CONFIG_ARCH_S3C64XX.
Acked-by: Mark Brown
signature.asc
Description: Digital
Dear Beloved Friend,
I am Mrs Nicole Marois Benoite, and i have been suffering from ovarian
cancer disease and the doctor says that i have just few days to leave. I am
from (Paris) France but based in Africa Burkina Faso since eleven years ago as
a business woman dealing with gold
Am 29.09.2013 00:14, schrieb Elad Wexler:
> On Sat, Sep 28, 2013 at 08:54:55PM +0200, richard -rw- weinberger wrote:
>> On Sat, Sep 28, 2013 at 8:14 PM, wrote:
>>> From: Elad Wexler
>>>
>>> Driver doesn't do anything special in 'module_init'.
>>>
>>> 'module_platform_init' makes the code more
Hey, again.
On Sat, Sep 28, 2013 at 05:49:30PM -0400, Tejun Heo wrote:
> 0001-sysfs-remove-unused-sysfs_buffer-pos.patch
> 0002-sysfs-remove-sysfs_buffer-needs_read_fill.patch
> 0003-sysfs-remove-sysfs_buffer-ops.patch
> 0004-sysfs-add-sysfs_open_file_mutex.patch
>
On Sat, Sep 28, 2013 at 08:54:55PM +0200, richard -rw- weinberger wrote:
> On Sat, Sep 28, 2013 at 8:14 PM, wrote:
> > From: Elad Wexler
> >
> > Driver doesn't do anything special in 'module_init'.
> >
> > 'module_platform_init' makes the code more readable.
> >
> > Signed-off-by: Elad Wexler
->needs_read_fill is used to implement the following behaviors.
1. Ensure buffer filling on the first read.
2. Force buffer filling after a write.
3. Force buffer filling after a successful poll.
However, #2 and #3 don't really work as sysfs doesn't reset file
position. While the read buffer
sysfs read path will be converted to use seq_file which will handle
buffering making sysfs_buffer a misnomer. Rename sysfs_buffer to
sysfs_open_file, and sysfs_open_dirent->buffers to ->files.
This path is pure rename.
Signed-off-by: Tejun Heo
---
fs/sysfs/file.c | 127
sysfs will be converted to use seq_file for read path, which will make
it difficult to pass around multiple pointers directly. This patch
adds sysfs_open_file->sd and ->file so that we can reach all the
necessary data structures from sysfs_open_file.
flush_write_buffer() is updated to drop
sysfs bin file handling will be merged into the regular file support.
This patch prepares the llseek path.
sysfs currently unconditionally uses seq_lseek() whether the file
supports read or not, which means that sysfs_seq_show() may be used
purely for seeking even if the file doesn't implement
sysfs bin file handling will be merged into the regular file support.
This patch copies mmap support from bin so that fs/sysfs/file.c can
handle mmapping bin files.
The code is copied mostly verbatim with the following updates.
* ->mmapped and ->vm_ops are added to sysfs_open_file and bin_buffer
sysfs bin file handling will be merged into the regular file support.
This patch prepares the read path.
This is a bit tricky as read support is quite different between
regular and bin files. bin file supports arbitrarily large file size
and passes the read offset and size directly to the
sysfs bin file handling will be merged into the regular file support.
This patch prepares the write path.
bin file write is almost identical to regular file write except that
the write length is capped by the inode size and @off is passed to the
write method. This patch adds bin file handling to
Add a separate mutex to protect sysfs_open_dirent->buffers list. This
will allow performing sleepable operations while traversing
sysfs_buffers, which will be renamed to sysfs_open_file.
Note that currently sysfs_open_dirent->buffers list isn't being used
for anything and this patch doesn't make
sysfs bin file handling will be merged into the regular file support.
All three access paths - read, write and mmap - can now handle both
regular and bin files. This patch updates sysfs_open_file() and
sysfs_release() such that they can handle both regular and bin files.
This is a preparation
sysfs read path implements its own buffering scheme between userland
and kernel callbacks, which essentially is a degenerate duplicate of
seq_file. This patch replaces the custom read buffering
implementation in sysfs with seq_file.
While the amount of code reduction is small, this reduces low
With the previous changes, sysfs regular file code is ready to handle
bin files too. This patch makes bin files share the regular file
path.
* sysfs_create/remove_bin_file() are moved to fs/sysfs/file.c.
* sysfs_init_inode() is updated to use sysfs_file_operations for both
regular and bin
Signed-off-by: Tejun Heo
---
fs/sysfs/file.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index 1656a79..81e3f72 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -44,7 +44,6 @@ struct sysfs_open_dirent {
struct sysfs_buffer {
size_t
There isn't much to be gained by keeping around kernel buffer while a
file is open especially as the read path planned to be converted to
use seq_file and won't use the buffer. This patch makes
sysfs_write_file() use per-write transient buffer instead of
sysfs_open_file->page.
This simplifies
Currently, sysfs_ops is fetched during sysfs_open_file() and cached in
sysfs_buffer->ops to be used while the file is open. This patch
removes the caching and makes each operation directly fetch sysfs_ops.
This patch doesn't introduce any behavior difference and is to prepare
for merging regular
Hello,
Currently, sysfs's file handling is a bit weird.
* Regular and bin file paths are similar but implemented completely
separately duplicating some hairy logics.
* Read path implements custom buffering which is essentially
degenerate seq_file.
In addition, sysfs core implementation is
On Thu, Sep 26, 2013 at 11:59:51AM +0200, Veaceslav Falico wrote:
Currently, we first do kobject_put(>kobj) and the kfree(entry),
however kobject_put() doesn't guarantee us that it was the last reference
and that the kobj isn't used currently by someone else, so after we
kfree(entry) with the
On Thu, Sep 26, 2013 at 10:19:14AM +0200, Daniel Lezcano wrote:
> On 09/26/2013 08:17 AM, Viresh Kumar wrote:
> >On 26 September 2013 04:00, Daniel Lezcano wrote:
> >>If you introduce a list, you will have to introduce a lock to protect
> >>it.
> >
> >I missed it, should have added that :)
> >
>
On 09/28/2013 11:20 AM, Myklebust, Trond wrote:
-Original Message-
From: Miklos Szeredi [mailto:mik...@szeredi.hu]
Sent: Saturday, September 28, 2013 12:50 AM
To: Zach Brown
Cc: J. Bruce Fields; Ric Wheeler; Anna Schumaker; Kernel Mailing List; Linux-
Fsdevel; linux-...@vger.kernel.org;
On Thu, Sep 26, 2013 at 06:25:00PM +0100, Nick Warne wrote:
> Hi all,
>
> I have a strange problem, which has been on going on for ages, and I finally
> decided to look at it (as it is a pain in the arse).
>
> Brief details:
>
> Samsung N145 Plus running Slack 14 with handbuilt kernel
>
On Sat, Sep 28, 2013 at 09:51:14PM +0200, Wolfram Gloger wrote:
> Kees Cook writes:
>
> > Please note that these bounds checks aren't correct to begin with. Since
> > a pointer is being dereferenced, the end boundry must be reduced by
> > sizeof(unsigned long) as well.
> >
> > It looks like
On Sat, Sep 28, 2013 at 02:48:59PM +0200, Oleg Nesterov wrote:
> On 09/27, Peter Zijlstra wrote:
> >
> > On Fri, Sep 27, 2013 at 08:15:32PM +0200, Oleg Nesterov wrote:
> >
> > > > +static bool cpuhp_readers_active_check(void)
> > > > {
> > > > + unsigned int seq = per_cpu_sum(cpuhp_seq);
>
On Sat, Sep 28, 2013 at 1:27 PM, Al Viro wrote:
> FWIW, I think I have a kinda-sorta solution for that and I'd like
> to hear your comments on that. I want to replace vfsmount_lock with seqlock
> and store additional seq number in nameidata, set to vfsmount_seq in the
> beginning and
On Sat, Sep 28, 2013 at 10:33 PM, Woody Suwalski wrote:
> Warnings are gone with this patch (and other 4 patches since 3.2.12-rc2
> from drm tree).
Ok, fix should land in stable kernels soonish (depends upon how
quickly the pull request propagate). Thanks for reporting this issue
and testing
Guten Tag,
Mein Name ist Mr.SUN Zhijun, ich mit der Bank of China zu arbeiten. Ich brauche
Ihre Unterstützung in Durchführung einer Transaktion bei $ 18,5 Millionen
Dollar geschätzt, möchte ich Ihnen 30% der gesamten Mittel als Ausgleich für
Ihre Unterstützung in dieser Transaktion. Ich werde
Daniel Vetter wrote:
On Fri, Sep 27, 2013 at 7:27 PM, Woody Suwalski wrote:
Daniel Vetter wrote:
On Thu, Sep 26, 2013 at 2:36 PM, Woody Suwalski
wrote:
Daniel, I have noticed these warnings on 3.12-rc1, did not go away on
3.12-rc2.
I see it only on EeePC with i915,not on ThinkPad with
Arnaldo:
A few perf-stat cleanups.
David Ahern (3):
perf stat: Fix misleading message when specifying cpu list or system wide
perf stat: Don't require a workload when using system wide or CPU options
perf stat: Add units to nanosec-based counters
tools/perf/builtin-stat.c | 15
Ingo pointed out that the task-clock counter should have the units explicitly
stated since it is not a counter.
Before:
perf stat -a -- sleep 1
Performance counter stats for 'sleep 1':
16186.874834 task-clock # 16.154 CPUs utilized
...
After:
perf stat -a -- sleep 1
perf-stat can do system wide counters or one or more cpus. For
these options do not require a workload to be specified.
Signed-off-by: David Ahern
Cc: Ingo Molnar
Cc: Frederic Weisbecker
Cc: Peter Zijlstra
Cc: Jiri Olsa
Cc: Namhyung Kim
Cc: Stephane Eranian
---
tools/perf/builtin-stat.c |
perf-stat displays the command run in its summary output which is misleading
when using a cpu list or system wide collection.
Before:
perf stat -a -- sleep 1
Performance counter stats for 'sleep 1':
16152.670249 task-clock# 16.132 CPUs utilized
417 context-switches
FWIW, I think I have a kinda-sorta solution for that and I'd like
to hear your comments on that. I want to replace vfsmount_lock with seqlock
and store additional seq number in nameidata, set to vfsmount_seq in the
beginning and rechecked in unlazy_walk/complete_walk.
The obvious
On Fri, Sep 27, 2013 at 8:05 PM, Benjamin Herrenschmidt
wrote:
> On Fri, 2013-09-27 at 16:44 -0700, Yinghai Lu wrote:
>
> In the meantime, can you properly submit the other one with the warning
> to Linus ? It will make things more robust overall...
https://patchwork.kernel.org/patch/2959121/
--
BenH found:
| 928bea964827d7824b548c1f8e06eccbbc4d0d7d
| PCI: Delay enabling bridges until they're needed
break PCI on powerpc. The reason is that the PCIe port driver will
call pci_enable_device() on the bridge, so device enabled (but skip
pci_set_master because pcie_port_auto and no acpi on
On Sat, Sep 28, 2013 at 09:58:04PM +0200, Ingo Molnar wrote:
> It's also probably the first time that code entered on an ordinary
> cell phone has gets into the Linux kernel, so it's probably a new
> Linux milestone, in a twisted, sick way. ;-)
We could put the following comment *below* the
On Sat, Sep 28, 2013 at 09:58:33PM +0200, Ingo Molnar wrote:
>
> * Borislav Petkov wrote:
>
> > On Sat, Sep 28, 2013 at 09:49:27PM +0200, Borislav Petkov wrote:
> > > And yes, that one works too.
> >
> > Btw, just to be thorough, we could handle negative numbers too:
> >
> > int
Move the printk() calls to to dev_*() instead, to tie into the dynamic
debugging infrastructure.
Also change some "raw" printk() calls to dev_err() to provide a better
error message to userspace so it can properly identify the device and
not just have to guess.
Signed-off-by: Greg Kroah-Hartman
* Borislav Petkov wrote:
> On Sat, Sep 28, 2013 at 09:49:27PM +0200, Borislav Petkov wrote:
> > And yes, that one works too.
>
> Btw, just to be thorough, we could handle negative numbers too:
>
> int num_digits(int val)
> {
> int m = 10;
> int d = 1;
>
> if (val < 0)
* H. Peter Anvin wrote:
> How about:
>
> m = 10;
> d = 1;
>
> while ( val >= m ) {
> m *= 10;
> d++;
> }
>
> ... and not have a *divide* in there?
Yeah :-)
> Man, entering code on a cell phone sucks...
Indeed that explains the BASIC style! (and you got the 8-space tabs
On Sat, Sep 28, 2013 at 09:49:27PM +0200, Borislav Petkov wrote:
> And yes, that one works too.
Btw, just to be thorough, we could handle negative numbers too:
int num_digits(int val)
{
int m = 10;
int d = 1;
if (val < 0)
val = -val;
while (val
Kees Cook writes:
> Please note that these bounds checks aren't correct to begin with. Since
> a pointer is being dereferenced, the end boundry must be reduced by
> sizeof(unsigned long) as well.
>
> It looks like process_32.c suffers the same problems, too.
I can't see the end boundary problem
* Linus Torvalds wrote:
> On Sat, Sep 28, 2013 at 12:37 PM, Ingo Molnar wrote:
> >
> > - down_write_nest_lock(_vma->root->rwsem, >mmap_sem);
> > + down_write_nest_lock(_vma->root->rwlock,
> > >mmap_sem);
>
> That's just completely bogus, and cannot work.
>
>
On Sat, Sep 28, 2013 at 12:42:37PM -0700, H. Peter Anvin wrote:
> How about:
>
> m = 10;
> d = 1;
>
> while ( val >= m ) {
> m *= 10;
> d++;
> }
>
> ... and not have a *divide* in there?
Yep, I know why :-)
And yes, that one works too.
> Man, entering code on a cell phone
* Linus Torvalds wrote:
> On Sat, Sep 28, 2013 at 12:37 PM, Ingo Molnar wrote:
> >
> > - down_write_nest_lock(_vma->root->rwsem, >mmap_sem);
> > + down_write_nest_lock(_vma->root->rwlock,
> > >mmap_sem);
>
> That's just completely bogus, and cannot work.
Told you
On Sat, Sep 28, 2013 at 12:37 PM, Ingo Molnar wrote:
>
> - down_write_nest_lock(_vma->root->rwsem, >mmap_sem);
> + down_write_nest_lock(_vma->root->rwlock, >mmap_sem);
That's just completely bogus, and cannot work.
Maybe just a "write_lock(_vma->root->rwlock)" (which
How about:
m = 10;
d = 1;
while ( val >= m ) {
m *= 10;
d++;
}
... and not have a *divide* in there?
Man, entering code on a cell phone sucks...
Ingo Molnar wrote:
>
>* Borislav Petkov wrote:
>
>> @@ -2,6 +2,10 @@ int num_digits(int val)
>> {
>> int digits =
* Linus Torvalds wrote:
> On Sat, Sep 28, 2013 at 12:21 PM, Ingo Molnar wrote:
> >
> > If we do that then I suspect the next step will be queued rwlocks :-/ The
> > current rwlock_t implementation is rather primitive by modern standards.
> > (We'd probably have killed rwlock_t long ago if not
I see only patch #2 and #3.
Sort out why only 2 of the 3 patches were posted, and resend them
all.
Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
* Ingo Molnar wrote:
> If we do that then I suspect the next step will be queued rwlocks :-/
> The current rwlock_t implementation is rather primitive by modern
> standards. (We'd probably have killed rwlock_t long ago if not for the
> tasklist_lock.)
>
> But yeah, it would work and
From: Borislav Petkov
Turn it into (for example):
[0.073380] x86: Booting SMP configuration:
[0.074005] node #0, CPUs: #1 #2 #3 #4 #5 #6 #7
[0.603005] node #1, CPUs: #8 #9 #10 #11 #12 #13 #14 #15
[1.25] node #2, CPUs:
On Sat, Sep 28, 2013 at 12:21 PM, Ingo Molnar wrote:
>
> If we do that then I suspect the next step will be queued rwlocks :-/ The
> current rwlock_t implementation is rather primitive by modern standards.
> (We'd probably have killed rwlock_t long ago if not for the
> tasklist_lock.)
Yeah, I'm
* Borislav Petkov wrote:
> @@ -2,6 +2,10 @@ int num_digits(int val)
> {
> int digits = 0;
>
> + /* Handle special case */
> + if (!val)
> + return 1;
> +
> while (val) {
> val /= 10;
> digits++;
Hm. I suspect this could then be
On Sat, Sep 28, 2013 at 12:13 PM, Andi Kleen wrote:
>
> And afaik anon_vma is usually hold short.
Yes.
But the problem with anon_vma is that the "usually" may be the 99.9%
case, but then there are some insane loads that do tons of forking
without execve, and they really make some of the rmap
* Linus Torvalds wrote:
> On Sat, Sep 28, 2013 at 12:41 AM, Ingo Molnar wrote:
> >
> >
> > Yeah, I fully agree. The reason I'm still very sympathetic to Tim's
> > efforts is that they address a regression caused by a mechanic
> > mutex->rwsem conversion:
> >
> > 5a505085f043 mm/rmap: Convert
On Monday 2013-09-23 20:37, Joe Perches wrote:
>There are a mix of function prototypes with and without extern
>in the kernel sources. Standardize on not using extern for
>function prototypes.
>
>Function prototypes don't need to be written with extern.
>extern is assumed by the compiler. Its
On Sat, Sep 28, 2013 at 08:12:36PM +0200, Ingo Molnar wrote:
>
> * Borislav Petkov wrote:
>
> > - pr_info("Booting Node %3d, Processors:", node);
> > + printk(KERN_INFO " node #%3d, CPUs: ", node);
>
> I think this should use %*s# and num_digits(node)
record option is a convience alias to include the -e raw_syscalls:*
argument to perf-record. All other options are passed to perf-record's
handler. Resulting data file can be analyzed by perf-trace -i.
Signed-off-by: David Ahern
Cc: Ingo Molnar
Cc: Frederic Weisbecker
Cc: Peter Zijlstra
Cc:
Loop over all threads within a machine - including threads moved to the
dead threads list -- and invoked a function. This allows commands to run
some specific function on each thread (eg., dump statistics) yet hides
how the threads are maintained within the machine and
Signed-off-by: David Ahern
Task comm's are getting lost when processing events from a file. The problem is
that the trace struct used by the live processing has its host machine and the
perf-session used for file based processing has its host machine. Fix by
having both references point to the same machine.
Before:
1 - 100 of 512 matches
Mail list logo
