Hello everyone,
the current git HEAD of Linus Torvalds tree breaks Nouveau on my Mac Mini
Model 2010. I get variation of the following kernel panic when booting.
(gateway) [~] nc -u -l -p
[3.796018] ata1: SATA link up 3.0 Gbps (SStatus 123 SControl 300)
[3.796100] ata2: SATA link up
>
> usb: chipidea: put hw_phymode_configure before ci_usb_phy_init
>
> hw_phymode_configure configures the PORTSC registers and allow the
> following phy_inits to operate on the right parameters. This fix a
> problem
> where the UPLI (ISP1504) could not be detected, because the Viewport was
>
My other patch (the one that fixes the security issue) was already
applied, albeit it was sent after this one, see
https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/?h=staging-linus=559c71fe5dc3bf2ecc55afb336145db7f0abf810
, that is why I think there is some problem with
On Wed, Dec 04, 2013 at 09:56:18AM +0800, Chris Ruehl wrote:
> Fix Internal error: : 808 [#1] ARM related to STS flag
>
> * init the sts flag to 0 (missed)
> * fix write the real bit not sts value
> * Set PORTCS_STS and DEVLC_STS only if sts = 1
> (prefered solution by Mr. Peter Chen, Maintainer
Using ACPI_COMPANION to get ACPI device instead of acpi_bus_get_device().
Signed-off-by: Lan Tianyu
---
drivers/acpi/processor_driver.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
index
On Fri, Dec 06, 2013 at 08:05:38AM +0200, Ivajlo Dimitrov wrote:
> Hi Greg,
>
> On 01.12.2013 19:07, Ivaylo DImitrov wrote:
> >From: Ivaylo Dimitrov
> >
> >Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't
> >need to be exported. It can also be made way simpler by using
Change the order of the output to put the srcline last.
e.g. old format:
4028fc main+0x2c (/bin/ls)
/build/buildd/coreutils-8.20/src/ls.c:1269 => 40d8a0
set_program_name+0x0 (/bin/ls)
new format:
4028fc main+0x2c (/bin/ls) => 40d8a0
On Thu, Dec 5, 2013 at 10:00 AM, Dan Williams wrote:
> On Wed, Dec 4, 2013 at 5:36 PM, Qiao Zhou wrote:
>> sram driver can be used by many chips besides CPU_MMP2, and so build
>> it alone. Also need to select MMP_SRAM for MMP_TDMA driver.
>>
>> Reported-by: Dan Williams
>> Signed-off-by: Qiao
Add field 'srcline' that displays the source file name
and line number associated with the sample ip. The
information displayed is the same as from addr2line.
Signed-off-by: Adrian Hunter
---
tools/perf/Documentation/perf-script.txt | 2 +-
tools/perf/builtin-script.c | 10
The address being used to calculate the offset was
the memory address but the address needed is the
address mapped to the dso. i.e. the 'addr' member
of 'struct addr_location'
Signed-off-by: Adrian Hunter
---
tools/perf/util/session.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
Hi
Here is perf script srcline printing.
Changes in V2:
Also print scrline for callchains
Adrian Hunter (3):
perf script: Fix symoff printing in callchains
perf script: Add an option to print the source line number
perf script: Improve srcline display for BTS
On Thu, Dec 05, 2013 at 05:37:01PM +1100, dt.ta...@gmail.com wrote:
> From: Daniel Tang
>
> The device tree binding chosen for the nspire-usb driver was inappropriate and
> should be renamed to lsi,zevio-usb.
>
> References to nspire have been replaced with zevio (the SoC name)
>
>
(2013/12/06 0:11), Toshi Kani wrote:
On Thu, 2013-12-05 at 19:25 +0900, Yasuaki Ishimatsu wrote:
(2013/12/05 6:09), Toshi Kani wrote:
When ACPI SLIT table has an I/O locality (i.e. a locality unique
to an I/O device), numa_set_distance() emits the warning message
below.
NUMA: Warning: node
On Fri, 2013-12-06 at 10:11 +0300, Dan Carpenter wrote:
> On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote:
> > On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote:
> > > On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote:
> > > > On Fri, 2013-12-06 at 01:50 +0300, Dan
On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote:
> On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote:
> > On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote:
> > > On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote:
> > > > On Thu, Dec 05, 2013 at 10:23:53PM +0100,
> -Original Message-
> From: Vinod Koul [mailto:vinod.k...@intel.com]
> Sent: Thursday, November 28, 2013 2:08 PM
> To: Lu Jingchang-B35083
> Cc: Mark Rutland; devicet...@vger.kernel.org; Wang Huan-B18965; linux-
> ker...@vger.kernel.org; shawn@linaro.org; linux-arm-
>
Use devm_regulator_register() to make cleanup paths simpler,
and remove unnecessary remove().
Signed-off-by: Jingoo Han
---
drivers/regulator/stw481x-vmmc.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/regulator/stw481x-vmmc.c
Use devm_regulator_register() to make cleanup paths simpler,
and remove unnecessary remove().
Signed-off-by: Jingoo Han
---
drivers/regulator/pfuze100-regulator.c | 20 +++-
1 file changed, 3 insertions(+), 17 deletions(-)
diff --git a/drivers/regulator/pfuze100-regulator.c
On 2013/12/6 12:44, David Miller wrote:
> From: Yijing Wang
> Date: Fri, 6 Dec 2013 11:06:28 +0800
>
>> On 2013/12/6 6:06, Maciej W. Rozycki wrote:
>>> On Thu, 5 Dec 2013, Yijing Wang wrote:
>>>
Replace local marco DFX_BUS_PCI with PCI standard marco
dev_is_pci().
>>>
>>> Typos above:
Use devm_regulator_register() to make cleanup paths simpler.
Signed-off-by: Jingoo Han
---
drivers/regulator/gpio-regulator.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/regulator/gpio-regulator.c
b/drivers/regulator/gpio-regulator.c
index
Use devm_regulator_register() to make cleanup paths simpler.
Signed-off-by: Jingoo Han
---
drivers/regulator/fixed.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index 5ea64b9..f45cc1ac 100644
---
Use devm_regulator_register() to make cleanup paths simpler.
Signed-off-by: Jingoo Han
---
drivers/regulator/db8500-prcmu.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/regulator/db8500-prcmu.c b/drivers/regulator/db8500-prcmu.c
index
Use devm_regulator_register() to make cleanup paths simpler.
Signed-off-by: Jingoo Han
---
drivers/regulator/ab8500.c | 24
1 file changed, 4 insertions(+), 20 deletions(-)
diff --git a/drivers/regulator/ab8500.c b/drivers/regulator/ab8500.c
index 0f86695..c625468
On 12/06/2013 01:18 AM, Tejun Heo wrote:
> Hello, Vladimir.
>
> Thanks a lot for the report and fix; however, I really wanna make sure
> that only online css's become visible, so I wrote up a different fix.
> Can you please test this one?
Hi, Tejun
This patch fixes this bug, but I have a couple
>> I am not sure if this question is related, uprobes or ftrace code does
>> not define __kprobes, so is it safe to place kprobe on uprobes or
>> ftrace code?
>
> Yes, it is "safe" in qualitative meaning. But for ftrace code, it could
> give a performance impact by miss-hitting. Since uprobe is
On Mon, Dec 2, 2013 at 6:49 AM, Rafael J. Wysocki wrote:
>
> Scenario 5: pci_stop_and_remove_bus_device() is run concurrently
> for a device and its parent bridge via remove_callback().
>
> In that case both code paths attempt to acquire
> pci_remove_rescan_mutex. If the child device
Button GPEs have been enabled in the acpi_wake_device_init() during
boot and Button driver enables these GPEs second time. This causes
disabling these gpes via sysfs interface requires twice "echo disable
> /sys/firmware/acpi/interrupts/gpeXXX". This patch is to remove
related code in the Button
Hello Arnd,
> Do you have a strong reason to have your own defconfig file? We
> currently try to consolidate as much as possible into
> multi_v7_defconfig, so please see if you can extend that instead to
> do what you need.
There's no reason why we can't use the multi-platform defconfig. I'll
Use PCI standard macro dev_is_pci() instead of hardcoding.
Signed-off-by: Yijing Wang
---
drivers/net/ethernet/3com/3c59x.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethernet/3com/3c59x.c
b/drivers/net/ethernet/3com/3c59x.c
index ad5272b..af24c3c
Replace local macro DFX_BUS_PCI() with PCI standard macro
dev_is_pci().
Acked-by: Maciej W. Rozycki
Signed-off-by: Yijing Wang
---
drivers/net/fddi/defxx.c | 20 +++-
1 files changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/net/fddi/defxx.c
On Friday 06 December 2013 05:03 AM, Stephen Warren wrote:
On 12/05/2013 03:44 AM, Laxman Dewangan wrote:
This patch series convert dts files of all Tegra's platforms to use the pinctron
dt-binding macro for better readability.
I think this series looks fine now; I'll apply soon pending what
On Friday 06 December 2013 05:00 AM, Stephen Warren wrote:
On 12/05/2013 03:57 AM, Laxman Dewangan wrote:
From: Ashwini Ghuge
This adds a driver for the Tegra124 pinmux, and required
parameterization data for Tegra124.
The driver uses the common Tegra pincontrol driver utility
functions to
On Thu, Dec 5, 2013 at 5:21 PM, Rafael J. Wysocki wrote:
>>
>> The use-after-free problems *sound* like a reference counting issue.
>> Yinghai's patch [1] should fix some of this; how much is left after
>> that?
>>
>> [1]
>>
On Wed, Nov 27, 2013 at 11:07 PM, Yinghai Lu wrote:
> On Wed, Nov 27, 2013 at 7:02 PM, David Rientjes wrote:
> maybe not related, now in another system, linus's tree + Srikar's patch.
>
> got
>
> [ 33.546361] divide error: [#1]
> SMP
> [ 33.589436] Modules linked in:
> [ 33.592869]
On Friday 06 December 2013 04:47 AM, Stephen Warren wrote:
On 12/05/2013 03:57 AM, Laxman Dewangan wrote:
This device tree binding document describes the Tegra124 pincontrol
DT bindings. This document lists all valid properties, names, mux
options of Tegra124 pins.
Is this a repost of what
(2013/12/05 22:08), Sandeepa Prabhu wrote:
>> OK, I think the kprobe is like a strong medicine, not a toy,
>> since it can intercept most of the kernel functions which
>> may process a sensitive user private data. Thus even if we
>> fix all bugs and make it safe, I don't think we can open
>> it
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
---
drivers/net/macvtap.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 9093004..d271fb4 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -779,8 +779,6
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
Acked-by: Michael S. Tsirkin
---
drivers/vhost/net.c |4 ++--
drivers/vhost/scsi.c |2 +-
drivers/vhost/test.c |3 +--
drivers/vhost/vhost.c |4 +---
drivers/vhost/vhost.h |2 +-
5 files changed, 6 insertions(+), 9
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
---
drivers/net/macvtap.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index f599c47..4c6f84c 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -819,7
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
---
drivers/net/macvtap.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index d271fb4..f599c47 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -588,7
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
---
drivers/net/tun.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 782e38b..f9c935a 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -1289,8 +1289,7 @@ done:
}
From: Zhi Yong Wu
Since net-next is open now, it's time to post them again.
Zhi Yong Wu (6):
vhost: remove the dead branch
vhost: adjust vhost_dev_init() to be void
macvtap: remove the dead branch
macvtap: adjust macvtap_skb_to_vnet_hdr() to be void
macvtap: remove unused parameter in
From: Zhi Yong Wu
Since vhost_dev_init() forever return 0, some branches are never run,
therefore need to be removed.
Signed-off-by: Zhi Yong Wu
Acked-by: Michael S. Tsirkin
---
drivers/vhost/net.c |5 -
drivers/vhost/scsi.c |5 -
drivers/vhost/test.c |5 -
3 files
On Thu, Dec 5, 2013 at 12:40 PM, Alexei Starovoitov wrote:
>> On Tue, Dec 3, 2013 at 4:01 PM, Andi Kleen wrote:
>>>
>>> Can you do some performance comparison compared to e.g. ktap?
>>> How much faster is it?
>
> Did simple ktap test with 1M alloc_skb/kfree_skb toy test from earlier email:
>
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
---
drivers/net/macvtap.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 9093004..957cc5c 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -876,6 +876,8
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
---
drivers/net/tun.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 782e38b..e26cbea 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -1356,6 +1356,8 @@ static ssize_t
This patch adds unlikely() macro into the most of codes.
The basic rule is to add that when:
- checking unusual errors,
- checking page mappings,
- and the other unlikely conditions.
Cc: Chao Yu
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/checkpoint.c | 22 ++
fs/f2fs/data.c | 63
(2013/12/05 23:49), Frank Ch. Eigler wrote:
>
> Hi, Masami -
>
> masami.hiramatsu.pt wrote:
>
>> [...]
>> For the safeness of kprobes, I have an idea; introduce a whitelist
>> for dynamic events. AFAICS, the biggest unstable issue of kprobes
>> comes from putting *many* probes on the functions
On Fri, Dec 6, 2013 at 2:08 PM, Guenter Roeck wrote:
> On 12/05/2013 02:28 PM, Zhi Yong Wu wrote:
>>
>> From: Zhi Yong Wu
>>
>> Signed-off-by: Zhi Yong Wu
>> ---
>> drivers/net/macvtap.c |2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/macvtap.c
While unwinding backtrace, stack overflow is possible. This stack
overflow can sometimes lead to data abort in system if the area after
stack is not mapped to physical memory.
To prevent this problem from happening, execute the instructions that
can cause a data abort in separate helper
On 12/05/2013 02:28 PM, Zhi Yong Wu wrote:
From: Zhi Yong Wu
Signed-off-by: Zhi Yong Wu
---
drivers/net/macvtap.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 9093004..d271fb4 100644
---
On Friday 06 December 2013 04:49 AM, Stephen Warren wrote:
On 12/05/2013 04:16 PM, Stephen Warren wrote:
On 12/05/2013 03:57 AM, Laxman Dewangan wrote:
The tegra124 pinmux controller is identical to tegra114 with
removing some of existing pins from T114 and adding new pins.
I already sent
Hi Greg,
On 01.12.2013 19:07, Ivaylo DImitrov wrote:
From: Ivaylo Dimitrov
Custom uuid helper function is needed only in rmgr/dbdcd.c and doesn't
need to be exported. It can also be made way simpler by using sscanf.
Signed-off-by: Ivaylo Dimitrov
---
drivers/staging/tidspbridge/Makefile
> -Original Message-
> From: Joe Perches [mailto:j...@perches.com]
> Sent: Friday, December 06, 2013 1:22 AM
> To: Jagannadha Sutradharudu Teki
> Cc: linux-kernel@vger.kernel.org; Andy Whitcroft; Jagannadha Sutradharudu
> Teki
> Subject: Re: [PATCH] checkpatch: Do not hardcode perl path
>
On Fri, Dec 6, 2013 at 9:20 AM, Andi Kleen wrote:
> "H. Peter Anvin" writes:
>>
>> Not to mention that in that case we might as well -- since we need a
>> compiler anyway -- generate the machine code in user space; the JIT
>> solution really only is useful if it can provide something that we
On Thu, Dec 5, 2013 at 2:38 AM, Ingo Molnar wrote:
>
>> Also I'm thinking to add 'license_string' section to bpf binary format
>> and call license_is_gpl_compatible() on it during load.
>> If false, then just reject it…. not even messing with taint flags...
>> That would be way stronger
Hi,
On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote:
> Previously the of_phy_get function took a struct device * and
> was declared static. It was impossible to call it from
> another driver and thus it was impossible to get phy defined
It was never intended to be called from other
Hi Alexei,
On Thu, Dec 5, 2013 at 12:40 PM, Alexei Starovoitov wrote:
>> On Tue, Dec 3, 2013 at 4:01 PM, Andi Kleen wrote:
>>>
>>> Can you do some performance comparison compared to e.g. ktap?
>>> How much faster is it?
>
> Did simple ktap test with 1M alloc_skb/kfree_skb toy test from earlier
On Thu, Dec 5, 2013 at 5:20 PM, Andi Kleen wrote:
>> the difference is bigger now: 484-145 vs 185-145
>
> This is a obvious improvement, but imho not big enough to be extremely
> compelling (< cost 1-2 cache misses, no orders of magnitude improvements
> that would justify a lot of code)
hmm.
All objects, which are allocated in blk_mq_register_disk, must be
released in blk_mq_unregister_disk.
I use a KVM virtual machine and virtio disk to reproduce this issue.
kmemleak: 18 new suspected memory leaks (see /sys/kernel/debug/kmemleak)
$ cat /sys/kernel/debug/kmemleak | head -n 30
On Thu, Dec 5, 2013 at 3:37 PM, Steven Rostedt wrote:
> On Thu, 5 Dec 2013 14:36:58 -0800
> Alexei Starovoitov wrote:
>
>> On Thu, Dec 5, 2013 at 5:46 AM, Steven Rostedt wrote:
>> >
>> > I know that it would be great to have the bpf filter run before
>> > recording of the tracepoint, but as
From: Yijing Wang
Date: Fri, 6 Dec 2013 11:06:28 +0800
> On 2013/12/6 6:06, Maciej W. Rozycki wrote:
>> On Thu, 5 Dec 2013, Yijing Wang wrote:
>>
>>> Replace local marco DFX_BUS_PCI with PCI standard marco
>>> dev_is_pci().
>>
>> Typos above: marco -> macro
>
> Sorry for the mistake, David,
On numa machine, if a 32-bit kernel runs over it, node data cannot
be allocated from local node if the account of memory for node 0
covers the low memory space entirely:
[0.00] Initmem setup node 0 [mem 0x-0x83fff]
[0.00] NODE_DATA [mem 0x367ed000-0x367edfff]
[
From: Zhi Yong Wu
Date: Fri, 6 Dec 2013 10:24:01 +0800
> Since net-next is open now, it's time to post them out again.
Patches 5 and 7 are bug fixes, and should be submitted to 'net'
not 'net-next'.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
Hi,
> -Original Message-
> From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
> Sent: Friday, December 06, 2013 12:12 PM
> To: Chao Yu
> Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-f2fs-de...@lists.sourceforge.net; 谭姝
> Subject: Re: [f2fs-dev] [PATCH 2/5 V2]
Linus,
Please pull. Just some binding documentation updates and DT maintainers
updates.
Rob
The following changes since commit 6ce4eac1f600b34f2f7f58f9cd8f0503d79e42ae:
Linux 3.13-rc1 (2013-11-22 11:30:55 -0800)
are available in the git repository at:
> -Original Message-
> From: Wood Scott-B07421
> Sent: Friday, December 06, 2013 5:31 AM
> To: Bhushan Bharat-R65777
> Cc: Alex Williamson; linux-...@vger.kernel.org; ag...@suse.de; Yoder Stuart-
> B08248; io...@lists.linux-foundation.org; bhelg...@google.com; linuxppc-
>
> -Original Message-
> From: Wood Scott-B07421
> Sent: Friday, December 06, 2013 5:52 AM
> To: Bhushan Bharat-R65777
> Cc: Alex Williamson; linux-...@vger.kernel.org; ag...@suse.de; Yoder Stuart-
> B08248; io...@lists.linux-foundation.org; bhelg...@google.com; linuxppc-
>
Hi,
Just in case, if you agreed the following comments, I'll fix those and
merge the patch by myself.
Thanks,
2013-12-05 (목), 17:15 +0800, Chao Yu:
> As we know, some of our branch condition will rarely be true. So we could add
> 'unlikely' to let compiler optimize these code, by this way we
Fixed a pointer variable format issue.
Signed-off-by: Seth Archer Brown
---
drivers/usb/atm/usbatm.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/atm/usbatm.c b/drivers/usb/atm/usbatm.c
index 25a7bfc..dada014 100644
--- a/drivers/usb/atm/usbatm.c
Hi all,
Changes since 20131205:
The crypto tree gained a build failure so I used the version from
next-20131205.
Non-merge commits (relative to Linus' tree): 2639
2875 files changed, 111902 insertions(+), 72577 deletions
usb_deauthorize_device() tries to unset the configuration of a USB
device and then unconditionally blows away the configuration descriptors
with usb_destroy_configuration(). This is bad if the
usb_set_configuration() call failed before the configuration could be
correctly unset, since pointers
Function dmar_parse_dev_scope() should release the PCI device reference
count gained in function dmar_parse_one_dev_scope() on error recovery,
otherwise will cause PCI device object leakage.
This patch also introduces dmar_free_dev_scope(), which will be used
to support DMAR device hotplug.
This patchset includes several bugfixes and code improvements for
Intel DMA remapping and interrupt remapping drivers. It's also a
preparation for Intel IOMMU device hotplug.
It applies to the latest mainstream kernel on top of
commit 7e3528c3660a2e8602abc7858b0994d611f74bc3
It has been
Currently Intel interrupt remapping drivers uses the "present" flag bit
in remapping entry to track whether an entry is allocated or not.
It works as follow:
1) allocate a remapping entry and set its "present" flag bit to 1
2) compose other fields for the entry
3) update the remapping entry with
Function intel_iommu_domain_init() may be concurrently called by upper
layer without serialization, so use atomic_t to protect domain id
allocation.
Signed-off-by: Jiang Liu
---
drivers/iommu/intel-iommu.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Remove dead code from VT-d related files.
Signed-off-by: Jiang Liu
---
drivers/iommu/dmar.c|2 --
drivers/iommu/intel-iommu.c | 25 -
2 files changed, 27 deletions(-)
diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
index 70612a9..9a76073 100644
Use defined macro instead of hardcoding in function set_ioapic_sid()
for readability.
Signed-off-by: Jiang Liu
---
drivers/iommu/intel_irq_remapping.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel_irq_remapping.c
Field si_domain->id is set by iommu_attach_domain(), so we could only
print domain id for static identity domain after calling
iommu_attach_domain(si_domain, iommu).
Signed-off-by: Jiang Liu
---
drivers/iommu/intel-iommu.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git
The g_iommus array will be freed twice when failed to initialize IOMMU
devices, which will cause system panic.
Signed-off-by: Jiang Liu
---
drivers/iommu/intel-iommu.c | 14 +++---
1 file changed, 3 insertions(+), 11 deletions(-)
diff --git a/drivers/iommu/intel-iommu.c
Function free_dmar_iommu() may access domain->iommu_lock by
spin_unlock_irqrestore(>iommu_lock, flags);
after freeing corresponding domain structure.
Sample stack dump:
[8.912818] =
[8.917072] [ BUG: held lock freed! ]
[8.921335] 3.13.0-rc1-gerry+ #12
In function free_dmar_iommu(), it sets IRQ handler data to NULL
before calling free_irq(), which will cause invalid memory access
because free_irq() will access IRQ handler data when calling
function dmar_msi_mask(). So only set IRQ handler data to NULL
after calling free_irq().
Sample stack
Use helper dev_is_pci() instead of hardcoding.
Signed-off-by: Jiang Liu
---
drivers/iommu/intel-iommu.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index fc3473b..c1831d7 100644
---
Release associated invalidation queue when destroying IOMMU unit
to avoid memory leak.
Signed-off-by: Jiang Liu
---
drivers/iommu/dmar.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
index 812b596..a9d9d0f 100644
---
Clean up most sparse warnings in Intel DMA and interrupt remapping
drivers.
Signed-off-by: Jiang Liu
---
drivers/iommu/dmar.c|8
drivers/iommu/intel-iommu.c |4 ++--
drivers/iommu/intel_irq_remapping.c |4 ++--
drivers/iommu/irq_remapping.c |
Data structure drhd->iommu is shared between DMA remapping driver and
interrupt remapping driver, so DMA remapping driver shouldn't release
drhd->iommu when it failed to initialize IOMMU devices. Otherwise it
may cause invalid memory access to the interrupt remapping driver.
Sample stack dump:
[
If dmar_table_init() fails to detect DMAR table on the first call,
it will return wrong result on following calls because it always
sets dmar_table_initialized no matter if succeeds or fails to
detect DMAR table.
Signed-off-by: Jiang Liu
---
drivers/iommu/dmar.c | 29
Enhance intel_iommu_init() to free all resources if failed to
initialize DMAR hardware.
Signed-off-by: Jiang Liu
---
drivers/iommu/intel-iommu.c | 80 ++-
1 file changed, 48 insertions(+), 32 deletions(-)
diff --git a/drivers/iommu/intel-iommu.c
Flag irq_remapping_enabled is only set by intel_enable_irq_remapping(),
which is called after detect_intel_iommu(). So we should check flag
disable_irq_remap instead of irq_remapping_enabled in function
detect_intel_iommu().
Reviewed-by: Yijing Wang
Signed-off-by: Jiang Liu
---
Function detect_intel_iommu()/alloc_iommu()/parse_ioapics_under_ir()
are only used internally, so mark them as static.
Signed-off-by: Jiang Liu
---
drivers/iommu/dmar.c|9 ++---
drivers/iommu/intel_irq_remapping.c |4 +++-
include/linux/dmar.h| 12
On 12/05/2013 10:36 PM, Andrey Vagin wrote:
> free_netdev calls netif_napi_del too, but it's too late, because napi
> structures are placed on vi->rq. netif_napi_add() is called from
> virtnet_alloc_queues.
>
> general protection fault: [#1] SMP
> Dumping ftrace buffer:
>(ftrace buffer
Simplify vt-d related code with existing macros and introduce a new
macro for_each_active_drhd_unit() to enumerate all active DRHD unit.
Signed-off-by: Jiang Liu
---
drivers/iommu/dmar.c|7 ++---
drivers/iommu/intel-iommu.c | 55 ---
In Intel IOMMU driver, it calculate page table level from adjusted guest
address width as 'level = (agaw - 30) / 9', which assumes (agaw -30)
could be divided by 9. On the other hand, 64bit is a valid agaw and
(64 - 30) can't be divided by 9, so it needs special handling.
This patch enhances
Release allocated resources on error recovery path in function
iommu_init_domains().
Acked-by: Yijing Wang
Signed-off-by: Jiang Liu
---
drivers/iommu/intel-iommu.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
index
On 12/05/2013 01:07 AM, Yijing Wang wrote:
>
> handle_link_up_event() and handle_link_down_event() are almost the same,
> what about use like:
> handle_link_state_change_event(p_slot, event) to reuse the the common code ?
>
>
Sure, I can combine both of them to make it look more like this. Let
On 12/05/2013 10:36 PM, Andrey Vagin wrote:
> free_unused_bufs must check vi->mergeable_rx_bufs before
> vi->big_packets, because we use this sequence in other places.
> Otherwise we allocate buffer of one type, then free it as another
> type.
>
> general protection fault: [#1] SMP
> Dumping
On 2013/12/6 6:06, Maciej W. Rozycki wrote:
> On Thu, 5 Dec 2013, Yijing Wang wrote:
>
>> Replace local marco DFX_BUS_PCI with PCI standard marco
>> dev_is_pci().
>
> Typos above: marco -> macro
Sorry for the mistake, David, should i need to resend this patch to fix this
typo error?
>
>>
On Fri, Dec 06, 2013 at 11:38:51AM +1100, James Cameron wrote:
> On Fri, Dec 06, 2013 at 03:28:37AM +0400, Sergei Ianovich wrote:
> > pxa2xx-uart was a separate uart platform driver. It was declaring
> > the same device names and numbers as 8250 driver. As a result,
> > it was impossible to use
On Fri, Dec 06, 2013 at 03:28:37AM +0400, Sergei Ianovich wrote:
> pxa2xx-uart was a separate uart platform driver. It was declaring
> the same device names and numbers as 8250 driver. As a result,
> it was impossible to use 8250 driver on PXA SoCs.
>
> Upon closer examination pxa2xx-uart turned
Hi,
> -Original Message-
> From: Jaegeuk Kim [mailto:jaegeuk@samsung.com]
> Sent: Friday, December 06, 2013 9:43 AM
> To: Chao Yu
> Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-f2fs-de...@lists.sourceforge.net; 谭姝
> Subject: RE: [f2fs-dev] [PATCH 3/3]
1 - 100 of 1612 matches
Mail list logo
