Re: [PATCH 7/8] ASoC: atmel: document clock properties of the wm8904 driver

2014-03-18 Thread Bo Shen
Hi Mark, On 03/17/2014 07:55 PM, Mark Brown wrote: On Mon, Mar 17, 2014 at 05:45:40PM +0800, Bo Shen wrote: - compatible: "atmel,asoc-wm8904" - atmel,model: The user-visible name of this sound complex. + - clocks: A list of clocks needed by the wm8904 chip. + - clock-output-names:

linux-next: manual merge of the random tree with Linus' tree

2014-03-18 Thread Stephen Rothwell
Hi Theodore, Today's linux-next merge of the random tree got a conflict in arch/x86/include/asm/archrandom.h between commit 5bfce5ef55cb ("x86, kaslr: Provide randomness functions") from Linus' tree and commits e3be36e60bdc ("x86, random: Enable the RDSEED instruction") and 91a60dc7aa88 ("random:

[PATCH] cpufreq: remove unused notifier: CPUFREQ_{SUSPENDCHANGE|RESUMECHANGE}

2014-03-18 Thread Viresh Kumar
Two cpufreq notifiers CPUFREQ_RESUMECHANGE and CPUFREQ_SUSPENDCHANGE were unused since sometime. And so better remove them to clean code a bit. Signed-off-by: Viresh Kumar --- Documentation/cpu-freq/core.txt | 4 arch/arm/kernel/smp.c | 3 +--

Re: [firefly] [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

2014-03-18 Thread Daniel Baluta
>> Signed-off-by: Matei Oprea >> Cc: ROSEdu Kernel Community > > Why the cc: for a non-maintainer / person? We try to keep track of student's contributions in this way. Also, patches are internally reviewed on this mailing list before sending them to maintainers. thanks, Daniel. -- To

Re: [PATCHv4 3/5] mailbox: pl320: Introduce common API driver

2014-03-18 Thread Jassi Brar
On 19 March 2014 00:40, Rob Herring wrote: > On Tue, Mar 18, 2014 at 1:45 PM, Jassi Brar wrote: >> Convert the PL320 controller driver to work with the common >> mailbox API. Also convert the only user of PL320, highbank-cpufreq.c >> to work with thee API. Drop the obsoleted driver pl320-ipc.c

Re: [PATCH v3 0/2] Add stop callback to the cpufreq_driver interface.

2014-03-18 Thread Viresh Kumar
On 19 March 2014 06:23, Rafael J. Wysocki wrote: > On Tuesday, March 18, 2014 12:25:14 PM Dirk Brandewie wrote: >> On 03/18/2014 12:08 PM, Srivatsa S. Bhat wrote: >> > On 03/18/2014 10:52 PM, dirk.brande...@gmail.com wrote: >> >> From: Dirk Brandewie >> >> >> > >> > I don't mean to nitpick, but

Re: [PATCH 4/4] blk-mq: add a exit_request method

2014-03-18 Thread Ming Lei
On Mon, Mar 17, 2014 at 9:18 PM, Christoph Hellwig wrote: > This gives drivers an easy way to free any resources allocated in > ->init_request. > > Signed-off-by: Christoph Hellwig > --- > block/blk-mq.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH v2 2/2] intel_pstate: Set core to min P state during core offline

2014-03-18 Thread Viresh Kumar
On 19 March 2014 01:14, Dirk Brandewie wrote: > There was no problem per se. In stop() all I really needed to do is stop > the > timer and set the P state to MIN. > > At init time I need to allocate memory and start timer. If stopping the > timer > and deallocating memory are separated then I

Re: [PATCHv4 2/5] mailbox: Introduce framework for mailbox

2014-03-18 Thread Jassi Brar
On 19 March 2014 09:30, Girish KS wrote: > On Wed, Mar 19, 2014 at 12:15 AM, Jassi Brar wrote: >> +int mbox_send_message(struct mbox_chan *chan, void *mssg) >> +{ >> + int t; >> + >> + if (!chan || !chan->cl) >> + return -EINVAL; >> + >> + t = _add_to_rbuf(chan,

Re: [RFC 0/6] mm: support madvise(MADV_FREE)

2014-03-18 Thread Johannes Weiner
On Tue, Mar 18, 2014 at 05:23:37PM -0700, Andy Lutomirski wrote: > On Tue, Mar 18, 2014 at 5:18 PM, Minchan Kim wrote: > > Hello, > > > > On Tue, Mar 18, 2014 at 10:55:24AM -0700, Andy Lutomirski wrote: > >> On 03/13/2014 11:37 PM, Minchan Kim wrote: > >> > This patch is an attempt to support

Re: [PATCH 1/2] cpufreq: Add stop callback to cpufreq_driver interface

2014-03-18 Thread Viresh Kumar
On 18 March 2014 22:52, wrote: > From: Dirk Brandewie > > This callback allows the driver to do clean up before the CPU is > completely down and its state cannot be modified. This is used > by the intel_pstate driver to reduce the requested P state prior to > the core going away. This is

Re: [PATCH 0/2] Add exit_prepare callback to the cpufreq_driver interface.

2014-03-18 Thread Viresh Kumar
On 18 March 2014 17:46, Srivatsa S. Bhat wrote: > Agreed. As far as I understand, for ->target drivers, today we use GOV_STOP > to stop managing the CPU going offline. And for ->setpolicy drivers, we will > use this new callback to achieve the same goal. So a better question would be: What's the

Re: [PATCH 8/9] PCI: Ignore BAR contents when firmware left decoding disabled

2014-03-18 Thread Ming Lei
Hi, Looks Sasha fixed the problem in lkvm tool[1]. Sasha, looks we both saw the problem, but from technical view, I am wondering if the fix is correct, because PCI spec. requires that the IO/MMIO bits in COMMAND register should be cleared after reset, maybe there are some potential problem in

Re: [PATCH] timer: remove code redundancy while calling get_nohz_timer_target()

2014-03-18 Thread Viresh Kumar
On 18 March 2014 21:14, Frederic Weisbecker wrote: > On Tue, Mar 18, 2014 at 04:26:07PM +0530, Viresh Kumar wrote: >> + if (pinned || !get_sysctl_timer_migration() || !idle_cpu(cpu)) >> + return cpu; > > Maybe the pinned part should stay a caller detail. Although I don't really >

Re: [PATCH] charger-manager: Fix checking of wrong return type

2014-03-18 Thread Chanwoo Choi
Ping. Thanks, Chanwoo Choi On 03/17/2014 08:33 PM, Chanwoo Choi wrote: > This patch fix minor issue about checking wrong return type. > > The of_cm_parse_desc() return ERR_PTR(errnor number) when some error happen > in this function. But, charger_manager_probe() has only checked whether > desc

Re: [PATCH 2/2] INTEL-IGB: Convert iounmap to pci_iounmap

2014-03-18 Thread Jeff Kirsher
On Tue, 2014-03-18 at 17:11 +0100, Peter Senna Tschudin wrote: > Use pci_iounmap instead of iounmap when the virtual mapping was done > with pci_iomap. A simplified version of the semantic patch that finds > this > issue is as follows: (http://coccinelle.lip6.fr/) > > // > @r@ > expression

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 Thread DaeSeok Youn
Thanks for reply. I will do that. Regards, Daeseok Youn. 2014-03-19 11:31 GMT+09:00 Greg KH : > On Wed, Mar 19, 2014 at 10:04:40AM +0900, DaeSeok Youn wrote: >> oh... >> You didn't get my reply about vmalloc usage. >> >> My replay attach again, below. >> >> > 2014-03-18 9:37 GMT+09:00 Greg KH :

linux-next: manual merge of the staging tree with the drm tree

2014-03-18 Thread Stephen Rothwell
Hi Greg, Today's linux-next merge of the staging tree got conflicts in drivers/staging/imx-drm/imx-hdmi.c, drivers/staging/imx-drm/imx-ldb.c, drivers/staging/imx-drm/imx-tve.c and drivers/staging/imx-drm/parallel-display.c between commits 69fa5293bf8d ("drm/kms: rip out

Re: For review: open_by_name_at(2) man page [v2]

2014-03-18 Thread NeilBrown
On Tue, 18 Mar 2014 13:55:15 +0100 "Michael Kerrisk (man-pages)" wrote: > Hi Aneesh, (and others) > > After integrating review comments from NeilBown and Christoph Hellwig, > here is draft 2 of a man page I've written for name_to_handle_at(2) and > open_by_name_at(2). Especially thanks to

Re: [PATCH 2/2] arm64: dts: exynos: added mailbox node

2014-03-18 Thread Girish KS
On Mon, Mar 17, 2014 at 7:36 PM, Mark Rutland wrote: > On Mon, Mar 17, 2014 at 12:03:59PM +, Girish K S wrote: >> This patch adds the dt node for the mailbox IP >> >> Signed-off-by: Girish K S >> >> Change-Id: I35e45e9a62592887a84a909aee54f259a2f731fa >> --- >>

Re: [PATCHv4 2/5] mailbox: Introduce framework for mailbox

2014-03-18 Thread Girish KS
On Wed, Mar 19, 2014 at 12:15 AM, Jassi Brar wrote: > Introduce common framework for client/protocol drivers and > controller drivers of Inter-Processor-Communication (IPC). > > Client driver developers should have a look at > include/linux/mailbox_client.h to understand the part of > the API

Re: [PATCH 1/2] mailbox: samsung: added support for samsung mailbox

2014-03-18 Thread Girish KS
On Tue, Mar 18, 2014 at 4:26 PM, Joe Perches wrote: > On Tue, 2014-03-18 at 15:52 +0530, Girish KS wrote: >> On Mon, Mar 17, 2014 at 5:33 PM, Girish K S wrote: > > Hi, just some trivial notes about the patch > >> > diff --git a/drivers/mailbox/mailbox-samsung.c >> >

Re: [PATCH] mfd: sec-core: Fix I2C dummy device resource leak on probe failure

2014-03-18 Thread Sachin Kamat
On 18 March 2014 18:27, Krzysztof Kozlowski wrote: > Dummy I2C device allocated in sec_pmic_probe() leaked if > devm_regmap_init_i2c() failed. Unregister it before returning from > probe. > > Signed-off-by: Krzysztof Kozlowski Looks good. Reviewed-by: Sachin Kamat -- With warm regards,

[PATCH RESEND -mm 1/2] mm: add !pte_present() check on existing hugetlb_entry callbacks

2014-03-18 Thread Naoya Horiguchi
Page table walker doesn't check non-present hugetlb entry in common path, so hugetlb_entry() callbacks must check it. The reason for this behavior is that some callers want to handle it in its own way. However, some callers don't check it now, which causes unpredictable result, for example when

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Luis R. Rodriguez
On Tue, Mar 18, 2014 at 8:10 PM, Stephen Hemminger wrote: > On Wed, 12 Mar 2014 20:15:25 -0700 > "Luis R. Rodriguez" wrote: > >> As it is now if you add create a bridge it gets started >> with a random MAC address and if you then add a net_device >> as a slave but later kick it out you end up

Re: [PATCH 8/9] PCI: Ignore BAR contents when firmware left decoding disabled

2014-03-18 Thread Ming Lei
On Tue, Mar 18, 2014 at 8:27 AM, Bjorn Helgaas wrote: > On Fri, Mar 14, 2014 at 09:48:35AM +0800, Ming Lei wrote: >> On Fri, Mar 14, 2014 at 12:08 AM, Bjorn Helgaas wrote: >> > On Thu, Mar 13, 2014 at 2:51 AM, Ming Lei wrote: >> >> Hi Bjorn, >> >> >> >> I found this patch broke virtio-pci

[PATCH v3] mac80211: LLVMLinux: Remove VLAIS usage from mac80211

2014-03-18 Thread behanw
From: Jan-Simon Möller Replaced the use of a Variable Length Array In Struct (VLAIS) with a C99 compliant equivalent. This is the original VLAIS struct. struct { struct aead_request req; u8 priv[crypto_aead_reqsize(tfm)]; } aead_req; This patch instead

Re: performance regression due to commit e82e0561("mm: vmscan: obey proportional scanning requirements for kswapd")

2014-03-18 Thread Hugh Dickins
On Tue, 18 Mar 2014, Yuanhan Liu wrote: > On Sat, Mar 15, 2014 at 08:56:10PM -0700, Hugh Dickins wrote: > > On Fri, 14 Mar 2014, Mel Gorman wrote: > > > > > > You say it's already been tested for months but it would be nice if the > > > workload that generated this thread was also tested. > > >

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-18 Thread David Miller
From: Stephen Rothwell Date: Tue, 18 Mar 2014 18:27:52 +1100 > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > net/netfilter/nft_hash.c: In function 'nft_hash_tbl_free': > net/netfilter/nft_hash.c:79:3: error: implicit declaration of

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Stephen Hemminger
On Wed, 12 Mar 2014 20:15:25 -0700 "Luis R. Rodriguez" wrote: > As it is now if you add create a bridge it gets started > with a random MAC address and if you then add a net_device > as a slave but later kick it out you end up with a zero > MAC address. Instead preserve the original random MAC >

Re: linux-next: build failure after merge of the final tree (net-next tree related)

2014-03-18 Thread David Miller
From: Stephen Rothwell Date: Mon, 17 Mar 2014 21:21:00 +1100 > After merging the final tree, today's linux-next build (powerpc > allyesconfig) failed like this: > > drivers/net/ethernet/intel/i40evf/built-in.o:(.data+0x1868): multiple > definition of `i40e_ptype_lookup' >

Re: [PATCH 3/4] blk-mq: replace blk_mq_init_commands with a ->init_request method

2014-03-18 Thread Ming Lei
On Mon, Mar 17, 2014 at 9:18 PM, Christoph Hellwig wrote: > Bedides a simpler and cleared interface this also allows to initialize the > flush_rq properly. The interface for that is still a bit messy as we don't > have a hw_ctx available for the flush request, but that's something that > should

Re: [PATCH] printk: fix one circular lockdep warning about console_lock

2014-03-18 Thread Jane Li
On 02/12/2014 05:19 AM, Andrew Morton wrote: On Tue, 11 Feb 2014 14:50:00 +0800 wrote: From: Jane Li This patch tries to fix a warning about possible circular locking dependency. If do in following sequence: enter suspend -> resume -> plug-out CPUx (echo 0 > cpux/online) lockdep

[PATCH] checkpatch: Improve octal permissions test speed

2014-03-18 Thread Joe Perches
The current octal permissions test is very slow. When commit 3fc9249967 ("checkpatch: add checks for constant non-octal permissions") was added, processing time approximately tripled. Regain almost all of the performance by not looping through all the possible functions unless the line contains

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Linus Torvalds
On Tue, Mar 18, 2014 at 7:37 PM, Hugh Dickins wrote: > > For 3.15, and probably 3.16 too, we should keep in place whatever > partial accommodations we have for the case (such as allowing for > anon and swap in fremap's zap_pte), in case we do need to revert; > but clean those away later on. (Not

Re: [PATCHv2 4/8] devfreq: exynos4: Fix bug of resource leak and code clean on probe()

2014-03-18 Thread Chanwoo Choi
Hi Tomasz, On 03/18/2014 09:18 PM, Tomasz Figa wrote: > On 17.03.2014 06:05, Chanwoo Choi wrote: >> Hi Tomasz, >> >> On 03/15/2014 02:49 AM, Tomasz Figa wrote: >>> Hi Chanwoo, >>> >>> On 13.03.2014 09:17, Chanwoo Choi wrote: This patch fix bug about resource leak when happening probe fail

Re: [PATCHv2 3/8] devfreq: exynos4: Add ppmu's clock control and code clean about regulator control

2014-03-18 Thread Chanwoo Choi
Hi Tomasz, On 03/18/2014 08:13 PM, Tomasz Figa wrote: > Hi Chanwoo, > > On 17.03.2014 06:59, Chanwoo Choi wrote: >> Hi Tomasz, >> >> On 03/17/2014 11:51 AM, Chanwoo Choi wrote: >>> Hi Tomasz, >>> >>> On 03/15/2014 02:42 AM, Tomasz Figa wrote: Hi Chanwoo, On 13.03.2014 09:17,

[PATCH RESEND -mm 2/2] mm/mempolicy.c: add comment in queue_pages_hugetlb()

2014-03-18 Thread Naoya Horiguchi
We have a race where we try to migrate an invalid page, resulting in hitting VM_BUG_ON_PAGE in isolate_huge_page(). queue_pages_hugetlb() is OK to fail, so let's check !PageHeadHuge to keep invalid hugepage from queuing. Reported-by: Sasha Levin Signed-off-by: Naoya Horiguchi ---

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Sasha Levin
On 03/18/2014 10:12 PM, Hugh Dickins wrote: On Tue, 18 Mar 2014, Sasha Levin wrote: On 03/18/2014 08:38 PM, Hugh Dickins wrote: On Tue, 11 Mar 2014, Dave Jones wrote: On Tue, Mar 11, 2014 at 09:36:03PM +0400, Cyrill Gorcunov wrote: > On Tue, Mar 11, 2014 at 01:10:45PM -0400, Dave Jones

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Hugh Dickins
On Tue, 18 Mar 2014, Linus Torvalds wrote: > On Tue, Mar 18, 2014 at 7:06 PM, Hugh Dickins wrote: > > > > I'd love that, if we can get away with it now: depends very > > much on whether we then turn out to break userspace or not. > > Right. I suspect we can, though, but it's one of those "we can

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 Thread Greg KH
On Wed, Mar 19, 2014 at 10:04:40AM +0900, DaeSeok Youn wrote: > oh... > You didn't get my reply about vmalloc usage. > > My replay attach again, below. > > > 2014-03-18 9:37 GMT+09:00 Greg KH : > >> On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: > >>> I think vmalloc/kmalloc in

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Linus Torvalds
On Tue, Mar 18, 2014 at 7:06 PM, Hugh Dickins wrote: > > I'd love that, if we can get away with it now: depends very > much on whether we then turn out to break userspace or not. Right. I suspect we can, though, but it's one of those "we can try it and see". Remind me early in the 3.15 merge

Re: [PATCH RFC] sched: introduce add_wait_queue_exclusive_head

2014-03-18 Thread Peng Tao
On Wed, Mar 19, 2014 at 12:23 AM, Oleg Nesterov wrote: > On 03/18, Peng Tao wrote: >> >> On Tue, Mar 18, 2014 at 10:05 PM, Peter Zijlstra >> wrote: >> > >> > Unless you cannot use ___wait() and really need to open-code the >> > wait_event() stuff. >> > >> Lustre's private l_wait_event() stuff

Re: [PATCH 1/3 Resend] tracing: Use inline task_nice() to get rid of an open coded implementation of it.

2014-03-18 Thread Dongsheng Yang
On 03/19/2014 10:15 AM, Steven Rostedt wrote: On Wed, 12 Mar 2014 18:26:42 +0800 Dongsheng Yang wrote: Function task_nice() was reimplemented as inline function, we can use it here to replace the open coded implementation. Signed-off-by: Dongsheng Yang cc: Steven Rostedt ---

[map_pages] 66431c4de99: -55.4% proc-vmstat.pgfault

2014-03-18 Thread Fengguang Wu
Hi Kirill, FYI, we noticed decreased page faults and increased mapped pages on git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master commit 66431c4de9921a9b3c7f3556bada4285912aedb7 ("mm: implement ->map_pages for page cache") c9161c06019b342 66431c4de9921a9b3c7f3556b

Re: [PATCH 3/3] sched: Use clamp() and clamp_val() to make it more readable.

2014-03-18 Thread Dongsheng Yang
On 03/19/2014 10:16 AM, Steven Rostedt wrote: On Wed, 12 Mar 2014 18:26:44 +0800 Dongsheng Yang wrote: As Kees suggested, I use clamp() function to replace the if and else branch, making it more readable and modular. Suggested-by: Kees Cook Signed-off-by: Dongsheng Yang ---

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Hugh Dickins
On Tue, 18 Mar 2014, Dave Jones wrote: > On Tue, Mar 18, 2014 at 10:06:02PM -0400, Dave Jones wrote: > > On Tue, Mar 18, 2014 at 09:32:36PM -0400, Sasha Levin wrote: > > > > > > Untested patch below: I can't quite say Reported-by, because it may > > > > not even be one that you and Sasha

Re: [PATCH RFC] sched: introduce add_wait_queue_exclusive_head

2014-03-18 Thread Peng Tao
On Tue, Mar 18, 2014 at 11:47 PM, Oleg Nesterov wrote: > On 03/18, Peter Zijlstra wrote: >> >> I think we can avoid the entire function if we add >> WQ_FLAG_LIFO and make prepare_to_wait_event() DTRT. > > Agreed, this looks very natural. > > prepare_to_wait_event(WQ_FLAG_LIFO) should probably

Re: [PATCH 3/3] sched: Use clamp() and clamp_val() to make it more readable.

2014-03-18 Thread Steven Rostedt
On Wed, 12 Mar 2014 18:26:44 +0800 Dongsheng Yang wrote: > As Kees suggested, I use clamp() function to replace the if and > else branch, making it more readable and modular. > > Suggested-by: Kees Cook > Signed-off-by: Dongsheng Yang > --- > kernel/sched/core.c | 11 ++- > 1 file

Re: [PATCH 1/3 Resend] tracing: Use inline task_nice() to get rid of an open coded implementation of it.

2014-03-18 Thread Steven Rostedt
On Wed, 12 Mar 2014 18:26:42 +0800 Dongsheng Yang wrote: > Function task_nice() was reimplemented as inline function, we can use it here > to replace the open coded implementation. > > Signed-off-by: Dongsheng Yang > cc: Steven Rostedt > --- > kernel/trace/trace.c | 2 +- > 1 file changed, 1

Re: [tip:x86/urgent] x86 idle: Repair large-server 50-watt idle-power regression

2014-03-18 Thread Jason Low
On Tue, Mar 18, 2014 at 2:16 AM, Peter Zijlstra wrote: > On Mon, Mar 17, 2014 at 05:20:10PM -0700, Davidlohr Bueso wrote: >> On Thu, 2013-12-19 at 11:51 -0800, tip-bot for Len Brown wrote: >> > Commit-ID: 40e2d7f9b5dae048789c64672bf3027fbb663ffa >> > Gitweb: >> >

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Hugh Dickins
On Tue, 18 Mar 2014, Sasha Levin wrote: > On 03/18/2014 08:38 PM, Hugh Dickins wrote: > > On Tue, 11 Mar 2014, Dave Jones wrote: > > > On Tue, Mar 11, 2014 at 09:36:03PM +0400, Cyrill Gorcunov wrote: > > > > On Tue, Mar 11, 2014 at 01:10:45PM -0400, Dave Jones wrote: > > > > > > > > > > >

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Dave Jones
On Tue, Mar 18, 2014 at 10:06:02PM -0400, Dave Jones wrote: > On Tue, Mar 18, 2014 at 09:32:36PM -0400, Sasha Levin wrote: > > > > Untested patch below: I can't quite say Reported-by, because it may > > > not even be one that you and Sasha have been seeing; but I'm hopeful, > > >

Fitted K*itchens North London

2014-03-18 Thread gelaan
Fitted K*itchens North London w w w . e x d i s p l a y k i t c h e n s 1 . c o . u k. Fitted K*itchens in North London for only £595 including appliances. Full fitted K*itchens only £595. Fitted K*itchens North London -- View this message in context:

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Hugh Dickins
On Tue, 18 Mar 2014, Linus Torvalds wrote: > On Tue, Mar 18, 2014 at 5:38 PM, Hugh Dickins wrote: > > > > And yes, it is possible (though very unusual) to find an anon page or > > swap entry in a VM_SHARED nonlinear mapping: coming from that horrid > > get_user_pages(write, force) case which COWs

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Dave Jones
On Tue, Mar 18, 2014 at 09:32:36PM -0400, Sasha Levin wrote: > > Untested patch below: I can't quite say Reported-by, because it may > > not even be one that you and Sasha have been seeing; but I'm hopeful, > > remap_file_pages is in the list. > > > > Please give this a try, preferably on

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree

2014-03-18 Thread Ben Widawsky
> I have used the drm-intel tree from next-20140318 for today. > > > > Bah! I'm still suffering from jet lag (just came back from Linux-Tage > in Chemnitz). > > The next time I compile test a patch for a module, I'll make sure I have > that module's config option se

Re: [PATCH] gpio: iop: fix devm_ioremap_resource() return value checking

2014-03-18 Thread Alexandre Courbot
On Tue, Mar 18, 2014 at 6:58 PM, Bartlomiej Zolnierkiewicz wrote: > devm_ioremap_resource() returns a pointer to the remapped memory or > an ERR_PTR() encoded error code on failure. Fix the check inside > iop3xx_gpio_probe() accordingly. Acked-by: Alexandre Courbot -- To unsubscribe from this

Re: [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure

2014-03-18 Thread Joe Perches
On Wed, 2014-03-19 at 12:46 +1100, Finn Thain wrote: > On Tue, 18 Mar 2014, Joe Perches wrote: > > > But using "if (0)" prevents the no_printk from occurring at all so there > > would be no side-effects and the format & args would still be verified > > by the compiler. > > I'd prefer this (for

[PATCH v2] Documentation: LLVMLinux: Update Documentation/dontdiff

2014-03-18 Thread behanw
From: Jan-Simon Möller Clang has a few other kinds of derived files which shouldn't be added to a patch. Add them to the Documentation/dontdiff file to prevent this. Signed-off-by: Jan-Simon Möller Signed-off-by: Behan Webster Cc: PaX Team --- Documentation/dontdiff | 3 +++ 1 file changed,

[PATCH v3] net: netfilter: LLVMLinux: vlais-netfilter

2014-03-18 Thread behanw
From: Mark Charlebois Replaced non-standard C use of Variable Length Arrays In Structs (VLAIS) in xt_repldata.h with a C99 compliant flexible array member and then calculated offsets to the other struct members. These other members aren't referenced by name in this code, however this patch

Re: [PATCH] gpiolib: check if gpio_desc pointer is error or NULL

2014-03-18 Thread Alexandre Courbot
On Tue, Mar 18, 2014 at 7:41 PM, Ben Dooks wrote: > Some of the gpiod_ calls take a pointer to a gpio_desc as their > argument but only check to see if it is NULL to validate the > input. > > Calls such as devm_gpiod_get() return an error-pointer if they > fail, so doing the following will not

Re: [RFC/PATCHSET 00/14] perf report: Add -F option for specifying output fields (v2)

2014-03-18 Thread Namhyung Kim
On Wed, Mar 19, 2014 at 1:43 AM, David Ahern wrote: > On 3/18/14, 7:30 PM, Namhyung Kim wrote: >> >> Hi David, >> >> On Tue, Mar 18, 2014 at 3:07 PM, David Ahern wrote: >>> >>> On 3/18/14, 12:32 AM, Namhyung Kim wrote: This is a patchset implementing -F/--field option to setup

Re: [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure

2014-03-18 Thread Finn Thain
On Tue, 18 Mar 2014, Joe Perches wrote: > But using "if (0)" prevents the no_printk from occurring at all so there > would be no side-effects and the format & args would still be verified > by the compiler. I'd prefer this (for symmetry and clarity): #if NDEBUG #define dprintk(flg, fmt, ...)

Re: [patch v3]DM: dm-insitu-comp: a compressed DM target for SSD

2014-03-18 Thread Shaohua Li
On Tue, Mar 18, 2014 at 05:28:43PM -0400, Mike Snitzer wrote: > On Tue, Mar 18 2014 at 3:41am -0400, > Shaohua Li wrote: > > > On Mon, Mar 17, 2014 at 04:00:40PM -0400, Mike Snitzer wrote: > > > > > > I folded your changes in, and then committed a patch ontop that cleans > > > some code up.

Re: [RFC/PATCHSET 00/14] perf report: Add -F option for specifying output fields (v2)

2014-03-18 Thread David Ahern
On 3/18/14, 7:30 PM, Namhyung Kim wrote: Hi David, On Tue, Mar 18, 2014 at 3:07 PM, David Ahern wrote: On 3/18/14, 12:32 AM, Namhyung Kim wrote: This is a patchset implementing -F/--field option to setup output field/column as Ingo requested. It depends on my perf/percentage patchset (with

Occational random segfault on Cortex-A15 when exiting SIGCHLD handler.

2014-03-18 Thread Lennart Sorensen
I have been trying to track down the cause of some random segfaults for the last couple of weeks. They were mostly showing up in one particular program (confdc which is part of confd from tail-f, but is essentially just the erlang 14 VM with some erlang modules running and the segfault is

Re: [PATCH v11 24/27] iommu/exynos: use exynos-iommu specific typedef

2014-03-18 Thread Grant Grundler
On Thu, Mar 13, 2014 at 10:13 PM, Cho KyongHo wrote: > This commit introduces sysmmu_pte_t for page table entries and > sysmmu_iova_t vor I/O virtual address that is manipulated by > exynos-iommu driver. The purpose of the typedef is to remove > dependencies to the driver code from the change of

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Sasha Levin
On 03/18/2014 08:38 PM, Hugh Dickins wrote: On Tue, 11 Mar 2014, Dave Jones wrote: On Tue, Mar 11, 2014 at 09:36:03PM +0400, Cyrill Gorcunov wrote: > On Tue, Mar 11, 2014 at 01:10:45PM -0400, Dave Jones wrote: > > > > > > Dave, iirc trinity can write log file pointing which exactly

Re: [RFC/PATCHSET 00/14] perf report: Add -F option for specifying output fields (v2)

2014-03-18 Thread Namhyung Kim
Hi David, On Tue, Mar 18, 2014 at 3:07 PM, David Ahern wrote: > On 3/18/14, 12:32 AM, Namhyung Kim wrote: >> >> This is a patchset implementing -F/--field option to setup output >> field/column as Ingo requested. It depends on my perf/percentage >> patchset (with minor updates) [1]. > > >

RE: [PATCH v2] pwm: add support for Intel Low Power Subsystem PWM

2014-03-18 Thread Chew, Chiau Ee
> On Fri, Feb 28, 2014 at 10:50:57PM +0800, Chew Chiau Ee wrote: > > From: Mika Westerberg > > > > Add support for Intel Low Power I/O subsystem PWM controllers found on > > Intel BayTrail SoC. > > > > Signed-off-by: Mika Westerberg > > Signed-off-by: Chew, Kean Ho > > Signed-off-by: Chang,

[PATCH v2] drm/i915: Do not dereference pointers from ring buffer in evict event

2014-03-18 Thread Steven Rostedt
The TP_printk() should never dereference any pointers, because the ring buffer can be read at some unknown time in the future. If a device no longer exists, it can cause a kernel oops. This also makes this event useless when saving the ring buffer in userspaces tools such as perf and trace-cmd.

Re: linux-next: build failure after merge of the drm-intel tree

2014-03-18 Thread Steven Rostedt
On Wed, 19 Mar 2014 11:53:50 +1100 Stephen Rothwell wrote: > Caused by commit a25ca17c1eac ("drm/i915: Do not dereference pointers > from ring buffer in evict event"). > > I have used the drm-intel tree from next-20140318 for today. > Bah! I'm still suffering fro

Re: [drbd] Kernel panic - not syncing: Out of memory and no killable processes...

2014-03-18 Thread Fengguang Wu
Hi Philipp, On Tue, Mar 18, 2014 at 03:30:16PM +0100, Lars Ellenberg wrote: > On Tue, Mar 18, 2014 at 10:07:17PM +0800, Fengguang Wu wrote: > > Greetings, > > > > We get the below OOM errors in our KVM boot tests and they are > > bisected to > > > > commit

Re: [PATCH v3 1/3] clk: s2mps11: Add support for S2MPS14 clocks

2014-03-18 Thread Mike Turquette
On Tue, Mar 18, 2014 at 6:09 PM, Mike Turquette wrote: > Quoting Krzysztof Kozlowski (2014-03-17 02:19:16) >> This patch adds support for S2MPS14 PMIC clocks (BT and AP) to the >> s2mps11 clock driver. >> >> Signed-off-by: Krzysztof Kozlowski >> Reviewed-by: Yadwinder Singh Brar >> Reviewed-by:

linux-next: build failure after merge of the sound-asoc tree

2014-03-18 Thread Stephen Rothwell
daifmt, ^ Caused by commit 56556f333ae3 ("ASoC: simple-card: overwrite cpu_dai->fmt with codec_dai->fmt"). daifmt was removed from struct simple_card_data in commit c56c4d74c6f9 ("ASoC: simple-card: Simplify code"). I have used the sound-asoc tree from next-2014031

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Luis R. Rodriguez
On Tue, Mar 18, 2014 at 6:04 PM, Toshiaki Makita wrote: > (2014/03/19 9:50), Luis R. Rodriguez wrote: >> On Tue, Mar 18, 2014 at 5:42 PM, Toshiaki Makita >> wrote: >>> nit, >>> If the last detached port happens to have the same addr as >>> random_init_addr, this seems to call

Re: [PATCH v3 1/3] clk: s2mps11: Add support for S2MPS14 clocks

2014-03-18 Thread Mike Turquette
Quoting Krzysztof Kozlowski (2014-03-17 02:19:16) > This patch adds support for S2MPS14 PMIC clocks (BT and AP) to the > s2mps11 clock driver. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Yadwinder Singh Brar > Reviewed-by: Tomasz Figa Taken into clk-next. Regards, Mike > --- >

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Linus Torvalds
On Tue, Mar 18, 2014 at 5:38 PM, Hugh Dickins wrote: > > And yes, it is possible (though very unusual) to find an anon page or > swap entry in a VM_SHARED nonlinear mapping: coming from that horrid > get_user_pages(write, force) case which COWs even in a shared mapping. Hmm. Maybe we could just

Re: [PATCH v3 2/5] pwm: kona: Introduce Kona PWM controller support

2014-03-18 Thread Tim Kryger
On Tue, Mar 18, 2014 at 4:47 PM, Tim Kryger wrote: > On Tue, Mar 18, 2014 at 2:52 PM, Thierry Reding > wrote: >> On Wed, Mar 12, 2014 at 01:15:43PM -0700, Tim Kryger wrote: >>> + >>> + /* There is polarity support in HW but it is easier to manage in SW */ >>> + if (pwm->polarity ==

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Toshiaki Makita
(2014/03/19 9:50), Luis R. Rodriguez wrote: > On Tue, Mar 18, 2014 at 5:42 PM, Toshiaki Makita > wrote: >> nit, >> If the last detached port happens to have the same addr as >> random_init_addr, this seems to call br_stp_change_bridge_id() even >> though bridge_id is not changed. > > Ah good

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 Thread DaeSeok Youn
oh... You didn't get my reply about vmalloc usage. My replay attach again, below. > 2014-03-18 9:37 GMT+09:00 Greg KH : >> On Tue, Mar 18, 2014 at 09:26:07AM +0900, DaeSeok Youn wrote: >>> I think vmalloc/kmalloc in uislib_malloc() can be removed and just use >>> vmalloc/kmalloc directly. >> >>

Re: [PATCH v11 17/27] iommu/exynos: remove calls to Runtime PM API functions

2014-03-18 Thread Cho KyongHo
On Tue, 18 Mar 2014 16:09:50 +0100, Tomasz Figa wrote: > On 18.03.2014 10:56, Cho KyongHo wrote: > > On Fri, 14 Mar 2014 13:59:00 +0100, Tomasz Figa wrote: > >> Hi KyongHo, > >> > >> On 14.03.2014 06:08, Cho KyongHo wrote: > > [snip] > > >>> -static bool __exynos_sysmmu_disable(struct

Re: [PATCH] staging: wlags49_h2: Coding style correction

2014-03-18 Thread Greg KH
On Wed, Mar 19, 2014 at 01:52:09AM +0100, Mathieu Maret wrote: > As the file was mixing tab and space, reindent the file > Mainly correct use of C99 comments, > space between parenthesis, > remove commented code > > Signed-off-by: Mathieu Maret > --- > drivers/staging/wlags49_h2/wl_netdev.c |

Re: [PATCH] s390: correct misuses of module_put in appldata_generic_handler.

2014-03-18 Thread Zhouyi Zhou
Delicate design! thanks for replying, sorry for the trouble On Tue, Mar 18, 2014 at 9:34 PM, Gerald Schaefer wrote: > On Tue, 18 Mar 2014 09:24:55 +0800 > Zhouyi Zhou wrote: > >> Thanks Gerald for reviewing and sorry for not elaborated it in the e-mail. >> >> Firstly, I think you can't call

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 Thread Greg KH
On Wed, Mar 19, 2014 at 09:03:49AM +0900, DaeSeok Youn wrote: > Hi, greg. > > Review my comment below. What comment? confused, greg k-h- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] staging: unisys: use kzalloc instead of kmalloc/memset 0

2014-03-18 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Wed, Mar 19, 2014 at 09:09:59AM +0900, DaeSeok Youn wrote: > Hi, Ken > Thanks for review. > > But I have a question, I wan to know why tracing buffer > status(Malloc_FailuresAlloc,

Re: [PATCH 9/9] powerpc/pm: support deep sleep feature on T1040

2014-03-18 Thread Chenhui Zhao
On Tue, Mar 18, 2014 at 05:42:09PM -0500, Scott Wood wrote: > On Mon, 2014-03-17 at 19:19 +0800, Chenhui Zhao wrote: > > On Fri, Mar 14, 2014 at 06:18:27PM -0500, Scott Wood wrote: > > > On Wed, 2014-03-12 at 18:40 +0800, Chenhui Zhao wrote: > > > > On Tue, Mar 11, 2014 at 08:10:24PM -0500, Scott

linux-next: build failure after merge of the drm-intel tree

2014-03-18 Thread Stephen Rothwell
ot;). I have used the drm-intel tree from next-20140318 for today. -- Cheers, Stephen Rothwell pgpVfa3HCVJ7H.pgp Description: PGP signature

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Luis R. Rodriguez
On Tue, Mar 18, 2014 at 5:42 PM, Toshiaki Makita wrote: > nit, > If the last detached port happens to have the same addr as > random_init_addr, this seems to call br_stp_change_bridge_id() even > though bridge_id is not changed. Ah good point. > Shouldn't the assignment of random_init_addr be

Re: [PATCH 00/12] scsi/NCR5380: fix debugging macros and #include structure

2014-03-18 Thread Joe Perches
On Wed, 2014-03-19 at 10:14 +1100, Finn Thain wrote: > As for side-effects, chip register accesses would be affected if dprintk() > expanded to no_printk() when NDEBUG & flg == 0. > > E.g. NCR5380.c line 1213: > dprintk(NDEBUG_INTR, "scsi : unknown interrupt, BASR 0x%X, MR 0x%X, SR > 0x%x\n",

Re: [PATCH 0/6] perf tools: Share map groups within process

2014-03-18 Thread Namhyung Kim
Hi Jiri, On Tue, Mar 18, 2014 at 2:46 PM, Jiri Olsa wrote: > hi, > this patchset moves thread's map_groups to be dynamically > allocated and shared within process threads. > > The main benefit would be to be able to look up memory > map from any thread that belongs to the process. > > This

Re: [PATCH 1/3] bridge: preserve random init MAC address

2014-03-18 Thread Toshiaki Makita
(2014/03/13 12:15), Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > As it is now if you add create a bridge it gets started > with a random MAC address and if you then add a net_device > as a slave but later kick it out you end up with a zero > MAC address. Instead preserve the original

Re: bad rss-counter message in 3.14rc5

2014-03-18 Thread Hugh Dickins
On Tue, 11 Mar 2014, Dave Jones wrote: > On Tue, Mar 11, 2014 at 09:36:03PM +0400, Cyrill Gorcunov wrote: > > On Tue, Mar 11, 2014 at 01:10:45PM -0400, Dave Jones wrote: > > > > > > > > Dave, iirc trinity can write log file pointing which exactly syscall > sequence > > > > was passed,

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-18 Thread Cho KyongHo
On Tue, 18 Mar 2014 15:26:48 +0100, Tomasz Figa wrote: > > > On 18.03.2014 14:01, Cho KyongHo wrote: > > On Fri, 14 Mar 2014 17:12:03 +0100, Tomasz Figa wrote: > >> Hi KyongHo, > >> > >> On 14.03.2014 06:10, Cho KyongHo wrote: > >>> Some master device descriptor like fimc-is which is an

Re: [PATCH v3 0/2] Add stop callback to the cpufreq_driver interface.

2014-03-18 Thread Rafael J. Wysocki
On Tuesday, March 18, 2014 12:25:14 PM Dirk Brandewie wrote: > On 03/18/2014 12:08 PM, Srivatsa S. Bhat wrote: > > On 03/18/2014 10:52 PM, dirk.brande...@gmail.com wrote: > >> From: Dirk Brandewie > >> > > > > I don't mean to nitpick, but generally its easier to deal with > > patchsets if you

[PATCH 3/5] f2fs: increase pages_skipped when skipping writepages

2014-03-18 Thread Jaegeuk Kim
This patch increases pages_skipped when skipping writepages. Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 11 ++- fs/f2fs/data.c | 6 +- fs/f2fs/node.c | 6 +- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/checkpoint.c

[PATCH 1/5] f2fs: introduce get_dirty_dents for readability

2014-03-18 Thread Jaegeuk Kim
The get_dirty_dents gives us the number of dirty dentry pages. Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 2 +- fs/f2fs/f2fs.h | 5 + fs/f2fs/inode.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/checkpoint.c b/fs/f2fs/checkpoint.c

[PATCH 4/5] f2fs: introduce nr_pages_to_write for segment alignment

2014-03-18 Thread Jaegeuk Kim
This patch introduces nr_pages_to_write to align page writes to the segment or other operational unit size, which can be tuned according to the system environment. Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 11 ++- fs/f2fs/data.c | 12 +++- fs/f2fs/node.c

[PATCH 5/5] f2fs: call f2fs_wait_on_page_writeback instead of native function

2014-03-18 Thread Jaegeuk Kim
If a page is on writeback, f2fs can face with deadlock due to under writepages. This is caused by merging IOs inside f2fs, so if it comes to detect, let's throw merged IOs, which is implemented by f2fs_wait_on_page_writeback. Signed-off-by: Jaegeuk Kim --- fs/f2fs/checkpoint.c | 6 ++

  1   2   3   4   5   6   7   8   9   10   >