From: Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven
Cc: Rafael J. Wysocki
Cc: linux...@vger.kernel.org
---
drivers/base/power/generic_ops.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/power/generic_ops.c b/drivers/base/power/generic_ops.c
index
From: Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven
Cc: Tejun Heo
---
include/linux/workqueue.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 704f4f652d0a..7ee010c0640c 100644
---
From: Geert Uytterhoeven
The example uses foo_process_next_request() everywhere else.
Signed-off-by: Geert Uytterhoeven
---
Documentation/power/runtime_pm.txt |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/power/runtime_pm.txt
From: Geert Uytterhoeven
As of commit 05aa55dddb9ee4045c320661068bea78dad6a6e5 ("PM / Runtime:
Lenient generic runtime pm callbacks"), the generic power management
callbacks pm_generic_runtime_suspend() and pm_generic_runtime_resume()
return 0, not -EINVAL, if the device doesn't provide its own
From: Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven
---
Documentation/power/runtime_pm.txt | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/power/runtime_pm.txt
b/Documentation/power/runtime_pm.txt
index a5683a5662cb..f62deb66d5c1 100644
From: Geert Uytterhoeven
dev_pm_info.runtime_error has always been a signed int, to store a signed
error code. Correct the documentation.
Signed-off-by: Geert Uytterhoeven
---
Documentation/power/runtime_pm.txt |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: Geert Uytterhoeven
Update the documentation for the removal of GENERIC_SUBSYS_PM_OPS in commit
90363ddf0a1a4dccfbb8d0c10b8f488bc7fa69f8 ("PM: Drop generic_subsys_pm_ops")
Signed-off-by: Geert Uytterhoeven
---
Documentation/power/runtime_pm.txt | 11 ---
1 file changed, 4
Hi,
> OK I read them and it seems that in order to change the scheduler, I have to
> write a C code and call the sched_set* functions. Please correct that if I am
> wrong.
>
> So in order to use my custom scheduler, I have to do the following steps.
>
> 1- Write my code using the APIs and
On Mon, Mar 24, 2014 at 09:20:45PM +0100, Andi Kleen wrote:
> On Mon, Mar 24, 2014 at 04:17:57PM -0400, Don Zickus wrote:
> > On Mon, Mar 24, 2014 at 12:54:31PM -0700, Andi Kleen wrote:
> > > Don Zickus writes:
> > >
> > > > In order for the c2c tool to work correctly, it needs to properly
> > >
On Mon, Mar 24, 2014 at 01:17:12PM -0400, Mikulas Patocka wrote:
>
>
> On Mon, 24 Mar 2014, Daniel Vetter wrote:
>
> > On Mon, Mar 24, 2014 at 07:45:47AM +1000, Dave Airlie wrote:
> > > On Mon, Mar 24, 2014 at 7:27 AM, Andreas Mohr wrote:
> > > > On Sun, Mar 23, 2014 at 09:39:16AM -0700, Linus
On Mon, 2014-03-24 at 10:45 -0700, Joe Perches wrote:
> Using addressof then casting to the original type is pointless,
> so remove these unnecessary casts.
>
> Done via coccinelle script:
>
> $ cat typecast.cocci
> @@
> type T;
> T foo;
> @@
>
> - (T *)
> +
>
> Signed-off-by:
Casting a pointer to a pointer of the same type is pointless,
so remove these unnecessary casts.
Around these changes:
o Remove unnecessary parentheses
o Use consistent dereference style (change ptr[0] to *ptr)
o Argument alignment
Done via coccinelle script: (and some typing)
$ cat
On Mon, 2014-03-24 at 13:15 -0700, Joe Perches wrote:
> Casting a pointer to a pointer of the same type is pointless,
> so remove these unnecessary casts.
>
> Done via coccinelle script:
>
> $ cat typecast_2.cocci
> @@
> type T;
> T *foo;
> @@
>
> - (T *)foo
> + foo
>
>
Starting from c4ad8f98bef7 "execve: use 'struct filename *' for
executable name passing" bprm->filename can not go away after
flush_old_exec(), so we do not need to save the binary name in
bprm->tcomm[] added by 96e02d158678 "exec: fix use-after-free
bug in setup_new_exec()".
And there was never
On Mon, Mar 24, 2014 at 04:17:57PM -0400, Don Zickus wrote:
> On Mon, Mar 24, 2014 at 12:54:31PM -0700, Andi Kleen wrote:
> > Don Zickus writes:
> >
> > > In order for the c2c tool to work correctly, it needs to properly
> > > sort all the records on uniquely identifiable data addresses. These
On Wed, 05 Mar 2014 21:00:56 +0900
Masami Hiramatsu wrote:
> kernel/kprobes.c | 61
> +++---
> 1 file changed, 53 insertions(+), 8 deletions(-)
>
> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index a21b4e6..3214289 100644
> ---
Casting a pointer to a pointer of the same type is pointless,
so remove these unnecessary casts.
Done via coccinelle script:
$ cat typecast_2.cocci
@@
type T;
T *foo;
@@
- (T *)foo
+ foo
Signed-off-by: Joe Perches
---
drivers/net/ethernet/atheros/alx/main.c | 2 +-
1 file
All of these are pointless...
Joe Perches (7):
altera: Remove casts of pointer to same type
alx: Remove casts of pointer to same type
intel: Remove casts of pointer to same type
qlcnic: Remove casts of pointer to same type
carl9170: Remove casts of pointer to same type
mwifiex: Remove
On Mon, Mar 24, 2014 at 12:54:31PM -0700, Andi Kleen wrote:
> Don Zickus writes:
>
> > In order for the c2c tool to work correctly, it needs to properly
> > sort all the records on uniquely identifiable data addresses. These
> > unique addresses are converted from virtual addresses provided by
Casting a pointer to a pointer of the same type is pointless,
so remove these unnecessary casts.
Done via coccinelle script:
$ cat typecast_2.cocci
@@
type T;
T *foo;
@@
- (T *)foo
+ foo
Signed-off-by: Joe Perches
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c | 2 +-
Casting a pointer to a pointer of the same type is pointless,
so remove these unnecessary casts.
Done via coccinelle script:
$ cat typecast_2.cocci
@@
type T;
T *foo;
@@
- (T *)foo
+ foo
Signed-off-by: Joe Perches
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++--
1
Casting a pointer to a pointer of the same type is pointless,
so remove these unnecessary casts.
Done via coccinelle script:
$ cat typecast_2.cocci
@@
type T;
T *foo;
@@
- (T *)foo
+ foo
Signed-off-by: Joe Perches
---
drivers/net/wireless/ath/carl9170/rx.c | 2 +-
1 file changed,
Casting a pointer to a pointer of the same type is pointless,
so remove these unnecessary casts.
Done via coccinelle script:
$ cat typecast_2.cocci
@@
type T;
T *foo;
@@
- (T *)foo
+ foo
Signed-off-by: Joe Perches
---
drivers/net/ethernet/altera/altera_tse_main.c | 4 ++--
1 file
Casting a pointer to a pointer of the same type is pointless,
so remove these unnecessary casts.
Done via coccinelle script:
$ cat typecast_2.cocci
@@
type T;
T *foo;
@@
- (T *)foo
+ foo
Signed-off-by: Joe Perches
---
drivers/net/wireless/mwifiex/pcie.c | 6 +++---
On Wed, 05 Mar 2014 21:00:49 +0900
Masami Hiramatsu wrote:
> Use NOKPROBE_SYMBOL macro to protect functions from
> kprobes instead of __kprobes annotation in sched/core.c.
>
> Signed-off-by: Masami Hiramatsu
> Cc: Ingo Molnar
> Cc: Peter Zijlstra
> ---
Reviewed-by: Steven Rostedt
-- Steve
On Wed, 05 Mar 2014 21:00:42 +0900
Masami Hiramatsu wrote:
> Use NOKPROBE_SYMBOL macro to protect functions from
> kprobes instead of __kprobes annotation in notifier.
>
> Signed-off-by: Masami Hiramatsu
> /*
> * Blocking notifier chain routines. All access to the chain is
> @@ -527,7
On Wed, 05 Mar 2014 21:00:35 +0900
Masami Hiramatsu wrote:
> -static __kprobes
> +static
> int kretprobe_dispatcher(struct kretprobe_instance *ri, struct pt_regs *regs)
again, static and int should be on the same line.
> {
> struct trace_kprobe *tk = container_of(ri->rp, struct
This patch documents the proposed functionality of idlestat tool and
states its intended use for scheduler benchmarking. The documentation
file describes the design of the tool, what kernel functionality it
relies upon, and what information is contained in the output report.
It also contains a
Conclusions from Energy Aware Scheduling sessions at the latest Kernel Summit
identified a need for tools that would assess power consumption of the system
These tools would be used to prove efficiency of scheduler patches by
comparing power consumption before and after they were applied.
On Mon, 24 Mar 2014, Liu Hua wrote:
> In 32-bit ARM systems, the fixmap mapping region can support
> no more than 14 CPUs(total: 896k; one CPU: 64K). And we can
> configure NR_CPUS up to 32. So there is a mismatch.
>
> This patch extends the fixmapping region downwards to boundary
> of DMA
Hi Peter,
Em Mon, 24 Mar 2014 16:34:17 +0100
Peter Senna Tschudin escreveu:
> Hi,
>
> I'm being blamed for some bugs for more than one year, and this
> weekend I was able to reproduce the error for the first time. I have
> the impression that the issue is related to Kconfig because when
>
On 2014-03-22 13:29, Monam Agarwal wrote:
This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL)
The rcu_assign_pointer() ensures that the initialization of a structure
is carried out before storing a pointer to that structure.
And in the case of the NULL pointer, there
Don Zickus writes:
> In order for the c2c tool to work correctly, it needs to properly
> sort all the records on uniquely identifiable data addresses. These
> unique addresses are converted from virtual addresses provided by the
> hardware into a kernel address using an mmap2 record as the
1) OpenVswitch's lookup_datapath() returns error pointers, so don't check
against NULL. From Jiri Pirko.
2) pfkey_compile_policy() code path tries to do a GFP_KERNEL allocation
under RCU locks, fix by using GFP_ATOMIC when necessary. From
Nikolay Aleksandrov.
3) phy_suspend()
The kernel piece passes more info now. Update the perf tool to reflect
that and adjust the synthesized maps to play along.
Signed-off-by: Don Zickus
---
tools/perf/util/event.c | 23 +--
tools/perf/util/event.h | 2 ++
tools/perf/util/machine.c | 4 +++-
From: Peter Zijlstra
The mmap2 interface was missing the protection and flags bits needed to
accurately determine if a mmap memory area was shared or private and
if it was readable or not.
[tweaked patch to compile and wrote changelog - Don
Signed-off-by: Don Zickus
--
Peter you mentioned
On Wed, 05 Mar 2014 21:00:21 +0900
Masami Hiramatsu wrote:
> /*
> * This is gone through when something in the kernel has done something bad
> diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c
> index ae5aafb..d00103a 100644
> --- a/arch/x86/kernel/kprobes/core.c
On Wed, 05 Mar 2014 21:00:00 +0900
Masami Hiramatsu wrote:
> There is no need to prohibit probing on the functions
> used for preparation, registeration, optimization,
> controll etc. Those are safely probed because those are
> not invoked from breakpoint/fault/debug handlers,
> there is no
In order for the c2c tool to work correctly, it needs to properly
sort all the records on uniquely identifiable data addresses. These
unique addresses are converted from virtual addresses provided by the
hardware into a kernel address using an mmap2 record as the decoder.
Once a unique address
On Wed, 05 Mar 2014 21:00:28 +0900
Masami Hiramatsu wrote:
> Use NOKPROBE_SYMBOL macro to protect functions from
> kprobes instead of __kprobes annotation.
>
> Signed-off-by: Masami Hiramatsu
> Cc: Ananth N Mavinakayanahalli
> Cc: "David S. Miller"
Reviewed-by: Steven Rostedt
-- Steve
--
Re-enable mmap2 support with some extra features. Also include a user,
perf report.
Perf report uses a new output format for the physid work I am trying to
do in the c2c tool. Hopefully this format is not as ugly.
V2: This is the second iteration of the mmap2 sorting in hist_entry's to
refresh_exported_devices() doesn't check udev_device_new_from_syspath()
return value and passed in null dev to udev_device_get_driver() resulting
in a segmentation fault. Change it to check for null return value from
both udev_device_new_from_syspath() and udev_device_get_driver().
Signed-off-by:
With the introduction of NUMA systems, came the possibility of remote memory
accesses.
Combine those remote memory accesses with contention on the remote node (ie a
modified
cacheline) and you have a possibility for very long latencies. These latencies
can
bottleneck a program.
The program
A basic patch that re-arranges some of the c2c code and adds a couple
of small features to lay the ground work for the rest of the patch
series.
Changes include:
o reworking the report path
o replace preprocess_sample with simpler calls
o rework raw output to handle separators
o remove phys id
My initial implementation for rbtree sorting in the c2c tool does not use the
normal history elements. As a result, adding callchain support (which is
deeply integrated with history elements) is more challenging when trying to
display its output.
To make things simpler for myself (and to avoid
Now that the infrastructure is set, add in the support to use
hist_entry to sort on physid.
V2: use new mmap2 sort
Signed-off-by: Don Zickus
---
tools/perf/builtin-c2c.c | 52 +++-
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git
The stddev calculation written matched standard error. As a result when
using this result to find the relative stddev between runs, it was not
accurate.
Update the formula to match traditional stddev. Then rename the old
stddev calculation to stderr_stats in case someone wants to use it.
Now that we have all the events sort on a unique address, we can walk
the rbtree sequential and count up all the HITMs for each cacheline
fairly easily.
Once we encounter a new event on a different cacheline, process the previous
cacheline. That includes determining if any HITMs were present on
Sometimes you want to verify the rbtree sorting on a unique id
is working correctly. This allows you to dump it.
Sample output:
Idx Hit Maj Min Ino InoGenPidDaddr
Iaddr Data Src (string) cpumode
0 0 0
Output some summary stats based on the processed records.
Mainly diagnostic uses.
Stats done by Dick Fowles, backported by me.
Sample output:
=
Trace Event Information
=
Total records
This patch adds a bunch of stats that will be used later in post-processing
to determine where and with what frequency the HITMs are coming from.
Most of the stats are decoded from the data source response. Another
piece of the stats is tracking which cpu the record came in on.
Credit to Dick
This patch mainly focuses on processing and displaying the collected
HITMs to stdout. Most of it is just printing data in a pretty way.
There is one trick used when walking the cacheline. When we get this
far we have two rbtrees. One rbtree holds every record sorted on a
unique id (using the
Modified the code to allow latency settings to be tweaked on the command line
and also the ability to dynamically profile stores (or disable using stores).
This allows the tool to be used on older Intel platforms like Westmere.
Signed-off-by: Don Zickus
---
tools/perf/builtin-c2c.c | 73
On Wed, 05 Mar 2014 21:00:14 +0900
Masami Hiramatsu wrote:
> Allow kprobes on text_poke/hw_breakpoint because
> those are not related to the critical int3-debug
> recursive path of kprobes at this moment.
>
> Signed-off-by: Masami Hiramatsu
Reviewed-by: Steven Rostedt
-- Steve
--
To
Just another table that displays the referenced symbols in the analysis
report. The table lists the most frequently used symbols first.
It is just another way to look at similar data to figure out who
is causing the most contention (based on the workload used).
Original done by Dick Fowles,
Seeing cacheline statistics is useful by itself. Seeing the callchain
for these cache contentions saves time tracking things down.
This patch tries to add callchain support. I had to use the generic
interface from a previous patch to output things to stdout easily.
Other than the displaying
From: Arnaldo Carvalho de Melo
This is the start of a new perf tool that will collect information about
memory accesses and analyse it to find things like hot cachelines, etc.
This is basically trying to get a prototype written by Richard Fowles
written using the tools/perf coding style and
This adds a quick summary of the hottest cache contention lines based
on the input data. This summarizes what the broken table shows you,
so you can see at a quick glance which cachelines are interesting.
Originally done by Dick Fowles, backported by me.
Sample output (width trimmed):
On Wed, 05 Mar 2014 21:00:07 +0900
Masami Hiramatsu wrote:
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -1209,7 +1209,7 @@ kretprobe_perf_func(struct trace_kprobe *tk, struct
> kretprobe_instance *ri,
> * kprobe_trace_self_tests_init() does
Have the netlink per-protocol optional bind function return an int error code
rather than void to signal a failure.
This will enable netlink protocols to perform extra checks including
capabilities and permissions verifications when updating memberships in
multicast groups.
In netlink_bind() and
From: Arnaldo Carvalho de Melo
>From the c2c prototype:
[root@sandy ~]# perf c2c -r report | head -7
T StatusPid Tid CPU Inst Adrs Virt Data Adrs Phys Data Adrs
Cycles Source Decoded SourceObJect:Symbol
This reverts commit 3090ffb5a2515990182f3f55b0688a7817325488.
Conflicts:
tools/perf/util/event.c
---
kernel/events/core.c| 4
tools/perf/util/event.c | 36 +++-
tools/perf/util/evsel.c | 1 +
3 files changed, 20 insertions(+), 21 deletions(-)
The cache contention tools needs to keep all the perf records unique in order
to properly parse all the data. Currently add_hist_entry() will combine
the duplicate record and add the weight/period to the existing record.
This throws away the unique data the cache contention tool needs (mainly
Joerg Roedel wrote:
>On Wed, Mar 05, 2014 at 06:54:18PM -0600, suravee.suthikulpa...@amd.com wrote:
>> From: Suravee Suthikulpanit
>>
>> In reality, the spec can only support 16-bit PASID since
>> INVALIDATE_IOTLB_PAGES and COMPLETE_PPR_REQUEST commands only allow
>> 16-bit PASID. So, we
On Wed, 05 Mar 2014 20:59:53 +0900
Masami Hiramatsu wrote:
> There is no need to prohibit probing on the functions
> used in preparation phase. Those are safely probed because
> those are not invoked from breakpoint/fault/debug handlers,
> there is no chance to cause recursive exceptions.
>
>
Remove some of the false positives when sorting by utilizing the MAP_SHARED bit.
This helps deal with the COW cases where a virtual address is modified but is
mapped to a read-only shared library area because the perf tool doesn't
understand
COW faults.
Using the MAP_SHARED bit tells the tool
This takes the parse_callchain_opt function and copies it into the
callchain.c file. Now the c2c tool can use it too without duplicating.
Signed-off-by: Don Zickus
---
tools/perf/util/callchain.c | 83 +
tools/perf/util/callchain.h | 1 +
2 files
This patch just converts some private functions into global ones
that can be used by other tools like the c2c tool I am trying to merge.
Don Zickus (4):
perf: Allow ability to map cpus to nodes easily
perf, kmem: Utilize the new generic cpunode_map
perf, callchain: Add generic report parse
Use the new routine.
Signed-off-by: Don Zickus
---
tools/perf/builtin-report.c | 77 +
1 file changed, 1 insertion(+), 76 deletions(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index c8f2113..c87412b 100644
---
Patches #2 and #3 have the same exact Subject line, please repost with unique
subject lines so that someone scanning the shortlog can tell what might
be different between these two commits.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
From: "zheng.li"
Date: Mon, 24 Mar 2014 17:01:42 +0800
> Recreate patch again as below, please check.
Your patch has been severely corrupted by your email client, and is
thus unusable by anyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message
Use the previous patch implementation of cpunode_map for builtin-kmem.c
Should not be any functional difference.
Cc: Li Zefan
Signed-off-by: Don Zickus
---
tools/perf/builtin-kmem.c | 78 ++-
1 file changed, 3 insertions(+), 75 deletions(-)
diff
This patch figures out the max number of cpus and nodes that are on the
system and creates a map of cpu to node. This allows us to provide a cpu
and quickly get the node associated with it.
It was mostly copied from builtin-kmem.c and tweaked slightly to use less memory
(use possible cpus
Frederic,
This one's for you.
Looks good as the exception_enter() is to catch when userspace causes
the exception which wouldn't be the case for kprobes. When kprobes
needs to do work, it would have already been in the kernel and the
NO_HZ_FULL and RCU should be aware of that.
But for me:
2014-03-24 19:14+0100, Paolo Bonzini:
> Il 24/03/2014 18:58, Radim Krčmář ha scritto:
> > I'd prefer 'ioapic->irr = 0' here ...)
>
> The point is that "ioapic->irr = 0" is overriding the previous
> memcpy, because state->irr is used as argument to
> kvm_ioapic_inject_all instead. So I think
Please pull to get these sparc fixes:
1) Do serial locking in a way that makes things clear that
these are IRQ spinlocks.
2) Conversion to generic idle loop broke first generation
Niagara machines, need to have %pil interrupts enabled
during cpu yield hypervisor call.
3) Do not use
On Sun, Mar 23, 2014 at 03:08:47PM -0400, Matthew Wilcox wrote:
> Comment fix only
>
> Signed-off-by: Matthew Wilcox
Thanks, applied to the ext4 git tree.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Already fixed
https://patchwork.linuxtv.org/patch/23115/
On 24.03.2014 20:38, Jim Davis wrote:
Building with the attached random configuration file,
warning: (DVB_USB_RTL28XXU) selects MEDIA_TUNER_E4000 which has unmet
direct dependencies ((MEDIA_ANALOG_TV_SUPPORT ||
MEDIA_DIGITAL_TV_SUPPORT
From: Wei Zhang
Date: Mon, 24 Mar 2014 15:34:31 +0800
> When use the gre vport, openvswitch register a gre_cisco_protocol but
> does not supply a err_handler with it. The gre_cisco_err() call the
> err_handler without existence check, cause the kernel crash.
>
> This patch base on v3.14-rc7.
On Sun, Mar 23, 2014 at 03:08:45PM -0400, Matthew Wilcox wrote:
> It's only called within inode.c, so make it static, remove its prototype
> from ext4.h and move it above all of its callers so it doesn't need a
> prototype within inode.c.
>
> Signed-off-by: Matthew Wilcox
Thanks, applied to the
On Mon, Mar 24, 2014 at 02:22:06PM -0400, Sasha Levin wrote:
> On 03/21/2014 02:35 PM, Benjamin LaHaise wrote:
> >Hi all,
> >
> >Based on the issues reported by Tang and Gu, I've come up with the an
> >alternative fix that avoids adding additional locking in the event read
> >code path. The fix
- Original Message -
> From: "Monam Agarwal"
> To: "mathieu desnoyers" ,
> rost...@goodmis.org, "keun-o park"
> , linux-kernel@vger.kernel.org
> Sent: Sunday, March 23, 2014 3:09:08 PM
> Subject: [PATCH] kernel: Use RCU_INIT_POINTER(x, NULL) in tracepoint.c
>
> This patch replaces
On 03/24/2014 07:24 AM, Jiri Slaby wrote:
> On 02/25/2014 10:50 PM, Corey Minyard wrote:
>> Looks right to me. Rocky, copying you in case there's an issue with this.
> Hi,
>
> any updates here, I don't see it in the -next tree yet?
>
> Thanks.
I normally don't submit to the -next tree because
On Mon, 24 Mar 2014 17:47:06 +0900
Masami Hiramatsu wrote:
> >> @@ -857,7 +857,7 @@ no_change:
> >> * Interrupts are disabled on entry as trap1 is an interrupt gate and they
> >> * remain disabled throughout this function.
> >> */
> >> -static int __kprobes post_kprobe_handler(struct
On Wed, 05 Mar 2014 20:59:32 +0900
Masami Hiramatsu wrote:
> thunk/restore functions are also used for tracing irqoff etc.
> and those are involved in kprobe's exception handling.
> Prohibit probing on them to avoid kernel crash.
>
> Signed-off-by: Masami Hiramatsu
> Cc: Thomas Gleixner
> Cc:
On Wed, 05 Mar 2014 20:59:04 +0900
Masami Hiramatsu wrote:
> .entry.text is a code area which is used for interrupt/syscall
> entries, and there are many sensitive codes.
> Thus, it is better to prohibit probing on all of such codes
> instead of a part of that.
> Since some symbols are already
On Mon, 24 Mar 2014 10:48:02 +0900
Masami Hiramatsu wrote:
> (2014/03/22 7:04), Steven Rostedt wrote:
> > On Wed, 05 Mar 2014 20:59:04 +0900
> > Masami Hiramatsu wrote:
> >
> >
> >> struct kprobe_insn_cache {
> >>struct mutex mutex;
> >> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
>
Have the netlink per-protocol optional bind function return an int error code
rather than void to signal a failure.
This will enable netlink protocols to perform extra checks including
capabilities and permissions verifications when updating memberships in
multicast groups.
In netlink_bind() and
On 14/03/24, Richard Guy Briggs wrote:
> On 14/03/23, David Miller wrote:
> > From: Richard Guy Briggs
> > Date: Fri, 21 Mar 2014 12:39:11 -0400
> >
> > > @@ -1441,6 +1441,17 @@ static int netlink_bind(struct socket *sock,
> > > struct sockaddr *addr,
> > > if (!nladdr->nl_groups &&
2014-03-24, 20:11:12 +0200, Mika Westerberg wrote:
> On Mon, Mar 24, 2014 at 08:00:33PM +0200, Mika Westerberg wrote:
> > On Mon, Mar 24, 2014 at 04:49:44PM +0100, Sabrina Dubroca wrote:
> > > Hi,
> > >
> > > With next-20140324, I get the BUG below w
Currently, the trace options are global, and shared among all
instances. This patchset allows instances to set certain trace options
independently, without affecting the global instance or other instances.
With this change, trace_overwrite will become an instance specific
option, while others
in with their reviews of this change.
Please review Tang, Gu. Thanks!
Hi Benjamin,
This patch seems to trigger:
[ 433.476216] ==
[ 433.478468] [ INFO: possible circular locking dependency detected ]
[ 433.480900] 3.14.0-rc7-next-20140324-sasha-00015
Il 24/03/2014 18:58, Radim Krčmář ha scritto:
> + rtc_irq_eoi_tracking_reset(ioapic);
> + for_each_set_bit(idx, , IOAPIC_NUM_PINS)
> + ioapic_set_irq(ioapic, idx, 1, true);
> +
> + kvm_rtc_eoi_tracking_restore_all(ioapic);
(We shouldn't have RTC interrupt with pending EOI in irr, so
The trace_flags global variable stores various trace options that are
shared across all ftrace instances. This patch adds accessors function
for trace_flags - a getter and a setter - and replaces usages of
trace_flags with these.
This is in preparation for replacing the global trace_flags with
This patch makes "trace_overwrite" an instance specific flag, so that
instances may independently control whether their buffers are in
overwrite mode or not.
To do this, the global_flags_start offset is set to 1, and the
trace_overwrite flag is moved to position 0 in the trace_options array.
Currently, the trace options are global, and shared among all
instances. This change divides the set of trace options into global
options and instance specific options. This division is done by using a
"global_flags_start" offset in the list of available trace options, that
marks the first global
Add loop to prevent return from machine_power_off if
pm_power_off is null or does not halt the system.
This caused a panic during hibernation testing on Kirkwood
Openblocks A6 board.
Signed-off-by: Sebastian Capella
Reported-by: Ezequiel Garcia
Cc: Len Brown
Cc: Pavel Machek
Cc: "Rafael J.
2014-03-21 10:27+0100, Paolo Bonzini:
> Unlike the old qemu-kvm, which really never did that, with new QEMU
> it is for some reason somewhat likely to migrate a VM with a nonzero
> IRR in the ioapic. In the case of ISA edge-triggered interrupts,
> this represents an interrupt that has not left
Hi Geert,
On 03/24, Geert Uytterhoeven wrote:
>
> Hi Oleg,
>
> On Sun, Mar 23, 2014 at 8:37 PM, Oleg Nesterov wrote:
> > It has no users and it doesn't look useful. I do not know why/when it
> > was introduced, I can't even find any user in the git history.
>
> 2.1.68pre1 for i386, 2.1.87pre1
Hi,
I have no further changes here.. I will submit a separate patch to
cover Ezequiel's concern. Any final comments? Otherwise, I'll submit
to Russell's system.
Thanks for the review!
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
101 - 200 of 918 matches
Mail list logo
