Re: [RFC][PATCH] vfs: In mntput run deactivate_super on a shallow stack.

2014-04-12 Thread Al Viro
On Sun, Apr 13, 2014 at 06:39:56AM +0100, Al Viro wrote: > type = get_fs_type("proc"); > ns = kmalloc(...); > /* fill *ns */ > mnt = kern_mount_data(type, p); s/p/ns/ > ... > if (error) { > kern_unmount(mnt); > kfree(p); ditto. >

Re: [RFC][PATCH] vfs: In mntput run deactivate_super on a shallow stack.

2014-04-12 Thread Al Viro
On Sat, Apr 12, 2014 at 03:15:39PM -0700, Eric W. Biederman wrote: > Can you explain which scenario you are thinking about with respect to a > failed modprobe? Completely made up example: static struct file_system_type foofs = { .mount = mount_foo, .kill_sb = kill_foo, };

Re: [PATCH v4 1/7] drivers: input: keyboard: st-keyscan: add keyscan driver

2014-04-12 Thread Dmitry Torokhov
Hi Gabriel, On Fri, Apr 11, 2014 at 05:07:30PM +0200, Gabriel FERNANDEZ wrote: > This patch adds ST Keyscan driver to use the keypad hw a subset > of ST boards provide. Specific board setup will be put in the > given dt. > > Signed-off-by: Gabriel Fernandez > Signed-off-by: Giuseppe Condorelli

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread H. Peter Anvin
On 04/11/2014 02:53 PM, Andy Lutomirski wrote: > > If you want a fully correct solution, you can use a fancier allocation > policy that can fit quite a few cpus per 4G :) > The more I think about this, I think this might actually be a reasonable option, *IF* someone is willing to deal with

Re: [PATCH v4] fs: FAT: Add support for DOS 1.x formatted volumes

2014-04-12 Thread OGAWA Hirofumi
Conrad Meyer writes: Hi, Sorry for late reply. > + > + bd_sects = part_nr_sects_read(sb->s_bdev->bd_part); This would be better to use i_read_size(>s_bdev->bd_inode->i_size) > + if (!fat_bpb_is_zero(b)) { > + fat_msg(sb, KERN_ERR, "%s; DOS 2.x BPB is

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Linus Torvalds
On Sat, Apr 12, 2014 at 7:56 PM, Andi Kleen wrote: > > Why? Either it works or it doesn't. > > If it works it doesn't make any sense to have a sysctl. BS. It "works" exactly like mmap() at NULL "works". It is a potential security leak, because x86-64 screwed up the architecture definition in

Re: new module to check constant memory for corruption

2014-04-12 Thread Valdis . Kletnieks
On Sun, 13 Apr 2014 03:33:10 +0200, alexander.kleinso...@gmx.de said: > printk(KERN_EMERG MODNAME "error: const kernel memory is broken > (%08lx != 0), please reboot!", g_SumLast); Make a list of all the things that can dynamically modify kernel text while it's running, starting

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread H. Peter Anvin
It leaks security sensitive information to userspace and corrupts the upper half of ESP because it lacks the equivalent of the espfix workaround. On April 12, 2014 7:56:48 PM PDT, Andi Kleen wrote: >"H. Peter Anvin" writes: >> >> But yes, we can make it configurable, but the default should

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread H. Peter Anvin
I would think any sensible application with 16-bit segments would be using sigaltstack. Does anyone know what Wine does? On April 12, 2014 6:29:11 PM PDT, Andy Lutomirski wrote: >On Sat, Apr 12, 2014 at 6:25 PM, Andy Lutomirski >wrote: >> On Sat, Apr 12, 2014 at 5:03 PM, H. Peter Anvin

Re: new module to check constant memory for corruption

2014-04-12 Thread Andi Kleen
alexander.kleinso...@gmx.de writes: > ramcheck kernel module > new module to check constant memory for corruption > > detect corruption of constant kernel memory (text and data) periodically. > runtime costs about 1..2 ms per sec (about 10 mb with 5 mb/ms), > which is distributed over 8 (BLOCKS)

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Andi Kleen
"H. Peter Anvin" writes: > > But yes, we can make it configurable, but the default should almost > certainly be off. Why? Either it works or it doesn't. If it works it doesn't make any sense to have a sysctl. -Andi -- a...@linux.intel.com -- Speaking for myself only -- To unsubscribe from

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Andi Kleen
Linus Torvalds writes: > On Fri, Apr 11, 2014 at 11:27 AM, Brian Gerst wrote: >> Is this bug really still present in modern CPUs? This change breaks >> running 16-bit apps in Wine. I have a few really old games I like to >> play on occasion, and I don't have a copy of Win 3.11 to put in a VM.

new module to check constant memory for corruption

2014-04-12 Thread Alexander . Kleinsorge
ramcheck kernel module new module to check constant memory for corruption detect corruption of constant kernel memory (text and data) periodically. runtime costs about 1..2 ms per sec (about 10 mb with 5 mb/ms), which is distributed over 8 (BLOCKS) time partitions (less than half ms per sec). in

Re: [GIT] kbuild misc changes for v3.15-rc1

2014-04-12 Thread Linus Torvalds
On Wed, Apr 9, 2014 at 8:59 AM, Michal Marek wrote: > > here is the non-critical part of kbuild: Michal, please make your pull request script clearly say both "git" and "pull" somewhere. Your emails don't trigger my search criteria, so they end up not being visible in my list of pull requests.

[PATCH RFC] blkcg: prepare blkcg knobs for default hierarchy

2014-04-12 Thread Tejun Heo
Hello, Unified hierarchy has finally been posted. http://thread.gmane.org/gmane.linux.kernel.containers/27601 It took a lot longer than I originally anticipated and over the course quite a few aspects of the initial design have changed, hopefully, for the better. One of the areas which has

Re: [PATCH] Route keyboard LEDs through the generic LEDs layer.

2014-04-12 Thread Dmitry Torokhov
On Sat, Apr 12, 2014 at 12:09:34PM +0200, Pavel Machek wrote: > Hi! > > > > > > This permits to reassign keyboard LEDs to something else than > > > > > keyboard "leds" > > > > > state, by adding keyboard led and modifier triggers connected to a > > > > > series > > > > > of VT input LEDs,

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Andy Lutomirski
On Sat, Apr 12, 2014 at 6:25 PM, Andy Lutomirski wrote: > On Sat, Apr 12, 2014 at 5:03 PM, H. Peter Anvin wrote: >> A signal arriving while in the user space trampoline could seriously >> complicate life. > > Agreed. Maybe I don't agree. Have signals ever worked sensibly when delivered to a

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Andy Lutomirski
On Sat, Apr 12, 2014 at 5:03 PM, H. Peter Anvin wrote: >> >> No self modifying code... The far jump must be in the indirect form >> anyhow. The CS:EIP must be accessible from user mode, but not >> necessarily from compatibility mode. So the trampoline (the jump) >> and data (CS:EIP) can live

Re: [PATCH] Route keyboard LEDs through the generic LEDs layer.

2014-04-12 Thread Dmitry Torokhov
On Fri, Apr 11, 2014 at 08:12:02AM +0200, Samuel Thibault wrote: > Hello, > > I'm sorry this went out with a few mistakes. > > Samuel Thibault, le Wed 09 Apr 2014 01:33:06 +0200, a écrit : > > Dmitry Torokhov, le Tue 08 Apr 2014 01:39:40 -0700, a écrit : > > > It is not about the VT, I am

Re: 3.13.?: Strange / dangerous fan policy...

2014-04-12 Thread Manuel Krause
On 2014-04-11 00:51, Manuel Krause wrote: On 2014-04-07 13:45, Rafael J. Wysocki wrote: On Monday, April 07, 2014 01:17:51 AM Manuel Krause wrote: On 2014-04-06 04:43, Guenter Roeck wrote: On 04/05/2014 07:37 PM, Manuel Krause wrote: On 2014-04-01 01:47, Guenter Roeck wrote: On 03/31/2014

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread H. Peter Anvin
On 04/12/2014 04:49 PM, Alexander van Heukelum wrote: > On Sun, Apr 13, 2014, at 1:31, H. Peter Anvin wrote: > d. Trampoline in user space > > A return to the vdso with values set up in registers r8-r15 would enable > a trampoline in user space. Unfortunately there is no way >

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Alexander van Heukelum
On Sun, Apr 13, 2014, at 1:31, H. Peter Anvin wrote: > >>> d. Trampoline in user space > >>> > >>> A return to the vdso with values set up in registers r8-r15 would enable > >>> a trampoline in user space. Unfortunately there is no way > >>> to do a far JMP entirely with register state so this

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Alexander van Heukelum
Hi, > This is a writeup I did to a select audience before this was public: I'ld like to add an option d.2. for your consideration. Can you think of a fundamental problem with it? Greetings, Alexander > > Some workarounds I have considered: > > > > a. Using paging in a similar way to the

Loan Offer

2014-04-12 Thread Mr.Robinson Dee
DO YOU NEED A LOAN TO PAY OFF YOUR BILLS EMAIL robinsonde...@hotmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread H. Peter Anvin
On 04/12/2014 04:26 PM, Alexander van Heukelum wrote: >>> >>> c. Trampoline in kernel space >>> >>> A trampoline in kernel space is not feasible since all ring transition >>> instructions capable of returning to 16-bit mode require the use of the >>> stack. > > "16 bit mode" -> "a mode with

Re: Fwd: New Defects reported by Coverity Scan for Linux

2014-04-12 Thread H. Peter Anvin
On 04/12/2014 02:41 PM, Ville Syrjälä wrote: > On Sat, Apr 12, 2014 at 07:29:29AM -0600, Bjorn Helgaas wrote: >> FYI, looks like these were added by a4dff76924fe ("x86/gpu: Add Intel >> graphics stolen memory quirk for gen2 platforms"). > > Some of the affected gen2 platforms do support up to 2GB

Re: Cryogenic: Enabling Power-Aware Applications on Linux

2014-04-12 Thread H. Peter Anvin
On 04/12/2014 04:36 AM, Pavel Machek wrote: >> >>> Hmm, but the API needs redoing, anyway, fcntl()? >> >> Depends --- while I like the idea, I did not hear enough to be >> certain that having this feature embedded in such a non-modular >> way was already the consensus (and I do not see a

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread H. Peter Anvin
On 04/12/2014 02:53 PM, Linus Torvalds wrote: > On Sat, Apr 12, 2014 at 12:44 PM, H. Peter Anvin wrote: >> Run a 32-bit VM. The 32-bit kernel does this right. > > I really don't think that's the answer. > > If people really run these 16-bit programs, we need to allow it. > Clearly it used to

Re: [RFC][PATCH] vfs: In mntput run deactivate_super on a shallow stack.

2014-04-12 Thread Eric W. Biederman
Al Viro writes: > On Wed, Apr 09, 2014 at 03:58:25PM -0700, Eric W. Biederman wrote: >> >> mntput as part of pathput is called from all over the vfs sometimes as >> in the case of symlink chasing from some rather deep call chains. >> During filesystem unmount with the right set of races those

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Linus Torvalds
On Sat, Apr 12, 2014 at 12:44 PM, H. Peter Anvin wrote: > Run a 32-bit VM. The 32-bit kernel does this right. I really don't think that's the answer. If people really run these 16-bit programs, we need to allow it. Clearly it used to work. Just make the unconditional "don't allow 16-bit

[GIT] Networking

2014-04-12 Thread David Miller
1) Various fixes to the new Redpine Signals wireless driver, from Fariya Fatima. 2) L2TP PPP connect code takes PMTU from the wrong socket, fix from Dmitry Petukhov. 3) UFO and TSO packets differ in whether they include the protocol header in gso_size, account for that in

Re: Fwd: New Defects reported by Coverity Scan for Linux

2014-04-12 Thread Ville Syrjälä
On Sat, Apr 12, 2014 at 07:29:29AM -0600, Bjorn Helgaas wrote: > FYI, looks like these were added by a4dff76924fe ("x86/gpu: Add Intel > graphics stolen memory quirk for gen2 platforms"). Some of the affected gen2 platforms do support up to 2GB of RAM which means that if the sign extension were

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Borislav Petkov
On Sat, Apr 12, 2014 at 05:13:40PM -0400, Brian Gerst wrote: > Performance is bad in general, running a 32-bit Fedora 20 guest. So this means you haven't tried the game in the guest yet, so that we can know for sure that a guest doesn't solve your problem or what? Btw, which game is that and can

[PATCHv2 2/7] pwm: sunxi: document OF bindings

2014-04-12 Thread Alexandre Belloni
This is the documentation for the Allwinner Socs PWM bindings. Signed-off-by: Alexandre Belloni --- Documentation/devicetree/bindings/pwm/pwm-sunxi.txt | 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/pwm-sunxi.txt diff --git

[PATCHv2 1/7] pwm: Add Allwinner SoC support

2014-04-12 Thread Alexandre Belloni
This adds a generic PWM framework driver for the PWM controller found on Allwinner SoCs. Signed-off-by: Alexandre Belloni --- drivers/pwm/Kconfig | 9 ++ drivers/pwm/Makefile| 1 + drivers/pwm/pwm-sunxi.c | 345 3 files changed, 355

[PATCHv2 3/7] ARM: sun4i: dt: add pinmux configuration for the PWM

2014-04-12 Thread Alexandre Belloni
Add the pinctrl descriptions for both PWM channels of the Allwinner A10. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/sun4i-a10.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi index

[PATCHv2 4/7] ARM: sun4i: dt: add PWM support

2014-04-12 Thread Alexandre Belloni
Add the PWM bindings for the Allwinner A10. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/sun4i-a10.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi index 109e796e4a69..bb11c422526b 100644 ---

[GIT PULL] target updates for v3.15-rc1

2014-04-12 Thread Nicholas A. Bellinger
Hello Linus! Here are the target pending updates for v3.15-rc1. Apologies in advance for waiting until the second to last day of the merge window to send these out. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next The highlights

[PATCHv2 7/7] ARM: sunxi: dt: add PWM support for the cubietruck

2014-04-12 Thread Alexandre Belloni
Enable the PWM for both PWM channels on the cubietruck. They can be found on connector CN8. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/sun7i-a20-cubietruck.dts | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20-cubietruck.dts

[PATCHv2 5/7] ARM: sun7i: dt: add pinmux configuration for the PWM

2014-04-12 Thread Alexandre Belloni
Add the pinctrl descriptions for both PWM channels of the Allwinner A20. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/sun7i-a20.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index

[PATCHv2 6/7] ARM: sun7i: dt: add PWM support

2014-04-12 Thread Alexandre Belloni
Add the PWM bindings for the Allwinner A20. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/sun7i-a20.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi index c6eb881a3ced..19d1f60209c5 100644 ---

[PATCHv2 0/7] Add Allwinner SoCs PWM support

2014-04-12 Thread Alexandre Belloni
Hi, This patch set adds support for the PWM controller found on the Allwinner SoCs. The first patch adds the driver itself. The second patch adds the DT binding documentation The third patch adds the bindings to the sun7i-a20 DTS include. And finally, the la patch adds support for the PWMs to

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Brian Gerst
On Sat, Apr 12, 2014 at 4:59 PM, Borislav Petkov wrote: > On Sat, Apr 12, 2014 at 04:34:14PM -0400, Brian Gerst wrote: >> My experience with kvm so far is that is slow and clunky. It may be OK >> for a server environment, but interactively it's difficult to use. > > Are you saying, you've run

[PATCH 2/2] swap: use separate priority list for available swap_infos

2014-04-12 Thread Dan Streetman
Originally get_swap_page() started iterating through the singly-linked list of swap_info_structs using swap_list.next or highest_priority_index, which both were intended to point to the highest priority active swap target that was not full. The previous patch in this series changed the

[PATCH 1/2] swap: change swap_info singly-linked list to list_head

2014-04-12 Thread Dan Streetman
Replace the singly-linked list tracking active, i.e. swapon'ed, swap_info_struct entries with a doubly-linked list using struct list_heads. Simplify the logic iterating and manipulating the list of entries, especially get_swap_page(), by using standard list_head functions, and removing the highest

[PATCH 0/2] swap: simplify/fix swap_list handling and iteration

2014-04-12 Thread Dan Streetman
The logic controlling the singly-linked list of swap_info_struct entries for all active, i.e. swapon'ed, swap targets is rather complex, because: -it stores the entries in priority order -there is a pointer to the highest priority entry -there is a pointer to the highest priority not-full entry

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Borislav Petkov
On Sat, Apr 12, 2014 at 04:34:14PM -0400, Brian Gerst wrote: > My experience with kvm so far is that is slow and clunky. It may be OK > for a server environment, but interactively it's difficult to use. Are you saying, you've run your game in a guest and perf. is sucky? -- Regards/Gruss,

Re: [PATCH] netfilter: conntrack: initialize net.ct.generation

2014-04-12 Thread David Miller
From: Andrey Vagin Date: Fri, 11 Apr 2014 21:34:20 +0400 > [ 251.920788] INFO: trying to register non-static key. I'll let Pablo integrate this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] net: ipv4: current group_info should be put after using.

2014-04-12 Thread David Miller
From: Mateusz Guzik Date: Fri, 11 Apr 2014 15:50:27 +0200 > Please cc: me if you resend the patch. Never resubmit a patch as a reply to a thread discussion a previous version of the patch if you want it to be considered for inclusion. Always make a new, fresh, mailing list posting properly

Re: [PATCH v2 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-04-12 Thread David Miller
From: Iyappan Subramanian Date: Fri, 11 Apr 2014 20:06:24 -0700 > This patch adds network driver for APM X-Gene SoC ethernet. > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Ravi Patel > Signed-off-by: Keyur Chudgar This driver is going to take a long to review and get to the point

Re: [PATCH] drivers: net: xen-netfront: fix array initialization bug

2014-04-12 Thread David Miller
From: Vincenzo Maffione Date: Sat, 12 Apr 2014 11:55:40 +0200 > This patch fixes the initialization of an array used in the TX > datapath that was mistakenly initialized together with the > RX datapath arrays. An out of range array access could happen > when RX and TX rings had different sizes.

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Brian Gerst
On Sat, Apr 12, 2014 at 4:11 PM, Borislav Petkov wrote: > On Sat, Apr 12, 2014 at 12:44:42PM -0700, H. Peter Anvin wrote: >> Run a 32-bit VM. The 32-bit kernel does this right. > > Yes, even better. > >> I suspect it would also work fine in a Qemu user mode guest (is >> this supported by KVM?),

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Brian Gerst
For this particular game, not 16-bit in general. The installer, also 16-bit, runs perfectly. Already filed wine bug 35977. On Sat, Apr 12, 2014 at 1:18 PM, H. Peter Anvin wrote: > So Wine regressed and noone noticed? They doesn't sound like an active user > base. > > On April 11, 2014

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Borislav Petkov
On Sat, Apr 12, 2014 at 12:44:42PM -0700, H. Peter Anvin wrote: > Run a 32-bit VM. The 32-bit kernel does this right. Yes, even better. > I suspect it would also work fine in a Qemu user mode guest (is > this supported by KVM?), in a ReactOS VM, or some other number of > combinations. Right.

Re: [Patch v3 1/6] devres: introduce API "devm_kmemdup

2014-04-12 Thread Greg Kroah-Hartman
On Sat, Apr 12, 2014 at 05:39:37PM +0100, Jonathan Cameron wrote: > On 09/04/14 01:56, Srinivas Pandruvada wrote: > > Introduce devm_kmemdup, which uses resource managed kmalloc. > > There are several request from maintainers to add this instead > > of using kmemdup. > > > > Signed-off-by:

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread H. Peter Anvin
Run a 32-bit VM. The 32-bit kernel does this right. I suspect it would also work fine in a Qemu user mode guest (is this supported by KVM?), in a ReactOS VM, or some other number of combinations. The real question is how many real users are actually affected. On April 12, 2014 12:35:41 PM

Re: [GIT PULL] Audit subsystem for v3.15

2014-04-12 Thread Linus Torvalds
On Thu, Apr 10, 2014 at 4:53 PM, Eric Paris wrote: > > Please pull the audit tree for v3.15. You will have merge conflicts. The merge conflicts were easy to resolve. I appreciate you spending the time to explain them, but quite frankly, I can figure out trivial ones on my own. What I really

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread Borislav Petkov
On Sat, Apr 12, 2014 at 10:18:25AM -0700, H. Peter Anvin wrote: > So Wine regressed and noone noticed? They doesn't sound like an active > user base. Btw, wouldn't this obscure use case simply work in a KVM guest with a kernel <= 3.14? Because if so, we simply cut it at 3.14, everything newer

[PATCH] Configure FSL eSPI CSBEF, CSAFT, and whether to send all received data to user

2014-04-12 Thread Jane Wan
Make FSL eSPI properties configurable through device tree. The configurable parameters include CSnBEF and CSnAFT in ESPI_SPMODEn registers (n=0,1,2,3), and whether to send all received data to user. The FSL eSPI driver hardcodes CSnBEF and CSnAFT to 0. Some device needs to set them to different

[PATCH] Configure FSL eSPI CSBEF, CSAFT, and whether to send all received data to user

2014-04-12 Thread Jane Wan
Make FSL eSPI CSnBEF and CSnAFT in ESPI_SPMODEn registers (n=0,1,2,3) configurable through device tree. FSL eSPI driver hardcodes them to 0. Some device requires different value. Allow FSL eSPI driver configurable whether to send all received data form slave devices to user. When user wants to

Re: [PATCH v2 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-04-12 Thread Florian Fainelli
2014-04-11 20:06 GMT-07:00 Iyappan Subramanian : > This patch adds documentation for APM X-Gene SoC ethernet DTS binding. > > Signed-off-by: Iyappan Subramanian > Signed-off-by: Ravi Patel > Signed-off-by: Keyur Chudgar > --- > .../devicetree/bindings/net/apm-xgene-enet.txt | 46 >

fs/debugfs/inode.c: thoughts about "CID 101681 Dereference after null check"

2014-04-12 Thread Toralf Förster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Just for fun (and to learn a little bit) I picked up an arbitrary entry from coverity [1] : CID 101681 Dereference after null check Either the check against null is unnecessary, or there may be a null pointer dereference.

Re: [PATCH] USB: cdc-acm: fix double usb_autopm_put_interface() in acm_port_activate()

2014-04-12 Thread Oliver Neukum
On Sat, 2014-04-12 at 02:10 +0400, Alexey Khoroshilov wrote: > If acm_submit_read_urbs() fails in acm_port_activate(), error handling > code calls usb_autopm_put_interface() while it is already called > before acm_submit_read_urbs(). The patch reorganizes error handling code > to avoid double

[PATCH] clk: versatile: free icst on error return

2014-04-12 Thread Colin King
From: Colin Ian King commit a183da63 introduced a new error return path that does not kfree icst if the kmemdup of desc->params fails. Signed-off-by: Colin Ian King --- drivers/clk/versatile/clk-icst.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/versatile/clk-icst.c

[PATCH] intel_idle: fix IVT idle state table setting

2014-04-12 Thread Christoph Jaeger
Ivy Town idle state table will not be set as intended. Fix it. Picked up by Coverity - CID 1201420/1201421. Fixes: 0138d8f075 ("intel_idle: fine-tune IVT residency targets") Signed-off-by: Christoph Jaeger --- drivers/idle/intel_idle.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH] staging: iio: fix coding style

2014-04-12 Thread Jonathan Cameron
On 09/04/14 19:09, Joel Porquet wrote: As suggested by checkpatch.pl, use dev_info() instead of printk(KERN_INFO ...) to print message. Signed-off-by: Joel Porquet --- Only tested by compilation. drivers/staging/iio/trigger/iio-trig-periodic-rtc.c | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [Patch v3 5/6] iio: hid-sensors: Added device rotation support

2014-04-12 Thread Jonathan Cameron
On 09/04/14 01:56, Srinivas Pandruvada wrote: Added usage id processing for device rotation. This uses IIO interfaces for triggered buffer to present data to user mode.This uses HID sensor framework for registering callback events from the sensor hub. Data is exported to user space in the form

Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels

2014-04-12 Thread H. Peter Anvin
So Wine regressed and noone noticed? They doesn't sound like an active user base. On April 11, 2014 9:44:22 PM PDT, Brian Gerst wrote: >On Fri, Apr 11, 2014 at 2:50 PM, Linus Torvalds > wrote: >> On Fri, Apr 11, 2014 at 11:45 AM, Brian Gerst >wrote: >>> >>> I haven't tested it recently but I

Re: [PATCH] serial: uart: add hw flow control support configuration

2014-04-12 Thread One Thousand Gnomes
> not needed if hw has flow control capabilities. This patch adds a > DT attribute for enabling hw flow control for a uart port. Also skip > stop and start if this flag is present in flag field of the port > structure. That seems a sensible thing to add. > - if (up->capabilities &

Re: [Patch v3 6/6] iio: Added ABI description for quaternion

2014-04-12 Thread Jonathan Cameron
On 09/04/14 01:56, Srinivas Pandruvada wrote: Added documentation for reading quaternion components for 3D rotations. Signed-off-by: Srinivas Pandruvada Your quaternion description doesn't really include all the nuances of quaternions, but will do the job without confusing anyone ;) (no

Re: [Patch v3 3/6] IIO: core: Modify scan element type

2014-04-12 Thread Jonathan Cameron
On 09/04/14 01:56, Srinivas Pandruvada wrote: The current scan element type uses the following format: [be|le]:[s|u]bits/storagebits[>>shift]. To specify multiple elements in this type, added a repeat value. So new format is: [be|le]:[s|u]bits/storagebits{X[repeat]}[>>shift]. Here X is

Re: [Patch v3 2/6] IIO: core: Introduce read_raw_multi

2014-04-12 Thread Jonathan Cameron
On 09/04/14 01:56, Srinivas Pandruvada wrote: This callback is introduced to overcome some limitations of existing read_raw callback. The functionality of both existing read_raw and read_raw_multi is similar, both are used to request values from the device. The current read_raw callback allows

Re: [Patch v3 1/6] devres: introduce API "devm_kmemdup

2014-04-12 Thread Jonathan Cameron
On 09/04/14 01:56, Srinivas Pandruvada wrote: Introduce devm_kmemdup, which uses resource managed kmalloc. There are several request from maintainers to add this instead of using kmemdup. Signed-off-by: Srinivas Pandruvada I've been trying to work out who else should be cc'd on this and so

Re: [PATCH] ipc/shm: disable SHMALL, SHMMAX

2014-04-12 Thread Davidlohr Bueso
On Sat, 2014-04-12 at 08:39 -0700, Davidlohr Bueso wrote: > On Sat, 2014-04-12 at 13:48 +0200, Manfred Spraul wrote: > > Shared memory segment can be abused to trigger out-of-memory conditions and > > the standard measures against out-of-memory do not work: > > > > - It is not possible to use

Re: [PATCH] ipc/shm: disable SHMALL, SHMMAX

2014-04-12 Thread Davidlohr Bueso
On Sat, 2014-04-12 at 13:48 +0200, Manfred Spraul wrote: > Shared memory segment can be abused to trigger out-of-memory conditions and > the standard measures against out-of-memory do not work: > > - It is not possible to use setrlimit to limit the size of shm segments. > > - Segments can exist

Re: [PATCH] ipc,shm: disable shmmax and shmall by default

2014-04-12 Thread Davidlohr Bueso
On Sat, 2014-04-12 at 10:50 +0200, Manfred Spraul wrote: > On 04/11/2014 10:27 PM, Davidlohr Bueso wrote: > > On Fri, 2014-04-11 at 20:28 +0200, Manfred Spraul wrote: > >> Hi Davidlohr, > >> > >> On 04/03/2014 02:20 AM, Davidlohr Bueso wrote: > >>> The default size for shmmax is, and always has

Re: [PATCH 3.14 00/23] 3.14.1-stable review

2014-04-12 Thread Greg Kroah-Hartman
On Sat, Apr 12, 2014 at 02:38:59PM +0900, Satoru Takeuchi wrote: > At Fri, 11 Apr 2014 17:46:55 -0600, > Shuah Khan wrote: > > > > On 04/11/2014 10:11 AM, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 3.14.1 release. > > > There are 23 patches in this

Re: [PATCH v2 1/2] ARM : DMA : remove useless information about DMA

2014-04-12 Thread Nicolas Pitre
On Sat, 12 Apr 2014, Liu hua wrote: > Hi Nicolas, > > Your version is better. you tell me this in the former letters. > So I am very sorry to forget to check that. > > May be I should remake this second patch to fit your change. What do > you think about that patch? You may simply drop your

Fwd: New Defects reported by Coverity Scan for Linux

2014-04-12 Thread Bjorn Helgaas
FYI, looks like these were added by a4dff76924fe ("x86/gpu: Add Intel graphics stolen memory quirk for gen2 platforms"). -- Forwarded message -- From: Date: Sat, Apr 12, 2014 at 1:24 AM Subject: New Defects reported by Coverity Scan for Linux To: ... ** CID 1201423:

Re: Postgresql performance problems with IO latency, especially during fsync()

2014-04-12 Thread Andres Freund
Hi Dave, On 2014-04-09 19:20:09 +1000, Dave Chinner wrote: > On Wed, Mar 26, 2014 at 08:11:13PM +0100, Andres Freund wrote: > > So, the average read time is less than one ms (SSD, and about 50% cached > > workload). But once another backend does the fsync(), read latency > > skyrockets. > > > >

[PATCH v2 3/4] fwserial: (coding style) useless "extern" & space

2014-04-12 Thread Dominique van den Broeck
Style-only modifications to make checkpatch.pl --file --strict a bit happier. Removed useless "extern" in dma_fifo.h ; Removed one supernumerary space. Signed-off-by: Dominique van den Broeck --- diff -upr a/drivers/staging/fwserial/dma_fifo.h b/drivers/staging/fwserial/dma_fifo.h ---

[PATCH v2 1/4] fwserial: (coding style) open parenthesis alignments

2014-04-12 Thread Dominique van den Broeck
Style-only modifications to make checkpatch.pl --file --strict a bit happier. Open parenthesis alignments. Signed-off-by: Dominique van den Broeck --- diff -upr a/drivers/staging/fwserial/dma_fifo.c b/drivers/staging/fwserial/dma_fifo.c --- a/drivers/staging/fwserial/dma_fifo.c 2014-04-11

[PATCH v2 4/4] fwserial: (coding style) removing FSF postal address

2014-04-12 Thread Dominique van den Broeck
Style-only modifications to make checkpatch.pl --file --strict a bit happier. Removing FSF postal address from file top comment since it has changed in the past, as stated by checkpatch.pl. Signed-off-by: Dominique van den Broeck --- diff -upr a/drivers/staging/fwserial/dma_fifo.c

[PATCH v2 2/4] fwserial: (coding style) if/else bracket matching

2014-04-12 Thread Dominique van den Broeck
Style-only modifications to make checkpatch.pl --file --strict a bit happier. if/else bracket matching (either none or both options should be bracketed). Signed-off-by: Dominique van den Broeck --- diff -upr a/drivers/staging/fwserial/fwserial.c b/drivers/staging/fwserial/fwserial.c ---

Re: [PATCH v4 0/5] rework sched_domain topology description

2014-04-12 Thread Dietmar Eggemann
On 11/04/14 10:44, Vincent Guittot wrote: This patchset was previously part of the larger tasks packing patchset [1]. I have splitted the latter in 3 different patchsets (at least) to make the thing easier. -configuration of sched_domain topology (this patchset) -update and consolidation of

[git pull] vfs.git

2014-04-12 Thread Al Viro
The first vfs pile, with deep apologies for being very late in this window. Assorted cleanups and fixes, plus a large preparatory part of iov_iter work. There's a lot more of that, but it'll probably go into the next merge window - it *does* shape up nicely, removes a lot of boilerplate, gets rid

[PATCH] ipc/shm: disable SHMALL, SHMMAX

2014-04-12 Thread Manfred Spraul
Shared memory segment can be abused to trigger out-of-memory conditions and the standard measures against out-of-memory do not work: - It is not possible to use setrlimit to limit the size of shm segments. - Segments can exist without association with any processes, thus the oom-killer is

Re: Cryogenic: Enabling Power-Aware Applications on Linux

2014-04-12 Thread Pavel Machek
Hi! > >> Yes, it depends on the device, but we have demonstrated power > >> savings for two different types of devices using two different > >> measurement setups performed by two independent groups. Some > >> of the measurements are available on the website, the second > >> set should become

3.15-mw: Oops Workqueue: writeback bdi_writeback_workfn (flush-8:16) RIP: e030:[] [] kobject_put+0x11/0x70

2014-04-12 Thread Sander Eikelenboom
Hi, I just ran into the oops belowafter some uptime. -- Sander [175753.946560] IP: [] kobject_put+0x11/0x70 [175753.964484] PGD 0 [175753.982157] Oops: [#1] SMP [175753.999575] Modules linked in: [175754.016705] CPU: 4 PID: 23869 Comm: kworker/u12:3 Not tainted 3.14.0-mw-20140409a+ #1

[PATCH] btrfs: fix use-after-free in mount_subvol()

2014-04-12 Thread Christoph Jaeger
Pointer 'newargs' is used after the memory that it points to has already been freed. Picked up by Coverity - CID 1201425. Fixes: 0723a0473f ("btrfs: allow mounting btrfs subvolumes with different ro/rw options") Signed-off-by: Christoph Jaeger --- fs/btrfs/super.c | 8 ++-- 1 file changed,

Re: [PATCH 0/6] workqueue: simpler workers management synchronization

2014-04-12 Thread Lai Jiangshan
Sorry, the cover letter was forgotten to send to LKML. On 04/12/2014 06:45 PM, Lai Jiangshan wrote: > Each patches remove codes! > > Patch1&2 are the basic patches. They add a *united* mechanism for managing > percpu pools' workers' & unbound pools' workers' & rescuers' CPUMASK. > > Patch1&4

[PATCH 3/6] workqueue: make destroy_worker() atomically

2014-04-12 Thread Lai Jiangshan
destroy_worker() doesn't need to wait for worker's task exit. There is no essential things to do after kthread_stop(). So we remove kthread_stop(). put_unbound_pool() needs to wait for workers' tasks exit. we add a new completion to handle it. The purpose of this patch is not making the slowpath

[PATCH 2/6] workqueue: generic framework to manage normal workers' cpumask

2014-04-12 Thread Lai Jiangshan
If a worker's cpumask need to be kept co-ordinate with the pool during cpu-hotpug, we add this worker to a special set which will be used to manage workers' cpumask. This special set is worker_idr currently and it serves for normal workers only. But we can't add rescuer to this set due to we

[PATCH 4/6] workqueue: commit worker to pool's concurrency setting atomically.

2014-04-12 Thread Lai Jiangshan
workers' concurrency setting need to be coordinate with pool's concurrency setting when create_worker()/destroy_worker()/cpu_inline() cpu_offline(). But create_worker() handles it non-atomically(not in a single pool->lock). This patch makes the behavior atomically. Now bind_list is used for

[PATCH 5/6] workqueue: remove manager_mutex

2014-04-12 Thread Lai Jiangshan
Now bind_mutex is used for coordinating workers' cpumask with the pool. pool->lock is used for coordinating workers' concurrency with the pool. cpumask is coordinated at first and then concurrency. manager_mutex don't need for cpumask nor concurrency. In restore_workers_cpumask(), we don't need

[PATCH 6/6] workqueue: destroy worker directly in idle timeout handler

2014-04-12 Thread Lai Jiangshan
Since destroy_worker() is working atomically, we move maybe_destroy_worker() out from manager and destroy worker directly in idle timeout handler. And we remove %POOL_MANAGE_WORKERS which help us remove a branch in worker_thread(). Signed-off-by: Lai Jiangshan --- kernel/workqueue.c | 71

[PATCH 1/6] workqueue: generic routine to restore percpu/unbound pools' workers' cpumask

2014-04-12 Thread Lai Jiangshan
Current code uses different routines to restore the cpumask of workers of percpu pools. unbound pools - restore_unbound_workers_cpumask() percpu pools - rebind_workers() Actually, restore_unbound_workers_cpumask() can be used for percpu pools. if percpu_pool->cpu != cpu,

Re: [PATCH] tools: Unify export.h

2014-04-12 Thread Borislav Petkov
On Fri, Apr 11, 2014 at 01:59:30PM +0200, Jiri Olsa wrote: > hum, this breaks tarpkg test.. note that I needed attached patch to > make the test output verbose Bah, I could swear make -C tools/perf build-test passed before sending out. Alternatively, I might've been smoking something funny

Re: [PATCH] Route keyboard LEDs through the generic LEDs layer.

2014-04-12 Thread Pavel Machek
Hi! > > > > This permits to reassign keyboard LEDs to something else than keyboard > > > > "leds" > > > > state, by adding keyboard led and modifier triggers connected to a > > > > series > > > > of VT input LEDs, themselves connected to VT input triggers, which > > > > per-input device LEDs

[PATCH] staging/imx-drm: fix code line width

2014-04-12 Thread Brilliantov Kirill Vladimirovich
Signed-off-by: Brilliantov Kirill Vladimirovich --- drivers/staging/imx-drm/imx-tve.c | 3 ++- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 3 ++- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 23 +++ drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 27

  1   2   3   >