Re: [PATCH 4/4] staging/wlan-ng: replace printk() with pr_xxx()

2014-05-15 Thread Greg KH
On Mon, May 12, 2014 at 05:22:47PM +0200, Denis Pithon wrote: > Fix some coding style issues concerning printk() usage. > > Signed-off-by: Denis Pithon > --- > drivers/staging/wlan-ng/p80211netdev.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git

[PATCH] Fix for possible null pointer dereference in keyspan.c

2014-05-15 Thread Rickard Strandqvist
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/usb/serial/keyspan.c |4 ++-- 1 fil ändrad, 2 tillägg(+), 2 borttagningar(-) diff --git

Re: [PATCH v6 0/8] Enable USB 3.0 support on Exynos5 systems

2014-05-15 Thread Kukjin Kim
On 05/14/14 23:01, Vivek Gautam wrote: From: Vivek gautam Based on 'for-next' branch of Kgene's linux-samsung tree; along with dts patches for USB 2.0 phy[1], and Exynos5800 [2]. Also based on the latest USB 3.0 DRD phy driver patches posted [3]. Changes from v5: - Added node reference names

Re: [PATCH] staging: wlan-ng: Fix sparse warnings

2014-05-15 Thread Greg KH
On Sun, Apr 13, 2014 at 10:09:49PM +0530, c...@slynux.com wrote: > From: Sarath Lakshman This doesn't match your From: line, why? > > Fixed missed declarations for few non-static functions. > > Signed-off-by: Sarath Lakshman > --- > drivers/staging/wlan-ng/cfg80211.c | 1 + >

[PATCH] Fix for possible null pointer dereference in node.c

2014-05-15 Thread Rickard Strandqvist
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/tidspbridge/rmgr/node.c |4 ++-- 1 fil ändrad, 2 tillägg(+), 2 borttagningar(-) diff --git

Re: [PATCH v5 2/3] CPU hotplug, stop-machine: Plug race-window that leads to "IPI-to-offline-CPU"

2014-05-15 Thread Srivatsa S. Bhat
On 05/16/2014 12:47 AM, Tejun Heo wrote: > On Fri, May 16, 2014 at 12:43:44AM +0530, Srivatsa S. Bhat wrote: >> During CPU offline, stop-machine is used to take control over all the online >> CPUs (via the per-cpu stopper thread) and then run take_cpu_down() on the CPU >> that is to be taken

Re: [patch 2/2] rtmutex: Avoid pointless requeueing in the deadlock detection chain walk

2014-05-15 Thread Steven Rostedt
On Thu, 15 May 2014 08:47:09 +0200 Ingo Molnar wrote: > > A couple of suggestions: > > 1) > > * Thomas Gleixner wrote: > > > + if (requeue) { > > + if (waiter == rt_mutex_top_waiter(lock)) { > > So we have a 'top_waiter' local variable already at this point, and we > use it

Re: [PATCH v3 1/6] watchdog: Add API to trigger reboots

2014-05-15 Thread Guenter Roeck
On Thu, May 15, 2014 at 09:50:20PM +0100, One Thousand Gnomes wrote: > > +void watchdog_do_reboot(void) > > +{ > > + if (wdd_reboot_dev) > > + wdd_reboot_dev->ops->reboot(wdd_reboot_dev); > > +} > > +EXPORT_SYMBOL(watchdog_do_reboot); > > Crashes and burns if you are unloading a

Re: [PATCH v3 1/3] phy: Add exynos-simple-phy driver

2014-05-15 Thread Tomasz Figa
On 15.05.2014 06:01, Rahul Sharma wrote: > Thanks Tomasz, > > On 15 May 2014 01:31, Tomasz Figa wrote: >> Hi Rahul, Tomasz, > [snip] >>> + simplephys: simple-phys@1004 { >>> + compatible = "samsung,exynos5250-simple-phy"; >> >> Missing reg property or unnecessary

Re: mm: NULL ptr deref handling mmaping of special mappings

2014-05-15 Thread Andy Lutomirski
On Thu, May 15, 2014 at 2:31 PM, Cyrill Gorcunov wrote: > On Fri, May 16, 2014 at 12:19:14AM +0400, Cyrill Gorcunov wrote: >> >> I see what you mean. We're rather targeting on bare x86-64 at the moment >> but compat mode is needed as well (not yet implemented though). I'll take >> a precise look

Re: [PATCH] i915: Add module option to support VGA arbiter on HD devices

2014-05-15 Thread Alex Williamson
On Mon, 2014-05-12 at 21:38 +0200, Daniel Vetter wrote: > On Mon, May 12, 2014 at 01:30:39PM -0600, Alex Williamson wrote: > > On Mon, 2014-05-12 at 21:08 +0200, Daniel Vetter wrote: > > > On Fri, May 09, 2014 at 02:20:41PM -0600, Alex Williamson wrote: > > > > Commit 81b5c7bc found that the

Re: [PATCH] net: tunnels - enable module autoloading

2014-05-15 Thread Tom Gundersen
On Thu, May 15, 2014 at 11:32 PM, Stephen Hemminger wrote: > On Tue, 13 May 2014 10:48:28 +0200 > Tom Gundersen wrote: > >> Enable the module alias hookup to allow tunnel modules to be autoloaded on >> demand. >> >> This is in line with how most other netdev kinds work, and will allow >>

Re: [patch 2/2] rtmutex: Avoid pointless requeueing in the deadlock detection chain walk

2014-05-15 Thread Steven Rostedt
On Wed, 14 May 2014 20:03:27 - Thomas Gleixner wrote: > /* Release the task */ > raw_spin_unlock_irqrestore(>pi_lock, flags); > + /* > + * We must abort the chain walk if there is no lock owner even > + * in the dead lock detection case, as we have nothing to > +

Re: [PATCH v2] zram: remove global tb_lock with fine grain lock

2014-05-15 Thread Andrew Morton
On Thu, 15 May 2014 16:00:47 +0800 Weijie Yang wrote: > Currently, we use a rwlock tb_lock to protect concurrent access to > the whole zram meta table. However, according to the actual access model, > there is only a small chance for upper user to access the same table[index], > so the current

Re: [PATCH] net: tunnels - enable module autoloading

2014-05-15 Thread Stephen Hemminger
On Tue, 13 May 2014 10:48:28 +0200 Tom Gundersen wrote: > Enable the module alias hookup to allow tunnel modules to be autoloaded on > demand. > > This is in line with how most other netdev kinds work, and will allow > userspace > to create tunnels without having CAP_SYS_MODULE. > >

Re: [PATCH 2/4] x86: SROP mitigation: implement signal canaries

2014-05-15 Thread Andi Kleen
Erik Bosman writes: > > diff --git a/arch/x86/ia32/ia32_signal.c b/arch/x86/ia32/ia32_signal.c > index 2206757..1a9285a 100644 > --- a/arch/x86/ia32/ia32_signal.c > +++ b/arch/x86/ia32/ia32_signal.c > @@ -212,9 +212,18 @@ asmlinkage long sys32_sigreturn(void) > struct sigframe_ia32

Re: mm: NULL ptr deref handling mmaping of special mappings

2014-05-15 Thread Cyrill Gorcunov
On Fri, May 16, 2014 at 12:19:14AM +0400, Cyrill Gorcunov wrote: > > I see what you mean. We're rather targeting on bare x86-64 at the moment > but compat mode is needed as well (not yet implemented though). I'll take > a precise look into this area. Thanks! Indeed, because we were not running

Re: [PATCH 8/8] printk: Add config option for disabling printk offloading

2014-05-15 Thread Jan Kara
On Wed 23-04-14 11:17:50, Andrew Morton wrote: > On Wed, 23 Apr 2014 13:08:47 +0200 Jan Kara wrote: > > > > If you want reliable crash logging then we need to be able to set a > > > printk level mask per console and just set the serial console for > > > "crit/err" and the queue console for the

Re: [PATCH v5 5/6] exynos: cpuidle: do not allow cpuidle registration for Exynos5420

2014-05-15 Thread Tomasz Figa
Hi Chander, On 14.05.2014 10:03, Chander Kashyap wrote: > Exynos5420 is big.Little Soc. It uses cpuidle-big-litle generic cpuidle > driver. > Hence do not allow exynos cpuidle driver registration for Exynos5420. > > Signed-off-by: Chander Kashyap > Signed-off-by: Chander Kashyap > Acked-by:

[RFC 1/1] vmlinux.lds.h: Add new SECTION() macro

2014-05-15 Thread Geoff Levand
Add a new preprocessor macro SECTION() to vmlinux.lds.h that defines a linker script output section with the section attributes commonly used, and replace all occurrences of equivalent descriptions in vmlinux.lds.h with the new macro. Based on linker script fixes in the commit log, creating or

Re: [PATCH] mm: filemap: Avoid unnecessary barries and waitqueue lookups in unlock_page fastpath v4

2014-05-15 Thread Andrew Morton
On Thu, 15 May 2014 11:48:09 +0100 Mel Gorman wrote: > Changelog since v3 > o Correct handling of exclusive waits > > This patch introduces a new page flag for 64-bit capable machines, > PG_waiters, to signal there are processes waiting on PG_lock and uses it to > avoid memory barriers and

Re: [PATCH v2]: fix Haswell precise store data source encoding

2014-05-15 Thread Andi Kleen
> Looking at the SDM documentation it does say something about > 'UOPS_RETIRED.ALL' supporting stores too but can't find that event. Is > that a typo, much like the 0x02 umask for stores on the D0 event is > missing from the documentation? Just wanted to make sure we are not > missing one more

[PATCH 4/4] x86: SROP mitigation: implement signal counting

2014-05-15 Thread Erik Bosman
This patch implements signal counting for x86-64, x86-32 and x32. Signed-off-by: Erik Bosman --- arch/x86/Kconfig| 1 + arch/x86/ia32/ia32_signal.c | 10 ++ arch/x86/kernel/signal.c| 19 +++ 3 files changed, 30 insertions(+) diff --git

[PATCH v2] net: tunnels - enable module autoloading

2014-05-15 Thread Tom Gundersen
Enable the module alias hookup to allow tunnel modules to be autoloaded on demand. This is in line with how most other netdev kinds work, and will allow userspace to create tunnels without having CAP_SYS_MODULE. Signed-off-by: Tom Gundersen --- v2: add ';' Hi Dave, I must have sent out the

[PATCH 3/4] SROP mitigation: Add signal counting mechanism

2014-05-15 Thread Erik Bosman
Add a signal counting mechanism for architectures to use in order to check whether the kernel should allow a {rt_,}sigreturn call to succeed. If there are no signal handlers that yet have to return, we can conclude this is not a legitimate call to {rt_,}sigreturn. We do signal counting per

[PATCH 1/4] SROP mitigation: Architecture independent code for signal canaries

2014-05-15 Thread Erik Bosman
Architecture independent code for signal canaries Add support for canary values in user-space signal frames. These canaries function much like stack canaries/cookies, making it harder for an attacker to fake a call to {rt_,}sigreturn() This patch deals with architecture independent changes

[PATCH 2/4] x86: SROP mitigation: implement signal canaries

2014-05-15 Thread Erik Bosman
This patch implements signal canaries for x86-64, x86-32 and x32. Signed-off-by: Erik Bosman --- arch/x86/Kconfig| 1 + arch/x86/ia32/ia32_signal.c | 27 +++ arch/x86/include/asm/sigframe.h | 12 arch/x86/kernel/signal.c| 41

Re: [PATCH] x86: skip check for spurious faults for non-present faults

2014-05-15 Thread H. Peter Anvin
I'm trying to wrap my head around any forward compatibility concerns... if we misidentify a fault as spurious that would be bad. On May 15, 2014 1:50:13 PM PDT, Dave Hansen wrote: >On 05/12/2014 03:29 AM, David Vrabel wrote: >> -/* Reserved-bit violation or user access to kernel space? */

Re: [RFC PATCH 06/10] usb: xhci: Add Tegra XHCI host-controller driver

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 01:18:22PM -0700, Andrew Bresticker wrote: > Arnd, > > On Thu, May 15, 2014 at 1:17 AM, Arnd Bergmann wrote: > > On Wednesday 14 May 2014 17:33:02 Andrew Bresticker wrote: > >> + > >> +int tegra_xhci_register_mbox_notifier(struct notifier_block *nb) > >> +{ > >> + int

Re: [2/2] conditionally reschedule in hashtab_insert while loading selinux policy.

2014-05-15 Thread Paul Moore
On Thursday, May 15, 2014 03:03:53 PM Dave Jones wrote: > After silencing the sleeping warning in mls_convert_context() I started > seeing similar traces from hashtab_insert. Do a cond_resched there too. > > Signed-off-by: Dave Jones Merged to the SELinux #next branch, thanks. > diff --git

Re: [RFC PATCH 06/10] usb: xhci: Add Tegra XHCI host-controller driver

2014-05-15 Thread Alan Stern
On Thu, 15 May 2014, Andrew Bresticker wrote: > > This does not feel appropriate at all: Rather than creating a child device, > > you should have a specific driver that hooks into functions exported > > by the xhci core. See Documentation/driver-model/design-patterns.txt > > This is how DWC3,

Re: [1/2] conditionally reschedule in mls_convert_context while loading selinux policy.

2014-05-15 Thread Paul Moore
On Thursday, May 15, 2014 03:02:53 PM Dave Jones wrote: > On a slow machine (with debugging enabled), upgrading selinux policy may > take a considerable amount of time. Long enough that the softlockup > detector gets triggered. > > The backtrace looks like this.. > > > BUG: soft lockup - CPU#2

[PATCH] ACPI / PM: Hold ACPI scan lock over the "freeze" sleep state

2014-05-15 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The "freeze" sleep state suffers from the same issue that was addressed by commit ad07277e82de (ACPI / PM: Hold acpi_scan_lock over system PM transitions) for ACPI sleep states, that is, things break if ->remove() is called for devices whose system resume callbacks

Re: [PATCH] HID: rmi: fix masks for x and w_x data

2014-05-15 Thread Benjamin Tissoires
On May 15 2014 or thereabouts, Andrew Duggan wrote: > The F11 data in the HID report contains four bits of data for w_x and the > least significant bits > of x. Currently only the first three bits are being used which is resulting > in small jumps in > the position data on the x axis and in the

Re: [PATCH 00/25] Change time_t and clock_t to 64 bit

2014-05-15 Thread One Thousand Gnomes
> > could do intelligent interpolation about what the epoch is, so in 2039 > > if we get a low 32 bit time_t value, we assume epoch == 1, conversely if > > we see a high one, we assume epoch == 0. We could add epoch on the end > > of the syscalls and detect if it's not present and fill in an > >

Re: [PATCH 00/25] Change time_t and clock_t to 64 bit

2014-05-15 Thread Joseph S. Myers
On Thu, 15 May 2014, Arnd Bergmann wrote: > > The distribution side of the change for _FILE_OFFSET_BITS (i.e., moving to > > building libraries that way so a glibc change to the default wouldn't > > cause issues for other libraries' ABIs) has gradually been done. The > > discussion in March

Re: [patch v4] Documentation/email-clients.txt: add a section about git

2014-05-15 Thread Randy Dunlap
On 05/15/2014 02:33 AM, Dan Carpenter wrote: > These days most people use git to send patches so I have added a section > about that. > > Signed-off-by: Dan Carpenter Applied. Thanks. > --- > v2: fix typo in commit message > v3: update git am and log commands. Mention the man pages. > v4:

[PATCH] HID: rmi: fix masks for x and w_x data

2014-05-15 Thread Andrew Duggan
The F11 data in the HID report contains four bits of data for w_x and the least significant bits of x. Currently only the first three bits are being used which is resulting in small jumps in the position data on the x axis and in the w_x data. Signed-off-by: Andrew Duggan ---

Re: [PATCH] staging/rtl8723au fix sparse warning in os_initfs.c

2014-05-15 Thread Dan Carpenter
On Thu, May 15, 2014 at 10:43:34PM +0200, Konrad Zapalowicz wrote: > This commit fixes the following sparse warning: > > drivers/staging/rtl8723au/os_dep/os_intfs.c: > - 322:14: warning: restricted __be16 degrades to integer > > Signed-off-by: Konrad Zapalowicz > --- >

Re: [PATCH 3/4] ip_tunnel: delete unneeded call to netdev_priv

2014-05-15 Thread David Miller
From: Julia Lawall Date: Thu, 15 May 2014 05:43:20 +0200 > From: Julia Lawall > > Netdev_priv is an accessor function, and has no purpose if its result is > not used. > > A simplified version of the semantic match that fixes this problem is as > follows: (http://coccinelle.lip6.fr/) > > //

Re: [PATCH 2/4] net/ariadne: delete unneeded call to netdev_priv

2014-05-15 Thread David Miller
From: Julia Lawall Date: Thu, 15 May 2014 05:43:19 +0200 > From: Julia Lawall > > Netdev_priv is an accessor function, and has no purpose if its result is > not used. > > A simplified version of the semantic match that fixes this problem is as > follows: (http://coccinelle.lip6.fr/) > > //

Re: [RFC] cpufreq: send notifications for intermediate (stable) frequencies

2014-05-15 Thread Doug Anderson
Stephen, On Thu, May 15, 2014 at 1:51 PM, Stephen Warren wrote: > On 05/15/2014 02:39 PM, Doug Anderson wrote: >> Hi, >> >> On Thu, May 15, 2014 at 12:17 PM, Stephen Warren >> wrote: >>> On 05/14/2014 11:56 PM, Viresh Kumar wrote: Douglas Anderson, recently pointed out an interesting

Re: [PATCH 4/4] vti6: delete unneeded call to netdev_priv

2014-05-15 Thread David Miller
From: Julia Lawall Date: Thu, 15 May 2014 05:43:21 +0200 > From: Julia Lawall > > Netdev_priv is an accessor function, and has no purpose if its result is > not used. > > A simplified version of the semantic match that fixes this problem is as > follows: (http://coccinelle.lip6.fr/) > > //

Re: [PATCH 1/4] drivers/net/wan: delete unneeded call to netdev_priv

2014-05-15 Thread David Miller
From: Julia Lawall Date: Thu, 15 May 2014 05:43:18 +0200 > Netdev_priv is an accessor function, and has no purpose if its result is > not used. > > A simplified version of the semantic match that fixes this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ local idexpression

[PATCH] ARM: OMAP: replace checks for CONFIG_USB_GADGET_OMAP

2014-05-15 Thread Paul Bolle
Commit 193ab2a60700 ("usb: gadget: allow multiple gadgets to be built") apparently required that checks for CONFIG_USB_GADGET_OMAP would be replaced with checks for CONFIG_USB_OMAP. Do so now for the remaining checks for CONFIG_USB_GADGET_OMAP, even though these checks have basically been broken

[PATCH 4/4] Documentation: update /proc/stat "intr" count summary

2014-05-15 Thread Randy Dunlap
From: Jan Moskyto Matejka The sum at the beginning of line "intr" includes also unnumbered interrupts. It implies that the sum at the beginning isn't the sum of the remainder of the line, not even an estimation. Fixed the documentation to mention that. This behaviour was added to /proc/stat in

[PATCH 3/4] Documentation: update java sample wrapper for java 7

2014-05-15 Thread Randy Dunlap
From: Jonathan Callen The sample wrapper currently fails on some Java 7 .class files. This updates the wrapper to properly handle those files. Signed-off-by: Jonathan Callen Signed-off-by: Randy Dunlap --- Documentation/java.txt |8 1 file changed, 8 insertions(+) ---

[PATCH 2/4] Documentation: update thunderbird email client settings

2014-05-15 Thread Randy Dunlap
From: Paul McQuade Added setting to email-clients that is easier to read and is easier to setup thunderbird. Removed config settings and added GUI settings. Signed-off-by: Paul McQuade Signed-off-by: Randy Dunlap --- Documentation/email-clients.txt | 15 +-- 1 file changed, 5

[PATCH 1/4] Documentation: fix typos in drm docbook

2014-05-15 Thread Randy Dunlap
From: Masanari Iida Fix spelling typo in DocBook/drm.tmpl Signed-off-by: Masanari Iida Signed-off-by: Randy Dunlap --- Documentation/DocBook/drm.tmpl | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) --- lnx-315-rc2.orig/Documentation/DocBook/drm.tmpl +++

Re: [PATCH v1 5/5] pci: keystone: add pcie driver based on designware core driver

2014-05-15 Thread Jason Gunthorpe
On Thu, May 15, 2014 at 04:04:47PM -0400, Murali Karicheri wrote: > Jason What you mean by "The PCI core handles setting the maximum > read request size already" I see there is function pcie_write_mrrs() > in the drivers/pci/probe.c that reads the mps using pcie_get_mps() > and then set mrrs to

Re: [PATCH v2] drivers: staging: line6: Add blank lines after declarations

2014-05-15 Thread Greg KH
On Wed, May 14, 2014 at 03:33:04AM +0300, Artem Fetishev wrote: > Use the more common kernel coding style. > > Version #2 of this patch removes unnecesary blank line added in version #1. This line isn't needed, it goes below the --- line. Also, sorry, someone else sent a valid version of this

Re: [RFC] cpufreq: send notifications for intermediate (stable) frequencies

2014-05-15 Thread Stephen Warren
On 05/15/2014 02:39 PM, Doug Anderson wrote: > Hi, > > On Thu, May 15, 2014 at 12:17 PM, Stephen Warren > wrote: >> On 05/14/2014 11:56 PM, Viresh Kumar wrote: >>> Douglas Anderson, recently pointed out an interesting problem due to which >>> his >>> udelay() was expiring earlier than it

Re: [PATCH v3 1/6] watchdog: Add API to trigger reboots

2014-05-15 Thread One Thousand Gnomes
> +void watchdog_do_reboot(void) > +{ > + if (wdd_reboot_dev) > + wdd_reboot_dev->ops->reboot(wdd_reboot_dev); > +} > +EXPORT_SYMBOL(watchdog_do_reboot); Crashes and burns if you are unloading a watchdog just as you try to reboot. Yes its wildly unlikely but it's still

Re: [PATCH 9/9] perf, tools, record: Always allow to overide default period v2

2014-05-15 Thread Andi Kleen
On Wed, May 14, 2014 at 02:50:47PM +0900, Namhyung Kim wrote: > On Mon, 12 May 2014 15:51:14 -0700, Andi Kleen wrote: > > From: Andi Kleen > > > > Fix the logic to allow overriding event default periods with -c or -F > > on the command line. I'm not sure I understand this if() fully, but > >

Re: [PATCH] x86: skip check for spurious faults for non-present faults

2014-05-15 Thread Dave Hansen
On 05/12/2014 03:29 AM, David Vrabel wrote: > - /* Reserved-bit violation or user access to kernel space? */ > - if (error_code & (PF_USER | PF_RSVD)) > + /* Only check for spurious faults on supervisor write or > +instruction faults. */ > + if (error_code != (PF_WRITE |

Re: [rfc]pwm: add xilinx pwm driver

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 06:30:13PM +0200, Arnd Bergmann wrote: > On Thursday 15 May 2014 15:56:03 Michal Simek wrote: > > IP is configurable as is normal for us. > > You can select IP with just one timer. > > It means register locations for specific timer are fixed. > >

Re: [RFC PATCH 00/10] Tegra XHCI support

2014-05-15 Thread Andrew Bresticker
On Thu, May 15, 2014 at 12:33 PM, Stephen Warren wrote: > On 05/14/2014 06:32 PM, Andrew Bresticker wrote: >> This is a first pass at the host and PHY drivers necessary for USB3.0 >> support on Tegra114 and Tegra124. The Tegra XHCI host controller requires >> external firmware [1] which must be

[PATCH] staging/rtl8723au fix sparse warning in os_initfs.c

2014-05-15 Thread Konrad Zapalowicz
This commit fixes the following sparse warning: drivers/staging/rtl8723au/os_dep/os_intfs.c: - 322:14: warning: restricted __be16 degrades to integer Signed-off-by: Konrad Zapalowicz --- drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 1/6] watchdog: Add API to trigger reboots

2014-05-15 Thread Guenter Roeck
Some hardware implements reboot through its watchdog hardware, for example by triggering a watchdog timeout. Platform specific code starts to spread into watchdog drivers, typically by setting pointers to a callback functions which is then called from the platform reset handler. To simplify code

Re: [PATCH 1/2] ti: Remove trailing semicolon from do {...} while (0) macro

2014-05-15 Thread David Miller
From: Joe Perches Date: Wed, 14 May 2014 12:15:13 -0700 > These should not have trailing semicolons so remove them. > > Signed-off-by: Joe Perches Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

[PATCH v3 3/6] arm64: Support reboot through watchdog subsystem

2014-05-15 Thread Guenter Roeck
The watchdog subsystem provides an API to perform a system reboot. Use it. Signed-off-by: Guenter Roeck --- v3: Drop reboot mode and cmd string parameters from API v2: No change arch/arm64/kernel/process.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/kernel/process.c

Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 07:37:32AM -0700, H. Peter Anvin wrote: > On 05/15/2014 05:38 AM, Daniel Vetter wrote: > > On Wed, May 14, 2014 at 09:41:12AM -0600, Ross Zwisler wrote: > >> With this commit: > >> > >> 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range > >> > >> If clflushopt is

[PATCH v3 4/6] arm: Support reboot through watchdog subsystem

2014-05-15 Thread Guenter Roeck
The watchdog subsystem provides an API to perform a system reboot. Use it. With this change, the arm_pm_restart callback is now optional, so check if it is set before calling it. Tested-by: Jonas Jensen Signed-off-by: Guenter Roeck --- v3: Drop reboot mode and cmd string parameters from API

[PATCH v3 6/6] watchdog: sunxi: Register reboot handler with watchdog subsystem

2014-05-15 Thread Guenter Roeck
The watchdog subsystem now provides an API to trigger a system reboot. Register with it. Acked-by: Maxime Ripard Signed-off-by: Guenter Roeck --- v3: Drop reboot mode and cmd string parameters from API v2: Rebased to v2 of Maxime's patch adding reboot support to the sunxi watchdog driver.

Re: [RFC PATCH 05/10] ARM: tegra: Export function to read USB calibration data

2014-05-15 Thread Stephen Warren
On 05/14/2014 06:33 PM, Andrew Bresticker wrote: > Board-specific USB configuration data is stored in FUSE_SKU_CALIB_0. > Export a function to read it so the PHY can be properly configured. This patch seems conceptually fine to me. Presumably once Peter's fuse driver is fleshed out, it can expose

Re: [PATCH 00/25] Change time_t and clock_t to 64 bit

2014-05-15 Thread Arnd Bergmann
On Thursday 15 May 2014 20:10:05 Joseph S. Myers wrote: > On Thu, 15 May 2014, Arnd Bergmann wrote: > > > Earlier in the thread there seemed to be a rough consensus that > > _TIME_BITS=64 wouldn't be a good idea because we wouldn't get everything > > changed to use it. For _FILE_OFFSET_BITS=64

Re: [RFC] cpufreq: send notifications for intermediate (stable) frequencies

2014-05-15 Thread Doug Anderson
Hi, On Thu, May 15, 2014 at 12:17 PM, Stephen Warren wrote: > On 05/14/2014 11:56 PM, Viresh Kumar wrote: >> Douglas Anderson, recently pointed out an interesting problem due to which >> his >> udelay() was expiring earlier than it should: >> https://lkml.org/lkml/2014/5/13/766 >> >> While

[PATCH v3 0/6] watchdog: Add reboot API

2014-05-15 Thread Guenter Roeck
Some hardware implements reboot through its watchdog hardware, for example by triggering a watchdog timeout or by writing into its watchdog register set. Platform specific code starts to spread into watchdog drivers, typically by setting pointers to a callback function which is then called from

[PATCH v3 2/6] watchdog: Document reboot API

2014-05-15 Thread Guenter Roeck
Document the new reboot API functionality. Signed-off-by: Guenter Roeck --- v3: Added documentation patch Documentation/watchdog/watchdog-kernel-api.txt | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Documentation/watchdog/watchdog-kernel-api.txt

[PATCH v3 5/6] watchdog: moxart: Register reboot handler with watchdog subsystem

2014-05-15 Thread Guenter Roeck
The watchdog subsystem now provides an API to trigger a system reboot. Register with it. Tested-by: Jonas Jensen Signed-off-by: Guenter Roeck --- v3: Drop reboot mode and cmd string parameters from API v2: No change drivers/watchdog/moxart_wdt.c | 19 +++ 1 file changed, 7

Re: [PATCH v12 11/31] documentation: iommu: add binding document of Exynos System MMU

2014-05-15 Thread Thierry Reding
On Mon, Apr 28, 2014 at 02:05:30PM +0200, Arnd Bergmann wrote: [...] > let me clarify by example: > > iommu@1 { > compatible = "some,simple-iommu"; > reg = <1>; > #iommu-cells = <0>; /* supports only one master */ > }; > > iommu@2 { >

Re: futex(2) man page update help request

2014-05-15 Thread Darren Hart
On 5/15/14, 7:14, "Thomas Gleixner" wrote: Wow Thomas, I planned to do exactly this and you beat me to it. Again. Thanks for getting this started. Michael, I imagine you want something more condensed, and I'll add to what tglx posted (inline below) to try and get you that, but if you have

Re: [lxc-devel] [RFC PATCH 00/11] Add support for devtmpfs in user namespaces

2014-05-15 Thread Richard Weinberger
Am 15.05.2014 22:26, schrieb Serge E. Hallyn: > Quoting Richard Weinberger (rich...@nod.at): >> Am 15.05.2014 21:50, schrieb Serge Hallyn: >>> Quoting Richard Weinberger (richard.weinber...@gmail.com): On Thu, May 15, 2014 at 4:08 PM, Greg Kroah-Hartman wrote: > Then don't use a

Re: [PATCH] ARM: imx: clean up error handling

2014-05-15 Thread Dan Carpenter
On Thu, May 15, 2014 at 09:24:30PM +0200, Emil Goode wrote: > If we fail to allocate struct platform_device pdev we > dereference it after the goto label err. > > I have rearranged the error handling a bit to fix the issue > and also make it more clear. > > Signed-off-by: Emil Goode > --- >

Re: [PATCH] Staging:dgnc:dgnc_driver open/close braces

2014-05-15 Thread Greg KH
On Wed, Apr 09, 2014 at 05:30:04PM +0100, Paul McQuade wrote: > ERROR: that open brace { should be on the previous line > ERROR: else should follow close brace '} > ERROR: space required before the open parenthesis '( > ERROR: trailing whitespace > ERROR: open brace '{' following function

Re: [RFC PATCH 3/3] clk: tegra: Implement Tegra124 shared/cbus clks

2014-05-15 Thread Stephen Warren
On 05/15/2014 04:52 AM, Peter De Schrijver wrote: > On Wed, May 14, 2014 at 04:27:40PM +0200, Thierry Reding wrote: >> * PGP Signed by an unknown key >> >> On Tue, May 13, 2014 at 12:09:49PM -0600, Stephen Warren wrote: >>> On 05/13/2014 08:06 AM, Peter De Schrijver wrote: Add shared and cbus

bq24190: What's the correct API to turn boost mode (OTG) on for the battery charger ?

2014-05-15 Thread Laurent Pinchart
Hello, I'm trying to enable battery charging on an OMAP4 board based on a twl6030 PMIC with external bq24190 battery charger and bq27510 fuel gauge. The system has an OTG USB port that can be used to charge the battery, and that can also be used in host mode. In that case the bq24190 needs to

Re: [PATCH 0/6 V2] x86, nmi: Various fixes and cleanups

2014-05-15 Thread Don Zickus
On Thu, May 15, 2014 at 03:25:43PM -0400, Don Zickus wrote: > I started this patch by fixing a performance problem with the GHES > NMI handler and then things evolved to more patches as I was poking > around in the code. > > The main focus was moving the GHES NMI driver to its own NMI subtype >

Re: [PATCH v2]: fix Haswell precise store data source encoding

2014-05-15 Thread Don Zickus
On Thu, May 15, 2014 at 10:08:51PM +0200, Stephane Eranian wrote: > On Thu, May 15, 2014 at 9:56 PM, Don Zickus wrote: > > On Thu, May 15, 2014 at 05:56:44PM +0200, Stephane Eranian wrote: > >> > >> This patch fixes a bug in precise_store_data_hsw() whereby > >> it would set the data source

Re: [lxc-devel] [RFC PATCH 00/11] Add support for devtmpfs in user namespaces

2014-05-15 Thread Serge E. Hallyn
Quoting Richard Weinberger (rich...@nod.at): > Am 15.05.2014 21:50, schrieb Serge Hallyn: > > Quoting Richard Weinberger (richard.weinber...@gmail.com): > >> On Thu, May 15, 2014 at 4:08 PM, Greg Kroah-Hartman > >> wrote: > >>> Then don't use a container to build such a thing, or fix the build >

Re: [RFC PATCH 08/10] ARM: tegra124: Bind CAR to syscon device

2014-05-15 Thread Andrew Bresticker
On Thu, May 15, 2014 at 12:25 PM, Stephen Warren wrote: > On 05/14/2014 06:33 PM, Andrew Bresticker wrote: >> The XUSB PHY driver will be accessing the CAR registers through the >> syscon interface. > > I very strongly don't want to use the syscon concept on Tegra. Instead, > I want only the CAR

Re: futex(2) man page update help request

2014-05-15 Thread Michael Kerrisk (man-pages)
On 05/15/2014 04:14 PM, Thomas Gleixner wrote: > On Thu, 15 May 2014, Michael Kerrisk (man-pages) wrote: >> And that universe would love to have your documentation of >> FUTEX_WAKE_BITSET and FUTEX_WAIT_BITSET ;-), > > I give you almost the full treatment, but I leave REQUEUE_PI to Darren > and

Re: mm: NULL ptr deref handling mmaping of special mappings

2014-05-15 Thread Cyrill Gorcunov
On Thu, May 15, 2014 at 12:59:04PM -0700, Andy Lutomirski wrote: > >> > >> What version and bitness is this? > > > > x86-64, 3.15-rc5 > > Aha. Give tip/x86/vdso or -next a try or boot a 32-bit 3.15-rc kernel > and you'll see it. I see what you mean. We're rather targeting on bare x86-64 at the

Re: [PATCH 3/9] perf, tools: Add support for reading JSON event files

2014-05-15 Thread Andi Kleen
> And more generally, can we extend these if-else's to a generic loop to > check a table like in match_field() so that it can be added easily? The simple cases are all already handled in a table above. The if() only contains cases that need special code. I don't think callbacks would be better

Re: [RFC PATCH 06/10] usb: xhci: Add Tegra XHCI host-controller driver

2014-05-15 Thread Andrew Bresticker
Arnd, On Thu, May 15, 2014 at 1:17 AM, Arnd Bergmann wrote: > On Wednesday 14 May 2014 17:33:02 Andrew Bresticker wrote: >> + >> +int tegra_xhci_register_mbox_notifier(struct notifier_block *nb) >> +{ >> + int ret; >> + >> + mutex_lock(_xhci_mbox_lock); >> + ret =

Re: [lxc-devel] [RFC PATCH 00/11] Add support for devtmpfs in user namespaces

2014-05-15 Thread Richard Weinberger
Am 15.05.2014 21:50, schrieb Serge Hallyn: > Quoting Richard Weinberger (richard.weinber...@gmail.com): >> On Thu, May 15, 2014 at 4:08 PM, Greg Kroah-Hartman >> wrote: >>> Then don't use a container to build such a thing, or fix the build >>> scripts to not do that :) >> >> I second this. >> To

Re: [PATCH 7/7] ARM: tegra: Add the EC i2c tunnel to tegra124-venice2

2014-05-15 Thread Olof Johansson
On Thu, May 15, 2014 at 11:55 AM, Doug Anderson wrote: > Stephen, > > On Thu, May 15, 2014 at 11:42 AM, Stephen Warren > wrote: >> On 04/17/2014 11:59 AM, Doug Anderson wrote: >>> This adds the EC i2c tunnel (and devices under it) to the >>> tegra124-venice2 device tree. >> >> Did the MFD

Re: [PATCH 5/9] perf, tools: Add perf download to download event files v2

2014-05-15 Thread Andi Kleen
> Could you please extend this script to support curl also? It seems the > wget is not installed by default on my system. I looked at it, but it's a major pain because curl is totally incompatible. I don't think it's a major burden to install wget? > > +set -e > > + > > +if [ "$1" == "" ] ;

Re: [PATCH 00/25] Change time_t and clock_t to 64 bit

2014-05-15 Thread Joseph S. Myers
On Thu, 15 May 2014, Arnd Bergmann wrote: > Earlier in the thread there seemed to be a rough consensus that > _TIME_BITS=64 wouldn't be a good idea because we wouldn't get everything > changed to use it. For _FILE_OFFSET_BITS=64 that's ok because most > user space doesn't ever want to deal with

Re: [PATCH v2]: fix Haswell precise store data source encoding

2014-05-15 Thread Stephane Eranian
On Thu, May 15, 2014 at 9:56 PM, Don Zickus wrote: > On Thu, May 15, 2014 at 05:56:44PM +0200, Stephane Eranian wrote: >> >> This patch fixes a bug in precise_store_data_hsw() whereby >> it would set the data source memory level to the wrong value. >> >> As per the the SDM Vol 3b Table 18-41

Re: [PATCH v1 5/5] pci: keystone: add pcie driver based on designware core driver

2014-05-15 Thread Murali Karicheri
On 5/15/2014 2:39 PM, Jason Gunthorpe wrote: On Thu, May 15, 2014 at 08:20:13PM +0200, Arnd Bergmann wrote: On Thursday 15 May 2014 13:45:08 Murali Karicheri wrote: +#ifdef CONFIG_PCI_KEYSTONE +/* + * The KeyStone PCIe controller has maximum read request size of 256 bytes. + */ +static void

Re: mm: NULL ptr deref handling mmaping of special mappings

2014-05-15 Thread Andy Lutomirski
On Thu, May 15, 2014 at 12:53 PM, Cyrill Gorcunov wrote: > On Thu, May 15, 2014 at 12:46:34PM -0700, Andy Lutomirski wrote: >> On Thu, May 15, 2014 at 1:45 AM, Cyrill Gorcunov wrote: >> > On Wed, May 14, 2014 at 03:23:27PM -0700, Andy Lutomirski wrote: >> >> I can summarize: >> >> >> >> On 3.14

Re: [PATCH v2]: fix Haswell precise store data source encoding

2014-05-15 Thread Don Zickus
On Thu, May 15, 2014 at 05:56:44PM +0200, Stephane Eranian wrote: > > This patch fixes a bug in precise_store_data_hsw() whereby > it would set the data source memory level to the wrong value. > > As per the the SDM Vol 3b Table 18-41 (Layout of Data Linear > Address Information in PEBS

[PATCH] ARM: OMAP: AM3517EVM: remove check for CONFIG_PANEL_SHARP_LQ043T1DG01

2014-05-15 Thread Paul Bolle
The Kconfig symbol PANEL_SHARP_LQ043T1DG01 was removed in v2.6.38. The check for CONFIG_PANEL_SHARP_LQ043T1DG01 and its MODULE variant has evaluated to false ever since. Remove that check. Signed-off-by: Paul Bolle --- Untested, again. arch/arm/mach-omap2/board-am3517evm.c | 5 - 1 file

Re: mm: NULL ptr deref handling mmaping of special mappings

2014-05-15 Thread Cyrill Gorcunov
On Thu, May 15, 2014 at 12:46:34PM -0700, Andy Lutomirski wrote: > On Thu, May 15, 2014 at 1:45 AM, Cyrill Gorcunov wrote: > > On Wed, May 14, 2014 at 03:23:27PM -0700, Andy Lutomirski wrote: > >> I can summarize: > >> > >> On 3.14 and before, the vdso is just a bunch of ELF headers and > >>

[PATCH v5 UPDATED 1/3] smp: Print more useful debug info upon receiving IPI on an offline CPU

2014-05-15 Thread Srivatsa S. Bhat
On 05/16/2014 01:13 AM, Joe Perches wrote: [...] > Ah, good. > > I was misled a bit by the WARN_ONCE that is in the > same block. Perhaps because there is a guard flag > above the block, maybe the WARN_ONCE should just be > WARN. > Ah, right, just WARN is sufficient there. Thanks!

Re: [Xen-devel] [PATCH 7/9] x86: skip check for spurious faults for non-present faults

2014-05-15 Thread H. Peter Anvin
On 05/15/2014 12:22 PM, Keir Fraser wrote: >> >> Are we chasing hardware errata here? Or did someone go off and *assume* >> that the x86 hardware architecture work a certain way? Or is there >> something way more subtle going on? > > See Intel Developer's Manual Vol 3 Section 4.10.4.3, 3rd

Re: [lxc-devel] [RFC PATCH 00/11] Add support for devtmpfs in user namespaces

2014-05-15 Thread Serge Hallyn
Quoting Richard Weinberger (richard.weinber...@gmail.com): > On Thu, May 15, 2014 at 4:08 PM, Greg Kroah-Hartman > wrote: > > Then don't use a container to build such a thing, or fix the build > > scripts to not do that :) > > I second this. > To me it looks like some folks try to (ab)use Linux

Re: [PATCH] ARM: OMAP: remove some dead code

2014-05-15 Thread Aaro Koskinen
On Thu, May 15, 2014 at 09:16:21PM +0200, Paul Bolle wrote: > A check for CONFIG_CBUS_TAHVO_USB was added in v2.6.17. The related > Kconfig symbol has never been part of the tree. Remove that check. > > Replace the while (...) loop with a simple if (...) statement, while > we're at it. > >

Re: mm: NULL ptr deref handling mmaping of special mappings

2014-05-15 Thread Andy Lutomirski
On Thu, May 15, 2014 at 1:45 AM, Cyrill Gorcunov wrote: > On Wed, May 14, 2014 at 03:23:27PM -0700, Andy Lutomirski wrote: >> I can summarize: >> >> On 3.14 and before, the vdso is just a bunch of ELF headers and >> executable data. When executed by 64-bit binaries, it reads from the >> fixmap

<    1   2   3   4   5   6   7   8   9   10   >