This patch adds and document a new KVM_DEV_VFIO_DEVICE group
and 2 device attributes: KVM_DEV_VFIO_DEVICE_FORWARD_IRQ,
KVM_DEV_VFIO_DEVICE_UNFORWARD_IRQ. The purpose is to be able
to set a VFIO device IRQ as forwarded or not forwarded.
the command takes as argument a handle to a new struct named
The VFIO external user API is enriched with 3 new functions that
allows a kernel user external to VFIO to retrieve some information
from a VFIO device.
- vfio_device_get_external_user enables to get a vfio device from
its fd and increments its reference counter
- vfio_device_put_external_user
On Sun, Nov 23, 2014 at 07:21:08PM +0100, Oleg Nesterov wrote:
> > Perhaps this is migration thread? stop_sched_class doesn't have
> > ->update_curr.
>
> Yes, I think this can explain the problem, but
>
> > could you try to cat /proc/pid-of-migration-thread/stat on your machine?
>
> This won't
This patch introduces a new KVM_DEV_VFIO_DEVICE group.
This is a new control channel which enables KVM to cooperate with
viable VFIO devices.
Functions are introduced to check the validity of a VFIO device
file descriptor, increment/decrement the ref counter of the VFIO
device.
The patch
Used by KVM-enabled VFIO-based device passthrough support in QEMU.
Signed-off-by: Joel Schopp
Signed-off-by: Eric Auger
---
Extracted from [RFC PATCH] arm64: KVM: add irqfd support
http://www.spinics.net/lists/kvm-arm/msg10798.html
---
arch/arm64/kvm/Kconfig | 1 +
arch/arm64/kvm/Makefile |
Provide wrapper functions that allow KVM-VFIO device code to
interact with a vfio device:
- kvm_vfio_device_get_external_user gets a handle to a struct
vfio_device from the vfio device file descriptor and increments
its reference counter,
- kvm_vfio_device_put_external_user decrements the
This patch sets __KVM_HAVE_ARCH_KVM_VFIO_FORWARD and implements
kvm_arch_vfio_set_forward for ARM.
As a result the KVM-VFIO device now allows to forward/unforward a
VFIO device IRQ on ARM.
kvm_arch_vfio_set_forward programs both genirq and the VGIC to control
where the physical IRQ deactivation
Hi Linus,
The following changes since commit fc14f9c1272f62c3e8d01300f52467c0d9af50f9:
Linux 3.18-rc5 (2014-11-16 16:36:20 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git
tags/armsoc-for-rc6
for you to fetch changes up to
From: Markus Elfring
Date: Sun, 23 Nov 2014 19:13:56 +0100
Another update suggestion was taken into account after a patch was applied
from static source code analysis.
Markus Elfring (2):
Deletion of unnecessary checks before two function calls
One function call less in ion_buffer_create()
On 11/23, Borislav Petkov wrote:
>
> On Sun, Nov 23, 2014 at 06:22:56PM +0100, Oleg Nesterov wrote:
> > Could you identify somehow the line which matches
> > task_sched_runtime+0x99 ? Probably do_task_delta_exec()...
>
> See http://marc.info/?l=linux-kernel=141675498417759=2
>
> Chris triggers the
Hi Rik,
On 11/21/2014 08:52 PM, Rik van Riel wrote:
When manipulating just one semaphore with semop, sem_lock only takes that
single semaphore's lock. This creates a problem during initialization of
the semaphore array, when the data structures used by sem_lock have not
been set up yet. The
Damn, sorry for noise ;)
On 11/23, Oleg Nesterov wrote:
>
> On 11/23, Oleg Nesterov wrote:
> >
> > On 11/23, Oleg Nesterov wrote:
> > >
> > > On 11/23, Borislav Petkov wrote:
> > > >
> > > > where we end up with a zero PMD. RIP is corrupted too so we're somewhere
> > > > off in the fields.
> > >
On 11/23, Oleg Nesterov wrote:
>
> On 11/23, Oleg Nesterov wrote:
> >
> > On 11/23, Borislav Petkov wrote:
> > >
> > > where we end up with a zero PMD. RIP is corrupted too so we're somewhere
> > > off in the fields.
> >
> > PMD = 0 is fine I guess, addr == 0 is not mapped.
> >
> > > Comment over
When the VGIC is destroyed it must take care of
- restoring the forwarded IRQs in non forwarded state,
- deactivating the IRQ in case the guest left without doing it
- cleaning nodes of the phys_map rbtree
Signed-off-by: Eric Auger
---
virt/kvm/arm/vgic.c | 36
This patch handles the case where irqfd attempts to inject
a forwarded IRQ before the vgic is ready to accept it. We
cannot simply return pretending nothing happened since the IRQ
will never be deactivated by the guest. Indeed, the corresponding
virtual IRQ cannot be injected into the guest and
Fix multiple injection of level sensitive forwarded IRQs.
With current code, the second injection fails since the state bitmaps
are not reset (process_maintenance is not called anymore).
New implementation follows those principles:
- A forwarded IRQ only can be sampled when it is pending
- when
This series applies on top of "ARM: Forwarding physical
interrupts to a guest VM" (http://lwn.net/Articles/603514/)
series.
It brings some extra functionalities that were requested to
be able to inject virtual level sensitive IRQs triggered from
VFIO/irqfd.
It adds:
- a specific handling of
Add a lock related to the rb tree manipulation. The rb tree can be
searched in one thread (irqfd handler for instance) and map/unmap
may happen in another.
Signed-off-by: Eric Auger
---
v2 -> v3:
re-arrange lock sequence in vgic_map_phys_irq
---
include/kvm/arm_vgic.h | 1 +
CONFIG_HAVE_KVM_IRQCHIP is needed to support IRQ routing (along
with irq_comm.c and irqchip.c usage). This is not the case for
arm/arm64 currently.
This patch unsets the flag for both arm and arm64.
Signed-off-by: Eric Auger
---
arch/arm/kvm/Kconfig | 2 --
arch/arm64/kvm/Kconfig | 1 -
2
From: Joel Schopp
This patch enables irqfd for arm64.
Signed-off-by: Joel Schopp
Signed-off-by: Eric Auger
---
[Eric Auger]
- originates from Joel's [RFC PATCH] arm64: KVM: add irqfd support
http://www.spinics.net/lists/kvm-arm/msg10798.html
- isolates modifications really related to
This patch enables irqfd on arm.
Both irqfd and resamplefd are supported. Injection is implemented
in vgic.c without routing.
This patch enables CONFIG_HAVE_KVM_EVENTFD and CONFIG_HAVE_KVM_IRQFD.
KVM_CAP_IRQFD is now advertised. KVM_CAP_IRQFD_RESAMPLE capability
automatically is advertised as
This patch series enables irqfd on arm and arm64.
Irqfd framework enables to inject a virtual IRQ into a guest upon an
eventfd trigger. User-side uses KVM_IRQFD VM ioctl to provide KVM with
a kvm_irqfd struct that associates a VM, an eventfd, a virtual IRQ number
(aka. the gsi). When an actor
On 11/23, Oleg Nesterov wrote:
>
> On 11/23, Borislav Petkov wrote:
> >
> > where we end up with a zero PMD. RIP is corrupted too so we're somewhere
> > off in the fields.
>
> PMD = 0 is fine I guess, addr == 0 is not mapped.
>
> > Comment over thread_group_cputime() talks about dead tasks
On Sat, Nov 22, 2014 at 09:22:42AM -0500, Tejun Heo wrote:
> While decoupling ATOMIC and DEAD flags, f47ad4578461 ("percpu_ref:
> decouple switching to percpu mode and reinit") updated
> __ref_is_percpu() so that it only tests ATOMIC flag to determine
> whether the ref is in percpu mode or not;
Hello, Linus.
This pull request contains one patch to fix a race condition which can
lead to percpu_ref using a percpu pointer which is corrupted with a
set DEAD bit. The bug was introduced while separating out the ATOMIC
mode flag from the DEAD flag. The fix is pretty straight forward.
I just
On Sun, Nov 23, 2014 at 06:22:56PM +0100, Oleg Nesterov wrote:
> Could you identify somehow the line which matches
> task_sched_runtime+0x99 ? Probably do_task_delta_exec()...
See http://marc.info/?l=linux-kernel=141675498417759=2
Chris triggers the same splat and reverting
6e998916dfe3
On Sun, Nov 23, 2014 at 03:26:54PM +0530, Lekshmi wrote:
> The following chaeckpatch warning was fixed:
> WARNING: line over 80 characters
>
> Signed-off-by: Lekshmi
I need a "full and real" name here in order to be able to accept any
patch.
--
To unsubscribe from this list: send the line
From: Eric Dumazet
rcu_dereference() should be used in sections protected by rcu_read_lock.
For writers, holding some kind of mutex or lock,
rcu_dereference_protected() is the way to go, adding explicit lockdep
bits.
In __unbind(), we are the last user of this mapped device, so can use
the
On Sun, 2014-11-23 at 11:53 -0500, Mike Snitzer wrote:
> On Sun, Nov 23, 2014 at 11:40 AM, Eric Dumazet wrote:
> > From: Eric Dumazet
> >
> > rcu_dereference() should be used in sections protected by rcu_read_lock.
> >
> > For writers, holding some kind of mutex or lock,
> >
On Sun, Nov 23, 2014 at 03:26:54PM +0530, Lekshmi wrote:
> The following chaeckpatch warning was fixed:
> WARNING: line over 80 characters
>
> Signed-off-by: Lekshmi
> ---
> drivers/staging/wlan-ng/prism2fw.c |6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git
On 11/23, Borislav Petkov wrote:
>
> where we end up with a zero PMD. RIP is corrupted too so we're somewhere
> off in the fields.
PMD = 0 is fine I guess, addr == 0 is not mapped.
> Comment over thread_group_cputime() talks about dead tasks accounting
This comment simply means that we also
From: Hakjoo Kim
Add the required pin configuration support to Exynos5410 using pinctrl
interface.
Signed-off-by: Hakjoo Kim
[AF: Rebased, style changes]
Signed-off-by: Andreas Färber
---
v2 -> v3:
* Added wake-up IRQ controller node (Tomasz Figa)
v1 -> v2:
* Filled in Sob from Hakjoo
Am 22.11.2014 um 21:26 schrieb Andreas Färber:
> From: Hakjoo Kim
>
> Add the required pin configuration support to Exynos5410 using pinctrl
> interface.
>
> Signed-off-by: Hakjoo Kim
> [AF: Rebased, style changes]
> Signed-off-by: Andreas Färber
> ---
> v1 -> v2:
> * Filled in Sob from
On Sun, Nov 23, 2014 at 01:48:06PM +0100, Julia Lawall wrote:
> From: Julia Lawall
>
> Initialize err before returning on failure, as done elsewhere in the
> function.
>
> Signed-off-by: Julia Lawall
>
> ---
> sound/pci/ctxfi/ctatc.c |4 +++-
> 1 file changed, 3 insertions(+), 1
Hello,
On Thu, Nov 20, 2014 at 12:03:08PM +0200, Grygorii Strashko wrote:
> @@ -664,6 +759,7 @@ static int davinci_i2c_probe(struct platform_device *pdev)
> if (!of_property_read_u32(pdev->dev.of_node, "clock-frequency",
> ))
>
On Sun, Nov 23, 2014 at 11:49:02AM -0500, Chris Mason wrote:
> I've adding Ingo and Stanislaw to the cc. With
> 6e998916dfe327e785e7c2447959b2c1a3ea4930 reverted, I'm no longer crashing.
Ok, reverting here too, to confirm.
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my
On Sun, Nov 23, 2014 at 11:40 AM, Eric Dumazet wrote:
> From: Eric Dumazet
>
> rcu_dereference() should be used in sections protected by rcu_read_lock.
>
> For writers, holding some kind of mutex or lock,
> rcu_dereference_protected() is the way to go, adding explicit lockdep
> bits.
>
> In
On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote:
On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote:
It must be:
commit 6e998916dfe327e785e7c2447959b2c1a3ea4930
Author: Stanislaw Gruszka
Date: Wed Nov 12 16:58:44 2014 +0100
sched/cputime: Fix
On Wed, 19 Nov 2014, Konstantin Khlebnikov wrote:
> On Wed, Nov 19, 2014 at 12:41 PM, Julia Lawall wrote:
> >> +// Comments: There are false positives in crypto/ where they are
> >> actually freed.
> >
> > I didn't really understand this comment. I ran the semantic patch and got
> > around 10
From: Eric Dumazet
rcu_dereference() should be used in sections protected by rcu_read_lock.
For writers, holding some kind of mutex or lock,
rcu_dereference_protected() is the way to go, adding explicit lockdep
bits.
In __unbind(), although there is no mutex or lock held, we are about
to free
From: Markus Elfring
Date: Sun, 23 Nov 2014 17:33:08 +0100
The backlight_device_unregister() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus
On Sun, 2014-11-23 at 07:21 -0500, Pranith Kumar wrote:
> I am not sure we should be taking rcu_read_lock() there as I am not
> sure how long that critical section might last. Can someone who is
> more familiar with the code take a look?
>
> I will try to look for a solution too in the mean
On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov wrote:
On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote:
It must be:
commit 6e998916dfe327e785e7c2447959b2c1a3ea4930
Author: Stanislaw Gruszka
Date: Wed Nov 12 16:58:44 2014 +0100
sched/cputime: Fix
On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote:
> It must be:
>
> commit 6e998916dfe327e785e7c2447959b2c1a3ea4930
> Author: Stanislaw Gruszka
> Date: Wed Nov 12 16:58:44 2014 +0100
>
>sched/cputime: Fix clock_nanosleep()/clock_gettime() inconsistency
>
> I'll do two runs to
> I picked up the patch into my tree and made the above changes because
> they're pretty trivial. If Wolfram is okay with it then I can take the
> whole series through my tree. Otherwise I'll put the of_reconfig_* empty
> stubs into a separate branch that he and broonie can both pull.
With your
On Fri, Nov 21, 2014 at 01:46:31AM +, Grant Likely wrote:
> On Tue, 28 Oct 2014 22:36:02 +0200
> , Pantelis Antoniou
> wrote:
> > Dynamically inserting i2c client device nodes requires the use
> > of a single device registration method. Rework and export it.
> >
> > Signed-off-by: Pantelis
On Sun, Nov 23, 2014 at 11:11 AM, Borislav Petkov wrote:
On Sun, Nov 23, 2014 at 10:56:27AM -0500, Chris Mason wrote:
On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason wrote:
>Since it looks like a race between process exit and /proc, I'll
try to
>hammer on that for a better reproduction.
On Sun, Nov 23, 2014 at 10:56:27AM -0500, Chris Mason wrote:
> On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason wrote:
> >Since it looks like a race between process exit and /proc, I'll try to
> >hammer on that for a better reproduction. But, here's hoping that
> >someone has already seen this one:
Add a node for the Ethernet controller to Meson DTS file and
enable it on the Geniatech ATV1200 board.
Signed-off-by: Beniamino Galvani
---
arch/arm/boot/dts/meson.dtsi | 11 +++
arch/arm/boot/dts/meson6-atv1200.dts | 4
2 files changed, 15 insertions(+)
diff --git
From: Markus Elfring
Date: Sun, 23 Nov 2014 17:05:18 +0100
The platform_device_put() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
On Sun, 2014-11-23 at 16:45 +0100, Andreas Noever wrote:
> On Sun, Nov 23, 2014 at 4:20 PM, Joe Perches wrote:
> > On Sun, 2014-11-23 at 15:14 +0100, SF Markus Elfring wrote:
> >> >> 2. Are any additional prefixes appropriate so that further name space
> >> >>conflicts can be better avoided?
On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason wrote:
Since it looks like a race between process exit and /proc, I'll try to
hammer on that for a better reproduction. But, here's hoping that
someone has already seen this one:
It falls over in less than 5 minutes with a fork bomb going. I'll
On Sun, 23 Nov 2014, SF Markus Elfring wrote:
> >> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/char/tpm/xen-tpmfront.c?id=fc14f9c1272f62c3e8d01300f52467c0d9af50f9#n268
> >
> > I think static functions can be named whatever
> > the developer chooses.
>
> I
On Sun, Nov 23, 2014 at 4:20 PM, Joe Perches wrote:
> On Sun, 2014-11-23 at 15:14 +0100, SF Markus Elfring wrote:
>> >> 2. Are any additional prefixes appropriate so that further name space
>> >>conflicts can be better avoided?
>> >
>> > To avoid possible external naming conflicts, add tb_
>> https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/char/tpm/xen-tpmfront.c?id=fc14f9c1272f62c3e8d01300f52467c0d9af50f9#n268
>
> I think static functions can be named whatever
> the developer chooses.
I agree also that this implementation detail is correct in
From: Markus Elfring
Date: Sun, 23 Nov 2014 16:30:05 +0100
The framebuffer_release() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Finally I figured out how to set up the mailer not to spoil everything.
Add support for bluetooth MCI WB335 (AR9565) Wi-Fi+bt module.
This bluetooth module requires loading patch and sysconfig by ath3k driver.
Signed-off-by: Dmitry Tunin
---
diff --git a/drivers/bluetooth/ath3k.c
On Sun, 2014-11-23 at 15:14 +0100, SF Markus Elfring wrote:
> >> 2. Are any additional prefixes appropriate so that further name space
> >>conflicts can be better avoided?
> >
> > To avoid possible external naming conflicts, add tb_ prefix to
> > various ring_ structs and functions.
>
> Do
Hi Linus,
My for-linus branch:
git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus
Has a fix for a long standing deadlock that we've been trying to nail
down for a while. It ended up being a bad interaction with the fair
reader/writer locks and the order btrfs
This is an ACPI driver for Dell laptops which receive HW switch events.
It exports rfkill device dell-rbtn which provide correct hard rfkill state.
It does not provide support for setting soft rfkill state yet.
Signed-off-by: Pali Rohár
---
drivers/platform/x86/Kconfig | 13 +++
This patch exports notifier functions so other modules can receive HW switch
events. By default when some module register notifier, dell-rbtn driver
automatically remove rfkill interfaces from system (it is expected that other
module will use events for other rfkill interface). This behaviour can
Until now module dell-laptop registered rfkill device which used i8042 filter
function for receiving HW switch rfkill events (handling special keycode).
But for some dell laptops there is native ACPI driver dell-rbtn which can
receive rfkill events (without i8042 hacks). On some machines it can
This patch series add new acpi Dell Airplane Mode Switch driver (DELLABCE and
DELRBTN acpi devices). It provides radio HW switch events (together with current
state of radio devices) and export them via rfkill interface. These events are
also used in dell-laptop driver instead i8042 filter hook
Hi everyone,
I was running some tests on Saturday before my pull, and I'm now hitting
this consistently across two boxes. One box has plain linus git:
commit cb95413971d605b0d152d3ceecc47ba8991d66fb
Merge: ecde006 6bab4a8
Author: Linus Torvalds
Date: Sat Nov 22 14:33:11 2014 -0800
The other
From: Markus Elfring
Date: Sun, 23 Nov 2014 15:45:03 +0100
The mmp_unregister_path() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Hi Dmitry,
> Add support for bluetooth MCI WB335 (AR9565) Wi-Fi+bt module.
> This bluetooth module requires loading patch and sysconfig by ath3k driver.
>
> /sys/kernel/debug/usb/devices
>
> T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 20 Spd=12 MxCh= 0
> D: Ver= 1.10 Cls=e0(wlcon) Sub=01
This patch adds support for configuring keyboard backlight settings on supported
Dell laptops. It exports kernel leds interface and uses Dell SMBIOS tokens or
keyboard class interface.
With this patch it is possible to set:
* keyboard backlight level
* timeout after which will be backlight
On Friday 21 November 2014 23:09:40 Darren Hart wrote:
> On Sat, Nov 22, 2014 at 07:46:25PM +0100, Pali Rohár wrote:
> > > > 0 Completed successfully
> > > > -1 Completed with error
> > > > -2 Function not supported
> > > >
> > > > So we can return something other too (not always
> > > >
While checking which drivers were still abusing internal videobuf API
functions I came across these carma fpga misc drivers. These drivers
have absolutely nothing to do with videobuf or the media subsystem.
Drivers shouldn't use those low-level functions in the first place,
and in fact in the
From: Hans Verkuil
This driver abuses videobuf helper functions. This is a bad idea
because:
1) this driver is completely unrelated to media drivers
2) the videobuf API is deprecated and will be removed eventually
This patch replaces the videobuf functions with the normal DMA kernel
API.
From: Hans Verkuil
This driver abuses videobuf helper functions. This is a bad idea
because:
1) this driver is completely unrelated to media drivers
2) the videobuf API is deprecated and will be removed eventually
This patch replaces the videobuf functions with the normal DMA kernel
API.
From: Hans Verkuil
drivers/misc/carma/carma-fpga-program.c: In function 'fpga_program_dma':
drivers/misc/carma/carma-fpga-program.c:529:2: error: expected ';' before 'if'
if (ret) {
^
drivers/misc/carma/carma-fpga-program.c: In function 'fpga_read':
Entirely compile out splice translation unit when the system is configured
without splice family of syscalls (i.e. CONFIG_SYSCALL_SPLICE is undefined).
Exported fs/splice functions are transparently mocked out with static inlines.
Because userspace support for splice has already been removed by
REPO: https://github.com/smipi1/linux-tinification.git
BRANCH: tiny/config-syscall-splice
BACKGROUND: This patch-set forms part of the Linux Kernel Tinification effort (
https://tiny.wiki.kernel.org/).
GOAL: Support compiling out the splice family of syscalls (splice, vmsplice,
tee and
Many embedded systems will not need the splice-family syscalls (splice,
vmsplice, tee and sendfile). Omitting them saves space. This adds a new EXPERT
config option CONFIG_SYSCALL_SPLICE (default y) to support compiling them out.
The goal is to completely compile out fs/splice. To achieve this,
To implement splice support, fs/fuse makes use of nosteal_pipe_buf_ops. This
struct is exported by fs/splice. The goal of the larger patch set is to
completely compile out fs/splice, so uses of the exported struct need to be
compiled out along with fs/splice.
This patch therefore compiles out
To implement splice support, net/core makes use of nosteal_pipe_buf_ops. This
struct is exported by fs/splice. The goal of the larger patch set is to
completely compile out fs/splice, so uses of the exported struct need to be
compiled out along with fs/splice.
This patch therefore compiles out
kernel_write shares infrastructure with the read_write translation unit but not
with the splice translation unit. Grouping kernel_write with the read_write
translation unit is more logical. It also paves the way to compiling out the
splice group of syscalls for embedded systems that do not need
sendfile functionally forms part of the splice group of syscalls (splice,
vmsplice and tee). Grouping sendfile with splice paves the way to compiling out
the splice group of syscalls for embedded systems that do not need these.
add/remove: 0/0 grow/shrink: 7/2 up/down: 86/-61 (25)
function
From: Markus Elfring
Date: Sun, 23 Nov 2014 15:15:29 +0100
The backlight_device_unregister() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus
>> 2. Are any additional prefixes appropriate so that further name space
>>conflicts can be better avoided?
>
> To avoid possible external naming conflicts, add tb_ prefix to
> various ring_ structs and functions.
Do you imagine that any XEN software developers need also to reconsider
this
Hello,
pressing some keys on laptops could cause some side effects.
Example scenario 1:
Laptop has Fn key for enabling/disabling WIFI and when that key
is pressed BIOS is doing two things:
1) Switch hard rfkill state of WIFI
2) Report that Fn key was pressed to kernel
(either via i8042 bus
On 2014/11/23 18:36, Thomas Gleixner wrote:
> On Sun, 23 Nov 2014, Thomas Gleixner wrote:
>
>> On Fri, 21 Nov 2014, Jiang Liu wrote:
>>
>>> Originally irq_domain_free_irqs_common() is designed to be used by
>>> irqdomains with parent. But there are desires to reuse for parentless
>>> irqdomains
ACPI 5.0 introduces _DEP to designate device objects that OSPM should
assign a higher priority in start ordering due to future operation region
accesses.
On Asus T100TA, ACPI battery info are read from a I2C slave device via
I2C operation region. Before I2C operation region handler is installed,
> Normally, tests only hurt readability if they cannot be false or cannot be
> true.
> Making a choice apparent when there really is a choice would seem
> to aid understanding.
I agree also to such facts.
> Program analysis tools can also potentially exploit this information,
The published
23 нояб. 2014 г., в 7:43, Felipe Balbi написал(а):
> maybe there was a typo? I tested on v3.18-rc3 :-)
I do my tests on kernel from angstrom with almost all i2c-omap patches
backported from linux/master.
Then I rebased them to wrong (old) kernel version and posted to the list.
Angstrom
From: Julia Lawall
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret =
From: Julia Lawall
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret =
The complate semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
//
@ok exists@
identifier f,ret,i;
expression e;
constant c;
@@
// identify a function that returns a negative return value at least once.
f(...) {
... when any
(
return -c@i;
|
ret = -c@i;
... when
From: Julia Lawall
Return a negative error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret =
From: Julia Lawall
Propagate the returned error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when !=
From: Julia Lawall
Propagate the error code on failure.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret = 0
)
... when != ret = e1
Oops!!! These are ancient patches. I meant to send something else.
Sorry for the noise.
julia
On Sun, 23 Nov 2014, Julia Lawall wrote:
> These patches fix cases where the return code appears to be unintentially
> nonnegative.
>
> The complete semantic match that finds the problem is as
From: Markus Elfring
Date: Sun, 23 Nov 2014 14:07:22 +0100
The i2c_put_adapter() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
From: Julia Lawall
Initialize ret on the second call to imx_audmux_v2_configure_port so that
the subsequent test checks that result and not the previous one.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret <
From: Julia Lawall
Initialize err before returning on failure, as done elsewhere in the
function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when !=
From: Julia Lawall
In the first case, the second test of whether retval is negative is
redundant. It is dropped and the previous and subsequent tests are
combined.
In the second case, add an initialization of retval on failure of ioremap.
A simplified version of the semantic match that finds
From: Julia Lawall
Initialize ret before returning on failure, as done elsewhere in the
function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when !=
From: Julia Lawall
Initialize rc before returning on failure, as done elsewhere in the
function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when !=
From: Julia Lawall
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1
201 - 300 of 656 matches
Mail list logo
