[PATCH 1/1] video: fbdev-VIA: Deletion of an unnecessary check before the function call framebuffer_release

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 23 Nov 2014 16:30:05 +0100 The framebuffer_release() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

Re: thunderbolt: Deletion of unnecessary checks before the function call ring_free

2014-11-23 Thread SF Markus Elfring
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/char/tpm/xen-tpmfront.c?id=fc14f9c1272f62c3e8d01300f52467c0d9af50f9#n268 I think static functions can be named whatever the developer chooses. I agree also that this implementation detail is correct in

Re: thunderbolt: Deletion of unnecessary checks before the function call ring_free

2014-11-23 Thread Andreas Noever
On Sun, Nov 23, 2014 at 4:20 PM, Joe Perches j...@perches.com wrote: On Sun, 2014-11-23 at 15:14 +0100, SF Markus Elfring wrote: 2. Are any additional prefixes appropriate so that further name space conflicts can be better avoided? To avoid possible external naming conflicts, add tb_

Re: thunderbolt: Deletion of unnecessary checks before the function call ring_free

2014-11-23 Thread Julia Lawall
On Sun, 23 Nov 2014, SF Markus Elfring wrote: https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/char/tpm/xen-tpmfront.c?id=fc14f9c1272f62c3e8d01300f52467c0d9af50f9#n268 I think static functions can be named whatever the developer chooses. I agree also

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason c...@fb.com wrote: Since it looks like a race between process exit and /proc, I'll try to hammer on that for a better reproduction. But, here's hoping that someone has already seen this one: It falls over in less than 5 minutes with a fork bomb

Re: thunderbolt: Deletion of unnecessary checks before the function call ring_free

2014-11-23 Thread Joe Perches
On Sun, 2014-11-23 at 16:45 +0100, Andreas Noever wrote: On Sun, Nov 23, 2014 at 4:20 PM, Joe Perches j...@perches.com wrote: On Sun, 2014-11-23 at 15:14 +0100, SF Markus Elfring wrote: 2. Are any additional prefixes appropriate so that further name space conflicts can be better

[PATCH 1/1] video: uvesafb: Deletion of an unnecessary check before the function call platform_device_put

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 23 Nov 2014 17:05:18 +0100 The platform_device_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software.

[PATCH] ARM: dts: meson: enable Ethernet controller

2014-11-23 Thread Beniamino Galvani
Add a node for the Ethernet controller to Meson DTS file and enable it on the Geniatech ATV1200 board. Signed-off-by: Beniamino Galvani b.galv...@gmail.com --- arch/arm/boot/dts/meson.dtsi | 11 +++ arch/arm/boot/dts/meson6-atv1200.dts | 4 2 files changed, 15 insertions(+)

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Borislav Petkov
On Sun, Nov 23, 2014 at 10:56:27AM -0500, Chris Mason wrote: On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason c...@fb.com wrote: Since it looks like a race between process exit and /proc, I'll try to hammer on that for a better reproduction. But, here's hoping that someone has already seen this

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:11 AM, Borislav Petkov b...@alien8.de wrote: On Sun, Nov 23, 2014 at 10:56:27AM -0500, Chris Mason wrote: On Sun, Nov 23, 2014 at 10:02 AM, Chris Mason c...@fb.com wrote: Since it looks like a race between process exit and /proc, I'll try to hammer on that for

Re: [PATCH v8 5/8] of: i2c: Export single device registration method

2014-11-23 Thread Wolfram Sang
On Fri, Nov 21, 2014 at 01:46:31AM +, Grant Likely wrote: On Tue, 28 Oct 2014 22:36:02 +0200 , Pantelis Antoniou pantelis.anton...@konsulko.com wrote: Dynamically inserting i2c client device nodes requires the use of a single device registration method. Rework and export it.

Re: [PATCH v8 6/8] OF: i2c: Add OF notifier handler

2014-11-23 Thread Wolfram Sang
I picked up the patch into my tree and made the above changes because they're pretty trivial. If Wolfram is okay with it then I can take the whole series through my tree. Otherwise I'll put the of_reconfig_* empty stubs into a separate branch that he and broonie can both pull. With your fix

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Borislav Petkov
On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: It must be: commit 6e998916dfe327e785e7c2447959b2c1a3ea4930 Author: Stanislaw Gruszka sgrus...@redhat.com Date: Wed Nov 12 16:58:44 2014 +0100 sched/cputime: Fix clock_nanosleep()/clock_gettime() inconsistency I'll do

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov b...@alien8.de wrote: On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: It must be: commit 6e998916dfe327e785e7c2447959b2c1a3ea4930 Author: Stanislaw Gruszka sgrus...@redhat.com Date: Wed Nov 12 16:58:44 2014 +0100

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-23 Thread Eric Dumazet
On Sun, 2014-11-23 at 07:21 -0500, Pranith Kumar wrote: I am not sure we should be taking rcu_read_lock() there as I am not sure how long that critical section might last. Can someone who is more familiar with the code take a look? I will try to look for a solution too in the mean time. I

[PATCH ] drivers/md: use proper rcu accessor

2014-11-23 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com rcu_dereference() should be used in sections protected by rcu_read_lock. For writers, holding some kind of mutex or lock, rcu_dereference_protected() is the way to go, adding explicit lockdep bits. In __unbind(), although there is no mutex or lock held, we

[PATCH 1/1] backlight: lp8788: Deletion of an unnecessary check before the function call backlight_device_unregister

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 23 Nov 2014 17:33:08 +0100 The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle

Re: [PATCH 1/2 v2] scripts/coccinelle: catch freeing cryptographic structures via kfree

2014-11-23 Thread Julia Lawall
On Wed, 19 Nov 2014, Konstantin Khlebnikov wrote: On Wed, Nov 19, 2014 at 12:41 PM, Julia Lawall julia.law...@lip6.fr wrote: +// Comments: There are false positives in crypto/ where they are actually freed. I didn't really understand this comment. I ran the semantic patch and got

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov b...@alien8.de wrote: On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: It must be: commit 6e998916dfe327e785e7c2447959b2c1a3ea4930 Author: Stanislaw Gruszka sgrus...@redhat.com Date: Wed Nov 12 16:58:44 2014 +0100

Re: [PATCH ] drivers/md: use proper rcu accessor

2014-11-23 Thread Mike Snitzer
On Sun, Nov 23, 2014 at 11:40 AM, Eric Dumazet eric.duma...@gmail.com wrote: From: Eric Dumazet eduma...@google.com rcu_dereference() should be used in sections protected by rcu_read_lock. For writers, holding some kind of mutex or lock, rcu_dereference_protected() is the way to go, adding

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Borislav Petkov
On Sun, Nov 23, 2014 at 11:49:02AM -0500, Chris Mason wrote: I've adding Ingo and Stanislaw to the cc. With 6e998916dfe327e785e7c2447959b2c1a3ea4930 reverted, I'm no longer crashing. Ok, reverting here too, to confirm. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my

Re: [5/5] i2c: davinci: use ICPFUNC to toggle I2C as gpio for bus recovery

2014-11-23 Thread Uwe Kleine-König
Hello, On Thu, Nov 20, 2014 at 12:03:08PM +0200, Grygorii Strashko wrote: @@ -664,6 +759,7 @@ static int davinci_i2c_probe(struct platform_device *pdev) if (!of_property_read_u32(pdev-dev.of_node, clock-frequency, prop))

Re: [PATCH 6/9] sound/pci/ctxfi/ctatc.c: fix error return code

2014-11-23 Thread Sudip Mukherjee
On Sun, Nov 23, 2014 at 01:48:06PM +0100, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Initialize err before returning on failure, as done elsewhere in the function. snip Signed-off-by: Julia Lawall julia.law...@lip6.fr --- sound/pci/ctxfi/ctatc.c |4 +++- 1 file

Re: [PATCH v2 4/5] ARM: dts: add pinctrl support to Exynos5410

2014-11-23 Thread Andreas Färber
Am 22.11.2014 um 21:26 schrieb Andreas Färber: From: Hakjoo Kim ruppi@hardkernel.com Add the required pin configuration support to Exynos5410 using pinctrl interface. Signed-off-by: Hakjoo Kim ruppi@hardkernel.com [AF: Rebased, style changes] Signed-off-by: Andreas Färber

[PATCH v3 4/5] ARM: dts: add pinctrl support to Exynos5410

2014-11-23 Thread Andreas Färber
From: Hakjoo Kim ruppi@hardkernel.com Add the required pin configuration support to Exynos5410 using pinctrl interface. Signed-off-by: Hakjoo Kim ruppi@hardkernel.com [AF: Rebased, style changes] Signed-off-by: Andreas Färber afaer...@suse.de --- v2 - v3: * Added wake-up IRQ controller

Re: task_stat splat

2014-11-23 Thread Oleg Nesterov
On 11/23, Borislav Petkov wrote: where we end up with a zero PMD. RIP is corrupted too so we're somewhere off in the fields. PMD = 0 is fine I guess, addr == 0 is not mapped. Comment over thread_group_cputime() talks about dead tasks accounting This comment simply means that we also need to

Re: [PATCH] Drivers:staging:wlan-ng: Fixed line over 80 characters warning

2014-11-23 Thread Sudip Mukherjee
On Sun, Nov 23, 2014 at 03:26:54PM +0530, Lekshmi wrote: The following chaeckpatch warning was fixed: WARNING: line over 80 characters Signed-off-by: Lekshmi andnlnb...@gmail.com --- drivers/staging/wlan-ng/prism2fw.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [PATCH ] drivers/md: use proper rcu accessor

2014-11-23 Thread Eric Dumazet
On Sun, 2014-11-23 at 11:53 -0500, Mike Snitzer wrote: On Sun, Nov 23, 2014 at 11:40 AM, Eric Dumazet eric.duma...@gmail.com wrote: From: Eric Dumazet eduma...@google.com rcu_dereference() should be used in sections protected by rcu_read_lock. For writers, holding some kind of mutex or

[PATCH v2] drivers/md: use proper rcu accessor

2014-11-23 Thread Eric Dumazet
From: Eric Dumazet eduma...@google.com rcu_dereference() should be used in sections protected by rcu_read_lock. For writers, holding some kind of mutex or lock, rcu_dereference_protected() is the way to go, adding explicit lockdep bits. In __unbind(), we are the last user of this mapped device,

Re: [PATCH] Drivers:staging:wlan-ng: Fixed line over 80 characters warning

2014-11-23 Thread Greg KH
On Sun, Nov 23, 2014 at 03:26:54PM +0530, Lekshmi wrote: The following chaeckpatch warning was fixed: WARNING: line over 80 characters Signed-off-by: Lekshmi andnlnb...@gmail.com I need a full and real name here in order to be able to accept any patch. -- To unsubscribe from this list: send

Re: task_stat splat

2014-11-23 Thread Borislav Petkov
On Sun, Nov 23, 2014 at 06:22:56PM +0100, Oleg Nesterov wrote: Could you identify somehow the line which matches task_sched_runtime+0x99 ? Probably do_task_delta_exec()... See http://marc.info/?l=linux-kernelm=141675498417759w=2 Chris triggers the same splat and reverting 6e998916dfe3

[GIT PULL] percpu fixes for v3.18-rc5

2014-11-23 Thread Tejun Heo
Hello, Linus. This pull request contains one patch to fix a race condition which can lead to percpu_ref using a percpu pointer which is corrupted with a set DEAD bit. The bug was introduced while separating out the ATOMIC mode flag from the DEAD flag. The fix is pretty straight forward. I just

Re: [PATCH percpu/for-3.18-fixes] percpu-ref: fix DEAD flag contamination of percpu pointer

2014-11-23 Thread Tejun Heo
On Sat, Nov 22, 2014 at 09:22:42AM -0500, Tejun Heo wrote: While decoupling ATOMIC and DEAD flags, f47ad4578461 (percpu_ref: decouple switching to percpu mode and reinit) updated __ref_is_percpu() so that it only tests ATOMIC flag to determine whether the ref is in percpu mode or not; however,

Re: task_stat splat

2014-11-23 Thread Oleg Nesterov
On 11/23, Oleg Nesterov wrote: On 11/23, Borislav Petkov wrote: where we end up with a zero PMD. RIP is corrupted too so we're somewhere off in the fields. PMD = 0 is fine I guess, addr == 0 is not mapped. Comment over thread_group_cputime() talks about dead tasks accounting This

[PATCH v4 0/3] irqfd support for arm/arm64

2014-11-23 Thread Eric Auger
This patch series enables irqfd on arm and arm64. Irqfd framework enables to inject a virtual IRQ into a guest upon an eventfd trigger. User-side uses KVM_IRQFD VM ioctl to provide KVM with a kvm_irqfd struct that associates a VM, an eventfd, a virtual IRQ number (aka. the gsi). When an actor

[PATCH v4 3/3] KVM: arm64: add irqfd support

2014-11-23 Thread Eric Auger
From: Joel Schopp joel.sch...@amd.com This patch enables irqfd for arm64. Signed-off-by: Joel Schopp joel.sch...@amd.com Signed-off-by: Eric Auger eric.au...@linaro.org --- [Eric Auger] - originates from Joel's [RFC PATCH] arm64: KVM: add irqfd support

[PATCH v4 2/3] KVM: arm: add irqfd support

2014-11-23 Thread Eric Auger
This patch enables irqfd on arm. Both irqfd and resamplefd are supported. Injection is implemented in vgic.c without routing. This patch enables CONFIG_HAVE_KVM_EVENTFD and CONFIG_HAVE_KVM_IRQFD. KVM_CAP_IRQFD is now advertised. KVM_CAP_IRQFD_RESAMPLE capability automatically is advertised as

[PATCH v4 1/3] KVM: arm/arm64: unset CONFIG_HAVE_KVM_IRQCHIP

2014-11-23 Thread Eric Auger
CONFIG_HAVE_KVM_IRQCHIP is needed to support IRQ routing (along with irq_comm.c and irqchip.c usage). This is not the case for arm/arm64 currently. This patch unsets the flag for both arm and arm64. Signed-off-by: Eric Auger eric.au...@linaro.org --- arch/arm/kvm/Kconfig | 2 --

[RFC 2/4] KVM: arm: vgic: add forwarded irq rbtree lock

2014-11-23 Thread Eric Auger
Add a lock related to the rb tree manipulation. The rb tree can be searched in one thread (irqfd handler for instance) and map/unmap may happen in another. Signed-off-by: Eric Auger eric.au...@linaro.org --- v2 - v3: re-arrange lock sequence in vgic_map_phys_irq --- include/kvm/arm_vgic.h | 1

[RFC 0/4] vgic additions for forwarded irq

2014-11-23 Thread Eric Auger
This series applies on top of ARM: Forwarding physical interrupts to a guest VM (http://lwn.net/Articles/603514/) series. It brings some extra functionalities that were requested to be able to inject virtual level sensitive IRQs triggered from VFIO/irqfd. It adds: - a specific handling of

[RFC 4/4] KVM: arm: vgic: handle irqfd forwarded IRQ injection before vgic readiness

2014-11-23 Thread Eric Auger
This patch handles the case where irqfd attempts to inject a forwarded IRQ before the vgic is ready to accept it. We cannot simply return pretending nothing happened since the IRQ will never be deactivated by the guest. Indeed, the corresponding virtual IRQ cannot be injected into the guest and

[RFC 1/4] KVM: arm: vgic: fix state machine for forwarded IRQ

2014-11-23 Thread Eric Auger
Fix multiple injection of level sensitive forwarded IRQs. With current code, the second injection fails since the state bitmaps are not reset (process_maintenance is not called anymore). New implementation follows those principles: - A forwarded IRQ only can be sampled when it is pending - when

[RFC 3/4] KVM: arm: vgic: cleanup forwarded IRQs on destroy

2014-11-23 Thread Eric Auger
When the VGIC is destroyed it must take care of - restoring the forwarded IRQs in non forwarded state, - deactivating the IRQ in case the guest left without doing it - cleaning nodes of the phys_map rbtree Signed-off-by: Eric Auger eric.au...@linaro.org --- virt/kvm/arm/vgic.c | 36

Re: task_stat splat

2014-11-23 Thread Oleg Nesterov
On 11/23, Oleg Nesterov wrote: On 11/23, Oleg Nesterov wrote: On 11/23, Borislav Petkov wrote: where we end up with a zero PMD. RIP is corrupted too so we're somewhere off in the fields. PMD = 0 is fine I guess, addr == 0 is not mapped. Comment over thread_group_cputime()

Re: task_stat splat

2014-11-23 Thread Oleg Nesterov
Damn, sorry for noise ;) On 11/23, Oleg Nesterov wrote: On 11/23, Oleg Nesterov wrote: On 11/23, Oleg Nesterov wrote: On 11/23, Borislav Petkov wrote: where we end up with a zero PMD. RIP is corrupted too so we're somewhere off in the fields. PMD = 0 is fine I guess,

Re: [PATCH] ipc,sem block sem_lock on sma-lock during sma initialization

2014-11-23 Thread Manfred Spraul
Hi Rik, On 11/21/2014 08:52 PM, Rik van Riel wrote: When manipulating just one semaphore with semop, sem_lock only takes that single semaphore's lock. This creates a problem during initialization of the semaphore array, when the data structures used by sem_lock have not been set up yet. The

Re: task_stat splat

2014-11-23 Thread Oleg Nesterov
On 11/23, Borislav Petkov wrote: On Sun, Nov 23, 2014 at 06:22:56PM +0100, Oleg Nesterov wrote: Could you identify somehow the line which matches task_sched_runtime+0x99 ? Probably do_task_delta_exec()... See http://marc.info/?l=linux-kernelm=141675498417759w=2 Chris triggers the same

[PATCH 0/2] staging: android: ion: Deletion of a few unnecessary checks

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 23 Nov 2014 19:13:56 +0100 Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Deletion of unnecessary checks before two function calls One function call

[GIT PULL] ARM: SoC fixes for -rc6

2014-11-23 Thread Olof Johansson
Hi Linus, The following changes since commit fc14f9c1272f62c3e8d01300f52467c0d9af50f9: Linux 3.18-rc5 (2014-11-16 16:36:20 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git tags/armsoc-for-rc6 for you to fetch changes up to

[PATCH v3 6/8] KVM: kvm-vfio: wrapper to VFIO external API device helpers

2014-11-23 Thread Eric Auger
Provide wrapper functions that allow KVM-VFIO device code to interact with a vfio device: - kvm_vfio_device_get_external_user gets a handle to a struct vfio_device from the vfio device file descriptor and increments its reference counter, - kvm_vfio_device_put_external_user decrements the

[PATCH v3 8/8] KVM: arm: kvm-vfio: forwarding control

2014-11-23 Thread Eric Auger
This patch sets __KVM_HAVE_ARCH_KVM_VFIO_FORWARD and implements kvm_arch_vfio_set_forward for ARM. As a result the KVM-VFIO device now allows to forward/unforward a VFIO device IRQ on ARM. kvm_arch_vfio_set_forward programs both genirq and the VGIC to control where the physical IRQ deactivation

[PATCH v3 2/8] KVM: arm64: Enable the KVM-VFIO device

2014-11-23 Thread Eric Auger
Used by KVM-enabled VFIO-based device passthrough support in QEMU. Signed-off-by: Joel Schopp joel.sch...@amd.com Signed-off-by: Eric Auger eric.au...@linaro.org --- Extracted from [RFC PATCH] arm64: KVM: add irqfd support http://www.spinics.net/lists/kvm-arm/msg10798.html ---

[PATCH v3 7/8] KVM: kvm-vfio: generic forwarding control

2014-11-23 Thread Eric Auger
This patch introduces a new KVM_DEV_VFIO_DEVICE group. This is a new control channel which enables KVM to cooperate with viable VFIO devices. Functions are introduced to check the validity of a VFIO device file descriptor, increment/decrement the ref counter of the VFIO device. The patch

[PATCH v3 5/8] VFIO: External user API device helpers

2014-11-23 Thread Eric Auger
The VFIO external user API is enriched with 3 new functions that allows a kernel user external to VFIO to retrieve some information from a VFIO device. - vfio_device_get_external_user enables to get a vfio device from its fd and increments its reference counter - vfio_device_put_external_user

Re: task_stat splat

2014-11-23 Thread Borislav Petkov
On Sun, Nov 23, 2014 at 07:21:08PM +0100, Oleg Nesterov wrote: Perhaps this is migration thread? stop_sched_class doesn't have -update_curr. Yes, I think this can explain the problem, but could you try to cat /proc/pid-of-migration-thread/stat on your machine? This won't trigger the

[PATCH v3 4/8] KVM: kvm-vfio: User API for IRQ forwarding

2014-11-23 Thread Eric Auger
This patch adds and document a new KVM_DEV_VFIO_DEVICE group and 2 device attributes: KVM_DEV_VFIO_DEVICE_FORWARD_IRQ, KVM_DEV_VFIO_DEVICE_UNFORWARD_IRQ. The purpose is to be able to set a VFIO device IRQ as forwarded or not forwarded. the command takes as argument a handle to a new struct named

Re: net: Hyper-V: Deletion of an unnecessary check before the function call vfree

2014-11-23 Thread David Miller
From: SF Markus Elfring elfr...@users.sourceforge.net Date: Sun, 23 Nov 2014 08:18:31 +0100 Whereas if you learn how to base your changes cleanly on the correct base now, all of your future submissions will go quickly and smoothly into my tree. My reluctance to work with more Linux

[PATCH 1/2] staging: android: ion: Deletion of unnecessary checks before two function calls

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 23 Nov 2014 18:48:15 +0100 The functions ion_heap_destroy() and vfree() perform also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by:

[PATCH v3 3/8] VFIO: platform: forwarded state tested when selecting IRQ handler

2014-11-23 Thread Eric Auger
In case the IRQ is forwarded, the VFIO platform IRQ handler does not need to disable the IRQ anymore. When setting the IRQ handler we now also test the forwarded state. In case the IRQ is forwarded we select the edge handler (no automaske). Signed-off-by: Eric Auger eric.au...@linaro.org ---

[PATCH v3 1/8] KVM: arm: Enable the KVM-VFIO device

2014-11-23 Thread Eric Auger
From: Kim Phillips kim.phill...@linaro.org Used by KVM-enabled VFIO-based device passthrough support in QEMU. Signed-off-by: Kim Phillips kim.phill...@linaro.org --- arch/arm/kvm/Kconfig | 1 + arch/arm/kvm/Makefile | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v3 0/8] KVM-VFIO IRQ forward control

2014-11-23 Thread Eric Auger
This series proposes an integration of ARM: Forwarding physical interrupts to a guest VM (http://lwn.net/Articles/603514/) in KVM. It enables to transform a VFIO platform driver IRQ into a forwarded IRQ. When a physical IRQ is forwarded (to a guest), the host does not deactivates this latter.

Re: [PATCH net-net 0/4] Increase the limit of tuntap queues

2014-11-23 Thread David Miller
From: Michael S. Tsirkin m...@redhat.com Date: Sun, 23 Nov 2014 12:46:23 +0200 At the moment attaching/detaching queues is an unpriveledged operation. Shouldn't we worry that an application can cause large allocations, and provide a way to limit these? David, could you comment on this

[PATCH 2/2] staging: android: ion: One function call less in ion_buffer_create() after error detection

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 23 Nov 2014 19:12:29 +0100 The jump label err1 was used by the ion_buffer_create() function in case of a memory allocation failure just to pass a null pointer to a vfree() function call by a data structure element. This implementation

[PATCH 1/2] staging: lustre: lnet: lnet: do not initialise statics to 0 or NULL

2014-11-23 Thread Balavasu kuppusammyprathaban
This patch fixes the checkpatch.pl issue Error: do not initialise statics to 0 or NULL Signed-off-by: Balavasu kp.balav...@gmail.com --- drivers/staging/lustre/lnet/lnet/router.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 0/6] kernel tinification: optionally compile out splice family of syscalls (splice, vmsplice, tee and sendfile)

2014-11-23 Thread David Miller
Truly removing sendfile/sendpage means that you can't even compile NFS into the tree. I cannot take this patch series seriously, sorry. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 2/2] staging: lustre: lnet: lnet: trailing statements should be on next line

2014-11-23 Thread Balavasu
This patch fixes the checkpatch.pl issue Error: trailing statements should be on next line Signed-off-by: Balavasu kp.balav...@gmail.com --- drivers/staging/lustre/lnet/lnet/router.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 2/3] i2c: slave-eeprom: add eeprom simulator driver

2014-11-23 Thread Uwe Kleine-König
Hallo Wolfram, On Sat, Nov 22, 2014 at 07:14:06PM +0100, Wolfram Sang wrote: + case I2C_SLAVE_REQ_READ_END: + eeprom-buffer_idx++; You don't check here for buffer_idx = ARRAY_SIZE(buffer)? Ditto in the I2C_SLAVE_REQ_WRITE_END case. I just noticed that

Re: [PATCH 1/2] staging: lustre: lnet: lnet: do not initialise statics to 0 or NULL

2014-11-23 Thread Greg KH
On Mon, Nov 24, 2014 at 12:15:21AM +0530, Balavasu kuppusammyprathaban wrote: This patch fixes the checkpatch.pl issue Error: do not initialise statics to 0 or NULL Signed-off-by: Balavasu kp.balav...@gmail.com You seem to have ignored everything I said in my last response to your previous

Re: [PATCH] ARM: dts: meson: enable Ethernet controller

2014-11-23 Thread Carlo Caione
On Sun, Nov 23, 2014 at 5:08 PM, Beniamino Galvani b.galv...@gmail.com wrote: Add a node for the Ethernet controller to Meson DTS file and enable it on the Geniatech ATV1200 board. Signed-off-by: Beniamino Galvani b.galv...@gmail.com --- arch/arm/boot/dts/meson.dtsi | 11 +++

Re: thunderbolt: Deletion of unnecessary checks before the function call ring_free

2014-11-23 Thread SF Markus Elfring
Why not just make the static source code analysis aware of the problem? This is also possible, of course. You can treat static functions differently that non-static ones. I have added this detail to my ideas around the next fine-tuning for the published semantic patch approach. There is

Hierarchical irqdomains - Status update

2014-11-23 Thread Thomas Gleixner
Folks, I've rebased the hierarchical irqdomain code on top of Bjorns msi_controller rework. Changes versus the previous version: - Bjorns new pci/mci branch. See also: http://lkml.kernel.org/r/20141121172018.ga6...@google.com Thanks Bjorn for fixing that just before your

Re: [RFC] proc interface to show file page cache usage details

2014-11-23 Thread Vladimir Shebordaev
On Sun, 2014-11-23 at 14:51 +0400, Vladimir Shebordaev wrote: Hi, I would like to suggest an interface to list inodes that currently occupy page cache in human readable form. A piece of code below creates a dedicated proc entry, namely, /proc/kpagecache. Upon read request it traverses all

Re: thunderbolt: Deletion of unnecessary checks before the function call ring_free

2014-11-23 Thread Joe Perches
On Sun, 2014-11-23 at 20:03 +0100, SF Markus Elfring wrote: Why not just make the static source code analysis aware of the problem? This is also possible, of course. You can treat static functions differently that non-static ones. I have added this detail to my ideas around the next

Re: [PATCH 6/9] sound/pci/ctxfi/ctatc.c: fix error return code

2014-11-23 Thread Julia Lawall
On Sun, 23 Nov 2014, Sudip Mukherjee wrote: On Sun, Nov 23, 2014 at 01:48:06PM +0100, Julia Lawall wrote: From: Julia Lawall julia.law...@lip6.fr Initialize err before returning on failure, as done elsewhere in the function. snip Signed-off-by: Julia Lawall julia.law...@lip6.fr

Re: [PATCH ] drivers/md: use proper rcu accessor

2014-11-23 Thread Mike Snitzer
On Sun, Nov 23 2014 at 12:31pm -0500, Eric Dumazet eric.duma...@gmail.com wrote: On Sun, 2014-11-23 at 11:53 -0500, Mike Snitzer wrote: On Sun, Nov 23, 2014 at 11:40 AM, Eric Dumazet eric.duma...@gmail.com wrote: From: Eric Dumazet eduma...@google.com rcu_dereference() should be

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-23 Thread Matt Fleming
On Fri, 21 Nov, at 03:19:52PM, Thomas Gleixner wrote: + barrier(); + cqe_genable = true; What's the exact point of that barrier? Yes, this definitely needs documenting. Vikas? + +/* + * Tests if only contiguous bits are set. + */ + +static inline bool

Re: [PATCH]: cross-compiling x86_64 kernel on i386 user-space fails

2014-11-23 Thread Thomas Gleixner
On Sat, 22 Nov 2014, Borislav Petkov wrote: On Sat, Nov 22, 2014 at 09:51:10AM +, Chris Clayton wrote: Hi, Yeah, next time make sure you actually CC people :-) I've added them to CC now. Commit e6023367d779060fddc9a52d1f474085b2b36298 broke building an x86_64 kernel in an

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-23 Thread Thomas Gleixner
On Sun, 23 Nov 2014, Matt Fleming wrote: Something like this? first_bit = find_next_bit(map, nr_bits, -1); zero_bit = find_next_zero_bit(map, nr_bits, first_bit); if (find_next_bit(map, nr_bits, zero_bit) nr_bits) return -EINVAL; /* non-contiguous bits */

Re: [PATCH 4/6] solos-pci: fix error return code

2014-11-23 Thread David Miller
From: Julia Lawall julia.law...@lip6.fr Date: Sat, 22 Nov 2014 15:39:17 +0100 From: Julia Lawall julia.law...@lip6.fr Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) ...

Re: [PATCH 0/6] kernel tinification: optionally compile out splice family of syscalls (splice, vmsplice, tee and sendfile)

2014-11-23 Thread Josh Triplett
On Sun, Nov 23, 2014 at 01:46:23PM -0500, David Miller wrote: Truly removing sendfile/sendpage means that you can't even compile NFS into the tree. If you mean the in-kernel nfsd (CONFIG_NFSD), that already has a large stack of select and depends on, both directly and indirectly; adding a

Re: [PATCH]: cross-compiling x86_64 kernel on i386 user-space fails

2014-11-23 Thread Borislav Petkov
On Sun, Nov 23, 2014 at 08:27:24PM +0100, Thomas Gleixner wrote: While that works, this wants to be: +RUN_SIZE = $(shell $(OBJDUMP) -h vmlinux | \ Ah, true: $ git grep OBJDUMP Makefile Makefile:363:OBJDUMP= $(CROSS_COMPILE)objdump Makefile:420:export CPP AR NM STRIP OBJCOPY

Re: [PATCH] x86: Intel Cache Allocation Technology support

2014-11-23 Thread Thomas Gleixner
On Fri, 21 Nov 2014, Vikas Shivappa wrote: On Fri, 21 Nov 2014, Thomas Gleixner wrote: On Wed, 19 Nov 2014, Vikas Shivappa wrote: + rdmsr(IA32_PQR_ASSOC, l, h); Why on earth do we want to read an MSR on every context switch? What's wrong with having DEFINE_PER_CPU(u64,

Re: [PATCH 1/3] PCI/MSI: Initial hook for archs to declare multivector MSI support

2014-11-23 Thread Thomas Gleixner
On Fri, 21 Nov 2014, Alex Williamson wrote: For the most part multivector MSI is not supported and drivers and hardware wanting multiple vectors opt for MSI-X instead. It seems though that having the ability to query the arch/platform code to determine whether allocating multiple MSI vectors

Re: [PATCH 2/3] i2c: slave-eeprom: add eeprom simulator driver

2014-11-23 Thread Uwe Kleine-König
Hello Wolfram, On Sat, Nov 22, 2014 at 07:26:30PM +0100, Wolfram Sang wrote: this mail is thematically more a reply to patch 1 and maybe just serves my understanding of the slave support. Sure. This shows how badly needed the documentation is :) ... + break; + + case

Re: [PATCH 1/1] scripts: add a graph generator based on checkpatch reports

2014-11-23 Thread Joe Perches
On Sat, 2014-11-22 at 21:56 +0100, Fabian Frederick wrote: This script generates a graph based on errors/warnings/checks detected by checkpatch -f recursively on each files of a directory. Results are grouped by subfolders and pushed in gnuplot datasets. Why is this useful? Ingo's badly named

Re: [PATCH 0/6] kernel tinification: optionally compile out splice family of syscalls (splice, vmsplice, tee and sendfile)

2014-11-23 Thread Pieter Smith
On Sun, Nov 23, 2014 at 11:43:26AM -0800, Josh Triplett wrote: On Sun, Nov 23, 2014 at 01:46:23PM -0500, David Miller wrote: Truly removing sendfile/sendpage means that you can't even compile NFS into the tree. If you mean the in-kernel nfsd (CONFIG_NFSD), that already has a large stack

Re: [PATCH net-net 0/4] Increase the limit of tuntap queues

2014-11-23 Thread Michael S. Tsirkin
On Sun, Nov 23, 2014 at 01:43:23PM -0500, David Miller wrote: From: Michael S. Tsirkin m...@redhat.com Date: Sun, 23 Nov 2014 12:46:23 +0200 At the moment attaching/detaching queues is an unpriveledged operation. Shouldn't we worry that an application can cause large allocations, and

Re: [2/5] i2c: davinci: query STP always when NACK is received

2014-11-23 Thread Uwe Kleine-König
Hello Grygorii, On Fri, Nov 21, 2014 at 05:33:37PM +0200, Grygorii Strashko wrote: On 11/21/2014 03:10 PM, Uwe Kleine-König wrote: On Fri, Nov 21, 2014 at 02:48:57PM +0200, Grygorii Strashko wrote: On 11/21/2014 12:19 AM, Uwe Kleine-König wrote: diff --git

Re: [4/5] i2c: davinci: use bus recovery infrastructure

2014-11-23 Thread Uwe Kleine-König
Hello Grygorii, On Fri, Nov 21, 2014 at 09:33:22PM +0200, Grygorii Strashko wrote: On 11/21/2014 09:07 PM, Uwe Kleine-König wrote: On Thu, Nov 20, 2014 at 12:03:07PM +0200, Grygorii Strashko wrote: Just another general comment about the driver that doesn't influence the correctness of this

[PATCH] staging: lustre: Fix sparse warnings for lnet/lnet/router.c

2014-11-23 Thread Giedrius Statkevicius
Fix the following sparse errors: drivers/staging/lustre/lnet/lnet/router.c:756:1: warning: symbol 'lnet_wait_known_routerstate' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/router.c:788:1: warning: symbol 'lnet_update_ni_status_locked' was not declared. Should it be

Re: [PATCH v3] x86/mce: Try printing all machine check banks known before panic

2014-11-23 Thread Borislav Petkov
On Fri, Nov 21, 2014 at 09:59:49PM +, Luck, Tony wrote: Oh, cpu errata. So this would mean that we can't even rely on the contents of the MCA banks, can we? In any case, is any of the information in the MCA banks in such cases even usable then? Because if not, we're definitely

Re: [PATCH] ipc,sem block sem_lock on sma-lock during sma initialization

2014-11-23 Thread Rik van Riel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/23/2014 01:23 PM, Manfred Spraul wrote: Hi Rik, On 11/21/2014 08:52 PM, Rik van Riel wrote: When manipulating just one semaphore with semop, sem_lock only takes that single semaphore's lock. This creates a problem during initialization of

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Thomas Gleixner
On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov b...@alien8.de wrote: On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: It must be: commit 6e998916dfe327e785e7c2447959b2c1a3ea4930 Author: Stanislaw Gruszka sgrus...@redhat.com

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 4:05 PM, Thomas Gleixner t...@linutronix.de wrote: On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov b...@alien8.de wrote: On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason wrote: It must be: commit

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 4:11 PM, Chris Mason c...@fb.com wrote: On Sun, Nov 23, 2014 at 4:05 PM, Thomas Gleixner t...@linutronix.de wrote: On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov b...@alien8.de wrote: On Sun, Nov 23, 2014 at 11:16:51AM

Re: [PATCH] ipc,sem block sem_lock on sma-lock during sma initialization

2014-11-23 Thread Davidlohr Bueso
On Sun, 2014-11-23 at 16:03 -0500, Rik van Riel wrote: On 11/23/2014 01:23 PM, Manfred Spraul wrote: Hi Rik, On 11/21/2014 08:52 PM, Rik van Riel wrote: When manipulating just one semaphore with semop, sem_lock only takes that single semaphore's lock. This creates a problem during

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Thomas Gleixner
On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 4:05 PM, Thomas Gleixner t...@linutronix.de wrote: On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov b...@alien8.de wrote: On Sun, Nov 23, 2014 at 11:16:51AM -0500, Chris Mason

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Borislav Petkov
On Sun, Nov 23, 2014 at 04:29:53PM -0500, Chris Mason wrote: 11 minutes later and it's still alive. I'll keep an eye on it and yell if it falls over. Ditto. Box here suspends and resumes fine even while the fork bomb is running. I'll watch it the next days just in case though.

Re: [PATCH v4] clocksource: arch_timer: Allow the device tree to specify uninitialized timer registers

2014-11-23 Thread Daniel Lezcano
On 11/20/2014 12:01 AM, Doug Anderson wrote: Daniel, On Wed, Oct 8, 2014 at 12:33 AM, Sonny Rao sonny...@chromium.org wrote: From: Doug Anderson diand...@chromium.org Some 32-bit (ARMv7) systems are architected like this: * The firmware doesn't know and doesn't care about hypervisor mode and

Re: New crashes walking proc with Saturday's git

2014-11-23 Thread Chris Mason
On Sun, Nov 23, 2014 at 4:38 PM, Thomas Gleixner t...@linutronix.de wrote: On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 4:05 PM, Thomas Gleixner t...@linutronix.de wrote: On Sun, 23 Nov 2014, Chris Mason wrote: On Sun, Nov 23, 2014 at 11:32 AM, Borislav Petkov

<    1   2   3   4   5   6   7   >