Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace

2014-12-31 Thread Sudip Mukherjee
On Wed, Dec 31, 2014 at 09:40:13PM -0800, Joe Perches wrote: > On Thu, 2015-01-01 at 10:17 +0530, Sudip Mukherjee wrote: > > On Wed, Dec 31, 2014 at 09:33:43PM +, Lorenzo Stoakes wrote: > > > This patch fixes warnings/errors raised by checkpatch.pl relating to > > > whitespace > > > in

Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace

2014-12-31 Thread Joe Perches
On Thu, 2015-01-01 at 10:17 +0530, Sudip Mukherjee wrote: > On Wed, Dec 31, 2014 at 09:33:43PM +, Lorenzo Stoakes wrote: > > This patch fixes warnings/errors raised by checkpatch.pl relating to > > whitespace > > in r8192U_dm.c and additionally it removes inconsistent whitespace > >

[PATCH] ovl: Prevent rw remount when it should be ro mount

2014-12-31 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write remount when the above situation. Signed-off-by: Seunghun Lee --- fs/overlayfs/super.c | 8 1 file

Re: [PATCH v2 3/4] staging: rtl8192u: remove redundant code

2014-12-31 Thread Sudip Mukherjee
On Thu, Jan 01, 2015 at 10:19:56AM +0530, Sudip Mukherjee wrote: > On Wed, Dec 31, 2014 at 09:10:42PM +, Lorenzo Stoakes wrote: > > This patch fixes warnings/errors raised by checkpatch.pl relating to > > redundant > > code in r8192U_dm.c. > > > > Signed-off-by: Lorenzo Stoakes > > --- > >

Re: [PATCH v2 3/4] staging: rtl8192u: remove redundant code

2014-12-31 Thread Sudip Mukherjee
On Wed, Dec 31, 2014 at 09:10:42PM +, Lorenzo Stoakes wrote: > This patch fixes warnings/errors raised by checkpatch.pl relating to redundant > code in r8192U_dm.c. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 176 > +-- >

Re: [PATCH v3 2/4] staging: rtl8192u: fix whitespace

2014-12-31 Thread Sudip Mukherjee
On Wed, Dec 31, 2014 at 09:33:43PM +, Lorenzo Stoakes wrote: > This patch fixes warnings/errors raised by checkpatch.pl relating to > whitespace > in r8192U_dm.c and additionally it removes inconsistent whitespace > throughout. > > Additionally some 0x00... padding has been added for

re

2014-12-31 Thread Alexandra Tobias
Hello! $1.5 million usd. registered by an Official of the United Nation. The Fund is a donation to you from the U.N through e-mails balloting in affiliation with commonwealth poverty eradication program. For your information the VAT and COD have been paid and the only money you will have to

Re: [PATCH V1 1/1] iio: Added Capella cm3232 ambient light sensor driver.

2014-12-31 Thread Jeremiah Mahler
Kevin, On Wed, Dec 31, 2014 at 04:10:30PM -0800, Kevin Tsai wrote: > CM3232 is an advanced ambient light sensor with I2C protocol interface. > The I2C slave address is internally hardwired as 0x10 (7-bit). Writing > to configure register is byte mode, but reading ALS register requests to > use

WIP alternative - was Re: [PATCH v3 14/20] selftests/size: add install target to enable test install

2014-12-31 Thread Tim Bird
On 12/24/2014 08:27 AM, Shuah Khan wrote: > Add a new make target to enable installing test. This target > installs test in the kselftest install location and add to the > kselftest script to run the test. Install target can be run > only from top level kernel source directory. > > Signed-off-by:

Re: [PATCH v3 0/6] support GMAC driver for RK3288

2014-12-31 Thread Heiko Stübner
Hi David, Am Mittwoch, 31. Dezember 2014, 19:15:38 schrieb David Miller: > From: Roger Chen > Date: Mon, 29 Dec 2014 17:42:32 +0800 > > > Roger Chen (6): > > patch1: add driver for Rockchip RK3288 SoCs integrated GMAC > > patch2: define clock ID used for GMAC > > patch3: modify CRU config

Re: [RFC 0/8] ARM64: Uprobe support added

2014-12-31 Thread Pratyush Anand
+Dave Sorry, I took all cc list from your kprobe patches and forgot to add you. :( Please review. On Wednesday 31 December 2014 08:51 PM, Pratyush Anand wrote: These patches have been prepared on top of ARM64 kprobe v3 patches [1] under review. Unit test for following has been done so far

Re: [PATCH v2 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver

2014-12-31 Thread Jonathan Richardson
Hi, Would anyone be able to look at this to help us move forward? Thanks. On 14-12-19 03:03 PM, Jonathan Richardson wrote: > On 14-12-19 02:26 PM, Joe Perches wrote: >> On Fri, 2014-12-19 at 14:17 -0800, Jonathan Richardson wrote: >>> Add initial version of the Broadcom touchscreen driver. >> >>

Re: [PATCH V8 00/33] loop: Issue O_DIRECT aio using bio_vec

2014-12-31 Thread Ming Lei
gt; aio: add aio_kernel_() interface >> fd/direct-io: introduce should_dirty for kernel aio >> block: loop: support to submit I/O via kernel aio based >> > > I tested with block-mq-v3 (for next-20141231) [1] and this looks promising > [2]. > > Maybe Ming can say wha

Re: [PATCH v3 0/5] block: loop: convert to blk-mq

2014-12-31 Thread Ming Lei
On Thu, Jan 1, 2015 at 8:18 AM, Sedat Dilek wrote: > On Thu, Jan 1, 2015 at 1:01 AM, Ming Lei wrote: >> Hi Sedat, >> >> On Thu, Jan 1, 2015 at 6:32 AM, Sedat Dilek wrote: >>> Forgot to CC LKML and linux-fsdevel. >>> >>> - Sedat - >> >>> >>> OK, I have installed fio (1.59-1) and libaio1

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread David Lang
On Wed, 31 Dec 2014, Arend van Spriel wrote: On 12/31/14 22:57, Linus Torvalds wrote: On Wed, Dec 31, 2014 at 1:44 PM, Theodore Ts'o wrote: Yeah, the confusing part is that "ip" tends to use "verb object" scheme, which is consistent with the Cisco IOS command set it was trying to emulate.

Re: [PATCH] qlcnic: Fix return value in qlcnic_probe()

2014-12-31 Thread David Miller
From: xuyongjia...@163.com Date: Tue, 30 Dec 2014 16:03:46 +0800 > From: Yongjian Xu > > If the check of adapter fails and goes into the 'else' branch, the > return value 'err' should not still be zero. > > Signed-off-by: Yongjian Xu Applied, thank you. -- To unsubscribe from this list: send

Re: [PATCH 2/8] myri10ge: fix error return code

2014-12-31 Thread David Miller
From: Julia Lawall Date: Mon, 29 Dec 2014 18:04:37 +0100 > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ... The patch also modifies the test of mgp->cmd to satisfy checkpatch. > >

Re: [PATCH 5/8] net: sun4i-emac: fix error return code

2014-12-31 Thread David Miller
From: Julia Lawall Date: Mon, 29 Dec 2014 18:04:40 +0100 > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall Applied. -- To unsubscribe from this

Re: [PATCH 1/8] net: Xilinx: fix error return code

2014-12-31 Thread David Miller
From: Julia Lawall Date: Mon, 29 Dec 2014 18:04:36 +0100 > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall Applied. -- To unsubscribe from this

Re: [PATCH 7/8] net: axienet: fix error return code

2014-12-31 Thread David Miller
From: Julia Lawall Date: Mon, 29 Dec 2014 18:04:42 +0100 > Return a negative error code on failure. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) ... > Signed-off-by: Julia Lawall Applied. -- To unsubscribe from this list:

[PATCH V1 1/1] iio: Added Capella cm3232 ambient light sensor driver.

2014-12-31 Thread Kevin Tsai
CM3232 is an advanced ambient light sensor with I2C protocol interface. The I2C slave address is internally hardwired as 0x10 (7-bit). Writing to configure register is byte mode, but reading ALS register requests to use word mode for 16-bit resolution. Signed-off-by: Kevin Tsai ---

Re: [PATCH v3 0/5] block: loop: convert to blk-mq

2014-12-31 Thread Sedat Dilek
On Thu, Jan 1, 2015 at 1:01 AM, Ming Lei wrote: > Hi Sedat, > > On Thu, Jan 1, 2015 at 6:32 AM, Sedat Dilek wrote: >> Forgot to CC LKML and linux-fsdevel. >> >> - Sedat - > >> >> OK, I have installed fio (1.59-1) and libaio1 (0.3.109-2ubuntu1) here. >> >> You say in [1]: >> >> "In the following

Re: [PATCH v3 0/6] support GMAC driver for RK3288

2014-12-31 Thread David Miller
From: Roger Chen Date: Mon, 29 Dec 2014 17:42:32 +0800 > Roger Chen (6): > patch1: add driver for Rockchip RK3288 SoCs integrated GMAC > patch2: define clock ID used for GMAC > patch3: modify CRU config for Rockchip RK3288 SoCs integrated GMAC > patch4: dts: rockchip: add gmac info for

Re: [GIT PULL] Audit fixes for 3.19 #2

2014-12-31 Thread Al Viro
On Wed, Dec 31, 2014 at 05:08:12PM -0500, Paul Moore wrote: > The getname/putname hacks work in the normal file case, but it falls apart > when you start talking about AF_UNIX socket files where the filename string > doesn't go through the getname/putname refcount tricks. In the past (no idea

Re: [PATCH v3 0/5] block: loop: convert to blk-mq

2014-12-31 Thread Ming Lei
Hi Sedat, On Thu, Jan 1, 2015 at 6:32 AM, Sedat Dilek wrote: > Forgot to CC LKML and linux-fsdevel. > > - Sedat - > > OK, I have installed fio (1.59-1) and libaio1 (0.3.109-2ubuntu1) here. > > You say in [1]: > > "In the following test: > - base: v3.19-rc2-2041231 > - loop over file in ext4

Re: [PATCH] net: ethernet: intel: i40e: i40e_fcoe.c: Remove unused function

2014-12-31 Thread Jeff Kirsher
On Wed, 2014-12-31 at 17:48 +0100, Rickard Strandqvist wrote: > Remove the function i40e_rx_is_fip() that is not used anywhere. > > This was partially found by using a static code analysis program > called cppcheck. > > Signed-off-by: Rickard Strandqvist > > --- >

Re: [GIT PULL] Audit fixes for 3.19 #2

2014-12-31 Thread Linus Torvalds
On Wed, Dec 31, 2014 at 2:08 PM, Paul Moore wrote: > > The getname/putname hacks work in the normal file case, but it falls apart > when you start talking about AF_UNIX socket files where the filename string > doesn't go through the getname/putname refcount tricks. In the past (no idea > how far

Re: [PATCH v2 2/2] doc: detailed documentation for completion

2014-12-31 Thread Jonathan Corbet
On Tue, 23 Dec 2014 20:41:40 +0100 Nicholas Mc Guire wrote: > diff --git a/Documentation/scheduler/completion-design.txt > b/Documentation/scheduler/completion-design.txt > new file mode 100644 > index 000..ec3e320 > --- /dev/null > +++ b/Documentation/scheduler/completion-design.txt > @@

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Arend van Spriel
On 12/31/14 22:57, Linus Torvalds wrote: On Wed, Dec 31, 2014 at 1:44 PM, Theodore Ts'o wrote: Yeah, the confusing part is that "ip" tends to use "verb object" scheme, which is consistent with the Cisco IOS command set it was trying to emulate. Side note: does anybody think that was really

Re: [PATCH V8 00/33] loop: Issue O_DIRECT aio using bio_vec

2014-12-31 Thread Sedat Dilek
lkml/2014/8/6/175 > > It looks like Ming is currently only pushing the first half of that > patchset. I don't know what his plans are for the last three patches: > > aio: add aio_kernel_() interface > fd/direct-io: introduce should_dirty for kernel aio > block: loop: support to

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Arend van Spriel
On 12/31/14 22:44, Theodore Ts'o wrote: On Wed, Dec 31, 2014 at 09:32:13PM +0100, Arend van Spriel wrote: Agree. I can't even recall using "ip" ever. iw help system does provide command specific help. The phy keyword is both a command and a selector key, which I realize is confusing to the

Re: [PATCH v2 1/2] doc: brief user documentation for completion

2014-12-31 Thread Jonathan Corbet
I'm finally getting around to looking at this. Honestly, I think we could add it now and make our documentation better, but I'm going to pick nits anyway in the hopes of one more round of improvement :) On Tue, 23 Dec 2014 20:41:39 +0100 Nicholas Mc Guire wrote: > diff --git

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Theodore Ts'o
On Wed, Dec 31, 2014 at 01:57:59PM -0800, Linus Torvalds wrote: > Side note: does anybody think that was really a good idea to begin > with? I mean, Cisco iOS is just _s_ universally loved, right? Well, at the time when it was "ip" came out, Cisco had a defacto monopoly on routing equipment,

Re: [GIT PULL] Audit fixes for 3.19 #2

2014-12-31 Thread Paul Moore
On Wednesday, December 31, 2014 01:23:14 PM Linus Torvalds wrote: > On Wed, Dec 31, 2014 at 12:33 PM, Paul Moore wrote: > > One audit patch to resolve a panic/oops when recording filenames in the > > audit log, see the mail archive link below. The fix isn't as nice as I > > would like, as it

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Linus Torvalds
On Wed, Dec 31, 2014 at 1:44 PM, Theodore Ts'o wrote: > > Yeah, the confusing part is that "ip" tends to use "verb object" > scheme, which is consistent with the Cisco IOS command set it was > trying to emulate. Side note: does anybody think that was really a good idea to begin with? I mean,

Re: [PATCH V8 00/33] loop: Issue O_DIRECT aio using bio_vec

2014-12-31 Thread Dave Kleikamp
On 12/31/2014 02:38 PM, Sedat Dilek wrote: > > What has happened to that aio_loop patchset? > Is it in Linux-next? > ( /me started to play with "block: loop: convert to blk-mq (v3)", so I > recalled this other improvement. ) It met with some harsh resistance, so I backed off on it. Then Al Viro

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Theodore Ts'o
On Wed, Dec 31, 2014 at 09:32:13PM +0100, Arend van Spriel wrote: > > Agree. I can't even recall using "ip" ever. iw help system does provide > command specific help. The phy keyword is both a command and a selector key, > which I realize is confusing to the user, eg. 'iw help info' does provide

Re: [PATCH v2] sound: pci: asihpi: hpifunc.c: Remove some unused functions

2014-12-31 Thread Eliot Blennerhassett
>>> More code changes may land in near future, so removing functions isn't >>> good at all at this moment. We need to wait until the all things are >>> settled down. IOW, forget about this for a while :) Hi Richard, Takashi, In principle I don't object to this patch (thanks for the work

[PATCH v3 2/4] staging: rtl8192u: fix whitespace

2014-12-31 Thread Lorenzo Stoakes
This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c and additionally it removes inconsistent whitespace throughout. Additionally some 0x00... padding has been added for alignment to the edca_setting_* variables. Signed-off-by: Lorenzo Stoakes ---

[PATCH] serial: omap_8250: Fix RTS handling, part B

2014-12-31 Thread Peter Hurley
Because the OMAP3 UART ignores MCR[1] (RTS) in autoRTS mode, autoRTS mode must not be enabled unless RTS is set (or port->mctrl & TIOCM_RTS, which is equivalent). Fixes premature raising of RTS in omap_8250_set_termios() -- RTS was raised even before UART mode was selected. Fixes raise of RTS

Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace

2014-12-31 Thread Lorenzo Stoakes
On 31 December 2014 at 21:20, Joe Perches wrote: > It'd be nicer to use the same form and indentation > for both entries. > > Probably be nicer to use: > > static u32 edca_setting_DL[HT_IOT_PEER_MAX] = { > 0x5e4322, 0x5e4322, 0x5e4322, 0x604322, 0x00a44f, 0x5ea44f > }; > static u32

Re: [GIT PULL] Audit fixes for 3.19 #2

2014-12-31 Thread Linus Torvalds
On Wed, Dec 31, 2014 at 12:33 PM, Paul Moore wrote: > > One audit patch to resolve a panic/oops when recording filenames in the audit > log, see the mail archive link below. The fix isn't as nice as I would like, > as it involves an allocate/copy of the filename, but it solves the problem and >

Re: [PATCH v2 2/4] staging: rtl8192u: fix whitespace

2014-12-31 Thread Joe Perches
On Wed, 2014-12-31 at 21:10 +, Lorenzo Stoakes wrote: > This patch fixes warnings/errors raised by checkpatch.pl relating to > whitespace > in r8192U_dm.c and additionally it removes inconsistent whitespace throughout. [] > diff --git a/drivers/staging/rtl8192u/r8192U_dm.c >

[PATCH v2 3/4] staging: rtl8192u: remove redundant code

2014-12-31 Thread Lorenzo Stoakes
This patch fixes warnings/errors raised by checkpatch.pl relating to redundant code in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 176 +-- 1 file changed, 84 insertions(+), 92 deletions(-) diff --git

[PATCH v2 2/4] staging: rtl8192u: fix whitespace

2014-12-31 Thread Lorenzo Stoakes
This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c and additionally it removes inconsistent whitespace throughout. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 1606 +- 1 file changed, 625

[PATCH v2 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Lorenzo Stoakes
This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c and cleans up existing ANSI C comments. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 811 ++- 1 file changed, 420 insertions(+), 391

[PATCH v2 4/4] staging: rtl8192u: Refactor heavy nesting

2014-12-31 Thread Lorenzo Stoakes
This patch fixes warnings raised by checkpatch.pl relating to heavily indented lines in r8192U_dm.c. It refactors a couple of else if cases to achieve the same outcome indented by one fewer tab. It additionally updateds comment positioning to be consistent across these cases. Signed-off-by:

Re: [PATCH 2/3] gpio: dln2: use bus_sync_unlock instead of scheduling work

2014-12-31 Thread Linus Walleij
On Thu, Dec 11, 2014 at 2:02 PM, Octavian Purdila wrote: > Use the irq_chip bus_sync_unlock method to update hardware registers > instead of scheduling work from the mask/unmask methods. This simplifies > a bit the driver and make it more uniform with the other GPIO IRQ > drivers. > >

Re: [PATCH 1/3] gpio: dln2: fix issue when an IRQ is unmasked then enabled

2014-12-31 Thread Linus Walleij
On Thu, Dec 11, 2014 at 2:02 PM, Octavian Purdila wrote: > As noticed during suspend/resume operations, the IRQ can be unmasked > then disabled in suspend and eventually enabled in resume, but without > being unmasked. > > The current implementation does not take into account interactions >

Re: [PATCH V8 00/33] loop: Issue O_DIRECT aio using bio_vec

2014-12-31 Thread Sedat Dilek
On Thu, Jul 25, 2013 at 7:50 PM, Dave Kleikamp wrote: > This patch series adds a kernel interface to fs/aio.c so that kernel code can > issue concurrent asynchronous IO to file systems. It adds an aio command and > file system methods which specify io memory with pages instead of userspace >

[GIT PULL] Audit fixes for 3.19 #2

2014-12-31 Thread Paul Moore
Hi Linus, One audit patch to resolve a panic/oops when recording filenames in the audit log, see the mail archive link below. The fix isn't as nice as I would like, as it involves an allocate/copy of the filename, but it solves the problem and the overhead should only affect users who have

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Arend van Spriel
On 12/31/14 18:31, Theodore Ts'o wrote: On Wed, Dec 31, 2014 at 04:02:24PM +0100, Arend van Spriel wrote: It is unfortunately indeed. I think iwconfig and friends will never go away although iw is a better alternative, simply because people don't like to change their home-made scripts/tools.

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-31 Thread James Bottomley
On Wed, 2014-12-31 at 20:38 +0200, Michael S. Tsirkin wrote: > On Wed, Dec 31, 2014 at 09:17:20AM -0800, James Bottomley wrote: [...] > > OK, parisc developers still being dense, but this does look like an > > abuse of the bitwise type. > > To give you another example: > > __le16 __user

Re: scsi: non atomic allocation in mempool_alloc in atomic context

2014-12-31 Thread Douglas Gilbert
On 14-12-31 01:14 PM, Sasha Levin wrote: Hi Christoph, I'm seeing an issue which was bisected down to 3c356bde1 ("scsi: stop passing a gfp_mask argument down the command setup path"): [ 3395.328221] BUG: sleeping function called from invalid context at mm/mempool.c:206 [ 3395.329540]

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Arend van Spriel
On 12/31/14 16:14, Andreas Hartmann wrote: Jiri Kosina wrote: On Wed, 31 Dec 2014, Arend van Spriel wrote: The thing with WEXT is that it will stay as is. So if tools like wicd want to support new features like P2P it will need to make the switch. I checked out wicd repo and found a number of

Re: perf-probe crash in dwarf_getcfi_elf

2014-12-31 Thread Mark Wielaard
On Tue, Dec 30, 2014 at 06:05:33PM +0900, Namhyung Kim wrote: > And I found a related commit (5704c8c4fa71 "getcfi_scn_eh_frame: Don't > crash and burn when .eh_frame bits aren't there.") in elfutils that > can lead to a unexpected crash like this. To safely use the function, > it needs to check

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Lorenzo Stoakes wrote: > On 31 December 2014 at 19:00, Konrad Zapalowicz > wrote: > > > > You also fix the line length here which shall be the subject of a > > separate patch as this is not C99 comments related change. > > > > Apologies - I missed this, will prepare a v2 with this

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Lorenzo Stoakes
On 31 December 2014 at 19:23, Jeremiah Mahler wrote: > But this change is not related to C99 comments and you didn't > explain why this change was made in your log message. > It should probably be in a separate patch. Absolutely, I am currently fixing this and checking for any other instances

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Jeremiah Mahler
Lorenzo, On Wed, Dec 31, 2014 at 06:42:53PM +, Lorenzo Stoakes wrote: > This patch fixes errors raised by checkpatch.pl relating to use of C99 > comments > in r8192U_dm.c. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 841 >

Re: [PATCH net-next] tun: return proper error code from tun_do_read

2014-12-31 Thread David Miller
From: Alex Gartrell Date: Thu, 25 Dec 2014 23:22:49 -0800 > Instead of -1 with EAGAIN, read on a O_NONBLOCK tun fd will return 0. This > fixes this by properly returning the error code from __skb_recv_datagram. > > Signed-off-by: Alex Gartrell Applied. -- To unsubscribe from this list: send

Re: [PATCH net-next] tun: Fixed unsigned/signed comparison

2014-12-31 Thread David Miller
From: Alex Gartrell Date: Thu, 25 Dec 2014 23:05:03 -0800 > Validated that this was actually using the unsigned comparison with gdb. > > Signed-off-by: Alex Gartrell Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Lorenzo Stoakes
On 31 December 2014 at 19:00, Konrad Zapalowicz wrote: > > You also fix the line length here which shall be the subject of a > separate patch as this is not C99 comments related change. > Apologies - I missed this, will prepare a v2 with this separated out into a different patch. Relatedly, the

[PATCH akpm/next] lib: crc32: conditionally constify crc32 lookup table

2014-12-31 Thread Daniel Borkmann
Commit 8f243af42ade ("sections: fix const sections for crc32 table") removed the compile-time generated crc32 tables from the RO sections, because it conflicts with the definition of __cacheline_aligned which puts all such aligned data into .data..cacheline_aligned section optimized for wasting

Re: [PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Konrad Zapalowicz
On 12/31, Lorenzo Stoakes wrote: > This patch fixes errors raised by checkpatch.pl relating to use of C99 > comments > in r8192U_dm.c. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 841 > ++- > 1 file changed, 432

[PATCH v3] staging: lustre: libcfs: fix sparse warnings about static declaration

2014-12-31 Thread Serguey Parkhomovsky
Fixes the following sparse warnings: drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:198:1: warning: symbol 'libcfs_arch_init' was not declared. Should it be static? drivers/staging/lustre/lustre/libcfs/linux/linux-prim.c:204:1: warning: symbol 'libcfs_arch_cleanup' was not declared.

Re: [PATCH v2] staging: lustre: linux-prim.c: fix sparse warnings about static declaration

2014-12-31 Thread Serguey Parkhomovsky
On Wed, Dec 31, 2014 at 11:40:29AM +0100, Konrad Zapalowicz wrote: > This lines are way too long. You should break the commit message line > around 72nd column so that it looks nice when emailed. > > You can also omit the filename from the topic line as this is already in > the diff. Thanks for

[PATCH 4/4] staging: rtl8192u: Refactor heavy nesting

2014-12-31 Thread Lorenzo Stoakes
This patch fixes warnings raised by checkpatch.pl relating to heavily indented lines in r8192U_dm.c. It refactors a couple of else if cases to achieve the same outcome indented by one fewer tab. It additionally updateds comment positioning to be consistent across these cases. Signed-off-by:

[PATCH 3/4] staging: rtl8192u: remove redundant code

2014-12-31 Thread Lorenzo Stoakes
This patch fixes warnings/errors raised by checkpatch.pl relating to redundant code in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 160 +-- 1 file changed, 77 insertions(+), 83 deletions(-) diff --git

[PATCH 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Lorenzo Stoakes
This patch fixes errors raised by checkpatch.pl relating to use of C99 comments in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 841 ++- 1 file changed, 432 insertions(+), 409 deletions(-) diff --git

[PATCH 2/4] staging: rtl8192u: fix whitespace

2014-12-31 Thread Lorenzo Stoakes
This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace in r8192U_dm.c. Signed-off-by: Lorenzo Stoakes --- drivers/staging/rtl8192u/r8192U_dm.c | 1409 +- 1 file changed, 530 insertions(+), 879 deletions(-) diff --git

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-31 Thread Michael S. Tsirkin
On Wed, Dec 31, 2014 at 09:17:20AM -0800, James Bottomley wrote: > On Sat, 2014-12-27 at 18:14 +0200, Michael S. Tsirkin wrote: > > On Thu, Dec 25, 2014 at 11:37:45PM +0100, Helge Deller wrote: > > > Hi Michael, > > > > > > On 12/25/2014 10:29 AM, Michael S. Tsirkin wrote: > > > >virtio wants to

Re: EFI mixed mode + perf = rampant triple faults

2014-12-31 Thread Matt Fleming
On Wed, 17 Dec, at 08:54:56AM, Andy Lutomirski wrote: > [trying again with .org spelled correctly. also cc: bpetkov] > > On Wed, Dec 17, 2014 at 8:51 AM, Andy Lutomirski wrote: > > I figured I should send this email before I forget about this issue: > > > > If you run perf record across any EFI

Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2014-12-31 Thread Jeremiah Mahler
Bas, On Wed, Dec 31, 2014 at 07:04:30PM +0100, Bas Peters wrote: > 2014-12-31 18:49 GMT+01:00 Jeremiah Mahler : > > Bas, > > > > On Wed, Dec 31, 2014 at 06:34:58PM +0100, Bas Peters wrote: > >> Fixed many checkpatch.pl complaints, ranging from whitespace issues to > >> reportedly deprecated

scsi: non atomic allocation in mempool_alloc in atomic context

2014-12-31 Thread Sasha Levin
Hi Christoph, I'm seeing an issue which was bisected down to 3c356bde1 ("scsi: stop passing a gfp_mask argument down the command setup path"): [ 3395.328221] BUG: sleeping function called from invalid context at mm/mempool.c:206 [ 3395.329540] in_atomic(): 1, irqs_disabled(): 0, pid: 6399,

Re: [PATCH 1/1 net-next] tipc: replace 0 by NULL for pointers

2014-12-31 Thread David Miller
From: Fabian Frederick Date: Thu, 25 Dec 2014 12:05:50 +0100 > Fix sparse warning: > net/tipc/link.c:1924:40: warning: Using plain integer as NULL pointer > > Signed-off-by: Fabian Frederick Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2014-12-31 Thread Bas Peters
2014-12-31 18:49 GMT+01:00 Jeremiah Mahler : > Bas, > > On Wed, Dec 31, 2014 at 06:34:58PM +0100, Bas Peters wrote: >> Fixed many checkpatch.pl complaints, ranging from whitespace issues to >> reportedly deprecated function and macro usage. >> > One patch should fix one type of problem. This

Re: [PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2014-12-31 Thread Jeremiah Mahler
Bas, On Wed, Dec 31, 2014 at 06:34:58PM +0100, Bas Peters wrote: > Fixed many checkpatch.pl complaints, ranging from whitespace issues to > reportedly deprecated function and macro usage. > One patch should fix one type of problem. This needs to be broken up in to individual patches. > I have

Re: [PATCH v2] sound: pci: asihpi: hpifunc.c: Remove some unused functions

2014-12-31 Thread Takashi Iwai
At Wed, 31 Dec 2014 18:07:36 +0100, Rickard Strandqvist wrote: > > 2014-12-31 17:45 GMT+01:00 Takashi Iwai : > > > At Wed, 31 Dec 2014 17:41:33 +0100, > > Rickard Strandqvist wrote: > > > > > > 2014-12-31 17:07 GMT+01:00 Takashi Iwai : > > > > > > > At Wed, 31 Dec 2014 16:17:02 +0100, > > > >

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Linus Torvalds
On Wed, Dec 31, 2014 at 9:31 AM, Theodore Ts'o wrote: > > Most poeple are still using "route" and "ifconfig" instead of "ip". > Deal with it. Indeed. This whole "let's throw out the old and broken" stuff is a disease. It would have been much better (and it's still an option, as Ted points out)

Re: [PATCH net-next 00/11] Time Counter fixes and improvements

2014-12-31 Thread Richard Cochran
On Tue, Dec 30, 2014 at 06:32:01PM -0500, David Miller wrote: > > Series applied, thanks Richard. I got an automated email from kbuild test robot showing new warnings and errors introduced by this series. I'll follow up with fixes soon. Thanks, Richard -- To unsubscribe from this list:

But do not tell anyone

2014-12-31 Thread George
Everything could become real http://binaryperform.go2cloud.org/aff_c?offer_id=36_id=1476 No more such Info? Simply answer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH] Drivers: isdn: gigaset: checkpatch cleanup

2014-12-31 Thread Bas Peters
Fixed many checkpatch.pl complaints, ranging from whitespace issues to reportedly deprecated function and macro usage. I have not been able to test the code as I do not have access to the hardware but since no new features were really added I don't think that should pose a problem. There are

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Theodore Ts'o
On Wed, Dec 31, 2014 at 04:02:24PM +0100, Arend van Spriel wrote: > > It is unfortunately indeed. I think iwconfig and friends will never go away > although iw is a better alternative, simply because people don't like to > change their home-made scripts/tools. WIRELESS_EXT actually is largely,

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-31 Thread James Bottomley
On Sat, 2014-12-27 at 18:14 +0200, Michael S. Tsirkin wrote: > On Thu, Dec 25, 2014 at 11:37:45PM +0100, Helge Deller wrote: > > Hi Michael, > > > > On 12/25/2014 10:29 AM, Michael S. Tsirkin wrote: > > >virtio wants to read bitwise types from userspace using get_user. At the > > > > I don't

[PATCH] acpi: acpica: utstring.c: Remove some unused functions

2014-12-31 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: acpi_ut_strlwr() acpi_ut_safe_strncat() acpi_ut_safe_strcat() acpi_ut_safe_strcpy() ut_convert_backslashes() acpi_ut_stricmp() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist

Re: [PATCH v2 0/3] x86: tools: shell-ify calc_run_size perl-ism

2014-12-31 Thread Borislav Petkov
On Wed, Dec 31, 2014 at 05:43:02PM +0100, Sylvain BERTRAND wrote: > Choked while compiling linux on a lightweight system, i.e. freed from perl. > > New script tested with dash shell and bash shell. > > V2: > - chocked->choked typo > - early conversion from hexadecimal > - error

[PATCH] net: ethernet: intel: i40e: i40e_fcoe.c: Remove unused function

2014-12-31 Thread Rickard Strandqvist
Remove the function i40e_rx_is_fip() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/net/ethernet/intel/i40e/i40e_fcoe.c |9 - 1 file changed, 9 deletions(-) diff --git

Re: [PATCH v2] sound: pci: asihpi: hpifunc.c: Remove some unused functions

2014-12-31 Thread Takashi Iwai
At Wed, 31 Dec 2014 17:41:33 +0100, Rickard Strandqvist wrote: > > 2014-12-31 17:07 GMT+01:00 Takashi Iwai : > > > At Wed, 31 Dec 2014 16:17:02 +0100, > > Rickard Strandqvist wrote: > > > > > > Removes some functions that are not used anywhere: > > > > See Eliot's previous reply. There will be

[PATCH v2 2/3] x86: tools: shell-ify calc_run_size perl-ism

2014-12-31 Thread Sylvain BERTRAND
Fix makefile. Signed-off-by: Sylvain BERTRAND --- --- a/arch/x86/boot/compressed/Makefile +++ b/arch/x86/boot/compressed/Makefile @@ -77,7 +77,7 @@ suffix-$(CONFIG_KERNEL_LZO) := lzo suffix-$(CONFIG_KERNEL_LZ4):= lz4 RUN_SIZE = $(shell $(OBJDUMP) -h vmlinux | \ -perl

[PATCH v2 1/3] x86: tools: shell-ify calc_run_size perl-ism

2014-12-31 Thread Sylvain BERTRAND
Add the shell script. Signed-off-by: Sylvain BERTRAND --- --- arch/x86/tools/calc_run_size.sh +++ arch/x86/tools/calc_run_size.sh @@ -0,0 +1,46 @@ +#!/bin/sh +# +# Calculate the amount of space needed to run the kernel, including room for +# the .bss and .brk sections. +# +# Usage: +# objdump

[PATCH v2 0/3] x86: tools: shell-ify calc_run_size perl-ism

2014-12-31 Thread Sylvain BERTRAND
Choked while compiling linux on a lightweight system, i.e. freed from perl. New script tested with dash shell and bash shell. V2: - chocked->choked typo - early conversion from hexadecimal - error messages on stderr -- Sylvain -- To unsubscribe from this list: send the

Re: [PATCH] Revert "cfg80211: make WEXT compatibility unselectable"

2014-12-31 Thread Paul Bolle
On Tue, 2014-12-30 at 23:52 +0100, Jiri Kosina wrote: > This reverts commit 24a0aa212ee2dbe44360288684478d76a8e20a0a. > > It's causing severe userspace breakage. Namely, all the utilities > from wireless-utils which are relying on CONFIG_WEXT (which means > tools like 'iwconfig', 'iwlist', etc)

[PATCH v2 3/3] x86: tools: shell-ify calc_run_size perl-ism

2014-12-31 Thread Sylvain BERTRAND
Remove perl script. Signed-off-by: Sylvain BERTRAND --- --- a/arch/x86/tools/calc_run_size.pl +++ b/arch/x86/tools/calc_run_size.pl @@ -1,39 +0,0 @@ -#!/usr/bin/perl -# -# Calculate the amount of space needed to run the kernel, including room for -# the .bss and .brk sections. -# -# Usage: -#

Re: [PATCH] ASoC: adi: Add missing return statement.

2014-12-31 Thread Lars-Peter Clausen
On 12/31/2014 05:20 PM, Andrew Jackson wrote: From: Andrew Jackson The probe routine was disabling the clock even if the system was configured successfully. Add a return statement to leave clocks enabled. Signed-off-by: Andrew Jackson Acked-by: Lars-Peter Clausen Thanks, never noticed

[PATCH] ASoC: adi: Add missing return statement.

2014-12-31 Thread Andrew Jackson
From: Andrew Jackson The probe routine was disabling the clock even if the system was configured successfully. Add a return statement to leave clocks enabled. Signed-off-by: Andrew Jackson --- Spotted while reviewing clock preparation sound/soc/adi/axi-i2s.c |2 ++ 1 files changed, 2

[PATCH] ASoC: dwc: Remove unnecessary conditional compilation

2014-12-31 Thread Andrew Jackson
From: Andrew Jackson of_match_ptr is already conditionally compiled based on CONFIG_OF so further conditional compilation is not required. Remove conditional compilation surrounding of_match_ptr. Signed-off-by: Andrew Jackson --- sound/soc/dwc/designware_i2s.c |2 -- 1 files changed, 0

Re: [PATCH v17 00/12] input: cyapa: instruction of cyapa patches

2014-12-31 Thread Jeremiah Mahler
Dudley, On Wed, Dec 31, 2014 at 09:16:49AM +0800, Dudley Du wrote: > V17 patches have below updates, details of other updates see history list: > 1) Fix kernel oops when system booting up with finger on TP. > 2) Remove unnecessary error log that may to system. > 3) Slipt out pm sleep code into

Re: [PATCH v2] sound: pci: asihpi: hpifunc.c: Remove some unused functions

2014-12-31 Thread Takashi Iwai
At Wed, 31 Dec 2014 16:17:02 +0100, Rickard Strandqvist wrote: > > Removes some functions that are not used anywhere: See Eliot's previous reply. There will be some code changes, so this action is no-go as of now. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 2/2] kbuild: Drop support for clean-rule

2014-12-31 Thread Sedat Dilek
On Wed, Dec 31, 2014 at 4:35 PM, Michal Marek wrote: > clean-rule has not been used since 94869f86 (kbuild: Accept absolute > paths in clean-files and introduce clean-dirs) ten years ago. > > Signed-off-by: Michal Marek Tested-by: Sedat Dilek - Sedat - > --- > scripts/Makefile.clean | 3 ---

Re: [PATCH V6 00/25] Generic BMIPS kernel

2014-12-31 Thread Florian Fainelli
2014-12-25 9:48 GMT-08:00 Kevin Cernekee : > V5->V6: Incorporate several fixes/enhancements from Jaedon Shin: > > - Fix register read/modify/write in RAC flush code. > > - Fix use of "SYS_HAS_CPU_BMIPS32_3300" Kconfig symbol. > > - Add base platform support for 7358 and 7362. > > The DTS files

  1   2   3   4   5   >