Re: [PATCH V2] Allow compaction of unevictable pages

2015-03-09 Thread Eric B Munson
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/09/2015 03:57 PM, David Rientjes wrote: > On Mon, 9 Mar 2015, Eric B Munson wrote: > >> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h >> index f279d9c..599fb01 100644 --- a/include/linux/mmzone.h +++ >> b/include/linux/mmzone.h @

Re: [PATCH] iio: light: Add support for Capella CM3323 color/light sensor

2015-03-09 Thread Daniel Baluta
On Mon, Mar 9, 2015 at 5:45 PM, Jonathan Cameron wrote: > On 02/03/15 19:03, Kevin Tsai wrote: >> Hi Daniel, >> >> Ambient light sensor is trying to match the brightness sensitivity of human >> visual system. Please see the following links: >> http://en.wikipedia.org/wiki/Color_vision#mediaviewe

[PATCH 1/2] CAPABILITIES: add cap_isequal helper

2015-03-09 Thread Mateusz Guzik
Can be used to determine whether two given sets have the same capabilities. Signed-off-by: Mateusz Guzik --- include/linux/capability.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/linux/capability.h b/include/linux/capability.h index af9f0b9..2fcf941 100644 --- a/incl

[PATCH] crypto: amcc: remove incorrect __init/__exit markups

2015-03-09 Thread Dmitry Torokhov
Even if bus is not hot-pluggable, the devices can be bound and unbound from the driver via sysfs, so we should not be using __init/__exit annotations on probe() and remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind

[PATCH 2/2] fs: avoid unnecessary prepare_creds in faccessat

2015-03-09 Thread Mateusz Guzik
Sometimes faccessat needs to modify current thread's credentials, but calls prepare_creds unconditionally. Take advantage of the fact that we can detect whether any modification to credentials is needed and in turn avoid unnecessary allocations. Signed-off-by: Mateusz Guzik --- fs/open.c | 53 +

[PATCH 0/2] avoid prepare_creds in faccessat when possible

2015-03-09 Thread Mateusz Guzik
Sometimes faccessat needs to modify current thread's credentials, but calls prepare_creds unconditionally. However, typically resulting credentials are identical to original ones and in that case newcredentials are unnecessary. We can detect this before allocating anything. This patch series adds

Re: [PATCH 2/2] pinctrl: mediatek: Adjust mt8173 pinctrl kconfig

2015-03-09 Thread Arnd Bergmann
On Friday 06 March 2015 14:24:51 Yingjoe Chen wrote: > Linus, > This one make PINCTRL_MT8173 option user selectable and is based on > mtk-staging in your tree. If you think this is OK, please applied or > squash this into previous change. Thanks. The patch looks good in principle, just two small c

Re: [PATCH 3/4] x86: save user rsp in pt_regs->sp on SYSCALL64 fastpath

2015-03-09 Thread Denys Vlasenko
On Mon, Mar 9, 2015 at 9:11 PM, Andy Lutomirski wrote: >> @@ -253,11 +247,13 @@ GLOBAL(system_call_after_swapgs) >> */ >> ENABLE_INTERRUPTS(CLBR_NONE) >> ALLOC_PT_GPREGS_ON_STACK 8 /* +8: space for orig_ax */ >> + movq%rcx,RIP(%rsp) >> + movq

Re: [PATCH v2 2/3] staging: panel: return register value

2015-03-09 Thread Willy Tarreau
On Mon, Mar 09, 2015 at 08:08:24PM +0530, Sudip Mukherjee wrote: > we were returning success even if the module failed to register. > now we are returning the actual return value, success or error. > > Signed-off-by: Sudip Mukherjee Thanks for this. Acked-by: Willy Tarreau Willy -- To unsubs

[PATCH v3 -next 02/11] serial: core: Fix kernel doc for uart_console_write()

2015-03-09 Thread Peter Hurley
'/**' is required to start a kernel-doc comment block. Acked-by: Rob Herring Signed-off-by: Peter Hurley --- drivers/tty/serial/serial_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c index 3f823c26..3

[GIT] Networking

2015-03-09 Thread David Miller
: don't truncate ethernet protocol type to u8 Brian King (1): bnx2x: Force fundamental reset for EEH recovery David S. Miller (4): Merge branch 'xgene' Merge branch 'xen-netback' Merge git://git.kernel.org/.../pablo/nf Merge tag 'lin

[PATCH v3 -next 01/11] console: Add extensible console matching

2015-03-09 Thread Peter Hurley
Add match() method to struct console which allows the console to perform console command line matching instead of (or in addition to) default console matching (ie., by fixed name and index). The match() method returns 0 to indicate a successful match; normal console matching occurs if no match() m

Re: [PATCH v2] MTD: cfi: reduce stack size

2015-03-09 Thread Sergei Shtylyov
Hello. On 3/9/2015 10:34 PM, Arnd Bergmann wrote: The cfi_staa_write_buffers function uses a large amount of kernel stack whenever CONFIG_MTD_MAP_BANK_WIDTH_32 is set, and that results in a warning on ARM allmodconfig builds: drivers/mtd/chips/cfi_cmdset_0020.c: In function 'cfi_staa_write_b

[PATCH v3 -next 05/11] serial: 8250_early: Assume uart already initialized if no baud option

2015-03-09 Thread Peter Hurley
The option string is not supplied if the earlycon is started via devicetree and OF_EARLYCON_DECLARE(). The option string is also not required if started via kernel command line parameters of the form: earlycon=uart,mmio, console=uart,mmio, If earlycon_device->baud is 0, then an option string

[PATCH v3 -next 03/11] serial: 8250_early: Remove early_device variable

2015-03-09 Thread Peter Hurley
early_device was only required for serial8250_find_port_for_earlycon(), which was replaced by extensible console matching. Fixup early_serial8250_write() to get the earlycon_device * from console->data (which is initialized by {of_}setup_earlycon()). Acked-by: Rob Herring Signed-off-by: Peter Hu

[PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console()

2015-03-09 Thread Peter Hurley
setup_earlycon() will now match and register the desired earlycon from the param string (as if 'earlycon=...' had been set on the command line). Use setup_earlycon() from existing arch call sites which start an earlycon directly. Acked-by: Rob Herring Signed-off-by: Peter Hurley --- arch/mips/m

[PATCH v3 -next 07/11] serial: earlycon: Ignore parse_options() error code

2015-03-09 Thread Peter Hurley
Because setup_earlycon() continues to attempt console registration if an error occurred parsing the option string, the actual value of the error code from parse_options() is ignored. Acked-by: Rob Herring Signed-off-by: Peter Hurley --- drivers/tty/serial/earlycon.c | 3 +-- 1 file changed, 1 i

[PATCH v3 -next 06/11] serial: 8250_early: Fix setup() error code

2015-03-09 Thread Peter Hurley
If parsing failed to decode a valid uart addr, return -ENODEV instead of success. Although setup_earlycon() will detect the failure anyway (because the write() method has not been set), that behavior is not obvious and should not be relied on. Acked-by: Rob Herring Signed-off-by: Peter Hurley --

[PATCH v3 -next 08/11] serial: earlycon: Skip parse_options() if empty string

2015-03-09 Thread Peter Hurley
Earlycon param strings of the form earlycon= are rejected from parse_options() with an error (which, in turn, results in a NULL argument for the setup() method options parameter). Only pass non-empty string to parse_options(); this will enable handling actual parse errors differently than expec

[PATCH v3 -next 09/11] serial: earlycon: Refactor earlycon registration

2015-03-09 Thread Peter Hurley
Separate earlycon matching from registration; add register_earlycon which initializes and registers the matched earlycon. Acked-by: Rob Herring Signed-off-by: Peter Hurley --- drivers/tty/serial/earlycon.c | 42 +- 1 file changed, 25 insertions(+), 17 del

[PATCH v3 -next 10/11] serial: earlycon: Enable earlycon without command line param

2015-03-09 Thread Peter Hurley
Earlycon matching can only be triggered if 'earlycon=...' has been specified on the kernel command line. To workaround this limitation requires tight coupling between arches and specific serial drivers in order to start an earlycon. Devicetree avoids this limitation with a link table that contains

[PATCH v3 -next 00/11] Extensible console matching & direct earlycon

2015-03-09 Thread Peter Hurley
Changes from v2: * remainder of unapplied series * Changed the title and commit log for "serial: earlycon: Allow earlycon params with name only" to "serial: earlycon: Skip parse_options() for empty string" per Rob's comment. Changes from v1: * rebased on and requires "console: Fix console na

[PATCH v3 -next 04/11] serial: earlycon: Move ->uartclk initialize

2015-03-09 Thread Peter Hurley
Initializing the ->uartclk field is not related to option parsing; relocate from parse_options() to setup_earlycon() (which mirrors the behavior of of_setup_earlycon()). Acked-by: Rob Herring Signed-off-by: Peter Hurley --- drivers/tty/serial/earlycon.c | 3 +-- 1 file changed, 1 insertion(+),

[PATCH] crypto: qat - remove incorrect __exit markup

2015-03-09 Thread Dmitry Torokhov
PCI bus is hot-pluggable, and even if it wasn't one can still unbind the device from driver via sysfs, so we should not make driver's remove method as __exit. Signed-off-by: Dmitry Torokhov --- drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: RCU stalls on heavy socket traffic

2015-03-09 Thread Sebastian Andrzej Siewior
On 03/09/2015 07:02 PM, Paul E. McKenney wrote: > abaf3f9d275b (rcu: Revert "Allow post-unlock reference for rt_mutex" to avoid > priority-inversion) > > This patch fixed a priority-inversion problem, so might well fix your > RCU CPU stall-warning problem. Yes, it fixes the problem. Thank you.

Re: [PATCH 0/3] clk: divider: three exactness fixes (and a rant)

2015-03-09 Thread Uwe Kleine-König
Hello Stephen, On Mon, Mar 09, 2015 at 12:05:34PM -0700, Stephen Boyd wrote: > On 03/09/15 02:58, Philipp Zabel wrote: > > Am Freitag, den 06.03.2015, 11:40 -0800 schrieb Stephen Boyd: > >> On 03/06/15 11:28, Uwe Kleine-König wrote: > >>> Hello Mike, > >>> > >>> On Fri, Mar 06, 2015 at 10:57:30AM

Re: [PATCH v3 1/7] x86, kaslr: Use init_size instead of run_size

2015-03-09 Thread Borislav Petkov
On Mon, Mar 09, 2015 at 01:06:00PM -0700, Yinghai Lu wrote: > Yes. Just to emphasize that " We need to make sure [z_extra_offset, > init_size) will fit ZO" So you want to say: "We need to make sure the compressed kernel fits in the interval [z_extra_offset, z_extra_offset + init_size)" ? -- R

Re: [PATCH 1/1] net: delete stale packet_mclist entries

2015-03-09 Thread David Miller
From: frugg...@aristanetworks.com (Francesco Ruggeri) Date: Mon, 09 Mar 2015 12:09:52 -0700 > From ce9a4f202723f6ba1b18bc7c4a258c130c1f4148 Mon Sep 17 00:00:00 2001 > From: Francesco Ruggeri > Date: Mon, 9 Mar 2015 11:51:04 -0700 > Subject: [PATCH 1/1] net: delete stale packet_mclist entries > >

Re: [PATCH 1/2] x86_64,signal: Save and restore SS in signal frames

2015-03-09 Thread Andy Lutomirski
Hi Ingo, Here's a blast from the past. I asked Andi today, and he seems conceptually okay with this. Could you consider applying it? Aside from being a bug fix IMO, it will allow my sigreturn test to work reasonably well as a native 64-bit program. I checked: it still applies cleanly. --Andy

Re: [PATCH v2 3/6] mtd: nand: vf610_nfc: add device tree bindings

2015-03-09 Thread Bill Pringlemeir
On 9 Mar 2015, ste...@agner.ch wrote: > Signed-off-by: Bill Pringlemeir > Signed-off-by: Stefan Agner > --- > .../devicetree/bindings/mtd/vf610-nfc.txt | 39 ++ > 1 file changed, 39 insertions(+) create mode 100644 > Documentation/devicetree/bindings/mtd/vf610-nfc.txt > > dif

Re: [PATCH v3 5/9] mtd: pxa3xx_nand: add support for the Marvell Berlin nand controller

2015-03-09 Thread Robert Jarzmik
Ezequiel Garcia writes: >>> Which flash do you have there? >> The one with 0xba20 id as I said, which is AFAIK a Numonyx NAND02GR4B2C. >> > > $ grep "0xBA" drivers/mtd/nand/nand_ids.c > EXTENDED_ID_NAND("NAND 256MiB 1,8V 16-bit", 0xBA, 256, LP_OPTIONS16), > > Seems already supported by the NAND

[PATCH] locking/mutex: Refactor mutex_spin_on_owner()

2015-03-09 Thread Jason Low
This patch applies on top of tip. --- Similar to what Linus suggested for rwsem_spin_on_owner(), in mutex_spin_on_owner(), instead of having while (true) and breaking out of the spin loop on lock->owner != owner, we can have the loop

[PATCH] Staging: dgnc: fix bitmask

2015-03-09 Thread Matteo Semenzato
From: Matteo Semenzato The bitmask should be used on msignals since the signals variable is not used anywhere in the function. Signed-off-by: Matteo Semenzato --- drivers/staging/dgnc/dgnc_cls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/dgnc_cls.c

Re: [PATCH 3/4] x86: save user rsp in pt_regs->sp on SYSCALL64 fastpath

2015-03-09 Thread Andy Lutomirski
On Mon, Mar 9, 2015 at 11:39 AM, Denys Vlasenko wrote: > PER_CPU(old_rsp) usage is simplified - now it is used only > as temp storage, and userspace stack pointer is immediately stored > in pt_regs->sp on syscall entry, instead of being used later, > on syscall exit. > > Instead of PER_CPU(old_rsp

[PATCH] Staging: comedi: fix information leak

2015-03-09 Thread Matteo Semenzato
From: Matteo Semenzato The comedi_cmd struct has an hole after chanlist_len that could contain uninitialized memory, this struct is copied to userspace. Signed-off-by: Matteo Semenato --- drivers/staging/comedi/comedi_fops.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/stagin

Re: [PATCH v3 1/7] x86, kaslr: Use init_size instead of run_size

2015-03-09 Thread Yinghai Lu
On Mon, Mar 9, 2015 at 1:00 PM, Borislav Petkov wrote: > On Mon, Mar 09, 2015 at 12:35:25PM -0700, Yinghai Lu wrote: >> Can you put back: >> " >> So need to make sure [z_extra_offset, init_size) will fit ZO, that means >> init_size need to be adjusted according to ZO size. >> That make init_size i

[patch v3] mm, hugetlb: abort __get_user_pages if current has been oom killed

2015-03-09 Thread David Rientjes
If __get_user_pages() is faulting a significant number of hugetlb pages, usually as the result of mmap(MAP_LOCKED), it can potentially allocate a very large amount of memory. If the process has been oom killed, this will cause a lot of memory to potentially deplete memory reserves. In the same wa

Re: [PATCH v3 1/7] x86, kaslr: Use init_size instead of run_size

2015-03-09 Thread Borislav Petkov
On Mon, Mar 09, 2015 at 12:35:25PM -0700, Yinghai Lu wrote: > Can you put back: > " > So need to make sure [z_extra_offset, init_size) will fit ZO, that means > init_size need to be adjusted according to ZO size. > That make init_size is always >= run_size. Why? We don't adjust init_size. We assi

Re: [PATCH 1/4] x86: save r11 into pt_regs->flags on SYSCALL64 fastpath

2015-03-09 Thread Andy Lutomirski
On Mon, Mar 9, 2015 at 11:39 AM, Denys Vlasenko wrote: > Before this patch, r11 was saved in pt_regs->r11. > Which looks natural, but requires messy shuffling to/from iret frame > whenever ptrace or e.g. sys_iopl wants to modify flags - because > that's how this register is used by SYSCALL/SYSRET.

Re: [PATCH V2] Allow compaction of unevictable pages

2015-03-09 Thread David Rientjes
On Mon, 9 Mar 2015, Eric B Munson wrote: > diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h > index f279d9c..599fb01 100644 > --- a/include/linux/mmzone.h > +++ b/include/linux/mmzone.h > @@ -232,8 +232,6 @@ struct lruvec { > #define ISOLATE_UNMAPPED ((__force isolate_mode_t)0x2)

Re: [PATCH v2 1/5] arm: KVM: export vcpi->pause state via MP_STATE ioctls

2015-03-09 Thread Peter Maydell
On 10 March 2015 at 04:29, Christoffer Dall wrote: > On Mon, Mar 09, 2015 at 04:34:21PM +, Alex Bennée wrote: >> - Boot >> - Power on secondary CPUs >> - Power off one secondary CPU >> - Migrate to file (cpu_powered reflects state of each CPU) >> >> - Start fresh QEMU >> - Restore from file (c

Re: [PATCH v5 3/8] pinctrl: cygnus: add initial IOMUX driver support

2015-03-09 Thread Paul Bolle
Ray Jui schreef op ma 09-03-2015 om 12:40 [-0700]: > I don't see this as an "issue" to be quite honest. (Off topic: is issue a, well, strong word? To my (non-English) mind it's rather neutral, carrying by itself less urgency than, say, problem. If I'm wrong I might have confused quite a few people

Re: [PATCH] net: macb: constify macb configuration data

2015-03-09 Thread David Miller
From: Josh Cartwright Date: Mon, 9 Mar 2015 11:14:39 -0500 > The configurations are not modified by the driver. Make them 'const' so > that they may be placed in a read-only section. > > Signed-off-by: Josh Cartwright Applied. -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [PATCH] x86: entry_32.S: change ESPFIX test to not touch PT_OLDSS(%esp)

2015-03-09 Thread Andy Lutomirski
On Mon, Mar 9, 2015 at 12:26 PM, H. Peter Anvin wrote: > On 03/09/2015 12:13 PM, Andy Lutomirski wrote: >> On Mon, Mar 9, 2015 at 10:44 AM, H. Peter Anvin wrote: >>> On 03/09/2015 09:44 AM, Linus Torvalds wrote: And remember: those zero-cost out-of-order branches turn quite expensi

[PATCH] ARM: shmobile: R-Car Gen2: Add da9063/da9210 regulator quirk

2015-03-09 Thread Geert Uytterhoeven
The r8a7790/lager and r8a7791/koelsch development boards have da9063 and da9210 regulators. Both regulators have their interrupt request lines tied to the same interrupt pin (IRQ2) on the SoC. After cold boot or da9063-induced restart, both the da9063 and da9210 seem to assert their interrupt req

Re: [PATCH v4 2/2] cgroups: add a pids subsystem

2015-03-09 Thread Tejun Heo
Hello, Austin. On Mon, Mar 09, 2015 at 02:58:11PM -0400, Austin S Hemmelgarn wrote: > On 2015-03-08 23:34, Tejun Heo wrote: > > > >Does pids limit make sense in the root cgroup? > > > I would say it kind of does, although I would just expect it to track > /proc/sys/kernel/pid_max (either as a read

[PATCH v2] HID: i2c-hid: Fix suspend/resume when already runtime suspended

2015-03-09 Thread Doug Anderson
If the i2c-hid device was runtime suspended and then the system suspended itself we'd end up disabling interrupts twice (in i2c_hid_runtime_suspend and i2c_hid_suspend) and not reenabling them until later when the i2c-hid device was runtime resumed. Unfortunately the i2c_hid_resume() calls i2c_hid_

Re: [PATCH] sunrpc: fix braino in ->poll()

2015-03-09 Thread J. Bruce Fields
On Sat, Mar 07, 2015 at 09:08:46PM +, Al Viro wrote: > POLL_OUT isn't what callers of ->poll() are expecting to see; it's > actually __SI_POLL | 2 and it's a siginfo code, not a poll bitmap > bit... Thanks!--b. > > Signed-off-by: Al Viro > --- > diff --git a/net/sunrpc/cache.c b/net/sunrpc/

Re: [PATCH v5 3/8] pinctrl: cygnus: add initial IOMUX driver support

2015-03-09 Thread Ray Jui
On 3/9/2015 12:30 PM, Paul Bolle wrote: > Ray Jui schreef op ma 09-03-2015 om 12:00 [-0700]: >> I think it depends on how you see it. Based on this logic, then one can >> also argue comments in the code will be pre-processed away and are not >> needed. They at least serve the same documentation p

Re: [PATCH v2 0/7] New Lenovos 2015 touchpads: party time!

2015-03-09 Thread Benjamin Tissoires
On Mon, Mar 9, 2015 at 4:24 AM, Hans de Goede wrote: > Hi, > > > On 09-03-15 07:46, Dmitry Torokhov wrote: >> >> On Wed, Feb 25, 2015 at 03:58:20PM +0100, Hans de Goede wrote: >>> >>> Hi, >>> >>> On 25-02-15 15:36, Benjamin Tissoires wrote: On Mon, Feb 16, 2015 at 10:23 PM, Benjamin Tiss

[PATCH v2] MTD: cfi: reduce stack size

2015-03-09 Thread Arnd Bergmann
The cfi_staa_write_buffers function uses a large amount of kernel stack whenever CONFIG_MTD_MAP_BANK_WIDTH_32 is set, and that results in a warning on ARM allmodconfig builds: drivers/mtd/chips/cfi_cmdset_0020.c: In function 'cfi_staa_write_buffers': drivers/mtd/chips/cfi_cmdset_0020.c:651:1: warn

Re: [PATCH] avc: remove unnecessary pointer reassignment

2015-03-09 Thread Paul Moore
On Wed, Mar 4, 2015 at 1:07 PM, Paul Moore wrote: > On Fri, Feb 27, 2015 at 8:15 AM, Stephen Smalley wrote: >> On 02/26/2015 04:54 PM, Jeff Vander Stoep wrote: >>> Commit f01e1af445fa ("selinux: don't pass in NULL avd to >>> avc_has_perm_noaudit") >>> made this pointer reassignment unnecessary.

Re: [PATCH v3 1/7] x86, kaslr: Use init_size instead of run_size

2015-03-09 Thread Yinghai Lu
On Mon, Mar 9, 2015 at 5:49 AM, Borislav Petkov wrote: > I ended up committing this. Anything I've missed? > > --- > From: Yinghai Lu > Date: Sat, 7 Mar 2015 14:07:15 -0800 > Subject: [PATCH] x86/setup: Use init_size instead of run_size > > Commit > > e6023367d779 ("x86, kaslr: Prevent .bss fro

Re: [PATCH] MTD: cfi: reduce stack size

2015-03-09 Thread Arnd Bergmann
On Monday 09 March 2015 12:58:54 Ezequiel Garcia wrote: > On 03/09/2015 10:58 AM, Arnd Bergmann wrote: > > The cfi_staa_write_buffers function uses a large amount of ernel stack > > Typo: "ernel" ok > > whenever CONFIG_MTD_MAP_BANK_WIDTH_32 is set, and that results in a > > warning on ARM allmod

Re: [PATCH] x86: entry_32.S: change ESPFIX test to not touch PT_OLDSS(%esp)

2015-03-09 Thread Denys Vlasenko
>> What we definitely should do here is at least frame this check with >>> That being said, what ends up in the high bits of esp when we iret to >>> vm86 mode? >> >> I don't know. I guess it's time to write an actual vm86 testcase :) > > Ick. I can try... I found an example which runs small bit o

Re: [PATCH v2 1/5] arm: KVM: export vcpi->pause state via MP_STATE ioctls

2015-03-09 Thread Christoffer Dall
On Mon, Mar 09, 2015 at 04:34:21PM +, Alex Bennée wrote: > > Christoffer Dall writes: > > > Hi Alex, > > > > The subject of this change has a typo, and I also think it's not about > > exposing the pause state (that's just an internal name/concept), but > > about exposing the PSCI state, or s

Re: [PATCH v5 3/8] pinctrl: cygnus: add initial IOMUX driver support

2015-03-09 Thread Paul Bolle
Ray Jui schreef op ma 09-03-2015 om 12:00 [-0700]: > I think it depends on how you see it. Based on this logic, then one can > also argue comments in the code will be pre-processed away and are not > needed. They at least serve the same documentation purpose in a way. So why not make them comments

Re: [PATCH] x86: entry_32.S: change ESPFIX test to not touch PT_OLDSS(%esp)

2015-03-09 Thread H. Peter Anvin
On 03/09/2015 12:13 PM, Andy Lutomirski wrote: > On Mon, Mar 9, 2015 at 10:44 AM, H. Peter Anvin wrote: >> On 03/09/2015 09:44 AM, Linus Torvalds wrote: >>> >>> And remember: those zero-cost out-of-order branches turn quite >>> expensive if they *ever* mispredict. Even a 5% mispredict rate is >>>

Re: [PATCH] ps3: Fix trivial typos in comment and debug message

2015-03-09 Thread Geoff Levand
On Sat, 2015-03-07 at 13:03 +0100, Yannick Guerrini wrote: > Change 'prosessor' to 'processor' > Change 'set_inteval' to 'set_interval' > > Signed-off-by: Yannick Guerrini > --- > drivers/ps3/ps3-lpm.c | 4 ++-- Looks good. Thanks for the fixes. Acked-by: Geoff Levand -- To unsubscribe from

Re: [PATCH] x86: entry_32.S: change ESPFIX test to not touch PT_OLDSS(%esp)

2015-03-09 Thread Andy Lutomirski
On Mon, Mar 9, 2015 at 10:44 AM, H. Peter Anvin wrote: > On 03/09/2015 09:44 AM, Linus Torvalds wrote: >> >> And remember: those zero-cost out-of-order branches turn quite >> expensive if they *ever* mispredict. Even a 5% mispredict rate is >> likely to mean "it's better to have a data dependency

[RFC 1/1 linux-next] fs/hfsplus: use kasprintf instead of kmalloc/strcpy.

2015-03-09 Thread Fabian Frederick
This patch removes prefixlen from all getxattr/setxattr callsites and maximum attribute preallocation. It's an RFC because it could bring a memory leak somewhere if attribute is stored on the old preallocation basis and I don't know the code enough to evaluate the risk. Suggested-by: Andrew Morto

[PATCH 1/1] net: delete stale packet_mclist entries

2015-03-09 Thread Francesco Ruggeri
>From ce9a4f202723f6ba1b18bc7c4a258c130c1f4148 Mon Sep 17 00:00:00 2001 From: Francesco Ruggeri Date: Mon, 9 Mar 2015 11:51:04 -0700 Subject: [PATCH 1/1] net: delete stale packet_mclist entries When an interface is deleted from a net namespace the ifindex in the corresponding entries in PF_PACKET

Re: [PATCH v2] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2015-03-09 Thread David Cohen
Hi Linus, On Mon, Mar 09, 2015 at 11:16:08AM -0500, Felipe Balbi wrote: > On Sat, Mar 07, 2015 at 09:06:22PM +0100, Linus Walleij wrote: > > On Fri, Feb 20, 2015 at 8:17 PM, David Cohen > > wrote: > > > On Fri, Feb 20, 2015 at 10:53:44AM +0100, Linus Walleij wrote: > > > > >> I would put this ad

Re: [PATCH 0/3] clk: divider: three exactness fixes (and a rant)

2015-03-09 Thread Stephen Boyd
On 03/09/15 02:58, Philipp Zabel wrote: > Am Freitag, den 06.03.2015, 11:40 -0800 schrieb Stephen Boyd: >> On 03/06/15 11:28, Uwe Kleine-König wrote: >>> Hello Mike, >>> >>> On Fri, Mar 06, 2015 at 10:57:30AM -0800, Mike Turquette wrote: Quoting Uwe Kleine-König (2015-02-21 02:40:22) > Hel

Re: [PATCH] iio: pressure: add support for MS5611 pressure and temperature sensor

2015-03-09 Thread tduszyns
On Sun, Mar 08, 2015 at 09:11:07PM +0200, Daniel Baluta wrote: > Hi Tomasz, > > On Sun, Mar 8, 2015 at 7:29 PM, Tomasz Duszynski wrote: > > Add support for Measurement Specialities MS5611 pressure > > and temperature sensor. > > > > Signed-off-by: Tomasz Duszynski > > > > > +++ b/drivers/iio/pre

Re: [PATCH] iio: pressure: add support for MS5611 pressure and temperature sensor

2015-03-09 Thread tduszyns
Hi Peter, On Sun, Mar 08, 2015 at 07:16:00PM +0100, Peter Meerwald wrote: > > Add support for Measurement Specialities MS5611 pressure > > and temperature sensor. > > comments inline below > > > Signed-off-by: Tomasz Duszynski > > --- > > drivers/iio/pressure/Kconfig | 27 + > > drive

Re: [PATCH v5 3/8] pinctrl: cygnus: add initial IOMUX driver support

2015-03-09 Thread Ray Jui
On 3/9/2015 11:40 AM, Paul Bolle wrote: > Linus Walleij schreef op ma 09-03-2015 om 17:28 [+0100]: >> I think you're right. Or I fear you're right. >> >> But this problem is present in so many drivers that a generic >> fixup needs to be done with a script and across an entire subsystem >> at once

Re: [PATCH] spmi: pmic_arb: enable build on arm64 platforms

2015-03-09 Thread Paul Bolle
Stanimir Varbanov schreef op ma 09-03-2015 om 18:53 [+0200]: > On 02/23/2015 02:57 PM, Ivan T. Ivanov wrote: > > What if we just drop ARM dependency? > > I'm fine with this, Paul? Well I'm fine with anything you do, as long as the Kconfig dependencies make sense and the commit summary and the co

Re: [PATCH v4 2/2] cgroups: add a pids subsystem

2015-03-09 Thread Austin S Hemmelgarn
On 2015-03-08 23:34, Tejun Heo wrote: Does pids limit make sense in the root cgroup? I would say it kind of does, although I would just expect it to track /proc/sys/kernel/pid_max (either as a read-only value, or as an alternative way to set it). -- To unsubscribe from this list: send the li

[PATCH 1/1 linux-next] fs/hfsplus: use bool instead of int for is_known_namespace() return value

2015-03-09 Thread Fabian Frederick
is_known_namespace() only returns true/false. Also remove inline and let compiler decide what to do with static functions. Inspired-by: "David S. Miller" Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/hfsplus/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH 2/2] spi: qup: Request CS GPIO's during probe

2015-03-09 Thread Stephen Boyd
On 03/09/15 01:20, Ivan T. Ivanov wrote: > Hi Stephen, > >> On Mar 6, 2015, at 8:34 PM, Stephen Boyd wrote: >> On 03/06/15 07:26, Ivan T. Ivanov wrote: >>> Ensure that driver is owner of the GPIO's used for CS signals. >> Why? What happens if we don’t? > We can have wrong DT configuration, which c

Re: [PATCH v2 1/1] serial: 8250_dw: Fix get_mctrl behaviour

2015-03-09 Thread Jonathan Richardson
On 15-03-09 11:40 AM, Dmitry Torokhov wrote: > On Thu, Feb 26, 2015 at 4:35 PM, Jonathan Richardson > wrote: >> @@ -334,6 +342,30 @@ static int dw8250_probe_of(struct uart_port *p, >> if (id >= 0) >> p->line = id; >> >> + if (of_property_read_bool(np, "dcd-override"))

Re: [PATCH v5 6/8] pinctrl: cygnus: add gpio/pinconf driver

2015-03-09 Thread Paul Bolle
Linus Walleij schreef op ma 09-03-2015 om 17:41 [+0100]: > As pointed out in another mail on similar subject, I think these macros > are a kind of obsolete documentation and if they should be dropped we > need to go over an entire subsystem at a time and remove all boolean users > in a big patch.

[PATCH 1/1 linux-next] fs/hfsplus: atomically set inode->i_flags

2015-03-09 Thread Fabian Frederick
According to commit 5f16f3225b06 ("ext4: atomically set inode->i_flags in ext4_set_inode_flags()") Cc: "Theodore Ts'o" Cc: Andrew Morton Signed-off-by: Fabian Frederick --- fs/hfsplus/ioctl.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/fs/hfsplus/ioctl.c b

Re: [PATCH v5 3/8] pinctrl: cygnus: add initial IOMUX driver support

2015-03-09 Thread Paul Bolle
Linus Walleij schreef op ma 09-03-2015 om 17:28 [+0100]: > I think you're right. Or I fear you're right. > > But this problem is present in so many drivers that a generic > fixup needs to be done with a script and across an entire subsystem > at once, Why don't we start with checking for similar

[PATCH 3/4] x86: save user rsp in pt_regs->sp on SYSCALL64 fastpath

2015-03-09 Thread Denys Vlasenko
PER_CPU(old_rsp) usage is simplified - now it is used only as temp storage, and userspace stack pointer is immediately stored in pt_regs->sp on syscall entry, instead of being used later, on syscall exit. Instead of PER_CPU(old_rsp) and task->thread.usersp, C code uses pt_regs->sp now. FIXUP/REST

Re: [PATCH v2 1/1] serial: 8250_dw: Fix get_mctrl behaviour

2015-03-09 Thread Dmitry Torokhov
On Thu, Feb 26, 2015 at 4:35 PM, Jonathan Richardson wrote: > @@ -334,6 +342,30 @@ static int dw8250_probe_of(struct uart_port *p, > if (id >= 0) > p->line = id; > > + if (of_property_read_bool(np, "dcd-override")) { > + /* Always report DCD as active */

Re: [PATCH 1/4] Cleaned hexadecimal dump

2015-03-09 Thread Mark Brown
On Sat, Mar 07, 2015 at 12:56:32PM -0500, Adrian Remonda wrote: > +static void hexDump(const void *src, size_t length, size_t bLine, char > *prefix) > +{ Please call this hex_dump or something - that's more in line with the kernel coding style. Please also don't vUse aHungarian nNotation, it's

[PATCH 1/4] x86: save r11 into pt_regs->flags on SYSCALL64 fastpath

2015-03-09 Thread Denys Vlasenko
Before this patch, r11 was saved in pt_regs->r11. Which looks natural, but requires messy shuffling to/from iret frame whenever ptrace or e.g. sys_iopl wants to modify flags - because that's how this register is used by SYSCALL/SYSRET. This patch saves r11 in pt_regs->flags, and uses that value fo

Re: [PATCH 3/4] Added input buffer from the terminal.

2015-03-09 Thread Mark Brown
On Sat, Mar 07, 2015 at 12:56:34PM -0500, Adrian Remonda wrote: > + int ret = 0; > + char *pSrc = src; The kernel coding style doesn't use Hungarian notation... > + if (input_tx) { > + size = strlen(input_tx+1); > + tx = (uint8_t *)malloc(size); > +

[PATCH 0/4 v2] x86: entry_64.S: steps towards simpler iret frame handling

2015-03-09 Thread Denys Vlasenko
These changes make SYSENTER64 code path save flags and user's stack pointer in pt_regs->flags and pt_regs->sp, where they belong. As a result, we can drop stub_iopl() and thread_struct::usersp. Usage of PER_CPU(old_rsp) is reduced to bare minimum. FIXUP/RESTORE_TOP_OF_STACK macros are on diet to

Re: [PATCH] x86: entry_32.S: change ESPFIX test to not touch PT_OLDSS(%esp)

2015-03-09 Thread Andy Lutomirski
On Mon, Mar 9, 2015 at 11:16 AM, Linus Torvalds wrote: > On Mon, Mar 9, 2015 at 11:04 AM, Andy Lutomirski wrote: >> >> One option would be to change the NMI entry code to move itself down 8 >> bytes if this happens (came from kernel mode or sp == sp0 - 12, >> perhaps). > > Hmm. That whole code cu

Re: [PATCH 0/5] Rename regulator_set_optimum_mode

2015-03-09 Thread Mark Brown
On Wed, Feb 11, 2015 at 07:35:26PM -0800, Bjorn Andersson wrote: > Changing the name of the regulator_set_optimum_mode() to > regulator_set_load() better reflects that the API is doing. Applied all, thanks. signature.asc Description: Digital signature

Re: [PATCH] x86: entry_32.S: change ESPFIX test to not touch PT_OLDSS(%esp)

2015-03-09 Thread Denys Vlasenko
On Mon, Mar 9, 2015 at 7:16 PM, Linus Torvalds wrote: > On Mon, Mar 9, 2015 at 11:04 AM, Andy Lutomirski wrote: >> >> One option would be to change the NMI entry code to move itself down 8 >> bytes if this happens (came from kernel mode or sp == sp0 - 12, >> perhaps). > > Hmm. That whole code cur

Re: [PATCH] ARM: at91: sama5d4: Properly configure L2CC

2015-03-09 Thread Alexandre Belloni
On 09/03/2015 at 17:23:37 +, Russell King - ARM Linux wrote : > On Wed, Mar 04, 2015 at 12:29:23PM +0100, Alexandre Belloni wrote: > > As the bootloader may not properly configure the L2CC, enforce its > > configuration > > in the kernel. > > > > Signed-off-by: Alexandre Belloni > > And I a

Re: [PATCH v2] driver core: fix several coding style warnings

2015-03-09 Thread Joe Perches
On Mon, 2015-03-09 at 20:08 +0200, Ioana Antoche wrote: > Fix checkpatch.pl warnings such as: > * missing blank line after declarations > * line over 80 characters > > Signed-off-by: Ioana Antoche > --- > * undo changes related to "ERROR: that open brace { should be on the previous > line". Not

Re: [PATCH] ASoC: tlv320aic23: remove incorrect __exit markups

2015-03-09 Thread Mark Brown
On Mon, Mar 09, 2015 at 11:18:14AM -0700, Dmitry Torokhov wrote: > Even if bus is not hot-pluggable, the devices can be unbound from the > driver via sysfs, so we should not be using __exit annotations on > remove() methods. The only exception is drivers registered with > platform_driver_probe() wh

[PATCH] ASoC: tlv320aic23: remove incorrect __exit markups

2015-03-09 Thread Dmitry Torokhov
Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: D

[PATCH] perf, x86: Fix Haswell CYCLE_ACTIVITY.* counter constraints

2015-03-09 Thread Andi Kleen
From: Andi Kleen Some of the CYCLE_ACTIVITY.* events can only be scheduled on counter 2. Due to a typo Haswell matched those with INTEL_EVENT_CONSTRAINT, which lead to the events never matching as the comparison does not expect anything in the umask too. Fix the typo. Signed-off-by: Andi Kleen

Re: [PATCH] ASoC: arizona: match wait_for_completion_timeout return type

2015-03-09 Thread Mark Brown
On Sun, Mar 08, 2015 at 09:16:49AM -0400, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int. An > appropriately named unsigned long is added and the assignment fixed up. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 1/2] ASoC: wm8996: match wait_for_completion_timeout return type

2015-03-09 Thread Mark Brown
On Sun, Mar 08, 2015 at 06:02:15AM -0400, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int. An > appropriately named unsigned long is added and the assignment fixed up > in case of completion occurring the remaining time is >=1 so ret is set to > 1 if n

Re: [PATCH] ASoC: wm2200: match wait_for_completion_timeout return type

2015-03-09 Thread Mark Brown
On Sun, Mar 08, 2015 at 07:06:05AM -0400, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int. An > appropriately named unsigned long is added and the assignment fixed up. applied, thanks. signature.asc Description: Digital signature

Re: [PATCH] x86: entry_32.S: change ESPFIX test to not touch PT_OLDSS(%esp)

2015-03-09 Thread Linus Torvalds
On Mon, Mar 9, 2015 at 11:04 AM, Andy Lutomirski wrote: > > One option would be to change the NMI entry code to move itself down 8 > bytes if this happens (came from kernel mode or sp == sp0 - 12, > perhaps). Hmm. That whole code currently depends on the stack setup being just a single instructio

Re: [PATCH v2] regmap: introduce regmap_name to fix syscon regmap trace events

2015-03-09 Thread Mark Brown
On Mon, Mar 09, 2015 at 12:20:13PM +0100, Philipp Zabel wrote: > This patch fixes a NULL pointer dereference when enabling regmap event > tracing in the presence of a syscon regmap, introduced by commit bdb0066df96e > ("mfd: syscon: Decouple syscon interface from platform devices"). > That patch in

Re: [PATCH] ASoC: wm5100: match wait_for_completion_timeout return type

2015-03-09 Thread Mark Brown
On Sun, Mar 08, 2015 at 06:57:07AM -0400, Nicholas Mc Guire wrote: > return type of wait_for_completion_timeout is unsigned long not int. An > appropriately named unsigned long is added and the assignment fixed up. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update

2015-03-09 Thread Mark Salyzyn
On 03/09/2015 04:17 AM, long.wanglong wrote: In the function ramoops_probe, the console_size, pmsg_size, ftrace_size may be update because the value is not the power of two. We should update the module parameter variables as well so they are visible through /sys/module/ramoops/parameters correctl

[PATCH] ASoC: cx20442: remove incorerct __exit markups

2015-03-09 Thread Dmitry Torokhov
Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: D

Re: [PCI] BUG: unable to handle kernel

2015-03-09 Thread Guenter Roeck
On 03/09/2015 11:09 AM, Murali Karicheri wrote: On 03/09/2015 01:34 PM, Guenter Roeck wrote: On 03/09/2015 10:03 AM, Murali Karicheri wrote: On 03/09/2015 12:07 PM, Guenter Roeck wrote: On 03/09/2015 08:53 AM, Murali Karicheri wrote: On 03/09/2015 10:44 AM, Bjorn Helgaas wrote: On Mon, Mar 9

Re: [PATCH] x86/fpu: drop_fpu() should not assume that tsk == current

2015-03-09 Thread Borislav Petkov
On Mon, Mar 09, 2015 at 07:06:47PM +0100, Oleg Nesterov wrote: > Yes... should I resend? Nah, already fixed up and uploaded to http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=tip-x86-fpu-urgent I'm going to collect the fpu urgent-only stuff there so that we don't lose track of the p

[PATCH] mtd: maps: sa1100-flash: remove incorrect __exit markups

2015-03-09 Thread Dmitry Torokhov
Even if bus is not hot-pluggable, the devices can be unbound from the driver via sysfs, so we should not be using __exit annotations on remove() methods. The only exception is drivers registered with platform_driver_probe() which specifically disables sysfs bind/unbind attributes. Signed-off-by: D

<    1   2   3   4   5   6   7   8   9   10   >