Re: [PATCH] block: Use BIT macro from include/linux/bitops.h

2015-05-20 Thread Jens Axboe
On 05/20/2015 01:41 PM, Jagan Teki wrote: On 21 May 2015 at 00:52, Jens Axboe wrote: On 05/18/2015 01:14 PM, Jagan Teki wrote: Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 31 I don't like it, I think it hurts readability. What do you mean by don't like, using kernel defined macro

Re: [PATCH 4/4] Staging: lustre: sparse lock warning fix

2015-05-20 Thread Dan Carpenter
In Smatch, it the equivalent warning is turned off by default because there are too many false positives, but you can enable it with the --spammy flag. kchecker --spammy drivers/staging/lustre/lustre/ptlrpc/nrs.c drivers/staging/lustre/lustre/ptlrpc/nrs.c:512 nrs_resource_put_safe() warn: 'spin_l

Re: [PATCH] block: Use BIT macro from include/linux/bitops.h

2015-05-20 Thread Jagan Teki
On 21 May 2015 at 00:52, Jens Axboe wrote: > On 05/18/2015 01:14 PM, Jagan Teki wrote: >> >> Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 31 > > > I don't like it, I think it hurts readability. What do you mean by don't like, using kernel defined macro instead of numerical assignments hut

Re: [PATCH v3] staging: rtl8712: Use ether_addr_copy() instead of memcpy()

2015-05-20 Thread Larry Finger
On 05/20/2015 01:41 PM, Jagan Teki wrote: On 18 May 2015 at 22:02, Jagan Teki wrote: Fixes Warning encounter this by applying checkpatch.pl against this file: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) pahole output for respective structures: - addr->sa_d

[PATCH] dma-buf: Minor coding style fixes

2015-05-20 Thread Jagan Teki
- WARNING: Missing a blank line after declarations - WARNING: line over 80 characters - WARNING: please, no space before tabs Signed-off-by: Jagan Teki Cc: Sumit Semwal --- drivers/dma-buf/dma-buf.c | 9 +++-- drivers/dma-buf/reservation.c | 9 ++--- drivers/dma-buf/seqno-fence.c |

Re: [PATCH v7 1/5] random: Blocking API for accessing nonblocking_pool

2015-05-20 Thread Stephan Mueller
Am Mittwoch, 20. Mai 2015, 20:49:45 schrieb Stephan Mueller: Hi Herbert, > > This is just a convoluted way of doing an uninterruptible sleep. > > Either make it uninterruptible or allow the function to return > > an error. > > Sorry, I overlooked the availability of wait_event. I was looking for

Re: [PATCH] Input:evdev - Fix to avoid the execution of same instruction in every iteration of for loop.

2015-05-20 Thread Dmitry Torokhov
Hi Shailendra, On Thu, May 21, 2015 at 12:35:46AM +0530, Shailendra Verma wrote: > Here in for loop the instruction "len / sizeof(compat_long_t)" is used > as a terminating condition which is executing (being computed) in every > iteration of for loop. Below is the armv7-a architecture assembly co

Re: [RFC v1 01/25] ARM, irq: Use irq_desc_get_xxx() to avoid redundant lookup of irq_desc

2015-05-20 Thread Russell King - ARM Linux
On Wed, May 20, 2015 at 05:59:49PM +0800, Jiang Liu wrote: > diff --git a/arch/arm/common/sa.c b/arch/arm/common/sa.c > index 5cc779c8e9c6..0d0844fa54c2 100644 > --- a/arch/arm/common/sa.c > +++ b/arch/arm/common/sa.c > @@ -200,7 +200,7 @@ static void > sa_irq_handler(unsigned

[PATCH] usb: ulpi: don't register drivers if bus doesn't exist

2015-05-20 Thread Sasha Levin
ULPI registers it's bus at module_init so if the bus fails to register, the module will fail to load and all will be well in the world. However, if the ULPI code is built-in rather than a module, the bus initialization may fail but we'd still try to register drivers later onto a non-existant bus,

Re: [PATCH] mtd: blktrans: change blktrans_getgeo rerurn value

2015-05-20 Thread Brian Norris
Hi Wenlin, In the subject: s/rerurn/return/ On Wed, May 13, 2015 at 02:29:16PM +0800, Wenlin Kang wrote: > Modify function blktrans_getgeo()'s return value to -ENXIO when > dev->tr->getgeo == NULL. > > We shouldn't make the return value to 0 when dev->tr->getgeo == NULL, > because the function

Re: [PATCH v3] staging: rtl8712: Use ether_addr_copy() instead of memcpy()

2015-05-20 Thread Dan Carpenter
On Thu, May 21, 2015 at 12:11:46AM +0530, Jagan Teki wrote: > Ping! No answer means that Greg hasn't gotten to it yet and no one else has an issue with it. Wait for 2 weeks before asking or 4 weeks if a merge window is open. regards, dan carpenter -- To unsubscribe from this list: send the line

Re: [PATCH 4/4] Staging: lustre: sparse lock warning fix

2015-05-20 Thread Dan Carpenter
On Wed, May 20, 2015 at 04:51:59PM +, Dilger, Andreas wrote: > On 2015/05/18, 3:21 PM, "Dan Carpenter" wrote: > > >On Mon, May 18, 2015 at 08:34:51PM +0200, Adrian Remonda wrote: > >> Fixed sparse warning: context imbalance in 'nrs_resource_put_safe' - > >> 'different lock contexts for basic

Re: [RESEND][ PATCH v3] irqchip/gicv3-its: ITS table size should not be smaller than PSZ

2015-05-20 Thread Thomas Gleixner
On Wed, 20 May 2015, Stuart Yoder wrote: > when allocating a device table, if the requested allocation > is smaller than the default granule size of the ITS > then, we need to round up to the default size > > Signed-off-by: Minghuan Lian > Signed-off-by: Stuart Yoder So who wrote that patch? T

Re: [PATCH 2/2] MIPS: MSA: bugfix of keeping MSA live context through clone or fork

2015-05-20 Thread Leonid Yegoshin
Cancel this, please. Reason - MSA registers are not supposed to be preserved through caller-called interface, including syscall. In other side, keeping MSA context is expensive. - Leonid. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to ma

Re: [PATCH] block: Use BIT macro from include/linux/bitops.h

2015-05-20 Thread Jens Axboe
On 05/18/2015 01:14 PM, Jagan Teki wrote: Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 31 I don't like it, I think it hurts readability. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [RFC PATCH 2/4] x86, mwaitt: introduce mwaitx idle with a configurable timer

2015-05-20 Thread Thomas Gleixner
On Wed, 20 May 2015, Borislav Petkov wrote: > On Wed, May 20, 2015 at 04:55:58PM +0100, One Thousand Gnomes wrote: > > > That's not what appears to be happening here though: the MWAITX will > > > return after the timeout. > > > > > > Which isn't really useful unless we use it to drive timers. >

[PATCH 1/2] dma: omap-dma: Fix line over 80 characters

2015-05-20 Thread Jagan Teki
This patch fixes line over 80 characters warninings while running checkpatch.pl Signed-off-by: Jagan Teki Cc: Dan Williams Cc: Vinod Koul --- drivers/dma/omap-dma.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap

[PATCH 2/2] dma: amba-pl08x: Fix line over 80 characters

2015-05-20 Thread Jagan Teki
This patch fixes line over 80 characters warninings while running checkpatch.pl Signed-off-by: Jagan Teki Cc: Dan Williams Cc: Vinod Koul --- drivers/dma/amba-pl08x.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-p

Re: [PATCH v4 0/3] Compile-time stack frame pointer validation

2015-05-20 Thread Jiri Kosina
On Wed, 20 May 2015, Peter Zijlstra wrote: > > I think it would be nice to have full DWARF unwind support for > > everything at some point. Unfortunately, I don't see any easy path to > > getting there. It doesn't help that AFAIK no one has ever proposed a > > usable in-kernel DWARF unwinder. >

Re: [PATCH 3/5] trace-cmd: lookup syscall names in profile

2015-05-20 Thread Josef Bacik
On 05/20/2015 03:01 PM, Steven Rostedt wrote: On Wed, 20 May 2015 14:56:17 -0400 Steven Rostedt wrote: On Wed, 20 May 2015 14:22:31 -0400 Josef Bacik wrote: I'll keep this as is, but I'm going to add code to check for this library, and go back to the default raw numbers if it doesn't exist.

[PATCH] Input:evdev - Fix to avoid the execution of same instruction in every iteration of for loop.

2015-05-20 Thread Shailendra Verma
Here in for loop the instruction "len / sizeof(compat_long_t)" is used as a terminating condition which is executing (being computed) in every iteration of for loop. Below is the armv7-a architecture assembly code with similar for loop having the same instruction in condition.Note that the instruct

Re: [PATCH 3/7] x86/intel_rdt: Add support for cache bit mask management

2015-05-20 Thread Thomas Gleixner
On Wed, 20 May 2015, Vikas Shivappa wrote: > On Mon, 18 May 2015, Thomas Gleixner wrote: > > > On Mon, 18 May 2015, Vikas Shivappa wrote: > > > On Fri, 15 May 2015, Thomas Gleixner wrote: > > > > > +static inline bool intel_rdt_update_cpumask(int cpu) > > > > > +{ > > > > > + } > > > > > > >

Sporadic 3.12.* panics on invalid function-by-pointer call

2015-05-20 Thread Mikhail Sennikovskii
Fellows, We are having sporadic panics of our 3.12.38 and 3.12.40 kernels, running on a 64-cpu host with AMD Opteron(tm) 6386 SE processors, which are presumably caused by a call on a corrupted function pointer stored in kernel .rodata or .data sections (e.g. fair_sched_class::task_tick). Both 3.1

Re: [PATCH 3/5] trace-cmd: lookup syscall names in profile

2015-05-20 Thread Steven Rostedt
On Wed, 20 May 2015 14:56:17 -0400 Steven Rostedt wrote: > On Wed, 20 May 2015 14:22:31 -0400 > Josef Bacik wrote: > > > > I'll keep this as is, but I'm going to add code to check for this > > > library, and go back to the default raw numbers if it doesn't exist. > > > > > > > Maybe we should

[PATCH v6 2/2] kconfig: add xenconfig defconfig helper

2015-05-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This lets you build a kernel which can support xen dom0 or xen guests on i386, x86-64 and arm64 by just using: make xenconfig You can start from an allnoconfig and then switch to xenconfig. This also splits out the options which are available currently to be built w

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-20 Thread Steven Rostedt
On Wed, 20 May 2015 11:29:55 -0700 Stephen Boyd wrote: > > I see no reason to spend to 4-8 bytes when spmi spec allows for maximum > > buffer size of 16. Do you suggest changing the API of read_cmd()? > > > > > Is that a maximum buffer size of 16 bytes? I'd prefer consistency > with the API th

[PATCH v6 1/2] kconfig: clarify kvmconfig is for kvm

2015-05-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We'll be adding options for xen as well. Cc: Josh Triplett Cc: Borislav Petkov Cc: Pekka Enberg Cc: David Rientjes Cc: Michal Marek Cc: Randy Dunlap Cc: penb...@kernel.org Cc: levinsasha...@gmail.com Cc: mtosa...@redhat.com Cc: fengguang...@intel.com Cc: David Vra

Re: [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios

2015-05-20 Thread Jeff Moyer
Ming Lin writes: > On Mon, May 18, 2015 at 9:52 AM, Jeff Moyer wrote: >> Ming Lin writes: >> >>> diff --git a/block/blk-core.c b/block/blk-core.c >>> index fd154b9..909f317 100644 >>> --- a/block/blk-core.c >>> +++ b/block/blk-core.c >>> @@ -617,6 +617,10 @@ struct request_queue *blk_alloc_queu

Re: [PATCH] mtd: cfi: Deiline large functions

2015-05-20 Thread Brian Norris
On Mon, May 18, 2015 at 12:58:40PM +0200, Denys Vlasenko wrote: > With this .config: http://busybox.net/~vda/kernel_config, > after uninlining these functions have sizes and callsite counts > as follows: Most of this is probably good, thanks. But I'm curious about one: > cfi_udelay(): 74 bytes, 2

Re: [PATCH 3/5] trace-cmd: lookup syscall names in profile

2015-05-20 Thread Steven Rostedt
On Wed, 20 May 2015 14:22:31 -0400 Josef Bacik wrote: > > I'll keep this as is, but I'm going to add code to check for this > > library, and go back to the default raw numbers if it doesn't exist. > > > > Maybe we should think about autoconf at some point? Thanks, Egad no! I hate autoconf. And

Re: [PATCH 2/7] timekeeping: Provide new API to get the current time resolution

2015-05-20 Thread Harald Geyer
John Stultz writes: > > I was thinking that the variable hrtimer_resolution, that Thomas > > introduced in > > https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/include/linux/hrtimer.h?h=timers/wip&id=03eeacdb07e2fdfc4ef311c2593286c92eba609c > > is meant to provide the same informatio

[PATCH v6 0/2] kconfig: add xenconfig

2015-05-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Michal Marek, Xen folks (David Vrabel, Konrad, Ian), which tree should these go through? This v6 addresses enabling xen on i386, x86-64 and arm64 starting from a 'make allnoconfig' setting. Luis R. Rodriguez (2): kconfig: clarify kvmconfig is for kvm kconfig: add x

Re: [RFC v1 15/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t

2015-05-20 Thread Robert Jarzmik
Jiang Liu writes: > diff --git a/arch/arm/mach-pxa/pcm990-baseboard.c > b/arch/arm/mach-pxa/pcm990-baseboard.c > index 2897da2a5df6..0d8331f8536e 100644 > --- a/arch/arm/mach-pxa/pcm990-baseboard.c > +++ b/arch/arm/mach-pxa/pcm990-baseboard.c > @@ -287,6 +287,7 @@ static struct irq_chip pcm990_i

Re: [PATCH 5/7] x86/intel_rdt: Software Cache for IA32_PQR_MSR

2015-05-20 Thread Thomas Gleixner
On Wed, 20 May 2015, Vikas Shivappa wrote: > On Fri, 15 May 2015, Thomas Gleixner wrote: > > > -static DEFINE_PER_CPU(struct intel_cqm_state, cqm_state); > > > +DEFINE_PER_CPU(struct intel_pqr_state, pqr_state); > > > > With CONFIG_PERF=n and CONFIG_CGROUP_RDT=y the linker will fail. > > copy fro

Re: [PATCH v7 1/5] random: Blocking API for accessing nonblocking_pool

2015-05-20 Thread Stephan Mueller
Am Donnerstag, 21. Mai 2015, 02:45:35 schrieb Herbert Xu: Hi Herbert, > On Wed, May 20, 2015 at 07:44:39PM +0200, Stephan Mueller wrote: > > + if (unlikely(nonblocking_pool.initialized == 0)) { > > + do { > > + rc = wait_event_interruptible(urandom_init_wait, > > +

Re: [PATCH] staging: rtl8188eu: core: Fix line over 80 characters

2015-05-20 Thread Greg Kroah-Hartman
On Thu, May 21, 2015 at 12:12:38AM +0530, Jagan Teki wrote: > On 18 May 2015 at 22:34, Jagan Teki wrote: > > This patch fixes line over 80 characters warninings while > > running checkpatch.pl - "WARNING: line over 80 characters" > > > > Signed-off-by: Jagan Teki > > Cc: Greg Kroah-Hartman > > C

Re: [PATCH v7 1/5] random: Blocking API for accessing nonblocking_pool

2015-05-20 Thread Herbert Xu
On Wed, May 20, 2015 at 07:44:39PM +0200, Stephan Mueller wrote: > > + if (unlikely(nonblocking_pool.initialized == 0)) { > + do { > + rc = wait_event_interruptible(urandom_init_wait, > + nonblocking_pool.initialized);

Re: [PATCH] block: Use BIT macro from include/linux/bitops.h

2015-05-20 Thread Jagan Teki
Ping! On 19 May 2015 at 00:44, Jagan Teki wrote: > Replace (1 << nr) to BIT(nr) where nr = 0, 1, 2 31 > > Signed-off-by: Jagan Teki > Cc: Wolfram Sang > Cc: Jens Axboe > --- > drivers/block/mg_disk.c | 10 +- > drivers/block/mtip32xx/mtip32xx.c | 14 +++--- > dr

Re: [RFC v1 25/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t

2015-05-20 Thread Thomas Gleixner
On Wed, 20 May 2015, Jiang Liu wrote: > On 2015/5/20 23:40, Thomas Gleixner wrote: > > On Wed, 20 May 2015, Jiang Liu wrote: > >> /* Chained IRQ handler for IPU error interrupt */ > >> -static void ipu_irq_err(unsigned int irq, struct irq_desc *desc) > >> +static void ipu_irq_err(struct irq_des

Re: [PATCH] staging: rtl8188eu: core: Fix line over 80 characters

2015-05-20 Thread Jagan Teki
On 18 May 2015 at 22:34, Jagan Teki wrote: > This patch fixes line over 80 characters warninings while > running checkpatch.pl - "WARNING: line over 80 characters" > > Signed-off-by: Jagan Teki > Cc: Greg Kroah-Hartman > Cc: Larry Finger > --- > drivers/staging/rtl8188eu/core/rtw_ap.c | 52 >

Re: [PATCH 0/7] Current queue for tip/timers/core

2015-05-20 Thread John Stultz
On Wed, May 20, 2015 at 10:19 AM, John Stultz wrote: > Hey Thomas, Ingo, > Just wanted to send you my current queue of items that I > have pending for tip/timers/core for 4.2 > > Let me know if you have any concerns or objections. > > thanks > -john > > Cc: Thomas Gleixner > Cc: Ingo Molnar >

Re: [PATCH v3] staging: rtl8712: Use ether_addr_copy() instead of memcpy()

2015-05-20 Thread Jagan Teki
On 18 May 2015 at 22:02, Jagan Teki wrote: > Fixes Warning encounter this by applying checkpatch.pl against this file: > Prefer ether_addr_copy() over memcpy() if the Ethernet addresses > are __aligned(2) > > pahole output for respective structures: > - addr->sa_data > struct sockaddr { >

Re: [PATCH v2 4/9] clocksource: mediatek: Use GPT as sched clock source

2015-05-20 Thread Stephen Boyd
On 05/20, Matthias Brugger wrote: > 2015-05-20 16:05 GMT+02:00 Yingjoe Chen : > > On Wed, 2015-05-20 at 13:02 +0200, Matthias Brugger wrote: > >> 2015-05-16 9:58 GMT+02:00 Yingjoe Chen : > >> > When cpu is in deep idle, arch timer will stop counting. Setup GPT as > >> > sched clock source so it can

[PATCH] clk:clk - Fix typo in comment.

2015-05-20 Thread Shailendra Verma
Signed-off-by: Shailendra Verma --- drivers/clk/clk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 459ce9d..2b2859f 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -2478,7 +2478,7 @@ void __clk_free_clk(struct clk *c

Re: [RFC v1 14/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t

2015-05-20 Thread Thomas Gleixner
On Wed, 20 May 2015, Jiang Liu wrote: > On 2015/5/20 23:25, Thomas Gleixner wrote: > > On Wed, 20 May 2015, Jiang Liu wrote: > >> --- a/include/linux/irqdesc.h > >> +++ b/include/linux/irqdesc.h > >> @@ -99,6 +99,11 @@ static inline struct irq_desc *irq_data_to_desc(struct > >> irq_data *data) >

Re: [RFC v1 14/25] genirq: Kill the first parameter 'irq' of irq_flow_handler_t

2015-05-20 Thread Thomas Gleixner
B1;2802;0cOn Wed, 20 May 2015, Jiang Liu wrote: > On 2015/5/20 23:25, Thomas Gleixner wrote: > > On Wed, 20 May 2015, Jiang Liu wrote: > >> --- a/include/linux/irqdesc.h > >> +++ b/include/linux/irqdesc.h > >> @@ -99,6 +99,11 @@ static inline struct irq_desc *irq_data_to_desc(struct > >> irq_data

Re: [PATCH 4/5] kconfig: Introduce "showif" to factor out conditions on visibility

2015-05-20 Thread josh
On Wed, May 20, 2015 at 12:00:13PM +0200, Paul Bolle wrote: > Hi Josh, > > On Thu, 2015-05-14 at 08:36 -0700, Josh Triplett wrote: > > kconfig implicitly creates a submenu whenever a series of symbols all > > have dependencies or prompt-visibility expressions that all depend on a > > preceeding sy

Re: [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios

2015-05-20 Thread Ming Lin
On Mon, May 18, 2015 at 9:52 AM, Jeff Moyer wrote: > Ming Lin writes: > >> diff --git a/block/blk-core.c b/block/blk-core.c >> index fd154b9..909f317 100644 >> --- a/block/blk-core.c >> +++ b/block/blk-core.c >> @@ -617,6 +617,10 @@ struct request_queue *blk_alloc_queue_node(gfp_t >> gfp_mask, i

Re: [PATCH] spmi: add command tracepoints for SPMI

2015-05-20 Thread Stephen Boyd
On 05/20, Ankit Gupta wrote: > On Tue, 19 May 2015 17:36:41 -0700 > Stephen Boyd wrote: > > On 05/18/15 14:51, Ankit Gupta wrote: > > > + > > > +TRACE_EVENT(spmi_read_end, > > > + TP_PROTO(u8 opcode, u8 sid, u16 addr, int ret, u8 len, > > > > Should "len" be size_t instead of u8? It would at leas

Re: [PATCH 3/5] trace-cmd: lookup syscall names in profile

2015-05-20 Thread Josef Bacik
On 05/20/2015 02:00 PM, Steven Rostedt wrote: On Fri, 8 May 2015 15:29:02 -0400 Josef Bacik wrote: When we profile syscall times we're just given the syscall number, not the name. This isn't helpful for human beings, so lookup the syscall names when we are printing out the information. This u

Re: [PATCH] smp/call: Detect stuck CSD locks

2015-05-20 Thread Chris J Arges
On Mon, May 11, 2015 at 04:00:03PM +0200, Ingo Molnar wrote: > > So potentially, CPU0 generated an interrupt that caused > > vcpu_enter_guest to be called on CPU1. However, when > > vmx_handle_external_intr was called, it didn't progress any further. > > So the IPI does look like to be lost in t

Re: [PATCH v3 03/11] block: allow __blk_queue_bounce() to handle bios larger than BIO_MAX_PAGES

2015-05-20 Thread Ming Lin
On Tue, May 19, 2015 at 1:44 AM, Christoph Hellwig wrote: > On Wed, May 06, 2015 at 11:34:13PM -0700, Ming Lin wrote: >> From: Kent Overstreet >> >> Allow __blk_queue_bounce() to handle bios with more than BIO_MAX_PAGES >> segments. Doing that, it becomes possible to simplify the block layer >> i

Re: [PATCH 08/11] KVM: implement multiple address spaces

2015-05-20 Thread Paolo Bonzini
On 20/05/2015 17:46, Radim Krčmář wrote: > I am a bit worried about the explosion that would happen if we wanted, > for example, per-VCPU address spaces Those would be very expensive. If we were to implement relocatable APIC base, we would have to do it in a different way than with memslots. >

Re: [c++std-parallel-1632] Re: Compilers and RCU readers: Once more unto the breach!

2015-05-20 Thread Paul E. McKenney
On Wed, May 20, 2015 at 04:54:51PM +0100, Andrew Haley wrote: > On 05/20/2015 04:46 PM, Will Deacon wrote: > > I'm not sure... you'd require the compiler to perform static analysis of > > loops to determine the state of the machine when they exit (if they exit!) > > in order to show whether or not

Re: [PATCH] arm: dts: Beaglebone i2c definitions

2015-05-20 Thread Tony Lindgren
* Tony Lindgren [150514 08:40]: > * Pantelis Antoniou [150513 01:05]: > > The beaglebone family of boards contain two I2C busses enabled. > > The first one with a baseboard identification EEPROM and a > > cape I2C bus. > > This seems safe to apply as the i2c2 pins are listed in the cape > specif

Re: [PATCH v3 01/11] block: make generic_make_request handle arbitrarily sized bios

2015-05-20 Thread Ming Lin
On Wed, May 20, 2015 at 5:44 AM, Christoph Hellwig wrote: > This needs the patch below for the blk-mq case with multiple queues. Will add it. > > Also I wonder why we really want to push this below ->make_request. > Moving it just outside ->make_request would make the callchain more > obvious an

Re: [PATCH 1/1] cifs: potential missing check for posix_lock_file_wait

2015-05-20 Thread Steve French
merged into cifs-2.6.git for-next On Fri, Apr 3, 2015 at 7:11 AM, Jeff Layton wrote: > On Tue, 24 Mar 2015 20:18:49 -0400 > Chengyu Song wrote: > >> posix_lock_file_wait may fail under certain circumstances, and its result is >> usually checked/returned. But given the complexity of cifs, I'm not

Re: Compilers and RCU readers: Once more unto the breach!

2015-05-20 Thread Paul E. McKenney
On Wed, May 20, 2015 at 04:46:17PM +0100, Will Deacon wrote: > On Wed, May 20, 2015 at 01:15:22PM +0100, Paul E. McKenney wrote: > > On Wed, May 20, 2015 at 12:47:45PM +0100, Will Deacon wrote: > > > On Wed, May 20, 2015 at 03:41:48AM +0100, Paul E. McKenney wrote: > > > > If a pointer is p

Re: [PATCH] ARM: dts: am437x-gp-evm: add DT nodes for ov2659 sensor

2015-05-20 Thread Tony Lindgren
* Tony Lindgren [150316 15:22]: > * Lad Prabhakar [150312 16:38]: > > From: "Lad, Prabhakar" > > > > this patch does the following: > > 1: adds DT node for fixed oscillator. > > 2: adds DT node entries for ov2659 sensor > > 3: adds remote-endpoint entry for VPFE. > > > > Signed-off-by: Lad, Pr

Re: [PATCH v3 00/11] simplify block layer based on immutable biovecs

2015-05-20 Thread Ming Lin
On Wed, May 20, 2015 at 5:48 AM, Christoph Hellwig wrote: > Passes test fine for me so far. You might also want to throw in the > following patch to make it more useful: I'll add it to next version. Thanks. > > --- > From a30035d4ae040723a6c94143db90231941d0caf7 Mon Sep 17 00:00:00 2001 > From

Re: [PATCH] regulator: max77686: fix gpio_enabled shift wrapping bug

2015-05-20 Thread Mark Brown
On Mon, May 18, 2015 at 10:01:03AM -0700, Joe Perches wrote: > The code should handle more than 32 bits here because "id" > can be a value up to MAX77686_REGULATORS (currently 34). Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH 3/5] trace-cmd: lookup syscall names in profile

2015-05-20 Thread Steven Rostedt
On Fri, 8 May 2015 15:29:02 -0400 Josef Bacik wrote: > When we profile syscall times we're just given the syscall number, not the > name. > This isn't helpful for human beings, so lookup the syscall names when we are > printing out the information. This uses the audit library to get this > info

Re: [PATCH 4/6] i2c-parport: use new parport device model

2015-05-20 Thread Jean Delvare
On Wed, 20 May 2015 22:44:52 +0530, Sudip Mukherjee wrote: > On Wed, May 20, 2015 at 05:49:07PM +0200, Wolfram Sang wrote: > > On Wed, May 20, 2015 at 08:57:00PM +0530, Sudip Mukherjee wrote: > > > static struct parport_driver i2c_parport_driver = { > > > - .name = "i2c-parport", > > > - .attach

Re: [PATCH RESEND] mach-omap2:Remove calls to deprecacted marco,PTR_RET in the files,fb.c and pmu.c

2015-05-20 Thread Tony Lindgren
* Nicholas Krause [150518 07:09]: > This removes two calls to the deprecated marco,PTR_RET in > the files,fb.c and pmu.c for the functions,omap_init_vrfb > and omap_init_pmu respectfully. Furthermore these are now > replaced by calling the correctly non deprecacted function, > PTR_ERR_OR_ZERO in b

Re: [PATCH 2/7] timekeeping: Provide new API to get the current time resolution

2015-05-20 Thread John Stultz
On Wed, May 20, 2015 at 10:53 AM, Harald Geyer wrote: > Hi John, > > John Stultz writes: >> From: Harald Geyer >> >> This patch series introduces a new function >> u32 ktime_get_resolution_ns(void) >> which allows to clean up some driver code. > > thanks for keeping track of this, but is this pat

Re: [PATCH] ARM: dts: omap3-gta04: Add GSM audio support

2015-05-20 Thread Tony Lindgren
* Marek Belisko [150507 12:36]: > Add voice audio card which is used for telephony on gta04 board. > gtm601 codec is UMTS modem with pcm interface which get samples from > microphone and provide data from other party side. Use simple audio card > to describe audio card. > > Signed-off-by: Marek B

Re: [PATCH V2] ARM: dts: omap5-uevm: Add Uart wakeup interrupt

2015-05-20 Thread Tony Lindgren
* Nishanth Menon [150515 15:18]: > UART3 wakeup takes place with iodaisy chain. enable the wakeup pin. > > Reported-by: Suman Anna > Signed-off-by: Nishanth Menon Applying into omap-for-v4.2/dt thanks. Tony > --- > > Test on linus master (f0897f4cc0fc) with 8250 driver: > http://pastebin.

Re: [EDT] [PATCH 1/1] Fix: hw watchpoint continually triggers callback

2015-05-20 Thread Will Deacon
On Mon, May 18, 2015 at 02:17:05PM +0100, Vaneet Narang wrote: > >Ok, so my first point shouldn't be a problem if we're just emulating the > >instruction. However, I still think there are corner cases. For example, > >imagine hitting a breakpoint on a ldr pc, [&foo] instruction where we've > >also

Re: [FYI] tux3: Core changes

2015-05-20 Thread David Lang
On Wed, 20 May 2015, Daniel Phillips wrote: On 05/20/2015 07:44 AM, Jan Kara wrote: Yeah, that's what I meant. If you create a function which manipulates page cache, you better make it work with other functions manipulating page cache. Otherwise it's a landmine waiting to be tripped by some u

Re: [PATCHv2] am335x-evm: add bluetooth support

2015-05-20 Thread Tony Lindgren
* Eyal Reizer [150504 05:43]: > From: Eliad Peller > > uart1 is used for connecting to wilink8 bluetooth subsystem. > add the needed muxes and definitions. > > Signed-off-by: Eliad Peller > Signed-off-by: Eyal Reizer Applying into omap-for-v4.2/dt thanks. Tony > --- > Changes in v2: > remo

Re: [PATCH 2/5] trace-cmd: group schedule stacktraces together with --merge

2015-05-20 Thread Josef Bacik
On 05/20/2015 01:36 PM, Steven Rostedt wrote: On Fri, 8 May 2015 15:29:01 -0400 Josef Bacik wrote: With --merge we want to be able to merge the scheduling information as well so we can see how the whole app spent its time. This is a little tricky because we have to sort based on comm instead

Re: [PATCH 2/7] timekeeping: Provide new API to get the current time resolution

2015-05-20 Thread Harald Geyer
Hi John, John Stultz writes: > From: Harald Geyer > > This patch series introduces a new function > u32 ktime_get_resolution_ns(void) > which allows to clean up some driver code. thanks for keeping track of this, but is this patch still useful? I was thinking that the variable hrtimer_resoluti

Re: [PATCH] ARM: dts: omap3-gta04: Add hdqw1 support

2015-05-20 Thread Tony Lindgren
* Marek Belisko [150428 13:55]: > Enable omap-hdq for battery fuel gauge access. > > Signed-off-by: Marek Belisko > Signed-off-by: H. Nikolaus Schaller Applying into omap-for-v4.2/dt thanks. Tony > --- > arch/arm/boot/dts/omap3-gta04.dtsi | 11 +++ > 1 file changed, 11 insertions(+)

Re: [PATCH 1/5] trace-cmd: add option to group like comms for profile

2015-05-20 Thread Josef Bacik
On 05/20/2015 01:31 PM, Steven Rostedt wrote: Finally have some time to look at this. On Fri, 8 May 2015 15:29:00 -0400 Josef Bacik wrote: When profiling large applications that have multiple children we really want to see the profile of the app all together. Add a --merge option to accompl

Re: [PATCH v3 1/2] serial_core: add pci uart early console support

2015-05-20 Thread Paul Bolle
On Wed, 2015-05-20 at 10:59 -0700, Bin Gao wrote: > The HAVE_EARLY_PCI entry should be actually in generic PCI layer, > i.e. drivers/pci, because it's a PCI feature but only some archs > (currently only x86) support it. > Then an arch with this feature could announce it in arch//Kconfig by: > selec

[PATCH v7 2/5] crypto: drbg - prepare for async seeding

2015-05-20 Thread Stephan Mueller
In order to prepare for the addition of the asynchronous seeding call, the invocation of seeding the DRBG is moved out into a helper function. In addition, a block of memory is allocated during initialization time that will be used as a scratchpad for obtaining entropy. That scratchpad is used for

[PATCH v7 1/5] random: Blocking API for accessing nonblocking_pool

2015-05-20 Thread Stephan Mueller
The added API calls provide a synchronous function call get_blocking_random_bytes where the caller is blocked until the nonblocking_pool is initialized. CC: Andreas Steffen CC: Theodore Ts'o CC: Sandy Harris Signed-off-by: Stephan Mueller --- drivers/char/random.c | 18 ++ in

[PATCH v7 4/5] crypto: drbg - use Jitter RNG to obtain seed

2015-05-20 Thread Stephan Mueller
During initialization, the DRBG now tries to allocate a handle of the Jitter RNG. If such a Jitter RNG is available during seeding, the DRBG pulls the required entropy/nonce string from get_random_bytes and concatenates it with a string of equal size from the Jitter RNG. That combined string is now

[PATCH v7 0/5] Seeding DRBG with more entropy

2015-05-20 Thread Stephan Mueller
Hi, as of now, the DRBG is only seeded from get_random_bytes. In various circumstances, the nonblocking_pool behind get_random_bytes may not be fully seeded from hardware events at the time the DRBG requires to be seeded. Based on the discussion in [1], the DRBG seeding is updated such that it doe

[PATCH v7 5/5] crypto: add jitterentropy RNG

2015-05-20 Thread Stephan Mueller
The CPU Jitter RNG provides a source of good entropy by collecting CPU executing time jitter. The entropy in the CPU execution time jitter is magnified by the CPU Jitter Random Number Generator. The CPU Jitter Random Number Generator uses the CPU execution timing jitter to generate a bit stream whi

[PATCH v7 3/5] crypto: drbg - add async seeding operation

2015-05-20 Thread Stephan Mueller
The async seeding operation is triggered during initalization right after the first non-blocking seeding is completed. As required by the asynchronous operation of random.c, a callback function is provided that is triggered by random.c once entropy is available. That callback function performs the

Re: [PATCH v3 1/2] serial_core: add pci uart early console support

2015-05-20 Thread Bin Gao
On Wed, May 20, 2015 at 11:16:25AM +0200, Paul Bolle wrote: > What I should have asked is: do you expect architectures other than X86 > to set HAVE_EARLY_PCI? Because then you should put that Kconfig entry in > a file reachable by all architectures. Say, in init/Kconfig or in > drivers/tty/serial/K

Re: [PATCH] locking: type cleanup when accessing fast_read_ctr

2015-05-20 Thread Oleg Nesterov
On 05/19, Nicholas Mc Guire wrote: > > I assumed it would not matter but did not see a simple way of getting it > type clean with unsigned either mainly due to the atomic_t being int and > val in update_fast_ctr() being passed as -1. Perhaps clear_fast_ctr() should have a comment to explain why it

Re: [PATCH] locking: type cleanup when accessing fast_read_ctr

2015-05-20 Thread Oleg Nesterov
On 05/19, Peter Zijlstra wrote: > > So the value is unsigned by purpose; that said we should never cross the > 2G I think, so it really doesn't matter much. Yes, thanks, this is on purpose. Actually I was asked to make it "unsigned" during the review, but I agree it looks better than "signed int"

Re: [PATCH] mce: fix fail to set 'monarchtimeout' via boot option

2015-05-20 Thread Borislav Petkov
On Wed, May 20, 2015 at 07:22:23PM +0800, Xie XiuQi wrote: > I use "mce=1,1000" in cmdline to change the monarch timeout, but > it does not work. > > The cause is that get_option() has parsed the ',' already, we need > not to check the ',' again. > > -- > get_option(): read an int from an opt

Re: [PATCH] mach-omap2:Remove calls to deprecacted marco,PTR_RET in the files,fb.c and pmu.c

2015-05-20 Thread Tony Lindgren
* Nicholas Krause [150509 21:58]: > This removes two calls to the deprecated marco,PTR_RET in > the files,fb.c and pmu.c for the functions,omap_init_vrfb > and omap_init_pmu respectfully. Furthermore these are now > replaced by calling the correctly non deprecacted function, > PTR_ERR_OR_ZERO in b

Re: [PATCH 2/5] trace-cmd: group schedule stacktraces together with --merge

2015-05-20 Thread Steven Rostedt
On Fri, 8 May 2015 15:29:01 -0400 Josef Bacik wrote: > With --merge we want to be able to merge the scheduling information as well so > we can see how the whole app spent its time. This is a little tricky because > we > have to sort based on comm instead of pid. It works out well enough becaus

Re: [PATCH 4/6] i2c-parport: use new parport device model

2015-05-20 Thread Wolfram Sang
> > > static struct parport_driver i2c_parport_driver = { > > > - .name = "i2c-parport", > > > - .attach = i2c_parport_attach, > > > - .detach = i2c_parport_detach, > > > + .name = "i2c-parport", > > > + .match_port = i2c_parport_attach, > > > + .detach = i2c_parport_detac

Re: [PATCH 6/6] MAINTAINERS: maintain parport

2015-05-20 Thread Sudip Mukherjee
On Wed, May 20, 2015 at 09:28:16AM -0700, Joe Perches wrote: > On Wed, 2015-05-20 at 17:46 +0200, Richard Weinberger wrote: > > On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee > > wrote: > > > Lets give the parport subsystem a proper name and start > > > maintaining the files. > > > > Excuse me,

Re: [PATCH 1/5] trace-cmd: add option to group like comms for profile

2015-05-20 Thread Steven Rostedt
Finally have some time to look at this. On Fri, 8 May 2015 15:29:00 -0400 Josef Bacik wrote: > When profiling large applications that have multiple children we really want > to > see the profile of the app all together. Add a --merge option to accomplish > this for profile. This matches even

Re: [PATCH v4 0/3] Compile-time stack frame pointer validation

2015-05-20 Thread Peter Zijlstra
On Wed, May 20, 2015 at 09:03:37AM -0700, Andy Lutomirski wrote: > I think it would be nice to have full DWARF unwind support for > everything at some point. Unfortunately, I don't see any easy path to > getting there. It doesn't help that AFAIK no one has ever proposed a > usable in-kernel DWARF

Re: [PATCH v5 12/21] clk: tegra: pll: Add specialized logic for T210

2015-05-20 Thread Benson Leung
On Wed, May 20, 2015 at 10:24 AM, Rhyland Klein wrote: > No, this was intentional. tegra_clk_register_pllss isn't used on > Tegra210, it adds its own version "register_clk_register_pllss_tegra210" > which it uses and it doesn't need the tegra_clk_pllss_ops either. So it > should be fine without th

Re: [PATCH v5 12/21] clk: tegra: pll: Add specialized logic for T210

2015-05-20 Thread Rhyland Klein
On 5/13/2015 4:59 PM, Benson Leung wrote: > On Tue, May 12, 2015 at 10:23 AM, Rhyland Klein wrote: >> On Tegra210 SoC's, the logic to enable several of the plls is different >> from previous generations. Therefore, add registeration functions specific > > s/registeration/registration > >> to Teg

Re: [PATCH 3/7] x86/intel_rdt: Add support for cache bit mask management

2015-05-20 Thread Vikas Shivappa
On Mon, 18 May 2015, Thomas Gleixner wrote: On Mon, 18 May 2015, Vikas Shivappa wrote: On Fri, 15 May 2015, Thomas Gleixner wrote: +static inline bool intel_rdt_update_cpumask(int cpu) +{ + } You must be kidding. the rapl and cqm use similar code. You want me to keep a seperate pac

RE: [Linux-nvdimm] [PATCH v2 19/20] nd_btt: atomic sector updates

2015-05-20 Thread Elliott, Robert (Server Storage)
> -Original Message- > From: dan.j.willi...@gmail.com [mailto:dan.j.willi...@gmail.com] On > Behalf Of Dan Williams > Sent: Saturday, May 16, 2015 10:22 PM > To: Elliott, Robert (Server Storage) > Cc: linux-nvd...@lists.01.org; Neil Brown; Greg KH; Dave Chinner; linux- > ker...@vger.kerne

[PATCH 1/7] time: make sure tz_minuteswest is set to a valid value when setting time

2015-05-20 Thread John Stultz
From: Sasha Levin Invalid values may overflow later, leading to undefined behaviour when multiplied by 60 to get the amount of seconds. Cc: Thomas Gleixner Cc: Ingo Molnar Signed-off-by: Sasha Levin Signed-off-by: John Stultz --- kernel/time/time.c | 4 1 file changed, 4 insertions(+)

Re: [PATCH v4 0/3] Compile-time stack frame pointer validation

2015-05-20 Thread Josh Poimboeuf
On Wed, May 20, 2015 at 09:59:18AM -0700, Linus Torvalds wrote: > On Wed, May 20, 2015 at 9:25 AM, Josh Poimboeuf wrote: > > On Wed, May 20, 2015 at 09:03:37AM -0700, Andy Lutomirski wrote: > >> > >> I've never quite understood what the '?' means. > > > > It basically means "here's a function addr

[PATCH 3/7] time: Rework debugging variables so they aren't global

2015-05-20 Thread John Stultz
Ingo suggested that the timekeeping debugging variables recently added should not be global, and should be tied to the timekeeper's read_base. Thus this patch implements that suggestion. This version is differnet from the earlier versions as it keeps the variables in the timekeeper structure rath

RE: [PATCH] regmap: add virtual PMIC IPC bus support

2015-05-20 Thread Yang, Fei
>> The detail is >> Beside pmic core driver itself, there are many pmic function device >> dirvers, such as gpio, theremal, charger, bcu ..., will use this regmap api >> to access registers. > This sounds like this is a single device, not a generic bus. Well, yes this is more like a bridge to th

Re: [PATCHv2 4/4] DTS: ARM: OMAP3-N900: Add lis3lv02d support

2015-05-20 Thread Tony Lindgren
* Sebastian Reichel [150514 15:41]: > Hi Tony, > > On Fri, Mar 27, 2015 at 03:39:46PM +0100, Sebastian Reichel wrote: > > This adds support for the N900's accelerometer to > > the Nokia N900 DTS file. > > > > Signed-off-by: Sebastian Reichel > > Acked-by: Tony Lindgren > > --- > > Quote from T

<    1   2   3   4   5   6   7   8   9   10   >