Re: [PATCH] perf trace: fix documentation for -i

2015-11-05 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 04, 2015 at 09:21:46AM -0800, Peter Feiner escreveu: > The -i flag was incorrectly listed as a short flag for --no-inherit. > It should have only been listed as a short flag for --input. > > This documentation error has existed since the --input flag was > introduced in

Re: [PATCH v6 14/17] aarch64: ilp32: use generic stat64 structure

2015-11-05 Thread Arnd Bergmann
On Tuesday 03 November 2015 02:30:43 Yury Norov wrote: > Generic 32-bit and AARCH32 stat64 structures has same names. > ILP32 needs generic stat64. So we can either make ILP32 mutual > exclusive with AARCH32, or introduce __stat64, and where needed, > cast stat64 to it with #define. > > Second

Re: [Linaro-acpi] [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-05 Thread Timur Tabi
Fu Wei wrote: SBSA 2.3 Page 23 : Note: the watchdog offset register is 32 bits wide. This gives a maximum watch period of around 10s at a system counter frequency of 400MHz. If a larger watch period is required then the compare value can be programmed directly into the compare value register.

RE: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread 平松雅巳 / HIRAMATU,MASAMI
From: Wang Nan [mailto:wangn...@huawei.com] > >It is possible that find_perf_probe_point_from_map() fails to find >symbol but still returns 0 because of an small error when coding: >find_perf_probe_point_from_map() set 'ret' to error code at first, >but also use it to hold return value of

Re: [RFC PATCH 3/3] sched: introduce synchronized idle injection

2015-11-05 Thread Peter Zijlstra
On Tue, Nov 03, 2015 at 02:31:20PM +0100, Peter Zijlstra wrote: > > @@ -5136,6 +5148,16 @@ pick_next_task_fair(struct rq *rq, struct > > task_struct *prev) > > struct task_struct *p; > > int new_tasks; > > > > +#ifdef CONFIG_CFS_IDLE_INJECT > > + if (cfs_rq->force_throttled && > > +

Re: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Linus Walleij
On Thu, Nov 5, 2015 at 2:40 PM, Linus Walleij wrote: > On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada > wrote: > >> ARCH_SUNXI selects RESET_CONTROLLER. >> The dependency "depends on RESET_CONTROLLER" is already met. >> >> Signed-off-by: Masahiro Yamada > > NACK, this pin controller needs

Re: perf related lockdep bug

2015-11-05 Thread Paul E. McKenney
On Thu, Nov 05, 2015 at 03:46:07AM +0100, Andi Kleen wrote: > On Wed, Nov 04, 2015 at 04:55:28PM -0800, Paul E. McKenney wrote: > > On Wed, Nov 04, 2015 at 09:58:36PM +0100, Andi Kleen wrote: > > > > > > I tested my perf stress workload with the patch applied on 4.3, > > > unfortunately got a

Re: [PATCH 1/7] doc:bindings:Add document for mfd hi665x PMIC

2015-11-05 Thread Mark Brown
On Thu, Nov 05, 2015 at 09:34:42PM +0800, Chen Feng wrote: Please use subject lines matching the style for the subsystem. This makes it easier for people to identify relevant patches. > +- #interrupt-cells: Should be 2, two cells are needed for irq. > +- interrupt-controller: hi655x has

Re: [Xen-devel] Linux 4.4 MW: Boot under Xen fails with CONFIG_DEBUG_WX enabled: RIP: ptdump_walk_pgd_level_core

2015-11-05 Thread Sander Eikelenboom
Thursday, November 5, 2015, 2:53:40 PM, you wrote: > On 11/05/2015 04:13 AM, Sander Eikelenboom wrote: >> >> It makes "cat /sys/kernel/debug/kernel_page_tables" work and >> prevents a kernel with CONFIG_DEBUG_WX=y from crashing at boot. > Great. Our nightly runs also failed spectacularly due to

Re: [Linaro-acpi] [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-05 Thread Fu Wei
Hi Timur On 5 November 2015 at 21:47, Timur Tabi wrote: > Guenter Roeck wrote: >> >> I would feel much more comfortable if the driver would just use the >> standard >> watchdog timeout and live with (worst case) 20 seconds timeout for now. > > > Actually, I'm wondering where the 20 seconds comes

Re: staging: most: Delete an unnecessary check before the function call "module_put"

2015-11-05 Thread SF Markus Elfring
> Please stop sending these patches for drivers/staging. Will further contributors take another look at similar update suggestions? > You are welcome to send them for other subsystems Thanks for this suggestion. > which I don't care about. I am curious if other software developers will give

Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

2015-11-05 Thread Mika Westerberg
On Thu, Nov 05, 2015 at 08:34:44PM +0800, Xiangliang Yu wrote: > Because of some hardware limitation, AMD I2C controller can't > trigger next interrupt if interrupt status has been changed > after clearing interrupt status bits. Then, I2C will lost > interrupt and IO timeout. > > According to

Re: [PATCH 1/4] arm64: dts: Reserve memory regions for hi6220

2015-11-05 Thread Leo Yan
On Thu, Oct 29, 2015 at 04:33:01PM +0800, Leo Yan wrote: > On Wed, Oct 28, 2015 at 11:32:29PM -0500, Rob Herring wrote: > > On Fri, Oct 9, 2015 at 9:20 AM, Leo Yan wrote: > > > On Fri, Oct 09, 2015 at 08:50:13AM -0500, Rob Herring wrote: > > >> On Fri, Oct 9, 2015 at 8:30 AM, Mark Rutland > >

Re: [PATCH v6 11/17] ptrace: Allow compat to use the native siginfo

2015-11-05 Thread Arnd Bergmann
On Tuesday 03 November 2015 02:30:40 Yury Norov wrote: > From: Andrew Pinski > > Set COMPAT_USE_NATIVE_SIGINFO to be true for non AARCH32 tasks. > > With ARM64 ILP32 ABI, we want to use the non-compat > siginfo as we want to simplify signal handling for this new ABI. > This patch just adds a

Re: [Xen-devel] Linux 4.4 MW: Boot under Xen fails with CONFIG_DEBUG_WX enabled: RIP: ptdump_walk_pgd_level_core

2015-11-05 Thread Boris Ostrovsky
On 11/05/2015 04:13 AM, Sander Eikelenboom wrote: It makes "cat /sys/kernel/debug/kernel_page_tables" work and prevents a kernel with CONFIG_DEBUG_WX=y from crashing at boot. Great. Our nightly runs also failed spectacularly due to this bug. It now does give a warning about an insecure W+X

Re: [Bugfix v4] PCI, ACPI: Fix regressions caused by resource_size_t overflow with 32-bit kernel

2015-11-05 Thread Tomasz Nowicki
On 05.11.2015 14:24, Jiang Liu wrote: On 2015/11/5 20:53, Tomasz Nowicki wrote: On 02.11.2015 16:27, Tomasz Nowicki wrote: On 08.07.2015 09:26, Jiang Liu wrote: Zoltan Boszormenyi reported this regression: "There's a Realtek RTL8111/8168/8411 (PCI ID 10ec:8168, Subsystem ID

Re: [PATCH] staging: most: Delete an unnecessary check before the function call "module_put"

2015-11-05 Thread Dan Carpenter
Relying on hidden sanity checks makes the code harder to read. A human being cannot remember which functions have sanity checks and which do not. These sorts of patches are easy to generate automatically but they make the code worse. There are so many *better* things to do instead of focusing

Re: [PATCH v6 13/17] arm64:ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it

2015-11-05 Thread Arnd Bergmann
On Tuesday 03 November 2015 02:30:42 Yury Norov wrote: > From: Andrew Pinski > > Add a separate syscall-table for ILP32, which dispatches either to native > LP64 system call implementation or to compat-syscalls, as appropriate. The uapi/asm-generic/unistd.h already contains a list of compat

[PATCH 2/7] doc:bindings:Document for mtcmos regulator on hi6220 SoC

2015-11-05 Thread Chen Feng
Add Document for mtcmos driver on hi6220 SoC Signed-off-by: Chen Feng Signed-off-by: Fei Wang --- .../bindings/regulator/hisilicon,hi6220-mtcmos.txt | 32 ++ 1 file changed, 32 insertions(+) create mode 100644

[PATCH 6/7] regulator: hisilicon: Add hi655x pmic voltage regulator driver

2015-11-05 Thread Chen Feng
Add driver support for HiSilicon Hi655x voltage regulators. Signed-off-by: Chen Feng Signed-off-by: Fei Wang --- drivers/regulator/Kconfig | 13 ++ drivers/regulator/Makefile | 2 + drivers/regulator/hi655x-regulator.c | 246

Re: [PATCH] PCI: rcar (usb): DT can override default window settings

2015-11-05 Thread Rob Herring
On Tue, Nov 03, 2015 at 04:19:26PM +, Phil Edworthy wrote: > If the dtb specifies dma-ranges, we use those values. Otherwise, we > default to the values that were previously hardcoded into the driver. > > Signed-off-by: Phil Edworthy > --- > .../devicetree/bindings/pci/pci-rcar-gen2.txt

[PATCH 5/7] regulator: add driver for mtcmos voltage regulator on hi6220 SoC

2015-11-05 Thread Chen Feng
Add driver to support mtcmos on hi6220 Signed-off-by: Chen Feng Signed-off-by: Fei Wang --- drivers/regulator/hi6220-mtcmos.c | 245 ++ 1 file changed, 245 insertions(+) create mode 100644 drivers/regulator/hi6220-mtcmos.c diff --git

Re: [Linaro-acpi] [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-05 Thread Timur Tabi
Guenter Roeck wrote: I would feel much more comfortable if the driver would just use the standard watchdog timeout and live with (worst case) 20 seconds timeout for now. Actually, I'm wondering where the 20 seconds comes from. When I load my driver on our hardware, it calculates a maximum

Re: [PATCH] mm, hugetlb: use memory policy when available

2015-11-05 Thread Vlastimil Babka
On 10/20/2015 09:53 PM, Dave Hansen wrote: > From: Dave Hansen > > I have a hugetlbfs user which is never explicitly allocating huge pages > with 'nr_hugepages'. They only set 'nr_overcommit_hugepages' and then let > the pages be allocated from the buddy allocator at fault time. > > This

Re: [Linaro-acpi] [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-05 Thread Timur Tabi
Fu Wei wrote: (1)It is not new. pre-timeout concept has been used by two drivers before this driver. and this concept has been in kernel documentation. It's "new" in that it's a new infrastructure. The private API of two other drivers doesn't count. (1) if we don't, for this two stages

[PATCH 3/7] doc:bindings:Document for hi655x pmic driver

2015-11-05 Thread Chen Feng
Add Document for hi655x pmic driver Signed-off-by: Chen Feng Signed-off-by: Fei Wang --- .../regulator/hisilicon,hi655x-regulator.txt | 50 ++ 1 file changed, 50 insertions(+) create mode 100644

Re: [PATCH] w1: w1_process() is not freezable kthread

2015-11-05 Thread Evgeniy Polyakov
Hi 28.10.2015, 08:26, "Jiri Kosina" : > On Tue, 27 Oct 2015, Evgeniy Polyakov wrote: > >>  > w1_process() calls try_to_freeze(), but the thread doesn't mark itself >>  > freezable through set_freezable(), so the try_to_freeze() call is useless. >> >>  I believe it is better to mark it freezable,

[PATCH 0/7] Add Support for Hi6220 PMIC Hi6553 MFD Core

2015-11-05 Thread Chen Feng
The patch sets add support for Hi6220 PMIC Hi655x MFD core and its regulator driver. Current testing and support board is Hikey which is one of 96boards. It is an arm64 open source board. For more information about this board, please access https://www.96boards.org. This is hardware layout

[PATCH] staging: most: Delete an unnecessary check before the function call "module_put"

2015-11-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Nov 2015 14:34:43 +0100 The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/7] doc:bindings:Add document for mfd hi665x PMIC

2015-11-05 Thread Chen Feng
Add document for mfd driver hi655x pmic driver Signed-off-by: Chen Feng Signed-off-by: Fei Wang --- .../devicetree/bindings/mfd/hisilicon,hi655x.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt

Re: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Linus Walleij
On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada wrote: > ARCH_SUNXI selects RESET_CONTROLLER. > The dependency "depends on RESET_CONTROLLER" is already met. > > Signed-off-by: Masahiro Yamada NACK, this pin controller needs that as dependency, I don't worry that it's overspecified. They both

[PATCH 4/7] mfd: hi655x: Add hi665x pmic driver

2015-11-05 Thread Chen Feng
Add pmic driver to support hisilicon hi665x pmic. Signed-off-by: Chen Feng Signed-off-by: Fei Wang --- drivers/mfd/Kconfig | 9 ++ drivers/mfd/Makefile| 1 + drivers/mfd/hi655x-pmic.c | 315

[PATCH 7/7] arm64: dts: Add mtcmos and pmic node for hi6220 HiKey board

2015-11-05 Thread Chen Feng
Add dts node for hi665x pmic and hi6220 mtcmos driver Signed-off-by: Chen Feng Signed-off-by: Fei Wang --- arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 210 ++ 1 file changed, 210 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi

Re: [RFC PATCH v6 00/17] ILP32 for ARM64

2015-11-05 Thread Andrew Pinski
On Thu, Nov 5, 2015 at 7:36 PM, Andreas Schwab wrote: > Yury Norov writes: > >> v6: >> - time_t, __kenel_off_t and other types turned to be 32-bit >>for compatibility reasons (after v5 discussion); > > Are the updated glibc patches available somewhere? Not in an useful form right now but i

Re: [PATCH 01/29] pci: Decouple quirks.c from i915_reg.h

2015-11-05 Thread Chris Wilson
On Wed, Nov 04, 2015 at 11:19:49PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > i915 register defines are going to become type safe, so going forward > the register defines can't be used as straight numbers. Since quirks.c > needs just a few extra register defines from

Re: [Outreachy kernel] [PATCH v2] firewire: Replace timeval with timespec64

2015-11-05 Thread Stefan Richter
On Oct 22 Arnd Bergmann wrote: > On Thursday 22 October 2015 04:05:00 Amitoj Kaur Chawla wrote: > > 32 bit systems using 'struct timeval' will break in the year 2038, so > > we replace the code appropriately. However, this driver is not broken > > in 2038 since we are using only the microseconds

Re: [for-next][PATCH] tracefs: Fix refcount imbalance in start_creating()

2015-11-05 Thread Steven Rostedt
Forgot to Cc Daniel. -- Steve On Thu, 5 Nov 2015 08:29:33 -0500 Steven Rostedt wrote: > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git > for-next > > Head SHA1: d227c3ae4e94e5eb11dd780a811f59e1a7b74ccd > > > Daniel Borkmann (1): > tracefs: Fix refcount

[for-next][PATCH] tracefs: Fix refcount imbalance in start_creating()

2015-11-05 Thread Steven Rostedt
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next Head SHA1: d227c3ae4e94e5eb11dd780a811f59e1a7b74ccd Daniel Borkmann (1): tracefs: Fix refcount imbalance in start_creating() fs/tracefs/inode.c | 6 +- 1 file changed, 5 insertions(+), 1

Re: [PATCH] mm: slab: Only move management objects off-slab for sizes larger than KMALLOC_MIN_SIZE

2015-11-05 Thread Andrew Morton
On Thu, 5 Nov 2015 11:50:35 + Catalin Marinas wrote: > Commit 8fc9cf420b36 ("slab: make more slab management structure off the > slab") enables off-slab management objects for sizes starting with > PAGE_SIZE >> 5. This means 128 bytes for a 4KB page configuration. > However, on systems

Re: [PATCH 1/1] staging: rdma: hfi1 : Prefer using the BIT macro

2015-11-05 Thread Leon Romanovsky
On Thu, Nov 05, 2015 at 05:28:03PM +0530, Sunny Kumar wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro > > Signed-off-by: Sunny Kumar > --- > drivers/staging/rdma/hfi1/user_sdma.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > /* Last packet in the

Re: ptrace and pseudoterminals

2015-11-05 Thread Peter Hurley
On 11/04/2015 02:43 PM, Oleg Nesterov wrote: > On 11/04, Peter Hurley wrote: >> >> Hi Pavel, >> >> On 11/03/2015 06:16 PM, Pavel Labath wrote: >>> Hello Oleg, everyone, >>> >>> I have noticed something, which may be considered a race in the >>> interaction of ptrace and pseudoterminal interfaces.

How to mark suspicious code?

2015-11-05 Thread Ivan Safonov
Hi all! How can I mark suspicious code, if I can not fix it? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [Bugfix v4] PCI, ACPI: Fix regressions caused by resource_size_t overflow with 32-bit kernel

2015-11-05 Thread Jiang Liu
On 2015/11/5 20:53, Tomasz Nowicki wrote: > On 02.11.2015 16:27, Tomasz Nowicki wrote: >> On 08.07.2015 09:26, Jiang Liu wrote: >>> Zoltan Boszormenyi reported this regression: >>>"There's a Realtek RTL8111/8168/8411 (PCI ID 10ec:8168, Subsystem ID >>> 1565:230e) network chip on the

[PATCH] mfd: syscon: check 'property' before of_node_put

2015-11-05 Thread Peng Fan
When 'property' is not NULL, of_parse_phandle will return the node pointer with refcount incremented. So when of_node_put, also need to check property. Signed-off-by: Peng Fan Cc: Lee Jones Cc: Arnd Bergmann --- drivers/mfd/syscon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH] perf tools: Change FEATURE-DUMP to FEATURE-DUMP.libbpf for lib bpf

2015-11-05 Thread Arnaldo Carvalho de Melo
Em Thu, Nov 05, 2015 at 02:56:34PM +0800, Yunlong Song escreveu: > Commit ed63f34c026e9a60d17fa750ecdfe3f600d49393 ("perf tools: Make perf > depend on libbpf") dynamically creates FEATURE-DUMP.libbpf during the > perf building, but the .gitignore under tools/lib/bpf/ mistakes > FEATURE-DUMP.libbpf

[PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread Wang Nan
It is possible that find_perf_probe_point_from_map() fails to find symbol but still returns 0 because of an small error when coding: find_perf_probe_point_from_map() set 'ret' to error code at first, but also use it to hold return value of kernel_get_symbol_address_by_name(). This patch resets

[PATCH 1/2] perf probe: Only call probe_file__get_events() when fd is valid

2015-11-05 Thread Wang Nan
In system with kprobe enabled but uprobe turned off, 'perf probe -d' causes segfault because it calls probe_file__get_events() with a negative fd (when deleting uprobe events). This patch validates fds before calling probe_file__get_events(). Signed-off-by: Wang Nan Cc: Arnaldo Carvalho de Melo

[PATCH 0/2] perf tools: Two bugfixs related to perf probe

2015-11-05 Thread Wang Nan
I found two bugs in perf probe related code. This two patches fix them. Wang Nan (2): perf probe: Only call probe_file__get_events() when fd is valid perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success tools/perf/builtin-probe.c| 12 ++--

[PATCH v4 4/5] net: stmmac: Fix simple style problem

2015-11-05 Thread LABBE Corentin
This patch fix the following warnings: - braces {} should be used on all arms of this statement - Prefer seq_puts to seq_printf - No space is necessary after a cast - Missing a blank line after declarations - Please don't use multiple blank lines - Comparison to NULL could be written - networking

[PATCH v4 3/5] net: stmmac: remove some __func__ printing

2015-11-05 Thread LABBE Corentin
Now that stmmac use netdev_xxx, some __func__ are not necessary since their use was to clearly identify which driver was logging. Moreover, as pointed by Joe Perches, using __func__ in xxx_dbg functions is relatively low value and dynamic debug can add it. This patch remove __func__ where such

[PATCH v4 2/5] net: stmmac: replace hardcoded function name by __func__

2015-11-05 Thread LABBE Corentin
Some printing have the function name hardcoded. It is better to use __func__ instead. Signed-off-by: LABBE Corentin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

[PATCH v4 5/5] net: stmmac: replace if (netif_msg_type) by their netif_xxx counterpart

2015-11-05 Thread LABBE Corentin
As sugested by Joe Perches, we could replace all if (netif_msg_type(priv)) dev_xxx(priv->devices, ...) by the simplier macro netif_xxx(priv, hw, priv->dev, ...) Signed-off-by: LABBE Corentin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 58 ++- 1 file changed, 25

[PATCH v4] stmmac: improve logging

2015-11-05 Thread LABBE Corentin
Hello This patch series try to improve logging of the stmmac driver. Changes since v3 - Fix a missing comma for letting patch to be used atomaticly. Changes since v2 - Rollback to dev_ for some early init printing - rebased on 4.4-rc1 Changes since v1 - Use netdev_xxx instead of dev_xxx - Use

[PATCH v4 1/5] net: stmmac: replace all pr_xxx by their netdev_xxx counterpart

2015-11-05 Thread LABBE Corentin
The stmmac driver use lots of pr_xxx functions to print information. This is bad since we cannot know which device logs the information. (moreover if two stmmac device are present) Furthermore, it seems that it assumes wrongly that all logs will always be subsequent by using a dev_xxx then some

Re: [RFC PATCH 0/3]perf/core: extend perf_reg and perf_sample_regs_intr

2015-11-05 Thread Peter Zijlstra
On Thu, Nov 05, 2015 at 02:16:15AM +0530, Madhavan Srinivasan wrote: > Second patch updates struct arch_misc_reg for arch/powerpc with pmu registers > and adds offsetof macro for the same. It extends perf_reg_value() > to use reg idx to decide on struct to return value from. Why; what's in those

Re: [PATCH 4/4] mm: prepare page_referenced() and page_idle to new THP refcounting

2015-11-05 Thread Kirill A. Shutemov
On Thu, Nov 05, 2015 at 03:53:54PM +0300, Vladimir Davydov wrote: > On Thu, Nov 05, 2015 at 02:36:06PM +0200, Kirill A. Shutemov wrote: > > On Thu, Nov 05, 2015 at 03:07:26PM +0300, Vladimir Davydov wrote: > > > @@ -849,30 +836,23 @@ static int page_referenced_one(struct page *page, > > > struct

Re: [PATCH 2/3] staging: lustre: Delete an unnecessary variable initialisation in class_register_type()

2015-11-05 Thread Dan Carpenter
Looks good. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 1/3] staging: lustre: Delete unnecessary checks before two function calls

2015-11-05 Thread Dan Carpenter
I don't like these patches because relying on hidden sanity checks makes the code harder to read. I am CC'd on all these patches because of kernel-janitors and normally I ignore them but this is drivers/staging so I am invested in this code. Feel free to send them to other subsystems though.

Re: [PATCH 4/4] mm: prepare page_referenced() and page_idle to new THP refcounting

2015-11-05 Thread Vladimir Davydov
On Thu, Nov 05, 2015 at 02:36:06PM +0200, Kirill A. Shutemov wrote: > On Thu, Nov 05, 2015 at 03:07:26PM +0300, Vladimir Davydov wrote: > > @@ -849,30 +836,23 @@ static int page_referenced_one(struct page *page, > > struct vm_area_struct *vma, > > if (pmd_page(*pmd) != page) > >

Re: [Bugfix v4] PCI, ACPI: Fix regressions caused by resource_size_t overflow with 32-bit kernel

2015-11-05 Thread Tomasz Nowicki
On 02.11.2015 16:27, Tomasz Nowicki wrote: On 08.07.2015 09:26, Jiang Liu wrote: Zoltan Boszormenyi reported this regression: "There's a Realtek RTL8111/8168/8411 (PCI ID 10ec:8168, Subsystem ID 1565:230e) network chip on the mainboard. After the r8169 driver loaded the IRQs in the

Re: [PATCH v2 1/2] ASoC: codec: Inno codec driver for RK3036 SoC

2015-11-05 Thread LABBE Corentin
On Thu, Nov 05, 2015 at 05:53:13PM +0800, Shunqian Zheng wrote: > From: ZhengShunQian > > RK3036 SoC integrated with an Inno audio codec. > This driver implements the functions of it. > > There is not need a special machine driver, since the > simple-card machine driver works perfect in this

[PATCH] kconfig: fix missing symbol error

2015-11-05 Thread yalin wang
Add GOLDFISH OLPC config symbols, which is missing. Signed-off-by: yalin wang --- drivers/platform/Kconfig | 8 1 file changed, 8 insertions(+) diff --git a/drivers/platform/Kconfig b/drivers/platform/Kconfig index 0adccbf..81f4fb3 100644 --- a/drivers/platform/Kconfig +++

Re: [PATCH 4/4] mm: prepare page_referenced() and page_idle to new THP refcounting

2015-11-05 Thread Kirill A. Shutemov
On Thu, Nov 05, 2015 at 03:07:26PM +0300, Vladimir Davydov wrote: > @@ -849,30 +836,23 @@ static int page_referenced_one(struct page *page, > struct vm_area_struct *vma, > if (pmd_page(*pmd) != page) > goto unlock_pmd; > > - if (vma->vm_flags &

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Masahiro Yamada
2015-11-05 21:20 GMT+09:00 Mark Brown : > On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote: >> 2015-11-05 20:28 GMT+09:00 Mark Brown : > >> > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as >> > ARCH_SUNXI. > >> The compile test of this driver should pass

Re: [PATCH v2 1/5] spi: introduce mmap read support for spi flash devices

2015-11-05 Thread Vignesh R
On 11/04/2015 08:09 PM, Mark Brown wrote: > On Tue, Nov 03, 2015 at 03:36:10PM +0530, Vignesh R wrote: > >> +} >> +mutex_lock(>mmap_lock_mutex); >> +ret = master->spi_mtd_mmap_read(spi, from, len, retlen, buf, >> +read_opcode, addr_width, >> +

Re: [PATCH v3 1/5] stmmac: replace all pr_xxx by their netdev_xxx counterpart

2015-11-05 Thread LABBE Corentin
On Thu, Nov 05, 2015 at 06:58:17PM +0800, kbuild test robot wrote: > Hi LABBE, > > [auto build test ERROR on: net/master] > [also build test ERROR on: v4.3 next-20151105] > > url: > https://github.com/0day-ci/linux/commits/LABBE-Corentin/stmmac-replace-all-pr_xx

Re: [PATCH RFC 0/7] Adding core support for wire-MSI bridges

2015-11-05 Thread Thomas Gleixner
On Thu, 5 Nov 2015, Marc Zyngier wrote: > On 04/11/15 13:34, Thomas Gleixner wrote: > > Marc, > > > > On Fri, 16 Oct 2015, Marc Zyngier wrote: > >> On 16/10/15 02:55, Jiang Liu wrote: > >>> There's a working to enable Intel VMD storage device, which > >>> has the similar requirement. Basically

Re: [PATCH RFC 0/7] Adding core support for wire-MSI bridges

2015-11-05 Thread Marc Zyngier
On 04/11/15 13:34, Thomas Gleixner wrote: > Marc, > > On Fri, 16 Oct 2015, Marc Zyngier wrote: >> On 16/10/15 02:55, Jiang Liu wrote: >>> There's a working to enable Intel VMD storage device, which >>> has the similar requirement. Basically a PCIe hierarchy is hidden >>> behind a parent PCIe

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Mark Brown
On Thu, Nov 05, 2015 at 09:11:47PM +0900, Masahiro Yamada wrote: > 2015-11-05 20:28 GMT+09:00 Mark Brown : > > The dependency is on ARCH_SUNXI || COMPILE_TEST which is not the same as > > ARCH_SUNXI. > The compile test of this driver should pass even if RESET_CONTROLLER > is not defined. > So,

[PATCH 3/3] staging: lustre: Less function calls in class_register_type() after error detection

2015-11-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Nov 2015 12:48:58 +0100 The functions "kfree" and "kobject_put" were called in a few cases by the function "class_register_type" during error handling even if the passed variable contained a null pointer. This implementation detail could be improved by the

[PATCH 2/3] staging: lustre: Delete an unnecessary variable initialisation in class_register_type()

2015-11-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Nov 2015 10:55:16 +0100 The variable "rc" will be eventually set to an error return code in the class_register_type() function. Thus let us omit the explicit initialisation at the beginning. Signed-off-by: Markus Elfring ---

Re: [PATCH] arm64: Increase the max granular size

2015-11-05 Thread Catalin Marinas
On Thu, Nov 05, 2015 at 08:45:08PM +0900, Joonsoo Kim wrote: > 2015-11-05 19:32 GMT+09:00 Catalin Marinas : > > On ARM we have a notion of cache writeback granule (CWG) which tells us > > "the maximum size of memory that can be overwritten as a result of the > > eviction of a cache entry that has

[PATCH 1/3] staging: lustre: Delete unnecessary checks before two function calls

2015-11-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Nov 2015 10:18:45 +0100 The functions kobject_put() and kset_unregister() test whether their argument is NULL and then return immediately. Thus the tests around their calls are not needed. This issue was detected by using the Coccinelle software.

Re: NETIF_F_GSO_SOFTWARE vs NETIF_F_GSO

2015-11-05 Thread Herbert Xu
On Wed, Nov 04, 2015 at 12:24:47PM +0100, Jason A. Donenfeld wrote: > > Strangely, the performance does not change at all regardless of > whether or not NETIF_F_GSO is specified. The NETIF_F_GSO flag turns on software GSO which should be on anyway. So that could be why it seems to make no

Re: [PATCH 1/6] dmaengine: tegra-apb: Correct runtime-pm usage

2015-11-05 Thread Vinod Koul
On Thu, Nov 05, 2015 at 03:15:18AM +0100, Rafael J. Wysocki wrote: > > > + Rafael > > > > > > This is contrariry to what I see, If my driver is runtime suspended and on > > > suspend, it gets runtime resumed and then suspended > > > > Since I was late to the thread, can you explain what kind of

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Masahiro Yamada
2015-11-05 20:28 GMT+09:00 Mark Brown : > On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote: >> ARCH_SUNXI selects RESET_CONTROLLER. >> The dependency "depends on RESET_CONTROLLER" is already met. > > No, it isn't. > >> config SPI_SUN6I >> tristate "Allwinner A31 SPI

Re: [PATCH] ARM: dts: zynq: describe SLCR as simple-mfd rather than simple-bus

2015-11-05 Thread Michal Simek
On 11/05/2015 09:46 AM, Masahiro Yamada wrote: > The SLCR (System-Level Control Registers) block is an MFD (Multi > Function Device) rather than a bus. > > "simple-mfd" seems a more suitable compatible string than "simple-bus". > > Signed-off-by: Masahiro Yamada > --- > >

[PATCH 0/3] staging: lustre: Deletion of some unnecessary checks

2015-11-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Nov 2015 13:03:33 +0100 Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (3): Delete unnecessary checks before two function calls Delete an unnecessary variable initialisation in

Re: [PATCH 4/4] mm: prepare page_referenced() and page_idle to new THP refcounting

2015-11-05 Thread Vladimir Davydov
On Thu, Nov 05, 2015 at 11:24:59AM +0200, Kirill A. Shutemov wrote: > On Thu, Nov 05, 2015 at 12:10:13PM +0300, Vladimir Davydov wrote: > > On Tue, Nov 03, 2015 at 05:26:15PM +0200, Kirill A. Shutemov wrote: > > ... > > > @@ -56,23 +56,69 @@ static int page_idle_clear_pte_refs_one(struct page > >

Re: [RFC PATCH 2/7] spi: sunxi: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Mark Brown
On Thu, Nov 05, 2015 at 08:15:23PM +0900, Masahiro Yamada wrote: > ARCH_SUNXI selects RESET_CONTROLLER. > The dependency "depends on RESET_CONTROLLER" is already met. No, it isn't. > config SPI_SUN6I > tristate "Allwinner A31 SPI controller" > depends on ARCH_SUNXI || COMPILE_TEST >

[PATCH v6 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

2015-11-05 Thread Pavel Fedin
This patch extends Exynos SROM controller driver with ability to configure controller outputs and enables SMSC9115 Ethernet chip on SMDK5410 board, which is connected via SROMc bank #3. With this patchset, support for the whole existing SMDK range can be added. Actually, only bank number is

[PATCH v6 2/4] ARM: dts: Add SROMc to Exynos 5410

2015-11-05 Thread Pavel Fedin
This machine uses own SoC device tree file, add missing part. Signed-off-by: Pavel Fedin --- arch/arm/boot/dts/exynos5410.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi index 4603356..e2b58f8 100644 ---

[PATCH v6 3/4] drivers: exynos-srom: Add support for bank configuration

2015-11-05 Thread Pavel Fedin
Implement handling properties in subnodes and adding child devices to the system. Child devices will not be added if configuration fails. Since the driver now does more than suspend-resume support, dependency on CONFIG_PM is removed. Signed-off-by: Pavel Fedin --- arch/arm/mach-exynos/Kconfig

[PATCH v6 4/4] ARM: dts: Add Ethernet chip to SMDK5410

2015-11-05 Thread Pavel Fedin
The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO initialization is required. Signed-off-by: Pavel Fedin --- arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 +++ arch/arm/boot/dts/exynos5410.dtsi | 6 + 2 files changed, 47

[PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-11-05 Thread Pavel Fedin
Add documentation for new subnode properties, allowing bank configuration. Based on u-boot implementation, but heavily reworked. Also, fix size of SROMc mapping in the example. Signed-off-by: Pavel Fedin --- .../bindings/arm/samsung/exynos-srom.txt | 71 +- 1 file

Re: [PATCH V2 2/3] dmaselftest: add memcpy selftest support functions

2015-11-05 Thread Vinod Koul
On Wed, Nov 04, 2015 at 09:42:46PM -0500, Sinan Kaya wrote: > Here is what I proposed. > > - a common file that gets compiled into a module that wants to use > self-test with a public API. It can be called from driver's probe > routine. > - the test is independent of my implementation. It uses

[PATCH v14 03/22] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags

2015-11-05 Thread Andreas Gruenbacher
Normally, deleting a file requires MAY_WRITE access to the parent directory. With richacls, a file may be deleted with MAY_DELETE_CHILD access to the parent directory or with MAY_DELETE_SELF access to the file. To support that, pass the MAY_DELETE_CHILD mask flag to inode_permission() when

Re: [Linaro-acpi] [PATCH v8 5/5] Watchdog: introduce ARM SBSA watchdog driver

2015-11-05 Thread Fu Wei
Hi Guenter, Great thanks for your feedback! On 5 November 2015 at 13:13, Guenter Roeck wrote: > On 11/04/2015 05:59 PM, Timur Tabi wrote: >> >> On Tue, Oct 27, 2015 at 11:06 AM, wrote: >>> >>> +static irqreturn_t sbsa_gwdt_interrupt(int irq, void *dev_id) >>> +{ >>> + struct sbsa_gwdt

[PATCH v14 04/22] vfs: Make the inode passed to inode_change_ok non-const

2015-11-05 Thread Andreas Gruenbacher
We will need to call iop->permission and iop->get_acl from inode_change_ok() for additional permission checks, and both take a non-const inode. Signed-off-by: Andreas Gruenbacher Reviewed-by: J. Bruce Fields --- fs/attr.c | 2 +- include/linux/fs.h | 2 +- 2 files changed, 2

[PATCH 1/1] staging: rdma: hfi1 : Prefer using the BIT macro

2015-11-05 Thread Sunny Kumar
This patch replaces bit shifting on 1 with the BIT(x) macro Signed-off-by: Sunny Kumar --- drivers/staging/rdma/hfi1/user_sdma.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rdma/hfi1/user_sdma.c b/drivers/staging/rdma/hfi1/user_sdma.c index

[PATCH v14 06/22] richacl: In-memory representation and helper functions

2015-11-05 Thread Andreas Gruenbacher
A richacl consists of an NFSv4 acl and an owner, group, and other mask. These three masks correspond to the owner, group, and other file permission bits, but they contain NFSv4 permissions instead of POSIX permissions. Each entry in the NFSv4 acl applies to the file owner (OWNER@), the owning

[PATCH v14 07/22] richacl: Permission mapping functions

2015-11-05 Thread Andreas Gruenbacher
We need to map from POSIX permissions to NFSv4 permissions when a chmod() is done, from NFSv4 permissions to POSIX permissions when an acl is set (which implicitly sets the file permission bits), and from the MAY_READ/MAY_WRITE/MAY_EXEC/MAY_APPEND flags to NFSv4 permissions when doing an access

[PATCH v14 08/22] richacl: Compute maximum file masks from an acl

2015-11-05 Thread Andreas Gruenbacher
Compute upper bound owner, group, and other file masks with as few permissions as possible without denying any permissions that the NFSv4 acl in a richacl grants. This algorithm is used when a file inherits an acl at create time and when an acl is set via a mechanism that does not provide file

[PATCH v2 2/2] arm64: dts: exynos7: Enable HS200 mode operation

2015-11-05 Thread Alim Akhtar
This patch enables HS200 mode operation on exynos7 based espresso board. This also removes _broken-cd_ property as per mmc binding documentation which says one of the properties between broken-cd and non-removable should be used. And we already use _non-removable_ as emmc mounted on board which is

[PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node

2015-11-05 Thread Alim Akhtar
This patch add pmic (s2mps15) node of espresso board, which includes addition of regulators and pmic-clk sub-nodes. This patch also adds {vmmc,vqmmc}-supply properties for mmc2 node. Signed-off-by: Abhilash Kesavan Signed-off-by: Alim Akhtar Reviewed-by: Javier Martinez Canillas --- Changes

Re: [RFC PATCH 3/7] spi: tegra: remove redundant "depends on RESET_CONTROLLER"

2015-11-05 Thread Mark Brown
On Thu, Nov 05, 2015 at 08:15:24PM +0900, Masahiro Yamada wrote: > ARCH_TEGRA selects RESET_CONTROLLER. > The dependency "depends on RESET_CONTROLLER" is already met. > tristate "NVIDIA Tegra114 SPI Controller" > depends on (ARCH_TEGRA && TEGRA20_APB_DMA) || COMPILE_TEST > -

[PATCH v14 11/22] vfs: Cache base_acl objects in inodes

2015-11-05 Thread Andreas Gruenbacher
POSIX ACLs and richacls are both objects allocated by kmalloc() with a reference count which are freed by kfree_rcu(). An inode can either cache an access and a default POSIX ACL, or a richacl (richacls do not have default acls). To allow an inode to cache either of the two kinds of acls,

[PATCH v14 12/22] vfs: Add get_richacl and set_richacl inode operations

2015-11-05 Thread Andreas Gruenbacher
These operations are similar to the get_acl and set_acl operations for POSIX ACLs. The distinction between access and default ACLs doesn't exist for richacls. Signed-off-by: Andreas Gruenbacher --- include/linux/fs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/fs.h

[PATCH] mm: slab: Only move management objects off-slab for sizes larger than KMALLOC_MIN_SIZE

2015-11-05 Thread Catalin Marinas
Commit 8fc9cf420b36 ("slab: make more slab management structure off the slab") enables off-slab management objects for sizes starting with PAGE_SIZE >> 5. This means 128 bytes for a 4KB page configuration. However, on systems with a KMALLOC_MIN_SIZE of 128 (arm64 in 4.4), such optimisation does

[PATCH v14 14/22] richacl: Update the file masks in chmod()

2015-11-05 Thread Andreas Gruenbacher
Doing a chmod() sets the file mode, which includes the file permission bits. When a file has a richacl, the permissions that the richacl grants need to be limited to what the new file permission bits allow. This is done by setting the file masks in the richacl to what the file permission bits

<    2   3   4   5   6   7   8   9   10   11   >