Re: [PATCH v2 2/2] kbuild: Remove stale asm-generic wrappers

2016-04-21 Thread James Hogan
On Tue, Feb 23, 2016 at 09:51:07AM +, James Hogan wrote: > Hi Michal, > > On Tue, Jan 19, 2016 at 03:27:24PM +0100, Arnd Bergmann wrote: > > On Tuesday 19 January 2016 14:22:13 James Hogan wrote: > > > On Tue, Jan 19, 2016 at 03:09:14PM +0100, Arnd Bergmann wrote: > > > > On Tuesday 19

Re: [PATCH v2 2/2] kbuild: Remove stale asm-generic wrappers

2016-04-21 Thread James Hogan
On Tue, Feb 23, 2016 at 09:51:07AM +, James Hogan wrote: > Hi Michal, > > On Tue, Jan 19, 2016 at 03:27:24PM +0100, Arnd Bergmann wrote: > > On Tuesday 19 January 2016 14:22:13 James Hogan wrote: > > > On Tue, Jan 19, 2016 at 03:09:14PM +0100, Arnd Bergmann wrote: > > > > On Tuesday 19

[PATCH net v2 3/3] drivers: net: cpsw: use of_phy_connect() in fixed-link case

2016-04-21 Thread David Rivshin (Allworx)
From: David Rivshin If a fixed-link DT subnode is used, the phy_device was looked up so that a PHY ID string could be constructed and passed to phy_connect(). This is not necessary, as the device_node can be passed directly to of_phy_connect() instead. This reuses the same

[PATCH net v2 3/3] drivers: net: cpsw: use of_phy_connect() in fixed-link case

2016-04-21 Thread David Rivshin (Allworx)
From: David Rivshin If a fixed-link DT subnode is used, the phy_device was looked up so that a PHY ID string could be constructed and passed to phy_connect(). This is not necessary, as the device_node can be passed directly to of_phy_connect() instead. This reuses the same codepath as if the

Re: [PATCH 0/3] Make x86's switch_mm run with IRQs off

2016-04-21 Thread Andy Lutomirski
On Thu, Apr 21, 2016 at 10:57 AM, Andy Lutomirski wrote: > This is some of the PCID prep work, but I think it's reasonable on > its own, too. I might also want it for FSGSBASE. I rebased this wrong. I'll send a new version after the kbuild bot has some time to test it. > >

Re: [PATCH 0/3] Make x86's switch_mm run with IRQs off

2016-04-21 Thread Andy Lutomirski
On Thu, Apr 21, 2016 at 10:57 AM, Andy Lutomirski wrote: > This is some of the PCID prep work, but I think it's reasonable on > its own, too. I might also want it for FSGSBASE. I rebased this wrong. I'll send a new version after the kbuild bot has some time to test it. > > Andy Lutomirski

Re: [PATCH V3 4/4] gpio: tegra: Add support for gpio debounce

2016-04-21 Thread Stephen Warren
On 04/20/2016 07:30 AM, Laxman Dewangan wrote: NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. diff --git a/drivers/gpio/gpio-tegra.c

Re: [PATCH V3 4/4] gpio: tegra: Add support for gpio debounce

2016-04-21 Thread Stephen Warren
On 04/20/2016 07:30 AM, Laxman Dewangan wrote: NVIDIA's Tegra210 support the HW debounce in the GPIO controller for all its GPIO pins. Add support for setting debounce timing by implementing the set_debounce callback of gpiochip. diff --git a/drivers/gpio/gpio-tegra.c

Re: [PATCH V3 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-21 Thread Stephen Warren
On 04/20/2016 07:30 AM, Laxman Dewangan wrote: Move the file scoped multiple global variable from Tegra GPIO driver to the structure and make this as gpiochip data which can be referred from GPIO chip callbacks. diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c +#define

Re: [PATCH V3 3/4] gpio: tegra: Get rid of all file scoped global variables

2016-04-21 Thread Stephen Warren
On 04/20/2016 07:30 AM, Laxman Dewangan wrote: Move the file scoped multiple global variable from Tegra GPIO driver to the structure and make this as gpiochip data which can be referred from GPIO chip callbacks. diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c +#define

Re: [PATCH V3 2/4] gpio: tegra: Make of_device_id compatible data to constant

2016-04-21 Thread Stephen Warren
On 04/20/2016 07:30 AM, Laxman Dewangan wrote: The data member of the of_device_id is the constant type and hence all static structure which is used for this initialisation as static. Reviewed-by: Stephen Warren

Re: [PATCH V3 2/4] gpio: tegra: Make of_device_id compatible data to constant

2016-04-21 Thread Stephen Warren
On 04/20/2016 07:30 AM, Laxman Dewangan wrote: The data member of the of_device_id is the constant type and hence all static structure which is used for this initialisation as static. Reviewed-by: Stephen Warren

Re: [PATCH] drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open

2016-04-21 Thread David Miller
From: Grygorii Strashko Date: Tue, 19 Apr 2016 21:09:49 +0300 > The cpsw_ndo_open() could try to access CPSW registers before > calling pm_runtime_get_sync(). This will trigger L3 error: > > WARNING: CPU: 0 PID: 21 at drivers/bus/omap_l3_noc.c:147 >

Re: [PATCH] drivers: net: cpsw: fix wrong regs access in cpsw_ndo_open

2016-04-21 Thread David Miller
From: Grygorii Strashko Date: Tue, 19 Apr 2016 21:09:49 +0300 > The cpsw_ndo_open() could try to access CPSW registers before > calling pm_runtime_get_sync(). This will trigger L3 error: > > WARNING: CPU: 0 PID: 21 at drivers/bus/omap_l3_noc.c:147 > l3_interrupt_handler+0x220/0x34c() >

[PATCH net v2 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

2016-04-21 Thread David Rivshin (Allworx)
From: David Rivshin The phy-handle, phy_id, and fixed-link properties are mutually exclusive, and only one need be specified. However if phy-handle was specified, an error message would complain about the lack of phy_id or fixed-link. Also, if phy-handle was specified and

[PATCH net v2 2/3] drivers: net: cpsw: fix error messages when using phy-handle DT property

2016-04-21 Thread David Rivshin (Allworx)
From: David Rivshin The phy-handle, phy_id, and fixed-link properties are mutually exclusive, and only one need be specified. However if phy-handle was specified, an error message would complain about the lack of phy_id or fixed-link. Also, if phy-handle was specified and the subsequent

[PATCH 3/6] rtc: rv3029: Add support of RV3049

2016-04-21 Thread Mylène Josserand
Add support of Microcrystal RV3049 RTC (SPI) using regmap on the RV3029 (I2C) driver. Signed-off-by: Mylène Josserand --- drivers/rtc/Kconfig| 37 +++ drivers/rtc/rtc-rv3029c2.c | 110 +++-- 2

[PATCH 5/6] rtc: rv3029: enable AE_x bits on set_alarm

2016-04-21 Thread Mylène Josserand
The RTC RV3029 handles different types of alarms : seconds, minutes, ... These alarms can be enabled or disabled individually using an AE_x bit which is the last bit (BIT(7)) on each alarm registers. To prepare the alarm IRQ support, the current code enables all the alarm types by setting each

[PATCH 3/6] rtc: rv3029: Add support of RV3049

2016-04-21 Thread Mylène Josserand
Add support of Microcrystal RV3049 RTC (SPI) using regmap on the RV3029 (I2C) driver. Signed-off-by: Mylène Josserand --- drivers/rtc/Kconfig| 37 +++ drivers/rtc/rtc-rv3029c2.c | 110 +++-- 2 files changed, 126 insertions(+), 21

[PATCH 5/6] rtc: rv3029: enable AE_x bits on set_alarm

2016-04-21 Thread Mylène Josserand
The RTC RV3029 handles different types of alarms : seconds, minutes, ... These alarms can be enabled or disabled individually using an AE_x bit which is the last bit (BIT(7)) on each alarm registers. To prepare the alarm IRQ support, the current code enables all the alarm types by setting each

[PATCH 4/6] rtc: rv3029: Removes some checks and warnings

2016-04-21 Thread Mylène Josserand
Removes some checks from checkpatch such as spaces around arithmetic operations. Signed-off-by: Mylène Josserand --- drivers/rtc/rtc-rv3029c2.c | 66 ++ 1 file changed, 32 insertions(+), 34 deletions(-) diff --git

[PATCH 4/6] rtc: rv3029: Removes some checks and warnings

2016-04-21 Thread Mylène Josserand
Removes some checks from checkpatch such as spaces around arithmetic operations. Signed-off-by: Mylène Josserand --- drivers/rtc/rtc-rv3029c2.c | 66 ++ 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/drivers/rtc/rtc-rv3029c2.c

[PATCH 1/6] rtc: rv3029: remove 'i2c' in functions names

2016-04-21 Thread Mylène Josserand
To prepare the use of regmap to add the support of RV-3049, all the 'i2c' in functions's names are removed. Signed-off-by: Mylène Josserand --- drivers/rtc/rtc-rv3029c2.c | 132 - 1 file changed, 57 insertions(+),

[PATCH 0/6] add support for Microcrystal RV-3049

2016-04-21 Thread Mylène Josserand
The current patchset adds the support of the microcrystal RV-3049 (spi). This RTC will use the same driver than RV-3029 by updating it to use regmap. It also adds the alarm IRQ functionality. Mylène Josserand (6): rtc: rv3029: remove 'i2c' in functions names rtc: rv3029: convert to use

[PATCH 6/6] rtc: rv3029: add alarm IRQ

2016-04-21 Thread Mylène Josserand
Add the alarm IRQ functionality. Signed-off-by: Mylène Josserand --- drivers/rtc/rtc-rv3029c2.c | 114 - 1 file changed, 93 insertions(+), 21 deletions(-) diff --git a/drivers/rtc/rtc-rv3029c2.c

[PATCH 1/6] rtc: rv3029: remove 'i2c' in functions names

2016-04-21 Thread Mylène Josserand
To prepare the use of regmap to add the support of RV-3049, all the 'i2c' in functions's names are removed. Signed-off-by: Mylène Josserand --- drivers/rtc/rtc-rv3029c2.c | 132 - 1 file changed, 57 insertions(+), 75 deletions(-) diff --git

[PATCH 0/6] add support for Microcrystal RV-3049

2016-04-21 Thread Mylène Josserand
The current patchset adds the support of the microcrystal RV-3049 (spi). This RTC will use the same driver than RV-3029 by updating it to use regmap. It also adds the alarm IRQ functionality. Mylène Josserand (6): rtc: rv3029: remove 'i2c' in functions names rtc: rv3029: convert to use

[PATCH 6/6] rtc: rv3029: add alarm IRQ

2016-04-21 Thread Mylène Josserand
Add the alarm IRQ functionality. Signed-off-by: Mylène Josserand --- drivers/rtc/rtc-rv3029c2.c | 114 - 1 file changed, 93 insertions(+), 21 deletions(-) diff --git a/drivers/rtc/rtc-rv3029c2.c b/drivers/rtc/rtc-rv3029c2.c index 42de1a3..152ca9d

[PATCH 2/6] rtc: rv3029: convert to use regmap

2016-04-21 Thread Mylène Josserand
To add support of rv3049, the current driver is converted to use regmap. Signed-off-by: Mylène Josserand --- drivers/rtc/rtc-rv3029c2.c | 275 +++-- 1 file changed, 142 insertions(+), 133 deletions(-) diff --git

[PATCH 2/6] rtc: rv3029: convert to use regmap

2016-04-21 Thread Mylène Josserand
To add support of rv3049, the current driver is converted to use regmap. Signed-off-by: Mylène Josserand --- drivers/rtc/rtc-rv3029c2.c | 275 +++-- 1 file changed, 142 insertions(+), 133 deletions(-) diff --git a/drivers/rtc/rtc-rv3029c2.c

[PATCH v1 01/23] ata: sata_dwc_460ex: remove incorrect locking

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard This lock is already taken in ata_scsi_queuecmd() a few levels up the call stack so attempting to take it here is an error. Moreover, it is pointless in the first place since it only protects a single, atomic assignment. Enabling lock debugging gives the

[PATCH v1 01/23] ata: sata_dwc_460ex: remove incorrect locking

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard This lock is already taken in ata_scsi_queuecmd() a few levels up the call stack so attempting to take it here is an error. Moreover, it is pointless in the first place since it only protects a single, atomic assignment. Enabling lock debugging gives the following output:

[PATCH v1 02/23] ata: sata_dwc_460ex: fix crash on offline links without an attached drive

2016-04-21 Thread Andy Shevchenko
From: Christian Lamparter This patch fixes Machine Check "Data Write PLB Error" which happens when libata-sff's ata_sff_dev_select is trying to write into the device_addr in order to select a drive. However, SATA has no master or slave devices like the old ATA Bus,

[PATCH v1 00/23] ata: sata_dwc_460ex: make it working again

2016-04-21 Thread Andy Shevchenko
The last approach in the commit 8b3444852a2b ("sata_dwc_460ex: move to generic DMA driver") to switch to generic DMA engine API wasn't tested on bare metal. Besides that we expecting new board support coming with the same SATA IP but with different DMA. This series is targetting the following

[PATCH v1 05/23] ata: sata_dwc_460ex: DMA is always a flow controller

2016-04-21 Thread Andy Shevchenko
In the original code the DMA is always a flow controller. Set this accordingly in updated code. Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_dwc_460ex.c

[PATCH v1 02/23] ata: sata_dwc_460ex: fix crash on offline links without an attached drive

2016-04-21 Thread Andy Shevchenko
From: Christian Lamparter This patch fixes Machine Check "Data Write PLB Error" which happens when libata-sff's ata_sff_dev_select is trying to write into the device_addr in order to select a drive. However, SATA has no master or slave devices like the old ATA Bus, therefore selecting a

[PATCH v1 00/23] ata: sata_dwc_460ex: make it working again

2016-04-21 Thread Andy Shevchenko
The last approach in the commit 8b3444852a2b ("sata_dwc_460ex: move to generic DMA driver") to switch to generic DMA engine API wasn't tested on bare metal. Besides that we expecting new board support coming with the same SATA IP but with different DMA. This series is targetting the following

[PATCH v1 05/23] ata: sata_dwc_460ex: DMA is always a flow controller

2016-04-21 Thread Andy Shevchenko
In the original code the DMA is always a flow controller. Set this accordingly in updated code. Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c index

[PATCH v1 12/23] ata: sata_dwc_460ex: correct HOSTDEV{P}_FROM_*() macros

2016-04-21 Thread Andy Shevchenko
Here we refactor HOSTDEV{P}_FROM_*() macros to fit one line and fix the definition of HSDEV_FROM_HSDEVP() where wrong name of the parameter waas used. Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 17 ++--- 1 file changed, 6

[PATCH net v2 1/3] drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac config

2016-04-21 Thread David Rivshin (Allworx)
From: David Rivshin Commit 9e42f715264ff158478fa30eaed847f6e131366b ("drivers: net: cpsw: add phy-handle parsing") saved the "phy-handle" phandle into a new cpsw_priv field. However, phy connections are per-slave, so the phy_node field should be in cpsw_slave_data rather

[PATCH v1 23/23] powerpc/4xx: Device tree update for the 460ex DWC SATA

2016-04-21 Thread Andy Shevchenko
Device tree update for the Applied micro processor 460ex on-chip SATA to use "dmas" property. Signed-off-by: Andy Shevchenko --- arch/powerpc/boot/dts/canyonlands.dts | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git

[PATCH v1 12/23] ata: sata_dwc_460ex: correct HOSTDEV{P}_FROM_*() macros

2016-04-21 Thread Andy Shevchenko
Here we refactor HOSTDEV{P}_FROM_*() macros to fit one line and fix the definition of HSDEV_FROM_HSDEVP() where wrong name of the parameter waas used. Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff

[PATCH net v2 1/3] drivers: net: cpsw: fix parsing of phy-handle DT property in dual_emac config

2016-04-21 Thread David Rivshin (Allworx)
From: David Rivshin Commit 9e42f715264ff158478fa30eaed847f6e131366b ("drivers: net: cpsw: add phy-handle parsing") saved the "phy-handle" phandle into a new cpsw_priv field. However, phy connections are per-slave, so the phy_node field should be in cpsw_slave_data rather than cpsw_priv. This

[PATCH v1 23/23] powerpc/4xx: Device tree update for the 460ex DWC SATA

2016-04-21 Thread Andy Shevchenko
Device tree update for the Applied micro processor 460ex on-chip SATA to use "dmas" property. Signed-off-by: Andy Shevchenko --- arch/powerpc/boot/dts/canyonlands.dts | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts/canyonlands.dts

[PATCH v1 06/23] ata: sata_dwc_460ex: select only core part of DMA driver

2016-04-21 Thread Andy Shevchenko
There is no need to have a platform driver compiled since the DMA driver is used as a library. Signed-off-by: Andy Shevchenko --- drivers/ata/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig

Re: [PATCH 1/3] checkpatch: add Kconfig 'default n' test

2016-04-21 Thread Paul Bolle
On do, 2016-04-21 at 10:16 -0700, Joe Perches wrote: > Also, there are some oddities like: > > arch/mips/cavium-octeon/Kconfig:default "n" For v4.6-rc4: $ git grep -n -e "default\s\+\"[mny]\"" -- "*Kconfig*" arch/mips/Kconfig:2232: default "y" arch/mips/Kconfig:2237: default

[PATCH v1 06/23] ata: sata_dwc_460ex: select only core part of DMA driver

2016-04-21 Thread Andy Shevchenko
There is no need to have a platform driver compiled since the DMA driver is used as a library. Signed-off-by: Andy Shevchenko --- drivers/ata/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index cfa936a..7c6e43a 100644 ---

Re: [PATCH 1/3] checkpatch: add Kconfig 'default n' test

2016-04-21 Thread Paul Bolle
On do, 2016-04-21 at 10:16 -0700, Joe Perches wrote: > Also, there are some oddities like: > > arch/mips/cavium-octeon/Kconfig:default "n" For v4.6-rc4: $ git grep -n -e "default\s\+\"[mny]\"" -- "*Kconfig*" arch/mips/Kconfig:2232: default "y" arch/mips/Kconfig:2237: default

[PATCH v1 19/23] ata: sata_dwc_460ex: use readl/writel_relaxed()

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard Rename the register access macros and use standard _relaxed() ops instead of __raw variants with explicit byte swapping. The original driver used the ppc-specific in/out_le32(). When it was adapted to other systems, these were added to the driver under

[PATCH v1 07/23] ata: sata_dwc_460ex: skip dma setup for non-dma commands

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard Calling dmaengine_prep_slave_sg() for non-dma ATA commands is unnecessary at best and could be harmful if the dma driver reacts badly to this. It also causes this driver to print a bogus error message in these cases. This patch changes sata_dwc_qc_issue() to

[PATCH v1 19/23] ata: sata_dwc_460ex: use readl/writel_relaxed()

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard Rename the register access macros and use standard _relaxed() ops instead of __raw variants with explicit byte swapping. The original driver used the ppc-specific in/out_le32(). When it was adapted to other systems, these were added to the driver under ifdefs. However,

[PATCH v1 07/23] ata: sata_dwc_460ex: skip dma setup for non-dma commands

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard Calling dmaengine_prep_slave_sg() for non-dma ATA commands is unnecessary at best and could be harmful if the dma driver reacts badly to this. It also causes this driver to print a bogus error message in these cases. This patch changes sata_dwc_qc_issue() to only do the dma

[PATCH v1 18/23] ata: sata_dwc_460ex: switch to new dmaengine_terminate_* API

2016-04-21 Thread Andy Shevchenko
Convert dmaengine_terminate_all() calls to synchronous and asynchronous versions where appropriate. Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_dwc_460ex.c

Re: [PATCH 2/8] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*()

2016-04-21 Thread Noralf Trønnes
Den 21.04.2016 09:28, skrev Daniel Vetter: On Wed, Apr 20, 2016 at 08:15:30PM +0200, Noralf Trønnes wrote: Den 20.04.2016 19:42, skrev Daniel Vetter: On Wed, Apr 20, 2016 at 05:25:23PM +0200, Noralf Trønnes wrote: Now that drm_fb_helper gets deferred io support, the

[PATCH v1 09/23] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard Currently this driver only works with a DesignWare DMA engine which it registers manually using the second "reg" address range and interrupt number from the DT node. This patch makes the driver instead use the "dmas" property if present, otherwise optionally

[PATCH v1 15/23] ata: sata_dwc_460ex: get rid of incorrect cast

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard The (void *__iomem) cast is wrong. Change the target type of the "base" pointer to void __iomem instead and drop the cast. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v1 18/23] ata: sata_dwc_460ex: switch to new dmaengine_terminate_* API

2016-04-21 Thread Andy Shevchenko
Convert dmaengine_terminate_all() calls to synchronous and asynchronous versions where appropriate. Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c

Re: [PATCH 2/8] drm/udl: Change drm_fb_helper_sys_*() calls to sys_*()

2016-04-21 Thread Noralf Trønnes
Den 21.04.2016 09:28, skrev Daniel Vetter: On Wed, Apr 20, 2016 at 08:15:30PM +0200, Noralf Trønnes wrote: Den 20.04.2016 19:42, skrev Daniel Vetter: On Wed, Apr 20, 2016 at 05:25:23PM +0200, Noralf Trønnes wrote: Now that drm_fb_helper gets deferred io support, the

[PATCH v1 09/23] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard Currently this driver only works with a DesignWare DMA engine which it registers manually using the second "reg" address range and interrupt number from the DT node. This patch makes the driver instead use the "dmas" property if present, otherwise optionally falling back on

[PATCH v1 15/23] ata: sata_dwc_460ex: get rid of incorrect cast

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard The (void *__iomem) cast is wrong. Change the target type of the "base" pointer to void __iomem instead and drop the cast. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v1 21/23] ata: sata_dwc_460ex: use devm_ioremap

2016-04-21 Thread Andy Shevchenko
This simplifies error handling and cleanup by using devm to manage IO mappings. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 30 +++--- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c

[PATCH v1 21/23] ata: sata_dwc_460ex: use devm_ioremap

2016-04-21 Thread Andy Shevchenko
This simplifies error handling and cleanup by using devm to manage IO mappings. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 30 +++--- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c

[PATCH v1 13/23] ata: sata_dwc_460ex: remove empty libata callback

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard The sata_dwc_qc_prep() does nothing. Use the default ata_noop_qc_prep instead. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 22 -- 1 file changed, 22 deletions(-) diff --git

[PATCH v1 13/23] ata: sata_dwc_460ex: remove empty libata callback

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard The sata_dwc_qc_prep() does nothing. Use the default ata_noop_qc_prep instead. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c

[PATCH v1 17/23] ata: sata_dwc_460ex: supply physical address of FIFO to DMA

2016-04-21 Thread Andy Shevchenko
DMA operates with physical addresses which is not exactly the same as ioremap() returns. Introduce variable to keep physical address of the SATA FIFO register and supply it when prepare DMA channel. Signed-off-by: Andy Shevchenko ---

[PATCH v1 20/23] ata: sata_dwc_460ex: tidy up sata_dwc_clear_dmacr()

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard This consolidates the reads from each of the if/else branches to one place making the code a lot nicer to look at. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 14 ++ 1 file changed, 6 insertions(+), 8

[PATCH v1 20/23] ata: sata_dwc_460ex: tidy up sata_dwc_clear_dmacr()

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard This consolidates the reads from each of the if/else branches to one place making the code a lot nicer to look at. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH v1 17/23] ata: sata_dwc_460ex: supply physical address of FIFO to DMA

2016-04-21 Thread Andy Shevchenko
DMA operates with physical addresses which is not exactly the same as ioremap() returns. Introduce variable to keep physical address of the SATA FIFO register and supply it when prepare DMA channel. Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 13 +++-- 1 file

[PATCH v1 16/23] ata: sata_dwc_460ex: add __iomem to register base pointer

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard The pointer to the mmio register base is missing the __iomem annotation. Fix this. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v1 16/23] ata: sata_dwc_460ex: add __iomem to register base pointer

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard The pointer to the mmio register base is missing the __iomem annotation. Fix this. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c

[PATCH v1 14/23] ata: sata_dwc_460ex: get rid of some pointless casts

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard Casting a pointer to unsigned long only to immediately cast it back to a pointer makes no sense. Fix this. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 30 +++--- 1 file changed, 15 insertions(+),

[PATCH v1 11/23] ata: sata_dwc_460ex: get rid of global data

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard This moves all global data into the driver private struct, thus permitting multiple devices of this type to be used. The core_scr_read/write() functions are replaced with equivalent calls to the existing sata_dwc_scr_read/write(). Signed-off-by: Mans

[PATCH v1 14/23] ata: sata_dwc_460ex: get rid of some pointless casts

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard Casting a pointer to unsigned long only to immediately cast it back to a pointer makes no sense. Fix this. Signed-off-by: Mans Rullgard --- drivers/ata/sata_dwc_460ex.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git

[PATCH v1 11/23] ata: sata_dwc_460ex: get rid of global data

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard This moves all global data into the driver private struct, thus permitting multiple devices of this type to be used. The core_scr_read/write() functions are replaced with equivalent calls to the existing sata_dwc_scr_read/write(). Signed-off-by: Mans Rullgard ---

[PATCH v1 10/23] ata: sata_dwc_460ex: add phy support

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard This adds support for powering on an optional PHY when activating the device. Signed-off-by: Mans Rullgard --- drivers/ata/Kconfig | 1 + drivers/ata/sata_dwc_460ex.c | 22 ++ 2 files changed, 23 insertions(+)

[PATCH v1 10/23] ata: sata_dwc_460ex: add phy support

2016-04-21 Thread Andy Shevchenko
From: Mans Rullgard This adds support for powering on an optional PHY when activating the device. Signed-off-by: Mans Rullgard --- drivers/ata/Kconfig | 1 + drivers/ata/sata_dwc_460ex.c | 22 ++ 2 files changed, 23 insertions(+) diff --git a/drivers/ata/Kconfig

[PATCH v1 08/23] ata: sata_dwc_460ex: don't call ata_sff_qc_issue() on DMA commands

2016-04-21 Thread Andy Shevchenko
ata_sff_qc_issue() can't handle DMA commands and thus we have to avoid it for them. Do call ata_bmdma_qc_issue() instead for this case. Suggested-by: Christian Lamparter Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c

[PATCH v1 03/23] ata: sata_dwc_460ex: set dma_boundary to 0x1fff

2016-04-21 Thread Andy Shevchenko
The original code states: Make sure a LLI block is not created that will span 8K max FIS boundary. If the block spans such a FIS boundary, there is a chance that a DMA burst will cross that boundary -- this results in an error in the host controller. Since we have

[PATCH v1 03/23] ata: sata_dwc_460ex: set dma_boundary to 0x1fff

2016-04-21 Thread Andy Shevchenko
The original code states: Make sure a LLI block is not created that will span 8K max FIS boundary. If the block spans such a FIS boundary, there is a chance that a DMA burst will cross that boundary -- this results in an error in the host controller. Since we have

[PATCH v1 08/23] ata: sata_dwc_460ex: don't call ata_sff_qc_issue() on DMA commands

2016-04-21 Thread Andy Shevchenko
ata_sff_qc_issue() can't handle DMA commands and thus we have to avoid it for them. Do call ata_bmdma_qc_issue() instead for this case. Suggested-by: Christian Lamparter Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

[PATCH v1 04/23] ata: sata_dwc_460ex: burst size must be in items not bytes

2016-04-21 Thread Andy Shevchenko
The burst size as defined by DMAengine API is in items of address width. Derive burst size from AHB_DMA_BRST_DFLT (64 bytes) by dividing it to DMA_SLAVE_BUSWIDTH_4_BYTES (4 bytes) that gives us 16 items. Signed-off-by: Andy Shevchenko ---

[PATCH v1 22/23] ata: sata_dwc_460ex: make debug messages neat

2016-04-21 Thread Andy Shevchenko
There is a duplication in the debug messages when accessing SCR registers. Remove duplication to make the messages neat. Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v1 04/23] ata: sata_dwc_460ex: burst size must be in items not bytes

2016-04-21 Thread Andy Shevchenko
The burst size as defined by DMAengine API is in items of address width. Derive burst size from AHB_DMA_BRST_DFLT (64 bytes) by dividing it to DMA_SLAVE_BUSWIDTH_4_BYTES (4 bytes) that gives us 16 items. Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 6 +++--- 1 file changed,

[PATCH v1 22/23] ata: sata_dwc_460ex: make debug messages neat

2016-04-21 Thread Andy Shevchenko
There is a duplication in the debug messages when accessing SCR registers. Remove duplication to make the messages neat. Signed-off-by: Andy Shevchenko --- drivers/ata/sata_dwc_460ex.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/ata/sata_dwc_460ex.c

Re: [PATCH v3 1/2] ext4: Pass in DIO_SKIP_DIO_COUNT flag if inode_dio_begin() called

2016-04-21 Thread Waiman Long
On 04/20/2016 04:58 PM, Christoph Hellwig wrote: FYI, none of the Dax code even needs to ever touch the dio_count, as dax I/O can't be asynchronous, and we thus don't need it to protect against truncate. I'd suggest to remove it and then end_io callback from the DAX code entirely as a start and

Re: [PATCH v3 1/2] ext4: Pass in DIO_SKIP_DIO_COUNT flag if inode_dio_begin() called

2016-04-21 Thread Waiman Long
On 04/20/2016 04:58 PM, Christoph Hellwig wrote: FYI, none of the Dax code even needs to ever touch the dio_count, as dax I/O can't be asynchronous, and we thus don't need it to protect against truncate. I'd suggest to remove it and then end_io callback from the DAX code entirely as a start and

[PATCH V4] audit: add tty field to LOGIN event

2016-04-21 Thread Richard Guy Briggs
The tty field was missing from AUDIT_LOGIN events. Refactor code to create a new function audit_get_tty(), using it to replace the call in audit_log_task_info() and to add it to audit_log_set_loginuid(). Lock and bump the kref to protect it, adding audit_put_tty() alias to decrement it.

[PATCH V4] audit: add tty field to LOGIN event

2016-04-21 Thread Richard Guy Briggs
The tty field was missing from AUDIT_LOGIN events. Refactor code to create a new function audit_get_tty(), using it to replace the call in audit_log_task_info() and to add it to audit_log_set_loginuid(). Lock and bump the kref to protect it, adding audit_put_tty() alias to decrement it.

Re: [PATCH 2/5] x86, KASLR: Drop CONFIG_RANDOMIZE_BASE_MAX_OFFSET

2016-04-21 Thread Kees Cook
On Thu, Apr 21, 2016 at 10:44 AM, Borislav Petkov wrote: > On Wed, Apr 20, 2016 at 01:55:43PM -0700, Kees Cook wrote: >> From: Baoquan He >> >> Currently CONFIG_RANDOMIZE_BASE_MAX_OFFSET is used to limit the maximum >> offset for kernel randomization. This limit

Re: [PATCH 2/5] x86, KASLR: Drop CONFIG_RANDOMIZE_BASE_MAX_OFFSET

2016-04-21 Thread Kees Cook
On Thu, Apr 21, 2016 at 10:44 AM, Borislav Petkov wrote: > On Wed, Apr 20, 2016 at 01:55:43PM -0700, Kees Cook wrote: >> From: Baoquan He >> >> Currently CONFIG_RANDOMIZE_BASE_MAX_OFFSET is used to limit the maximum >> offset for kernel randomization. This limit doesn't need to be a CONFIG >>

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Alexander Duyck
On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: > Current code writes the tx/rx relaxed order without reading it first. > This can lead to unintended consequences as we are forcibly writing > other bits. The consequences were very much intended as there are situations

Re: [PATCH] ixgbevf: Fix relaxed order settings in VF driver

2016-04-21 Thread Alexander Duyck
On Thu, Apr 21, 2016 at 10:21 AM, Babu Moger wrote: > Current code writes the tx/rx relaxed order without reading it first. > This can lead to unintended consequences as we are forcibly writing > other bits. The consequences were very much intended as there are situations where enabling relaxed

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-21 Thread Hannes Frederic Sowa
On 21.04.2016 15:31, Eric Dumazet wrote: > On Thu, 2016-04-21 at 05:05 -0400, valdis.kletni...@vt.edu wrote: >> On Thu, 21 Apr 2016 09:42:12 +0200, Hannes Frederic Sowa said: >>> Hi, >>> >>> On Thu, Apr 21, 2016, at 02:30, Valdis Kletnieks wrote: linux-next 20160420 is whining at an

Re: linux-next: zillions of lockdep whinges in include/net/sock.h:1408

2016-04-21 Thread Hannes Frederic Sowa
On 21.04.2016 15:31, Eric Dumazet wrote: > On Thu, 2016-04-21 at 05:05 -0400, valdis.kletni...@vt.edu wrote: >> On Thu, 21 Apr 2016 09:42:12 +0200, Hannes Frederic Sowa said: >>> Hi, >>> >>> On Thu, Apr 21, 2016, at 02:30, Valdis Kletnieks wrote: linux-next 20160420 is whining at an

Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation

2016-04-21 Thread Greg Kurz
On Thu, 21 Apr 2016 19:39:31 +0200 Radim Krčmář wrote: > 2016-04-21 19:18+0200, Greg Kurz: > > On Thu, 21 Apr 2016 18:08:41 +0200 > > Radim Krčmář wrote: > >> 2016-04-21 17:49+0200, Greg Kurz: > >> > So we're good ? > >> > >> I support the

Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation

2016-04-21 Thread Greg Kurz
On Thu, 21 Apr 2016 19:39:31 +0200 Radim Krčmář wrote: > 2016-04-21 19:18+0200, Greg Kurz: > > On Thu, 21 Apr 2016 18:08:41 +0200 > > Radim Krčmář wrote: > >> 2016-04-21 17:49+0200, Greg Kurz: > >> > So we're good ? > >> > >> I support the change, just had a nit about API design for

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-04-21 Thread Timur Tabi
Florian Fainelli wrote: Well, PHYLIB does prefer using MDIO accesses to "speak" to PHYs, built-in or external, but there is always the option of investing into some custom development with the subsystem to make it play nicely with your HW. So I've done some more research, and I believe that

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-04-21 Thread Timur Tabi
Florian Fainelli wrote: Well, PHYLIB does prefer using MDIO accesses to "speak" to PHYs, built-in or external, but there is always the option of investing into some custom development with the subsystem to make it play nicely with your HW. So I've done some more research, and I believe that

[PATCH 2/3] x86/mm: Uninline switch_mm

2016-04-21 Thread Andy Lutomirski
It's fairly large and it has quite a few callers. This may also help untangle some headers down the road. Signed-off-by: Andy Lutomirski --- arch/x86/include/asm/mmu_context.h | 98 +-- arch/x86/mm/tlb.c | 102

[PATCH 2/3] x86/mm: Uninline switch_mm

2016-04-21 Thread Andy Lutomirski
It's fairly large and it has quite a few callers. This may also help untangle some headers down the road. Signed-off-by: Andy Lutomirski --- arch/x86/include/asm/mmu_context.h | 98 +-- arch/x86/mm/tlb.c | 102

<    1   2   3   4   5   6   7   8   9   10   >