Re: [PATCH v2 net-next v2 11/12] net: dsa: mv88e6xxx: add an SMI ops structure

2016-06-14 Thread Andrew Lunn
> +struct mv88e6xxx_smi_ops { > + int (*read)(struct mii_bus *bus, int sw_addr, > + int addr, int reg, u16 *val); > + int (*write)(struct mii_bus *bus, int sw_addr, > + int addr, int reg, u16 val); > +}; > + I think this API would be better if it used ps,

Re: [PATCH v2 net-next v2 11/12] net: dsa: mv88e6xxx: add an SMI ops structure

2016-06-14 Thread Andrew Lunn
> +struct mv88e6xxx_smi_ops { > + int (*read)(struct mii_bus *bus, int sw_addr, > + int addr, int reg, u16 *val); > + int (*write)(struct mii_bus *bus, int sw_addr, > + int addr, int reg, u16 val); > +}; > + I think this API would be better if it used ps,

Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface

2016-06-14 Thread Sudip Mukherjee
On Tuesday 14 June 2016 10:23 PM, Ben Hutchings wrote: On Tue, 2016-06-14 at 22:11 +0100, Sudip Mukherjee wrote: On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: 3.2.81-rc1 review patch. If anyone has any objections, please let me know. -- From: Jason Gunthorpe

Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface

2016-06-14 Thread Sudip Mukherjee
On Tuesday 14 June 2016 10:23 PM, Ben Hutchings wrote: On Tue, 2016-06-14 at 22:11 +0100, Sudip Mukherjee wrote: On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: 3.2.81-rc1 review patch. If anyone has any objections, please let me know. -- From: Jason Gunthorpe commit

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-14 Thread Luis R. Rodriguez
On Tue, Jun 14, 2016 at 11:17:13PM +0200, Julia Lawall wrote: > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > On Tue, Jun 14, 2016 at 10:47:32PM +0200, Julia Lawall wrote: > > > > > > > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > On Tue, Jun 14, 2016 at

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-14 Thread Luis R. Rodriguez
On Tue, Jun 14, 2016 at 11:17:13PM +0200, Julia Lawall wrote: > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > On Tue, Jun 14, 2016 at 10:47:32PM +0200, Julia Lawall wrote: > > > > > > > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > On Tue, Jun 14, 2016 at

Re: [PATCH v3] Input: synaptics-rmi4: Support regulator supplies

2016-06-14 Thread Rob Herring
On Fri, Jun 10, 2016 at 10:25:22PM -0700, Bjorn Andersson wrote: > From: Bjorn Andersson > > Support the two supplies - vdd and vio - to make it possible to control > power to the Synaptics chip. > > Signed-off-by: Bjorn Andersson

Re: [PATCH v3] Input: synaptics-rmi4: Support regulator supplies

2016-06-14 Thread Rob Herring
On Fri, Jun 10, 2016 at 10:25:22PM -0700, Bjorn Andersson wrote: > From: Bjorn Andersson > > Support the two supplies - vdd and vio - to make it possible to control > power to the Synaptics chip. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- >

Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC

2016-06-14 Thread Paolo Bonzini
On 14/06/2016 23:44, Suravee Suthikulanit wrote: > On 6/14/2016 4:22 PM, Paolo Bonzini wrote: >> - Original Message - >>> From: "Suravee Suthikulanit" >>> To: "Paolo Bonzini" , >>> linux-kernel@vger.kernel.org, k...@vger.kernel.org >>>

Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC

2016-06-14 Thread Paolo Bonzini
On 14/06/2016 23:44, Suravee Suthikulanit wrote: > On 6/14/2016 4:22 PM, Paolo Bonzini wrote: >> - Original Message - >>> From: "Suravee Suthikulanit" >>> To: "Paolo Bonzini" , >>> linux-kernel@vger.kernel.org, k...@vger.kernel.org >>> Cc: rkrc...@redhat.com >>> Sent: Tuesday, June 14,

mm: BUG: KASAN: use-after-free in unmapped_area_topdown

2016-06-14 Thread Sasha Levin
] CPU: 4 PID: 23061 Comm: syz-executor Not tainted 4.7.0-rc3-next-20160614-sasha-00032-g8e3c1a2-dirty #3105 [ 1292.662336] 110016b04f32 81187c24 8800b5827a18 a402fb57 [ 1292.662347] 0004 fbfff5e30bac 41b58ab3 aeafca90 [ 1292.662357

mm: BUG: KASAN: use-after-free in unmapped_area_topdown

2016-06-14 Thread Sasha Levin
] CPU: 4 PID: 23061 Comm: syz-executor Not tainted 4.7.0-rc3-next-20160614-sasha-00032-g8e3c1a2-dirty #3105 [ 1292.662336] 110016b04f32 81187c24 8800b5827a18 a402fb57 [ 1292.662347] 0004 fbfff5e30bac 41b58ab3 aeafca90 [ 1292.662357

Re: [PATCH] firmware: qcom: scm: Expose PAS command 10 as reset-controller

2016-06-14 Thread Rob Herring
On Fri, Jun 10, 2016 at 09:52:20PM -0700, Bjorn Andersson wrote: > PAS command 10 is used to assert and deassert the MSS reset via > TrustZone, expose this as a reset-controller to follow the non-secure > case where GCC exposes this control. > > Signed-off-by: Bjorn Andersson

Re: [PATCH] firmware: qcom: scm: Expose PAS command 10 as reset-controller

2016-06-14 Thread Rob Herring
On Fri, Jun 10, 2016 at 09:52:20PM -0700, Bjorn Andersson wrote: > PAS command 10 is used to assert and deassert the MSS reset via > TrustZone, expose this as a reset-controller to follow the non-secure > case where GCC exposes this control. > > Signed-off-by: Bjorn Andersson > --- >

Re: [PATCH v4 0/1] pstore/ram: add Device Tree bindings

2016-06-14 Thread Rob Herring
On Fri, Jun 10, 2016 at 03:50:58PM -0700, Kees Cook wrote: > This is a "v4" of Greg Hackmann's DT bindings for ramoops. This is > what I'm going to land in the pstore tree unless there are strong and > convincing arguments against it. :) > > I made a number of changes based people's feedback, and

Re: [PATCH v4 0/1] pstore/ram: add Device Tree bindings

2016-06-14 Thread Rob Herring
On Fri, Jun 10, 2016 at 03:50:58PM -0700, Kees Cook wrote: > This is a "v4" of Greg Hackmann's DT bindings for ramoops. This is > what I'm going to land in the pstore tree unless there are strong and > convincing arguments against it. :) > > I made a number of changes based people's feedback, and

Re: [PATCH 3.2 00/46] 3.2.81-rc1 review

2016-06-14 Thread Sudip Mukherjee
On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.2.81 release. There are 46 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should

Re: [PATCH 3.2 00/46] 3.2.81-rc1 review

2016-06-14 Thread Sudip Mukherjee
On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.2.81 release. There are 46 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should

mm: BUG allocating pages

2016-06-14 Thread Sasha Levin
B W 4.7.0-rc3-next-20160614-sasha-00032-g8e3c1a2-dirty #3105 [ 708.554605] task: 8803d2648000 ti: 8800c677 task.ti: 8800c677 [ 708.555782] RIP: __rmqueue (include/linux/page-flags.h:646 mm/page_alloc.c:705 mm/page_alloc.c:1797 mm/page_alloc.c:2166) [ 708.557174

mm: BUG allocating pages

2016-06-14 Thread Sasha Levin
B W 4.7.0-rc3-next-20160614-sasha-00032-g8e3c1a2-dirty #3105 [ 708.554605] task: 8803d2648000 ti: 8800c677 task.ti: 8800c677 [ 708.555782] RIP: __rmqueue (include/linux/page-flags.h:646 mm/page_alloc.c:705 mm/page_alloc.c:1797 mm/page_alloc.c:2166) [ 708.557174

Re: [PATCH 06/13] irq: add a helper spread an affinity mask for MSI/MSI-X vectors

2016-06-14 Thread Guilherme G. Piccoli
On 06/14/2016 04:58 PM, Christoph Hellwig wrote: This is lifted from the blk-mq code and adopted to use the affinity mask concept just intruced in the irq handling code. Very nice patch Christoph, thanks. There's a little typo above, on "intruced". Signed-off-by: Christoph Hellwig

Re: [PATCH 06/13] irq: add a helper spread an affinity mask for MSI/MSI-X vectors

2016-06-14 Thread Guilherme G. Piccoli
On 06/14/2016 04:58 PM, Christoph Hellwig wrote: This is lifted from the blk-mq code and adopted to use the affinity mask concept just intruced in the irq handling code. Very nice patch Christoph, thanks. There's a little typo above, on "intruced". Signed-off-by: Christoph Hellwig ---

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add addressing mode to info

2016-06-14 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> @@ -3681,7 +3681,7 @@ mv88e6xxx_smi_detect(struct device *dev, struct >> mii_bus *bus, int sw_addr, >> u16 id; >> >> ops = _smi_direct_ops; >> -if (sw_addr > 0) >> +if (sw_addr > 0 && info->flags & MV88E6XXX_FLAG_MULTI_CHIP)

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add addressing mode to info

2016-06-14 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> @@ -3681,7 +3681,7 @@ mv88e6xxx_smi_detect(struct device *dev, struct >> mii_bus *bus, int sw_addr, >> u16 id; >> >> ops = _smi_direct_ops; >> -if (sw_addr > 0) >> +if (sw_addr > 0 && info->flags & MV88E6XXX_FLAG_MULTI_CHIP) >>

Re: [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add SMI detection helper

2016-06-14 Thread Andrew Lunn
On Tue, Jun 14, 2016 at 02:31:50PM -0400, Vivien Didelot wrote: > Extract the allocation and switch ID reading code used by both legacy > and new probing into an helper function which uses a info structure to > describe how to access the switch ID register. > > Signed-off-by: Vivien Didelot

Re: [PATCH v2 net-next v2 09/12] net: dsa: mv88e6xxx: add SMI detection helper

2016-06-14 Thread Andrew Lunn
On Tue, Jun 14, 2016 at 02:31:50PM -0400, Vivien Didelot wrote: > Extract the allocation and switch ID reading code used by both legacy > and new probing into an helper function which uses a info structure to > describe how to access the switch ID register. > > Signed-off-by: Vivien Didelot >

Re: [PATCH 02/48] ARM: at91: Document new TCB bindings

2016-06-14 Thread Rob Herring
On Sat, Jun 11, 2016 at 12:03:05AM +0200, Alexandre Belloni wrote: > The current binding for the TCB is not flexible enough for some use cases > and prevents proper utilization of all the channels. > > Cc: Daniel Lezcano > Cc: Thierry Reding

Re: [PATCH 02/48] ARM: at91: Document new TCB bindings

2016-06-14 Thread Rob Herring
On Sat, Jun 11, 2016 at 12:03:05AM +0200, Alexandre Belloni wrote: > The current binding for the TCB is not flexible enough for some use cases > and prevents proper utilization of all the channels. > > Cc: Daniel Lezcano > Cc: Thierry Reding > Cc: linux-...@vger.kernel.org > Cc: Rob Herring >

Re: [PATCH v2 net-next v2 10/12] net: dsa: mv88e6xxx: iterate on compatible info

2016-06-14 Thread Andrew Lunn
On Tue, Jun 14, 2016 at 02:31:51PM -0400, Vivien Didelot wrote: > With legacy probing, we cannot have a compatible info structure. We have > to guess it. Instead of using only the first info structure of the info > table, iterate over the compatible data. > > That way, the legacy code will

Re: [PATCH v2 net-next v2 10/12] net: dsa: mv88e6xxx: iterate on compatible info

2016-06-14 Thread Andrew Lunn
On Tue, Jun 14, 2016 at 02:31:51PM -0400, Vivien Didelot wrote: > With legacy probing, we cannot have a compatible info structure. We have > to guess it. Instead of using only the first info structure of the info > table, iterate over the compatible data. > > That way, the legacy code will

Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC

2016-06-14 Thread Suravee Suthikulanit
On 6/14/2016 4:22 PM, Paolo Bonzini wrote: - Original Message - From: "Suravee Suthikulanit" To: "Paolo Bonzini" , linux-kernel@vger.kernel.org, k...@vger.kernel.org Cc: rkrc...@redhat.com Sent: Tuesday, June 14, 2016 8:20:30 PM

Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC

2016-06-14 Thread Suravee Suthikulanit
On 6/14/2016 4:22 PM, Paolo Bonzini wrote: - Original Message - From: "Suravee Suthikulanit" To: "Paolo Bonzini" , linux-kernel@vger.kernel.org, k...@vger.kernel.org Cc: rkrc...@redhat.com Sent: Tuesday, June 14, 2016 8:20:30 PM Subject: Re: [PATCH] KVM: SVM: compile out AVIC if

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Dave Hansen
On 06/14/2016 01:16 PM, Nadav Amit wrote: > Dave Hansen wrote: > >> On 06/14/2016 09:47 AM, Nadav Amit wrote: >>> Lukasz Anaczkowski wrote: >>> > From: Andi Kleen > +void fix_pte_leak(struct mm_struct *mm,

Re: [PATCH] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Dave Hansen
On 06/14/2016 01:16 PM, Nadav Amit wrote: > Dave Hansen wrote: > >> On 06/14/2016 09:47 AM, Nadav Amit wrote: >>> Lukasz Anaczkowski wrote: >>> > From: Andi Kleen > +void fix_pte_leak(struct mm_struct *mm, unsigned long addr, pte_t *ptep) > +{ >>> Here there should be a call to

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add addressing mode to info

2016-06-14 Thread Andrew Lunn
> @@ -3681,7 +3681,7 @@ mv88e6xxx_smi_detect(struct device *dev, struct mii_bus > *bus, int sw_addr, > u16 id; > > ops = _smi_direct_ops; > - if (sw_addr > 0) > + if (sw_addr > 0 && info->flags & MV88E6XXX_FLAG_MULTI_CHIP) > ops = _smi_indirect_ops; Hi Vivien

Re: [PATCH v2 net-next v2 12/12] net: dsa: mv88e6xxx: add addressing mode to info

2016-06-14 Thread Andrew Lunn
> @@ -3681,7 +3681,7 @@ mv88e6xxx_smi_detect(struct device *dev, struct mii_bus > *bus, int sw_addr, > u16 id; > > ops = _smi_direct_ops; > - if (sw_addr > 0) > + if (sw_addr > 0 && info->flags & MV88E6XXX_FLAG_MULTI_CHIP) > ops = _smi_indirect_ops; Hi Vivien

Re: [RFC 0/4] Intel Integrated Sensor Hub Support (ISH)

2016-06-14 Thread Grant Likely
On Tue, Jun 14, 2016 at 6:01 PM, Bastien Nocera wrote: > On Tue, 2016-06-14 at 17:08 +0100, Grant Likely wrote: >> On Tue, Jun 14, 2016 at 4:12 PM, Bastien Nocera >> wrote: >> > On Tue, 2016-06-14 at 14:44 +0100, Grant Likely wrote: >> > > On Fri, Jun 10,

Re: [RFC 0/4] Intel Integrated Sensor Hub Support (ISH)

2016-06-14 Thread Grant Likely
On Tue, Jun 14, 2016 at 6:01 PM, Bastien Nocera wrote: > On Tue, 2016-06-14 at 17:08 +0100, Grant Likely wrote: >> On Tue, Jun 14, 2016 at 4:12 PM, Bastien Nocera >> wrote: >> > On Tue, 2016-06-14 at 14:44 +0100, Grant Likely wrote: >> > > On Fri, Jun 10, 2016 at 4:27 PM, Bastien Nocera > > > t>

Re: [PATCH 1/1] modules: add ro_after_init support

2016-06-14 Thread Kees Cook
On Mon, Jun 13, 2016 at 5:13 PM, Jessica Yu wrote: > Add ro_after_init support for modules by adding a new page-aligned section > in the module layout (after rodata) for ro_after_init data and enabling RO > protection for that section after module init runs. > > Signed-off-by:

Re: [PATCH 1/1] modules: add ro_after_init support

2016-06-14 Thread Kees Cook
On Mon, Jun 13, 2016 at 5:13 PM, Jessica Yu wrote: > Add ro_after_init support for modules by adding a new page-aligned section > in the module layout (after rodata) for ro_after_init data and enabling RO > protection for that section after module init runs. > > Signed-off-by: Jessica Yu This

Re: [PATCH 0/7] Fixes for liblockdep

2016-06-14 Thread Sasha Levin
On 06/14/2016 04:44 PM, Ben Hutchings wrote: > Here are a number of fixes for liblockdep. The first three need to > go into 4.7 and 4.6-stable; the second should probably go to all > stable branches. Thanks Ben! I've added it all to the queue and will send it along. Thanks, Sasha

Re: [PATCH 0/7] Fixes for liblockdep

2016-06-14 Thread Sasha Levin
On 06/14/2016 04:44 PM, Ben Hutchings wrote: > Here are a number of fixes for liblockdep. The first three need to > go into 4.7 and 4.6-stable; the second should probably go to all > stable branches. Thanks Ben! I've added it all to the queue and will send it along. Thanks, Sasha

Re: [PATCH 1/7] liblockdep: Fix undefined symbol prandom_u32

2016-06-14 Thread Sasha Levin
On 06/14/2016 04:47 PM, Ben Hutchings wrote: > __lock_pin_lock() now calls prandom_u32() which is not defined in > liblockdep. __lock_pin_lock() and its caller lock_pin_lock() are dead > code in liblockdep, but we still need to provide a definition of > prandom_u32() in case lazy binding is

Re: [PATCH 1/7] liblockdep: Fix undefined symbol prandom_u32

2016-06-14 Thread Sasha Levin
On 06/14/2016 04:47 PM, Ben Hutchings wrote: > __lock_pin_lock() now calls prandom_u32() which is not defined in > liblockdep. __lock_pin_lock() and its caller lock_pin_lock() are dead > code in liblockdep, but we still need to provide a definition of > prandom_u32() in case lazy binding is

Re: [PATCH v3 2/3] LSM: module hierarchy in /proc/.../attr

2016-06-14 Thread Kees Cook
On Tue, Jun 14, 2016 at 12:27 PM, Casey Schaufler wrote: > On 6/14/2016 11:43 AM, Kees Cook wrote: >> On Fri, Jun 10, 2016 at 2:25 PM, Casey Schaufler >> wrote: >>> Subject: [PATCH v3 2/3] LSM: module hierarchy in /proc/.../attr >>> >>> Back in

Re: [PATCH v3 2/3] LSM: module hierarchy in /proc/.../attr

2016-06-14 Thread Kees Cook
On Tue, Jun 14, 2016 at 12:27 PM, Casey Schaufler wrote: > On 6/14/2016 11:43 AM, Kees Cook wrote: >> On Fri, Jun 10, 2016 at 2:25 PM, Casey Schaufler >> wrote: >>> Subject: [PATCH v3 2/3] LSM: module hierarchy in /proc/.../attr >>> >>> Back in 2007 I made what turned out to be a rather serious

Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface

2016-06-14 Thread Ben Hutchings
On Tue, 2016-06-14 at 22:11 +0100, Sudip Mukherjee wrote: > On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: > > 3.2.81-rc1 review patch.  If anyone has any objections, please let > > me know. > > > > -- > > > > From: Jason Gunthorpe > > >

Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface

2016-06-14 Thread Ben Hutchings
On Tue, 2016-06-14 at 22:11 +0100, Sudip Mukherjee wrote: > On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: > > 3.2.81-rc1 review patch.  If anyone has any objections, please let > > me know. > > > > -- > > > > From: Jason Gunthorpe > > > > commit

Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC

2016-06-14 Thread Paolo Bonzini
- Original Message - > From: "Suravee Suthikulanit" > To: "Paolo Bonzini" , linux-kernel@vger.kernel.org, > k...@vger.kernel.org > Cc: rkrc...@redhat.com > Sent: Tuesday, June 14, 2016 8:20:30 PM > Subject: Re: [PATCH] KVM: SVM:

Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC

2016-06-14 Thread Paolo Bonzini
- Original Message - > From: "Suravee Suthikulanit" > To: "Paolo Bonzini" , linux-kernel@vger.kernel.org, > k...@vger.kernel.org > Cc: rkrc...@redhat.com > Sent: Tuesday, June 14, 2016 8:20:30 PM > Subject: Re: [PATCH] KVM: SVM: compile out AVIC if !CONFIG_X86_LOCAL_APIC > > Hi Paolo,

Travellers Email List

2016-06-14 Thread Jenny Jordan
Hi, Would you be interested in acquiring an email list of "Travellers Email List" from USA? We have data for Gardening Email List, Investors Email List, Health and Fitness Email List, and many more. Choose the best one that meets your need. We provide you with current and active contact

Travellers Email List

2016-06-14 Thread Jenny Jordan
Hi, Would you be interested in acquiring an email list of "Travellers Email List" from USA? We have data for Gardening Email List, Investors Email List, Health and Fitness Email List, and many more. Choose the best one that meets your need. We provide you with current and active contact

[PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module

2016-06-14 Thread Javier Martinez Canillas
The driver is for a trackpad device so is not needed for booting and makes more sense to have it as module to reduce the kernel image size. It was probably enabled as built-in because module autoload was not working when the I2C device was registered by OF but this got fixed in commit

[PATCH] ARM: multi_v7_defconfig: Build Atmel maXTouch driver as a module

2016-06-14 Thread Javier Martinez Canillas
The driver is for a trackpad device so is not needed for booting and makes more sense to have it as module to reduce the kernel image size. It was probably enabled as built-in because module autoload was not working when the I2C device was registered by OF but this got fixed in commit

Re: [PATCH 21/21] time: Delete CURRENT_TIME_SEC and CURRENT_TIME macro

2016-06-14 Thread John Stultz
On Wed, Jun 8, 2016 at 10:05 PM, Deepa Dinamani wrote: > All uses of these macors have been replaced by other > time functions. > These macros are also not y2038 safe. > And, all its usecases can be fulfilled by y2038 > safe ktime_get_* variants. > Assuming the prereqs

Re: [PATCH 21/21] time: Delete CURRENT_TIME_SEC and CURRENT_TIME macro

2016-06-14 Thread John Stultz
On Wed, Jun 8, 2016 at 10:05 PM, Deepa Dinamani wrote: > All uses of these macors have been replaced by other > time functions. > These macros are also not y2038 safe. > And, all its usecases can be fulfilled by y2038 > safe ktime_get_* variants. > Assuming the prereqs are in place: Acked-by:

Re: [PATCH v2] kernel/kcov: unproxify debugfs file's fops

2016-06-14 Thread Sasha Levin
On 05/24/2016 10:39 AM, Greg Kroah-Hartman wrote: > On Tue, May 24, 2016 at 02:05:05PM +0200, Nicolai Stange wrote: >> > Since commit 49d200deaa68 ("debugfs: prevent access to removed files' >> > private data"), a debugfs file's file_operations methods get proxied >> > through lifetime aware

Re: [PATCH v2] kernel/kcov: unproxify debugfs file's fops

2016-06-14 Thread Sasha Levin
On 05/24/2016 10:39 AM, Greg Kroah-Hartman wrote: > On Tue, May 24, 2016 at 02:05:05PM +0200, Nicolai Stange wrote: >> > Since commit 49d200deaa68 ("debugfs: prevent access to removed files' >> > private data"), a debugfs file's file_operations methods get proxied >> > through lifetime aware

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-14 Thread Arnd Bergmann
On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: > On 2016/6/13 17:06, Arnd Bergmann wrote: > > On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: > > You tx function uses BQL to optimize the queue length, and that > > is great. You also check xmit reclaim for rx interrupts, so >

Re: [PATCH 3/3] net: hisilicon: Add Fast Ethernet MAC driver

2016-06-14 Thread Arnd Bergmann
On Tuesday, June 14, 2016 9:17:44 PM CEST Li Dongpo wrote: > On 2016/6/13 17:06, Arnd Bergmann wrote: > > On Monday, June 13, 2016 2:07:56 PM CEST Dongpo Li wrote: > > You tx function uses BQL to optimize the queue length, and that > > is great. You also check xmit reclaim for rx interrupts, so >

Re: [PATCH 15/21] time: Add time64_to_tm()

2016-06-14 Thread John Stultz
On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani wrote: > time_to_tm() takes time_t as an argument. > time_t is not y2038 safe. > Add time64_to_tm() that takes time64_t as an argument > which is y2038 safe. > The plan is to eventually replace all calls to time_to_tm() > by

Re: [PATCH 15/21] time: Add time64_to_tm()

2016-06-14 Thread John Stultz
On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani wrote: > time_to_tm() takes time_t as an argument. > time_t is not y2038 safe. > Add time64_to_tm() that takes time64_t as an argument > which is y2038 safe. > The plan is to eventually replace all calls to time_to_tm() > by time64_to_tm(). > >

Re: [PATCH v2 net-next v2 05/12] net: dsa: mv88e6xxx: add switch register helpers

2016-06-14 Thread Andrew Lunn
On Tue, Jun 14, 2016 at 02:31:46PM -0400, Vivien Didelot wrote: > The mixed assignments, allocations and registrations in the probe code > make it hard to follow the logic and figure out what is DSA or chip > specific. > > Extract the struct dsa_switch related code in a simple >

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-14 Thread Julia Lawall
On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > On Tue, Jun 14, 2016 at 10:47:32PM +0200, Julia Lawall wrote: > > > > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > > > On Tue, Jun 14, 2016 at 07:22:03AM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Mon, 13 Jun 2016, Luis

Re: [patch 13/20] timer: Switch to a non cascading wheel

2016-06-14 Thread Eric Dumazet
On Tue, Jun 14, 2016 at 1:42 PM, Peter Zijlstra wrote: > On Tue, Jun 14, 2016 at 08:05:49PM +0200, Thomas Gleixner wrote: >> On Tue, 14 Jun 2016, Arjan van de Ven wrote: >> >> > evaluating a 120 hours timer ever 37 hours to see if it should fire... >> > not too horrid. >> >>

Re: [PATCH v2 net-next v2 05/12] net: dsa: mv88e6xxx: add switch register helpers

2016-06-14 Thread Andrew Lunn
On Tue, Jun 14, 2016 at 02:31:46PM -0400, Vivien Didelot wrote: > The mixed assignments, allocations and registrations in the probe code > make it hard to follow the logic and figure out what is DSA or chip > specific. > > Extract the struct dsa_switch related code in a simple >

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-14 Thread Julia Lawall
On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > On Tue, Jun 14, 2016 at 10:47:32PM +0200, Julia Lawall wrote: > > > > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > > > On Tue, Jun 14, 2016 at 07:22:03AM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Mon, 13 Jun 2016, Luis

Re: [patch 13/20] timer: Switch to a non cascading wheel

2016-06-14 Thread Eric Dumazet
On Tue, Jun 14, 2016 at 1:42 PM, Peter Zijlstra wrote: > On Tue, Jun 14, 2016 at 08:05:49PM +0200, Thomas Gleixner wrote: >> On Tue, 14 Jun 2016, Arjan van de Ven wrote: >> >> > evaluating a 120 hours timer ever 37 hours to see if it should fire... >> > not too horrid. >> >> Well that thing is

Re: [PATCH v2 net-next v2 01/12] net: dsa: mv88e6xxx: fix style issues

2016-06-14 Thread Andrew Lunn
On Tue, Jun 14, 2016 at 02:31:42PM -0400, Vivien Didelot wrote: > This patch fixes 5 style problems reported by checkpatch: > > WARNING: suspect code indent for conditional statements (8, 24) > #492: FILE: drivers/net/dsa/mv88e6xxx.c:492: > + if (phydev->link) > +

Re: [PATCH v2] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread H. Peter Anvin
On June 14, 2016 2:02:55 PM PDT, Borislav Petkov wrote: >On Tue, Jun 14, 2016 at 01:54:25PM -0700, H. Peter Anvin wrote: >> There was that. It is still possible that we end up with NOP a JMP >> right before another JMP; we could perhaps make the patching code >> smarter and see

Re: [PATCH v2 net-next v2 01/12] net: dsa: mv88e6xxx: fix style issues

2016-06-14 Thread Andrew Lunn
On Tue, Jun 14, 2016 at 02:31:42PM -0400, Vivien Didelot wrote: > This patch fixes 5 style problems reported by checkpatch: > > WARNING: suspect code indent for conditional statements (8, 24) > #492: FILE: drivers/net/dsa/mv88e6xxx.c:492: > + if (phydev->link) > +

Re: [PATCH v2] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread H. Peter Anvin
On June 14, 2016 2:02:55 PM PDT, Borislav Petkov wrote: >On Tue, Jun 14, 2016 at 01:54:25PM -0700, H. Peter Anvin wrote: >> There was that. It is still possible that we end up with NOP a JMP >> right before another JMP; we could perhaps make the patching code >> smarter and see if we have a JMP

Re: [PATCH 2/7] liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain::depth

2016-06-14 Thread Peter Zijlstra
On Tue, Jun 14, 2016 at 09:47:53PM +0100, Ben Hutchings wrote: > Even before that commit, which reduced lock_chain::depth from 8 bits > to 6, MAX_LOCK_DEPTH was too large. > -#define MAX_LOCK_DEPTH 2000UL > +#define MAX_LOCK_DEPTH 63UL So per that commit; there still is a 4 byte hole we could

Re: [PATCH 2/7] liblockdep: Reduce MAX_LOCK_DEPTH to avoid overflowing lock_chain::depth

2016-06-14 Thread Peter Zijlstra
On Tue, Jun 14, 2016 at 09:47:53PM +0100, Ben Hutchings wrote: > Even before that commit, which reduced lock_chain::depth from 8 bits > to 6, MAX_LOCK_DEPTH was too large. > -#define MAX_LOCK_DEPTH 2000UL > +#define MAX_LOCK_DEPTH 63UL So per that commit; there still is a 4 byte hole we could

Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface

2016-06-14 Thread Sudip Mukherjee
On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: 3.2.81-rc1 review patch. If anyone has any objections, please let me know. -- From: Jason Gunthorpe commit e6bd18f57aad1a2d1ef40e646d03ed0f2515c9e3 upstream. The drivers/infiniband stack

Re: [PATCH 3.2 31/46] IB/security: Restrict use of the write() interface

2016-06-14 Thread Sudip Mukherjee
On Sunday 12 June 2016 10:34 PM, Ben Hutchings wrote: 3.2.81-rc1 review patch. If anyone has any objections, please let me know. -- From: Jason Gunthorpe commit e6bd18f57aad1a2d1ef40e646d03ed0f2515c9e3 upstream. The drivers/infiniband stack uses write() as a replacement for

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-14 Thread Luis R. Rodriguez
On Tue, Jun 14, 2016 at 10:47:32PM +0200, Julia Lawall wrote: > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > On Tue, Jun 14, 2016 at 07:22:03AM +0200, Julia Lawall wrote: > > > > > > > > > On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > On Mon, Jun 13, 2016 at

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-14 Thread Luis R. Rodriguez
On Tue, Jun 14, 2016 at 10:47:32PM +0200, Julia Lawall wrote: > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > On Tue, Jun 14, 2016 at 07:22:03AM +0200, Julia Lawall wrote: > > > > > > > > > On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > On Mon, Jun 13, 2016 at

Re: [PATCH v2] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread H. Peter Anvin
On 06/14/16 14:02, Borislav Petkov wrote: > On Tue, Jun 14, 2016 at 01:54:25PM -0700, H. Peter Anvin wrote: >> There was that. It is still possible that we end up with NOP a JMP >> right before another JMP; we could perhaps make the patching code >> smarter and see if we have a JMP immediately

Re: [PATCH v2] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread H. Peter Anvin
On 06/14/16 14:02, Borislav Petkov wrote: > On Tue, Jun 14, 2016 at 01:54:25PM -0700, H. Peter Anvin wrote: >> There was that. It is still possible that we end up with NOP a JMP >> right before another JMP; we could perhaps make the patching code >> smarter and see if we have a JMP immediately

Re: [PATCH v3 3/3] LSM: Add context interface for proc attr

2016-06-14 Thread Kees Cook
On Tue, Jun 14, 2016 at 1:19 PM, Casey Schaufler wrote: > On 6/14/2016 11:57 AM, Kees Cook wrote: >> it's okay.) Also, should lsm == NULL be checked early and >> rejected/skipped so the lsm != NULL test isn't needed in both loops? > > Ah, you miss the nuance of the code.

Re: [PATCH v3 3/3] LSM: Add context interface for proc attr

2016-06-14 Thread Kees Cook
On Tue, Jun 14, 2016 at 1:19 PM, Casey Schaufler wrote: > On 6/14/2016 11:57 AM, Kees Cook wrote: >> it's okay.) Also, should lsm == NULL be checked early and >> rejected/skipped so the lsm != NULL test isn't needed in both loops? > > Ah, you miss the nuance of the code. NULL is an acceptance

RE: [PATCH v4 0/8] Replay Protected Memory Block (RPMB) subsystem

2016-06-14 Thread Winkler, Tomas
>>> wrote: >>> > Few storage technology such is EMMC, UFS, and NVMe support RPMB >>> >hardware partition with common protocol and frame layout. >>> > The RPMB partition cannot be accessed via standard block layer, but >>> >by a set of specific commands: WRITE, READ, GET_WRITE_COUNTER, and >>>

RE: [PATCH v4 0/8] Replay Protected Memory Block (RPMB) subsystem

2016-06-14 Thread Winkler, Tomas
>>> wrote: >>> > Few storage technology such is EMMC, UFS, and NVMe support RPMB >>> >hardware partition with common protocol and frame layout. >>> > The RPMB partition cannot be accessed via standard block layer, but >>> >by a set of specific commands: WRITE, READ, GET_WRITE_COUNTER, and >>>

Re: [PATCH 1/1] kernel/sysctl.c: avoid overflow

2016-06-14 Thread Kees Cook
On Tue, Jun 14, 2016 at 1:19 PM, Andrew Morton wrote: > On Sat, 11 Jun 2016 03:33:08 +0200 Heinrich Schuchardt > wrote: > >> An undetected overflow may occur in do_proc_dointvec_minmax_conv_param. >> >> ... >> >> --- a/kernel/sysctl.c >> +++

Re: [PATCH 1/1] kernel/sysctl.c: avoid overflow

2016-06-14 Thread Kees Cook
On Tue, Jun 14, 2016 at 1:19 PM, Andrew Morton wrote: > On Sat, 11 Jun 2016 03:33:08 +0200 Heinrich Schuchardt > wrote: > >> An undetected overflow may occur in do_proc_dointvec_minmax_conv_param. >> >> ... >> >> --- a/kernel/sysctl.c >> +++ b/kernel/sysctl.c >> @@ -2313,7 +2313,17 @@ static

[PATCH v2] audit: add fields to exclude filter by reusing user filter

2016-06-14 Thread Richard Guy Briggs
RFE: add additional fields for use in audit filter exclude rules https://github.com/linux-audit/audit-kernel/issues/5 Re-factor and combine audit_filter_type() with audit_filter_user() to use audit_filter_user_rules() to enable the exclude filter to additionally filter on PID, UID, GID, AUID,

[PATCH v2] audit: add fields to exclude filter by reusing user filter

2016-06-14 Thread Richard Guy Briggs
RFE: add additional fields for use in audit filter exclude rules https://github.com/linux-audit/audit-kernel/issues/5 Re-factor and combine audit_filter_type() with audit_filter_user() to use audit_filter_user_rules() to enable the exclude filter to additionally filter on PID, UID, GID, AUID,

[PATCH] audit: catch errors from audit_filter_rules field checks

2016-06-14 Thread Richard Guy Briggs
In the case of an error returned from a field check in an audit filter syscall rule, it is treated as a match and the rule action is honoured. This could cause a rule with a default of NEVER and an selinux field check error to avoid logging. Recommend matching with an action of ALWAYS to catch

[PATCH] audit: catch errors from audit_filter_rules field checks

2016-06-14 Thread Richard Guy Briggs
In the case of an error returned from a field check in an audit filter syscall rule, it is treated as a match and the rule action is honoured. This could cause a rule with a default of NEVER and an selinux field check error to avoid logging. Recommend matching with an action of ALWAYS to catch

Re: [PATCH v2] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Borislav Petkov
On Tue, Jun 14, 2016 at 01:54:25PM -0700, H. Peter Anvin wrote: > There was that. It is still possible that we end up with NOP a JMP > right before another JMP; we could perhaps make the patching code > smarter and see if we have a JMP immediately after. Yeah, I still can't get reproduce that

Re: [PATCH v2] Linux VM workaround for Knights Landing A/D leak

2016-06-14 Thread Borislav Petkov
On Tue, Jun 14, 2016 at 01:54:25PM -0700, H. Peter Anvin wrote: > There was that. It is still possible that we end up with NOP a JMP > right before another JMP; we could perhaps make the patching code > smarter and see if we have a JMP immediately after. Yeah, I still can't get reproduce that

Re: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-14 Thread Logan Gunthorpe
On 14/06/16 01:33 PM, Allen Hubbe wrote: >> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c >> index cba31fd..9bebd0d 100644 >> --- a/drivers/ntb/test/ntb_tool.c >> +++ b/drivers/ntb/test/ntb_tool.c >> @@ -59,6 +59,13 @@ >> * >> * Eg: check if clearing the doorbell

Re: [PATCH v2 6/8] ntb_tool: Add link status and files to debugfs

2016-06-14 Thread Logan Gunthorpe
On 14/06/16 01:33 PM, Allen Hubbe wrote: >> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c >> index cba31fd..9bebd0d 100644 >> --- a/drivers/ntb/test/ntb_tool.c >> +++ b/drivers/ntb/test/ntb_tool.c >> @@ -59,6 +59,13 @@ >> * >> * Eg: check if clearing the doorbell

Re: [PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: read switch ID from info

2016-06-14 Thread Vivien Didelot
Hi, Sergei Shtylyov writes: >> -id = mv88e6xxx_reg_read(ps, REG_PORT(0), PORT_SWITCH_ID); >> +of_id = of_match_node(mv88e6xxx_of_id_table, np); > > You could use of_device_get_match_data() here. > >> +if (!of_id) >> +return

Re: [PATCH v2 net-next v2 08/12] net: dsa: mv88e6xxx: read switch ID from info

2016-06-14 Thread Vivien Didelot
Hi, Sergei Shtylyov writes: >> -id = mv88e6xxx_reg_read(ps, REG_PORT(0), PORT_SWITCH_ID); >> +of_id = of_match_node(mv88e6xxx_of_id_table, np); > > You could use of_device_get_match_data() here. > >> +if (!of_id) >> +return -EINVAL; >> + >> +info = (const struct

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-06-14 Thread Trent Piepho
On Mon, 2016-06-13 at 14:35 -0500, atull wrote: > > > + > > > + /* Allow bridge to be visible to L3 masters or not */ > > > + if (priv->remap_mask) { > > > + priv->l3_remap_value |= ALT_L3_REMAP_MPUZERO_MSK; > > > > Doesn't seem like this belongs here. I realize the write-only register >

Re: [PATCH v16 6/6] ARM: socfpga: fpga bridge driver support

2016-06-14 Thread Trent Piepho
On Mon, 2016-06-13 at 14:35 -0500, atull wrote: > > > + > > > + /* Allow bridge to be visible to L3 masters or not */ > > > + if (priv->remap_mask) { > > > + priv->l3_remap_value |= ALT_L3_REMAP_MPUZERO_MSK; > > > > Doesn't seem like this belongs here. I realize the write-only register >

Re: [Y2038] [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps

2016-06-14 Thread Arnd Bergmann
On Tuesday, June 14, 2016 10:55:39 AM CEST Deepa Dinamani wrote: > On Fri, Jun 10, 2016 at 3:19 PM, Arnd Bergmann wrote: > > On Thursday, June 9, 2016 11:45:01 AM CEST Linus Torvalds wrote: > >> On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani > >> wrote: >

Re: [Y2038] [PATCH 02/21] fs: ext4: Use current_fs_time() for inode timestamps

2016-06-14 Thread Arnd Bergmann
On Tuesday, June 14, 2016 10:55:39 AM CEST Deepa Dinamani wrote: > On Fri, Jun 10, 2016 at 3:19 PM, Arnd Bergmann wrote: > > On Thursday, June 9, 2016 11:45:01 AM CEST Linus Torvalds wrote: > >> On Wed, Jun 8, 2016 at 10:04 PM, Deepa Dinamani > >> wrote: > >> > CURRENT_TIME_SEC and CURRENT_TIME

<    1   2   3   4   5   6   7   8   9   10   >