Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Rafał Miłecki
On 18 July 2016 at 07:40, Peter Chen wrote: > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: >> On 18 July 2016 at 04:31, Peter Chen wrote: >> > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: >> >> + >> >> +usbport

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Rafał Miłecki
On 18 July 2016 at 07:40, Peter Chen wrote: > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: >> On 18 July 2016 at 04:31, Peter Chen wrote: >> > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: >> >> + >> >> +usbport trigger: >> >> +- usb-ports : List of USB ports

linux-next: manual merge of the kvm tree with the powerpc tree

2016-07-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the kvm tree got a conflict in: arch/powerpc/kernel/idle_book3s.S between commit: 69c592ed40d3 ("powerpc/opal: Add real mode call wrappers") from the powerpc tree and commit: fd7bacbca47a ("KVM: PPC: Book3S HV: Fix TB corruption in guest exit path on

linux-next: manual merge of the kvm tree with the powerpc tree

2016-07-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the kvm tree got a conflict in: arch/powerpc/kernel/idle_book3s.S between commit: 69c592ed40d3 ("powerpc/opal: Add real mode call wrappers") from the powerpc tree and commit: fd7bacbca47a ("KVM: PPC: Book3S HV: Fix TB corruption in guest exit path on

linux-next: manual merge of the kvm tree with the powerpc tree

2016-07-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the kvm tree got a conflict in: arch/powerpc/kernel/exceptions-64s.S between commit: 9baaef0a22c8 ("powerpc/irq: Add support for HV virtualization interrupts") from the powerpc tree and commit: fd7bacbca47a ("KVM: PPC: Book3S HV: Fix TB corruption in

linux-next: manual merge of the kvm tree with the powerpc tree

2016-07-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the kvm tree got a conflict in: arch/powerpc/kernel/exceptions-64s.S between commit: 9baaef0a22c8 ("powerpc/irq: Add support for HV virtualization interrupts") from the powerpc tree and commit: fd7bacbca47a ("KVM: PPC: Book3S HV: Fix TB corruption in

Re: [patch] phy: phy-brcm-sata: fix a loop timeout

2016-07-17 Thread Yendapally Reddy Dhananjaya Reddy
On Tue, Jun 21, 2016 at 2:07 PM, Dan Carpenter wrote: > Since this loop is a post op then it means we end with "try == -1" but > afterward we test for if it's zero. Fix this by changing to a pre-op so > we end on zero. Thanks Dan. That should be pre-op. Thnaks

Re: [patch] phy: phy-brcm-sata: fix a loop timeout

2016-07-17 Thread Yendapally Reddy Dhananjaya Reddy
On Tue, Jun 21, 2016 at 2:07 PM, Dan Carpenter wrote: > Since this loop is a post op then it means we end with "try == -1" but > afterward we test for if it's zero. Fix this by changing to a pre-op so > we end on zero. Thanks Dan. That should be pre-op. Thnaks Dhananjay > > Fixes: 024812889ad1

Re: [PATCH 04/10] phy: da8xx-usb: new driver for DA8xx SoC USB PHY

2016-07-17 Thread Kishon Vijay Abraham I
Hi Arnd, On Saturday 16 July 2016 02:44 AM, Arnd Bergmann wrote: > On Tuesday, July 5, 2016 10:53:51 AM CEST Kishon Vijay Abraham I wrote: >> From: David Lechner >> >> This is a new phy driver for the SoC USB controllers on the TI DA8xx >> family of microcontrollers. The

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-07-17 Thread Namhyung Kim
Hello, On Sun, Jul 17, 2016 at 10:12:26PM -0700, Kees Cook wrote: > On Sun, Jul 17, 2016 at 9:37 PM, Namhyung Kim wrote: > > The virtio pstore driver provides interface to the pstore subsystem so > > that the guest kernel's log/dump message can be saved on the host > >

Re: [PATCH 04/10] phy: da8xx-usb: new driver for DA8xx SoC USB PHY

2016-07-17 Thread Kishon Vijay Abraham I
Hi Arnd, On Saturday 16 July 2016 02:44 AM, Arnd Bergmann wrote: > On Tuesday, July 5, 2016 10:53:51 AM CEST Kishon Vijay Abraham I wrote: >> From: David Lechner >> >> This is a new phy driver for the SoC USB controllers on the TI DA8xx >> family of microcontrollers. The USB 1.1 PHY is just a

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-07-17 Thread Namhyung Kim
Hello, On Sun, Jul 17, 2016 at 10:12:26PM -0700, Kees Cook wrote: > On Sun, Jul 17, 2016 at 9:37 PM, Namhyung Kim wrote: > > The virtio pstore driver provides interface to the pstore subsystem so > > that the guest kernel's log/dump message can be saved on the host > > machine. Users can access

RE: [PATCH v6 1/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's

2016-07-17 Thread Tan, Jui Nee
> -Original Message- > From: Tan, Jui Nee > Sent: Monday, July 18, 2016 11:35 AM > To: 'Paul Gortmaker' ; > andriy.shevche...@linux.intel.com > Cc: mika.westerb...@linux.intel.com; heikki.kroge...@linux.intel.com; > t...@linutronix.de; mi...@redhat.com; H.

RE: [PATCH v6 1/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's

2016-07-17 Thread Tan, Jui Nee
> -Original Message- > From: Tan, Jui Nee > Sent: Monday, July 18, 2016 11:35 AM > To: 'Paul Gortmaker' ; > andriy.shevche...@linux.intel.com > Cc: mika.westerb...@linux.intel.com; heikki.kroge...@linux.intel.com; > t...@linutronix.de; mi...@redhat.com; H. Peter Anvin ; > X86 ML ;

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Peter Chen
On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: > On 18 July 2016 at 04:31, Peter Chen wrote: > > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: > >> + > >> +usbport trigger: > >> +- usb-ports : List of USB ports that usbport should observed

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Peter Chen
On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: > On 18 July 2016 at 04:31, Peter Chen wrote: > > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: > >> + > >> +usbport trigger: > >> +- usb-ports : List of USB ports that usbport should observed for turning > >> on a >

Re: [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target()

2016-07-17 Thread Joonsoo Kim
On Fri, Jul 15, 2016 at 10:47:06AM +0800, Xishi Qiu wrote: > alloc_migrate_target() is called from migrate_pages(), and the page > is always from user space, so we can add __GFP_HIGHMEM directly. No, all migratable pages are not from user space. For example, blockdev file cache has __GFP_MOVABLE

Re: [PATCH 1/2] mem-hotplug: use GFP_HIGHUSER_MOVABLE in, alloc_migrate_target()

2016-07-17 Thread Joonsoo Kim
On Fri, Jul 15, 2016 at 10:47:06AM +0800, Xishi Qiu wrote: > alloc_migrate_target() is called from migrate_pages(), and the page > is always from user space, so we can add __GFP_HIGHMEM directly. No, all migratable pages are not from user space. For example, blockdev file cache has __GFP_MOVABLE

Re: [patch] mm, compaction: make sure freeing scanner isn't persistently expensive

2016-07-17 Thread Joonsoo Kim
On Mon, Jul 11, 2016 at 04:01:52PM -0700, David Rientjes wrote: > On Thu, 30 Jun 2016, Joonsoo Kim wrote: > > > We need to find a root cause of this problem, first. > > > > I guess that this problem would happen when isolate_freepages_block() > > early stop due to watermark check (if your patch

Re: [patch] mm, compaction: make sure freeing scanner isn't persistently expensive

2016-07-17 Thread Joonsoo Kim
On Mon, Jul 11, 2016 at 04:01:52PM -0700, David Rientjes wrote: > On Thu, 30 Jun 2016, Joonsoo Kim wrote: > > > We need to find a root cause of this problem, first. > > > > I guess that this problem would happen when isolate_freepages_block() > > early stop due to watermark check (if your patch

Re: [PATCH] dwc_eth_qos: Remove deprecated create_singlethread_workqueue

2016-07-17 Thread David Miller
From: Bhaktipriya Shridhar Date: Sat, 16 Jul 2016 13:53:28 +0530 > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > A dedicated workqueue has been used since the workitem viz > lp->txtimeout_reinit is involved in reinitialization if a TX timeout

Re: [PATCH] dwc_eth_qos: Remove deprecated create_singlethread_workqueue

2016-07-17 Thread David Miller
From: Bhaktipriya Shridhar Date: Sat, 16 Jul 2016 13:53:28 +0530 > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > A dedicated workqueue has been used since the workitem viz > lp->txtimeout_reinit is involved in reinitialization if a TX timeout > occurs, which is

linux-next: manual merge of the rcu tree with the tip tree

2016-07-17 Thread Stephen Rothwell
Hi Paul, Today's linux-next merge of the rcu tree got a conflict in: kernel/rcu/tree.c between commit: 4df8374254ea ("rcu: Convert rcutree to hotplug state machine") from the tip tree and commit: 2a84cde733b0 ("rcu: Exact CPU-online tracking for RCU") from the rcu tree. I fixed it up

linux-next: manual merge of the rcu tree with the tip tree

2016-07-17 Thread Stephen Rothwell
Hi Paul, Today's linux-next merge of the rcu tree got a conflict in: kernel/rcu/tree.c between commit: 4df8374254ea ("rcu: Convert rcutree to hotplug state machine") from the tip tree and commit: 2a84cde733b0 ("rcu: Exact CPU-online tracking for RCU") from the rcu tree. I fixed it up

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-17 Thread Dave Young
On 07/18/16 at 06:44am, Borislav Petkov wrote: > On Mon, Jul 18, 2016 at 10:18:09AM +0800, Dave Young wrote: > > I would say avoiding ratelimit during boot make no much sense. Userspace > > can not > > write to /dev/kmsg when system_state == SYSTEM_BOOTING because init process > > has not run

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-17 Thread Dave Young
On 07/18/16 at 06:44am, Borislav Petkov wrote: > On Mon, Jul 18, 2016 at 10:18:09AM +0800, Dave Young wrote: > > I would say avoiding ratelimit during boot make no much sense. Userspace > > can not > > write to /dev/kmsg when system_state == SYSTEM_BOOTING because init process > > has not run

Re: [PATCH/RFC] Re: linux-next: build failure after merge of the luto-misc tree

2016-07-17 Thread Stephen Rothwell
Hi Arnaldo, On Fri, 15 Jul 2016 12:43:26 -0300 Arnaldo Carvalho de Melo wrote: > > Ok, same results, it works, queuing this one, ack? Stephen, does it work > for you? Sorry, no. See my other email. I am cross building (if that makes a difference). -- Cheers, Stephen

Re: [PATCH/RFC] Re: linux-next: build failure after merge of the luto-misc tree

2016-07-17 Thread Stephen Rothwell
Hi Arnaldo, On Fri, 15 Jul 2016 12:43:26 -0300 Arnaldo Carvalho de Melo wrote: > > Ok, same results, it works, queuing this one, ack? Stephen, does it work > for you? Sorry, no. See my other email. I am cross building (if that makes a difference). -- Cheers, Stephen Rothwell

linux-next: build failure after merge of the tip tree

2016-07-17 Thread Stephen Rothwell
Hi all, After merging the tip tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from tools/arch/x86/include/uapi/asm/bitsperlong.h:10:0, from /usr/include/asm-generic/int-ll64.h:11, from

linux-next: build failure after merge of the tip tree

2016-07-17 Thread Stephen Rothwell
Hi all, After merging the tip tree, today's linux-next build (x86_64 allmodconfig) failed like this: In file included from tools/arch/x86/include/uapi/asm/bitsperlong.h:10:0, from /usr/include/asm-generic/int-ll64.h:11, from

Re: linux-next: manual merge of the kspp tree with the arm64 tree

2016-07-17 Thread Kees Cook
On Sun, Jul 17, 2016 at 10:06 PM, Stephen Rothwell wrote: > Hi Kees, > > On Sun, 17 Jul 2016 21:49:40 -0700 Kees Cook wrote: >> >> If I'm reading correctly, this second fixup is wrong. It should read; >> >> kasan_check_read(from, n); >>

Re: linux-next: manual merge of the kspp tree with the arm64 tree

2016-07-17 Thread Kees Cook
On Sun, Jul 17, 2016 at 10:06 PM, Stephen Rothwell wrote: > Hi Kees, > > On Sun, 17 Jul 2016 21:49:40 -0700 Kees Cook wrote: >> >> If I'm reading correctly, this second fixup is wrong. It should read; >> >> kasan_check_read(from, n); >> check_object_size(from, n, true); >> return

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-07-17 Thread Kees Cook
On Sun, Jul 17, 2016 at 9:37 PM, Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest

Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-07-17 Thread Kees Cook
On Sun, Jul 17, 2016 at 9:37 PM, Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest at the next boot

Re: [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

2016-07-17 Thread Juergen Gross
On 16/07/16 22:23, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:42:42 +0200 > > The kfree() function was called in one case by the > scsiback_device_action() function during error handling > even if the passed variable "tmr" contained

Re: [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

2016-07-17 Thread Juergen Gross
On 16/07/16 22:23, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:42:42 +0200 > > The kfree() function was called in one case by the > scsiback_device_action() function during error handling > even if the passed variable "tmr" contained a null pointer. > > Adjust

Re: linux-next: manual merge of the kspp tree with the arm64 tree

2016-07-17 Thread Stephen Rothwell
Hi Kees, On Sun, 17 Jul 2016 21:49:40 -0700 Kees Cook wrote: > > If I'm reading correctly, this second fixup is wrong. It should read; > > kasan_check_read(from, n); > check_object_size(from, n, true); > return __arch_copy_to_user(to, from, n); > > (i.e. fix

Re: linux-next: manual merge of the kspp tree with the arm64 tree

2016-07-17 Thread Stephen Rothwell
Hi Kees, On Sun, 17 Jul 2016 21:49:40 -0700 Kees Cook wrote: > > If I'm reading correctly, this second fixup is wrong. It should read; > > kasan_check_read(from, n); > check_object_size(from, n, true); > return __arch_copy_to_user(to, from, n); > > (i.e. fix double space between

Re: [PATCH 3/3] xen-scsiback: Pass a failure indication as a constant

2016-07-17 Thread Juergen Gross
On 16/07/16 22:24, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:55:01 +0200 > > Pass the constant "FAILED" in a function call directly instead of > using an intialisation for a local variable. > > Signed-off-by: Markus Elfring

Re: [PATCH 3/3] xen-scsiback: Pass a failure indication as a constant

2016-07-17 Thread Juergen Gross
On 16/07/16 22:24, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:55:01 +0200 > > Pass the constant "FAILED" in a function call directly instead of > using an intialisation for a local variable. > > Signed-off-by: Markus Elfring Reviewed-by: Juergen Gross

Re: [PATCH 08/31] mm, vmscan: simplify the logic deciding whether kswapd sleeps

2016-07-17 Thread Joonsoo Kim
On Thu, Jul 14, 2016 at 10:32:09AM +0200, Vlastimil Babka wrote: > On 07/14/2016 07:23 AM, Joonsoo Kim wrote: > >On Fri, Jul 08, 2016 at 11:11:47AM +0100, Mel Gorman wrote: > >>On Fri, Jul 08, 2016 at 11:44:47AM +0900, Joonsoo Kim wrote: > >> > >>It doesn't stop reclaiming for the lower zones.

Re: [PATCH 08/31] mm, vmscan: simplify the logic deciding whether kswapd sleeps

2016-07-17 Thread Joonsoo Kim
On Thu, Jul 14, 2016 at 10:32:09AM +0200, Vlastimil Babka wrote: > On 07/14/2016 07:23 AM, Joonsoo Kim wrote: > >On Fri, Jul 08, 2016 at 11:11:47AM +0100, Mel Gorman wrote: > >>On Fri, Jul 08, 2016 at 11:44:47AM +0900, Joonsoo Kim wrote: > >> > >>It doesn't stop reclaiming for the lower zones.

Re: [PATCH 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"

2016-07-17 Thread Juergen Gross
On 16/07/16 22:22, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:21:05 +0200 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was

Re: [PATCH 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"

2016-07-17 Thread Juergen Gross
On 16/07/16 22:22, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:21:05 +0200 > > The kfree() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle

[BUG] kernel BUG at arch/x86/mm/pageattr.c:216!

2016-07-17 Thread Xie XiuQi
Hi all, I'm getting BUG_ON occurred in a panic at arch/x86/mm/pageattr.c:216! on 3.10.0-327.el7 (RHEL 7.2) I want to do a test, to expect system will reboot immediately after panic. But, in drm_fb_helper_panic, may trigger a BUG_ON at arch/x86/mm/pageattr.c:216! Does anyone has good idea to fix

Re: [PATCH 08/31] mm, vmscan: simplify the logic deciding whether kswapd sleeps

2016-07-17 Thread Joonsoo Kim
On Thu, Jul 14, 2016 at 10:05:00AM +0100, Mel Gorman wrote: > On Thu, Jul 14, 2016 at 02:23:32PM +0900, Joonsoo Kim wrote: > > > > > > > > > And, I'd like to know why max() is used for classzone_idx rather > > > > > > than > > > > > > min()? I think that kswapd should balance the lowest zone

Re: [PATCH 08/31] mm, vmscan: simplify the logic deciding whether kswapd sleeps

2016-07-17 Thread Joonsoo Kim
On Thu, Jul 14, 2016 at 10:05:00AM +0100, Mel Gorman wrote: > On Thu, Jul 14, 2016 at 02:23:32PM +0900, Joonsoo Kim wrote: > > > > > > > > > And, I'd like to know why max() is used for classzone_idx rather > > > > > > than > > > > > > min()? I think that kswapd should balance the lowest zone

[BUG] kernel BUG at arch/x86/mm/pageattr.c:216!

2016-07-17 Thread Xie XiuQi
Hi all, I'm getting BUG_ON occurred in a panic at arch/x86/mm/pageattr.c:216! on 3.10.0-327.el7 (RHEL 7.2) I want to do a test, to expect system will reboot immediately after panic. But, in drm_fb_helper_panic, may trigger a BUG_ON at arch/x86/mm/pageattr.c:216! Does anyone has good idea to fix

Re: linux-next: manual merge of the kspp tree with the arm64 tree

2016-07-17 Thread Kees Cook
On Sun, Jul 17, 2016 at 7:59 PM, Stephen Rothwell wrote: > Hi Kees, > > Today's linux-next merge of the kspp tree got a conflict in: > > arch/arm64/include/asm/uaccess.h > > between commit: > > bffe1baff5d5 ("arm64: kasan: instrument user memory access API") > > from

Re: linux-next: manual merge of the kspp tree with the arm64 tree

2016-07-17 Thread Kees Cook
On Sun, Jul 17, 2016 at 7:59 PM, Stephen Rothwell wrote: > Hi Kees, > > Today's linux-next merge of the kspp tree got a conflict in: > > arch/arm64/include/asm/uaccess.h > > between commit: > > bffe1baff5d5 ("arm64: kasan: instrument user memory access API") > > from the arm64 tree and

Re: [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis

2016-07-17 Thread Joonsoo Kim
On Thu, Jul 14, 2016 at 09:48:41AM +0200, Vlastimil Babka wrote: > On 07/14/2016 08:28 AM, Joonsoo Kim wrote: > >On Fri, Jul 08, 2016 at 11:05:32AM +0100, Mel Gorman wrote: > >>On Fri, Jul 08, 2016 at 11:28:52AM +0900, Joonsoo Kim wrote: > >>>On Thu, Jul 07, 2016 at 10:48:08AM +0100, Mel Gorman

Re: [PATCH 04/31] mm, vmscan: begin reclaiming pages on a per-node basis

2016-07-17 Thread Joonsoo Kim
On Thu, Jul 14, 2016 at 09:48:41AM +0200, Vlastimil Babka wrote: > On 07/14/2016 08:28 AM, Joonsoo Kim wrote: > >On Fri, Jul 08, 2016 at 11:05:32AM +0100, Mel Gorman wrote: > >>On Fri, Jul 08, 2016 at 11:28:52AM +0900, Joonsoo Kim wrote: > >>>On Thu, Jul 07, 2016 at 10:48:08AM +0100, Mel Gorman

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Rafał Miłecki
On 18 July 2016 at 04:31, Peter Chen wrote: > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: >> + >> +usbport trigger: >> +- usb-ports : List of USB ports that usbport should observed for turning on >> a >> + given LED. >> + > > %s/should/should

Re: [PATCH V2] leds: trigger: Introduce an USB port trigger

2016-07-17 Thread Rafał Miłecki
On 18 July 2016 at 04:31, Peter Chen wrote: > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: >> + >> +usbport trigger: >> +- usb-ports : List of USB ports that usbport should observed for turning on >> a >> + given LED. >> + > > %s/should/should be Thanks. >> diff

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-17 Thread Borislav Petkov
On Mon, Jul 18, 2016 at 10:18:09AM +0800, Dave Young wrote: > I would say avoiding ratelimit during boot make no much sense. Userspace can > not > write to /dev/kmsg when system_state == SYSTEM_BOOTING because init process > has not run yet. You're right - kernel_init() sets SYSTEM_RUNNING

Re: [PATCH -v4 2/2] printk: Add kernel parameter to control writes to /dev/kmsg

2016-07-17 Thread Borislav Petkov
On Mon, Jul 18, 2016 at 10:18:09AM +0800, Dave Young wrote: > I would say avoiding ratelimit during boot make no much sense. Userspace can > not > write to /dev/kmsg when system_state == SYSTEM_BOOTING because init process > has not run yet. You're right - kernel_init() sets SYSTEM_RUNNING

Re: [PATCH 6/9] x86, pkeys: add pkey set/get syscalls

2016-07-17 Thread Andy Lutomirski
On Thu, Jul 14, 2016 at 1:07 AM, Ingo Molnar wrote: > > * Andy Lutomirski wrote: > >> On Wed, Jul 13, 2016 at 12:56 AM, Ingo Molnar wrote: >> > >> > * Andy Lutomirski wrote: >> > >> >> > If we push a PKRU value into

Re: [PATCH 6/9] x86, pkeys: add pkey set/get syscalls

2016-07-17 Thread Andy Lutomirski
On Thu, Jul 14, 2016 at 1:07 AM, Ingo Molnar wrote: > > * Andy Lutomirski wrote: > >> On Wed, Jul 13, 2016 at 12:56 AM, Ingo Molnar wrote: >> > >> > * Andy Lutomirski wrote: >> > >> >> > If we push a PKRU value into a thread between the rdpkru() and >> >> > wrpkru(), we'll >> >> > lose the

[PATCH 2/3] qemu: Implement virtio-pstore device

2016-07-17 Thread Namhyung Kim
From: Namhyung Kim Add virtio pstore device to allow kernel log files saved on the host. It will save the log files on the directory given by pstore device option. $ qemu-system-x86_64 -device virtio-pstore,directory=dir-xx ... (guest) # echo c > /proc/sysrq-trigger

[PATCH 2/3] qemu: Implement virtio-pstore device

2016-07-17 Thread Namhyung Kim
From: Namhyung Kim Add virtio pstore device to allow kernel log files saved on the host. It will save the log files on the directory given by pstore device option. $ qemu-system-x86_64 -device virtio-pstore,directory=dir-xx ... (guest) # echo c > /proc/sysrq-trigger $ ls dir-xx

[RFC/PATCHSET 0/3] virtio-pstore: Implement virtio pstore device

2016-07-17 Thread Namhyung Kim
Hello, This patchset is a proof of concept of virtio-pstore idea [1]. It has some rough edges and I'm not familiar with this area, so please give me feedbacks and advices if I'm going to a wrong direction. It started from the fact that dumping ftrace buffer at kernel oops/panic takes too much

[RFC/PATCHSET 0/3] virtio-pstore: Implement virtio pstore device

2016-07-17 Thread Namhyung Kim
Hello, This patchset is a proof of concept of virtio-pstore idea [1]. It has some rough edges and I'm not familiar with this area, so please give me feedbacks and advices if I'm going to a wrong direction. It started from the fact that dumping ftrace buffer at kernel oops/panic takes too much

[PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-07-17 Thread Namhyung Kim
The virtio pstore driver provides interface to the pstore subsystem so that the guest kernel's log/dump message can be saved on the host machine. Users can access the log file directly on the host, or on the guest at the next boot using pstore filesystem. It currently deals with kernel log

[PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-07-17 Thread Namhyung Kim
The virtio pstore driver provides interface to the pstore subsystem so that the guest kernel's log/dump message can be saved on the host machine. Users can access the log file directly on the host, or on the guest at the next boot using pstore filesystem. It currently deals with kernel log

[PATCH 3/3] kvmtool: Implement virtio-pstore device

2016-07-17 Thread Namhyung Kim
Add virtio pstore device to allow kernel log messages saved on the host. With this patch, it will save the log files under directory given by --pstore option. $ lkvm run --pstore=dir-xx (guest) # echo c > /proc/sysrq-trigger $ ls dir-xx dmesg-0.enc.z dmesg-1.enc.z The log files are

[PATCH 3/3] kvmtool: Implement virtio-pstore device

2016-07-17 Thread Namhyung Kim
Add virtio pstore device to allow kernel log messages saved on the host. With this patch, it will save the log files under directory given by --pstore option. $ lkvm run --pstore=dir-xx (guest) # echo c > /proc/sysrq-trigger $ ls dir-xx dmesg-0.enc.z dmesg-1.enc.z The log files are

Re: [PATCH v3 12/17] mm, compaction: more reliably increase direct compaction priority

2016-07-17 Thread Joonsoo Kim
On Fri, Jul 15, 2016 at 03:37:52PM +0200, Vlastimil Babka wrote: > On 07/06/2016 07:39 AM, Joonsoo Kim wrote: > > On Fri, Jun 24, 2016 at 11:54:32AM +0200, Vlastimil Babka wrote: > >> During reclaim/compaction loop, compaction priority can be increased by the > >> should_compact_retry() function,

Re: [PATCH v3 12/17] mm, compaction: more reliably increase direct compaction priority

2016-07-17 Thread Joonsoo Kim
On Fri, Jul 15, 2016 at 03:37:52PM +0200, Vlastimil Babka wrote: > On 07/06/2016 07:39 AM, Joonsoo Kim wrote: > > On Fri, Jun 24, 2016 at 11:54:32AM +0200, Vlastimil Babka wrote: > >> During reclaim/compaction loop, compaction priority can be increased by the > >> should_compact_retry() function,

[PATCH] Staging: ks7010: michael_mic: fixed macros coding style issue

2016-07-17 Thread Sunbing
Fixed coding style issue: Enclose multiple statements macros definition in a do while loop. Use one space around binary operators. Signed-off-by: Sunbing --- drivers/staging/ks7010/michael_mic.c | 20 +--- 1 file changed, 13 insertions(+), 7

[PATCH] Staging: ks7010: michael_mic: fixed macros coding style issue

2016-07-17 Thread Sunbing
Fixed coding style issue: Enclose multiple statements macros definition in a do while loop. Use one space around binary operators. Signed-off-by: Sunbing --- drivers/staging/ks7010/michael_mic.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git

Re: [PATCH 1/1] tracing, bpf: Implement function bpf_probe_write

2016-07-17 Thread Alexei Starovoitov
On Sun, Jul 17, 2016 at 03:19:13AM -0700, Sargun Dhillon wrote: > > +static u64 bpf_copy_to_user(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5) > +{ > + void *to = (void *) (long) r1; > + void *from = (void *) (long) r2; > + int size = (int) r3; > + > + /* check if we're in a user

Re: [PATCH 1/1] tracing, bpf: Implement function bpf_probe_write

2016-07-17 Thread Alexei Starovoitov
On Sun, Jul 17, 2016 at 03:19:13AM -0700, Sargun Dhillon wrote: > > +static u64 bpf_copy_to_user(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5) > +{ > + void *to = (void *) (long) r1; > + void *from = (void *) (long) r2; > + int size = (int) r3; > + > + /* check if we're in a user

linux-next: manual merge of the device-mapper tree with the block tree

2016-07-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the device-mapper tree got a conflict in: include/linux/blkdev.h between commit: 288dab8a35a0 ("block: add a separate operation type for secure erase") from the block tree and commit: ff6bbdd8ef75 ("block: add QUEUE_FLAG_DAX for devices to advertise

linux-next: manual merge of the device-mapper tree with the block tree

2016-07-17 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the device-mapper tree got a conflict in: include/linux/blkdev.h between commit: 288dab8a35a0 ("block: add a separate operation type for secure erase") from the block tree and commit: ff6bbdd8ef75 ("block: add QUEUE_FLAG_DAX for devices to advertise

[PATCH v2 04/10] binfmt_flat: clean up create_flat_tables() and stack accesses

2016-07-17 Thread Nicolas Pitre
In addition to better code clarity, this brings proper usage of user memory accessors everywhere the stack is touched. This is essential for making this work on MMU systems. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 117

[PATCH v2 04/10] binfmt_flat: clean up create_flat_tables() and stack accesses

2016-07-17 Thread Nicolas Pitre
In addition to better code clarity, this brings proper usage of user memory accessors everywhere the stack is touched. This is essential for making this work on MMU systems. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 117 ++- 1 file

[PATCH v2 08/10] binfmt_flat: update libraries' data segment pointer with userspace accessors

2016-07-17 Thread Nicolas Pitre
This is needed on systems with a MMU. This also gets rid of the strangest C code I've seen lateli i.e. an integer indexed with a pointer value within square brackets. That really looked backwards. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 19 +-- 1

[PATCH v2 09/10] binfmt_flat: add MMU-specific support

2016-07-17 Thread Nicolas Pitre
Not much else to do at this point except for the different stack setups. SuperH and Xtensa could be added to the allowed list if they implement __put_user_unaligned() and __get_user_unaligned(). Signed-off-by: Nicolas Pitre --- fs/Kconfig.binfmt | 3 ++- fs/binfmt_flat.c |

[PATCH v2 08/10] binfmt_flat: update libraries' data segment pointer with userspace accessors

2016-07-17 Thread Nicolas Pitre
This is needed on systems with a MMU. This also gets rid of the strangest C code I've seen lateli i.e. an integer indexed with a pointer value within square brackets. That really looked backwards. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 19 +-- 1 file changed, 13

[PATCH v2 09/10] binfmt_flat: add MMU-specific support

2016-07-17 Thread Nicolas Pitre
Not much else to do at this point except for the different stack setups. SuperH and Xtensa could be added to the allowed list if they implement __put_user_unaligned() and __get_user_unaligned(). Signed-off-by: Nicolas Pitre --- fs/Kconfig.binfmt | 3 ++- fs/binfmt_flat.c | 16

[PATCH 1/1] netfilter: Add helper array register/unregister functions

2016-07-17 Thread fgao
From: Gao Feng Add nf_ct_helper_init, nf_conntrack_helpers_register/unregister functions to enhance the conntrack helper codes. Signed-off-by: Gao Feng --- include/net/netfilter/nf_conntrack_helper.h | 16 ++ net/netfilter/nf_conntrack_ftp.c|

[PATCH 1/1] netfilter: Add helper array register/unregister functions

2016-07-17 Thread fgao
From: Gao Feng Add nf_ct_helper_init, nf_conntrack_helpers_register/unregister functions to enhance the conntrack helper codes. Signed-off-by: Gao Feng --- include/net/netfilter/nf_conntrack_helper.h | 16 ++ net/netfilter/nf_conntrack_ftp.c| 58 +++---

RE: [PATCH v6 1/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's

2016-07-17 Thread Tan, Jui Nee
> -Original Message- > From: paul.gortma...@gmail.com [mailto:paul.gortma...@gmail.com] On > Behalf Of Paul Gortmaker > Sent: Friday, July 15, 2016 8:01 AM > To: Tan, Jui Nee > Cc: mika.westerb...@linux.intel.com; heikki.kroge...@linux.intel.com; >

RE: [PATCH v6 1/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's

2016-07-17 Thread Tan, Jui Nee
> -Original Message- > From: paul.gortma...@gmail.com [mailto:paul.gortma...@gmail.com] On > Behalf Of Paul Gortmaker > Sent: Friday, July 15, 2016 8:01 AM > To: Tan, Jui Nee > Cc: mika.westerb...@linux.intel.com; heikki.kroge...@linux.intel.com; > andriy.shevche...@linux.intel.com;

[PATCH v2 07/10] binfmt_flat: use clear_user() rather than memset() to clear .bss

2016-07-17 Thread Nicolas Pitre
This is needed on systems with a MMU. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index c85f8f1239..e981e66bb5 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c

[PATCH v2 07/10] binfmt_flat: use clear_user() rather than memset() to clear .bss

2016-07-17 Thread Nicolas Pitre
This is needed on systems with a MMU. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index c85f8f1239..e981e66bb5 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -803,10

[PATCH v2 06/10] binfmt_flat: use proper user space accessors with old relocs code

2016-07-17 Thread Nicolas Pitre
Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index fc0ee3ed5d..c85f8f1239 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -394,38

[PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems

2016-07-17 Thread Nicolas Pitre
Let's take the simple and obvious approach by decompressing the binary into a kernel buffer and then copying it to user space. Those who are looking for more performance on a MMU system are unlikely to choose this executable format anyway. Signed-off-by: Nicolas Pitre ---

[PULL REQUEST] [PATCH v2 00/10] allow BFLT executables on systems with a MMU

2016-07-17 Thread Nicolas Pitre
This series provides the necessary changes to allow "flat" executable binaries meant for no-MMU systems to actually run on systems with a MMU. This can also be found in the following git repo: git://git.linaro.org/people/nicolas.pitre/linux binfmt_flat_with_mmu *Why?* Because

[PATCH v2 05/10] binfmt_flat: use proper user space accessors with relocs processing code

2016-07-17 Thread Nicolas Pitre
Relocs are fixed up in place in user space memory. The appropriate accessors are required for this code to work with an active MMU. The architecture specific handlers for ARM and M68K are also covered. SuperH and Xtensa are left out as they doesn't implement __get_user_unaligned() and

[PATCH v2 06/10] binfmt_flat: use proper user space accessors with old relocs code

2016-07-17 Thread Nicolas Pitre
Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index fc0ee3ed5d..c85f8f1239 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -394,38 +394,41 @@ static

[PATCH v2 10/10] binfmt_flat: allow compressed flat binary format to work on MMU systems

2016-07-17 Thread Nicolas Pitre
Let's take the simple and obvious approach by decompressing the binary into a kernel buffer and then copying it to user space. Those who are looking for more performance on a MMU system are unlikely to choose this executable format anyway. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 44

[PULL REQUEST] [PATCH v2 00/10] allow BFLT executables on systems with a MMU

2016-07-17 Thread Nicolas Pitre
This series provides the necessary changes to allow "flat" executable binaries meant for no-MMU systems to actually run on systems with a MMU. This can also be found in the following git repo: git://git.linaro.org/people/nicolas.pitre/linux binfmt_flat_with_mmu *Why?* Because

[PATCH v2 05/10] binfmt_flat: use proper user space accessors with relocs processing code

2016-07-17 Thread Nicolas Pitre
Relocs are fixed up in place in user space memory. The appropriate accessors are required for this code to work with an active MMU. The architecture specific handlers for ARM and M68K are also covered. SuperH and Xtensa are left out as they doesn't implement __get_user_unaligned() and

[PATCH v2 03/10] binfmt_flat: use generic transfer_args_to_stack()

2016-07-17 Thread Nicolas Pitre
This gets rid of the rather ugly, open coded and suboptimal copy code. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index 085059d879..64feb873f0

[PATCH v2 01/10] binfmt_flat: assorted cleanups

2016-07-17 Thread Nicolas Pitre
Remove excessive casts, do some code grouping, etc. No functional changes. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 118 ++- 1 file changed, 56 insertions(+), 62 deletions(-) diff --git a/fs/binfmt_flat.c

[PATCH v2 02/10] elf_fdpic_transfer_args_to_stack(): make it generic

2016-07-17 Thread Nicolas Pitre
This copying of arguments and environment is common to both NOMMU binary formats we support. Let's make the elf_fdpic version available to the flat format as well. While at it, improve the code a bit not to copy below the actual data area. Signed-off-by: Nicolas Pitre ---

[PATCH v2 03/10] binfmt_flat: use generic transfer_args_to_stack()

2016-07-17 Thread Nicolas Pitre
This gets rid of the rather ugly, open coded and suboptimal copy code. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index 085059d879..64feb873f0 100644 ---

[PATCH v2 01/10] binfmt_flat: assorted cleanups

2016-07-17 Thread Nicolas Pitre
Remove excessive casts, do some code grouping, etc. No functional changes. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 118 ++- 1 file changed, 56 insertions(+), 62 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index

[PATCH v2 02/10] elf_fdpic_transfer_args_to_stack(): make it generic

2016-07-17 Thread Nicolas Pitre
This copying of arguments and environment is common to both NOMMU binary formats we support. Let's make the elf_fdpic version available to the flat format as well. While at it, improve the code a bit not to copy below the actual data area. Signed-off-by: Nicolas Pitre --- fs/binfmt_elf_fdpic.c

  1   2   3   4   5   >