Re: [PATCH 0/5 RFC] Add an interface to discover relationships between namespaces

2016-07-26 Thread Michael Kerrisk (man-pages)
Hello Andrew, On 26 July 2016 at 20:25, Andrew Vagin wrote: > On Tue, Jul 26, 2016 at 10:03:25AM +0200, Michael Kerrisk (man-pages) wrote: >> On 07/26/2016 04:54 AM, Andrew Vagin wrote: >> > On Mon, Jul 25, 2016 at 09:59:43AM -0500, Eric W. Biederman wrote: >> > > "Michael

[PATCH 3/9] usb: gadget: f_midi: remove alignment code for OUT endpoint

2016-07-26 Thread Felipe F. Tonello
The new version of alloc_ep_req() already aligns the buffer size to wMaxPacketSize on OUT endpoints. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

Re: [lustre-devel] [PATCH 05/12] staging: lustre: Optimize error handling in class_register_type()

2016-07-26 Thread Oleg Drokin
On Jul 26, 2016, at 3:11 PM, Oleg Drokin wrote: > > On Jul 26, 2016, at 3:05 PM, SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Tue, 26 Jul 2016 14:23:23 +0200 >> >> Return a constant error code without storing it in the local variable "rc" >>

Re: [PATCH 0/5 RFC] Add an interface to discover relationships between namespaces

2016-07-26 Thread Michael Kerrisk (man-pages)
Hello Andrew, On 26 July 2016 at 20:25, Andrew Vagin wrote: > On Tue, Jul 26, 2016 at 10:03:25AM +0200, Michael Kerrisk (man-pages) wrote: >> On 07/26/2016 04:54 AM, Andrew Vagin wrote: >> > On Mon, Jul 25, 2016 at 09:59:43AM -0500, Eric W. Biederman wrote: >> > > "Michael Kerrisk (man-pages)"

[PATCH 3/9] usb: gadget: f_midi: remove alignment code for OUT endpoint

2016-07-26 Thread Felipe F. Tonello
The new version of alloc_ep_req() already aligns the buffer size to wMaxPacketSize on OUT endpoints. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/function/f_midi.c

Re: [lustre-devel] [PATCH 05/12] staging: lustre: Optimize error handling in class_register_type()

2016-07-26 Thread Oleg Drokin
On Jul 26, 2016, at 3:11 PM, Oleg Drokin wrote: > > On Jul 26, 2016, at 3:05 PM, SF Markus Elfring wrote: > >> From: Markus Elfring >> Date: Tue, 26 Jul 2016 14:23:23 +0200 >> >> Return a constant error code without storing it in the local variable "rc" >> after a failed memory allocation at

[PATCH 2/9] usb: gadget: align buffer size when allocating for OUT endpoint

2016-07-26 Thread Felipe F. Tonello
Using usb_ep_align() makes sure that the buffer size for OUT endpoints is always aligned with wMaxPacketSize (512 usually). This makes sure that no buffer has the wrong size, which can cause nasty bugs. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/u_f.c | 3

[PATCH 2/9] usb: gadget: align buffer size when allocating for OUT endpoint

2016-07-26 Thread Felipe F. Tonello
Using usb_ep_align() makes sure that the buffer size for OUT endpoints is always aligned with wMaxPacketSize (512 usually). This makes sure that no buffer has the wrong size, which can cause nasty bugs. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/u_f.c | 3 +++ 1 file changed, 3

Re: [PATCH] mm: Move readahead limit outside of readahead, and advisory syscalls

2016-07-26 Thread Kyle Walker
On Mon, Jul 25, 2016 at 4:47 PM, Andrew Morton wrote: > > Can this suffering be quantified please? > The observed suffering is primarily visible within an IBM Qradar installation. From a high level, the lower limit to the amount of advisory readahead pages results in a

Re: [PATCH] mm: Move readahead limit outside of readahead, and advisory syscalls

2016-07-26 Thread Kyle Walker
On Mon, Jul 25, 2016 at 4:47 PM, Andrew Morton wrote: > > Can this suffering be quantified please? > The observed suffering is primarily visible within an IBM Qradar installation. From a high level, the lower limit to the amount of advisory readahead pages results in a 3-5x increase in time

Re: [PATCH v2 7/9] usb: gadget: remove useless parameter in alloc_ep_req()

2016-07-26 Thread Felipe Ferreri Tonello
Forgot to mention, but changes from v1 is a typo alloc_ep_req(). On 26/07/16 20:18, Felipe F. Tonello wrote: > This parameter was not really necessary and gadget drivers would almost always > create an inline function to pass the same value to len and default_len. > > So this patch also removes

Re: [PATCH v2 7/9] usb: gadget: remove useless parameter in alloc_ep_req()

2016-07-26 Thread Felipe Ferreri Tonello
Forgot to mention, but changes from v1 is a typo alloc_ep_req(). On 26/07/16 20:18, Felipe F. Tonello wrote: > This parameter was not really necessary and gadget drivers would almost always > create an inline function to pass the same value to len and default_len. > > So this patch also removes

[PATCH v2 7/9] usb: gadget: remove useless parameter in alloc_ep_req()

2016-07-26 Thread Felipe F. Tonello
This parameter was not really necessary and gadget drivers would almost always create an inline function to pass the same value to len and default_len. So this patch also removes duplicate code from few drivers. Signed-off-by: Felipe F. Tonello ---

[PATCH v2 7/9] usb: gadget: remove useless parameter in alloc_ep_req()

2016-07-26 Thread Felipe F. Tonello
This parameter was not really necessary and gadget drivers would almost always create an inline function to pass the same value to len and default_len. So this patch also removes duplicate code from few drivers. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_hid.c|

[PATCH 12/12] staging: lustre: Delete an unnecessary variable initialisation in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 19:50:40 +0200 The variable "req" will eventually be set to an appropriate pointer from a call of the ptlrpc_request_alloc() function. Thus omit the explicit initialisation which became unnecessary with a previous update

[PATCH 12/12] staging: lustre: Delete an unnecessary variable initialisation in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 19:50:40 +0200 The variable "req" will eventually be set to an appropriate pointer from a call of the ptlrpc_request_alloc() function. Thus omit the explicit initialisation which became unnecessary with a previous update step. Signed-off-by: Markus

Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"

2016-07-26 Thread Rob Herring
On Tue, Jul 26, 2016 at 1:50 PM, Max Filippov wrote: > On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote: >> This partially reverts commit 69d99e6c0d62 keeping only the main >> purpose of the original commit which is the removal of >> of_platform_populate() call. The

[PATCH 6/9] usb: gadget: f_midi: drop substreams when disabling endpoint

2016-07-26 Thread Felipe F. Tonello
This change makes sure that the ALSA buffers are cleaned if an endpoint becomes disabled. Before this change, if the internal ALSA buffer did overflow, the MIDI function would stop sending MIDI to the host. Signed-off-by: Felipe F. Tonello ---

[PATCH 4/9] usb: gadget: f_midi: defaults buflen sizes to 512

2016-07-26 Thread Felipe F. Tonello
512 is the value used by wMaxPacketSize, as specified by the USB Spec. This makes sure this driver uses, by default, the most optimal value for IN and OUT endpoint requests. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 2 +-

[PATCH 4/9] usb: gadget: f_midi: defaults buflen sizes to 512

2016-07-26 Thread Felipe F. Tonello
512 is the value used by wMaxPacketSize, as specified by the USB Spec. This makes sure this driver uses, by default, the most optimal value for IN and OUT endpoint requests. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 2 +- drivers/usb/gadget/legacy/gmidi.c|

[PATCH 6/9] usb: gadget: f_midi: drop substreams when disabling endpoint

2016-07-26 Thread Felipe F. Tonello
This change makes sure that the ALSA buffers are cleaned if an endpoint becomes disabled. Before this change, if the internal ALSA buffer did overflow, the MIDI function would stop sending MIDI to the host. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_midi.c | 27

Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"

2016-07-26 Thread Rob Herring
On Tue, Jul 26, 2016 at 1:50 PM, Max Filippov wrote: > On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote: >> This partially reverts commit 69d99e6c0d62 keeping only the main >> purpose of the original commit which is the removal of >> of_platform_populate() call. The moving of

[PATCH 5/9] usb: gadget: f_midi: refactor state machine

2016-07-26 Thread Felipe F. Tonello
This refactor results in a cleaner state machine code and promotes consistency, readability, and maintanability of this driver. This refactor state machine was well tested and it is currently running in production code and devices. Signed-off-by: Felipe F. Tonello ---

[PATCH v2 0/9] Gadget endpoint request allocation and MIDI

2016-07-26 Thread Felipe F. Tonello
As discussed with Baolin Wang, Michal Nazarewicz and Felipe Balbi. I propose the forced buffer alignment of OUT endpoints USB requests. This is implemented by patches #1 and #2. That not just simplifies the driver code, but it also prevents nasty bugs when buflen is not aligned or even less than

[PATCH 5/9] usb: gadget: f_midi: refactor state machine

2016-07-26 Thread Felipe F. Tonello
This refactor results in a cleaner state machine code and promotes consistency, readability, and maintanability of this driver. This refactor state machine was well tested and it is currently running in production code and devices. Signed-off-by: Felipe F. Tonello ---

[PATCH v2 0/9] Gadget endpoint request allocation and MIDI

2016-07-26 Thread Felipe F. Tonello
As discussed with Baolin Wang, Michal Nazarewicz and Felipe Balbi. I propose the forced buffer alignment of OUT endpoints USB requests. This is implemented by patches #1 and #2. That not just simplifies the driver code, but it also prevents nasty bugs when buflen is not aligned or even less than

[PATCH 10/12] staging: lustre: Rename jump labels in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 19:29:11 +0200 Adjust jump targets according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 19

[PATCH 10/12] staging: lustre: Rename jump labels in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 19:29:11 +0200 Adjust jump targets according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff

[PATCH 7/9] usb: gadget: remove useless parameter in alloc_ep_req()

2016-07-26 Thread Felipe F. Tonello
This parameter was not really necessary and gadget drivers would almost always create an inline function to pass the same value to len and default_len. So this patch also removes duplicate code from few drivers. Signed-off-by: Felipe F. Tonello ---

Re: [PATCHv1, RFC 00/33] ext4: support of huge pages

2016-07-26 Thread Kirill A. Shutemov
On Tue, Jul 26, 2016 at 01:29:38PM -0400, Theodore Ts'o wrote: > On Tue, Jul 26, 2016 at 03:35:02AM +0300, Kirill A. Shutemov wrote: > > Here's the first version of my patchset which intended to bring huge pages > > to ext4. It's not yet ready for applying or serious use, but good enough > > to

[PATCH 7/9] usb: gadget: remove useless parameter in alloc_ep_req()

2016-07-26 Thread Felipe F. Tonello
This parameter was not really necessary and gadget drivers would almost always create an inline function to pass the same value to len and default_len. So this patch also removes duplicate code from few drivers. Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_hid.c|

Re: [PATCHv1, RFC 00/33] ext4: support of huge pages

2016-07-26 Thread Kirill A. Shutemov
On Tue, Jul 26, 2016 at 01:29:38PM -0400, Theodore Ts'o wrote: > On Tue, Jul 26, 2016 at 03:35:02AM +0300, Kirill A. Shutemov wrote: > > Here's the first version of my patchset which intended to bring huge pages > > to ext4. It's not yet ready for applying or serious use, but good enough > > to

[PATCH 11/12] staging: lustre: Move an assignment for the variable "eof" in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 19:40:28 +0200 Move the assignment for the local variable "eof" behind the source code for memory allocations by this function. Signed-off-by: Markus Elfring ---

[PATCH 11/12] staging: lustre: Move an assignment for the variable "eof" in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 19:40:28 +0200 Move the assignment for the local variable "eof" behind the source code for memory allocations by this function. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 3 ++- 1 file changed, 2

[PATCH 8/9] usb: gadget: f_hid: use free_ep_req()

2016-07-26 Thread Felipe F. Tonello
We should always use free_ep_req() when allocating requests with alloc_ep_req(). Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_hid.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c

[PATCH 8/9] usb: gadget: f_hid: use free_ep_req()

2016-07-26 Thread Felipe F. Tonello
We should always use free_ep_req() when allocating requests with alloc_ep_req(). Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_hid.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c

[PATCH 05/12] staging: lustre: Optimize error handling in class_register_type()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 14:23:23 +0200 Return a constant error code without storing it in the local variable "rc" after a failed memory allocation at the beginning of this function. Signed-off-by: Markus Elfring

[PATCH 05/12] staging: lustre: Optimize error handling in class_register_type()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 14:23:23 +0200 Return a constant error code without storing it in the local variable "rc" after a failed memory allocation at the beginning of this function. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/obdclass/genops.c | 3 +--

[PATCH 9/9] usb: gadget: f_hid: use alloc_ep_req()

2016-07-26 Thread Felipe F. Tonello
Use gadget's framework allocation function instead of directly calling usb_ep_alloc_request(). Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_hid.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git

[PATCH 9/9] usb: gadget: f_hid: use alloc_ep_req()

2016-07-26 Thread Felipe F. Tonello
Use gadget's framework allocation function instead of directly calling usb_ep_alloc_request(). Signed-off-by: Felipe F. Tonello --- drivers/usb/gadget/function/f_hid.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/usb/gadget/function/f_hid.c

[PATCH 1/9] usb: gadget: fix usb_ep_align_maybe endianness and new usb_ep_align

2016-07-26 Thread Felipe F. Tonello
USB spec specifies wMaxPacketSize to be little endian (as other properties), so when using this variable in the driver we should convert to the current CPU endianness if necessary. This patch also introduces usb_ep_align() which does always returns the aligned buffer size for an endpoint. This is

[PATCH 1/9] usb: gadget: fix usb_ep_align_maybe endianness and new usb_ep_align

2016-07-26 Thread Felipe F. Tonello
USB spec specifies wMaxPacketSize to be little endian (as other properties), so when using this variable in the driver we should convert to the current CPU endianness if necessary. This patch also introduces usb_ep_align() which does always returns the aligned buffer size for an endpoint. This is

Re: [PATCH 05/12] staging: lustre: Optimize error handling in class_register_type()

2016-07-26 Thread Oleg Drokin
On Jul 26, 2016, at 3:05 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 26 Jul 2016 14:23:23 +0200 > > Return a constant error code without storing it in the local variable "rc" > after a failed memory allocation at the beginning of this

Re: [PATCH 05/12] staging: lustre: Optimize error handling in class_register_type()

2016-07-26 Thread Oleg Drokin
On Jul 26, 2016, at 3:05 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 26 Jul 2016 14:23:23 +0200 > > Return a constant error code without storing it in the local variable "rc" > after a failed memory allocation at the beginning of this function. > > Signed-off-by: Markus

[PATCH 09/12] staging: lustre: Delete a check for the variable "req" in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 17:56:49 +0200 Delete a check for the local variable "req" which became unnecessary with the previous update step. Signed-off-by: Markus Elfring ---

[PATCH 09/12] staging: lustre: Delete a check for the variable "req" in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 17:56:49 +0200 Delete a check for the local variable "req" which became unnecessary with the previous update step. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH 08/12] staging: lustre: Less checks after a failed ptlrpc_request_alloc() in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 17:54:24 +0200 Release memory directly after a call of the function "ptlrpc_request_alloc" failed. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-

[PATCH 08/12] staging: lustre: Less checks after a failed ptlrpc_request_alloc() in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 17:54:24 +0200 Release memory directly after a call of the function "ptlrpc_request_alloc" failed. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 03/12] staging: lustre: One function call less in class_register_type() after error detection

2016-07-26 Thread Oleg Drokin
On Jul 26, 2016, at 3:02 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 26 Jul 2016 13:40:47 +0200 > > The kobject_put() function was called in a few cases by the > class_register_type() function during error handling even if the passed > data

Re: [PATCH 03/12] staging: lustre: One function call less in class_register_type() after error detection

2016-07-26 Thread Oleg Drokin
On Jul 26, 2016, at 3:02 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 26 Jul 2016 13:40:47 +0200 > > The kobject_put() function was called in a few cases by the > class_register_type() function during error handling even if the passed > data structure element did not

[PATCH 07/12] staging: lustre: Less checks after a failed alloc_page() in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 17:12:51 +0200 Release memory directly after a page allocation failed at the beginning. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 15

[PATCH 07/12] staging: lustre: Less checks after a failed alloc_page() in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 17:12:51 +0200 Release memory directly after a page allocation failed at the beginning. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff

[PATCH 06/12] staging: lustre: Return directly after a failed kcalloc() in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 16:32:31 +0200 Return directly after a memory allocation failed at the beginning. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 6 ++ 1 file

[PATCH 06/12] staging: lustre: Return directly after a failed kcalloc() in mgc_process_recover_log()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 16:32:31 +0200 Return directly after a memory allocation failed at the beginning. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/mgc/mgc_request.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 04/12] staging: lustre: Split a condition check in class_register_type()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 14:10:55 +0200 The kfree() function was called in up to three cases by the class_register_type() function during error handling even if the passed data structure element contained a null pointer. * Split a condition

[PATCH 04/12] staging: lustre: Split a condition check in class_register_type()

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 14:10:55 +0200 The kfree() function was called in up to three cases by the class_register_type() function during error handling even if the passed data structure element contained a null pointer. * Split a condition check for memory allocation

Re: [PATCH] pwm: cros_ec: add __packed to prevent padding

2016-07-26 Thread Dmitry Torokhov
On Tue, Jul 26, 2016 at 11:22:13AM -0700, Brian Norris wrote: > While the particular usage in question is likely safe (struct > cros_ec_command is 32-bit aligned, followed by <=32-bit fields), it's > been suggested this is not a great pattern to follow for the general > case -- for example, if we

Re: [PATCH] pwm: cros_ec: add __packed to prevent padding

2016-07-26 Thread Dmitry Torokhov
On Tue, Jul 26, 2016 at 11:22:13AM -0700, Brian Norris wrote: > While the particular usage in question is likely safe (struct > cros_ec_command is 32-bit aligned, followed by <=32-bit fields), it's > been suggested this is not a great pattern to follow for the general > case -- for example, if we

[PATCH 03/12] staging: lustre: One function call less in class_register_type() after error detection

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 13:40:47 +0200 The kobject_put() function was called in a few cases by the class_register_type() function during error handling even if the passed data structure element did not contain a pointer for a valid data item.

[PATCH 03/12] staging: lustre: One function call less in class_register_type() after error detection

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 13:40:47 +0200 The kobject_put() function was called in a few cases by the class_register_type() function during error handling even if the passed data structure element did not contain a pointer for a valid data item. Adjust jump targets according to

Re: [PATCH 02/32] x86/intel_rdt: Add support for Cache Allocation detection

2016-07-26 Thread Nilay Vaish
On 12 July 2016 at 20:02, Fenghua Yu wrote: > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index 0fe6953..42c90cb 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -711,6 +711,21 @@ void get_cpu_cap(struct

Re: [PATCH 02/32] x86/intel_rdt: Add support for Cache Allocation detection

2016-07-26 Thread Nilay Vaish
On 12 July 2016 at 20:02, Fenghua Yu wrote: > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index 0fe6953..42c90cb 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -711,6 +711,21 @@ void get_cpu_cap(struct cpuinfo_x86 *c) >

[PATCH 02/12] staging: lustre: Delete unnecessary checks before the function call "kobject_put"

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 13:00:32 +0200 The kobject_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software.

[PATCH 02/12] staging: lustre: Delete unnecessary checks before the function call "kobject_put"

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 13:00:32 +0200 The kobject_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-26 Thread Josh Poimboeuf
On Tue, Jul 26, 2016 at 01:49:06PM -0400, Brian Gerst wrote: > On Tue, Jul 26, 2016 at 12:47 PM, Josh Poimboeuf wrote: > > On Mon, Jul 25, 2016 at 05:09:44PM -0700, Andy Lutomirski wrote: > >> On Sat, Jul 23, 2016 at 7:04 AM, Josh Poimboeuf > >> wrote:

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-26 Thread Josh Poimboeuf
On Tue, Jul 26, 2016 at 01:49:06PM -0400, Brian Gerst wrote: > On Tue, Jul 26, 2016 at 12:47 PM, Josh Poimboeuf wrote: > > On Mon, Jul 25, 2016 at 05:09:44PM -0700, Andy Lutomirski wrote: > >> On Sat, Jul 23, 2016 at 7:04 AM, Josh Poimboeuf > >> wrote: > >> > Am I correct in understanding that

[PATCH 0/1] (Was: introduce for_each_process_thread_{break,continue}() helpers)

2016-07-26 Thread Oleg Nesterov
On 07/25, Oleg Nesterov wrote: > > IMHO this makes sense in any case, but mostly this is preparation for > another change: show_state_filter() should be preemptible. But this needs > more discussion, I'll write another email/patch when I fully understand > the hard-lockup caused by sysrq-t. Yes,

[PATCH 01/12] staging/lustre/ldlm: Delete unnecessary checks before the function call "kset_unregister"

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 11:33:43 +0200 The kset_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software.

[PATCH 0/1] (Was: introduce for_each_process_thread_{break,continue}() helpers)

2016-07-26 Thread Oleg Nesterov
On 07/25, Oleg Nesterov wrote: > > IMHO this makes sense in any case, but mostly this is preparation for > another change: show_state_filter() should be preemptible. But this needs > more discussion, I'll write another email/patch when I fully understand > the hard-lockup caused by sysrq-t. Yes,

[PATCH 01/12] staging/lustre/ldlm: Delete unnecessary checks before the function call "kset_unregister"

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 26 Jul 2016 11:33:43 +0200 The kset_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring ---

[PATCH 1/1] stop_machine: touch_nmi_watchdog() after MULTI_STOP_PREPARE

2016-07-26 Thread Oleg Nesterov
Suppose that stop_machine(fn) hangs because fn() hangs. In this case NMI hard-lockup can be triggered on another CPU which does nothing wrong and the trace from nmi_panic() won't help to investigate the problem. And this change "fixes" the problem we (seem to) hit in practice. - stop_two_cpus(0,

[PATCH 1/1] stop_machine: touch_nmi_watchdog() after MULTI_STOP_PREPARE

2016-07-26 Thread Oleg Nesterov
Suppose that stop_machine(fn) hangs because fn() hangs. In this case NMI hard-lockup can be triggered on another CPU which does nothing wrong and the trace from nmi_panic() won't help to investigate the problem. And this change "fixes" the problem we (seem to) hit in practice. - stop_two_cpus(0,

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-26 Thread Josh Poimboeuf
On Tue, Jul 26, 2016 at 01:51:27PM -0400, Steven Rostedt wrote: > On Tue, 26 Jul 2016 11:26:42 -0500 > Josh Poimboeuf wrote: > > > > Ok, I think that makes sense to me now. As I understand it, the > > "outermost" RIP is the authoritative one, because it was written by the

Re: [PATCH 10/19] x86/dumpstack: add get_stack_info() interface

2016-07-26 Thread Josh Poimboeuf
On Tue, Jul 26, 2016 at 01:51:27PM -0400, Steven Rostedt wrote: > On Tue, 26 Jul 2016 11:26:42 -0500 > Josh Poimboeuf wrote: > > > > Ok, I think that makes sense to me now. As I understand it, the > > "outermost" RIP is the authoritative one, because it was written by the > > original NMI.

Re: [PATCH v2 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-07-26 Thread Michael S. Tsirkin
On Wed, Jun 29, 2016 at 06:32:13PM +0800, Liang Li wrote: > This patch set contains two parts of changes to the virtio-balloon. > > One is the change for speeding up the inflating & deflating process, > the main idea of this optimization is to use bitmap to send the page > information to host

Re: [PATCH v2 kernel 0/7] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-07-26 Thread Michael S. Tsirkin
On Wed, Jun 29, 2016 at 06:32:13PM +0800, Liang Li wrote: > This patch set contains two parts of changes to the virtio-balloon. > > One is the change for speeding up the inflating & deflating process, > the main idea of this optimization is to use bitmap to send the page > information to host

[PATCH 00/12] staging-Lustre: Fine-tuning for seven function implementations

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (12): ldlm: Delete unnecessary checks before the function call "kset_unregister" Delete unnecessary checks before

Re: [PATCH v2 2/4] dt-bindings: Add a binding for Mediatek MDP

2016-07-26 Thread Rob Herring
On Fri, Jul 22, 2016 at 04:33:01PM +0800, Minghsiu Tsai wrote: > Add a DT binding documentation of MDP for the MT8173 SoC > from Mediatek > > Signed-off-by: Minghsiu Tsai > --- > .../devicetree/bindings/media/mediatek-mdp.txt | 96 > > 1

[PATCH 00/12] staging-Lustre: Fine-tuning for seven function implementations

2016-07-26 Thread SF Markus Elfring
From: Markus Elfring Further update suggestions were taken into account after a patch was applied from static source code analysis. Markus Elfring (12): ldlm: Delete unnecessary checks before the function call "kset_unregister" Delete unnecessary checks before the function call

Re: [PATCH v2 2/4] dt-bindings: Add a binding for Mediatek MDP

2016-07-26 Thread Rob Herring
On Fri, Jul 22, 2016 at 04:33:01PM +0800, Minghsiu Tsai wrote: > Add a DT binding documentation of MDP for the MT8173 SoC > from Mediatek > > Signed-off-by: Minghsiu Tsai > --- > .../devicetree/bindings/media/mediatek-mdp.txt | 96 > > 1 file changed, 96

Re: [PATCH v3] virtio: new feature to detect IOMMU device quirk

2016-07-26 Thread Michael S. Tsirkin
On Mon, Jul 25, 2016 at 12:50:09AM -0700, Christoph Hellwig wrote: > On Tue, Jul 19, 2016 at 05:38:23AM +0300, Michael S. Tsirkin wrote: > > > > On other systems, including SPARC and PPC64, virtio-pci devices are > > enumerated as though they are behind an IOMMU, but the virtio host > > ignores

Re: [PATCH v3] virtio: new feature to detect IOMMU device quirk

2016-07-26 Thread Michael S. Tsirkin
On Mon, Jul 25, 2016 at 12:50:09AM -0700, Christoph Hellwig wrote: > On Tue, Jul 19, 2016 at 05:38:23AM +0300, Michael S. Tsirkin wrote: > > > > On other systems, including SPARC and PPC64, virtio-pci devices are > > enumerated as though they are behind an IOMMU, but the virtio host > > ignores

Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"

2016-07-26 Thread Max Filippov
On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote: > This partially reverts commit 69d99e6c0d62 keeping only the main > purpose of the original commit which is the removal of > of_platform_populate() call. The moving of of_clk_init() caused changes > in the initialization order breaking

Re: [PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"

2016-07-26 Thread Max Filippov
On Tue, Jul 26, 2016 at 01:01:32PM -0500, Rob Herring wrote: > This partially reverts commit 69d99e6c0d62 keeping only the main > purpose of the original commit which is the removal of > of_platform_populate() call. The moving of of_clk_init() caused changes > in the initialization order breaking

Re: [PATCH] iio: orientation: Add BNO055 9-axis Absolute Orientation Sensor driver

2016-07-26 Thread Peter Meerwald-Stadler
Hallo Navin, > Thanks for reviewing the patch. I will send the updated patch. I am sorry to have overlooked a previous patch by Vlad Dogaru, see http://comments.gmane.org/gmane.linux.kernel.iio/24643, for the BNO055 there have been a number of issues, it has not been accepted yet I think our

Re: [PATCH] iio: orientation: Add BNO055 9-axis Absolute Orientation Sensor driver

2016-07-26 Thread Peter Meerwald-Stadler
Hallo Navin, > Thanks for reviewing the patch. I will send the updated patch. I am sorry to have overlooked a previous patch by Vlad Dogaru, see http://comments.gmane.org/gmane.linux.kernel.iio/24643, for the BNO055 there have been a number of issues, it has not been accepted yet I think our

[GIT PULL] arch/tile changes for 4.8

2016-07-26 Thread Chris Metcalf
Linus, Please pull the following changes for 4.8 from: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git master A few stray changes. Chris Metcalf (3): tile: allow disabling CONFIG_EARLY_PRINTK tile 32-bit big-endian: fix bugs in syscall argument order

Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-07-26 Thread Brian Norris
Hi Thierry, On Tue, Jul 26, 2016 at 11:14:33AM +0200, Thierry Reding wrote: > On Mon, Jul 25, 2016 at 01:48:25PM -0700, Brian Norris wrote: > > On Mon, Jul 25, 2016 at 10:43:13PM +0200, Wolfram Sang wrote: > > > On Mon, Jul 25, 2016 at 11:14:10AM -0700, Brian Norris wrote: > > > >

[GIT PULL] arch/tile changes for 4.8

2016-07-26 Thread Chris Metcalf
Linus, Please pull the following changes for 4.8 from: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git master A few stray changes. Chris Metcalf (3): tile: allow disabling CONFIG_EARLY_PRINTK tile 32-bit big-endian: fix bugs in syscall argument order

Re: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()

2016-07-26 Thread Brian Norris
Hi Thierry, On Tue, Jul 26, 2016 at 11:14:33AM +0200, Thierry Reding wrote: > On Mon, Jul 25, 2016 at 01:48:25PM -0700, Brian Norris wrote: > > On Mon, Jul 25, 2016 at 10:43:13PM +0200, Wolfram Sang wrote: > > > On Mon, Jul 25, 2016 at 11:14:10AM -0700, Brian Norris wrote: > > > >

[PATCH v2 2/2] usb: typec: add PD sink port support for Intel Whiskey Cove PMIC Typc-C PHY driver

2016-07-26 Thread Bin Gao
From: Chandra Sekhar Anagani This adds PD sink port support for the USB Type-C PHY on Intel WhiskeyCove PMIC which is available on some of the Intel Broxton SoC based platforms. This patch depends on these two patches: https://lkml.org/lkml/2016/6/29/349

[PATCH v2 2/2] usb: typec: add PD sink port support for Intel Whiskey Cove PMIC Typc-C PHY driver

2016-07-26 Thread Bin Gao
From: Chandra Sekhar Anagani This adds PD sink port support for the USB Type-C PHY on Intel WhiskeyCove PMIC which is available on some of the Intel Broxton SoC based platforms. This patch depends on these two patches: https://lkml.org/lkml/2016/6/29/349 https://lkml.org/lkml/2016/6/29/350

Re: [PATCH 0/5 RFC] Add an interface to discover relationships between namespaces

2016-07-26 Thread W. Trevor King
On Tue, Jul 26, 2016 at 11:25:24AM -0700, Andrew Vagin wrote: > Sure. If a process wants to compare two namespaces, it needs to get file > descriptors for them (open /proc/PID/ns/XXX, use new ioctl-s, find a > process which has them), > and then it calls kcmp(pid1, pid2, KCMP_NSFD, ns_fd1, ns_fd2)

Re: [PATCH 0/5 RFC] Add an interface to discover relationships between namespaces

2016-07-26 Thread W. Trevor King
On Tue, Jul 26, 2016 at 11:25:24AM -0700, Andrew Vagin wrote: > Sure. If a process wants to compare two namespaces, it needs to get file > descriptors for them (open /proc/PID/ns/XXX, use new ioctl-s, find a > process which has them), > and then it calls kcmp(pid1, pid2, KCMP_NSFD, ns_fd1, ns_fd2)

[PATCH v2 1/2] usb: typec: Add USB Power Delivery sink port support

2016-07-26 Thread Bin Gao
This patch implements a simple USB Power Delivery sink port state machine. It assumes the hardware only handles PD packet transmitting and receiving over the CC line of the USB Type-C connector. The state transition is completely controlled by software. This patch only implement the sink port

[PATCH v2 1/2] usb: typec: Add USB Power Delivery sink port support

2016-07-26 Thread Bin Gao
This patch implements a simple USB Power Delivery sink port state machine. It assumes the hardware only handles PD packet transmitting and receiving over the CC line of the USB Type-C connector. The state transition is completely controlled by software. This patch only implement the sink port

Re: [PATCH v3 1/7] firmware: rockchip: sip: Add rockchip SIP runtime service

2016-07-26 Thread Mark Rutland
On Fri, Jul 22, 2016 at 05:07:14PM +0800, Lin Huang wrote: > +config ROCKCHIP_SIP > + bool "Rockchip SIP interface" > + depends on ARM64 && ARM_PSCI_FW > + help > + Say Y here if you want to enable SIP callbacks for Rockchip platforms > + This option enables support for

Re: [PATCH v3 1/7] firmware: rockchip: sip: Add rockchip SIP runtime service

2016-07-26 Thread Mark Rutland
On Fri, Jul 22, 2016 at 05:07:14PM +0800, Lin Huang wrote: > +config ROCKCHIP_SIP > + bool "Rockchip SIP interface" > + depends on ARM64 && ARM_PSCI_FW > + help > + Say Y here if you want to enable SIP callbacks for Rockchip platforms > + This option enables support for

[PATCH v2 0/2] usb: typec: Introduce USB PD sink state machine driver and add PD sink support for Intel BXT PMIC Type-C phy

2016-07-26 Thread Bin Gao
This series introduce a USB PD(Power Delivery) sink port simple state machine driver and adds USB PD sink port support for Intel BXT Whiskey Cove PMIC Type-C phy driver. This series depends on these two patches: https://lkml.org/lkml/2016/6/29/349 https://lkml.org/lkml/2016/6/29/350 Bin Gao (1):

[PATCH v2 0/2] usb: typec: Introduce USB PD sink state machine driver and add PD sink support for Intel BXT PMIC Type-C phy

2016-07-26 Thread Bin Gao
This series introduce a USB PD(Power Delivery) sink port simple state machine driver and adds USB PD sink port support for Intel BXT Whiskey Cove PMIC Type-C phy driver. This series depends on these two patches: https://lkml.org/lkml/2016/6/29/349 https://lkml.org/lkml/2016/6/29/350 Bin Gao (1):

<    1   2   3   4   5   6   7   8   9   10   >