[PATCH net-next v3 1/2] e1000e: factor out systim sanitization

This is prepatory work for an expanding list of adapter families that have occasional ~10 hour clock jumps when being used for PTP. Factor out the sanitization function and convert to using a feature (bug) flag, per suggestion from Jesse Brandeburg. Littering functional code with device-specific

[PATCH net-next v3 1/2] e1000e: factor out systim sanitization

This is prepatory work for an expanding list of adapter families that have occasional ~10 hour clock jumps when being used for PTP. Factor out the sanitization function and convert to using a feature (bug) flag, per suggestion from Jesse Brandeburg. Littering functional code with device-specific

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

On 2016-07-26 09:59, Christian Lamparter wrote: Thanks, I gave the program a try with my WNDA3100 and a WN821N v2 devices. I did not see any corruptions in any of the tests though. Can you tell me something about your wireless network too? I would like to know what router and firmware are you

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

On 2016-07-26 09:59, Christian Lamparter wrote: Thanks, I gave the program a try with my WNDA3100 and a WN821N v2 devices. I did not see any corruptions in any of the tests though. Can you tell me something about your wireless network too? I would like to know what router and firmware are you

[PATCH v3 net-next 0/2] e1000e: fix PTP on e1000_pch_variants

This little series factors out the systim sanitization code first, then adds e1000_pch_lpt as a new case in the switch that calls the sanitize function, fixing PTP clock issues I've had reported against an Intel I-218V NIC in an Intel NUC5ik5RYH system. Jarod Wilson (2): e1000e: factor out

[PATCH net-next v3 2/2] e1000e: fix PTP on e1000_pch_lpt variants

I've got reports that the Intel I-218V NIC in Intel NUC5i5RYH systems used as a PTP slave experiences random ~10 hour clock jumps, which are resolved if the same workaround for the 82574 and 82583 is employed, so set the appropriate flag2 in e1000_pch_lpt_info too. Reported-by: Rupesh Patel

[PATCH v3 net-next 0/2] e1000e: fix PTP on e1000_pch_variants

This little series factors out the systim sanitization code first, then adds e1000_pch_lpt as a new case in the switch that calls the sanitize function, fixing PTP clock issues I've had reported against an Intel I-218V NIC in an Intel NUC5ik5RYH system. Jarod Wilson (2): e1000e: factor out

[PATCH net-next v3 2/2] e1000e: fix PTP on e1000_pch_lpt variants

I've got reports that the Intel I-218V NIC in Intel NUC5i5RYH systems used as a PTP slave experiences random ~10 hour clock jumps, which are resolved if the same workaround for the 82574 and 82583 is employed, so set the appropriate flag2 in e1000_pch_lpt_info too. Reported-by: Rupesh Patel CC:

[PATCH] [RFC] Introduce mmap randomization

From: William Roberts This patch introduces the ability randomize mmap locations where the address is not requested, for instance when ld is allocating pages for shared libraries. It chooses to randomize based on the current personality for ASLR. Currently,

[PATCH] [RFC] Introduce mmap randomization

From: William Roberts This patch introduces the ability randomize mmap locations where the address is not requested, for instance when ld is allocating pages for shared libraries. It chooses to randomize based on the current personality for ASLR. Currently, allocations are done sequentially

[PATCH] [RFC] Introduce mmap randomization

The recent get_random_long() change in get_random_range() and then the subsequent patches Jason put out, all stemmed from my tinkering with the concept of randomizing mmap. Any feedback would be greatly appreciated, including any feedback indicating that I am idiot.

[PATCH] pwm: cros_ec: add __packed to prevent padding

While the particular usage in question is likely safe (struct cros_ec_command is 32-bit aligned, followed by <=32-bit fields), it's been suggested this is not a great pattern to follow for the general case -- for example, if we follow a 'struct cros_ec_command' (which is 32-bit- but not

Re: [PATCH] fs: configfs: don't set buffer_needs_fill to zero if show() returns error

On Fri, Jul 1, 2016 at 12:28 PM, Tal Shorer wrote: > A confgifs attribute's show() callback is called once the first time > the user attempts to read from it. If it returns an error, that > error is returned to the user. However, the open file's > buffer_needs_fill is still

Re: [patch 61/66] timers: Convert to hotplug state machine

Hi Richard, On 26/07/16 15:40, rcoch...@linutronix.de wrote: > Jon, > > On Tue, Jul 26, 2016 at 10:20:58AM +0100, Jon Hunter wrote: >> Thanks. I have not tried another ARM based device, but I would be >> curious if another ARM device sees this or not. > > I do see this stall on socfpga and on

[PATCH] [RFC] Introduce mmap randomization

The recent get_random_long() change in get_random_range() and then the subsequent patches Jason put out, all stemmed from my tinkering with the concept of randomizing mmap. Any feedback would be greatly appreciated, including any feedback indicating that I am idiot.

[PATCH] pwm: cros_ec: add __packed to prevent padding

While the particular usage in question is likely safe (struct cros_ec_command is 32-bit aligned, followed by <=32-bit fields), it's been suggested this is not a great pattern to follow for the general case -- for example, if we follow a 'struct cros_ec_command' (which is 32-bit- but not

Re: [PATCH] fs: configfs: don't set buffer_needs_fill to zero if show() returns error

On Fri, Jul 1, 2016 at 12:28 PM, Tal Shorer wrote: > A confgifs attribute's show() callback is called once the first time > the user attempts to read from it. If it returns an error, that > error is returned to the user. However, the open file's > buffer_needs_fill is still set to zero and

Re: [patch 61/66] timers: Convert to hotplug state machine

Hi Richard, On 26/07/16 15:40, rcoch...@linutronix.de wrote: > Jon, > > On Tue, Jul 26, 2016 at 10:20:58AM +0100, Jon Hunter wrote: >> Thanks. I have not tried another ARM based device, but I would be >> curious if another ARM device sees this or not. > > I do see this stall on socfpga and on

Re: [PATCH v2] i2c: i2c-cros-ec-tunnel: Reduce logging noise

Hi, On Mon, Jul 25, 2016 at 1:58 PM, Guenter Roeck wrote: > If an i2c access through i2c-cros-ec-tunnel returns an error, the following > log message is seen on the console. > > cros-ec-i2c-tunnel ff20.spi:ec@0:i2c-tunnel: > Error parsing EC i2c

Re: [PATCH v2] i2c: i2c-cros-ec-tunnel: Reduce logging noise

Hi, On Mon, Jul 25, 2016 at 1:58 PM, Guenter Roeck wrote: > If an i2c access through i2c-cros-ec-tunnel returns an error, the following > log message is seen on the console. > > cros-ec-i2c-tunnel ff20.spi:ec@0:i2c-tunnel: > Error parsing EC i2c message -121 > > This

[PATCH memory-barriers.txt 4/5] Doc/memory-barriers: Fix a typo of example result

From: SeongJae Park An example result for data dependent write has a typo. This commit fixes the wrong typo. Signed-off-by: SeongJae Park Signed-off-by: Paul E. McKenney --- Documentation/memory-barriers.txt | 2 +- 1

[PATCH v2] reset: uniphier: add reset controller drivers for UniPhier SoCs

This is the initial commit for UniPhier reset controller drivers. Signed-off-by: Masahiro Yamada --- Changes in v2 (mostly suggested by Philipp Zabel): - Unify multiple module_platform_driver() boilerplates into one - Unify tiny driver code and decrease the

Re: [patch 61/66] timers: Convert to hotplug state machine

Hi Thomas, On 26/07/16 15:15, Thomas Gleixner wrote: > Jon, > > On Tue, 26 Jul 2016, Jon Hunter wrote: >> On 25/07/16 16:35, rcoch...@linutronix.de wrote: >>> Just to be sure, this problem didn't exist before the HP rework, that >>> is, suspend worked fine with and without CONFIG_PREEMPT, right?

[PATCH memory-barriers.txt 4/5] Doc/memory-barriers: Fix a typo of example result

From: SeongJae Park An example result for data dependent write has a typo. This commit fixes the wrong typo. Signed-off-by: SeongJae Park Signed-off-by: Paul E. McKenney --- Documentation/memory-barriers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2] reset: uniphier: add reset controller drivers for UniPhier SoCs

This is the initial commit for UniPhier reset controller drivers. Signed-off-by: Masahiro Yamada --- Changes in v2 (mostly suggested by Philipp Zabel): - Unify multiple module_platform_driver() boilerplates into one - Unify tiny driver code and decrease the number of files - Invert the

Re: [patch 61/66] timers: Convert to hotplug state machine

Hi Thomas, On 26/07/16 15:15, Thomas Gleixner wrote: > Jon, > > On Tue, 26 Jul 2016, Jon Hunter wrote: >> On 25/07/16 16:35, rcoch...@linutronix.de wrote: >>> Just to be sure, this problem didn't exist before the HP rework, that >>> is, suspend worked fine with and without CONFIG_PREEMPT, right?

[PATCH memory-barriers.txt 3/5] memory-barriers.txt: Fix wrong section reference

From: SeongJae Park Signed-off-by: SeongJae Park Signed-off-by: Paul E. McKenney --- Documentation/memory-barriers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/memory-barriers.txt

[PATCH memory-barriers.txt 3/5] memory-barriers.txt: Fix wrong section reference

From: SeongJae Park Signed-off-by: SeongJae Park Signed-off-by: Paul E. McKenney --- Documentation/memory-barriers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt index e1926a096818..19c8eb6f246e

[PATCH memory-barriers.txt 1/5] documentation: Clarify limited control-dependency scope

Nothing in the control-dependencies section of memory-barriers.txt says that control dependencies don't extend beyond the end of the if-statement containing the control dependency. Worse yet, in many situations, they do extend beyond that if-statement. In particular, the compiler cannot destroy

[PATCH memory-barriers.txt 2/5] memory-barriers.txt: Maintain consistent blank line

From: SeongJae Park Signed-off-by: SeongJae Park Signed-off-by: Paul E. McKenney --- Documentation/memory-barriers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/memory-barriers.txt

[PATCH memory-barriers.txt 1/5] documentation: Clarify limited control-dependency scope

Nothing in the control-dependencies section of memory-barriers.txt says that control dependencies don't extend beyond the end of the if-statement containing the control dependency. Worse yet, in many situations, they do extend beyond that if-statement. In particular, the compiler cannot destroy

[PATCH memory-barriers.txt 2/5] memory-barriers.txt: Maintain consistent blank line

From: SeongJae Park Signed-off-by: SeongJae Park Signed-off-by: Paul E. McKenney --- Documentation/memory-barriers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt index a4d0a99de04d..e1926a096818 100644 ---

[PATCH memory-barriers.txt 0/5] Fixes and Korean translation

Hello! This series provides some fixes and updates: 1. Clarify the limited scope of control dependencies. 2. Whitespace fixes, courtesy of SeongJae Park. 3. Fix a section reference, courtesy of SeongJae Park. 4. Fix a bug in a memory-ordering example, courtesy of SeongJae

[PATCH memory-barriers.txt 0/5] Fixes and Korean translation

Hello! This series provides some fixes and updates: 1. Clarify the limited scope of control dependencies. 2. Whitespace fixes, courtesy of SeongJae Park. 3. Fix a section reference, courtesy of SeongJae Park. 4. Fix a bug in a memory-ordering example, courtesy of SeongJae

Re: [patch 61/66] timers: Convert to hotplug state machine

Hi Richard, On 26/07/16 16:42, rcoch...@linutronix.de wrote: > Jon, > > On Mon, Jul 25, 2016 at 03:56:48PM +0100, Jon Hunter wrote: >>> When tearing down, call timers_dead_cpu before notify_dead. >>> There is a hidden dependency between: >>> >>> - timers >>> - Block multiqueue >>> - rcutree >>>

Re: [patch 61/66] timers: Convert to hotplug state machine

Hi Richard, On 26/07/16 16:42, rcoch...@linutronix.de wrote: > Jon, > > On Mon, Jul 25, 2016 at 03:56:48PM +0100, Jon Hunter wrote: >>> When tearing down, call timers_dead_cpu before notify_dead. >>> There is a hidden dependency between: >>> >>> - timers >>> - Block multiqueue >>> - rcutree >>>

[PATCH v5 2/2] clk: uniphier: add clock data for UniPhier SoCs

Add clock data arrays for all UniPhier SoCs. Signed-off-by: Masahiro Yamada --- .../devicetree/bindings/clock/uniphier-clock.txt | 123 drivers/clk/uniphier/Makefile | 3 + drivers/clk/uniphier/clk-uniphier-core.c | 91 +++

[PATCH v5 1/2] clk: uniphier: add core support code for UniPhier clock drivers

This is the common code for the clock drivers of UniPhier SoCs. Signed-off-by: Masahiro Yamada --- MAINTAINERS | 1 + drivers/clk/Kconfig | 1 + drivers/clk/Makefile

[PATCH v5 2/2] clk: uniphier: add clock data for UniPhier SoCs

Add clock data arrays for all UniPhier SoCs. Signed-off-by: Masahiro Yamada --- .../devicetree/bindings/clock/uniphier-clock.txt | 123 drivers/clk/uniphier/Makefile | 3 + drivers/clk/uniphier/clk-uniphier-core.c | 91 +++

[PATCH v5 1/2] clk: uniphier: add core support code for UniPhier clock drivers

This is the common code for the clock drivers of UniPhier SoCs. Signed-off-by: Masahiro Yamada --- MAINTAINERS | 1 + drivers/clk/Kconfig | 1 + drivers/clk/Makefile | 1 +

Re: [PATCH v2 30/58] staging: lustre: create striped directory

> On Tue, 2016-07-26 at 12:36 -0400, James Simmons wrote: > > From: wang di > > > > 1. client send create request to the master MDT, which > >   will allocate FIDs and create slaves. for all of slaves. > > > > 2. Client needs to revalidate slaves during intent getattr > >    

Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

On Tue, Jul 26, 2016 at 10:38:24PM +0530, Bhaktipriya Shridhar wrote: > The workqueue health->wq was used as per device private health thread. > This was done to perform delayed work. > > The workqueue has a single workitem(>work) and > hence doesn't require ordering. It is involved in handling

[PATCH v2 00/22] usb: serial: ti_usb_3410_5052: clean driver

Hi Johan, Thanks for your review ! Here is the v2 of the serie. I didn't resubmit patches related to the switch to generic implementation (open, close, read and write). I will work on them later when this first batch will be pushed. Thank you, Mathieu Mathieu OTHACEHE (22): usb: serial:

[PATCH v2 01/22] usb: serial: ti_usb_3410_5052: Do not use __uX types

__uX types should only be used for user-space interactions. Signed-off-by: Mathieu OTHACEHE --- Changelog: v2: * Replace cpu_to_be16s calls by cpu_to_be16 * Remove other useless casts drivers/usb/serial/ti_usb_3410_5052.c | 101 +- 1 file

[PATCH v5 0/2] clk: uniphier: add clock drivers for UniPhier SoCs

I split into two patches to make review easier. 1/2: core support code 2/2: data arrays Changes in v5: - Rebase onto next-20160726 for easier git-am Changes in v4: - Unify module_platform_driver() boilerplate into a single place - Add binding document - Add USB3 clocks Changes in v3

Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

On Tue, Jul 26, 2016 at 10:38:24PM +0530, Bhaktipriya Shridhar wrote: > The workqueue health->wq was used as per device private health thread. > This was done to perform delayed work. > > The workqueue has a single workitem(>work) and > hence doesn't require ordering. It is involved in handling

[PATCH v2 00/22] usb: serial: ti_usb_3410_5052: clean driver

Hi Johan, Thanks for your review ! Here is the v2 of the serie. I didn't resubmit patches related to the switch to generic implementation (open, close, read and write). I will work on them later when this first batch will be pushed. Thank you, Mathieu Mathieu OTHACEHE (22): usb: serial:

[PATCH v2 01/22] usb: serial: ti_usb_3410_5052: Do not use __uX types

__uX types should only be used for user-space interactions. Signed-off-by: Mathieu OTHACEHE --- Changelog: v2: * Replace cpu_to_be16s calls by cpu_to_be16 * Remove other useless casts drivers/usb/serial/ti_usb_3410_5052.c | 101 +- 1 file changed, 51

[PATCH v5 0/2] clk: uniphier: add clock drivers for UniPhier SoCs

I split into two patches to make review easier. 1/2: core support code 2/2: data arrays Changes in v5: - Rebase onto next-20160726 for easier git-am Changes in v4: - Unify module_platform_driver() boilerplate into a single place - Add binding document - Add USB3 clocks Changes in v3

Re: [PATCH v2 30/58] staging: lustre: create striped directory

> On Tue, 2016-07-26 at 12:36 -0400, James Simmons wrote: > > From: wang di > > > > 1. client send create request to the master MDT, which > >   will allocate FIDs and create slaves. for all of slaves. > > > > 2. Client needs to revalidate slaves during intent getattr > >    and open request.

[PATCH v2 05/22] usb: serial: ti_usb_3410_5052: Use C_X macros instead of c_cflag manipulation

Use C_X tty.h macros to avoid direct manipulation of termios c_cflag variable. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH v2 05/22] usb: serial: ti_usb_3410_5052: Use C_X macros instead of c_cflag manipulation

Use C_X tty.h macros to avoid direct manipulation of termios c_cflag variable. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c

[PATCH v2 12/22] usb: serial: ti_usb_3410_5052: Remove usb_serial pointer in ti_port

There is no need to keep a pointer to usb_serial in ti_port structure. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c

[PATCH v2 12/22] usb: serial: ti_usb_3410_5052: Remove usb_serial pointer in ti_port

There is no need to keep a pointer to usb_serial in ti_port structure. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c

[PATCH v2 07/22] usb: serial: ti_usb_3410_5052: Use macros instead of magic values

Use macros to define 3410 and 5052 baud bases. Use macro to define usb download timeout. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git

[PATCH v2 04/22] usb: serial: ti_usb_3410_5052: Remove useless NULL-testing

It is useless to check the return of usb_get_serial_port_data. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 34 +- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git

[PATCH v2 07/22] usb: serial: ti_usb_3410_5052: Use macros instead of magic values

Use macros to define 3410 and 5052 baud bases. Use macro to define usb download timeout. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c

[PATCH v2 04/22] usb: serial: ti_usb_3410_5052: Remove useless NULL-testing

It is useless to check the return of usb_get_serial_port_data. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 34 +- 1 file changed, 1 insertion(+), 33 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c

[PATCH v2 13/22] usb: serial: ti_usb_3410_5052: Change ti_get/set_serial_info function arguments

It is sufficient to pass usb_serial_port structure to ti_get_serial_info and ti_set_serial_info. Also use unsigned int instead of unsigned for cwait variable. Signed-off-by: Mathieu OTHACEHE --- Changelog: v2: * Do not remove prototypes and move functions declarations.

[PATCH v2 18/22] usb: serial: ti_usb_3410_5052: Standardize debug and error messages

Use the format "error text: error value\n" when possible. Drop redundant function names from error messages. Also move a couple err messages to dbg messages. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 105 --

[PATCH v2 20/22] usb: serial: ti_usb_3410_5052: Set shadow msr before waking up waiters

Save msr before testing the delta and waking up any waiters. Also use port directly instead of tport->tp_port. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH v2 17/22] usb: serial: ti_usb_3410_5052: Fix firmware downloading

The buffer used to store firmware is allocated to maximum firmware size (TI_FIRMWARE_BUF_SIZE) + header size. This buffer is filled with requested firmware (fw_p->size) and padded with 0xff bytes. The header is written over the 3 first bytes of the buffer (overwritting the 3 first bytes of the

[PATCH v2 11/22] usb: serial: ti_usb_3410_5052: Do not modify interrupt context

It is useless to pass a specific context (ti_device) to the interrupt callback. So use the default context (usb_serial_port). Remove useless variables in ti_interrupt_callback. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 58

[PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments

Remove useless ti_device pointer, and change addr to u32. Change size variable in function from int to size_t. Also fix minor style issue. Signed-off-by: Mathieu OTHACEHE --- Changelog: v2: * Do not delete prototype and move function declaration

[PATCH v2 11/22] usb: serial: ti_usb_3410_5052: Do not modify interrupt context

It is useless to pass a specific context (ti_device) to the interrupt callback. So use the default context (usb_serial_port). Remove useless variables in ti_interrupt_callback. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 58 --- 1

[PATCH v2 10/22] usb: serial: ti_usb_3410_5052: Change ti_write_byte function arguments

Remove useless ti_device pointer, and change addr to u32. Change size variable in function from int to size_t. Also fix minor style issue. Signed-off-by: Mathieu OTHACEHE --- Changelog: v2: * Do not delete prototype and move function declaration drivers/usb/serial/ti_usb_3410_5052.c | 20

[PATCH v2 20/22] usb: serial: ti_usb_3410_5052: Set shadow msr before waking up waiters

Save msr before testing the delta and waking up any waiters. Also use port directly instead of tport->tp_port. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

[PATCH v2 17/22] usb: serial: ti_usb_3410_5052: Fix firmware downloading

The buffer used to store firmware is allocated to maximum firmware size (TI_FIRMWARE_BUF_SIZE) + header size. This buffer is filled with requested firmware (fw_p->size) and padded with 0xff bytes. The header is written over the 3 first bytes of the buffer (overwritting the 3 first bytes of the

[PATCH v2 13/22] usb: serial: ti_usb_3410_5052: Change ti_get/set_serial_info function arguments

It is sufficient to pass usb_serial_port structure to ti_get_serial_info and ti_set_serial_info. Also use unsigned int instead of unsigned for cwait variable. Signed-off-by: Mathieu OTHACEHE --- Changelog: v2: * Do not remove prototypes and move functions declarations.

[PATCH v2 18/22] usb: serial: ti_usb_3410_5052: Standardize debug and error messages

Use the format "error text: error value\n" when possible. Drop redundant function names from error messages. Also move a couple err messages to dbg messages. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 105 -- 1 file changed, 50

[PATCH v2 09/22] usb: serial: ti_usb_3410_5052: Remove useless tty_wakeup

tty_wakeup is already called when blocked bulk-out transfers complete. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c

[PATCH v2 02/22] usb: serial: ti_usb_3410_5052: Remove useless dev_dbg messages

Remove useless or redundant dev_dbg messages. Fix debug-message typos. Signed-off-by: Mathieu OTHACEHE --- Changelog: v2: * Keep some debug messages drivers/usb/serial/ti_usb_3410_5052.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff

[PATCH v2 09/22] usb: serial: ti_usb_3410_5052: Remove useless tty_wakeup

tty_wakeup is already called when blocked bulk-out transfers complete. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index

[PATCH v2 02/22] usb: serial: ti_usb_3410_5052: Remove useless dev_dbg messages

Remove useless or redundant dev_dbg messages. Fix debug-message typos. Signed-off-by: Mathieu OTHACEHE --- Changelog: v2: * Keep some debug messages drivers/usb/serial/ti_usb_3410_5052.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git

[PATCH v2 06/22] usb: serial: ti_usb_3410_5052: Remove unused variables

Remove variables affected but never read. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index

[PATCH v2 06/22] usb: serial: ti_usb_3410_5052: Remove unused variables

Remove variables affected but never read. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index 29bb62c..2b7fe89 100644 ---

[PATCH v2 03/22] usb: serial: ti_usb_3410_5052: Use kzalloc instead of kmalloc

Use kzalloc instead of kmalloc to avoid field initialisation to 0. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c

[PATCH v2 03/22] usb: serial: ti_usb_3410_5052: Use kzalloc instead of kmalloc

Use kzalloc instead of kmalloc to avoid field initialisation to 0. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index

[PATCH v2 14/22] usb: serial: ti_usb_3410_5052: Do not set shadow mcr in open callback

Setting DTR/RTS is handled using dtr_rts in tty_core. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index

[PATCH v2 14/22] usb: serial: ti_usb_3410_5052: Do not set shadow mcr in open callback

Setting DTR/RTS is handled using dtr_rts in tty_core. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index 3a88c2f..b5ea850 100644 ---

[PATCH v2 22/22] usb: serial: ti_usb_3410_5052: Fix indentation problems

Fix some minor indentation problems. Also correct a multi-line comment. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 42 +++ 1 file changed, 23 insertions(+), 19 deletions(-) diff --git

[PATCH v2 19/22] usb: serial: ti_usb_3410_5052: Use variables for vendor and product

Use variables for vendor and product in download_firmware to improve readability. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git

[PATCH v2 21/22] usb: serial: ti_usb_3410_5052: Add CMSPAR support

Add CMSPAR support in set_termios callback. Move TI_UART_ENABLE_PARITY_CHECKING setting in the upper block to avoid doing it twice. Delete useless TI_UART_ENABLE_PARITY_CHECKING unsetting. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 19

[PATCH v2 15/22] usb: serial: ti_usb_3410_5052: Check old_termios parameter in set_termios

The old_termios parameter is never used in set_termios callback. Add a check to old_termios to see if we can return right away because there is nothing to change. Also pass NULL for old_termios in open callback because it is the initial call to set_termios. Signed-off-by: Mathieu OTHACEHE

[PATCH v2 22/22] usb: serial: ti_usb_3410_5052: Fix indentation problems

Fix some minor indentation problems. Also correct a multi-line comment. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 42 +++ 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c

[PATCH v2 19/22] usb: serial: ti_usb_3410_5052: Use variables for vendor and product

Use variables for vendor and product in download_firmware to improve readability. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c

[PATCH v2 21/22] usb: serial: ti_usb_3410_5052: Add CMSPAR support

Add CMSPAR support in set_termios callback. Move TI_UART_ENABLE_PARITY_CHECKING setting in the upper block to avoid doing it twice. Delete useless TI_UART_ENABLE_PARITY_CHECKING unsetting. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 19 ++- 1 file

[PATCH v2 15/22] usb: serial: ti_usb_3410_5052: Check old_termios parameter in set_termios

The old_termios parameter is never used in set_termios callback. Add a check to old_termios to see if we can return right away because there is nothing to change. Also pass NULL for old_termios in open callback because it is the initial call to set_termios. Signed-off-by: Mathieu OTHACEHE ---

[PATCH v2 16/22] usb: serial: ti_usb_3410_5052: Raise DTR and RTS flags if speed is not null anymore

If speed is non null anymore, we can raise DTR and RTS flags in ti_set_termios. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c

[PATCH v2 16/22] usb: serial: ti_usb_3410_5052: Raise DTR and RTS flags if speed is not null anymore

If speed is non null anymore, we can raise DTR and RTS flags in ti_set_termios. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/ti_usb_3410_5052.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/serial/ti_usb_3410_5052.c b/drivers/usb/serial/ti_usb_3410_5052.c index

[PATCH v2 08/22] usb: serial: ti_usb_3410_5052: Remove in_sync and out_sync functions

ti_command_in_sync and ti_command_out_sync shouldn't use userspace datatypes (__uX), data should be void* to avoid casting and size should be size_t. This patch rewrite those functions with new names: ti_send_ctrl_data_urb and ti_recv_ctrl_urb. Also add a ti_send_ctrl_urb to simplify command

[PATCH v2 08/22] usb: serial: ti_usb_3410_5052: Remove in_sync and out_sync functions

ti_command_in_sync and ti_command_out_sync shouldn't use userspace datatypes (__uX), data should be void* to avoid casting and size should be size_t. This patch rewrite those functions with new names: ti_send_ctrl_data_urb and ti_recv_ctrl_urb. Also add a ti_send_ctrl_urb to simplify command

[PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"

This partially reverts commit 69d99e6c0d62 keeping only the main purpose of the original commit which is the removal of of_platform_populate() call. The moving of of_clk_init() caused changes in the initialization order breaking booting. Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary

[PATCH] xtensa: Partially Revert "xtensa: Remove unnecessary of_platform_populate with default match table"

This partially reverts commit 69d99e6c0d62 keeping only the main purpose of the original commit which is the removal of of_platform_populate() call. The moving of of_clk_init() caused changes in the initialization order breaking booting. Fixes: 69d99e6c0d621f ("xtensa: Remove unnecessary

Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

On Tue, Jul 26, 2016 at 10:53:55AM -0700, Jeff Kirsher wrote: > On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote: > > Per Jesse Brandeburg, e1000e should be using flags for this sort of > > thing. > > > > Littering functional code with device-specific checks is much messier > > than > >

Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

On Tue, Jul 26, 2016 at 10:53:55AM -0700, Jeff Kirsher wrote: > On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote: > > Per Jesse Brandeburg, e1000e should be using flags for this sort of > > thing. > > > > Littering functional code with device-specific checks is much messier > > than > >

Re: Volunteering for BeFS maintainership

On Tue, Jul 26, 2016 at 12:16:24AM +0100, Luis de Bethencourt wrote: > > I will wait a few days in case other people want to comment before. > Sounds great! Do you have a git tree set up for your befs development? And if you haven't made plans to use xfstests, I would certainly commend that

Re: Volunteering for BeFS maintainership

On Tue, Jul 26, 2016 at 12:16:24AM +0100, Luis de Bethencourt wrote: > > I will wait a few days in case other people want to comment before. > Sounds great! Do you have a git tree set up for your befs development? And if you haven't made plans to use xfstests, I would certainly commend that

Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support

On Tue, Jul 26, 2016 at 10:50:08AM +0100, Daniel Thompson wrote: > On 25/07/16 18:13, Catalin Marinas wrote: > >You get more unexpected side effects by not saving/restoring the whole > >stack. We looked into this on Friday and came to the conclusion that > >there is no safe way for kprobes to know

Re: [PATCH v15 04/10] arm64: Kprobes with single stepping support

On Tue, Jul 26, 2016 at 10:50:08AM +0100, Daniel Thompson wrote: > On 25/07/16 18:13, Catalin Marinas wrote: > >You get more unexpected side effects by not saving/restoring the whole > >stack. We looked into this on Friday and came to the conclusion that > >there is no safe way for kprobes to know

<    2   3   4   5   6   7   8   9   10   11   >