Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

2016-07-29 Thread David Ahern
On 7/28/16 10:20 PM, David Miller wrote: From: John Stultz Date: Thu, 28 Jul 2016 21:18:16 -0700 After moving my HiKey tree to pre-v4.8-rc, I noticed when using Android that I was getting routing errors after toggling networking on and off (or entering suspend). Wifi

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

2016-07-29 Thread David Ahern
On 7/28/16 10:20 PM, David Miller wrote: From: John Stultz Date: Thu, 28 Jul 2016 21:18:16 -0700 After moving my HiKey tree to pre-v4.8-rc, I noticed when using Android that I was getting routing errors after toggling networking on and off (or entering suspend). Wifi associated, but I got

Re: [PATCH] nbd: fix race in ioctl

2016-07-29 Thread Jens Axboe
On 07/29/2016 04:55 AM, Vegard Nossum wrote: On 05/30/2016 02:58 PM, Markus Pargmann wrote: Hi, On Friday 27 May 2016 12:59:35 Vegard Nossum wrote: Quentin ran into this bug: WARNING: CPU: 64 PID: 10085 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x65/0x80 [...] It seems fairly obvious that

Re: [PATCH] nbd: fix race in ioctl

2016-07-29 Thread Jens Axboe
On 07/29/2016 04:55 AM, Vegard Nossum wrote: On 05/30/2016 02:58 PM, Markus Pargmann wrote: Hi, On Friday 27 May 2016 12:59:35 Vegard Nossum wrote: Quentin ran into this bug: WARNING: CPU: 64 PID: 10085 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x65/0x80 [...] It seems fairly obvious that

Re: [RFC] mm: bail out in shrin_inactive_list

2016-07-29 Thread Johannes Weiner
On Mon, Jul 25, 2016 at 04:51:59PM +0900, Minchan Kim wrote: > With node-lru, if there are enough reclaimable pages in highmem > but nothing in lowmem, VM can try to shrink inactive list although > the requested zone is lowmem. > > The problem is direct reclaimer scans inactive list is fulled

Re: [RFC] mm: bail out in shrin_inactive_list

2016-07-29 Thread Johannes Weiner
On Mon, Jul 25, 2016 at 04:51:59PM +0900, Minchan Kim wrote: > With node-lru, if there are enough reclaimable pages in highmem > but nothing in lowmem, VM can try to shrink inactive list although > the requested zone is lowmem. > > The problem is direct reclaimer scans inactive list is fulled

Re: [PATCH] block: fix use-after-free in seq file

2016-07-29 Thread Jens Axboe
On 07/29/2016 02:40 AM, Vegard Nossum wrote: I got a KASAN report of use-after-free: == BUG: KASAN: use-after-free in klist_iter_exit+0x61/0x70 at addr 8800b6581508 Read of size 8 by task trinity-c1/315

Re: [PATCH] block: fix use-after-free in seq file

2016-07-29 Thread Jens Axboe
On 07/29/2016 02:40 AM, Vegard Nossum wrote: I got a KASAN report of use-after-free: == BUG: KASAN: use-after-free in klist_iter_exit+0x61/0x70 at addr 8800b6581508 Read of size 8 by task trinity-c1/315

[PATCH] ASoC: da7219: Make more efficient use of MCLK within driver

2016-07-29 Thread Adam Thomson
Currently, if the driver has control of MCLK then it remains enabled as long as the codec is in STANDBY or above. The MCLK is only really required in STANDBY when a 3-pole jack is inserted and the HP detect procedure is required to run. This patch updates the code to enable/disable the MCLK when

[PATCH] ASoC: da7219: Make more efficient use of MCLK within driver

2016-07-29 Thread Adam Thomson
Currently, if the driver has control of MCLK then it remains enabled as long as the codec is in STANDBY or above. The MCLK is only really required in STANDBY when a 3-pole jack is inserted and the HP detect procedure is required to run. This patch updates the code to enable/disable the MCLK when

[PATCH 1/2] i2c: add i2c_trylock_bus wrapper, use it

2016-07-29 Thread Peter Rosin
This unifies usage with i2c_lock_bus and i2c_unlock_bus, and paves the way for the next patch which looks a bit saner with this preparatory work taken care of beforehand. Signed-off-by: Peter Rosin --- drivers/i2c/i2c-core.c | 2 +- drivers/i2c/i2c-mux.c | 4 ++--

[PATCH 1/2] i2c: add i2c_trylock_bus wrapper, use it

2016-07-29 Thread Peter Rosin
This unifies usage with i2c_lock_bus and i2c_unlock_bus, and paves the way for the next patch which looks a bit saner with this preparatory work taken care of beforehand. Signed-off-by: Peter Rosin --- drivers/i2c/i2c-core.c | 2 +- drivers/i2c/i2c-mux.c | 4 ++-- include/linux/i2c.h| 14

Re: Makefile.sphinx:17: The 'sphinx-build' command was not found

2016-07-29 Thread Jonathan Corbet
On Thu, 28 Jul 2016 15:05:07 -0700 (PDT) Christian Kujau wrote: > Indeed, I don't have "sphinx-build" installed (nor do I want to build > documentation), running "make SPHINXBUILD=/bin/true help" makes the > warning go away. Is there a way to omit the warning when >

Re: Makefile.sphinx:17: The 'sphinx-build' command was not found

2016-07-29 Thread Jonathan Corbet
On Thu, 28 Jul 2016 15:05:07 -0700 (PDT) Christian Kujau wrote: > Indeed, I don't have "sphinx-build" installed (nor do I want to build > documentation), running "make SPHINXBUILD=/bin/true help" makes the > warning go away. Is there a way to omit the warning when > running "make help"? E.g.

Re: [PATCH 4/7] arm64: Use simpler API for random address requests

2016-07-29 Thread Will Deacon
On Thu, Jul 28, 2016 at 08:47:27PM +, Jason Cooper wrote: > Currently, all callers to randomize_range() set the length to 0 and > calculate end by adding a constant to the start address. We can > simplify the API to remove a bunch of needless checks and variables. > > Use the new

Re: [PATCH 4/7] arm64: Use simpler API for random address requests

2016-07-29 Thread Will Deacon
On Thu, Jul 28, 2016 at 08:47:27PM +, Jason Cooper wrote: > Currently, all callers to randomize_range() set the length to 0 and > calculate end by adding a constant to the start address. We can > simplify the API to remove a bunch of needless checks and variables. > > Use the new

Re: Build failure in linux mainline when building arcv2 images

2016-07-29 Thread Guenter Roeck
On 07/28/2016 10:20 PM, Vineet Gupta wrote: Hi Guenter, On 07/28/2016 08:23 PM, Guenter Roeck wrote: Hi Vineet, Mainline fails to build arcv2 images with the following error. {standard input}: Assembler messages: {standard input}:19174: Error: Instruction with long immediate data in delay

Re: Build failure in linux mainline when building arcv2 images

2016-07-29 Thread Guenter Roeck
On 07/28/2016 10:20 PM, Vineet Gupta wrote: Hi Guenter, On 07/28/2016 08:23 PM, Guenter Roeck wrote: Hi Vineet, Mainline fails to build arcv2 images with the following error. {standard input}: Assembler messages: {standard input}:19174: Error: Instruction with long immediate data in delay

Re: [PATCH v10 2/7] x86, acpi, cpu-hotplug: Enable acpi to register all possible cpus at boot time.

2016-07-29 Thread Thomas Gleixner
On Tue, 26 Jul 2016, Dou Liyang wrote: > 1. Enable apic registeration flow to handle both enabled and disabled cpus. >This is done by introducing an extra parameter to generic_processor_info to >let the caller control if disabled cpus are ignored. If I'm reading the patch correctly then

Re: [PATCH v10 2/7] x86, acpi, cpu-hotplug: Enable acpi to register all possible cpus at boot time.

2016-07-29 Thread Thomas Gleixner
On Tue, 26 Jul 2016, Dou Liyang wrote: > 1. Enable apic registeration flow to handle both enabled and disabled cpus. >This is done by introducing an extra parameter to generic_processor_info to >let the caller control if disabled cpus are ignored. If I'm reading the patch correctly then

Re: [PATCH 2/2] ARM: dts: TS-4900: add basic device tree

2016-07-29 Thread Fabio Estevam
Hi Lucile, This looks good. Only some minor nits: On Wed, Jul 27, 2016 at 2:53 PM, Lucile Quirion wrote: > @@ -0,0 +1,21 @@ > +/* > + * Copyright 2011 Freescale Semiconductor, Inc. > + * Copyright 2011 Linaro Ltd. > + * > + * The code contained herein is

Re: [PATCH 2/2] ARM: dts: TS-4900: add basic device tree

2016-07-29 Thread Fabio Estevam
Hi Lucile, This looks good. Only some minor nits: On Wed, Jul 27, 2016 at 2:53 PM, Lucile Quirion wrote: > @@ -0,0 +1,21 @@ > +/* > + * Copyright 2011 Freescale Semiconductor, Inc. > + * Copyright 2011 Linaro Ltd. > + * > + * The code contained herein is licensed under the GNU General Public >

Re: [PACTH v1 1/2] usb: xhci: plat: Enable runtime PM

2016-07-29 Thread Robert Foss
On 2016-07-28 08:24 PM, Felipe Balbi wrote: Hi, robert.f...@collabora.com writes: From: Andrew Bresticker Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Andrew Bresticker

Re: [PATCH] mm: move swap-in anonymous page into active list

2016-07-29 Thread Johannes Weiner
On Fri, Jul 29, 2016 at 12:25:40PM +0900, Minchan Kim wrote: > Every swap-in anonymous page starts from inactive lru list's head. > It should be activated unconditionally when VM decide to reclaim > because page table entry for the page always usually has marked > accessed bit. Thus, their window

Re: [PACTH v1 1/2] usb: xhci: plat: Enable runtime PM

2016-07-29 Thread Robert Foss
On 2016-07-28 08:24 PM, Felipe Balbi wrote: Hi, robert.f...@collabora.com writes: From: Andrew Bresticker Enable runtime PM for the xhci-plat device so that the parent device may implement runtime PM. Signed-off-by: Andrew Bresticker Tested-by: Robert Foss Signed-off-by: Robert Foss

Re: [PATCH] mm: move swap-in anonymous page into active list

2016-07-29 Thread Johannes Weiner
On Fri, Jul 29, 2016 at 12:25:40PM +0900, Minchan Kim wrote: > Every swap-in anonymous page starts from inactive lru list's head. > It should be activated unconditionally when VM decide to reclaim > because page table entry for the page always usually has marked > accessed bit. Thus, their window

Re: [PATCH] usb: lvstest: Remove deprecated create_singlethread_workqueue

2016-07-29 Thread Tejun Heo
On Thu, Jul 28, 2016 at 02:15:11PM +0530, Bhaktipriya Shridhar wrote: > The workqueue has a single work item(>rh_work) and hence > doesn't require ordering. Also, it is not being used on a memory > reclaim path. Hence, the singlethreaded workqueue has been replaced > with the use of system_wq. >

Re: [PATCH] usb: lvstest: Remove deprecated create_singlethread_workqueue

2016-07-29 Thread Tejun Heo
On Thu, Jul 28, 2016 at 02:15:11PM +0530, Bhaktipriya Shridhar wrote: > The workqueue has a single work item(>rh_work) and hence > doesn't require ordering. Also, it is not being used on a memory > reclaim path. Hence, the singlethreaded workqueue has been replaced > with the use of system_wq. >

Re: [PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue

2016-07-29 Thread Tejun Heo
On Thu, Jul 28, 2016 at 01:57:29PM +0530, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue replaces the deprecated > create_singlethread_workqueue. > > There are multiple work items on the work queue, which require > ordering. Hence, an ordered workqueue has been used. > > The workqueue

Re: [PATCH] usb: dwc2: Remove deprecated create_singlethread_workqueue

2016-07-29 Thread Tejun Heo
On Thu, Jul 28, 2016 at 01:57:29PM +0530, Bhaktipriya Shridhar wrote: > alloc_ordered_workqueue replaces the deprecated > create_singlethread_workqueue. > > There are multiple work items on the work queue, which require > ordering. Hence, an ordered workqueue has been used. > > The workqueue

Re: [PATCH] clk: bcm: Add driver for Northstar ILP clock

2016-07-29 Thread Mark Rutland
On Fri, Jul 29, 2016 at 02:58:32PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > This clock is present on cheaper Northstar devices like BCM53573 or > BCM47189 using Corex-A7. This driver uses PMU (Power Management Unit) > to calculate clock rate and allows using it in

Re: [PATCH] clk: bcm: Add driver for Northstar ILP clock

2016-07-29 Thread Mark Rutland
On Fri, Jul 29, 2016 at 02:58:32PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > This clock is present on cheaper Northstar devices like BCM53573 or > BCM47189 using Corex-A7. This driver uses PMU (Power Management Unit) > to calculate clock rate and allows using it in a generic (clk_*)

Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

2016-07-29 Thread Tejun Heo
Hello, Alan. On Wed, Jul 27, 2016 at 04:45:19PM -0400, Alan Stern wrote: > > Hmm... That doesn't really make them dependable during memory reclaim. > > True. But it does mean that they can't cause a deadlock by waiting > indefinitely for some other memory to be paged out to the very device >

Re: [RFC] usb: host: u132-hcd: Remove deprecated create_singlethread_workqueue

2016-07-29 Thread Tejun Heo
Hello, Alan. On Wed, Jul 27, 2016 at 04:45:19PM -0400, Alan Stern wrote: > > Hmm... That doesn't really make them dependable during memory reclaim. > > True. But it does mean that they can't cause a deadlock by waiting > indefinitely for some other memory to be paged out to the very device >

Re: Why do we need reset_control_get_optional() ?

2016-07-29 Thread Philipp Zabel
Hi Masahiro, Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada: [...] > However, I think the following makes more sense: > > > menuconfig RESET_CONTROLLER > bool "Reset Controller Support" > depends on (ARCH_HAS_RESET_CONTROLLER || COMPILE_TEST) >

Re: Why do we need reset_control_get_optional() ?

2016-07-29 Thread Philipp Zabel
Hi Masahiro, Am Donnerstag, den 28.07.2016, 19:29 +0900 schrieb Masahiro Yamada: [...] > However, I think the following makes more sense: > > > menuconfig RESET_CONTROLLER > bool "Reset Controller Support" > depends on (ARCH_HAS_RESET_CONTROLLER || COMPILE_TEST) >

Re: [PATCH] sched/core: add taint on "BUG: sleeping function called from invalid context"

2016-07-29 Thread Thomas Gleixner
On Fri, 29 Jul 2016, Rusty Russell wrote: > Vegard Nossum writes: > > Seeing this, it occurs to me that we should probably add a taint here: > > Taint has traditionally meant "the user did something unsupported, take > the bug report with a grain of salt". Such as

Re: [PATCH] sched/core: add taint on "BUG: sleeping function called from invalid context"

2016-07-29 Thread Thomas Gleixner
On Fri, 29 Jul 2016, Rusty Russell wrote: > Vegard Nossum writes: > > Seeing this, it occurs to me that we should probably add a taint here: > > Taint has traditionally meant "the user did something unsupported, take > the bug report with a grain of salt". Such as force removing a module. We

Re: [PATCH][v2] timekeeping: Fix memory overwrite of sleep_time_bin array

2016-07-29 Thread Thomas Gleixner
On Fri, 29 Jul 2016, Chen Yu wrote: > On Tue, Jul 19, 2016 at 12:40:14PM +0200, Thomas Gleixner wrote: > 1st is to bypass the sleep time if pm_trace is involved(a little complicated > because it needs to deal with historical pm_trace), or > > 2nd version is to introduce a sysfs interface to

Re: [PATCH][v2] timekeeping: Fix memory overwrite of sleep_time_bin array

2016-07-29 Thread Thomas Gleixner
On Fri, 29 Jul 2016, Chen Yu wrote: > On Tue, Jul 19, 2016 at 12:40:14PM +0200, Thomas Gleixner wrote: > 1st is to bypass the sleep time if pm_trace is involved(a little complicated > because it needs to deal with historical pm_trace), or > > 2nd version is to introduce a sysfs interface to

Re: [ANNOUNCE] git-series: track changes to a patch series over time

2016-07-29 Thread Josh Triplett
On Fri, Jul 29, 2016 at 01:44:44PM +0100, Richard Ipsum wrote: > On Fri, Jul 29, 2016 at 04:04:26AM -0700, Josh Triplett wrote: > > I hope to use git notes with git-series in the future, by putting > > another gitlink under the git-series for notes related to the series. > > I'd intended that for

Re: [ANNOUNCE] git-series: track changes to a patch series over time

2016-07-29 Thread Josh Triplett
On Fri, Jul 29, 2016 at 01:44:44PM +0100, Richard Ipsum wrote: > On Fri, Jul 29, 2016 at 04:04:26AM -0700, Josh Triplett wrote: > > I hope to use git notes with git-series in the future, by putting > > another gitlink under the git-series for notes related to the series. > > I'd intended that for

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-29 Thread Mel Gorman
On Fri, Jul 29, 2016 at 10:13:40AM +1000, Dave Chinner wrote: > On Thu, Jul 28, 2016 at 11:25:13AM +0100, Mel Gorman wrote: > > On Thu, Jul 28, 2016 at 03:49:47PM +1000, Dave Chinner wrote: > > > Seems you're all missing the obvious. > > > > > > Add a tracepoint for a shrinker callback that

Re: [PATCH 1/3] Add a new field to struct shrinker

2016-07-29 Thread Mel Gorman
On Fri, Jul 29, 2016 at 10:13:40AM +1000, Dave Chinner wrote: > On Thu, Jul 28, 2016 at 11:25:13AM +0100, Mel Gorman wrote: > > On Thu, Jul 28, 2016 at 03:49:47PM +1000, Dave Chinner wrote: > > > Seems you're all missing the obvious. > > > > > > Add a tracepoint for a shrinker callback that

[PATCH] clk: bcm: Add driver for Northstar ILP clock

2016-07-29 Thread Rafał Miłecki
From: Rafał Miłecki This clock is present on cheaper Northstar devices like BCM53573 or BCM47189 using Corex-A7. This driver uses PMU (Power Management Unit) to calculate clock rate and allows using it in a generic (clk_*) way. Signed-off-by: Rafał Miłecki

[PATCH] clk: bcm: Add driver for Northstar ILP clock

2016-07-29 Thread Rafał Miłecki
From: Rafał Miłecki This clock is present on cheaper Northstar devices like BCM53573 or BCM47189 using Corex-A7. This driver uses PMU (Power Management Unit) to calculate clock rate and allows using it in a generic (clk_*) way. Signed-off-by: Rafał Miłecki ---

mmotm git tree since-4.7 branch created (was: mmotm 2016-07-28-16-33 uploaded)

2016-07-29 Thread Michal Hocko
I have just created since-4.7 branch in mm git tree (http://git.kernel.org/?p=linux/kernel/git/mhocko/mm.git;a=summary). It is based on v4.7 tag in Linus tree and mmotm-2016-07-28-16-33 I have pulled cgroups, libnvdim and tip/mm trees because they seem to have changes which might be needed. I had

mmotm git tree since-4.7 branch created (was: mmotm 2016-07-28-16-33 uploaded)

2016-07-29 Thread Michal Hocko
I have just created since-4.7 branch in mm git tree (http://git.kernel.org/?p=linux/kernel/git/mhocko/mm.git;a=summary). It is based on v4.7 tag in Linus tree and mmotm-2016-07-28-16-33 I have pulled cgroups, libnvdim and tip/mm trees because they seem to have changes which might be needed. I had

Re: [PATCH 13/18] perf symbols: Protect dso cache tree using dso->lock

2016-07-29 Thread Bryton Lee
Sorry for disturb you! maybe my question isn't a good question, but I do want to know what situation made dwarf callchain unwind process concurrently, can you guys give a example to elaborate on that. thank you very much! On Mon, May 18, 2015 at 11:50 PM, Arnaldo Carvalho de Melo

Re: [PATCH 13/18] perf symbols: Protect dso cache tree using dso->lock

2016-07-29 Thread Bryton Lee
Sorry for disturb you! maybe my question isn't a good question, but I do want to know what situation made dwarf callchain unwind process concurrently, can you guys give a example to elaborate on that. thank you very much! On Mon, May 18, 2015 at 11:50 PM, Arnaldo Carvalho de Melo wrote: > From:

Re: [PATCH v2 4/4] ARM: OMAP2+: omap_device: fix crash on omap_device removal

2016-07-29 Thread Grygorii Strashko
On 07/29/2016 08:15 AM, Peter Ujfalusi wrote: On 07/28/16 20:50, Grygorii Strashko wrote: Below call chain causes system crash when OMAP device is removed by calling of_platform_depopulate()/device_del(): Should you swap 3 <-> 4 in the series? Currently patch 3 will introduce the crash you

Re: [PATCH v2 4/4] ARM: OMAP2+: omap_device: fix crash on omap_device removal

2016-07-29 Thread Grygorii Strashko
On 07/29/2016 08:15 AM, Peter Ujfalusi wrote: On 07/28/16 20:50, Grygorii Strashko wrote: Below call chain causes system crash when OMAP device is removed by calling of_platform_depopulate()/device_del(): Should you swap 3 <-> 4 in the series? Currently patch 3 will introduce the crash you

[PATCH 2/2] i2c: move locking operations to their own struct

2016-07-29 Thread Peter Rosin
This makes it trivial to constify them, so do that. Signed-off-by: Peter Rosin --- drivers/i2c/i2c-core.c | 13 - drivers/i2c/i2c-mux.c | 25 - include/linux/i2c.h| 25 ++--- 3 files changed, 42 insertions(+), 21

[PATCH 2/2] i2c: move locking operations to their own struct

2016-07-29 Thread Peter Rosin
This makes it trivial to constify them, so do that. Signed-off-by: Peter Rosin --- drivers/i2c/i2c-core.c | 13 - drivers/i2c/i2c-mux.c | 25 - include/linux/i2c.h| 25 ++--- 3 files changed, 42 insertions(+), 21 deletions(-) diff

Re: [PATCH] usb:serial: Add Fintek F81532/534 driver

2016-07-29 Thread One Thousand Gnomes
O > +static int f81534_set_normal_register(struct usb_device *dev, u16 reg, u8 > data) > +{ > + size_t count = F81534_USB_MAX_RETRY; > + int status; > + u8 *tmp; > + > + tmp = kmalloc(sizeof(u8), GFP_KERNEL); > + if (!tmp) > + return -ENOMEM; You end up doing huge

Re: [PATCH] usb:serial: Add Fintek F81532/534 driver

2016-07-29 Thread One Thousand Gnomes
O > +static int f81534_set_normal_register(struct usb_device *dev, u16 reg, u8 > data) > +{ > + size_t count = F81534_USB_MAX_RETRY; > + int status; > + u8 *tmp; > + > + tmp = kmalloc(sizeof(u8), GFP_KERNEL); > + if (!tmp) > + return -ENOMEM; You end up doing huge

Re: [ANNOUNCE] git-series: track changes to a patch series over time

2016-07-29 Thread Richard Ipsum
On Fri, Jul 29, 2016 at 04:04:26AM -0700, Josh Triplett wrote: [snip] > > These definitely seem like a family of related problems. I'd like to > use git-series as a format for storing iterations on things like GitHub > pull-requests or Gerrit patch versions (in the latter case, overcoming >

Re: [ANNOUNCE] git-series: track changes to a patch series over time

2016-07-29 Thread Richard Ipsum
On Fri, Jul 29, 2016 at 04:04:26AM -0700, Josh Triplett wrote: [snip] > > These definitely seem like a family of related problems. I'd like to > use git-series as a format for storing iterations on things like GitHub > pull-requests or Gerrit patch versions (in the latter case, overcoming >

Re: [RFC] net/mlx5_core/en_main: Remove deprecated create_workqueue

2016-07-29 Thread Tejun Heo
Hello, On Fri, Jul 29, 2016 at 01:30:05AM +0300, Saeed Mahameed wrote: > > Are the workitems being used on a memory reclaim path? > > do you mean they need to allocate memory ? It's a bit convoluted. A workqueue needs WQ_MEM_RECLAIM flag to be guaranteed forward progress under memory pressure,

Re: [RFC] net/mlx5_core/en_main: Remove deprecated create_workqueue

2016-07-29 Thread Tejun Heo
Hello, On Fri, Jul 29, 2016 at 01:30:05AM +0300, Saeed Mahameed wrote: > > Are the workitems being used on a memory reclaim path? > > do you mean they need to allocate memory ? It's a bit convoluted. A workqueue needs WQ_MEM_RECLAIM flag to be guaranteed forward progress under memory pressure,

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-29 Thread Tejun Heo
Hello, On Thu, Jul 28, 2016 at 12:37:35PM +0300, Leon Romanovsky wrote: > Did you test this patch? Did you notice the memory reclaim path nature > of this work? The conversion uses WQ_MEM_RECLAIM, which is standard for all workqueues which can stall packet processing if stalled. The requirement

[GIT PULL] fuse update for 4.8

2016-07-29 Thread Miklos Szeredi
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-linus This fixes error propagation from writeback to fsync/close for writeback cache mode as well as adding a missing capability flag to the INIT message. The rest are cleanups. (The commits are

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

2016-07-29 Thread Tejun Heo
Hello, On Thu, Jul 28, 2016 at 12:37:35PM +0300, Leon Romanovsky wrote: > Did you test this patch? Did you notice the memory reclaim path nature > of this work? The conversion uses WQ_MEM_RECLAIM, which is standard for all workqueues which can stall packet processing if stalled. The requirement

[GIT PULL] fuse update for 4.8

2016-07-29 Thread Miklos Szeredi
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/fuse.git for-linus This fixes error propagation from writeback to fsync/close for writeback cache mode as well as adding a missing capability flag to the INIT message. The rest are cleanups. (The commits are

Re: [PATCH] block: fix use-after-free in seq file

2016-07-29 Thread Tejun Heo
On Fri, Jul 29, 2016 at 10:40:31AM +0200, Vegard Nossum wrote: > I got a KASAN report of use-after-free: > > == > BUG: KASAN: use-after-free in klist_iter_exit+0x61/0x70 at addr > 8800b6581508 > Read of size 8 by

Re: [PATCH] block: fix use-after-free in seq file

2016-07-29 Thread Tejun Heo
On Fri, Jul 29, 2016 at 10:40:31AM +0200, Vegard Nossum wrote: > I got a KASAN report of use-after-free: > > == > BUG: KASAN: use-after-free in klist_iter_exit+0x61/0x70 at addr > 8800b6581508 > Read of size 8 by

[PATCH 1/1] x86/entry: spell EBX register correctly in documentation

2016-07-29 Thread Nicolas Iooss
As EBS does not mean anything reasonable in the context it is used, it seems like a misspelling for EBX. Signed-off-by: Nicolas Iooss --- arch/x86/entry/entry_64.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/entry/entry_64.S

[PATCH 1/1] x86/entry: spell EBX register correctly in documentation

2016-07-29 Thread Nicolas Iooss
As EBS does not mean anything reasonable in the context it is used, it seems like a misspelling for EBX. Signed-off-by: Nicolas Iooss --- arch/x86/entry/entry_64.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S index

Re: [PATCH] cxl: replace loop with for_each_child_of_node(), remove unneeded of_node_put()

2016-07-29 Thread Michael Ellerman
Andrew Donnellan writes: > Rewrite the cxl_guest_init_afu() loop in cxl_of_probe() to use > for_each_child_of_node() rather than a hand-coded for loop. > > Remove the useless of_node_put(afu_np) call after the loop, where it's > guaranteed that afu_np == NULL. > >

Re: [PATCH] cxl: replace loop with for_each_child_of_node(), remove unneeded of_node_put()

2016-07-29 Thread Michael Ellerman
Andrew Donnellan writes: > Rewrite the cxl_guest_init_afu() loop in cxl_of_probe() to use > for_each_child_of_node() rather than a hand-coded for loop. > > Remove the useless of_node_put(afu_np) call after the loop, where it's > guaranteed that afu_np == NULL. > > Reported-by: SF Markus Elfring

[PATCH 1/1] Bluetooth: add printf format attribute to hci_set_[fh]w_info()

2016-07-29 Thread Nicolas Iooss
Commit 5177a83827cd ("Bluetooth: Add debugfs fields for hardware and firmware info") introduced hci_set_hw_info() and hci_set_fw_info(). These functions use kvasprintf_const() but are not marked with a __printf attribute. Adding such an attribute helps detecting issues related to

[PATCH 1/1] Bluetooth: add printf format attribute to hci_set_[fh]w_info()

2016-07-29 Thread Nicolas Iooss
Commit 5177a83827cd ("Bluetooth: Add debugfs fields for hardware and firmware info") introduced hci_set_hw_info() and hci_set_fw_info(). These functions use kvasprintf_const() but are not marked with a __printf attribute. Adding such an attribute helps detecting issues related to

Re: [RFC PATCH 1/1] i2c: i2c-mux-pca954x: Add interrupt controller support.

2016-07-29 Thread Peter Rosin
On 2016-07-28 04:44, Phil Reid wrote: > G'day Peter, > > Thanks for the feedback. > +linux-kernel@vger.kernel.org > > On 27/07/2016 13:32, Peter Rosin wrote: >> On 2016-07-27 05:05, Phil Reid wrote: >>> +static void pca954x_irq_mask(struct irq_data *idata) >>> +{ >>> + struct i2c_mux_core

Re: [RFC PATCH 1/1] i2c: i2c-mux-pca954x: Add interrupt controller support.

2016-07-29 Thread Peter Rosin
On 2016-07-28 04:44, Phil Reid wrote: > G'day Peter, > > Thanks for the feedback. > +linux-kernel@vger.kernel.org > > On 27/07/2016 13:32, Peter Rosin wrote: >> On 2016-07-27 05:05, Phil Reid wrote: >>> +static void pca954x_irq_mask(struct irq_data *idata) >>> +{ >>> + struct i2c_mux_core

[GIT PULL] overlayfs update for 4.8

2016-07-29 Thread Miklos Szeredi
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-linus First of all, this fixes a regression in overlayfs introduced by the dentry hash salting. I've moved the patch fixing this to the front of the queue, so if (god forbid) something needs

[GIT PULL] overlayfs update for 4.8

2016-07-29 Thread Miklos Szeredi
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-linus First of all, this fixes a regression in overlayfs introduced by the dentry hash salting. I've moved the patch fixing this to the front of the queue, so if (god forbid) something needs

Re: [PATCH 2/4] x86/platform/UV: Fix problem with bad UV4 EFI System Table causing panic

2016-07-29 Thread Thomas Gleixner
On Wed, 27 Jul 2016, Mike Travis wrote: > Fix a problem that occurs if for some reason the UV4 EFI System Table > is not available, the check inadvertantly can cause a panic. > > Reviewed-by: Dimitri Sivanich > Reviewed-by: Nathan Zimmer > Tested-by: Frank

Re: [PATCH 2/4] x86/platform/UV: Fix problem with bad UV4 EFI System Table causing panic

2016-07-29 Thread Thomas Gleixner
On Wed, 27 Jul 2016, Mike Travis wrote: > Fix a problem that occurs if for some reason the UV4 EFI System Table > is not available, the check inadvertantly can cause a panic. > > Reviewed-by: Dimitri Sivanich > Reviewed-by: Nathan Zimmer > Tested-by: Frank Ramsay > Tested-by: John Estabrook

[PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer

2016-07-29 Thread Nicolas Iooss
handle_object_size_mismatch() used %pk to format a kernel pointer in pr_err(). This seems to be a misspelling for %pK. Fixes: c6d308534aef ("UBSAN: run-time undefined behavior sanity checker") Signed-off-by: Nicolas Iooss --- lib/ubsan.c | 2 +- 1 file changed, 1

[PATCH 1/1] UBSAN: use uppercase K to format a kernel pointer

2016-07-29 Thread Nicolas Iooss
handle_object_size_mismatch() used %pk to format a kernel pointer in pr_err(). This seems to be a misspelling for %pK. Fixes: c6d308534aef ("UBSAN: run-time undefined behavior sanity checker") Signed-off-by: Nicolas Iooss --- lib/ubsan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [ANNOUNCE] git-series: track changes to a patch series over time

2016-07-29 Thread Josh Triplett
On Fri, Jul 29, 2016 at 11:10:11AM +0100, Richard Ipsum wrote: > On Thu, Jul 28, 2016 at 11:40:55PM -0700, Josh Triplett wrote: > [snip] > > > > I'd welcome any feedback, whether on the interface and workflow, the > > internals and collaboration, ideas on presenting diffs of patch series, > > or

Re: [ANNOUNCE] git-series: track changes to a patch series over time

2016-07-29 Thread Josh Triplett
On Fri, Jul 29, 2016 at 11:10:11AM +0100, Richard Ipsum wrote: > On Thu, Jul 28, 2016 at 11:40:55PM -0700, Josh Triplett wrote: > [snip] > > > > I'd welcome any feedback, whether on the interface and workflow, the > > internals and collaboration, ideas on presenting diffs of patch series, > > or

Re: [PATCH] nbd: fix race in ioctl

2016-07-29 Thread Vegard Nossum
On 05/30/2016 02:58 PM, Markus Pargmann wrote: Hi, On Friday 27 May 2016 12:59:35 Vegard Nossum wrote: Quentin ran into this bug: WARNING: CPU: 64 PID: 10085 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x65/0x80 [...] It seems fairly obvious that device_create_file() is not being protected from

Re: [PATCH] nbd: fix race in ioctl

2016-07-29 Thread Vegard Nossum
On 05/30/2016 02:58 PM, Markus Pargmann wrote: Hi, On Friday 27 May 2016 12:59:35 Vegard Nossum wrote: Quentin ran into this bug: WARNING: CPU: 64 PID: 10085 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x65/0x80 [...] It seems fairly obvious that device_create_file() is not being protected from

Re: [PATCH 3/3] mdacon: replace MDA_ADDR macro by inline function

2016-07-29 Thread Jiri Slaby
On 07/25/2016, 06:04 PM, Joe Perches wrote: > On Mon, 2016-07-25 at 17:24 +0200, Jiri Slaby wrote: >> MDA_ADDR is one of those macros which could be an inline function. So >> convert MDA_ADDR to mda_addr. >> >> Signed-off-by: Jiri Slaby >> --- >> drivers/video/console/mdacon.c |

Re: [PATCH 3/3] mdacon: replace MDA_ADDR macro by inline function

2016-07-29 Thread Jiri Slaby
On 07/25/2016, 06:04 PM, Joe Perches wrote: > On Mon, 2016-07-25 at 17:24 +0200, Jiri Slaby wrote: >> MDA_ADDR is one of those macros which could be an inline function. So >> convert MDA_ADDR to mda_addr. >> >> Signed-off-by: Jiri Slaby >> --- >> drivers/video/console/mdacon.c | 19

Request for your partnership

2016-07-29 Thread Bun Sam
Good day, I work with one of the major banks in Cambodia as the director of auditor. I have a proposal for you, a very urgent and quick business that will be completed in 12 working days. I have just discovered documents relating to funds belonging to a deceased client of our bank, I went

Request for your partnership

2016-07-29 Thread Bun Sam
Good day, I work with one of the major banks in Cambodia as the director of auditor. I have a proposal for you, a very urgent and quick business that will be completed in 12 working days. I have just discovered documents relating to funds belonging to a deceased client of our bank, I went

Request for your partnership

2016-07-29 Thread Bun Sam
Good day, I work with one of the major banks in Cambodia as the director of auditor. I have a proposal for you, a very urgent and quick business that will be completed in 12 working days. I have just discovered documents relating to funds belonging to a deceased client of our bank, I went

Request for your partnership

2016-07-29 Thread Bun Sam
Good day, I work with one of the major banks in Cambodia as the director of auditor. I have a proposal for you, a very urgent and quick business that will be completed in 12 working days. I have just discovered documents relating to funds belonging to a deceased client of our bank, I went

Re: [PATCH 4/5] i2c: i801: do not report an error if FEATURE_HOST_NOTIFY is not set

2016-07-29 Thread Jean Delvare
On Thu, 28 Jul 2016 11:50:42 +0200, Benjamin Tissoires wrote: > we can skip one test when calling i801_enable_host_notify(). Given > that we call it all the time, it's better to consider the fact that > the adapter doesn't support Host Notify as not an error. > > Signed-off-by: Benjamin Tissoires

Re: [PATCH 4/5] i2c: i801: do not report an error if FEATURE_HOST_NOTIFY is not set

2016-07-29 Thread Jean Delvare
On Thu, 28 Jul 2016 11:50:42 +0200, Benjamin Tissoires wrote: > we can skip one test when calling i801_enable_host_notify(). Given > that we call it all the time, it's better to consider the fact that > the adapter doesn't support Host Notify as not an error. > > Signed-off-by: Benjamin Tissoires

Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1

2016-07-29 Thread Arnd Bergmann
On Friday, July 29, 2016 12:19:32 PM CEST Borislav Petkov wrote: > On Fri, Jul 29, 2016 at 12:08:51PM +0200, Arnd Bergmann wrote: > > Let me try to get to the bottom of this, maybe we can get the warning > > back in the future. It has found a number of actual bugs. The majority > > of

Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1

2016-07-29 Thread Arnd Bergmann
On Friday, July 29, 2016 12:19:32 PM CEST Borislav Petkov wrote: > On Fri, Jul 29, 2016 at 12:08:51PM +0200, Arnd Bergmann wrote: > > Let me try to get to the bottom of this, maybe we can get the warning > > back in the future. It has found a number of actual bugs. The majority > > of

Re: [PATCH] clocksource: arm_arch_timer: Support reading clock rate from a driver

2016-07-29 Thread Marc Zyngier
On 29/07/16 11:18, Mark Rutland wrote: > [adding Marc to Cc] > > On Fri, Jul 29, 2016 at 11:23:11AM +0200, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> On some devices using arch code for reading clock rate doesn't work. So >> far the only option was to specify

Re: [PATCH] clocksource: arm_arch_timer: Support reading clock rate from a driver

2016-07-29 Thread Marc Zyngier
On 29/07/16 11:18, Mark Rutland wrote: > [adding Marc to Cc] > > On Fri, Jul 29, 2016 at 11:23:11AM +0200, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> On some devices using arch code for reading clock rate doesn't work. So >> far the only option was to specify clock-frequency in a DT. This

Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1

2016-07-29 Thread Borislav Petkov
On Fri, Jul 29, 2016 at 12:08:51PM +0200, Arnd Bergmann wrote: > Let me try to get to the bottom of this, maybe we can get the warning > back in the future. It has found a number of actual bugs. The majority > of -Wmaybe-uninitialized warnings that I fixed in linux-next were > false positives

Re: [PATCH] Kbuild: Move -Wmaybe-uninitialized to W=1

2016-07-29 Thread Borislav Petkov
On Fri, Jul 29, 2016 at 12:08:51PM +0200, Arnd Bergmann wrote: > Let me try to get to the bottom of this, maybe we can get the warning > back in the future. It has found a number of actual bugs. The majority > of -Wmaybe-uninitialized warnings that I fixed in linux-next were > false positives

Re: [PATCH] clocksource: arm_arch_timer: Support reading clock rate from a driver

2016-07-29 Thread Mark Rutland
[adding Marc to Cc] On Fri, Jul 29, 2016 at 11:23:11AM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > On some devices using arch code for reading clock rate doesn't work. So > far the only option was to specify clock-frequency in a DT. This works > only if a clock

Re: [PATCH] clocksource: arm_arch_timer: Support reading clock rate from a driver

2016-07-29 Thread Mark Rutland
[adding Marc to Cc] On Fri, Jul 29, 2016 at 11:23:11AM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > On some devices using arch code for reading clock rate doesn't work. So > far the only option was to specify clock-frequency in a DT. This works > only if a clock frequency doesn't have

<    1   2   3   4   5   6   7   8   9   >