On Thu, Dec 01, 2016 at 08:38:15AM +0100, Vlastimil Babka wrote:
> >> By default config this should not be used on x86.
> > What do you mean by that statement?
>
> I mean that the 16 mbytes for generic CMA area is not a default on x86:
>
> config CMA_SIZE_MBYTES
> int "Size in Mega
On Thu, Dec 01, 2016 at 08:38:15AM +0100, Vlastimil Babka wrote:
> >> By default config this should not be used on x86.
> > What do you mean by that statement?
>
> I mean that the 16 mbytes for generic CMA area is not a default on x86:
>
> config CMA_SIZE_MBYTES
> int "Size in Mega
On 28/11/16 21:16, Zach Brown wrote:
> Add PCI ID for Intel byt sdio host controller sub-vended by NI.
>
> The controller has different behavior because of the board layout NI
> puts it on.
>
> Signed-off-by: Zach Brown
Acked-by: Adrian Hunter
>
On 28/11/16 21:16, Zach Brown wrote:
> Add PCI ID for Intel byt sdio host controller sub-vended by NI.
>
> The controller has different behavior because of the board layout NI
> puts it on.
>
> Signed-off-by: Zach Brown
Acked-by: Adrian Hunter
> ---
> drivers/mmc/host/sdhci-pci-core.c | 24
On 28/11/16 21:16, Zach Brown wrote:
> On NI 9037 boards the max SDIO frequency is limited by trace lengths
> and other layout choices. The max SDIO frequency is stored in an ACPI
> table.
>
> The driver reads the ACPI entry MXFQ during sdio_probe_slot and sets the
> f_max field of the host.
>
>
On 28/11/16 21:16, Zach Brown wrote:
> On NI 9037 boards the max SDIO frequency is limited by trace lengths
> and other layout choices. The max SDIO frequency is stored in an ACPI
> table.
>
> The driver reads the ACPI entry MXFQ during sdio_probe_slot and sets the
> f_max field of the host.
>
>
On Wed 30-11-16 12:04:31, Ross Zwisler wrote:
> On Tue, Nov 29, 2016 at 09:53:03AM +0100, Jan Kara wrote:
> > On Mon 28-11-16 12:15:04, Ross Zwisler wrote:
> > > On Thu, Nov 24, 2016 at 10:02:39AM +0100, Jan Kara wrote:
> > > > On Wed 23-11-16 11:44:17, Ross Zwisler wrote:
> > > > > With the
On Wed 30-11-16 12:04:31, Ross Zwisler wrote:
> On Tue, Nov 29, 2016 at 09:53:03AM +0100, Jan Kara wrote:
> > On Mon 28-11-16 12:15:04, Ross Zwisler wrote:
> > > On Thu, Nov 24, 2016 at 10:02:39AM +0100, Jan Kara wrote:
> > > > On Wed 23-11-16 11:44:17, Ross Zwisler wrote:
> > > > > With the
Hi, Rafael
> From: rjwyso...@gmail.com [mailto:rjwyso...@gmail.com] On Behalf Of Rafael J.
> Wysocki
> Subject: Re: [PATCH 02/11] ACPICA: Back port of "ACPICA: Dispatcher: Tune
> interpreter lock around
> AcpiEvInitializeRegion()"
>
> On Wed, Nov 30, 2016 at 8:20 AM, Lv Zheng
Hi, Rafael
> From: rjwyso...@gmail.com [mailto:rjwyso...@gmail.com] On Behalf Of Rafael J.
> Wysocki
> Subject: Re: [PATCH 02/11] ACPICA: Back port of "ACPICA: Dispatcher: Tune
> interpreter lock around
> AcpiEvInitializeRegion()"
>
> On Wed, Nov 30, 2016 at 8:20 AM, Lv Zheng wrote:
> >
From: MaJun
Add the two-level-route property in ITS node.
When this property string defined, two-level route(indirect) function
will be enabled in ITS driver, otherwise disable it.
Signed-off-by: MaJun
---
From: MaJun
Add a new flag to control indirect route function for ACPI mode.
To carry the user defined flags information, we used the reserved byte
in ITS MADT table
Signed-off-by: MaJun
---
drivers/irqchip/irq-gic-v3-its.c | 5 -
From: MaJun
Add the two-level-route property in ITS node.
When this property string defined, two-level route(indirect) function
will be enabled in ITS driver, otherwise disable it.
Signed-off-by: MaJun
---
Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.txt | 3 +++
1 file
From: MaJun
Add a new flag to control indirect route function for ACPI mode.
To carry the user defined flags information, we used the reserved byte
in ITS MADT table
Signed-off-by: MaJun
---
drivers/irqchip/irq-gic-v3-its.c | 5 -
include/acpi/actbl1.h| 3 ++-
2 files changed,
From: MaJun
For current ITS driver, two level table (indirect route) is enabled when the
memory used
for LPI route table over the limit(64KB * 2) size. But this function impact the
performance of LPI interrupt actually because need more time to look up the
table.
From: MaJun
For current ITS driver, two level table (indirect route) is enabled when the
memory used
for LPI route table over the limit(64KB * 2) size. But this function impact the
performance of LPI interrupt actually because need more time to look up the
table.
Although this function can
From: MaJun
Add a new flag for ITS node in DT mode so we can disable/enable the
indirect route function.
Signed-off-by: MaJun
---
drivers/irqchip/irq-gic-v3-its.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git
From: MaJun
Add a new flag for ITS node in DT mode so we can disable/enable the
indirect route function.
Signed-off-by: MaJun
---
drivers/irqchip/irq-gic-v3-its.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v3-its.c
sorry, ignore this one..
在 2016/12/1 15:41, Majun 写道:
> From: MaJun
>
> The return value 0 from acpi_register_gsi() means irq mapping failed.
> So, we should process this case in else branch.
>
> Signed-off-by: MaJun
> ---
> drivers/acpi/resource.c
Hi,
On 12/01/2016 03:35 PM, Baolin Wang wrote:
> On 1 December 2016 at 14:35, Lu Baolu wrote:
>> Hi,
>>
>> On 12/01/2016 02:04 PM, Baolin Wang wrote:
>>> Hi Baolu,
>>>
>>> On 1 December 2016 at 13:45, Lu Baolu wrote:
Hi,
On
sorry, ignore this one..
在 2016/12/1 15:41, Majun 写道:
> From: MaJun
>
> The return value 0 from acpi_register_gsi() means irq mapping failed.
> So, we should process this case in else branch.
>
> Signed-off-by: MaJun
> ---
> drivers/acpi/resource.c | 2 +-
> 1 file changed, 1 insertion(+),
Hi,
On 12/01/2016 03:35 PM, Baolin Wang wrote:
> On 1 December 2016 at 14:35, Lu Baolu wrote:
>> Hi,
>>
>> On 12/01/2016 02:04 PM, Baolin Wang wrote:
>>> Hi Baolu,
>>>
>>> On 1 December 2016 at 13:45, Lu Baolu wrote:
Hi,
On 11/30/2016 05:02 PM, Baolin Wang wrote:
> If the
On 12/01/2016 08:21 AM, Michal Hocko wrote:
Forgot to CC Joonsoo. The email thread starts more or less here
http://lkml.kernel.org/r/20161130092239.gd18...@dhcp22.suse.cz
On Thu 01-12-16 08:15:07, Michal Hocko wrote:
On Wed 30-11-16 20:19:03, Robin H. Johnson wrote:
[...]
> alloc_contig_range:
On 12/01/2016 08:21 AM, Michal Hocko wrote:
Forgot to CC Joonsoo. The email thread starts more or less here
http://lkml.kernel.org/r/20161130092239.gd18...@dhcp22.suse.cz
On Thu 01-12-16 08:15:07, Michal Hocko wrote:
On Wed 30-11-16 20:19:03, Robin H. Johnson wrote:
[...]
> alloc_contig_range:
From: MaJun
The return value 0 from acpi_register_gsi() means irq mapping failed.
So, we should process this case in else branch.
Signed-off-by: MaJun
---
drivers/acpi/resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
From: MaJun
The return value 0 from acpi_register_gsi() means irq mapping failed.
So, we should process this case in else branch.
Signed-off-by: MaJun
---
drivers/acpi/resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/resource.c
Jiada Wang wrote:
> since commit 57e6dae1087bbaa6b33d3dd8a8e90b63888939a3 the expected packetsize
> is always limited to
> nominal + 25%. It was discovered, that some devices
Which devices?
> have a much higher jitter in used packetsizes than 25%
How high? (Please note that the USB
Jiada Wang wrote:
> since commit 57e6dae1087bbaa6b33d3dd8a8e90b63888939a3 the expected packetsize
> is always limited to
> nominal + 25%. It was discovered, that some devices
Which devices?
> have a much higher jitter in used packetsizes than 25%
How high? (Please note that the USB
On Wed, Nov 30, 2016 at 09:02:49AM -0800, Davidlohr Bueso wrote:
> On Wed, 30 Nov 2016, Greg KH wrote:
> > What changed from v1? Please always include it below the --- line to
> > keep maintainer's semi-sane.
>
> If anything changed I would have -- this is only the From != SoB thing
> you were
On Wed, Nov 30, 2016 at 09:02:49AM -0800, Davidlohr Bueso wrote:
> On Wed, 30 Nov 2016, Greg KH wrote:
> > What changed from v1? Please always include it below the --- line to
> > keep maintainer's semi-sane.
>
> If anything changed I would have -- this is only the From != SoB thing
> you were
On 12/01/2016 07:21 AM, Robin H. Johnson wrote:
On Wed, Nov 30, 2016 at 10:24:59PM +0100, Vlastimil Babka wrote:
[add more CC's]
On 11/30/2016 09:19 PM, Robin H. Johnson wrote:
> Somewhere in the Radeon/DRM codebase, CMA page allocation has either
> regressed in the timeline of 4.5->4.9,
On 12/01/2016 07:21 AM, Robin H. Johnson wrote:
On Wed, Nov 30, 2016 at 10:24:59PM +0100, Vlastimil Babka wrote:
[add more CC's]
On 11/30/2016 09:19 PM, Robin H. Johnson wrote:
> Somewhere in the Radeon/DRM codebase, CMA page allocation has either
> regressed in the timeline of 4.5->4.9,
On 1 December 2016 at 14:35, Lu Baolu wrote:
> Hi,
>
> On 12/01/2016 02:04 PM, Baolin Wang wrote:
>> Hi Baolu,
>>
>> On 1 December 2016 at 13:45, Lu Baolu wrote:
>>> Hi,
>>>
>>> On 11/30/2016 05:02 PM, Baolin Wang wrote:
If the hardware
On 1 December 2016 at 14:35, Lu Baolu wrote:
> Hi,
>
> On 12/01/2016 02:04 PM, Baolin Wang wrote:
>> Hi Baolu,
>>
>> On 1 December 2016 at 13:45, Lu Baolu wrote:
>>> Hi,
>>>
>>> On 11/30/2016 05:02 PM, Baolin Wang wrote:
If the hardware never responds to the stop endpoint command, the
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188601. This patch
is based on "0001-dma-ioat-set-error-code-on-failures.patch". In this
patch, assign error code -ENOMEM to return variable err as long as the
call to dma_mapping_error() fails.
Signed-off-by: Pan Bian
---
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188601. This patch
is based on "0001-dma-ioat-set-error-code-on-failures.patch". In this
patch, assign error code -ENOMEM to return variable err as long as the
call to dma_mapping_error() fails.
Signed-off-by: Pan Bian
---
On Wed, Nov 30, 2016 at 11:10:41PM +0530, Amitesh Singh wrote:
> On Nov 30, 2016 02:26, "Greg KH" wrote:
> >
> > On Mon, Nov 28, 2016 at 05:55:29PM +0530, Amitesh Singh wrote:
> > > Signed-off-by: Amitesh Singh
> > > ---
> >
> > I can't take
On Wed, Nov 30, 2016 at 11:10:41PM +0530, Amitesh Singh wrote:
> On Nov 30, 2016 02:26, "Greg KH" wrote:
> >
> > On Mon, Nov 28, 2016 at 05:55:29PM +0530, Amitesh Singh wrote:
> > > Signed-off-by: Amitesh Singh
> > > ---
> >
> > I can't take patches without a changelog text :(
>
> did you mean
Hi Michal,
[auto build test ERROR on net/master]
url:
https://github.com/0day-ci/linux/commits/Michal-Kubecek/tipc-check-minimum-bearer-MTU/20161201-140555
config: i386-randconfig-s0-201648 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the
Hi Michal,
[auto build test ERROR on net/master]
url:
https://github.com/0day-ci/linux/commits/Michal-Kubecek/tipc-check-minimum-bearer-MTU/20161201-140555
config: i386-randconfig-s0-201648 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the
Forgot to CC Joonsoo. The email thread starts more or less here
http://lkml.kernel.org/r/20161130092239.gd18...@dhcp22.suse.cz
On Thu 01-12-16 08:15:07, Michal Hocko wrote:
> On Wed 30-11-16 20:19:03, Robin H. Johnson wrote:
> [...]
> > alloc_contig_range: [83f2a3, 83f2a4) PFNs busy
>
> Huh, do
Forgot to CC Joonsoo. The email thread starts more or less here
http://lkml.kernel.org/r/20161130092239.gd18...@dhcp22.suse.cz
On Thu 01-12-16 08:15:07, Michal Hocko wrote:
> On Wed 30-11-16 20:19:03, Robin H. Johnson wrote:
> [...]
> > alloc_contig_range: [83f2a3, 83f2a4) PFNs busy
>
> Huh, do
On Thu, 01 Dec 2016 03:29:23 +0100,
Dmitry Torokhov wrote:
>
> Hi Takashi,
>
> On Mon, Nov 28, 2016 at 02:56:36PM +0100, Takashi Iwai wrote:
> > Hi Dmitry,
> >
> > I've been testing a small machine with Intel Cherry Trail chipset, and
> > noticed that the kernel spews errors always like:
> >
>
On Thu, 01 Dec 2016 03:29:23 +0100,
Dmitry Torokhov wrote:
>
> Hi Takashi,
>
> On Mon, Nov 28, 2016 at 02:56:36PM +0100, Takashi Iwai wrote:
> > Hi Dmitry,
> >
> > I've been testing a small machine with Intel Cherry Trail chipset, and
> > noticed that the kernel spews errors always like:
> >
>
On Wed, Nov 30, 2016 at 11:59:49PM +, csmanjuvi...@gmail.com wrote:
> From: Manjunath Goudar
>
> The ohci_hcd_pxa27x_drv_probe function is not doing anything other
> than calling usb_hcd_pxa27x_probe function so ohci_hcd_pxa27x_drv_probe
> function is useless that is
On Wed, Nov 30, 2016 at 11:59:49PM +, csmanjuvi...@gmail.com wrote:
> From: Manjunath Goudar
>
> The ohci_hcd_pxa27x_drv_probe function is not doing anything other
> than calling usb_hcd_pxa27x_probe function so ohci_hcd_pxa27x_drv_probe
> function is useless that is why removed
On Wed, Nov 30, 2016 at 03:34:29PM -0800, Guenter Roeck wrote:
> On Wed, Nov 30, 2016 at 10:29:37AM +0100, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.8.12 release.
> > There are 37 patches in this series, all will be posted as a response
> > to this one.
On Wed, Nov 30, 2016 at 03:34:29PM -0800, Guenter Roeck wrote:
> On Wed, Nov 30, 2016 at 10:29:37AM +0100, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.8.12 release.
> > There are 37 patches in this series, all will be posted as a response
> > to this one.
On Wed 30-11-16 20:19:03, Robin H. Johnson wrote:
[...]
> alloc_contig_range: [83f2a3, 83f2a4) PFNs busy
Huh, do I get it right that the request was for a _single_ page? Why do
we need CMA for that?
--
Michal Hocko
SUSE Labs
On Wed 30-11-16 20:19:03, Robin H. Johnson wrote:
[...]
> alloc_contig_range: [83f2a3, 83f2a4) PFNs busy
Huh, do I get it right that the request was for a _single_ page? Why do
we need CMA for that?
--
Michal Hocko
SUSE Labs
On Wed, Nov 30, 2016 at 09:04:28AM -0700, Shuah Khan wrote:
> On 11/30/2016 02:29 AM, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.8.12 release.
> > There are 37 patches in this series, all will be posted as a response
> > to this one. If anyone has any
On Wed, Nov 30, 2016 at 09:04:28AM -0700, Shuah Khan wrote:
> On 11/30/2016 02:29 AM, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.8.12 release.
> > There are 37 patches in this series, all will be posted as a response
> > to this one. If anyone has any
On Wed, Nov 30, 2016 at 08:39:35AM -0800, Kevin Hilman wrote:
> kernelci.org bot writes:
>
> > stable-rc boot: 226 boots: 6 failed, 214 passed with 5 offline, 1 conflict
> > (v4.8.11-37-g70e9fe5f6b13)
> >
> > Full Boot Summary:
> >
On Wed, Nov 30, 2016 at 08:39:35AM -0800, Kevin Hilman wrote:
> kernelci.org bot writes:
>
> > stable-rc boot: 226 boots: 6 failed, 214 passed with 5 offline, 1 conflict
> > (v4.8.11-37-g70e9fe5f6b13)
> >
> > Full Boot Summary:
> >
On Wed, Nov 30, 2016 at 11:49:56AM -0500, Martin K. Petersen wrote:
> > "Greg" == Greg Kroah-Hartman writes:
>
> Greg,
>
> Greg> From: Andrey Grodzovsky
>
> Greg> commit 18f6084a989ba1b38702f9af37a2e4049a924be6 upstream.
>
> Please also
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188591. In function
ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the
value of return variable err is 0 (indicates no error). As a result, the
return value may be inconsistent with the execution status. This patch
fixes the
On Wed, Nov 30, 2016 at 11:49:56AM -0500, Martin K. Petersen wrote:
> > "Greg" == Greg Kroah-Hartman writes:
>
> Greg,
>
> Greg> From: Andrey Grodzovsky
>
> Greg> commit 18f6084a989ba1b38702f9af37a2e4049a924be6 upstream.
>
> Please also queue 7ff723ad0f87 ("scsi: mpt3sas: Unblock device
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188591. In function
ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the
value of return variable err is 0 (indicates no error). As a result, the
return value may be inconsistent with the execution status. This patch
fixes the
Hi Takashi
On 11/30/2016 05:51 PM, Takashi Iwai wrote:
On Wed, 30 Nov 2016 08:59:22 +0100,
Jiada Wang wrote:
From: Daniel Girnus
ALSA usually calls the prepare function twice before starting the playback:
1. On hw_params call from userland and
2. internally when
Hi Takashi
On 11/30/2016 05:51 PM, Takashi Iwai wrote:
On Wed, 30 Nov 2016 08:59:22 +0100,
Jiada Wang wrote:
From: Daniel Girnus
ALSA usually calls the prepare function twice before starting the playback:
1. On hw_params call from userland and
2. internally when starting the stream.
Some
Hello Takashi
On 11/30/2016 05:54 PM, Takashi Iwai wrote:
On Wed, 30 Nov 2016 08:59:21 +0100,
Jiada Wang wrote:
From: Andreas Pape
since commit 57e6dae1087bbaa6b33d3dd8a8e90b63888939a3 the expected packetsize
is always limited to
Please use a form with 12 chars SHA
Hello Takashi
On 11/30/2016 05:54 PM, Takashi Iwai wrote:
On Wed, 30 Nov 2016 08:59:21 +0100,
Jiada Wang wrote:
From: Andreas Pape
since commit 57e6dae1087bbaa6b33d3dd8a8e90b63888939a3 the expected packetsize
is always limited to
Please use a form with 12 chars SHA ID plus the commit
results are here ... the culprit is, again, commit 2d66cccd73 ("mm:
Prevent __alloc_pages_nodemask() RCU CPU stall warnings"), and reverting that
patch fixes the problem. Good that you dropped it already :-).
Guenter
---
# bad: [59ab0083490c8a871b51e893bae5806e55901d7e
results are here ... the culprit is, again, commit 2d66cccd73 ("mm:
Prevent __alloc_pages_nodemask() RCU CPU stall warnings"), and reverting that
patch fixes the problem. Good that you dropped it already :-).
Guenter
---
# bad: [59ab0083490c8a871b51e893bae5806e55901d7e
Piotr,
Thanks for sending the patch, I've made this change to my turbostat
branch for 4.10.
I did not apply your patch directly because for some reason it didn't
appear in patchwork for linux-pm,
only for lkml, which I do not review.
Also, your patch depended on your style update patch to use
Piotr,
Thanks for sending the patch, I've made this change to my turbostat
branch for 4.10.
I did not apply your patch directly because for some reason it didn't
appear in patchwork for linux-pm,
only for lkml, which I do not review.
Also, your patch depended on your style update patch to use
Hi all,
Changes since 20161130:
New tree: openrisc
The cifs tree lost its build failure.
The net-next tree gained conflicts against the net and arm-soc trees.
The block tree gained a build failure for which I applied a merge
fix patch.
The tip tree gained a conflict against the net-next tree
Hi all,
Changes since 20161130:
New tree: openrisc
The cifs tree lost its build failure.
The net-next tree gained conflicts against the net and arm-soc trees.
The block tree gained a build failure for which I applied a merge
fix patch.
The tip tree gained a conflict against the net-next tree
Hi,
On 12/01/2016 02:04 PM, Baolin Wang wrote:
> Hi Baolu,
>
> On 1 December 2016 at 13:45, Lu Baolu wrote:
>> Hi,
>>
>> On 11/30/2016 05:02 PM, Baolin Wang wrote:
>>> If the hardware never responds to the stop endpoint command, the
>>> URBs will never be completed, and
Hi,
On 12/01/2016 02:04 PM, Baolin Wang wrote:
> Hi Baolu,
>
> On 1 December 2016 at 13:45, Lu Baolu wrote:
>> Hi,
>>
>> On 11/30/2016 05:02 PM, Baolin Wang wrote:
>>> If the hardware never responds to the stop endpoint command, the
>>> URBs will never be completed, and we might hang the USB
On Thu, 2016-12-01 at 06:14 +, Rohit Thapliyal wrote:
> Hi,
>
Hi,
Do not top post on netdev, and do not use HTML format : it wont reach
netdev.
>
> Found at just one place in ping_v6_sendmsg, where np is checked for
> NULL.
>
> And I am not sure, if it is really required there also.
>
On Thu, 2016-12-01 at 06:14 +, Rohit Thapliyal wrote:
> Hi,
>
Hi,
Do not top post on netdev, and do not use HTML format : it wont reach
netdev.
>
> Found at just one place in ping_v6_sendmsg, where np is checked for
> NULL.
>
> And I am not sure, if it is really required there also.
>
Commit fixed to handle the ifdef CONFIG_CIFS_SMB2 disabled problem you
noted, and repushed to my for-next branch. Thx for pointing this out.
On Tue, Nov 29, 2016 at 4:27 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build
Commit fixed to handle the ifdef CONFIG_CIFS_SMB2 disabled problem you
noted, and repushed to my for-next branch. Thx for pointing this out.
On Tue, Nov 29, 2016 at 4:27 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the cifs tree, today's linux-next build (powerpc
> ppc64_defconfig)
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
wm831x_clkout_is_prepared() returns "true" when it fails to read
CLOCK_CONTROL_1. "true" means the device is already prepared. So
return "true" on the read failure seems improper.
Signed-off-by: Pan Bian
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188561. Function
wm831x_clkout_is_prepared() returns "true" when it fails to read
CLOCK_CONTROL_1. "true" means the device is already prepared. So
return "true" on the read failure seems improper.
Signed-off-by: Pan Bian
---
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188551. A negative
return value means there are errors, while 0 indicates success. However,
in function bpa10x_send_frame(), it returns 0 no matter whether
usb_submit_urb() returns a negative value. As a result, the caller of
bpa10x_send_frame()
Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188551. A negative
return value means there are errors, while 0 indicates success. However,
in function bpa10x_send_frame(), it returns 0 no matter whether
usb_submit_urb() returns a negative value. As a result, the caller of
bpa10x_send_frame()
On Wed, Nov 30, 2016 at 10:24:59PM +0100, Vlastimil Babka wrote:
> [add more CC's]
>
> On 11/30/2016 09:19 PM, Robin H. Johnson wrote:
> > Somewhere in the Radeon/DRM codebase, CMA page allocation has either
> > regressed in the timeline of 4.5->4.9, and/or the drm/radeon code is
> > doing
On Wed, Nov 30, 2016 at 10:24:59PM +0100, Vlastimil Babka wrote:
> [add more CC's]
>
> On 11/30/2016 09:19 PM, Robin H. Johnson wrote:
> > Somewhere in the Radeon/DRM codebase, CMA page allocation has either
> > regressed in the timeline of 4.5->4.9, and/or the drm/radeon code is
> > doing
When a read transaction completes, one of several things will happen:
either a new transfer is started by the driver, a new transfer request
is raised by the Cuda (i.e. TREQ asserted), or both happen at once.
When both happen at once, there is a race condition between the TREQ test
in the
When reading_reply is set, reply_ptr points into an adb_request struct.
Hence, when reply_ptr instead points into the global cuda_rbuf,
it must be the case that reading_reply is not set.
Unfortunately, this rule can be violated because re-initialization
of reply_ptr and reading_reply presently
When a read transaction completes, one of several things will happen:
either a new transfer is started by the driver, a new transfer request
is raised by the Cuda (i.e. TREQ asserted), or both happen at once.
When both happen at once, there is a race condition between the TREQ test
in the
When reading_reply is set, reply_ptr points into an adb_request struct.
Hence, when reply_ptr instead points into the global cuda_rbuf,
it must be the case that reading_reply is not set.
Unfortunately, this rule can be violated because re-initialization
of reply_ptr and reading_reply presently
The Egret system controller was the predecessor to the Cuda and the
differences are minor.
On Cuda, byte acknowledgement requires one transition of the TACK
signal; on Egret two are needed. On Cuda, TIP is active low; on Egret
it is active high. And Cuda raises certain interrupts that Egret
Applied.
thanks!
Len Brown, Intel Open Source Technology Center
Add missing log message severity, remove old debug messages and
replace printk() loop with print_hex_dump() call.
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-cuda.c | 26 ++
1 file changed, 6
Initialize data_index where appropriate to improve readability and
assist debugging. This change doesn't affect driver behaviour.
I prefer to see
current_req->data[data_index++]
in place of
current_req->data[0]
or
current_req->data[1]
inasmuchas it becomes obvious what the
The Egret system controller was the predecessor to the Cuda and the
differences are minor.
On Cuda, byte acknowledgement requires one transition of the TACK
signal; on Egret two are needed. On Cuda, TIP is active low; on Egret
it is active high. And Cuda raises certain interrupts that Egret
Applied.
thanks!
Len Brown, Intel Open Source Technology Center
Add missing log message severity, remove old debug messages and
replace printk() loop with print_hex_dump() call.
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-cuda.c | 26 ++
1 file changed, 6 insertions(+), 20 deletions(-)
diff --git
Initialize data_index where appropriate to improve readability and
assist debugging. This change doesn't affect driver behaviour.
I prefer to see
current_req->data[data_index++]
in place of
current_req->data[0]
or
current_req->data[1]
inasmuchas it becomes obvious what the
The cuda_start() function uses spinlock_irq_save/restore for mutual
exclusion. Let's have cuda_poll() do the same when polling the VIA
interrupt.
The benefit to disabling local irqs when the interrupt is being polled
is that the interrupt handler now has the same timing properties
regardless of
There is no possibility that current_req can change during execution of
cuda_start(). This can be confirmed by inspection: cuda_lock is always
held whenever cuda_start() is called or current_req is modified.
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
This patch series has some improvements for the the Cuda driver: cleanup,
bug fixes and new functionality.
The broken via-maciisi driver is then replaced by via-cuda. This
eliminates over 600 LoC.
Thanks to Stan Johnson for testing these patches on a Mac LC III and
a PowerMac G3.
Finn Thain
The cuda_start() function uses spinlock_irq_save/restore for mutual
exclusion. Let's have cuda_poll() do the same when polling the VIA
interrupt.
The benefit to disabling local irqs when the interrupt is being polled
is that the interrupt handler now has the same timing properties
regardless of
There is no possibility that current_req can change during execution of
cuda_start(). This can be confirmed by inspection: cuda_lock is always
held whenever cuda_start() is called or current_req is modified.
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-cuda.c | 8
This patch series has some improvements for the the Cuda driver: cleanup,
bug fixes and new functionality.
The broken via-maciisi driver is then replaced by via-cuda. This
eliminates over 600 LoC.
Thanks to Stan Johnson for testing these patches on a Mac LC III and
a PowerMac G3.
Finn Thain
If the Cuda driver does not enter the 'read_done' state for some
reason, it may continue in the 'reading' state until the buffer
overflows. Add a bounds check to prevent this.
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
If the Cuda driver does not enter the 'read_done' state for some
reason, it may continue in the 'reading' state until the buffer
overflows. Add a bounds check to prevent this.
Tested-by: Stan Johnson
Signed-off-by: Finn Thain
---
drivers/macintosh/via-cuda.c | 8 +++-
1 file changed, 7
1 - 100 of 1760 matches
Mail list logo