Re: [PATCH v8 1/3] perf annotate: Show raw form for jump instruction with indirect target

2016-12-05 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 05, 2016 at 05:21:42PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Dec 05, 2016 at 09:26:45PM +0530, Ravi Bangoria escreveu: > > For jump instructions that does not include target address as direct > > operand, show the original disassembled line for them. This is needed > >

Re: [PATCH v8 1/3] perf annotate: Show raw form for jump instruction with indirect target

2016-12-05 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 05, 2016 at 05:21:42PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Mon, Dec 05, 2016 at 09:26:45PM +0530, Ravi Bangoria escreveu: > > For jump instructions that does not include target address as direct > > operand, show the original disassembled line for them. This is needed > >

[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-05 Thread Nicolai Stange
Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, amdgpu_debugfs_add_files() accesses ->control->debugfs_root though. This results in a NULL pointer dereference. Fix this by omitting the

[PATCH] drm/amdgpu: don't add files at control minor debugfs directory

2016-12-05 Thread Nicolai Stange
Since commit 8a357d10043c ("drm: Nerf DRM_CONTROL nodes"), a struct drm_device's ->control member is always NULL. In the case of CONFIG_DEBUG_FS=y, amdgpu_debugfs_add_files() accesses ->control->debugfs_root though. This results in a NULL pointer dereference. Fix this by omitting the

Re: [PATCH] objtool: fix bytes check of lea's rex_prefix

2016-12-05 Thread Josh Poimboeuf
On Mon, Dec 05, 2016 at 11:55:51AM +0100, Jiri Slaby wrote: > For the "lea %(rsp), %rbp" case, we check if there is a rex_prefix. But > we check "bytes" which is insn_byte_t[4] in rex_prefix (insn_field > structure). Therefore, the check is always true. > > Instead, check nbytes which is the

Re: [PATCH] objtool: fix bytes check of lea's rex_prefix

2016-12-05 Thread Josh Poimboeuf
On Mon, Dec 05, 2016 at 11:55:51AM +0100, Jiri Slaby wrote: > For the "lea %(rsp), %rbp" case, we check if there is a rex_prefix. But > we check "bytes" which is insn_byte_t[4] in rex_prefix (insn_field > structure). Therefore, the check is always true. > > Instead, check nbytes which is the

Re: [PATCH v8 1/3] perf annotate: Show raw form for jump instruction with indirect target

2016-12-05 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 05, 2016 at 09:26:45PM +0530, Ravi Bangoria escreveu: > For jump instructions that does not include target address as direct > operand, show the original disassembled line for them. This is needed > for certain powerpc jump instructions that use target address in a > register (such as

Re: [PATCH v8 1/3] perf annotate: Show raw form for jump instruction with indirect target

2016-12-05 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 05, 2016 at 09:26:45PM +0530, Ravi Bangoria escreveu: > For jump instructions that does not include target address as direct > operand, show the original disassembled line for them. This is needed > for certain powerpc jump instructions that use target address in a > register (such as

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Christoph Hellwig
On Mon, Dec 05, 2016 at 12:46:14PM -0700, Jason Gunthorpe wrote: > In any event the allocator still needs to track which regions are in > use and be able to hook 'free' from userspace. That does suggest it > should be integrated into the nvme driver and not a bolt on driver.. Two totally

[PATCH v4 00/13] net: ethernet: ti: cpts: update and fixes

2016-12-05 Thread Grygorii Strashko
It is preparation series intended to clean up and optimize TI CPTS driver to facilitate further integration with other TI's SoCs like Keystone 2. Changes in v4: - fixed build error in patch "net: ethernet: ti: cpts: clean up event list if event pool is empty" - rebased on top of net-next

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Christoph Hellwig
On Mon, Dec 05, 2016 at 12:46:14PM -0700, Jason Gunthorpe wrote: > In any event the allocator still needs to track which regions are in > use and be able to hook 'free' from userspace. That does suggest it > should be integrated into the nvme driver and not a bolt on driver.. Two totally

[PATCH v4 00/13] net: ethernet: ti: cpts: update and fixes

2016-12-05 Thread Grygorii Strashko
It is preparation series intended to clean up and optimize TI CPTS driver to facilitate further integration with other TI's SoCs like Keystone 2. Changes in v4: - fixed build error in patch "net: ethernet: ti: cpts: clean up event list if event pool is empty" - rebased on top of net-next

[PATCH v4 13/13] net: ethernet: ti: cpts: fix overflow check period

2016-12-05 Thread Grygorii Strashko
The CPTS drivers uses 8sec period for overflow checking with assumption that CPTS retclk will not exceed 500MHz. But that's not true on some TI platforms (Kesytone 2). As result, it is possible that CPTS counter will overflow more than once between two readings. Hence, fix it by selecting

Re: bio linked list corruption.

2016-12-05 Thread Vegard Nossum
On 5 December 2016 at 20:11, Vegard Nossum wrote: > On 5 December 2016 at 18:55, Linus Torvalds > wrote: >> On Mon, Dec 5, 2016 at 9:09 AM, Vegard Nossum >> wrote: >> Since you apparently can recreate this fairly

[PATCH v4 13/13] net: ethernet: ti: cpts: fix overflow check period

2016-12-05 Thread Grygorii Strashko
The CPTS drivers uses 8sec period for overflow checking with assumption that CPTS retclk will not exceed 500MHz. But that's not true on some TI platforms (Kesytone 2). As result, it is possible that CPTS counter will overflow more than once between two readings. Hence, fix it by selecting

Re: bio linked list corruption.

2016-12-05 Thread Vegard Nossum
On 5 December 2016 at 20:11, Vegard Nossum wrote: > On 5 December 2016 at 18:55, Linus Torvalds > wrote: >> On Mon, Dec 5, 2016 at 9:09 AM, Vegard Nossum >> wrote: >> Since you apparently can recreate this fairly easily, how about trying >> this stupid patch? >> >> NOTE! This is entirely

Re: [mm PATCH 0/3] Page fragment updates

2016-12-05 Thread Andrew Morton
On Mon, 5 Dec 2016 09:01:12 -0800 Alexander Duyck wrote: > On Tue, Nov 29, 2016 at 10:23 AM, Alexander Duyck > wrote: > > This patch series takes care of a few cleanups for the page fragments API. > > > > ... > > It's been about a week

Re: [mm PATCH 0/3] Page fragment updates

2016-12-05 Thread Andrew Morton
On Mon, 5 Dec 2016 09:01:12 -0800 Alexander Duyck wrote: > On Tue, Nov 29, 2016 at 10:23 AM, Alexander Duyck > wrote: > > This patch series takes care of a few cleanups for the page fragments API. > > > > ... > > It's been about a week since I submitted this series. Just wanted to > check in

Re: [PATCH V3 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-12-05 Thread kbuild test robot
Hi Salil, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Salil-Mehta/net-hns-Fix-to-conditionally-convey-RX-checksum-flag-to-stack/20161206-022948 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

Re: [PATCH V3 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack

2016-12-05 Thread kbuild test robot
Hi Salil, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Salil-Mehta/net-hns-Fix-to-conditionally-convey-RX-checksum-flag-to-stack/20161206-022948 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

[PATCH v4 02/13] net: ethernet: ti: allow cpts to be built separately

2016-12-05 Thread Grygorii Strashko
TI CPTS IP is used as part of TI OMAP CPSW driver, but it's also present as part of NETCP on TI Keystone 2 SoCs. So, It's required to enable build of CPTS for both this drivers and this can be achieved by allowing CPTS to be built separately. Hence, allow cpts to be built separately and convert

[PATCH v4 05/13] net: ethernet: ti: cpts: fix registration order

2016-12-05 Thread Grygorii Strashko
The ptp clock registered before spinlock, which is protecting it, and before timecounter and cyclecounter initialization in cpts_register(). So, ensure that ptp clock is registered the last, after everything else is done. Signed-off-by: Grygorii Strashko Acked-by:

[PATCH v4 10/13] net: ethernet: ti: cpts: move dt props parsing to cpts driver

2016-12-05 Thread Grygorii Strashko
Move DT properties parsing into CPTS driver to simplify CPSW code and CPTS driver porting on other SoC in the future (like Keystone 2) - with this change it will not be required to add the same DT parsing code in Keystone 2 NETCP driver. Signed-off-by: Grygorii Strashko

[PATCH v4 02/13] net: ethernet: ti: allow cpts to be built separately

2016-12-05 Thread Grygorii Strashko
TI CPTS IP is used as part of TI OMAP CPSW driver, but it's also present as part of NETCP on TI Keystone 2 SoCs. So, It's required to enable build of CPTS for both this drivers and this can be achieved by allowing CPTS to be built separately. Hence, allow cpts to be built separately and convert

[PATCH v4 05/13] net: ethernet: ti: cpts: fix registration order

2016-12-05 Thread Grygorii Strashko
The ptp clock registered before spinlock, which is protecting it, and before timecounter and cyclecounter initialization in cpts_register(). So, ensure that ptp clock is registered the last, after everything else is done. Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran ---

[PATCH v4 10/13] net: ethernet: ti: cpts: move dt props parsing to cpts driver

2016-12-05 Thread Grygorii Strashko
Move DT properties parsing into CPTS driver to simplify CPSW code and CPTS driver porting on other SoC in the future (like Keystone 2) - with this change it will not be required to add the same DT parsing code in Keystone 2 NETCP driver. Signed-off-by: Grygorii Strashko ---

[PATCH v4 06/13] net: ethernet: ti: cpts: disable cpts when unregistered

2016-12-05 Thread Grygorii Strashko
The cpts now is left enabled after unregistration. Hence, disable it in cpts_unregister(). Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- drivers/net/ethernet/ti/cpts.c | 4 1 file changed, 4 insertions(+) diff --git

Re: bio linked list corruption.

2016-12-05 Thread Linus Torvalds
On Mon, Dec 5, 2016 at 11:11 AM, Vegard Nossum wrote: > > [ cut here ] > WARNING: CPU: 22 PID: 14012 at mm/shmem.c:2668 shmem_fallocate+0x9a7/0xac0 Ok, good. So that's confirmed as the cause of this problem. And the call chain that I wanted is

[PATCH v4 03/13] net: ethernet: ti: cpsw: minimize direct access to struct cpts

2016-12-05 Thread Grygorii Strashko
This will provide more flexibility in changing CPTS internals and also required for further changes. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 28 +++- drivers/net/ethernet/ti/cpts.h | 39

[PATCH v4 11/13] clocksource: export the clocks_calc_mult_shift to use by timestamp code

2016-12-05 Thread Grygorii Strashko
From: Murali Karicheri The CPSW CPTS driver is capable of doing timestamping on tx/rx packets and requires to know mult and shift factors for timestamp conversion from raw value to nanoseconds (ptp clock). Now these mult and shift factors are calculated manually and provided

[PATCH v4 06/13] net: ethernet: ti: cpts: disable cpts when unregistered

2016-12-05 Thread Grygorii Strashko
The cpts now is left enabled after unregistration. Hence, disable it in cpts_unregister(). Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- drivers/net/ethernet/ti/cpts.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/ti/cpts.c

Re: bio linked list corruption.

2016-12-05 Thread Linus Torvalds
On Mon, Dec 5, 2016 at 11:11 AM, Vegard Nossum wrote: > > [ cut here ] > WARNING: CPU: 22 PID: 14012 at mm/shmem.c:2668 shmem_fallocate+0x9a7/0xac0 Ok, good. So that's confirmed as the cause of this problem. And the call chain that I wanted is obviously completely

[PATCH v4 03/13] net: ethernet: ti: cpsw: minimize direct access to struct cpts

2016-12-05 Thread Grygorii Strashko
This will provide more flexibility in changing CPTS internals and also required for further changes. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/cpsw.c | 28 +++- drivers/net/ethernet/ti/cpts.h | 39 +++ 2 files

[PATCH v4 11/13] clocksource: export the clocks_calc_mult_shift to use by timestamp code

2016-12-05 Thread Grygorii Strashko
From: Murali Karicheri The CPSW CPTS driver is capable of doing timestamping on tx/rx packets and requires to know mult and shift factors for timestamp conversion from raw value to nanoseconds (ptp clock). Now these mult and shift factors are calculated manually and provided through DT, which

[PATCH v4 12/13] net: ethernet: ti: cpts: calc mult and shift from refclk freq

2016-12-05 Thread Grygorii Strashko
The cyclecounter mult and shift values can be calculated based on the CPTS rfclk frequency and timekeepnig framework provides required algos and API's. Hence, calc mult and shift basing on CPTS rfclk frequency if both cpts_clock_shift and cpts_clock_mult properties are not provided in DT (the

[PATCH v4 01/13] net: ethernet: ti: cpts: switch to readl/writel_relaxed()

2016-12-05 Thread Grygorii Strashko
Switch to readl/writel_relaxed() APIs, because this is recommended API and the CPTS IP is reused on Keystone 2 SoCs where LE/BE modes are supported. Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- drivers/net/ethernet/ti/cpts.c

[PATCH v4 12/13] net: ethernet: ti: cpts: calc mult and shift from refclk freq

2016-12-05 Thread Grygorii Strashko
The cyclecounter mult and shift values can be calculated based on the CPTS rfclk frequency and timekeepnig framework provides required algos and API's. Hence, calc mult and shift basing on CPTS rfclk frequency if both cpts_clock_shift and cpts_clock_mult properties are not provided in DT (the

[PATCH v4 01/13] net: ethernet: ti: cpts: switch to readl/writel_relaxed()

2016-12-05 Thread Grygorii Strashko
Switch to readl/writel_relaxed() APIs, because this is recommended API and the CPTS IP is reused on Keystone 2 SoCs where LE/BE modes are supported. Signed-off-by: Grygorii Strashko Acked-by: Richard Cochran --- drivers/net/ethernet/ti/cpts.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v4 09/13] net: ethernet: ti: cpts: rework initialization/deinitialization

2016-12-05 Thread Grygorii Strashko
The current implementation CPTS initialization and deinitialization (represented by cpts_register/unregister()) does too many static initialization from .ndo_open(), which is reasonable to do once at probe time instead, and also require caller to allocate memory for struct cpts, which is internal

[PATCH v4 09/13] net: ethernet: ti: cpts: rework initialization/deinitialization

2016-12-05 Thread Grygorii Strashko
The current implementation CPTS initialization and deinitialization (represented by cpts_register/unregister()) does too many static initialization from .ndo_open(), which is reasonable to do once at probe time instead, and also require caller to allocate memory for struct cpts, which is internal

[PATCH v4 07/13] net: ethernet: ti: cpts: clean up event list if event pool is empty

2016-12-05 Thread Grygorii Strashko
From: WingMan Kwok When a CPTS user does not exit gracefully by disabling cpts timestamping and leaving a joined multicast group, the system continues to receive and timestamps the ptp packets which eventually occupy all the event list entries. When this happns, the added code

[PATCH v4 04/13] net: ethernet: ti: cpts: fix unbalanced clk api usage in cpts_register/unregister

2016-12-05 Thread Grygorii Strashko
There are two issues with TI CPTS code which are reproducible when TI CPSW ethX device passes few up/down iterations: - cpts refclk prepare counter continuously incremented after each up/down iteration; - devm_clk_get(dev, "cpts") is called many times. Hence, fix these issues by using

[PATCH v4 07/13] net: ethernet: ti: cpts: clean up event list if event pool is empty

2016-12-05 Thread Grygorii Strashko
From: WingMan Kwok When a CPTS user does not exit gracefully by disabling cpts timestamping and leaving a joined multicast group, the system continues to receive and timestamps the ptp packets which eventually occupy all the event list entries. When this happns, the added code tries to remove

[PATCH v4 04/13] net: ethernet: ti: cpts: fix unbalanced clk api usage in cpts_register/unregister

2016-12-05 Thread Grygorii Strashko
There are two issues with TI CPTS code which are reproducible when TI CPSW ethX device passes few up/down iterations: - cpts refclk prepare counter continuously incremented after each up/down iteration; - devm_clk_get(dev, "cpts") is called many times. Hence, fix these issues by using

[PATCH v4 08/13] net: ethernet: ti: cpts: drop excessive writes to CTRL and INT_EN regs

2016-12-05 Thread Grygorii Strashko
CPTS module and IRQs are always enabled when CPTS is registered, before starting overflow check work, and disabled during deregistration, when overflow check work has been canceled already. So, It doesn't require to (re)enable CPTS module and IRQs in cpts_overflow_check(). Signed-off-by: Grygorii

[PATCH v4 08/13] net: ethernet: ti: cpts: drop excessive writes to CTRL and INT_EN regs

2016-12-05 Thread Grygorii Strashko
CPTS module and IRQs are always enabled when CPTS is registered, before starting overflow check work, and disabled during deregistration, when overflow check work has been canceled already. So, It doesn't require to (re)enable CPTS module and IRQs in cpts_overflow_check(). Signed-off-by: Grygorii

Re: [PATCH 1/1 v2] isdn: hisax: set error code on failure

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 18:43:31 +0800 > From: Pan Bian > > In function hfc4s8s_probe(), the value of return variable err should be > negative on failures. However, when the call to request_region() returns > NULL, the value of err is

Re: [PATCH 1/1 v2] isdn: hisax: set error code on failure

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 18:43:31 +0800 > From: Pan Bian > > In function hfc4s8s_probe(), the value of return variable err should be > negative on failures. However, when the call to request_region() returns > NULL, the value of err is 0. This patch fixes the bug, assigning >

Re: [PATCH 5/7] perf tools: Force fixdep compilation at the start of the build

2016-12-05 Thread Arnaldo Carvalho de Melo
Em Sun, Dec 04, 2016 at 09:42:56PM +0100, Jiri Olsa escreveu: > The fixdep tool needs to be built before everything else, > because it fixes every object dependency file. > > We handle this currently by making all objects to depend > on fixdep, which is error prone and is easily forgotten > when

Re: [PATCH 5/7] perf tools: Force fixdep compilation at the start of the build

2016-12-05 Thread Arnaldo Carvalho de Melo
Em Sun, Dec 04, 2016 at 09:42:56PM +0100, Jiri Olsa escreveu: > The fixdep tool needs to be built before everything else, > because it fixes every object dependency file. > > We handle this currently by making all objects to depend > on fixdep, which is error prone and is easily forgotten > when

Re: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-05 Thread Shuah Khan
Hi Andrey, On 12/05/2016 12:56 PM, Shuah Khan wrote: > vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs > attributes triggering the lock-class key not persistent warning. Call > sysfs_attr_init() for dynamically allocated sysfs attributes to fix it. > > vhci_hcd vhci_hcd:

Re: [PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-05 Thread Shuah Khan
Hi Andrey, On 12/05/2016 12:56 PM, Shuah Khan wrote: > vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs > attributes triggering the lock-class key not persistent warning. Call > sysfs_attr_init() for dynamically allocated sysfs attributes to fix it. > > vhci_hcd vhci_hcd:

Re: [PATCH 1/1] net: ethernet: broadcom: fix improper return value

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 14:29:29 +0800 > From: Pan Bian > > Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate > memory, and jumps to label "lbl" if the allocation fails. Label "lbl" > first cleans memory and then

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Logan Gunthorpe
On 05/12/16 12:46 PM, Jason Gunthorpe wrote: NVMe might have to deal with pci-e hot-unplug, which is a similar problem-class to the GPU case.. Sure, but if the NVMe device gets hot-unplugged it means that all the CMB mappings are useless and need to be torn down. This probably means

Re: [PATCH 1/1] net: ethernet: broadcom: fix improper return value

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 14:29:29 +0800 > From: Pan Bian > > Marco BNX2X_ALLOC_AND_SET(arr, lbl, func) calls kmalloc() to allocate > memory, and jumps to label "lbl" if the allocation fails. Label "lbl" > first cleans memory and then returns variable rc. Before calling the >

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Logan Gunthorpe
On 05/12/16 12:46 PM, Jason Gunthorpe wrote: NVMe might have to deal with pci-e hot-unplug, which is a similar problem-class to the GPU case.. Sure, but if the NVMe device gets hot-unplugged it means that all the CMB mappings are useless and need to be torn down. This probably means

[PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-05 Thread Shuah Khan
vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs attributes triggering the lock-class key not persistent warning. Call sysfs_attr_init() for dynamically allocated sysfs attributes to fix it. vhci_hcd vhci_hcd: USB/IP Virtual Host Controller vhci_hcd vhci_hcd: new USB bus

[PATCH] usbip: fix warning in vhci_hcd_probe/lockdep_init_map

2016-12-05 Thread Shuah Khan
vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs attributes triggering the lock-class key not persistent warning. Call sysfs_attr_init() for dynamically allocated sysfs attributes to fix it. vhci_hcd vhci_hcd: USB/IP Virtual Host Controller vhci_hcd vhci_hcd: new USB bus

Re: [PATCH 1/1] atm: fix improper return value

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 13:45:15 +0800 > From: Pan Bian > > It returns variable "error" when ioremap_nocache() returns a NULL > pointer. The value of "error" is 0 then, which will mislead the callers > to believe that there is no error.

Re: [PATCH 1/1] atm: fix improper return value

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 13:45:15 +0800 > From: Pan Bian > > It returns variable "error" when ioremap_nocache() returns a NULL > pointer. The value of "error" is 0 then, which will mislead the callers > to believe that there is no error. This patch fixes the bug, returning >

Re: [PATCH 1/1] net: irda: set error code on failures

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 13:27:40 +0800 > From: Pan Bian > > When the calls to kzalloc() fail, the value of return variable ret may > be 0. 0 means success in this context. This patch fixes the bug, > assigning "-ENOMEM" to ret before

Re: [PATCH 1/1] net: irda: set error code on failures

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 13:27:40 +0800 > From: Pan Bian > > When the calls to kzalloc() fail, the value of return variable ret may > be 0. 0 means success in this context. This patch fixes the bug, > assigning "-ENOMEM" to ret before calling kzalloc(). > > Bugzilla:

Re: [PATCH 1/1] net: caif: remove ineffective check

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 12:15:44 +0800 > The check of the return value of sock_register() is ineffective. > "if(!err)" seems to be a typo. It is better to propagate the error code > to the callers of caif_sktinit_module(). This patch removes the check >

Re: [PATCH 1/1] net: caif: remove ineffective check

2016-12-05 Thread David Miller
From: Pan Bian Date: Sun, 4 Dec 2016 12:15:44 +0800 > The check of the return value of sock_register() is ineffective. > "if(!err)" seems to be a typo. It is better to propagate the error code > to the callers of caif_sktinit_module(). This patch removes the check > statment and directly

Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

2016-12-05 Thread David Miller
From: Grygorii Strashko Date: Mon, 5 Dec 2016 12:47:16 -0600 > > > On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote: >> There is desc_read() macros to read desc fields, so no need to >> use __raw_readl(); >> >> Signed-off-by: Ivan Khoronzhuk

Re: [PATCH] net: ethernet: ti: cpdma: use desc_read in chan_process instead of raw read

2016-12-05 Thread David Miller
From: Grygorii Strashko Date: Mon, 5 Dec 2016 12:47:16 -0600 > > > On 12/02/2016 08:05 PM, Ivan Khoronzhuk wrote: >> There is desc_read() macros to read desc fields, so no need to >> use __raw_readl(); >> >> Signed-off-by: Ivan Khoronzhuk > > > I'm going to update it all at once as part of

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Jason Gunthorpe
On Mon, Dec 05, 2016 at 12:27:20PM -0700, Logan Gunthorpe wrote: > > > On 05/12/16 12:14 PM, Jason Gunthorpe wrote: > >But CMB sounds much more like the GPU case where there is a > >specialized allocator handing out the BAR to consumers, so I'm not > >sure a general purpose chardev makes a lot

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Jason Gunthorpe
On Mon, Dec 05, 2016 at 12:27:20PM -0700, Logan Gunthorpe wrote: > > > On 05/12/16 12:14 PM, Jason Gunthorpe wrote: > >But CMB sounds much more like the GPU case where there is a > >specialized allocator handing out the BAR to consumers, so I'm not > >sure a general purpose chardev makes a lot

[PATCH 1/2] Revert "f2fs: use percpu_counter for # of dirty pages in inode"

2016-12-05 Thread Jaegeuk Kim
This reverts commit 1beba1b3a953107c3ff5448ab4e4297db4619c76. The perpcu_counter doesn't provide atomicity in single core and consume more DRAM. That incurs fs_mark test failure due to ENOMEM. Cc: sta...@vger.kernel.org Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h | 10

[PATCH 1/2] Revert "f2fs: use percpu_counter for # of dirty pages in inode"

2016-12-05 Thread Jaegeuk Kim
This reverts commit 1beba1b3a953107c3ff5448ab4e4297db4619c76. The perpcu_counter doesn't provide atomicity in single core and consume more DRAM. That incurs fs_mark test failure due to ENOMEM. Cc: sta...@vger.kernel.org Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h | 10 +-

[PATCH 2/2] f2fs: call sync_fs when f2fs is idle

2016-12-05 Thread Jaegeuk Kim
The sync_fs in f2fs_balance_fs_bg must avoid interrupting current user requests. Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index d5141a06b9a3..8affc5621181

[PATCH 2/2] f2fs: call sync_fs when f2fs is idle

2016-12-05 Thread Jaegeuk Kim
The sync_fs in f2fs_balance_fs_bg must avoid interrupting current user requests. Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index d5141a06b9a3..8affc5621181 100644 ---

Re: [PATCH] Yama: allow access for the current ptrace parent

2016-12-05 Thread Kees Cook
On Mon, Dec 5, 2016 at 11:13 AM, Josh Stone wrote: > On 12/02/2016 03:27 PM, Kees Cook wrote: >>> + /* If there's already an active tracing relationship, then make an >> >> I'll adjust the comment style here and add it to my tree for -next. > > Thanks! > > I guess the

Re: [PATCH] Yama: allow access for the current ptrace parent

2016-12-05 Thread Kees Cook
On Mon, Dec 5, 2016 at 11:13 AM, Josh Stone wrote: > On 12/02/2016 03:27 PM, Kees Cook wrote: >>> + /* If there's already an active tracing relationship, then make an >> >> I'll adjust the comment style here and add it to my tree for -next. > > Thanks! > > I guess the tweak is that it

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2016-12-05 Thread Andreas Grünbacher
2016-12-05 17:25 GMT+01:00 J. Bruce Fields : > On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: >> >> Can NFS people comment on this? Where does the nfs4_acl come from? >> > >> >

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2016-12-05 Thread Andreas Grünbacher
2016-12-05 17:25 GMT+01:00 J. Bruce Fields : > On Mon, Dec 05, 2016 at 04:36:03PM +0100, Miklos Szeredi wrote: >> On Mon, Dec 5, 2016 at 4:19 PM, J. Bruce Fields wrote: >> >> Can NFS people comment on this? Where does the nfs4_acl come from? >> > >> > This is the interface the NFS client

Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning

2016-12-05 Thread Michael S. Tsirkin
On Wed, Nov 23, 2016 at 10:48:19PM +0200, Michael S. Tsirkin wrote: > sparse is unhappy about this code in hlist_add_tail_rcu: > > struct hlist_node *i, *last = NULL; > > for (i = hlist_first_rcu(h); i; i = hlist_next_rcu(i)) > last = i; > > This is because

Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning

2016-12-05 Thread Michael S. Tsirkin
On Wed, Nov 23, 2016 at 10:48:19PM +0200, Michael S. Tsirkin wrote: > sparse is unhappy about this code in hlist_add_tail_rcu: > > struct hlist_node *i, *last = NULL; > > for (i = hlist_first_rcu(h); i; i = hlist_next_rcu(i)) > last = i; > > This is because

Re: [PATCHv13 0/3] rdmacg: IB/core: rdma controller support

2016-12-05 Thread Tejun Heo
Parav, it's a bit too late for this cycle. Let's target v4.11. I'll review the patches after the merge window. Please ping me if I don't. Thanks. -- tejun

Re: [PATCHv13 0/3] rdmacg: IB/core: rdma controller support

2016-12-05 Thread Tejun Heo
Parav, it's a bit too late for this cycle. Let's target v4.11. I'll review the patches after the merge window. Please ping me if I don't. Thanks. -- tejun

Re: ILP32 for ARM64: testing with glibc testsuite

2016-12-05 Thread Steve Ellcey
On Mon, 2016-12-05 at 11:07 +0100, Andreas Schwab wrote: > On Dez 05 2016, "Zhangjian (Bamvor)" > wrote: > > > > > Is there some progresses on it? We could collabrate to fix those > > issues. > All the elf/nptl/rt fails should be fixed by the recent binutils >

Re: ILP32 for ARM64: testing with glibc testsuite

2016-12-05 Thread Steve Ellcey
On Mon, 2016-12-05 at 11:07 +0100, Andreas Schwab wrote: > On Dez 05 2016, "Zhangjian (Bamvor)" > wrote: > > > > > Is there some progresses on it? We could collabrate to fix those > > issues. > All the elf/nptl/rt fails should be fixed by the recent binutils > fixes. > > Andreas. I am using

Re: usb/gadget: use-after-free in gadgetfs_setup

2016-12-05 Thread Alan Stern
On Mon, 5 Dec 2016, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). > > BUG: KASAN: use-after-free in gadgetfs_setup+0x208a/0x20e0 at addr > 88003dfe5bf2 > Read of size

Re: usb/gadget: use-after-free in gadgetfs_setup

2016-12-05 Thread Alan Stern
On Mon, 5 Dec 2016, Andrey Konovalov wrote: > Hi! > > I've got the following error report while running the syzkaller fuzzer. > > On commit 3c49de52d5647cda8b42c4255cf8a29d1e22eff5 (Dec 2). > > BUG: KASAN: use-after-free in gadgetfs_setup+0x208a/0x20e0 at addr > 88003dfe5bf2 > Read of size

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-12-05 Thread Richard Cochran
On Mon, Dec 05, 2016 at 12:25:57PM -0600, Grygorii Strashko wrote: > >> --- a/Documentation/devicetree/bindings/net/keystone-netcp.txt > >> +++ b/Documentation/devicetree/bindings/net/keystone-netcp.txt > >> @@ -113,6 +113,15 @@ Optional properties: > >>will only

Re: [PATCH 1/6] net: ethernet: ti: netcp: add support of cpts

2016-12-05 Thread Richard Cochran
On Mon, Dec 05, 2016 at 12:25:57PM -0600, Grygorii Strashko wrote: > >> --- a/Documentation/devicetree/bindings/net/keystone-netcp.txt > >> +++ b/Documentation/devicetree/bindings/net/keystone-netcp.txt > >> @@ -113,6 +113,15 @@ Optional properties: > >>will only

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Logan Gunthorpe
On 05/12/16 12:14 PM, Jason Gunthorpe wrote: But CMB sounds much more like the GPU case where there is a specialized allocator handing out the BAR to consumers, so I'm not sure a general purpose chardev makes a lot of sense? I don't think it will ever need to be as complicated as the GPU

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Logan Gunthorpe
On 05/12/16 12:14 PM, Jason Gunthorpe wrote: But CMB sounds much more like the GPU case where there is a specialized allocator handing out the BAR to consumers, so I'm not sure a general purpose chardev makes a lot of sense? I don't think it will ever need to be as complicated as the GPU

Re: [PATCH v8 1/3] perf annotate: Show raw form for jump instruction with indirect target

2016-12-05 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 05, 2016 at 09:26:45PM +0530, Ravi Bangoria escreveu: > For jump instructions that does not include target address as direct > operand, show the original disassembled line for them. This is needed > for certain powerpc jump instructions that use target address in a > register (such as

Re: [PATCH v8 1/3] perf annotate: Show raw form for jump instruction with indirect target

2016-12-05 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 05, 2016 at 09:26:45PM +0530, Ravi Bangoria escreveu: > For jump instructions that does not include target address as direct > operand, show the original disassembled line for them. This is needed > for certain powerpc jump instructions that use target address in a > register (such as

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Jason Gunthorpe
On Mon, Dec 05, 2016 at 10:48:58AM -0800, Dan Williams wrote: > On Mon, Dec 5, 2016 at 10:39 AM, Logan Gunthorpe wrote: > > On 05/12/16 11:08 AM, Dan Williams wrote: > >> > >> I've already recommended that iopmem not be a block device and instead > >> be a device-dax

Re: Enabling peer to peer device transactions for PCIe devices

2016-12-05 Thread Jason Gunthorpe
On Mon, Dec 05, 2016 at 10:48:58AM -0800, Dan Williams wrote: > On Mon, Dec 5, 2016 at 10:39 AM, Logan Gunthorpe wrote: > > On 05/12/16 11:08 AM, Dan Williams wrote: > >> > >> I've already recommended that iopmem not be a block device and instead > >> be a device-dax instance. I also don't think

Re: [PATCH] Yama: allow access for the current ptrace parent

2016-12-05 Thread Josh Stone
On 12/02/2016 03:27 PM, Kees Cook wrote: >> + /* If there's already an active tracing relationship, then make an > > I'll adjust the comment style here and add it to my tree for -next. Thanks! I guess the tweak is that it should have an empty "/*" line? FWIW, checkpatch.pl doesn't warn

Re: [PATCH] Yama: allow access for the current ptrace parent

2016-12-05 Thread Josh Stone
On 12/02/2016 03:27 PM, Kees Cook wrote: >> + /* If there's already an active tracing relationship, then make an > > I'll adjust the comment style here and add it to my tree for -next. Thanks! I guess the tweak is that it should have an empty "/*" line? FWIW, checkpatch.pl doesn't warn

Re: bio linked list corruption.

2016-12-05 Thread Vegard Nossum
On 5 December 2016 at 18:55, Linus Torvalds wrote: > On Mon, Dec 5, 2016 at 9:09 AM, Vegard Nossum wrote: >> >> The warning shows that it made it past the list_empty_careful() check >> in finish_wait() but then bugs out on the >task_list >>

Re: bio linked list corruption.

2016-12-05 Thread Vegard Nossum
On 5 December 2016 at 18:55, Linus Torvalds wrote: > On Mon, Dec 5, 2016 at 9:09 AM, Vegard Nossum wrote: >> >> The warning shows that it made it past the list_empty_careful() check >> in finish_wait() but then bugs out on the >task_list >> dereference. >> >> Anything stick out? > > I hate that

Re: [PATCH v2 2/2] eeprom: Add IDT 89HPESx driver bindings file

2016-12-05 Thread Serge Semin
On Mon, Dec 05, 2016 at 11:27:07AM -0600, Rob Herring wrote: > On Mon, Dec 5, 2016 at 9:25 AM, Serge Semin wrote: > > On Mon, Dec 05, 2016 at 08:46:21AM -0600, Rob Herring > > wrote: > >> On Tue, Nov 29, 2016 at 01:38:21AM +0300, Serge

Re: [PATCH v2 2/2] eeprom: Add IDT 89HPESx driver bindings file

2016-12-05 Thread Serge Semin
On Mon, Dec 05, 2016 at 11:27:07AM -0600, Rob Herring wrote: > On Mon, Dec 5, 2016 at 9:25 AM, Serge Semin wrote: > > On Mon, Dec 05, 2016 at 08:46:21AM -0600, Rob Herring > > wrote: > >> On Tue, Nov 29, 2016 at 01:38:21AM +0300, Serge Semin wrote: > >> > See cover-letter for changelog > >> >

Re: scsi: use-after-free in bio_copy_from_iter

2016-12-05 Thread Al Viro
On Mon, Dec 05, 2016 at 04:17:53PM +0100, Johannes Thumshirn wrote: > 633 hp = >header; > [...] > 646 hp->dxferp = (char __user *)buf + cmd_size; > So the memory for hp->dxferp comes from: > 633 hp = >header; > >From my debug instrumentation I see that the

Re: scsi: use-after-free in bio_copy_from_iter

2016-12-05 Thread Al Viro
On Mon, Dec 05, 2016 at 04:17:53PM +0100, Johannes Thumshirn wrote: > 633 hp = >header; > [...] > 646 hp->dxferp = (char __user *)buf + cmd_size; > So the memory for hp->dxferp comes from: > 633 hp = >header; > >From my debug instrumentation I see that the

<    3   4   5   6   7   8   9   10   11   12   >