Re: [GIT PULL] overlayfs update for 4.10

2016-12-11 Thread Miklos Szeredi
On Sun, Dec 11, 2016 at 02:51:15PM +0100, Miklos Szeredi wrote: > On Sun, Dec 11, 2016 at 3:12 AM, Al Viro wrote: > > On Sat, Dec 10, 2016 at 09:49:26PM +0100, Miklos Szeredi wrote: > >> Hi Al, > >> > >> I usually send overlayfs pulls directly to Linus, but it it suits

Re: [GIT PULL] overlayfs update for 4.10

2016-12-11 Thread Miklos Szeredi
On Sun, Dec 11, 2016 at 02:51:15PM +0100, Miklos Szeredi wrote: > On Sun, Dec 11, 2016 at 3:12 AM, Al Viro wrote: > > On Sat, Dec 10, 2016 at 09:49:26PM +0100, Miklos Szeredi wrote: > >> Hi Al, > >> > >> I usually send overlayfs pulls directly to Linus, but it it suits you, > >> please > >> feel

[PATCH V2] firmware: simplify defining and handling FW_OPT_FALLBACK

2016-12-11 Thread Rafał Miłecki
From: Rafał Miłecki I found handling of FW_OPT_FALLBACK a bit complex. It was defined using another option and their values were dependent on kernel config. It was also non-trivial to follow the code. Some callers were using FW_OPT_FALLBACK which was confusing since the

[PATCH V2] firmware: simplify defining and handling FW_OPT_FALLBACK

2016-12-11 Thread Rafał Miłecki
From: Rafał Miłecki I found handling of FW_OPT_FALLBACK a bit complex. It was defined using another option and their values were dependent on kernel config. It was also non-trivial to follow the code. Some callers were using FW_OPT_FALLBACK which was confusing since the _request_firmware

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-11 Thread Michal Marek
Dne 6.12.2016 v 12:54 Robert Jarzmik napsal(a): > Robert Jarzmik writes: > >> When the kernel is compiled with an "O=" argument, the object files are >> not necessarily in the source tree, and more probably in another tree. >> >> In this situation, the current used check

Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory

2016-12-11 Thread Michal Marek
Dne 6.12.2016 v 12:54 Robert Jarzmik napsal(a): > Robert Jarzmik writes: > >> When the kernel is compiled with an "O=" argument, the object files are >> not necessarily in the source tree, and more probably in another tree. >> >> In this situation, the current used check doesn't work, and >>

[PATCH] treewide: Make remaining source files non-executable

2016-12-11 Thread Joe Perches
.c and .h source files should not be executable, change the permissions to 0644. Signed-off-by: Joe Perches --- drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_d.h | 0 drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_sh_mask.h | 0

[PATCH] treewide: Make remaining source files non-executable

2016-12-11 Thread Joe Perches
.c and .h source files should not be executable, change the permissions to 0644. Signed-off-by: Joe Perches --- drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_d.h | 0 drivers/gpu/drm/amd/include/asic_reg/dce/dce_11_2_sh_mask.h | 0 drivers/gpu/drm/amd/include/cgs_common.h

linux-next: no v4.11 code yet

2016-12-11 Thread Stephen Rothwell
Hi all, Please do not add any v4.11 code to your linux-next included branches until after v4.10-rc1 has been released. -- Cheers, Stephen Rothwell

linux-next: no v4.11 code yet

2016-12-11 Thread Stephen Rothwell
Hi all, Please do not add any v4.11 code to your linux-next included branches until after v4.10-rc1 has been released. -- Cheers, Stephen Rothwell

Linux 4.9

2016-12-11 Thread Linus Torvalds
So Linux 4.9 is out, and the merge window for 4.10 is thus open. With the extra week for 4.9, the timing for the merge window is obviously a bit awkward, and it technically closes in two weeks on Christmas Day. But that is a pure technicality, because I will certainly stop pulling on the 23rd at

Linux 4.9

2016-12-11 Thread Linus Torvalds
So Linux 4.9 is out, and the merge window for 4.10 is thus open. With the extra week for 4.9, the timing for the merge window is obviously a bit awkward, and it technically closes in two weeks on Christmas Day. But that is a pure technicality, because I will certainly stop pulling on the 23rd at

Re: [kernel-hardening] [PATCH] siphash: add cryptographically secure hashtable function

2016-12-11 Thread Greg KH
On Sun, Dec 11, 2016 at 04:30:31PM +0100, Jason A. Donenfeld wrote: > Hi Greg, > > Thanks for the review. Responses to your suggestions are inline below: > > On Sat, Dec 10, 2016 at 1:37 PM, Greg KH wrote: > > Please use u64 and u8 instead of the userspace uint64_t

Re: [kernel-hardening] [PATCH] siphash: add cryptographically secure hashtable function

2016-12-11 Thread Greg KH
On Sun, Dec 11, 2016 at 04:30:31PM +0100, Jason A. Donenfeld wrote: > Hi Greg, > > Thanks for the review. Responses to your suggestions are inline below: > > On Sat, Dec 10, 2016 at 1:37 PM, Greg KH wrote: > > Please use u64 and u8 instead of the userspace uint64_t and uint8_t > > types for

Re: CVE-2016-7097 causes acl leak

2016-12-11 Thread Greg KH
On Mon, Dec 05, 2016 at 09:16:31AM -0800, Mark Salyzyn wrote: > Commit 073931017b49d9458aa351605b43a7e34598caef has several occurrences of > an acl leak. > > posix_acl_update_mode(inose, , ); > > . . . > > posix_acl_release(acl); > > > acl is NULLed in posix_acl_update_mode to signal caller

Re: CVE-2016-7097 causes acl leak

2016-12-11 Thread Greg KH
On Mon, Dec 05, 2016 at 09:16:31AM -0800, Mark Salyzyn wrote: > Commit 073931017b49d9458aa351605b43a7e34598caef has several occurrences of > an acl leak. > > posix_acl_update_mode(inose, , ); > > . . . > > posix_acl_release(acl); > > > acl is NULLed in posix_acl_update_mode to signal caller

Re: [PATCH v9] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-12-11 Thread Nick Dyer
On Sun, Dec 11, 2016 at 12:03:49AM -0800, Dmitry Torokhov wrote: > On Sun, Dec 11, 2016 at 12:18:26AM +, Nick Dyer wrote: > > +static void rmi_f34v7_parse_img_header_10_bl_container(struct f34_data > > *f34, > > + const u8 *image) > > +{ > > +

Re: [PATCH v9] Input: synaptics-rmi4 - add support for F34 V7 bootloader

2016-12-11 Thread Nick Dyer
On Sun, Dec 11, 2016 at 12:03:49AM -0800, Dmitry Torokhov wrote: > On Sun, Dec 11, 2016 at 12:18:26AM +, Nick Dyer wrote: > > +static void rmi_f34v7_parse_img_header_10_bl_container(struct f34_data > > *f34, > > + const u8 *image) > > +{ > > +

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-11 Thread Pavel Machek
Hi! > On 09.12.2016 12:21, Pavel Machek wrote: > > On Fri 2016-12-09 00:19:43, Francois Romieu wrote: > >> Lino Sanfilippo : > >> [...] > >> > OTOH Pavel said that he actually could produce a deadlock. Now I wonder > >> > if > >> > this is caused by that locking scheme

Re: [PATCH 1/2] net: ethernet: sxgbe: remove private tx queue lock

2016-12-11 Thread Pavel Machek
Hi! > On 09.12.2016 12:21, Pavel Machek wrote: > > On Fri 2016-12-09 00:19:43, Francois Romieu wrote: > >> Lino Sanfilippo : > >> [...] > >> > OTOH Pavel said that he actually could produce a deadlock. Now I wonder > >> > if > >> > this is caused by that locking scheme (in a way I have not

Re: [PATCH] stmmac: disable tx coalescing

2016-12-11 Thread Pavel Machek
On Sun 2016-12-11 14:31:13, David Miller wrote: > From: Pavel Machek > Date: Sun, 11 Dec 2016 20:07:50 +0100 > > > David, ping? Can I get you to apply this one? > > > > As you noticed, tx coalescing is completely broken in that driver, and > > not easy to repair. This is simplest

Re: [PATCH] stmmac: disable tx coalescing

2016-12-11 Thread Pavel Machek
On Sun 2016-12-11 14:31:13, David Miller wrote: > From: Pavel Machek > Date: Sun, 11 Dec 2016 20:07:50 +0100 > > > David, ping? Can I get you to apply this one? > > > > As you noticed, tx coalescing is completely broken in that driver, and > > not easy to repair. This is simplest way to disable

Re: [PATCH] stmmac: disable tx coalescing

2016-12-11 Thread David Miller
From: Pavel Machek Date: Sun, 11 Dec 2016 20:07:50 +0100 > David, ping? Can I get you to apply this one? > > As you noticed, tx coalescing is completely broken in that driver, and > not easy to repair. This is simplest way to disable it. It can still > be re-enabled from

Re: [PATCH] stmmac: disable tx coalescing

2016-12-11 Thread David Miller
From: Pavel Machek Date: Sun, 11 Dec 2016 20:07:50 +0100 > David, ping? Can I get you to apply this one? > > As you noticed, tx coalescing is completely broken in that driver, and > not easy to repair. This is simplest way to disable it. It can still > be re-enabled from userspace, so code can

[PATCH] ARM: ep93xx: Disable TS-72xx watchdog before uncompressing

2016-12-11 Thread Florian Fainelli
The TS-72xx/73xx boards have a CPLD watchdog which is configured to reset the board after 8 seconds, if the kernel is large enough that this takes about this time to decompress the kernel, we will encounter a spurious reboot. Do not pull ts72xx.h, but instead locally define what we need to

[PATCH] ARM: ep93xx: Disable TS-72xx watchdog before uncompressing

2016-12-11 Thread Florian Fainelli
The TS-72xx/73xx boards have a CPLD watchdog which is configured to reset the board after 8 seconds, if the kernel is large enough that this takes about this time to decompress the kernel, we will encounter a spurious reboot. Do not pull ts72xx.h, but instead locally define what we need to

Re: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

2016-12-11 Thread Marek Vasut
On 12/11/2016 07:01 PM, Arvind Yadav wrote: > Here, If devm_ioremap will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > > Signed-off-by: Arvind Yadav > --- > drivers/mtd/devices/docg3.c | 5 - > 1 file changed, 4 insertions(+), 1

Re: [V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

2016-12-11 Thread Marek Vasut
On 12/11/2016 07:01 PM, Arvind Yadav wrote: > Here, If devm_ioremap will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. > > Signed-off-by: Arvind Yadav > --- > drivers/mtd/devices/docg3.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

[PATCH] staging: dgnc: update TODO file

2016-12-11 Thread Fernando Apesteguia
Remove reference to checkpatch warnings since its output is now clean. --- drivers/staging/dgnc/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO index 0e0825b..0bdfd26 100644 --- a/drivers/staging/dgnc/TODO +++

[PATCH] staging: dgnc: update TODO file

2016-12-11 Thread Fernando Apesteguia
Remove reference to checkpatch warnings since its output is now clean. --- drivers/staging/dgnc/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO index 0e0825b..0bdfd26 100644 --- a/drivers/staging/dgnc/TODO +++

Re: Remaining crypto API regressions with CONFIG_VMAP_STACK

2016-12-11 Thread Andy Lutomirski
On Fri, Dec 9, 2016 at 3:08 PM, Eric Biggers wrote: > In the 4.9 kernel, virtually-mapped stacks will be supported and enabled by > default on x86_64. This has been exposing a number of problems in which > on-stack buffers are being passed into the crypto API, which to

Re: Remaining crypto API regressions with CONFIG_VMAP_STACK

2016-12-11 Thread Andy Lutomirski
On Fri, Dec 9, 2016 at 3:08 PM, Eric Biggers wrote: > In the 4.9 kernel, virtually-mapped stacks will be supported and enabled by > default on x86_64. This has been exposing a number of problems in which > on-stack buffers are being passed into the crypto API, which to support crypto >

Re: [PATCH] stmmac: disable tx coalescing

2016-12-11 Thread Pavel Machek
Hi! David, ping? Can I get you to apply this one? As you noticed, tx coalescing is completely broken in that driver, and not easy to repair. This is simplest way to disable it. It can still be re-enabled from userspace, so code can be fixed in future. Best regards,

Re: [PATCH] stmmac: disable tx coalescing

2016-12-11 Thread Pavel Machek
Hi! David, ping? Can I get you to apply this one? As you noticed, tx coalescing is completely broken in that driver, and not easy to repair. This is simplest way to disable it. It can still be re-enabled from userspace, so code can be fixed in future. Best regards,

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Pan Xinhui
在 2016/12/12 01:43, Pan Xinhui 写道: hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might help. pls. ignore the code style and this is tested :)

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Pan Xinhui
在 2016/12/12 01:43, Pan Xinhui 写道: hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might help. pls. ignore the code style and this is tested :)

[V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

2016-12-11 Thread Arvind Yadav
Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. Signed-off-by: Arvind Yadav --- drivers/mtd/devices/docg3.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/docg3.c

[V1] mtd: devices: docg3:- Handle return value of devm_ioremap.

2016-12-11 Thread Arvind Yadav
Here, If devm_ioremap will fail. It will return NULL. Kernel can run into a NULL-pointer dereference. Signed-off-by: Arvind Yadav --- drivers/mtd/devices/docg3.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c

Re: [PATCH v2 0/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Pan Xinhui
在 2016/12/11 23:36, Jia He 写道: nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from

Re: [PATCH v2 0/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Pan Xinhui
在 2016/12/11 23:36, Jia He 写道: nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from

[PATCH 1/2] lockdep: Markup callers of might_lock() as potential sleepers

2016-12-11 Thread Chris Wilson
If might_lock() is called on a mutex, it may also potentially sleep. Call might_sleep() in this case so that the caller is checked for both. This is similar to the might_sleep() that is checked by the real mutex_lock(). Signed-off-by: Chris Wilson Cc: Peter Zijlstra

[PATCH 1/2] lockdep: Markup callers of might_lock() as potential sleepers

2016-12-11 Thread Chris Wilson
If might_lock() is called on a mutex, it may also potentially sleep. Call might_sleep() in this case so that the caller is checked for both. This is similar to the might_sleep() that is checked by the real mutex_lock(). Signed-off-by: Chris Wilson Cc: Peter Zijlstra Cc: Ingo Molnar ---

[PATCH 2/2] kref: Annotate kref_put_mutex() with might_lock()

2016-12-11 Thread Chris Wilson
As kref_put_mutex() may take the mutex (on the final unreference), mark it up with might_lock() so that the caller is unconditionally checked by lockdep. Signed-off-by: Chris Wilson Cc: Peter Zijlstra --- include/linux/kref.h | 1 + 1 file

[PATCH 2/2] kref: Annotate kref_put_mutex() with might_lock()

2016-12-11 Thread Chris Wilson
As kref_put_mutex() may take the mutex (on the final unreference), mark it up with might_lock() so that the caller is unconditionally checked by lockdep. Signed-off-by: Chris Wilson Cc: Peter Zijlstra --- include/linux/kref.h | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Pan Xinhui
hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might help. pls. ignore the code style and this is tested :) diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index

Re: [PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Pan Xinhui
hi, jia nice catch! However I think we should fix it totally. This is because do_proc_dointvec_conv() try to get a int value from a bool *. something like below might help. pls. ignore the code style and this is tested :) diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index

net/3com/3c515: Fix timer handling, prevent leaks and crashes

2016-12-11 Thread Thomas Gleixner
The timer handling in this driver is broken in several ways: - corkscrew_open() initializes and arms a timer before requesting the device interrupt. If the request fails the timer stays armed. A second call to corkscrew_open will unconditionally reinitialize the quued timer and arm it

net/3com/3c515: Fix timer handling, prevent leaks and crashes

2016-12-11 Thread Thomas Gleixner
The timer handling in this driver is broken in several ways: - corkscrew_open() initializes and arms a timer before requesting the device interrupt. If the request fails the timer stays armed. A second call to corkscrew_open will unconditionally reinitialize the quued timer and arm it

[PATCH] libnvdimm, pfn: fix align attribute

2016-12-11 Thread Dan Williams
Fix the format specifier so that the attribute can be parsed correctly. Currently it returns decimal 1000 for a 4096-byte alignment. Cc: Reported-by: Dave Jiang Fixes: 315c562536c4 ("libnvdimm, pfn: add 'align' attribute, default to HPAGE_SIZE")

[PATCH] libnvdimm, pfn: fix align attribute

2016-12-11 Thread Dan Williams
Fix the format specifier so that the attribute can be parsed correctly. Currently it returns decimal 1000 for a 4096-byte alignment. Cc: Reported-by: Dave Jiang Fixes: 315c562536c4 ("libnvdimm, pfn: add 'align' attribute, default to HPAGE_SIZE") Signed-off-by: Dan Williams ---

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Willy Tarreau
On Sun, Dec 11, 2016 at 03:50:31PM +0100, Jason A. Donenfeld wrote: > 3. Add 3 bytes of padding, set to zero, to the encrypted section just > before the IP header, marked for future use. > Pros: satisfies IETF mantras, can use those extra bits in the future > for interesting protocol extensions

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Willy Tarreau
On Sun, Dec 11, 2016 at 03:50:31PM +0100, Jason A. Donenfeld wrote: > 3. Add 3 bytes of padding, set to zero, to the encrypted section just > before the IP header, marked for future use. > Pros: satisfies IETF mantras, can use those extra bits in the future > for interesting protocol extensions

[V1] rtc:rtc-vr41xx :- Retunr error is not correct in rtc_probe

2016-12-11 Thread Arvind Yadav
Here, rtc_probe is returning EBUSY at any error case. It should return ENOMEM insted of EBUSY. -EBUSY A resource you need is not avaialable. -ENOMEM This is used to signify lack of memory resources. -ENODEV This is used when no device is available. Signed-off-by: Arvind Yadav

[V1] rtc:rtc-vr41xx :- Retunr error is not correct in rtc_probe

2016-12-11 Thread Arvind Yadav
Here, rtc_probe is returning EBUSY at any error case. It should return ENOMEM insted of EBUSY. -EBUSY A resource you need is not avaialable. -ENOMEM This is used to signify lack of memory resources. -ENODEV This is used when no device is available. Signed-off-by: Arvind Yadav ---

[PATCH v2 0/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Jason A. Donenfeld
On Sun, Dec 11, 2016 at 4:30 PM, Andrew Lunn wrote: > I'm not a crypto expert, but does this not give you a helping hand in > breaking the crypto? You know the plain text value of these bytes, and > where they are in the encrypted text. You also know with some probability that

[PATCH v2 0/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Jason A. Donenfeld
On Sun, Dec 11, 2016 at 4:30 PM, Andrew Lunn wrote: > I'm not a crypto expert, but does this not give you a helping hand in > breaking the crypto? You know the plain text value of these bytes, and > where they are in the encrypted text. You also know with some probability that there's going to

[PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module paramter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc items.

[PATCH v2 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module paramter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc items.

[PATCH v10 0/2] the fixup for the USB HOST1 at rk3288 platform

2016-12-11 Thread Randy Li
changelog: v10 minior fixup v9 use a work_queue to reset usb phy to prevent access mutex lock at interrupter runtime. v8 minior fixup v7 add the forgot dummy phy_reset() for the generic phy is disabled. v7 Some minor fixup v6 Send the last two patches v5 A few modification at style,

[PATCH v10 1/2] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-12-11 Thread Randy Li
On the rk3288 USB host-only port (the one that's not the OTG-enabled port) the PHY can get into a bad state when a wakeup is asserted (not just a wakeup from full system suspend but also a wakeup from autosuspend). We can get the PHY out of its bad state by asserting its "port reset", but

[PATCH v10 0/2] the fixup for the USB HOST1 at rk3288 platform

2016-12-11 Thread Randy Li
changelog: v10 minior fixup v9 use a work_queue to reset usb phy to prevent access mutex lock at interrupter runtime. v8 minior fixup v7 add the forgot dummy phy_reset() for the generic phy is disabled. v7 Some minor fixup v6 Send the last two patches v5 A few modification at style,

[PATCH v10 1/2] usb: dwc2: assert phy reset when waking up in rk3288 platform

2016-12-11 Thread Randy Li
On the rk3288 USB host-only port (the one that's not the OTG-enabled port) the PHY can get into a bad state when a wakeup is asserted (not just a wakeup from full system suspend but also a wakeup from autosuspend). We can get the PHY out of its bad state by asserting its "port reset", but

[PATCH v10 2/2] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset

2016-12-11 Thread Randy Li
The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 has a hardware errata that causes everything to get confused when we get a remote wakeup. We'll use the reset that's in the CRU to reset the port when it's in a bad state. Note that we add the reset to both dwc2 controllers

[PATCH v10 2/2] ARM: dts: rockchip: Point rk3288 dwc2 usb at the full PHY reset

2016-12-11 Thread Randy Li
The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 has a hardware errata that causes everything to get confused when we get a remote wakeup. We'll use the reset that's in the CRU to reset the port when it's in a bad state. Note that we add the reset to both dwc2 controllers

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Andrew Lunn
> 3. Add 3 bytes of padding, set to zero, to the encrypted section just > before the IP header, marked for future use. > Pros: satisfies IETF mantras, can use those extra bits in the future > for interesting protocol extensions for authenticated peers. > Cons: lowers MTU, marginally more difficult

Re: [kernel-hardening] [PATCH] siphash: add cryptographically secure hashtable function

2016-12-11 Thread Jason A. Donenfeld
Hi Greg, Thanks for the review. Responses to your suggestions are inline below: On Sat, Dec 10, 2016 at 1:37 PM, Greg KH wrote: > Please use u64 and u8 instead of the userspace uint64_t and uint8_t > types for kernel code. Yes, the ship has probably sailed for

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Andrew Lunn
> 3. Add 3 bytes of padding, set to zero, to the encrypted section just > before the IP header, marked for future use. > Pros: satisfies IETF mantras, can use those extra bits in the future > for interesting protocol extensions for authenticated peers. > Cons: lowers MTU, marginally more difficult

Re: [kernel-hardening] [PATCH] siphash: add cryptographically secure hashtable function

2016-12-11 Thread Jason A. Donenfeld
Hi Greg, Thanks for the review. Responses to your suggestions are inline below: On Sat, Dec 10, 2016 at 1:37 PM, Greg KH wrote: > Please use u64 and u8 instead of the userspace uint64_t and uint8_t > types for kernel code. Yes, the ship has probably sailed for trying to > strictly enforce it,

Re: [PATCH] iio: adc: max1027: allocate DMA-safe buffer

2016-12-11 Thread Jonathan Cameron
On 10/12/16 20:53, Marcus Folkesson wrote: > On Sat, Dec 10, 2016 at 05:36:34PM +, Jonathan Cameron wrote: >> On 09/12/16 10:24, Marcus Folkesson wrote: >>> The buffer needs to be DMA-safe when used with spi_read() >>> >>> Signed-off-by: Marcus Folkesson >> Please

Re: [PATCH] iio: adc: max1027: allocate DMA-safe buffer

2016-12-11 Thread Jonathan Cameron
On 10/12/16 20:53, Marcus Folkesson wrote: > On Sat, Dec 10, 2016 at 05:36:34PM +, Jonathan Cameron wrote: >> On 09/12/16 10:24, Marcus Folkesson wrote: >>> The buffer needs to be DMA-safe when used with spi_read() >>> >>> Signed-off-by: Marcus Folkesson >> Please read the documentation in

Re: [PATCH 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread kbuild test robot
-bool-to-u32/20161211-225133 base: git://linux-nfs.org/~bfields/linux.git nfsd-next config: i386-randconfig-x006-201650 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings

Re: [PATCH 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread kbuild test robot
-bool-to-u32/20161211-225133 base: git://linux-nfs.org/~bfields/linux.git nfsd-next config: i386-randconfig-x006-201650 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All error/warnings

Re: [PATCH 2/3] sys_mmap64()

2016-12-11 Thread kbuild test robot
-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: c6x-evmc6457_defconfig (attached as .config) compiler: c6x-elf-gcc (GCC) 6.2.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross

Re: [PATCH 2/3] sys_mmap64()

2016-12-11 Thread kbuild test robot
-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: c6x-evmc6457_defconfig (attached as .config) compiler: c6x-elf-gcc (GCC) 6.2.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Jason A. Donenfeld
Hey guys, Thanks for the extremely detailed answers. The main take-away from this is that passing unaligned packets to the networking stack kills kittens. So now it's a question of mitigation. I have three options: 1. Copy the plaintext to three bytes before the start of the cipher text,

Re: Misalignment, MIPS, and ip_hdr(skb)->version

2016-12-11 Thread Jason A. Donenfeld
Hey guys, Thanks for the extremely detailed answers. The main take-away from this is that passing unaligned packets to the networking stack kills kittens. So now it's a question of mitigation. I have three options: 1. Copy the plaintext to three bytes before the start of the cipher text,

[PATCH 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc

[PATCH 1/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc

[PATCH 0/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc

[PATCH 0/1] lockd: Change nsm_use_hostnames from bool to u32

2016-12-11 Thread Jia He
nsm_use_hostnames is a module parameter and it will be exported to sysctl procfs. This is to let user sometimes change it from userspace. But the minimal unit for sysctl procfs read/write it sizeof(int). In big endian system, the converting from/to bool to/from int will cause error for proc

Re: [PATCH 2/3] sys_mmap64()

2016-12-11 Thread kbuild test robot
-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: h8300-h8300h-sim_defconfig (attached as .config) compiler: h8300-linux-gcc (GCC) 6.2.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross

Re: [PATCH 2/3] sys_mmap64()

2016-12-11 Thread kbuild test robot
-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: h8300-h8300h-sim_defconfig (attached as .config) compiler: h8300-linux-gcc (GCC) 6.2.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross

Re: [PATCH RFC 2/2] ARM: nommu: remap exception base address to RAM

2016-12-11 Thread Afzal Mohammed
Hi, On Sun, Dec 11, 2016 at 06:42:55PM +0530, Afzal Mohammed wrote: > Kernel text start at an offset of at least 32K to account for page > tables in MMU case. Proper way to put it might have been "32K (to account for 16K initial page tables & the old atags)", unless i missed something. Regards

Re: [PATCH RFC 2/2] ARM: nommu: remap exception base address to RAM

2016-12-11 Thread Afzal Mohammed
Hi, On Sun, Dec 11, 2016 at 06:42:55PM +0530, Afzal Mohammed wrote: > Kernel text start at an offset of at least 32K to account for page > tables in MMU case. Proper way to put it might have been "32K (to account for 16K initial page tables & the old atags)", unless i missed something. Regards

RE: [PATCH V4 00/11] megaraid_sas: Updates for scsi-next

2016-12-11 Thread Sasikumar PC
Hi Chris, I will be rebasing to include " pci_alloc_irq_vectors conversion from Hannes" in the next version of the patch Thanks sasi -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Wednesday, December 07, 2016 2:31 AM To: Sasikumar Chandrasekaran Cc:

RE: [PATCH V4 00/11] megaraid_sas: Updates for scsi-next

2016-12-11 Thread Sasikumar PC
Hi Chris, I will be rebasing to include " pci_alloc_irq_vectors conversion from Hannes" in the next version of the patch Thanks sasi -Original Message- From: Christoph Hellwig [mailto:h...@infradead.org] Sent: Wednesday, December 07, 2016 2:31 AM To: Sasikumar Chandrasekaran Cc:

Re: [PATCH 2/2] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically

2016-12-11 Thread Tetsuo Handa
Tetsuo Handa wrote: > Michal Hocko wrote: > > On Thu 08-12-16 21:53:44, Tetsuo Handa wrote: > > > If we could agree > > > with calling __alloc_pages_nowmark() before out_of_memory() if > > > __GFP_NOFAIL > > > is given, we can avoid locking up while minimizing possibility of invoking > > > the

Re: [PATCH 2/2] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically

2016-12-11 Thread Tetsuo Handa
Tetsuo Handa wrote: > Michal Hocko wrote: > > On Thu 08-12-16 21:53:44, Tetsuo Handa wrote: > > > If we could agree > > > with calling __alloc_pages_nowmark() before out_of_memory() if > > > __GFP_NOFAIL > > > is given, we can avoid locking up while minimizing possibility of invoking > > > the

Re: [GIT PULL] overlayfs update for 4.10

2016-12-11 Thread Miklos Szeredi
On Sun, Dec 11, 2016 at 3:12 AM, Al Viro wrote: > On Sat, Dec 10, 2016 at 09:49:26PM +0100, Miklos Szeredi wrote: >> Hi Al, >> >> I usually send overlayfs pulls directly to Linus, but it it suits you, please >> feel free to pull from: >> >>

Re: [GIT PULL] overlayfs update for 4.10

2016-12-11 Thread Miklos Szeredi
On Sun, Dec 11, 2016 at 3:12 AM, Al Viro wrote: > On Sat, Dec 10, 2016 at 09:49:26PM +0100, Miklos Szeredi wrote: >> Hi Al, >> >> I usually send overlayfs pulls directly to Linus, but it it suits you, please >> feel free to pull from: >> >>

Re: [PATCH 3/3] mm: make pagoff_t type 64-bit

2016-12-11 Thread kbuild test robot
/mm-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: i386-randconfig-x003-201650 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones

Re: [PATCH 3/3] mm: make pagoff_t type 64-bit

2016-12-11 Thread kbuild test robot
/mm-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: i386-randconfig-x003-201650 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones

Re: [PATCH 3/3] mm: make pagoff_t type 64-bit

2016-12-11 Thread kbuild test robot
/mm-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: i386-tinyconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed

Re: [PATCH 3/3] mm: make pagoff_t type 64-bit

2016-12-11 Thread kbuild test robot
/mm-move-argument-checkers-of-mmap_pgoff-to-separated-routine/20161211-211314 config: i386-tinyconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed

[PATCH] firmware: simplify defining and handling FW_OPT_FALLBACK

2016-12-11 Thread Rafał Miłecki
From: Rafał Miłecki I found handling of FW_OPT_FALLBACK a bit complex. It was defined using another option and their values were dependent on kernel config. It was also non-trivial to follow the code. Some callers were using FW_OPT_FALLBACK which was confusing since the

[PATCH] firmware: simplify defining and handling FW_OPT_FALLBACK

2016-12-11 Thread Rafał Miłecki
From: Rafał Miłecki I found handling of FW_OPT_FALLBACK a bit complex. It was defined using another option and their values were dependent on kernel config. It was also non-trivial to follow the code. Some callers were using FW_OPT_FALLBACK which was confusing since the _request_firmware

[PATCH RFC 2/2] ARM: nommu: remap exception base address to RAM

2016-12-11 Thread Afzal Mohammed
Remap exception base address to start of RAM in Kernel in !MMU mode. Based on existing Kconfig help, Kernel was expecting it to be configured by external support. Also earlier it was not possible to copy the exception table to start of RAM due to Kconfig dependency, which has been fixed by a

[PATCH RFC 2/2] ARM: nommu: remap exception base address to RAM

2016-12-11 Thread Afzal Mohammed
Remap exception base address to start of RAM in Kernel in !MMU mode. Based on existing Kconfig help, Kernel was expecting it to be configured by external support. Also earlier it was not possible to copy the exception table to start of RAM due to Kconfig dependency, which has been fixed by a

<    1   2   3   4   >