[PATCH 01/29] IB/mlx4: Use kcalloc() in mlx4_ib_alloc_pv_bufs()

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 17 Feb 2017 20:00:34 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kcalloc". This issue was detected by using the Coccinelle

[PATCH 06/29] IB/mlx4: Delete three unnecessary return statements

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 17 Feb 2017 21:34:27 +0100 The script "checkpatch.pl" pointed information out like the following. WARNING: void function return statements are not generally useful Thus remove such a statement in the affected functions. Signed-off-by: Markus Elfring ---

Re: [RFC 7/8] fpga-region: add sysfs interface

2017-02-18 Thread Moritz Fischer
On Sat, Feb 18, 2017 at 02:10:43PM -0600, Alan Tull wrote: > On Sat, Feb 18, 2017 at 6:45 AM, Nadathur, Sundar > wrote: > > > Hi all, > >Interesting discussion. The discussion so far has brought out many > > concerns such as OS independence. There is an existing

[PATCH 05/29] IB/mlx4: Fix a typo in a comment line

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 17 Feb 2017 20:48:59 +0100 Add a missing character in this description and adjust the comment formatting. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/mlx4/mad.c | 6 -- 1 file

Re: [RFC 7/8] fpga-region: add sysfs interface

2017-02-18 Thread Moritz Fischer
On Sat, Feb 18, 2017 at 02:10:43PM -0600, Alan Tull wrote: > On Sat, Feb 18, 2017 at 6:45 AM, Nadathur, Sundar > wrote: > > > Hi all, > >Interesting discussion. The discussion so far has brought out many > > concerns such as OS independence. There is an existing format, well-known > > to

[PATCH 05/29] IB/mlx4: Fix a typo in a comment line

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 17 Feb 2017 20:48:59 +0100 Add a missing character in this description and adjust the comment formatting. Signed-off-by: Markus Elfring --- drivers/infiniband/hw/mlx4/mad.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 04/29] IB/mlx4: Improve another size determination in alloc_pv_object()

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 17 Feb 2017 20:20:43 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 04/29] IB/mlx4: Improve another size determination in alloc_pv_object()

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 17 Feb 2017 20:20:43 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:

Re: [PATCH 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread Joe Perches
On Sun, 2017-02-19 at 01:50 +0530, simran singhal wrote: > Simplify function returns by merging assignment and return into > one command line. > Found with Coccinelle > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; [] > diff --git

Re: [PATCH 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread Joe Perches
On Sun, 2017-02-19 at 01:50 +0530, simran singhal wrote: > Simplify function returns by merging assignment and return into > one command line. > Found with Coccinelle > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; [] > diff --git

[PATCH 03/29] IB/mlx4: Improve another size determination in mlx4_ib_alloc_demux_ctx()

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 17 Feb 2017 20:15:02 +0100 Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 03/29] IB/mlx4: Improve another size determination in mlx4_ib_alloc_demux_ctx()

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 17 Feb 2017 20:15:02 +0100 Replace the specification of a data type by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus

[PATCH 02/29] IB/mlx4: Improve another size determination in mlx4_ib_alloc_pv_bufs()

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 17 Feb 2017 20:05:38 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 02/29] IB/mlx4: Improve another size determination in mlx4_ib_alloc_pv_bufs()

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 17 Feb 2017 20:05:38 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:

[PATCH 00/29] IB/mlx: Fine-tuning for several function implementations

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 18 Feb 2017 21:34:32 +0100 Several update suggestions were taken into account from static source code analysis. Markus Elfring (29): Use kcalloc() in mlx4_ib_alloc_pv_bufs() Improve another size determination in

[PATCH 00/29] IB/mlx: Fine-tuning for several function implementations

2017-02-18 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 18 Feb 2017 21:34:32 +0100 Several update suggestions were taken into account from static source code analysis. Markus Elfring (29): Use kcalloc() in mlx4_ib_alloc_pv_bufs() Improve another size determination in mlx4_ib_alloc_pv_bufs() Improve another size

Re: [Outreachy kernel] [PATCH 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread Julia Lawall
On Sun, 19 Feb 2017, simran singhal wrote: > Simplify function returns by merging assignment and return into > one command line. > Found with Coccinelle > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: simran singhal

Re: [Outreachy kernel] [PATCH 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread Julia Lawall
On Sun, 19 Feb 2017, simran singhal wrote: > Simplify function returns by merging assignment and return into > one command line. > Found with Coccinelle > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: simran singhal > --- >

Re: [PATCH] switchtec: cleanup cdev init

2017-02-18 Thread Logan Gunthorpe
Hi, Please don't apply this patch and instead apply the switchtec driver as we submitted in v2. As per the discussion in [1], not using the cdev's kobj parent results in incorrect reference counting and a possible use of the cdev after its containing structure is freed. I've also done a quick

Re: [PATCH] switchtec: cleanup cdev init

2017-02-18 Thread Logan Gunthorpe
Hi, Please don't apply this patch and instead apply the switchtec driver as we submitted in v2. As per the discussion in [1], not using the cdev's kobj parent results in incorrect reference counting and a possible use of the cdev after its containing structure is freed. I've also done a quick

[PATCH 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread simran singhal
Simplify function returns by merging assignment and return into one command line. Found with Coccinelle @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: simran singhal --- drivers/staging/vt6655/card.c | 2 +- 1 file

[PATCH 1/6] staging: vt6655: Compress return logic

2017-02-18 Thread simran singhal
Simplify function returns by merging assignment and return into one command line. Found with Coccinelle @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: simran singhal --- drivers/staging/vt6655/card.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 2/2] mfd: axp20x: Add support for dts property "xpowers,master-mode"

2017-02-18 Thread Rask Ingemann Lambertsen
commit b101829a029a ("mfd: axp20x: Fix AXP806 access errors on cold boot") was intended to fix the case where a board uses an AXP806 in slave mode, but the boot loader leaves it in master mode for lack of AXP806 support. But now the driver breaks on boards where the PMIC is operating in master

[PATCH 2/2] mfd: axp20x: Add support for dts property "xpowers,master-mode"

2017-02-18 Thread Rask Ingemann Lambertsen
commit b101829a029a ("mfd: axp20x: Fix AXP806 access errors on cold boot") was intended to fix the case where a board uses an AXP806 in slave mode, but the boot loader leaves it in master mode for lack of AXP806 support. But now the driver breaks on boards where the PMIC is operating in master

Re: [RFC 7/8] fpga-region: add sysfs interface

2017-02-18 Thread Alan Tull
On Sat, Feb 18, 2017 at 6:45 AM, Nadathur, Sundar wrote: > Hi all, >Interesting discussion. The discussion so far has brought out many > concerns such as OS independence. There is an existing format, well-known to > developers, with widespread support, and which

Re: [RFC 7/8] fpga-region: add sysfs interface

2017-02-18 Thread Alan Tull
On Sat, Feb 18, 2017 at 6:45 AM, Nadathur, Sundar wrote: > Hi all, >Interesting discussion. The discussion so far has brought out many > concerns such as OS independence. There is an existing format, well-known to > developers, with widespread support, and which is quite extensible: >

[PATCH 1/2] dts: mfd: axp20x: Add xpowers,master-mode property for AXP806 PMICs

2017-02-18 Thread Rask Ingemann Lambertsen
commit b101829a029a ("mfd: axp20x: Fix AXP806 access errors on cold boot") was intended to fix the case where a board uses an AXP806 in slave mode, but the boot loader leaves it in master mode for lack of AXP806 support. But now the driver breaks on boards where the PMIC is operating in master

[PATCH 1/2] dts: mfd: axp20x: Add xpowers,master-mode property for AXP806 PMICs

2017-02-18 Thread Rask Ingemann Lambertsen
commit b101829a029a ("mfd: axp20x: Fix AXP806 access errors on cold boot") was intended to fix the case where a board uses an AXP806 in slave mode, but the boot loader leaves it in master mode for lack of AXP806 support. But now the driver breaks on boards where the PMIC is operating in master

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Joe Perches wrote: > On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote: > > On Sun, 19 Feb 2017, simran singhal wrote: > > > Extra parentheses were causing checkpatch issues > > > and were removed. > [] > > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c > > >

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Joe Perches wrote: > On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote: > > On Sun, 19 Feb 2017, simran singhal wrote: > > > Extra parentheses were causing checkpatch issues > > > and were removed. > [] > > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c > > >

[PATCH 0/2] mfd: axp20x: Restore master mode support on AXP806

2017-02-18 Thread Rask Ingemann Lambertsen
The AXP806 (and very similar AXP808) PMICs can be wired to either master mode or slave mode on a board-by-board basis. A register on the PMIC needs to be set accordingly for the PMIC to respond to other register accesses. The "xpowers,master-mode" property introduced in this patch series lets a

[PATCH 0/2] mfd: axp20x: Restore master mode support on AXP806

2017-02-18 Thread Rask Ingemann Lambertsen
The AXP806 (and very similar AXP808) PMICs can be wired to either master mode or slave mode on a board-by-board basis. A register on the PMIC needs to be set accordingly for the PMIC to respond to other register accesses. The "xpowers,master-mode" property introduced in this patch series lets a

Re: [RFC 3/4] dt-bindings: iio: add support for GPIO triggers

2017-02-18 Thread Jonathan Cameron
On 17/02/17 16:03, Fabrice Gasnier wrote: > Document Industrial I/O GPIO trigger support. > > Signed-off-by: Fabrice Gasnier Whilst I think this needs redoing for the interrupt trigger driver, please be aware that bindings must be OS agnostic i.e. you can't name things

Re: [RFC 3/4] dt-bindings: iio: add support for GPIO triggers

2017-02-18 Thread Jonathan Cameron
On 17/02/17 16:03, Fabrice Gasnier wrote: > Document Industrial I/O GPIO trigger support. > > Signed-off-by: Fabrice Gasnier Whilst I think this needs redoing for the interrupt trigger driver, please be aware that bindings must be OS agnostic i.e. you can't name things after linux specific

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread Joe Perches
On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote: > On Sun, 19 Feb 2017, simran singhal wrote: > > Extra parentheses were causing checkpatch issues > > and were removed. [] > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c > > b/drivers/staging/rtl8192e/rtl819x_HTProc.c [] > > @@

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread Joe Perches
On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote: > On Sun, 19 Feb 2017, simran singhal wrote: > > Extra parentheses were causing checkpatch issues > > and were removed. [] > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c > > b/drivers/staging/rtl8192e/rtl819x_HTProc.c [] > > @@

Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-18 Thread H. Nikolaus Schaller
> Am 18.02.2017 um 19:08 schrieb Pavel Machek : > >>> And I agree that kernel should _not_ attempt rescaling itself, as it >>> would lose precision. >> >> With an almost 1:1 mapping you won't loose precision. > > How do you propose to do that? something like xinput --set-prop

Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-18 Thread H. Nikolaus Schaller
> Am 18.02.2017 um 19:08 schrieb Pavel Machek : > >>> And I agree that kernel should _not_ attempt rescaling itself, as it >>> would lose precision. >> >> With an almost 1:1 mapping you won't loose precision. > > How do you propose to do that? something like xinput --set-prop --type=float

Re: [RFC 4/4] iio: trigger: add GPIO trigger

2017-02-18 Thread Jonathan Cameron
On 17/02/17 16:16, Lars-Peter Clausen wrote: > On 02/17/2017 05:03 PM, Fabrice Gasnier wrote: >> GPIOs can be used to generate triggers for any IIO device. >> Introduce generic GPIO trigger driver. It offers some options >> to tune polarity (e.g. rising/falling edge), and label so trigger >> name

Re: [RFC 4/4] iio: trigger: add GPIO trigger

2017-02-18 Thread Jonathan Cameron
On 17/02/17 16:16, Lars-Peter Clausen wrote: > On 02/17/2017 05:03 PM, Fabrice Gasnier wrote: >> GPIOs can be used to generate triggers for any IIO device. >> Introduce generic GPIO trigger driver. It offers some options >> to tune polarity (e.g. rising/falling edge), and label so trigger >> name

Re: [PATCH] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-18 Thread Joe Perches
On Sat, 2017-02-18 at 21:32 +0530, Arushi Singhal wrote: > Unnecessary parentheses as reported by checkpatch.pl [] > diff --git a/drivers/staging/ks7010/ks_hostif.c > b/drivers/staging/ks7010/ks_hostif.c [] > @@ -121,19 +121,19 @@ int get_current_ap(struct ks_wlan_private *priv, struct >

Re: [RFC 0/4] iio: trigger: Add OF support and GPIO based trigger

2017-02-18 Thread Jonathan Cameron
On 17/02/17 16:23, Daniel Baluta wrote: > On Fri, Feb 17, 2017 at 6:03 PM, Fabrice Gasnier > wrote: >> Hi, >> >> I send this as an RFC, as I'm digging to try to get as generic >> as possible GPIO based trigger support, as discussed earlier in >> other patchset "Add EXTI

Re: [PATCH] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-18 Thread Joe Perches
On Sat, 2017-02-18 at 21:32 +0530, Arushi Singhal wrote: > Unnecessary parentheses as reported by checkpatch.pl [] > diff --git a/drivers/staging/ks7010/ks_hostif.c > b/drivers/staging/ks7010/ks_hostif.c [] > @@ -121,19 +121,19 @@ int get_current_ap(struct ks_wlan_private *priv, struct >

Re: [RFC 0/4] iio: trigger: Add OF support and GPIO based trigger

2017-02-18 Thread Jonathan Cameron
On 17/02/17 16:23, Daniel Baluta wrote: > On Fri, Feb 17, 2017 at 6:03 PM, Fabrice Gasnier > wrote: >> Hi, >> >> I send this as an RFC, as I'm digging to try to get as generic >> as possible GPIO based trigger support, as discussed earlier in >> other patchset "Add EXTI GPIO trigger support to

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread Julia Lawall
On Sun, 19 Feb 2017, simran singhal wrote: > Extra parentheses were causing checkpatch issues > and were removed. > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-)

Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread Julia Lawall
On Sun, 19 Feb 2017, simran singhal wrote: > Extra parentheses were causing checkpatch issues > and were removed. > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Did not apply on linux-next-20170217 > > Signed-off-by: Romain Perier

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Did not apply on linux-next-20170217 > > Signed-off-by: Romain Perier > --- >

[PATCH] scsi: hpsa: Use 'pci_dma_mapping_error()' instead of 'dma_mapping_error()'

2017-02-18 Thread Christophe JAILLET
Use 'pci_dma_mapping_error()' instead of 'dma_mapping_error()' because it is more consistent with the rest of the code. It is also a little less verbove. While at it, remove some '(dma_addr_t)' casts in order to be consistent within the file. Signed-off-by: Christophe JAILLET

[PATCH] scsi: hpsa: Use 'pci_dma_mapping_error()' instead of 'dma_mapping_error()'

2017-02-18 Thread Christophe JAILLET
Use 'pci_dma_mapping_error()' instead of 'dma_mapping_error()' because it is more consistent with the rest of the code. It is also a little less verbove. While at it, remove some '(dma_addr_t)' casts in order to be consistent within the file. Signed-off-by: Christophe JAILLET ---

Re: [PATCH] proc/sysctl: prune stale dentries during unregistering

2017-02-18 Thread Konstantin Khlebnikov
This patch has locking problem. I've got lockdep splat under LTP. [ 6633.115456] == [ 6633.115502] [ INFO: possible circular locking dependency detected ] [ 6633.115553] 4.9.10-debug+ #9 Tainted: G L [ 6633.115584]

Re: [PATCH] proc/sysctl: prune stale dentries during unregistering

2017-02-18 Thread Konstantin Khlebnikov
This patch has locking problem. I've got lockdep splat under LTP. [ 6633.115456] == [ 6633.115502] [ INFO: possible circular locking dependency detected ] [ 6633.115553] 4.9.10-debug+ #9 Tainted: G L [ 6633.115584]

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: Tested all patches by compilation and checkpatch. All of them compile fine, but patches 11 and 12 need some fixes. You can resend as PATCH instead of RFC. > The current PCI pool API are simple macro functions direct expanded to > the

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: Tested all patches by compilation and checkpatch. All of them compile fine, but patches 11 and 12 need some fixes. You can resend as PATCH instead of RFC. > The current PCI pool API are simple macro functions direct expanded to > the

[PATCH v2 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread simran singhal
Align * on last line, to conform to the kernal coding style for block comments. Signed-off-by: simran singhal --- v2: -Modified commit message drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread simran singhal
Align * on last line, to conform to the kernal coding style for block comments. Signed-off-by: simran singhal --- v2: -Modified commit message drivers/staging/rtl8192e/rtl819x_HT.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h

Re: [RFC v2 12/20] scsi: mpt3sas: Replace PCI pool old API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:48AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Please run checkpatch, fix the style issue and resend. > > Signed-off-by: Romain Perier

Re: [RFC v2 12/20] scsi: mpt3sas: Replace PCI pool old API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:48AM +0100, Romain Perier wrote: > The PCI pool API is deprecated. This commits replaces the PCI pool old > API by the appropriated function with the DMA pool API. Please run checkpatch, fix the style issue and resend. > > Signed-off-by: Romain Perier > --- >

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: Hi Romain, Checkpatch gives some warnings you can fix related to NULL tests before dma_pool_destroy(), and you changed indentation style in some of your changes. Some times it is important to keep consistency within a file even if

Re: [RFC v2 11/20] scsi: megaraid: Replace PCI pool old API

2017-02-18 Thread Peter Senna Tschudin
On Sat, Feb 18, 2017 at 09:35:47AM +0100, Romain Perier wrote: Hi Romain, Checkpatch gives some warnings you can fix related to NULL tests before dma_pool_destroy(), and you changed indentation style in some of your changes. Some times it is important to keep consistency within a file even if

[PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread simran singhal
Extra parentheses were causing checkpatch issues and were removed. Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c

[PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses

2017-02-18 Thread simran singhal
Extra parentheses were causing checkpatch issues and were removed. Signed-off-by: simran singhal --- drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c

[PATCH v2] staging: lustre: ko2iblnd: Adapt to the removal of ib_get_dma_mr()

2017-02-18 Thread Doug Oucharek
I tried to send this patch yesterday and it appeared to work. However, I did not see an email from the list. Assuming it failed and trying again. I apologize if this is a repeat.

[PATCH v2] staging: lustre: ko2iblnd: Adapt to the removal of ib_get_dma_mr()

2017-02-18 Thread Doug Oucharek
I tried to send this patch yesterday and it appeared to work. However, I did not see an email from the list. Assuming it failed and trying again. I apologize if this is a repeat.

[PATCH] staging: lustre: ko2iblnd: Adapt to the removal of ib_get_dma_mr()

2017-02-18 Thread Doug Oucharek
In Linux kernel 4.9-rc1, the function ib_get_dma_mr() was removed and a second parameter was added to ib_alloc_pd(). As this broke the building of the ko2iblnd module in staging, the Kconfig for LNet has marked ko2iblnd as broken and stopped building it. This patch fixes this breakage by: -

[PATCH] staging: lustre: ko2iblnd: Adapt to the removal of ib_get_dma_mr()

2017-02-18 Thread Doug Oucharek
In Linux kernel 4.9-rc1, the function ib_get_dma_mr() was removed and a second parameter was added to ib_alloc_pd(). As this broke the building of the ko2iblnd module in staging, the Kconfig for LNet has marked ko2iblnd as broken and stopped building it. This patch fixes this breakage by: -

Re: [RFC PATCH v4 00/28] x86: Secure Memory Encryption (AMD)

2017-02-18 Thread Borislav Petkov
On Thu, Feb 16, 2017 at 09:41:59AM -0600, Tom Lendacky wrote: > create mode 100644 Documentation/x86/amd-memory-encryption.txt > create mode 100644 arch/x86/include/asm/mem_encrypt.h > create mode 100644 arch/x86/kernel/mem_encrypt_boot.S > create mode 100644 arch/x86/kernel/mem_encrypt_init.c

Re: [RFC PATCH v4 00/28] x86: Secure Memory Encryption (AMD)

2017-02-18 Thread Borislav Petkov
On Thu, Feb 16, 2017 at 09:41:59AM -0600, Tom Lendacky wrote: > create mode 100644 Documentation/x86/amd-memory-encryption.txt > create mode 100644 arch/x86/include/asm/mem_encrypt.h > create mode 100644 arch/x86/kernel/mem_encrypt_boot.S > create mode 100644 arch/x86/kernel/mem_encrypt_init.c

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-18 Thread Russell King - ARM Linux
On Sat, Feb 18, 2017 at 09:29:17AM -0800, Steve Longerbeam wrote: > On 02/18/2017 01:23 AM, Russell King - ARM Linux wrote: > >On Fri, Feb 17, 2017 at 05:12:44PM -0800, Steve Longerbeam wrote: > >>Hi Russell, > >> > >>I signed-off on this but after more review I'm not sure this is right. > >> >

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-18 Thread Russell King - ARM Linux
On Sat, Feb 18, 2017 at 09:29:17AM -0800, Steve Longerbeam wrote: > On 02/18/2017 01:23 AM, Russell King - ARM Linux wrote: > >On Fri, Feb 17, 2017 at 05:12:44PM -0800, Steve Longerbeam wrote: > >>Hi Russell, > >> > >>I signed-off on this but after more review I'm not sure this is right. > >> >

Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-18 Thread Pavel Machek
> > And I agree that kernel should _not_ attempt rescaling itself, as it > > would lose precision. > > With an almost 1:1 mapping you won't loose precision. How do you propose to do that? Pavel -- (english)

Re: [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

2017-02-18 Thread Pavel Machek
> > And I agree that kernel should _not_ attempt rescaling itself, as it > > would lose precision. > > With an almost 1:1 mapping you won't loose precision. How do you propose to do that? Pavel -- (english)

Re: next_tick hang was Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

2017-02-18 Thread Pavel Machek
Hi! > > I guess I can. But I'll only have one 80x25 screen to look at... > > > > .config is attached. > > Ah this is x86-32, interesting! I'm going to try to boot that, we never know. > > Thanks a lot! Happens on x86-64, too; I'm running that normally, but for testing, 32-bit kernel is

Re: next_tick hang was Re: v4.10-rc8 (-rc6) boot regression on Intel desktop, does not boot after cold boots, boots after reboot

2017-02-18 Thread Pavel Machek
Hi! > > I guess I can. But I'll only have one 80x25 screen to look at... > > > > .config is attached. > > Ah this is x86-32, interesting! I'm going to try to boot that, we never know. > > Thanks a lot! Happens on x86-64, too; I'm running that normally, but for testing, 32-bit kernel is

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

2017-02-18 Thread Romain Perier
Le 18/02/2017 à 14:06, Greg Kroah-Hartman a écrit : > On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: >> The current PCI pool API are simple macro functions direct expanded to >> the appropriated dma pool functions. The prototypes are almost the same >> and semantically, they are

Re: [RFC v2 00/20] Replace PCI pool by DMA pool API

2017-02-18 Thread Romain Perier
Le 18/02/2017 à 14:06, Greg Kroah-Hartman a écrit : > On Sat, Feb 18, 2017 at 09:35:36AM +0100, Romain Perier wrote: >> The current PCI pool API are simple macro functions direct expanded to >> the appropriated dma pool functions. The prototypes are almost the same >> and semantically, they are

Re: [PATCHv2 4/5] perf stat: Add -a as a default target

2017-02-18 Thread Borislav Petkov
On Fri, Feb 17, 2017 at 06:48:13PM +0100, Boris Petkov wrote: > LGTM. > > Acked-by: me Well, it looks good but actually trying it is a different story. For example: $ ./perf stat -e amd_nb/event=0xe0,umask=0x1f/ sleep 1 still says because argc is not 0. So how about the below diff instead?

Re: [PATCHv2 4/5] perf stat: Add -a as a default target

2017-02-18 Thread Borislav Petkov
On Fri, Feb 17, 2017 at 06:48:13PM +0100, Boris Petkov wrote: > LGTM. > > Acked-by: me Well, it looks good but actually trying it is a different story. For example: $ ./perf stat -e amd_nb/event=0xe0,umask=0x1f/ sleep 1 still says because argc is not 0. So how about the below diff instead?

Re: net: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in skb_array_produce

2017-02-18 Thread Dmitry Vyukov
On Sat, Feb 18, 2017 at 6:28 PM, Dmitry Vyukov wrote: > On Fri, Feb 10, 2017 at 6:17 AM, Jason Wang wrote: >> >> >> On 2017年02月10日 02:10, Michael S. Tsirkin wrote: >>> >>> On Thu, Feb 09, 2017 at 05:02:31AM -0500, Jason Wang wrote: -

Re: net: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in skb_array_produce

2017-02-18 Thread Dmitry Vyukov
On Sat, Feb 18, 2017 at 6:28 PM, Dmitry Vyukov wrote: > On Fri, Feb 10, 2017 at 6:17 AM, Jason Wang wrote: >> >> >> On 2017年02月10日 02:10, Michael S. Tsirkin wrote: >>> >>> On Thu, Feb 09, 2017 at 05:02:31AM -0500, Jason Wang wrote: - Original Message - > > Hello, >

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-18 Thread Steve Longerbeam
On 02/16/2017 02:57 PM, Russell King - ARM Linux wrote: On Thu, Feb 16, 2017 at 02:27:41PM -0800, Steve Longerbeam wrote: On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: In version 4: With this version, I get:

Re: [PATCH v4 00/36] i.MX Media Driver

2017-02-18 Thread Steve Longerbeam
On 02/16/2017 02:57 PM, Russell King - ARM Linux wrote: On Thu, Feb 16, 2017 at 02:27:41PM -0800, Steve Longerbeam wrote: On 02/16/2017 02:20 PM, Russell King - ARM Linux wrote: On Wed, Feb 15, 2017 at 06:19:02PM -0800, Steve Longerbeam wrote: In version 4: With this version, I get:

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-18 Thread Steve Longerbeam
On 02/18/2017 01:23 AM, Russell King - ARM Linux wrote: On Fri, Feb 17, 2017 at 05:12:44PM -0800, Steve Longerbeam wrote: Hi Russell, I signed-off on this but after more review I'm not sure this is right. The CSI-2 receiver really has no control over frame rate. It's output frame rate is

Re: [PATCH v4 29/36] media: imx: mipi-csi2: enable setting and getting of frame rates

2017-02-18 Thread Steve Longerbeam
On 02/18/2017 01:23 AM, Russell King - ARM Linux wrote: On Fri, Feb 17, 2017 at 05:12:44PM -0800, Steve Longerbeam wrote: Hi Russell, I signed-off on this but after more review I'm not sure this is right. The CSI-2 receiver really has no control over frame rate. It's output frame rate is

Re: net: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in skb_array_produce

2017-02-18 Thread Dmitry Vyukov
On Fri, Feb 10, 2017 at 6:17 AM, Jason Wang wrote: > > > On 2017年02月10日 02:10, Michael S. Tsirkin wrote: >> >> On Thu, Feb 09, 2017 at 05:02:31AM -0500, Jason Wang wrote: >>> >>> - Original Message - Hello, I've got the following report while

Re: net: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected in skb_array_produce

2017-02-18 Thread Dmitry Vyukov
On Fri, Feb 10, 2017 at 6:17 AM, Jason Wang wrote: > > > On 2017年02月10日 02:10, Michael S. Tsirkin wrote: >> >> On Thu, Feb 09, 2017 at 05:02:31AM -0500, Jason Wang wrote: >>> >>> - Original Message - Hello, I've got the following report while running syzkaller fuzzer

Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote: > > > On Saturday, February 18, 2017 at 9:46:48 PM UTC+5:30, Julia Lawall wrote: > > > On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote: > > > > > > > On Saturday, February 18, 2017 at 9:00:51 PM UTC+5:30, Julia > Lawall wrote: >

Re: [Outreachy kernel] [PATCH 3/6] staging: rtl8192e: Fix block comments warning

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote: > > > On Saturday, February 18, 2017 at 9:46:48 PM UTC+5:30, Julia Lawall wrote: > > > On Sat, 18 Feb 2017, SIMRAN SINGHAL wrote: > > > > > > > On Saturday, February 18, 2017 at 9:00:51 PM UTC+5:30, Julia > Lawall wrote: >

[PATCH v2] mmc: meson-gx: remove mmc host on device removal

2017-02-18 Thread Michał Zegan
The mmc host was added in meson_mmc_probe, but never removed in meson_mmc_remove. Fix that by removing the host before deallocating other resources. Signed-off-by: Michał Zegan Tested-by: Michał Zegan --- changes since v1: rebased on top of patchset

[PATCH] mmc: meson-gx: fix error path when driver initialization fails before enabling clocks

2017-02-18 Thread Michał Zegan
This patch fixes the case where meson_mmc_probe function fails before core_clk is enabled. Originally, that would result in a try to disable the core clock, and if it was not already enabled, it would result in a kernel warning. This issue is similar to the one with div_clk. Fix it by introducing

[PATCH v2] mmc: meson-gx: remove mmc host on device removal

2017-02-18 Thread Michał Zegan
The mmc host was added in meson_mmc_probe, but never removed in meson_mmc_remove. Fix that by removing the host before deallocating other resources. Signed-off-by: Michał Zegan Tested-by: Michał Zegan --- changes since v1: rebased on top of patchset at

[PATCH] mmc: meson-gx: fix error path when driver initialization fails before enabling clocks

2017-02-18 Thread Michał Zegan
This patch fixes the case where meson_mmc_probe function fails before core_clk is enabled. Originally, that would result in a try to disable the core clock, and if it was not already enabled, it would result in a kernel warning. This issue is similar to the one with div_clk. Fix it by introducing

Re: [Outreachy kernel] [PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Arushi Singhal wrote: > The following patch the checkpatch.pl warning: > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > start of a line > > Signed-off-by: Arushi Singhal > --- > drivers/staging/ks7010/ks_hostif.c |

Re: [Outreachy kernel] [PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-18 Thread Julia Lawall
On Sat, 18 Feb 2017, Arushi Singhal wrote: > The following patch the checkpatch.pl warning: > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > start of a line > > Signed-off-by: Arushi Singhal > --- > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > 1 file changed, 2

[PATCH] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-18 Thread Arushi Singhal
Unnecessary parentheses should be avoided as reported by checkpatch.pl Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 24 drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files changed, 22

[PATCH] staging: ks7010: Unnecessary parentheses should be avoided

2017-02-18 Thread Arushi Singhal
Unnecessary parentheses should be avoided as reported by checkpatch.pl Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 24 drivers/staging/ks7010/ks_wlan_net.c | 20 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff

Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-18 Thread Greg KH
On Sat, Feb 18, 2017 at 10:10:02PM +0530, Arushi Singhal wrote: > The following patch the checkpatch.pl warning: > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > start of a line > > Signed-off-by: Arushi Singhal > --- >

Re: [PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-18 Thread Greg KH
On Sat, Feb 18, 2017 at 10:10:02PM +0530, Arushi Singhal wrote: > The following patch the checkpatch.pl warning: > drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the > start of a line > > Signed-off-by: Arushi Singhal > --- > drivers/staging/ks7010/ks_hostif.c | 4 ++-- > 1

[PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-18 Thread Arushi Singhal
The following patch the checkpatch.pl warning: drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH] Staging: ks7010: There should be no spaces at the start of a line

2017-02-18 Thread Arushi Singhal
The following patch the checkpatch.pl warning: drivers/staging/ks7010/ks_hostif.c warning: please, no spaces at the start of a line Signed-off-by: Arushi Singhal --- drivers/staging/ks7010/ks_hostif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

<    1   2   3   4   5   >