RE: [PATCH] scsi: aacraid: remove redundant zero check on ret

2017-02-26 Thread Dave Carroll
> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Friday, February 24, 2017 7:44 AM > To: dl-esc-Aacraid Linux Driver; James E . J . Bottomley; Martin K . > Petersen; linux-s...@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org;

RE: [PATCH] scsi: aacraid: remove redundant zero check on ret

2017-02-26 Thread Dave Carroll
> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Friday, February 24, 2017 7:44 AM > To: dl-esc-Aacraid Linux Driver; James E . J . Bottomley; Martin K . > Petersen; linux-s...@vger.kernel.org > Cc: kernel-janit...@vger.kernel.org;

[GIT PULL] watchdog updates for v4.11

2017-02-26 Thread Guenter Roeck
Hi Linus, Wim asked me to handle the watchdog pull request this time around. Please pull watchdog updates for Linux v4.11 from signed tag: git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-for-linus-v4.11 [ Yes, I know, I rebased to v4.10 which I should not

[GIT PULL] watchdog updates for v4.11

2017-02-26 Thread Guenter Roeck
Hi Linus, Wim asked me to handle the watchdog pull request this time around. Please pull watchdog updates for Linux v4.11 from signed tag: git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git watchdog-for-linus-v4.11 [ Yes, I know, I rebased to v4.10 which I should not

Microphone gain on N900

2017-02-26 Thread Pavel Machek
Hi! v4.10 works quite nicely on N900, but I still have problems with audio. Even GSM calls would be usable, if I had reasonable volume on microphone and speaker... but I don't. Both speaker and microphone are too quiet. I can get louder output by plugging headset -- good. I can hear the other

Microphone gain on N900

2017-02-26 Thread Pavel Machek
Hi! v4.10 works quite nicely on N900, but I still have problems with audio. Even GSM calls would be usable, if I had reasonable volume on microphone and speaker... but I don't. Both speaker and microphone are too quiet. I can get louder output by plugging headset -- good. I can hear the other

Re: [PATCH-tip 2/3] locking/rwsem: move down rwsem_down_read_failed()

2017-02-26 Thread Davidlohr Bueso
On Wed, 22 Feb 2017, Waiman Long wrote: Move the rwsem_down_read_failed() function down to below the optimistic spinning section as it is going to use function in that section in a later patch. So the title is a bit ambiguous, and I would argue that this should be folded into patch 3, and

Re: [PATCH-tip 2/3] locking/rwsem: move down rwsem_down_read_failed()

2017-02-26 Thread Davidlohr Bueso
On Wed, 22 Feb 2017, Waiman Long wrote: Move the rwsem_down_read_failed() function down to below the optimistic spinning section as it is going to use function in that section in a later patch. So the title is a bit ambiguous, and I would argue that this should be folded into patch 3, and

[PATCH] hid: usbhid: hiddev.c: fix checkpatch.pl errors

2017-02-26 Thread Avraham Shukron
- Extracted assignments out of 'if' statements - Removed unnecessary spaces - Broke long lines - Added empty lines after declarations Signed-off-by: Avraham Shukron --- drivers/hid/usbhid/hiddev.c | 51 ++--- 1 file changed, 34

[PATCH] hid: usbhid: hiddev.c: fix checkpatch.pl errors

2017-02-26 Thread Avraham Shukron
- Extracted assignments out of 'if' statements - Removed unnecessary spaces - Broke long lines - Added empty lines after declarations Signed-off-by: Avraham Shukron --- drivers/hid/usbhid/hiddev.c | 51 ++--- 1 file changed, 34 insertions(+), 17

Re: [PATCH v2 1/2] of: add devm_ functions for populate and depopulate

2017-02-26 Thread Daniel Vetter
On Fri, Feb 24, 2017 at 10:31:25AM -0600, Rob Herring wrote: > On Fri, Feb 24, 2017 at 10:14 AM, Benjamin Gaignard > wrote: > > Lots of calls to of_platform_populate() are not unbalanced by a call > > to of_platform_depopulate(). This create issues while drivers are

Re: [PATCH v2 1/2] of: add devm_ functions for populate and depopulate

2017-02-26 Thread Daniel Vetter
On Fri, Feb 24, 2017 at 10:31:25AM -0600, Rob Herring wrote: > On Fri, Feb 24, 2017 at 10:14 AM, Benjamin Gaignard > wrote: > > Lots of calls to of_platform_populate() are not unbalanced by a call > > to of_platform_depopulate(). This create issues while drivers are > > bind/unbind. > > > > In

Re: [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table

2017-02-26 Thread Guennadi Liakhovetski
On Wed, 22 Feb 2017, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the

Re: [PATCH 1/3] [media] soc-camera: ov5642: Add OF device ID table

2017-02-26 Thread Guennadi Liakhovetski
On Wed, 22 Feb 2017, Javier Martinez Canillas wrote: > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the

OT: Crowdfunding to port OpenBMC to Asus KGPE-D16

2017-02-26 Thread Paul Menzel
[Please CC me, as I am not subscribed.] Dear OpenBMC people, If you haven’t heard yet, there is a crowdfunding campaign going on to fund a port of OpenBMC to the Asus KGPE-D16 [1]. The free firmware coreboot [2] runs on that board, and no BLOBs have to be used with it. Having OpenBMC run on

OT: Crowdfunding to port OpenBMC to Asus KGPE-D16

2017-02-26 Thread Paul Menzel
[Please CC me, as I am not subscribed.] Dear OpenBMC people, If you haven’t heard yet, there is a crowdfunding campaign going on to fund a port of OpenBMC to the Asus KGPE-D16 [1]. The free firmware coreboot [2] runs on that board, and no BLOBs have to be used with it. Having OpenBMC run on

Re: [PATCH v2] drm/color: Document CTM eqations

2017-02-26 Thread Daniel Vetter
On Fri, Feb 17, 2017 at 01:54:52PM +, Brian Starkey wrote: > What's the verdict? We've got [1] which is about to become another > (driver) implementation - better to change before that merges than > after I guess. We could also just switch the internal representation to something more

Re: [PATCH v2] drm/color: Document CTM eqations

2017-02-26 Thread Daniel Vetter
On Fri, Feb 17, 2017 at 01:54:52PM +, Brian Starkey wrote: > What's the verdict? We've got [1] which is about to become another > (driver) implementation - better to change before that merges than > after I guess. We could also just switch the internal representation to something more

Re: [PATCH v4] drm/color: Document CTM eqations

2017-02-26 Thread Daniel Vetter
On Tue, Jan 31, 2017 at 05:43:48PM +, Brian Starkey wrote: > Explicitly state the expected CTM equations in the kerneldoc for the CTM > property, and the form of the matrix on struct drm_color_ctm. > > Cc: Ville Syrjälä > Cc: Lionel Landwerlin

Re: [PATCH v4] drm/color: Document CTM eqations

2017-02-26 Thread Daniel Vetter
On Tue, Jan 31, 2017 at 05:43:48PM +, Brian Starkey wrote: > Explicitly state the expected CTM equations in the kerneldoc for the CTM > property, and the form of the matrix on struct drm_color_ctm. > > Cc: Ville Syrjälä > Cc: Lionel Landwerlin > Cc: Daniel Vetter > Signed-off-by: Brian

Re: [PATCH] drm/via: use get_user_pages_unlocked()

2017-02-26 Thread Daniel Vetter
On Mon, Feb 20, 2017 at 06:46:54PM +, Lorenzo Stoakes wrote: > On 6 January 2017 at 07:09, Lorenzo Stoakes wrote: > > > > Adding Andrew, as this may be another less active corner of the corner, > > thanks! > > Hi all, > > Thought I'd also give this one a gentle nudge

Re: [PATCH] drm/via: use get_user_pages_unlocked()

2017-02-26 Thread Daniel Vetter
On Mon, Feb 20, 2017 at 06:46:54PM +, Lorenzo Stoakes wrote: > On 6 January 2017 at 07:09, Lorenzo Stoakes wrote: > > > > Adding Andrew, as this may be another less active corner of the corner, > > thanks! > > Hi all, > > Thought I'd also give this one a gentle nudge now the merge window

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Joe Perches
On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote: > On Sun, 26 Feb 2017, Joe Perches wrote: > > Mailing lists _should_ be copied on patch submissions. > > The idea of outreachy is that it should be a place for people to get > started without too much criticism from the outside. Originally,

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Joe Perches
On Sun, 2017-02-26 at 19:59 +0100, Julia Lawall wrote: > On Sun, 26 Feb 2017, Joe Perches wrote: > > Mailing lists _should_ be copied on patch submissions. > > The idea of outreachy is that it should be a place for people to get > started without too much criticism from the outside. Originally,

[PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

2017-02-26 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

2017-02-26 Thread Colin King
From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c

Re: [PATCH v2 1/2] crypto: vmx - Use skcipher for cbc fallback

2017-02-26 Thread Marcelo Cerri
On Fri, Feb 24, 2017 at 11:23:54AM -0300, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo > --- > drivers/crypto/vmx/aes_cbc.c | 44 > ++-- > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff

Re: [PATCH v2 1/2] crypto: vmx - Use skcipher for cbc fallback

2017-02-26 Thread Marcelo Cerri
On Fri, Feb 24, 2017 at 11:23:54AM -0300, Paulo Flabiano Smorigo wrote: > Signed-off-by: Paulo Flabiano Smorigo > --- > drivers/crypto/vmx/aes_cbc.c | 44 > ++-- > 1 file changed, 22 insertions(+), 22 deletions(-) > > diff --git

Re: [PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

2017-02-26 Thread Colin Ian King
On 26/02/17 18:52, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- > 1 file changed, 1

Re: [PATCH][V2] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "though"

2017-02-26 Thread Colin Ian King
On 26/02/17 18:52, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in RT_TRACE message > > Signed-off-by: Colin Ian King > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH-tip 1/3] locking/rwsem: Check wait_list without lock if spinner present

2017-02-26 Thread Davidlohr Bueso
On Wed, 22 Feb 2017, Waiman Long wrote: We can safely check the wait_list to see if waiters are present without lock when there are spinners to fall back on in case we miss a waiter. The advantage is that we can save a pair of spin_lock/unlock calls when the wait_list is empty. This translates

Re: [PATCH-tip 1/3] locking/rwsem: Check wait_list without lock if spinner present

2017-02-26 Thread Davidlohr Bueso
On Wed, 22 Feb 2017, Waiman Long wrote: We can safely check the wait_list to see if waiters are present without lock when there are spinners to fall back on in case we miss a waiter. The advantage is that we can save a pair of spin_lock/unlock calls when the wait_list is empty. This translates

Re: [PATCH-tip 3/3] locking/rwsem: Stop active read lock ASAP

2017-02-26 Thread Davidlohr Bueso
On Wed, 22 Feb 2017, Waiman Long wrote: On a 2-socket 36-core 72-thread x86-64 E5-2699 v3 system, a rwsem microbenchmark was run with 36 locking threads (one/core) doing 100k reader and writer lock/unlock operations each, the resulting locking rates (avg of 3 runs) on a 4.10 kernel were 561.4

Re: [PATCH-tip 3/3] locking/rwsem: Stop active read lock ASAP

2017-02-26 Thread Davidlohr Bueso
On Wed, 22 Feb 2017, Waiman Long wrote: On a 2-socket 36-core 72-thread x86-64 E5-2699 v3 system, a rwsem microbenchmark was run with 36 locking threads (one/core) doing 100k reader and writer lock/unlock operations each, the resulting locking rates (avg of 3 runs) on a 4.10 kernel were 561.4

[PATCH 1/1] Fixing coding guidelines in drivers/staging/android/ion/*

2017-02-26 Thread pjambhlekar
Signed-off-by: pjambhlekar --- drivers/staging/android/ion/ion-ioctl.c| 2 +- drivers/staging/android/ion/ion.c | 8 drivers/staging/android/ion/ion_cma_heap.c | 3 +-- drivers/staging/android/ion/ion_dummy_driver.c | 2 +-

[PATCH 1/1] Fixing coding guidelines in drivers/staging/android/ion/*

2017-02-26 Thread pjambhlekar
Signed-off-by: pjambhlekar --- drivers/staging/android/ion/ion-ioctl.c| 2 +- drivers/staging/android/ion/ion.c | 8 drivers/staging/android/ion/ion_cma_heap.c | 3 +-- drivers/staging/android/ion/ion_dummy_driver.c | 2 +-

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Joe Perches
On Sun, 2017-02-26 at 19:03 +0100, Julia Lawall wrote: > > On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote: > > > This was reported by checkpatch.pl > > > > Signed-off-by: Narcisa Ana Maria Vasile > > Acked-by: Julia Lawall > >

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Joe Perches
On Sun, 2017-02-26 at 19:03 +0100, Julia Lawall wrote: > > On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote: > > > This was reported by checkpatch.pl > > > > Signed-off-by: Narcisa Ana Maria Vasile > > Acked-by: Julia Lawall > > Actually, the outreachy tutorial says not to send patches

Re: [PATCH v2 6/7] tpm: expose spaces via a device link /dev/tpms

2017-02-26 Thread Dr. Greg Wettstein
On Sun, Feb 26, 2017 at 01:44:40PM +0200, Jarkko Sakkinen wrote: Good day, I hope this note finds the week starting well for everyone. > On Fri, Feb 24, 2017 at 08:02:08AM -0500, James Bottomley wrote: > > On Thu, 2017-02-23 at 11:09 +0200, Jarkko Sakkinen wrote: > > > On Thu, Feb 16, 2017 at

Re: [PATCH v2 6/7] tpm: expose spaces via a device link /dev/tpms

2017-02-26 Thread Dr. Greg Wettstein
On Sun, Feb 26, 2017 at 01:44:40PM +0200, Jarkko Sakkinen wrote: Good day, I hope this note finds the week starting well for everyone. > On Fri, Feb 24, 2017 at 08:02:08AM -0500, James Bottomley wrote: > > On Thu, 2017-02-23 at 11:09 +0200, Jarkko Sakkinen wrote: > > > On Thu, Feb 16, 2017 at

Re: [PATCH v4 3/4] leds: Add LED support for MT6323 PMIC

2017-02-26 Thread Jacek Anaszewski
Hi Sean, Thanks for the update. I have one comment to your changes below. On 02/24/2017 07:47 PM, sean.w...@mediatek.com wrote: > From: Sean Wang > > MT6323 PMIC is a multi-function device that includes > LED function. It allows attaching up to 4 LEDs which > can either

[PATCH] net: rocker: use new api ethtool_{get|set}_link_ksettings

2017-02-26 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/rocker/rocker_main.c | 55

[PATCH] net: rocker: use new api ethtool_{get|set}_link_ksettings

2017-02-26 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/rocker/rocker_main.c | 55

Re: [PATCH v4 3/4] leds: Add LED support for MT6323 PMIC

2017-02-26 Thread Jacek Anaszewski
Hi Sean, Thanks for the update. I have one comment to your changes below. On 02/24/2017 07:47 PM, sean.w...@mediatek.com wrote: > From: Sean Wang > > MT6323 PMIC is a multi-function device that includes > LED function. It allows attaching up to 4 LEDs which > can either be on, off or dimmed

[PATCH] uapi: fix asm/ipcbuf.h userspace compilation errors

2017-02-26 Thread Dmitry V. Levin
Include to fix asm/ipcbuf.h userspace compilation errors like this: /usr/include/asm-generic/ipcbuf.h:20:2: error: unknown type name '__kernel_key_t' __kernel_key_t key; /usr/include/asm-generic/ipcbuf.h:21:2: error: unknown type name '__kernel_uid32_t' __kernel_uid32_t uid;

[PATCH] uapi: fix asm/ipcbuf.h userspace compilation errors

2017-02-26 Thread Dmitry V. Levin
Include to fix asm/ipcbuf.h userspace compilation errors like this: /usr/include/asm-generic/ipcbuf.h:20:2: error: unknown type name '__kernel_key_t' __kernel_key_t key; /usr/include/asm-generic/ipcbuf.h:21:2: error: unknown type name '__kernel_uid32_t' __kernel_uid32_t uid;

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote: > This was reported by checkpatch.pl > > Signed-off-by: Narcisa Ana Maria Vasile Acked-by: Julia Lawall Actually, the outreachy tutorial says not to send patches to mailing lists, only to

Re: [Outreachy kernel] [PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Narcisa Ana Maria Vasile wrote: > This was reported by checkpatch.pl > > Signed-off-by: Narcisa Ana Maria Vasile Acked-by: Julia Lawall Actually, the outreachy tutorial says not to send patches to mailing lists, only to people (except in the case of IIO, where the

Re: [PATCH v4 1/4] Documentation: devicetree: Add document bindings for leds-mt6323

2017-02-26 Thread Jacek Anaszewski
Hi Sean, Thanks for the update. I have one comment below. On 02/24/2017 07:47 PM, sean.w...@mediatek.com wrote: > From: Sean Wang > > This patch adds documentation for devicetree bindings > for LED support on MT6323 PMIC > > Signed-off-by: Sean Wang

Re: [PATCH v4 1/4] Documentation: devicetree: Add document bindings for leds-mt6323

2017-02-26 Thread Jacek Anaszewski
Hi Sean, Thanks for the update. I have one comment below. On 02/24/2017 07:47 PM, sean.w...@mediatek.com wrote: > From: Sean Wang > > This patch adds documentation for devicetree bindings > for LED support on MT6323 PMIC > > Signed-off-by: Sean Wang > --- >

[PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Narcisa Ana Maria Vasile
This was reported by checkpatch.pl Signed-off-by: Narcisa Ana Maria Vasile --- drivers/staging/bcm2835-audio/bcm2835-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c

[PATCH] staging: bcm2835-audio: Fixed spacing around '&'

2017-02-26 Thread Narcisa Ana Maria Vasile
This was reported by checkpatch.pl Signed-off-by: Narcisa Ana Maria Vasile --- drivers/staging/bcm2835-audio/bcm2835-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/bcm2835-audio/bcm2835-pcm.c index

Re: [PATCH v2 1/3] module: verify address is read-only

2017-02-26 Thread Jessica Yu
+++ Eddie Kovsky [17/02/17 22:58 -0700]: Implement a mechanism to check if a module's address is in the rodata or ro_after_init sections. It mimics the exsiting functions that test if an address is inside a module's text section. It would be helpful to explain in the changelog the motivation

Re: [PATCH v2 1/3] module: verify address is read-only

2017-02-26 Thread Jessica Yu
+++ Eddie Kovsky [17/02/17 22:58 -0700]: Implement a mechanism to check if a module's address is in the rodata or ro_after_init sections. It mimics the exsiting functions that test if an address is inside a module's text section. It would be helpful to explain in the changelog the motivation

Re: [Outreachy kernel] [PATCH v4 2/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses are removed as reported by checkpatch.pl > to make coder nicer and to improve readability. > Also coding style is improved.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: >

Re: [Outreachy kernel] [PATCH v4 2/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses are removed as reported by checkpatch.pl > to make coder nicer and to improve readability. > Also coding style is improved.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: >

Re: [Outreachy kernel] [PATCH v4 1/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses are removed as reported by checkpatch.pl > to make coder nicer and to improve readability. > Also coding style is improved.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: >

Re: [Outreachy kernel] [PATCH v4 1/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Unnecessary parentheses are removed as reported by checkpatch.pl > to make coder nicer and to improve readability. > Also coding style is improved.For example:- > It's often nicer to read if &(foo[0]) is converted to foo like: >

[PATCH v4 2/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Arushi Singhal
Unnecessary parentheses are removed as reported by checkpatch.pl to make coder nicer and to improve readability. Also coding style is improved.For example:- It's often nicer to read if &(foo[0]) is converted to foo like: memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);

[PATCH v4 2/2] staging: ks7010: Unnecessary parentheses are removed.

2017-02-26 Thread Arushi Singhal
Unnecessary parentheses are removed as reported by checkpatch.pl to make coder nicer and to improve readability. Also coding style is improved.For example:- It's often nicer to read if &(foo[0]) is converted to foo like: memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);

[PATCH 0/1] Fixing coding guidelines in drivers/staging/android/ion

2017-02-26 Thread pjambhlekar
Coding guidelines are fixed by running checkpatch.pl pjambhlekar (1): Fixing coding guidelines in drivers/staging/android/ion/* drivers/staging/android/ion/ion-ioctl.c| 2 +- drivers/staging/android/ion/ion.c | 8 drivers/staging/android/ion/ion_cma_heap.c |

[PATCH 0/1] Fixing coding guidelines in drivers/staging/android/ion

2017-02-26 Thread pjambhlekar
Coding guidelines are fixed by running checkpatch.pl pjambhlekar (1): Fixing coding guidelines in drivers/staging/android/ion/* drivers/staging/android/ion/ion-ioctl.c| 2 +- drivers/staging/android/ion/ion.c | 8 drivers/staging/android/ion/ion_cma_heap.c |

Re: [LSF/MM TOPIC] do we really need PG_error at all?

2017-02-26 Thread James Bottomley
[added linux-scsi and linux-block because this is part of our error handling as well] On Sun, 2017-02-26 at 09:42 -0500, Jeff Layton wrote: > Proposing this as a LSF/MM TOPIC, but it may turn out to be me just > not understanding the semantics here. > > As I was looking into -ENOSPC handling in

Re: [LSF/MM TOPIC] do we really need PG_error at all?

2017-02-26 Thread James Bottomley
[added linux-scsi and linux-block because this is part of our error handling as well] On Sun, 2017-02-26 at 09:42 -0500, Jeff Layton wrote: > Proposing this as a LSF/MM TOPIC, but it may turn out to be me just > not understanding the semantics here. > > As I was looking into -ENOSPC handling in

Re: [PATCH 1/1] Fixing coding guidelines in drivers/staging/android/ion/*

2017-02-26 Thread Greg Kroah-Hartman
On Sun, Feb 26, 2017 at 10:24:02PM +0530, pjambhlekar wrote: > Signed-off-by: pjambhlekar > --- > drivers/staging/android/ion/ion-ioctl.c| 2 +- > drivers/staging/android/ion/ion.c | 8 > drivers/staging/android/ion/ion_cma_heap.c | 3 +--

Re: [PATCH 1/1] Fixing coding guidelines in drivers/staging/android/ion/*

2017-02-26 Thread Greg Kroah-Hartman
On Sun, Feb 26, 2017 at 10:24:02PM +0530, pjambhlekar wrote: > Signed-off-by: pjambhlekar > --- > drivers/staging/android/ion/ion-ioctl.c| 2 +- > drivers/staging/android/ion/ion.c | 8 > drivers/staging/android/ion/ion_cma_heap.c | 3 +-- >

Re: [PATCH] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "although"

2017-02-26 Thread Larry Finger
On 02/26/2017 09:19 AM, Colin King wrote: From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King Bad fix. It should be althougth => through. Please read the context. NACK. Larry ---

Re: [PATCH] rtlwifi: rtl8192de: ix spelling mistake: "althougth" -> "although"

2017-02-26 Thread Larry Finger
On 02/26/2017 09:19 AM, Colin King wrote: From: Colin Ian King trivial fix to spelling mistake in RT_TRACE message Signed-off-by: Colin Ian King Bad fix. It should be althougth => through. Please read the context. NACK. Larry --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c |

Re: [PATCH] net: s2io: fix typo argumnet argument

2017-02-26 Thread David Miller
From: Corentin Labbe Date: Sat, 25 Feb 2017 21:12:41 +0100 > This commit fix the typo argumnet/argument > > Signed-off-by: Corentin Labbe Applied.

Re: [PATCH] net: vxge: fix typo argumnet argument

2017-02-26 Thread David Miller
From: Corentin Labbe Date: Sat, 25 Feb 2017 21:08:57 +0100 > This commit fix the typo argumnet/argument > > Signed-off-by: Corentin Labbe Applied.

Re: [PATCH] net: s2io: fix typo argumnet argument

2017-02-26 Thread David Miller
From: Corentin Labbe Date: Sat, 25 Feb 2017 21:12:41 +0100 > This commit fix the typo argumnet/argument > > Signed-off-by: Corentin Labbe Applied.

Re: [PATCH] net: vxge: fix typo argumnet argument

2017-02-26 Thread David Miller
From: Corentin Labbe Date: Sat, 25 Feb 2017 21:08:57 +0100 > This commit fix the typo argumnet/argument > > Signed-off-by: Corentin Labbe Applied.

[PATCH v2 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-02-26 Thread matthew . gerlach
From: Matthew Gerlach Adding the core functions necessary for a fpga-mgr driver for the Altera Partial IP component. It is intended for these functions to be used by the various bus implementations like the platform bus or the PCIe bus. Signed-off-by: Matthew

[PATCH v2 2/4] fpga pr ip: Core driver support for Altera Partial Reconfiguration IP.

2017-02-26 Thread matthew . gerlach
From: Matthew Gerlach Adding the core functions necessary for a fpga-mgr driver for the Altera Partial IP component. It is intended for these functions to be used by the various bus implementations like the platform bus or the PCIe bus. Signed-off-by: Matthew Gerlach --- drivers/fpga/Kconfig

[PATCH v2 0/4] Altera Partial Reconfiguration IP

2017-02-26 Thread matthew . gerlach
From: Matthew Gerlach This set of patches implements a fpga-mgr driver for the Altera Partial Reconfiguration IP. The driver depends on a patch from Alan Tull that adds a config complete timeout. The driver code itself is divided into core functions and

[PATCH v2 0/4] Altera Partial Reconfiguration IP

2017-02-26 Thread matthew . gerlach
From: Matthew Gerlach This set of patches implements a fpga-mgr driver for the Altera Partial Reconfiguration IP. The driver depends on a patch from Alan Tull that adds a config complete timeout. The driver code itself is divided into core functions and functions to implement a platform

[PATCH v2 1/4] fpga: add config complete timeout

2017-02-26 Thread matthew . gerlach
From: Alan Tull Adding timeout for maximum allowed time for FPGA to go to operating mode after a FPGA region has been programmed. Signed-off-by: Alan Tull --- drivers/fpga/fpga-region.c| 3 +++ include/linux/fpga/fpga-mgr.h | 3 +++

[PATCH v2 1/4] fpga: add config complete timeout

2017-02-26 Thread matthew . gerlach
From: Alan Tull Adding timeout for maximum allowed time for FPGA to go to operating mode after a FPGA region has been programmed. Signed-off-by: Alan Tull --- drivers/fpga/fpga-region.c| 3 +++ include/linux/fpga/fpga-mgr.h | 3 +++ 2 files changed, 6 insertions(+) diff --git

Re: [Outreachy kernel] [PATCH v4] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Error was reported by checkpatch.pl as "Avoid multiple line > dereference".And If there is boolean operator then it is > fixed by Splitting line at boolean operator to satisfy coding > style. Please improve the commit message. Capital letters should

Re: [Outreachy kernel] [PATCH v4] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Julia Lawall
On Sun, 26 Feb 2017, Arushi Singhal wrote: > Error was reported by checkpatch.pl as "Avoid multiple line > dereference".And If there is boolean operator then it is > fixed by Splitting line at boolean operator to satisfy coding > style. Please improve the commit message. Capital letters should

[PATCH v2 4/4] fpga pr ip: Platform driver for Altera Partial Reconfiguration IP.

2017-02-26 Thread matthew . gerlach
From: Matthew Gerlach This adds a platform bus driver for a fpga-mgr driver that uses the Altera Partial Reconfiguration IP component. v2: s/altr,pr-ip-core/altr,pr-ip/ Signed-off-by: Matthew Gerlach ---

[PATCH v2 4/4] fpga pr ip: Platform driver for Altera Partial Reconfiguration IP.

2017-02-26 Thread matthew . gerlach
From: Matthew Gerlach This adds a platform bus driver for a fpga-mgr driver that uses the Altera Partial Reconfiguration IP component. v2: s/altr,pr-ip-core/altr,pr-ip/ Signed-off-by: Matthew Gerlach --- drivers/fpga/Kconfig | 7

[PATCH v2 3/4] fpga dt: bindings for Altera Partial Reconfiguration IP.

2017-02-26 Thread matthew . gerlach
From: Matthew Gerlach Device Tree bindings for Altera Partial Reconfiguration IP. v2: s/Reconfiguraion/Reconfiguration/ Signed-off-by: Matthew Gerlach ---

[PATCH v2 3/4] fpga dt: bindings for Altera Partial Reconfiguration IP.

2017-02-26 Thread matthew . gerlach
From: Matthew Gerlach Device Tree bindings for Altera Partial Reconfiguration IP. v2: s/Reconfiguraion/Reconfiguration/ Signed-off-by: Matthew Gerlach --- Documentation/devicetree/bindings/fpga/altera-pr-ip.txt | 12 1 file changed, 12 insertions(+) create

Re: [PATCH] lib: fix spelling mistake: "actualy" -> "actually"

2017-02-26 Thread David Miller
From: Colin King Date: Sun, 26 Feb 2017 12:10:12 + > From: Colin Ian King > > trivial fix to spelling mistake in pr_err message > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH] lib: fix spelling mistake: "actualy" -> "actually"

2017-02-26 Thread David Miller
From: Colin King Date: Sun, 26 Feb 2017 12:10:12 + > From: Colin Ian King > > trivial fix to spelling mistake in pr_err message > > Signed-off-by: Colin Ian King Applied.

[PATCH v4] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Arushi Singhal
Error was reported by checkpatch.pl as "Avoid multiple line dereference".And If there is boolean operator then it is fixed by Splitting line at boolean operator to satisfy coding style. Signed-off-by: Arushi Singhal --- changes in v4 - changes done such that no

[PATCH v4] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Arushi Singhal
Error was reported by checkpatch.pl as "Avoid multiple line dereference".And If there is boolean operator then it is fixed by Splitting line at boolean operator to satisfy coding style. Signed-off-by: Arushi Singhal --- changes in v4 - changes done such that no other errors can generate. -

Re: [PATCH v3] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Joe Perches
On Sun, 2017-02-26 at 21:23 +0530, Arushi Singhal wrote: > Error was reported by checkpatch.pl as "Avoid multiple line > dereference".And If there is boolean operator then it is > fixed by Splitting line at boolean operator to satisfy coding > style. [] > diff --git

Re: [PATCH v3] staging: xgifb: correct the multiple line dereference

2017-02-26 Thread Joe Perches
On Sun, 2017-02-26 at 21:23 +0530, Arushi Singhal wrote: > Error was reported by checkpatch.pl as "Avoid multiple line > dereference".And If there is boolean operator then it is > fixed by Splitting line at boolean operator to satisfy coding > style. [] > diff --git

[PATCH v2] staging: ks7010: remove code in comments.

2017-02-26 Thread Arushi Singhal
Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal

[PATCH v2] staging: ks7010: remove code in comments.

2017-02-26 Thread Arushi Singhal
Commenting Code Is a Bad Idea. Comments are their to explain the code and how the code achieves its goal and as codes in the comments does not explain what the code is doing so there is no use of commenting them. So in this patch codes in the comments are removed. Signed-off-by: Arushi Singhal

Re: [PATCH v3 2/2] iio: stm32 trigger: Implement parent trigger feature

2017-02-26 Thread Benjamin Gaignard
2017-02-26 15:59 GMT+01:00 Benjamin Gaignard : > 2017-02-25 18:53 GMT+01:00 Jonathan Cameron : >> On 24/02/17 14:48, Benjamin Gaignard wrote: >>> Add validate_trigger function in iio_trigger_ops and >>> dev_attr_parent_trigger into trigger attribute

Re: [PATCH v3 2/2] iio: stm32 trigger: Implement parent trigger feature

2017-02-26 Thread Benjamin Gaignard
2017-02-26 15:59 GMT+01:00 Benjamin Gaignard : > 2017-02-25 18:53 GMT+01:00 Jonathan Cameron : >> On 24/02/17 14:48, Benjamin Gaignard wrote: >>> Add validate_trigger function in iio_trigger_ops and >>> dev_attr_parent_trigger into trigger attribute group to be able >>> to accept triggers as

Re: [PATCH 4.10 00/21] 4.10.1-stable review

2017-02-26 Thread Greg Kroah-Hartman
On Fri, Feb 24, 2017 at 10:09:22AM -0800, kernelci.org bot wrote: > stable-rc boot: 191 boots: 2 failed, 181 passed with 8 offline > (v4.10-22-g0b3f6c4ba776) > > Full Boot Summary: > https://kernelci.org/boot/all/job/stable-rc/kernel/v4.10-22-g0b3f6c4ba776/ > Full Build Summary: >

Re: [PATCH 4.10 00/21] 4.10.1-stable review

2017-02-26 Thread Greg Kroah-Hartman
On Fri, Feb 24, 2017 at 11:20:10AM -0700, Shuah Khan wrote: > On 02/24/2017 01:39 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.10.1 release. > > There are 21 patches in this series, all will be posted as a response > > to this one. If anyone has any

Re: [PATCH 4.10 00/21] 4.10.1-stable review

2017-02-26 Thread Greg Kroah-Hartman
On Fri, Feb 24, 2017 at 08:24:17PM -0800, Guenter Roeck wrote: > On 02/24/2017 12:39 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.10.1 release. > > There are 21 patches in this series, all will be posted as a response > > to this one. If anyone has any

Re: [PATCH 4.10 00/21] 4.10.1-stable review

2017-02-26 Thread Greg Kroah-Hartman
On Fri, Feb 24, 2017 at 10:09:22AM -0800, kernelci.org bot wrote: > stable-rc boot: 191 boots: 2 failed, 181 passed with 8 offline > (v4.10-22-g0b3f6c4ba776) > > Full Boot Summary: > https://kernelci.org/boot/all/job/stable-rc/kernel/v4.10-22-g0b3f6c4ba776/ > Full Build Summary: >

Re: [PATCH 4.10 00/21] 4.10.1-stable review

2017-02-26 Thread Greg Kroah-Hartman
On Fri, Feb 24, 2017 at 11:20:10AM -0700, Shuah Khan wrote: > On 02/24/2017 01:39 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.10.1 release. > > There are 21 patches in this series, all will be posted as a response > > to this one. If anyone has any

Re: [PATCH 4.10 00/21] 4.10.1-stable review

2017-02-26 Thread Greg Kroah-Hartman
On Fri, Feb 24, 2017 at 08:24:17PM -0800, Guenter Roeck wrote: > On 02/24/2017 12:39 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.10.1 release. > > There are 21 patches in this series, all will be posted as a response > > to this one. If anyone has any

<    1   2   3   4   5   6   >