Re: [PATCH 4/5] zram: remove zram_meta structure

2017-04-03 Thread Sergey Senozhatsky
On (04/04/17 14:40), Minchan Kim wrote: > > [..] > > > -struct zram_meta { > > > +struct zram { > > > struct zram_table_entry *table; > > > struct zs_pool *mem_pool; > > > -}; > > > - > > > -struct zram { > > > - struct zram_meta *meta; > > > struct zcomp *comp; > > > struct gendisk *disk;

Re: [PATCH 4/5] zram: remove zram_meta structure

2017-04-03 Thread Sergey Senozhatsky
On (04/04/17 14:40), Minchan Kim wrote: > > [..] > > > -struct zram_meta { > > > +struct zram { > > > struct zram_table_entry *table; > > > struct zs_pool *mem_pool; > > > -}; > > > - > > > -struct zram { > > > - struct zram_meta *meta; > > > struct zcomp *comp; > > > struct gendisk *disk;

[PATCH] net: ibm: emac: remove unused sysrq handler for 'c' key

2017-04-03 Thread Eric Biggers
From: Eric Biggers Since commit d6580a9f1523 ("kexec: sysrq: simplify sysrq-c handler"), the sysrq handler for the 'c' key has been sysrq_crash_op. Debugging code in the ibm_emac driver also tries to register a handler for the 'c' key, but this has no effect because

[PATCH] net: ibm: emac: remove unused sysrq handler for 'c' key

2017-04-03 Thread Eric Biggers
From: Eric Biggers Since commit d6580a9f1523 ("kexec: sysrq: simplify sysrq-c handler"), the sysrq handler for the 'c' key has been sysrq_crash_op. Debugging code in the ibm_emac driver also tries to register a handler for the 'c' key, but this has no effect because register_sysrq_key() doesn't

Re: [PATCH 2/3] pwm: pwm-samsung: fix suspend/resume support

2017-04-03 Thread kbuild test robot
Hi Bartlomiej, [auto build test ERROR on hwmon/hwmon-next] [also build test ERROR on v4.11-rc5 next-20170403] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Bartlomiej-Zolnierkiewicz/pwm-pwm

Re: [PATCH 2/3] pwm: pwm-samsung: fix suspend/resume support

2017-04-03 Thread kbuild test robot
Hi Bartlomiej, [auto build test ERROR on hwmon/hwmon-next] [also build test ERROR on v4.11-rc5 next-20170403] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Bartlomiej-Zolnierkiewicz/pwm-pwm

Re: [PATCH 4/5] zram: remove zram_meta structure

2017-04-03 Thread Minchan Kim
On Tue, Apr 04, 2017 at 11:31:15AM +0900, Sergey Senozhatsky wrote: < snip > > > [..] > > -struct zram_meta { > > +struct zram { > > struct zram_table_entry *table; > > struct zs_pool *mem_pool; > > -}; > > - > > -struct zram { > > - struct zram_meta *meta; > > struct zcomp *comp;

Re: [PATCH 4/5] zram: remove zram_meta structure

2017-04-03 Thread Minchan Kim
On Tue, Apr 04, 2017 at 11:31:15AM +0900, Sergey Senozhatsky wrote: < snip > > > [..] > > -struct zram_meta { > > +struct zram { > > struct zram_table_entry *table; > > struct zs_pool *mem_pool; > > -}; > > - > > -struct zram { > > - struct zram_meta *meta; > > struct zcomp *comp;

Re: [PATCH v2 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [PATCH v2 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-04-03 Thread Wu Hao
On Mon, Apr 03, 2017 at 03:26:14PM -0500, Alan Tull wrote: > On Fri, Mar 31, 2017 at 3:50 AM, Wu Hao wrote: > > On Fri, Mar 31, 2017 at 12:11:12PM +0800, Xiao Guangrong wrote: > >> On 31/03/2017 4:30 AM, Alan Tull wrote: > >> >On Thu, Mar 30, 2017 at 7:08 AM, Wu Hao

Re: [PATCH 11/16] fpga: intel: fme: add partial reconfiguration sub feature support

2017-04-03 Thread Wu Hao
On Mon, Apr 03, 2017 at 03:26:14PM -0500, Alan Tull wrote: > On Fri, Mar 31, 2017 at 3:50 AM, Wu Hao wrote: > > On Fri, Mar 31, 2017 at 12:11:12PM +0800, Xiao Guangrong wrote: > >> On 31/03/2017 4:30 AM, Alan Tull wrote: > >> >On Thu, Mar 30, 2017 at 7:08 AM, Wu Hao wrote: > >> >>From: Kang

Re: [PATCH 01/16] docs: fpga: add a document for Intel FPGA driver overview

2017-04-03 Thread Wu Hao
On Mon, Apr 03, 2017 at 03:44:17PM -0500, Alan Tull wrote: > On Sun, Apr 2, 2017 at 9:41 AM, Moritz Fischer wrote: > > On Sat, Apr 01, 2017 at 07:16:19PM +0800, Wu Hao wrote: > >> On Fri, Mar 31, 2017 at 01:38:06PM -0500, Alan Tull wrote: > >> > On Fri, Mar 31, 2017 at 1:24 PM,

Re: [PATCH 01/16] docs: fpga: add a document for Intel FPGA driver overview

2017-04-03 Thread Wu Hao
On Mon, Apr 03, 2017 at 03:44:17PM -0500, Alan Tull wrote: > On Sun, Apr 2, 2017 at 9:41 AM, Moritz Fischer wrote: > > On Sat, Apr 01, 2017 at 07:16:19PM +0800, Wu Hao wrote: > >> On Fri, Mar 31, 2017 at 01:38:06PM -0500, Alan Tull wrote: > >> > On Fri, Mar 31, 2017 at 1:24 PM, > >> > wrote: >

[PATCH] usb: dwc3: of-simple: fix noderef.cocci warnings

2017-04-03 Thread kbuild test robot
drivers/usb/dwc3/dwc3-of-simple.c:53:43-49: ERROR: application of sizeof to pointer sizeof when applied to a pointer typed expression gives the size of the pointer Generated by: scripts/coccinelle/misc/noderef.cocci CC: Vivek Gautam Signed-off-by: Fengguang Wu

[PATCH] usb: dwc3: of-simple: fix noderef.cocci warnings

2017-04-03 Thread kbuild test robot
drivers/usb/dwc3/dwc3-of-simple.c:53:43-49: ERROR: application of sizeof to pointer sizeof when applied to a pointer typed expression gives the size of the pointer Generated by: scripts/coccinelle/misc/noderef.cocci CC: Vivek Gautam Signed-off-by: Fengguang Wu --- dwc3-of-simple.c |2

Re: [PATCH v2 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [PATCH v2 3/4] usb: dwc3: of-simple: Add support to get resets for the device

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [PATCH 01/16] docs: fpga: add a document for Intel FPGA driver overview

2017-04-03 Thread Wu Hao
On Sun, Apr 02, 2017 at 07:41:46AM -0700, Moritz Fischer wrote: > On Sat, Apr 01, 2017 at 07:16:19PM +0800, Wu Hao wrote: > > On Fri, Mar 31, 2017 at 01:38:06PM -0500, Alan Tull wrote: > > > On Fri, Mar 31, 2017 at 1:24 PM, wrote: > > > > > > > > > > > > On Thu,

Re: [PATCH 01/16] docs: fpga: add a document for Intel FPGA driver overview

2017-04-03 Thread Wu Hao
On Sun, Apr 02, 2017 at 07:41:46AM -0700, Moritz Fischer wrote: > On Sat, Apr 01, 2017 at 07:16:19PM +0800, Wu Hao wrote: > > On Fri, Mar 31, 2017 at 01:38:06PM -0500, Alan Tull wrote: > > > On Fri, Mar 31, 2017 at 1:24 PM, wrote: > > > > > > > > > > > > On Thu, 30 Mar 2017, Wu Hao wrote: > > >

[PATCH] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff

2017-04-03 Thread Anshuman Khandual
The commit 091d0d55b286 ("shm: fix null pointer deref when userspace specifies invalid hugepage size") had replaced MAP_HUGE_MASK with SHM_HUGE_MASK. Though both of them contain the same numeric value of 0x3f, MAP_HUGE_MASK flag sounds more appropriate than the other one in the context. Hence

[PATCH] mm/mmap: Replace SHM_HUGE_MASK with MAP_HUGE_MASK inside mmap_pgoff

2017-04-03 Thread Anshuman Khandual
The commit 091d0d55b286 ("shm: fix null pointer deref when userspace specifies invalid hugepage size") had replaced MAP_HUGE_MASK with SHM_HUGE_MASK. Though both of them contain the same numeric value of 0x3f, MAP_HUGE_MASK flag sounds more appropriate than the other one in the context. Hence

Re: [PATCH 1/5] zram: handle multiple pages attached bio's bvec

2017-04-03 Thread Sergey Senozhatsky
On (04/03/17 14:17), Minchan Kim wrote: > Johannes Thumshirn reported system goes the panic when using NVMe over > Fabrics loopback target with zram. > > The reason is zram expects each bvec in bio contains a single page > but nvme can attach a huge bulk of pages attached to the bio's bvec > so

Re: [PATCH 1/5] zram: handle multiple pages attached bio's bvec

2017-04-03 Thread Sergey Senozhatsky
On (04/03/17 14:17), Minchan Kim wrote: > Johannes Thumshirn reported system goes the panic when using NVMe over > Fabrics loopback target with zram. > > The reason is zram expects each bvec in bio contains a single page > but nvme can attach a huge bulk of pages attached to the bio's bvec > so

Re: [PATCH 2/2] extcon: Add new extcon_register_notifier_all() to monitor all external connectors

2017-04-03 Thread Chanwoo Choi
Hi, On 2017년 04월 03일 20:14, Hans de Goede wrote: > Hi, > > On 03-04-17 09:24, Chanwoo Choi wrote: >> Hi, >> >> On 2017년 03월 30일 23:58, Hans de Goede wrote: >>> Hi, >>> >>> On 30-03-17 11:20, Chanwoo Choi wrote: On 2017년 03월 30일 18:04, Hans de Goede wrote: > > > > Also this should be

Re: [PATCH 2/2] extcon: Add new extcon_register_notifier_all() to monitor all external connectors

2017-04-03 Thread Chanwoo Choi
Hi, On 2017년 04월 03일 20:14, Hans de Goede wrote: > Hi, > > On 03-04-17 09:24, Chanwoo Choi wrote: >> Hi, >> >> On 2017년 03월 30일 23:58, Hans de Goede wrote: >>> Hi, >>> >>> On 30-03-17 11:20, Chanwoo Choi wrote: On 2017년 03월 30일 18:04, Hans de Goede wrote: > > > > Also this should be

Re: [PATCH 4/5] zram: remove zram_meta structure

2017-04-03 Thread Minchan Kim
On Tue, Apr 04, 2017 at 11:31:15AM +0900, Sergey Senozhatsky wrote: > On (04/03/17 14:17), Minchan Kim wrote: > [..] > > -static struct zram_meta *zram_meta_alloc(char *pool_name, u64 disksize) > > +static bool zram_meta_alloc(struct zram *zram, u64 disksize) > > { > > size_t num_pages; > > -

Re: [PATCH 4/5] zram: remove zram_meta structure

2017-04-03 Thread Minchan Kim
On Tue, Apr 04, 2017 at 11:31:15AM +0900, Sergey Senozhatsky wrote: > On (04/03/17 14:17), Minchan Kim wrote: > [..] > > -static struct zram_meta *zram_meta_alloc(char *pool_name, u64 disksize) > > +static bool zram_meta_alloc(struct zram *zram, u64 disksize) > > { > > size_t num_pages; > > -

[PATCH v2 1/2] usb: gadget: udc: avoid use of freed pointer

2017-04-03 Thread Gustavo A. R. Silva
Rewrite udc_free_dma_chain() function to avoid use of pointer after free. Addresses-Coverity-ID: 1091172 Acked-by: Michal Nazarewicz Reviewed-by: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2:

[PATCH v2 1/2] usb: gadget: udc: avoid use of freed pointer

2017-04-03 Thread Gustavo A. R. Silva
Rewrite udc_free_dma_chain() function to avoid use of pointer after free. Addresses-Coverity-ID: 1091172 Acked-by: Michal Nazarewicz Reviewed-by: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Remove 'td->next = 0x00' inside for loop. Remove unnecessary pointer

Re: [PATCH 2/5] zram: partial IO refactoring

2017-04-03 Thread Minchan Kim
Hi Sergey, On Tue, Apr 04, 2017 at 11:17:06AM +0900, Sergey Senozhatsky wrote: > Hello, > > On (04/03/17 14:17), Minchan Kim wrote: > > +static bool zram_special_page_read(struct zram *zram, u32 index, > > + struct page *page, > > + unsigned

Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw bit_spin_lock op

2017-04-03 Thread Minchan Kim
On Tue, Apr 04, 2017 at 11:18:51AM +0900, Sergey Senozhatsky wrote: > On (04/03/17 14:17), Minchan Kim wrote: > > With this clean-up phase, I want to use zram's wrapper function > > to lock table access which is more consistent with other zram's > > functions. > > > > Signed-off-by: Minchan Kim

Re: [PATCH 2/5] zram: partial IO refactoring

2017-04-03 Thread Minchan Kim
Hi Sergey, On Tue, Apr 04, 2017 at 11:17:06AM +0900, Sergey Senozhatsky wrote: > Hello, > > On (04/03/17 14:17), Minchan Kim wrote: > > +static bool zram_special_page_read(struct zram *zram, u32 index, > > + struct page *page, > > + unsigned

Re: [PATCH 3/5] zram: use zram_slot_lock instead of raw bit_spin_lock op

2017-04-03 Thread Minchan Kim
On Tue, Apr 04, 2017 at 11:18:51AM +0900, Sergey Senozhatsky wrote: > On (04/03/17 14:17), Minchan Kim wrote: > > With this clean-up phase, I want to use zram's wrapper function > > to lock table access which is more consistent with other zram's > > functions. > > > > Signed-off-by: Minchan Kim

FWD: gathered list of available stocks

2017-04-03 Thread rcde sai
Hi I was browsing thru website and gathered list of available stocks. I have chosen three of them and I have attached all three of them with a specified specs. Payment will be semi-annually. Please do let me know if we can get this going A.S.A.P. Thank You Misu Del Copo Dei Capi

FWD: gathered list of available stocks

2017-04-03 Thread rcde sai
Hi I was browsing thru website and gathered list of available stocks. I have chosen three of them and I have attached all three of them with a specified specs. Payment will be semi-annually. Please do let me know if we can get this going A.S.A.P. Thank You Misu Del Copo Dei Capi

Re: [PATCH 5/5] zram: introduce zram data accessor

2017-04-03 Thread Sergey Senozhatsky
On (04/03/17 14:17), Minchan Kim wrote: > With element, sometime I got confused handle and element access. > It might be my bad but I think it's time to introduce accessor > to prevent future idiot like me. > This patch is just clean-up patch so it shouldn't change any > behavior. > >

Re: [PATCH 5/5] zram: introduce zram data accessor

2017-04-03 Thread Sergey Senozhatsky
On (04/03/17 14:17), Minchan Kim wrote: > With element, sometime I got confused handle and element access. > It might be my bad but I think it's time to introduce accessor > to prevent future idiot like me. > This patch is just clean-up patch so it shouldn't change any > behavior. > >

[PATCH v2 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype

2017-04-03 Thread Gustavo A. R. Silva
Remove unnecessary variable and update function prototype. Acked-by: Michal Nazarewicz Reviewed-by: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2: None. drivers/usb/gadget/udc/amd5536udc.c | 5

[PATCH v2 2/2] usb: gadget: udc: remove unnecessary variable and update function prototype

2017-04-03 Thread Gustavo A. R. Silva
Remove unnecessary variable and update function prototype. Acked-by: Michal Nazarewicz Reviewed-by: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2: None. drivers/usb/gadget/udc/amd5536udc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [PATCH v6 06/11] powerpc/perf: IMC pmu cpumask and cpu hotplug support

2017-04-03 Thread Daniel Axtens
Madhavan Srinivasan writes: > From: Hemant Kumar > > Adds cpumask attribute to be used by each IMC pmu. Only one cpu (any > online CPU) from each chip for nest PMUs is designated to read counters. > > On CPU hotplug, dying CPU is checked to

Re: [PATCH v6 06/11] powerpc/perf: IMC pmu cpumask and cpu hotplug support

2017-04-03 Thread Daniel Axtens
Madhavan Srinivasan writes: > From: Hemant Kumar > > Adds cpumask attribute to be used by each IMC pmu. Only one cpu (any > online CPU) from each chip for nest PMUs is designated to read counters. > > On CPU hotplug, dying CPU is checked to see whether it is one of the > designated cpus, if

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread Vivek Gautam
On 04/04/2017 09:44 AM, kbuild test robot wrote: Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread Vivek Gautam
On 04/04/2017 09:44 AM, kbuild test robot wrote: Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

Re: [PATCH v2 1/4] reset: Add API to count number of reset available with device

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [PATCH v2 1/4] reset: Add API to count number of reset available with device

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test ERROR on balbi-usb/next] [also build test ERROR on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [PATCH v2 2/4] reset: Add APIs to manage array of resets

2017-04-03 Thread kbuild test robot
Hi Vivek, [auto build test WARNING on balbi-usb/next] [also build test WARNING on v4.11-rc5 next-20170403] [cannot apply to pza/reset/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Vivek

Re: [RFC][PATCH] spin loop arch primitives for busy waiting

2017-04-03 Thread Nicholas Piggin
On Tue, 4 Apr 2017 13:02:33 +1000 Nicholas Piggin wrote: > On Mon, 3 Apr 2017 17:43:05 -0700 > Linus Torvalds wrote: > > > But that depends on architectures having some pattern that we *can* > > abstract. Would some "begin/in-loop/end" pattern

Re: [RFC][PATCH] spin loop arch primitives for busy waiting

2017-04-03 Thread Nicholas Piggin
On Tue, 4 Apr 2017 13:02:33 +1000 Nicholas Piggin wrote: > On Mon, 3 Apr 2017 17:43:05 -0700 > Linus Torvalds wrote: > > > But that depends on architectures having some pattern that we *can* > > abstract. Would some "begin/in-loop/end" pattern like the above be > > sufficient? > > Yes.

Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues")

2017-04-03 Thread Mike Galbraith
On Mon, 2017-04-03 at 21:11 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 03, 2017 at 07:56:32PM +0200, Mike Galbraith wrote: > > On Mon, 2017-04-03 at 16:18 +0200, Christoph Hellwig wrote: > > > Mike, > > > > > > can you try the patch below? > > > > No more spinning kworker woes, but I still

Re: Random guest crashes since 5c34d002dcc7 ("virtio_pci: use shared interrupts for virtqueues")

2017-04-03 Thread Mike Galbraith
On Mon, 2017-04-03 at 21:11 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 03, 2017 at 07:56:32PM +0200, Mike Galbraith wrote: > > On Mon, 2017-04-03 at 16:18 +0200, Christoph Hellwig wrote: > > > Mike, > > > > > > can you try the patch below? > > > > No more spinning kworker woes, but I still

Re: [PATCH v6 05/11] powerpc/perf: Generic imc pmu event functions

2017-04-03 Thread Daniel Axtens
Hi, So a major complaint I have is that you're changing prototypes of functions from earlier patches. This makes my life a lot harder: I get my head around what a function is and does and then suddenly the prototype changes, the behaviour changes, and I have to re-evaluate everything I thought I

Re: [PATCH v6 05/11] powerpc/perf: Generic imc pmu event functions

2017-04-03 Thread Daniel Axtens
Hi, So a major complaint I have is that you're changing prototypes of functions from earlier patches. This makes my life a lot harder: I get my head around what a function is and does and then suddenly the prototype changes, the behaviour changes, and I have to re-evaluate everything I thought I

[PATCH v2 2/2] usb: misc: refactor code

2017-04-03 Thread Gustavo A. R. Silva
Code refactoring to make the flow easier to follow. Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Remove unfruitful changes in previous patch. Revert change to

[PATCH v2 2/2] usb: misc: refactor code

2017-04-03 Thread Gustavo A. R. Silva
Code refactoring to make the flow easier to follow. Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Remove unfruitful changes in previous patch. Revert change to comment. drivers/usb/misc/usbtest.c | 49

[PATCH v2 1/2] usb: misc: add missing continue in switch

2017-04-03 Thread Gustavo A. R. Silva
Add missing continue in switch. Addresses-Coverity-ID: 1248733 Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2: None. drivers/usb/misc/usbtest.c | 1 + 1 file changed,

[PATCH v2 1/2] usb: misc: add missing continue in switch

2017-04-03 Thread Gustavo A. R. Silva
Add missing continue in switch. Addresses-Coverity-ID: 1248733 Cc: Alan Stern Cc: Greg Kroah-Hartman Signed-off-by: Gustavo A. R. Silva --- Changes in v2: None. drivers/usb/misc/usbtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/misc/usbtest.c

[PATCH v3] regulator: hi655x: Correct dependency/boot failure

2017-04-03 Thread Jeremy Linton
The hi655x-regulator driver consumes a similarly named platform device. Adding that to the module device table, allows modprobe to locate this driver once the device is created. Without this the sd/mmc device fails to start, resulting in boot failures. Signed-off-by: Jeremy Linton

[PATCH v3] regulator: hi655x: Correct dependency/boot failure

2017-04-03 Thread Jeremy Linton
The hi655x-regulator driver consumes a similarly named platform device. Adding that to the module device table, allows modprobe to locate this driver once the device is created. Without this the sd/mmc device fails to start, resulting in boot failures. Signed-off-by: Jeremy Linton ---

Re: AMD IOMMU causing filesystem corruption

2017-04-03 Thread Samuel Sieb
On 04/03/2017 02:39 PM, Joerg Roedel wrote: You have a system based on the AMD Stoney platform, on which the PCI-ATS feature of the GPU is broken, as we recently found out. Can you please test whether the attached patch fixes the issue on your machine? Yes, that works, thank you! Now I'm

Re: AMD IOMMU causing filesystem corruption

2017-04-03 Thread Samuel Sieb
On 04/03/2017 02:39 PM, Joerg Roedel wrote: You have a system based on the AMD Stoney platform, on which the PCI-ATS feature of the GPU is broken, as we recently found out. Can you please test whether the attached patch fixes the issue on your machine? Yes, that works, thank you! Now I'm

Re: [PATCH v2 6/6] hpet: fix style issue about braces and alignment

2017-04-03 Thread Joe Perches
On Mon, 2017-04-03 at 14:15 +0200, Corentin Labbe wrote: > This patch fix all style issue for braces and alignment [] > diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c [] > @@ -255,9 +255,9 @@ static int hpet_open(struct inode *inode, struct file > *file) > > for (devp = NULL,

Re: [PATCH v2 6/6] hpet: fix style issue about braces and alignment

2017-04-03 Thread Joe Perches
On Mon, 2017-04-03 at 14:15 +0200, Corentin Labbe wrote: > This patch fix all style issue for braces and alignment [] > diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c [] > @@ -255,9 +255,9 @@ static int hpet_open(struct inode *inode, struct file > *file) > > for (devp = NULL,

[git pull] drm fixes for v4.11-rc6

2017-04-03 Thread Dave Airlie
Hi Linus, I'm going to be away for the latter part of this week, and early next week, so I probably won't get to dequeue any more fixes before -rc6, if anyone has any urgent fixes they can get Daniel's help and maybe send them to you direct, I don't know of anything that is that urgent, hopefully

[git pull] drm fixes for v4.11-rc6

2017-04-03 Thread Dave Airlie
Hi Linus, I'm going to be away for the latter part of this week, and early next week, so I probably won't get to dequeue any more fixes before -rc6, if anyone has any urgent fixes they can get Daniel's help and maybe send them to you direct, I don't know of anything that is that urgent, hopefully

linux-next: build failure after merge of the keys tree

2017-04-03 Thread Stephen Rothwell
he version from next-20170403 for today. -- Cheers, Stephen Rothwell

linux-next: build failure after merge of the keys tree

2017-04-03 Thread Stephen Rothwell
he version from next-20170403 for today. -- Cheers, Stephen Rothwell

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-04-03 Thread Tony Lindgren
Hi, * Kishon Vijay Abraham I [170330 04:51]: > On Monday 27 March 2017 08:35 PM, Tony Lindgren wrote: > > Seems this can be also done when implementing PM runtime handling. > > If you want some of these changes done for the initial patch, > > please let me know. > > I think it's

Re: [PATCHv2] phy: cpcap-usb: Add CPCAP PMIC USB support

2017-04-03 Thread Tony Lindgren
Hi, * Kishon Vijay Abraham I [170330 04:51]: > On Monday 27 March 2017 08:35 PM, Tony Lindgren wrote: > > Seems this can be also done when implementing PM runtime handling. > > If you want some of these changes done for the initial patch, > > please let me know. > > I think it's better we get

[PATCH 1/2] platform/x86: silead_dmi - do not treat all devices as i2c_clients

2017-04-03 Thread Dmitry Torokhov
I2C bus has both i2c clients and adapter devices, so we must be careful in notifier code and verify that we are actually dealing with an i2c client before using it as such. Fixes: cef9dd85acd7 ("platform/x86: add support for devices with Silead...") Signed-off-by: Dmitry Torokhov

[PATCH 1/2] platform/x86: silead_dmi - do not treat all devices as i2c_clients

2017-04-03 Thread Dmitry Torokhov
I2C bus has both i2c clients and adapter devices, so we must be careful in notifier code and verify that we are actually dealing with an i2c client before using it as such. Fixes: cef9dd85acd7 ("platform/x86: add support for devices with Silead...") Signed-off-by: Dmitry Torokhov ---

[PATCH 2/2] platform/x86: silead_dmi - abort early if DMI does not match

2017-04-03 Thread Dmitry Torokhov
There is no point in registering I2C bus notifier if DMI data does not match. Signed-off-by: Dmitry Torokhov --- drivers/platform/x86/silead_dmi.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git

[PATCH 2/2] platform/x86: silead_dmi - abort early if DMI does not match

2017-04-03 Thread Dmitry Torokhov
There is no point in registering I2C bus notifier if DMI data does not match. Signed-off-by: Dmitry Torokhov --- drivers/platform/x86/silead_dmi.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/platform/x86/silead_dmi.c

Re: [PATCH v5 4/6] watchdog: iTCO_wdt: cleanup set/unset no_reboot calls

2017-04-03 Thread Guenter Roeck
On 04/03/2017 05:24 PM, Kuppuswamy Sathyanarayanan wrote: Both iTCO_wdt_unset_NO_REBOOT_bit() and iTCO_wdt_unset_NO_REBOOT_bit() I think you mean s/set/unset/ once. functions has lot of common code between them. So merging these two functions would remove these unnecessary code duplications.

Re: [PATCH v5 4/6] watchdog: iTCO_wdt: cleanup set/unset no_reboot calls

2017-04-03 Thread Guenter Roeck
On 04/03/2017 05:24 PM, Kuppuswamy Sathyanarayanan wrote: Both iTCO_wdt_unset_NO_REBOOT_bit() and iTCO_wdt_unset_NO_REBOOT_bit() I think you mean s/set/unset/ once. functions has lot of common code between them. So merging these two functions would remove these unnecessary code duplications.

Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts

2017-04-03 Thread Tony Lindgren
* Lee Jones [170403 07:34]: > On Mon, 03 Apr 2017, Tony Lindgren wrote: > > > Hi, > > > > * Lee Jones [170403 03:23]: > > > On Wed, 22 Mar 2017, Tony Lindgren wrote: > > > > > > > On CPCAP we need to keep reading interrupts until there are no > > >

Re: [PATCH 2/4] mfd: cpcap: Use handle_reread flag for interrupts

2017-04-03 Thread Tony Lindgren
* Lee Jones [170403 07:34]: > On Mon, 03 Apr 2017, Tony Lindgren wrote: > > > Hi, > > > > * Lee Jones [170403 03:23]: > > > On Wed, 22 Mar 2017, Tony Lindgren wrote: > > > > > > > On CPCAP we need to keep reading interrupts until there are no > > > > more interrupts. Otherwise the PMIC

[PATCHv3 0/3] CPCAP PMIC IRQ fix and related changes

2017-04-03 Thread Tony Lindgren
Hi all, Here's v3 set of fixes to make CPCAP PMIC interrupts work reliably when used with multiple drivers. While working on the ADC, charger and USB PHY drivers I noticed that the PMIC interrupt to the SoC would eventually stop working. All these can wait for v4.12 merge window as these issues

[PATCHv3 0/3] CPCAP PMIC IRQ fix and related changes

2017-04-03 Thread Tony Lindgren
Hi all, Here's v3 set of fixes to make CPCAP PMIC interrupts work reliably when used with multiple drivers. While working on the ADC, charger and USB PHY drivers I noticed that the PMIC interrupt to the SoC would eventually stop working. All these can wait for v4.12 merge window as these issues

[PATCH 2/3] mfd: cpcap: Use ack_invert interrupts

2017-04-03 Thread Tony Lindgren
We should use ack_invert as the int_read_and_clear() in the Motorola kernel tree does "ireg_val & ~mreg_val" before writing to the mask register. Fixes: 56e1d40d3bea ("mfd: cpcap: Add minimal support") Cc: Charles Keepax Cc: Marcel Partap

[PATCH 2/3] mfd: cpcap: Use ack_invert interrupts

2017-04-03 Thread Tony Lindgren
We should use ack_invert as the int_read_and_clear() in the Motorola kernel tree does "ireg_val & ~mreg_val" before writing to the mask register. Fixes: 56e1d40d3bea ("mfd: cpcap: Add minimal support") Cc: Charles Keepax Cc: Marcel Partap Cc: Michael Scott Tested-by: Sebastian Reichel

[PATCH 1/3] mfd: cpcap: Fix interrupt to use level interrupt

2017-04-03 Thread Tony Lindgren
I made a mistake assuming the device tree configuration for interrupt triggering was somehow passed to the SPI device but it's not. In the Motorola Linux kernel tree CPCAP PMIC is configured as a rising edge triggered interrupt, but then then it's interrupt handler keeps looping until the GPIO

[PATCH 1/3] mfd: cpcap: Fix interrupt to use level interrupt

2017-04-03 Thread Tony Lindgren
I made a mistake assuming the device tree configuration for interrupt triggering was somehow passed to the SPI device but it's not. In the Motorola Linux kernel tree CPCAP PMIC is configured as a rising edge triggered interrupt, but then then it's interrupt handler keeps looping until the GPIO

[PATCH 3/3] mfd: cpcap: Fix bad use of IRQ sense register

2017-04-03 Thread Tony Lindgren
The cpcap INTS registers are for getting the value of the line, not for configuring the type. Fixes: 56e1d40d3bea ("mfd: cpcap: Add minimal support") Cc: Charles Keepax Cc: Marcel Partap Cc: Michael Scott Cc:

[PATCH 3/3] mfd: cpcap: Fix bad use of IRQ sense register

2017-04-03 Thread Tony Lindgren
The cpcap INTS registers are for getting the value of the line, not for configuring the type. Fixes: 56e1d40d3bea ("mfd: cpcap: Add minimal support") Cc: Charles Keepax Cc: Marcel Partap Cc: Michael Scott Cc: Sebastian Reichel Reviewed-By: Sebastian Reichel Tested-by: Sebastian Reichel

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-03 Thread Nikolaus Rath
Hi Ota, > -Support Alps HID I2C T4 Touchpad device. > -Laptop names that use this Touchpad:HP Zbook Studio, Elitebook Folio G1, > Elitebook 1030 G1, Elitebook 1040 G3 > > Signed-off-by: Masaki Ota > --- > drivers/hid/hid-alps.c | 500 >

Re: [PATCH 1/2] Alps HID I2C T4 device support

2017-04-03 Thread Nikolaus Rath
Hi Ota, > -Support Alps HID I2C T4 Touchpad device. > -Laptop names that use this Touchpad:HP Zbook Studio, Elitebook Folio G1, > Elitebook 1030 G1, Elitebook 1040 G3 > > Signed-off-by: Masaki Ota > --- > drivers/hid/hid-alps.c | 500 > +++-- >

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

2017-04-03 Thread John Stultz
On Mon, Apr 3, 2017 at 5:54 AM, Minas Harutyunyan wrote: > On 4/3/2017 9:23 AM, John Youn wrote: >> On 03/31/2017 04:04 PM, John Stultz wrote: >>> On Thu, Mar 2, 2017 at 12:00 PM, John Stultz wrote: Hey John, We've noticed that

Re: dwc2_hc_chhltd_intr_dma - ChHltd set errors?

2017-04-03 Thread John Stultz
On Mon, Apr 3, 2017 at 5:54 AM, Minas Harutyunyan wrote: > On 4/3/2017 9:23 AM, John Youn wrote: >> On 03/31/2017 04:04 PM, John Stultz wrote: >>> On Thu, Mar 2, 2017 at 12:00 PM, John Stultz wrote: Hey John, We've noticed that when using usb ethernet adapters on HiKey, we

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

2017-04-03 Thread NeilBrown
On Mon, Apr 03 2017, Jeff Layton wrote: > On Mon, 2017-04-03 at 12:16 -0700, Matthew Wilcox wrote: >> On Mon, Apr 03, 2017 at 01:47:37PM -0400, Jeff Layton wrote: >> > > I wonder whether it's even worth supporting both EIO and ENOSPC for a >> > > writeback problem. If I understand correctly, at

Re: [RFC PATCH 0/4] fs: introduce new writeback error tracking infrastructure and convert ext4 to use it

2017-04-03 Thread NeilBrown
On Mon, Apr 03 2017, Jeff Layton wrote: > On Mon, 2017-04-03 at 12:16 -0700, Matthew Wilcox wrote: >> On Mon, Apr 03, 2017 at 01:47:37PM -0400, Jeff Layton wrote: >> > > I wonder whether it's even worth supporting both EIO and ENOSPC for a >> > > writeback problem. If I understand correctly, at

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

2017-04-03 Thread Tony Lindgren
Hi, * Tony Lindgren [170328 10:13]: > * Mark Brown [170328 09:51]: > > On Tue, Mar 28, 2017 at 08:47:41AM -0700, Tony Lindgren wrote: > > > * Mark Brown [170328 08:21]: > > > > > > Right, my thinking here is that by pushing into genirq

Re: [PATCH 1/4] regmap: irq: Fix lost interrupts by introducing handle_reread

2017-04-03 Thread Tony Lindgren
Hi, * Tony Lindgren [170328 10:13]: > * Mark Brown [170328 09:51]: > > On Tue, Mar 28, 2017 at 08:47:41AM -0700, Tony Lindgren wrote: > > > * Mark Brown [170328 08:21]: > > > > > > Right, my thinking here is that by pushing into genirq we minimise the > > > > need even further since it'll

Re: [RFC][PATCH] spin loop arch primitives for busy waiting

2017-04-03 Thread Nicholas Piggin
On Mon, 3 Apr 2017 17:43:05 -0700 Linus Torvalds wrote: > On Mon, Apr 3, 2017 at 4:50 PM, Nicholas Piggin wrote: > > If you have any ideas, I'd be open to them. > > So the idea would be that maybe we can just make those things > explicit.

Re: [RFC][PATCH] spin loop arch primitives for busy waiting

2017-04-03 Thread Nicholas Piggin
On Mon, 3 Apr 2017 17:43:05 -0700 Linus Torvalds wrote: > On Mon, Apr 3, 2017 at 4:50 PM, Nicholas Piggin wrote: > > If you have any ideas, I'd be open to them. > > So the idea would be that maybe we can just make those things > explicit. IOW, instead of having that magical looping

[PATCH v5 3/5] dt-bindings: Add TI SCI PM Domains

2017-04-03 Thread Dave Gerlach
Add a generic power domain implementation, TI SCI PM Domains, that will hook into the genpd framework and allow the TI SCI protocol to control device power states. Also, provide macros representing each device index as understood by TI SCI to be used in the device node power-domain references.

[PATCH v5 0/5] ARM: K2G: Add support for TI-SCI Generic PM Domains

2017-04-03 Thread Dave Gerlach
Hi, This is v5 of the series to add support for TI-SCI Generic PM Domains with all ACKs in place and ready for Santosh to merge. Previous versions can be found here: v4: https://www.spinics.net/lists/arm-kernel/msg566778.html v3: https://www.spinics.net/lists/kernel/msg2413975.html v2:

  1   2   3   4   5   6   7   8   9   10   >