[PATCH 18/25] net: mvpp2: Rename a jump label in mvpp2_prs_double_vlan_add()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 13:03:49 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 7 +++ 1 file changed, 3

[PATCH 18/25] net: mvpp2: Rename a jump label in mvpp2_prs_double_vlan_add()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 13:03:49 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link()

2017-04-17 Thread Ralph Sennhauser
On Tue, 11 Apr 2017 18:04:50 +0300 Amir Goldstein wrote: > On Tue, Apr 11, 2017 at 1:50 PM, Richard Weinberger > wrote: > > Hi! > > > > Am 11.04.2017 um 12:20 schrieb Amir Goldstein: > >> On Thu, Apr 6, 2017 at 3:26 PM, Richard Weinberger > >>

Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link()

2017-04-17 Thread Ralph Sennhauser
On Tue, 11 Apr 2017 18:04:50 +0300 Amir Goldstein wrote: > On Tue, Apr 11, 2017 at 1:50 PM, Richard Weinberger > wrote: > > Hi! > > > > Am 11.04.2017 um 12:20 schrieb Amir Goldstein: > >> On Thu, Apr 6, 2017 at 3:26 PM, Richard Weinberger > >> wrote: > >>> Am 06.04.2017 um 14:09 schrieb

[PATCH 17/25] net: mvpp2: Rename a jump label in mvpp2_txq_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 12:58:33 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 5 ++--- 1 file changed, 2

[PATCH 17/25] net: mvpp2: Rename a jump label in mvpp2_txq_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 12:58:33 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 16/25] net: mvpp2: Rename a jump label in mvpp2_tx_frag_process()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 11:36:34 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 5 ++--- 1 file changed, 2

[PATCH 16/25] net: mvpp2: Rename a jump label in mvpp2_tx_frag_process()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 11:36:34 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH 15/25] net: mvpp2: Adjust three error messages

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 11:20:41 +0200 Use the word "failed" in the string for three function calls. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 6 +++--- 1 file changed, 3

[PATCH 15/25] net: mvpp2: Adjust three error messages

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 11:20:41 +0200 Use the word "failed" in the string for three function calls. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 14/25] net: mvpp2: Rename a jump label in two functions

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 11:10:47 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 16 +++- 1 file

[PATCH 14/25] net: mvpp2: Rename a jump label in two functions

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 11:10:47 +0200 Adjust jump labels according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/ethernet/marvell/mvpp2.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git

[PATCH 13/25] net: mvpp2: Fix a jump label position in mvpp2_rx()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 10:52:02 +0200 The script "checkpatch.pl" pointed out that labels should not be indented. Thus delete two horizontal tabs before the jump label "err_drop_frame" in the function "mvpp2_rx". Signed-off-by: Markus Elfring

[PATCH 13/25] net: mvpp2: Fix a jump label position in mvpp2_rx()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 10:52:02 +0200 The script "checkpatch.pl" pointed out that labels should not be indented. Thus delete two horizontal tabs before the jump label "err_drop_frame" in the function "mvpp2_rx". Signed-off-by: Markus Elfring ---

[PATCH 12/25] net: mvpp2: Improve a size determination in two functions

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 10:40:32 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding

[PATCH 12/25] net: mvpp2: Improve a size determination in two functions

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 10:40:32 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:

Re: [PATCH] mm: Add additional consistency check

2017-04-17 Thread Christoph Lameter
On Tue, 11 Apr 2017, Michal Hocko wrote: > On Tue 11-04-17 13:59:44, Cristopher Lameter wrote: > > On Tue, 11 Apr 2017, Michal Hocko wrote: > > > > > I didn't say anything like that. Hence the proposed patch which still > > > needs some more thinking and evaluation. > > > > This patch does not

Re: [PATCH] mm: Add additional consistency check

2017-04-17 Thread Christoph Lameter
On Tue, 11 Apr 2017, Michal Hocko wrote: > On Tue 11-04-17 13:59:44, Cristopher Lameter wrote: > > On Tue, 11 Apr 2017, Michal Hocko wrote: > > > > > I didn't say anything like that. Hence the proposed patch which still > > > needs some more thinking and evaluation. > > > > This patch does not

[PATCH 11/25] net: mvpp2: Improve 27 size determinations

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 10:30:29 +0200 Replace the specification of data structures by references to a local variable as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. Signed-off-by: Markus

[PATCH 11/25] net: mvpp2: Improve 27 size determinations

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 10:30:29 +0200 Replace the specification of data structures by references to a local variable as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. Signed-off-by: Markus Elfring ---

Re: [PATCH v2] bridge: ebtables: fix reception of frames DNAT-ed to bridge device

2017-04-17 Thread Linus Lüssing
On Tue, Mar 21, 2017 at 04:32:45PM -0700, Stephen Hemminger wrote: > On Tue, 21 Mar 2017 23:28:45 +0100 > Linus Lüssing wrote: > > > However, the IP code drops it in the beginning of ip_input.c/ip_rcv() > > as the dnat target did not update the skb->pkt_type. If after >

Re: [PATCH v2] bridge: ebtables: fix reception of frames DNAT-ed to bridge device

2017-04-17 Thread Linus Lüssing
On Tue, Mar 21, 2017 at 04:32:45PM -0700, Stephen Hemminger wrote: > On Tue, 21 Mar 2017 23:28:45 +0100 > Linus Lüssing wrote: > > > However, the IP code drops it in the beginning of ip_input.c/ip_rcv() > > as the dnat target did not update the skb->pkt_type. If after > > dnat'ing the packet is

[PATCH 10/25] net: mvpp2: Improve another size determination in mvpp2_prs_default_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 09:12:34 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

Re: copy_page() on a kmalloc-ed page with DEBUG_SLAB enabled (was "zram: do not use copy_page with non-page alinged address")

2017-04-17 Thread Christoph Lameter
On Mon, 17 Apr 2017, Sergey Senozhatsky wrote: > Minchan reported that doing copy_page() on a kmalloc(PAGE_SIZE) page > with DEBUG_SLAB enabled can cause a memory corruption (See below or > lkml.kernel.org/r/1492042622-12074-2-git-send-email-minc...@kernel.org ) Yes the alignment guarantees do

[PATCH 10/25] net: mvpp2: Improve another size determination in mvpp2_prs_default_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 09:12:34 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:

Re: copy_page() on a kmalloc-ed page with DEBUG_SLAB enabled (was "zram: do not use copy_page with non-page alinged address")

2017-04-17 Thread Christoph Lameter
On Mon, 17 Apr 2017, Sergey Senozhatsky wrote: > Minchan reported that doing copy_page() on a kmalloc(PAGE_SIZE) page > with DEBUG_SLAB enabled can cause a memory corruption (See below or > lkml.kernel.org/r/1492042622-12074-2-git-send-email-minc...@kernel.org ) Yes the alignment guarantees do

[PATCH 09/25] net: mvpp2: Improve another size determination in mvpp2_bm_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 09:06:33 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 09/25] net: mvpp2: Improve another size determination in mvpp2_bm_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 09:06:33 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:

[PATCH 08/25] net: mvpp2: Improve another size determination in mvpp2_port_probe()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:55:42 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 08/25] net: mvpp2: Improve another size determination in mvpp2_port_probe()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:55:42 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:

Re: [PATCH v2 08/17] fs: retrofit old error reporting API onto new infrastructure

2017-04-17 Thread Jeff Layton
On Thu, 2017-04-13 at 08:14 +1000, NeilBrown wrote: > On Wed, Apr 12 2017, Jeff Layton wrote: > > > Now that we have a better way to store and report errors that occur > > during writeback, we need to convert the existing codebase to use it. We > > could just adapt all of the filesystem code and

[PATCH 07/25] net: mvpp2: Improve another size determination in mvpp2_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:48:23 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

Re: [PATCH v2 08/17] fs: retrofit old error reporting API onto new infrastructure

2017-04-17 Thread Jeff Layton
On Thu, 2017-04-13 at 08:14 +1000, NeilBrown wrote: > On Wed, Apr 12 2017, Jeff Layton wrote: > > > Now that we have a better way to store and report errors that occur > > during writeback, we need to convert the existing codebase to use it. We > > could just adapt all of the filesystem code and

[PATCH 07/25] net: mvpp2: Improve another size determination in mvpp2_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:48:23 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:

[PATCH 06/25] net: mvpp2: Improve two size determinations in mvpp2_probe()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:38:32 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding

[PATCH 06/25] net: mvpp2: Improve two size determinations in mvpp2_probe()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:38:32 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:

[PATCH 05/25] net: mvpp2: Use kmalloc_array() in mvpp2_txq_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:09:07 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was

[PATCH 05/25] net: mvpp2: Use kmalloc_array() in mvpp2_txq_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 08:09:07 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle

[PATCH 04/25] net: mvneta: Adjust six checks for null pointers

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 22:45:33 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus

[PATCH 04/25] net: mvneta: Adjust six checks for null pointers

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 22:45:33 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code

[PATCH 03/25] net: mvneta: Use kmalloc_array() in mvneta_txq_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 22:11:22 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected

[PATCH 03/25] net: mvneta: Use kmalloc_array() in mvneta_txq_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 22:11:22 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle

[PATCH 02/25] net: mvneta: Improve two size determinations in mvneta_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 21:45:38 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding

[PATCH 02/25] net: mvneta: Improve two size determinations in mvneta_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 21:45:38 +0200 Replace the specification of two data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by:

[PATCH 01/25] net: mvneta: Use devm_kmalloc_array() in mvneta_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 21:23:19 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kmalloc_array". This issue

[PATCH 01/25] net: mvneta: Use devm_kmalloc_array() in mvneta_init()

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 16 Apr 2017 21:23:19 +0200 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "devm_kmalloc_array". This issue was detected by using the

[PATCH 1/2] component: remove struct master from the header

2017-04-17 Thread Helen Koike
struct master is not necessary in the header file, it is a private struct only used in component.c Signed-off-by: Helen Koike --- include/linux/component.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/component.h b/include/linux/component.h index

[PATCH 2/2] component: add kernel-docs in the header

2017-04-17 Thread Helen Koike
Add kernel-doc style documentation in component.h to facilitate understanding the component system without reading the entire code. Signed-off-by: Helen Koike --- include/linux/component.h | 137 ++ 1 file changed, 127

[PATCH 2/2] component: add kernel-docs in the header

2017-04-17 Thread Helen Koike
Add kernel-doc style documentation in component.h to facilitate understanding the component system without reading the entire code. Signed-off-by: Helen Koike --- include/linux/component.h | 137 ++ 1 file changed, 127 insertions(+), 10 deletions(-)

[PATCH 1/2] component: remove struct master from the header

2017-04-17 Thread Helen Koike
struct master is not necessary in the header file, it is a private struct only used in component.c Signed-off-by: Helen Koike --- include/linux/component.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/linux/component.h b/include/linux/component.h index a559eeb..a15c094 100644

Re: [PATCH net-next,1/2] hv_netvsc: Fix the queue index computation in forwarding case

2017-04-17 Thread David Miller
From: Haiyang Zhang Date: Wed, 12 Apr 2017 11:35:05 -0700 > From: Haiyang Zhang > > If the outgoing skb has a RX queue mapping available, we use the queue > number directly, other than put it through Send Indirection Table. > >

Re: [PATCH net-next,1/2] hv_netvsc: Fix the queue index computation in forwarding case

2017-04-17 Thread David Miller
From: Haiyang Zhang Date: Wed, 12 Apr 2017 11:35:05 -0700 > From: Haiyang Zhang > > If the outgoing skb has a RX queue mapping available, we use the queue > number directly, other than put it through Send Indirection Table. > > Signed-off-by: Haiyang Zhang > Reviewed-by: Stephen Hemminger

Re: [PATCH net-next,2/2] hv_netvsc: Exclude non-TCP port numbers from vRSS hashing

2017-04-17 Thread David Miller
From: Haiyang Zhang Date: Wed, 12 Apr 2017 11:35:06 -0700 > From: Haiyang Zhang > > Azure hosts are not supporting non-TCP port numbers in vRSS hashing for > now. For example, UDP packet loss rate will be high if port numbers are > also

Re: [PATCH net-next,2/2] hv_netvsc: Exclude non-TCP port numbers from vRSS hashing

2017-04-17 Thread David Miller
From: Haiyang Zhang Date: Wed, 12 Apr 2017 11:35:06 -0700 > From: Haiyang Zhang > > Azure hosts are not supporting non-TCP port numbers in vRSS hashing for > now. For example, UDP packet loss rate will be high if port numbers are > also included in vRSS hash. > > So, we created this patch to

Re:staging:skein: skein_base.h, skein_block.h: move macros into appropriate header files

2017-04-17 Thread Karim Eshapa
On Mon, 17 Apr 2017 09:04:03 +0200, Greg KH wrote: > On Mon, Apr 17, 2017 at 02:47:34AM +0200, Karim Eshapa wrote: >> >> Macros more related to BLK operations. > > That doesn't make any sense to me, can you be more explicit?. skein_block.h contains all fn's related to processing on different

Re:staging:skein: skein_base.h, skein_block.h: move macros into appropriate header files

2017-04-17 Thread Karim Eshapa
On Mon, 17 Apr 2017 09:04:03 +0200, Greg KH wrote: > On Mon, Apr 17, 2017 at 02:47:34AM +0200, Karim Eshapa wrote: >> >> Macros more related to BLK operations. > > That doesn't make any sense to me, can you be more explicit?. skein_block.h contains all fn's related to processing on different

[PATCH 00/25] Ethernet-Marvell: Fine-tuning for several function implementations

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 16:44:32 +0200 Several update suggestions were taken into account from static source code analysis. Markus Elfring (25): Use devm_kmalloc_array() in mvneta_init() Improve two size determinations in mvneta_init()

[PATCH 00/25] Ethernet-Marvell: Fine-tuning for several function implementations

2017-04-17 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 17 Apr 2017 16:44:32 +0200 Several update suggestions were taken into account from static source code analysis. Markus Elfring (25): Use devm_kmalloc_array() in mvneta_init() Improve two size determinations in mvneta_init() Use kmalloc_array() in

Re: [PATCH net-next v2] net: dsa: isolate legacy code

2017-04-17 Thread David Miller
From: Vivien Didelot Date: Wed, 12 Apr 2017 12:45:03 -0400 > This patch moves as is the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. > > Signed-off-by: Vivien Didelot >

Re: [PATCH net-next v2] net: dsa: isolate legacy code

2017-04-17 Thread David Miller
From: Vivien Didelot Date: Wed, 12 Apr 2017 12:45:03 -0400 > This patch moves as is the legacy DSA code from dsa.c to legacy.c, > except the few shared symbols which remain in dsa.c. > > Signed-off-by: Vivien Didelot > --- > Changes in v2: > - drop CONFIG_NET_DSA_LEGACY so that legacy code

Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

2017-04-17 Thread David Miller
From: Wolfgang Bumiller Date: Wed, 12 Apr 2017 16:21:38 +0200 > Commit 1045ba77a ("net sched actions: Add support for user cookies") > added code to net/sched/act_api.c's tcf_action_init_1 using the `tb` > nlattr array unconditionally, while it was otherwise used as well

Re: [RFC PATCH linux 0/2] net sched actions: access to uninitialized data and error handling

2017-04-17 Thread David Miller
From: Wolfgang Bumiller Date: Wed, 12 Apr 2017 16:21:38 +0200 > Commit 1045ba77a ("net sched actions: Add support for user cookies") > added code to net/sched/act_api.c's tcf_action_init_1 using the `tb` > nlattr array unconditionally, while it was otherwise used as well as > initialized only

Re: [PATCH 1/3] mtd: sharpsl: add sharpslpart MTD partition parser

2017-04-17 Thread Boris Brezillon
Marek, Andrea, Before we even start discussing minor improvements (like coding style), I'd like to discuss the sharp FTL and partition table format, and decide whether we want to have such an old FTL included in the kernel. Actually, that's the very reason I asked Andrea to post his series as

Re: [PATCH 1/3] mtd: sharpsl: add sharpslpart MTD partition parser

2017-04-17 Thread Boris Brezillon
Marek, Andrea, Before we even start discussing minor improvements (like coding style), I'd like to discuss the sharp FTL and partition table format, and decide whether we want to have such an old FTL included in the kernel. Actually, that's the very reason I asked Andrea to post his series as

Re: [RFC 2/3] sched/topology: fix sched groups on NUMA machines with mesh topology

2017-04-17 Thread Lauro Venancio
On 04/14/2017 01:58 PM, Peter Zijlstra wrote: > On Fri, Apr 14, 2017 at 01:38:13PM +0200, Peter Zijlstra wrote: >> On Thu, Apr 13, 2017 at 10:56:08AM -0300, Lauro Ramos Venancio wrote: >>> This patch constructs the sched groups from each CPU perspective. So, on >>> a 4 nodes machine with ring

Re: [RFC 2/3] sched/topology: fix sched groups on NUMA machines with mesh topology

2017-04-17 Thread Lauro Venancio
On 04/14/2017 01:58 PM, Peter Zijlstra wrote: > On Fri, Apr 14, 2017 at 01:38:13PM +0200, Peter Zijlstra wrote: >> On Thu, Apr 13, 2017 at 10:56:08AM -0300, Lauro Ramos Venancio wrote: >>> This patch constructs the sched groups from each CPU perspective. So, on >>> a 4 nodes machine with ring

Re: [PATCH v4 1/2] vfio/type1: Remove locked page accounting workqueue

2017-04-17 Thread Alex Williamson
On Mon, 17 Apr 2017 14:47:54 +0800 Peter Xu wrote: > On Sun, Apr 16, 2017 at 07:42:27PM -0600, Alex Williamson wrote: > > [...] > > > -static void vfio_lock_acct(struct task_struct *task, long npage) > > +static int vfio_lock_acct(struct task_struct *task, long npage, bool

Re: [PATCH v4 1/2] vfio/type1: Remove locked page accounting workqueue

2017-04-17 Thread Alex Williamson
On Mon, 17 Apr 2017 14:47:54 +0800 Peter Xu wrote: > On Sun, Apr 16, 2017 at 07:42:27PM -0600, Alex Williamson wrote: > > [...] > > > -static void vfio_lock_acct(struct task_struct *task, long npage) > > +static int vfio_lock_acct(struct task_struct *task, long npage, bool > > lock_cap) > >

Re: [kernel-hardening] Re: [PATCH 3/4] restrict unprivileged TIOCSTI tty ioctl

2017-04-17 Thread Jann Horn
On Mon, Apr 17, 2017 at 8:53 AM, Greg KH wrote: > On Mon, Apr 17, 2017 at 02:07:05AM -0400, Matt Brown wrote: >> this patch depends on patch 1 and 2 >> >> enforces restrictions on unprivileged users injecting commands >> into other processes in the same tty session

Re: [kernel-hardening] Re: [PATCH 3/4] restrict unprivileged TIOCSTI tty ioctl

2017-04-17 Thread Jann Horn
On Mon, Apr 17, 2017 at 8:53 AM, Greg KH wrote: > On Mon, Apr 17, 2017 at 02:07:05AM -0400, Matt Brown wrote: >> this patch depends on patch 1 and 2 >> >> enforces restrictions on unprivileged users injecting commands >> into other processes in the same tty session using the TIOCSTI ioctl >> >>

Re: [PATCH] ACPICA: Export mutex functions

2017-04-17 Thread Guenter Roeck
On 04/17/2017 02:48 AM, Zheng, Lv wrote: Hi, From: Devel [mailto:devel-boun...@acpica.org] On Behalf Of Zheng, Lv Sent: Monday, April 17, 2017 5:40 PM To: Guenter Roeck ; Moore, Robert Cc: linux-a...@vger.kernel.org; de...@acpica.org; Wysocki,

Re: [PATCH] ACPICA: Export mutex functions

2017-04-17 Thread Guenter Roeck
On 04/17/2017 02:48 AM, Zheng, Lv wrote: Hi, From: Devel [mailto:devel-boun...@acpica.org] On Behalf Of Zheng, Lv Sent: Monday, April 17, 2017 5:40 PM To: Guenter Roeck ; Moore, Robert Cc: linux-a...@vger.kernel.org; de...@acpica.org; Wysocki, Rafael J ; linux-kernel@vger.kernel.org Subject:

[PATCH] x86/unwind: ensure stack pointer is aligned

2017-04-17 Thread Josh Poimboeuf
With frame pointers disabled, on some older versions of GCC (like 4.8.3), it's possible for the stack pointer to get aligned at a half-word boundary: 04d0 : 4d0: 41 57 push %r15 4d2: 41 56 push %r14 4d4:

[PATCH] x86/unwind: ensure stack pointer is aligned

2017-04-17 Thread Josh Poimboeuf
With frame pointers disabled, on some older versions of GCC (like 4.8.3), it's possible for the stack pointer to get aligned at a half-word boundary: 04d0 : 4d0: 41 57 push %r15 4d2: 41 56 push %r14 4d4:

[PATCH 3/4] KASLR: Handle memory limit specified by memmap and mem option

2017-04-17 Thread Baoquan He
Option mem= will limit the max address system can use. Any memory region above the limit will be removed. And memmap=nn[KMG] which has no offset specified has the same behaviour as mem=. KASLR need consider this when choose the random position for decompressing kernel. Do it in this patch.

[PATCH 3/4] KASLR: Handle memory limit specified by memmap and mem option

2017-04-17 Thread Baoquan He
Option mem= will limit the max address system can use. Any memory region above the limit will be removed. And memmap=nn[KMG] which has no offset specified has the same behaviour as mem=. KASLR need consider this when choose the random position for decompressing kernel. Do it in this patch.

[PATCH 4/4] doc: Update description about memmap option in kernel-parameter.txt

2017-04-17 Thread Baoquan He
In commit 9710f581bb4c ("x86, mm: Let "memmap=" take more entries one time") memmap was changed to adopt multiple values with comma delimited in one entry, so update the related description. And if only specify size value without offset, like memmap=nn[KMG], memmap behaves equal to mem=nn[KMG],

[PATCH 4/4] doc: Update description about memmap option in kernel-parameter.txt

2017-04-17 Thread Baoquan He
In commit 9710f581bb4c ("x86, mm: Let "memmap=" take more entries one time") memmap was changed to adopt multiple values with comma delimited in one entry, so update the related description. And if only specify size value without offset, like memmap=nn[KMG], memmap behaves equal to mem=nn[KMG],

[PATCH 2/4] KASLR: Parse all memmap entries in cmdline

2017-04-17 Thread Baoquan He
In commit f28442497b5c ("x86/boot: Fix KASLR and memmap= collision"), memmap= option is parsed so that kaslr can avoid those reserved regions. It uses cmdline_find_option to get the value if memmap= is specified, however the problem is cmdline_find_option can only find the last entry if multiple

[PATCH 2/4] KASLR: Parse all memmap entries in cmdline

2017-04-17 Thread Baoquan He
In commit f28442497b5c ("x86/boot: Fix KASLR and memmap= collision"), memmap= option is parsed so that kaslr can avoid those reserved regions. It uses cmdline_find_option to get the value if memmap= is specified, however the problem is cmdline_find_option can only find the last entry if multiple

[PATCH 1/4] param: Move function next_arg to lib/cmdline.c for later reuse

2017-04-17 Thread Baoquan He
next_arg will be used to parse cmdline in x86/boot/compressed code, so move it to lib/cmdline.c for better code reuse. No change in functionality. Signed-off-by: Baoquan He Cc: Andrew Morton Cc: Jessica Yu Cc: Petr Mladek

[PATCH 1/4] param: Move function next_arg to lib/cmdline.c for later reuse

2017-04-17 Thread Baoquan He
next_arg will be used to parse cmdline in x86/boot/compressed code, so move it to lib/cmdline.c for better code reuse. No change in functionality. Signed-off-by: Baoquan He Cc: Andrew Morton Cc: Jessica Yu Cc: Petr Mladek Cc: Jens Axboe Cc: Josh Triplett Cc: zijun_hu Cc: Larry Finger Cc:

[PATCH 0/4] Handle memmap and mem kernel options in boot stage kaslr

2017-04-17 Thread Baoquan He
People reported kernel panic occurs during system boots up with mem boot option. After checking code, several problems are found about memmap= and mem= in boot stage kaslr. *) In commit f28442497b5c ("x86/boot: Fix KASLR and memmap= collision"), only one memmap entry is considered and only

[PATCH 0/4] Handle memmap and mem kernel options in boot stage kaslr

2017-04-17 Thread Baoquan He
People reported kernel panic occurs during system boots up with mem boot option. After checking code, several problems are found about memmap= and mem= in boot stage kaslr. *) In commit f28442497b5c ("x86/boot: Fix KASLR and memmap= collision"), only one memmap entry is considered and only

Re: arch/x86//kernel/ftrace.c:35:3: error: #error The following combination is not supported: ((compiler missing -mfentry) || (CONFIG_X86_32 and !CONFIG_DYNAMIC_FTRACE)) && CONFIG_FUNCTION_GRAPH_TRACE

2017-04-17 Thread Josh Poimboeuf
On Sun, Apr 16, 2017 at 09:20:50AM +0800, kbuild test robot wrote: > Hi Josh, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: d5ff0814fda50f0306e102f39640cf5bb76af08e > commit:

Re: arch/x86//kernel/ftrace.c:35:3: error: #error The following combination is not supported: ((compiler missing -mfentry) || (CONFIG_X86_32 and !CONFIG_DYNAMIC_FTRACE)) && CONFIG_FUNCTION_GRAPH_TRACE

2017-04-17 Thread Josh Poimboeuf
On Sun, Apr 16, 2017 at 09:20:50AM +0800, kbuild test robot wrote: > Hi Josh, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: d5ff0814fda50f0306e102f39640cf5bb76af08e > commit:

Re: skb_over_panic using UDP and 6lowpan / fakelb

2017-04-17 Thread Alexander Aring
Hi, sorry for the late reply. On 04/03/2017 07:29 PM, Cong Wang wrote: > (Cc'ing netdev and maintainers) > > On Mon, Mar 27, 2017 at 2:16 AM, David Palma wrote: >> >> Hi, >> >> Sending a simple UDP packet (39 bytes long), over a 6lowpan interface >> (using fakelb),

Re: skb_over_panic using UDP and 6lowpan / fakelb

2017-04-17 Thread Alexander Aring
Hi, sorry for the late reply. On 04/03/2017 07:29 PM, Cong Wang wrote: > (Cc'ing netdev and maintainers) > > On Mon, Mar 27, 2017 at 2:16 AM, David Palma wrote: >> >> Hi, >> >> Sending a simple UDP packet (39 bytes long), over a 6lowpan interface >> (using fakelb), creates a kernel panic

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

2017-04-17 Thread Namhyung Kim
Hi Masami, On Mon, Apr 17, 2017 at 8:52 PM, Masami Hiramatsu wrote: > On Mon, 17 Apr 2017 11:44:27 +0900 > Namhyung Kim wrote: > >> When function tracer has a pid filter, it adds a probe to sched_switch >> to track if current task can be ignored. The

Re: [PATCH 1/4] ftrace: Fix function pid filter on instances

2017-04-17 Thread Namhyung Kim
Hi Masami, On Mon, Apr 17, 2017 at 8:52 PM, Masami Hiramatsu wrote: > On Mon, 17 Apr 2017 11:44:27 +0900 > Namhyung Kim wrote: > >> When function tracer has a pid filter, it adds a probe to sched_switch >> to track if current task can be ignored. The probe checks the >> ftrace_ignore_pid from

Re: uvcvideo logging kernel warnings on device disconnect

2017-04-17 Thread Laurent Pinchart
Hi Daniel, On Monday 17 Apr 2017 18:57:57 Daniel Axtens wrote: > Hi, > > >> > I hate to pester, but wondered if you had found anything obvious. > >> > I really do appreciate you taking the time to look. > >> > >> Sorry, I haven't had the chance and now will not be able to until > >> January

Re: uvcvideo logging kernel warnings on device disconnect

2017-04-17 Thread Laurent Pinchart
Hi Daniel, On Monday 17 Apr 2017 18:57:57 Daniel Axtens wrote: > Hi, > > >> > I hate to pester, but wondered if you had found anything obvious. > >> > I really do appreciate you taking the time to look. > >> > >> Sorry, I haven't had the chance and now will not be able to until > >> January

Re: [PATCH] ARM: dts: omap4-droid4: add bluetooth

2017-04-17 Thread Rob Herring
On Sun, Apr 16, 2017 at 10:26 AM, Sebastian Reichel wrote: > Hi Michael, > > On Sat, Apr 15, 2017 at 07:00:29PM -0700, Michael Scott wrote: >> On Apr 15, 2017 3:18 PM, "Sebastian Reichel" wrote: >>> Droid 4 has wl1835 connected to the OMAP's UART4 port, which is

Re: [PATCH] ARM: dts: omap4-droid4: add bluetooth

2017-04-17 Thread Rob Herring
On Sun, Apr 16, 2017 at 10:26 AM, Sebastian Reichel wrote: > Hi Michael, > > On Sat, Apr 15, 2017 at 07:00:29PM -0700, Michael Scott wrote: >> On Apr 15, 2017 3:18 PM, "Sebastian Reichel" wrote: >>> Droid 4 has wl1835 connected to the OMAP's UART4 port, which is >> >> Technically, I believe the

Re: [PATCH 2/2] [media] uvcvideo: Kill video URBs on disconnect

2017-04-17 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Monday 17 Apr 2017 18:52:40 Daniel Axtens wrote: > When an in-use webcam is disconnected, I noticed the following > messages: > > uvcvideo: Failed to resubmit video URB (-19). > > -19 is -ENODEV, which does make sense given that the device has >

Re: [PATCH 2/2] [media] uvcvideo: Kill video URBs on disconnect

2017-04-17 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Monday 17 Apr 2017 18:52:40 Daniel Axtens wrote: > When an in-use webcam is disconnected, I noticed the following > messages: > > uvcvideo: Failed to resubmit video URB (-19). > > -19 is -ENODEV, which does make sense given that the device has >

[PATCH 0/4] Some documentation fixes

2017-04-17 Thread Mauro Carvalho Chehab
This patch series address a few issues at the documentation, after applying this patch series: https://lkml.org/lkml/2017/4/16/2 The first patch solves a limitation with Sphinx and literal blocks inside a footnote. The next two patches fix issues with xpad.rst documentation, with mentions

[PATCH 4/4] [RFC] input: add kAPI and uAPI kernel-doc stuff at the input book

2017-04-17 Thread Mauro Carvalho Chehab
Move the kAPI kernel-doc produced documentation to Documentation/input and add uAPI documentation there too. Signed-off-by: Mauro Carvalho Chehab --- Documentation/driver-api/iio/intro.rst | 4 ++-- Documentation/driver-api/index.rst

[PATCH 0/4] Some documentation fixes

2017-04-17 Thread Mauro Carvalho Chehab
This patch series address a few issues at the documentation, after applying this patch series: https://lkml.org/lkml/2017/4/16/2 The first patch solves a limitation with Sphinx and literal blocks inside a footnote. The next two patches fix issues with xpad.rst documentation, with mentions

[PATCH 4/4] [RFC] input: add kAPI and uAPI kernel-doc stuff at the input book

2017-04-17 Thread Mauro Carvalho Chehab
Move the kAPI kernel-doc produced documentation to Documentation/input and add uAPI documentation there too. Signed-off-by: Mauro Carvalho Chehab --- Documentation/driver-api/iio/intro.rst | 4 ++-- Documentation/driver-api/index.rst

<    3   4   5   6   7   8   9   10   11   >