Re: [v3 0/9] parallelized "struct page" zeroing

We should either keep memset() only for deferred struct pages as what I have in my patches. Another option is to add a new function struct_page_clear() which would default to memset() and to something else on platforms that decide to optimize it. On SPARC it would call STBIs, and we would

Re: [v3 0/9] parallelized "struct page" zeroing

We should either keep memset() only for deferred struct pages as what I have in my patches. Another option is to add a new function struct_page_clear() which would default to memset() and to something else on platforms that decide to optimize it. On SPARC it would call STBIs, and we would

[PATCH] staging: greybus: power_supply: replace kzalloc by kcalloc

According to checkpatch.pl, kcalloc should be preferred to kzalloc with multiply. Signed-off-by: JB Van Puyvelde --- drivers/staging/greybus/power_supply.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/power_supply.c

[PATCH] staging: greybus: power_supply: replace kzalloc by kcalloc

According to checkpatch.pl, kcalloc should be preferred to kzalloc with multiply. Signed-off-by: JB Van Puyvelde --- drivers/staging/greybus/power_supply.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/power_supply.c

[PATCH v2] sound: Disable the build of OSS drivers

OSS drivers are left as badly unmaintained, and now we're facing a problem to clean up the hackish set_fs() usage in their codes. Since most of drivers have been covered by ALSA, and the others are dead old and inactive, let's leave them RIP. This patch is the first step: disable the build of

[PATCH v2] sound: Disable the build of OSS drivers

OSS drivers are left as badly unmaintained, and now we're facing a problem to clean up the hackish set_fs() usage in their codes. Since most of drivers have been covered by ALSA, and the others are dead old and inactive, let's leave them RIP. This patch is the first step: disable the build of

Re: [v2] Input: elan_i2c - check if device is there before really probing

On Mon, May 08, 2017 at 05:45:53PM -0700, Dmitry Torokhov wrote: > Before trying to properly initialize the touchpad and generate bunch of > errors, let's first see it there is anything at the given address. If we > get error, fail silently with -ENXIO. > > Signed-off-by: Dmitry Torokhov

Re: [v2] Input: elan_i2c - check if device is there before really probing

On Mon, May 08, 2017 at 05:45:53PM -0700, Dmitry Torokhov wrote: > Before trying to properly initialize the touchpad and generate bunch of > errors, let's first see it there is anything at the given address. If we > get error, fail silently with -ENXIO. > > Signed-off-by: Dmitry Torokhov

Re: Threads stuck in zap_pid_ns_processes()

On Thu, May 11, 2017 at 03:23:17PM -0500, Eric W. Biederman wrote: > Guenter Roeck writes: > > > On Thu, May 11, 2017 at 12:31:21PM -0500, Eric W. Biederman wrote: > >> Guenter Roeck writes: > >> > >> > Hi all, > >> > > >> > the test program attached

Re: Threads stuck in zap_pid_ns_processes()

On Thu, May 11, 2017 at 03:23:17PM -0500, Eric W. Biederman wrote: > Guenter Roeck writes: > > > On Thu, May 11, 2017 at 12:31:21PM -0500, Eric W. Biederman wrote: > >> Guenter Roeck writes: > >> > >> > Hi all, > >> > > >> > the test program attached below almost always results in one of the

Re: [v3 0/9] parallelized "struct page" zeroing

Have you measured that? I do not think it would be super hard to measure. I would be quite surprised if this added much if anything at all as the whole struct page should be in the cache line already. We do set reference count and other struct members. Almost nobody should be looking at our page

Re: [v3 0/9] parallelized "struct page" zeroing

Have you measured that? I do not think it would be super hard to measure. I would be quite surprised if this added much if anything at all as the whole struct page should be in the cache line already. We do set reference count and other struct members. Almost nobody should be looking at our page

Re: [PATCH v3 1/2] selinux: add brief info to policydb

On 5/11/2017 1:22 PM, Stephen Smalley wrote: > On Thu, 2017-05-11 at 08:56 -0700, Casey Schaufler wrote: >> On 5/11/2017 5:59 AM, Sebastien Buisson wrote: >>> Add policybrief field to struct policydb. It holds a brief info >>> of the policydb, in the following form: >>> <0 or 1 for enforce>:<0 or

Re: [PATCH v3 1/2] selinux: add brief info to policydb

On 5/11/2017 1:22 PM, Stephen Smalley wrote: > On Thu, 2017-05-11 at 08:56 -0700, Casey Schaufler wrote: >> On 5/11/2017 5:59 AM, Sebastien Buisson wrote: >>> Add policybrief field to struct policydb. It holds a brief info >>> of the policydb, in the following form: >>> <0 or 1 for enforce>:<0 or

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

On Thu, May 11, 2017 at 01:23:06PM -0700, Tony Lindgren wrote: > * Bin Liu [170511 13:05]: > > On Thu, May 11, 2017 at 12:38:11PM -0700, Tony Lindgren wrote: > > > > > > I wonder if just keeping VBUS on longer in OTG_STATE_A_WAIT_BCON > > > solves this issue? > > > > We don't cut

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

On Thu, May 11, 2017 at 01:23:06PM -0700, Tony Lindgren wrote: > * Bin Liu [170511 13:05]: > > On Thu, May 11, 2017 at 12:38:11PM -0700, Tony Lindgren wrote: > > > > > > I wonder if just keeping VBUS on longer in OTG_STATE_A_WAIT_BCON > > > solves this issue? > > > > We don't cut VBUS

Re: [alsa-devel] future of sounds/oss

On Thu, 11 May 2017 22:28:49 +0200, Linus Torvalds wrote: > > On Thu, May 11, 2017 at 1:21 PM, Takashi Iwai wrote: > > > > Since no one cried against it so far, I'll try to smuggle the > > following patch into 4.12. > > Can we instead just disable it with a one-liner that just

Re: [alsa-devel] future of sounds/oss

On Thu, 11 May 2017 22:28:49 +0200, Linus Torvalds wrote: > > On Thu, May 11, 2017 at 1:21 PM, Takashi Iwai wrote: > > > > Since no one cried against it so far, I'll try to smuggle the > > following patch into 4.12. > > Can we instead just disable it with a one-liner that just makes >

Re: [PATCH] target: remove dead code

On 05/09/2017 02:46 PM, Gustavo A. R. Silva wrote: > Local variable _ret_ is assigned to a constant value and it is never > updated again. Remove this variable and the dead code it guards. > > Addresses-Coverity-ID: 140761 > Signed-off-by: Gustavo A. R. Silva > ---

Re: [PATCH] target: remove dead code

On 05/09/2017 02:46 PM, Gustavo A. R. Silva wrote: > Local variable _ret_ is assigned to a constant value and it is never > updated again. Remove this variable and the dead code it guards. > > Addresses-Coverity-ID: 140761 > Signed-off-by: Gustavo A. R. Silva > --- Reviewed-by: Tyrel Datwyler

Re: [alsa-devel] future of sounds/oss

On 05/11/17 13:28, Linus Torvalds wrote: > On Thu, May 11, 2017 at 1:21 PM, Takashi Iwai wrote: >> >> Since no one cried against it so far, I'll try to smuggle the >> following patch into 4.12. > > Can we instead just disable it with a one-liner that just makes > SOUND_PRIME have

Re: [alsa-devel] future of sounds/oss

On 05/11/17 13:28, Linus Torvalds wrote: > On Thu, May 11, 2017 at 1:21 PM, Takashi Iwai wrote: >> >> Since no one cried against it so far, I'll try to smuggle the >> following patch into 4.12. > > Can we instead just disable it with a one-liner that just makes > SOUND_PRIME have a > >

Re: Threads stuck in zap_pid_ns_processes()

Guenter Roeck writes: > On Thu, May 11, 2017 at 12:31:21PM -0500, Eric W. Biederman wrote: >> Guenter Roeck writes: >> >> > Hi all, >> > >> > the test program attached below almost always results in one of the child >> > processes being stuck in

Re: Threads stuck in zap_pid_ns_processes()

Guenter Roeck writes: > On Thu, May 11, 2017 at 12:31:21PM -0500, Eric W. Biederman wrote: >> Guenter Roeck writes: >> >> > Hi all, >> > >> > the test program attached below almost always results in one of the child >> > processes being stuck in zap_pid_ns_processes(). When this happens, I can

Re: [alsa-devel] future of sounds/oss

On Thu, May 11, 2017 at 1:21 PM, Takashi Iwai wrote: > > Since no one cried against it so far, I'll try to smuggle the > following patch into 4.12. Can we instead just disable it with a one-liner that just makes SOUND_PRIME have a depends on n in it, so that you can't

Re: [alsa-devel] future of sounds/oss

On Thu, May 11, 2017 at 1:21 PM, Takashi Iwai wrote: > > Since no one cried against it so far, I'll try to smuggle the > following patch into 4.12. Can we instead just disable it with a one-liner that just makes SOUND_PRIME have a depends on n in it, so that you can't select it.

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

* Tony Lindgren [170511 13:26]: > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c > --- a/drivers/usb/musb/musb_dsps.c > +++ b/drivers/usb/musb/musb_dsps.c > @@ -270,6 +270,10 @@ static int dsps_check_status(struct musb *musb, void > *unused) >

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

* Tony Lindgren [170511 13:26]: > diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c > --- a/drivers/usb/musb/musb_dsps.c > +++ b/drivers/usb/musb/musb_dsps.c > @@ -270,6 +270,10 @@ static int dsps_check_status(struct musb *musb, void > *unused) >

Re: Lockdep splat involving all_q_mutex

On Thu, May 11, 2017 at 02:12:39PM -0600, Jens Axboe wrote: > On 05/10/2017 09:13 PM, Paul E. McKenney wrote: > > On Wed, May 10, 2017 at 08:55:54PM -0600, Jens Axboe wrote: > >> On 05/10/2017 04:34 PM, Paul E. McKenney wrote: > >>> Hello! > >>> > >>> I got the lockdep splat shown below during

Re: Lockdep splat involving all_q_mutex

On Thu, May 11, 2017 at 02:12:39PM -0600, Jens Axboe wrote: > On 05/10/2017 09:13 PM, Paul E. McKenney wrote: > > On Wed, May 10, 2017 at 08:55:54PM -0600, Jens Axboe wrote: > >> On 05/10/2017 04:34 PM, Paul E. McKenney wrote: > >>> Hello! > >>> > >>> I got the lockdep splat shown below during

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

* Bin Liu [170511 13:05]: > On Thu, May 11, 2017 at 12:38:11PM -0700, Tony Lindgren wrote: > > > > I wonder if just keeping VBUS on longer in OTG_STATE_A_WAIT_BCON > > solves this issue? > > We don't cut VBUS intentionally for host mode (when devctl=0x19). The > VBUS got cut in

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

* Bin Liu [170511 13:05]: > On Thu, May 11, 2017 at 12:38:11PM -0700, Tony Lindgren wrote: > > > > I wonder if just keeping VBUS on longer in OTG_STATE_A_WAIT_BCON > > solves this issue? > > We don't cut VBUS intentionally for host mode (when devctl=0x19). The > VBUS got cut in this case only

Re: I'd like to donate a MacBook Pro

2017-05-11 5:16 GMT-06:00 Mathias Nyman : > Looks like there are a few people suffering from macbook xhci related issues > > From the bugs linked it looks like there are both some UEFI issues and a > non-responsive > usb device at boot. at least one USB device does

Re: I'd like to donate a MacBook Pro

2017-05-11 5:16 GMT-06:00 Mathias Nyman : > Looks like there are a few people suffering from macbook xhci related issues > > From the bugs linked it looks like there are both some UEFI issues and a > non-responsive > usb device at boot. at least one USB device does not respond to a address >

Re: [alsa-devel] future of sounds/oss

On Thu, 11 May 2017 11:15:11 +0200, Christoph Hellwig wrote: > > On Thu, May 11, 2017 at 10:46:47AM +0200, Takashi Iwai wrote: > > Yeah, I also started looking at it after reading the LWN article. > > The removal of set_fs() in ALSA part was already finished, and I'm > > currently brushing up the

Re: [alsa-devel] future of sounds/oss

On Thu, 11 May 2017 11:15:11 +0200, Christoph Hellwig wrote: > > On Thu, May 11, 2017 at 10:46:47AM +0200, Takashi Iwai wrote: > > Yeah, I also started looking at it after reading the LWN article. > > The removal of set_fs() in ALSA part was already finished, and I'm > > currently brushing up the

Re: Threads stuck in zap_pid_ns_processes()

On Thu, May 11, 2017 at 12:31:21PM -0500, Eric W. Biederman wrote: > Guenter Roeck writes: > > > Hi all, > > > > the test program attached below almost always results in one of the child > > processes being stuck in zap_pid_ns_processes(). When this happens, I can > > see

Re: Threads stuck in zap_pid_ns_processes()

On Thu, May 11, 2017 at 12:31:21PM -0500, Eric W. Biederman wrote: > Guenter Roeck writes: > > > Hi all, > > > > the test program attached below almost always results in one of the child > > processes being stuck in zap_pid_ns_processes(). When this happens, I can > > see from test logs that

Re: [PATCH v3 1/2] selinux: add brief info to policydb

On Thu, 2017-05-11 at 08:56 -0700, Casey Schaufler wrote: > On 5/11/2017 5:59 AM, Sebastien Buisson wrote: > > Add policybrief field to struct policydb. It holds a brief info > > of the policydb, in the following form: > > <0 or 1 for enforce>:<0 or 1 for checkreqprot>:= > > Policy brief is

Re: [PATCH v3 1/2] selinux: add brief info to policydb

On Thu, 2017-05-11 at 08:56 -0700, Casey Schaufler wrote: > On 5/11/2017 5:59 AM, Sebastien Buisson wrote: > > Add policybrief field to struct policydb. It holds a brief info > > of the policydb, in the following form: > > <0 or 1 for enforce>:<0 or 1 for checkreqprot>:= > > Policy brief is

Re: [PATCH] x86/power/64: Use char arrays for asm function names

On Tue 2017-05-09 14:00:51, Kees Cook wrote: > This switches the hibernate_64.S function names into character arrays > to match other areas of the kernel where this is done (e.g., linker > scripts). Specifically this fixes a compile-time error noticed by the > future CONFIG_FORTIFY_SOURCE routines

Re: [PATCH] x86/power/64: Use char arrays for asm function names

On Tue 2017-05-09 14:00:51, Kees Cook wrote: > This switches the hibernate_64.S function names into character arrays > to match other areas of the kernel where this is done (e.g., linker > scripts). Specifically this fixes a compile-time error noticed by the > future CONFIG_FORTIFY_SOURCE routines

Re: Lockdep splat involving all_q_mutex

On 05/10/2017 09:13 PM, Paul E. McKenney wrote: > On Wed, May 10, 2017 at 08:55:54PM -0600, Jens Axboe wrote: >> On 05/10/2017 04:34 PM, Paul E. McKenney wrote: >>> Hello! >>> >>> I got the lockdep splat shown below during some rcutorture testing (which >>> does CPU hotplug operations) on mainline

Re: Lockdep splat involving all_q_mutex

On 05/10/2017 09:13 PM, Paul E. McKenney wrote: > On Wed, May 10, 2017 at 08:55:54PM -0600, Jens Axboe wrote: >> On 05/10/2017 04:34 PM, Paul E. McKenney wrote: >>> Hello! >>> >>> I got the lockdep splat shown below during some rcutorture testing (which >>> does CPU hotplug operations) on mainline

Re: [PATCH] FS: Fixing return type of unsigned_offsets

On Thu, May 11, 2017 at 8:07 AM, Al Viro wrote: > FVO"needed" equal to "needed to make sparse STFU"? If anything, that's > sparse being wrong - evaluate.c:check_assignment_type() should do > if (t == _bool) { > if

Re: [PATCH] FS: Fixing return type of unsigned_offsets

On Thu, May 11, 2017 at 8:07 AM, Al Viro wrote: > FVO"needed" equal to "needed to make sparse STFU"? If anything, that's > sparse being wrong - evaluate.c:check_assignment_type() should do > if (t == _bool) { > if (is_fouled_type(s)) >

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

On Thu, May 11, 2017 at 12:38:11PM -0700, Tony Lindgren wrote: > * Bin Liu [170511 12:23]: > > On Thu, May 11, 2017 at 02:10:05PM -0500, Bin Liu wrote: > > [...] > > > > > > The otg state machine implementation in the musb drivers are kind > > > > > > of strange. > > > > > >

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

On Thu, May 11, 2017 at 12:38:11PM -0700, Tony Lindgren wrote: > * Bin Liu [170511 12:23]: > > On Thu, May 11, 2017 at 02:10:05PM -0500, Bin Liu wrote: > > [...] > > > > > > The otg state machine implementation in the musb drivers are kind > > > > > > of strange. > > > > > >

Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on error status

On 11.05.2017 21:29, Colin King wrote: From: Colin Ian King The error status err is initialized as zero and then being checked several times to see if it is less than zero even when it has not been updated. It may seem that the err should be assigned to the return

Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on error status

On 11.05.2017 21:29, Colin King wrote: From: Colin Ian King The error status err is initialized as zero and then being checked several times to see if it is less than zero even when it has not been updated. It may seem that the err should be assigned to the return code of the call to the

[PATCH] pinctrl: when claiming hog, skip maps not served by same device

When pinctrl device registers, it automatically claims hogs, that is, maps that pinctrl device serves for itself. It is possible that in addition to SoC's pinctrl device, other pinctrl devices get registered. E.g. some gpio expander devies are registered as pinctrl devices. For such devices,

[PATCH] pinctrl: when claiming hog, skip maps not served by same device

When pinctrl device registers, it automatically claims hogs, that is, maps that pinctrl device serves for itself. It is possible that in addition to SoC's pinctrl device, other pinctrl devices get registered. E.g. some gpio expander devies are registered as pinctrl devices. For such devices,

Re: [RFC 04/10] x86/mm: Pass flush_tlb_info to flush_tlb_others() etc

> On May 7, 2017, at 5:38 AM, Andy Lutomirski wrote: > > @@ -243,15 +237,15 @@ static void flush_tlb_func(void *info) > return; > } > > - if (f->flush_end == TLB_FLUSH_ALL) { > + if (f->end == TLB_FLUSH_ALL) { > local_flush_tlb(); >

Re: [RFC 04/10] x86/mm: Pass flush_tlb_info to flush_tlb_others() etc

> On May 7, 2017, at 5:38 AM, Andy Lutomirski wrote: > > @@ -243,15 +237,15 @@ static void flush_tlb_func(void *info) > return; > } > > - if (f->flush_end == TLB_FLUSH_ALL) { > + if (f->end == TLB_FLUSH_ALL) { > local_flush_tlb(); >

[kernel-locking] question about structure field initialization

Hello everybody, While looking into Coverity ID 1402035 I ran into the following piece of code at kernel/locking/test-ww_mutex.c:197: 197static int test_abba(bool resolve) 198{ 199struct test_abba abba; 200struct ww_acquire_ctx ctx; 201int err, ret; 202 203

[kernel-locking] question about structure field initialization

Hello everybody, While looking into Coverity ID 1402035 I ran into the following piece of code at kernel/locking/test-ww_mutex.c:197: 197static int test_abba(bool resolve) 198{ 199struct test_abba abba; 200struct ww_acquire_ctx ctx; 201int err, ret; 202 203

Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on error status

Hi, On 11.05.2017 20:29, Colin King wrote: > From: Colin Ian King > > The error status err is initialized as zero and then being checked > several times to see if it is less than zero even when it has not > been updated. It may seem that the err should be assigned to

Re: [PATCH][V2] ethernet: aquantia: remove redundant checks on error status

Hi, On 11.05.2017 20:29, Colin King wrote: > From: Colin Ian King > > The error status err is initialized as zero and then being checked > several times to see if it is less than zero even when it has not > been updated. It may seem that the err should be assigned to the > return code of the

Re: [RFC][PATCH] sched/deadline: Remove if statement before clearing throttle and yielded

On Thu, May 11, 2017 at 03:01:16PM +0100, Juri Lelli wrote: > > - if (dl_se->dl_yielded) > > - dl_se->dl_yielded = 0; > > - if (dl_se->dl_throttled) > > - dl_se->dl_throttled = 0; > > + dl_se->dl_yielded = 0; > > + dl_se->dl_throttled = 0; > > } > > Looks good to me.

Re: [RFC][PATCH] sched/deadline: Remove if statement before clearing throttle and yielded

On Thu, May 11, 2017 at 03:01:16PM +0100, Juri Lelli wrote: > > - if (dl_se->dl_yielded) > > - dl_se->dl_yielded = 0; > > - if (dl_se->dl_throttled) > > - dl_se->dl_throttled = 0; > > + dl_se->dl_yielded = 0; > > + dl_se->dl_throttled = 0; > > } > > Looks good to me.

Re: [PATCH v5 13/17] dt-bindings: qca7000: rename binding

Hi, Am Mittwoch, 10. Mai 2017, 10:53:24 CEST schrieb Stefan Wahren: > Before we can merge the QCA7000 UART binding the document needs to be > renamed. > > Signed-off-by: Stefan Wahren > --- > .../devicetree/bindings/net/{qca-qca7000-spi.txt => qca-qca7000.txt} | >

Re: [PATCH v5 13/17] dt-bindings: qca7000: rename binding

Hi, Am Mittwoch, 10. Mai 2017, 10:53:24 CEST schrieb Stefan Wahren: > Before we can merge the QCA7000 UART binding the document needs to be > renamed. > > Signed-off-by: Stefan Wahren > --- > .../devicetree/bindings/net/{qca-qca7000-spi.txt => qca-qca7000.txt} | > 0 1 file changed, 0

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, 11 May 2017 21:10:11 +0200 Fredrik Markström wrote: > On Thu, May 11, 2017 at 6:01 PM, Stephen Hemminger > wrote: > > On Thu, 11 May 2017 15:46:27 +0200 > > Fredrik Markstrom wrote: > > > >> From:

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, 11 May 2017 21:10:11 +0200 Fredrik Markström wrote: > On Thu, May 11, 2017 at 6:01 PM, Stephen Hemminger > wrote: > > On Thu, 11 May 2017 15:46:27 +0200 > > Fredrik Markstrom wrote: > > > >> From: Fredrik Markström > >> > >> is_skb_forwardable() currently checks if the packet size

[PATCH v8 5/5] virtio_net: check return value of skb_to_sgvec always

Signed-off-by: Jason A. Donenfeld Cc: "Michael S. Tsirkin" Cc: Jason Wang --- drivers/net/virtio_net.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index

[PATCH v8 5/5] virtio_net: check return value of skb_to_sgvec always

Signed-off-by: Jason A. Donenfeld Cc: "Michael S. Tsirkin" Cc: Jason Wang --- drivers/net/virtio_net.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 9320d96a1632..13fbe4b349c2 100644 ---

[PATCH v8 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow

This is a defense-in-depth measure in response to bugs like 4d6fa57b4dab ("macsec: avoid heap overflow in skb_to_sgvec"). There's not only a potential overflow of sglist items, but also a stack overflow potential, so we fix this by limiting the amount of recursion this function is allowed to do.

[PATCH v8 1/5] skbuff: return -EMSGSIZE in skb_to_sgvec to prevent overflow

This is a defense-in-depth measure in response to bugs like 4d6fa57b4dab ("macsec: avoid heap overflow in skb_to_sgvec"). There's not only a potential overflow of sglist items, but also a stack overflow potential, so we fix this by limiting the amount of recursion this function is allowed to do.

[PATCH v8 3/5] rxrpc: check return value of skb_to_sgvec always

Signed-off-by: Jason A. Donenfeld Cc: David Howells --- net/rxrpc/rxkad.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index 1bb9b2ccc267..ecab9334e3c1 100644 ---

[PATCH v8 3/5] rxrpc: check return value of skb_to_sgvec always

Signed-off-by: Jason A. Donenfeld Cc: David Howells --- net/rxrpc/rxkad.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/net/rxrpc/rxkad.c b/net/rxrpc/rxkad.c index 1bb9b2ccc267..ecab9334e3c1 100644 --- a/net/rxrpc/rxkad.c +++ b/net/rxrpc/rxkad.c @@ -227,7

[PATCH v8 4/5] macsec: check return value of skb_to_sgvec always

Signed-off-by: Jason A. Donenfeld Cc: Sabrina Dubroca --- drivers/net/macsec.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index cdc347be68f2..dfcb1e9d2ab2 100644 ---

[PATCH v8 4/5] macsec: check return value of skb_to_sgvec always

Signed-off-by: Jason A. Donenfeld Cc: Sabrina Dubroca --- drivers/net/macsec.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index cdc347be68f2..dfcb1e9d2ab2 100644 --- a/drivers/net/macsec.c +++

[PATCH v8 2/5] ipsec: check return value of skb_to_sgvec always

Signed-off-by: Jason A. Donenfeld Cc: Steffen Klassert Cc: Herbert Xu Cc: "David S. Miller" --- net/ipv4/ah4.c | 8 ++-- net/ipv4/esp4.c | 20 +--- net/ipv6/ah6.c | 8

[PATCH v8 2/5] ipsec: check return value of skb_to_sgvec always

Signed-off-by: Jason A. Donenfeld Cc: Steffen Klassert Cc: Herbert Xu Cc: "David S. Miller" --- net/ipv4/ah4.c | 8 ++-- net/ipv4/esp4.c | 20 +--- net/ipv6/ah6.c | 8 ++-- net/ipv6/esp6.c | 20 +--- 4 files changed, 38 insertions(+), 18

[PATCH v8 0/5] skb_to_sgvec hardening

The recent bug with macsec and historical one with virtio have indicated that letting skb_to_sgvec trounce all over an sglist without checking the length is probably a bad idea. And it's not necessary either: an sglist already explicitly marks its last item, and the initialization functions are

[PATCH v8 0/5] skb_to_sgvec hardening

The recent bug with macsec and historical one with virtio have indicated that letting skb_to_sgvec trounce all over an sglist without checking the length is probably a bad idea. And it's not necessary either: an sglist already explicitly marks its last item, and the initialization functions are

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

* Bin Liu [170511 12:23]: > On Thu, May 11, 2017 at 02:10:05PM -0500, Bin Liu wrote: > [...] > > > > > The otg state machine implementation in the musb drivers are kind of > > > > > strange. > > > > > OTG_STATE_A_WAIT_BCON suppose to be a steady state when no usb device > > > > >

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

* Bin Liu [170511 12:23]: > On Thu, May 11, 2017 at 02:10:05PM -0500, Bin Liu wrote: > [...] > > > > > The otg state machine implementation in the musb drivers are kind of > > > > > strange. > > > > > OTG_STATE_A_WAIT_BCON suppose to be a steady state when no usb device > > > > > is > > > > >

[PATCH] mm: per-cgroup memory reclaim stats

Track the following reclaim counters for every memory cgroup: PGREFILL, PGSCAN, PGSTEAL, PGACTIVATE, PGDEACTIVATE, PGLAZYFREE and PGLAZYFREED. These values are exposed using the memory.stats interface of cgroup v2. The meaning of each value is the same as for global counters, available using

[PATCH] mm: per-cgroup memory reclaim stats

Track the following reclaim counters for every memory cgroup: PGREFILL, PGSCAN, PGSTEAL, PGACTIVATE, PGDEACTIVATE, PGLAZYFREE and PGLAZYFREED. These values are exposed using the memory.stats interface of cgroup v2. The meaning of each value is the same as for global counters, available using

[PATCH] mm, docs: update memory.stat description with workingset* entries

Commit 4b4cea91691d ("mm: vmscan: fix IO/refault regression in cache workingset transition") introduced three new entries in memory stat file: - workingset_refault, - workingset_activate, - workingset_nodereclaim. This commit adds a corresponding description to the cgroup v2 docs.

[PATCH] mm, docs: update memory.stat description with workingset* entries

Commit 4b4cea91691d ("mm: vmscan: fix IO/refault regression in cache workingset transition") introduced three new entries in memory stat file: - workingset_refault, - workingset_activate, - workingset_nodereclaim. This commit adds a corresponding description to the cgroup v2 docs.

Re: [RFC][PATCH 00/14] VFS: Introduce superblock configuration context [ver #2]

Anna Schumaker wrote: > Is there any way to split the NFS patch into multiple pieces? Are you okay with a patch or two that add code that is unconnected in that patch, but connected in a later one? David

Re: [RFC][PATCH 00/14] VFS: Introduce superblock configuration context [ver #2]

Anna Schumaker wrote: > Is there any way to split the NFS patch into multiple pieces? Are you okay with a patch or two that add code that is unconnected in that patch, but connected in a later one? David

[PATCH V2] x86/efi: Add EFI_PGT_DUMP support for x86_32, kexec

From: Sai Praneeth EFI_PGT_DUMP, as the name suggests dumps efi page tables to dmesg during kernel boot. This feature is very useful while debugging page faults/null pointer dereferences to efi related addresses. Presently, this feature is limited only to x86_64,

[PATCH V2] x86/efi: Add EFI_PGT_DUMP support for x86_32, kexec

From: Sai Praneeth EFI_PGT_DUMP, as the name suggests dumps efi page tables to dmesg during kernel boot. This feature is very useful while debugging page faults/null pointer dereferences to efi related addresses. Presently, this feature is limited only to x86_64, so let's extend it to other efi

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

On Thu, May 11, 2017 at 02:10:05PM -0500, Bin Liu wrote: [...] > > > > The otg state machine implementation in the musb drivers are kind of > > > > strange. > > > > OTG_STATE_A_WAIT_BCON suppose to be a steady state when no usb device is > > > > attached, but the musb drivers use it as a

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

On Thu, May 11, 2017 at 02:10:05PM -0500, Bin Liu wrote: [...] > > > > The otg state machine implementation in the musb drivers are kind of > > > > strange. > > > > OTG_STATE_A_WAIT_BCON suppose to be a steady state when no usb device is > > > > attached, but the musb drivers use it as a

Re: [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func.

On Thu, 11 May 2017 11:31:27 -0700 Eric Anholt wrote: > drm_encoder_cleanup() finishes with memsetting it to 0, already. > > Signed-off-by: Eric Anholt Acked-by: Boris Brezillon > --- >

Re: [PATCH v2 6/7] drm/atmel-hlcdc: Drop custom encoder cleanup func.

On Thu, 11 May 2017 11:31:27 -0700 Eric Anholt wrote: > drm_encoder_cleanup() finishes with memsetting it to 0, already. > > Signed-off-by: Eric Anholt Acked-by: Boris Brezillon > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 8 +--- > 1 file changed, 1 insertion(+), 7

Re: [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge.

Hi Eric, On Thu, 11 May 2017 11:31:28 -0700 Eric Anholt wrote: > This cuts 135 lines of boilerplate, at the cost of losing the > filtering of get_modes() using atmel_hlcdc_dc_mode_valid(). The > atomic check will still check that we don't set an invalid mode, > though. Nice.

Re: [PATCH v2 7/7] drm/atmel-hlcdc: Replace the panel usage with drm_panel_bridge.

Hi Eric, On Thu, 11 May 2017 11:31:28 -0700 Eric Anholt wrote: > This cuts 135 lines of boilerplate, at the cost of losing the > filtering of get_modes() using atmel_hlcdc_dc_mode_valid(). The > atomic check will still check that we don't set an invalid mode, > though. Nice. > >

Re: [PATCH v5 15/17] dt-bindings: qca7000: append UART interface to binding

Hi, Am Mittwoch, 10. Mai 2017, 10:53:26 CEST schrieb Stefan Wahren: > This merges the serdev binding for the QCA7000 UART driver (Ethernet over > UART) into the existing document. > > Signed-off-by: Stefan Wahren > --- > .../devicetree/bindings/net/qca-qca7000.txt

Re: [PATCH v5 15/17] dt-bindings: qca7000: append UART interface to binding

Hi, Am Mittwoch, 10. Mai 2017, 10:53:26 CEST schrieb Stefan Wahren: > This merges the serdev binding for the QCA7000 UART driver (Ethernet over > UART) into the existing document. > > Signed-off-by: Stefan Wahren > --- > .../devicetree/bindings/net/qca-qca7000.txt| 32 >

Re: pinctrl-sx150x.c broken in 4.11

>>> Maybe create_pinctrl() could check if the pin controller device >>> for a potential hog points to the device itself and bail out >>> if that's not the case? >> >> Well that's exactly what patch from my first mail in this thread does. >> This indeed fixes my case, but I don't know if it is

Re: pinctrl-sx150x.c broken in 4.11

>>> Maybe create_pinctrl() could check if the pin controller device >>> for a potential hog points to the device itself and bail out >>> if that's not the case? >> >> Well that's exactly what patch from my first mail in this thread does. >> This indeed fixes my case, but I don't know if it is

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, May 11, 2017 at 6:01 PM, Stephen Hemminger wrote: > On Thu, 11 May 2017 15:46:27 +0200 > Fredrik Markstrom wrote: > >> From: Fredrik Markström >> >> is_skb_forwardable() currently checks if the packet

Re: [PATCH v2 1/2] net: Added mtu parameter to dev_forward_skb calls

On Thu, May 11, 2017 at 6:01 PM, Stephen Hemminger wrote: > On Thu, 11 May 2017 15:46:27 +0200 > Fredrik Markstrom wrote: > >> From: Fredrik Markström >> >> is_skb_forwardable() currently checks if the packet size is <= mtu of >> the receiving interface. This is not consistent with most of the

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

On Thu, May 11, 2017 at 02:01:00PM -0500, Bin Liu wrote: > On Thu, May 11, 2017 at 11:55:28AM -0700, Tony Lindgren wrote: > > * Bin Liu [170511 11:53]: > > > On Mon, Mar 27, 2017 at 10:55:37AM -0700, Tony Lindgren wrote: > > > > * Bin Liu [170327 10:17]: > > > > > On

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

On Thu, May 11, 2017 at 02:01:00PM -0500, Bin Liu wrote: > On Thu, May 11, 2017 at 11:55:28AM -0700, Tony Lindgren wrote: > > * Bin Liu [170511 11:53]: > > > On Mon, Mar 27, 2017 at 10:55:37AM -0700, Tony Lindgren wrote: > > > > * Bin Liu [170327 10:17]: > > > > > On Mon, Mar 27, 2017 at

<    1   2   3   4   5   6   7   8   9   10   >