Re: [PATCH] Documentation: atomic_ops.txt is core-api/atomic_ops.rst

2017-06-23 Thread Paul E. McKenney
On Fri, Jun 23, 2017 at 01:31:39PM -0700, Palmer Dabbelt wrote: > I was reading the memory barries documentation in order to make sure the > RISC-V barries were correct, and I found a broken link to the atomic > operations documentation. > > Signed-off-by: Palmer Dabbelt >

Re: [PATCH] Documentation: atomic_ops.txt is core-api/atomic_ops.rst

2017-06-23 Thread Paul E. McKenney
On Fri, Jun 23, 2017 at 01:31:39PM -0700, Palmer Dabbelt wrote: > I was reading the memory barries documentation in order to make sure the > RISC-V barries were correct, and I found a broken link to the atomic > operations documentation. > > Signed-off-by: Palmer Dabbelt > Acked-by: Will Deacon

Re: [PATCH v2 1/3] dt-bindings: iio: humidity: add bindings for HDC100x sensors

2017-06-23 Thread Rob Herring
On Mon, Jun 19, 2017 at 11:01:04AM -0500, Michael Stecklein wrote: > Add the bindings for the family of HDC100x sensors. > > Signed-off-by: Michael Stecklein > --- > .../devicetree/bindings/iio/humidity/hdc100x.txt| 17 > + > 1 file changed, 17

Re: [PATCH v2 1/3] dt-bindings: iio: humidity: add bindings for HDC100x sensors

2017-06-23 Thread Rob Herring
On Mon, Jun 19, 2017 at 11:01:04AM -0500, Michael Stecklein wrote: > Add the bindings for the family of HDC100x sensors. > > Signed-off-by: Michael Stecklein > --- > .../devicetree/bindings/iio/humidity/hdc100x.txt| 17 > + > 1 file changed, 17 insertions(+) > create

Re: [PATCH 6/6] mm, migration: do not trigger OOM killer when migrating memory

2017-06-23 Thread Andrew Morton
On Fri, 23 Jun 2017 10:53:45 +0200 Michal Hocko wrote: > From: Michal Hocko > > Page migration (for memory hotplug, soft_offline_page or mbind) needs > to allocate a new memory. This can trigger an oom killer if the target > memory is depleated. Although

Re: [PATCH 6/6] mm, migration: do not trigger OOM killer when migrating memory

2017-06-23 Thread Andrew Morton
On Fri, 23 Jun 2017 10:53:45 +0200 Michal Hocko wrote: > From: Michal Hocko > > Page migration (for memory hotplug, soft_offline_page or mbind) needs > to allocate a new memory. This can trigger an oom killer if the target > memory is depleated. Although quite unlikely, still possible,

Re: [PATCH v2 01/19] doc: DT: camss: Binding document for Qualcomm Camera subsystem driver

2017-06-23 Thread Rob Herring
On Mon, Jun 19, 2017 at 05:48:21PM +0300, Todor Tomov wrote: > Add DT binding document for Qualcomm Camera subsystem driver. "dt-bindings: media: ..." for the subject please. > > CC: Rob Herring > CC: devicet...@vger.kernel.org > Signed-off-by: Todor Tomov

Re: [PATCH v2 01/19] doc: DT: camss: Binding document for Qualcomm Camera subsystem driver

2017-06-23 Thread Rob Herring
On Mon, Jun 19, 2017 at 05:48:21PM +0300, Todor Tomov wrote: > Add DT binding document for Qualcomm Camera subsystem driver. "dt-bindings: media: ..." for the subject please. > > CC: Rob Herring > CC: devicet...@vger.kernel.org > Signed-off-by: Todor Tomov > --- >

Re: New NTB API Issue

2017-06-23 Thread Logan Gunthorpe
On 23/06/17 01:07 PM, Allen Hubbe wrote: > The client's haven't been fully ported to the multi-port api yet. They were > only minimally changed to call the new api, but so far other than that they > have only been made to work as they had before. So is it intended to eventually send the

Re: New NTB API Issue

2017-06-23 Thread Logan Gunthorpe
On 23/06/17 01:07 PM, Allen Hubbe wrote: > The client's haven't been fully ported to the multi-port api yet. They were > only minimally changed to call the new api, but so far other than that they > have only been made to work as they had before. So is it intended to eventually send the

Re: [PATCH v2] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes

2017-06-23 Thread Marcelo Ricardo Leitner
On Wed, Jun 21, 2017 at 07:03:27PM +0200, Denys Vlasenko wrote: > This function compiles to 147 bytes of machine code. 13 callsites. > > I'm no expert on SCTP events, but quick reading of SCTP docs tells me that > SCTP events are not happening on every packet. > They are ASSOC_CHANGE,

Re: [PATCH v2] net/sctp/ulpevent.c: Deinline sctp_ulpevent_set_owner, save 1616 bytes

2017-06-23 Thread Marcelo Ricardo Leitner
On Wed, Jun 21, 2017 at 07:03:27PM +0200, Denys Vlasenko wrote: > This function compiles to 147 bytes of machine code. 13 callsites. > > I'm no expert on SCTP events, but quick reading of SCTP docs tells me that > SCTP events are not happening on every packet. > They are ASSOC_CHANGE,

Re: [PATCH 0/3] Enable namespaced file capabilities

2017-06-23 Thread Vivek Goyal
On Fri, Jun 23, 2017 at 03:17:23PM -0500, Serge E. Hallyn wrote: > Quoting Vivek Goyal (vgo...@redhat.com): > > On Thu, Jun 22, 2017 at 02:59:46PM -0400, Stefan Berger wrote: > > > This series of patches primary goal is to enable file capabilities > > > in user namespaces without affecting the

Re: [PATCH 0/3] Enable namespaced file capabilities

2017-06-23 Thread Vivek Goyal
On Fri, Jun 23, 2017 at 03:17:23PM -0500, Serge E. Hallyn wrote: > Quoting Vivek Goyal (vgo...@redhat.com): > > On Thu, Jun 22, 2017 at 02:59:46PM -0400, Stefan Berger wrote: > > > This series of patches primary goal is to enable file capabilities > > > in user namespaces without affecting the

Re: [tip:x86/mm] x86/mmap, ASLR: Do not treat unlimited-stack tasks as legacy mmap

2017-06-23 Thread Jiri Kosina
On Fri, 23 Jun 2017, tip-bot for Michal Hocko wrote: > TASK_SIZE (allowed by mmap_base) is pretty much unimited in the real > life. This would give mmap 20TB of additional address space which is > quite nice. Especially when it is much more likely to use that address > space than the reserved

Re: [tip:x86/mm] x86/mmap, ASLR: Do not treat unlimited-stack tasks as legacy mmap

2017-06-23 Thread Jiri Kosina
On Fri, 23 Jun 2017, tip-bot for Michal Hocko wrote: > TASK_SIZE (allowed by mmap_base) is pretty much unimited in the real > life. This would give mmap 20TB of additional address space which is > quite nice. Especially when it is much more likely to use that address > space than the reserved

Re: [RFC 8/9] iommu/intel-svm: notify page request to guest

2017-06-23 Thread Alex Williamson
On Fri, 23 Jun 2017 13:16:29 -0700 Jacob Pan wrote: > On Thu, 22 Jun 2017 16:53:58 -0600 > Alex Williamson wrote: > > > On Wed, 14 Jun 2017 15:23:02 -0700 > > Jacob Pan wrote: > > > > > If the source

Re: [RFC 8/9] iommu/intel-svm: notify page request to guest

2017-06-23 Thread Alex Williamson
On Fri, 23 Jun 2017 13:16:29 -0700 Jacob Pan wrote: > On Thu, 22 Jun 2017 16:53:58 -0600 > Alex Williamson wrote: > > > On Wed, 14 Jun 2017 15:23:02 -0700 > > Jacob Pan wrote: > > > > > If the source device of a page request has its PASID table pointer > > > bond to a guest, the first

Re: [PATCH] Documentation: atomic_ops.txt is core-api/atomic_ops.rst

2017-06-23 Thread Palmer Dabbelt
On Fri, 23 Jun 2017 13:29:54 PDT (-0700), cor...@lwn.net wrote: > On Fri, 23 Jun 2017 13:25:22 -0700 > Palmer Dabbelt wrote: > >> I was reading the memory barries documentation in order to make sure the >> RISC-V barries were correct, and I found a broken link to the atomic >>

[PATCH] Documentation: atomic_ops.txt is core-api/atomic_ops.rst

2017-06-23 Thread Palmer Dabbelt
I was reading the memory barries documentation in order to make sure the RISC-V barries were correct, and I found a broken link to the atomic operations documentation. Signed-off-by: Palmer Dabbelt Acked-by: Will Deacon ---

Re: [PATCH] Documentation: atomic_ops.txt is core-api/atomic_ops.rst

2017-06-23 Thread Palmer Dabbelt
On Fri, 23 Jun 2017 13:29:54 PDT (-0700), cor...@lwn.net wrote: > On Fri, 23 Jun 2017 13:25:22 -0700 > Palmer Dabbelt wrote: > >> I was reading the memory barries documentation in order to make sure the >> RISC-V barries were correct, and I found a broken link to the atomic >> operations

[PATCH] Documentation: atomic_ops.txt is core-api/atomic_ops.rst

2017-06-23 Thread Palmer Dabbelt
I was reading the memory barries documentation in order to make sure the RISC-V barries were correct, and I found a broken link to the atomic operations documentation. Signed-off-by: Palmer Dabbelt Acked-by: Will Deacon --- Documentation/memory-barriers.txt | 10 +- 1 file changed, 5

Re: [PATCH 0/3] Enable namespaced file capabilities

2017-06-23 Thread Casey Schaufler
On 6/23/2017 11:35 AM, Serge E. Hallyn wrote: > Quoting Stefan Berger (stef...@linux.vnet.ibm.com): >> On 06/23/2017 12:16 PM, Casey Schaufler wrote: >>> On 6/23/2017 9:00 AM, Serge E. Hallyn wrote: Quoting Amir Goldstein (amir7...@gmail.com): > On Thu, Jun 22, 2017 at 9:59 PM, Stefan

Re: [PATCH 0/3] Enable namespaced file capabilities

2017-06-23 Thread Casey Schaufler
On 6/23/2017 11:35 AM, Serge E. Hallyn wrote: > Quoting Stefan Berger (stef...@linux.vnet.ibm.com): >> On 06/23/2017 12:16 PM, Casey Schaufler wrote: >>> On 6/23/2017 9:00 AM, Serge E. Hallyn wrote: Quoting Amir Goldstein (amir7...@gmail.com): > On Thu, Jun 22, 2017 at 9:59 PM, Stefan

Re: [PATCH] Documentation: atomic_ops.txt is core-api/atomic_ops.rst

2017-06-23 Thread Jonathan Corbet
On Fri, 23 Jun 2017 13:25:22 -0700 Palmer Dabbelt wrote: > I was reading the memory barries documentation in order to make sure the > RISC-V barries were correct, and I found a broken link to the atomic > operations documentation. This looks good to me, but can you resend

Re: [PATCH] Documentation: atomic_ops.txt is core-api/atomic_ops.rst

2017-06-23 Thread Jonathan Corbet
On Fri, 23 Jun 2017 13:25:22 -0700 Palmer Dabbelt wrote: > I was reading the memory barries documentation in order to make sure the > RISC-V barries were correct, and I found a broken link to the atomic > operations documentation. This looks good to me, but can you resend with Paul McKenney on

Re: Regression in kernel 4.12-rc1 for Powerpc 32 - bisected to commit 3448890c32c3

2017-06-23 Thread Al Viro
On Fri, Jun 23, 2017 at 01:49:16PM -0500, Larry Finger wrote: > > BTW, could you try to check what happens if you kill the > > if (__builtin_constant_p(n) && (n <= 8)) > > bits in raw_copy_{to,from}_user()? The usefulness of those (in > > __copy_from_user() > > originally) had always been

Re: Regression in kernel 4.12-rc1 for Powerpc 32 - bisected to commit 3448890c32c3

2017-06-23 Thread Al Viro
On Fri, Jun 23, 2017 at 01:49:16PM -0500, Larry Finger wrote: > > BTW, could you try to check what happens if you kill the > > if (__builtin_constant_p(n) && (n <= 8)) > > bits in raw_copy_{to,from}_user()? The usefulness of those (in > > __copy_from_user() > > originally) had always been

Re: [PATCH] staging: octeon-usb: coding style fix

2017-06-23 Thread Greg KH
On Thu, Jun 15, 2017 at 10:28:47AM +0530, bincy_k_phi...@yahoo.co.in wrote: > From: bincy k philip Please use Capital Letters for your name. > > trivial fix for extra space error > > Signed-off-by: bincy k philip > --- >

Re: [PATCH] staging: octeon-usb: coding style fix

2017-06-23 Thread Greg KH
On Thu, Jun 15, 2017 at 10:28:47AM +0530, bincy_k_phi...@yahoo.co.in wrote: > From: bincy k philip Please use Capital Letters for your name. > > trivial fix for extra space error > > Signed-off-by: bincy k philip > --- > drivers/staging/octeon-usb/octeon-hcd.c | 2 +- > 1 file changed, 1

Re: [PATCH v9 1/5] firmware: add extensible driver data params

2017-06-23 Thread Greg KH
On Mon, Jun 19, 2017 at 09:35:22PM +0200, Luis R. Rodriguez wrote: > > I agree, that's what I'm saying here. I just do not see that happening > > with your patch set at all. It's adding more code, a more complex way > > to interact with the subsystem, and not making driver writer lives any > >

Re: [PATCH v9 1/5] firmware: add extensible driver data params

2017-06-23 Thread Greg KH
On Mon, Jun 19, 2017 at 09:35:22PM +0200, Luis R. Rodriguez wrote: > > I agree, that's what I'm saying here. I just do not see that happening > > with your patch set at all. It's adding more code, a more complex way > > to interact with the subsystem, and not making driver writer lives any > >

Re: [PATCH v9 1/5] firmware: add extensible driver data params

2017-06-23 Thread Greg KH
To respond to one issue in your wall-of-text response: On Mon, Jun 19, 2017 at 09:35:22PM +0200, Luis R. Rodriguez wrote: > You may argue that *one* upstream users is not sufficient to introduce a new > feature for, but I disagree given we have had new full *API* added for a new > feature on the

Re: [PATCH v9 1/5] firmware: add extensible driver data params

2017-06-23 Thread Greg KH
To respond to one issue in your wall-of-text response: On Mon, Jun 19, 2017 at 09:35:22PM +0200, Luis R. Rodriguez wrote: > You may argue that *one* upstream users is not sufficient to introduce a new > feature for, but I disagree given we have had new full *API* added for a new > feature on the

Re: [PATCH v2 2/7] staging: ccree: register setkey for none hash macs

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:56PM +0300, Gilad Ben-Yossef wrote: > Fix a bug where the transformation init code did > not register a setkey method for none hash based MACs. "none hash based MACs"? Is that the correct language, I don't understand it, sorry, can you expand on it a bit in your v3

Re: [PATCH v2 2/7] staging: ccree: register setkey for none hash macs

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:56PM +0300, Gilad Ben-Yossef wrote: > Fix a bug where the transformation init code did > not register a setkey method for none hash based MACs. "none hash based MACs"? Is that the correct language, I don't understand it, sorry, can you expand on it a bit in your v3

Re: [PATCH v2 5/7] staging: ccree: add clock management support

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:59PM +0300, Gilad Ben-Yossef wrote: > Some SoC which implement CryptoCell have a dedicated clock > tied to it, some do not. Implement clock support if exists > based on device tree data and tie power management to it. > > Signed-off-by: Gilad Ben-Yossef

Re: [PATCH v2 5/7] staging: ccree: add clock management support

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:59PM +0300, Gilad Ben-Yossef wrote: > Some SoC which implement CryptoCell have a dedicated clock > tied to it, some do not. Implement clock support if exists > based on device tree data and tie power management to it. > > Signed-off-by: Gilad Ben-Yossef > --- >

Re: [PATCH V2] staging: rtl8192u: style fix

2017-06-23 Thread Greg KH
On Sat, Jun 17, 2017 at 03:26:32PM +1200, Derek Robson wrote: > Fixed checkpatch.pl warnings of "function definition argument FOO should > also have an identifier name" > Found using checkpatch > > Signed-off-by: Derek Robson > > V1 had vauge subjet v2 does as well :( Also

Re: [PATCH] staging: rtl8192u: ieee80211: Convert printks to pr_

2017-06-23 Thread Greg Kroah-Hartman
On Wed, Jun 21, 2017 at 05:49:32PM +0530, simran singhal wrote: > Use the current logging style. > Coalesce formats where appropriate. > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 34 > ++- > 1 file

Re: [PATCH V2] staging: rtl8192u: style fix

2017-06-23 Thread Greg KH
On Sat, Jun 17, 2017 at 03:26:32PM +1200, Derek Robson wrote: > Fixed checkpatch.pl warnings of "function definition argument FOO should > also have an identifier name" > Found using checkpatch > > Signed-off-by: Derek Robson > > V1 had vauge subjet v2 does as well :( Also this V1 line needs

Re: [PATCH] staging: rtl8192u: ieee80211: Convert printks to pr_

2017-06-23 Thread Greg Kroah-Hartman
On Wed, Jun 21, 2017 at 05:49:32PM +0530, simran singhal wrote: > Use the current logging style. > Coalesce formats where appropriate. > > Signed-off-by: simran singhal > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c | 34 > ++- > 1 file changed, 14 insertions(+),

Re: [PATCH 3/3] Enable security.selinux in user namespaces

2017-06-23 Thread Stephen Smalley
On Thu, 2017-06-22 at 14:59 -0400, Stefan Berger wrote: > Before the current modifications, SELinux extended attributes were > visible inside the user namespace but changes in patch 1 hid them. > This patch enables security.selinux in user namespaces and allows > them to be written to in the same

Re: [PATCH v2 00/53] Get rid of Docbook

2017-06-23 Thread Jonathan Corbet
On Fri, 16 Jun 2017 16:03:23 +0200 Markus Heiser wrote: > I guess there are little remains lying around ;) what I have found: I just committed the following to clean up that stuff, thanks. jon >From 52b3f239bb692d9b3a68461798fb15c011e4108e Mon Sep 17 00:00:00 2001

Re: [PATCH 3/3] Enable security.selinux in user namespaces

2017-06-23 Thread Stephen Smalley
On Thu, 2017-06-22 at 14:59 -0400, Stefan Berger wrote: > Before the current modifications, SELinux extended attributes were > visible inside the user namespace but changes in patch 1 hid them. > This patch enables security.selinux in user namespaces and allows > them to be written to in the same

Re: [PATCH v2 00/53] Get rid of Docbook

2017-06-23 Thread Jonathan Corbet
On Fri, 16 Jun 2017 16:03:23 +0200 Markus Heiser wrote: > I guess there are little remains lying around ;) what I have found: I just committed the following to clean up that stuff, thanks. jon >From 52b3f239bb692d9b3a68461798fb15c011e4108e Mon Sep 17 00:00:00 2001 From: Jonathan Corbet Date:

Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'

2017-06-23 Thread Stefan Wahren
> Christophe JAILLET hat am 23. Juni 2017 um > 21:44 geschrieben: > > > 'tz' is a valid pointer at this point, so calling PTR_ERR on it is > pointless. > This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above. > So remove it. 'err' is already

Re: [PATCH v2] thermal: bcm2835: Fix error code in 'bcm2835_thermal_probe'

2017-06-23 Thread Stefan Wahren
> Christophe JAILLET hat am 23. Juni 2017 um > 21:44 geschrieben: > > > 'tz' is a valid pointer at this point, so calling PTR_ERR on it is > pointless. > This 'err = PTR_ERR(tz)' looks like a cut'n'paste from a few lines above. > So remove it. 'err' is already the error we want to report. >

Re: [PATCH 5/6] staging: lustre: lustre: several over 80 characters cleanups

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 15, 2017 at 05:06:30PM +0100, James Simmons wrote: > > > On Wed, 2017-06-14 at 11:01 -0400, James Simmons wrote: > > > Cleanup many of the over 80 characters reported by checkpatch > > > > Please don't let checkpatch get in the way of lustre > > readability. > > > > lustre commonly

Re: [PATCH v2 3/7] staging: ccree: add support for older HW revisions

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:57PM +0300, Gilad Ben-Yossef wrote: > Add support for the older CryptoCell 710 and 630P hardware revisions. No, I do not want to add new features to staging drivers where ever possible. I want you to spend your time fixing up the code to be good enough to get it out

Re: [PATCH 5/6] staging: lustre: lustre: several over 80 characters cleanups

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 15, 2017 at 05:06:30PM +0100, James Simmons wrote: > > > On Wed, 2017-06-14 at 11:01 -0400, James Simmons wrote: > > > Cleanup many of the over 80 characters reported by checkpatch > > > > Please don't let checkpatch get in the way of lustre > > readability. > > > > lustre commonly

Re: [PATCH v2 3/7] staging: ccree: add support for older HW revisions

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 04:36:57PM +0300, Gilad Ben-Yossef wrote: > Add support for the older CryptoCell 710 and 630P hardware revisions. No, I do not want to add new features to staging drivers where ever possible. I want you to spend your time fixing up the code to be good enough to get it out

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis

2017-06-23 Thread Greg KH
On Thu, Jun 15, 2017 at 01:04:55AM +0530, srishti sharma wrote: > Fixed alignment so that it matched open parenthesis. > > Signed-off-by: srishti sharma > --- > .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 18 > +- > 1 file changed, 9

[PATCH] Documentation: atomic_ops.txt is core-api/atomic_ops.rst

2017-06-23 Thread Palmer Dabbelt
I was reading the memory barries documentation in order to make sure the RISC-V barries were correct, and I found a broken link to the atomic operations documentation. Signed-off-by: Palmer Dabbelt Acked-by: Will Deacon ---

Re: [PATCH 6/6] staging: lustre: lustre: fix all braces issues reported by checkpatch

2017-06-23 Thread Greg Kroah-Hartman
On Wed, Jun 14, 2017 at 11:01:21AM -0400, James Simmons wrote: > Cleanup all braces that was reported by checkpatch. The only > issue not fixed up is in mdc_lock.c. Removing the braces in > the case of mdc_lock.c will break the build. > > Signed-off-by: James Simmons >

Re: [PATCH] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis

2017-06-23 Thread Greg KH
On Thu, Jun 15, 2017 at 01:04:55AM +0530, srishti sharma wrote: > Fixed alignment so that it matched open parenthesis. > > Signed-off-by: srishti sharma > --- > .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 18 > +- > 1 file changed, 9 insertions(+), 9 deletions(-)

[PATCH] Documentation: atomic_ops.txt is core-api/atomic_ops.rst

2017-06-23 Thread Palmer Dabbelt
I was reading the memory barries documentation in order to make sure the RISC-V barries were correct, and I found a broken link to the atomic operations documentation. Signed-off-by: Palmer Dabbelt Acked-by: Will Deacon --- Documentation/memory-barriers.txt | 10 +- 1 file changed, 5

Re: [PATCH 6/6] staging: lustre: lustre: fix all braces issues reported by checkpatch

2017-06-23 Thread Greg Kroah-Hartman
On Wed, Jun 14, 2017 at 11:01:21AM -0400, James Simmons wrote: > Cleanup all braces that was reported by checkpatch. The only > issue not fixed up is in mdc_lock.c. Removing the braces in > the case of mdc_lock.c will break the build. > > Signed-off-by: James Simmons > --- >

Re: [PATCH] staging: lustre: lnet: selftest: Change the type of variable to bool

2017-06-23 Thread Greg Kroah-Hartman
On Tue, Jun 20, 2017 at 02:36:37PM +0530, simran singhal wrote: > This patch changes the type of variable done from int to boolean. As it > is been used as a boolean in the function sfw_test_rpc_done(). It also > makes the code more readable and bool data type also requires less > memory in

Re: [PATCHv3 1/3] firmware_class: move NO_CACHE from private to driver_data_req_params

2017-06-23 Thread Greg KH
On Fri, Jun 16, 2017 at 05:58:29PM -0500, yi1...@linux.intel.com wrote: > From: Yi Li > > This adds DRIVER_DATA_REQ_NO_CACHE flag with .req flag under struct > driver_data_req_params. When this flag is set, the driver_data driver > will not cache the firmware during PM

Re: [PATCH v3 07/11] tty: improve tty_insert_flip_char() fast path

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 07:13:51PM +0200, Arnd Bergmann wrote: > kernelci.org reports a crazy stack usage for the VT code when CONFIG_KASAN > is enabled: > > drivers/tty/vt/keyboard.c: In function 'kbd_keycode': > drivers/tty/vt/keyboard.c:1452:1: error: the frame size of 2240 bytes is > larger

Re: [PATCH] staging: lustre: lnet: selftest: Change the type of variable to bool

2017-06-23 Thread Greg Kroah-Hartman
On Tue, Jun 20, 2017 at 02:36:37PM +0530, simran singhal wrote: > This patch changes the type of variable done from int to boolean. As it > is been used as a boolean in the function sfw_test_rpc_done(). It also > makes the code more readable and bool data type also requires less > memory in

Re: [PATCHv3 1/3] firmware_class: move NO_CACHE from private to driver_data_req_params

2017-06-23 Thread Greg KH
On Fri, Jun 16, 2017 at 05:58:29PM -0500, yi1...@linux.intel.com wrote: > From: Yi Li > > This adds DRIVER_DATA_REQ_NO_CACHE flag with .req flag under struct > driver_data_req_params. When this flag is set, the driver_data driver > will not cache the firmware during PM cycle, which is expensive.

Re: [PATCH v3 07/11] tty: improve tty_insert_flip_char() fast path

2017-06-23 Thread Greg Kroah-Hartman
On Thu, Jun 22, 2017 at 07:13:51PM +0200, Arnd Bergmann wrote: > kernelci.org reports a crazy stack usage for the VT code when CONFIG_KASAN > is enabled: > > drivers/tty/vt/keyboard.c: In function 'kbd_keycode': > drivers/tty/vt/keyboard.c:1452:1: error: the frame size of 2240 bytes is > larger

Re: [PATCH 5/6] staging: lustre: lustre: several over 80 characters cleanups

2017-06-23 Thread Greg Kroah-Hartman
On Wed, Jun 14, 2017 at 11:01:20AM -0400, James Simmons wrote: > -void ldlm_extent_policy_wire_to_local(const union ldlm_wire_policy_data > *wpolicy, > - union ldlm_policy_data *lpolicy) > +void > +ldlm_extent_policy_wire_to_local(const union

[PATCH] firmware: remove request_firmware_into_buf()

2017-06-23 Thread Greg Kroah-Hartman
As Luis pointed out, there are no in-kernel users of request_firmware_into_buf(), so remove it, and the now unused internal flag, which simplifies the logic around buffer handling a bit. Reported-by: "Luis R. Rodriguez" Signed-off-by: Greg Kroah-Hartman

Re: [PATCH 5/6] staging: lustre: lustre: several over 80 characters cleanups

2017-06-23 Thread Greg Kroah-Hartman
On Wed, Jun 14, 2017 at 11:01:20AM -0400, James Simmons wrote: > -void ldlm_extent_policy_wire_to_local(const union ldlm_wire_policy_data > *wpolicy, > - union ldlm_policy_data *lpolicy) > +void > +ldlm_extent_policy_wire_to_local(const union

[PATCH] firmware: remove request_firmware_into_buf()

2017-06-23 Thread Greg Kroah-Hartman
As Luis pointed out, there are no in-kernel users of request_firmware_into_buf(), so remove it, and the now unused internal flag, which simplifies the logic around buffer handling a bit. Reported-by: "Luis R. Rodriguez" Signed-off-by: Greg Kroah-Hartman ---

Re: [PATCH 1/1] fix coding style

2017-06-23 Thread Greg Kroah-Hartman
On Fri, Jun 16, 2017 at 01:23:59PM +0800, Jhih-Ming Hunag wrote: > Hi, > > I fixed some coding style following scripts/checkpatch.pl suggestion. > > Signed-off-by: Jhih-Ming Hunag > --- > drivers/staging/android/ion/ion.c | 8 > 1 file changed, 4 insertions(+), 4

Re: [PATCH 1/1] fix coding style

2017-06-23 Thread Greg Kroah-Hartman
On Fri, Jun 16, 2017 at 01:23:59PM +0800, Jhih-Ming Hunag wrote: > Hi, > > I fixed some coding style following scripts/checkpatch.pl suggestion. > > Signed-off-by: Jhih-Ming Hunag > --- > drivers/staging/android/ion/ion.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > >

Re: [PATCH] staging: sm750fb: Remove typedefs from _logical_chip_type_t and _clock_type_t

2017-06-23 Thread Greg Kroah-Hartman
On Mon, Jun 19, 2017 at 10:51:21PM +0530, Simran Singhal wrote: > This patch removes typedefs from enum _logical_chip_type_t and enum > _clock_type_t and rename them to logical_chip_type_t and clock_type_t > respectively. Why are you doing two different typedef fixups in a single patch? Please

Re: [PATCH] Staging: wlan-ng: hfa384x_usb: Fixed sparse warning cast to restricted __le16

2017-06-23 Thread Greg KH
On Fri, Jun 16, 2017 at 03:35:07PM +0530, Jaya Durga wrote: > when building with make C=1 CF=-D__CHECK_ENDIAN__ > > drivers/staging/wlan-ng/hfa384x_usb.c:3383:36: warning: cast to restricted > __le16 > > fixed by using the le16_to_cpus function. > > Signed-off-by: Jaya Durga >

Re: [PATCH] staging: sm750fb: Remove typedefs from _logical_chip_type_t and _clock_type_t

2017-06-23 Thread Greg Kroah-Hartman
On Mon, Jun 19, 2017 at 10:51:21PM +0530, Simran Singhal wrote: > This patch removes typedefs from enum _logical_chip_type_t and enum > _clock_type_t and rename them to logical_chip_type_t and clock_type_t > respectively. Why are you doing two different typedef fixups in a single patch? Please

Re: [PATCH] Staging: wlan-ng: hfa384x_usb: Fixed sparse warning cast to restricted __le16

2017-06-23 Thread Greg KH
On Fri, Jun 16, 2017 at 03:35:07PM +0530, Jaya Durga wrote: > when building with make C=1 CF=-D__CHECK_ENDIAN__ > > drivers/staging/wlan-ng/hfa384x_usb.c:3383:36: warning: cast to restricted > __le16 > > fixed by using the le16_to_cpus function. > > Signed-off-by: Jaya Durga > --- >

Re: [PATCH V2] staging: sm750fb - style fix

2017-06-23 Thread Greg KH
On Sat, Jun 17, 2017 at 03:03:24PM +1200, Derek Robson wrote: > Fixed checkpatch.pl warnings of the form "function definition argument > 'foo' should also have an identifier name" in header files. > > Signed-off-by: Derek Robson > > V1 had vague subject > --- Same as

Re: [PATCH] Staging: rtl8712 : osdep_intf.h: fix macro coding style issue

2017-06-23 Thread Greg KH
On Thu, Jun 22, 2017 at 12:10:04PM +0530, Jaya Durga wrote: > From: Jaya Durga > > Fix checkpatch.pl warning of the form "CHECK" Macro argument 'x' > may be better as '(x)' to avoid precedence issues. > > Signed-off-by: Jaya Durga > --- >

Re: [PATCH V2] staging: sm750fb - style fix

2017-06-23 Thread Greg KH
On Sat, Jun 17, 2017 at 03:03:24PM +1200, Derek Robson wrote: > Fixed checkpatch.pl warnings of the form "function definition argument > 'foo' should also have an identifier name" in header files. > > Signed-off-by: Derek Robson > > V1 had vague subject > --- Same as before...

Re: [PATCH] Staging: rtl8712 : osdep_intf.h: fix macro coding style issue

2017-06-23 Thread Greg KH
On Thu, Jun 22, 2017 at 12:10:04PM +0530, Jaya Durga wrote: > From: Jaya Durga > > Fix checkpatch.pl warning of the form "CHECK" Macro argument 'x' > may be better as '(x)' to avoid precedence issues. > > Signed-off-by: Jaya Durga > --- > drivers/staging/rtl8712/osdep_intf.h | 2 +- > 1 file

Re: [PATCH 2/2] Staging: rtl8712 : os_intfs.c: use octal

2017-06-23 Thread Greg KH
On Thu, Jun 22, 2017 at 03:42:35PM +0530, Jaya Durga wrote: > Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' > are not preferred.Consider using octal permissions '0644'. > > Signed-off-by: Jaya Durga > --6 What is this last line for? Please fix up and

Re: [PATCH 2/2] Staging: rtl8712 : os_intfs.c: use octal

2017-06-23 Thread Greg KH
On Thu, Jun 22, 2017 at 03:42:35PM +0530, Jaya Durga wrote: > Fix checkpatch.pl Warning: Symbolic permissions 'S_IRUGO | S_IWUSR' > are not preferred.Consider using octal permissions '0644'. > > Signed-off-by: Jaya Durga > --6 What is this last line for? Please fix up and resend. thanks,

Re: [PATCH V2] staging: rtl8723bs - remove asm includes

2017-06-23 Thread Greg KH
On Sat, Jun 17, 2017 at 03:21:22PM +1200, Derek Robson wrote: > Fixed checkpatch warnings "Use #include instead of " > Found using checkpatch > > Signed-off-by: Derek Robson > > V1 had vauge subject. > --- Please move the V1 below the --- line. thanks, greg k-h

Re: [PATCH V2] staging: rtl8723bs - remove asm includes

2017-06-23 Thread Greg KH
On Sat, Jun 17, 2017 at 03:21:22PM +1200, Derek Robson wrote: > Fixed checkpatch warnings "Use #include instead of " > Found using checkpatch > > Signed-off-by: Derek Robson > > V1 had vauge subject. > --- Please move the V1 below the --- line. thanks, greg k-h

Re: [PATCH] FIXUP: CHROMIUM: fix transposed param settings

2017-06-23 Thread Brian Norris
Hi Nick, When sending patches to kernel mailing lists, we don't use prefixes like "CHROMIUM" -- those only apply to Chrome OS kernel trees, to indicate patches that should be specific to the Chromium (OS) project and not necessarily upstream Linux. Here, you want to follow the patterns used by

Re: [PATCH] FIXUP: CHROMIUM: fix transposed param settings

2017-06-23 Thread Brian Norris
Hi Nick, When sending patches to kernel mailing lists, we don't use prefixes like "CHROMIUM" -- those only apply to Chrome OS kernel trees, to indicate patches that should be specific to the Chromium (OS) project and not necessarily upstream Linux. Here, you want to follow the patterns used by

Re: [RFC 2/9] iommu/vt-d: add bind_pasid_table function

2017-06-23 Thread Jacob Pan
On Fri, 23 Jun 2017 12:59:00 -0600 Alex Williamson wrote: > On Fri, 23 Jun 2017 11:19:52 -0700 > Jacob Pan wrote: > > > On Thu, 22 Jun 2017 16:52:15 -0600 > > Alex Williamson wrote: > > > > > On Wed, 14

Re: [RFC 2/9] iommu/vt-d: add bind_pasid_table function

2017-06-23 Thread Jacob Pan
On Fri, 23 Jun 2017 12:59:00 -0600 Alex Williamson wrote: > On Fri, 23 Jun 2017 11:19:52 -0700 > Jacob Pan wrote: > > > On Thu, 22 Jun 2017 16:52:15 -0600 > > Alex Williamson wrote: > > > > > On Wed, 14 Jun 2017 15:22:56 -0700 > > > Jacob Pan wrote: > > > > +static int

Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values

2017-06-23 Thread Julien Gomes
On 06/23/2017 11:47 AM, David Miller wrote: > From: Julien Gomes > Date: Fri, 23 Jun 2017 10:52:26 -0700 > >> On 06/23/2017 10:39 AM, David Miller wrote: >> >>> From: Julien Gomes >>> Date: Wed, 21 Jun 2017 10:58:10 -0700 >>> When sending a cache

Re: [PATCH net-next 1/2] ipmr: restrict mroute "queue full" warning to related error values

2017-06-23 Thread Julien Gomes
On 06/23/2017 11:47 AM, David Miller wrote: > From: Julien Gomes > Date: Fri, 23 Jun 2017 10:52:26 -0700 > >> On 06/23/2017 10:39 AM, David Miller wrote: >> >>> From: Julien Gomes >>> Date: Wed, 21 Jun 2017 10:58:10 -0700 >>> When sending a cache report on mroute_sk, mroute will emit a

Re: [RFC 7/9] iommu/dmar: notify unrecoverable faults

2017-06-23 Thread Jacob Pan
On Thu, 22 Jun 2017 16:54:16 -0600 Alex Williamson wrote: > On Wed, 14 Jun 2017 15:23:01 -0700 > Jacob Pan wrote: > > > Currently, when device DMA faults are detected by IOMMU the fault > > reasons are printed but the offending device

Re: [RFC 7/9] iommu/dmar: notify unrecoverable faults

2017-06-23 Thread Jacob Pan
On Thu, 22 Jun 2017 16:54:16 -0600 Alex Williamson wrote: > On Wed, 14 Jun 2017 15:23:01 -0700 > Jacob Pan wrote: > > > Currently, when device DMA faults are detected by IOMMU the fault > > reasons are printed but the offending device is not notified. > > This patch allows device drivers to be

Re: [PATCH 0/3] Enable namespaced file capabilities

2017-06-23 Thread Serge E. Hallyn
Quoting Vivek Goyal (vgo...@redhat.com): > On Thu, Jun 22, 2017 at 02:59:46PM -0400, Stefan Berger wrote: > > This series of patches primary goal is to enable file capabilities > > in user namespaces without affecting the file capabilities that are > > effective on the host. This is to prevent

Re: [PATCH 0/3] Enable namespaced file capabilities

2017-06-23 Thread Serge E. Hallyn
Quoting Vivek Goyal (vgo...@redhat.com): > On Thu, Jun 22, 2017 at 02:59:46PM -0400, Stefan Berger wrote: > > This series of patches primary goal is to enable file capabilities > > in user namespaces without affecting the file capabilities that are > > effective on the host. This is to prevent

Re: [PATCH 0/4] g_NCR5380: PDMA fixes and cleanup

2017-06-23 Thread Ondrej Zary
On Friday 23 June 2017 13:01:53 Finn Thain wrote: > On Fri, 23 Jun 2017, I wrote: > > Does this patch help? It should be applied on top of this series of 4. > > Sorry, I sent the wrong diff. Please try this patch instead. Thanks, much better now: both HDD and CD-ROM seem to work on DTC and

Re: [RFC 8/9] iommu/intel-svm: notify page request to guest

2017-06-23 Thread Jacob Pan
On Thu, 22 Jun 2017 16:53:58 -0600 Alex Williamson wrote: > On Wed, 14 Jun 2017 15:23:02 -0700 > Jacob Pan wrote: > > > If the source device of a page request has its PASID table pointer > > bond to a guest, the first level page tables

Re: [PATCH 0/4] g_NCR5380: PDMA fixes and cleanup

2017-06-23 Thread Ondrej Zary
On Friday 23 June 2017 13:01:53 Finn Thain wrote: > On Fri, 23 Jun 2017, I wrote: > > Does this patch help? It should be applied on top of this series of 4. > > Sorry, I sent the wrong diff. Please try this patch instead. Thanks, much better now: both HDD and CD-ROM seem to work on DTC and

Re: [RFC 8/9] iommu/intel-svm: notify page request to guest

2017-06-23 Thread Jacob Pan
On Thu, 22 Jun 2017 16:53:58 -0600 Alex Williamson wrote: > On Wed, 14 Jun 2017 15:23:02 -0700 > Jacob Pan wrote: > > > If the source device of a page request has its PASID table pointer > > bond to a guest, the first level page tables are owned by the guest. > > In this case, we shall let

Re: [PATCH] alienware-wmi: Adjust instance of all wmi_evaluate_method calls to 0

2017-06-23 Thread Darren Hart
On Wed, Jun 21, 2017 at 05:01:35PM -0500, Mario Limonciello wrote: > Pali recently noticed that WMI instances are zero indexed. > > The only reason that these calls all worked properly is because the ASL > didn't verify the instance number. > > Signed-off-by: Mario Limonciello

Re: [PATCH] alienware-wmi: Adjust instance of all wmi_evaluate_method calls to 0

2017-06-23 Thread Darren Hart
On Wed, Jun 21, 2017 at 05:01:35PM -0500, Mario Limonciello wrote: > Pali recently noticed that WMI instances are zero indexed. > > The only reason that these calls all worked properly is because the ASL > didn't verify the instance number. > > Signed-off-by: Mario Limonciello Thanks Mario,

Re: [PATCH 0/3] Enable namespaced file capabilities

2017-06-23 Thread Vivek Goyal
On Thu, Jun 22, 2017 at 02:59:46PM -0400, Stefan Berger wrote: > This series of patches primary goal is to enable file capabilities > in user namespaces without affecting the file capabilities that are > effective on the host. This is to prevent that any unprivileged user > on the host maps his

Re: [PATCH 0/3] Enable namespaced file capabilities

2017-06-23 Thread Vivek Goyal
On Thu, Jun 22, 2017 at 02:59:46PM -0400, Stefan Berger wrote: > This series of patches primary goal is to enable file capabilities > in user namespaces without affecting the file capabilities that are > effective on the host. This is to prevent that any unprivileged user > on the host maps his

<    1   2   3   4   5   6   7   8   9   10   >