Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

2017-06-25 Thread Anand Moon
Hi Krzysztof On 25 June 2017 at 20:59, Krzysztof Kozlowski wrote: > On Sun, Jun 25, 2017 at 08:48:13PM +0530, Anand Moon wrote: >> Hi Krzystof, >> >> 2: We should also increase the tips from 4 to 8 to support different >> >> cluster of cpu's. >> > >> > There are 4 CPU thermal

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

2017-06-25 Thread Anand Moon
Hi Krzysztof On 25 June 2017 at 20:59, Krzysztof Kozlowski wrote: > On Sun, Jun 25, 2017 at 08:48:13PM +0530, Anand Moon wrote: >> Hi Krzystof, >> >> 2: We should also increase the tips from 4 to 8 to support different >> >> cluster of cpu's. >> > >> > There are 4 CPU thermal zones on

Re: [PATCH v5 0/4] USB Audio Gadget refactoring

2017-06-25 Thread Jassi Brar
On Sun, Jun 18, 2017 at 6:53 PM, Ruslan Bilovol wrote: > Hi Felipe, > > This is v5 of audio gadget refactoring. > Note, that legacy f_uac1 function is broken since v4.10 > by commit 7e4da3fcf7c9 ("usb: gadget: composite: Test > get_alt() presence instead of set_alt()").

Re: [PATCH v2] rtc: ds3232: add temperature support

2017-06-25 Thread Andy Shevchenko
On Thu, Jun 22, 2017 at 7:58 PM, Kirill Esipov wrote: > DS3232/DS3234 has the temperature registers with a resolution of 0.25 > degree celsius. This enables to get the value through hwmon. > > # cat /sys/class/hwmon/hwmon0/temp1_input > 37250 > +config

Re: [PATCH v5 0/4] USB Audio Gadget refactoring

2017-06-25 Thread Jassi Brar
On Sun, Jun 18, 2017 at 6:53 PM, Ruslan Bilovol wrote: > Hi Felipe, > > This is v5 of audio gadget refactoring. > Note, that legacy f_uac1 function is broken since v4.10 > by commit 7e4da3fcf7c9 ("usb: gadget: composite: Test > get_alt() presence instead of set_alt()"). The fact that > at

Re: [PATCH v2] rtc: ds3232: add temperature support

2017-06-25 Thread Andy Shevchenko
On Thu, Jun 22, 2017 at 7:58 PM, Kirill Esipov wrote: > DS3232/DS3234 has the temperature registers with a resolution of 0.25 > degree celsius. This enables to get the value through hwmon. > > # cat /sys/class/hwmon/hwmon0/temp1_input > 37250 > +config RTC_DRV_DS3232_HWMON > +

Re: [PATCH V4] acpi: acpica: fix acpi parse and parseext cache leaks

2017-06-25 Thread Andy Shevchenko
On Fri, Jun 23, 2017 at 12:36 PM, Seunghun Han wrote: > I'm Seunghun Han, and I work for National Security Research Institute of > South Korea. > - /* Clean up */ > - do { > -

Re: [PATCH V4] acpi: acpica: fix acpi parse and parseext cache leaks

2017-06-25 Thread Andy Shevchenko
On Fri, Jun 23, 2017 at 12:36 PM, Seunghun Han wrote: > I'm Seunghun Han, and I work for National Security Research Institute of > South Korea. > - /* Clean up */ > - do { > -

[PATCH] ov9650: fix semicolon.cocci warnings

2017-06-25 Thread kbuild test robot
drivers/media/i2c/ov9650.c:2034:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 5ffa34fa8f2e ("ov9650: add support of OV9655 variant") CC: Hugues Fruchet Signed-off-by: Fengguang Wu

Re: [PATCH v1 6/6] [media] ov9650: add support of OV9655 variant

2017-06-25 Thread kbuild test robot
-of-OV9655-camera/20170625-201153 base: git://linuxtv.org/media_tree.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/media/i2c/ov9650.c:2034:2-3: Unneeded semicolon Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure

[PATCH] ov9650: fix semicolon.cocci warnings

2017-06-25 Thread kbuild test robot
drivers/media/i2c/ov9650.c:2034:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: 5ffa34fa8f2e ("ov9650: add support of OV9655 variant") CC: Hugues Fruchet Signed-off-by: Fengguang Wu --- ov9650.c |2 +- 1 file changed, 1

Re: [PATCH v1 6/6] [media] ov9650: add support of OV9655 variant

2017-06-25 Thread kbuild test robot
-of-OV9655-camera/20170625-201153 base: git://linuxtv.org/media_tree.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/media/i2c/ov9650.c:2034:2-3: Unneeded semicolon Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure

[PATCH] modsign: add markers to endif-statements in certs/Makefile

2017-06-25 Thread Jarkko Sakkinen
It's a bit hard for eye to track certs/Makefile if you are not accustomed to it. This commit adds comments to key endif statements in order to help to keep the context while reading this file. Signed-off-by: Jarkko Sakkinen --- certs/Makefile | 6 +++--- 1 file

[PATCH] modsign: add markers to endif-statements in certs/Makefile

2017-06-25 Thread Jarkko Sakkinen
It's a bit hard for eye to track certs/Makefile if you are not accustomed to it. This commit adds comments to key endif statements in order to help to keep the context while reading this file. Signed-off-by: Jarkko Sakkinen --- certs/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [PATCH net-next] net: add netlink_ext_ack support to rtnl_link_ops

2017-06-25 Thread David Miller
From: Matthias Schiffer Date: Sat, 24 Jun 2017 13:35:17 +0200 > The following functions are extended with a netlink_ext_ack argument to > allow extended error reporting: > > * validate > * newlink > * changelink > * slave_validate > * slave_changelink > >

Re: [PATCH net-next] net: add netlink_ext_ack support to rtnl_link_ops

2017-06-25 Thread David Miller
From: Matthias Schiffer Date: Sat, 24 Jun 2017 13:35:17 +0200 > The following functions are extended with a netlink_ext_ack argument to > allow extended error reporting: > > * validate > * newlink > * changelink > * slave_validate > * slave_changelink > > Signed-off-by: Matthias Schiffer

Re: [PATCH] net/icmp: restore source address if packet is NATed

2017-06-25 Thread David Miller
From: "Jason A. Donenfeld" Date: Sat, 24 Jun 2017 04:17:27 +0200 > The ICMP routines use the source address for two reasons: > > 1. Rate-limiting ICMP transmissions based on source address, so >that one source address cannot provoke a flood of replies. If >

Re: [PATCH] net/icmp: restore source address if packet is NATed

2017-06-25 Thread David Miller
From: "Jason A. Donenfeld" Date: Sat, 24 Jun 2017 04:17:27 +0200 > The ICMP routines use the source address for two reasons: > > 1. Rate-limiting ICMP transmissions based on source address, so >that one source address cannot provoke a flood of replies. If >the source address

[PATCH] irqchip: gicv3-its: Use NUMA aware memory allocation for ITS tables

2017-06-25 Thread Shanker Donthineni
The NUMA node information is visible to ITS driver but not being used other than handling errata. This patch allocates the memory for ITS tables from the corresponding NUMA node using the appropriate NUMA aware functions. Signed-off-by: Shanker Donthineni ---

[PATCH] irqchip: gicv3-its: Use NUMA aware memory allocation for ITS tables

2017-06-25 Thread Shanker Donthineni
The NUMA node information is visible to ITS driver but not being used other than handling errata. This patch allocates the memory for ITS tables from the corresponding NUMA node using the appropriate NUMA aware functions. Signed-off-by: Shanker Donthineni --- drivers/irqchip/irq-gic-v3-its.c |

[PATCH] powerpc/perf: Fix branch event code for power9

2017-06-25 Thread Madhavan Srinivasan
Correct "branch" event code of Power9 is "r4d05e". Replace the current "branch" event code with "r4d05e" and add a hack to use "r10012" as event code for power9 dd1. Fixes: d89f473ff6f8 ("powerpc/perf: Fix PM_BRU_CMPL event code for power9") Reported-by: Anton Blanchard

[PATCH] powerpc/perf: Fix branch event code for power9

2017-06-25 Thread Madhavan Srinivasan
Correct "branch" event code of Power9 is "r4d05e". Replace the current "branch" event code with "r4d05e" and add a hack to use "r10012" as event code for power9 dd1. Fixes: d89f473ff6f8 ("powerpc/perf: Fix PM_BRU_CMPL event code for power9") Reported-by: Anton Blanchard Signed-off-by: Madhavan

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

2017-06-25 Thread Krzysztof Kozlowski
On Sun, Jun 25, 2017 at 08:48:13PM +0530, Anand Moon wrote: > Hi Krzystof, > >> 2: We should also increase the tips from 4 to 8 to support different > >> cluster of cpu's. > > > > There are 4 CPU thermal zones on Exynos5422. What do you want to expand? > > What I meant was to support more trip

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

2017-06-25 Thread Krzysztof Kozlowski
On Sun, Jun 25, 2017 at 08:48:13PM +0530, Anand Moon wrote: > Hi Krzystof, > >> 2: We should also increase the tips from 4 to 8 to support different > >> cluster of cpu's. > > > > There are 4 CPU thermal zones on Exynos5422. What do you want to expand? > > What I meant was to support more trip

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

2017-06-25 Thread Anand Moon
Hi Krzystof, On 25 June 2017 at 19:01, Krzysztof Kozlowski wrote: > On Sun, Jun 25, 2017 at 06:53:24PM +0530, Anand Moon wrote: >> Hi Willy, >> >> On 24 June 2017 at 02:39, Willy Wolff wrote: >> > Odroid XU*-familly boards has thermal sensors per A15

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

2017-06-25 Thread Anand Moon
Hi Krzystof, On 25 June 2017 at 19:01, Krzysztof Kozlowski wrote: > On Sun, Jun 25, 2017 at 06:53:24PM +0530, Anand Moon wrote: >> Hi Willy, >> >> On 24 June 2017 at 02:39, Willy Wolff wrote: >> > Odroid XU*-familly boards has thermal sensors per A15 cores, but the actual >> > thermal-zones

[PATCH] soc/qman: Change a comment for an entry check insid drain_mr_fqrni function

2017-06-25 Thread Karim Eshapa
Change the comment for an entry check inside function drain_mr_fqrni() with sleep for sufficient period of time instead of long time proccessor cycles. Signed-off-by: Karim Eshapa --- drivers/soc/fsl/qbman/qman.c | 25 + 1 file changed, 13

[PATCH] soc/qman: Change a comment for an entry check insid drain_mr_fqrni function

2017-06-25 Thread Karim Eshapa
Change the comment for an entry check inside function drain_mr_fqrni() with sleep for sufficient period of time instead of long time proccessor cycles. Signed-off-by: Karim Eshapa --- drivers/soc/fsl/qbman/qman.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-)

[PATCH] soc/qman: Sleep instead of stuck hacking jiffies.

2017-06-25 Thread Karim Eshapa
Use msleep() instead of stucking with long delay will be more efficient. Signed-off-by: Karim Eshapa --- drivers/soc/fsl/qbman/qman.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c

[PATCH] soc/qman: Sleep instead of stuck hacking jiffies.

2017-06-25 Thread Karim Eshapa
Use msleep() instead of stucking with long delay will be more efficient. Signed-off-by: Karim Eshapa --- drivers/soc/fsl/qbman/qman.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c index 3d891db..18d391e

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Sun, Jun 25, 2017 at 04:27:23PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jun 25, 2017 at 02:54:29PM +0100, Sudip Mukherjee wrote: > > On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > > > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > > > On Mon, Jun

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Sun, Jun 25, 2017 at 04:27:23PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jun 25, 2017 at 02:54:29PM +0100, Sudip Mukherjee wrote: > > On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > > > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > > > On Mon, Jun

Re: [PATCH v2 2/2] i2c: Add Spreadtrum I2C controller driver

2017-06-25 Thread Andy Shevchenko
On Wed, Jun 21, 2017 at 10:23 AM, Baolin Wang wrote: > This patch adds the I2C controller driver for Spreadtrum platform. Needs more work. See my comments below. > +#include > +#include Since your answer to the comment about arch_initcall you perhaps need to

Re: [PATCH v2 2/2] i2c: Add Spreadtrum I2C controller driver

2017-06-25 Thread Andy Shevchenko
On Wed, Jun 21, 2017 at 10:23 AM, Baolin Wang wrote: > This patch adds the I2C controller driver for Spreadtrum platform. Needs more work. See my comments below. > +#include > +#include Since your answer to the comment about arch_initcall you perhaps need to get rid of tristate (use bool)

[PATCH] stm32-dcmi: fix semicolon.cocci warnings

2017-06-25 Thread kbuild test robot
drivers/media/platform/stm32/stm32-dcmi.c:808:2-3: Unneeded semicolon drivers/media/platform/stm32/stm32-dcmi.c:562:2-3: Unneeded semicolon drivers/media/platform/stm32/stm32-dcmi.c:762:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci

[PATCH] stm32-dcmi: fix semicolon.cocci warnings

2017-06-25 Thread kbuild test robot
drivers/media/platform/stm32/stm32-dcmi.c:808:2-3: Unneeded semicolon drivers/media/platform/stm32/stm32-dcmi.c:562:2-3: Unneeded semicolon drivers/media/platform/stm32/stm32-dcmi.c:762:2-3: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci

Re: [PATCH v1 3/5] [media] stm32-dcmi: crop sensor image to match user resolution

2017-06-25 Thread kbuild test robot
/Camera-support-on-STM32F746G-DISCO-board/20170625-204425 base: git://linuxtv.org/media_tree.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/media/platform/stm32/stm32-dcmi.c:808:2-3: Unneeded semicolon drivers/media/platform/stm32/stm32-dcmi.c:562:2

Re: [PATCH v1 3/5] [media] stm32-dcmi: crop sensor image to match user resolution

2017-06-25 Thread kbuild test robot
/Camera-support-on-STM32F746G-DISCO-board/20170625-204425 base: git://linuxtv.org/media_tree.git master coccinelle warnings: (new ones prefixed by >>) >> drivers/media/platform/stm32/stm32-dcmi.c:808:2-3: Unneeded semicolon drivers/media/platform/stm32/stm32-dcmi.c:562:2

Re: [PATCH 3/4] btrfs: Add zstd support

2017-06-25 Thread kbuild test robot
Hi Nick, [auto build test ERROR on linus/master] [also build test ERROR on v4.12-rc6 next-20170623] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nick-Terrell/lib-Add-xxhash-module/20170625

Re: [PATCH 3/4] btrfs: Add zstd support

2017-06-25 Thread kbuild test robot
Hi Nick, [auto build test ERROR on linus/master] [also build test ERROR on v4.12-rc6 next-20170623] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nick-Terrell/lib-Add-xxhash-module/20170625

Re: PM / wakeirq: Convert to SRCU

2017-06-25 Thread Paul E. McKenney
On Sun, Jun 25, 2017 at 11:11:57AM +0200, Thomas Gleixner wrote: > On Sat, 24 Jun 2017, Paul E. McKenney wrote: > > On Sat, Jun 24, 2017 at 11:56:11AM +0200, Thomas Gleixner wrote: > > > static DECLARE_WAIT_QUEUE_HEAD(wakeup_count_wait_queue); > > > > > > +static struct srcu_struct wakeup_srcu;

Re: PM / wakeirq: Convert to SRCU

2017-06-25 Thread Paul E. McKenney
On Sun, Jun 25, 2017 at 11:11:57AM +0200, Thomas Gleixner wrote: > On Sat, 24 Jun 2017, Paul E. McKenney wrote: > > On Sat, Jun 24, 2017 at 11:56:11AM +0200, Thomas Gleixner wrote: > > > static DECLARE_WAIT_QUEUE_HEAD(wakeup_count_wait_queue); > > > > > > +static struct srcu_struct wakeup_srcu;

Re: [PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

2017-06-25 Thread Srishti Sharma
On Sun, Jun 25, 2017 at 8:01 PM, Greg KH wrote: > On Sat, Jun 24, 2017 at 08:58:10AM +0530, srishti sharma wrote: >> Fixed alignment so that it matched open parenthesis. >> >> Signed-off-by: srishti sharma > > Does your legal name not have

Re: [PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

2017-06-25 Thread Srishti Sharma
On Sun, Jun 25, 2017 at 8:01 PM, Greg KH wrote: > On Sat, Jun 24, 2017 at 08:58:10AM +0530, srishti sharma wrote: >> Fixed alignment so that it matched open parenthesis. >> >> Signed-off-by: srishti sharma > > Does your legal name not have capital letters? Please fix and resend. Sorry , yes !

Re: [PATCH/RFC 9/9] perf record: Add --module-dir option

2017-06-25 Thread Namhyung Kim
On Fri, Jun 23, 2017 at 11:45:24AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 23, 2017 at 02:48:27PM +0900, Namhyung Kim escreveu: > > Currently perf only searches module binaries on the canonical > > directory (/lib/modules/`uname -r`). But sometimes user needs to load > > local

Re: [PATCH/RFC 9/9] perf record: Add --module-dir option

2017-06-25 Thread Namhyung Kim
On Fri, Jun 23, 2017 at 11:45:24AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 23, 2017 at 02:48:27PM +0900, Namhyung Kim escreveu: > > Currently perf only searches module binaries on the canonical > > directory (/lib/modules/`uname -r`). But sometimes user needs to load > > local

[PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

2017-06-25 Thread Srishti Sharma
Fixed alignment so that it matched open parenthesis. Signed-off-by: Srishti Sharma --- Changes in v2: -Fix all checks of the type "alignment should match open parenthesis" for a file in the same patch. .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 18

[PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

2017-06-25 Thread Srishti Sharma
Fixed alignment so that it matched open parenthesis. Signed-off-by: Srishti Sharma --- Changes in v2: -Fix all checks of the type "alignment should match open parenthesis" for a file in the same patch. .../staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 18 +- 1 file

Re: [PATCH] staging: wlan-ng: Fix sparse warning: incorrect type in assignment This patch fixes the following sparse warning

2017-06-25 Thread Greg KH
On Fri, Jun 23, 2017 at 04:21:54AM +0200, AbdAllah-MEZITI wrote: > drivers/staging/wlan-ng/prism2mgmt.c:188:25: warning: incorrect type in > assignment (different base types) > drivers/staging/wlan-ng/prism2mgmt.c:188:25:expected unsigned short > [unsigned] [addressable] [usertype] tx_rate >

Re: [PATCH] staging: wlan-ng: Fix sparse warning: incorrect type in assignment This patch fixes the following sparse warning

2017-06-25 Thread Greg KH
On Fri, Jun 23, 2017 at 04:21:54AM +0200, AbdAllah-MEZITI wrote: > drivers/staging/wlan-ng/prism2mgmt.c:188:25: warning: incorrect type in > assignment (different base types) > drivers/staging/wlan-ng/prism2mgmt.c:188:25:expected unsigned short > [unsigned] [addressable] [usertype] tx_rate >

Re: [PATCH/RFC 5/9] perf symbols: Fixup the end address of kernel map properly

2017-06-25 Thread Namhyung Kim
On Fri, Jun 23, 2017 at 11:27:25AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 23, 2017 at 02:48:23PM +0900, Namhyung Kim escreveu: > > When /proc/kallsyms is used for kernel address, addresses in module can > > be changed when the module is reloaded. So if one did perf record with > >

Re: [PATCH/RFC 5/9] perf symbols: Fixup the end address of kernel map properly

2017-06-25 Thread Namhyung Kim
On Fri, Jun 23, 2017 at 11:27:25AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 23, 2017 at 02:48:23PM +0900, Namhyung Kim escreveu: > > When /proc/kallsyms is used for kernel address, addresses in module can > > be changed when the module is reloaded. So if one did perf record with > >

Re: [PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

2017-06-25 Thread Greg KH
On Sat, Jun 24, 2017 at 08:58:10AM +0530, srishti sharma wrote: > Fixed alignment so that it matched open parenthesis. > > Signed-off-by: srishti sharma Does your legal name not have capital letters? Please fix and resend. thanks, greg k-h

Re: [PATCH v2] Staging: vc04_services: bcm2835-audio: bcm2835-ctl.c: Fixed alignment to match open parenthesis.

2017-06-25 Thread Greg KH
On Sat, Jun 24, 2017 at 08:58:10AM +0530, srishti sharma wrote: > Fixed alignment so that it matched open parenthesis. > > Signed-off-by: srishti sharma Does your legal name not have capital letters? Please fix and resend. thanks, greg k-h

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 02:54:29PM +0100, Sudip Mukherjee wrote: > On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > > > From: Teddy

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 02:54:29PM +0100, Sudip Mukherjee wrote: > On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > > > From: Teddy

Re: [PATCH/RFC 4/9] perf symbols: Load kernel module symbols ASAP

2017-06-25 Thread Namhyung Kim
On Fri, Jun 23, 2017 at 11:26:04AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 23, 2017 at 02:48:22PM +0900, Namhyung Kim escreveu: > > When loading kernel symbols from /proc/kallsyms, it might have different > > addresses for modules. We should honor the mmap event recorded in a > >

Re: [PATCH/RFC 4/9] perf symbols: Load kernel module symbols ASAP

2017-06-25 Thread Namhyung Kim
On Fri, Jun 23, 2017 at 11:26:04AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 23, 2017 at 02:48:22PM +0900, Namhyung Kim escreveu: > > When loading kernel symbols from /proc/kallsyms, it might have different > > addresses for modules. We should honor the mmap event recorded in a > >

Re: [PATCH/RFC 6/9] perf symbols: Use already loaded module dso when loading kcore

2017-06-25 Thread Namhyung Kim
On Fri, Jun 23, 2017 at 10:55:47AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 23, 2017 at 02:48:24PM +0900, Namhyung Kim escreveu: > > Even every module has loaded onto same addresses, some modules can be > > changed and reloaded. > > Can you rephrase the above statement? > > You mean

Re: [PATCH/RFC 6/9] perf symbols: Use already loaded module dso when loading kcore

2017-06-25 Thread Namhyung Kim
On Fri, Jun 23, 2017 at 10:55:47AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 23, 2017 at 02:48:24PM +0900, Namhyung Kim escreveu: > > Even every module has loaded onto same addresses, some modules can be > > changed and reloaded. > > Can you rephrase the above statement? > > You mean

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > > From: Teddy Wang > > > > > > If vesafb is enabled in the

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > > From: Teddy Wang > > > > > > If vesafb is enabled in the config then /dev/fb0 is

Re: [PATCH/RFC 3/9] perf symbols: Discard symbols in kallsyms for loaded modules

2017-06-25 Thread Namhyung Kim
On Fri, Jun 23, 2017 at 10:51:05AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 23, 2017 at 02:48:21PM +0900, Namhyung Kim escreveu: > > If a module is already loaded, it should have symbols and no need to > > load new symbols from kallsyms. Actually kallsyms can have different > >

Re: [PATCH/RFC 3/9] perf symbols: Discard symbols in kallsyms for loaded modules

2017-06-25 Thread Namhyung Kim
On Fri, Jun 23, 2017 at 10:51:05AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 23, 2017 at 02:48:21PM +0900, Namhyung Kim escreveu: > > If a module is already loaded, it should have symbols and no need to > > load new symbols from kallsyms. Actually kallsyms can have different > >

printk + errno texts

2017-06-25 Thread Enrico Weigelt, metux IT consult
Hi folks, I'd like to introduce a new printk() conversion which prints out errno values as readable text. Where are these things defined ? I'd guess the actual translation must be somewhere in lib/vsprintf.c, but where are the format string checks defined ? thx --mtx

printk + errno texts

2017-06-25 Thread Enrico Weigelt, metux IT consult
Hi folks, I'd like to introduce a new printk() conversion which prints out errno values as readable text. Where are these things defined ? I'd guess the actual translation must be somewhere in lib/vsprintf.c, but where are the format string checks defined ? thx --mtx

Re: [RFC] memory corruption caused by efi driver?

2017-06-25 Thread Greg KH
On Sun, Jun 25, 2017 at 09:06:58PM +0800, Xishi Qiu wrote: > On 2017/6/24 19:12, Greg KH wrote: > > > On Sat, Jun 24, 2017 at 05:52:23PM +0800, Yisheng Xie wrote: > >> hi all, > >> > >> I met an Oops problem with linux-3.10. The RIP is > >> sysfs_open_file+0x46/0x2b0 (I will and the full > >>

Re: [RFC] memory corruption caused by efi driver?

2017-06-25 Thread Greg KH
On Sun, Jun 25, 2017 at 09:06:58PM +0800, Xishi Qiu wrote: > On 2017/6/24 19:12, Greg KH wrote: > > > On Sat, Jun 24, 2017 at 05:52:23PM +0800, Yisheng Xie wrote: > >> hi all, > >> > >> I met an Oops problem with linux-3.10. The RIP is > >> sysfs_open_file+0x46/0x2b0 (I will and the full > >>

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

2017-06-25 Thread Krzysztof Kozlowski
On Sun, Jun 25, 2017 at 06:53:24PM +0530, Anand Moon wrote: > Hi Willy, > > On 24 June 2017 at 02:39, Willy Wolff wrote: > > Odroid XU*-familly boards has thermal sensors per A15 cores, but the actual > > thermal-zones define only cooling-maps action for cpu0. > > > >

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

2017-06-25 Thread Krzysztof Kozlowski
On Sun, Jun 25, 2017 at 06:53:24PM +0530, Anand Moon wrote: > Hi Willy, > > On 24 June 2017 at 02:39, Willy Wolff wrote: > > Odroid XU*-familly boards has thermal sensors per A15 cores, but the actual > > thermal-zones define only cooling-maps action for cpu0. > > > > If the application is

[PATCH 1/3] include: usb: audio: specify exact endiannes of descriptors

2017-06-25 Thread Ruslan Bilovol
USB spec says that multiple byte fields are stored in little-endian order (see chapter 8.1 of USB2.0 spec and chapter 7.1 of USB3.0 spec), thus mark such fields as LE for UAC1 and UAC2 headers Signed-off-by: Ruslan Bilovol --- include/linux/usb/audio-v2.h | 14

[PATCH 1/3] include: usb: audio: specify exact endiannes of descriptors

2017-06-25 Thread Ruslan Bilovol
USB spec says that multiple byte fields are stored in little-endian order (see chapter 8.1 of USB2.0 spec and chapter 7.1 of USB3.0 spec), thus mark such fields as LE for UAC1 and UAC2 headers Signed-off-by: Ruslan Bilovol --- include/linux/usb/audio-v2.h | 14 +++---

[PATCH 3/3] usb: gadget: f_uac2: endianness fixes.

2017-06-25 Thread Ruslan Bilovol
As per USB spec, multiple-bytes fields are stored in little-endian order. Use CPU<->LE helpers for such fields. Signed-off-by: Ruslan Bilovol --- drivers/usb/gadget/function/f_uac2.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-)

[PATCH 3/3] usb: gadget: f_uac2: endianness fixes.

2017-06-25 Thread Ruslan Bilovol
As per USB spec, multiple-bytes fields are stored in little-endian order. Use CPU<->LE helpers for such fields. Signed-off-by: Ruslan Bilovol --- drivers/usb/gadget/function/f_uac2.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git

[PATCH 0/3] USB Audio gadget endianness fixes

2017-06-25 Thread Ruslan Bilovol
Audio gadget refactoring patches touched few function files and triggered kbuild test robot verification who found some endianness issues by sparse tool. Since most of these issues existed from beginning in f_uac2 and f_uac1_legacy drivers (and were inherited be f_uac1), it seems nobody run audio

[PATCH 2/3] usb: gadget: f_uac1: endianness fixes.

2017-06-25 Thread Ruslan Bilovol
As per USB spec, multiple-bytes fields are stored in little-endian order. Use CPU<->LE helpers for such fields. Signed-off-by: Ruslan Bilovol --- drivers/usb/gadget/function/f_uac1.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff

[PATCH 0/3] USB Audio gadget endianness fixes

2017-06-25 Thread Ruslan Bilovol
Audio gadget refactoring patches touched few function files and triggered kbuild test robot verification who found some endianness issues by sparse tool. Since most of these issues existed from beginning in f_uac2 and f_uac1_legacy drivers (and were inherited be f_uac1), it seems nobody run audio

[PATCH 2/3] usb: gadget: f_uac1: endianness fixes.

2017-06-25 Thread Ruslan Bilovol
As per USB spec, multiple-bytes fields are stored in little-endian order. Use CPU<->LE helpers for such fields. Signed-off-by: Ruslan Bilovol --- drivers/usb/gadget/function/f_uac1.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

2017-06-25 Thread Anand Moon
Hi Willy, On 24 June 2017 at 02:39, Willy Wolff wrote: > Odroid XU*-familly boards has thermal sensors per A15 cores, but the actual > thermal-zones define only cooling-maps action for cpu0. > > If the application is running on all cores but core4 (first core of the

Re: [PATCH] ARM: dts: exynos: Exynos5422 Odroid-XU* incomplete thermal-zones definition

2017-06-25 Thread Anand Moon
Hi Willy, On 24 June 2017 at 02:39, Willy Wolff wrote: > Odroid XU*-familly boards has thermal sensors per A15 cores, but the actual > thermal-zones define only cooling-maps action for cpu0. > > If the application is running on all cores but core4 (first core of the A15 > cluster), the CPU can

Re: [RFC] memory corruption caused by efi driver?

2017-06-25 Thread Xishi Qiu
On 2017/6/24 19:12, Greg KH wrote: > On Sat, Jun 24, 2017 at 05:52:23PM +0800, Yisheng Xie wrote: >> hi all, >> >> I met an Oops problem with linux-3.10. The RIP is sysfs_open_file+0x46/0x2b0 >> (I will and the full >> crash log in the end of this mail). > > 3.10 is _very_ old and obsolete, can

Re: [RFC] memory corruption caused by efi driver?

2017-06-25 Thread Xishi Qiu
On 2017/6/24 19:12, Greg KH wrote: > On Sat, Jun 24, 2017 at 05:52:23PM +0800, Yisheng Xie wrote: >> hi all, >> >> I met an Oops problem with linux-3.10. The RIP is sysfs_open_file+0x46/0x2b0 >> (I will and the full >> crash log in the end of this mail). > > 3.10 is _very_ old and obsolete, can

Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 08:22:06AM -0400, Tommy Nguyen wrote: > Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE > and debugfs_create_file_unsafe should be used instead. Why use the _unsafe version? Are you sure it will work properly? What benifit does it offer? > > Signed-off-by:

Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 08:22:06AM -0400, Tommy Nguyen wrote: > Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE > and debugfs_create_file_unsafe should be used instead. Why use the _unsafe version? Are you sure it will work properly? What benifit does it offer? > > Signed-off-by:

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > From: Teddy Wang > > > > If vesafb is enabled in the config then /dev/fb0 is created by vesa > > and this sm750 driver gets fb1,

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > From: Teddy Wang > > > > If vesafb is enabled in the config then /dev/fb0 is created by vesa > > and this sm750 driver gets fb1, fb2. But we need to be fb0 and

Re: [PATCH] android: Update maintainer's e-mail in TODO

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 08:17:23AM -0400, Tommy Nguyen wrote: > See https://lkml.org/lkml/2012/1/31/505 What does a 5 year old email have to do with anything? > Changes dead e-mail to maintainer's current e-mail. Since when is my email address "dead"? Sorry, but this patch makes no sense at

Re: [PATCH] android: Update maintainer's e-mail in TODO

2017-06-25 Thread Greg Kroah-Hartman
On Sun, Jun 25, 2017 at 08:17:23AM -0400, Tommy Nguyen wrote: > See https://lkml.org/lkml/2012/1/31/505 What does a 5 year old email have to do with anything? > Changes dead e-mail to maintainer's current e-mail. Since when is my email address "dead"? Sorry, but this patch makes no sense at

[PATCH] staging: lustre: replace kmalloc with kmalloc_array

2017-06-25 Thread Denis Petrovic
This patch fixes the following checkpatch.pl warning: WARNING: Prefer kmalloc_array over kmalloc with multiply Signed-off-by: Denis Petrovic --- drivers/staging/lustre/lnet/libcfs/linux/linux-tracefile.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH] staging: lustre: replace kmalloc with kmalloc_array

2017-06-25 Thread Denis Petrovic
This patch fixes the following checkpatch.pl warning: WARNING: Prefer kmalloc_array over kmalloc with multiply Signed-off-by: Denis Petrovic --- drivers/staging/lustre/lnet/libcfs/linux/linux-tracefile.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH] ocfs2: free 'dummy_sc' in sc_fop_release() in case of memory leak

2017-06-25 Thread piaojun
'sd->dbg_sock' is malloc in sc_common_open(), but not freed at the end of sc_fop_release(). Signed-off-by: Jun Piao --- fs/ocfs2/cluster/netdebug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ocfs2/cluster/netdebug.c b/fs/ocfs2/cluster/netdebug.c index

[PATCH] ocfs2: free 'dummy_sc' in sc_fop_release() in case of memory leak

2017-06-25 Thread piaojun
'sd->dbg_sock' is malloc in sc_common_open(), but not freed at the end of sc_fop_release(). Signed-off-by: Jun Piao --- fs/ocfs2/cluster/netdebug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ocfs2/cluster/netdebug.c b/fs/ocfs2/cluster/netdebug.c index 564c504..74a21f6 100644 ---

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > From: Teddy Wang > > If vesafb is enabled in the config then /dev/fb0 is created by vesa > and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to > effectively work with xorg. > So if

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

2017-06-25 Thread Sudip Mukherjee
On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > From: Teddy Wang > > If vesafb is enabled in the config then /dev/fb0 is created by vesa > and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to > effectively work with xorg. > So if it has been alloted fb1, then

Re: [PATCH v1 5/6] [media] ov9650: add multiple variant support

2017-06-25 Thread kbuild test robot
-of-OV9655-camera/20170625-201153 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x079-06251032 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones

Re: [PATCH v1 5/6] [media] ov9650: add multiple variant support

2017-06-25 Thread kbuild test robot
-of-OV9655-camera/20170625-201153 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-x079-06251032 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones

[PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

2017-06-25 Thread Tommy Nguyen
Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE and debugfs_create_file_unsafe should be used instead. Signed-off-by: Tommy Nguyen --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

2017-06-25 Thread Tommy Nguyen
Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE and debugfs_create_file_unsafe should be used instead. Signed-off-by: Tommy Nguyen --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion.c

[PATCH] android: Update maintainer's e-mail in TODO

2017-06-25 Thread Tommy Nguyen
See https://lkml.org/lkml/2012/1/31/505 Changes dead e-mail to maintainer's current e-mail. Signed-off-by: Tommy Nguyen --- drivers/staging/android/TODO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/TODO

[PATCH] android: Update maintainer's e-mail in TODO

2017-06-25 Thread Tommy Nguyen
See https://lkml.org/lkml/2012/1/31/505 Changes dead e-mail to maintainer's current e-mail. Signed-off-by: Tommy Nguyen --- drivers/staging/android/TODO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/TODO b/drivers/staging/android/TODO index

<    1   2   3   4   5   6   >