Re: [PATCH v6 2/2] x86/refcount: Implement fast refcount overflow protection

2017-07-19 Thread Josh Poimboeuf
On Wed, Jul 19, 2017 at 04:12:37PM -0700, Kees Cook wrote: > On Wed, Jul 19, 2017 at 12:37 PM, Josh Poimboeuf wrote: > > +#define ASM_UNREACHABLE > > \ > > + "999: .pushsection .discard.unreachable\n\t"

Re: [PATCH v6 2/2] x86/refcount: Implement fast refcount overflow protection

2017-07-19 Thread Josh Poimboeuf
On Wed, Jul 19, 2017 at 04:12:37PM -0700, Kees Cook wrote: > On Wed, Jul 19, 2017 at 12:37 PM, Josh Poimboeuf wrote: > > +#define ASM_UNREACHABLE > > \ > > + "999: .pushsection .discard.unreachable\n\t"\ > > +

Re: http://www.remword.com/kps_result/ unavailable!

2017-07-19 Thread Randy Dunlap
On 10/31/2016 07:59 AM, Geert Uytterhoeven wrote: > Hi Michael, > > On Fri, Sep 16, 2016 at 4:11 PM, Michael Opdenacker > wrote: >> I've just detected that the http://www.remword.com/kps_result/ page with the >> Kernel Patch Statistics is gone :( > > Oops,

Re: http://www.remword.com/kps_result/ unavailable!

2017-07-19 Thread Randy Dunlap
On 10/31/2016 07:59 AM, Geert Uytterhoeven wrote: > Hi Michael, > > On Fri, Sep 16, 2016 at 4:11 PM, Michael Opdenacker > wrote: >> I've just detected that the http://www.remword.com/kps_result/ page with the >> Kernel Patch Statistics is gone :( > > Oops, I knew the statistics hadn't been

[PATCH v4 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

2017-07-19 Thread Rajmohan Mani
The Kabylake platform coreboot (Chrome OS equivalent of BIOS) has defined 4 operation regions for the TI TPS68470 PMIC. These operation regions are to enable/disable voltage regulators, configure voltage regulators, enable/disable clocks and to configure clocks. This config adds ACPI operation

[PATCH v4 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation region driver

2017-07-19 Thread Rajmohan Mani
The Kabylake platform coreboot (Chrome OS equivalent of BIOS) has defined 4 operation regions for the TI TPS68470 PMIC. These operation regions are to enable/disable voltage regulators, configure voltage regulators, enable/disable clocks and to configure clocks. This config adds ACPI operation

[PATCH v4 2/3] gpio: Add support for TPS68470 GPIOs

2017-07-19 Thread Rajmohan Mani
This patch adds support for TPS68470 GPIOs. There are 7 GPIOs and a few sensor related GPIOs. These GPIOs can be requested and configured as appropriate. The GPIOs are also provided with descriptive names. However, the typical use case is that the OS GPIO driver will interact with TPS68470 GPIO

[PATCH v4 2/3] gpio: Add support for TPS68470 GPIOs

2017-07-19 Thread Rajmohan Mani
This patch adds support for TPS68470 GPIOs. There are 7 GPIOs and a few sensor related GPIOs. These GPIOs can be requested and configured as appropriate. The GPIOs are also provided with descriptive names. However, the typical use case is that the OS GPIO driver will interact with TPS68470 GPIO

[PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-19 Thread Rajmohan Mani
The TPS68470 device is an advanced power management unit that powers a Compact Camera Module (CCM), generates clocks for image sensors, drives a dual LED for Flash and incorporates two LED drivers for general purpose indicators. This patch adds support for TPS68470 mfd device. Signed-off-by:

[PATCH v4 1/3] mfd: Add new mfd device TPS68470

2017-07-19 Thread Rajmohan Mani
The TPS68470 device is an advanced power management unit that powers a Compact Camera Module (CCM), generates clocks for image sensors, drives a dual LED for Flash and incorporates two LED drivers for general purpose indicators. This patch adds support for TPS68470 mfd device. Signed-off-by:

Re: [PATCH net-next] net: dsa: unexport dsa_is_port_initialized

2017-07-19 Thread David Miller
From: Vivien Didelot Date: Tue, 18 Jul 2017 16:23:56 -0400 > The dsa_is_port_initialized helper is only used by dsa_switch_resume and > dsa_switch_suspend, if CONFIG_PM_SLEEP is enabled. Make it static to > dsa.c. > > Signed-off-by: Vivien Didelot

Re: [PATCH net-next] net: dsa: unexport dsa_is_port_initialized

2017-07-19 Thread David Miller
From: Vivien Didelot Date: Tue, 18 Jul 2017 16:23:56 -0400 > The dsa_is_port_initialized helper is only used by dsa_switch_resume and > dsa_switch_suspend, if CONFIG_PM_SLEEP is enabled. Make it static to > dsa.c. > > Signed-off-by: Vivien Didelot Applied.

[PATCH v4 0/3] TPS68470 PMIC drivers

2017-07-19 Thread Rajmohan Mani
This is the patch series for TPS68470 PMIC that works as a camera PMIC. The patch series provide the following 3 drivers, to help configure the voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be able to use the camera sensors connected to this PMIC. TPS68470 MFD driver:

[PATCH v4 0/3] TPS68470 PMIC drivers

2017-07-19 Thread Rajmohan Mani
This is the patch series for TPS68470 PMIC that works as a camera PMIC. The patch series provide the following 3 drivers, to help configure the voltage regulators, clocks and GPIOs provided by the TPS68470 PMIC, to be able to use the camera sensors connected to this PMIC. TPS68470 MFD driver:

Re: [PATCH v1 1/1] dt-binding: ptp: Add SoC compatibility strings for dte ptp clock

2017-07-19 Thread David Miller
From: Arun Parameswaran Date: Tue, 18 Jul 2017 10:14:16 -0700 > Hi David, > > On 17-07-10 06:44 AM, Rob Herring wrote: >> On Thu, Jul 06, 2017 at 10:37:57AM -0700, Arun Parameswaran wrote: >>> Add SoC specific compatibility strings to the Broadcom DTE >>> based

Re: [PATCH v1 1/1] dt-binding: ptp: Add SoC compatibility strings for dte ptp clock

2017-07-19 Thread David Miller
From: Arun Parameswaran Date: Tue, 18 Jul 2017 10:14:16 -0700 > Hi David, > > On 17-07-10 06:44 AM, Rob Herring wrote: >> On Thu, Jul 06, 2017 at 10:37:57AM -0700, Arun Parameswaran wrote: >>> Add SoC specific compatibility strings to the Broadcom DTE >>> based PTP clock binding document. >>>

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

2017-07-19 Thread Mani, Rajmohan
Hi Lee, > > On Fri, 09 Jun 2017, Mani, Rajmohan wrote: > > > > > Hi Andy, > > > > > > > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote: > > > > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani > > > > wrote: > > > > > > The TPS68470 device is an advanced

RE: [PATCH v1 1/3] mfd: Add new mfd device TPS68470

2017-07-19 Thread Mani, Rajmohan
Hi Lee, > > On Fri, 09 Jun 2017, Mani, Rajmohan wrote: > > > > > Hi Andy, > > > > > > > On Tue, Jun 06, 2017 at 03:59:49PM +0300, Andy Shevchenko wrote: > > > > > On Tue, Jun 6, 2017 at 2:55 PM, Rajmohan Mani > > > > wrote: > > > > > > The TPS68470 device is an advanced power management unit

Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t

2017-07-19 Thread Kees Cook
On Wed, Jul 19, 2017 at 4:11 PM, Davidlohr Bueso wrote: > On Wed, 19 Jul 2017, Andrew Morton wrote: > >> On Wed, 19 Jul 2017 15:54:27 -0700 Davidlohr Bueso >> wrote: >> >>> On Wed, 19 Jul 2017, Andrew Morton wrote: >>> >>> >I do rather dislike these

Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t

2017-07-19 Thread Kees Cook
On Wed, Jul 19, 2017 at 4:11 PM, Davidlohr Bueso wrote: > On Wed, 19 Jul 2017, Andrew Morton wrote: > >> On Wed, 19 Jul 2017 15:54:27 -0700 Davidlohr Bueso >> wrote: >> >>> On Wed, 19 Jul 2017, Andrew Morton wrote: >>> >>> >I do rather dislike these conversions from the point of view of >>>

Re: cpuidle and cpufreq coupling?

2017-07-19 Thread Rafael J. Wysocki
On Thu, Jul 20, 2017 at 12:54 AM, Florian Fainelli wrote: > Hi, > > We have a particular ARM CPU design that is drawing quite a lot of > current upon exit from WFI, and it does so in a way even before the > first instruction out of WFI is executed. That means we cannot

Re: cpuidle and cpufreq coupling?

2017-07-19 Thread Rafael J. Wysocki
On Thu, Jul 20, 2017 at 12:54 AM, Florian Fainelli wrote: > Hi, > > We have a particular ARM CPU design that is drawing quite a lot of > current upon exit from WFI, and it does so in a way even before the > first instruction out of WFI is executed. That means we cannot influence > directly the

Re: [PATCH V2 net-next 12/21] net-next/hinic: Add qp resources

2017-07-19 Thread David Miller
From: Aviad Krawczyk Date: Wed, 19 Jul 2017 17:19:10 +0800 > diff --git a/drivers/net/ethernet/huawei/hinic/Makefile > b/drivers/net/ethernet/huawei/hinic/Makefile > index 519382b..24728f0 100644 > --- a/drivers/net/ethernet/huawei/hinic/Makefile > +++

Re: [PATCH V2 net-next 12/21] net-next/hinic: Add qp resources

2017-07-19 Thread David Miller
From: Aviad Krawczyk Date: Wed, 19 Jul 2017 17:19:10 +0800 > diff --git a/drivers/net/ethernet/huawei/hinic/Makefile > b/drivers/net/ethernet/huawei/hinic/Makefile > index 519382b..24728f0 100644 > --- a/drivers/net/ethernet/huawei/hinic/Makefile > +++

Re: [PATCH v6 2/2] x86/refcount: Implement fast refcount overflow protection

2017-07-19 Thread Kees Cook
On Wed, Jul 19, 2017 at 12:37 PM, Josh Poimboeuf wrote: > +#define ASM_UNREACHABLE > \ > + "999: .pushsection .discard.unreachable\n\t"\ > + ".long 999b - .\n\t"

Re: [PATCH v6 2/2] x86/refcount: Implement fast refcount overflow protection

2017-07-19 Thread Kees Cook
On Wed, Jul 19, 2017 at 12:37 PM, Josh Poimboeuf wrote: > +#define ASM_UNREACHABLE > \ > + "999: .pushsection .discard.unreachable\n\t"\ > + ".long 999b - .\n\t"\ >

Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t

2017-07-19 Thread Davidlohr Bueso
On Wed, 19 Jul 2017, Andrew Morton wrote: On Wed, 19 Jul 2017 15:54:27 -0700 Davidlohr Bueso wrote: On Wed, 19 Jul 2017, Andrew Morton wrote: >I do rather dislike these conversions from the point of view of >performance overhead and general code bloat. But I seem to have

Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t

2017-07-19 Thread Davidlohr Bueso
On Wed, 19 Jul 2017, Andrew Morton wrote: On Wed, 19 Jul 2017 15:54:27 -0700 Davidlohr Bueso wrote: On Wed, 19 Jul 2017, Andrew Morton wrote: >I do rather dislike these conversions from the point of view of >performance overhead and general code bloat. But I seem to have lost >that

Re: [linux-sunxi] [PATCH v4 4/5] ARM: sunxi: h3/h5: switch apb0-related clocks to r_ccu

2017-07-19 Thread Ondřej Jirman
Hi, Icenowy Zheng píše v Út 04. 04. 2017 v 17:50 +0800: > From: Icenowy Zheng > > Now we have driver for the PRCM CCU, switch to use it instead of > old-style clock nodes for apb0-related clocks in sunxi-h3-h5.dtsi . > > The mux 3 of R_CCU is still the internal oscillator,

Re: [linux-sunxi] [PATCH v4 4/5] ARM: sunxi: h3/h5: switch apb0-related clocks to r_ccu

2017-07-19 Thread Ondřej Jirman
Hi, Icenowy Zheng píše v Út 04. 04. 2017 v 17:50 +0800: > From: Icenowy Zheng > > Now we have driver for the PRCM CCU, switch to use it instead of > old-style clock nodes for apb0-related clocks in sunxi-h3-h5.dtsi . > > The mux 3 of R_CCU is still the internal oscillator, which is said to be

[PATCH 3/3] can: m_can: Add PM Runtime

2017-07-19 Thread Franklin S Cooper Jr
Add support for PM Runtime which is the new way to handle managing clocks. However, to avoid breaking SoCs not using PM_RUNTIME leave the old clk management approach in place. PM_RUNTIME is required by OMAP based devices to handle clock management. Therefore, this allows future Texas Instruments

[PATCH 1/3] can: m_can: Make hclk optional

2017-07-19 Thread Franklin S Cooper Jr
Hclk is the MCAN's interface clock. However, for OMAP based devices such as DRA7 SoC family the interface clock is handled by hwmod. Therefore, this interface clock is managed by hwmod driver via pm_runtime_get and pm_runtime_put calls. Therefore, this interface clock isn't defined in DT and thus

[PATCH 3/3] can: m_can: Add PM Runtime

2017-07-19 Thread Franklin S Cooper Jr
Add support for PM Runtime which is the new way to handle managing clocks. However, to avoid breaking SoCs not using PM_RUNTIME leave the old clk management approach in place. PM_RUNTIME is required by OMAP based devices to handle clock management. Therefore, this allows future Texas Instruments

[PATCH 1/3] can: m_can: Make hclk optional

2017-07-19 Thread Franklin S Cooper Jr
Hclk is the MCAN's interface clock. However, for OMAP based devices such as DRA7 SoC family the interface clock is handled by hwmod. Therefore, this interface clock is managed by hwmod driver via pm_runtime_get and pm_runtime_put calls. Therefore, this interface clock isn't defined in DT and thus

[PATCH 2/3] can: m_can: Update documentation to indicate that hclk may be optional

2017-07-19 Thread Franklin S Cooper Jr
Update the documentation to reflect that hclk is now an optional clock. Signed-off-by: Franklin S Cooper Jr --- Documentation/devicetree/bindings/net/can/m_can.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 2/3] can: m_can: Update documentation to indicate that hclk may be optional

2017-07-19 Thread Franklin S Cooper Jr
Update the documentation to reflect that hclk is now an optional clock. Signed-off-by: Franklin S Cooper Jr --- Documentation/devicetree/bindings/net/can/m_can.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 7:06 GMT+08:00 Nadav Amit : > Wanpeng Li wrote: > >> 2017-07-20 6:53 GMT+08:00 Nadav Amit : >>> Wanpeng Li wrote: >>> 2017-07-20 0:25 GMT+08:00 Nadav Amit : > Radim

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Nadav Amit
Wanpeng Li wrote: > 2017-07-20 6:53 GMT+08:00 Nadav Amit : >> Wanpeng Li wrote: >> >>> 2017-07-20 0:25 GMT+08:00 Nadav Amit : Radim Krčmář wrote: > 2017-07-19 08:14-0700,

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 7:06 GMT+08:00 Nadav Amit : > Wanpeng Li wrote: > >> 2017-07-20 6:53 GMT+08:00 Nadav Amit : >>> Wanpeng Li wrote: >>> 2017-07-20 0:25 GMT+08:00 Nadav Amit : > Radim Krčmář wrote: > >> 2017-07-19 08:14-0700, Nadav Amit: >>> Radim Krčmář wrote: @@ -2363,6

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Nadav Amit
Wanpeng Li wrote: > 2017-07-20 6:53 GMT+08:00 Nadav Amit : >> Wanpeng Li wrote: >> >>> 2017-07-20 0:25 GMT+08:00 Nadav Amit : Radim Krčmář wrote: > 2017-07-19 08:14-0700, Nadav Amit: >> Radim Krčmář wrote: >>> @@ -2363,6 +2368,8 @@ static unsigned long

[PATCH 0/3] can: m_can: Add PM Runtime Support

2017-07-19 Thread Franklin S Cooper Jr
Add PM runtime support to the MCAN driver. To support devices that don't use PM runtime leave the original clk calls in the driver. Perhaps in the future when it makes sense we can remove these non pm runtime clk calls. Franklin S Cooper Jr (3): can: m_can: Make hclk optional can: m_can:

[PATCH 0/3] can: m_can: Add PM Runtime Support

2017-07-19 Thread Franklin S Cooper Jr
Add PM runtime support to the MCAN driver. To support devices that don't use PM runtime leave the original clk calls in the driver. Perhaps in the future when it makes sense we can remove these non pm runtime clk calls. Franklin S Cooper Jr (3): can: m_can: Make hclk optional can: m_can:

Re: [PATCH v6 2/2] x86/refcount: Implement fast refcount overflow protection

2017-07-19 Thread Josh Poimboeuf
On Wed, Jul 19, 2017 at 03:50:14PM -0700, Kees Cook wrote: > >> > }) > >> > + > >> > +#define ASM_UNREACHABLE > >> >\ > >> > + "999: .pushsection .discard.unreachable\n\t"\ > >> > + ".long 999b - .\n\t"

Re: [PATCH v6 2/2] x86/refcount: Implement fast refcount overflow protection

2017-07-19 Thread Josh Poimboeuf
On Wed, Jul 19, 2017 at 03:50:14PM -0700, Kees Cook wrote: > >> > }) > >> > + > >> > +#define ASM_UNREACHABLE > >> >\ > >> > + "999: .pushsection .discard.unreachable\n\t"\ > >> > + ".long 999b - .\n\t"

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 6:53 GMT+08:00 Nadav Amit : > Wanpeng Li wrote: > >> 2017-07-20 0:25 GMT+08:00 Nadav Amit : >>> Radim Krčmář wrote: >>> 2017-07-19 08:14-0700, Nadav Amit: > Radim Krčmář

Re: [PATCH -next v3 0/9] rbtree: Cache leftmost node internally

2017-07-19 Thread Davidlohr Bueso
On Wed, 19 Jul 2017, Andrew Morton wrote: On Thu, 29 Jun 2017 10:15:44 -0700 Davidlohr Bueso wrote: Changes from v2 (https://lkml.org/lkml/2017/6/8/857): - Fixed 0day reported crash for drm_mm selftest program. We were not correctly using the cached version of rbtree with

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 6:53 GMT+08:00 Nadav Amit : > Wanpeng Li wrote: > >> 2017-07-20 0:25 GMT+08:00 Nadav Amit : >>> Radim Krčmář wrote: >>> 2017-07-19 08:14-0700, Nadav Amit: > Radim Krčmář wrote: >> @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct >> kvm_vcpu *vcpu)

Re: [PATCH -next v3 0/9] rbtree: Cache leftmost node internally

2017-07-19 Thread Davidlohr Bueso
On Wed, 19 Jul 2017, Andrew Morton wrote: On Thu, 29 Jun 2017 10:15:44 -0700 Davidlohr Bueso wrote: Changes from v2 (https://lkml.org/lkml/2017/6/8/857): - Fixed 0day reported crash for drm_mm selftest program. We were not correctly using the cached version of rbtree with the allocated

Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t

2017-07-19 Thread Andrew Morton
On Wed, 19 Jul 2017 15:54:27 -0700 Davidlohr Bueso wrote: > On Wed, 19 Jul 2017, Andrew Morton wrote: > > >I do rather dislike these conversions from the point of view of > >performance overhead and general code bloat. But I seem to have lost > >that struggle and I don't

Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t

2017-07-19 Thread Andrew Morton
On Wed, 19 Jul 2017 15:54:27 -0700 Davidlohr Bueso wrote: > On Wed, 19 Jul 2017, Andrew Morton wrote: > > >I do rather dislike these conversions from the point of view of > >performance overhead and general code bloat. But I seem to have lost > >that struggle and I don't think any of these are

Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t

2017-07-19 Thread Davidlohr Bueso
On Wed, 19 Jul 2017, Andrew Morton wrote: I do rather dislike these conversions from the point of view of performance overhead and general code bloat. But I seem to have lost that struggle and I don't think any of these are fastpath(?). Well, since we now have fd25d19 (locking/refcount:

Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t

2017-07-19 Thread Davidlohr Bueso
On Wed, 19 Jul 2017, Andrew Morton wrote: I do rather dislike these conversions from the point of view of performance overhead and general code bloat. But I seem to have lost that struggle and I don't think any of these are fastpath(?). Well, since we now have fd25d19 (locking/refcount:

cpuidle and cpufreq coupling?

2017-07-19 Thread Florian Fainelli
Hi, We have a particular ARM CPU design that is drawing quite a lot of current upon exit from WFI, and it does so in a way even before the first instruction out of WFI is executed. That means we cannot influence directly the exit from WFI other than by changing the state in which it would be

cpuidle and cpufreq coupling?

2017-07-19 Thread Florian Fainelli
Hi, We have a particular ARM CPU design that is drawing quite a lot of current upon exit from WFI, and it does so in a way even before the first instruction out of WFI is executed. That means we cannot influence directly the exit from WFI other than by changing the state in which it would be

Re: [PATCH -next v3 0/9] rbtree: Cache leftmost node internally

2017-07-19 Thread Andrew Morton
On Thu, 29 Jun 2017 10:15:44 -0700 Davidlohr Bueso wrote: > Changes from v2 (https://lkml.org/lkml/2017/6/8/857): > - Fixed 0day reported crash for drm_mm selftest program. We were > not correctly using the cached version of rbtree with the allocated > nodes. > - Added cfq

Re: [PATCH -next v3 0/9] rbtree: Cache leftmost node internally

2017-07-19 Thread Andrew Morton
On Thu, 29 Jun 2017 10:15:44 -0700 Davidlohr Bueso wrote: > Changes from v2 (https://lkml.org/lkml/2017/6/8/857): > - Fixed 0day reported crash for drm_mm selftest program. We were > not correctly using the cached version of rbtree with the allocated > nodes. > - Added cfq patch to use internal

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Nadav Amit
Wanpeng Li wrote: > 2017-07-20 0:25 GMT+08:00 Nadav Amit : >> Radim Krčmář wrote: >> >>> 2017-07-19 08:14-0700, Nadav Amit: Radim Krčmář wrote: > @@ -2363,6 +2368,8 @@ static unsigned long

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Nadav Amit
Wanpeng Li wrote: > 2017-07-20 0:25 GMT+08:00 Nadav Amit : >> Radim Krčmář wrote: >> >>> 2017-07-19 08:14-0700, Nadav Amit: Radim Krčmář wrote: > @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct kvm_vcpu > *vcpu) > > static void vmx_set_rflags(struct

Re: [PATCH 15/17] fs/ext4: use cached rbtrees

2017-07-19 Thread Davidlohr Bueso
On Wed, 19 Jul 2017, Jan Kara wrote: Hum, so I'm somewhat undecided whether this is worth the churn. For free blocks rb_tree we use rb_first() only in ext4_mb_generate_from_freelist() which gets called only when generating new buddy bitmap from on-disk bitmap and we traverse the whole tree

Re: [PATCH 15/17] fs/ext4: use cached rbtrees

2017-07-19 Thread Davidlohr Bueso
On Wed, 19 Jul 2017, Jan Kara wrote: Hum, so I'm somewhat undecided whether this is worth the churn. For free blocks rb_tree we use rb_first() only in ext4_mb_generate_from_freelist() which gets called only when generating new buddy bitmap from on-disk bitmap and we traverse the whole tree

Re: [PATCH v6 2/2] x86/refcount: Implement fast refcount overflow protection

2017-07-19 Thread Kees Cook
On Wed, Jul 19, 2017 at 12:52 PM, Josh Poimboeuf wrote: > On Wed, Jul 19, 2017 at 12:45:19PM -0700, Kees Cook wrote: >> > diff --git a/arch/x86/include/asm/refcount.h >> > b/arch/x86/include/asm/refcount.h >> > index 13b91e850a02..e7587db3487c 100644 >> > ---

Re: [PATCH v6 2/2] x86/refcount: Implement fast refcount overflow protection

2017-07-19 Thread Kees Cook
On Wed, Jul 19, 2017 at 12:52 PM, Josh Poimboeuf wrote: > On Wed, Jul 19, 2017 at 12:45:19PM -0700, Kees Cook wrote: >> > diff --git a/arch/x86/include/asm/refcount.h >> > b/arch/x86/include/asm/refcount.h >> > index 13b91e850a02..e7587db3487c 100644 >> > --- a/arch/x86/include/asm/refcount.h >>

[PATCH] bluetooth: btwilink: remove unnecessary static in bt_ti_probe()

2017-07-19 Thread Gustavo A. R. Silva
Remove unnecessary static on local variable hst. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following semantic patch:

[PATCH] bluetooth: btwilink: remove unnecessary static in bt_ti_probe()

2017-07-19 Thread Gustavo A. R. Silva
Remove unnecessary static on local variable hst. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following semantic patch:

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 0:25 GMT+08:00 Nadav Amit : > Radim Krčmář wrote: > >> 2017-07-19 08:14-0700, Nadav Amit: >>> Radim Krčmář wrote: @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct kvm_vcpu *vcpu) static

Re: [PATCH v2] KVM: VMX: Fix invalid guest state detection after task-switch emulation

2017-07-19 Thread Wanpeng Li
2017-07-20 0:25 GMT+08:00 Nadav Amit : > Radim Krčmář wrote: > >> 2017-07-19 08:14-0700, Nadav Amit: >>> Radim Krčmář wrote: @@ -2363,6 +2368,8 @@ static unsigned long vmx_get_rflags(struct kvm_vcpu *vcpu) static void vmx_set_rflags(struct kvm_vcpu *vcpu, unsigned long

[PATCH] soc: versatile: remove unnecessary static in realview_soc_probe()

2017-07-19 Thread Gustavo A. R. Silva
Remove unnecessary static on local variables syscon_regmap. Such variables are initialized before being used, on every execution path throughout the functions. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following

[PATCH] soc: versatile: remove unnecessary static in realview_soc_probe()

2017-07-19 Thread Gustavo A. R. Silva
Remove unnecessary static on local variables syscon_regmap. Such variables are initialized before being used, on every execution path throughout the functions. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following

[PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

2017-07-19 Thread Gustavo A. R. Silva
Remove unnecessary static on local variable syscon_regmap. Such variables are initialized before being used, on every execution path throughout the functions. So, the static has no benefit. This issue was detected using Coccinelle and the following semantic patch: @bad exists@ position p;

[PATCH] soc: integrator: remove unnecessary static in integrator_soc_init()

2017-07-19 Thread Gustavo A. R. Silva
Remove unnecessary static on local variable syscon_regmap. Such variables are initialized before being used, on every execution path throughout the functions. So, the static has no benefit. This issue was detected using Coccinelle and the following semantic patch: @bad exists@ position p;

[PATCH] cpu hotplug: Prevent Page Fault in cpuhp_remove_callbacks()

2017-07-19 Thread Ethan Barnes
Hi, There is a page fault in cpu hotplug when removing the callbacks for the last dynamic state. The last dynamic state will not be removed, causing a page fault when hotplug thinks the callbacks still exists and calls it. The problem is as follows: - __cpuhp_remove_state() eventually calls

[PATCH] cpu hotplug: Prevent Page Fault in cpuhp_remove_callbacks()

2017-07-19 Thread Ethan Barnes
Hi, There is a page fault in cpu hotplug when removing the callbacks for the last dynamic state. The last dynamic state will not be removed, causing a page fault when hotplug thinks the callbacks still exists and calls it. The problem is as follows: - __cpuhp_remove_state() eventually calls

Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t

2017-07-19 Thread Andrew Morton
On Sun, 09 Jul 2017 16:59:55 -0500 ebied...@xmission.com (Eric W. Biederman) wrote: > Elena Reshetova writes: > > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid

Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t

2017-07-19 Thread Andrew Morton
On Sun, 09 Jul 2017 16:59:55 -0500 ebied...@xmission.com (Eric W. Biederman) wrote: > Elena Reshetova writes: > > > refcount_t type and corresponding API should be > > used instead of atomic_t when the variable is used as > > a reference counter. This allows to avoid accidental > > refcounter

[PATCH] drm/i915/selftests: Fix an error handling path in 'mock_gem_device()'

2017-07-19 Thread Christophe JAILLET
Goto the right label in case of error, otherwise there is a leak. This has been introduced by c5cf9a9147ff. In this patch a goto has not been updated. Fixes: c5cf9a9147ff ("drm/i915: Create a kmem_cache to allocate struct i915_priolist from") Signed-off-by: Christophe JAILLET

[PATCH] drm/i915/selftests: Fix an error handling path in 'mock_gem_device()'

2017-07-19 Thread Christophe JAILLET
Goto the right label in case of error, otherwise there is a leak. This has been introduced by c5cf9a9147ff. In this patch a goto has not been updated. Fixes: c5cf9a9147ff ("drm/i915: Create a kmem_cache to allocate struct i915_priolist from") Signed-off-by: Christophe JAILLET ---

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

2017-07-19 Thread Francois Romieu
Aviad Krawczyk : [...] > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c > b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c > new file mode 100644 > index 000..fbc9de4 > --- /dev/null > +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c [...] >

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

2017-07-19 Thread Francois Romieu
Aviad Krawczyk : [...] > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c > b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c > new file mode 100644 > index 000..fbc9de4 > --- /dev/null > +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c [...] > +/** > + * hinic_init_hwdev

Re: [PATCH] llist: clang: introduce member_address_is_nonnull()

2017-07-19 Thread Sodagudi Prasad
Hi All, Observed boot up crash with clang in kerne/sched/core.c file sched_ttwu_pending() function, because it is using llist_for_each_entry_safe(). After pulling patch from “https://lkml.org/lkml/2017/7/19/1169, no crash observed. Tested-by: Sodagudi Prasad

Re: [PATCH] llist: clang: introduce member_address_is_nonnull()

2017-07-19 Thread Sodagudi Prasad
Hi All, Observed boot up crash with clang in kerne/sched/core.c file sched_ttwu_pending() function, because it is using llist_for_each_entry_safe(). After pulling patch from “https://lkml.org/lkml/2017/7/19/1169, no crash observed. Tested-by: Sodagudi Prasad -Thanks, Prasad -- The

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-19 Thread Dave Jiang
On 07/19/2017 03:16 PM, Christophe JAILLET wrote: > If the 'memcmp' fails, free allocated resources as done in all other > error handling paths. > > Signed-off-by: Christophe JAILLET Good catch! Thanks. Signed-off-by: Dave Jiang > --- >

Re: [PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-19 Thread Dave Jiang
On 07/19/2017 03:16 PM, Christophe JAILLET wrote: > If the 'memcmp' fails, free allocated resources as done in all other > error handling paths. > > Signed-off-by: Christophe JAILLET Good catch! Thanks. Signed-off-by: Dave Jiang > --- > Please review carefully, this patch looks "too

Re: [PATCH] mm, vmscan: do not loop on too_many_isolated for ever

2017-07-19 Thread Andrew Morton
On Mon, 10 Jul 2017 09:48:42 +0200 Michal Hocko wrote: > From: Michal Hocko > > Tetsuo Handa has reported [1][2][3]that direct reclaimers might get stuck > in too_many_isolated loop basically for ever because the last few pages > on the LRU lists are

Re: [PATCH] mm, vmscan: do not loop on too_many_isolated for ever

2017-07-19 Thread Andrew Morton
On Mon, 10 Jul 2017 09:48:42 +0200 Michal Hocko wrote: > From: Michal Hocko > > Tetsuo Handa has reported [1][2][3]that direct reclaimers might get stuck > in too_many_isolated loop basically for ever because the last few pages > on the LRU lists are isolated by the kswapd which is stuck on fs

Re: [PATCH 09/10] percpu: replace area map allocator with bitmap allocator

2017-07-19 Thread Dennis Zhou
Hi Josef, On Wed, Jul 19, 2017 at 07:11:06PM +, Josef Bacik wrote: > > This was a bear to review, I feel like it could be split into a few smaller > pieces. You are changing hinting, allocating/freeing, and how you find > chunks. > Those seem like good logical divisions to me. Overall the

Re: [PATCH 09/10] percpu: replace area map allocator with bitmap allocator

2017-07-19 Thread Dennis Zhou
Hi Josef, On Wed, Jul 19, 2017 at 07:11:06PM +, Josef Bacik wrote: > > This was a bear to review, I feel like it could be split into a few smaller > pieces. You are changing hinting, allocating/freeing, and how you find > chunks. > Those seem like good logical divisions to me. Overall the

[PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-19 Thread Christophe JAILLET
If the 'memcmp' fails, free allocated resources as done in all other error handling paths. Signed-off-by: Christophe JAILLET --- Please review carefully, this patch looks "too obvious" to me! --- drivers/dma/ioat/init.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] dmaengine: ioatdma: Fix error handling path in 'ioat_dma_self_test()'

2017-07-19 Thread Christophe JAILLET
If the 'memcmp' fails, free allocated resources as done in all other error handling paths. Signed-off-by: Christophe JAILLET --- Please review carefully, this patch looks "too obvious" to me! --- drivers/dma/ioat/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 09/10] percpu: replace area map allocator with bitmap allocator

2017-07-19 Thread Dennis Zhou
Hi Josef, Thanks for taking a look at my code. On Wed, Jul 19, 2017 at 07:16:35PM +, Josef Bacik wrote: > > Actually I decided I do want to complain about this. Have you considered > making > chunks statically sized, like slab does? We could avoid this whole bound_map > thing completely

Re: [PATCH 09/10] percpu: replace area map allocator with bitmap allocator

2017-07-19 Thread Dennis Zhou
Hi Josef, Thanks for taking a look at my code. On Wed, Jul 19, 2017 at 07:16:35PM +, Josef Bacik wrote: > > Actually I decided I do want to complain about this. Have you considered > making > chunks statically sized, like slab does? We could avoid this whole bound_map > thing completely

[PATCH] scsi: mpt3sas_scsih: remove unnecessary statics

2017-07-19 Thread Gustavo A. R. Silva
Remove unnecessary static on local variables raid_device. Such variables are initialized before being used, on every execution path throughout the functions. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following

[PATCH] scsi: mpt3sas_scsih: remove unnecessary statics

2017-07-19 Thread Gustavo A. R. Silva
Remove unnecessary static on local variables raid_device. Such variables are initialized before being used, on every execution path throughout the functions. The static has no benefit and, removing it reduces the object file size. This issue was detected using Coccinelle and the following

Re: [PATCH v3 1/5] mm: add vm_insert_mixed_mkwrite()

2017-07-19 Thread Ross Zwisler
On Wed, Jul 19, 2017 at 11:51:12AM -0600, Ross Zwisler wrote: > On Wed, Jul 19, 2017 at 04:16:59PM +0200, Jan Kara wrote: > > On Wed 28-06-17 16:01:48, Ross Zwisler wrote: > > > To be able to use the common 4k zero page in DAX we need to have our PTE > > > fault path look more like our PMD fault

Re: [PATCH v3 1/5] mm: add vm_insert_mixed_mkwrite()

2017-07-19 Thread Ross Zwisler
On Wed, Jul 19, 2017 at 11:51:12AM -0600, Ross Zwisler wrote: > On Wed, Jul 19, 2017 at 04:16:59PM +0200, Jan Kara wrote: > > On Wed 28-06-17 16:01:48, Ross Zwisler wrote: > > > To be able to use the common 4k zero page in DAX we need to have our PTE > > > fault path look more like our PMD fault

Re: [PATCH] documentation: Fix two-CPU control-dependency example

2017-07-19 Thread Paul E. McKenney
On Thu, Jul 20, 2017 at 06:33:26AM +0900, Akira Yokosawa wrote: > On 2017/07/20 2:43, Paul E. McKenney wrote: > > On Mon, Jul 17, 2017 at 05:24:42PM +0900, Akira Yokosawa wrote: > >> >From b798b9b631e237d285aa8699da00bfb8ced33bea Mon Sep 17 00:00:00 2001 > >> From: Akira Yokosawa

Re: [PATCH] documentation: Fix two-CPU control-dependency example

2017-07-19 Thread Paul E. McKenney
On Thu, Jul 20, 2017 at 06:33:26AM +0900, Akira Yokosawa wrote: > On 2017/07/20 2:43, Paul E. McKenney wrote: > > On Mon, Jul 17, 2017 at 05:24:42PM +0900, Akira Yokosawa wrote: > >> >From b798b9b631e237d285aa8699da00bfb8ced33bea Mon Sep 17 00:00:00 2001 > >> From: Akira Yokosawa > >> Date: Mon,

Re: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API

2017-07-19 Thread Andy Shevchenko
On Wed, Jul 19, 2017 at 11:18 PM, Haiyang Zhang wrote: >> struct hv_fcopy_hdr { >> __u32 operation; >> - uuid_le service_id0; /* currently unused */ >> - uuid_le service_id1; /* currently unused */ >> + __u8 service_id0[16]; /* currently unused */ >> +

Re: [PATCH v1 4/6] vmbus: Switch to use new generic UUID API

2017-07-19 Thread Andy Shevchenko
On Wed, Jul 19, 2017 at 11:18 PM, Haiyang Zhang wrote: >> struct hv_fcopy_hdr { >> __u32 operation; >> - uuid_le service_id0; /* currently unused */ >> - uuid_le service_id1; /* currently unused */ >> + __u8 service_id0[16]; /* currently unused */ >> + __u8

Re: [PATCH] Revert "x86/uaccess: Add stack frame output operand in get_user() inline asm"

2017-07-19 Thread Matthias Kaehlcke
El Wed, Jul 19, 2017 at 12:46:31PM -0500 Josh Poimboeuf ha dit: > On Thu, Jul 13, 2017 at 02:57:04PM -0700, Matthias Kaehlcke wrote: > > El Thu, Jul 13, 2017 at 04:34:06PM -0500 Josh Poimboeuf ha dit: > > > > > On Thu, Jul 13, 2017 at 02:12:45PM -0700, Matthias Kaehlcke wrote: > > > > El Thu,

Re: [PATCH] Revert "x86/uaccess: Add stack frame output operand in get_user() inline asm"

2017-07-19 Thread Matthias Kaehlcke
El Wed, Jul 19, 2017 at 12:46:31PM -0500 Josh Poimboeuf ha dit: > On Thu, Jul 13, 2017 at 02:57:04PM -0700, Matthias Kaehlcke wrote: > > El Thu, Jul 13, 2017 at 04:34:06PM -0500 Josh Poimboeuf ha dit: > > > > > On Thu, Jul 13, 2017 at 02:12:45PM -0700, Matthias Kaehlcke wrote: > > > > El Thu,

<    1   2   3   4   5   6   7   8   9   10   >