Re: [PATCH 2/2] mmc: Add mmc_force_detect_change_begin / _end functions

invite Jack from expressif 在 2017/7/21 22:35, Quentin Schulz 写道: From: Hans de Goede Some sdio devices have a multiple stage bring-up process. Specifically the esp8089 (for which an out of tree driver is available) loads firmware on the first call to its sdio-drivers' probe function and then

Re: [PATCH v2 2/4] cgroup: Allow bypass mode in subtree_control

Hello, Waiman. On Fri, Jul 21, 2017 at 04:34:51PM -0400, Waiman Long wrote: > The special prefix '#' attached to a controller name can now be written > into the cgroup.subtree_control file to set that controller in bypass > mode in all the child cgroups. The controller will show up in the >

Re: [PATCH v2 2/4] cgroup: Allow bypass mode in subtree_control

Hello, Waiman. On Fri, Jul 21, 2017 at 04:34:51PM -0400, Waiman Long wrote: > The special prefix '#' attached to a controller name can now be written > into the cgroup.subtree_control file to set that controller in bypass > mode in all the child cgroups. The controller will show up in the >

Re: [PATCH v2 1/4] cgroup: Child cgroup creation not allowed on invalid domain

Hello, Waiman. On Fri, Jul 21, 2017 at 04:34:50PM -0400, Waiman Long wrote: > When thread mode is used, it is possible that some cgroups may be > in an invalid state. Currently users may not be aware that they are > invalid until they try to migrate tasks over. This patch disallows > child cgroup

Re: [PATCH v2 1/4] cgroup: Child cgroup creation not allowed on invalid domain

Hello, Waiman. On Fri, Jul 21, 2017 at 04:34:50PM -0400, Waiman Long wrote: > When thread mode is used, it is possible that some cgroups may be > in an invalid state. Currently users may not be aware that they are > invalid until they try to migrate tasks over. This patch disallows > child cgroup

Re: [PATCH 038/102] mmc: dw_mmc: explicitly request exclusive reset control

On 2017/7/19 23:25, Philipp Zabel wrote: Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers

Re: [PATCH 038/102] mmc: dw_mmc: explicitly request exclusive reset control

On 2017/7/19 23:25, Philipp Zabel wrote: Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert all drivers

Re: [PATCH 054/102] PCI: rockchip: explicitly request exclusive reset control

Hi Philipp, On 2017/7/19 23:25, Philipp Zabel wrote: Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert

Re: [PATCH 054/102] PCI: rockchip: explicitly request exclusive reset control

Hi Philipp, On 2017/7/19 23:25, Philipp Zabel wrote: Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert

Re: [PATCH 3.18 36/68] Handle mismatched open calls

On Wed, Jul 19, 2017 at 06:39:13PM +, Pavel Shilovskiy wrote: > 2017-07-14 9:43 Ben Hutchings : > > On Fri, 2017-05-05 at 11:32 -0700, Greg Kroah-Hartman wrote: > > > 3.18-stable review patch.  If anyone has any objections, please let me > > > know. > > > > > >

Re: [PATCH 3.18 36/68] Handle mismatched open calls

On Wed, Jul 19, 2017 at 06:39:13PM +, Pavel Shilovskiy wrote: > 2017-07-14 9:43 Ben Hutchings : > > On Fri, 2017-05-05 at 11:32 -0700, Greg Kroah-Hartman wrote: > > > 3.18-stable review patch.  If anyone has any objections, please let me > > > know. > > > > > > -- > > > > >

Re: [PATCH 058/102] phy: rockchip-pcie: explicitly request exclusive reset control

Hi Philipp On 2017/7/19 23:26, Philipp Zabel wrote: Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert

Re: [PATCH 058/102] phy: rockchip-pcie: explicitly request exclusive reset control

Hi Philipp On 2017/7/19 23:26, Philipp Zabel wrote: Commit a53e35db70d1 ("reset: Ensure drivers are explicit when requesting reset lines") started to transition the reset control request API calls to explicitly state whether the driver needs exclusive or shared reset control behavior. Convert

Re: [PATCH v3 2/2] acpi/iort: numa: Add numa node mapping for smmuv3 devices

On Sat, Jul 22, 2017 at 8:53 AM, Hanjun Guo wrote: > Hi Ganapat, > > On 2017/6/8 12:44, Ganapatrao Kulkarni wrote: >> Add code to parse proximity domain in SMMUv3 IORT table to >> set numa node mapping for smmuv3 devices. >> >> Signed-off-by: Ganapatrao Kulkarni

Re: [PATCH v3 2/2] acpi/iort: numa: Add numa node mapping for smmuv3 devices

On Sat, Jul 22, 2017 at 8:53 AM, Hanjun Guo wrote: > Hi Ganapat, > > On 2017/6/8 12:44, Ganapatrao Kulkarni wrote: >> Add code to parse proximity domain in SMMUv3 IORT table to >> set numa node mapping for smmuv3 devices. >> >> Signed-off-by: Ganapatrao Kulkarni >> --- >>

[PATCH v2] ARM: zImage: Fix stack overflow in merge_fdt_bootargs()

This function is called very early on from head.S and currently sets up a stack frame of more than 1024 bytes: atags_to_fdt.c: In function ‘merge_fdt_bootargs’: atags_to_fdt.c:98:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] This causes a crash and

[PATCH v2] ARM: zImage: Fix stack overflow in merge_fdt_bootargs()

This function is called very early on from head.S and currently sets up a stack frame of more than 1024 bytes: atags_to_fdt.c: In function ‘merge_fdt_bootargs’: atags_to_fdt.c:98:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=] This causes a crash and

[PATCH v2 net] net: ethernet: mediatek: avoid potential invalid memory access

From: Sean Wang Potential dangerous invalid memory might be accessed if invalid mac value reflected from the forward port field in rxd4 caused by possible potential hardware defects. So added a simple sanity checker to avoid the kind of situation happening.

[PATCH v2 net] net: ethernet: mediatek: avoid potential invalid memory access

From: Sean Wang Potential dangerous invalid memory might be accessed if invalid mac value reflected from the forward port field in rxd4 caused by possible potential hardware defects. So added a simple sanity checker to avoid the kind of situation happening. Signed-off-by: Sean Wang Acked-by:

[PATCH v8 1/3] clk: nxp: clk-lpc32xx: rename clk_gate_is_enabled()

From: Gabriel Fernandez We need to export clk_gate_is_enabled() from clk framework, then to avoid compilation issue we have to rename clk_gate_is_enabled() in NXP LPC32xx clock driver. We changed all gate op with 'lpc32xx_' prefix: lpc32xx_clk_gate_enable(),

[PATCH v8 1/3] clk: nxp: clk-lpc32xx: rename clk_gate_is_enabled()

From: Gabriel Fernandez We need to export clk_gate_is_enabled() from clk framework, then to avoid compilation issue we have to rename clk_gate_is_enabled() in NXP LPC32xx clock driver. We changed all gate op with 'lpc32xx_' prefix: lpc32xx_clk_gate_enable(), lpc32xx_clk_gate_disable(),

[PATCH v8 2/3] clk: gate: expose clk_gate_ops::is_enabled

From: Gabriel Fernandez This patch exposes clk_gate_ops::is_enabled as functions that can be directly called and assigned in places like this so we don't need wrapper functions that do nothing besides forward the call. Signed-off-by: Gabriel Fernandez

[PATCH v8 2/3] clk: gate: expose clk_gate_ops::is_enabled

From: Gabriel Fernandez This patch exposes clk_gate_ops::is_enabled as functions that can be directly called and assigned in places like this so we don't need wrapper functions that do nothing besides forward the call. Signed-off-by: Gabriel Fernandez Suggested-by: Stephen Boyd ---

[PATCH v8 3/3] clk: stm32h7: Add stm32h743 clock driver

From: Gabriel Fernandez This patch enables clocks for STM32H743 boards. Signed-off-by: Gabriel Fernandez for MFD changes: Acked-by: Lee Jones for DT-Bindings Acked-by: Rob Herring ---

[PATCH v8 3/3] clk: stm32h7: Add stm32h743 clock driver

From: Gabriel Fernandez This patch enables clocks for STM32H743 boards. Signed-off-by: Gabriel Fernandez for MFD changes: Acked-by: Lee Jones for DT-Bindings Acked-by: Rob Herring --- .../devicetree/bindings/clock/st,stm32h7-rcc.txt | 71 + drivers/clk/Makefile

[PATCH v8 0/3] clk: stm32h7: Add stm32h743 clock driver

From: Gabriel Fernandez v8: - Documentation remarks from Valdimir: - rename 'rcc' node name into 'reset-clock-controller' - delete source paths into the device tree bindings documentation - other cosmetic changes v7: - Documentation: put

[PATCH v8 0/3] clk: stm32h7: Add stm32h743 clock driver

From: Gabriel Fernandez v8: - Documentation remarks from Valdimir: - rename 'rcc' node name into 'reset-clock-controller' - delete source paths into the device tree bindings documentation - other cosmetic changes v7: - Documentation: put 'st,syscfg' phandle in

Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote: > Hello Gabriel, > > On 07/19/2017 05:25 PM, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch enables clocks for STM32H743 boards. >> >> Signed-off-by: Gabriel Fernandez

Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote: > Hello Gabriel, > > On 07/19/2017 05:25 PM, gabriel.fernan...@st.com wrote: >> From: Gabriel Fernandez >> >> This patch enables clocks for STM32H743 boards. >> >> Signed-off-by: Gabriel Fernandez >> >> for MFD changes: >> Acked-by: Lee Jones

Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

On 07/21/2017 10:37 PM, Stephen Boyd wrote: > On 07/20, Vladimir Zapolskiy wrote: >> Hi Gabriel, >> >> On 07/20/2017 11:31 AM, Gabriel FERNANDEZ wrote: >>> Hi Vladimir, >>> >>> >>> On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote: Hello Gabriel, On 07/19/2017 05:25 PM,

Re: [PATCH v7 3/3] clk: stm32h7: Add stm32h743 clock driver

On 07/21/2017 10:37 PM, Stephen Boyd wrote: > On 07/20, Vladimir Zapolskiy wrote: >> Hi Gabriel, >> >> On 07/20/2017 11:31 AM, Gabriel FERNANDEZ wrote: >>> Hi Vladimir, >>> >>> >>> On 07/19/2017 11:20 PM, Vladimir Zapolskiy wrote: Hello Gabriel, On 07/19/2017 05:25 PM,

Re: [PATCH v3 0/4] Add xxhash and zstd modules

On Fri, Jul 21, 2017 at 11:56:21AM -0400, Austin S. Hemmelgarn wrote: > On 2017-07-20 17:27, Nick Terrell wrote: > > This patch set adds xxhash, zstd compression, and zstd decompression > > modules. It also adds zstd support to BtrFS and SquashFS. > > > > Each patch has relevant summaries,

Re: [PATCH v3 0/4] Add xxhash and zstd modules

On Fri, Jul 21, 2017 at 11:56:21AM -0400, Austin S. Hemmelgarn wrote: > On 2017-07-20 17:27, Nick Terrell wrote: > > This patch set adds xxhash, zstd compression, and zstd decompression > > modules. It also adds zstd support to BtrFS and SquashFS. > > > > Each patch has relevant summaries,

Re: [GIT PULL] xen: features and fixes for 4.13-rc2

On 21/07/17 22:57, Linus Torvalds wrote: > On Fri, Jul 21, 2017 at 3:17 AM, Juergen Gross wrote: >> drivers/xen/pvcalls-back.c | 1236 >> > > This really doesn't look like a fix. > > The merge window is over. > > So I'm not pulling

Re: [GIT PULL] xen: features and fixes for 4.13-rc2

On 21/07/17 22:57, Linus Torvalds wrote: > On Fri, Jul 21, 2017 at 3:17 AM, Juergen Gross wrote: >> drivers/xen/pvcalls-back.c | 1236 >> > > This really doesn't look like a fix. > > The merge window is over. > > So I'm not pulling this without way

Re: [PATCH net] net: ethernet: mediatek: avoid potential invalid memory access

Hi Sean, [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/sean-wang-mediatek-com/net-ethernet-mediatek-avoid-potential-invalid-memory-access/20170722-155541 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9

Re: [PATCH net] net: ethernet: mediatek: avoid potential invalid memory access

Hi Sean, [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/sean-wang-mediatek-com/net-ethernet-mediatek-avoid-potential-invalid-memory-access/20170722-155541 config: arm-allmodconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9

Re: [PATCH][media-next] media: dvb-frontends/stv0910: make various local variables static

Am Fri, 21 Jul 2017 12:06:35 +0100 schrieb Colin King : > From: Colin Ian King > > The list stvlist and arrays padc_lookup, s1_sn_lookup and s2_sn_lookup > do not need to be in global scope, so make them all static. > > Cleans up a bunch of

Re: [PATCH][media-next] media: dvb-frontends/stv0910: make various local variables static

Am Fri, 21 Jul 2017 12:06:35 +0100 schrieb Colin King : > From: Colin Ian King > > The list stvlist and arrays padc_lookup, s1_sn_lookup and s2_sn_lookup > do not need to be in global scope, so make them all static. > > Cleans up a bunch of smatch warnings: > symbol 'padc_lookup' was not

[PATCH] staging: vboxvideo: remove unused variables

Fix compiler warnings: vbox_mode.c:57:15: warning: variable ‘crtc_id’ set but not used vbox_mode.c:581:25: warning: variable ‘vbox_connector’ set but not used Signed-off-by: Paolo Cretaro --- drivers/staging/vboxvideo/vbox_mode.c | 5 - 1 file changed, 5 deletions(-)

[PATCH] staging: vboxvideo: remove unused variables

Fix compiler warnings: vbox_mode.c:57:15: warning: variable ‘crtc_id’ set but not used vbox_mode.c:581:25: warning: variable ‘vbox_connector’ set but not used Signed-off-by: Paolo Cretaro --- drivers/staging/vboxvideo/vbox_mode.c | 5 - 1 file changed, 5 deletions(-) diff --git

Re: [PATCH] staging: pi433: use IS_ERR to check kthread_run return value

On 22/07/2017 12:27, Paolo Cretaro wrote: > Fix compiler warning: ordered comparison of pointer with integer zero Sorry, just noticed a similar patch has been submitted a few days ago, please ignore this patch. Paolo > > Signed-off-by: Paolo Cretaro > --- >

Re: [PATCH] staging: pi433: use IS_ERR to check kthread_run return value

On 22/07/2017 12:27, Paolo Cretaro wrote: > Fix compiler warning: ordered comparison of pointer with integer zero Sorry, just noticed a similar patch has been submitted a few days ago, please ignore this patch. Paolo > > Signed-off-by: Paolo Cretaro > --- > drivers/staging/pi433/pi433_if.c |

[PATCH] staging: pi433: use IS_ERR to check kthread_run return value

Fix compiler warning: ordered comparison of pointer with integer zero Signed-off-by: Paolo Cretaro --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c

[PATCH] staging: pi433: use IS_ERR to check kthread_run return value

Fix compiler warning: ordered comparison of pointer with integer zero Signed-off-by: Paolo Cretaro --- drivers/staging/pi433/pi433_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c index

RE: af_packet: use after free in prb_retire_rx_blk_timer_expired

I also hit this issue with trinity test: The call trace: [exception RIP: prb_retire_rx_blk_timer_expired+70] RIP: 81633be6 RSP: 8801bec03dc0 RFLAGS: 00010246 RAX: RBX: 8801b49d0948 RCX: RDX: 8801b31057a0 RSI:

RE: af_packet: use after free in prb_retire_rx_blk_timer_expired

I also hit this issue with trinity test: The call trace: [exception RIP: prb_retire_rx_blk_timer_expired+70] RIP: 81633be6 RSP: 8801bec03dc0 RFLAGS: 00010246 RAX: RBX: 8801b49d0948 RCX: RDX: 8801b31057a0 RSI:

Re: [PATCH v2 4/7] driver core: add devm_device_add_group() and friends

On Thu, Jul 20, 2017 at 08:50:26AM -0700, Dmitry Torokhov wrote: > On July 20, 2017 1:20:09 AM PDT, Greg Kroah-Hartman > wrote: > >On Thu, Jul 20, 2017 at 01:12:56AM -0700, Dmitry Torokhov wrote: > >> Any chance you could create an unmutable branch off 4.12 so I can >

Re: [PATCH v2 4/7] driver core: add devm_device_add_group() and friends

On Thu, Jul 20, 2017 at 08:50:26AM -0700, Dmitry Torokhov wrote: > On July 20, 2017 1:20:09 AM PDT, Greg Kroah-Hartman > wrote: > >On Thu, Jul 20, 2017 at 01:12:56AM -0700, Dmitry Torokhov wrote: > >> Any chance you could create an unmutable branch off 4.12 so I can > >start using it in input

[GIT PULL] TTY/Serial fixes for 4.13-rc2

The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: Linux v4.13-rc1 (2017-07-15 15:22:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/ tags/tty-4.13-rc2 for you to fetch changes up to

[GIT PULL] TTY/Serial fixes for 4.13-rc2

The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: Linux v4.13-rc1 (2017-07-15 15:22:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git/ tags/tty-4.13-rc2 for you to fetch changes up to

[GIT PULL] Char/Misc driver fixes for 4.13-rc2

The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: Linux v4.13-rc1 (2017-07-15 15:22:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/ tags/char-misc-4.13-rc1 for you to fetch changes up to

[GIT PULL] Char/Misc driver fixes for 4.13-rc2

The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: Linux v4.13-rc1 (2017-07-15 15:22:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/ tags/char-misc-4.13-rc1 for you to fetch changes up to

[GIT PULL] USB fixes for 4.13-rc2

The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: Linux v4.13-rc1 (2017-07-15 15:22:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.13-rc2 for you to fetch changes up to

[GIT PULL] USB fixes for 4.13-rc2

The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: Linux v4.13-rc1 (2017-07-15 15:22:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.13-rc2 for you to fetch changes up to

[GIT PULL] Staging driver fixes and a new driver for 4.13-rc2

The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: Linux v4.13-rc1 (2017-07-15 15:22:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.13-rc2 for you to fetch changes up to

[GIT PULL] Staging driver fixes and a new driver for 4.13-rc2

The following changes since commit 5771a8c08880cdca3bfb4a3fc6d309d6bba20877: Linux v4.13-rc1 (2017-07-15 15:22:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.13-rc2 for you to fetch changes up to

Re: [PATCH v2] ovl: drop CAP_SYS_RESOURCE from saved mounter's credentials

Bumped into this patch (Now upstream commit 51f8f3c4e225) and realized it is missing cc: stable # v4.8 At least this docker PR suggests that regression introduced in v4.8 will not be appreciated down the road: https://github.com/moby/moby/issues/29364 On Tue, Jan 10, 2017 at 9:17 PM, Vivek

Re: [PATCH v2] ovl: drop CAP_SYS_RESOURCE from saved mounter's credentials

Bumped into this patch (Now upstream commit 51f8f3c4e225) and realized it is missing cc: stable # v4.8 At least this docker PR suggests that regression introduced in v4.8 will not be appreciated down the road: https://github.com/moby/moby/issues/29364 On Tue, Jan 10, 2017 at 9:17 PM, Vivek

Re: [PATCH 1/3] staging: pi433: Style fix - align block comments

Reviewed-by: Marcus Wolf Thanks for your work, Derek! > Derek Robson hat am 22. Juli 2017 um 05:50 geschrieben: > > > Fixed the alignment of block comments > Found using checkpatch > > Signed-off-by: Derek Robson > --- >

Re: [PATCH 1/3] staging: pi433: Style fix - align block comments

Reviewed-by: Marcus Wolf Thanks for your work, Derek! > Derek Robson hat am 22. Juli 2017 um 05:50 geschrieben: > > > Fixed the alignment of block comments > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/pi433/pi433_if.c | 38 +++-- >

Re: [PATCH 2/3] staging: pi433: - style fix, space before tabs

Reviewed-by: Marcus Wolf >From my point of view, the rearrangement of the block of SET_CHECKED reduces >the readability a lot. I like same stuff to be aligned (all brakets below each other as a column, all spi->dev below each other and so on) But if it is necessary

Re: [PATCH 2/3] staging: pi433: - style fix, space before tabs

Reviewed-by: Marcus Wolf >From my point of view, the rearrangement of the block of SET_CHECKED reduces >the readability a lot. I like same stuff to be aligned (all brakets below each other as a column, all spi->dev below each other and so on) But if it is necessary to fullfill the rules, we

Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line

Reviewed-by: Marcus Wolf Regarding the patch for rf69.c, I'd prefer to have all mantisses allinged (all 'm' as a column below each other, all 'a' below each other, ...). For me that improves the readability a lot. Maybe that can be acchieved somehow without breaking

Re: [PATCH 3/3] staging: pi433: - style fix, space at start of line

Reviewed-by: Marcus Wolf Regarding the patch for rf69.c, I'd prefer to have all mantisses allinged (all 'm' as a column below each other, all 'a' below each other, ...). For me that improves the readability a lot. Maybe that can be acchieved somehow without breaking the style rules - but for

[PATCH] tile: array underflow in setup_maxnodemem()

My static checker correctly complains that we should have a lower bound on "node" to prevent an array underflow. Fixes: 867e359b97c9 ("arch/tile: core support for Tilera 32-bit chips.") Signed-off-by: Dan Carpenter diff --git a/arch/tile/kernel/setup.c

[PATCH] tile: array underflow in setup_maxnodemem()

My static checker correctly complains that we should have a lower bound on "node" to prevent an array underflow. Fixes: 867e359b97c9 ("arch/tile: core support for Tilera 32-bit chips.") Signed-off-by: Dan Carpenter diff --git a/arch/tile/kernel/setup.c b/arch/tile/kernel/setup.c index

Re: [PATCH 2/2] dma: Add Spreadtrum DMA controller driver

On Tue, Jul 18, 2017 at 03:06:12PM +0800, Baolin Wang wrote: > +/* DMA global registers definition */ > +#define DMA_GLB_PAUSE0x0 > +#define DMA_GLB_FRAG_WAIT0x4 > +#define DMA_GLB_REQ_PEND0_EN 0x8 > +#define DMA_GLB_REQ_PEND1_EN 0xc > +#define

Re: [PATCH 2/2] dma: Add Spreadtrum DMA controller driver

On Tue, Jul 18, 2017 at 03:06:12PM +0800, Baolin Wang wrote: > +/* DMA global registers definition */ > +#define DMA_GLB_PAUSE0x0 > +#define DMA_GLB_FRAG_WAIT0x4 > +#define DMA_GLB_REQ_PEND0_EN 0x8 > +#define DMA_GLB_REQ_PEND1_EN 0xc > +#define

[PATCH v6] cpufreq: schedutil: Make iowait boost more energy efficient

Currently the iowait_boost feature in schedutil makes the frequency go to max on iowait wakeups. This feature was added to handle a case that Peter described where the throughput of operations involving continuous I/O requests [1] is reduced due to running at a lower frequency, however the lower

[PATCH v6] cpufreq: schedutil: Make iowait boost more energy efficient

Currently the iowait_boost feature in schedutil makes the frequency go to max on iowait wakeups. This feature was added to handle a case that Peter described where the throughput of operations involving continuous I/O requests [1] is reduced due to running at a lower frequency, however the lower

[PATCH] perf script: remove some bogus error handling

If script_desc__new() fails then the current code has a NULL dereference. We don't actually need to do any cleanup, we can just return NULL. Signed-off-by: Dan Carpenter diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index

[PATCH] perf script: remove some bogus error handling

If script_desc__new() fails then the current code has a NULL dereference. We don't actually need to do any cleanup, we can just return NULL. Signed-off-by: Dan Carpenter diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c index 83cdc0a61fd6..89ea2bc9b9be 100644 ---

[PATCH 2/2] fsl/qe: Cleanup error paths in ucc_of_parse_tdm()

The most important part of this change is that it not propogates error codes instead of returning -EINVAL. There was also a tab missing, and a couple other minor cleanups which don't affect runtime. Signed-off-by: Dan Carpenter --- Not tested, but I don't think

[PATCH 2/2] fsl/qe: Cleanup error paths in ucc_of_parse_tdm()

The most important part of this change is that it not propogates error codes instead of returning -EINVAL. There was also a tab missing, and a couple other minor cleanups which don't affect runtime. Signed-off-by: Dan Carpenter --- Not tested, but I don't think propogating the errors will cause

Re: [PATCH] staging: vboxvideo: make a couple of symbols static

22.07.2017 00:17, Hans de Goede wrote: > Hi, > > On 19-07-17 11:36, Colin King wrote: >> From: Colin Ian King >> >> Module parameter vbox_modeset and structure vbox_bo_driver do not need to >> be in global scope and hence can be made static. >> >> Cleans up a couple of

Re: [PATCH] staging: vboxvideo: make a couple of symbols static

22.07.2017 00:17, Hans de Goede wrote: > Hi, > > On 19-07-17 11:36, Colin King wrote: >> From: Colin Ian King >> >> Module parameter vbox_modeset and structure vbox_bo_driver do not need to >> be in global scope and hence can be made static. >> >> Cleans up a couple of sparse warnings: >> symbol

Re: [PATCH v13 5/5] powerpc/perf: Add thread imc pmu support

my bad, missed to change the authership of this patch. From: Anju T Sudhakar On Wednesday 19 July 2017 03:06 AM, Madhavan Srinivasan wrote: Add support to register Thread In-Memory Collection pmu counters. Patch adds thread imc specific data structures, along with

Re: [PATCH v13 5/5] powerpc/perf: Add thread imc pmu support

my bad, missed to change the authership of this patch. From: Anju T Sudhakar On Wednesday 19 July 2017 03:06 AM, Madhavan Srinivasan wrote: Add support to register Thread In-Memory Collection pmu counters. Patch adds thread imc specific data structures, along with memory init functions and

Re: [PATCH v13 4/5] powerpc/perf: Add core imc pmu support

my bad, missed to change the authership of this patch. From: Anju T Sudhakar On Wednesday 19 July 2017 03:06 AM, Madhavan Srinivasan wrote: Add support to register Core In-Memory Collection pmu counters. Patch adds core imc specific data structures, along with memory

Re: [PATCH v13 4/5] powerpc/perf: Add core imc pmu support

my bad, missed to change the authership of this patch. From: Anju T Sudhakar On Wednesday 19 July 2017 03:06 AM, Madhavan Srinivasan wrote: Add support to register Core In-Memory Collection pmu counters. Patch adds core imc specific data structures, along with memory init functions and

Re: [PATCH v13 3/5] powerpc/perf: Add nest imc pmu support

my bad, missed to change the authership of this patch. From: Anju T Sudhakar On Wednesday 19 July 2017 03:06 AM, Madhavan Srinivasan wrote: Add support to register Nest In-Memory Collection pmu counters. Patch adds a new device file called "imc-pmu.c" under

Re: [PATCH v13 3/5] powerpc/perf: Add nest imc pmu support

my bad, missed to change the authership of this patch. From: Anju T Sudhakar On Wednesday 19 July 2017 03:06 AM, Madhavan Srinivasan wrote: Add support to register Nest In-Memory Collection pmu counters. Patch adds a new device file called "imc-pmu.c" under powerpc/perf folder to contain all

[PATCH v2 0/2] ASoC: Add I2S support for Allwinner H3 SoCs

From: Marcus Cooper Hi All, please find attached a series of patches to bring i2s support to the Allwinner H3 SoC. This has been tested with the following setups: A20 Olimex EVB connected to a pcm5102 Orange Pi 2 connected to a uda1380 Orange Pi 2 hdmi audio playback Pine

[PATCH v2 0/2] ASoC: Add I2S support for Allwinner H3 SoCs

From: Marcus Cooper Hi All, please find attached a series of patches to bring i2s support to the Allwinner H3 SoC. This has been tested with the following setups: A20 Olimex EVB connected to a pcm5102 Orange Pi 2 connected to a uda1380 Orange Pi 2 hdmi audio playback Pine 64 connected to the

[PATCH v2 2/2] ASoC: sun4i-i2s: Add support for H3

From: Marcus Cooper The sun8i-h3 introduces a lot of changes to the i2s block such as different register locations, extended clock division and more operational modes. As we have to consider the earlier implementation then these changes need to be isolated. Signed-off-by:

[PATCH v2 2/2] ASoC: sun4i-i2s: Add support for H3

From: Marcus Cooper The sun8i-h3 introduces a lot of changes to the i2s block such as different register locations, extended clock division and more operational modes. As we have to consider the earlier implementation then these changes need to be isolated. Signed-off-by: Marcus Cooper ---

[PATCH v2 1/2] ASoC: sun4i-i2s: Add more quirks for newer SoCs

From: Marcus Cooper In preparation for changing this driver to support newer SoC implementations then where needed there has been a switch from regmap_update_bits to regmap_field. Also included are adjustment variables although they are not set as no adjustment is required

[PATCH v2 1/2] ASoC: sun4i-i2s: Add more quirks for newer SoCs

From: Marcus Cooper In preparation for changing this driver to support newer SoC implementations then where needed there has been a switch from regmap_update_bits to regmap_field. Also included are adjustment variables although they are not set as no adjustment is required for the current

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

On Thu, Jul 06, 2017 at 02:20:20PM +0200, Pierre-Yves MORDRET wrote: > +static int stm32_dmamux_probe(struct platform_device *pdev) > +{ > + struct device_node *node = pdev->dev.of_node; > + struct device_node *dma_node; > + struct stm32_dmamux_data *stm32_dmamux; > + struct

Re: [PATCH v3 2/5] dmaengine: Add STM32 DMAMUX driver

On Thu, Jul 06, 2017 at 02:20:20PM +0200, Pierre-Yves MORDRET wrote: > +static int stm32_dmamux_probe(struct platform_device *pdev) > +{ > + struct device_node *node = pdev->dev.of_node; > + struct device_node *dma_node; > + struct stm32_dmamux_data *stm32_dmamux; > + struct

Re: [PATCH v6] Bluetooth: btusb: Fix memory leak in play_deferred

Hi Oliver, > Currently we are calling usb_submit_urb directly to submit deferred tx > urbs after unanchor them. > > So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb > and cause memory leak: > unreferenced object 0xffc0ce0fa400 (size 256): > ... > backtrace: >[]

Re: [PATCH v6] Bluetooth: btusb: Fix memory leak in play_deferred

Hi Oliver, > Currently we are calling usb_submit_urb directly to submit deferred tx > urbs after unanchor them. > > So the usb_giveback_urb_bh would failed to unref it in usb_unanchor_urb > and cause memory leak: > unreferenced object 0xffc0ce0fa400 (size 256): > ... > backtrace: >[]

Re: [PATCH v2] media: Convert to using %pOF instead of full_name

On 07/21/2017 09:28 PM, Rob Herring wrote: Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring Acked-by: Niklas

Re: [PATCH v2] media: Convert to using %pOF instead of full_name

On 07/21/2017 09:28 PM, Rob Herring wrote: Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node. Signed-off-by: Rob Herring Acked-by: Niklas Söderlund Acked-by: Laurent

Re: [PATCH] Bluetooth: Style fix - align block comments

Hi Derek, > Fixed alignment of all block comments. > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/bluetooth/ath3k.c | 3 ++- > drivers/bluetooth/bt3c_cs.c | 8 +--- > drivers/bluetooth/btmrvl_sdio.c | 6 -- >

Re: [PATCH] Bluetooth: Style fix - align block comments

Hi Derek, > Fixed alignment of all block comments. > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/bluetooth/ath3k.c | 3 ++- > drivers/bluetooth/bt3c_cs.c | 8 +--- > drivers/bluetooth/btmrvl_sdio.c | 6 -- > drivers/bluetooth/btsdio.c | 3 ++- >

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

On Sat, 22 Jul 2017, Borislav Petkov wrote: > On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote: > > Someone pointed out that the rule is probably not OK when the address of > > the static variable is taken, because then it is likely being used as > > permanent storage. > > Makes

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

On Sat, 22 Jul 2017, Borislav Petkov wrote: > On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote: > > Someone pointed out that the rule is probably not OK when the address of > > the static variable is taken, because then it is likely being used as > > permanent storage. > > Makes

Re: [PATCH] EDAC: remove unnecessary static in edac_fake_inject_write()

On Fri, Jul 21, 2017 at 10:08:12PM +0200, Julia Lawall wrote: > Someone pointed out that the rule is probably not OK when the address of > the static variable is taken, because then it is likely being used as > permanent storage. Makes sense to me. > An improved rule is: Do you think it is

<    1   2   3   4   >