[PATCH v3 05/12] mmc: mediatek: add pad_tune0 support

2017-10-09 Thread Chaotian Jing
from mt2701, the register of PAD_TUNE has been phased out, while there is a new register of PAD_TUNE0 Signed-off-by: Chaotian Jing --- drivers/mmc/host/mtk-sd.c | 69 ++- 1 file changed, 51 insertions(+), 18 deletions(-) diff --git a/drivers/mmc/host/

[PATCH v3 00/13] mmc: mediatek: add support of mt2701/mt2712

2017-10-09 Thread Chaotian Jing
This serial of patches are adding support of mt2701/mt2712. there are many changes and HW improvement between mt8173 and mt2701/mt2712, below is a list of these changes: 1. enlarge CLKDIV bits from 8 to 12 2. remove the PAD_TUNE register and add a new PAD_TUNE0 register 3. add data sync and

[PATCH v3 01/12] mmc: mediatek: add support of mt2701/mt2712

2017-10-09 Thread Chaotian Jing
mt2701/mt2712 has 12bit clock div, which is not compatible with mt8135/mt8173. and, some additional features will be added in mt2701/mt2712, so that need distinguish it by comatibale name. Signed-off-by: Chaotian Jing --- drivers/mmc/host/mtk-sd.c | 82 +++

[PATCH v2] mm/page_alloc.c: inline __rmqueue()

2017-10-09 Thread Aaron Lu
__rmqueue() is called by rmqueue_bulk() and rmqueue() under zone->lock and the two __rmqueue() call sites are in very hot page allocator paths. Since __rmqueue() is a small function, inline it can save us some time. With the will-it-scale/page_fault1/process benchmark, when using nr_cpu processes

[PATCH v4 4/5] media: atmel-isc: Remove unnecessary member

2017-10-09 Thread Wenyou Yang
Remove the memeber *config from the isc_subdev_entity struct, the member is useless afterward. Signed-off-by: Wenyou Yang --- Changes in v4: None Changes in v3: None Changes in v2: None drivers/media/platform/atmel/atmel-isc.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) d

Re: [PATCH] page_alloc.c: inline __rmqueue()

2017-10-09 Thread Aaron Lu
On Mon, Oct 09, 2017 at 01:23:34PM -0700, Dave Hansen wrote: > On 10/08/2017 10:44 PM, Aaron Lu wrote: > > On a 2 sockets Intel-Skylake machine: > > base %change head > > 77342+6.3% 82203will-it-scale.per_process_ops > > What's the unit here? Tha

[PATCH v4 5/5] media: atmel-isc: Rework the format list

2017-10-09 Thread Wenyou Yang
To improve the readability of code, split the format array into two, one for the format description, other for the register configuration. Meanwhile, add the flag member to indicate the format can be achieved from the sensor or be produced by the controller, and rename members related to the regist

[PATCH] radix-tree: get_slot_offset() returns invalid offset when parent is NULL

2017-10-09 Thread Wei Yang
When parent is NULL, get_slot_offset() returns almost the address of slot. This is an invalid value for offset. One possible scenario happens on deleting #0 index, when it is the only one in tree. Current behavior doesn't harm the system, because the offset will not be used when parent is NULL in

[PATCH v4 3/5] media: atmel-isc: Enable the clocks during probe

2017-10-09 Thread Wenyou Yang
To meet the relationship, enable the HCLOCK and ispck during the device probe, "isc_pck frequency is less than or equal to isc_ispck, and isc_ispck is greater than or equal to HCLOCK." Meanwhile, call the pm_runtime_enable() in the right place. Signed-off-by: Wenyou Yang --- Changes in v4: - Mo

[PATCH v4 2/5] media: atmel-isc: Add prepare and unprepare ops

2017-10-09 Thread Wenyou Yang
A software write operation to the ISC_CLKEN or ISC_CLKDIS register requires double clock domain synchronization and is not permitted when the ISC_SR.SIP is asserted. So add the .prepare and .unprepare ops to make sure the ISC_CLKSR.SIP is unasserted before the write operation to the ISC_CLKEN or IS

[PATCH v4 0/5] media: atmel-isc: Rework the format list and clock provider

2017-10-09 Thread Wenyou Yang
To improve the readability of code, rework the format list table, split the format array into two. Meanwhile, fix the issue of the clock provider operation and the pm runtime support. Changes in v4: - Call pm_runtime_get_sync() and pm_runtime_put_sync() in ->prepare and ->unprepare callback.

[PATCH v4 1/5] media: atmel-isc: Add spin lock for clock enable ops

2017-10-09 Thread Wenyou Yang
Add the spin lock for the clock enable and disable operations. Signed-off-by: Wenyou Yang --- Changes in v4: None Changes in v3: - Fix the wrong used spinlock. - s/_/- on the subject. Changes in v2: None drivers/media/platform/atmel/atmel-isc.c | 15 ++- 1 file changed, 14 inser

[PATCH v2] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-09 Thread Jonathan Liu
This fixes a kernel oops when unloading the driver due to usb_put_phy being called after usb_phy_generic_unregister when the device is detached. Calling usb_phy_generic_unregister causes x->dev->driver to be NULL in usb_put_phy and results in a NULL pointer dereference. Cc: sta...@vger.kernel.org

Re: [PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-09 Thread Jonathan Liu
Hi, On 10 October 2017 at 13:14, Bin Liu wrote: > On Tue, Oct 10, 2017 at 08:17:34AM +1100, Jonathan Liu wrote: >> Hi, >> >> On 10 October 2017 at 01:23, Bin Liu wrote: >> > Hi, >> > >> > On Tue, Sep 26, 2017 at 09:39:23PM +1000, Jonathan Liu wrote: >> >> This fixes a kernel oops when unloading

Re: [RFC] yamldt v0.5, now a DTS compiler too

2017-10-09 Thread David Gibson
On Mon, Oct 09, 2017 at 06:07:28PM +0300, Pantelis Antoniou wrote: > Hi David, > > > On Oct 9, 2017, at 03:00 , David Gibson wrote: > > > > On Sun, Oct 08, 2017 at 04:08:03PM -0700, Frank Rowand wrote: > >> On 10/07/17 03:23, Pantelis Antoniou wrote: > >>> Hi Rob, > >>> > On Oct 6, 2017, a

Re: [PATCH v2 0/3] pinctrl: sunxi: Start to enforce the strict mode

2017-10-09 Thread Chen-Yu Tsai
On Tue, Oct 10, 2017 at 4:53 AM, Maxime Ripard wrote: > Hi, > > Here is an attempt to enable pinctrl's strict mode on our pinctrl drivers. > Indeed, our controllers should have had that mode enabled since its > introduction. > > However, there's a number of issues with old device trees that preven

Re: [linux-sunxi] Re: [PATCH 3/6] ARM: sun8i: r40: add 5V regulator for Banana Pi M2 Ultra

2017-10-09 Thread Chen-Yu Tsai
On Tue, Oct 10, 2017 at 7:25 AM, Icenowy Zheng wrote: > > > 于 2017年10月10日 GMT+08:00 上午5:04:07, Maxime Ripard > 写到: >>On Sun, Oct 08, 2017 at 04:29:03AM +, Icenowy Zheng wrote: >>> On newer revisions of the Banana Pi M2 Ultra boards, the 5V power >>output >>> (used by HDMI, SATA and USB) is c

Re: [PATCH 1/1] xdp: Sample xdp program implementing ip forward

2017-10-09 Thread Jacob, Christina
Sorry for the late reply. I will include the suggested changes in the next revision of the patch. Please see inline for clarifications and questions. Thanks, Christina From: Daniel Borkmann Sent: Tuesday, October 3, 2017 9:24 PM To: Jacob, Christina; net...@

Re: [PATCH] usb: musb: sunxi: Explicitly release USB PHY on exit

2017-10-09 Thread Bin Liu
On Tue, Oct 10, 2017 at 08:17:34AM +1100, Jonathan Liu wrote: > Hi, > > On 10 October 2017 at 01:23, Bin Liu wrote: > > Hi, > > > > On Tue, Sep 26, 2017 at 09:39:23PM +1000, Jonathan Liu wrote: > >> This fixes a kernel oops when unloading the driver due to usb_put_phy > >> being called after usb_

Re: [PATCH] regulator: lp873x: Update the enable mask for LDOs and BUCKs

2017-10-09 Thread Keerthy
On Monday 09 October 2017 09:20 PM, Mark Brown wrote: > On Mon, Oct 09, 2017 at 06:35:14PM +0300, Tero Kristo wrote: > >> The EN signal coming in to the PMIC is actually used to poweroff the system >> completely. There is no other mechanism for doing this in lp873x based >> systems, they removed

Re: [PATCH v2 1/3] dt-bindings: Add document for rockchip RGB output interface

2017-10-09 Thread Sandy Huang
在 2017/10/9 21:05, Rob Herring 写道: On Mon, Oct 9, 2017 at 3:06 AM, Sandy Huang wrote: Hi rob, Thanks for your reply. 在 2017/10/4 5:56, Rob Herring 写道: On Fri, Sep 22, 2017 at 11:00:26AM +0800, Sandy Huang wrote: This path add support rv1108 rgb output interface driver. Signed-off-b

Re: [PATCH v2] serial: sh-sci: Fix init data attribute for struct 'port_cfg'

2017-10-09 Thread Guenter Roeck
On Mon, Oct 9, 2017 at 6:26 PM, Matthias Kaehlcke wrote: > The __init attribute is meant to mark functions, use __initdata instead > for the data structure. > > This fixes the following error when building with clang: > > drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only >

Re: [PATCH net-next RFC 4/9] net: dsa: mv88e6xxx: add support for event capture

2017-10-09 Thread Richard Cochran
On Mon, Oct 09, 2017 at 04:08:50PM -0600, Levi Pearson wrote: > Another issue related to this is that while the free-running counter > in the hardware can't be easily adjusted, the periodic event generator > *can* be finely adjusted (via picosecond and sub-picosecond > accumulators) to correct for

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-09 Thread Jassi Brar
On Tue, Oct 10, 2017 at 4:27 AM, Rob Herring wrote: > On Mon, Oct 9, 2017 at 9:46 AM, Jassi Brar wrote: >> On Mon, Oct 9, 2017 at 7:22 PM, Rob Herring wrote: >>> On Fri, Oct 6, 2017 at 9:26 PM, Jassi Brar wrote: On Fri, Oct 6, 2017 at 9:24 PM, Rob Herring wrote: > On Fri, Oct 6, 2017

Re: [PATCH V5 00/14] blk-mq-sched: improve sequential I/O performance(part 1)

2017-10-09 Thread Ming Lei
On Mon, Oct 09, 2017 at 11:04:39PM +0800, Ming Lei wrote: > Hi John, > > On Mon, Oct 09, 2017 at 01:09:22PM +0100, John Garry wrote: > > On 30/09/2017 11:27, Ming Lei wrote: > > > Hi Jens, > > > > > > In Red Hat internal storage test wrt. blk-mq scheduler, we > > > found that I/O performance is m

Re: [PATCH v2 09/13] mmc: mediatek: add stop_clk fix and enhance_rx support

2017-10-09 Thread Chaotian Jing
On Mon, 2017-10-09 at 17:00 +0200, Matthias Brugger wrote: > > On 10/09/2017 01:35 PM, Chaotian Jing wrote: > > mt2712 supports stop_clk fix and enhance_rx, which can improve > > host stability. > > > > Signed-off-by: Chaotian Jing > > --- > > drivers/mmc/host/mtk-sd.c | 47 > > ++

Re: [PATCH] x86/tsc: Append description for 'tsc=unstable' boot parameter

2017-10-09 Thread Dou Liyang
Hi Pavel, At 10/09/2017 08:25 PM, Pavel Tatashin wrote: Hi Dou, Have you tested tsc=unstable with your DR setup? Is it working as expected? I mean instead of previous "notsc"? Not yet, I have applied for the machine, I'll start testing once I have access to it. And I am looking at this part o

Re: [PATCH v2 05/13] mmc: mediatek: make hs400_tune_response only for mt8173

2017-10-09 Thread Chaotian Jing
On Mon, 2017-10-09 at 16:58 +0200, Matthias Brugger wrote: > > On 10/09/2017 01:35 PM, Chaotian Jing wrote: > > the origin design of hs400_tune_response is for mt8173 because of > > mt8173 has a special design. for doing that, we add a new member > > "compatible", by now it's only for mt8173. > >

Re: [PATCH v2 03/13] mmc: dt-bindings: make compatible explicit

2017-10-09 Thread Chaotian Jing
On Mon, 2017-10-09 at 16:54 +0200, Matthias Brugger wrote: > > On 10/09/2017 01:35 PM, Chaotian Jing wrote: > > the driver has updated to have an explicit compatible, so update > > binding file according to the driver change. > > > > Signed-off-by: Chaotian Jing > > --- > > Documentation/devic

Re: [PATCH v2 4/5] arm64: locking: Move rwlock implementation over to qrwlocks

2017-10-09 Thread Waiman Long
On 10/06/2017 09:34 AM, Will Deacon wrote: > Now that the qrwlock can make use of WFE, remove our homebrew rwlock > code in favour of the generic queued implementation. > > Signed-off-by: Will Deacon > --- > arch/arm64/Kconfig | 17 > arch/arm64/include/asm/Kbuild

[PATCH v2] serial: sh-sci: Fix init data attribute for struct 'port_cfg'

2017-10-09 Thread Matthias Kaehlcke
The __init attribute is meant to mark functions, use __initdata instead for the data structure. This fixes the following error when building with clang: drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only applies to functions, methods, properties, and global variables s

Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE

2017-10-09 Thread Richard Kuo
On Mon, Oct 09, 2017 at 03:11:47PM +0800, Cao jin wrote: > As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is > used to add arch-specific options for $(CC). From commandline, > CFLAGS_MODULE shall be used. > Doesn't have any functional change, but just follow kbuild rules. > > Si

Re: [RFC] a question about mlockall() and mprotect()

2017-10-09 Thread Xishi Qiu
On 2017/10/10 2:26, Michal Hocko wrote: > On Wed 27-09-17 13:51:09, Xishi Qiu wrote: >> On 2017/9/26 19:00, Michal Hocko wrote: >> >>> On Tue 26-09-17 11:45:16, Vlastimil Babka wrote: On 09/26/2017 11:22 AM, Xishi Qiu wrote: > On 2017/9/26 17:13, Xishi Qiu wrote: >>> This is still ver

[PATCH 2/4] x86/unwind: Use MSB for frame pointer encoding on 32-bit

2017-10-09 Thread Josh Poimboeuf
On x86-32, Tetsuo Handa and Fengguang Wu reported unwinder warnings like: WARNING: kernel stack regs at f60bb9c8 in swapper:1 has bad 'bp' value 0ba0 And also there were some stack dumps with a bunch of unreliable '?' symbols after an apic_timer_interrupt symbol, meaning the unwinder got c

[PATCH 0/4] x86/unwind: 32-bit unwinder fixes

2017-10-09 Thread Josh Poimboeuf
Some x86-32 unwinder bug fixes. Josh Poimboeuf (4): x86/unwind: Fix dereference of untrusted pointer x86/unwind: Use MSB for frame pointer encoding on 32-bit x86/unwind: Align stack pointer in unwinder dump x86/unwind: Disable unwinder warnings on 32-bit arch/x86/entry/entry_32.S |

[PATCH 1/4] x86/unwind: Fix dereference of untrusted pointer

2017-10-09 Thread Josh Poimboeuf
Tetsuo Handa and Fengguang Wu reported a panic in the unwinder: BUG: unable to handle kernel NULL pointer dereference at 01f2 IP: update_stack_state+0xd4/0x340 *pde = Oops: [#1] PREEMPT SMP CPU: 0 PID: 18728 Comm: 01-cpu-hotplug Not tainted 4.13.0-rc4-00170-gb09be67 #

[PATCH 4/4] x86/unwind: Disable unwinder warnings on 32-bit

2017-10-09 Thread Josh Poimboeuf
x86-32 doesn't have stack validation, so in most cases it doesn't make sense to warn about bad frame pointers. Reported-by: Tetsuo Handa Signed-off-by: Josh Poimboeuf --- arch/x86/kernel/unwind_frame.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/kernel/unwind_frame.c b/a

[PATCH 3/4] x86/unwind: Align stack pointer in unwinder dump

2017-10-09 Thread Josh Poimboeuf
When printing the unwinder dump, the stack pointer could be unaligned, for one of two reasons: - stack corruption; or - GCC created an unaligned stack. There's no way for the unwinder to tell the difference between the two, so we have to assume one or the other. GCC unaligned stacks are very ra

Re: [PATCH 3/4] sched: WARN when migrating to an offline CPU

2017-10-09 Thread Levin, Alexander (Sasha Levin)
On Mon, Oct 09, 2017 at 10:04:45AM +0200, Peter Zijlstra wrote: >On Sat, Oct 07, 2017 at 05:43:32PM +, Levin, Alexander (Sasha Levin) wrote: >> On Sat, Oct 07, 2017 at 11:15:17AM +0200, Peter Zijlstra wrote: >> >On Sat, Oct 07, 2017 at 02:07:26AM +, Levin, Alexander (Sasha Levin) >> >wrote

[PATCH] perf/ftrace : Fix repetitious traces when specify a target task

2017-10-09 Thread Cheng Jian
When use perf to trace the sched_wakeup and sched_wakeup_new tracepoint, there is a bug that output the same event repetitiously. It can be reproduced by : perf record -e sched:sched_wakeup_new ./bug_fork bug_fork is an demo that can generating wakeup_new events : the parent proc

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

2017-10-09 Thread Levin, Alexander (Sasha Levin)
On Mon, Oct 09, 2017 at 04:23:57PM -0700, Alexei Starovoitov wrote: >On Mon, Oct 09, 2017 at 11:15:40PM +, Levin, Alexander (Sasha Levin) wrote: >> On Mon, Oct 09, 2017 at 04:06:20PM -0700, Alexei Starovoitov wrote: >> >On Mon, Oct 09, 2017 at 08:26:34PM +, Levin, Alexander (Sasha Levin) >

Re: [PATCH] cifs: Fix bool initialization/comparison

2017-10-09 Thread Nico Kadel-Garcia
On Sat, Oct 7, 2017 at 10:02 AM, Thomas Meyer via samba-technical wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. Except that "==" is not a pure boolean check. It's a value check, and unless these values are defined *very* carefully they may be set to

Re: [PATCH RFC tip/core/rcu 11/15] tracepoint: Remove smp_read_barrier_depends() from comment

2017-10-09 Thread Mathieu Desnoyers
- On Oct 9, 2017, at 8:31 PM, rostedt rost...@goodmis.org wrote: > [ added Mathieu ] > > On Mon, 9 Oct 2017 17:22:45 -0700 > "Paul E. McKenney" wrote: > >> The comment in tracepoint_add_func() mentions smp_read_barrier_depends(), >> whose use should be quite restricted. This commit update

Re: [PATCH v2 4/4] mm:swap: skip swapcache for swapin of synchronous device

2017-10-09 Thread Huang, Ying
Minchan Kim writes: > Hi Huang, > > Sorry for the late response. It was long national holiday. > > On Fri, Sep 29, 2017 at 04:51:17PM +0800, huang ying wrote: >> On Wed, Sep 20, 2017 at 1:43 PM, Minchan Kim wrote: >> > With fast swap storage, platform want to use swap more aggressively >> > and

Re: [PATCH] timer: Remove meaningless .data/.function assignments

2017-10-09 Thread David Miller
From: Kees Cook Date: Mon, 9 Oct 2017 17:10:32 -0700 > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. > > Cc: Krzysztof Halasa > Cc:

Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-10-09 Thread Masahiro Yamada
2017-10-06 5:58 GMT+09:00 Doug Anderson : > Hi, > > On Thu, Oct 5, 2017 at 12:26 AM, Masahiro Yamada > wrote: >> As far as I tested, I always see only one space after ":=" in v2. >> >> I did not consider this deeply, >> but something is working nicely behind the scene. > > Try adding this to the e

Re: [PATCH v3 2/5] of: reserved_mem: Accessor for acquiring reserved_mem

2017-10-09 Thread Rob Herring
On Wed, Oct 4, 2017 at 10:32 PM, Bjorn Andersson wrote: > In some cases drivers referencing a reserved-memory region might want to > remap the entire region, but when defining the reserved-memory by "size" > the client driver has no means to know the associated base address of > the reserved memor

Re: [PATCH v3 1/5] of/platform: Generalize /reserved-memory handling

2017-10-09 Thread Rob Herring
On Wed, Oct 4, 2017 at 10:32 PM, Bjorn Andersson wrote: > By iterating over all /reserved-memory child nodes and match each one to > a list of compatibles that we want to treat specially, we can easily > extend the list of compatibles to handle - without having to resort to > of_platform_populate(

Re: [PATCH v3 4/5] soc: qcom: Remote filesystem memory driver

2017-10-09 Thread Rob Herring
On Wed, Oct 4, 2017 at 10:32 PM, Bjorn Andersson wrote: > The Qualcomm remote file system protocol is used by certain remoteprocs, > in particular the modem, to read and write persistent storage in > platforms where only the application CPU has physical storage access. > > The protocol is based on

Re: [PATCH v2 0/3] Altera ASMI Parallel II IP Core

2017-10-09 Thread matthew . gerlach
Hi Everyone, Thanks to Rob Herring for Acking the device tree bindings part of the patch. Does anyone have any feedback for the rest of the patch set? Thanks, Matthew Gerlach On Wed, 20 Sep 2017, matthew.gerl...@linux.intel.com wrote: From: Matthew Gerlach This patch set adds a spi-nor

Re: [PATCH 11/13] selftests/powerpc: kill off ACCESS_ONCE()

2017-10-09 Thread Michael Ellerman
Mark Rutland writes: > For several reasons, it is desirable to use {READ,WRITE}_ONCE() in > preference to ACCESS_ONCE(), and new code is expected to use one of the > former. So far, there's been no reason to change most existing uses of > ACCESS_ONCE(), as these aren't currently harmful. > > Howe

Re: [PATCH 09/15] ARM: dts: at91: sama5d2_xplained: Add charger node of pmic.

2017-10-09 Thread Yang, Wenyou
Hi Claudiu, On 2017/10/10 0:09, Claudiu Beznea wrote: Add charger device node as a sub-device node of act8945a mfd, move the charger's properties to this node, and use the "interrupts" property to replace "active-semi,irq_gpios" to denote the act8945a charger's irq. Signed-off-by: Wenyou Yang

Re: [PATCH] serial: sh-sci: Remove __init attribute from static struct 'port_cfg'

2017-10-09 Thread Matthias Kaehlcke
El Mon, Oct 09, 2017 at 05:18:32PM -0700 Guenter Roeck ha dit: > On Mon, Oct 9, 2017 at 5:04 PM, Matthias Kaehlcke wrote: > > This fixes the following error when building with clang: > > > > drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only > > applies to functions, metho

Re: [PATCH v2 4/4] mm:swap: skip swapcache for swapin of synchronous device

2017-10-09 Thread Minchan Kim
Hi Huang, Sorry for the late response. It was long national holiday. On Fri, Sep 29, 2017 at 04:51:17PM +0800, huang ying wrote: > On Wed, Sep 20, 2017 at 1:43 PM, Minchan Kim wrote: > > With fast swap storage, platform want to use swap more aggressively > > and swap-in is crucial to application

Re: [PATCH RFC tip/core/rcu 11/15] tracepoint: Remove smp_read_barrier_depends() from comment

2017-10-09 Thread Steven Rostedt
[ added Mathieu ] On Mon, 9 Oct 2017 17:22:45 -0700 "Paul E. McKenney" wrote: > The comment in tracepoint_add_func() mentions smp_read_barrier_depends(), > whose use should be quite restricted. This commit updates the comment > to instead mention the smp_store_release() and rcu_dereference_sc

Re: [RFC v5 4/8] platform: x86: Add generic Intel IPC driver

2017-10-09 Thread sathyanarayanan kuppuswamy
Hi, On 10/09/2017 12:11 AM, Christoph Hellwig wrote: What does IPC stand for in this device? Inter processor communication -- Sathyanarayanan Kuppuswamy Linux kernel developer

Re: [RFC PATCH 4/4] kbuild: evaluate cc-option and friends only when building kernel

2017-10-09 Thread Doug Anderson
Hi, On Mon, Oct 9, 2017 at 5:23 PM, Masahiro Yamada wrote: > I am still wondering if I should apply this one > because your cache approach provides much more benefits. > > (that is why I prefixed this 4/4 with RFC.) > > > Maybe I will send v2, or maybe not. I'm not sure I have a strong opinion e

Re: [PATCH] watchdog: hpwdt: change maintainer.

2017-10-09 Thread Guenter Roeck
On 10/09/2017 11:56 AM, Jerry Hoemann wrote: Signed-off-by: Jerry Hoemann Reviewed-by: Guenter Roeck We should get an Ack from Jimmy, though. Guenter --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2d3d750..e7dc993 100

[PATCH RFC tip/core/rcu 10/15] locking: Remove smp_read_barrier_depends() from queued_spin_lock_slowpath()

2017-10-09 Thread Paul E. McKenney
Queued spinlocks are not used by DEC Alpha, and furthermore operations such as READ_ONCE() and release/relaxed RMW atomics are being changed to imply smp_read_barrier_depends(). This commit therefore removes the now-redundant smp_read_barrier_depends() from queued_spin_lock_slowpath(), and adjusts

[PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove smp_read_barrier_depends()

2017-10-09 Thread Paul E. McKenney
Now that smp_read_barrier_depends() is implied by READ_ONCE(), adding READ_ONCE() to assoc_array_ptr_to_leaf() and __assoc_array_ptr_to_meta() allows the several smp_read_barrier_depends() calls to be removed from lib/assoc_array.c. This commit makes this change. Signed-off-by: Paul E. McKenney

[PATCH RFC tip/core/rcu 15/15] keyring: Remove now-redundant smp_read_barrier_depends()

2017-10-09 Thread Paul E. McKenney
Now that the associative-array library properly heads dependency chains, the various smp_read_barrier_depends() calls in security/keys/keyring.c are no longer needed. This commit therefore removes them. Signed-off-by: Paul E. McKenney Cc: David Howells Cc: James Morris Cc: "Serge E. Hallyn" C

[PATCH RFC tip/core/rcu 04/15] fs/dcache: Use release-acquire for name/length update

2017-10-09 Thread Paul E. McKenney
The code in __d_alloc() carefully orders filling in the NUL character of the name (and the length, hash, and the name itself) with assigning of the name itself. However, prepend_name() does not order the accesses to the ->name and ->len fields, other than on TSO systems. This commit therefore rep

[PATCH RFC tip/core/rcu 05/15] percpu: READ_ONCE() now implies smp_read_barrier_depends()

2017-10-09 Thread Paul E. McKenney
Because READ_ONCE() now implies smp_read_barrier_depends(), this commit removes the now-redundant smp_read_barrier_depends() following the READ_ONCE() in __ref_is_percpu(). Signed-off-by: Paul E. McKenney Cc: Tejun Heo Cc: Christoph Lameter --- include/linux/percpu-refcount.h | 6 +++--- lib/p

[PATCH RFC tip/core/rcu 08/15] seqlock: Remove now-redundant smp_read_barrier_depends()

2017-10-09 Thread Paul E. McKenney
READ_ONCE() now implies smp_read_barrier_depends(), so this patch removes the now-redundant smp_read_barrier_depends() from raw_read_seqcount_latch(). Signed-off-by: Paul E. McKenney Cc: Peter Zijlstra Cc: Ingo Molnar --- include/linux/seqlock.h | 3 +-- 1 file changed, 1 insertion(+), 2 delet

[PATCH RFC tip/core/rcu 01/15] doc: READ_ONCE() now implies smp_barrier_depends()

2017-10-09 Thread Paul E. McKenney
This commit updates an example in memory-barriers.txt to account for the fact that READ_ONCE() now implies smp_barrier_depends(). Signed-off-by: Paul E. McKenney --- Documentation/memory-barriers.txt | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/Documentation/me

Re: [RFC PATCH 4/4] kbuild: evaluate cc-option and friends only when building kernel

2017-10-09 Thread Masahiro Yamada
2017-10-10 7:04 GMT+09:00 Doug Anderson : > Hi, > > On Tue, Oct 3, 2017 at 8:56 PM, Masahiro Yamada > wrote: >> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include >> index 9ffd3dd..222d0a2 100644 >> --- a/scripts/Kbuild.include >> +++ b/scripts/Kbuild.include >> @@ -96,6 +96,13 @@ try-ru

[PATCH RFC tip/core/rcu 11/15] tracepoint: Remove smp_read_barrier_depends() from comment

2017-10-09 Thread Paul E. McKenney
The comment in tracepoint_add_func() mentions smp_read_barrier_depends(), whose use should be quite restricted. This commit updates the comment to instead mention the smp_store_release() and rcu_dereference_sched() that the current code actually uses. Signed-off-by: Paul E. McKenney Cc: Ingo Mol

[PATCH RFC tip/core/rcu 07/15] rtnetlink: Update now-misleading smp_read_barrier_depends() comment

2017-10-09 Thread Paul E. McKenney
Now that READ_ONCE() implies smp_read_barrier_depends(), update the rtnl_dereference() header comment accordingly. Signed-off-by: Paul E. McKenney Cc: "David S. Miller" Cc: Vladislav Yasevich Cc: Mark Rutland Cc: David Ahern Cc: Vlad Yasevich --- include/linux/rtnetlink.h | 3 +-- 1 file ch

[PATCH RFC tip/core/rcu 14/15] netfilter: Remove now-redundant smp_read_barrier_depends()

2017-10-09 Thread Paul E. McKenney
READ_ONCE() now implies smp_read_barrier_depends(), which means that the instances in arpt_do_table(), ipt_do_table(), and ip6t_do_table() are now redundant. This commit removes them and adjusts the comments. Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc: Floria

[PATCH RFC tip/core/rcu 13/15] mm/ksm: Remove now-redundant smp_read_barrier_depends()

2017-10-09 Thread Paul E. McKenney
Because READ_ONCE() now implies smp_read_barrier_depends(), the smp_read_barrier_depends() in get_ksm_page() is now redundant. This commit removes it and updates the comments. Signed-off-by: Paul E. McKenney Cc: Andrew Morton Cc: Andrea Arcangeli Cc: Minchan Kim Cc: Michal Hocko Cc: "Kirill A

[PATCH RFC tip/core/rcu 06/15] rcu: Adjust read-side accessor comments for READ_ONCE()

2017-10-09 Thread Paul E. McKenney
Now that READ_ONCE() implies smp_read_barrier_depends(), the commit updates now-misleading comments to account for this change. Signed-off-by: Paul E. McKenney --- include/linux/rcupdate.h | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/include/linux

[PATCH RFC tip/core/rcu 02/15] mn10300: READ_ONCE() now implies smp_read_barrier_depends()

2017-10-09 Thread Paul E. McKenney
Given that READ_ONCE() now implies smp_read_barrier_depends(), there is no need for the open-coded smp_read_barrier_depends() in mn10300_serial_receive_interrupt() and mn10300_serial_poll_get_char(). This commit therefore removes them, but replaces them with comments calling out that carrying depen

[PATCH RFC tip/core/rcu 03/15] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering

2017-10-09 Thread Paul E. McKenney
The __qed_spq_block() function expects an smp_read_barrier_depends() to order a prior READ_ONCE() against a later load that does not depend on the prior READ_ONCE(), an expectation that can fail to be met. This commit therefore replaces the READ_ONCE() with smp_load_acquire() and removes the smp_re

[PATCH RFC tip/core/rcu 09/15] uprobes: Remove now-redundant smp_read_barrier_depends()

2017-10-09 Thread Paul E. McKenney
Now that READ_ONCE() implies smp_read_barrier_depends(), the get_xol_area() and get_trampoline_vaddr() no longer need their smp_read_barrier_depends() calls, which this commit removes. While we are here, convert the corresponding smp_wmb() to an smp_store_release(). Signed-off-by: Paul E. McKenney

[PATCH RFC tip/core/rcu 0/15] Remove to-be-unneeded smp_read_barrier_depends()

2017-10-09 Thread Paul E. McKenney
Hello! Will Deacon has proposed adding smp_read_barrier_depends() to READ_ONCE(), which would mean that quite a few instances of smp_read_barrier_depends() would become redundant. This series depends on Will's change and removes those smp_read_barrier_depends(), while fixing a bug or two along th

Re: [PATCH] serial: sh-sci: Remove __init attribute from static struct 'port_cfg'

2017-10-09 Thread Guenter Roeck
On Mon, Oct 9, 2017 at 5:04 PM, Matthias Kaehlcke wrote: > This fixes the following error when building with clang: > > drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only > applies to functions, methods, properties, and global variables > static struct __init plat_sci_p

Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

2017-10-09 Thread Fenglin Wu
On 10/9/2017 1:56 PM, Bjorn Andersson wrote: On Sun 08 Oct 22:34 PDT 2017, Fenglin Wu wrote: On 10/6/2017 12:27 AM, Bjorn Andersson wrote: On Mon 11 Sep 17:32 PDT 2017, fengl...@codeaurora.org wrote: From: Fenglin Wu GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is con

[PATCH] scsi/aic7xxx: Convert timers to use timer_setup()

2017-10-09 Thread Kees Cook
stat_timer only ever assigns the same function and data, so consolidate to using timer_setup(), adjust callback, drop everything else used to pass things around, and remove needless typedefs. reset_timer is unused; remove it. Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: "Martin K. Peterse

Re: [PATCH ALT4 V3 2/2] audit: filter PATH records keyed on filesystem magic

2017-10-09 Thread Steve Grubb
On Thursday, September 7, 2017 6:36:32 PM EDT Paul Moore wrote: > On Wed, Aug 23, 2017 at 7:03 AM, Richard Guy Briggs wrote: > > Tracefs or debugfs were causing hundreds to thousands of PATH records to > > be associated with the init_module and finit_module SYSCALL records on a > > > > few module

Re: [PATCH v4 1/2] PCI: pci-host-generic: add support for Synopsys DesignWare RC in ECAM mode

2017-10-09 Thread Bjorn Helgaas
On Mon, Oct 09, 2017 at 05:46:07PM +0100, Will Deacon wrote: > On Fri, Oct 06, 2017 at 06:21:59PM -0500, Bjorn Helgaas wrote: > > On Fri, Oct 06, 2017 at 05:39:18PM +0100, Ard Biesheuvel wrote: > > > diff --git a/drivers/pci/host/pci-host-generic.c > > > b/drivers/pci/host/pci-host-generic.c > > >

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

2017-10-09 Thread Laura Abbott
On 10/09/2017 03:08 PM, Mark Brown wrote: > On Mon, Oct 09, 2017 at 02:25:47PM -0700, Laura Abbott wrote: > >> Anyway, to move this forward I think we need to see a proof of concept >> of using selinux to protect access to specific heaps. > > Aren't Unix permissions enough with separate files or

[PATCH] timer: Remove meaningless .data/.function assignments

2017-10-09 Thread Kees Cook
Several timer users needlessly reset their .function/.data fields during their timer callback, but nothing else changes them. Some users do not use their .data field at all. Each instance is removed here. Cc: Krzysztof Halasa Cc: Aditya Shankar Cc: Ganesh Krishna Cc: Greg Kroah-Hartman Cc: Jen

Re: [PATCH 3/4] kbuild: re-order the code to not parse unnecessary variables

2017-10-09 Thread Masahiro Yamada
2017-10-10 7:03 GMT+09:00 Doug Anderson : > Hi, > > On Tue, Oct 3, 2017 at 8:56 PM, Masahiro Yamada > wrote: >> The top Makefile is divided into some sections such as mixed targets, >> config targets, build targets, etc. >> >> When we build mixed targets, Kbuild just invokes submake to process >>

Re: [PATCH] Staging: rtlwifi: Remove NULL pointer dereference

2017-10-09 Thread Tobin C. Harding
On Tue, Oct 10, 2017 at 02:48:58AM +0530, Shreeya Patel wrote: > Remove NULL pointer dereference as it results in undefined > behaviour, and will usually lead to a runtime error. The diff does not show any pointer dereference so it is hard to understand what you are trying to do with this patch.

[PATCH] serial: sh-sci: Remove __init attribute from static struct 'port_cfg'

2017-10-09 Thread Matthias Kaehlcke
This fixes the following error when building with clang: drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only applies to functions, methods, properties, and global variables static struct __init plat_sci_port port_cfg; Signed-off-by: Matthias Kaehlcke --- drivers/tty/s

Re: [locking] 892ad5acca [ 12.849409] WARNING: bad unlock balance detected!

2017-10-09 Thread Paul E. McKenney
On Mon, Oct 09, 2017 at 04:24:25PM -0700, Linus Torvalds wrote: > On Mon, Oct 9, 2017 at 8:55 AM, Fengguang Wu wrote: > > > > 0day kernel testing robot got the below dmesg and the first bad commit is > > This makes no sense. > > > [ 12.849409] WARNING: bad unlock balance detected! > > [ 12.8

Re: [PATCH v9 10/29] x86/insn-eval: Do not BUG on invalid register type

2017-10-09 Thread Ricardo Neri
On Sat, 2017-10-07 at 18:22 +0200, Borislav Petkov wrote: > Reviewed-by: Borislav Petkov Thank you! BR, Ricardo

Re: [PATCH] KVM: remove printing of token address

2017-10-09 Thread Tobin C. Harding
On Mon, Oct 09, 2017 at 12:58:12PM +0200, Paolo Bonzini wrote: > On 09/10/2017 12:04, Tobin C. Harding wrote: > > On Mon, Oct 09, 2017 at 03:49:38AM -0400, Paolo Bonzini wrote: > >> > >> > >> - Original Message - > >>> From: "Tobin C. Harding" > >>> To: "Paolo Bonzini" , rkrc...@redhat.com

Re: [PATCH 2/2] media: venus: venc: fix bytesused v4l2_plane field

2017-10-09 Thread Nicolas Dufresne
I confirm this works properly now. This was tested with GStreamer with the following command: gst-launch-1.0 videotestsrc ! v4l2vp8enc ! v4l2vp8dec ! kmssink And the following patch, which is work in progress to implement data_offset. https://gitlab.collabora.com/nicolas/gst-plugins-good/co

Re: [PATCH 3/6] ARM: sun8i: r40: add 5V regulator for Banana Pi M2 Ultra

2017-10-09 Thread Icenowy Zheng
于 2017年10月10日 GMT+08:00 上午5:04:07, Maxime Ripard 写到: >On Sun, Oct 08, 2017 at 04:29:03AM +, Icenowy Zheng wrote: >> On newer revisions of the Banana Pi M2 Ultra boards, the 5V power >output >> (used by HDMI, SATA and USB) is controller via a GPIO. >> >> Add the regulator node for it. >> >

Re: [PATCH 2/6] ARM: sun8i: r40: add USB host port nodes for R40

2017-10-09 Thread Icenowy Zheng
于 2017年10月10日 GMT+08:00 上午5:03:40, Maxime Ripard 写到: >On Sun, Oct 08, 2017 at 04:29:02AM +, Icenowy Zheng wrote: >> From: Icenowy Zheng >> >> Allwinner R40 SoC features a USB OTG port and two USB HOST ports. >> >> Add support for the host ports in the DTSI file. >> >> The OTG controller

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

2017-10-09 Thread Alexei Starovoitov
On Mon, Oct 09, 2017 at 11:15:40PM +, Levin, Alexander (Sasha Levin) wrote: > On Mon, Oct 09, 2017 at 04:06:20PM -0700, Alexei Starovoitov wrote: > >On Mon, Oct 09, 2017 at 08:26:34PM +, Levin, Alexander (Sasha Levin) > >wrote: > >> On Mon, Oct 09, 2017 at 10:15:42AM -0700, Alexei Starovoi

Re: [locking] 892ad5acca [ 12.849409] WARNING: bad unlock balance detected!

2017-10-09 Thread Linus Torvalds
On Mon, Oct 9, 2017 at 8:55 AM, Fengguang Wu wrote: > > 0day kernel testing robot got the below dmesg and the first bad commit is This makes no sense. > [ 12.849409] WARNING: bad unlock balance detected! > [ 12.850157] 4.12.0-00420-g892ad5a #1 Not tainted > [ 12.850870] ---

Re: linux-next: manual merge of the drivers-x86 tree with the net-next tree

2017-10-09 Thread Darren Hart
On Mon, Oct 09, 2017 at 08:56:34PM +0100, Mark Brown wrote: > On Mon, Oct 09, 2017 at 10:43:01PM +0300, Mika Westerberg wrote: > > > If possible, I would rather move this chapter to be before "Networking > > over Thunderbolt cable". Reason is that it then follows NVM flashing > > chapter which is

Re: [PATCH v4 1/2] pid: Replace pid bitmap implementation with IDR API

2017-10-09 Thread Andrew Morton
On Mon, 9 Oct 2017 17:13:43 -0400 Gargi Sharma wrote: > This patch replaces the current bitmap implemetation for > Process ID allocation. Functions that are no longer required, > for example, free_pidmap(), alloc_pidmap(), etc. are removed. > The rest of the functions are modified to use the IDR

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

2017-10-09 Thread David Miller
From: Alexei Starovoitov Date: Mon, 9 Oct 2017 16:06:20 -0700 >> For these archs, wouldn't it then be more efficient to use BUG_ON >> rather than BUG()? > > why more efficient? any data to prove that? It can completely eliminate a branch. For example on powerpc if you use BUG() then the code g

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

2017-10-09 Thread Levin, Alexander (Sasha Levin)
On Mon, Oct 09, 2017 at 04:06:20PM -0700, Alexei Starovoitov wrote: >On Mon, Oct 09, 2017 at 08:26:34PM +, Levin, Alexander (Sasha Levin) wrote: >> On Mon, Oct 09, 2017 at 10:15:42AM -0700, Alexei Starovoitov wrote: >> >On Mon, Oct 09, 2017 at 11:37:59AM -0400, Tim Hansen wrote: >> >> Fix BUG()

Re: [PATCH tip/core/rcu 1/9] rcu: Provide GP ordering in face of migrations and delays

2017-10-09 Thread Paul E. McKenney
On Mon, Oct 09, 2017 at 10:16:37AM +0200, Peter Zijlstra wrote: > On Sat, Oct 07, 2017 at 11:28:57AM -0700, Paul E. McKenney wrote: > > But if you are saying that it would be good to have wait_for_completion() > > and complete() directly modeled at some point, no argument. In addition, > > I hope

[GIT] Networking

2017-10-09 Thread David Miller
1) Fix object leak on IPSEC offload failure, from Steffen Klassert. 2) Fix range checks in ipset address range addition operations, from Jozsef Kadlecsik. 3) Fix pernet ops unregistration order in ipset, from Florian Westphal. 4) Add missing netlink attribute policy for nl80211 packet pat

Re: [PATCH 02/13] EDAC, altera: kill off ACCESS_ONCE()

2017-10-09 Thread Thor Thayer
On 10/09/2017 01:28 PM, Mark Rutland wrote: For several reasons, it is desirable to use {READ,WRITE}_ONCE() in preference to ACCESS_ONCE(), and new code is expected to use one of the former. So far, there's been no reason to change most existing uses of ACCESS_ONCE(), as these aren't currently ha

<    1   2   3   4   5   6   7   8   9   10   >