Re: [PATCH v4 1/2] PCI: pci-host-generic: add support for Synopsys DesignWare RC in ECAM mode

2017-10-09 Thread Will Deacon
On Fri, Oct 06, 2017 at 06:21:59PM -0500, Bjorn Helgaas wrote: > On Fri, Oct 06, 2017 at 05:39:18PM +0100, Ard Biesheuvel wrote: > > diff --git a/drivers/pci/host/pci-host-generic.c > > b/drivers/pci/host/pci-host-generic.c > > index 7d709a7e0aa8..01e81a30e303 100644 > > ---

Re: [PATCH v4 1/2] PCI: pci-host-generic: add support for Synopsys DesignWare RC in ECAM mode

2017-10-09 Thread Will Deacon
On Fri, Oct 06, 2017 at 06:21:59PM -0500, Bjorn Helgaas wrote: > On Fri, Oct 06, 2017 at 05:39:18PM +0100, Ard Biesheuvel wrote: > > diff --git a/drivers/pci/host/pci-host-generic.c > > b/drivers/pci/host/pci-host-generic.c > > index 7d709a7e0aa8..01e81a30e303 100644 > > ---

Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs

2017-10-09 Thread Steven Rostedt
On Sat, 7 Oct 2017 10:55:00 +0200 Ingo Molnar wrote: > So the text first starts talking about 'hooks' then uses the 'callback' > terminology in the rest of th document. Could we please change it all to > 'callback'? > > [ This is a pet peeve of mine as 'hook' gives me the

Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs

2017-10-09 Thread Steven Rostedt
On Sat, 7 Oct 2017 10:55:00 +0200 Ingo Molnar wrote: > So the text first starts talking about 'hooks' then uses the 'callback' > terminology in the rest of th document. Could we please change it all to > 'callback'? > > [ This is a pet peeve of mine as 'hook' gives me the cringe! ;-) ] >

Re: [PATCH v5 1/2] staging: ion: simplify ioctl args checking function

2017-10-09 Thread Laura Abbott
On 10/09/2017 02:21 AM, Benjamin Gaignard wrote: > 2017-09-27 15:20 GMT+02:00 Benjamin Gaignard : >> Make arguments checking more easy to read. >> > > Hi Laura, > > Even if we don't have found a solution for the second patch I believe > this one could be useful. >

Re: [PATCH v5 1/2] staging: ion: simplify ioctl args checking function

2017-10-09 Thread Laura Abbott
On 10/09/2017 02:21 AM, Benjamin Gaignard wrote: > 2017-09-27 15:20 GMT+02:00 Benjamin Gaignard : >> Make arguments checking more easy to read. >> > > Hi Laura, > > Even if we don't have found a solution for the second patch I believe > this one could be useful. > May I ask you your point of

[PATCH] net: thunderx: mark expected switch fall-throughs in nicvf_main()

2017-10-09 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Cc: Sunil Goutham Cc: Robert Richter Cc: linux-arm-ker...@lists.infradead.org Cc: net...@vger.kernel.org Signed-off-by: Gustavo A. R. Silva

[PATCH] net: thunderx: mark expected switch fall-throughs in nicvf_main()

2017-10-09 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Cc: Sunil Goutham Cc: Robert Richter Cc: linux-arm-ker...@lists.infradead.org Cc: net...@vger.kernel.org Signed-off-by: Gustavo A. R. Silva ---

Re: [PATCH 1/9] kbuild: rpm-pkg: remove ppc64 specific image handling

2017-10-09 Thread Masahiro Yamada
2017-09-30 10:10 GMT+09:00 Masahiro Yamada : > This conditional was added by commit 1a0f3d422bb9 ("kbuild: fix > make rpm for powerpc"). Its git-log explains the default kernel > image is zImage, but obviously the current arch/powerpc/Makefile > does not set

Re: [PATCH 1/9] kbuild: rpm-pkg: remove ppc64 specific image handling

2017-10-09 Thread Masahiro Yamada
2017-09-30 10:10 GMT+09:00 Masahiro Yamada : > This conditional was added by commit 1a0f3d422bb9 ("kbuild: fix > make rpm for powerpc"). Its git-log explains the default kernel > image is zImage, but obviously the current arch/powerpc/Makefile > does not set KBUILD_IMAGE, so the image file is

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Yang Shi
On 10/8/17 11:36 PM, Michal Hocko wrote: On Mon 09-10-17 08:33:16, Michal Hocko wrote: On Sat 07-10-17 00:37:55, Yang Shi wrote: On 10/6/17 2:37 AM, Michal Hocko wrote: On Thu 05-10-17 05:29:10, Yang Shi wrote: [...] + list_for_each_entry_safe(s, s2, _caches, list) { +

Re: [PATCH 3/3] mm: oom: show unreclaimable slab info when unreclaimable slabs > user memory

2017-10-09 Thread Yang Shi
On 10/8/17 11:36 PM, Michal Hocko wrote: On Mon 09-10-17 08:33:16, Michal Hocko wrote: On Sat 07-10-17 00:37:55, Yang Shi wrote: On 10/6/17 2:37 AM, Michal Hocko wrote: On Thu 05-10-17 05:29:10, Yang Shi wrote: [...] + list_for_each_entry_safe(s, s2, _caches, list) { +

Re: [RFC PATCH] mm: shm: round up tmpfs size to huge page size when huge=always

2017-10-09 Thread Yang Shi
On 10/8/17 11:48 PM, Michal Hocko wrote: On Sun 08-10-17 15:56:51, Kirill A. Shutemov wrote: On Sat, Oct 07, 2017 at 04:22:10AM +0800, Yang Shi wrote: When passing "huge=always" option for mounting tmpfs, THP is supposed to be allocated all the time when it can fit, but when the available

Re: [RFC PATCH] mm: shm: round up tmpfs size to huge page size when huge=always

2017-10-09 Thread Yang Shi
On 10/8/17 11:48 PM, Michal Hocko wrote: On Sun 08-10-17 15:56:51, Kirill A. Shutemov wrote: On Sat, Oct 07, 2017 at 04:22:10AM +0800, Yang Shi wrote: When passing "huge=always" option for mounting tmpfs, THP is supposed to be allocated all the time when it can fit, but when the available

Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs

2017-10-09 Thread Steven Rostedt
On Mon, 9 Oct 2017 10:33:17 -0600 Jonathan Corbet wrote: > On Mon, 9 Oct 2017 12:20:35 -0400 > Steven Rostedt wrote: > > > > > SAVE_REGS_IF_SUPPORTED - Similar to SAVE_REGS but the registering of a > > > > ftrace_ops on an architecture that does not

Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs

2017-10-09 Thread Steven Rostedt
On Mon, 9 Oct 2017 10:33:17 -0600 Jonathan Corbet wrote: > On Mon, 9 Oct 2017 12:20:35 -0400 > Steven Rostedt wrote: > > > > > SAVE_REGS_IF_SUPPORTED - Similar to SAVE_REGS but the registering of a > > > > ftrace_ops on an architecture that does not support passing of > > > > regs > > >

Re: Re: [RFC PATCH 0/4] PM / Domains: Add support for explicit control of PM domains

2017-10-09 Thread Todor Tomov
Hi, On 30.05.2017 06:41, Rajendra Nayak wrote: > [].. > I was proposing to have such a lower-layer by splitting the existing genpd framework so the drivers would have the option of calling the lower-level power control functions to look-up pm-domains and control them directly

Re: Re: [RFC PATCH 0/4] PM / Domains: Add support for explicit control of PM domains

2017-10-09 Thread Todor Tomov
Hi, On 30.05.2017 06:41, Rajendra Nayak wrote: > [].. > I was proposing to have such a lower-layer by splitting the existing genpd framework so the drivers would have the option of calling the lower-level power control functions to look-up pm-domains and control them directly

Re: [PATCH v6 1/4] sched/clock: interface to allow timestamps early in boot

2017-10-09 Thread Pavel Tatashin
Urgh, that's horrific. Can't we simply make sched_clock() go earlier? (we're violating "notsc" in any case and really should kill that option). Then we can do something like so on top... Hi Peter, I've been thinking about your proposal, and I have one concern: sched_clock() can be

Re: [PATCH v6 1/4] sched/clock: interface to allow timestamps early in boot

2017-10-09 Thread Pavel Tatashin
Urgh, that's horrific. Can't we simply make sched_clock() go earlier? (we're violating "notsc" in any case and really should kill that option). Then we can do something like so on top... Hi Peter, I've been thinking about your proposal, and I have one concern: sched_clock() can be

Re: [PATCH 1/1] driver:garmin gps: use setup_timer

2017-10-09 Thread Kees Cook
On Mon, Oct 9, 2017 at 6:59 AM, Johan Hovold wrote: > On Thu, Sep 21, 2017 at 04:54:24PM +0530, Allen Pais wrote: >> Use setup_timer function instead of initializing timer with the >> function and data fields. > > Why the odd indentation here? > >> Signed-off-by: Allen

Re: [PATCH 1/1] driver:garmin gps: use setup_timer

2017-10-09 Thread Kees Cook
On Mon, Oct 9, 2017 at 6:59 AM, Johan Hovold wrote: > On Thu, Sep 21, 2017 at 04:54:24PM +0530, Allen Pais wrote: >> Use setup_timer function instead of initializing timer with the >> function and data fields. > > Why the odd indentation here? > >> Signed-off-by: Allen Pais >> --- >>

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-09 Thread Krzysztof Kozlowski
On Mon, Oct 09, 2017 at 02:37:14AM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 8 October 2017 at 21:20, Krzysztof Kozlowski wrote: > > On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: > >> Hi Krzysztof, > >> > >> On 6 October 2017 at 12:12, Krzysztof Kozlowski

Re: [RFC 2/2] phy: exynos5-usbdrd: remove disable and enable of phy clk

2017-10-09 Thread Krzysztof Kozlowski
On Mon, Oct 09, 2017 at 02:37:14AM +0530, Anand Moon wrote: > Hi Krzysztof, > > On 8 October 2017 at 21:20, Krzysztof Kozlowski wrote: > > On Sun, Oct 08, 2017 at 06:11:12PM +0530, Anand Moon wrote: > >> Hi Krzysztof, > >> > >> On 6 October 2017 at 12:12, Krzysztof Kozlowski wrote: > >> > On

Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs

2017-10-09 Thread Jonathan Corbet
On Mon, 9 Oct 2017 12:20:35 -0400 Steven Rostedt wrote: > > > SAVE_REGS_IF_SUPPORTED - Similar to SAVE_REGS but the registering of a > > > ftrace_ops on an architecture that does not support passing of regs > > > will not fail with this flag set. But the callback

Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs

2017-10-09 Thread Jonathan Corbet
On Mon, 9 Oct 2017 12:20:35 -0400 Steven Rostedt wrote: > > > SAVE_REGS_IF_SUPPORTED - Similar to SAVE_REGS but the registering of a > > > ftrace_ops on an architecture that does not support passing of regs > > > will not fail with this flag set. But the callback must check if > > >

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Laura Abbott
On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: > On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: >> Hi Greg, >> >> On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: >>> 4.9-stable review patch. If anyone has any objections, please let me know. >> >>

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Laura Abbott
On 10/06/2017 08:10 PM, Levin, Alexander (Sasha Levin) wrote: > On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: >> Hi Greg, >> >> On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: >>> 4.9-stable review patch. If anyone has any objections, please let me know. >> >>

Re: [RESEND PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC

2017-10-09 Thread Eric W. Biederman
Jürg Billeter writes: > On Thu, 2017-10-05 at 18:27 +0200, Oleg Nesterov wrote: >> On 10/03, Jürg Billeter wrote: >> > >> > My use case is to provide a way for a process to spawn a child and >> > ensure that no descendants survive when that child dies. Avoiding >> > runaway

Re: [RESEND PATCH] prctl: add PR_[GS]ET_PDEATHSIG_PROC

2017-10-09 Thread Eric W. Biederman
Jürg Billeter writes: > On Thu, 2017-10-05 at 18:27 +0200, Oleg Nesterov wrote: >> On 10/03, Jürg Billeter wrote: >> > >> > My use case is to provide a way for a process to spawn a child and >> > ensure that no descendants survive when that child dies. Avoiding >> > runaway processes is

Re: [PATCH] hexagon: get rid of #include

2017-10-09 Thread Richard Kuo
On Mon, Oct 09, 2017 at 11:25:28PM +0900, Masahiro Yamada wrote: > >> > > > > How should this patch be handled? > > > > I checked > git://git.kernel.org/pub/scm/linux/kernel/git/rkuo/linux-hexagon-kernel.git > > I could not see any patch applied to the tree since last year. > > Assuming the

Re: [PATCH] hexagon: get rid of #include

2017-10-09 Thread Richard Kuo
On Mon, Oct 09, 2017 at 11:25:28PM +0900, Masahiro Yamada wrote: > >> > > > > How should this patch be handled? > > > > I checked > git://git.kernel.org/pub/scm/linux/kernel/git/rkuo/linux-hexagon-kernel.git > > I could not see any patch applied to the tree since last year. > > Assuming the

Re: [PATCH RFC] ftrace: Clear hashes of saved init functions

2017-10-09 Thread Joel Fernandes
On Mon, Oct 9, 2017 at 9:21 AM, Steven Rostedt wrote: > On Mon, 9 Oct 2017 08:33:51 -0700 > Joel Fernandes wrote: >> >> On Mon, Oct 9, 2017 at 8:09 AM, Steven Rostedt wrote: >> > On Sun, 8 Oct 2017 14:33:04 -0700 >> > Joel Fernandes

Re: [PATCH RFC] ftrace: Clear hashes of saved init functions

2017-10-09 Thread Joel Fernandes
On Mon, Oct 9, 2017 at 9:21 AM, Steven Rostedt wrote: > On Mon, 9 Oct 2017 08:33:51 -0700 > Joel Fernandes wrote: >> >> On Mon, Oct 9, 2017 at 8:09 AM, Steven Rostedt wrote: >> > On Sun, 8 Oct 2017 14:33:04 -0700 >> > Joel Fernandes wrote: >> > >> >> >> >> static void >> >>

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Mark Brown
On Mon, Oct 09, 2017 at 04:23:21PM +, Levin, Alexander (Sasha Levin) wrote: > Okay, so something like [REVIEW automatic-patch-selection for 4.X] > is sort of what you're suggesting? Yeah (perhaps a bit less verbose so some of the actual patch subject is visible!) but something visible like

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Mark Brown
On Mon, Oct 09, 2017 at 04:23:21PM +, Levin, Alexander (Sasha Levin) wrote: > Okay, so something like [REVIEW automatic-patch-selection for 4.X] > is sort of what you're suggesting? Yeah (perhaps a bit less verbose so some of the actual patch subject is visible!) but something visible like

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Will Deacon
On Mon, Oct 09, 2017 at 04:23:21PM +, Levin, Alexander (Sasha Levin) wrote: > On Mon, Oct 09, 2017 at 04:47:46PM +0100, Mark Brown wrote: > >On Mon, Oct 09, 2017 at 02:00:53PM +, Levin, Alexander (Sasha Levin) > >wrote: > > > >> In this case, for example, this patch had a "review cycle"

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Will Deacon
On Mon, Oct 09, 2017 at 04:23:21PM +, Levin, Alexander (Sasha Levin) wrote: > On Mon, Oct 09, 2017 at 04:47:46PM +0100, Mark Brown wrote: > >On Mon, Oct 09, 2017 at 02:00:53PM +, Levin, Alexander (Sasha Levin) > >wrote: > > > >> In this case, for example, this patch had a "review cycle"

Re: [PATCH] infiniband: add MMU dependency for user_mem

2017-10-09 Thread Doug Ledford
On Fri, 2017-10-06 at 09:13 +0200, Arnd Bergmann wrote: > The infiniband subsystem causes a link failure when the umem > driver is built on MMU-less systems: > > mm/mmu_notifier.o: In function `do_mmu_notifier_register': > mmu_notifier.c:(.text+0x32): undefined reference to > `mm_take_all_locks'

Re: [PATCH] infiniband: add MMU dependency for user_mem

2017-10-09 Thread Doug Ledford
On Fri, 2017-10-06 at 09:13 +0200, Arnd Bergmann wrote: > The infiniband subsystem causes a link failure when the umem > driver is built on MMU-less systems: > > mm/mmu_notifier.o: In function `do_mmu_notifier_register': > mmu_notifier.c:(.text+0x32): undefined reference to > `mm_take_all_locks'

Re: [PATCH] kbuild: allow making undefined symbols fatal for external modules

2017-10-09 Thread Masahiro Yamada
2017-10-02 19:50 GMT+09:00 Jonas Gorski : > By passing appropriate values in KBUILD_EXTRA_SYMBOLS it is possible to > make modpost be able to resolve all symbols for external modules, even > between to other external modules. > > Because of this, it might be desirable to

Re: [PATCH] kbuild: allow making undefined symbols fatal for external modules

2017-10-09 Thread Masahiro Yamada
2017-10-02 19:50 GMT+09:00 Jonas Gorski : > By passing appropriate values in KBUILD_EXTRA_SYMBOLS it is possible to > make modpost be able to resolve all symbols for external modules, even > between to other external modules. > > Because of this, it might be desirable to make unresolved symbols an

Re: [PATCH v2] livepatch: unpatch all klp_objects if klp_module_coming fails

2017-10-09 Thread Josh Poimboeuf
On Mon, Oct 09, 2017 at 04:49:29PM +0200, Miroslav Benes wrote: > On Mon, 2 Oct 2017, Joe Lawrence wrote: > > > When an incoming module is considered for livepatching by > > klp_module_coming(), it iterates over multiple patches and multiple > > kernel objects in this order: > > > >

Re: [PATCH v2] livepatch: unpatch all klp_objects if klp_module_coming fails

2017-10-09 Thread Josh Poimboeuf
On Mon, Oct 09, 2017 at 04:49:29PM +0200, Miroslav Benes wrote: > On Mon, 2 Oct 2017, Joe Lawrence wrote: > > > When an incoming module is considered for livepatching by > > klp_module_coming(), it iterates over multiple patches and multiple > > kernel objects in this order: > > > >

Re: [PATCH] net/mlx4_core: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Wed, 2017-10-04 at 17:51 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Tariq Toukan >

Re: [PATCH] net/mlx4_core: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Wed, 2017-10-04 at 17:51 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Tariq Toukan > Cc:

Re: [PATCH] IB/ipoib: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Wed, 2017-10-04 at 17:45 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Doug Ledford >

Re: [PATCH] IB/ipoib: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Wed, 2017-10-04 at 17:45 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Doug Ledford > Cc: Sean Hefty > Cc:

Re: [PATCH] RDMA/i40iw: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Sat, 2017-10-07 at 09:12 -0500, Shiraz Saleem wrote: > Hi Kees, > > Sorry, I didnt notice this earlier, but, you made the change only to > the stats timer > to use the new timer init APIs. Can you do the same for the cm_timer > and terminate_timer > too for i40iw; so that things are

Re: [PATCH] RDMA/i40iw: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Sat, 2017-10-07 at 09:12 -0500, Shiraz Saleem wrote: > Hi Kees, > > Sorry, I didnt notice this earlier, but, you made the change only to > the stats timer > to use the new timer init APIs. Can you do the same for the cm_timer > and terminate_timer > too for i40iw; so that things are

Re: [PATCH] RDMA/i40iw: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Wed, 2017-10-04 at 17:45 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Faisal Latif

Re: [PATCH] RDMA/i40iw: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Wed, 2017-10-04 at 17:45 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. > > Cc: Faisal Latif > Cc: Shiraz Saleem >

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Levin, Alexander (Sasha Levin)
On Mon, Oct 09, 2017 at 04:47:46PM +0100, Mark Brown wrote: >On Mon, Oct 09, 2017 at 02:00:53PM +, Levin, Alexander (Sasha Levin) wrote: > >> In this case, for example, this patch had a "review cycle" of 18 days >> where 4 different emails regarding this patch were sent out as it was >> making

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-09 Thread Levin, Alexander (Sasha Levin)
On Mon, Oct 09, 2017 at 04:47:46PM +0100, Mark Brown wrote: >On Mon, Oct 09, 2017 at 02:00:53PM +, Levin, Alexander (Sasha Levin) wrote: > >> In this case, for example, this patch had a "review cycle" of 18 days >> where 4 different emails regarding this patch were sent out as it was >> making

Re: [PATCH] IB/qib: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Wed, 2017-10-04 at 17:45 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > helper to pass the timer pointer explicitly. > > Cc: Mike Marciniszyn

Re: [PATCH] IB/qib: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Wed, 2017-10-04 at 17:45 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > helper to pass the timer pointer explicitly. > > Cc: Mike Marciniszyn > Cc: Doug

Re: [PATCH] RDMA/nes: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Wed, 2017-10-04 at 17:45 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. A pointer from nesadapter back > to > nesdev

Re: [PATCH] RDMA/nes: Convert timers to use timer_setup()

2017-10-09 Thread Doug Ledford
On Wed, 2017-10-04 at 17:45 -0700, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list > pointer to > all timer callbacks, switch to using the new timer_setup() and > from_timer() > to pass the timer pointer explicitly. A pointer from nesadapter back > to > nesdev

Re: [PATCH RFC] ftrace: Clear hashes of saved init functions

2017-10-09 Thread Steven Rostedt
On Mon, 9 Oct 2017 08:33:51 -0700 Joel Fernandes wrote: > Hi Steve, > > On Mon, Oct 9, 2017 at 8:09 AM, Steven Rostedt wrote: > > On Sun, 8 Oct 2017 14:33:04 -0700 > > Joel Fernandes wrote: > > > >> > >> static void > >>

Re: [PATCH] direct-io: Prevent NULL pointer access in submit_page_section

2017-10-09 Thread Al Viro
On Mon, Oct 09, 2017 at 11:13:18AM +0200, Andreas Gruenbacher wrote: > In the code added to function submit_page_section by commit b1058b981, > sdio->bio can currently be NULL when calling dio_bio_submit. This then > leads to a NULL pointer access in dio_bio_submit, so check for a NULL > bio in

Re: [PATCH RFC] ftrace: Clear hashes of saved init functions

2017-10-09 Thread Steven Rostedt
On Mon, 9 Oct 2017 08:33:51 -0700 Joel Fernandes wrote: > Hi Steve, > > On Mon, Oct 9, 2017 at 8:09 AM, Steven Rostedt wrote: > > On Sun, 8 Oct 2017 14:33:04 -0700 > > Joel Fernandes wrote: > > > >> > >> static void > >> clear_mod_from_hash(struct ftrace_page *pg, struct ftrace_hash

Re: [PATCH] direct-io: Prevent NULL pointer access in submit_page_section

2017-10-09 Thread Al Viro
On Mon, Oct 09, 2017 at 11:13:18AM +0200, Andreas Gruenbacher wrote: > In the code added to function submit_page_section by commit b1058b981, > sdio->bio can currently be NULL when calling dio_bio_submit. This then > leads to a NULL pointer access in dio_bio_submit, so check for a NULL > bio in

Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs

2017-10-09 Thread Steven Rostedt
On Mon, 9 Oct 2017 09:33:50 -0600 Jonathan Corbet wrote: > On Fri, 6 Oct 2017 11:34:30 -0400 > Steven Rostedt wrote: > > > On Fri, 6 Oct 2017 13:49:59 +0900 > > Masami Hiramatsu wrote: > > > > > Steve, could you write a

Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs

2017-10-09 Thread Steven Rostedt
On Mon, 9 Oct 2017 09:33:50 -0600 Jonathan Corbet wrote: > On Fri, 6 Oct 2017 11:34:30 -0400 > Steven Rostedt wrote: > > > On Fri, 6 Oct 2017 13:49:59 +0900 > > Masami Hiramatsu wrote: > > > > > Steve, could you write a documentation how to use ftrace callback? > > > I think I should

Re: [PATCH] [media] ov5645: I2C address change

2017-10-09 Thread Todor Tomov
Hi Laurent :) On 9.10.2017 15:52, Laurent Pinchart wrote: > Hello, > > On Monday, 9 October 2017 12:34:26 EEST Sakari Ailus wrote: >> On Mon, Oct 09, 2017 at 11:36:01AM +0300, Todor Tomov wrote: >>> On 4.10.2017 13:47, Laurent Pinchart wrote: CC'ing the I2C mainling list and the I2C

Re: [PATCH] [media] ov5645: I2C address change

2017-10-09 Thread Todor Tomov
Hi Laurent :) On 9.10.2017 15:52, Laurent Pinchart wrote: > Hello, > > On Monday, 9 October 2017 12:34:26 EEST Sakari Ailus wrote: >> On Mon, Oct 09, 2017 at 11:36:01AM +0300, Todor Tomov wrote: >>> On 4.10.2017 13:47, Laurent Pinchart wrote: CC'ing the I2C mainling list and the I2C

Re: [PATCH v6] PCI: quirks: update Cavium ThunderX ACS quirk implementation

2017-10-09 Thread Vadim Lomovtsev
Hi Bjorn, Would you please consider to take this patch ? It is required to provide correct ACS mask for CN8xxx PCI root ports. WBR, Vadim On Wed, Sep 27, 2017 at 02:18:54PM -0600, Alex Williamson wrote: > On Wed, 27 Sep 2017 11:20:39 -0700 > Vadim Lomovtsev

Re: [PATCH v6] PCI: quirks: update Cavium ThunderX ACS quirk implementation

2017-10-09 Thread Vadim Lomovtsev
Hi Bjorn, Would you please consider to take this patch ? It is required to provide correct ACS mask for CN8xxx PCI root ports. WBR, Vadim On Wed, Sep 27, 2017 at 02:18:54PM -0600, Alex Williamson wrote: > On Wed, 27 Sep 2017 11:20:39 -0700 > Vadim Lomovtsev wrote: > > > This commit makes

[PATCH 02/15] ARM: dts: at91: sama5d27_som1_ek: enable i2c2

2017-10-09 Thread Claudiu Beznea
Enable i2c. Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts index

Re: [PATCH v7 4/6] lib/dlock-list: Make sibling CPUs share the same linked list

2017-10-09 Thread Waiman Long
On 10/09/2017 11:40 AM, Jan Kara wrote: > On Thu 05-10-17 14:43:26, Waiman Long wrote: >> The dlock list needs one list for each of the CPUs available. However, >> for sibling CPUs, they are sharing the L2 and probably L1 caches >> too. As a result, there is not much to gain in term of avoiding >>

[PATCH 02/15] ARM: dts: at91: sama5d27_som1_ek: enable i2c2

2017-10-09 Thread Claudiu Beznea
Enable i2c. Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts index 43bca17b9e4e..03a4c77fd6ab 100644

Re: [PATCH v7 4/6] lib/dlock-list: Make sibling CPUs share the same linked list

2017-10-09 Thread Waiman Long
On 10/09/2017 11:40 AM, Jan Kara wrote: > On Thu 05-10-17 14:43:26, Waiman Long wrote: >> The dlock list needs one list for each of the CPUs available. However, >> for sibling CPUs, they are sharing the L2 and probably L1 caches >> too. As a result, there is not much to gain in term of avoiding >>

[PATCH 03/15] ARM: dts: at91: sama5d27_som1_ek: update serial aliases

2017-10-09 Thread Claudiu Beznea
Overwrite sama5d2.dtsi aliases node to match the at91-sama5d27_som1_ek board configuration. ttyS0 stands for DBGU, ttyS1 for the mikro BUS 1 serial lines and ttyS2 for the mikro BUS 2 serial lines. Signed-off-by: Ludovic Desroches [claudiu.bez...@microchip.com:

[PATCH 03/15] ARM: dts: at91: sama5d27_som1_ek: update serial aliases

2017-10-09 Thread Claudiu Beznea
Overwrite sama5d2.dtsi aliases node to match the at91-sama5d27_som1_ek board configuration. ttyS0 stands for DBGU, ttyS1 for the mikro BUS 1 serial lines and ttyS2 for the mikro BUS 2 serial lines. Signed-off-by: Ludovic Desroches [claudiu.bez...@microchip.com: change subject to match the

[PATCH 06/15] ARM: dts: at91: sama5d27_som1_ek: add pinmuxing for pwm0

2017-10-09 Thread Claudiu Beznea
Add pin muxing for pwm0 and set it as disabled since it is in conflict with the pins for leds. Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 06/15] ARM: dts: at91: sama5d27_som1_ek: add pinmuxing for pwm0

2017-10-09 Thread Claudiu Beznea
Add pin muxing for pwm0 and set it as disabled since it is in conflict with the pins for leds. Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts

Re: [PATCH] cklight: tps65217_bl: Remove unnecessary default brightness check

2017-10-09 Thread Jingoo Han
On Sunday, October 8, 2017 5:57 PM, Christos Gkekas wrote: > > Variable val holds the default brightness and is unsigned, therefore > checking whether it is less than zero is redundant. > > Signed-off-by: Christos Gkekas It looks good. Acked-by: Jingoo Han

[PATCH 07/15] ARM: dts: at91: sama5d27_som1_ek: remove not connected CAN0

2017-10-09 Thread Claudiu Beznea
CAN0 is not connected on the sama5d27_som1_ek board, so remove it from DT. Signed-off-by: Nicolas Ferre [claudiu.bez...@microchip.com: change subject to match the desired prefix] Signed-off-by: Claudiu Beznea ---

Re: [PATCH] cklight: tps65217_bl: Remove unnecessary default brightness check

2017-10-09 Thread Jingoo Han
On Sunday, October 8, 2017 5:57 PM, Christos Gkekas wrote: > > Variable val holds the default brightness and is unsigned, therefore > checking whether it is less than zero is redundant. > > Signed-off-by: Christos Gkekas It looks good. Acked-by: Jingoo Han Best regards, Jingoo Han > --- >

[PATCH 07/15] ARM: dts: at91: sama5d27_som1_ek: remove not connected CAN0

2017-10-09 Thread Claudiu Beznea
CAN0 is not connected on the sama5d27_som1_ek board, so remove it from DT. Signed-off-by: Nicolas Ferre [claudiu.bez...@microchip.com: change subject to match the desired prefix] Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 12 1 file changed, 12

Re: [PATCH] IB/rxe: check for allocation failure on elem

2017-10-09 Thread Doug Ledford
On Mon, 2017-10-09 at 14:18 +0100, Colin Ian King wrote: > On 09/10/17 14:16, Doug Ledford wrote: > > > > > > Since Colin is non-responsive in this thread, I went ahead and took > > his > > patch, but then applied a fixup of my own: > > Sorry, I somehow missed that email. Thanks for following

Re: [PATCH] IB/rxe: check for allocation failure on elem

2017-10-09 Thread Doug Ledford
On Mon, 2017-10-09 at 14:18 +0100, Colin Ian King wrote: > On 09/10/17 14:16, Doug Ledford wrote: > > > > > > Since Colin is non-responsive in this thread, I went ahead and took > > his > > patch, but then applied a fixup of my own: > > Sorry, I somehow missed that email. Thanks for following

[PATCH 05/15] ARM: dts: at91: sama5d27_som1_ek: add aliases for i2c

2017-10-09 Thread Claudiu Beznea
Add aliases for i2c devices to not rely on probe order for i2c device numbering. Signed-off-by: Ludovic Desroches [claudiu.bez...@microchip.com: remove i2c0, change subject] Signed-off-by: Claudiu Beznea ---

[PATCH 05/15] ARM: dts: at91: sama5d27_som1_ek: add aliases for i2c

2017-10-09 Thread Claudiu Beznea
Add aliases for i2c devices to not rely on probe order for i2c device numbering. Signed-off-by: Ludovic Desroches [claudiu.bez...@microchip.com: remove i2c0, change subject] Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 2 ++ 1 file changed, 2 insertions(+)

[PATCH 08/15] ARM: dts: at91: sama5d27_som1_ek: remove pull-up on SD/MMC lines

2017-10-09 Thread Claudiu Beznea
As the board have the proper pull-ups soldered on the data and CMD lines we don't need them specified in the PADs. So remove the "bias-pull-up" property and set "bias-disable". Signed-off-by: Nicolas Ferre [claudiu.bez...@microchip.com: change subject to match the

[PATCH 08/15] ARM: dts: at91: sama5d27_som1_ek: remove pull-up on SD/MMC lines

2017-10-09 Thread Claudiu Beznea
As the board have the proper pull-ups soldered on the data and CMD lines we don't need them specified in the PADs. So remove the "bias-pull-up" property and set "bias-disable". Signed-off-by: Nicolas Ferre [claudiu.bez...@microchip.com: change subject to match the desired prefix] Signed-off-by:

[PATCH] IB/core: remove redundant check on prot_sg_cnt

2017-10-09 Thread Colin King
From: Colin Ian King prot_sg_cnt cannot be zero as a previous check on ret (from which prot_sg_cnt is assigned) returns -ENOMEM if is it zero. Since it cannot be zero we can simplify the code by removing the non -zero check on prot_sg_cnt and redundant else statement.

[PATCH] IB/core: remove redundant check on prot_sg_cnt

2017-10-09 Thread Colin King
From: Colin Ian King prot_sg_cnt cannot be zero as a previous check on ret (from which prot_sg_cnt is assigned) returns -ENOMEM if is it zero. Since it cannot be zero we can simplify the code by removing the non -zero check on prot_sg_cnt and redundant else statement. Detected by CoverityScan,

[PATCH 11/15] ARM: dts: at91: sama5d2_xplained: add pinmuxing for pwm0

2017-10-09 Thread Claudiu Beznea
Add pin muxing for pwm0 and set it as disabled since it is in conflict with pins for leds. Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git

[PATCH 12/15] ARM: dts: at91: sama5d2_xplained: remove pull-up on SD/MMC lines

2017-10-09 Thread Claudiu Beznea
As the board have the proper pull-ups soldered on the data and CMD lines we don't need them specified in the PADs. So remove the "bias-pull-up" property and set "bias-disable". This will also save some power. Signed-off-by: Nicolas Ferre

[PATCH 11/15] ARM: dts: at91: sama5d2_xplained: add pinmuxing for pwm0

2017-10-09 Thread Claudiu Beznea
Add pin muxing for pwm0 and set it as disabled since it is in conflict with pins for leds. Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts

[PATCH 12/15] ARM: dts: at91: sama5d2_xplained: remove pull-up on SD/MMC lines

2017-10-09 Thread Claudiu Beznea
As the board have the proper pull-ups soldered on the data and CMD lines we don't need them specified in the PADs. So remove the "bias-pull-up" property and set "bias-disable". This will also save some power. Signed-off-by: Nicolas Ferre [claudiu.bez...@microchip.com: change subject to match the

[PATCH 13/15] ARM: dts: at91: at91sam9x25ek: add CAN1 interface

2017-10-09 Thread Claudiu Beznea
As the CAN1 interface is not multiplexed with other peripherals on this board, enable it so that it can be tested more easily. Signed-off-by: Nicolas Ferre Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91sam9x25ek.dts | 4

[PATCH 13/15] ARM: dts: at91: at91sam9x25ek: add CAN1 interface

2017-10-09 Thread Claudiu Beznea
As the CAN1 interface is not multiplexed with other peripherals on this board, enable it so that it can be tested more easily. Signed-off-by: Nicolas Ferre Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91sam9x25ek.dts | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 10/15] ARM: dts: at91: sama5d2_xplained: set PB_USER as wakeup source

2017-10-09 Thread Claudiu Beznea
Set the PB_USER button as a wakeup source to resume from ulp0 mode. Signed-off-by: Ludovic Desroches [claudiu.bez...@microchip.com: change subject to match the desired prefix] Signed-off-by: Claudiu Beznea ---

[PATCH 10/15] ARM: dts: at91: sama5d2_xplained: set PB_USER as wakeup source

2017-10-09 Thread Claudiu Beznea
Set the PB_USER button as a wakeup source to resume from ulp0 mode. Signed-off-by: Ludovic Desroches [claudiu.bez...@microchip.com: change subject to match the desired prefix] Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v7 5/6] lib/dlock-list: Enable faster lookup with hashing

2017-10-09 Thread Waiman Long
On 10/09/2017 12:03 PM, Davidlohr Bueso wrote: > On Mon, 09 Oct 2017, Waiman Long wrote: > >> On 10/09/2017 09:08 AM, Davidlohr Bueso wrote: >>> On Thu, 05 Oct 2017, Waiman Long wrote: >>> This patch provides an alternative way of list selection. The caller can provide a object context

Re: [PATCH v7 5/6] lib/dlock-list: Enable faster lookup with hashing

2017-10-09 Thread Waiman Long
On 10/09/2017 12:03 PM, Davidlohr Bueso wrote: > On Mon, 09 Oct 2017, Waiman Long wrote: > >> On 10/09/2017 09:08 AM, Davidlohr Bueso wrote: >>> On Thu, 05 Oct 2017, Waiman Long wrote: >>> This patch provides an alternative way of list selection. The caller can provide a object context

[PATCH 14/15] ARM: dts: at91: at91sam9x25ek: add pwm0

2017-10-09 Thread Claudiu Beznea
Add the PWM0 interface and one output of channel 0 (on PC10) on this headless board. The output conflicts with LCD and ISI, so only enable it for this particular board of the series (ISI is enabled on at91sam9g25ek, as an example but we can do the other way around). Signed-off-by: Nicolas Ferre

[PATCH 14/15] ARM: dts: at91: at91sam9x25ek: add pwm0

2017-10-09 Thread Claudiu Beznea
Add the PWM0 interface and one output of channel 0 (on PC10) on this headless board. The output conflicts with LCD and ISI, so only enable it for this particular board of the series (ISI is enabled on at91sam9g25ek, as an example but we can do the other way around). Signed-off-by: Nicolas Ferre

<    6   7   8   9   10   11   12   13   14   15   >