[PATCH 1/4] x86/unwind: Fix dereference of untrusted pointer

Tetsuo Handa and Fengguang Wu reported a panic in the unwinder: BUG: unable to handle kernel NULL pointer dereference at 01f2 IP: update_stack_state+0xd4/0x340 *pde = Oops: [#1] PREEMPT SMP CPU: 0 PID: 18728 Comm: 01-cpu-hotplug Not tainted 4.13.0-rc4-00170-gb09be67

[PATCH 1/4] x86/unwind: Fix dereference of untrusted pointer

Tetsuo Handa and Fengguang Wu reported a panic in the unwinder: BUG: unable to handle kernel NULL pointer dereference at 01f2 IP: update_stack_state+0xd4/0x340 *pde = Oops: [#1] PREEMPT SMP CPU: 0 PID: 18728 Comm: 01-cpu-hotplug Not tainted 4.13.0-rc4-00170-gb09be67

[PATCH 4/4] x86/unwind: Disable unwinder warnings on 32-bit

x86-32 doesn't have stack validation, so in most cases it doesn't make sense to warn about bad frame pointers. Reported-by: Tetsuo Handa Signed-off-by: Josh Poimboeuf --- arch/x86/kernel/unwind_frame.c | 7 +++ 1 file changed, 7

[PATCH 3/4] x86/unwind: Align stack pointer in unwinder dump

When printing the unwinder dump, the stack pointer could be unaligned, for one of two reasons: - stack corruption; or - GCC created an unaligned stack. There's no way for the unwinder to tell the difference between the two, so we have to assume one or the other. GCC unaligned stacks are very

[PATCH 4/4] x86/unwind: Disable unwinder warnings on 32-bit

x86-32 doesn't have stack validation, so in most cases it doesn't make sense to warn about bad frame pointers. Reported-by: Tetsuo Handa Signed-off-by: Josh Poimboeuf --- arch/x86/kernel/unwind_frame.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/x86/kernel/unwind_frame.c

[PATCH 3/4] x86/unwind: Align stack pointer in unwinder dump

When printing the unwinder dump, the stack pointer could be unaligned, for one of two reasons: - stack corruption; or - GCC created an unaligned stack. There's no way for the unwinder to tell the difference between the two, so we have to assume one or the other. GCC unaligned stacks are very

Re: [PATCH 3/4] sched: WARN when migrating to an offline CPU

On Mon, Oct 09, 2017 at 10:04:45AM +0200, Peter Zijlstra wrote: >On Sat, Oct 07, 2017 at 05:43:32PM +, Levin, Alexander (Sasha Levin) wrote: >> On Sat, Oct 07, 2017 at 11:15:17AM +0200, Peter Zijlstra wrote: >> >On Sat, Oct 07, 2017 at 02:07:26AM +, Levin, Alexander (Sasha Levin) >>

Re: [PATCH 3/4] sched: WARN when migrating to an offline CPU

On Mon, Oct 09, 2017 at 10:04:45AM +0200, Peter Zijlstra wrote: >On Sat, Oct 07, 2017 at 05:43:32PM +, Levin, Alexander (Sasha Levin) wrote: >> On Sat, Oct 07, 2017 at 11:15:17AM +0200, Peter Zijlstra wrote: >> >On Sat, Oct 07, 2017 at 02:07:26AM +, Levin, Alexander (Sasha Levin) >>

[PATCH] perf/ftrace : Fix repetitious traces when specify a target task

When use perf to trace the sched_wakeup and sched_wakeup_new tracepoint, there is a bug that output the same event repetitiously. It can be reproduced by : perf record -e sched:sched_wakeup_new ./bug_fork bug_fork is an demo that can generating wakeup_new events : the parent

[PATCH] perf/ftrace : Fix repetitious traces when specify a target task

When use perf to trace the sched_wakeup and sched_wakeup_new tracepoint, there is a bug that output the same event repetitiously. It can be reproduced by : perf record -e sched:sched_wakeup_new ./bug_fork bug_fork is an demo that can generating wakeup_new events : the parent

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

On Mon, Oct 09, 2017 at 04:23:57PM -0700, Alexei Starovoitov wrote: >On Mon, Oct 09, 2017 at 11:15:40PM +, Levin, Alexander (Sasha Levin) wrote: >> On Mon, Oct 09, 2017 at 04:06:20PM -0700, Alexei Starovoitov wrote: >> >On Mon, Oct 09, 2017 at 08:26:34PM +, Levin, Alexander (Sasha Levin)

Re: [PATCH v2] net/core: Fix BUG to BUG_ON conditionals.

On Mon, Oct 09, 2017 at 04:23:57PM -0700, Alexei Starovoitov wrote: >On Mon, Oct 09, 2017 at 11:15:40PM +, Levin, Alexander (Sasha Levin) wrote: >> On Mon, Oct 09, 2017 at 04:06:20PM -0700, Alexei Starovoitov wrote: >> >On Mon, Oct 09, 2017 at 08:26:34PM +, Levin, Alexander (Sasha Levin)

Re: [PATCH] cifs: Fix bool initialization/comparison

On Sat, Oct 7, 2017 at 10:02 AM, Thomas Meyer via samba-technical wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. Except that "==" is not a pure boolean check. It's a value check, and unless these values are defined

Re: [PATCH] cifs: Fix bool initialization/comparison

On Sat, Oct 7, 2017 at 10:02 AM, Thomas Meyer via samba-technical wrote: > Bool initializations should use true and false. Bool tests don't need > comparisons. Except that "==" is not a pure boolean check. It's a value check, and unless these values are defined *very* carefully they may be set

Re: [PATCH RFC tip/core/rcu 11/15] tracepoint: Remove smp_read_barrier_depends() from comment

- On Oct 9, 2017, at 8:31 PM, rostedt rost...@goodmis.org wrote: > [ added Mathieu ] > > On Mon, 9 Oct 2017 17:22:45 -0700 > "Paul E. McKenney" wrote: > >> The comment in tracepoint_add_func() mentions smp_read_barrier_depends(), >> whose use should be quite

Re: [PATCH RFC tip/core/rcu 11/15] tracepoint: Remove smp_read_barrier_depends() from comment

- On Oct 9, 2017, at 8:31 PM, rostedt rost...@goodmis.org wrote: > [ added Mathieu ] > > On Mon, 9 Oct 2017 17:22:45 -0700 > "Paul E. McKenney" wrote: > >> The comment in tracepoint_add_func() mentions smp_read_barrier_depends(), >> whose use should be quite restricted. This commit

Re: [PATCH v2 4/4] mm:swap: skip swapcache for swapin of synchronous device

Minchan Kim writes: > Hi Huang, > > Sorry for the late response. It was long national holiday. > > On Fri, Sep 29, 2017 at 04:51:17PM +0800, huang ying wrote: >> On Wed, Sep 20, 2017 at 1:43 PM, Minchan Kim wrote: >> > With fast swap storage, platform

Re: [PATCH v2 4/4] mm:swap: skip swapcache for swapin of synchronous device

Minchan Kim writes: > Hi Huang, > > Sorry for the late response. It was long national holiday. > > On Fri, Sep 29, 2017 at 04:51:17PM +0800, huang ying wrote: >> On Wed, Sep 20, 2017 at 1:43 PM, Minchan Kim wrote: >> > With fast swap storage, platform want to use swap more aggressively >> > and

Re: [PATCH] timer: Remove meaningless .data/.function assignments

From: Kees Cook Date: Mon, 9 Oct 2017 17:10:32 -0700 > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. > > Cc:

Re: [PATCH] timer: Remove meaningless .data/.function assignments

From: Kees Cook Date: Mon, 9 Oct 2017 17:10:32 -0700 > Several timer users needlessly reset their .function/.data fields during > their timer callback, but nothing else changes them. Some users do not > use their .data field at all. Each instance is removed here. > > Cc: Krzysztof Halasa > Cc:

Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-10-06 5:58 GMT+09:00 Doug Anderson : > Hi, > > On Thu, Oct 5, 2017 at 12:26 AM, Masahiro Yamada > wrote: >> As far as I tested, I always see only one space after ":=" in v2. >> >> I did not consider this deeply, >> but something is

Re: [RFC PATCH 1/2] kbuild: Add a cache for generated variables

2017-10-06 5:58 GMT+09:00 Doug Anderson : > Hi, > > On Thu, Oct 5, 2017 at 12:26 AM, Masahiro Yamada > wrote: >> As far as I tested, I always see only one space after ":=" in v2. >> >> I did not consider this deeply, >> but something is working nicely behind the scene. > > Try adding this to the

Re: [PATCH v3 2/5] of: reserved_mem: Accessor for acquiring reserved_mem

On Wed, Oct 4, 2017 at 10:32 PM, Bjorn Andersson wrote: > In some cases drivers referencing a reserved-memory region might want to > remap the entire region, but when defining the reserved-memory by "size" > the client driver has no means to know the associated base

Re: [PATCH v3 2/5] of: reserved_mem: Accessor for acquiring reserved_mem

On Wed, Oct 4, 2017 at 10:32 PM, Bjorn Andersson wrote: > In some cases drivers referencing a reserved-memory region might want to > remap the entire region, but when defining the reserved-memory by "size" > the client driver has no means to know the associated base address of > the reserved

Re: [PATCH v3 1/5] of/platform: Generalize /reserved-memory handling

On Wed, Oct 4, 2017 at 10:32 PM, Bjorn Andersson wrote: > By iterating over all /reserved-memory child nodes and match each one to > a list of compatibles that we want to treat specially, we can easily > extend the list of compatibles to handle - without having to

Re: [PATCH v3 1/5] of/platform: Generalize /reserved-memory handling

On Wed, Oct 4, 2017 at 10:32 PM, Bjorn Andersson wrote: > By iterating over all /reserved-memory child nodes and match each one to > a list of compatibles that we want to treat specially, we can easily > extend the list of compatibles to handle - without having to resort to >

Re: [PATCH v3 4/5] soc: qcom: Remote filesystem memory driver

On Wed, Oct 4, 2017 at 10:32 PM, Bjorn Andersson wrote: > The Qualcomm remote file system protocol is used by certain remoteprocs, > in particular the modem, to read and write persistent storage in > platforms where only the application CPU has physical storage access.

Re: [PATCH v2 0/3] Altera ASMI Parallel II IP Core

Hi Everyone, Thanks to Rob Herring for Acking the device tree bindings part of the patch. Does anyone have any feedback for the rest of the patch set? Thanks, Matthew Gerlach On Wed, 20 Sep 2017, matthew.gerl...@linux.intel.com wrote: From: Matthew Gerlach

Re: [PATCH v3 4/5] soc: qcom: Remote filesystem memory driver

On Wed, Oct 4, 2017 at 10:32 PM, Bjorn Andersson wrote: > The Qualcomm remote file system protocol is used by certain remoteprocs, > in particular the modem, to read and write persistent storage in > platforms where only the application CPU has physical storage access. > > The protocol is based

Re: [PATCH v2 0/3] Altera ASMI Parallel II IP Core

Hi Everyone, Thanks to Rob Herring for Acking the device tree bindings part of the patch. Does anyone have any feedback for the rest of the patch set? Thanks, Matthew Gerlach On Wed, 20 Sep 2017, matthew.gerl...@linux.intel.com wrote: From: Matthew Gerlach This patch set adds a

Re: [PATCH 11/13] selftests/powerpc: kill off ACCESS_ONCE()

Mark Rutland writes: > For several reasons, it is desirable to use {READ,WRITE}_ONCE() in > preference to ACCESS_ONCE(), and new code is expected to use one of the > former. So far, there's been no reason to change most existing uses of > ACCESS_ONCE(), as these aren't

Re: [PATCH 11/13] selftests/powerpc: kill off ACCESS_ONCE()

Mark Rutland writes: > For several reasons, it is desirable to use {READ,WRITE}_ONCE() in > preference to ACCESS_ONCE(), and new code is expected to use one of the > former. So far, there's been no reason to change most existing uses of > ACCESS_ONCE(), as these aren't currently harmful. > >

Re: [PATCH 09/15] ARM: dts: at91: sama5d2_xplained: Add charger node of pmic.

Hi Claudiu, On 2017/10/10 0:09, Claudiu Beznea wrote: Add charger device node as a sub-device node of act8945a mfd, move the charger's properties to this node, and use the "interrupts" property to replace "active-semi,irq_gpios" to denote the act8945a charger's irq. Signed-off-by: Wenyou Yang

Re: [PATCH 09/15] ARM: dts: at91: sama5d2_xplained: Add charger node of pmic.

Hi Claudiu, On 2017/10/10 0:09, Claudiu Beznea wrote: Add charger device node as a sub-device node of act8945a mfd, move the charger's properties to this node, and use the "interrupts" property to replace "active-semi,irq_gpios" to denote the act8945a charger's irq. Signed-off-by: Wenyou Yang

Re: [PATCH] serial: sh-sci: Remove __init attribute from static struct 'port_cfg'

El Mon, Oct 09, 2017 at 05:18:32PM -0700 Guenter Roeck ha dit: > On Mon, Oct 9, 2017 at 5:04 PM, Matthias Kaehlcke wrote: > > This fixes the following error when building with clang: > > > > drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only > > applies

Re: [PATCH] serial: sh-sci: Remove __init attribute from static struct 'port_cfg'

El Mon, Oct 09, 2017 at 05:18:32PM -0700 Guenter Roeck ha dit: > On Mon, Oct 9, 2017 at 5:04 PM, Matthias Kaehlcke wrote: > > This fixes the following error when building with clang: > > > > drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only > > applies to functions,

Re: [PATCH v2 4/4] mm:swap: skip swapcache for swapin of synchronous device

Hi Huang, Sorry for the late response. It was long national holiday. On Fri, Sep 29, 2017 at 04:51:17PM +0800, huang ying wrote: > On Wed, Sep 20, 2017 at 1:43 PM, Minchan Kim wrote: > > With fast swap storage, platform want to use swap more aggressively > > and swap-in is

Re: [PATCH v2 4/4] mm:swap: skip swapcache for swapin of synchronous device

Hi Huang, Sorry for the late response. It was long national holiday. On Fri, Sep 29, 2017 at 04:51:17PM +0800, huang ying wrote: > On Wed, Sep 20, 2017 at 1:43 PM, Minchan Kim wrote: > > With fast swap storage, platform want to use swap more aggressively > > and swap-in is crucial to

Re: [PATCH RFC tip/core/rcu 11/15] tracepoint: Remove smp_read_barrier_depends() from comment

[ added Mathieu ] On Mon, 9 Oct 2017 17:22:45 -0700 "Paul E. McKenney" wrote: > The comment in tracepoint_add_func() mentions smp_read_barrier_depends(), > whose use should be quite restricted. This commit updates the comment > to instead mention the

Re: [PATCH RFC tip/core/rcu 11/15] tracepoint: Remove smp_read_barrier_depends() from comment

[ added Mathieu ] On Mon, 9 Oct 2017 17:22:45 -0700 "Paul E. McKenney" wrote: > The comment in tracepoint_add_func() mentions smp_read_barrier_depends(), > whose use should be quite restricted. This commit updates the comment > to instead mention the smp_store_release() and

Re: [RFC v5 4/8] platform: x86: Add generic Intel IPC driver

Hi, On 10/09/2017 12:11 AM, Christoph Hellwig wrote: What does IPC stand for in this device? Inter processor communication -- Sathyanarayanan Kuppuswamy Linux kernel developer

Re: [RFC PATCH 4/4] kbuild: evaluate cc-option and friends only when building kernel

Hi, On Mon, Oct 9, 2017 at 5:23 PM, Masahiro Yamada wrote: > I am still wondering if I should apply this one > because your cache approach provides much more benefits. > > (that is why I prefixed this 4/4 with RFC.) > > > Maybe I will send v2, or maybe not. I'm

Re: [RFC v5 4/8] platform: x86: Add generic Intel IPC driver

Hi, On 10/09/2017 12:11 AM, Christoph Hellwig wrote: What does IPC stand for in this device? Inter processor communication -- Sathyanarayanan Kuppuswamy Linux kernel developer

Re: [RFC PATCH 4/4] kbuild: evaluate cc-option and friends only when building kernel

Hi, On Mon, Oct 9, 2017 at 5:23 PM, Masahiro Yamada wrote: > I am still wondering if I should apply this one > because your cache approach provides much more benefits. > > (that is why I prefixed this 4/4 with RFC.) > > > Maybe I will send v2, or maybe not. I'm not sure I have a strong opinion

Re: [PATCH] watchdog: hpwdt: change maintainer.

On 10/09/2017 11:56 AM, Jerry Hoemann wrote: Signed-off-by: Jerry Hoemann Reviewed-by: Guenter Roeck We should get an Ack from Jimmy, though. Guenter --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] watchdog: hpwdt: change maintainer.

On 10/09/2017 11:56 AM, Jerry Hoemann wrote: Signed-off-by: Jerry Hoemann Reviewed-by: Guenter Roeck We should get an Ack from Jimmy, though. Guenter --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2d3d750..e7dc993

[PATCH RFC tip/core/rcu 10/15] locking: Remove smp_read_barrier_depends() from queued_spin_lock_slowpath()

Queued spinlocks are not used by DEC Alpha, and furthermore operations such as READ_ONCE() and release/relaxed RMW atomics are being changed to imply smp_read_barrier_depends(). This commit therefore removes the now-redundant smp_read_barrier_depends() from queued_spin_lock_slowpath(), and

[PATCH RFC tip/core/rcu 10/15] locking: Remove smp_read_barrier_depends() from queued_spin_lock_slowpath()

Queued spinlocks are not used by DEC Alpha, and furthermore operations such as READ_ONCE() and release/relaxed RMW atomics are being changed to imply smp_read_barrier_depends(). This commit therefore removes the now-redundant smp_read_barrier_depends() from queued_spin_lock_slowpath(), and

[PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove smp_read_barrier_depends()

Now that smp_read_barrier_depends() is implied by READ_ONCE(), adding READ_ONCE() to assoc_array_ptr_to_leaf() and __assoc_array_ptr_to_meta() allows the several smp_read_barrier_depends() calls to be removed from lib/assoc_array.c. This commit makes this change. Signed-off-by: Paul E. McKenney

[PATCH RFC tip/core/rcu 12/15] lib/assoc_array: Remove smp_read_barrier_depends()

Now that smp_read_barrier_depends() is implied by READ_ONCE(), adding READ_ONCE() to assoc_array_ptr_to_leaf() and __assoc_array_ptr_to_meta() allows the several smp_read_barrier_depends() calls to be removed from lib/assoc_array.c. This commit makes this change. Signed-off-by: Paul E. McKenney

[PATCH RFC tip/core/rcu 15/15] keyring: Remove now-redundant smp_read_barrier_depends()

Now that the associative-array library properly heads dependency chains, the various smp_read_barrier_depends() calls in security/keys/keyring.c are no longer needed. This commit therefore removes them. Signed-off-by: Paul E. McKenney Cc: David Howells

[PATCH RFC tip/core/rcu 15/15] keyring: Remove now-redundant smp_read_barrier_depends()

Now that the associative-array library properly heads dependency chains, the various smp_read_barrier_depends() calls in security/keys/keyring.c are no longer needed. This commit therefore removes them. Signed-off-by: Paul E. McKenney Cc: David Howells Cc: James Morris Cc: "Serge E. Hallyn"

[PATCH RFC tip/core/rcu 04/15] fs/dcache: Use release-acquire for name/length update

The code in __d_alloc() carefully orders filling in the NUL character of the name (and the length, hash, and the name itself) with assigning of the name itself. However, prepend_name() does not order the accesses to the ->name and ->len fields, other than on TSO systems. This commit therefore

[PATCH RFC tip/core/rcu 04/15] fs/dcache: Use release-acquire for name/length update

The code in __d_alloc() carefully orders filling in the NUL character of the name (and the length, hash, and the name itself) with assigning of the name itself. However, prepend_name() does not order the accesses to the ->name and ->len fields, other than on TSO systems. This commit therefore

[PATCH RFC tip/core/rcu 05/15] percpu: READ_ONCE() now implies smp_read_barrier_depends()

Because READ_ONCE() now implies smp_read_barrier_depends(), this commit removes the now-redundant smp_read_barrier_depends() following the READ_ONCE() in __ref_is_percpu(). Signed-off-by: Paul E. McKenney Cc: Tejun Heo Cc: Christoph Lameter

[PATCH RFC tip/core/rcu 08/15] seqlock: Remove now-redundant smp_read_barrier_depends()

READ_ONCE() now implies smp_read_barrier_depends(), so this patch removes the now-redundant smp_read_barrier_depends() from raw_read_seqcount_latch(). Signed-off-by: Paul E. McKenney Cc: Peter Zijlstra Cc: Ingo Molnar ---

[PATCH RFC tip/core/rcu 05/15] percpu: READ_ONCE() now implies smp_read_barrier_depends()

Because READ_ONCE() now implies smp_read_barrier_depends(), this commit removes the now-redundant smp_read_barrier_depends() following the READ_ONCE() in __ref_is_percpu(). Signed-off-by: Paul E. McKenney Cc: Tejun Heo Cc: Christoph Lameter --- include/linux/percpu-refcount.h | 6 +++---

[PATCH RFC tip/core/rcu 08/15] seqlock: Remove now-redundant smp_read_barrier_depends()

READ_ONCE() now implies smp_read_barrier_depends(), so this patch removes the now-redundant smp_read_barrier_depends() from raw_read_seqcount_latch(). Signed-off-by: Paul E. McKenney Cc: Peter Zijlstra Cc: Ingo Molnar --- include/linux/seqlock.h | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH RFC tip/core/rcu 01/15] doc: READ_ONCE() now implies smp_barrier_depends()

This commit updates an example in memory-barriers.txt to account for the fact that READ_ONCE() now implies smp_barrier_depends(). Signed-off-by: Paul E. McKenney --- Documentation/memory-barriers.txt | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-)

Re: [RFC PATCH 4/4] kbuild: evaluate cc-option and friends only when building kernel

2017-10-10 7:04 GMT+09:00 Doug Anderson : > Hi, > > On Tue, Oct 3, 2017 at 8:56 PM, Masahiro Yamada > wrote: >> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include >> index 9ffd3dd..222d0a2 100644 >> --- a/scripts/Kbuild.include >>

[PATCH RFC tip/core/rcu 11/15] tracepoint: Remove smp_read_barrier_depends() from comment

The comment in tracepoint_add_func() mentions smp_read_barrier_depends(), whose use should be quite restricted. This commit updates the comment to instead mention the smp_store_release() and rcu_dereference_sched() that the current code actually uses. Signed-off-by: Paul E. McKenney

[PATCH RFC tip/core/rcu 01/15] doc: READ_ONCE() now implies smp_barrier_depends()

This commit updates an example in memory-barriers.txt to account for the fact that READ_ONCE() now implies smp_barrier_depends(). Signed-off-by: Paul E. McKenney --- Documentation/memory-barriers.txt | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git

Re: [RFC PATCH 4/4] kbuild: evaluate cc-option and friends only when building kernel

2017-10-10 7:04 GMT+09:00 Doug Anderson : > Hi, > > On Tue, Oct 3, 2017 at 8:56 PM, Masahiro Yamada > wrote: >> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include >> index 9ffd3dd..222d0a2 100644 >> --- a/scripts/Kbuild.include >> +++ b/scripts/Kbuild.include >> @@ -96,6 +96,13 @@

[PATCH RFC tip/core/rcu 11/15] tracepoint: Remove smp_read_barrier_depends() from comment

The comment in tracepoint_add_func() mentions smp_read_barrier_depends(), whose use should be quite restricted. This commit updates the comment to instead mention the smp_store_release() and rcu_dereference_sched() that the current code actually uses. Signed-off-by: Paul E. McKenney Cc: Ingo

[PATCH RFC tip/core/rcu 07/15] rtnetlink: Update now-misleading smp_read_barrier_depends() comment

Now that READ_ONCE() implies smp_read_barrier_depends(), update the rtnl_dereference() header comment accordingly. Signed-off-by: Paul E. McKenney Cc: "David S. Miller" Cc: Vladislav Yasevich Cc: Mark Rutland

[PATCH RFC tip/core/rcu 14/15] netfilter: Remove now-redundant smp_read_barrier_depends()

READ_ONCE() now implies smp_read_barrier_depends(), which means that the instances in arpt_do_table(), ipt_do_table(), and ip6t_do_table() are now redundant. This commit removes them and adjusts the comments. Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso

[PATCH RFC tip/core/rcu 07/15] rtnetlink: Update now-misleading smp_read_barrier_depends() comment

Now that READ_ONCE() implies smp_read_barrier_depends(), update the rtnl_dereference() header comment accordingly. Signed-off-by: Paul E. McKenney Cc: "David S. Miller" Cc: Vladislav Yasevich Cc: Mark Rutland Cc: David Ahern Cc: Vlad Yasevich --- include/linux/rtnetlink.h | 3 +-- 1 file

[PATCH RFC tip/core/rcu 14/15] netfilter: Remove now-redundant smp_read_barrier_depends()

READ_ONCE() now implies smp_read_barrier_depends(), which means that the instances in arpt_do_table(), ipt_do_table(), and ip6t_do_table() are now redundant. This commit removes them and adjusts the comments. Signed-off-by: Paul E. McKenney Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc:

[PATCH RFC tip/core/rcu 13/15] mm/ksm: Remove now-redundant smp_read_barrier_depends()

Because READ_ONCE() now implies smp_read_barrier_depends(), the smp_read_barrier_depends() in get_ksm_page() is now redundant. This commit removes it and updates the comments. Signed-off-by: Paul E. McKenney Cc: Andrew Morton Cc: Andrea

[PATCH RFC tip/core/rcu 13/15] mm/ksm: Remove now-redundant smp_read_barrier_depends()

Because READ_ONCE() now implies smp_read_barrier_depends(), the smp_read_barrier_depends() in get_ksm_page() is now redundant. This commit removes it and updates the comments. Signed-off-by: Paul E. McKenney Cc: Andrew Morton Cc: Andrea Arcangeli Cc: Minchan Kim Cc: Michal Hocko Cc: "Kirill

[PATCH RFC tip/core/rcu 06/15] rcu: Adjust read-side accessor comments for READ_ONCE()

Now that READ_ONCE() implies smp_read_barrier_depends(), the commit updates now-misleading comments to account for this change. Signed-off-by: Paul E. McKenney --- include/linux/rcupdate.h | 23 +++ 1 file changed, 11 insertions(+), 12

[PATCH RFC tip/core/rcu 06/15] rcu: Adjust read-side accessor comments for READ_ONCE()

Now that READ_ONCE() implies smp_read_barrier_depends(), the commit updates now-misleading comments to account for this change. Signed-off-by: Paul E. McKenney --- include/linux/rcupdate.h | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git

[PATCH RFC tip/core/rcu 02/15] mn10300: READ_ONCE() now implies smp_read_barrier_depends()

Given that READ_ONCE() now implies smp_read_barrier_depends(), there is no need for the open-coded smp_read_barrier_depends() in mn10300_serial_receive_interrupt() and mn10300_serial_poll_get_char(). This commit therefore removes them, but replaces them with comments calling out that carrying

[PATCH RFC tip/core/rcu 03/15] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering

The __qed_spq_block() function expects an smp_read_barrier_depends() to order a prior READ_ONCE() against a later load that does not depend on the prior READ_ONCE(), an expectation that can fail to be met. This commit therefore replaces the READ_ONCE() with smp_load_acquire() and removes the

[PATCH RFC tip/core/rcu 09/15] uprobes: Remove now-redundant smp_read_barrier_depends()

Now that READ_ONCE() implies smp_read_barrier_depends(), the get_xol_area() and get_trampoline_vaddr() no longer need their smp_read_barrier_depends() calls, which this commit removes. While we are here, convert the corresponding smp_wmb() to an smp_store_release(). Signed-off-by: Paul E.

[PATCH RFC tip/core/rcu 02/15] mn10300: READ_ONCE() now implies smp_read_barrier_depends()

Given that READ_ONCE() now implies smp_read_barrier_depends(), there is no need for the open-coded smp_read_barrier_depends() in mn10300_serial_receive_interrupt() and mn10300_serial_poll_get_char(). This commit therefore removes them, but replaces them with comments calling out that carrying

[PATCH RFC tip/core/rcu 03/15] drivers/net/ethernet/qlogic/qed: Fix __qed_spq_block() ordering

The __qed_spq_block() function expects an smp_read_barrier_depends() to order a prior READ_ONCE() against a later load that does not depend on the prior READ_ONCE(), an expectation that can fail to be met. This commit therefore replaces the READ_ONCE() with smp_load_acquire() and removes the

[PATCH RFC tip/core/rcu 09/15] uprobes: Remove now-redundant smp_read_barrier_depends()

Now that READ_ONCE() implies smp_read_barrier_depends(), the get_xol_area() and get_trampoline_vaddr() no longer need their smp_read_barrier_depends() calls, which this commit removes. While we are here, convert the corresponding smp_wmb() to an smp_store_release(). Signed-off-by: Paul E.

[PATCH RFC tip/core/rcu 0/15] Remove to-be-unneeded smp_read_barrier_depends()

Hello! Will Deacon has proposed adding smp_read_barrier_depends() to READ_ONCE(), which would mean that quite a few instances of smp_read_barrier_depends() would become redundant. This series depends on Will's change and removes those smp_read_barrier_depends(), while fixing a bug or two along

[PATCH RFC tip/core/rcu 0/15] Remove to-be-unneeded smp_read_barrier_depends()

Hello! Will Deacon has proposed adding smp_read_barrier_depends() to READ_ONCE(), which would mean that quite a few instances of smp_read_barrier_depends() would become redundant. This series depends on Will's change and removes those smp_read_barrier_depends(), while fixing a bug or two along

Re: [PATCH] serial: sh-sci: Remove __init attribute from static struct 'port_cfg'

On Mon, Oct 9, 2017 at 5:04 PM, Matthias Kaehlcke wrote: > This fixes the following error when building with clang: > > drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only > applies to functions, methods, properties, and global variables > static

Re: [PATCH] serial: sh-sci: Remove __init attribute from static struct 'port_cfg'

On Mon, Oct 9, 2017 at 5:04 PM, Matthias Kaehlcke wrote: > This fixes the following error when building with clang: > > drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only > applies to functions, methods, properties, and global variables > static struct __init

Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

On 10/9/2017 1:56 PM, Bjorn Andersson wrote: On Sun 08 Oct 22:34 PDT 2017, Fenglin Wu wrote: On 10/6/2017 12:27 AM, Bjorn Andersson wrote: On Mon 11 Sep 17:32 PDT 2017, fengl...@codeaurora.org wrote: From: Fenglin Wu GPIO is expected to be disabled iff

Re: [PATCH V1] pinctrl: qcom: spmi-gpio: Update GPIO EN_CTL when setting pin config

On 10/9/2017 1:56 PM, Bjorn Andersson wrote: On Sun 08 Oct 22:34 PDT 2017, Fenglin Wu wrote: On 10/6/2017 12:27 AM, Bjorn Andersson wrote: On Mon 11 Sep 17:32 PDT 2017, fengl...@codeaurora.org wrote: From: Fenglin Wu GPIO is expected to be disabled iff PIN_CONFIG_BIAS_HIGH_IMPEDANCE is

[PATCH] scsi/aic7xxx: Convert timers to use timer_setup()

stat_timer only ever assigns the same function and data, so consolidate to using timer_setup(), adjust callback, drop everything else used to pass things around, and remove needless typedefs. reset_timer is unused; remove it. Cc: Hannes Reinecke Cc: "James E.J. Bottomley"

[PATCH] scsi/aic7xxx: Convert timers to use timer_setup()

stat_timer only ever assigns the same function and data, so consolidate to using timer_setup(), adjust callback, drop everything else used to pass things around, and remove needless typedefs. reset_timer is unused; remove it. Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: "Martin K.

Re: [PATCH ALT4 V3 2/2] audit: filter PATH records keyed on filesystem magic

On Thursday, September 7, 2017 6:36:32 PM EDT Paul Moore wrote: > On Wed, Aug 23, 2017 at 7:03 AM, Richard Guy Briggs wrote: > > Tracefs or debugfs were causing hundreds to thousands of PATH records to > > be associated with the init_module and finit_module SYSCALL records on a >

Re: [PATCH v4 1/2] PCI: pci-host-generic: add support for Synopsys DesignWare RC in ECAM mode

On Mon, Oct 09, 2017 at 05:46:07PM +0100, Will Deacon wrote: > On Fri, Oct 06, 2017 at 06:21:59PM -0500, Bjorn Helgaas wrote: > > On Fri, Oct 06, 2017 at 05:39:18PM +0100, Ard Biesheuvel wrote: > > > diff --git a/drivers/pci/host/pci-host-generic.c > > > b/drivers/pci/host/pci-host-generic.c > >

Re: [PATCH ALT4 V3 2/2] audit: filter PATH records keyed on filesystem magic

On Thursday, September 7, 2017 6:36:32 PM EDT Paul Moore wrote: > On Wed, Aug 23, 2017 at 7:03 AM, Richard Guy Briggs wrote: > > Tracefs or debugfs were causing hundreds to thousands of PATH records to > > be associated with the init_module and finit_module SYSCALL records on a > > > > few

Re: [PATCH v4 1/2] PCI: pci-host-generic: add support for Synopsys DesignWare RC in ECAM mode

On Mon, Oct 09, 2017 at 05:46:07PM +0100, Will Deacon wrote: > On Fri, Oct 06, 2017 at 06:21:59PM -0500, Bjorn Helgaas wrote: > > On Fri, Oct 06, 2017 at 05:39:18PM +0100, Ard Biesheuvel wrote: > > > diff --git a/drivers/pci/host/pci-host-generic.c > > > b/drivers/pci/host/pci-host-generic.c > >

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

On 10/09/2017 03:08 PM, Mark Brown wrote: > On Mon, Oct 09, 2017 at 02:25:47PM -0700, Laura Abbott wrote: > >> Anyway, to move this forward I think we need to see a proof of concept >> of using selinux to protect access to specific heaps. > > Aren't Unix permissions enough with separate files or

Re: [PATCH v5 2/2] staging: ion: create one device entry per heap

On 10/09/2017 03:08 PM, Mark Brown wrote: > On Mon, Oct 09, 2017 at 02:25:47PM -0700, Laura Abbott wrote: > >> Anyway, to move this forward I think we need to see a proof of concept >> of using selinux to protect access to specific heaps. > > Aren't Unix permissions enough with separate files or

[PATCH] timer: Remove meaningless .data/.function assignments

Several timer users needlessly reset their .function/.data fields during their timer callback, but nothing else changes them. Some users do not use their .data field at all. Each instance is removed here. Cc: Krzysztof Halasa Cc: Aditya Shankar Cc:

Re: [PATCH 3/4] kbuild: re-order the code to not parse unnecessary variables

2017-10-10 7:03 GMT+09:00 Doug Anderson : > Hi, > > On Tue, Oct 3, 2017 at 8:56 PM, Masahiro Yamada > wrote: >> The top Makefile is divided into some sections such as mixed targets, >> config targets, build targets, etc. >> >> When we build

[PATCH] timer: Remove meaningless .data/.function assignments

Several timer users needlessly reset their .function/.data fields during their timer callback, but nothing else changes them. Some users do not use their .data field at all. Each instance is removed here. Cc: Krzysztof Halasa Cc: Aditya Shankar Cc: Ganesh Krishna Cc: Greg Kroah-Hartman Cc:

Re: [PATCH 3/4] kbuild: re-order the code to not parse unnecessary variables

2017-10-10 7:03 GMT+09:00 Doug Anderson : > Hi, > > On Tue, Oct 3, 2017 at 8:56 PM, Masahiro Yamada > wrote: >> The top Makefile is divided into some sections such as mixed targets, >> config targets, build targets, etc. >> >> When we build mixed targets, Kbuild just invokes submake to process >>

Re: [PATCH] Staging: rtlwifi: Remove NULL pointer dereference

On Tue, Oct 10, 2017 at 02:48:58AM +0530, Shreeya Patel wrote: > Remove NULL pointer dereference as it results in undefined > behaviour, and will usually lead to a runtime error. The diff does not show any pointer dereference so it is hard to understand what you are trying to do with this patch.

Re: [PATCH] Staging: rtlwifi: Remove NULL pointer dereference

On Tue, Oct 10, 2017 at 02:48:58AM +0530, Shreeya Patel wrote: > Remove NULL pointer dereference as it results in undefined > behaviour, and will usually lead to a runtime error. The diff does not show any pointer dereference so it is hard to understand what you are trying to do with this patch.

[PATCH] serial: sh-sci: Remove __init attribute from static struct 'port_cfg'

This fixes the following error when building with clang: drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only applies to functions, methods, properties, and global variables static struct __init plat_sci_port port_cfg; Signed-off-by: Matthias Kaehlcke

[PATCH] serial: sh-sci: Remove __init attribute from static struct 'port_cfg'

This fixes the following error when building with clang: drivers/tty/serial/sh-sci.c:3247:15: error: '__section__' attribute only applies to functions, methods, properties, and global variables static struct __init plat_sci_port port_cfg; Signed-off-by: Matthias Kaehlcke ---

<    1   2   3   4   5   6   7   8   9   10   >