[PATCH] sound: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. These are all the "mechanical" changes remaining in the sound subsystem. Cc: Jaroslav Kysela

[PATCH] sound: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. These are all the "mechanical" changes remaining in the sound subsystem. Cc: Jaroslav Kysela Cc: Takashi

Re: [PATCH 2/2] crypto: s5p-sss: Add HASH support for Exynos

2017-10-25 Thread Vladimir Zapolskiy
Hi Kamil, thank you for updates, everything looks good from my point of view. On 10/25/2017 05:57 PM, Kamil Konieczny wrote: > Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW. > It uses the crypto framework asynchronous hash api. > It is based on omap-sham.c driver. > S5P has

Re: [PATCH 2/2] crypto: s5p-sss: Add HASH support for Exynos

2017-10-25 Thread Vladimir Zapolskiy
Hi Kamil, thank you for updates, everything looks good from my point of view. On 10/25/2017 05:57 PM, Kamil Konieczny wrote: > Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW. > It uses the crypto framework asynchronous hash api. > It is based on omap-sham.c driver. > S5P has

Re: [PATCH v3 2/2] ima: check signature enforcement against cmdline param instead of CONFIG

2017-10-25 Thread Bruno E. O. Meneguele
On 24-10, Mimi Zohar wrote: > On Tue, 2017-10-24 at 15:37 -0200, Bruno E. O. Meneguele wrote: > > When the user requests MODULE_CHECK policy and its kernel is compiled > > with CONFIG_MODULE_SIG_FORCE not set, all modules would not load, just > > those loaded in initram time. One option the user

Re: [PATCH v3 2/2] ima: check signature enforcement against cmdline param instead of CONFIG

2017-10-25 Thread Bruno E. O. Meneguele
On 24-10, Mimi Zohar wrote: > On Tue, 2017-10-24 at 15:37 -0200, Bruno E. O. Meneguele wrote: > > When the user requests MODULE_CHECK policy and its kernel is compiled > > with CONFIG_MODULE_SIG_FORCE not set, all modules would not load, just > > those loaded in initram time. One option the user

Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

2017-10-25 Thread Bart Van Assche
On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote: > However, maintainers: sorry to send this one -- it can't be merged > yet, this uses timer_setup_on_stack() which is only in -next right > now. If it looks okay, though, I can carry this in the timer tree. Hello Kees, Can you have a look at

Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

2017-10-25 Thread Bart Van Assche
On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote: > However, maintainers: sorry to send this one -- it can't be merged > yet, this uses timer_setup_on_stack() which is only in -next right > now. If it looks okay, though, I can carry this in the timer tree. Hello Kees, Can you have a look at

Re: [PATCH 1/8] SOC: brcmstb: add memory API

2017-10-25 Thread Jim Quinlan
On Tue, Oct 24, 2017 at 8:23 PM, Florian Fainelli wrote: > Hi Jim, > > On 10/24/2017 11:15 AM, Jim Quinlan wrote: >> +#elif defined(CONFIG_MIPS) >> +int brcmstb_memory_phys_addr_to_memc(phys_addr_t pa) >> +{ >> + /* The logic here is fairly simple and hardcoded: if pa <=

Re: [PATCH 1/8] SOC: brcmstb: add memory API

2017-10-25 Thread Jim Quinlan
On Tue, Oct 24, 2017 at 8:23 PM, Florian Fainelli wrote: > Hi Jim, > > On 10/24/2017 11:15 AM, Jim Quinlan wrote: >> +#elif defined(CONFIG_MIPS) >> +int brcmstb_memory_phys_addr_to_memc(phys_addr_t pa) >> +{ >> + /* The logic here is fairly simple and hardcoded: if pa <= 0x5000_, >> +

Re: [PATCH v8 5/5] dt-bindings: watchdog: Add bindings for RAVE SP watchdog driver

2017-10-25 Thread Andrey Smirnov
On Tue, Oct 24, 2017 at 12:07 PM, Rob Herring wrote: > On Wed, Oct 18, 2017 at 10:01:36AM -0700, Andrey Smirnov wrote: > > Commit msg? > OK, will add in v9. >> Cc: linux-kernel@vger.kernel.org >> Cc: devicet...@vger.kernel.org >> Cc: linux-watch...@vger.kernel.org >> Cc:

Re: [PATCH v8 5/5] dt-bindings: watchdog: Add bindings for RAVE SP watchdog driver

2017-10-25 Thread Andrey Smirnov
On Tue, Oct 24, 2017 at 12:07 PM, Rob Herring wrote: > On Wed, Oct 18, 2017 at 10:01:36AM -0700, Andrey Smirnov wrote: > > Commit msg? > OK, will add in v9. >> Cc: linux-kernel@vger.kernel.org >> Cc: devicet...@vger.kernel.org >> Cc: linux-watch...@vger.kernel.org >> Cc: cphe...@gmail.com >>

Re: [PATCH v2] lib: optimize cpumask_next_and()

2017-10-25 Thread Yury Norov
On Tue, Oct 24, 2017 at 12:51:59PM +0200, Clement Courbet wrote: > We've measured that we spend ~0.6% of sys cpu time in cpumask_next_and(). > It's essentially a joined iteration in search for a non-zero bit, which > is currently implemented as a lookup join (find a nonzero bit on the > lhs,

Re: [PATCH v2] lib: optimize cpumask_next_and()

2017-10-25 Thread Yury Norov
On Tue, Oct 24, 2017 at 12:51:59PM +0200, Clement Courbet wrote: > We've measured that we spend ~0.6% of sys cpu time in cpumask_next_and(). > It's essentially a joined iteration in search for a non-zero bit, which > is currently implemented as a lookup join (find a nonzero bit on the > lhs,

[PATCH 1/2] crypto: s5p-sss: Change spaces to tabs

2017-10-25 Thread Kamil Konieczny
Change #define lines to use tabs consistently. Acked-by: Vladimir Zapolskiy Reviewed-by: Krzysztof Kozlowski Signed-off-by: Kamil Konieczny --- drivers/crypto/s5p-sss.c | 190 +++ 1

[PATCH 1/2] crypto: s5p-sss: Change spaces to tabs

2017-10-25 Thread Kamil Konieczny
Change #define lines to use tabs consistently. Acked-by: Vladimir Zapolskiy Reviewed-by: Krzysztof Kozlowski Signed-off-by: Kamil Konieczny --- drivers/crypto/s5p-sss.c | 190 +++ 1 file changed, 95 insertions(+), 95 deletions(-) diff --git

[PATCH 2/2] crypto: s5p-sss: Add HASH support for Exynos

2017-10-25 Thread Kamil Konieczny
Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW. It uses the crypto framework asynchronous hash api. It is based on omap-sham.c driver. S5P has some HW differencies and is not implemented. Modifications in s5p-sss: - Add hash supporting structures and functions. - Modify irq

[PATCH 2/2] crypto: s5p-sss: Add HASH support for Exynos

2017-10-25 Thread Kamil Konieczny
Add support for MD5, SHA1, SHA256 hash algorithms for Exynos HW. It uses the crypto framework asynchronous hash api. It is based on omap-sham.c driver. S5P has some HW differencies and is not implemented. Modifications in s5p-sss: - Add hash supporting structures and functions. - Modify irq

[PATCH v8 0/2] crypto: s5p-sss: Add HASH support for Exynos

2017-10-25 Thread Kamil Konieczny
First patch change spaces to tabs, second adds HASH support for Exynos. Changes: version 8: - fixes suggested by Vladimir Zapolskiy: drop first condition check in s5p_hash_import, delete unused include delay.h, fix typo in commit message, fix descriptions of struct s5p_hash_reqctx and

[PATCH v8 0/2] crypto: s5p-sss: Add HASH support for Exynos

2017-10-25 Thread Kamil Konieczny
First patch change spaces to tabs, second adds HASH support for Exynos. Changes: version 8: - fixes suggested by Vladimir Zapolskiy: drop first condition check in s5p_hash_import, delete unused include delay.h, fix typo in commit message, fix descriptions of struct s5p_hash_reqctx and

[PATCH v2] iio : Add cm3218 smbus ara and acpi support

2017-10-25 Thread Marc CAPDEVILLE
On asus T100, Capella cm3218 chip is implemented as ambiant light sensor. This chip expose an smbus ARA protocol device on standard address 0x0c. The chip is not functional before all alerts are acknowledged. On asus T100, this device is enumerated on ACPI bus and the description give tow I2C

[PATCH v2] iio : Add cm3218 smbus ara and acpi support

2017-10-25 Thread Marc CAPDEVILLE
On asus T100, Capella cm3218 chip is implemented as ambiant light sensor. This chip expose an smbus ARA protocol device on standard address 0x0c. The chip is not functional before all alerts are acknowledged. On asus T100, this device is enumerated on ACPI bus and the description give tow I2C

Re: [PATCH v2 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute

2017-10-25 Thread Rob Herring
On Thu, Oct 19, 2017 at 08:55:59AM +0530, Raveendra Padasalagi wrote: > Add documentation on optional dt attribute "debounce-timeout-ms" > in extcon node to capture user specified timeout value for id > and vbus gpio detection. > > Signed-off-by: Raveendra Padasalagi

Re: [PATCH v2 1/2] Documentation: dt: extcon: add optional debounce-timeout-ms attribute

2017-10-25 Thread Rob Herring
On Thu, Oct 19, 2017 at 08:55:59AM +0530, Raveendra Padasalagi wrote: > Add documentation on optional dt attribute "debounce-timeout-ms" > in extcon node to capture user specified timeout value for id > and vbus gpio detection. > > Signed-off-by: Raveendra Padasalagi > Reviewed-by: Ray Jui >

Re: [PATCH v4 19/27] x86: assembly, make some functions local

2017-10-25 Thread Mark Rutland
On Wed, Oct 25, 2017 at 04:21:48PM +0200, Jiri Slaby wrote: > Hi, > > On 10/06/2017, 03:21 PM, Mark Rutland wrote: > > If the aim of this series is to introduce something that architectures > > use consistently, then can we please actually poke other architectures > > about it? e.g. send this to

Re: [PATCH v4 19/27] x86: assembly, make some functions local

2017-10-25 Thread Mark Rutland
On Wed, Oct 25, 2017 at 04:21:48PM +0200, Jiri Slaby wrote: > Hi, > > On 10/06/2017, 03:21 PM, Mark Rutland wrote: > > If the aim of this series is to introduce something that architectures > > use consistently, then can we please actually poke other architectures > > about it? e.g. send this to

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

2017-10-25 Thread PrasannaKumar Muralidharan
Hi Jarkko, On 24 October 2017 at 23:52, Jarkko Sakkinen wrote: > On Tue, Oct 24, 2017 at 10:05:20PM +0530, PrasannaKumar Muralidharan wrote: >> > 1. Every user in the kernel is using TPM_ANY_NUM, which means there are >> >no other users. >> >> Completely

Re: [tpmdd-devel] [PATCH] tpm: remove chip_num parameter from in-kernel API

2017-10-25 Thread PrasannaKumar Muralidharan
Hi Jarkko, On 24 October 2017 at 23:52, Jarkko Sakkinen wrote: > On Tue, Oct 24, 2017 at 10:05:20PM +0530, PrasannaKumar Muralidharan wrote: >> > 1. Every user in the kernel is using TPM_ANY_NUM, which means there are >> >no other users. >> >> Completely agree that there is no in kernel

Re: alpha boot hang - 4.14-rc* regression

2017-10-25 Thread Meelis Roos
> > > > removing libata modules and rebooting fixes it - so it seems to be > > > > loading of libata. > > > > > > Can you please cherry-pick: > > > > > > commit b1f9e5e355e9 ("ide: fix IRQ assignment for PCI bus order probing") > > > > > > from mainline and let us know if that solves the issue

Re: alpha boot hang - 4.14-rc* regression

2017-10-25 Thread Meelis Roos
> > > > removing libata modules and rebooting fixes it - so it seems to be > > > > loading of libata. > > > > > > Can you please cherry-pick: > > > > > > commit b1f9e5e355e9 ("ide: fix IRQ assignment for PCI bus order probing") > > > > > > from mainline and let us know if that solves the issue

Re: [RFC] perf tool: Fix memory corruption because of zero length symbols

2017-10-25 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 25, 2017 at 02:50:33PM +0530, Naveen N. Rao escreveu: > On 2017/10/25 08:28AM, Jiri Olsa wrote: > > On Tue, Oct 24, 2017 at 07:50:06PM +0530, Ravi Bangoria wrote: > > > Perf top is often crashing at very random locations on powerpc. > > > After investigating, I found the crash only

Re: [RFC] perf tool: Fix memory corruption because of zero length symbols

2017-10-25 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 25, 2017 at 02:50:33PM +0530, Naveen N. Rao escreveu: > On 2017/10/25 08:28AM, Jiri Olsa wrote: > > On Tue, Oct 24, 2017 at 07:50:06PM +0530, Ravi Bangoria wrote: > > > Perf top is often crashing at very random locations on powerpc. > > > After investigating, I found the crash only

Re: [RFC v4 13/17] [media] vb2: add in-fence support to QBUF

2017-10-25 Thread Brian Starkey
Hi Gustavo, On Fri, Oct 20, 2017 at 07:50:08PM -0200, Gustavo Padovan wrote: From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers are only queued to the driver once they are

Re: [RFC v4 13/17] [media] vb2: add in-fence support to QBUF

2017-10-25 Thread Brian Starkey
Hi Gustavo, On Fri, Oct 20, 2017 at 07:50:08PM -0200, Gustavo Padovan wrote: From: Gustavo Padovan Receive in-fence from userspace and add support for waiting on them before queueing the buffer to the driver. Buffers are only queued to the driver once they are ready. A buffer is ready when

Re: [PATCH] tpm: Move Linux RNG connection to hwrng

2017-10-25 Thread PrasannaKumar Muralidharan
Hi Jason, Nice to see this patch. Some minor comments below. On 25 October 2017 at 00:12, Jason Gunthorpe wrote: > The tpm-rng.c approach is completely inconsistent with how the kernel > handles hotplug. Instead manage a hwrng device for each TPM. This will >

Re: [PATCH] tpm: Move Linux RNG connection to hwrng

2017-10-25 Thread PrasannaKumar Muralidharan
Hi Jason, Nice to see this patch. Some minor comments below. On 25 October 2017 at 00:12, Jason Gunthorpe wrote: > The tpm-rng.c approach is completely inconsistent with how the kernel > handles hotplug. Instead manage a hwrng device for each TPM. This will > cause the kernel to read entropy

Re: [PATCH v6 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-25 Thread Boris Ostrovsky
On 10/24/2017 01:33 PM, Stefano Stabellini wrote: > Also add pvcalls-front to the Makefile. > > Signed-off-by: Stefano Stabellini > CC: boris.ostrov...@oracle.com > CC: jgr...@suse.com > --- > drivers/xen/Kconfig | 9 + > drivers/xen/Makefile | 1 + > 2 files

Re: [PATCH v6 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-25 Thread Boris Ostrovsky
On 10/24/2017 01:33 PM, Stefano Stabellini wrote: > Also add pvcalls-front to the Makefile. > > Signed-off-by: Stefano Stabellini > CC: boris.ostrov...@oracle.com > CC: jgr...@suse.com > --- > drivers/xen/Kconfig | 9 + > drivers/xen/Makefile | 1 + > 2 files changed, 10 insertions(+) >

Re: I2C-PIIX4: Use common error handling code in piix4_probe()

2017-10-25 Thread SF Markus Elfring
> I'm no longer taking patches from you. Why do you not like another update suggestion for this use case? Regards, Markus

Re: I2C-PIIX4: Use common error handling code in piix4_probe()

2017-10-25 Thread SF Markus Elfring
> I'm no longer taking patches from you. Why do you not like another update suggestion for this use case? Regards, Markus

[PATCH] iio/accel/bmc150: Improve unlocking of a mutex in two functions

2017-10-25 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 25 Oct 2017 16:26:29 +0200 Add a jump target so that a call of the function "mutex_unlock" is mostly stored at the end of these function implementations. Replace five calls by goto statements. This issue was detected by using the

[PATCH] iio/accel/bmc150: Improve unlocking of a mutex in two functions

2017-10-25 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 25 Oct 2017 16:26:29 +0200 Add a jump target so that a call of the function "mutex_unlock" is mostly stored at the end of these function implementations. Replace five calls by goto statements. This issue was detected by using the Coccinelle software.

Re: [PATCH] I2C-PIIX4: Use common error handling code in piix4_probe()

2017-10-25 Thread Jean Delvare
On mer., 2017-10-25 at 13:40 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 25 Oct 2017 13:30:18 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by

Re: [PATCH] I2C-PIIX4: Use common error handling code in piix4_probe()

2017-10-25 Thread Jean Delvare
On mer., 2017-10-25 at 13:40 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 25 Oct 2017 13:30:18 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle software.

Re: fuse readdirplus skip one entry when interrupted by signal

2017-10-25 Thread Miklos Szeredi
On Wed, Oct 25, 2017 at 4:28 PM, Marios Titas wrote: > Original reporter here ("Haskell user"). I tested your patch and everything > works as expected now. Thanks for the prompt response! Thanks for the report and testing. Thanks, Miklos

Re: fuse readdirplus skip one entry when interrupted by signal

2017-10-25 Thread Miklos Szeredi
On Wed, Oct 25, 2017 at 4:28 PM, Marios Titas wrote: > Original reporter here ("Haskell user"). I tested your patch and everything > works as expected now. Thanks for the prompt response! Thanks for the report and testing. Thanks, Miklos

Re: [PATCH v2 0/7] fix fanotify issues with the series in v4.12

2017-10-25 Thread Miklos Szeredi
On Wed, Oct 25, 2017 at 10:41 AM, Miklos Szeredi wrote: > We discovered some problems in the latest fsnotify/fanotify codebase with > the help of a stress test (Xiong Zhou is working on upstreaming it to > fstests). > > This series attempts to fix these. With the patch

Re: [PATCH v2 0/7] fix fanotify issues with the series in v4.12

2017-10-25 Thread Miklos Szeredi
On Wed, Oct 25, 2017 at 10:41 AM, Miklos Szeredi wrote: > We discovered some problems in the latest fsnotify/fanotify codebase with > the help of a stress test (Xiong Zhou is working on upstreaming it to > fstests). > > This series attempts to fix these. With the patch applied the stress test >

Re: [PATCH v6 12/13] xen/pvcalls: implement release command

2017-10-25 Thread Boris Ostrovsky
On 10/24/2017 01:33 PM, Stefano Stabellini wrote: > Send PVCALLS_RELEASE to the backend and wait for a reply. Take both > in_mutex and out_mutex to avoid concurrent accesses. Then, free the > socket. > > For passive sockets, check whether we have already pre-allocated an > active socket for the

Re: [PATCH v6 12/13] xen/pvcalls: implement release command

2017-10-25 Thread Boris Ostrovsky
On 10/24/2017 01:33 PM, Stefano Stabellini wrote: > Send PVCALLS_RELEASE to the backend and wait for a reply. Take both > in_mutex and out_mutex to avoid concurrent accesses. Then, free the > socket. > > For passive sockets, check whether we have already pre-allocated an > active socket for the

Re: [PATCH] drm/i915/selftests: Convert timers to use timer_setup()

2017-10-25 Thread Jani Nikula
On Wed, 25 Oct 2017, Kees Cook wrote: > On Wed, Oct 25, 2017 at 4:16 PM, Chris Wilson > wrote: >> Quoting Kees Cook (2017-10-25 15:05:13) >>> On Wed, Oct 25, 2017 at 3:11 PM, Chris Wilson >>> wrote: >>> > Quoting Chris

Re: [PATCH] drm/i915/selftests: Convert timers to use timer_setup()

2017-10-25 Thread Jani Nikula
On Wed, 25 Oct 2017, Kees Cook wrote: > On Wed, Oct 25, 2017 at 4:16 PM, Chris Wilson > wrote: >> Quoting Kees Cook (2017-10-25 15:05:13) >>> On Wed, Oct 25, 2017 at 3:11 PM, Chris Wilson >>> wrote: >>> > Quoting Chris Wilson (2017-10-25 11:24:19) >>> >> Quoting Chris Wilson (2017-10-24

Re: fuse readdirplus skip one entry when interrupted by signal

2017-10-25 Thread Marios Titas
On Wed, Oct 25, 2017 at 11:38:09AM +0200, Miklos Szeredi wrote: On Tue, Oct 24, 2017 at 08:10:49PM +0200, Jakob Unterwurzacher wrote: A user running a Haskell program [1] noticed a problem with fuse's readdirplus: when it is interrupted by a signal, it skips one directory entry. The problem is

Re: fuse readdirplus skip one entry when interrupted by signal

2017-10-25 Thread Marios Titas
On Wed, Oct 25, 2017 at 11:38:09AM +0200, Miklos Szeredi wrote: On Tue, Oct 24, 2017 at 08:10:49PM +0200, Jakob Unterwurzacher wrote: A user running a Haskell program [1] noticed a problem with fuse's readdirplus: when it is interrupted by a signal, it skips one directory entry. The problem is

Re: [PATCH] drm/i915/selftests: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
On Wed, Oct 25, 2017 at 4:16 PM, Chris Wilson wrote: > Quoting Kees Cook (2017-10-25 15:05:13) >> On Wed, Oct 25, 2017 at 3:11 PM, Chris Wilson >> wrote: >> > Quoting Chris Wilson (2017-10-25 11:24:19) >> >> Quoting Chris Wilson (2017-10-24

Re: [PATCH] drm/i915/selftests: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
On Wed, Oct 25, 2017 at 4:16 PM, Chris Wilson wrote: > Quoting Kees Cook (2017-10-25 15:05:13) >> On Wed, Oct 25, 2017 at 3:11 PM, Chris Wilson >> wrote: >> > Quoting Chris Wilson (2017-10-25 11:24:19) >> >> Quoting Chris Wilson (2017-10-24 17:17:09) >> >> > Quoting Kees Cook (2017-10-24

Re: [PATCH 1/1] l2tp: cleanup l2tp_tunnel_delete calls

2017-10-25 Thread Guillaume Nault
On Wed, Oct 25, 2017 at 03:57:55PM +0200, Jiri Slaby wrote: > l2tp_tunnel_delete does not return anything since commit 62b982eeb458 > ("l2tp: fix race condition in l2tp_tunnel_delete"). But call sites of > l2tp_tunnel_delete still do casts to void to avoid unused return value > warnings. > >

Re: [PATCH 1/1] l2tp: cleanup l2tp_tunnel_delete calls

2017-10-25 Thread Guillaume Nault
On Wed, Oct 25, 2017 at 03:57:55PM +0200, Jiri Slaby wrote: > l2tp_tunnel_delete does not return anything since commit 62b982eeb458 > ("l2tp: fix race condition in l2tp_tunnel_delete"). But call sites of > l2tp_tunnel_delete still do casts to void to avoid unused return value > warnings. > >

Re: [PATCH v4 19/27] x86: assembly, make some functions local

2017-10-25 Thread Jiri Slaby
Hi, On 10/06/2017, 03:21 PM, Mark Rutland wrote: > If the aim of this series is to introduce something that architectures > use consistently, then can we please actually poke other architectures > about it? e.g. send this to linux-arch, with a cover letter explaining > the idea and asking

Re: [PATCH v4 19/27] x86: assembly, make some functions local

2017-10-25 Thread Jiri Slaby
Hi, On 10/06/2017, 03:21 PM, Mark Rutland wrote: > If the aim of this series is to introduce something that architectures > use consistently, then can we please actually poke other architectures > about it? e.g. send this to linux-arch, with a cover letter explaining > the idea and asking

Re: [PATCH v4 01/27] linkage: new macros for assembler symbols

2017-10-25 Thread Jiri Slaby
On 10/06/2017, 05:23 PM, Josh Poimboeuf wrote: > On Mon, Oct 02, 2017 at 11:12:20AM +0200, Jiri Slaby wrote: >>SYM_CODE_INNER_LABEL -- only for labels in the middle of code >>SYM_CODE_INNER_LABEL_NOALIGN -- only for labels in the middle of code > > Why are the inner labels aligned by

Re: [PATCH v4 01/27] linkage: new macros for assembler symbols

2017-10-25 Thread Jiri Slaby
On 10/06/2017, 05:23 PM, Josh Poimboeuf wrote: > On Mon, Oct 02, 2017 at 11:12:20AM +0200, Jiri Slaby wrote: >>SYM_CODE_INNER_LABEL -- only for labels in the middle of code >>SYM_CODE_INNER_LABEL_NOALIGN -- only for labels in the middle of code > > Why are the inner labels aligned by

Re: [PATCH v2 7/7] fanotify: clean up CONFIG_FANOTIFY_ACCESS_PERMISSIONS ifdefs

2017-10-25 Thread Miklos Szeredi
On Wed, Oct 25, 2017 at 1:44 PM, Amir Goldstein wrote: >> +static inline bool fanotify_is_perm_event(u32 mask) >> +{ >> + return IS_ENABLED(CONFIG_FANOTIFY_ACCESS_PERMISSIONS) && >> + mask & FAN_ALL_PERM_EVENTS; > > I know this is good w.r.t operation

Re: [PATCH v2 7/7] fanotify: clean up CONFIG_FANOTIFY_ACCESS_PERMISSIONS ifdefs

2017-10-25 Thread Miklos Szeredi
On Wed, Oct 25, 2017 at 1:44 PM, Amir Goldstein wrote: >> +static inline bool fanotify_is_perm_event(u32 mask) >> +{ >> + return IS_ENABLED(CONFIG_FANOTIFY_ACCESS_PERMISSIONS) && >> + mask & FAN_ALL_PERM_EVENTS; > > I know this is good w.r.t operation precedence, but it gets

Re: [PATCH v4 19/27] x86: assembly, make some functions local

2017-10-25 Thread Jiri Slaby
On 10/06/2017, 04:01 PM, Ard Biesheuvel wrote: > On 6 October 2017 at 13:53, Jiri Slaby wrote: >> On 10/04/2017, 09:33 AM, Ard Biesheuvel wrote: >>> In arm64, we use ENTRY/ENDPROC for functions with external linkage, >>> and the bare symbol name/ENDPROC for functions with local

Re: [PATCH v4 19/27] x86: assembly, make some functions local

2017-10-25 Thread Jiri Slaby
On 10/06/2017, 04:01 PM, Ard Biesheuvel wrote: > On 6 October 2017 at 13:53, Jiri Slaby wrote: >> On 10/04/2017, 09:33 AM, Ard Biesheuvel wrote: >>> In arm64, we use ENTRY/ENDPROC for functions with external linkage, >>> and the bare symbol name/ENDPROC for functions with local linkage. I >>>

Re: [PATCH] rcu: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
Sorry, I sent this and forgot that timer_setup_on_stack() is only in -next. If this patch is okay, I can carry it in the timers tree. Thanks! -Kees On Tue, Oct 24, 2017 at 11:32 AM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list

Re: [PATCH] rcu: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
Sorry, I sent this and forgot that timer_setup_on_stack() is only in -next. If this patch is okay, I can carry it in the timers tree. Thanks! -Kees On Tue, Oct 24, 2017 at 11:32 AM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer

Re: Fixing CVE-2017-15361

2017-10-25 Thread Matthew Garrett
On Wed, Oct 25, 2017 at 6:44 AM, Jarkko Sakkinen wrote: > I'm implementing a fix for CVE-2017-15361 that simply blacklists > vulnerable FW versions. I think this is the only responsible action from > my side that I can do. I'm not sure this is ideal - do Infineon

Re: Fixing CVE-2017-15361

2017-10-25 Thread Matthew Garrett
On Wed, Oct 25, 2017 at 6:44 AM, Jarkko Sakkinen wrote: > I'm implementing a fix for CVE-2017-15361 that simply blacklists > vulnerable FW versions. I think this is the only responsible action from > my side that I can do. I'm not sure this is ideal - do Infineon have any Linux tooling for

Re: [PATCH] usb: usbatm: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
This also uses timer_setup_on_stack() (only in -next). If it's okay, I'll carry it in the timers tree. Thanks! -Kees On Tue, Oct 24, 2017 at 12:08 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks,

Re: [PATCH] usb: usbatm: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
This also uses timer_setup_on_stack() (only in -next). If it's okay, I'll carry it in the timers tree. Thanks! -Kees On Tue, Oct 24, 2017 at 12:08 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new

Re: [PATCH] usb: usbtest: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
Sorry, I sent this one but forgot that timer_setup_on_stack() is in -next only. If it's okay, I can carry it in the timers tree. Thanks! -Kees On Tue, Oct 24, 2017 at 12:27 PM, Felipe Balbi wrote: > Kees Cook writes: > >> In preparation for

Re: [PATCH] usb: usbtest: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
Sorry, I sent this one but forgot that timer_setup_on_stack() is in -next only. If it's okay, I can carry it in the timers tree. Thanks! -Kees On Tue, Oct 24, 2017 at 12:27 PM, Felipe Balbi wrote: > Kees Cook writes: > >> In preparation for unconditionally passing the struct timer_list

Re: [PATCH] tracing: Allocate mask_str buffer dynamically

2017-10-25 Thread Du, Changbin
On Wed, Oct 25, 2017 at 07:24:36PM +0800, changbin...@intel.com wrote: > From: Changbin Du > > The default NR_CPUS can be very large, but actual possible nr_cpu_ids > usually is very small. For my x86 distribution, the NR_CPUS is 8192 and > nr_cpu_ids is 4. About 2 pages

Re: [PATCH] tracing: Allocate mask_str buffer dynamically

2017-10-25 Thread Du, Changbin
On Wed, Oct 25, 2017 at 07:24:36PM +0800, changbin...@intel.com wrote: > From: Changbin Du > > The default NR_CPUS can be very large, but actual possible nr_cpu_ids > usually is very small. For my x86 distribution, the NR_CPUS is 8192 and > nr_cpu_ids is 4. About 2 pages are wasted. > > Most

Re: [PATCH v2 1/7] fsnotify: clean up fsnotify_prepare/finish_user_wait()

2017-10-25 Thread Miklos Szeredi
On Wed, Oct 25, 2017 at 2:07 PM, Amir Goldstein wrote: >>> -bool fsnotify_prepare_user_wait(struct fsnotify_iter_info *iter_info) >>> +/* >>> + * Get mark reference when we found the mark via lockless traversal of >>> object >>> + * list. Mark can be already removed from the

Re: [PATCH v2 1/7] fsnotify: clean up fsnotify_prepare/finish_user_wait()

2017-10-25 Thread Miklos Szeredi
On Wed, Oct 25, 2017 at 2:07 PM, Amir Goldstein wrote: >>> -bool fsnotify_prepare_user_wait(struct fsnotify_iter_info *iter_info) >>> +/* >>> + * Get mark reference when we found the mark via lockless traversal of >>> object >>> + * list. Mark can be already removed from the list by now and on

[PATCH] mfd: ssbi: Use devm_of_platform_populate()

2017-10-25 Thread Benjamin Gaignard
Use devm_of_platform_populate() instead of of_platform_populate() to be sure that of_platform_depopulate() is called when removing the driver. Signed-off-by: Benjamin Gaignard --- drivers/mfd/ssbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] mfd: ssbi: Use devm_of_platform_populate()

2017-10-25 Thread Benjamin Gaignard
Use devm_of_platform_populate() instead of of_platform_populate() to be sure that of_platform_depopulate() is called when removing the driver. Signed-off-by: Benjamin Gaignard --- drivers/mfd/ssbi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/ssbi.c

Re: [PATCH] media: pvrusb2: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
Eek, sorry, this uses timer_setup_on_stack() which is only in -next. If you can Ack this, I can carry it in the timer tree. Thanks! -Kees On Tue, Oct 24, 2017 at 5:22 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all

Re: [PATCH] media: pvrusb2: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
Eek, sorry, this uses timer_setup_on_stack() which is only in -next. If you can Ack this, I can carry it in the timer tree. Thanks! -Kees On Tue, Oct 24, 2017 at 5:22 PM, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks,

Re: [PATCH] fs, mm: account filp and names caches to kmemcg

2017-10-25 Thread Michal Hocko
On Wed 25-10-17 09:11:51, Johannes Weiner wrote: > On Wed, Oct 25, 2017 at 09:15:22AM +0200, Michal Hocko wrote: [...] > > ... we shouldn't make it more loose though. > > Then we can end this discussion right now. I pointed out right from > the start that the only way to replace -ENOMEM with OOM

Re: [PATCH] fs, mm: account filp and names caches to kmemcg

2017-10-25 Thread Michal Hocko
On Wed 25-10-17 09:11:51, Johannes Weiner wrote: > On Wed, Oct 25, 2017 at 09:15:22AM +0200, Michal Hocko wrote: [...] > > ... we shouldn't make it more loose though. > > Then we can end this discussion right now. I pointed out right from > the start that the only way to replace -ENOMEM with OOM

Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
On Wed, Oct 25, 2017 at 2:41 PM, Jason A. Donenfeld wrote: > On Wed, Oct 25, 2017 at 12:01 PM, Kees Cook wrote: >> sess->time2retain_timer.expires = >> (get_jiffies_64() + sess->sess_ops->DefaultTime2Retain * HZ); >>

Re: [PATCH] iscsi-target: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
On Wed, Oct 25, 2017 at 2:41 PM, Jason A. Donenfeld wrote: > On Wed, Oct 25, 2017 at 12:01 PM, Kees Cook wrote: >> sess->time2retain_timer.expires = >> (get_jiffies_64() + sess->sess_ops->DefaultTime2Retain * HZ); >> add_timer(>time2retain_timer); >>

Re: [PATCH] Bluetooth: btusb: Add new NFA344A entry.

2017-10-25 Thread Marcel Holtmann
Hi Bartosz, > This change allows proper low power mode entry in suspend. please include /sys/kernel/debug/usb/devices entries for this hardware. > > Signed-off-by: Bartosz Chronowski > --- > drivers/bluetooth/btusb.c | 1 + > 1 file changed, 1 insertion(+) >

Re: [PATCH] Bluetooth: btusb: Add new NFA344A entry.

2017-10-25 Thread Marcel Holtmann
Hi Bartosz, > This change allows proper low power mode entry in suspend. please include /sys/kernel/debug/usb/devices entries for this hardware. > > Signed-off-by: Bartosz Chronowski > --- > drivers/bluetooth/btusb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-10-25 Thread Yunlong Song
Hi, Chao, Please see my comments below. On 2017/10/25 20:26, Chao Yu wrote: On 2017/10/25 18:02, Yunlong Song wrote: ping... I've replied in this thread, check your email list please, or you can check the comments in below link: https://patchwork.kernel.org/patch/9909407/ Anyway, see

Re: [PATCH v3] f2fs: add cur_reserved_blocks to support soft block reservation

2017-10-25 Thread Yunlong Song
Hi, Chao, Please see my comments below. On 2017/10/25 20:26, Chao Yu wrote: On 2017/10/25 18:02, Yunlong Song wrote: ping... I've replied in this thread, check your email list please, or you can check the comments in below link: https://patchwork.kernel.org/patch/9909407/ Anyway, see

Re: [PATCHv2 9/9] perf tools: Unwind properly location after REJECT

2017-10-25 Thread Jiri Olsa
On Tue, Oct 24, 2017 at 02:51:21PM +0200, Jiri Olsa wrote: > On Fri, Oct 13, 2017 at 04:50:36PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 13, 2017 at 10:37:36AM +0200, Jiri Olsa escreveu: > > > We have defined YY_USER_ACTION to keep trace of the column > > > location during events

Re: [PATCHv2 9/9] perf tools: Unwind properly location after REJECT

2017-10-25 Thread Jiri Olsa
On Tue, Oct 24, 2017 at 02:51:21PM +0200, Jiri Olsa wrote: > On Fri, Oct 13, 2017 at 04:50:36PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 13, 2017 at 10:37:36AM +0200, Jiri Olsa escreveu: > > > We have defined YY_USER_ACTION to keep trace of the column > > > location during events

[PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

2017-10-25 Thread Jose Abreu
This adds the documentation for TSN feature EST and FP. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Rob Herring

[PATCH net-next 2/2] bindings: net: stmmac: Add documentation for TSN parameters

2017-10-25 Thread Jose Abreu
This adds the documentation for TSN feature EST and FP. Signed-off-by: Jose Abreu Cc: David S. Miller Cc: Joao Pinto Cc: Giuseppe Cavallaro Cc: Alexandre Torgue Cc: Rob Herring --- Documentation/devicetree/bindings/net/stmmac.txt | 20 1 file changed, 20 insertions(+)

[PATCH] Bluetooth: btusb: Add new NFA344A entry.

2017-10-25 Thread Bartosz Chronowski
This change allows proper low power mode entry in suspend. Signed-off-by: Bartosz Chronowski --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 7a5c06a..513a7a5 100644

[PATCH] Bluetooth: btusb: Add new NFA344A entry.

2017-10-25 Thread Bartosz Chronowski
This change allows proper low power mode entry in suspend. Signed-off-by: Bartosz Chronowski --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 7a5c06a..513a7a5 100644 --- a/drivers/bluetooth/btusb.c +++

Re: [PATCH] drm/i915/selftests: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
On Wed, Oct 25, 2017 at 3:11 PM, Chris Wilson wrote: > Quoting Chris Wilson (2017-10-25 11:24:19) >> Quoting Chris Wilson (2017-10-24 17:17:09) >> > Quoting Kees Cook (2017-10-24 16:13:44) >> > > In preparation for unconditionally passing the struct timer_list pointer

Re: [PATCH] drm/i915/selftests: Convert timers to use timer_setup()

2017-10-25 Thread Kees Cook
On Wed, Oct 25, 2017 at 3:11 PM, Chris Wilson wrote: > Quoting Chris Wilson (2017-10-25 11:24:19) >> Quoting Chris Wilson (2017-10-24 17:17:09) >> > Quoting Kees Cook (2017-10-24 16:13:44) >> > > In preparation for unconditionally passing the struct timer_list pointer >> > > to >> > > all timer

[PATCH net-next 1/2] net: stmmac: Add support for DWMAC5 with TSN features

2017-10-25 Thread Jose Abreu
This adds support for IP version 5 of DWMAC. The new introduced features are the Enhancements to Scheduled Traffic (EST) as defined by IEEE802.1Qbv-2015 and Frame Preemption (FPE) as defined by IEEE802.1Qbu. In order to not break previous setups all the necessary configuration is only performed

[PATCH net-next 1/2] net: stmmac: Add support for DWMAC5 with TSN features

2017-10-25 Thread Jose Abreu
This adds support for IP version 5 of DWMAC. The new introduced features are the Enhancements to Scheduled Traffic (EST) as defined by IEEE802.1Qbv-2015 and Frame Preemption (FPE) as defined by IEEE802.1Qbu. In order to not break previous setups all the necessary configuration is only performed

<    3   4   5   6   7   8   9   10   11   12   >