Re: [04/11] i2c: mpc: use of_property_read_bool

2017-10-27 Thread Wolfram Sang
On Fri, Aug 05, 2016 at 10:56:44AM +0200, Julia Lawall wrote: > Use of_property_read_bool to check for the existence of a property. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression e1,e2; > statement S2,S1; > @@ > - if

Re: [04/11] i2c: mpc: use of_property_read_bool

2017-10-27 Thread Wolfram Sang
On Fri, Aug 05, 2016 at 10:56:44AM +0200, Julia Lawall wrote: > Use of_property_read_bool to check for the existence of a property. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression e1,e2; > statement S2,S1; > @@ > - if

[PATCH v2] kbuild: fix linker feature test macros when cross compiling with Clang

2017-10-27 Thread Nick Desaulniers
I was not seeing my linker flags getting added when using ld-option when cross compiling with Clang. Upon investigation, this seems to be due to a difference in how GCC vs Clang handle cross compilation. GCC is configured at build time to support one backend, that is implicit when compiling.

[PATCH v2] kbuild: fix linker feature test macros when cross compiling with Clang

2017-10-27 Thread Nick Desaulniers
I was not seeing my linker flags getting added when using ld-option when cross compiling with Clang. Upon investigation, this seems to be due to a difference in how GCC vs Clang handle cross compilation. GCC is configured at build time to support one backend, that is implicit when compiling.

Re: [PATCH 11/18] x86/asm/64: Pass sp0 directly to load_sp0()

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:43AM -0700, Andy Lutomirski wrote: > load_sp0() had an odd signature: > > void load_sp0(struct tss_struct *tss, struct thread_struct *thread); > > Simplify it to: > > void load_sp0(unsigned long sp0); > > Signed-off-by: Andy Lutomirski > --- >

Re: [PATCH 11/18] x86/asm/64: Pass sp0 directly to load_sp0()

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:43AM -0700, Andy Lutomirski wrote: > load_sp0() had an odd signature: > > void load_sp0(struct tss_struct *tss, struct thread_struct *thread); > > Simplify it to: > > void load_sp0(unsigned long sp0); > > Signed-off-by: Andy Lutomirski > --- >

[PATCH v7 10/10] lib/dlock-list: Fix use-after-unlock problem in dlist_for_each_entry_safe()

2017-10-27 Thread Waiman Long
The dlist_for_each_entry_safe() macro in include/linux/dlock-list has a use-after-unlock problem where racing condition can happen because of a lack of spinlock protection. Fortunately, this macro is not currently being used in the kernel. This patch changes the dlist_for_each_entry_safe() macro

Re: [PATCH 10/18] x86/asm/32: Pull MSR_IA32_SYSENTER_CS update code out of native_load_sp0()

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:42AM -0700, Andy Lutomirski wrote: > This causees the MSR_IA32_SYSENTER_CS write to move out of the Spellcheck pls. > paravirt hook. This shouldn't affect Xen PV: Xen already ignores > MSR_IA32_SYSENTER_ESP writes. In any event, Xen doesn't support > vm86() in a

Re: [PATCH 10/18] x86/asm/32: Pull MSR_IA32_SYSENTER_CS update code out of native_load_sp0()

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:42AM -0700, Andy Lutomirski wrote: > This causees the MSR_IA32_SYSENTER_CS write to move out of the Spellcheck pls. > paravirt hook. This shouldn't affect Xen PV: Xen already ignores > MSR_IA32_SYSENTER_ESP writes. In any event, Xen doesn't support > vm86() in a

[PATCH v7 10/10] lib/dlock-list: Fix use-after-unlock problem in dlist_for_each_entry_safe()

2017-10-27 Thread Waiman Long
The dlist_for_each_entry_safe() macro in include/linux/dlock-list has a use-after-unlock problem where racing condition can happen because of a lack of spinlock protection. Fortunately, this macro is not currently being used in the kernel. This patch changes the dlist_for_each_entry_safe() macro

Re: [PATCH 09/18] x86/asm/64: De-Xen-ify our NMI code

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:41AM -0700, Andy Lutomirski wrote: > Xen PV is fundamentally incompatible with our fancy NMI code: it > doesn't use IST at all, and Xen entries clobber two stack slots > below the hardware frame. > > Drop Xen PV support from our NMI code entirely. > > Cc: Juergen

Re: [PATCH 09/18] x86/asm/64: De-Xen-ify our NMI code

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:41AM -0700, Andy Lutomirski wrote: > Xen PV is fundamentally incompatible with our fancy NMI code: it > doesn't use IST at all, and Xen entries clobber two stack slots > below the hardware frame. > > Drop Xen PV support from our NMI code entirely. > > Cc: Juergen

Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:39AM -0700, Andy Lutomirski wrote: > They did almost the same thing. Remove a bunch of pointless > instructions (mostly hidden in macros) and reduce cognitive load by > merging them. > > Signed-off-by: Andy Lutomirski > --- >

Re: [PATCH 07/18] x86/asm/64: Merge the fast and slow SYSRET paths

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:39AM -0700, Andy Lutomirski wrote: > They did almost the same thing. Remove a bunch of pointless > instructions (mostly hidden in macros) and reduce cognitive load by > merging them. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/entry/entry_64.S | 6 +++--- >

Re: [PATCH 06/18] x86/asm/64: Use pop instead of movq in syscall_return_via_sysret

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:38AM -0700, Andy Lutomirski wrote: > Saves 64 bytes. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/entry/entry_64.S | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/entry/entry_64.S

Re: [PATCH 06/18] x86/asm/64: Use pop instead of movq in syscall_return_via_sysret

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:38AM -0700, Andy Lutomirski wrote: > Saves 64 bytes. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/entry/entry_64.S | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/entry/entry_64.S b/arch/x86/entry/entry_64.S

Re: [PATCH] kbuild: fix linker feature test macros when cross compiling with Clang

2017-10-27 Thread Nick Desaulniers
On Fri, Oct 27, 2017 at 11:28 AM, Nick Desaulniers wrote: > On Fri, Oct 27, 2017 at 4:20 AM, Masahiro Yamada > wrote: >> - please base your patch on linux-kbuild/kbuild branch > > Will do. Do I need to note it's based off that branch?

Re: [PATCH] kbuild: fix linker feature test macros when cross compiling with Clang

2017-10-27 Thread Nick Desaulniers
On Fri, Oct 27, 2017 at 11:28 AM, Nick Desaulniers wrote: > On Fri, Oct 27, 2017 at 4:20 AM, Masahiro Yamada > wrote: >> - please base your patch on linux-kbuild/kbuild branch > > Will do. Do I need to note it's based off that branch? Otherwise wont > 0-day bot complain that my patch doesn't

Re: [PATCH] i2c: imx: Remove a useless test in 'i2c_imx_init_recovery_info()'

2017-10-27 Thread Wolfram Sang
On Tue, Aug 08, 2017 at 10:15:01AM +0200, Uwe Kleine-König wrote: > On Tue, Aug 08, 2017 at 09:40:59AM +0200, Christophe JAILLET wrote: > > Le 07/08/2017 à 08:36, Uwe Kleine-König a écrit : > > > On Mon, Aug 07, 2017 at 01:49:53AM +0200, Christophe JAILLET wrote: > > > > 'devm_pinctrl_get()' never

Re: [PATCH] i2c: imx: Remove a useless test in 'i2c_imx_init_recovery_info()'

2017-10-27 Thread Wolfram Sang
On Tue, Aug 08, 2017 at 10:15:01AM +0200, Uwe Kleine-König wrote: > On Tue, Aug 08, 2017 at 09:40:59AM +0200, Christophe JAILLET wrote: > > Le 07/08/2017 à 08:36, Uwe Kleine-König a écrit : > > > On Mon, Aug 07, 2017 at 01:49:53AM +0200, Christophe JAILLET wrote: > > > > 'devm_pinctrl_get()' never

Re: [PATCH 05/18] x86/asm/64: Shrink paranoid_exit_restore and make labels local

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:37AM -0700, Andy Lutomirski wrote: > paranoid_exit_restore was a copy of > restore_regs_and_return_to_kernel. Merge them and make the > paranoid_exit internal labels local. > > Keeping .Lparanoid_exit makes the code a bit shorter because it > allows a 2-byte jnz

Re: [PATCH 05/18] x86/asm/64: Shrink paranoid_exit_restore and make labels local

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:37AM -0700, Andy Lutomirski wrote: > paranoid_exit_restore was a copy of > restore_regs_and_return_to_kernel. Merge them and make the > paranoid_exit internal labels local. > > Keeping .Lparanoid_exit makes the code a bit shorter because it > allows a 2-byte jnz

Re: [RESEND v12 0/6] cgroup-aware OOM killer

2017-10-27 Thread Johannes Weiner
On Thu, Oct 26, 2017 at 02:03:41PM -0700, David Rientjes wrote: > On Thu, 26 Oct 2017, Johannes Weiner wrote: > > > > The nack is for three reasons: > > > > > > (1) unfair comparison of root mem cgroup usage to bias against that mem > > > cgroup from oom kill in system oom conditions, > >

Re: [RESEND v12 0/6] cgroup-aware OOM killer

2017-10-27 Thread Johannes Weiner
On Thu, Oct 26, 2017 at 02:03:41PM -0700, David Rientjes wrote: > On Thu, 26 Oct 2017, Johannes Weiner wrote: > > > > The nack is for three reasons: > > > > > > (1) unfair comparison of root mem cgroup usage to bias against that mem > > > cgroup from oom kill in system oom conditions, > >

Re: [PATCH 02/18] x86/asm/64: Split the iret-to-user and iret-to-kernel paths

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:34AM -0700, Andy Lutomirski wrote: > These code paths will diverge soon. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/entry/entry_64.S| 32 +++- > arch/x86/entry/entry_64_compat.S | 2 +- >

Re: [PATCH 02/18] x86/asm/64: Split the iret-to-user and iret-to-kernel paths

2017-10-27 Thread Borislav Petkov
On Thu, Oct 26, 2017 at 01:26:34AM -0700, Andy Lutomirski wrote: > These code paths will diverge soon. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/entry/entry_64.S| 32 +++- > arch/x86/entry/entry_64_compat.S | 2 +- > arch/x86/kernel/head_64.S

[PATCH net-next 1/7] net: dsa: get ports within parsing code

2017-10-27 Thread Vivien Didelot
There is no point into hiding the -EINVAL error code in ERR_PTR from a dsa_get_ports function, simply get the "ports" node directly from within the dsa_parse_ports_dn function. This also has the effect to make the pdata and device tree handling code symmetrical inside _dsa_register_switch. At

[PATCH net-next 1/7] net: dsa: get ports within parsing code

2017-10-27 Thread Vivien Didelot
There is no point into hiding the -EINVAL error code in ERR_PTR from a dsa_get_ports function, simply get the "ports" node directly from within the dsa_parse_ports_dn function. This also has the effect to make the pdata and device tree handling code symmetrical inside _dsa_register_switch. At

[PATCH net-next 5/7] net: dsa: get master device at port parsing time

2017-10-27 Thread Vivien Didelot
Fetching the master device can be done directly when a port is parsed from device tree or pdata, instead of waiting until dsa_dst_parse. Now that -EPROBE_DEFER is returned before we add the switch to the tree, there is no need to check for this error after dsa_dst_parse. Signed-off-by: Vivien

[PATCH net-next 5/7] net: dsa: get master device at port parsing time

2017-10-27 Thread Vivien Didelot
Fetching the master device can be done directly when a port is parsed from device tree or pdata, instead of waiting until dsa_dst_parse. Now that -EPROBE_DEFER is returned before we add the switch to the tree, there is no need to check for this error after dsa_dst_parse. Signed-off-by: Vivien

[PATCH net-next 0/7] net: dsa: add port parsing functions

2017-10-27 Thread Vivien Didelot
This patchset adds port parsing functions called early in the new bindings parsing stage, which regroup all the fetching of static data available at the port level, including the port's type, name and CPU master interface. This simplifies the rest of the code which does not need to dig into

[PATCH net-next 7/7] net: dsa: remove name arg from slave create

2017-10-27 Thread Vivien Didelot
Now that slave dsa_port always have their name set, there is no need to pass it to dsa_slave_create() anymore. Remove this argument. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 3 +-- net/dsa/dsa_priv.h | 2 +- net/dsa/legacy.c | 2 +-

[PATCH net-next 0/7] net: dsa: add port parsing functions

2017-10-27 Thread Vivien Didelot
This patchset adds port parsing functions called early in the new bindings parsing stage, which regroup all the fetching of static data available at the port level, including the port's type, name and CPU master interface. This simplifies the rest of the code which does not need to dig into

[PATCH net-next 7/7] net: dsa: remove name arg from slave create

2017-10-27 Thread Vivien Didelot
Now that slave dsa_port always have their name set, there is no need to pass it to dsa_slave_create() anymore. Remove this argument. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 3 +-- net/dsa/dsa_priv.h | 2 +- net/dsa/legacy.c | 2 +- net/dsa/slave.c| 3 ++- 4 files changed, 5

[PATCH net-next 4/7] net: dsa: check master device before put

2017-10-27 Thread Vivien Didelot
In the case of pdata, the dsa_cpu_parse function calls dev_put() before making sure it isn't NULL. Fix this. Fixes: 71e0bbde0d88 ("net: dsa: Add support for platform data") Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli ---

[PATCH net-next 4/7] net: dsa: check master device before put

2017-10-27 Thread Vivien Didelot
In the case of pdata, the dsa_cpu_parse function calls dev_put() before making sure it isn't NULL. Fix this. Fixes: 71e0bbde0d88 ("net: dsa: Add support for platform data") Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli --- net/dsa/dsa2.c | 7 --- 1 file changed, 4

[PATCH net-next 2/7] net: dsa: add port parse functions

2017-10-27 Thread Vivien Didelot
Add symmetrical DSA port parsing functions for pdata and device tree, used to parse and validate a given port node or platform data. They don't do much for the moment but will be extended later on to assign a port type and get device references. Signed-off-by: Vivien Didelot

[PATCH net-next 2/7] net: dsa: add port parse functions

2017-10-27 Thread Vivien Didelot
Add symmetrical DSA port parsing functions for pdata and device tree, used to parse and validate a given port node or platform data. They don't do much for the moment but will be extended later on to assign a port type and get device references. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c

[PATCH net-next 6/7] net: dsa: get port name at parse time

2017-10-27 Thread Vivien Didelot
Get the optional "label" property and assign a default one directly at parse time instead of doing it when creating the slave. For legacy, simply assign the port name stored in cd->port_names. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 10

[PATCH net-next 3/7] net: dsa: get port type at parse time

2017-10-27 Thread Vivien Didelot
Assign a port's type at parsed time instead of waiting for the tree to be completed. Because this is now done earlier, we can use the port's type in dsa_port_is_* helpers instead of digging again in topology description. Signed-off-by: Vivien Didelot ---

[PATCH net-next 6/7] net: dsa: get port name at parse time

2017-10-27 Thread Vivien Didelot
Get the optional "label" property and assign a default one directly at parse time instead of doing it when creating the slave. For legacy, simply assign the port name stored in cd->port_names. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 10 +- net/dsa/legacy.c | 1 + 2 files

[PATCH net-next 3/7] net: dsa: get port type at parse time

2017-10-27 Thread Vivien Didelot
Assign a port's type at parsed time instead of waiting for the tree to be completed. Because this is now done earlier, we can use the port's type in dsa_port_is_* helpers instead of digging again in topology description. Signed-off-by: Vivien Didelot --- net/dsa/dsa2.c | 37

[git pull] drm fixes for v4.14-rc7

2017-10-27 Thread Dave Airlie
Hi Linus, Two amd fixes, one i915 core and a few i915 GVT fixes, things seem fairly quiet. Dave. The following changes since commit bb176f67090ca54869fc1262c913aa69d2ede070: Linux 4.14-rc6 (2017-10-23 06:49:47 -0400) are available in the git repository at:

[git pull] drm fixes for v4.14-rc7

2017-10-27 Thread Dave Airlie
Hi Linus, Two amd fixes, one i915 core and a few i915 GVT fixes, things seem fairly quiet. Dave. The following changes since commit bb176f67090ca54869fc1262c913aa69d2ede070: Linux 4.14-rc6 (2017-10-23 06:49:47 -0400) are available in the git repository at:

Re: [PATCH] fpga: fpga-mgr: remove unnecessary code in __fpga_mgr_get

2017-10-27 Thread Gustavo A. R. Silva
Quoting Alan Tull : On Fri, Oct 27, 2017 at 2:09 PM, Gustavo A. R. Silva wrote: Hi Alan, Quoting Alan Tull : On Thu, Oct 26, 2017 at 6:02 PM, Gustavo A. R. Silva wrote: Hi Gustavo, Thanks for pointing

Re: [PATCH] fpga: fpga-mgr: remove unnecessary code in __fpga_mgr_get

2017-10-27 Thread Gustavo A. R. Silva
Quoting Alan Tull : On Fri, Oct 27, 2017 at 2:09 PM, Gustavo A. R. Silva wrote: Hi Alan, Quoting Alan Tull : On Thu, Oct 26, 2017 at 6:02 PM, Gustavo A. R. Silva wrote: Hi Gustavo, Thanks for pointing that out. There's also a similar thing in fpga-bridge.c that I need to fix. Can

[PATCH 2/2] perf tools: Unwind properly location after REJECT

2017-10-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We have defined YY_USER_ACTION to keep trace of the column location during events parsing, but we need to clean it up when we call REJECT. When REJECT is called, the lexer shrinks the text and re-runs the matching, so we need to address it in resuming the

[PATCH 2/2] perf tools: Unwind properly location after REJECT

2017-10-27 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We have defined YY_USER_ACTION to keep trace of the column location during events parsing, but we need to clean it up when we call REJECT. When REJECT is called, the lexer shrinks the text and re-runs the matching, so we need to address it in resuming the previous location value

[PATCH 1/2] perf symbols: Fix memory corruption because of zero length symbols

2017-10-27 Thread Arnaldo Carvalho de Melo
From: Ravi Bangoria Perf top is often crashing at very random locations on powerpc. After investigating, I found the crash only happens when sample is of zero length symbol. Powerpc kernel has many such symbols which does not contain length details in vmlinux

[GIT PULL 0/2] perf/urgent fixes

2017-10-27 Thread Arnaldo Carvalho de Melo
repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.14-20171027 for you to fetch changes up to 9445464bb8318e42e5232b37fc7218ed028517f6: perf tools: Unwind properly location after REJECT (2017-10-27 11:42:51 -0300

[PATCH 1/2] perf symbols: Fix memory corruption because of zero length symbols

2017-10-27 Thread Arnaldo Carvalho de Melo
From: Ravi Bangoria Perf top is often crashing at very random locations on powerpc. After investigating, I found the crash only happens when sample is of zero length symbol. Powerpc kernel has many such symbols which does not contain length details in vmlinux binary and thus start and end

[GIT PULL 0/2] perf/urgent fixes

2017-10-27 Thread Arnaldo Carvalho de Melo
repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-urgent-for-mingo-4.14-20171027 for you to fetch changes up to 9445464bb8318e42e5232b37fc7218ed028517f6: perf tools: Unwind properly location after REJECT (2017-10-27 11:42:51 -0300

Re: [PATCH] fpga: fpga-mgr: remove unnecessary code in __fpga_mgr_get

2017-10-27 Thread Alan Tull
On Fri, Oct 27, 2017 at 2:09 PM, Gustavo A. R. Silva wrote: > Hi Alan, > > Quoting Alan Tull : > >> On Thu, Oct 26, 2017 at 6:02 PM, Gustavo A. R. Silva >> wrote: >> >> Hi Gustavo, >> >> Thanks for pointing that out. There's

Re: [PATCH] fpga: fpga-mgr: remove unnecessary code in __fpga_mgr_get

2017-10-27 Thread Alan Tull
On Fri, Oct 27, 2017 at 2:09 PM, Gustavo A. R. Silva wrote: > Hi Alan, > > Quoting Alan Tull : > >> On Thu, Oct 26, 2017 at 6:02 PM, Gustavo A. R. Silva >> wrote: >> >> Hi Gustavo, >> >> Thanks for pointing that out. There's also a similar thing in >> fpga-bridge.c that I need to fix. >> > >

Re: [PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-27 Thread Leon Romanovsky
On Thu, Oct 26, 2017 at 08:33:39PM -0400, Dennis Dalessandro wrote: > On 10/26/2017 12:12 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 26 Oct 2017 17:54:15 +0200 > > > > Add a jump target so that a bit of exception handling can be better

Re: [PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-27 Thread Leon Romanovsky
On Thu, Oct 26, 2017 at 08:33:39PM -0400, Dennis Dalessandro wrote: > On 10/26/2017 12:12 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 26 Oct 2017 17:54:15 +0200 > > > > Add a jump target so that a bit of exception handling can be better reused > > at the end of this

Re: [PATCH] init/main.c: check for null pointer before calling initcall

2017-10-27 Thread Thomas Gleixner
On Fri, 27 Oct 2017, Abderrahmane Benbachir wrote: > David Daney a écrit : > > > On 10/27/2017 11:22 AM, Thomas Gleixner wrote: > > > On Fri, 27 Oct 2017, David Daney wrote: > > > > > > > On 10/27/2017 09:47 AM, Abderrahmane Benbachir wrote: > > > > > Simple check to

Re: [PATCH] init/main.c: check for null pointer before calling initcall

2017-10-27 Thread Thomas Gleixner
On Fri, 27 Oct 2017, Abderrahmane Benbachir wrote: > David Daney a écrit : > > > On 10/27/2017 11:22 AM, Thomas Gleixner wrote: > > > On Fri, 27 Oct 2017, David Daney wrote: > > > > > > > On 10/27/2017 09:47 AM, Abderrahmane Benbachir wrote: > > > > > Simple check to prevent kernel panic when

[PATCH] Check all .c files for bad kernel-doc comments

2017-10-27 Thread Matthew Wilcox
From: Matthew Wilcox Implement a '-none' output mode for kernel-doc which will only output warning messages, and suppresses the warning message about there being no kernel-doc in the file. Add it to the rule to build .o files from .c files, so it will check all .c files

[PATCH] Check all .c files for bad kernel-doc comments

2017-10-27 Thread Matthew Wilcox
From: Matthew Wilcox Implement a '-none' output mode for kernel-doc which will only output warning messages, and suppresses the warning message about there being no kernel-doc in the file. Add it to the rule to build .o files from .c files, so it will check all .c files that have been modified.

Re: [PATCH] pinctrl: armada-37xx: Add edge both type gpio irq support

2017-10-27 Thread Andrew Lunn
Hi Gregory > In the end I don't think it is a problem. I think it should be clearly documented somewhere. Hardware which can do both edges in hardware won't have this problem. If i'm using this generic feature, i want an idea if it is mostly going to work, or always going to work. Andrew

Re: [PATCH] pinctrl: armada-37xx: Add edge both type gpio irq support

2017-10-27 Thread Andrew Lunn
Hi Gregory > In the end I don't think it is a problem. I think it should be clearly documented somewhere. Hardware which can do both edges in hardware won't have this problem. If i'm using this generic feature, i want an idea if it is mostly going to work, or always going to work. Andrew

Re: [PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-27 Thread Leon Romanovsky
On Thu, Oct 26, 2017 at 06:12:31PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 26 Oct 2017 17:54:15 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was

Re: [PATCH] IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-27 Thread Leon Romanovsky
On Thu, Oct 26, 2017 at 06:12:31PM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 26 Oct 2017 17:54:15 +0200 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle

[PATCH net-next] hv_netvsc: Set tx_table to equal weight after subchannels open

2017-10-27 Thread Haiyang Zhang
From: Haiyang Zhang In some cases, like internal vSwitch, the host doesn't provide send indirection table updates. This patch sets the table to be equal weight after subchannels are all open. Otherwise, all workload will be on one TX channel. As tested, this patch has

[PATCH net-next] hv_netvsc: Set tx_table to equal weight after subchannels open

2017-10-27 Thread Haiyang Zhang
From: Haiyang Zhang In some cases, like internal vSwitch, the host doesn't provide send indirection table updates. This patch sets the table to be equal weight after subchannels are all open. Otherwise, all workload will be on one TX channel. As tested, this patch has largely increased the

Re: [PATCH net-next 0/9] net: dsa: define port types

2017-10-27 Thread Andrew Lunn
On Fri, Oct 27, 2017 at 02:56:51PM +0200, Egil Hjelmeland wrote: > > The DSA code currently has 3 bitmaps in the dsa_switch structure: > > cpu_port_mask, dsa_port_mask and enabled_port_mask. > > > Hi Vivien > > First I must apologize to everybody for not replying in-thread. Problem > is that I

Re: [PATCH net-next 0/9] net: dsa: define port types

2017-10-27 Thread Andrew Lunn
On Fri, Oct 27, 2017 at 02:56:51PM +0200, Egil Hjelmeland wrote: > > The DSA code currently has 3 bitmaps in the dsa_switch structure: > > cpu_port_mask, dsa_port_mask and enabled_port_mask. > > > Hi Vivien > > First I must apologize to everybody for not replying in-thread. Problem > is that I

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-27 Thread Leon Romanovsky
On Fri, Oct 27, 2017 at 09:34:18AM +0200, SF Markus Elfring wrote: > >> Add a jump target so that a bit of exception handling can be better reused > >> at the end of this function. > > > > I'm not sure this is that big of a win. > > Such a view is appropriate because I proposed just another small

Re: IB/mlx4: Use common error handling code in __mlx4_ib_create_flow()

2017-10-27 Thread Leon Romanovsky
On Fri, Oct 27, 2017 at 09:34:18AM +0200, SF Markus Elfring wrote: > >> Add a jump target so that a bit of exception handling can be better reused > >> at the end of this function. > > > > I'm not sure this is that big of a win. > > Such a view is appropriate because I proposed just another small

[PULL REQUEST] i2c/cht-wc-fusb302-immutable branch for v4.15

2017-10-27 Thread Wolfram Sang
Hi, as discussed before, here is the immutable branch for the i2c-cht-wc driver, so you can safely apply Hans' patch "[PATCH resend v5 3/3] platform/x86: intel_cht_int33fe: Update fusb302 type string, add properties" [1] on top of this. Thanks, Wolfram [1]

[PULL REQUEST] i2c/cht-wc-fusb302-immutable branch for v4.15

2017-10-27 Thread Wolfram Sang
Hi, as discussed before, here is the immutable branch for the i2c-cht-wc driver, so you can safely apply Hans' patch "[PATCH resend v5 3/3] platform/x86: intel_cht_int33fe: Update fusb302 type string, add properties" [1] on top of this. Thanks, Wolfram [1]

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

2017-10-27 Thread Leon Romanovsky
On Fri, Oct 27, 2017 at 02:30:11PM +0200, Thomas Bogendoerfer wrote: > If there is no SFP module plugged into a port of mlx5 cards > 'cat /sys/class/infniband/mlx5_X/ports/1/rate' returns Invalid argument. > This causes tools like 'ibstat' to malfunction. This change adjusts mlx5 > to all other

Re: [PATCH] IB/mlx5: give back valid speed/width even without plugged in SFP module

2017-10-27 Thread Leon Romanovsky
On Fri, Oct 27, 2017 at 02:30:11PM +0200, Thomas Bogendoerfer wrote: > If there is no SFP module plugged into a port of mlx5 cards > 'cat /sys/class/infniband/mlx5_X/ports/1/rate' returns Invalid argument. > This causes tools like 'ibstat' to malfunction. This change adjusts mlx5 > to all other

Re: [PATCH 07/27] kexec_file: Disable at runtime if securelevel has been set

2017-10-27 Thread Mimi Zohar
On Thu, 2017-10-26 at 10:17 -0400, Mimi Zohar wrote: > On Thu, 2017-10-26 at 15:42 +0800, joeyli wrote: > > Hi Mimi, > > > > Thank you for reviewing. > > > > On Mon, Oct 23, 2017 at 11:54:43AM -0400, Mimi Zohar wrote: > > > On Thu, 2017-10-19 at 15:51 +0100, David Howells wrote: > > > > From:

Re: [PATCH 07/27] kexec_file: Disable at runtime if securelevel has been set

2017-10-27 Thread Mimi Zohar
On Thu, 2017-10-26 at 10:17 -0400, Mimi Zohar wrote: > On Thu, 2017-10-26 at 15:42 +0800, joeyli wrote: > > Hi Mimi, > > > > Thank you for reviewing. > > > > On Mon, Oct 23, 2017 at 11:54:43AM -0400, Mimi Zohar wrote: > > > On Thu, 2017-10-19 at 15:51 +0100, David Howells wrote: > > > > From:

[PATCH] mmc: vub300: Use common code in __download_offload_pseudocode()

2017-10-27 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 27 Oct 2017 21:21:40 +0200 Add a jump target so that a specific string copy operation is stored only once at the end of this function implementation. Replace two calls of the function "strncpy" by goto statements. This issue was

[PATCH] mmc: vub300: Use common code in __download_offload_pseudocode()

2017-10-27 Thread SF Markus Elfring
From: Markus Elfring Date: Fri, 27 Oct 2017 21:21:40 +0200 Add a jump target so that a specific string copy operation is stored only once at the end of this function implementation. Replace two calls of the function "strncpy" by goto statements. This issue was detected by using the Coccinelle

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-27 Thread Craig Bergstrom
Sounds good. Thanks for the context. I'll keep this on my plate and I'll turn something around once I've had a chance to test a bit, probably next week. On Fri, Oct 27, 2017 at 1:24 PM, Ingo Molnar wrote: > > * Craig Bergstrom wrote: > >> Reverting seems

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-27 Thread Craig Bergstrom
Sounds good. Thanks for the context. I'll keep this on my plate and I'll turn something around once I've had a chance to test a bit, probably next week. On Fri, Oct 27, 2017 at 1:24 PM, Ingo Molnar wrote: > > * Craig Bergstrom wrote: > >> Reverting seems like the right approach at the moment.

Re: [PULL REQUEST] i2c-mux for 4.15-rc1

2017-10-27 Thread Wolfram Sang
Hi Peda, > This cycle has been real quiet for me. There's only the one trivial patch > that somewhat simplifies DT parsing in the i2c-mux-reg driver. Did this maybe slip through the cracks? http://patchwork.ozlabs.org/patch/816846/ ("[trivial] dt-bindings: i2c: i2c-mux: Spelling s/required

Re: [PULL REQUEST] i2c-mux for 4.15-rc1

2017-10-27 Thread Wolfram Sang
Hi Peda, > This cycle has been real quiet for me. There's only the one trivial patch > that somewhat simplifies DT parsing in the i2c-mux-reg driver. Did this maybe slip through the cracks? http://patchwork.ozlabs.org/patch/816846/ ("[trivial] dt-bindings: i2c: i2c-mux: Spelling s/required

[GIT PULL] x86 fixes

2017-10-27 Thread Ingo Molnar
Linus, Please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus # HEAD: 90edaac62729d3b9cbb97756261a0049a7fdd6a0 Revert "x86/mm: Limit mmap() of /dev/mem to valid physical addresses" Misc fixes: - revert

[GIT PULL] x86 fixes

2017-10-27 Thread Ingo Molnar
Linus, Please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus # HEAD: 90edaac62729d3b9cbb97756261a0049a7fdd6a0 Revert "x86/mm: Limit mmap() of /dev/mem to valid physical addresses" Misc fixes: - revert

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-27 Thread Ingo Molnar
* Craig Bergstrom wrote: > Reverting seems like the right approach at the moment. My apologies > for the breakage so late the in the cycle. Note that there's no need for you to apologize and you carry exactly zero amount of blame for the late-cycle breakage: it was my

Re: ce56a86e2a ("x86/mm: Limit mmap() of /dev/mem to valid physical addresses"): kernel BUG at arch/x86/mm/physaddr.c:79!

2017-10-27 Thread Ingo Molnar
* Craig Bergstrom wrote: > Reverting seems like the right approach at the moment. My apologies > for the breakage so late the in the cycle. Note that there's no need for you to apologize and you carry exactly zero amount of blame for the late-cycle breakage: it was my decision to send it to

[GIT PULL] scheduler fix

2017-10-27 Thread Ingo Molnar
Linus, Please pull the latest sched-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-urgent-for-linus # HEAD: 88796e7e5c457cae72833196cb98e6895dd107e2 sched/swait: Document it clearly that the swait facilities are special and shouldn't be

[GIT PULL] scheduler fix

2017-10-27 Thread Ingo Molnar
Linus, Please pull the latest sched-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-urgent-for-linus # HEAD: 88796e7e5c457cae72833196cb98e6895dd107e2 sched/swait: Document it clearly that the swait facilities are special and shouldn't be

Re: [PATCH] PM / QoS: Fix device resume latency PM QoS

2017-10-27 Thread Rafael J. Wysocki
On Fri, Oct 27, 2017 at 8:52 PM, Andy Shevchenko wrote: > On Thu, Oct 26, 2017 at 11:38 AM, Rafael J. Wysocki wrote: >> On Wed, Oct 25, 2017 at 10:06 PM, Andy Shevchenko >> wrote: >>> On Tue, Oct 24, 2017 at 11:49 AM,

Re: [PATCH] PM / QoS: Fix device resume latency PM QoS

2017-10-27 Thread Rafael J. Wysocki
On Fri, Oct 27, 2017 at 8:52 PM, Andy Shevchenko wrote: > On Thu, Oct 26, 2017 at 11:38 AM, Rafael J. Wysocki wrote: >> On Wed, Oct 25, 2017 at 10:06 PM, Andy Shevchenko >> wrote: >>> On Tue, Oct 24, 2017 at 11:49 AM, Rafael J. Wysocki >>> wrote: On Tuesday, October 24, 2017 7:54:09 AM

Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

2017-10-27 Thread Michael Lyle
On Fri, Oct 27, 2017 at 12:05 PM, Eric Wheeler wrote: > Should this Cc: stable to avoid the register race (possible > crash?) described by Liang in other stable kernels? > > Reviewed-by: Eric Wheeler This seems like an unlikely failure;

Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

2017-10-27 Thread Michael Lyle
On Fri, Oct 27, 2017 at 12:05 PM, Eric Wheeler wrote: > Should this Cc: stable to avoid the register race (possible > crash?) described by Liang in other stable kernels? > > Reviewed-by: Eric Wheeler This seems like an unlikely failure; basically you must have built bcache for debug (which not

[GIT PULL] perf fix

2017-10-27 Thread Ingo Molnar
Linus, Please pull the latest perf-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-urgent-for-linus # HEAD: 2eece390bf68ec8f733d7e4a3ba8a5ea350082ae perf/x86/intel/bts: Fix exclusive event reference leak A fix for a misplaced permission

[GIT PULL] perf fix

2017-10-27 Thread Ingo Molnar
Linus, Please pull the latest perf-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git perf-urgent-for-linus # HEAD: 2eece390bf68ec8f733d7e4a3ba8a5ea350082ae perf/x86/intel/bts: Fix exclusive event reference leak A fix for a misplaced permission

[GIT PULL] EFI fixes

2017-10-27 Thread Ingo Molnar
Linus, Please pull the latest efi-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git efi-urgent-for-linus # HEAD: 38fb6652229c2149e8694d57db442878fdf8a1bd efi/libstub/arm: Don't randomize runtime regions when CONFIG_HIBERNATION=y Two fixes: an ARM

[GIT PULL] EFI fixes

2017-10-27 Thread Ingo Molnar
Linus, Please pull the latest efi-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git efi-urgent-for-linus # HEAD: 38fb6652229c2149e8694d57db442878fdf8a1bd efi/libstub/arm: Don't randomize runtime regions when CONFIG_HIBERNATION=y Two fixes: an ARM

Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

2017-10-27 Thread Eric Wheeler
On Tue, 10 Oct 2017, Michael Lyle wrote: > On 10/10/2017 05:25 AM, Coly Li wrote: > > On 2017/10/10 下午5:00, Liang Chen wrote: > >> mutex_destroy does nothing most of time, but it's better to call > >> it to make the code future proof and it also has some meaning > >> for like mutex debug. > >> >

Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

2017-10-27 Thread Eric Wheeler
On Tue, 10 Oct 2017, Michael Lyle wrote: > On 10/10/2017 05:25 AM, Coly Li wrote: > > On 2017/10/10 下午5:00, Liang Chen wrote: > >> mutex_destroy does nothing most of time, but it's better to call > >> it to make the code future proof and it also has some meaning > >> for like mutex debug. > >> >

Re: [PATCH] fpga: fpga-mgr: remove unnecessary code in __fpga_mgr_get

2017-10-27 Thread Gustavo A. R. Silva
Hi Alan, Quoting Alan Tull : On Thu, Oct 26, 2017 at 6:02 PM, Gustavo A. R. Silva wrote: Hi Gustavo, Thanks for pointing that out. There's also a similar thing in fpga-bridge.c that I need to fix. Can you share with me what exactly are you

Re: [PATCH] fpga: fpga-mgr: remove unnecessary code in __fpga_mgr_get

2017-10-27 Thread Gustavo A. R. Silva
Hi Alan, Quoting Alan Tull : On Thu, Oct 26, 2017 at 6:02 PM, Gustavo A. R. Silva wrote: Hi Gustavo, Thanks for pointing that out. There's also a similar thing in fpga-bridge.c that I need to fix. Can you share with me what exactly are you trying to fix? If the issue is similar I might

<    1   2   3   4   5   6   7   8   9   10   >