[RFC v8 3/7] platform/x86: intel_pmc_ipc: Use regmap calls for GCR updates

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan This patch adds support for regmap based implementation for GCR read/write/update APIs. Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/platform/x86/Kconfig

[RFC v8 3/7] platform/x86: intel_pmc_ipc: Use regmap calls for GCR updates

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan This patch adds support for regmap based implementation for GCR read/write/update APIs. Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/platform/x86/Kconfig | 1 + drivers/platform/x86/intel_pmc_ipc.c | 122 +--

[RFC v8 0/7] SCU/PMC/PUNIT Inter-Processor Communication(IPC) driver cleanup

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Hi All, Currently intel_pmc_ipc.c, intel_punit_ipc.c, intel_scu_ipc.c drivers implements the same IPC features. This code duplication could be avoided if we implement the IPC driver as a generic library and let

[RFC v8 0/7] SCU/PMC/PUNIT Inter-Processor Communication(IPC) driver cleanup

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Hi All, Currently intel_pmc_ipc.c, intel_punit_ipc.c, intel_scu_ipc.c drivers implements the same IPC features. This code duplication could be avoided if we implement the IPC driver as a generic library and let custom device drivers use API provided by

Re: [PATCH net-next] tools: bpftool: add bash completion for bpftool

2017-10-29 Thread David Miller
From: Jakub Kicinski Date: Thu, 26 Oct 2017 14:16:05 -0700 > From: Quentin Monnet > > Add a completion file for bash. The completion function runs bpftool > when needed, making it smart enough to help users complete ids or tags > for

Re: [PATCH net-next] tools: bpftool: add bash completion for bpftool

2017-10-29 Thread David Miller
From: Jakub Kicinski Date: Thu, 26 Oct 2017 14:16:05 -0700 > From: Quentin Monnet > > Add a completion file for bash. The completion function runs bpftool > when needed, making it smart enough to help users complete ids or tags > for eBPF programs and maps currently on the system. > > Update

Re: Can we break RDPID/RDTSCP ABI ASAP and see if it's okay?

2017-10-29 Thread Thomas Gleixner
On Sat, 28 Oct 2017, Andy Lutomirski wrote: > We currently do this on boot: > > write_rdtscp_aux((node << 12) | cpu); > > This *sucks*. It means that, to very quickly obtain the CPU number > using RDPID, an ALU op is needed. It also doesn't bloody work on > systems with more than 4096 CPUs. >

Re: Can we break RDPID/RDTSCP ABI ASAP and see if it's okay?

2017-10-29 Thread Thomas Gleixner
On Sat, 28 Oct 2017, Andy Lutomirski wrote: > We currently do this on boot: > > write_rdtscp_aux((node << 12) | cpu); > > This *sucks*. It means that, to very quickly obtain the CPU number > using RDPID, an ALU op is needed. It also doesn't bloody work on > systems with more than 4096 CPUs. >

Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed

2017-10-29 Thread Leon Romanovsky
On Sun, Oct 29, 2017 at 10:20:18AM +0300, Moni Shoua wrote: > On Fri, Oct 27, 2017 at 6:59 PM, Thomas Bogendoerfer > wrote: > > Following crash happens, if crc algorithm couldn't be allocated: > > > > [ 1087.989072] rdma_rxe: loaded > > [ 1097.855397] PCLMULQDQ-NI

Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed

2017-10-29 Thread Leon Romanovsky
On Sun, Oct 29, 2017 at 10:20:18AM +0300, Moni Shoua wrote: > On Fri, Oct 27, 2017 at 6:59 PM, Thomas Bogendoerfer > wrote: > > Following crash happens, if crc algorithm couldn't be allocated: > > > > [ 1087.989072] rdma_rxe: loaded > > [ 1097.855397] PCLMULQDQ-NI instructions are not detected. >

[PATCH v2 2/5] staging: fsl-dpaa2/eth: Split function

2017-10-29 Thread Bogdan Purcareata
From: Ioana Radulescu Since setup_dpni() became a bit too long, move the buffer layout configuration to a separate function. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Purcareata --- v1 -> v2: - no

[PATCH v2 2/5] staging: fsl-dpaa2/eth: Split function

2017-10-29 Thread Bogdan Purcareata
From: Ioana Radulescu Since setup_dpni() became a bit too long, move the buffer layout configuration to a separate function. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Purcareata --- v1 -> v2: - no changes drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 79

[PATCH v2 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment

2017-10-29 Thread Bogdan Purcareata
The WRIOP hardware block v1.0.0 (found on LS2080A board) requires data in RX buffers to be aligned to 256B, but newer revisions (e.g. on LS2088A, LS1088A) only require 64B alignment. Check WRIOP version and decide at runtime which alignment requirement to configure for ingress buffers.

[PATCH v2 5/5] staging: fsl-dpaa2/eth: Extra headroom in RX buffers

2017-10-29 Thread Bogdan Purcareata
The needed headroom that we ask the stack to reserve for us in TX skbs is larger than the headroom available in RX frames, which leads to skb reallocations in forwarding scenarios involving two DPNI interfaces. Configure the hardware to reserve some extra space in the RX frame headroom to avoid

[PATCH v2 1/5] staging: fsl-dpaa2/eth: Label cleanup

2017-10-29 Thread Bogdan Purcareata
From: Ioana Radulescu Clean up goto labels in a couple of functions, by removing/renaming redundant ones. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Purcareata --- v1 -> v2: - no changes

[PATCH v2 4/5] staging: fsl-dpaa2/eth: Change RX buffer alignment

2017-10-29 Thread Bogdan Purcareata
The WRIOP hardware block v1.0.0 (found on LS2080A board) requires data in RX buffers to be aligned to 256B, but newer revisions (e.g. on LS2088A, LS1088A) only require 64B alignment. Check WRIOP version and decide at runtime which alignment requirement to configure for ingress buffers.

[PATCH v2 5/5] staging: fsl-dpaa2/eth: Extra headroom in RX buffers

2017-10-29 Thread Bogdan Purcareata
The needed headroom that we ask the stack to reserve for us in TX skbs is larger than the headroom available in RX frames, which leads to skb reallocations in forwarding scenarios involving two DPNI interfaces. Configure the hardware to reserve some extra space in the RX frame headroom to avoid

[PATCH v2 1/5] staging: fsl-dpaa2/eth: Label cleanup

2017-10-29 Thread Bogdan Purcareata
From: Ioana Radulescu Clean up goto labels in a couple of functions, by removing/renaming redundant ones. Signed-off-by: Ioana Radulescu Signed-off-by: Bogdan Purcareata --- v1 -> v2: - no changes drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 35 +++--- 1 file

[PATCH v2 3/5] staging: fsl-dpaa2/eth: Don't account SWA in tx_data_offset

2017-10-29 Thread Bogdan Purcareata
When configuring the Tx buffer layout, the software annotation size is mentioned, and MC accounts for it when configuring the frame tx_data_offset. No need to handle it in the driver as well. This results in 64B less memory allocated per frame. Signed-off-by: Bogdan Purcareata

[PATCH v2 3/5] staging: fsl-dpaa2/eth: Don't account SWA in tx_data_offset

2017-10-29 Thread Bogdan Purcareata
When configuring the Tx buffer layout, the software annotation size is mentioned, and MC accounts for it when configuring the frame tx_data_offset. No need to handle it in the driver as well. This results in 64B less memory allocated per frame. Signed-off-by: Bogdan Purcareata --- v1 -> v2: -

[PATCH v2 0/5] staging: fsl-dpaa2/eth: Frame buffer work

2017-10-29 Thread Bogdan Purcareata
This patchset does some refactoring in the frame buffer area, in order for it to be in line with firmware (MC) configuration. Patches 1 - 2 do some label cleanup and move the buffer layout setup to a dedicated function. Patch 3 updates tx_data_offset - the offset for Tx frame buffers - to not

[PATCH v2 0/5] staging: fsl-dpaa2/eth: Frame buffer work

2017-10-29 Thread Bogdan Purcareata
This patchset does some refactoring in the frame buffer area, in order for it to be in line with firmware (MC) configuration. Patches 1 - 2 do some label cleanup and move the buffer layout setup to a dedicated function. Patch 3 updates tx_data_offset - the offset for Tx frame buffers - to not

[RFC v7 6/7] platform/x86: intel_pmc_ipc: Use generic Intel IPC device calls

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Removed redundant IPC helper functions and refactored the driver to use generic IPC device driver APIs. Also, cleaned up the driver to minimize the usage of global variable ipcdev by propogating the struct

[RFC v7 6/7] platform/x86: intel_pmc_ipc: Use generic Intel IPC device calls

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Removed redundant IPC helper functions and refactored the driver to use generic IPC device driver APIs. Also, cleaned up the driver to minimize the usage of global variable ipcdev by propogating the struct intel_pmc_ipc_dev pointer or by getting it from device

[RFC v7 3/7] platform/x86: intel_pmc_ipc: Use regmap calls for GCR updates

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan This patch adds support for regmap based implementation for GCR read/write/update APIs. Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/platform/x86/Kconfig

[RFC v7 4/7] platform: x86: Add generic Intel IPC driver

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently intel_scu_ipc.c, intel_pmc_ipc.c and intel_punit_ipc.c redundantly implements the same IPC features and has lot of code duplication between them. This driver addresses this issue by grouping the common IPC

[RFC v7 3/7] platform/x86: intel_pmc_ipc: Use regmap calls for GCR updates

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan This patch adds support for regmap based implementation for GCR read/write/update APIs. Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/platform/x86/Kconfig | 1 + drivers/platform/x86/intel_pmc_ipc.c | 122 +--

[RFC v7 4/7] platform: x86: Add generic Intel IPC driver

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently intel_scu_ipc.c, intel_pmc_ipc.c and intel_punit_ipc.c redundantly implements the same IPC features and has lot of code duplication between them. This driver addresses this issue by grouping the common IPC functionalities under the same driver.

[RFC v7 5/7] platform/x86: intel_punit_ipc: Use generic intel ipc device calls

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Removed redundant IPC helper functions and refactored the driver to use APIs provided by generic IPC driver. This patch also cleans-up PUNIT IPC user drivers(intel_telemetry_pltdrv.c) to use APIs provided by generic IPC

[RFC v7 5/7] platform/x86: intel_punit_ipc: Use generic intel ipc device calls

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Removed redundant IPC helper functions and refactored the driver to use APIs provided by generic IPC driver. This patch also cleans-up PUNIT IPC user drivers(intel_telemetry_pltdrv.c) to use APIs provided by generic IPC driver. Signed-off-by: Kuppuswamy

[RFC v7 7/7] platform/x86: intel_scu_ipc: Use generic Intel IPC device calls

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Removed redundant IPC helper functions and refactored the driver to use generic IPC device driver APIs. This patch also cleans-up SCU IPC user drivers(rtc-mrst.c, intel-mid_wdt.c, intel-mid_wdt.c, intel-mid.c) to use

[RFC v7 7/7] platform/x86: intel_scu_ipc: Use generic Intel IPC device calls

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Removed redundant IPC helper functions and refactored the driver to use generic IPC device driver APIs. This patch also cleans-up SCU IPC user drivers(rtc-mrst.c, intel-mid_wdt.c, intel-mid_wdt.c, intel-mid.c) to use APIs provided by generic IPC driver.

[RFC v7 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to create dependent devices

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently, we have lot of repetitive code in dependent device resource allocation and device creation handling code. This logic can be improved if we use MFD framework for dependent device creation. This patch adds this

[RFC v7 2/7] platform/x86: intel_pmc_ipc: Use MFD framework to create dependent devices

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently, we have lot of repetitive code in dependent device resource allocation and device creation handling code. This logic can be improved if we use MFD framework for dependent device creation. This patch adds this support. Signed-off-by: Kuppuswamy

[RFC v7 1/7] platform/x86: intel_punit_ipc: Fix resource ioremap warning

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan For PUNIT device, ISPDRIVER_IPC and GTDDRIVER_IPC resources are not mandatory. So when PMC IPC driver creates a PUNIT device, if these resources are not available then it creates dummy resource entries for these missing

[RFC v7 1/7] platform/x86: intel_punit_ipc: Fix resource ioremap warning

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan For PUNIT device, ISPDRIVER_IPC and GTDDRIVER_IPC resources are not mandatory. So when PMC IPC driver creates a PUNIT device, if these resources are not available then it creates dummy resource entries for these missing resources. But during PUNIT device probe,

[RFC v7 0/7] SCU/PMC/PUNIT Inter-Processor Communication(IPC) driver cleanup

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Hi All, Currently intel_pmc_ipc.c, intel_punit_ipc.c, intel_scu_ipc.c drivers implements the same IPC features. This code duplication could be avoided if we implement the IPC driver as a generic library and let

[RFC v7 0/7] SCU/PMC/PUNIT Inter-Processor Communication(IPC) driver cleanup

2017-10-29 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Hi All, Currently intel_pmc_ipc.c, intel_punit_ipc.c, intel_scu_ipc.c drivers implements the same IPC features. This code duplication could be avoided if we implement the IPC driver as a generic library and let custom device drivers use API provided by

[watchdog] watchdog: mei_wdt: don't use of variable length array

2017-10-29 Thread Tomas Winkler
Fixes sparse warning: drivers/watchdog/mei_wdt.c:530:18: warning: Variable length array is used Signed-off-by: Tomas Winkler Reviewed-by: Alexander Usyskin --- drivers/watchdog/mei_wdt.c | 7 +++ 1 file changed, 3 insertions(+), 4

[watchdog] watchdog: mei_wdt: don't use of variable length array

2017-10-29 Thread Tomas Winkler
Fixes sparse warning: drivers/watchdog/mei_wdt.c:530:18: warning: Variable length array is used Signed-off-by: Tomas Winkler Reviewed-by: Alexander Usyskin --- drivers/watchdog/mei_wdt.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/watchdog/mei_wdt.c

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-29 Thread Kalderon, Michal
From: Dan Carpenter Sent: Friday, October 27, 2017 2:52 PM >On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: >> > iwarp_info = _hwfn->p_rdma_info->iwarp; >> > @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn, >> > if (rc) >> >

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-29 Thread Kalderon, Michal
From: Dan Carpenter Sent: Friday, October 27, 2017 2:52 PM >On Fri, Oct 27, 2017 at 05:32:42PM +0800, Yunsheng Lin wrote: >> > iwarp_info = _hwfn->p_rdma_info->iwarp; >> > @@ -2696,6 +2696,7 @@ qed_iwarp_ll2_start(struct qed_hwfn *p_hwfn, >> > if (rc) >> > goto err; >> > >> >

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-29 Thread Kalderon, Michal
From: Dan Carpenter Sent: Friday, October 27, 2017 9:40 AM > There are several places where we accidentally return success when > kcalloc() fails. > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > processing mpa fpdus") > Signed-off-by: Dan

Re: [PATCH net-next] qed: Set error code for allocation failures

2017-10-29 Thread Kalderon, Michal
From: Dan Carpenter Sent: Friday, October 27, 2017 9:40 AM > There are several places where we accidentally return success when > kcalloc() fails. > > Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and > processing mpa fpdus") > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed

2017-10-29 Thread Moni Shoua
On Fri, Oct 27, 2017 at 6:59 PM, Thomas Bogendoerfer wrote: > Following crash happens, if crc algorithm couldn't be allocated: > > [ 1087.989072] rdma_rxe: loaded > [ 1097.855397] PCLMULQDQ-NI instructions are not detected. > [ 1097.901220] rdma_rxe: failed to allocate crc

Re: [PATCH 2/2] IB/rxe: don't crash, if allocation of crc algorithm failed

2017-10-29 Thread Moni Shoua
On Fri, Oct 27, 2017 at 6:59 PM, Thomas Bogendoerfer wrote: > Following crash happens, if crc algorithm couldn't be allocated: > > [ 1087.989072] rdma_rxe: loaded > [ 1097.855397] PCLMULQDQ-NI instructions are not detected. > [ 1097.901220] rdma_rxe: failed to allocate crc algorithmi err:-2 > [

[PATCH] tty: ehv_bytechan: fix spelling mistake

2017-10-29 Thread Arvind Yadav
Trivial fix to spelling mistakes "interupt" -> "interrupt". Signed-off-by: Arvind Yadav --- drivers/tty/ehv_bytechan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/ehv_bytechan.c b/drivers/tty/ehv_bytechan.c index

[PATCH] tty: ehv_bytechan: fix spelling mistake

2017-10-29 Thread Arvind Yadav
Trivial fix to spelling mistakes "interupt" -> "interrupt". Signed-off-by: Arvind Yadav --- drivers/tty/ehv_bytechan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/ehv_bytechan.c b/drivers/tty/ehv_bytechan.c index a1c7125..ec0989d 100644 ---

[PATCH] mtd: mtdswap: fix spelling mistake: 'TRESHOLD' -> 'THRESHOLD'

2017-10-29 Thread Arvind Yadav
Trivial fix to spelling mistakes. Signed-off-by: Arvind Yadav --- drivers/mtd/mtdswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c index 7d9080e..f07492c 100644 --- a/drivers/mtd/mtdswap.c +++

[PATCH] mtd: mtdswap: fix spelling mistake: 'TRESHOLD' -> 'THRESHOLD'

2017-10-29 Thread Arvind Yadav
Trivial fix to spelling mistakes. Signed-off-by: Arvind Yadav --- drivers/mtd/mtdswap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c index 7d9080e..f07492c 100644 --- a/drivers/mtd/mtdswap.c +++ b/drivers/mtd/mtdswap.c @@

Re: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-29 Thread Christoph Hellwig
On Fri, Oct 27, 2017 at 11:20:41PM +, Duyck, Alexander H wrote: > I don't see this so much as a security problem per-se. It all depends > on the hardware setup. If I recall correctly, there are devices where > the PF function doesn't really do much other than act as a bit more > heavy-weight

Re: [PATCH] Enable SR-IOV instantiation through /sys file

2017-10-29 Thread Christoph Hellwig
On Fri, Oct 27, 2017 at 11:20:41PM +, Duyck, Alexander H wrote: > I don't see this so much as a security problem per-se. It all depends > on the hardware setup. If I recall correctly, there are devices where > the PF function doesn't really do much other than act as a bit more > heavy-weight

[PATCH] scsi: scsi_transport_iscsi: fix spelling mistake: 'Cound' -> 'Could'

2017-10-29 Thread Arvind Yadav
Trivial fix to spelling mistakes in 'iscsi_get_host_stats'. Signed-off-by: Arvind Yadav --- drivers/scsi/scsi_transport_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c

[PATCH] scsi: scsi_transport_iscsi: fix spelling mistake: 'Cound' -> 'Could'

2017-10-29 Thread Arvind Yadav
Trivial fix to spelling mistakes in 'iscsi_get_host_stats'. Signed-off-by: Arvind Yadav --- drivers/scsi/scsi_transport_iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index 8934f19..590a56c

[PATCH] mfd: pcf50633: fix spelling mistake: 'Falied' -> 'Failed'

2017-10-29 Thread Arvind Yadav
Trivial fix to spelling mistakes in 'pcf50633_client_dev_register'. Signed-off-by: Arvind Yadav --- drivers/mfd/pcf50633-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c index

[PATCH] mfd: pcf50633: fix spelling mistake: 'Falied' -> 'Failed'

2017-10-29 Thread Arvind Yadav
Trivial fix to spelling mistakes in 'pcf50633_client_dev_register'. Signed-off-by: Arvind Yadav --- drivers/mfd/pcf50633-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c index 6155d12..f952dff 100644 ---

<    1   2   3   4   5   6