[PATCH 1/2] perf tools: Fix memory leak in addr2inlines()

2017-10-30 Thread Namhyung Kim
When libbfd is not used, addr2inlines() executes `addr2line -i` and process output line by line. But it resets filename to NULL in the loop so getline() allocates additional memory everytime instead of realloc. Cc: Jin Yao Cc: Milian Wolff

[PATCH 1/2] perf tools: Fix memory leak in addr2inlines()

2017-10-30 Thread Namhyung Kim
When libbfd is not used, addr2inlines() executes `addr2line -i` and process output line by line. But it resets filename to NULL in the loop so getline() allocates additional memory everytime instead of realloc. Cc: Jin Yao Cc: Milian Wolff Signed-off-by: Namhyung Kim ---

[PATCH 2/2] perf tools: Show correct function name for srcline of callchains

2017-10-30 Thread Namhyung Kim
When libbfd is not used, it doesn't show proper function name and reuse the original symbol of the sample. That's because it passes the original sym to inline_list__append(). As `addr2line -f` returns function names as well, use that to create ad inline_sym and pass it to inline_list__append().

[PATCH 2/2] perf tools: Show correct function name for srcline of callchains

2017-10-30 Thread Namhyung Kim
When libbfd is not used, it doesn't show proper function name and reuse the original symbol of the sample. That's because it passes the original sym to inline_list__append(). As `addr2line -f` returns function names as well, use that to create ad inline_sym and pass it to inline_list__append().

Re: [PATCH V8 2/2] printk: hash addresses printed with %p

2017-10-30 Thread Tobin C. Harding
On Mon, Oct 30, 2017 at 08:00:46PM -0400, Steven Rostedt wrote: > On Tue, 31 Oct 2017 09:41:02 +1100 > "Tobin C. Harding" wrote: > > > > Cool. So I think we need > > > > get_random_bytes(_key, sizeof(ptr_key)); > > You'll need to add a comment here to describe what ordering

Re: [PATCH V8 2/2] printk: hash addresses printed with %p

2017-10-30 Thread Tobin C. Harding
On Mon, Oct 30, 2017 at 08:00:46PM -0400, Steven Rostedt wrote: > On Tue, 31 Oct 2017 09:41:02 +1100 > "Tobin C. Harding" wrote: > > > > Cool. So I think we need > > > > get_random_bytes(_key, sizeof(ptr_key)); > > You'll need to add a comment here to describe what ordering the memory >

Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Chao Yu
On 2017/10/31 9:33, Yunlong Song wrote: > ping... > > On 2017/9/1 20:00, Yunlong Song wrote: >> In come corner case, the reserved segments are used to do gc, and there are >> not enough free segments for write checkpoint to finish its job, then the >> gc process will fail to change the prefree

Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Chao Yu
On 2017/10/31 9:33, Yunlong Song wrote: > ping... > > On 2017/9/1 20:00, Yunlong Song wrote: >> In come corner case, the reserved segments are used to do gc, and there are >> not enough free segments for write checkpoint to finish its job, then the >> gc process will fail to change the prefree

Re: [lkp-robot] [printk] 7f7c60e066: BUG:KASAN:slab-out-of-bounds

2017-10-30 Thread Ye Xiaolong
On 10/30, Kees Cook wrote: >On Wed, Oct 25, 2017 at 9:22 AM, kernel test robot > wrote: >> >> FYI, we noticed the following commit (built with gcc-4.9): >> >> commit: 7f7c60e0663645e757e520245606fde9c6e326bb ("printk: hash addresses >> printed with %p") >> url: >>

Re: [lkp-robot] [printk] 7f7c60e066: BUG:KASAN:slab-out-of-bounds

2017-10-30 Thread Ye Xiaolong
On 10/30, Kees Cook wrote: >On Wed, Oct 25, 2017 at 9:22 AM, kernel test robot > wrote: >> >> FYI, we noticed the following commit (built with gcc-4.9): >> >> commit: 7f7c60e0663645e757e520245606fde9c6e326bb ("printk: hash addresses >> printed with %p") >> url: >>

[PATCH] irq_work: Don't reinvent the wheel but use existing llist API

2017-10-30 Thread Frederic Weisbecker
From: Byungchul Park Although llist provides proper APIs, they are not used. Make them used. Signed-off-by: Byungchul Park Cc: Peter Zijlstra Signed-off-by: Frederic Weisbecker --- kernel/irq_work.c |

[PATCH] irq_work: Don't reinvent the wheel but use existing llist API

2017-10-30 Thread Frederic Weisbecker
From: Byungchul Park Although llist provides proper APIs, they are not used. Make them used. Signed-off-by: Byungchul Park Cc: Peter Zijlstra Signed-off-by: Frederic Weisbecker --- kernel/irq_work.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/kernel/irq_work.c

Re: [PATCH 2/2] samples/bpf: add a test for bpf_override_return

2017-10-30 Thread Alexei Starovoitov
On 10/30/17 2:19 PM, Josef Bacik wrote: + +rm -f testfile.img +dd if=/dev/zero of=testfile.img bs=1M seek=1000 count=1 +DEVICE=$(losetup --show -f testfile.img) +mkfs.btrfs -f $DEVICE +mkdir tmpmnt +./tracex7 $DEVICE +if [ $? -eq 0 ] +then + echo "SUCCESS!" +else + echo "FAILED!" +fi

Re: [PATCH 2/2] samples/bpf: add a test for bpf_override_return

2017-10-30 Thread Alexei Starovoitov
On 10/30/17 2:19 PM, Josef Bacik wrote: + +rm -f testfile.img +dd if=/dev/zero of=testfile.img bs=1M seek=1000 count=1 +DEVICE=$(losetup --show -f testfile.img) +mkfs.btrfs -f $DEVICE +mkdir tmpmnt +./tracex7 $DEVICE +if [ $? -eq 0 ] +then + echo "SUCCESS!" +else + echo "FAILED!" +fi

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

2017-10-30 Thread Alexei Starovoitov
On 10/30/17 2:19 PM, Josef Bacik wrote: From: Josef Bacik Error injection is sloppy and very ad-hoc. BPF could fill this niche perfectly with it's kprobe functionality. We could make sure errors are only triggered in specific call chains that we care about with very specific

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

2017-10-30 Thread Alexei Starovoitov
On 10/30/17 2:19 PM, Josef Bacik wrote: From: Josef Bacik Error injection is sloppy and very ad-hoc. BPF could fill this niche perfectly with it's kprobe functionality. We could make sure errors are only triggered in specific call chains that we care about with very specific situations.

Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Yunlong Song
ping... On 2017/9/1 20:00, Yunlong Song wrote: In come corner case, the reserved segments are used to do gc, and there are not enough free segments for write checkpoint to finish its job, then the gc process will fail to change the prefree segments to free segments. Signed-off-by: Yunlong Song

Re: [PATCH v2] f2fs: collect prefree segments to avoild write checkpoint fail

2017-10-30 Thread Yunlong Song
ping... On 2017/9/1 20:00, Yunlong Song wrote: In come corner case, the reserved segments are used to do gc, and there are not enough free segments for write checkpoint to finish its job, then the gc process will fail to change the prefree segments to free segments. Signed-off-by: Yunlong Song

Re: [f2fs-dev] [PATCH v2] f2fs: add bug_on when f2fs_gc even fails to get one victim

2017-10-30 Thread Yunlong Song
I think there may be bugs somewhere, since no victim is selected but it really needs gc. What is the size of the data image? On 2017/10/16 11:25, Chao Yu wrote: On 2017/10/14 20:34, Yunlong Song wrote: Do you mean check out-of-space test? I have tried that but no bugon. Yes, test recent f2fs

Re: [f2fs-dev] [PATCH v2] f2fs: add bug_on when f2fs_gc even fails to get one victim

2017-10-30 Thread Yunlong Song
I think there may be bugs somewhere, since no victim is selected but it really needs gc. What is the size of the data image? On 2017/10/16 11:25, Chao Yu wrote: On 2017/10/14 20:34, Yunlong Song wrote: Do you mean check out-of-space test? I have tried that but no bugon. Yes, test recent f2fs

Re: [PATCH 2/8] irqchip: mips-gic: Use irq_cpu_online to (un)mask all-VP(E) IRQs

2017-10-30 Thread Marc Zyngier
On Mon, Oct 30 2017 at 9:36:16 am GMT, Paul Burton wrote: > Hi Marc, > > On Mon, Oct 30, 2017 at 08:00:08AM +, Marc Zyngier wrote: >> > static int __init gic_of_init(struct device_node *node, >> > struct device_node *parent) >> > @@ -768,6

Re: [PATCH 2/8] irqchip: mips-gic: Use irq_cpu_online to (un)mask all-VP(E) IRQs

2017-10-30 Thread Marc Zyngier
On Mon, Oct 30 2017 at 9:36:16 am GMT, Paul Burton wrote: > Hi Marc, > > On Mon, Oct 30, 2017 at 08:00:08AM +, Marc Zyngier wrote: >> > static int __init gic_of_init(struct device_node *node, >> > struct device_node *parent) >> > @@ -768,6 +806,8 @@ static int

Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Brijesh Singh
On 10/30/17 12:57 PM, Borislav Petkov wrote: > On Mon, Oct 30, 2017 at 12:49:14PM -0500, Brijesh Singh wrote: >> If the buffer is allocated on the stack then there is no guarantee that > static global is not allocated on the stack. Okay, Just tried static global with CONFIG_VMAP_STACK=y and I

Re: [Part2 PATCH v6.1 16/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support

2017-10-30 Thread Brijesh Singh
On 10/30/17 12:57 PM, Borislav Petkov wrote: > On Mon, Oct 30, 2017 at 12:49:14PM -0500, Brijesh Singh wrote: >> If the buffer is allocated on the stack then there is no guarantee that > static global is not allocated on the stack. Okay, Just tried static global with CONFIG_VMAP_STACK=y and I

Re: Kernel crash in free_pipe_info()

2017-10-30 Thread Cong Wang
On Mon, Oct 30, 2017 at 3:14 PM, Linus Torvalds wrote: > On Mon, Oct 30, 2017 at 1:58 PM, Cong Wang wrote: >> >> We got more than a dozen of kernel crashes at free_pipe_info() on our >> 4.1 kernel, they are all very similar to this one

Re: Kernel crash in free_pipe_info()

2017-10-30 Thread Cong Wang
On Mon, Oct 30, 2017 at 3:14 PM, Linus Torvalds wrote: > On Mon, Oct 30, 2017 at 1:58 PM, Cong Wang wrote: >> >> We got more than a dozen of kernel crashes at free_pipe_info() on our >> 4.1 kernel, they are all very similar to this one (with slightly >> different faulty addresses): > > Were it

[PATCH v2] x86/cpufeatures: Enable new SSE/AVX/AVX512 cpu features

2017-10-30 Thread Gayatri Kammela
Add a few new SSE/AVX/AVX512 instruction groups/features for enumeration in /proc/cpuinfo: AVX512_VBMI2, GFNI, VAES, VPCLMULQDQ, AVX512_VNNI, AVX512_BITALG. CPUID.(EAX=7,ECX=0):ECX[bit 6] AVX512_VBMI2 CPUID.(EAX=7,ECX=0):ECX[bit 8] GFNI CPUID.(EAX=7,ECX=0):ECX[bit 9] VAES

[PATCH v2] x86/cpufeatures: Enable new SSE/AVX/AVX512 cpu features

2017-10-30 Thread Gayatri Kammela
Add a few new SSE/AVX/AVX512 instruction groups/features for enumeration in /proc/cpuinfo: AVX512_VBMI2, GFNI, VAES, VPCLMULQDQ, AVX512_VNNI, AVX512_BITALG. CPUID.(EAX=7,ECX=0):ECX[bit 6] AVX512_VBMI2 CPUID.(EAX=7,ECX=0):ECX[bit 8] GFNI CPUID.(EAX=7,ECX=0):ECX[bit 9] VAES

Re: Kernel crash in free_pipe_info()

2017-10-30 Thread Cong Wang
On Mon, Oct 30, 2017 at 3:26 PM, Linus Torvalds wrote: > On Mon, Oct 30, 2017 at 3:14 PM, Linus Torvalds > wrote: >> On Mon, Oct 30, 2017 at 1:58 PM, Cong Wang wrote: >>> >>> We got more than a dozen of

Re: Kernel crash in free_pipe_info()

2017-10-30 Thread Cong Wang
On Mon, Oct 30, 2017 at 3:26 PM, Linus Torvalds wrote: > On Mon, Oct 30, 2017 at 3:14 PM, Linus Torvalds > wrote: >> On Mon, Oct 30, 2017 at 1:58 PM, Cong Wang wrote: >>> >>> We got more than a dozen of kernel crashes at free_pipe_info() on our >>> 4.1 kernel, they are all very similar to this

[PATCH v4 3/3] MAINTAINERS: Add a new entry of the ov7740 driver

2017-10-30 Thread Wenyou Yang
Add a new entry of the ov7740 sensor driver to the MAINTAINERS file. Signed-off-by: Wenyou Yang --- Changes in v4: None Changes in v3: - Put the MAINTAINERS change to a separate patch. Changes in v2: - Split off the bindings into a separate patch. - Add a new

[PATCH v4 3/3] MAINTAINERS: Add a new entry of the ov7740 driver

2017-10-30 Thread Wenyou Yang
Add a new entry of the ov7740 sensor driver to the MAINTAINERS file. Signed-off-by: Wenyou Yang --- Changes in v4: None Changes in v3: - Put the MAINTAINERS change to a separate patch. Changes in v2: - Split off the bindings into a separate patch. - Add a new entry to the MAINTAINERS file.

[PATCH v4 2/3] media: ov7740: Document device tree bindings

2017-10-30 Thread Wenyou Yang
Add the device tree binding documentation for the ov7740 sensor driver. Signed-off-by: Wenyou Yang --- Changes in v4: None Changes in v3: - Explicitly document the "remote-endpoint" property. Changes in v2: None .../devicetree/bindings/media/i2c/ov7740.txt |

[PATCH v4 2/3] media: ov7740: Document device tree bindings

2017-10-30 Thread Wenyou Yang
Add the device tree binding documentation for the ov7740 sensor driver. Signed-off-by: Wenyou Yang --- Changes in v4: None Changes in v3: - Explicitly document the "remote-endpoint" property. Changes in v2: None .../devicetree/bindings/media/i2c/ov7740.txt | 47 ++

[PATCH v4 1/3] media: i2c: Add the ov7740 image sensor driver

2017-10-30 Thread Wenyou Yang
The ov7740 (color) image sensor is a high performance VGA CMOS image snesor, which supports for output formats: RAW RGB and YUV and image sizes: VGA, and QVGA, CIF and any size smaller. Signed-off-by: Songjun Wu Signed-off-by: Wenyou Yang ---

[PATCH v4 1/3] media: i2c: Add the ov7740 image sensor driver

2017-10-30 Thread Wenyou Yang
The ov7740 (color) image sensor is a high performance VGA CMOS image snesor, which supports for output formats: RAW RGB and YUV and image sizes: VGA, and QVGA, CIF and any size smaller. Signed-off-by: Songjun Wu Signed-off-by: Wenyou Yang --- Changes in v4: - Assign 'val' a initial value to

[PATCH v4 0/3] media: ov7740: Add a V4L2 sensor-level driver

2017-10-30 Thread Wenyou Yang
Add a Video4Linux2 sensor-level driver for the OmniVision OV7740 VGA camera image sensor. Changes in v4: - Assign 'val' a initial value to avoid warning: 'val' may be used uninitialized. - Rename REG_REG15 to avoid warning: "REG_REG15" redefined. Changes in v3: - Explicitly document the

[PATCH v4 0/3] media: ov7740: Add a V4L2 sensor-level driver

2017-10-30 Thread Wenyou Yang
Add a Video4Linux2 sensor-level driver for the OmniVision OV7740 VGA camera image sensor. Changes in v4: - Assign 'val' a initial value to avoid warning: 'val' may be used uninitialized. - Rename REG_REG15 to avoid warning: "REG_REG15" redefined. Changes in v3: - Explicitly document the

Re: [PATCH] iio: adc: aspeed: Deassert reset in probe

2017-10-30 Thread Joel Stanley
On Tue, Oct 31, 2017 at 11:02 AM, Joel Stanley wrote: > On Tue, Oct 31, 2017 at 2:51 AM, Philipp Zabel > wrote: >> Hi Joel, >> >> On Mon, Oct 30, 2017 at 8:22 AM, Joel Stanley wrote: >>> The ASPEED SoC must deassert a reset in order to

Re: [PATCH] iio: adc: aspeed: Deassert reset in probe

2017-10-30 Thread Joel Stanley
On Tue, Oct 31, 2017 at 11:02 AM, Joel Stanley wrote: > On Tue, Oct 31, 2017 at 2:51 AM, Philipp Zabel > wrote: >> Hi Joel, >> >> On Mon, Oct 30, 2017 at 8:22 AM, Joel Stanley wrote: >>> The ASPEED SoC must deassert a reset in order to use the ADC peripheral. >>> >>> The device tree bindings

Re: [Xen-devel] [PATCH v5 1/1] xen/time: do not decrease steal time after live migration on xen

2017-10-30 Thread Boris Ostrovsky
On 10/30/2017 08:14 PM, Dongli Zhang wrote: Hi Boris, On 10/30/2017 09:34 PM, Boris Ostrovsky wrote: On 10/30/2017 04:03 AM, Dongli Zhang wrote: After guest live migration on xen, steal time in /proc/stat (cpustat[CPUTIME_STEAL]) might decrease because steal returned by xen_steal_lock()

Re: [Xen-devel] [PATCH v5 1/1] xen/time: do not decrease steal time after live migration on xen

2017-10-30 Thread Boris Ostrovsky
On 10/30/2017 08:14 PM, Dongli Zhang wrote: Hi Boris, On 10/30/2017 09:34 PM, Boris Ostrovsky wrote: On 10/30/2017 04:03 AM, Dongli Zhang wrote: After guest live migration on xen, steal time in /proc/stat (cpustat[CPUTIME_STEAL]) might decrease because steal returned by xen_steal_lock()

Re: consult a question about action_result() in memory_failure()

2017-10-30 Thread Naoya Horiguchi
Hi gengdongjiu, On Tue, Oct 24, 2017 at 08:47:41PM +0800, gengdongjiu wrote: > Hi Naoya, >very sorry to disturb you, I want to consult you about the handing to > error page type in memory_failure(). > If the error page is the current task's page table, will the memory_failure > not handling

Re: consult a question about action_result() in memory_failure()

2017-10-30 Thread Naoya Horiguchi
Hi gengdongjiu, On Tue, Oct 24, 2017 at 08:47:41PM +0800, gengdongjiu wrote: > Hi Naoya, >very sorry to disturb you, I want to consult you about the handing to > error page type in memory_failure(). > If the error page is the current task's page table, will the memory_failure > not handling

Re: linux-next: manual merge of the spi-nor tree with the imx-mxs tree

2017-10-30 Thread Cyrille Pitchen
Hi all, + Marek Mark, thanks for this report. Shawn, Yuan, if I don't make a mistake, patch "dt-bindings: mtd: add sst25wf040b and en25s64 to sip-nor list" was not submitted to the linux-mtd mailing list hence was neither reviewed nor acked by any spi-nor maintainer. If so, such a patch should

Re: linux-next: manual merge of the spi-nor tree with the imx-mxs tree

2017-10-30 Thread Cyrille Pitchen
Hi all, + Marek Mark, thanks for this report. Shawn, Yuan, if I don't make a mistake, patch "dt-bindings: mtd: add sst25wf040b and en25s64 to sip-nor list" was not submitted to the linux-mtd mailing list hence was neither reviewed nor acked by any spi-nor maintainer. If so, such a patch should

Re: [PATCH] MAINTAINERS: update TPM driver infrastructure changes

2017-10-30 Thread Peter Huewe
Hi, Am Freitag, 29. September 2017 22:23:13 CEST schrieb Jarkko Sakkinen: On Fri, Sep 29, 2017 at 08:29:09AM +, peter.hu...@infineon.com wrote: ... Spinics is archiving us at https://www.spinics.net/lists/linux-integrity/ It would be good to add this to the vger page + documented on the

Re: [PATCH] MAINTAINERS: update TPM driver infrastructure changes

2017-10-30 Thread Peter Huewe
Hi, Am Freitag, 29. September 2017 22:23:13 CEST schrieb Jarkko Sakkinen: On Fri, Sep 29, 2017 at 08:29:09AM +, peter.hu...@infineon.com wrote: ... Spinics is archiving us at https://www.spinics.net/lists/linux-integrity/ It would be good to add this to the vger page + documented on the

Re: xfs: list corruption in xfs_setup_inode()

2017-10-30 Thread Dave Chinner
On Mon, Oct 30, 2017 at 02:55:43PM -0700, Cong Wang wrote: > Hello, > > We triggered a list corruption (double add) warning below on our 4.9 > kernel (the 4.9 kernel we use is based on -stable release, with only a > few unrelated networking backports): > > > WARNING: CPU: 5 PID: 628 at

Re: xfs: list corruption in xfs_setup_inode()

2017-10-30 Thread Dave Chinner
On Mon, Oct 30, 2017 at 02:55:43PM -0700, Cong Wang wrote: > Hello, > > We triggered a list corruption (double add) warning below on our 4.9 > kernel (the 4.9 kernel we use is based on -stable release, with only a > few unrelated networking backports): > > > WARNING: CPU: 5 PID: 628 at

Re: [PATCH] iio: adc: aspeed: Deassert reset in probe

2017-10-30 Thread Joel Stanley
On Tue, Oct 31, 2017 at 2:51 AM, Philipp Zabel wrote: > Hi Joel, > > On Mon, Oct 30, 2017 at 8:22 AM, Joel Stanley wrote: >> The ASPEED SoC must deassert a reset in order to use the ADC peripheral. >> >> The device tree bindings are updated to document

Re: [PATCH] iio: adc: aspeed: Deassert reset in probe

2017-10-30 Thread Joel Stanley
On Tue, Oct 31, 2017 at 2:51 AM, Philipp Zabel wrote: > Hi Joel, > > On Mon, Oct 30, 2017 at 8:22 AM, Joel Stanley wrote: >> The ASPEED SoC must deassert a reset in order to use the ADC peripheral. >> >> The device tree bindings are updated to document the resets phandle, and >> the example is

Re: [pmem_attach_disk] WARNING: CPU: 46 PID: 518 at kernel/memremap.c:363 devm_memremap_pages+0x350/0x4b0

2017-10-30 Thread Dan Williams
On Mon, Oct 30, 2017 at 5:00 PM, Fengguang Wu wrote: > Hi Dan, > > On Mon, Oct 30, 2017 at 08:59:46AM -0700, Dan Williams wrote: >> >> On Mon, Oct 30, 2017 at 12:40 AM, Fengguang Wu >> wrote: >>> >>> >>> CC nvdimm maintainers. >>> >>> On Sun, Oct

Re: [pmem_attach_disk] WARNING: CPU: 46 PID: 518 at kernel/memremap.c:363 devm_memremap_pages+0x350/0x4b0

2017-10-30 Thread Dan Williams
On Mon, Oct 30, 2017 at 5:00 PM, Fengguang Wu wrote: > Hi Dan, > > On Mon, Oct 30, 2017 at 08:59:46AM -0700, Dan Williams wrote: >> >> On Mon, Oct 30, 2017 at 12:40 AM, Fengguang Wu >> wrote: >>> >>> >>> CC nvdimm maintainers. >>> >>> On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote:

Re: [Xen-devel] [PATCH v5 1/1] xen/time: do not decrease steal time after live migration on xen

2017-10-30 Thread Dongli Zhang
Hi Boris, On 10/30/2017 09:34 PM, Boris Ostrovsky wrote: > On 10/30/2017 04:03 AM, Dongli Zhang wrote: >> After guest live migration on xen, steal time in /proc/stat >> (cpustat[CPUTIME_STEAL]) might decrease because steal returned by >> xen_steal_lock() might be less than

Re: [Xen-devel] [PATCH v5 1/1] xen/time: do not decrease steal time after live migration on xen

2017-10-30 Thread Dongli Zhang
Hi Boris, On 10/30/2017 09:34 PM, Boris Ostrovsky wrote: > On 10/30/2017 04:03 AM, Dongli Zhang wrote: >> After guest live migration on xen, steal time in /proc/stat >> (cpustat[CPUTIME_STEAL]) might decrease because steal returned by >> xen_steal_lock() might be less than

Re: [lkp-robot] [printk] 7f7c60e066: BUG:KASAN:slab-out-of-bounds

2017-10-30 Thread Kees Cook
On Wed, Oct 25, 2017 at 9:22 AM, kernel test robot wrote: > > FYI, we noticed the following commit (built with gcc-4.9): > > commit: 7f7c60e0663645e757e520245606fde9c6e326bb ("printk: hash addresses > printed with %p") > url: >

Re: [lkp-robot] [printk] 7f7c60e066: BUG:KASAN:slab-out-of-bounds

2017-10-30 Thread Kees Cook
On Wed, Oct 25, 2017 at 9:22 AM, kernel test robot wrote: > > FYI, we noticed the following commit (built with gcc-4.9): > > commit: 7f7c60e0663645e757e520245606fde9c6e326bb ("printk: hash addresses > printed with %p") > url: >

Re: [btrfs] WARNING: CPU: 0 PID: 6379 at fs/direct-io.c:293 dio_complete+0x1d4/0x220

2017-10-30 Thread Fengguang Wu
Hi Eryu, On Mon, Oct 30, 2017 at 03:44:29PM +0800, Eryu Guan wrote: Hi Fengguang, On Mon, Oct 30, 2017 at 08:20:21AM +0100, Fengguang Wu wrote: CC fsdevel. On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: > Hi Linus, > > Up to now we see the below boot error/warnings when

Re: [btrfs] WARNING: CPU: 0 PID: 6379 at fs/direct-io.c:293 dio_complete+0x1d4/0x220

2017-10-30 Thread Fengguang Wu
Hi Eryu, On Mon, Oct 30, 2017 at 03:44:29PM +0800, Eryu Guan wrote: Hi Fengguang, On Mon, Oct 30, 2017 at 08:20:21AM +0100, Fengguang Wu wrote: CC fsdevel. On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: > Hi Linus, > > Up to now we see the below boot error/warnings when

[PATCH] hv: kvp: Avoid reading past allocated blocks from KVP file

2017-10-30 Thread Long Li
From: Paul Meyer While reading in more than one block (50) of KVP records, the allocation goes per block, but the reads used the total number of allocated records (without resetting the pointer/stream). This causes the records buffer to overrun when the refresh reads

[PATCH] hv: kvp: Avoid reading past allocated blocks from KVP file

2017-10-30 Thread Long Li
From: Paul Meyer While reading in more than one block (50) of KVP records, the allocation goes per block, but the reads used the total number of allocated records (without resetting the pointer/stream). This causes the records buffer to overrun when the refresh reads more than one block over the

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 5:01 PM, wrote: > On 30 October 2017 9:37:37 p.m. GMT+00:00, Kees Cook > wrote: >>On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: >>> On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 5:01 PM, wrote: > On 30 October 2017 9:37:37 p.m. GMT+00:00, Kees Cook > wrote: >>On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: >>> On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: On 30/10/17 11:38, Johan Hovold wrote: > On

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Fri, Oct 27, 2017 at 5:57 AM, Bart Van Assche wrote: > On Fri, 2017-10-27 at 02:19 -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to

Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Fri, Oct 27, 2017 at 5:57 AM, Bart Van Assche wrote: > On Fri, 2017-10-27 at 02:19 -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer pointer

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread pure . logic
On 30 October 2017 9:37:37 p.m. GMT+00:00, Kees Cook wrote: >On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: >> On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: >>> >>> >>> On 30/10/17 11:38, Johan Hovold wrote: >>> > On Mon, Oct

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread pure . logic
On 30 October 2017 9:37:37 p.m. GMT+00:00, Kees Cook wrote: >On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: >> On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: >>> >>> >>> On 30/10/17 11:38, Johan Hovold wrote: >>> > On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan

Re: [pmem_attach_disk] WARNING: CPU: 46 PID: 518 at kernel/memremap.c:363 devm_memremap_pages+0x350/0x4b0

2017-10-30 Thread Fengguang Wu
Hi Dan, On Mon, Oct 30, 2017 at 08:59:46AM -0700, Dan Williams wrote: On Mon, Oct 30, 2017 at 12:40 AM, Fengguang Wu wrote: CC nvdimm maintainers. On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: Hi Linus, Up to now we see the below boot

Re: [pmem_attach_disk] WARNING: CPU: 46 PID: 518 at kernel/memremap.c:363 devm_memremap_pages+0x350/0x4b0

2017-10-30 Thread Fengguang Wu
Hi Dan, On Mon, Oct 30, 2017 at 08:59:46AM -0700, Dan Williams wrote: On Mon, Oct 30, 2017 at 12:40 AM, Fengguang Wu wrote: CC nvdimm maintainers. On Sun, Oct 29, 2017 at 11:51:55PM +0100, Fengguang Wu wrote: Hi Linus, Up to now we see the below boot error/warnings when testing

[PATCH] selftests: lib.mk: print individual test results to console by default

2017-10-30 Thread Shuah Khan
Change run_tests to print individual test results to console by default. Introduce "summary" option to print individual test results to a file /tmp/test_name and just print the summary to the console. This change is necessary to support use-cases where test machines get rebooted once tests are

[PATCH] selftests: lib.mk: print individual test results to console by default

2017-10-30 Thread Shuah Khan
Change run_tests to print individual test results to console by default. Introduce "summary" option to print individual test results to a file /tmp/test_name and just print the summary to the console. This change is necessary to support use-cases where test machines get rebooted once tests are

Re: [PATCH V8 2/2] printk: hash addresses printed with %p

2017-10-30 Thread Steven Rostedt
On Tue, 31 Oct 2017 09:41:02 +1100 "Tobin C. Harding" wrote: > Cool. So I think we need > > get_random_bytes(_key, sizeof(ptr_key)); You'll need to add a comment here to describe what ordering the memory barrier is used against. That is, somewhere else there's something

Re: [PATCH V8 2/2] printk: hash addresses printed with %p

2017-10-30 Thread Steven Rostedt
On Tue, 31 Oct 2017 09:41:02 +1100 "Tobin C. Harding" wrote: > Cool. So I think we need > > get_random_bytes(_key, sizeof(ptr_key)); You'll need to add a comment here to describe what ordering the memory barrier is used against. That is, somewhere else there's something that needs to

Re: [kernel-hardening] [PATCH 1/2] kvm: whitelist struct kvm_vcpu_arch

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 4:28 PM, Eric Biggers wrote: > On Thu, Oct 26, 2017 at 03:45:46PM +0200, Paolo Bonzini wrote: >> On x86, ARM and s390, struct kvm_vcpu_arch has a usercopy region >> taht is read and written by the KVM_GET/SET_CPUID2 ioctls (x86) >> or

Re: [kernel-hardening] [PATCH 1/2] kvm: whitelist struct kvm_vcpu_arch

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 4:28 PM, Eric Biggers wrote: > On Thu, Oct 26, 2017 at 03:45:46PM +0200, Paolo Bonzini wrote: >> On x86, ARM and s390, struct kvm_vcpu_arch has a usercopy region >> taht is read and written by the KVM_GET/SET_CPUID2 ioctls (x86) >> or KVM_GET/SET_ONE_REG (ARM/s390).

Re: [PATCH] drm/vc4: Convert timers to use timer_setup()

2017-10-30 Thread Eric Anholt
Kees Cook writes: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Reviewed and applied to drm-misc-next. Thanks!

Re: [PATCH] drm/vc4: Convert timers to use timer_setup()

2017-10-30 Thread Eric Anholt
Kees Cook writes: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. Reviewed and applied to drm-misc-next. Thanks! signature.asc Description: PGP

Re: "PM / QoS: Fix device resume latency PM QoS" breaks sound

2017-10-30 Thread Rafael J. Wysocki
On 10/28/2017 10:10 PM, Chris Clayton wrote: Hi, I pulled the latestchanges from Linus' tree this evening and have found that with the new kernel, sound is not working on my laptop. More precisely, the built-in speakers don't produce any sound. Sound does work when I use ear-plugs in the

Re: "PM / QoS: Fix device resume latency PM QoS" breaks sound

2017-10-30 Thread Rafael J. Wysocki
On 10/28/2017 10:10 PM, Chris Clayton wrote: Hi, I pulled the latestchanges from Linus' tree this evening and have found that with the new kernel, sound is not working on my laptop. More precisely, the built-in speakers don't produce any sound. Sound does work when I use ear-plugs in the

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-30 Thread Namhyung Kim
Hi Arnaldo, On Mon, Oct 30, 2017 at 05:03:47PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 25, 2017 at 10:46:00AM +0900, Namhyung Kim escreveu: > > Hi Milian, > > > > On Tue, Oct 24, 2017 at 10:51:43AM +0200, Milian Wolff wrote: > > > On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung

Re: [PATCH v6 6/6] perf util: use correct IP mapping to find srcline for hist entry

2017-10-30 Thread Namhyung Kim
Hi Arnaldo, On Mon, Oct 30, 2017 at 05:03:47PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Oct 25, 2017 at 10:46:00AM +0900, Namhyung Kim escreveu: > > Hi Milian, > > > > On Tue, Oct 24, 2017 at 10:51:43AM +0200, Milian Wolff wrote: > > > On Freitag, 20. Oktober 2017 07:15:33 CEST Namhyung

Re: [PATCH] net: caif: chnl_net: remove unnecessary null check in chnl_recv_cb

2017-10-30 Thread Gustavo A. R. Silva
Hi, Quoting "Gustavo A. R. Silva" : container_of is never null, so this null check is unnecessary. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/caif/chnl_net.c | 2 -- 1 file changed, 2

Re: [PATCH] net: caif: chnl_net: remove unnecessary null check in chnl_recv_cb

2017-10-30 Thread Gustavo A. R. Silva
Hi, Quoting "Gustavo A. R. Silva" : container_of is never null, so this null check is unnecessary. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/caif/chnl_net.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/caif/chnl_net.c

Re: [PATCH v3 2/5] input: misc: introduce Atmel PTC driver

2017-10-30 Thread Dmitry Torokhov
Hi Ludovic, On Fri, Oct 20, 2017 at 03:31:18PM +0200, Ludovic Desroches wrote: > The Atmel Peripheral Touch Controller subsystem offers built-in hardware > for capacitive touch measurement on sensors that function as buttons, > sliders and wheels. > > Two files are loaded when probing the

Re: [PATCH v3 2/5] input: misc: introduce Atmel PTC driver

2017-10-30 Thread Dmitry Torokhov
Hi Ludovic, On Fri, Oct 20, 2017 at 03:31:18PM +0200, Ludovic Desroches wrote: > The Atmel Peripheral Touch Controller subsystem offers built-in hardware > for capacitive touch measurement on sensors that function as buttons, > sliders and wheels. > > Two files are loaded when probing the

Re: [kernel-hardening] [PATCH 1/2] kvm: whitelist struct kvm_vcpu_arch

2017-10-30 Thread Eric Biggers
On Thu, Oct 26, 2017 at 03:45:46PM +0200, Paolo Bonzini wrote: > On x86, ARM and s390, struct kvm_vcpu_arch has a usercopy region > taht is read and written by the KVM_GET/SET_CPUID2 ioctls (x86) > or KVM_GET/SET_ONE_REG (ARM/s390). Without whitelisting the area, > KVM is completely broken on

Re: [kernel-hardening] [PATCH 1/2] kvm: whitelist struct kvm_vcpu_arch

2017-10-30 Thread Eric Biggers
On Thu, Oct 26, 2017 at 03:45:46PM +0200, Paolo Bonzini wrote: > On x86, ARM and s390, struct kvm_vcpu_arch has a usercopy region > taht is read and written by the KVM_GET/SET_CPUID2 ioctls (x86) > or KVM_GET/SET_ONE_REG (ARM/s390). Without whitelisting the area, > KVM is completely broken on

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-10-30 Thread Rafael J. Wysocki
On Monday, October 30, 2017 11:19:08 AM CET Rafael J. Wysocki wrote: > On Mon, Oct 30, 2017 at 8:10 AM, Tero Kristo wrote: > > The recent change to the PM QoS framework to introduce a proper > > no constraint value overlooked to handle the devices which don't > > implement PM QoS

Re: [PATCH] PM / QoS: Fix default runtime_pm device resume latency

2017-10-30 Thread Rafael J. Wysocki
On Monday, October 30, 2017 11:19:08 AM CET Rafael J. Wysocki wrote: > On Mon, Oct 30, 2017 at 8:10 AM, Tero Kristo wrote: > > The recent change to the PM QoS framework to introduce a proper > > no constraint value overlooked to handle the devices which don't > > implement PM QoS OPS. Runtime PM

[GIT PULL] Urgent power management fix for v4.14

2017-10-30 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-urgent-4.14 with top-most commit 2a9a86d5c81389cd9afe6a4fea42c585733cd705 PM / QoS: Fix default runtime_pm device resume latency on top of commit Linux 4.14-rc7 to receive an urgent

[GIT PULL] Urgent power management fix for v4.14

2017-10-30 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ pm-urgent-4.14 with top-most commit 2a9a86d5c81389cd9afe6a4fea42c585733cd705 PM / QoS: Fix default runtime_pm device resume latency on top of commit Linux 4.14-rc7 to receive an urgent

[PATCH v3 3/8] debugfs: debugfs_real_fops(): drop __must_hold sparse annotation

2017-10-30 Thread Nicolai Stange
Currently, debugfs_real_fops() is annotated with a __must_hold(_srcu) sparse annotation. With the conversion of the SRCU based protection of users against concurrent file removals to a per-file refcount based scheme, this becomes wrong. Drop this annotation. Signed-off-by: Nicolai Stange

[PATCH v3 3/8] debugfs: debugfs_real_fops(): drop __must_hold sparse annotation

2017-10-30 Thread Nicolai Stange
Currently, debugfs_real_fops() is annotated with a __must_hold(_srcu) sparse annotation. With the conversion of the SRCU based protection of users against concurrent file removals to a per-file refcount based scheme, this becomes wrong. Drop this annotation. Signed-off-by: Nicolai Stange ---

[PATCH v3 4/8] debugfs: convert to debugfs_file_get() and -put()

2017-10-30 Thread Nicolai Stange
Convert all calls to the now obsolete debugfs_use_file_start() and debugfs_use_file_finish() from the debugfs core itself to the new debugfs_file_get() and debugfs_file_put() API. Fixes: 49d200deaa68 ("debugfs: prevent access to removed files' private data") Signed-off-by:

[PATCH v3 4/8] debugfs: convert to debugfs_file_get() and -put()

2017-10-30 Thread Nicolai Stange
Convert all calls to the now obsolete debugfs_use_file_start() and debugfs_use_file_finish() from the debugfs core itself to the new debugfs_file_get() and debugfs_file_put() API. Fixes: 49d200deaa68 ("debugfs: prevent access to removed files' private data") Signed-off-by:

[PATCH v3 5/8] IB/hfi1: convert to debugfs_file_get() and -put()

2017-10-30 Thread Nicolai Stange
Convert all calls to the now obsolete debugfs_use_file_start() and debugfs_use_file_finish() to the new debugfs_file_get() and debugfs_file_put() API. Fixes: 49d200deaa68 ("debugfs: prevent access to removed files' private data") Signed-off-by: Nicolai Stange

[PATCH v3 5/8] IB/hfi1: convert to debugfs_file_get() and -put()

2017-10-30 Thread Nicolai Stange
Convert all calls to the now obsolete debugfs_use_file_start() and debugfs_use_file_finish() to the new debugfs_file_get() and debugfs_file_put() API. Fixes: 49d200deaa68 ("debugfs: prevent access to removed files' private data") Signed-off-by: Nicolai Stange ---

[PATCH v3 6/8] debugfs: purge obsolete SRCU based removal protection

2017-10-30 Thread Nicolai Stange
Purge the SRCU based file removal race protection in favour of the new, refcount based debugfs_file_get()/debugfs_file_put() API. Fixes: 49d200deaa68 ("debugfs: prevent access to removed files' private data") Signed-off-by: Nicolai Stange ---

[PATCH v3 6/8] debugfs: purge obsolete SRCU based removal protection

2017-10-30 Thread Nicolai Stange
Purge the SRCU based file removal race protection in favour of the new, refcount based debugfs_file_get()/debugfs_file_put() API. Fixes: 49d200deaa68 ("debugfs: prevent access to removed files' private data") Signed-off-by: Nicolai Stange --- fs/debugfs/file.c | 48

<    1   2   3   4   5   6   7   8   9   10   >