[PATCH v3 1/8] debugfs: add support for more elaborate ->d_fsdata

2017-10-30 Thread Nicolai Stange
Currently, the user provided fops, "real_fops", are stored directly into ->d_fsdata. In order to be able to store more per-file state and thus prepare for more granular file removal protection, wrap the real_fops into a dynamically allocated container struct, debugfs_fsdata. A struct

[PATCH v3 1/8] debugfs: add support for more elaborate ->d_fsdata

2017-10-30 Thread Nicolai Stange
Currently, the user provided fops, "real_fops", are stored directly into ->d_fsdata. In order to be able to store more per-file state and thus prepare for more granular file removal protection, wrap the real_fops into a dynamically allocated container struct, debugfs_fsdata. A struct

[PATCH v3 2/8] debugfs: implement per-file removal protection

2017-10-30 Thread Nicolai Stange
Since commit 49d200deaa68 ("debugfs: prevent access to removed files' private data"), accesses to a file's private data are protected from concurrent removal by covering all file_operations with a SRCU read section and sychronizing with those before returning from debugfs_remove() by means of

[PATCH v3 7/8] debugfs: call debugfs_real_fops() only after debugfs_file_get()

2017-10-30 Thread Nicolai Stange
The current implementation of debugfs_real_fops() relies on a debugfs_fsdata instance to be installed at ->d_fsdata. With future patches introducing lazy allocation of these, this requirement will be guaranteed to be fullfilled only inbetween a debugfs_file_get()/debugfs_file_put() pair. The

[PATCH v3 2/8] debugfs: implement per-file removal protection

2017-10-30 Thread Nicolai Stange
Since commit 49d200deaa68 ("debugfs: prevent access to removed files' private data"), accesses to a file's private data are protected from concurrent removal by covering all file_operations with a SRCU read section and sychronizing with those before returning from debugfs_remove() by means of

[PATCH v3 7/8] debugfs: call debugfs_real_fops() only after debugfs_file_get()

2017-10-30 Thread Nicolai Stange
The current implementation of debugfs_real_fops() relies on a debugfs_fsdata instance to be installed at ->d_fsdata. With future patches introducing lazy allocation of these, this requirement will be guaranteed to be fullfilled only inbetween a debugfs_file_get()/debugfs_file_put() pair. The

[PATCH v3 8/8] debugfs: defer debugfs_fsdata allocation to first usage

2017-10-30 Thread Nicolai Stange
Currently, __debugfs_create_file allocates one struct debugfs_fsdata instance for every file created. However, there are potentially many debugfs file around, most of which are never touched by userspace. Thus, defer the allocations to the first usage, i.e. to the first debugfs_file_get(). A

[PATCH v3 8/8] debugfs: defer debugfs_fsdata allocation to first usage

2017-10-30 Thread Nicolai Stange
Currently, __debugfs_create_file allocates one struct debugfs_fsdata instance for every file created. However, there are potentially many debugfs file around, most of which are never touched by userspace. Thus, defer the allocations to the first usage, i.e. to the first debugfs_file_get(). A

[PATCH v3 0/8] debugfs: per-file removal protection

2017-10-30 Thread Nicolai Stange
Hi, this is v3 of the per-file removal protection with the main change to v2 being that it's sent in non-RFC mode now. For this, I dropped the questionable former [9/9] ("debugfs: free debugfs_fsdata instances") for now. Perhaps I'll resend it later on its own as a RFC again. The problem this

[PATCH v3 0/8] debugfs: per-file removal protection

2017-10-30 Thread Nicolai Stange
Hi, this is v3 of the per-file removal protection with the main change to v2 being that it's sent in non-RFC mode now. For this, I dropped the questionable former [9/9] ("debugfs: free debugfs_fsdata instances") for now. Perhaps I'll resend it later on its own as a RFC again. The problem this

Re: [PATCH v3 1/5] dt-bindings: input: Add Atmel PTC subsystem bindings

2017-10-30 Thread Dmitry Torokhov
Hi Ludovic, On Fri, Oct 20, 2017 at 03:31:17PM +0200, Ludovic Desroches wrote: > Add description of the Atmel PTC subsystem bindings. > > Signed-off-by: Ludovic Desroches > Acked-by: Rob Herring > --- >

Re: [PATCH v3 1/5] dt-bindings: input: Add Atmel PTC subsystem bindings

2017-10-30 Thread Dmitry Torokhov
Hi Ludovic, On Fri, Oct 20, 2017 at 03:31:17PM +0200, Ludovic Desroches wrote: > Add description of the Atmel PTC subsystem bindings. > > Signed-off-by: Ludovic Desroches > Acked-by: Rob Herring > --- > .../devicetree/bindings/input/atmel,ptc.txt| 67 > ++ > 1

Re: [PATCH v8 1/4] firmware: scm: Add new SCM call API for switching memory ownership

2017-10-30 Thread Andy Gross
On Tue, Oct 24, 2017 at 09:22:24PM +0530, Avaneesh Kumar Dwivedi wrote: > Two different processors on a SOC need to switch memory ownership > during load/unload. To enable this, second level memory map table > need to be updated, which is done by secure layer. > This patch adds the interface for

Re: [PATCH v8 1/4] firmware: scm: Add new SCM call API for switching memory ownership

2017-10-30 Thread Andy Gross
On Tue, Oct 24, 2017 at 09:22:24PM +0530, Avaneesh Kumar Dwivedi wrote: > Two different processors on a SOC need to switch memory ownership > during load/unload. To enable this, second level memory map table > need to be updated, which is done by secure layer. > This patch adds the interface for

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-30 Thread Heiko Stuebner
Hi Jeffy, Sean, Am Donnerstag, 19. Oktober 2017, 11:48:02 CET schrieb Jeffy Chen: > > Make edp display works on chromebook kevin(at least for boot animation). > > Also solve some issues i meet during the bringup. > > Changes in v6: > Don't change order of rockchip_drm_psr_register(). > >

Re: [PATCH v6 00/10] rockchip: kevin: Enable edp display

2017-10-30 Thread Heiko Stuebner
Hi Jeffy, Sean, Am Donnerstag, 19. Oktober 2017, 11:48:02 CET schrieb Jeffy Chen: > > Make edp display works on chromebook kevin(at least for boot animation). > > Also solve some issues i meet during the bringup. > > Changes in v6: > Don't change order of rockchip_drm_psr_register(). > >

Re: [PATCHv4 1/1] [tools/selftests]: android/ion: userspace test utility for ion buffer sharing

2017-10-30 Thread Laura Abbott
On 10/23/2017 04:26 PM, Pintu Agarwal wrote: This is a test utility to verify ION buffer sharing in user space between 2 independent processes. It uses unix domain socket (with SCM_RIGHTS) as IPC to transfer an FD to another process to share the same buffer. This utility demonstrates how ION

Re: [PATCHv4 1/1] [tools/selftests]: android/ion: userspace test utility for ion buffer sharing

2017-10-30 Thread Laura Abbott
On 10/23/2017 04:26 PM, Pintu Agarwal wrote: This is a test utility to verify ION buffer sharing in user space between 2 independent processes. It uses unix domain socket (with SCM_RIGHTS) as IPC to transfer an FD to another process to share the same buffer. This utility demonstrates how ION

Re: Linux 4.14-rc6: WARNING: CPU: 9 PID: 5377 at arch/x86/events/intel/core.c:2228 intel_pmu_handle_irq+0x4a8/0x4c0

2017-10-30 Thread Fengguang Wu
On Mon, Oct 30, 2017 at 11:02:58AM +0100, Peter Zijlstra wrote: On Mon, Oct 30, 2017 at 07:27:36AM +0100, Fengguang Wu wrote: [ 189.480568] perf: interrupt took too long (5132 > 4982), lowering kernel.perf_event_max_sample_rate to 38000 [ 189.690660] perf: interrupt took too long (6582 >

Re: Linux 4.14-rc6: WARNING: CPU: 9 PID: 5377 at arch/x86/events/intel/core.c:2228 intel_pmu_handle_irq+0x4a8/0x4c0

2017-10-30 Thread Fengguang Wu
On Mon, Oct 30, 2017 at 11:02:58AM +0100, Peter Zijlstra wrote: On Mon, Oct 30, 2017 at 07:27:36AM +0100, Fengguang Wu wrote: [ 189.480568] perf: interrupt took too long (5132 > 4982), lowering kernel.perf_event_max_sample_rate to 38000 [ 189.690660] perf: interrupt took too long (6582 >

[PATCH] net: caif: chnl_net: remove unnecessary null check in chnl_recv_cb

2017-10-30 Thread Gustavo A. R. Silva
container_of is never null, so this null check is unnecessary. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/caif/chnl_net.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c

[PATCH] net: caif: chnl_net: remove unnecessary null check in chnl_recv_cb

2017-10-30 Thread Gustavo A. R. Silva
container_of is never null, so this null check is unnecessary. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/caif/chnl_net.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/caif/chnl_net.c b/net/caif/chnl_net.c index 922ac1d..489298d

Re: [PATCH V9] printk: hash addresses printed with %p

2017-10-30 Thread Tobin C. Harding
On Mon, Oct 30, 2017 at 03:31:41PM -0700, Kees Cook wrote: > On Sun, Oct 29, 2017 at 3:59 PM, Tobin C. Harding wrote: > > Currently there are many places in the kernel where addresses are being > > printed using an unadorned %p. Kernel pointers should be printed using > > %pK

Re: [PATCH V9] printk: hash addresses printed with %p

2017-10-30 Thread Tobin C. Harding
On Mon, Oct 30, 2017 at 03:31:41PM -0700, Kees Cook wrote: > On Sun, Oct 29, 2017 at 3:59 PM, Tobin C. Harding wrote: > > Currently there are many places in the kernel where addresses are being > > printed using an unadorned %p. Kernel pointers should be printed using > > %pK allowing some

Crashes in perf_event_ctx_lock_nested

2017-10-30 Thread Guenter Roeck
Hi Thomas, we are seeing the following crash in v4.14-rc5/rc7 if CONFIG_HARDLOCKUP_DETECTOR is enabled. [5.908021] NMI watchdog: Enabled. Permanently consumes one hw-PMU counter. [5.915836] == [5.917325] Unsafe

Crashes in perf_event_ctx_lock_nested

2017-10-30 Thread Guenter Roeck
Hi Thomas, we are seeing the following crash in v4.14-rc5/rc7 if CONFIG_HARDLOCKUP_DETECTOR is enabled. [5.908021] NMI watchdog: Enabled. Permanently consumes one hw-PMU counter. [5.915836] == [5.917325] Unsafe

Re: [PATCH V8 2/2] printk: hash addresses printed with %p

2017-10-30 Thread Tobin C. Harding
On Mon, Oct 30, 2017 at 05:33:22PM -0400, Steven Rostedt wrote: > On Thu, 26 Oct 2017 13:58:38 +1100 > "Tobin C. Harding" wrote: > > > > +static bool have_filled_random_ptr_key; > > > +static siphash_key_t ptr_key __read_mostly; > > > + > > > +static void

Re: [PATCH V8 2/2] printk: hash addresses printed with %p

2017-10-30 Thread Tobin C. Harding
On Mon, Oct 30, 2017 at 05:33:22PM -0400, Steven Rostedt wrote: > On Thu, 26 Oct 2017 13:58:38 +1100 > "Tobin C. Harding" wrote: > > > > +static bool have_filled_random_ptr_key; > > > +static siphash_key_t ptr_key __read_mostly; > > > + > > > +static void fill_random_ptr_key(struct

[PATCH v8 05/13] xen/pvcalls: implement connect command

2017-10-30 Thread Stefano Stabellini
Send PVCALLS_CONNECT to the backend. Allocate a new ring and evtchn for the active socket. Introduce fields in struct sock_mapping to keep track of active sockets. Introduce a waitqueue to allow the frontend to wait on data coming from the backend on the active socket (recvmsg command). Two

[PATCH v8 04/13] xen/pvcalls: implement socket command and handle events

2017-10-30 Thread Stefano Stabellini
Send a PVCALLS_SOCKET command to the backend, use the masked req_prod_pvt as req_id. This way, req_id is guaranteed to be between 0 and PVCALLS_NR_REQ_PER_RING. We already have a slot in the rsp array ready for the response, and there cannot be two outstanding responses with the same req_id. Wait

[PATCH v8 05/13] xen/pvcalls: implement connect command

2017-10-30 Thread Stefano Stabellini
Send PVCALLS_CONNECT to the backend. Allocate a new ring and evtchn for the active socket. Introduce fields in struct sock_mapping to keep track of active sockets. Introduce a waitqueue to allow the frontend to wait on data coming from the backend on the active socket (recvmsg command). Two

[PATCH v8 04/13] xen/pvcalls: implement socket command and handle events

2017-10-30 Thread Stefano Stabellini
Send a PVCALLS_SOCKET command to the backend, use the masked req_prod_pvt as req_id. This way, req_id is guaranteed to be between 0 and PVCALLS_NR_REQ_PER_RING. We already have a slot in the rsp array ready for the response, and there cannot be two outstanding responses with the same req_id. Wait

[PATCH v8 06/13] xen/pvcalls: implement bind command

2017-10-30 Thread Stefano Stabellini
Send PVCALLS_BIND to the backend. Introduce a new structure, part of struct sock_mapping, to store information specific to passive sockets. Introduce a status field to keep track of the status of the passive socket. Signed-off-by: Stefano Stabellini Reviewed-by: Boris

[PATCH v8 06/13] xen/pvcalls: implement bind command

2017-10-30 Thread Stefano Stabellini
Send PVCALLS_BIND to the backend. Introduce a new structure, part of struct sock_mapping, to store information specific to passive sockets. Introduce a status field to keep track of the status of the passive socket. Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky CC:

[PATCH v8 02/13] xen/pvcalls: implement frontend disconnect

2017-10-30 Thread Stefano Stabellini
Introduce a data structure named pvcalls_bedata. It contains pointers to the command ring, the event channel, a list of active sockets and a list of passive sockets. Lists accesses are protected by a spin_lock. Introduce a waitqueue to allow waiting for a response on commands sent to the backend.

[PATCH v8 07/13] xen/pvcalls: implement listen command

2017-10-30 Thread Stefano Stabellini
Send PVCALLS_LISTEN to the backend. Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-front.c | 57 +

[PATCH v8 02/13] xen/pvcalls: implement frontend disconnect

2017-10-30 Thread Stefano Stabellini
Introduce a data structure named pvcalls_bedata. It contains pointers to the command ring, the event channel, a list of active sockets and a list of passive sockets. Lists accesses are protected by a spin_lock. Introduce a waitqueue to allow waiting for a response on commands sent to the backend.

[PATCH v8 07/13] xen/pvcalls: implement listen command

2017-10-30 Thread Stefano Stabellini
Send PVCALLS_LISTEN to the backend. Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/pvcalls-front.c | 57 + drivers/xen/pvcalls-front.h | 1 + 2 files changed, 58

[PATCH v8 09/13] xen/pvcalls: implement sendmsg

2017-10-30 Thread Stefano Stabellini
Send data to an active socket by copying data to the "out" ring. Take the active socket out_mutex so that only one function can access the ring at any given time. If not enough room is available on the ring, rather than returning immediately or sleep-waiting, spin for up to 5000 cycles. This

[PATCH v8 09/13] xen/pvcalls: implement sendmsg

2017-10-30 Thread Stefano Stabellini
Send data to an active socket by copying data to the "out" ring. Take the active socket out_mutex so that only one function can access the ring at any given time. If not enough room is available on the ring, rather than returning immediately or sleep-waiting, spin for up to 5000 cycles. This

[PATCH v8 08/13] xen/pvcalls: implement accept command

2017-10-30 Thread Stefano Stabellini
Introduce a waitqueue to allow only one outstanding accept command at any given time and to implement polling on the passive socket. Introduce a flags field to keep track of in-flight accept and poll commands. Send PVCALLS_ACCEPT to the backend. Allocate a new active socket. Make sure that only

[PATCH v8 08/13] xen/pvcalls: implement accept command

2017-10-30 Thread Stefano Stabellini
Introduce a waitqueue to allow only one outstanding accept command at any given time and to implement polling on the passive socket. Introduce a flags field to keep track of in-flight accept and poll commands. Send PVCALLS_ACCEPT to the backend. Allocate a new active socket. Make sure that only

[PATCH v8 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend

2017-10-30 Thread Stefano Stabellini
Introduce a xenbus frontend for the pvcalls protocol, as defined by https://xenbits.xen.org/docs/unstable/misc/pvcalls.html. This patch only adds the stubs, the code will be added by the following patches. Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky

[PATCH v8 10/13] xen/pvcalls: implement recvmsg

2017-10-30 Thread Stefano Stabellini
Implement recvmsg by copying data from the "in" ring. If not enough data is available and the recvmsg call is blocking, then wait on the inflight_conn_req waitqueue. Take the active socket in_mutex so that only one function can access the ring at any given time. Signed-off-by: Stefano Stabellini

[PATCH v8 01/13] xen/pvcalls: introduce the pvcalls xenbus frontend

2017-10-30 Thread Stefano Stabellini
Introduce a xenbus frontend for the pvcalls protocol, as defined by https://xenbits.xen.org/docs/unstable/misc/pvcalls.html. This patch only adds the stubs, the code will be added by the following patches. Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky CC:

[PATCH v8 10/13] xen/pvcalls: implement recvmsg

2017-10-30 Thread Stefano Stabellini
Implement recvmsg by copying data from the "in" ring. If not enough data is available and the recvmsg call is blocking, then wait on the inflight_conn_req waitqueue. Take the active socket in_mutex so that only one function can access the ring at any given time. Signed-off-by: Stefano Stabellini

[PATCH v8 11/13] xen/pvcalls: implement poll command

2017-10-30 Thread Stefano Stabellini
For active sockets, check the indexes and use the inflight_conn_req waitqueue to wait. For passive sockets if an accept is outstanding (PVCALLS_FLAG_ACCEPT_INFLIGHT), check if it has been answered by looking at bedata->rsp[req_id]. If so, return POLLIN. Otherwise use the inflight_accept_req

[PATCH v8 11/13] xen/pvcalls: implement poll command

2017-10-30 Thread Stefano Stabellini
For active sockets, check the indexes and use the inflight_conn_req waitqueue to wait. For passive sockets if an accept is outstanding (PVCALLS_FLAG_ACCEPT_INFLIGHT), check if it has been answered by looking at bedata->rsp[req_id]. If so, return POLLIN. Otherwise use the inflight_accept_req

[PATCH v8 12/13] xen/pvcalls: implement release command

2017-10-30 Thread Stefano Stabellini
Send PVCALLS_RELEASE to the backend and wait for a reply. Take both in_mutex and out_mutex to avoid concurrent accesses. Then, free the socket. For passive sockets, check whether we have already pre-allocated an active socket for the purpose of being accepted. If so, free that as well.

[PATCH v8 12/13] xen/pvcalls: implement release command

2017-10-30 Thread Stefano Stabellini
Send PVCALLS_RELEASE to the backend and wait for a reply. Take both in_mutex and out_mutex to avoid concurrent accesses. Then, free the socket. For passive sockets, check whether we have already pre-allocated an active socket for the purpose of being accepted. If so, free that as well.

[PATCH v8 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-30 Thread Stefano Stabellini
Also add pvcalls-front to the Makefile. Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/Kconfig | 11 +++ drivers/xen/Makefile | 1 + 2 files changed, 12

[PATCH v8 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-30 Thread Stefano Stabellini
Also add pvcalls-front to the Makefile. Signed-off-by: Stefano Stabellini Reviewed-by: Boris Ostrovsky CC: boris.ostrov...@oracle.com CC: jgr...@suse.com --- drivers/xen/Kconfig | 11 +++ drivers/xen/Makefile | 1 + 2 files changed, 12 insertions(+) diff --git a/drivers/xen/Kconfig

[PATCH v8 03/13] xen/pvcalls: connect to the backend

2017-10-30 Thread Stefano Stabellini
Implement the probe function for the pvcalls frontend. Read the supported versions, max-page-order and function-calls nodes from xenstore. Only one frontend<->backend connection is supported at any given time for a guest. Store the active frontend device to a static pointer. Introduce a stub

[PATCH v8 03/13] xen/pvcalls: connect to the backend

2017-10-30 Thread Stefano Stabellini
Implement the probe function for the pvcalls frontend. Read the supported versions, max-page-order and function-calls nodes from xenstore. Only one frontend<->backend connection is supported at any given time for a guest. Store the active frontend device to a static pointer. Introduce a stub

[PATCH v8 00/13] introduce the Xen PV Calls frontend

2017-10-30 Thread Stefano Stabellini
Hi all, this series introduces the frontend for the newly introduced PV Calls procotol. PV Calls is a paravirtualized protocol that allows the implementation of a set of POSIX functions in a different domain. The PV Calls frontend sends POSIX function calls to the backend, which implements them

[PATCH v8 00/13] introduce the Xen PV Calls frontend

2017-10-30 Thread Stefano Stabellini
Hi all, this series introduces the frontend for the newly introduced PV Calls procotol. PV Calls is a paravirtualized protocol that allows the implementation of a set of POSIX functions in a different domain. The PV Calls frontend sends POSIX function calls to the backend, which implements them

Re: [PATCH V8 0/2] printk: hash addresses printed with %p

2017-10-30 Thread Tobin C. Harding
On Mon, Oct 30, 2017 at 03:03:21PM -0700, Kees Cook wrote: > On Wed, Oct 25, 2017 at 7:53 PM, Tobin C. Harding wrote: > > Here is the behaviour that this set implements. > > > > For kpt_restrict==0 > > > > Randomness not ready: > > printed with %p: (pointer)

Re: [PATCH V8 0/2] printk: hash addresses printed with %p

2017-10-30 Thread Tobin C. Harding
On Mon, Oct 30, 2017 at 03:03:21PM -0700, Kees Cook wrote: > On Wed, Oct 25, 2017 at 7:53 PM, Tobin C. Harding wrote: > > Here is the behaviour that this set implements. > > > > For kpt_restrict==0 > > > > Randomness not ready: > > printed with %p: (pointer) # NOTE: with

Re: [PATCH V9] printk: hash addresses printed with %p

2017-10-30 Thread Kees Cook
On Sun, Oct 29, 2017 at 3:59 PM, Tobin C. Harding wrote: > Currently there are many places in the kernel where addresses are being > printed using an unadorned %p. Kernel pointers should be printed using > %pK allowing some control via the kptr_restrict sysctl. Exposing addresses >

Re: [PATCH V9] printk: hash addresses printed with %p

2017-10-30 Thread Kees Cook
On Sun, Oct 29, 2017 at 3:59 PM, Tobin C. Harding wrote: > Currently there are many places in the kernel where addresses are being > printed using an unadorned %p. Kernel pointers should be printed using > %pK allowing some control via the kptr_restrict sysctl. Exposing addresses > gives

[PATCH 1/7] rtc: Allow rtc drivers to specify the tv_nsec value for ntp

2017-10-30 Thread John Stultz
From: Jason Gunthorpe ntp is currently hardwired to try and call the rtc set when wall clock tv_nsec is 0.5 seconds. This historical behaviour works well with certain PC RTCs, but is not universal to all rtc hardware. Change how this works by introducing the

[PATCH 1/7] rtc: Allow rtc drivers to specify the tv_nsec value for ntp

2017-10-30 Thread John Stultz
From: Jason Gunthorpe ntp is currently hardwired to try and call the rtc set when wall clock tv_nsec is 0.5 seconds. This historical behaviour works well with certain PC RTCs, but is not universal to all rtc hardware. Change how this works by introducing the driver specific concept of

[GIT PULL][PATCH 0/7] Timekeeping items for 4.15

2017-10-30 Thread John Stultz
Hey Thomas, Bit later then I'd like, but here's my current queue of timekeeping items for 4.15. >From Arnd's patchset, I'm missing the last patch as it didn't apply properly, but the rest of it looked ok to me. Please let me know if you have any objections. thanks -john Cc: Arnd Bergmann

[GIT PULL][PATCH 0/7] Timekeeping items for 4.15

2017-10-30 Thread John Stultz
Hey Thomas, Bit later then I'd like, but here's my current queue of timekeeping items for 4.15. >From Arnd's patchset, I'm missing the last patch as it didn't apply properly, but the rest of it looked ok to me. Please let me know if you have any objections. thanks -john Cc: Arnd Bergmann

[PATCH 4/7] time: Remove unused functions

2017-10-30 Thread John Stultz
From: Arnd Bergmann The (slow but) ongoing work on conversion from timespec to timespec64 has led some timespec based helper functions to become unused. No new code should use them, so we can remove the functions entirely. I'm planning to obsolete additional interfaces next and

[PATCH 4/7] time: Remove unused functions

2017-10-30 Thread John Stultz
From: Arnd Bergmann The (slow but) ongoing work on conversion from timespec to timespec64 has led some timespec based helper functions to become unused. No new code should use them, so we can remove the functions entirely. I'm planning to obsolete additional interfaces next and remove more of

[PATCH 5/7] time: Move time_t based interfaces to time32.h

2017-10-30 Thread John Stultz
From: Arnd Bergmann Interfaces based on 'struct timespec' or 'struct timeval' should no longer be used for new code, which can use either ktime_t or 'struct timespec64' instead. To make this a little clearer, this moves the various helpers into a new time32.h header. For the

[PATCH 5/7] time: Move time_t based interfaces to time32.h

2017-10-30 Thread John Stultz
From: Arnd Bergmann Interfaces based on 'struct timespec' or 'struct timeval' should no longer be used for new code, which can use either ktime_t or 'struct timespec64' instead. To make this a little clearer, this moves the various helpers into a new time32.h header. For the moment, this gets

[PATCH 6/7] time: Move time_t conversion helpers to time32.h

2017-10-30 Thread John Stultz
From: Arnd Bergmann On 64-bit architectures, the timespec64 based helpers in linux/time.h are defined as macros pointing to their timespec based counterparts. This made sense when they were first introduced, but as we are migrating away from timespec in general, it's much less

[PATCH 6/7] time: Move time_t conversion helpers to time32.h

2017-10-30 Thread John Stultz
From: Arnd Bergmann On 64-bit architectures, the timespec64 based helpers in linux/time.h are defined as macros pointing to their timespec based counterparts. This made sense when they were first introduced, but as we are migrating away from timespec in general, it's much less intuitive now.

[PATCH 7/7] time: Move old timekeeping interfaces to timekeeping32.h

2017-10-30 Thread John Stultz
From: Arnd Bergmann The interfaces based on 'struct timespec' and 'unsigned long' seconds are no longer recommended for new code, and we are trying to migrate to ktime_t based interfaces and other y2038-safe variants. This moves all the legacy interfaces from linux/timekeeping.h

[PATCH 7/7] time: Move old timekeeping interfaces to timekeeping32.h

2017-10-30 Thread John Stultz
From: Arnd Bergmann The interfaces based on 'struct timespec' and 'unsigned long' seconds are no longer recommended for new code, and we are trying to migrate to ktime_t based interfaces and other y2038-safe variants. This moves all the legacy interfaces from linux/timekeeping.h into a new

[PATCH 2/7] timekeeping: Consolidate timekeeping_inject_offset code

2017-10-30 Thread John Stultz
From: Arnd Bergmann The code to check the adjtimex() or clock_adjtime() arguments is spread out across multiple files for presumably only historic reasons. As a preparatation for a rework to get rid of the use of 'struct timeval' and 'struct timespec' in there, this moves all the

[PATCH 2/7] timekeeping: Consolidate timekeeping_inject_offset code

2017-10-30 Thread John Stultz
From: Arnd Bergmann The code to check the adjtimex() or clock_adjtime() arguments is spread out across multiple files for presumably only historic reasons. As a preparatation for a rework to get rid of the use of 'struct timeval' and 'struct timespec' in there, this moves all the portions into

[PATCH 3/7] timekeeping: Use timespec64 in timekeeping_inject_offset

2017-10-30 Thread John Stultz
From: Arnd Bergmann As part of changing all the timekeeping code to use 64-bit time_t consistently, this removes the uses of timeval and timespec as much as possible from do_adjtimex() and timekeeping_inject_offset(). The timeval_inject_offset_valid() and

[PATCH 3/7] timekeeping: Use timespec64 in timekeeping_inject_offset

2017-10-30 Thread John Stultz
From: Arnd Bergmann As part of changing all the timekeeping code to use 64-bit time_t consistently, this removes the uses of timeval and timespec as much as possible from do_adjtimex() and timekeeping_inject_offset(). The timeval_inject_offset_valid() and timespec_inject_offset_valid() just

Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID

2017-10-30 Thread sathyanarayanan kuppuswamy
Hi, On 10/30/2017 03:58 AM, Cyrille Pitchen wrote: Applied to the spi-nor/next branch of l2-mtd Just for info, this patch didn't apply directly, it misses a line in the list of PCI IDS: { PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)_info }, I re-based my patch on top of Mika's SPI

Re: [PATCH v2 1/1] mtd: intel-spi: Add Intel Lewisburg PCH SPI super SKU PCI ID

2017-10-30 Thread sathyanarayanan kuppuswamy
Hi, On 10/30/2017 03:58 AM, Cyrille Pitchen wrote: Applied to the spi-nor/next branch of l2-mtd Just for info, this patch didn't apply directly, it misses a line in the list of PCI IDS: { PCI_VDEVICE(INTEL, 0x18e0), (unsigned long)_info }, I re-based my patch on top of Mika's SPI

Re: Kernel crash in free_pipe_info()

2017-10-30 Thread Linus Torvalds
On Mon, Oct 30, 2017 at 3:14 PM, Linus Torvalds wrote: > On Mon, Oct 30, 2017 at 1:58 PM, Cong Wang wrote: >> >> We got more than a dozen of kernel crashes at free_pipe_info() on our >> 4.1 kernel, they are all very similar to this one

Re: Kernel crash in free_pipe_info()

2017-10-30 Thread Linus Torvalds
On Mon, Oct 30, 2017 at 3:14 PM, Linus Torvalds wrote: > On Mon, Oct 30, 2017 at 1:58 PM, Cong Wang wrote: >> >> We got more than a dozen of kernel crashes at free_pipe_info() on our >> 4.1 kernel, they are all very similar to this one (with slightly >> different faulty addresses): > > Were it

[PATCH v2] staging: vc04_services: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Additionally removes invalid NULL check, as pointed out by Dan Carpenter. Cc: Greg Kroah-Hartman

[PATCH v2] staging: vc04_services: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Additionally removes invalid NULL check, as pointed out by Dan Carpenter. Cc: Greg Kroah-Hartman Cc: Eric

[PATCH v2] i2c: xgene-slimpro: Support v2

2017-10-30 Thread Hoan Tran
This patch supports xgene-slimpro-i2c v2 which uses the non-cachable memory as the PCC shared memory. Signed-off-by: Hoan Tran --- v2: - Remove un-necessary ifdef CONFIG_ACPI - Use acpi_match_table pointer from pdev - Use MEMREMAP_WT for non-cachable memory

[PATCH v2] i2c: xgene-slimpro: Support v2

2017-10-30 Thread Hoan Tran
This patch supports xgene-slimpro-i2c v2 which uses the non-cachable memory as the PCC shared memory. Signed-off-by: Hoan Tran --- v2: - Remove un-necessary ifdef CONFIG_ACPI - Use acpi_match_table pointer from pdev - Use MEMREMAP_WT for non-cachable memory

Re: [Jfs-discussion] [PATCH] jfs: remove increment of i_version counter

2017-10-30 Thread Dave Kleikamp
On 10/30/2017 10:16 AM, Jeff Layton wrote: > From: Jeff Layton > > JFS does not set SB_I_VERSION and doesn't use the i_version counter > internally. Just remove this increment. Looks good. I'll push it upstream. Thanks, Shaggy > > Signed-off-by: Jeff Layton

Re: [Jfs-discussion] [PATCH] jfs: remove increment of i_version counter

2017-10-30 Thread Dave Kleikamp
On 10/30/2017 10:16 AM, Jeff Layton wrote: > From: Jeff Layton > > JFS does not set SB_I_VERSION and doesn't use the i_version counter > internally. Just remove this increment. Looks good. I'll push it upstream. Thanks, Shaggy > > Signed-off-by: Jeff Layton > --- > fs/jfs/super.c | 1 - >

Re: [PATCH] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

2017-10-30 Thread Gustavo A. R. Silva
Hi Alan, Quoting Alan Tull : On Sat, Oct 28, 2017 at 12:15 PM, Moritz Fischer wrote: Hi Gustavo, Thanks! Glad to help. :) Thanks -- Gustavo A. R. Silva

Re: [PATCH] fpga: fpga-bridge: remove unnecessary null check in of_fpga_bridge_get

2017-10-30 Thread Gustavo A. R. Silva
Hi Alan, Quoting Alan Tull : On Sat, Oct 28, 2017 at 12:15 PM, Moritz Fischer wrote: Hi Gustavo, Thanks! Glad to help. :) Thanks -- Gustavo A. R. Silva

[PATCH] netfilter: ipset: use swap macro instead of _manually_ swapping values

2017-10-30 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variables tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/netfilter/ipset/ip_set_bitmap_ip.c| 8 ++--

[PATCH] netfilter: ipset: use swap macro instead of _manually_ swapping values

2017-10-30 Thread Gustavo A. R. Silva
Make use of the swap macro and remove unnecessary variables tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- net/netfilter/ipset/ip_set_bitmap_ip.c| 8 ++--

[PATCH net-next] net: dsa: b53: Have b53_hdr_setup() enable/disable tagging

2017-10-30 Thread Florian Fainelli
Have b53_hdr_setup() check what kind of tagging protocol is configured (Broadcom or none) and apply the correct settings in both cases. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 16 +--- 1 file changed, 13 insertions(+), 3

[PATCH net-next] net: dsa: b53: Have b53_hdr_setup() enable/disable tagging

2017-10-30 Thread Florian Fainelli
Have b53_hdr_setup() check what kind of tagging protocol is configured (Broadcom or none) and apply the correct settings in both cases. Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_common.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git

Re: [PATCH] media: av7110: switch to useing timer_setup()

2017-10-30 Thread Kees Cook
On Tue, Oct 24, 2017 at 5:40 PM, Dmitry Torokhov wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Also stop

Re: [PATCH] media: av7110: switch to useing timer_setup()

2017-10-30 Thread Kees Cook
On Tue, Oct 24, 2017 at 5:40 PM, Dmitry Torokhov wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Also stop poking into input core

Re: [PATCH v7 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-30 Thread Stefano Stabellini
On Mon, 30 Oct 2017, Boris Ostrovsky wrote: > On 10/30/2017 05:42 PM, Stefano Stabellini wrote: > > On Mon, 30 Oct 2017, Boris Ostrovsky wrote: > >> On 10/30/2017 03:48 PM, Stefano Stabellini wrote: > >>> On Mon, 30 Oct 2017, Boris Ostrovsky wrote: > Build warnings (gcc (GCC) 6.3.1 20161221

Re: [PATCH v7 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-30 Thread Stefano Stabellini
On Mon, 30 Oct 2017, Boris Ostrovsky wrote: > On 10/30/2017 05:42 PM, Stefano Stabellini wrote: > > On Mon, 30 Oct 2017, Boris Ostrovsky wrote: > >> On 10/30/2017 03:48 PM, Stefano Stabellini wrote: > >>> On Mon, 30 Oct 2017, Boris Ostrovsky wrote: > Build warnings (gcc (GCC) 6.3.1 20161221

Re: Kernel crash in free_pipe_info()

2017-10-30 Thread Linus Torvalds
On Mon, Oct 30, 2017 at 1:58 PM, Cong Wang wrote: > > We got more than a dozen of kernel crashes at free_pipe_info() on our > 4.1 kernel, they are all very similar to this one (with slightly > different faulty addresses): Were it not for the pointer to the much more

Re: Kernel crash in free_pipe_info()

2017-10-30 Thread Linus Torvalds
On Mon, Oct 30, 2017 at 1:58 PM, Cong Wang wrote: > > We got more than a dozen of kernel crashes at free_pipe_info() on our > 4.1 kernel, they are all very similar to this one (with slightly > different faulty addresses): Were it not for the pointer to the much more recent powerpc version at

Re: [Jfs-discussion] [PATCH] jfs: Add missing NULL pointer check in __get_metapage

2017-10-30 Thread Dave Kleikamp
On 10/25/2017 02:50 AM, Juerg Haefliger wrote: > Is this a patch you might consider? Sorry it's taken me so long to respond. I don't think this is the right fix. A failed allocation will still result in a null pointer dereference by the caller, __get_metapage(). I think the check needs to be put

Re: [Jfs-discussion] [PATCH] jfs: Add missing NULL pointer check in __get_metapage

2017-10-30 Thread Dave Kleikamp
On 10/25/2017 02:50 AM, Juerg Haefliger wrote: > Is this a patch you might consider? Sorry it's taken me so long to respond. I don't think this is the right fix. A failed allocation will still result in a null pointer dereference by the caller, __get_metapage(). I think the check needs to be put

<    1   2   3   4   5   6   7   8   9   10   >