Re: [PATCH v3] Update MIPS email addresses

2017-10-30 Thread Paul Burton
Hello all, On Wed, Oct 25, 2017 at 05:04:33PM -0700, Paul Burton wrote: > MIPS will soon not be a part of Imagination Technologies, and as such > many @imgtec.com email addresses will no longer be valid. The affected email addresses now only have one week of life left. Can someone/anyone please

Re: [PATCH v3] Update MIPS email addresses

2017-10-30 Thread Paul Burton
Hello all, On Wed, Oct 25, 2017 at 05:04:33PM -0700, Paul Burton wrote: > MIPS will soon not be a part of Imagination Technologies, and as such > many @imgtec.com email addresses will no longer be valid. The affected email addresses now only have one week of life left. Can someone/anyone please

Re: [PATCH V4 00/12] drivers: Boot Constraints core

2017-10-30 Thread Rob Herring
On Sun, Oct 29, 2017 at 8:48 AM, Viresh Kumar wrote: > Hi Greg, > > Here is V4 of the boot constraints core based on your feedback from V3. > We now have support for three platforms (as you suggested) included in > this series: Hisilicon, IMX and Qualcomm. > > I have

Re: [PATCH V4 00/12] drivers: Boot Constraints core

2017-10-30 Thread Rob Herring
On Sun, Oct 29, 2017 at 8:48 AM, Viresh Kumar wrote: > Hi Greg, > > Here is V4 of the boot constraints core based on your feedback from V3. > We now have support for three platforms (as you suggested) included in > this series: Hisilicon, IMX and Qualcomm. > > I have tested the Hisilicon patches

Re: WARNING in strp_data_ready

2017-10-30 Thread Tom Herbert
On Mon, Oct 30, 2017 at 2:44 PM, John Fastabend wrote: > On 10/24/2017 08:20 AM, syzbot wrote: >> Hello, >> >> syzkaller hit the following crash on 73d3393ada4f70fa3df5639c8d438f2f034c0ecb >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master >>

Re: WARNING in strp_data_ready

2017-10-30 Thread Tom Herbert
On Mon, Oct 30, 2017 at 2:44 PM, John Fastabend wrote: > On 10/24/2017 08:20 AM, syzbot wrote: >> Hello, >> >> syzkaller hit the following crash on 73d3393ada4f70fa3df5639c8d438f2f034c0ecb >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master >> compiler: gcc (GCC) 7.1.1

Re: [PATCH] drm: gma500: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 3:08 AM, Daniel Vetter wrote: > On Tue, Oct 24, 2017 at 08:16:09AM -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to

Re: [PATCH] drm: gma500: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 3:08 AM, Daniel Vetter wrote: > On Tue, Oct 24, 2017 at 08:16:09AM -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer

Re: [PATCH V8 0/2] printk: hash addresses printed with %p

2017-10-30 Thread Kees Cook
On Wed, Oct 25, 2017 at 7:53 PM, Tobin C. Harding wrote: > Here is the behaviour that this set implements. > > For kpt_restrict==0 > > Randomness not ready: > printed with %p: (pointer) # NOTE: with padding > Valid pointer: > printed with %pK:

Re: [PATCH V8 0/2] printk: hash addresses printed with %p

2017-10-30 Thread Kees Cook
On Wed, Oct 25, 2017 at 7:53 PM, Tobin C. Harding wrote: > Here is the behaviour that this set implements. > > For kpt_restrict==0 > > Randomness not ready: > printed with %p: (pointer) # NOTE: with padding > Valid pointer: > printed with %pK:

Re: [PATCH v7 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-30 Thread Boris Ostrovsky
On 10/30/2017 05:42 PM, Stefano Stabellini wrote: > On Mon, 30 Oct 2017, Boris Ostrovsky wrote: >> On 10/30/2017 03:48 PM, Stefano Stabellini wrote: >>> On Mon, 30 Oct 2017, Boris Ostrovsky wrote: Build warnings (gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)) >>> Hi Boris, I am trying to repro

Re: [PATCH v7 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-30 Thread Boris Ostrovsky
On 10/30/2017 05:42 PM, Stefano Stabellini wrote: > On Mon, 30 Oct 2017, Boris Ostrovsky wrote: >> On 10/30/2017 03:48 PM, Stefano Stabellini wrote: >>> On Mon, 30 Oct 2017, Boris Ostrovsky wrote: Build warnings (gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)) >>> Hi Boris, I am trying to repro

xfs: list corruption in xfs_setup_inode()

2017-10-30 Thread Cong Wang
Hello, We triggered a list corruption (double add) warning below on our 4.9 kernel (the 4.9 kernel we use is based on -stable release, with only a few unrelated networking backports): WARNING: CPU: 5 PID: 628 at lib/list_debug.c:36 __list_add+0xac/0xb0 list_add double add: new=8d9d691e0aa0,

xfs: list corruption in xfs_setup_inode()

2017-10-30 Thread Cong Wang
Hello, We triggered a list corruption (double add) warning below on our 4.9 kernel (the 4.9 kernel we use is based on -stable release, with only a few unrelated networking backports): WARNING: CPU: 5 PID: 628 at lib/list_debug.c:36 __list_add+0xac/0xb0 list_add double add: new=8d9d691e0aa0,

Re: [PATCH] netfilter: ipset: ip_set_bitmap_ipmac: use swap macro in bitmap_ipmac_create

2017-10-30 Thread Gustavo A. R. Silva
Hi Jozsef, Quoting Jozsef Kadlecsik : Hi, On Sat, 28 Oct 2017, Gustavo A. R. Silva wrote: Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle.

Re: [PATCH] netfilter: ipset: ip_set_bitmap_ipmac: use swap macro in bitmap_ipmac_create

2017-10-30 Thread Gustavo A. R. Silva
Hi Jozsef, Quoting Jozsef Kadlecsik : Hi, On Sat, 28 Oct 2017, Gustavo A. R. Silva wrote: Make use of the swap macro and remove unnecessary variable tmp. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva

Re: [PATCH 0/2] Fix s5p-mfc lock contention in request firmware paths

2017-10-30 Thread Shuah Khan
On 10/25/2017 04:28 PM, Marian Mihailescu wrote: > Hi Shuah, > > For MFC patch, you can delete the "dev" variable since it's not being > used anymore and results in a compile warning. > > - struct s5p_mfc_dev *dev = ctx->dev; > Hi Marian, This series doesn't have the unused warn problem. I

Re: [PATCH 0/2] Fix s5p-mfc lock contention in request firmware paths

2017-10-30 Thread Shuah Khan
On 10/25/2017 04:28 PM, Marian Mihailescu wrote: > Hi Shuah, > > For MFC patch, you can delete the "dev" variable since it's not being > used anymore and results in a compile warning. > > - struct s5p_mfc_dev *dev = ctx->dev; > Hi Marian, This series doesn't have the unused warn problem. I

[PATCH] mmc: dw_mmc: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Jaehoon Chung Cc: Ulf Hansson Cc:

[PATCH] mmc: dw_mmc: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Jaehoon Chung Cc: Ulf Hansson Cc: linux-...@vger.kernel.org Signed-off-by: Kees Cook ---

Re: [PATCH v3 0/12] arm+arm64: vdso unification to lib/vdso/

2017-10-30 Thread Mark Rutland
On Mon, Oct 30, 2017 at 01:34:13PM -0700, Mark Salyzyn wrote: > On 10/30/2017 07:18 AM, Mark Rutland wrote: > > On Fri, Oct 27, 2017 at 03:23:48PM -0700, Mark Salyzyn wrote: > > > Note I noticed a bug in the old implementation of __kernel_clock_getres; > > > it was checking only the lower 32bits

Re: [PATCH v3 0/12] arm+arm64: vdso unification to lib/vdso/

2017-10-30 Thread Mark Rutland
On Mon, Oct 30, 2017 at 01:34:13PM -0700, Mark Salyzyn wrote: > On 10/30/2017 07:18 AM, Mark Rutland wrote: > > On Fri, Oct 27, 2017 at 03:23:48PM -0700, Mark Salyzyn wrote: > > > Note I noticed a bug in the old implementation of __kernel_clock_getres; > > > it was checking only the lower 32bits

Re: WARNING in strp_data_ready

2017-10-30 Thread John Fastabend
On 10/24/2017 08:20 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on 73d3393ada4f70fa3df5639c8d438f2f034c0ecb > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. >

Re: [PATCH 03/17] coresight: Add helper for inserting synchronization packets

2017-10-30 Thread Mathieu Poirier
On Thu, Oct 19, 2017 at 06:15:39PM +0100, Suzuki K Poulose wrote: > Right now we open code filling the trace buffer with synchronization > packets when the circular buffer wraps around in different drivers. > Move this to a common place. > > Cc: Mathieu Poirier > Cc:

Re: WARNING in strp_data_ready

2017-10-30 Thread John Fastabend
On 10/24/2017 08:20 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on 73d3393ada4f70fa3df5639c8d438f2f034c0ecb > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. >

Re: [PATCH 03/17] coresight: Add helper for inserting synchronization packets

2017-10-30 Thread Mathieu Poirier
On Thu, Oct 19, 2017 at 06:15:39PM +0100, Suzuki K Poulose wrote: > Right now we open code filling the trace buffer with synchronization > packets when the circular buffer wraps around in different drivers. > Move this to a common place. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by:

Re: [PATCH] usb: musb: dsps: remove the duplicated timer

2017-10-30 Thread Greg Kroah-Hartman
On Mon, Oct 30, 2017 at 02:29:54PM -0700, Kees Cook wrote: > On Mon, Oct 30, 2017 at 9:29 AM, Bin Liu wrote: > > Now struct musb has the timer (dev_timer) for glue drivers, so let's > > remove the duplicated timer defined in dsps glue driver, and use > > dev_timer defined in struct

Re: [PATCH] usb: musb: dsps: remove the duplicated timer

2017-10-30 Thread Greg Kroah-Hartman
On Mon, Oct 30, 2017 at 02:29:54PM -0700, Kees Cook wrote: > On Mon, Oct 30, 2017 at 9:29 AM, Bin Liu wrote: > > Now struct musb has the timer (dev_timer) for glue drivers, so let's > > remove the duplicated timer defined in dsps glue driver, and use > > dev_timer defined in struct musb. > > > >

Re: [PATCH v7 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-30 Thread Stefano Stabellini
On Mon, 30 Oct 2017, Boris Ostrovsky wrote: > On 10/30/2017 03:48 PM, Stefano Stabellini wrote: > > On Mon, 30 Oct 2017, Boris Ostrovsky wrote: > >> > >> Build warnings (gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)) > > Hi Boris, I am trying to repro the warnings below. I have been > > unsuccessful

Re: [PATCH v7 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

2017-10-30 Thread Stefano Stabellini
On Mon, 30 Oct 2017, Boris Ostrovsky wrote: > On 10/30/2017 03:48 PM, Stefano Stabellini wrote: > > On Mon, 30 Oct 2017, Boris Ostrovsky wrote: > >> > >> Build warnings (gcc (GCC) 6.3.1 20161221 (Red Hat 6.3.1-1)) > > Hi Boris, I am trying to repro the warnings below. I have been > > unsuccessful

[PATCH 2/2] pvcalls: fix casts to avoid warnings on 32 bit

2017-10-30 Thread Stefano Stabellini
Cast the map pointers to uintptr_t instead of uint64_t everywhere when setting the socket ids. In pvcalls_front_event_handler, first cast the poll id to uintptr_t, then to struct sock_mapping * to avoid warnings. We know that the poll id is fine because it is was set by the frontend initially in

[PATCH 1/2] pvcalls: check return value from copy_from/to_iter

2017-10-30 Thread Stefano Stabellini
Check the return value of copy_from_iter in __write_ring and copy_to_iter in __read_ring. Update "len" accordingly. In the cases where we issue two consecutive copy_from_iter, or two consecutive copy_to_iter, first check return, then goto out if it is not what we expect. Signed-off-by: Stefano

[PATCH 2/2] pvcalls: fix casts to avoid warnings on 32 bit

2017-10-30 Thread Stefano Stabellini
Cast the map pointers to uintptr_t instead of uint64_t everywhere when setting the socket ids. In pvcalls_front_event_handler, first cast the poll id to uintptr_t, then to struct sock_mapping * to avoid warnings. We know that the poll id is fine because it is was set by the frontend initially in

[PATCH 1/2] pvcalls: check return value from copy_from/to_iter

2017-10-30 Thread Stefano Stabellini
Check the return value of copy_from_iter in __write_ring and copy_to_iter in __read_ring. Update "len" accordingly. In the cases where we issue two consecutive copy_from_iter, or two consecutive copy_to_iter, first check return, then goto out if it is not what we expect. Signed-off-by: Stefano

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: > On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: >> >> >> On 30/10/17 11:38, Johan Hovold wrote: >> > On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote: >> >> On 30/10/17 11:32, Johan Hovold

Re: [PATCH v2] staging: greybus: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 4:48 AM, Johan Hovold wrote: > On Mon, Oct 30, 2017 at 11:44:22AM +, Bryan O'Donoghue wrote: >> >> >> On 30/10/17 11:38, Johan Hovold wrote: >> > On Mon, Oct 30, 2017 at 11:35:50AM +, Bryan O'Donoghue wrote: >> >> On 30/10/17 11:32, Johan Hovold wrote: >> >>> The

[PATCH] genirq: __setup_irq(): fix type of literal 1 in shift

2017-10-30 Thread Rasmus Villemoes
If we ever get a value >= 31 from ffz(), we'd be invoking UB; in the > 31 case, probably assigning the same thread_mask to to multiple irqactions (at least on x86_64, where the shift count is implicitly truncated to 5 bits). In practice, I think the bug is mostly harmless, since when we first get

[PATCH] genirq: __setup_irq(): fix type of literal 1 in shift

2017-10-30 Thread Rasmus Villemoes
If we ever get a value >= 31 from ffz(), we'd be invoking UB; in the > 31 case, probably assigning the same thread_mask to to multiple irqactions (at least on x86_64, where the shift count is implicitly truncated to 5 bits). In practice, I think the bug is mostly harmless, since when we first get

[PATCH 2/2] max8997_charger: Improve a size determination in max8997_battery_probe()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 22:22:54 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style

[PATCH 2/2] max8997_charger: Improve a size determination in max8997_battery_probe()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 22:22:54 +0100 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was

Re: [RESEND v12 0/6] cgroup-aware OOM killer

2017-10-30 Thread David Rientjes
On Fri, 27 Oct 2017, Roman Gushchin wrote: > The thing is that the hierarchical approach (as in v8), which are you pushing, > has it's own limitations, which we've discussed in details earlier. There are > reasons why v12 is different, and we can't really simple go back. I mean if > there are

Re: [RESEND v12 0/6] cgroup-aware OOM killer

2017-10-30 Thread David Rientjes
On Fri, 27 Oct 2017, Roman Gushchin wrote: > The thing is that the hierarchical approach (as in v8), which are you pushing, > has it's own limitations, which we've discussed in details earlier. There are > reasons why v12 is different, and we can't really simple go back. I mean if > there are

[PATCH 1/2] max8997_charger: Use common error handling code in max8997_battery_probe()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 22:14:52 +0100 Add a jump target so that a specific error message is stored only once at the end of this function implementation. Replace two calls of the function "dev_err" by goto statements. This issue was detected by

[PATCH 1/2] max8997_charger: Use common error handling code in max8997_battery_probe()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 22:14:52 +0100 Add a jump target so that a specific error message is stored only once at the end of this function implementation. Replace two calls of the function "dev_err" by goto statements. This issue was detected by using the Coccinelle software.

[PATCH 0/2] max8997_charger: Fine-tuning for max8997_battery_probe()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 22:30:22 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use common error handling code Improve a size determination drivers/power/supply/max8997_charger.c

[PATCH 0/2] max8997_charger: Fine-tuning for max8997_battery_probe()

2017-10-30 Thread SF Markus Elfring
From: Markus Elfring Date: Mon, 30 Oct 2017 22:30:22 +0100 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Use common error handling code Improve a size determination drivers/power/supply/max8997_charger.c | 19 +-- 1

Re: [PATCH V8 2/2] printk: hash addresses printed with %p

2017-10-30 Thread Steven Rostedt
On Thu, 26 Oct 2017 13:58:38 +1100 "Tobin C. Harding" wrote: > > +static bool have_filled_random_ptr_key; > > +static siphash_key_t ptr_key __read_mostly; > > + > > +static void fill_random_ptr_key(struct random_ready_callback *unused) > > +{ > > + get_random_bytes(_key,

Re: [PATCH V8 2/2] printk: hash addresses printed with %p

2017-10-30 Thread Steven Rostedt
On Thu, 26 Oct 2017 13:58:38 +1100 "Tobin C. Harding" wrote: > > +static bool have_filled_random_ptr_key; > > +static siphash_key_t ptr_key __read_mostly; > > + > > +static void fill_random_ptr_key(struct random_ready_callback *unused) > > +{ > > + get_random_bytes(_key, sizeof(ptr_key)); > >

Re: [PATCH] i2c: xgene-slimpro: Support v2

2017-10-30 Thread Hoan Tran
Hi Andy, On Sat, Oct 28, 2017 at 12:37 PM, Andy Shevchenko wrote: > On Sat, 2017-10-28 at 14:11 +0200, Wolfram Sang wrote: >> Thanks for the patch! >> >> On Mon, Oct 23, 2017 at 03:12:20PM -0700, Hoan Tran wrote: >> > This patch supports xgene-slimpro-i2c v2

Re: [PATCH] i2c: xgene-slimpro: Support v2

2017-10-30 Thread Hoan Tran
Hi Andy, On Sat, Oct 28, 2017 at 12:37 PM, Andy Shevchenko wrote: > On Sat, 2017-10-28 at 14:11 +0200, Wolfram Sang wrote: >> Thanks for the patch! >> >> On Mon, Oct 23, 2017 at 03:12:20PM -0700, Hoan Tran wrote: >> > This patch supports xgene-slimpro-i2c v2 which uses the non-cachable >> >

linux-next: No tree for Oct 20th

2017-10-30 Thread Mark Brown
There will be no -next tree today, there are too many non-trivial conflicts for things to complete in a reasonable time. signature.asc Description: PGP signature

linux-next: No tree for Oct 20th

2017-10-30 Thread Mark Brown
There will be no -next tree today, there are too many non-trivial conflicts for things to complete in a reasonable time. signature.asc Description: PGP signature

Re: [PATCH] usb: musb: dsps: remove the duplicated timer

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 9:29 AM, Bin Liu wrote: > Now struct musb has the timer (dev_timer) for glue drivers, so let's > remove the duplicated timer defined in dsps glue driver, and use > dev_timer defined in struct musb. > > Signed-off-by: Bin Liu Reviewed-by: Kees

Re: [PATCH] usb: musb: dsps: remove the duplicated timer

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 9:29 AM, Bin Liu wrote: > Now struct musb has the timer (dev_timer) for glue drivers, so let's > remove the duplicated timer defined in dsps glue driver, and use > dev_timer defined in struct musb. > > Signed-off-by: Bin Liu Reviewed-by: Kees Cook Thanks for this; it

Re: [PATCH v3 2/2] usb: dwc2: host: Convert hcd_queue to timer_setup

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 10:08 AM, Douglas Anderson wrote: > Convert the timers in hcd_queue to use the new timer_setup() call > introduced in commit 686fef928bba ("timer: Prepare to change timer > callback argument type"). > > Suggested-by: Stefan Wahren

Re: [PATCH v3 2/2] usb: dwc2: host: Convert hcd_queue to timer_setup

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 10:08 AM, Douglas Anderson wrote: > Convert the timers in hcd_queue to use the new timer_setup() call > introduced in commit 686fef928bba ("timer: Prepare to change timer > callback argument type"). > > Suggested-by: Stefan Wahren > Signed-off-by: Douglas Anderson > Cc:

Re: [PATCH v7] printk: hash addresses printed with %p

2017-10-30 Thread Tobin C. Harding
On Mon, Oct 30, 2017 at 04:22:44PM -0400, Steven Rostedt wrote: > On Wed, 25 Oct 2017 14:49:34 +1100 > "Tobin C. Harding" wrote: > > > > First, the static_key stuff. > > > > DEFINE_STATIC_KEY_TRUE(no_ptr_secret) : Doesn't sleep, just a > > declaration. > > > > if

Re: [PATCH v7] printk: hash addresses printed with %p

2017-10-30 Thread Tobin C. Harding
On Mon, Oct 30, 2017 at 04:22:44PM -0400, Steven Rostedt wrote: > On Wed, 25 Oct 2017 14:49:34 +1100 > "Tobin C. Harding" wrote: > > > > First, the static_key stuff. > > > > DEFINE_STATIC_KEY_TRUE(no_ptr_secret) : Doesn't sleep, just a > > declaration. > > > > if

Re: [PATCH] rcu: Convert timers to use timer_setup()

2017-10-30 Thread Paul E. McKenney
On Mon, Oct 30, 2017 at 02:13:03PM -0700, Kees Cook wrote: > On Mon, Oct 30, 2017 at 11:04 AM, Paul E. McKenney > wrote: > > On Tue, Oct 24, 2017 at 02:32:04AM -0700, Kees Cook wrote: > >> In preparation for unconditionally passing the struct timer_list pointer to > >>

Re: [PATCH] rcu: Convert timers to use timer_setup()

2017-10-30 Thread Paul E. McKenney
On Mon, Oct 30, 2017 at 02:13:03PM -0700, Kees Cook wrote: > On Mon, Oct 30, 2017 at 11:04 AM, Paul E. McKenney > wrote: > > On Tue, Oct 24, 2017 at 02:32:04AM -0700, Kees Cook wrote: > >> In preparation for unconditionally passing the struct timer_list pointer to > >> all timer callbacks, switch

Re: [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param_call()

2017-10-30 Thread Kees Cook
On Tue, Oct 17, 2017 at 7:04 PM, Kees Cook wrote: > (re-sending to Jessica's @korg address...) > > The module_param_call() macro was explicitly casting the .set and .get > function prototypes away with (void *). This can lead to hard-to-find > type mismatches. Additionally,

[PATCH 2/2] samples/bpf: add a test for bpf_override_return

2017-10-30 Thread Josef Bacik
From: Josef Bacik This adds a basic test for bpf_override_return to verify it works. We override the main function for mounting a btrfs fs so it'll return -ENOMEM and then make sure that trying to mount a btrfs fs will fail. Signed-off-by: Josef Bacik ---

Re: [RESEND][PATCH 0/3] module: Do not paper over type mismatches in module_param_call()

2017-10-30 Thread Kees Cook
On Tue, Oct 17, 2017 at 7:04 PM, Kees Cook wrote: > (re-sending to Jessica's @korg address...) > > The module_param_call() macro was explicitly casting the .set and .get > function prototypes away with (void *). This can lead to hard-to-find > type mismatches. Additionally, it creates problems

[PATCH 2/2] samples/bpf: add a test for bpf_override_return

2017-10-30 Thread Josef Bacik
From: Josef Bacik This adds a basic test for bpf_override_return to verify it works. We override the main function for mounting a btrfs fs so it'll return -ENOMEM and then make sure that trying to mount a btrfs fs will fail. Signed-off-by: Josef Bacik --- samples/bpf/Makefile

[PATCH 1/2] bpf: add a bpf_override_function helper

2017-10-30 Thread Josef Bacik
From: Josef Bacik Error injection is sloppy and very ad-hoc. BPF could fill this niche perfectly with it's kprobe functionality. We could make sure errors are only triggered in specific call chains that we care about with very specific situations. Accomplish this with the

[PATCH 0/2] Add the ability to do BPF directed error injection

2017-10-30 Thread Josef Bacik
A lot of our error paths are not well tested because we have no good way of injecting errors generically. Some subystems (block, memory) have ways to inject errors, but they are random so it's hard to get reproduceable results. With BPF we can add determinism to our error injection. We can use

[PATCH 1/2] bpf: add a bpf_override_function helper

2017-10-30 Thread Josef Bacik
From: Josef Bacik Error injection is sloppy and very ad-hoc. BPF could fill this niche perfectly with it's kprobe functionality. We could make sure errors are only triggered in specific call chains that we care about with very specific situations. Accomplish this with the

[PATCH 0/2] Add the ability to do BPF directed error injection

2017-10-30 Thread Josef Bacik
A lot of our error paths are not well tested because we have no good way of injecting errors generically. Some subystems (block, memory) have ways to inject errors, but they are random so it's hard to get reproduceable results. With BPF we can add determinism to our error injection. We can use

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-30 Thread Sergei Shtylyov
On 10/30/2017 11:51 PM, Sergei Shtylyov wrote: From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Have you actually tried to see if there's any

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-30 Thread Sergei Shtylyov
On 10/30/2017 11:51 PM, Sergei Shtylyov wrote: From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. Have you actually tried to see if there's any change in the resulting object

Re: [PATCH 4.13 44/85] tracing/samples: Fix creation and deletion of simple_thread_fn creation

2017-10-30 Thread Greg Kroah-Hartman
On Mon, Oct 30, 2017 at 03:57:11PM -0400, Steven Rostedt wrote: > On Tue, 24 Oct 2017 15:07:18 +0200 > Greg Kroah-Hartman wrote: > > > 4.13-stable review patch. If anyone has any objections, please let me know. > > Just that it needs a fix. > > > > > ---

Re: [PATCH 4.13 44/85] tracing/samples: Fix creation and deletion of simple_thread_fn creation

2017-10-30 Thread Greg Kroah-Hartman
On Mon, Oct 30, 2017 at 03:57:11PM -0400, Steven Rostedt wrote: > On Tue, 24 Oct 2017 15:07:18 +0200 > Greg Kroah-Hartman wrote: > > > 4.13-stable review patch. If anyone has any objections, please let me know. > > Just that it needs a fix. > > > > > ---

Re: [PATCH] HID: i2c-hid: add reset gpio property

2017-10-30 Thread Brian Norris
On Mon, Oct 30, 2017 at 03:15:19PM -0500, Rob Herring wrote: > On Mon, Oct 30, 2017 at 11:57 AM, Brian Norris > wrote: > > On Mon, Oct 30, 2017 at 10:49:49AM +0800, Lin Huang wrote: > >> --- a/drivers/hid/i2c-hid/i2c-hid.c > >> +++ b/drivers/hid/i2c-hid/i2c-hid.c > >>

Re: [PATCH] HID: i2c-hid: add reset gpio property

2017-10-30 Thread Brian Norris
On Mon, Oct 30, 2017 at 03:15:19PM -0500, Rob Herring wrote: > On Mon, Oct 30, 2017 at 11:57 AM, Brian Norris > wrote: > > On Mon, Oct 30, 2017 at 10:49:49AM +0800, Lin Huang wrote: > >> --- a/drivers/hid/i2c-hid/i2c-hid.c > >> +++ b/drivers/hid/i2c-hid/i2c-hid.c > >> @@ -793,6 +794,34 @@

Re: [PATCH] rcu: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 11:04 AM, Paul E. McKenney wrote: > On Tue, Oct 24, 2017 at 02:32:04AM -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and

Re: [PATCH] rcu: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 11:04 AM, Paul E. McKenney wrote: > On Tue, Oct 24, 2017 at 02:32:04AM -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-30 Thread Sergei Shtylyov
On 10/29/2017 02:00 PM, Geert Uytterhoeven wrote: From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle

Re: [PATCH] ravb: Use common error handling code in ravb_probe()

2017-10-30 Thread Sergei Shtylyov
On 10/29/2017 02:00 PM, Geert Uytterhoeven wrote: From: Markus Elfring Date: Sat, 28 Oct 2017 19:10:08 +0200 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by:

Re: [PATCH] net: tipc: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 2:57 AM, Jon Maloy wrote: > > >> -Original Message- >> From: keesc...@google.com [mailto:keesc...@google.com] On Behalf Of >> Kees Cook >> Sent: Friday, October 27, 2017 06:58 >> To: Jon Maloy >> Cc: David S. Miller

Re: [PATCH] net: tipc: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Mon, Oct 30, 2017 at 2:57 AM, Jon Maloy wrote: > > >> -Original Message- >> From: keesc...@google.com [mailto:keesc...@google.com] On Behalf Of >> Kees Cook >> Sent: Friday, October 27, 2017 06:58 >> To: Jon Maloy >> Cc: David S. Miller ; Ying Xue >> ; net...@vger.kernel.org; tipc- >>

Re: [PATCH v2 1/3] usb: host: remove ehci-msm.c

2017-10-30 Thread Bjorn Andersson
On Thu 26 Oct 08:06 PDT 2017, Alan Stern wrote: > On Thu, 26 Oct 2017, Alex Elder wrote: > > > No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it. > > What about old Qualcomm SoCs? What should they use instead? > These drivers where unfortunately broken by design (host

Re: [PATCH v2 1/3] usb: host: remove ehci-msm.c

2017-10-30 Thread Bjorn Andersson
On Thu 26 Oct 08:06 PDT 2017, Alan Stern wrote: > On Thu, 26 Oct 2017, Alex Elder wrote: > > > No Qualcomm SoC requires the "ehci-msm.c" code any more. So remove it. > > What about old Qualcomm SoCs? What should they use instead? > These drivers where unfortunately broken by design (host

[PATCH v2] net: tipc: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Jon Maloy Cc: Ying Xue Cc: "David S. Miller"

[PATCH v2] net: tipc: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Jon Maloy Cc: Ying Xue Cc: "David S. Miller" Cc: net...@vger.kernel.org Cc:

[PATCH] drivers/net: tundra: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: "David S. Miller" Cc: Philippe Reynes Cc:

[PATCH] drivers/net: tundra: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: "David S. Miller" Cc: Philippe Reynes Cc: "yuval.sh...@oracle.com" Cc: Eric Dumazet Cc:

[PATCH] drivers/net: ntb_netdev: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Jon Mason Cc: Dave Jiang Cc: Allen Hubbe

[PATCH] drivers/net: ntb_netdev: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Jon Mason Cc: Dave Jiang Cc: Allen Hubbe Cc: linux-...@googlegroups.com Cc: net...@vger.kernel.org

[PATCH v2] media: s5p-mfc: fix lockdep warning

2017-10-30 Thread Shuah Khan
The driver mmap functions shouldn't take lock when calling vb2_mmap(). Fix it to not take the lock. The following lockdep warning is fixed with this change. [ 2106.181412] == [ 2106.187563] WARNING: possible circular locking dependency detected

[PATCH v2] media: s5p-mfc: fix lockdep warning

2017-10-30 Thread Shuah Khan
The driver mmap functions shouldn't take lock when calling vb2_mmap(). Fix it to not take the lock. The following lockdep warning is fixed with this change. [ 2106.181412] == [ 2106.187563] WARNING: possible circular locking dependency detected

[PATCH v4 02/37] tracing: Add Documentation for log2 modifier

2017-10-30 Thread Tom Zanussi
Add a line for the log2 modifier, to keep it aligned with tracing/README. Signed-off-by: Tom Zanussi --- Documentation/trace/histogram.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/trace/histogram.txt b/Documentation/trace/histogram.txt

[PATCH v4 02/37] tracing: Add Documentation for log2 modifier

2017-10-30 Thread Tom Zanussi
Add a line for the log2 modifier, to keep it aligned with tracing/README. Signed-off-by: Tom Zanussi --- Documentation/trace/histogram.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/trace/histogram.txt b/Documentation/trace/histogram.txt index b2145f4..a4143f04a 100644

[PATCH v4 04/37] tracing: Remove code which merges duplicates

2017-10-30 Thread Tom Zanussi
From: Vedang Patel We now have the logic to detect and remove duplicates in the tracing_map hash table. The code which merges duplicates in the histogram is redundant now. So, modify this code just to detect duplicates. The duplication detection code is still kept to

[PATCH v4 04/37] tracing: Remove code which merges duplicates

2017-10-30 Thread Tom Zanussi
From: Vedang Patel We now have the logic to detect and remove duplicates in the tracing_map hash table. The code which merges duplicates in the histogram is redundant now. So, modify this code just to detect duplicates. The duplication detection code is still kept to ensure that any rare race

[PATCH v4 03/37] tracing: Add support to detect and avoid duplicates

2017-10-30 Thread Tom Zanussi
From: Vedang Patel A duplicate in the tracing_map hash table is when 2 different entries have the same key and, as a result, the key_hash. This is possible due to a race condition in the algorithm. This race condition is inherent to the algorithm and not a bug. This was

[PATCH v4 03/37] tracing: Add support to detect and avoid duplicates

2017-10-30 Thread Tom Zanussi
From: Vedang Patel A duplicate in the tracing_map hash table is when 2 different entries have the same key and, as a result, the key_hash. This is possible due to a race condition in the algorithm. This race condition is inherent to the algorithm and not a bug. This was fine because, until now,

Re: [lkp-robot] [android/ion] 5fb70554d6: kernel_selftests.android.make_fail

2017-10-30 Thread Laura Abbott
On 10/30/2017 12:12 AM, Pintu Kumar wrote: > On Sun, Oct 29, 2017 at 7:51 PM, kernel test robot > wrote: >> >> FYI, we noticed the following commit (built with gcc-6): >> >> commit: 5fb70554d68e2ea032b6a28b082801d8b7b76cb8 ("android/ion: userspace >> test utility for ion

Re: [lkp-robot] [android/ion] 5fb70554d6: kernel_selftests.android.make_fail

2017-10-30 Thread Laura Abbott
On 10/30/2017 12:12 AM, Pintu Kumar wrote: > On Sun, Oct 29, 2017 at 7:51 PM, kernel test robot > wrote: >> >> FYI, we noticed the following commit (built with gcc-6): >> >> commit: 5fb70554d68e2ea032b6a28b082801d8b7b76cb8 ("android/ion: userspace >> test utility for ion buffer sharing") >> url:

[PATCH v4 17/37] tracing: Move get_hist_field_flags()

2017-10-30 Thread Tom Zanussi
Move get_hist_field_flags() to make it more easily accessible for new code (and keep the move separate from new functionality). Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 44 1 file changed, 22

[PATCH v4 17/37] tracing: Move get_hist_field_flags()

2017-10-30 Thread Tom Zanussi
Move get_hist_field_flags() to make it more easily accessible for new code (and keep the move separate from new functionality). Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_hist.c | 44 1 file changed, 22 insertions(+), 22 deletions(-) diff

<    1   2   3   4   5   6   7   8   9   10   >