Re: [PATCH v2] kbuild: fix linker feature test macros when cross compiling with Clang

2017-10-30 15:50 GMT+09:00 Masahiro Yamada : > 2017-10-29 0:00 GMT+09:00 Masahiro Yamada : >> 2017-10-28 5:13 GMT+09:00 Nick Desaulniers : >>> I was not seeing my linker flags getting added when using ld-option

Re: [PATCH v2] kbuild: fix linker feature test macros when cross compiling with Clang

2017-10-30 15:50 GMT+09:00 Masahiro Yamada : > 2017-10-29 0:00 GMT+09:00 Masahiro Yamada : >> 2017-10-28 5:13 GMT+09:00 Nick Desaulniers : >>> I was not seeing my linker flags getting added when using ld-option when >>> cross compiling with Clang. Upon investigation, this seems to be due to >>> a

[PATCH 1/3] pinctrl: mcp23s08: Improve unlocking of a mutex in mcp23s08_irq()

From: Markus Elfring Date: Mon, 30 Oct 2017 16:03:12 +0100 * Add a jump target so that a call of the function "mutex_unlock" is stored only twice in this function implementation. * Replace five calls by goto statements. * Adjust five condition checks. This

[PATCH 1/3] pinctrl: mcp23s08: Improve unlocking of a mutex in mcp23s08_irq()

From: Markus Elfring Date: Mon, 30 Oct 2017 16:03:12 +0100 * Add a jump target so that a call of the function "mutex_unlock" is stored only twice in this function implementation. * Replace five calls by goto statements. * Adjust five condition checks. This issue was detected by using the

[PATCH 0/3] pinctrl-mcp23s08: Fine-tuning for two function implementations

From: Markus Elfring Date: Mon, 30 Oct 2017 16:40:20 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Improve unlocking of a mutex in mcp23s08_irq() Use common error handling code in

[PATCH 0/3] pinctrl-mcp23s08: Fine-tuning for two function implementations

From: Markus Elfring Date: Mon, 30 Oct 2017 16:40:20 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Improve unlocking of a mutex in mcp23s08_irq() Use common error handling code in mcp23s08_dbg_show() Combine two function calls

Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE

2017-10-10 10:26 GMT+09:00 Richard Kuo : > On Mon, Oct 09, 2017 at 03:11:47PM +0800, Cao jin wrote: >> As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is >> used to add arch-specific options for $(CC). From commandline, >> CFLAGS_MODULE shall be used. >>

Re: [PATCH 3/3] hexagon/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE

2017-10-10 10:26 GMT+09:00 Richard Kuo : > On Mon, Oct 09, 2017 at 03:11:47PM +0800, Cao jin wrote: >> As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is >> used to add arch-specific options for $(CC). From commandline, >> CFLAGS_MODULE shall be used. >> Doesn't have any

Re: [PATCH 2/3] c6x/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE

2017-10-09 16:11 GMT+09:00 Cao jin : > As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is > used to add arch-specific options for $(CC). From commandline, > CFLAGS_MODULE shall be used. > Doesn't have any functional change, but just follow kbuild rules.

Re: [PATCH 2/3] c6x/kbuild: replace CFLAGS_MODULE with KBUILD_CFLAGS_MODULE

2017-10-09 16:11 GMT+09:00 Cao jin : > As kbuild document & commit 6588169d51 says: KBUILD_CFLAGS_MODULE is > used to add arch-specific options for $(CC). From commandline, > CFLAGS_MODULE shall be used. > Doesn't have any functional change, but just follow kbuild rules. > > Signed-off-by: Cao jin

Re: [PATCH 1/3] arm/kbuild: replace {C,LD}FLAGS_MODULE with KBUILD_{C,LD}FLAGS_MODULE

2017-10-09 16:11 GMT+09:00 Cao jin : > As kbuild document & commit 6588169d51 says: KBUILD_{C,LD}FLAGS_MODULE are > used to add arch-specific options for $(CC) and $(LD). From commandline, > {C,LD}FLAGS_MODULE shall be used. > Doesn't have any functional change, but just

Re: [PATCH 1/3] arm/kbuild: replace {C,LD}FLAGS_MODULE with KBUILD_{C,LD}FLAGS_MODULE

2017-10-09 16:11 GMT+09:00 Cao jin : > As kbuild document & commit 6588169d51 says: KBUILD_{C,LD}FLAGS_MODULE are > used to add arch-specific options for $(CC) and $(LD). From commandline, > {C,LD}FLAGS_MODULE shall be used. > Doesn't have any functional change, but just follow kbuild rules. > >

Re: [PATCH RFC 5/5] sched/fair: remove impossible condition from find_idlest_group_cpu

On Sat, Oct 28 2017 at 09:59, Joel Fernandes wrote: > find_idlest_group_cpu goes through CPUs of a group previous selected by > find_idlest_group. find_idlest_group returns NULL if the local group is the > selected one and doesn't execute find_idlest_group_cpu if the group to which > 'cpu'

Re: [PATCH RFC 5/5] sched/fair: remove impossible condition from find_idlest_group_cpu

On Sat, Oct 28 2017 at 09:59, Joel Fernandes wrote: > find_idlest_group_cpu goes through CPUs of a group previous selected by > find_idlest_group. find_idlest_group returns NULL if the local group is the > selected one and doesn't execute find_idlest_group_cpu if the group to which > 'cpu'

Re: [PATCH] ARM: add a private asm/unaligned.h

Hi Ard, On lun., oct. 30 2017, Ard Biesheuvel wrote: > On 30 October 2017 at 15:33, Gregory CLEMENT > wrote: >> Hi Ard, >> >> On lun., oct. 30 2017, Ard Biesheuvel wrote: >> >>> On 30 October 2017 at

Re: [PATCH] ARM: add a private asm/unaligned.h

Hi Ard, On lun., oct. 30 2017, Ard Biesheuvel wrote: > On 30 October 2017 at 15:33, Gregory CLEMENT > wrote: >> Hi Ard, >> >> On lun., oct. 30 2017, Ard Biesheuvel wrote: >> >>> On 30 October 2017 at 15:09, Gregory CLEMENT >>> wrote: Hi Ard, On lun., oct. 30 2017, Ard

Re: [RESEND PATCH v2 1/2] soc: amlogic: add Meson GX VPU Domains driver

Hi Neil, [...] > + > + pm_genpd_init(_hdmi_pd.genpd, _qos_governor, > + meson_gx_pwrc_vpu_get_power(_hdmi_pd)); > + This means that you may initialize the genpd in powered on state. For that scenario, I think you will hit a clock unprepare/disable in-balance issue

Re: [RESEND PATCH v2 1/2] soc: amlogic: add Meson GX VPU Domains driver

Hi Neil, [...] > + > + pm_genpd_init(_hdmi_pd.genpd, _qos_governor, > + meson_gx_pwrc_vpu_get_power(_hdmi_pd)); > + This means that you may initialize the genpd in powered on state. For that scenario, I think you will hit a clock unprepare/disable in-balance issue

[PATCH 4/4] KEYS: Use reduce_timer() to shorten gc timeout

Use reduce_timer() to shorten the garbage collector timeout instead of checking the old timeout and overwriting it without using a lock. This should avoid timeout-updating races causing timeouts to get extended. Signed-off-by: David Howells --- security/keys/gc.c |7

[PATCH 4/4] KEYS: Use reduce_timer() to shorten gc timeout

Use reduce_timer() to shorten the garbage collector timeout instead of checking the old timeout and overwriting it without using a lock. This should avoid timeout-updating races causing timeouts to get extended. Signed-off-by: David Howells --- security/keys/gc.c |7 ++- 1 file

[PATCH 3/4] security: keys: Replace time_t with time64_t for struct key_preparsed_payload

From: Baolin Wang The 'struct key_preparsed_payload' will use 'time_t' which we will try to remove in the kernel, since 'time_t' is not year 2038 safe on 32bits systems. Thus this patch replaces 'time_t' with 'time64_t' which is year 2038 safe on 32 bits system for

[PATCH 3/4] security: keys: Replace time_t with time64_t for struct key_preparsed_payload

From: Baolin Wang The 'struct key_preparsed_payload' will use 'time_t' which we will try to remove in the kernel, since 'time_t' is not year 2038 safe on 32bits systems. Thus this patch replaces 'time_t' with 'time64_t' which is year 2038 safe on 32 bits system for 'struct

[PATCH 2/4] security: keys: Replace time_t/timespec with time64_t

From: Baolin Wang The 'struct key' will use 'time_t' which we try to remove in the kernel, since 'time_t' is not year 2038 safe on 32bit systems. Also the 'struct keyring_search_context' will use 'timespec' type to record current time, which is also not year 2038 safe on

[PATCH 2/4] security: keys: Replace time_t/timespec with time64_t

From: Baolin Wang The 'struct key' will use 'time_t' which we try to remove in the kernel, since 'time_t' is not year 2038 safe on 32bit systems. Also the 'struct keyring_search_context' will use 'timespec' type to record current time, which is also not year 2038 safe on 32bit systems. Thus

[PATCH 0/4] Timer reduction function

Hi Thomas, Here's a set of patches, the first of which introduces a function, reduce_timer(), that starts an inactive timer or reduces the expiry time on it if the desired timeout is less than the current expiry time. This is of immediate use in keyrings, where the gc timer currently sampled

[PATCH 0/4] Timer reduction function

Hi Thomas, Here's a set of patches, the first of which introduces a function, reduce_timer(), that starts an inactive timer or reduces the expiry time on it if the desired timeout is less than the current expiry time. This is of immediate use in keyrings, where the gc timer currently sampled

[PATCH 1/4] Add a function to start/reduce a timer

Add a function, similar to mod_timer(), that will start a timer it isn't running and will modify it if it is running and has an expiry time longer than the new time. If the timer is running with an expiry time that's the same or sooner, no change is made. The function looks like: int

[PATCH 1/4] Add a function to start/reduce a timer

Add a function, similar to mod_timer(), that will start a timer it isn't running and will modify it if it is running and has an expiry time longer than the new time. If the timer is running with an expiry time that's the same or sooner, no change is made. The function looks like: int

Re: [PATCH] ARM: add a private asm/unaligned.h

On 30 October 2017 at 15:33, Gregory CLEMENT wrote: > Hi Ard, > > On lun., oct. 30 2017, Ard Biesheuvel wrote: > >> On 30 October 2017 at 15:09, Gregory CLEMENT >> wrote: >>> Hi Ard, >>> >>> On

Re: [PATCH] ARM: add a private asm/unaligned.h

On 30 October 2017 at 15:33, Gregory CLEMENT wrote: > Hi Ard, > > On lun., oct. 30 2017, Ard Biesheuvel wrote: > >> On 30 October 2017 at 15:09, Gregory CLEMENT >> wrote: >>> Hi Ard, >>> >>> On lun., oct. 30 2017, Ard Biesheuvel wrote: >>> On 30 October 2017 at 15:05, Gregory CLEMENT

Re: Changing FAT label of mounted file system

On Wednesday 06 September 2017 00:35:10 OGAWA Hirofumi wrote: > Pali Rohár writes: > > > Hello! > > Hi, > > > On most file system it is possible to change its label at anytime, when > > mounted or unmounted. But FAT is such special file system on which is > > label

Re: Changing FAT label of mounted file system

On Wednesday 06 September 2017 00:35:10 OGAWA Hirofumi wrote: > Pali Rohár writes: > > > Hello! > > Hi, > > > On most file system it is possible to change its label at anytime, when > > mounted or unmounted. But FAT is such special file system on which is > > label stored in two location,

Re: [PATCH] ARM: add a private asm/unaligned.h

Hi Ard, On lun., oct. 30 2017, Ard Biesheuvel wrote: > On 30 October 2017 at 15:09, Gregory CLEMENT > wrote: >> Hi Ard, >> >> On lun., oct. 30 2017, Ard Biesheuvel wrote: >> >>> On 30 October 2017 at

Re: [PATCH] ARM: add a private asm/unaligned.h

Hi Ard, On lun., oct. 30 2017, Ard Biesheuvel wrote: > On 30 October 2017 at 15:09, Gregory CLEMENT > wrote: >> Hi Ard, >> >> On lun., oct. 30 2017, Ard Biesheuvel wrote: >> >>> On 30 October 2017 at 15:05, Gregory CLEMENT >>> wrote: Hi Ard, On lun., oct. 30 2017, Ard

RE: [PATCH v10 1/9] LIB: Introduce a generic PIO mapping method

Hi Corey Many Thanks for your comments [...] > > #define IO_SPACE_LIMIT 0x > > #endif > > > > +#include > > This whole thing would be a lot simpler if you had: > > #ifdef CONFIG_INDIRECT_PIO > #define inb logic_inb > #define outb logic outb > . > . > #endif /* CONFIG_INDIRECT_PIO */

RE: [PATCH v10 1/9] LIB: Introduce a generic PIO mapping method

Hi Corey Many Thanks for your comments [...] > > #define IO_SPACE_LIMIT 0x > > #endif > > > > +#include > > This whole thing would be a lot simpler if you had: > > #ifdef CONFIG_INDIRECT_PIO > #define inb logic_inb > #define outb logic outb > . > . > #endif /* CONFIG_INDIRECT_PIO */

Re: Linux & FAT32 label

On Monday 16 October 2017 09:28:45 Pali Rohár wrote: > On Monday 16 October 2017 03:12:43 Andreas Bombe wrote: > > The other thing is completely ignoring the boot sector label, which I > > could have as a mode enabled by command line switch or environmental > > variable, or just outright make it

Re: Linux & FAT32 label

On Monday 16 October 2017 09:28:45 Pali Rohár wrote: > On Monday 16 October 2017 03:12:43 Andreas Bombe wrote: > > The other thing is completely ignoring the boot sector label, which I > > could have as a mode enabled by command line switch or environmental > > variable, or just outright make it

Re: [PATCH v2 10/10] arm+arm64: vdso: Add support for CLOCK_BOOTTIME

Hi Mark, On Thu, Oct 12, 2017 at 04:01:45PM -0700, Mark Salyzyn wrote: > Add a case for CLOCK_BOOTTIME as it is popular for measuring > relative time on systems expected to suspend() or hibernate(). > > Signed-off-by: Mark Salyzyn > > v2: rebased and changed from 3/3 to

Re: [PATCH v2 10/10] arm+arm64: vdso: Add support for CLOCK_BOOTTIME

Hi Mark, On Thu, Oct 12, 2017 at 04:01:45PM -0700, Mark Salyzyn wrote: > Add a case for CLOCK_BOOTTIME as it is popular for measuring > relative time on systems expected to suspend() or hibernate(). > > Signed-off-by: Mark Salyzyn > > v2: rebased and changed from 3/3 to 10/10, fortified commit

Re: [PATCH 1/4] reset: make device_reset_optional() really optional

Hi Masahiro, On Sun, 2017-10-29 at 01:50 +0900, Masahiro Yamada wrote: > Commit bb475230b8e5 ("reset: make optional functions really optional") > converted *_get_optional* functions, but device_reset_optional() was > left behind. Convert it in the same way. > > Signed-off-by: Masahiro Yamada

Re: [PATCH 1/4] reset: make device_reset_optional() really optional

Hi Masahiro, On Sun, 2017-10-29 at 01:50 +0900, Masahiro Yamada wrote: > Commit bb475230b8e5 ("reset: make optional functions really optional") > converted *_get_optional* functions, but device_reset_optional() was > left behind. Convert it in the same way. > > Signed-off-by: Masahiro Yamada

Re: WARNING in ata_qc_issue

Hello, On Fri, Oct 27, 2017 at 01:19:01AM -0700, syzbot wrote: > WARNING: CPU: 1 PID: 2909 at drivers/ata/libata-core.c:5391 > ata_qc_issue+0x519/0xea0 drivers/ata/libata-core.c:5390 ... > sg_common_write.isra.17+0xf80/0x1c10 drivers/scsi/sg.c:806 > sg_write+0x7a0/0xc90 drivers/scsi/sg.c:677 >

Re: WARNING in ata_qc_issue

Hello, On Fri, Oct 27, 2017 at 01:19:01AM -0700, syzbot wrote: > WARNING: CPU: 1 PID: 2909 at drivers/ata/libata-core.c:5391 > ata_qc_issue+0x519/0xea0 drivers/ata/libata-core.c:5390 ... > sg_common_write.isra.17+0xf80/0x1c10 drivers/scsi/sg.c:806 > sg_write+0x7a0/0xc90 drivers/scsi/sg.c:677 >

Re: possible deadlock in lru_add_drain_all

On Mon, Oct 30, 2017 at 04:10:09PM +0100, Peter Zijlstra wrote: > I can indeed confirm it's running old code; cpuhp_state is no more. > > However, that splat translates like: > > __cpuhp_setup_state() > #0 cpus_read_lock() > __cpuhp_setup_state_cpuslocked() > #1

Re: possible deadlock in lru_add_drain_all

On Mon, Oct 30, 2017 at 04:10:09PM +0100, Peter Zijlstra wrote: > I can indeed confirm it's running old code; cpuhp_state is no more. > > However, that splat translates like: > > __cpuhp_setup_state() > #0 cpus_read_lock() > __cpuhp_setup_state_cpuslocked() > #1

Re: 答复: [PATCH v5 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

On Tue, Oct 24, 2017 at 11:06 AM, liwei (CM) wrote: > what's your opinion about my explanation and revision method? > I am looking forward to your reply, thanks! Sorry for the delay, I was travelling last week. > 发件人: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] 代表

Re: 答复: [PATCH v5 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

On Tue, Oct 24, 2017 at 11:06 AM, liwei (CM) wrote: > what's your opinion about my explanation and revision method? > I am looking forward to your reply, thanks! Sorry for the delay, I was travelling last week. > 发件人: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] 代表 Arnd Bergmann > On

Re: [PATCH v7 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

On 10/26/2017 04:45 PM, Boris Ostrovsky wrote: > On 10/26/2017 04:16 PM, Stefano Stabellini wrote: >> On Thu, 26 Oct 2017, Boris Ostrovsky wrote: >>> On 10/26/2017 03:11 PM, Stefano Stabellini wrote: Also add pvcalls-front to the Makefile. Signed-off-by: Stefano Stabellini

Re: [PATCH v7 13/13] xen: introduce a Kconfig option to enable the pvcalls frontend

On 10/26/2017 04:45 PM, Boris Ostrovsky wrote: > On 10/26/2017 04:16 PM, Stefano Stabellini wrote: >> On Thu, 26 Oct 2017, Boris Ostrovsky wrote: >>> On 10/26/2017 03:11 PM, Stefano Stabellini wrote: Also add pvcalls-front to the Makefile. Signed-off-by: Stefano Stabellini CC:

Re: [PATCH] ARM: add a private asm/unaligned.h

On 30 October 2017 at 15:09, Gregory CLEMENT wrote: > Hi Ard, > > On lun., oct. 30 2017, Ard Biesheuvel wrote: > >> On 30 October 2017 at 15:05, Gregory CLEMENT >> wrote: >>> Hi Ard, >>> >>> On

Re: [PATCH] ARM: add a private asm/unaligned.h

On 30 October 2017 at 15:09, Gregory CLEMENT wrote: > Hi Ard, > > On lun., oct. 30 2017, Ard Biesheuvel wrote: > >> On 30 October 2017 at 15:05, Gregory CLEMENT >> wrote: >>> Hi Ard, >>> >>> On lun., oct. 30 2017, Ard Biesheuvel wrote: >>> >> ... Could you please share the output

[PATCH] reiserfs: remove unneeded i_version bump

From: Jeff Layton The i_version field in reiserfs is not initialized and is only ever updated here. Nothing ever views it, so just remove it. Signed-off-by: Jeff Layton --- fs/reiserfs/super.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] reiserfs: remove unneeded i_version bump

From: Jeff Layton The i_version field in reiserfs is not initialized and is only ever updated here. Nothing ever views it, so just remove it. Signed-off-by: Jeff Layton --- fs/reiserfs/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c index

[PATCH] orangefs: remove initialization of i_version

From: Jeff Layton ...as it's completely unused. Signed-off-by: Jeff Layton --- fs/orangefs/super.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c index 47f3fb9cbec4..0cf130de41d5 100644 ---

[PATCH] orangefs: remove initialization of i_version

From: Jeff Layton ...as it's completely unused. Signed-off-by: Jeff Layton --- fs/orangefs/super.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/orangefs/super.c b/fs/orangefs/super.c index 47f3fb9cbec4..0cf130de41d5 100644 --- a/fs/orangefs/super.c +++ b/fs/orangefs/super.c @@

Re: [PATCH] Check all .c files for bad kernel-doc comments

On Mon, 30 Oct 2017, Matthew Wilcox wrote: > On Mon, Oct 30, 2017 at 12:40:20PM +0900, Masahiro Yamada wrote: >> 2017-10-28 4:41 GMT+09:00 Matthew Wilcox : >> > Implement a '-none' output mode for kernel-doc which will only output >> > warning messages,

Re: [PATCH] Check all .c files for bad kernel-doc comments

On Mon, 30 Oct 2017, Matthew Wilcox wrote: > On Mon, Oct 30, 2017 at 12:40:20PM +0900, Masahiro Yamada wrote: >> 2017-10-28 4:41 GMT+09:00 Matthew Wilcox : >> > Implement a '-none' output mode for kernel-doc which will only output >> > warning messages, and suppresses the warning message about

[PATCH] nilfs2: remove inode->i_version initialization

From: Jeff Layton It's never used in nilfs2. Signed-off-by: Jeff Layton --- fs/nilfs2/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 4fc018dfcfae..3ce20cd44a20 100644 --- a/fs/nilfs2/super.c +++

[PATCH] nilfs2: remove inode->i_version initialization

From: Jeff Layton It's never used in nilfs2. Signed-off-by: Jeff Layton --- fs/nilfs2/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nilfs2/super.c b/fs/nilfs2/super.c index 4fc018dfcfae..3ce20cd44a20 100644 --- a/fs/nilfs2/super.c +++ b/fs/nilfs2/super.c @@ -160,7 +160,6 @@

[PATCH] jfs: remove increment of i_version counter

From: Jeff Layton JFS does not set SB_I_VERSION and doesn't use the i_version counter internally. Just remove this increment. Signed-off-by: Jeff Layton --- fs/jfs/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/jfs/super.c

[PATCH] jfs: remove increment of i_version counter

From: Jeff Layton JFS does not set SB_I_VERSION and doesn't use the i_version counter internally. Just remove this increment. Signed-off-by: Jeff Layton --- fs/jfs/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/jfs/super.c b/fs/jfs/super.c index 2f14677169c3..2f7b3af5b8b7

[PATCH] hpfs: don't bother with the i_version counter or f_version

From: Jeff Layton HPFS does not set SB_I_VERSION and does not use the i_version counter internally. Signed-off-by: Jeff Layton --- fs/hpfs/dir.c | 1 - fs/hpfs/dnode.c | 2 -- fs/hpfs/super.c | 1 - 3 files changed, 4 deletions(-) diff --git

[PATCH] hpfs: don't bother with the i_version counter or f_version

From: Jeff Layton HPFS does not set SB_I_VERSION and does not use the i_version counter internally. Signed-off-by: Jeff Layton --- fs/hpfs/dir.c | 1 - fs/hpfs/dnode.c | 2 -- fs/hpfs/super.c | 1 - 3 files changed, 4 deletions(-) diff --git a/fs/hpfs/dir.c b/fs/hpfs/dir.c index

Re: [PATCH] Check all .c files for bad kernel-doc comments

Hi Matthew, 2017-10-30 22:40 GMT+09:00 Matthew Wilcox : > On Mon, Oct 30, 2017 at 12:40:20PM +0900, Masahiro Yamada wrote: >> 2017-10-28 4:41 GMT+09:00 Matthew Wilcox : >> > Implement a '-none' output mode for kernel-doc which will only output >> >

Re: [PATCH] Check all .c files for bad kernel-doc comments

Hi Matthew, 2017-10-30 22:40 GMT+09:00 Matthew Wilcox : > On Mon, Oct 30, 2017 at 12:40:20PM +0900, Masahiro Yamada wrote: >> 2017-10-28 4:41 GMT+09:00 Matthew Wilcox : >> > Implement a '-none' output mode for kernel-doc which will only output >> > warning messages, and suppresses the warning

Re: [Part2 PATCH v6 32/38] KVM: SVM: Add support for SEV DEBUG_DECRYPT command

On Mon, Oct 30, 2017 at 08:56:13AM -0500, Brijesh Singh wrote: > I am not able to reproduce the build warning in my setup, what config > option or compiler you are using to  trigger this issue ? gcc7 has gotten smarter. > I am on Fedora with gcc 6.4.x. Logically, the code looks okay. I can > try

Re: [Part2 PATCH v6 32/38] KVM: SVM: Add support for SEV DEBUG_DECRYPT command

On Mon, Oct 30, 2017 at 08:56:13AM -0500, Brijesh Singh wrote: > I am not able to reproduce the build warning in my setup, what config > option or compiler you are using to  trigger this issue ? gcc7 has gotten smarter. > I am on Fedora with gcc 6.4.x. Logically, the code looks okay. I can > try

[PATCH] f2fs: don't bother with inode->i_version

From: Jeff Layton f2fs does not set the SB_I_VERSION flag, so the i_version will never be incremented on write. It was recently changed to increment the i_version on a quota write, which isn't necessary here. Signed-off-by: Jeff Layton ---

[PATCH] f2fs: don't bother with inode->i_version

From: Jeff Layton f2fs does not set the SB_I_VERSION flag, so the i_version will never be incremented on write. It was recently changed to increment the i_version on a quota write, which isn't necessary here. Signed-off-by: Jeff Layton --- fs/f2fs/super.c | 2 -- 1 file changed, 2

Re: possible deadlock in lru_add_drain_all

On Mon, Oct 30, 2017 at 07:09:21PM +0900, Byungchul Park wrote: > On Mon, Oct 30, 2017 at 09:22:03AM +0100, Michal Hocko wrote: > > [Cc Byungchul. The original full report is > > http://lkml.kernel.org/r/089e0825eec8955c1f055c83d...@google.com] > > > > Could you have a look please? This smells

Re: possible deadlock in lru_add_drain_all

On Mon, Oct 30, 2017 at 07:09:21PM +0900, Byungchul Park wrote: > On Mon, Oct 30, 2017 at 09:22:03AM +0100, Michal Hocko wrote: > > [Cc Byungchul. The original full report is > > http://lkml.kernel.org/r/089e0825eec8955c1f055c83d...@google.com] > > > > Could you have a look please? This smells

Re: [PATCH] ARM: add a private asm/unaligned.h

On Fri, Oct 27, 2017 at 5:27 PM, Russell King - ARM Linux wrote: > > There's three things wrong, all of which I have patches to address: > > 1. The decompressor code reading the image data sometimes issues unaligned >reads. Some compilers get this wrong and cause an

Re: [PATCH] ARM: add a private asm/unaligned.h

On Fri, Oct 27, 2017 at 5:27 PM, Russell King - ARM Linux wrote: > > There's three things wrong, all of which I have patches to address: > > 1. The decompressor code reading the image data sometimes issues unaligned >reads. Some compilers get this wrong and cause an abort. Arnds patch >

Re: [PATCH] ARM: add a private asm/unaligned.h

Hi Ard, On lun., oct. 30 2017, Ard Biesheuvel wrote: > On 30 October 2017 at 15:05, Gregory CLEMENT > wrote: >> Hi Ard, >> >> On lun., oct. 30 2017, Ard Biesheuvel wrote: >> > ... >>> >>> Could you

Re: [PATCH] ARM: add a private asm/unaligned.h

Hi Ard, On lun., oct. 30 2017, Ard Biesheuvel wrote: > On 30 October 2017 at 15:05, Gregory CLEMENT > wrote: >> Hi Ard, >> >> On lun., oct. 30 2017, Ard Biesheuvel wrote: >> > ... >>> >>> Could you please share the output of 'readelf -S' for those vmlinux >>> decompressor images? >> >>

[PATCH] ntfs: remove i_version handling

From: Jeff Layton NTFS keeps track of the i_version counter here, seemingly for no reason. It does not set the SB_I_VERSION flag so it'll never be incremented on write, and it doesn't increment it internally for metadata operations. Signed-off-by: Jeff Layton

[PATCH] ntfs: remove i_version handling

From: Jeff Layton NTFS keeps track of the i_version counter here, seemingly for no reason. It does not set the SB_I_VERSION flag so it'll never be incremented on write, and it doesn't increment it internally for metadata operations. Signed-off-by: Jeff Layton --- fs/ntfs/inode.c | 9 -

Re: [PATCH] ARM: add a private asm/unaligned.h

On 30 October 2017 at 15:05, Gregory CLEMENT wrote: > Hi Ard, > > On lun., oct. 30 2017, Ard Biesheuvel wrote: > ... >> >> Could you please share the output of 'readelf -S' for those vmlinux >> decompressor images? > > Here it is: >

Re: [PATCH] ARM: add a private asm/unaligned.h

On 30 October 2017 at 15:05, Gregory CLEMENT wrote: > Hi Ard, > > On lun., oct. 30 2017, Ard Biesheuvel wrote: > ... >> >> Could you please share the output of 'readelf -S' for those vmlinux >> decompressor images? > > Here it is: > > In the meantime I also used an arm-linux-gnueabihf- in case

Re: [PATCH] libata: fix spelling mistake: 'ambigious' -> 'ambiguous'

On Sat, Oct 28, 2017 at 11:51:47PM +0530, Arvind Yadav wrote: > Trivial fix to spelling mistakes in ata_parse_force_one(). > > Signed-off-by: Arvind Yadav Applied to libata/for-4.15. Thanks. -- tejun

Re: [PATCH] libata: fix spelling mistake: 'ambigious' -> 'ambiguous'

On Sat, Oct 28, 2017 at 11:51:47PM +0530, Arvind Yadav wrote: > Trivial fix to spelling mistakes in ata_parse_force_one(). > > Signed-off-by: Arvind Yadav Applied to libata/for-4.15. Thanks. -- tejun

Re: [PATCH] ARM: add a private asm/unaligned.h

Hi Ard, On lun., oct. 30 2017, Ard Biesheuvel wrote: > On 30 October 2017 at 13:48, Gregory CLEMENT > wrote: >> Hi Russell, >> >> On ven., oct. 27 2017, Russell King - ARM Linux >> wrote: >> >>> On Fri,

Re: [PATCH] ARM: add a private asm/unaligned.h

Hi Ard, On lun., oct. 30 2017, Ard Biesheuvel wrote: > On 30 October 2017 at 13:48, Gregory CLEMENT > wrote: >> Hi Russell, >> >> On ven., oct. 27 2017, Russell King - ARM Linux >> wrote: >> >>> On Fri, Oct 27, 2017 at 05:19:55PM +0200, Gregory CLEMENT wrote: Hi Arnd, On

Re: [PATCH] ecryptfs: remove unnecessary i_version bump

On Mon, 2017-10-30 at 11:01 -0400, Jeff Layton wrote: > From: Jeff Layton > > There is no need to bump the i_version counter here, as ecryptfs does > not set the MS_I_VERSION flag, and doesn't use it internally. It also My apologies, I've been sitting on this patch for a

Re: [PATCH] ecryptfs: remove unnecessary i_version bump

On Mon, 2017-10-30 at 11:01 -0400, Jeff Layton wrote: > From: Jeff Layton > > There is no need to bump the i_version counter here, as ecryptfs does > not set the MS_I_VERSION flag, and doesn't use it internally. It also My apologies, I've been sitting on this patch for a while now. That should

Re: [PATCH] fs, cifs: convert tcon_link.tl_count from atomic_t to refcount_t

Elena Reshetova writes: > atomic_t variables are currently used to implement reference > counters with the following properties: > - counter is initialized to 1 using atomic_set() > - a resource is freed upon counter reaching zero > - once counter reaches zero, its

Re: [PATCH] fs, cifs: convert tcon_link.tl_count from atomic_t to refcount_t

Elena Reshetova writes: > atomic_t variables are currently used to implement reference > counters with the following properties: > - counter is initialized to 1 using atomic_set() > - a resource is freed upon counter reaching zero > - once counter reaches zero, its further >increments

[PATCH] ecryptfs: remove unnecessary i_version bump

From: Jeff Layton There is no need to bump the i_version counter here, as ecryptfs does not set the MS_I_VERSION flag, and doesn't use it internally. It also only bumps it when the inode is instantiated, which doesn't make much sense. Signed-off-by: Jeff Layton

[PATCH] ecryptfs: remove unnecessary i_version bump

From: Jeff Layton There is no need to bump the i_version counter here, as ecryptfs does not set the MS_I_VERSION flag, and doesn't use it internally. It also only bumps it when the inode is instantiated, which doesn't make much sense. Signed-off-by: Jeff Layton --- fs/ecryptfs/inode.c | 1 -

Re: [PATCH v2] workqueue: Fix NULL pointer dereference

On Sat, Oct 28, 2017 at 11:07:28AM +0800, Li Bin wrote: > When queue_work() is used in irq (not in task context), there is > a potential case that trigger NULL pointer dereference. > > worker_thread() > |-spin_lock_irq() >

Re: [PATCH v2] workqueue: Fix NULL pointer dereference

On Sat, Oct 28, 2017 at 11:07:28AM +0800, Li Bin wrote: > When queue_work() is used in irq (not in task context), there is > a potential case that trigger NULL pointer dereference. > > worker_thread() > |-spin_lock_irq() >

Re: [PATCH] nlm_shutdown_hosts_net() cleanup

On 2017-10-30 17:49, J. Bruce Fields wrote: > On Mon, Oct 30, 2017 at 04:47:58PM +0300, Vasily Averin wrote: >> nlm_complain_hosts() walk through nlm_server_hosts hlist that should be >> protected by nlm_host_mutex. > > I haven't looked at the NLM locking in ages. Do we know who else might >

Re: [PATCH] nlm_shutdown_hosts_net() cleanup

On 2017-10-30 17:49, J. Bruce Fields wrote: > On Mon, Oct 30, 2017 at 04:47:58PM +0300, Vasily Averin wrote: >> nlm_complain_hosts() walk through nlm_server_hosts hlist that should be >> protected by nlm_host_mutex. > > I haven't looked at the NLM locking in ages. Do we know who else might >

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

On Mon, Oct 30, 2017 at 10:17:27AM -0400, Tyler Baicar wrote: > I'm okay with reverting this Then please send a revert patch along with a cleaned up splat explaining why we're reverting. > and coming up with another solution, but that seems like it could be > masking a problem. Doh, the splat

Re: [ghes_copy_tofrom_phys] BUG: sleeping function called from invalid context at mm/page_alloc.c:4150

On Mon, Oct 30, 2017 at 10:17:27AM -0400, Tyler Baicar wrote: > I'm okay with reverting this Then please send a revert patch along with a cleaned up splat explaining why we're reverting. > and coming up with another solution, but that seems like it could be > masking a problem. Doh, the splat

Re: [PATCH] ARM: add a private asm/unaligned.h

On 30 October 2017 at 13:48, Gregory CLEMENT wrote: > Hi Russell, > > On ven., oct. 27 2017, Russell King - ARM Linux > wrote: > >> On Fri, Oct 27, 2017 at 05:19:55PM +0200, Gregory CLEMENT wrote: >>> Hi Arnd, >>> >>> On ven., oct. 20

Re: [PATCH] ARM: add a private asm/unaligned.h

On 30 October 2017 at 13:48, Gregory CLEMENT wrote: > Hi Russell, > > On ven., oct. 27 2017, Russell King - ARM Linux > wrote: > >> On Fri, Oct 27, 2017 at 05:19:55PM +0200, Gregory CLEMENT wrote: >>> Hi Arnd, >>> >>> On ven., oct. 20 2017, Arnd Bergmann wrote: >>> >>> > The

[PATCH] lockd: fix lockd shutdown race with signal

Commit efda760fe95ea ("lockd: fix lockd shutdown race") is incorrect, it removes grace a) for init_net only b) only on stop of lockd kernel thread If we start nfsd from another net namespace lockd_up_net() calls set_grace_period() that adds lockd_manager into per-netns list. Then we stop nfsd

[PATCH] lockd: fix lockd shutdown race with signal

Commit efda760fe95ea ("lockd: fix lockd shutdown race") is incorrect, it removes grace a) for init_net only b) only on stop of lockd kernel thread If we start nfsd from another net namespace lockd_up_net() calls set_grace_period() that adds lockd_manager into per-netns list. Then we stop nfsd

<    4   5   6   7   8   9   10   11   12   13   >