Re: [PATCH] apparmor: fix off-by-one comparison on MAXMAPPED_SIG

2017-11-08 Thread John Johansen
On 11/08/2017 10:53 AM, Linus Torvalds wrote: > On Wed, Nov 8, 2017 at 8:09 AM, John Johansen > wrote: >> >> Signed-off-by: Colin Ian King >> Signed-off-by: John Johansen > > This sign-off chain is odd. It implies that the patch came from Colin > King, bnut it lacks authorship attribution. > >

Re: [RFC PATCH v2] ftrace: support very early function tracing

2017-11-08 Thread Steven Rostedt
On Wed, 08 Nov 2017 18:44:39 + Abderrahmane Benbachir wrote: > I implemented the ring_buffer_set_clock solution and I have some questions. > > > void __init ftrace_early_fill_ringbuffer(void *data) > { > ... > ring_buffer_set_clock(tr->trace_buffer.buffer, early_trace_clock); >

Re: WARNING in __check_heap_object

2017-11-08 Thread Dmitry Vyukov
On Wed, Nov 8, 2017 at 8:02 PM, Kees Cook wrote: >>> On Tue, Nov 7, 2017 at 10:36 AM, syzbot >>> >>> wrote: Hello, syzkaller hit the following crash on 5a3517e009e979f21977d362212b7729c5165d92 git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master c

Re: [RFC PATCH v2] ftrace: support very early function tracing

2017-11-08 Thread Peter Zijlstra
On Wed, Nov 08, 2017 at 11:07:57AM -0500, Steven Rostedt wrote: > On Wed, 8 Nov 2017 09:10:58 +0100 > Peter Zijlstra wrote: > > > On Tue, Nov 07, 2017 at 09:17:06PM -0500, Steven Rostedt wrote: > > > > +#ifdef CONFIG_X86_TSC > > > > + entry->clock = rdtsc(); > > > > +#else > > > > + e

Re: [3/3] arm64: Add software workaround for Falkor erratum 1041

2017-11-08 Thread Manoj Iyer
On Thu, 2 Nov 2017, Shanker Donthineni wrote: The ARM architecture defines the memory locations that are permitted to be accessed as the result of a speculative instruction fetch from an exception level for which all stages of translation are disabled. Specifically, the core is permitted to spec

Re: [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops

2017-11-08 Thread Vivien Didelot
Hi Joe, Joe Perches writes: > On Wed, 2017-11-08 at 12:19 -0500, Vivien Didelot wrote: >> The DSA switch VLAN ops pass the switchdev_trans structure down to the >> drivers, but no one is using them and they aren't supposed to anyway. > [] >> diff --git a/include/net/dsa.h b/include/net/dsa.h > [

Re: [PATCH] dell-smbios: fix string overflow

2017-11-08 Thread Andy Shevchenko
On Wed, Nov 8, 2017 at 8:30 PM, wrote: >> I recommend using "platform/x86: dell-smbios:" in commit header. While we (maintainers) are fixing this manually, it would be better if contributors will do this themselves :-) >> On 11/08/2017 04:08 AM, Arnd Bergmann wrote: >> > The new sysfs code ove

Re: WARNING in __check_heap_object

2017-11-08 Thread Kees Cook
On Wed, Nov 8, 2017 at 12:23 AM, Dmitry Vyukov wrote: > On Tue, Nov 7, 2017 at 9:35 PM, Kees Cook wrote: >> On Tue, Nov 7, 2017 at 10:36 AM, syzbot >> >> wrote: >>> Hello, >>> >>> syzkaller hit the following crash on >>> 5a3517e009e979f21977d362212b7729c5165d92 >>> git://git.kernel.org/pub/scm/l

Re: [kernel-hardening] Re: [PATCH resend 2/2] userns: control capabilities of some user namespaces

2017-11-08 Thread Christian Brauner
On Wed, Nov 08, 2017 at 03:09:59AM -0800, Mahesh Bandewar (महेश बंडेवार) wrote: > Sorry folks I was traveling and seems like lot happened on this thread. :p > > I will try to response few of these comments selectively - > > > The thing that makes me hesitate with this set is that it is a > > perm

[PATCH] arm64: cpu_errata: Add Kryo to Falkor 1003 errata

2017-11-08 Thread Stephen Boyd
The Kryo CPUs are also affected by the Falkor 1003 errata, so we need to do the same workaround on Kryo CPUs. The MIDR is slightly more complicated here, where the PART number is not always the same when looking at all the bits from 15 to 4. Drop the lower 8 bits and just look at the top 4 to see i

Re: [PATCH v2] s390/virtio: mark headers as BSD licensed

2017-11-08 Thread Christian Borntraeger
On 11/08/2017 07:57 PM, Christian Borntraeger wrote: > So what about the following > > - leave kvm_virtio.h unchanged and we will delete this file via the s390 tree > > - change virtio_ccw.h to BSD license. The content of this file is really > really trivial GPLv2 and BSD dual licence might b

Re: [PATCH 0/3] zfcp: timer_setup() refactoring feature for v4.15-rc1

2017-11-08 Thread Kees Cook
On Wed, Nov 8, 2017 at 6:17 AM, Steffen Maier wrote: > Hi all, > > here is a small series for the timer_setup() refactoring of zfcp. > We target it for the merge window to land in v4.15-rc1. > > Unfortunately, they don't seem to apply to the current state of neither > James' misc branch nor Martin

[PATCH] media: coda: remove definition of CODA_STD_MJPG

2017-11-08 Thread Martin Kepplinger
According to i.MX VPU API Reference Manuals the MJPG video codec is refernced to by number 7, not 3. Also Philipp pointed out that this value is only meant to fill in CMD_ENC_SEQ_COD_STD for encoding, only on i.MX53. It was never written to any register, and even if defined correctly, wouldn't be

Re: [PATCH v2] s390/virtio: mark headers as BSD licensed

2017-11-08 Thread Christian Borntraeger
So what about the following - leave kvm_virtio.h unchanged and we will delete this file via the s390 tree - change virtio_ccw.h to BSD license. The content of this file is really really trivial and it boils down to 2 defines, that can be easily reconstructed by looking at the virtio spec. Not e

Re: [PATCH] apparmor: fix off-by-one comparison on MAXMAPPED_SIG

2017-11-08 Thread Linus Torvalds
On Wed, Nov 8, 2017 at 10:53 AM, Linus Torvalds wrote: > So either the authorship is broken, or the sign-off chain is. Which is it? Ahh, looking around for emails, I see that Colin sent the first version with just one comparison, and you added the second one. So authorship is mixed, I guess. git

Re: [PATCH] fs/xfs: Remove NULL check before kmem_cache_destroy

2017-11-08 Thread Tim Hansen
gt; + kmem_cache_destroy(zone); > } > > extern void *kmem_zone_alloc(kmem_zone_t *, xfs_km_flags_t); > -- > 2.1.4 > This patch was created on linux-next repo, tag next-20171108.

Re: [PATCH] apparmor: fix off-by-one comparison on MAXMAPPED_SIG

2017-11-08 Thread Linus Torvalds
On Wed, Nov 8, 2017 at 8:09 AM, John Johansen wrote: > > Signed-off-by: Colin Ian King > Signed-off-by: John Johansen This sign-off chain is odd. It implies that the patch came from Colin King, bnut it lacks authorship attribution. So who authored this? If it was Colin, there should have been

[PATCH] fs/xfs: Remove NULL check before kmem_cache_destroy

2017-11-08 Thread Tim Hansen
kmem_cache_destroy already checks for null values. Signed-off-by: Tim Hansen --- fs/xfs/kmem.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/xfs/kmem.h b/fs/xfs/kmem.h index 7509019..4b87472 100644 --- a/fs/xfs/kmem.h +++ b/fs/xfs/kmem.h @@ -119,8 +119,7 @@ kmem_zone_f

Re: [PATCH V3 2/2] It makes the code clearer and less error prone.

2017-11-08 Thread Steven Rostedt
On Tue, 15 Aug 2017 09:25:10 +0200 Federico Vaga wrote: > On Monday, August 14, 2017 7:33:41 PM CEST Steven Rostedt wrote: > > On Thu, 3 Aug 2017 00:15:58 +0200 > > Federico Vaga wrote: > > > > Why did you change the subject? The previous patch had a much better > > one: "trace-cmd: Use asprin

Re: [PATCH 0/2] ARM: dts: NSP fixes

2017-11-08 Thread Florian Fainelli
On 11/07/2017 02:28 PM, Florian Fainelli wrote: > Hi all, > > This patch series contains a couple of fixes: > > - disables AHCI on NSP HR boards since that results in a hard hang > - fixes PPI interrupts specifiers Applied to devicetree/fixes. -- Florian

Re: [PATCH v2 06/12] hwrng: bcm2835-rng: Rework interrupt masking

2017-11-08 Thread Stefan Wahren
Hi Florian, > Florian Fainelli hat am 8. November 2017 um 01:44 > geschrieben: > > > The interrupt masking done for Northstart Plus and Northstar (BCM5301X) > is moved from being a function pointer mapped to of_device_id::data into > a proper part of the hwrng::init callback. While at it, we a

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-08 Thread Darrick J. Wong
On Tue, Nov 07, 2017 at 09:26:48PM +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 07, 2017 at 11:28:46AM -0800, Christoph Hellwig wrote: > > On Tue, Nov 07, 2017 at 02:15:26PM -0500, Theodore Ts'o wrote: > > > On Tue, Nov 07, 2017 at 06:46:58PM +, Alan Cox wrote: > > > > > Given that it had no

Re: [RFC PATCH v2] ftrace: support very early function tracing

2017-11-08 Thread Abderrahmane Benbachir
I implemented the ring_buffer_set_clock solution and I have some questions. void __init ftrace_early_fill_ringbuffer(void *data) { ... ring_buffer_set_clock(tr->trace_buffer.buffer, early_trace_clock); preempt_disable_notrace(); for (i = 0; i < vearly_entries_count; i++)

[PATCH 3/3] net: sched: cls_fw: Adjust nine checks for null pointers

2017-11-08 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 8 Nov 2017 19:26:29 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code plac

[PATCH 2/3] net: sched: cls_fw: Improve two size determinations in fw_change()

2017-11-08 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 8 Nov 2017 19:19:10 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detect

[PATCH 1/3] net: sched: cls_fw: Use common error handling code in fw_change()

2017-11-08 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 8 Nov 2017 19:15:08 +0100 Add a jump target so that a bit of exception handling can be better reused in an if branch of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/sched/cls_fw.c | 7 +++ 1

Re: [PATCH 1/1] locking/qspinlock/x86: Avoid test-and-set when PV_DEDICATED is set

2017-11-08 Thread Radim Krčmář
2017-10-31 10:02-0700, Eduardo Valentin: > Hello Radim, > > On Tue, Oct 24, 2017 at 01:18:59PM +0200, Radim Krčmář wrote: > > 2017-10-23 17:44-0700, Eduardo Valentin: > > > Currently, the existing qspinlock implementation will fallback to > > > test-and-set if the hypervisor has not set the PV_UNH

[PATCH v2] sched: fix sched_feat for !SCHED_DEBUG builds

2017-11-08 Thread Patrick Bellasi
When the kernel is compiled with !SCHED_DEBUG support, we expect that all SCHED_FEAT are turned into compile time constants being propagated to support compiler optimizations. Specifically, we expect that code blocks like this: if (sched_feat(FEATURE_NAME) [&& ]) { /* FEATURE CODE */

[PATCH 0/3] net/sched/cls_fw: Fine-tuning for seven function implementations

2017-11-08 Thread SF Markus Elfring
From: Markus Elfring Date: Wed, 8 Nov 2017 19:36:54 +0100 Three update suggestions were taken into account from static source code analysis. Markus Elfring (3): Use common error handling code in fw_change() Improve two size determinations in fw_change() Adjust nine checks for null pointers

[RFC PATCH for 4.15 1/6] membarrier: selftest: Test private expedited cmd

2017-11-08 Thread Mathieu Desnoyers
Test the new MEMBARRIER_CMD_PRIVATE_EXPEDITED and MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED commands. Add checks expecting specific error values on system calls expected to fail. Signed-off-by: Mathieu Desnoyers Acked-by: Shuah Khan Acked-by: Greg Kroah-Hartman CC: Peter Zijlstra CC: Paul E.

[RFC PATCH for 4.15 3/6] membarrier: Document scheduler barrier requirements (v5)

2017-11-08 Thread Mathieu Desnoyers
Document the membarrier requirement on having a full memory barrier in __schedule() after coming from user-space, before storing to rq->curr. It is provided by smp_mb__after_spinlock() in __schedule(). Document that membarrier requires a full barrier on transition from kernel thread to userspace t

Re: [PATCH v2 12/12] hwrng: bcm63xx-rng: Remove since bcm2835-rng takes over

2017-11-08 Thread Eric Anholt
Florian Fainelli writes: > bcm2835-rng is now capable of supporting the BCM63xx hardware, so remove > the driver which duplicates the same functionality. > > Signed-off-by: Florian Fainelli Assuming Stefan's testing says that the .name handling you settled on works, patches 9, 11, 12 are: Revi

[RFC PATCH for 4.15 2/6] membarrier: powerpc: Skip memory barrier in switch_mm() (v6)

2017-11-08 Thread Mathieu Desnoyers
Allow PowerPC to skip the full memory barrier in switch_mm(), and only issue the barrier when scheduling into a task belonging to a process that has registered to use expedited private. Threads targeting the same VM but which belong to different thread groups is a tricky case. It has a few consequ

[RFC PATCH for 4.15 5/6] membarrier: x86: Provide core serializing command

2017-11-08 Thread Mathieu Desnoyers
There are two places where core serialization is needed by membarrier: 1) When returning from the membarrier IPI, 2) After scheduler updates curr to a thread with a different mm, before going back to user-space, since the curr->mm is used by membarrier to check whether it needs to send an IP

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-08 Thread Alexander Duyck
On Wed, Nov 8, 2017 at 9:12 AM, Fengguang Wu wrote: > Hi Linus, > > > On Wed, Nov 08, 2017 at 08:20:38AM -0800, Linus Torvalds wrote: >> >> On Wed, Nov 8, 2017 at 1:48 AM, Fengguang Wu >> wrote: >>> >>> >>> Now I got the faddr2line output. :) >> >> >> Thank you, but this also shows that you then

[RFC PATCH for 4.15 6/6] membarrier: selftest: Test private expedited sync core cmd

2017-11-08 Thread Mathieu Desnoyers
Test the new MEMBARRIER_CMD_PRIVATE_EXPEDITED_SYNC_CORE and MEMBARRIER_CMD_REGISTER_PRIVATE_EXPEDITED_SYNC_CORE commands. Signed-off-by: Mathieu Desnoyers CC: Shuah Khan CC: Greg Kroah-Hartman CC: Peter Zijlstra CC: Paul E. McKenney CC: Boqun Feng CC: Andrew Hunter CC: Maged Michael CC: gr

[RFC PATCH for 4.15 0/6] membarrier updates for 4.15

2017-11-08 Thread Mathieu Desnoyers
Here are the membarrier changes I plan on sending for the 4.15 merge window. This series includes selftests improvements for sys_membarrier, improvement of powerpc handling of the memory barrier required by sys_membarrier in switch_mm(), and adds a new core serializing membarrier, currently only i

[RFC PATCH for 4.15 4/6] membarrier: Provide core serializing command

2017-11-08 Thread Mathieu Desnoyers
Provide core serializing membarrier command to support memory reclaim by JIT. Each architecture needs to explicitly opt into that support by documenting in their architecture code how they provide the core serializing instructions required when returning from the membarrier IPI, and after the sche

RE: [Revised PATCH v2] hv: kvp: Avoid reading past allocated blocks from KVP file

2017-11-08 Thread KY Srinivasan
> -Original Message- > From: Haiyang Zhang > Sent: Wednesday, November 8, 2017 6:22 AM > To: Long Li ; KY Srinivasan ; > Stephen Hemminger ; > de...@linuxdriverproject.org; linux-kernel@vger.kernel.org > Cc: Paul Meyer ; Long Li > > Subject: RE: [Revised PATCH v2] hv: kvp: Avoid reading

Re: [PATCH v2] s390/virtio: mark headers as BSD licensed

2017-11-08 Thread Christian Borntraeger
On 11/08/2017 07:15 PM, Cornelia Huck wrote: > On Wed, 8 Nov 2017 19:12:25 +0100 > Christian Borntraeger wrote: > >> On 11/08/2017 05:59 PM, Michael S. Tsirkin wrote: >>> Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as >>> well. The s390 ones need to be BSD as well. >>

Re: [PATCH v2 08/12] hwrng: bcm2835-rng: Abstract I/O accessors

2017-11-08 Thread Eric Anholt
Florian Fainelli writes: > In preparation for allowing BCM63xx to use this driver, we abstract I/O > accessors such that we can easily change those later on. This may even be a fix on rpi, since i/o from different devices can get reordered and you're using the barrier variants now! Reviewed-by:

Re: [PATCH] sh: migor: Reserve memory block for CEU

2017-11-08 Thread Geert Uytterhoeven
Hi Jacopo, On Wed, Nov 8, 2017 at 7:05 PM, Jacopo Mondi wrote: > A memory region for CEU video buffer has to be reserved during machine > initialization. > > Originally, it was allocated through DMA API helpers and stored in the > second IORESOURCE_MEM entry, to be later remapped by the CEU drive

Re: [PATCH v2 07/12] hwrng: bcm2835-rng: Manage an optional clock

2017-11-08 Thread Eric Anholt
Florian Fainelli writes: > One of the last steps before bcm63xx-rng can be eliminated is to manage > a clock during hwrng::init and hwrng::cleanup, so fetch it in the probe > function, and manage it during these two steps when valid. > > Signed-off-by: Florian Fainelli > --- > drivers/char/hw_r

RE: [PATCH] dell-smbios: fix string overflow

2017-11-08 Thread Mario.Limonciello
> -Original Message- > From: sathyanarayanan kuppuswamy > [mailto:sathyanarayanan.kuppusw...@linux.intel.com] > Sent: Wednesday, November 8, 2017 12:23 PM > To: Arnd Bergmann ; Pali Rohár ; > Limonciello, Mario ; Darren Hart > ; Andy Shevchenko > Cc: Edward O'Callaghan ; Hans de Goede >

Applied "ASoC: Intel: improve SND_SOC_INTEL_MACH dependencies" to the asoc tree

2017-11-08 Thread Mark Brown
The patch ASoC: Intel: improve SND_SOC_INTEL_MACH dependencies has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and

Re: [PATCH v2 06/12] hwrng: bcm2835-rng: Rework interrupt masking

2017-11-08 Thread Eric Anholt
Florian Fainelli writes: > The interrupt masking done for Northstart Plus and Northstar (BCM5301X) > is moved from being a function pointer mapped to of_device_id::data into > a proper part of the hwrng::init callback. While at it, we also make the > of_data be a proper structure indicating the p

Applied "ASoC: Intel: improve DMADEVICES dependency" to the asoc tree

2017-11-08 Thread Mark Brown
The patch ASoC: Intel: improve DMADEVICES dependency has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Li

Re: [PATCH 5/5] driver core: Remove redundant license text

2017-11-08 Thread Luis R. Rodriguez
On Tue, Nov 07, 2017 at 05:30:09PM +0100, Greg Kroah-Hartman wrote: > Now that the SPDX tag is in all driver core files, that identifies the > license in a specific and legally-defined manner. Takashi and Jiri mentioned that the effort to add SPDX tags to files which did not have licensing was dis

[PATCH] tools/power turbostat: mark expected switch fall-through

2017-11-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1354683 Signed-off-by: Gustavo A. R. Silva --- tools/power/x86/turbostat/turbostat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/power/x86/turbostat/t

Re: [PATCH v2 05/12] hwrng: bcm2835-rng: Use device managed helpers

2017-11-08 Thread Eric Anholt
Florian Fainelli writes: > Now that we have moved the RNG disabling into a hwrng::cleanup callback, > we can use the device managed registration operation and remove our > remove callback since it won't do anything necessary. 3-5 are: Reviewed-by: Eric Anholt signature.asc Description: PGP s

Re: [PATCH v2] nvme: compare NQN string with right size

2017-11-08 Thread Christoph Hellwig
Thanks, applied both patches to nvme-4.15.

Re: [PATCH] dell-smbios: fix string overflow

2017-11-08 Thread sathyanarayanan kuppuswamy
Hi, I recommend using "platform/x86: dell-smbios:" in commit header. On 11/08/2017 04:08 AM, Arnd Bergmann wrote: The new sysfs code overwrites two fixed-length character arrays that are each one byte shorter than they need to be, to hold the trailing \0: drivers/platform/x86/dell-smbios.c: In

Re: [PATCH v2 02/12] hwrng: bcm2835-rng: Define a driver private context

2017-11-08 Thread Eric Anholt
Florian Fainelli writes: > Instead of making hwrng::priv host the base register address, define a > driver private context, make it per platform device instance and pass it > down the different functions. > > Signed-off-by: Florian Fainelli > --- > drivers/char/hw_random/bcm2835-rng.c | 55 > +

Re: oops with 4.14-rc8 when opening and closing /dev/watchdog0

2017-11-08 Thread Guenter Roeck
On Wed, Nov 08, 2017 at 02:26:34PM +0100, Rasmus Villemoes wrote: > Running current master (4.14.0-rc8-9-gfbc3edf) I can reproduce the > below quite consistently, though there are some variations in the stack > trace. It happens when I start and stop busybox watchdog on > /dev/watchdog0 a few t

Re: [PATCH v2] s390/virtio: mark headers as BSD licensed

2017-11-08 Thread Cornelia Huck
On Wed, 8 Nov 2017 19:12:25 +0100 Christian Borntraeger wrote: > On 11/08/2017 05:59 PM, Michael S. Tsirkin wrote: > > Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as > > well. The s390 ones need to be BSD as well. > > > > Fixes: e2be04c7f995 ("License cleanup: add SPDX

Re: [PATCH v2] s390/virtio: mark headers as BSD licensed

2017-11-08 Thread Christian Borntraeger
On 11/08/2017 05:59 PM, Michael S. Tsirkin wrote: > Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as > well. The s390 ones need to be BSD as well. > > Fixes: e2be04c7f995 ("License cleanup: add SPDX license identifier to uapi > header files with a license") > Cc: Greg K

Re: [PATCH] isa: Prevent NULL dereference in isa_bus driver callbacks

2017-11-08 Thread Greg Kroah-Hartman
On Wed, Nov 08, 2017 at 09:11:22AM -0800, Linus Torvalds wrote: > On Wed, Nov 8, 2017 at 7:23 AM, William Breathitt Gray > wrote: > > > > This patch fixes a possible NULL pointer dereference if one of the > > isa_driver callbacks to attempted for an unsupported device. This error > > should not oc

Re: [PATCH v2] s390/virtio: mark headers as BSD licensed

2017-11-08 Thread Heiko Carstens
On Wed, Nov 08, 2017 at 06:59:21PM +0200, Michael S. Tsirkin wrote: > Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as > well. The s390 ones need to be BSD as well. > > Fixes: e2be04c7f995 ("License cleanup: add SPDX license identifier to uapi > header files with a licens

Re: [cdrom_check_status] BUG: unable to handle kernel NULL pointer dereference at 000001c0

2017-11-08 Thread Bartlomiej Zolnierkiewicz
On Wednesday, November 08, 2017 05:28:16 PM Bartlomiej Zolnierkiewicz wrote: > Something is very wrong here as pci_request_selected_regions() in > drivers/ide/setup-pci.c:ide_pci_enable() should allocate PCI resources > so the second probe attempt should not happen. Also interface/device > names r

[PATCH v2] iio: core: Mark expected switch fall-through

2017-11-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1397962 Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Fix subject line. drivers/iio/industrialio-core.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-08 Thread Christoph Hellwig
And I swear I wrote the previous mail before I read this announcement: https://fsfe.org/news/2017/news-20171108-01.en.html But the actual practices there are pretty much what I'd expect as a start (plus a list of acceptable licenses), they even use the same identifiers as you are adding

[PATCH] sh: migor: Reserve memory block for CEU

2017-11-08 Thread Jacopo Mondi
A memory region for CEU video buffer has to be reserved during machine initialization. Originally, it was allocated through DMA API helpers and stored in the second IORESOURCE_MEM entry, to be later remapped by the CEU driver with a call to 'dma_declare_coherent_memory()' As Linux does not allow

Re: [vlan_device_event] BUG: unable to handle kernel paging request at 6b6b6ccf

2017-11-08 Thread Linus Torvalds
On Wed, Nov 8, 2017 at 9:12 AM, Fengguang Wu wrote: > > OK. Here is the original faddr2line output: > > $ ~/linux/scripts/faddr2line vmlinux vlan_device_event+0x7f5/0xa40 > vlan_device_event+0x7f5/0xa40: > vlan_device_event at net/8021q/vlan.h:60 Hmm. Yes, that's not what I hoped for. > I notice

Re: [PATCH] io: core: mark expected switch fall-through

2017-11-08 Thread Gustavo A. R. Silva
Quoting Peter Meerwald-Stadler : In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. please fix the subject line, should be iio: core: Mark... Oh yeah. I'll send v2 shortly. Thanks! -- Gustavo A. R. Silva

Re: [PATCH] io: core: mark expected switch fall-through

2017-11-08 Thread Peter Meerwald-Stadler
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. please fix the subject line, should be iio: core: Mark... thx, p. > Addresses-Coverity-ID: 1397962 > Signed-off-by: Gustavo A. R. Silva > --- > drivers/iio/industrialio-core.c |

Re: [PATCH v2 2/3] drivers: hwmon: Add W83773G driver

2017-11-08 Thread Guenter Roeck
On Wed, Nov 08, 2017 at 02:03:34PM +0800, Lei YU wrote: > On Tue, Nov 7, 2017 at 10:33 PM, Guenter Roeck wrote: > > On 11/07/2017 12:27 AM, Lei YU wrote: > >> > >> Nuvoton W83773G is a hardware monitor IC providing one local > >> temperature and two remote temperature sensors. > >> > >> Signed-off

Re: [PATCH v2] mm, shrinker: make shrinker_list lockless

2017-11-08 Thread Greg Thelen
(off list) Shakeel Butt wrote: > In our production, we have observed that the job loader gets stuck for > 10s of seconds while doing mount operation. It turns out that it was > stuck in register_shrinker() and some unrelated job was under memory > pressure and spending time in shrink_slab(). Our

Re: [PATCH 0/2] mmc: renesas_sdhi: clean-up and fix CONFIG stuff for renesas_sdhi

2017-11-08 Thread Wolfram Sang
On Tue, Nov 07, 2017 at 04:57:20PM +0900, Masahiro Yamada wrote: Ulf, Yamada-san: All of Yamada-san's patches look good from a glimpse. However, I am currently swamped with work and will probably need 1-2 weeks for review. I am sorry about that! However, since 4.16 is far away enough, I don't thi

[PATCH] fsl/fman_port: mark expected switch fall-throughs

2017-11-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1397960 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/freescale/fman/fman_port.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/eth

Re: [PATCH V2 2/3] dmaengine: qcom_hidma: add support for the new revision

2017-11-08 Thread Timur Tabi
On 11/08/2017 11:37 AM, Sinan Kaya wrote: I think we are talking styles here. I don't think my suggestions are stylistic. Your version wastes space. However, if you really insist on your approach, that's fine with me. I'm not the maintainer. -- Qualcomm Datacenter Technologies, Inc. as an

Re: [PATCH V2 2/3] dmaengine: qcom_hidma: add support for the new revision

2017-11-08 Thread Robin Murphy
On 08/11/17 16:29, Sinan Kaya wrote: Add support for probing the newer HW and also organize MSI capable hardware into an array for maintenance reasons. Signed-off-by: Sinan Kaya --- drivers/dma/qcom/hidma.c | 41 + 1 file changed, 29 insertions(+), 12

Re: [PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops

2017-11-08 Thread Joe Perches
On Wed, 2017-11-08 at 12:19 -0500, Vivien Didelot wrote: > The DSA switch VLAN ops pass the switchdev_trans structure down to the > drivers, but no one is using them and they aren't supposed to anyway. [] > diff --git a/include/net/dsa.h b/include/net/dsa.h [] > @@ -410,12 +410,10 @@ struct dsa_swi

Re: [Xen-devel] [PATCH] Xen/pciback: Implement PCI slot or bus reset with 'do_flr' SysFS attribute

2017-11-08 Thread Pasi Kärkkäinen
Hi, On Wed, Nov 08, 2017 at 09:44:48AM -0600, Govinda Tatti wrote: > Thanks Jan for your review comments. Please see below for my comments. > > On 11/7/2017 8:40 AM, Jan Beulich wrote: > On 06.11.17 at 18:48, wrote: > >>--- a/Documentation/ABI/testing/sysfs-driver-pciback > >>+++ b/Documenta

Re: [PATCH] locktorture: Fix Oops when reader/writer count is 0

2017-11-08 Thread Paul E. McKenney
On Wed, Nov 08, 2017 at 10:57:07AM -0600, Jeremy Linton wrote: > On 11/08/2017 10:48 AM, Paul E. McKenney wrote: > >On Wed, Nov 08, 2017 at 06:45:23AM -0800, Davidlohr Bueso wrote: > >>On Tue, 07 Nov 2017, Paul E. McKenney wrote: > >> > >>>On Tue, Nov 07, 2017 at 10:07:48PM +0100, Peter Zijlstra wr

[PATCH v2] mm, shrinker: make shrinker_list lockless

2017-11-08 Thread Shakeel Butt
In our production, we have observed that the job loader gets stuck for 10s of seconds while doing mount operation. It turns out that it was stuck in register_shrinker() and some unrelated job was under memory pressure and spending time in shrink_slab(). Our machines have a lot of shrinkers register

Re: [PATCH V2 2/3] dmaengine: qcom_hidma: add support for the new revision

2017-11-08 Thread Sinan Kaya
On 11/8/2017 12:12 PM, Timur Tabi wrote: > On 11/08/2017 10:58 AM, Sinan Kaya wrote: >> Besides, C compiler also won't let me put two arrays together like this. >> >> struct my_struct { >> struct some_struct array1[] >> struct some_struct array2[] >> } > > Why not this: > > const struct o

Re: [PATCHv3 1/1] locking/qspinlock/x86: Avoid test-and-set when PV_DEDICATED is set

2017-11-08 Thread Radim Krčmář
2017-11-06 12:26-0800, Eduardo Valentin: > Currently, the existing qspinlock implementation will fallback to > test-and-set if the hypervisor has not set the PV_UNHALT flag. > > This patch gives the opportunity to guest kernels to select > between test-and-set and the regular queueu fair lock impl

[PATCH] io: core: mark expected switch fall-through

2017-11-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1397962 Signed-off-by: Gustavo A. R. Silva --- drivers/iio/industrialio-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/industrialio-core.c b

Re: [PATCH v2] checkpatch: do not check missing blank line before builtin_*_driver

2017-11-08 Thread Joe Perches
On Wed, 2017-11-08 at 22:32 +0900, Masahiro Yamada wrote: > Hi Joe, Andrew, > > (sorry, Andrew was missing from the list...) > > 2017-09-18 11:01 GMT+09:00 Masahiro Yamada : > > checkpatch.pl does not check missing blank line before module_*_driver. > > I want it to behave likewise for builtin_*_

Re: [PATCH V1 1/1] serial: 8250_fintek: Fix crash with baud rate B0

2017-11-08 Thread Alan Cox
On Wed, 8 Nov 2017 11:05:46 +0800 "Ji-Ze Hong (Peter Hong)" wrote: > The 8250_fintek.c is support the Fintek F81866/F81216 with dynamic clock. > But It'll generate "division by zero" exception and crash in > fintek_8250_set_termios() with baud rate 0 on baudrate_table[i] % baud. 0 means "hang u

Re: [PATCH] staging: fsl-dpaa2: Fix multiple assignments should be avoided

2017-11-08 Thread Joe Perches
On Wed, 2017-11-08 at 09:16 -0800, Randy Dunlap wrote: > On 11/08/2017 03:39 AM, Joe Perches wrote: > > On Wed, 2017-11-08 at 12:40 +0300, Dan Carpenter wrote: > > > On Wed, Nov 08, 2017 at 10:20:48AM +0100, Greg KH wrote: > > > > On Tue, Nov 07, 2017 at 07:45:03PM -0500, Joshua Abraham wrote: > >

Re: [PATCH v2] s390/virtio: mark headers as BSD licensed

2017-11-08 Thread Cornelia Huck
On Wed, 8 Nov 2017 19:01:07 +0200 "Michael S. Tsirkin" wrote: > On Wed, Nov 08, 2017 at 06:59:21PM +0200, Michael S. Tsirkin wrote: > > Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as > > well. The s390 ones need to be BSD as well. > > > > Fixes: e2be04c7f995 ("License

Re: [PATCH] s390/virtio: mark headers as BSD licensed

2017-11-08 Thread Greg Kroah-Hartman
On Wed, Nov 08, 2017 at 06:47:18PM +0200, Michael S. Tsirkin wrote: > Virtio UAPI headers aren't just for UAPI, it's for guests/hypervisors as > well. The s390 ones need to be BSD as well. > > Fixes: e2be04c7f995 ("License cleanup: add SPDX license identifier to uapi > header files with a licens

Re: [PATCH v4 01/17] PCI: dwc: Use the DMA-API to get the MSI address

2017-11-08 Thread Bjorn Helgaas
On Wed, Nov 08, 2017 at 12:45:49PM +, Joao Pinto wrote: > Hello to all, > > Às 12:56 AM de 11/8/2017, Bjorn Helgaas escreveu: > > On Fri, Nov 03, 2017 at 02:47:05PM +0100, Niklas Cassel wrote: > >> Use the DMA-API to get the MSI address. This address will be written to > >> our PCI config spac

Re: [tip:x86/asm] x86/umip: Add emulation code for UMIP instructions

2017-11-08 Thread Alan Cox
On Wed, 8 Nov 2017 17:53:12 +0100 Denys Vlasenko wrote: > On 11/08/2017 05:34 PM, Linus Torvalds wrote: > > On Wed, Nov 8, 2017 at 8:14 AM, Denys Vlasenko wrote: > > > >> > >> Can we avoid maintain emulation of these isns, by asking Wine to remove > >> their use instead? > > > > If we ask

Re: [PATCH] rtc: x-gene: mark PM functions as __maybe_unused

2017-11-08 Thread Loc Ho
Hi, > The new xgene_rtc_alarm_irq_enabled() function is only accessed > from PM code, which is inside of an #ifdef; this causes a harmless > build warning when CONFIG_PM is disabled: > > drivers/rtc/rtc-xgene.c:108:12: error: 'xgene_rtc_alarm_irq_enabled' defined > but not used [-Werror=unused-fu

[PATCH] Fixes issue with bit shift in rf69_get_modulation

2017-11-08 Thread Marcus Wolf
Fixes issue with bit shift in rf69_get_modulation Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index 290b419..c945b4b 100644 --- a/drivers/staging/pi4

Re: [PATCH v7 6/6] x86/tsc: use tsc early

2017-11-08 Thread Pavel Tatashin
Hi Dou, > I have tested it based on tip tree. it is OK for me. Execllent, Thank you very much for spending time testing this project. >> x86_init.timers.timer_init(); >> tsc_init(); >> + tsc_early_fini(); > > > Can we put this into tsc_init(), So we can remove the definiti

[PATCH] net: ethernet: bgmac: mark expected switch fall-through

2017-11-08 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1397972 Signed-off-by: Gustavo A. R. Silva --- drivers/net/ethernet/broadcom/bgmac-platform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethern

Re: [tip:x86/asm] x86/umip: Add emulation code for UMIP instructions

2017-11-08 Thread Denys Vlasenko
On 11/08/2017 06:14 PM, Paolo Bonzini wrote: On 08/11/2017 18:09, Denys Vlasenko wrote: On 11/08/2017 05:57 PM, Linus Torvalds wrote: On Wed, Nov 8, 2017 at 8:53 AM, Denys Vlasenko wrote: We can postpone enabling UMIP by default by a year or so. By this time, new Wine will be on majority of u

Re: [PATCH v7 1/6] x86/tsc: remove tsc_disabled flag

2017-11-08 Thread Pavel Tatashin
> > IMO, we already have a message by > > mark_tsc_unstable("boot parameter notsc"); > > and we will use 'notsc' in case of CONFIG_X86_TSC = no > > So, I guess there is no need to print this msg. > OK, removed the warning.

Re: [PATCH 2/2] kbuild: handle dtb-y and CONFIG_OF_ALL_DTBS natively in Makefile.lib

2017-11-08 Thread Rob Herring
On Sun, Nov 5, 2017 at 7:49 AM, Arnd Bergmann wrote: > On Sun, Nov 5, 2017 at 6:30 AM, Masahiro Yamada > wrote: >> If CONFIG_OF_ALL_DTBS is enabled, "make ARCH=arm64 dtbs" compiles each >> DTB twice; one from arch/arm64/boot/dts/*/Makefile and the other from >> the dtb-$(CONFIG_OF_ALL_DTBS) line

[PATCH net-next 6/6] net: dsa: add switch vlan bitmap functions

2017-11-08 Thread Vivien Didelot
This patch brings no functional changes. It moves out the VLAN code iterating on a list of VLAN members into new dsa_switch_vlan_{prepare,add}_bitmap() functions. This gives us a better isolation of the two switchdev phases. Signed-off-by: Vivien Didelot --- net/dsa/switch.c | 49 ++

[PATCH net-next 2/6] net: dsa: return after mdb prepare phase

2017-11-08 Thread Vivien Didelot
The current code does not return after successfully preparing the MDB addition on every ports member of a multicast group. Fix this. Fixes: a1a6b7ea7f2d ("net: dsa: add cross-chip multicast support") Reported-by: Egil Hjelmeland Signed-off-by: Vivien Didelot --- net/dsa/switch.c | 2 ++ 1 file

[PATCH net-next 4/6] net: dsa: remove trans argument from vlan ops

2017-11-08 Thread Vivien Didelot
The DSA switch VLAN ops pass the switchdev_trans structure down to the drivers, but no one is using them and they aren't supposed to anyway. Remove the trans argument from VLAN prepare and add operations. At the same time, fix the following checkpatch warning: WARNING: line over 80 character

[PATCH v8 5/5] MAINTAINERS: xen, kvm: track pvclock-abi.h changes

2017-11-08 Thread Joao Martins
This file defines an ABI shared between guest and hypervisor(s) (KVM, Xen) and as such there should be an correspondent entry in MAINTAINERS file. Notice that there's already a text notice at the top of the header file, hence this commit simply enforces it more explicitly and have both peers notice

Re: WTF? Re: [PATCH] License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-08 Thread Alan Cox
> By default all files without license information are under the default > license of the kernel, which is GPL version 2. Which is factually incorrect. They are under a licence that is at least as permissive as GPL v2. However they may be under a more permissive licence and as you are not

[PATCH v8 4/5] x86/xen/time: setup vcpu 0 time info page

2017-11-08 Thread Joao Martins
In order to support pvclock vdso on xen we need to setup the time info page for vcpu 0 and register the page with Xen using the VCPUOP_register_vcpu_time_memory_area hypercall. This hypercall will also forcefully update the pvti which will set some of the necessary flags for vdso. Afterwards we che

[PATCH v8 3/5] x86/xen/time: set pvclock flags on xen_time_init()

2017-11-08 Thread Joao Martins
Specifically check for PVCLOCK_TSC_STABLE_BIT and if this bit is set, then set it too on pvclock flags. This allows Xen clocksource to use it and thus speeding up xen_clocksource_read() callers (i.e. sched_clock()) Signed-off-by: Joao Martins Reviewed-by: Boris Ostrovsky --- Changes since v5: *

[PATCH v8 1/5] ptp_kvm: probe for kvm guest availability

2017-11-08 Thread Joao Martins
In the event of moving pvclock_pvti_cpu0_va() definition to common pvclock code, this function would return a value on non KVM guests. Later on this would fail with a GPF on ptp_kvm_init when running on a Xen guest. Therefore, ptp_kvm_init() should check whether it is running in a KVM guest. Signe

<    2   3   4   5   6   7   8   9   10   11   >